News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

SMF 2.0.14 Image Proxy

Started by HDB, May 14, 2017, 09:28:17 PM

Previous topic - Next topic

HDB

First off let me say that I have found the "enable image proxy" check box in the server settings in the general tab in the Admin CP. I have turned it on

I have an https forum and when I turned on the image proxy the threads that have mixed content images that are coming from outside the forum via http sources are not showing.

Some things that might have some bearing on this issue are ...

My shared hosting account does not have a detectable accelerator and I have always gotten this Red message on the Server Caching page in the Admin CP...

SMF has not been able to detect a compatible accelerator on your server.

I have never had the cache for the server set to the recommended "Level 1 Caching" since my host has no detectable accelerator. In an effort to resolve this image proxy issue I turned it on to "Level 1 Caching (Recommended)". That did not help.

In Database and Paths (in Admin CP Server Settings) I have always had a defined path for cache called out home/hd******in/public_html/cache. No changes were ever made here (just info for your consideration).

Also in an effort to solve this I have emptied the forum's cache in the Admin CP Forum Maintenance under Routine tab "Empty the file cache" > Run Task Now. No resolution was seen by doing this.

I have also cleared my browser's cache and it still is an issue.

I also have a WAF and I turned off the cache (which was ON) from my dashboard in the WAF. Still no help. No pictures.

HDB

Additional info...

When I open the missing image in a separate tab I get a parsing error.

https://hd******in.com/proxy.php?request=http%3A%2F%2Fwww.iammoon.com%2Falbums%2FFXDI%2520Inner%2520Primary%2520Bearing%2520R-R%2Fslides%2FIMG_20170401_132645759.jpg&hash=7d465c543a1a55c50bbc13ce109d7714

The error from the above link is...

Parse error: syntax error, unexpected ')', expecting :: (T_PAAMAYIM_NEKUDOTAYIM) in /home/hd******in/public_html/proxy.php on line 173




vbgamer45

HDB what PHP version are you running?
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro


vbgamer45

If possible try to upgrade to 5.6 that should be safe for your site if you are using just SMF.
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

HDB

 It looks like they have pre-selected some PHP modules that would be default. I set it to 5.6 and got a white screen. It is back at 5.4 now and the forum works again. But still mix content images are missing.

vbgamer45

Looks like  a bug change

$response = $request->result();

if (empty(response)) {
return false;
}

To

$response = $request->result();

if (empty($response)) {
return false;
}
Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro


Colin

"If everybody is thinking alike, then somebody is not thinking." - Gen. George S. Patton Jr.

Colin

HDB

Fantastic!!! It works! Thanks vbgamer45!!

And Colin too!!

SleePy

Interesting that this happened.  It never triggered any issue on any of the test sites we have, doesn't throw a undefined constant (as I would expect here) or trigger any syntax error in any version of PHP we tested.  My IDE does see it as a keyword for a method though.  So I wonder if PHP sees it as some keyword and accepts it.

FYI, We are fixing the files here.  Patch is fixed and downloads are in the process of being fixed.  Thanks for the catch.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf

MobileCS

If we uninstall the patch, will the administration section show the download link again?

Colin

Quote from: MobileCS on May 14, 2017, 11:47:13 PM
If we uninstall the patch, will the administration section show the download link again?

Yes or you can just manually download it from the download page.
"If everybody is thinking alike, then somebody is not thinking." - Gen. George S. Patton Jr.

Colin

MobileCS

Thank you. This is the first time I've seen the "Package Manager Updates" link on the left side.

Yariksat

At me at initial loading the broken image is displayed, at repeated loading of page of the normal image.
File from the attachment is working properly?

Illori

please start your own topic for your own issue. this topic belongs to someone else and is marked solved.

Geor'G

Quote from: HDB on May 14, 2017, 09:51:59 PM
Additional info...

When I open the missing image in a separate tab I get a parsing error.

https://hd******in.com/proxy.php?request=http%3A%2F%2Fwww.iammoon.com%2Falbums%2FFXDI%2520Inner%2520Primary%2520Bearing%2520R-R%2Fslides%2FIMG_20170401_132645759.jpg&hash=7d465c543a1a55c50bbc13ce109d7714

The error from the above link is...

Parse error: syntax error, unexpected ')', expecting :: (T_PAAMAYIM_NEKUDOTAYIM) in /home/hd******in/public_html/proxy.php on line 173





PHP 5.6.29
Also this problem.

RU:
Тоже эта проблема.

Quote from: vbgamer45 on May 14, 2017, 11:03:13 PM
Looks like  a bug change

$response = $request->result();

if (empty(response)) {
return false;
}

To

$response = $request->result();

if (empty($response)) {
return false;
}

This has already been fixed.

RU:
Это уже исправлено.


Geor'G

Quote from: Yariksat on May 15, 2017, 07:10:13 AM
This is it ? - https://www.simplemachines.org/community/index.php?topic=553875.0
Tried already.

Working:
[img]http://s16.radikal.ru/i190/1705/cc/b3b75e5c7ecd.jpg[/img]

Does not work:
[url=http://radikal.ru/fp/4o2v4y0kg0tc6][img]http://s16.radikal.ru/i190/1705/cc/b3b75e5c7ecdt.jpg[/img][/url]

Illori

if you believe you have found a bug in SMF please post in the bug reports board instead of here.

Advertisement: