• Welcome to Simple Machines Community Forum. Please login or sign up.
October 17, 2021, 12:26:04 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


[4825] Firefox 8 beta bug

Started by wattie, October 04, 2011, 10:02:17 AM

Previous topic - Next topic

emanuele

* emanuele is tired of seeing the message "Warning - while you were typing a new reply has been posted. You may wish to review your post." :P


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Norv

You mean, *I* was quicker than you this time?

* Norv marks the event. :)
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

emanuele

lol

I got the message three times in a row... :P


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Norv

Haha!
Well, it's an important issue at this time. But please, do state what you meant, lol.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

neugi

hi,

i tried the fix suggested here:
http://dev.simplemachines.org/mantis/view.php?id=4825

but than i get problmes with the images(jpg)

can anybody confirm this?

best

Tomcraft


neugi

found the problem, there ist a space in the filename, and with the space in the filename it is not working. because the " are missing.

if removed the spaces udn replaced them with _ and now it works.

best

reschke

Quote from: neugi on November 13, 2011, 01:56:33 PM
found the problem, there ist a space in the filename, and with the space in the filename it is not working. because the " are missing.

if removed the spaces udn replaced them with _ and now it works.

best

Spaces require escaping as %20 in this format. Note that you can simply send the same format to Chrome, Opera, Firefox, Konqueror, and IE >= 9. No need to special case except for legacy browsers like IE <= 8 and Safari.

neugi

i know ;) but the encoding ist not avalible some files are encoded some not, it has been imported form bb

you are right, the code for opera works fine.

thx

forumite

Torsten,

Could you please explain what the .DS_Store file in that archive does? TIA.

Quote from: TomcraftCan you please try my patch?

reschke

Quote from: forumite on November 14, 2011, 04:13:17 AM
Torsten,

Could you please explain what the .DS_Store file in that archive does? TIA.

Quote from: TomcraftCan you please try my patch?

https://secure.wikimedia.org/wikipedia/en/wiki/.DS_Store [nofollow]

forumite

Thanks. I didn't understand why it would be included in a patch.

reschke

Quote from: forumite on November 14, 2011, 05:05:50 AM
Thanks. I didn't understand why it would be included in a patch.

It's just one of these MacOS annoyances...

Darknico

Quote from: neugi on November 13, 2011, 01:38:43 PM
hi,

i tried the fix suggested here:
http://dev.simplemachines.org/mantis/view.php?id=4825

but than i get problmes with the images(jpg)

can anybody confirm this?

best

This fix work correctly or is in test?
Italian SMF - Supporto Italiano per la board SMF - Ci trovate tutti li!! :)


forumite

Quote from: reschkeIt's just one of these MacOS annoyances...

Ah OK. BTW your patch worked fine - thanks. However, because I didn't know what that file was, I merely copied/pasted your code in a text editor rather than using the Package Manager.

tfs

Quote from: Tomcraft on November 13, 2011, 01:45:50 PM
Can you please try my patch?

Regards, Torsten

It works for files that don't contain spaces in the filename, but is still broken for files with a space in the name.

For instance My_File.txt works

My File.txt downloads as "My"
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

Spuds

November 14, 2011, 01:43:41 PM #56 Last Edit: November 14, 2011, 06:40:27 PM by Spuds
try

if ($context['browser']['is_firefox'])
header('Content-Disposition: ' . $disposition . '; filename*=UTF-8\'\'' . rawurlencode(preg_replace('~&#(\d{3,8});~e', '$fixchar(\'$1\')', $utf8name)));

Tomcraft

Seems to work fine! I modified the patch with the new code.

Regards, Torsten

reschke

Quote from: Tomcraft on November 14, 2011, 01:59:05 PM
Seems to work fine! I modified the patch with the new code.

Regards, Torsten

It's good if this fixes the current and urgent issue. But please, going forward, consider removing as much special-casing as possible, thus send the same header to all of Chrome/Opera/Konqueror/FF and IE>=9.

tfs

Quote from: Tomcraft on November 14, 2011, 01:59:05 PM
Seems to work fine! I modified the patch with the new code.

Regards, Torsten

Now it wants to name the download "My+File.txt" instead of "My File.txt"
A good tree cannot bring forth evil fruit, neither can an evil tree bring forth good fruit.

Advertisement: