• Welcome to Simple Machines Community Forum. Please login or sign up.
December 06, 2021, 01:42:21 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Quick edit not working at all: Firefox + Windows 10

Started by Antechinus, September 04, 2021, 06:55:18 PM

Previous topic - Next topic

shadav

yeah I randomly get the log in screen on the alerts a page fresh usually fixes it
however I use chrome

SleePy

Do you sit on that page for a while?  I.e, long enough that your session times out on the forum?
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf

Aleksi "Lex" Kilpinen

I can actually replicate that login issue 100% of the time by first going to https://simplemachines.org/ and then opening the alerts, and clicking mark read while on that page. 
A Finnish Project Manager (Support Specialist)
 Happily running multiple SMF 2.x installations.
  Fooling around with i7-10700 @ 2,90GHz-4.80GHz / 16Gb / RTX-2070 Super / 3840x2160 / Win 10 x64


How you can help SMF

"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

Diego Andrés

So that's not a cust site issue only, good to know  :laugh:

SMF Tricks - Free & Premium Responsive Themes for SMF.

SleePy

Ahh yea.  Looks like that page isn't responding properly when the request comes from a cors domain.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf

Antechinus

The quick edit is working for me now, at least with Firefox. Firefox is up to v93.0 now, but I don't know if that is relevant.

Have not got around to checking other browsers yet.


SleePy

Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf



SleePy

I just tested in firefox (mac) with a cleared cache, no issue.  No addons running on it.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf


SleePy

Are you receiving any javascript errors by chance?
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf


Antechinus

Console error message:
Uncaught ReferenceError: oQuickModify is not defined
    onclick https://www.simplemachines.org/community/index.php?topic=578824.new#new:1

SleePy

Do you have it in your html source code:
var oQuickModify = new QuickModify
Also type in the console:
window.XMLHttpRequest
Either the code is missing for some reason, or the browser isn't supporting javascript properly to do xhjr.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf

Antechinus

I have this (from another thread where I have just posted):

            <li class="quick_edit" id="modify_button_4102136" onclick="oQuickModify.modifyMsg('4102136', '')">
                <a href="javascript:void(0);">
                    <span class="main_icons quick_edit_button"></span>Quick Edit
                </a>
            </li>

And:
            if ('XMLHttpRequest' in window)
            {
                var oQuickModify = new QuickModify({
                    sScriptUrl: smf_scripturl,
                    sClassName: 'quick_edit',
                    bShowModify: true,
                    iTopicId: 579468,
                    sTemplateBodyEdit: '\n\t\t\t\t\t\t<div id="quick_edit_body_container">\n\t\t\t\t\t\t\t<div id="error_box" class="error"><' + '/div>\n\t\t\t\t\t\t\t<textarea class="editor" name="message" rows="12" tabindex="4">%body%<' + '/textarea><br>\n\t\t\t\t\t\t\t<input type="hidden" name="c93aa3d" value="c7b9857a7a00cae8c7f111fd4213ac77">\n\t\t\t\t\t\t\t<input type="hidden" name="topic" value="579468">\n\t\t\t\t\t\t\t<input type="hidden" name="msg" value="%msg_id%">\n\t\t\t\t\t\t\t<div class="righttext quickModifyMargin">\n\t\t\t\t\t\t\t\t<input type="submit" name="post" value="Save" tabindex="5" onclick="return oQuickModify.modifySave(\'c7b9857a7a00cae8c7f111fd4213ac77\', \'c93aa3d\');" accesskey="s" class="button"> <input type="submit" name="cancel" value="Belay That" tabindex="6" onclick="return oQuickModify.modifyCancel();" class="button">\n\t\t\t\t\t\t\t<' + '/div>\n\t\t\t\t\t\t<' + '/div>',
                    sTemplateSubjectEdit: '<input type="text" name="subject" value="%subject%" size="80" maxlength="80" tabindex="7">',
                    sTemplateBodyNormal: '%body%',
                    sTemplateSubjectNormal: '<a hr'+'ef="' + smf_scripturl + '?topic=579468.msg%msg_id%#msg%msg_id%" rel="nofollow">%subject%<' + '/a>',
                    sTemplateTopSubject: '%subject%',
                    sTemplateReasonEdit: 'Reason for editing: <input type="text" name="modify_reason" value="%modify_reason%" size="80" maxlength="80" tabindex="8" class="quickModifyMargin">',
                    sTemplateReasonNormal: '%modify_text',
                    sErrorBorderStyle: '1px solid red',
                    sFormRemoveAccessKeys: 'postmodify'
                });

Typing that code you suggested into the console yields this result:
Uncaught ReferenceError: oQuickModify is not defined
    onclick https://www.simplemachines.org/community/index.php?topic=579468.msg4102136#msg4102136:1

Kindred

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.<br /><br />"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

SleePy

Typing that code should not mention anything about oQuickModify.  Your browser should respond with something about a function existing.  Chrome responds with:
ƒ XMLHttpRequest() { [native code] }
Right now its like a extension isn't allowing that function to exist, so of course its not working.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:GitHub
Join us on IRC Libera.chat/#smf

Antechinus

Ok, when I get some coffee into me I'll go through disabling extensions, and see if that makes a difference.

I suspect it won't, because when I first reported this I tried it with every browser I have installed, and had the same issue with all of them, and most of them are not running any extensions at all. Still, it's an easy check for Firefox, so worth trying.

Advertisement: