News:

Join the Facebook Fan Page.

Main Menu

Bookmarks

Started by Matthew K., July 16, 2007, 01:07:24 PM

Previous topic - Next topic

Kindred

to put what into the user_info array?  The entire bookmark list?  No way... I have users who have 50+ bookmarks and they update their list more than once a day...
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Chas Large

Can someone help with missing topic icons on themes other than Curve?

I use the ClearSky theme and when I view the My Bookmarks list, any custom topic icons are not shown, see first attachment but if I switch to the Curve theme they are, attachment two.

Obviously there is an issue with the way the mod is installed in that and other custom themes that we're using because these icons ONLY appear in the curve theme.

Any help or advice greatly received. Thanks.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Kindred

well, do the images exist in the custom theme's image directory? :)
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

HunterP

Quote from: Kindred on February 04, 2013, 10:32:50 AM
to put what into the user_info array?  The entire bookmark list?

No, just *if* the user has made any bookmarks.

Kindred

oh...   well then, I'd say don't bother. just read it from the user_settings array as Arantor suggested.
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Arantor

There would be absolutely no point putting it into $user_info, seeing how $user_info gets its information from $user_settings in the first place...


@ Chas: that is simply because you do need to put the images in both themes, not just the default one, as Kindred hinted.
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Chas Large

Quote from: Kindred on February 04, 2013, 11:15:03 AM
well, do the images exist in the custom theme's image directory? :)
I was just about to post that that was the cause. I tried to work out the code and in the end looked at the source code for the page and realised that it was seeking the images in the theme's images/post directory. They were not there.

What made me wonder if it is the mod is that it's the only mod that does/did not pull the images from the default theme.

Anyway, worry not I've fixed it at my end. Cheers.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Matthew K.

Glad you got everything sorted out Chas!

Kindred

cheers Chas.

BTW: AFAIK, **NO** mods pull images from the default directory... they always pull images from each specific theme.
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Arantor

Um, hate to burst your bubble, but I know SimpleDesk used the default directory specifically avoid this sort of issue ;)
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Matthew K.

Yeah, and typically I do the same thing unless there's a good reason to include other theme support for the images.

Chas Large

Quote from: Labradoodle-360 on February 04, 2013, 03:20:04 PM
Glad you got everything sorted out Chas!
Yes thanks. Brill mod and worthy of a prize if there was one. ;)
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Chas Large

Quote from: Kindred on February 04, 2013, 03:31:57 PM
cheers Chas.

BTW: AFAIK, **NO** mods pull images from the default directory... they always pull images from each specific theme.
Odd then that the topic POST icons appear in each theme even if they are not in the images folder for that theme, must mean the theme references the default images directory. Must have gotten confused, not unknown for me ;)

Thanks again for your help.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Kindred

Arantor... that's cause you know what you're doing.

On the other hand, I can see th epoint of installing theme specific files as well (differently colored or designed themes may need a different icon)
I know that aeva installed the BBC image into each and every theme... :)
Слова
Украина

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

dimspace

Quote from: Kindred on February 04, 2013, 04:31:05 PM
I know that aeva installed the BBC image into each and every theme... :)

maybe thats because smf as a general rule, by default puts bbc images into every theme, would be problematic to go against that? (i think)

Personally, install images into other themes drives me up the wall, every new theme you have to remember which modifications icons to copy across. Wish they would all just go to default, which would suit 95% of users. The 5% that want custom images for each theme are probably capable of editing the mod to use the theme image directory instead.

I rejig most mosts at install to use the default directory rather than theme directory unless i specifically want them to.

but anyway, this is well off topic.

the bookmarks mod is excellent, well once i edited it to work with my png post icons :D

Arantor

Quotemaybe thats because smf as a general rule, by default puts bbc images into every theme, would be problematic to go against that? (i think)

If the mod author specifies $themedir in the installation, it will use the default theme and in 2.0 will ask the user about using different themes' folders. Both of these are accessible in most cases to modders, whether they use $settings['images_url'] (current theme's images folder) or $settings['default_theme_url'] . '/images' (default theme folder)

Alternatively one can specify $themes_dir/default in the installer to force it into the default theme.

It's mostly because generations of modders have seen $settings['images_url'] in use (e.g. in themes) and have opted to use that.

Yes, it's off topic but maybe this could be the start of a more beneficial change?
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

dimspace

Quote from: Arantor on February 07, 2013, 01:56:17 PM

It's mostly because generations of modders have seen $settings['images_url'] in use (e.g. in themes) and have opted to use that.

Yes, it's off topic but maybe this could be the start of a more beneficial change?

well logic would say, that it should look in the current themes images folder first and in the abscence of the image then take it from the default theme

or is that too simple

Matthew K.

Which would require some sort of function to load an image, that would need to use file_exists(); on every image of every page load? Might as well throw your server in the toilet.

dimspace

Quote from: Labradoodle-360 on February 07, 2013, 10:17:44 PM
Which would require some sort of function to load an image, that would need to use file_exists(); on every image of every page load? Might as well throw your server in the toilet.

well theres that :D


Arantor

And file_exists results aren't cached by the file system or anything. ;)
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Advertisement: