• Welcome to Simple Machines Community Forum. Please login or sign up.
October 23, 2021, 12:47:26 PM

News:

Wondering if this will always be free?  See why free is better.


Deleted files function for themes

Started by lurkalot, November 09, 2013, 03:48:03 PM

Previous topic - Next topic

lurkalot

Add a theme, you upload and install the theme, no problem.  Then you decide you no longer want that theme and try another, (or you decide to try out a few different themes)  so you click the so called "Remove" link.  Now the remove link only actually un-installs the theme from SMF, but it leaves loads of files sitting on your server.

Can we please have a delete files function in the theme manager, the same as we do in the package manager?

We touched on this a while back, not sure if it was ever considered. http://www.simplemachines.org/community/index.php?topic=473844.0

Suki

I recently did some minor tweaks here and there regarding theme installs and I did thought about handling true removal, if enough people agree on this them I'll add it.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Making tough decisions, so you don't have to.

lurkalot

Quote from: Suki on November 09, 2013, 03:50:52 PM
I recently did some minor tweaks here and there regarding theme installs and I did thought about handling true removal, if enough people agree on this them I'll add it.

Thank you Suki.  I hope some other members chip in then.  Over 230 views but no comments, surely it can't be just me who wants this as a core feature.  :)

Kindred

hmmmm...   this could lead to a lot of trouble.

If you remove a theme (from the SMF admin) you may want to add it back eventually -- or recover some files from that directory -- but remve it from the available themes on the site.

I think that, perhaps, a warning/notice that the remove button does not delete the actual custom theme directory and files might be a more appropriate thing
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Suki

Yep, when I was doing the update/replace feature I did thought about making a copy of said theme and move it somewhere else or just leave it there with a different name something like theme_copy/

Of course we could rename the whole feature, instead of calling it remove we could call it disable/enable and also have a remove option, if the user really wants to remove it.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Making tough decisions, so you don't have to.

Kindred

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Suki

Yeah, just thinking how would be handled, perhaps another variable/value disable/1 or 0 besides renaming its dir.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Making tough decisions, so you don't have to.

Chalky

How about an option in Forum Maintenance to delete selected unused theme files?  That way deletion wouldn't be done by mistake.

Illori

i dont think it would be done by mistake in the first place. i think people should understand what the X does, and there is a popup to agree to deleting the theme.

lurkalot

Quote from: Suki on November 10, 2013, 05:20:12 PM

Of course we could rename the whole feature, instead of calling it remove we could call it disable/enable and also have a remove option, if the user really wants to remove it.

I didn't explain properly in my first post, sorry.   But that is exactly what I wanted.  So it works like the package manager, it has a install / Un-install, and a additional delete files option.

Suki

OK I just finished making some changes to how themes are installed, basically themes will have the same install tag that mods do and it won't be possible to install a 1.1.x or 2.0 theme anymore, it is also possible for themers to use the version tag and if the user install a new version the same theme will be updated and a bunch of other minor things but anyway I'm now working on this.

I'm basically thinking on a new var/value entry, var enable and value either 1 or 0, the theme list will have a disable/enable link along with the current delete link. Disabling just sets the var to 0, deleting remove the theme from both the DB and its dir.

I'm also thinking on adding some more info about each theme and not just the paths and urls so some suggestions are more than welcome.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Making tough decisions, so you don't have to.

Illori

currently in 2.1 the folder for the "stars" has been moved to "Themes/{theme}/images/membericons/"

maybe could be useful to allow that folder to be user defined or per theme defined to where they want it?

Arantor

No good deed goes unpunished
All helpful urges should be circumvented

Illori

well there are some people that may want different badges to match their theme where others may have some that work with all themes.

maybe an option to have it per theme or overall for all themes?

Arantor

I'd be highly surprised if that's the case.
No good deed goes unpunished
All helpful urges should be circumvented

Illori

it may be rare, but i could see someone complaining if the option per theme did not exist.

Arantor

I see more complaints about it being confusing to set up.
No good deed goes unpunished
All helpful urges should be circumvented


Arantor

The thing is I'd rather keep it simple ;)
No good deed goes unpunished
All helpful urges should be circumvented

Kindred

Ilori...
They can already do badges per theme...
Just use the same file name for the "star" file in each theme's images directory
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Advertisement: