• Welcome to Simple Machines Community Forum. Please login or sign up.
December 03, 2021, 06:35:23 PM

News:

Wondering if this will always be free?  See why free is better.


2.0.16 Not able to use basic html in Privacy Policy text

Started by lurkalot, December 30, 2019, 01:47:49 PM

Previous topic - Next topic

lurkalot

Noticed you can't use basic html in the Privacy Policy text/

Also wrapping html bbc [html] [/html] tags doesn't work either.

You can however still use basic html and bbc html tags in the Registration Agreement as expected.


Illori

I was able to use basic html if it is enabled for posts in the privacy policy. well I tested it with a link and that worked.

can you test a normal link?
QuoteThis will allow the posting of some basic HTML tags: •<b>, <u>, <i>, <s>, <em>, <ins>, <del>
•<a href="">
•<img src="" alt="" />
•<br />, <hr />
•<pre>, <blockquote>

I am not sure the html you are testing with is "basic" enough.

lurkalot

Quote from: Illori on December 30, 2019, 01:56:34 PM
I was able to use basic html if it is enabled for posts in the privacy policy. well I tested it with a link and that worked.

can you test a normal link?
QuoteThis will allow the posting of some basic HTML tags: %u2022<b>, <u>, <i>, <s>, <em>, <ins>, <del>
%u2022<a href="">
%u2022<img src="" alt="" />
%u2022<br />, <hr />
%u2022<pre>, <blockquote>

I am not sure the html you are testing with is "basic" enough.

Well maybe, but I can post the same in the Agreement text and that works, so would have thought it would be ok.  Plus part of that code starting at the second header in each document is wrapped in [html] [/html] tags and you can see it's stripped those out.

Doesn't seem right to me.  ;)

shawnb61

Like agreement.txt, the privacy agreement is simple text.  No BBC or html is honored. 

None of it works on my linux or wamp environments, for either agreement.txt or the privacy agreement - as I expected. 

I'm more surprised you see it function sometimes... 

I wonder if different apache settings or browsers are in play?

On my hosted environment, when I tried this, it actually triggered a modsec violation...   ::)
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

lurkalot

Strange. But if that's how it supposed to be, then all's good.  I'm curious as to why it behaves like this on my local though, perhaps as you say a difference in environment. I'm using XAMPP

Forum version: SMF 2.0.16 (more detailed)
Current SMF version: SMF 2.0.16
GD version: bundled (2.1.0 compatible)
Database Server: MariaDB
MySQL version: 10.1.32-MariaDB
PHP: 7.1.17
Server version: Apache/2.4.33 (Win32) OpenSSL/1.0.2o PHP/7.1.17 

This is what's added to both the Agreement and the Policy, exactly the same code in both.  So you can see from the screenshot above what happens.


<h1>A Heading</h1>
<p>A paragraph.</p>
<p>this is another paragraph</p>

[html]
<h1>A Heading</h1>
<p>A paragraph.</p>
<p>this is another paragraph</p>
[/html]

lurkalot

Ok just to add to the above, I now tested this on one of my live test sites and it works exactly the same as on my local.   ???

Illori

I was told
Quote from: Sesquipedalian on December 27, 2019, 03:08:08 AM
Quote
the privacy policy is stored in the database right? is there a limit on number of characters? html support? bbc?

Yes, that's right. The max length of 65535 bytes, which is far more than enough. Basic HTML and BBC are both supported, exactly like the registration agreement.

if what I was told was incorrect then that is fine. otherwise it needs to be fixed.

shawnb61

December 30, 2019, 04:34:36 PM #7 Last Edit: December 30, 2019, 04:51:03 PM by shawnb61
I'll log something just to have & document the discussion.   (#112 logged)

Attached is what I see, in a post, & in the reg agreement.  It's basically what I would have expected.

The reason I think some additional processing is going on for lurkalot somewhere is due to the difference between the top two...
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

lurkalot

Quote from: shawnb61 on December 30, 2019, 04:34:36 PM

The reason I think some additional processing is going on for lurkalot somewhere is due to the difference between the top two...

The thing that bemuses me is, I set up 4 new local installs especially for testing the 2.0.15 to 2.0.16 upgrade process.  They were all fresh clean installs of 2.0.15  Then upgraded to 2.0.16

The only thing any of these local test sites have in common was they all had the GDPR helper mod installed and Uninstalled prior to upgrading to 2.0.16

So it's either SMF,  the GDPR Helper mod,  or something in XAMPP causing the additional processing.  ;)

shawnb61

Quote from: lurkalot on December 30, 2019, 05:26:34 PM
So it's either SMF,  the GDPR Helper mod,  or something in XAMPP causing the additional processing.  ;)

Did you deinstall the GDPR helper?  If not, try that.
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

lurkalot

Quote from: shawnb61 on December 30, 2019, 05:34:17 PM
Quote from: lurkalot on December 30, 2019, 05:26:34 PM
So it's either SMF,  the GDPR Helper mod,  or something in XAMPP causing the additional processing.  ;)

Did you deinstall the GDPR helper?  If not, try that.

Yep, that was what I was testing. 

Quotethey all had the GDPR helper mod installed and Uninstalled prior to upgrading to 2.0.16

shawnb61

Sigh...  Yep.  It's a bug...   ::)   I found the code, and yes, it applies the bbc/html logic for both.  Sorry about that. 

Part of my confusion here is where I'm looking...  I've been looking at the agreement itself, where it's maintained.  bbc & html are not honored there. 

But they *are* honored on the registration page, for both the reg agreement & the policy, upon display.

There are some differences in the processing, which explains the difference in behavior. 
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

lurkalot

Cool, we got there eventually.  lol...   Really glad you were able to narrow it down, hopefully it's not going o be to painful to fix.   Thank you.  ;)

Advertisement: