News:

Wondering if this will always be free?  See why free is better.

Main Menu

& appeares in RSS topics [SMF 2.0.18]

Started by Arskrigitsioniets, November 22, 2021, 10:00:03 AM

Previous topic - Next topic

Arskrigitsioniets

If you have any thread with & in title, this & will appear in RSS of the forum. And because of this symbol, RSS readers give error ...action=.xml;type=atom;sa=recent;limit=5 is invalid XML, likely due to invalid characters. XML error: XML_ERR_NAME_REQUIRED I use SMF 2.0.18.

RSS generator of the SMF should avoid of putting this symbol in RSS feeds.

Aleksi "Lex" Kilpinen

#1
Does not happen here, so we can safely assume this has been fixed in 2.1 - can someone confirm if this is also fixed for 2.0 at this point on GH or do we need an issue logged?

</entry>
<entry>
<title><![CDATA[&amp; appeares in RSS topics]]></title>
<link rel="alternate" type="text/html" href="https://www.simplemachines.org/community/index.php?topic=579665.msg4103161#msg4103161" />
<summary type="html"><![CDATA[If you have any thread with &amp; in title, this &amp; will appear in RSS of the forum. And because of this symbol, RSS readers give error <i>...action=.xml;type=atom;sa=recent;limit=5 is invalid XML, likely due to invalid characters. XML error: XML_ERR_NAME_R...</i>]]></summary>
<category term="Bug Reports" />
<author>
<name>Arskrigitsioniets</name>
<email>*** withdrawn ***</email>
<uri>https://www.simplemachines.org/community/index.php?action=profile;u=594269</uri>
</author>
<published>2021-11-22T15:00:03Z</published>
<updated>2021-11-22T15:00:03Z</updated>
<id>tag:www.simplemachines.org,2021-11-22:msg=4103161</id>
</entry>
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Aleksi "Lex" Kilpinen

This should already be fixed for 2.0, and the fix will be included in the next release.
The package attached here may help you right now https://www.simplemachines.org/community/index.php?msg=4081407

Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arskrigitsioniets

I updated my SMF to 2.0.19. Unfortunatelly, this bug is still not fixed. Can you pleas mark this as unresolved again?

Aleksi "Lex" Kilpinen

As far as I know, the fix was included in .19 - did your update go through without errors?
Is the issue exactly the same?
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arskrigitsioniets

Quote from: Aleksi "Lex" Kilpinen on January 20, 2022, 02:02:14 PMAs far as I know, the fix was included in .19 - did your update go through without errors?
Is the issue exactly the same?
Both yes, I still see this symbol in RSS feed so RSS reader from my WordPress site gives an error.

UPD: It seems that the fix works only with new topics and messages, created after the update - they look like &amp; in RSS instead just &. So, time should solve the problem.

Aleksi "Lex" Kilpinen

Can you check your actual RSS feed, go to your forum with index.php?action=.xml;type=atom;
Then check to see how the title is in the xml - For example this topic on this site shows like this

<title><![CDATA[Re: &amp; appeares in RSS topics [SMF 2.0.18]]]></title>
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arskrigitsioniets

My actual feed contains a reply to a topic created before and a topic created after the update.

Before update:
<title>Workers & Resources: Soviet Republic: отчёт для сообщества №42</title>

AFter update:
<title>Тест тема с &amp;</title>

So it looks like the fix works for new topics, but the older ones still contain unshielded &. So, it means that the fix actually works but some old topics still can break it. It was not so evident so first I thought that fix just didn't work.

Aleksi "Lex" Kilpinen

#8
OK, thanks.
I wonder if it's just a cache, or where that pre-update title comes from then.
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arskrigitsioniets

Quote from: Aleksi "Lex" Kilpinen on January 20, 2022, 11:48:05 PMOK, thanks.
I wonder if it's just a cache, or where that pre-update title comes from then.
No, it isn't a cache.

Aleksi "Lex" Kilpinen

Okay, you seem to be sure of that - So, how did you arrive to that conclusion?
I'm just trying to figure out if there is still something that should have been fixed.
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arskrigitsioniets

Quote from: Aleksi "Lex" Kilpinen on January 21, 2022, 10:32:22 AMOkay, you seem to be sure of that - So, how did you arrive to that conclusion?
I'm just trying to figure out if there is still something that should have been fixed.
If you mean something like browser cache, I cleaned it.

My system is: I show RSS through my WordPress site, there's a function to show an RSS feed right on the sidebar. And during a week I get this from SMF 2.0.19

Quotehttps://forum.strategycon.ru//index.php?action=.xml;type=atom;sa=recent;limit=5 is invalid XML, likely due to invalid characters. XML error: XML_ERR_NAME_REQUIRED at line 67, column 20
Also when I look to RSS feed by myself, I see that unshielded & in old topics.

As far as I know, SMF itself doesn't have such a long cache system affecting RSS. Is there's something like, well, you can tell me how to clean that cache and I'll try.

Aleksi "Lex" Kilpinen

In your routine maintenance options, there's a function to empty out the SMF file cache.
You could try doing that, and seeing if it changes things. I'm not actually sure if it's utilized for RSS at all though.
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arskrigitsioniets

Quote from: Aleksi "Lex" Kilpinen on January 21, 2022, 12:13:59 PMIn your routine maintenance options, there's a function to empty out the SMF file cache.
You could try doing that, and seeing if it changes things. I'm not actually sure if it's utilized for RSS at all though.
I've tried this right now, but it hasn't helped, old topics still have unshielded & in RSS.

Aleksi "Lex" Kilpinen

Thanks, I think I might just install 2.0.18 and see if I can find the time to test this out a bit myself over the weekend.
Slava
Ukraini!


"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Advertisement: