• Welcome to Simple Machines Community Forum. Please login or sign up.
October 28, 2021, 09:24:58 AM

News:

Want to get involved in developing SMF, then why not lend a hand on our github!


Activation link (webmail derefferer Problem) FIX

Started by b.IT, September 10, 2012, 12:15:55 PM

Previous topic - Next topic

b.IT

Some webmail providers break the member activation links by replacing ";" with garbage. This is an annoying problem but there's an easy cure, just replace ";" with "&"

Fix:
in sub-members.php (2x) and register.php (1x)

FIND:

'ACTIVATIONLINK' => $scripturl . '?action=activate;u=' . $memberID . ';code=' . $validation_code,
'ACTIVATIONLINKWITHOUTCODE' => $scripturl . '?action=activate;u=' . $memberID,


REPLACE:

'ACTIVATIONLINK' => $scripturl . '?action=activate&u=' . $memberID . '&code=' . $validation_code,
'ACTIVATIONLINKWITHOUTCODE' => $scripturl . '?action=activate&u=' . $memberID,


Please include this in the next release & keep u the good work
regards,
b.IT

b.IT

September 13, 2012, 04:11:47 AM #1 Last Edit: September 13, 2012, 05:41:11 AM by b.IT
the problem is wider spread, than I initially thought, because all links for emails are consructed this way.

password reset:

Reminder.php

Find
'REMINDLINK' => $scripturl . '?action=reminder;sa=setpassword;u=' . $row['id_member'] . ';code=' . $password,

Replace
'REMINDLINK' => $scripturl . '?action=reminder&sa=setpassword&u=' . $row['id_member'] . '&code=' . $password,

I'll check for more troublesome links

Edit: Board and PM-Notification is also broken, still searching where those links are composed 

emanuele

Hello b.IT and thank you for the report and the possible fix.
Is there any webmail in particular we can check to see the issue in action?


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Robert.

Thanks for the fix, I've encountered this problem a lot of times when registering with a Hotmail adress. :)

@Emanuele: I don't know about others, but I'm having this issue when registering with a Hotmail adress all the time. ;)

emanuele

* emanuele has to find the password for his hotmail address... lol


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Oldiesmann

It's a shame that Hotmail is doing that, as semicolons are indeed valid characters in URLs. They're not commonly used, but they are valid (as are several other characters which aren't commonly used in URLs).
Michael Eshom
Cincy Space - now open!

Arantor

It's long been an issue.

We could possibly fix it more broadly in 2.1 by just splicing loadEmailTemplate to auto replace all ; with &, but longer term (3.0) we'll need to rethink our routing system anyway.
No good deed goes unpunished
All helpful urges should be circumvented

Advertisement: