I have my doubts if this is a "feature" or a bug, let me try to describe what I see:
I tried out a theme, and I did not like it.
When I now go to Admin »Administration Center »Themes and Layout »Theme Settings
and click on REMOVE, then I get
"Are you sure you want to permanently remove this theme?"
If I confirm, I would expect that this theme is not only removed from that list, but also from the server - which does not happen. I just logged onto the server and still see the files of the theme that I just tried to remove.
Is this a known bug?
Let me add that I used 2.0.13 - until today - where this happened.
I have now updated to 2.0.14 and the described behaviour happens again
It's known behaviour, but every time it was taken to the team as a bug, it was always shot down with "what if you want to reinstall it?"
Quote from: Arantor on May 16, 2017, 05:16:51 AM
It's known behaviour, but every time it was taken to the team as a bug, it was always shot down with "what if you want to reinstall it?"
it has been fixed in SMF 2.1, you can disable and remove a theme.
When did THAT get changed? Last I checked, that was the team who argued for several pages about renaming "child board" to "sub-board".
it has been a while, if i recall correctly suki made the change.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FO863VZy.png&hash=71f6ef0026e7941a67c65c965a868a295f03c0b5)
i dont know why you would want to disable the theme instead of delete it but you have the option now.
Quote from: Illori on May 16, 2017, 05:39:51 AMi dont know why you would want to disable the theme instead of delete it but you have the option now.
Because you might not want seasonal or holiday themes available to the members year-round?
Quote from: Steve on May 16, 2017, 08:56:31 AM
Quote from: Illori on May 16, 2017, 05:39:51 AMi dont know why you would want to disable the theme instead of delete it but you have the option now.
Because you might not want seasonal or holiday themes available to the members year-round?
there is still the main theme page that lets you select which themes can be selectable to members
But will disabled themes show up in that list? They shouldn't I would think.
nope they dont show up.
Quote from: Arantor on May 16, 2017, 05:32:24 AM
When did THAT get changed? Last I checked, that was the team who argued for several pages about renaming "child board" to "sub-board".
Might be somewhere around this time, https://www.simplemachines.org/community/index.php?topic=514149.0
I don't remember that at the time - and at that time I was dev team...
Let's not overthink or think it to death: Having the option is fair and fine with me.
All I understood was that I must wait till the release of 2.1 - and just another year has passed now. :-\
Originally, I do think this was intended behavior - it just removed the theme from the list of installed themes, but left the files intact in case you wanted to work on them still.
That is correct. This is FAD
FAD=?
Functions As Designed
Ah!!! :)
Well, let's keep this subject marked as solved then. Thank you.
Quote from: Kindred on May 12, 2018, 05:12:02 PM
That is correct. This is FAD
I'd say it was more of a FID :P
Especially as it's now been "been fixed in SMF 2.1"
What is FID now?
Personally, I don't view the change as a fix. I think it is a dehancement, but I don't feel strongly enough to argue that point when there are other things which need to be put back instead.
Quote from: SMiFFER on May 23, 2018, 08:29:54 AM
FAD is clear to me now.
Quote from: SMiFFER on May 22, 2018, 02:47:27 PM
What is FID now?
Was just me being sarky
FAD = Functions As Designed
FID = Failure In Design.
I apologise for my strange sense of humor.
Quote from: Kindred on May 22, 2018, 11:30:47 PM
Personally, I don't view the change as a fix. I think it is a dehancement,
I'd second that, and add that changing behaviour of an old familiar function like that is not a good idea. Add options, sure - but replace functionality? Why?
Quote from: lurkalot on May 23, 2018, 01:03:52 PM
Quote from: SMiFFER on May 23, 2018, 08:29:54 AM
FAD is clear to me now.
Quote from: SMiFFER on May 22, 2018, 02:47:27 PM
What is FID now?
Was just me being sarky
FAD = Functions As Designed
FID = Failure In Design.
I apologise for my strange sense of humor.
I also do not know what sarky is. Foreign language and slang you know :)
(maybe sarky, but foreign language...)
But I am already used to a weird sense of humor on this forum.
Thank you anyway.
Quote from: Aleksi "Lex" Kilpinen on May 24, 2018, 12:53:12 AM
Quote from: Kindred on May 22, 2018, 11:30:47 PM
Personally, I don't view the change as a fix. I think it is a dehancement,
I'd second that, and add that changing behaviour of an old familiar function like that is not a good idea. Add options, sure - but replace functionality? Why?
I see it from a different angle - more general to SMF.
Functions should do what they claim they would do. No matter of personal tastes and attitudes.
We should more discuss functions and not persons and their personal tastes and animosities.
No wonder the last SMF version is 7 years ago!
If a function CLAIMS it removes something, then it shall DO that. EXACTLY THAT and nothing else. No discussion.
Otherwise we can soon throw SMF into the trashcan, when it always does something completely different just because some years-ago-developer has a special taste about it.
The alternative would be to change the documentation from "remove" to "deactivate" and all would be fine.
But always these hard-to-find and hard-to-explain functions in SMF really drive users off and 7 years since the last full version paired with the standard argument that 2.x is feature-locked and nothing changes for so incredibly long only adds to that.
Just my 2 Eurocents.
Except, it does do what it claims to do, therefore, FAD is indeed FAD. It just doesn't do what you think it should do.... but your logic combined removal with deletion (which may often be the case, but not in smf... deleting a mod does not remove it either. Therefore your logic is incorrect in this case and the "fix"is not a fix, but an illogical change.
As for your snark, it is not called for and not appreciated.
What is "snark" ?
https://www.merriam-webster.com/dictionary/snark
uncalled for attitude
I am not sure I could find any of that, but thank you, mate.