Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: flapjack on March 15, 2010, 08:02:00 PM

Title: [4275]Search not showing up 2nd page
Post by: flapjack on March 15, 2010, 08:02:00 PM
SMF2.0RC3 9736(simplemachines.org)

I was just looking for any info on "Bad Behavior" plugin here, so I put the name in the search up top and clicked the button.
now: there's 4 pages of results, but for some reason I am only able to browse the first one, 2nd-3rd-4th are not showing up

I guess it's because some boards/threads are unavailable for my group, but shouldn't they be excluded from the results? or maybe I'm wrong and there's another explanation
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 15, 2010, 08:27:08 PM
The input is bad behavior, but when it comes back to be able to do a second search, it's now listed as bad+behavior, so what was a space is erroneously url_encode()'d.
Title: Re: Search not showing up 2nd page
Post by: butchs on March 17, 2010, 08:44:02 AM
I am not sure if this is what you mean but we are currently have a public beta in testing of the Bad Behavior anti-spam "plugin" or mod as we call it at SMF Helper (http://community.smfhelper.info/index.php/topic,5121.0.html).

After two weeks of work, I just finished getting it up and limping this week.  I hope???  It is not ready to submittal to SMF so it is being tested there.
::)
Title: Re: Search not showing up 2nd page
Post by: flapjack on March 17, 2010, 01:16:50 PM
I contacted the autor of the BB script and was told that the SMF plugin was already submitted and is in SMF's waiting room :)
andd your resolution seems to be 2.0 specified, when I'm still with 1.1.11
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 17, 2010, 02:19:53 PM
Quote from: butchs on March 17, 2010, 08:44:02 AM
I am not sure if this is what you mean but we are currently have a public beta in testing of the Bad Behavior anti-spam "plugin" or mod as we call it at SMF Helper (http://community.smfhelper.info/index.php/topic,5121.0.html).

After two weeks of work, I just finished getting it up and limping this week.  I hope???  It is not ready to submittal to SMF so it is being tested there.
::)


?? We're discussing a bug here of SMF, not related to Bad Behavior mod...
Title: Re: Search not showing up 2nd page
Post by: butchs on March 17, 2010, 03:27:28 PM
Sorry.
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 27, 2010, 07:04:29 PM
I would like to confirm this is present in RC3 public and here still even in r9824.
Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on March 27, 2010, 11:16:40 PM
This is not happening on my test RC3 forum using a Core-based custom theme, or here when using the Core theme, so it must be something related to the Curve theme.
Title: Re: Search not showing up 2nd page
Post by: flapjack on March 27, 2010, 11:38:06 PM
yes, I can confirm that
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 28, 2010, 07:38:44 PM
Actually using Core here doesn't solve the problem, the pagination links are still broken.
Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on March 28, 2010, 08:15:51 PM
It's working for me.   ???

Title: Re: Search not showing up 2nd page
Post by: Arantor on March 28, 2010, 08:17:25 PM
Didn't work for me when I tried it earlier here.
Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on March 28, 2010, 08:18:15 PM
Maybe it's an on and off thing?  Intermittent, I mean.
Title: Re: Search not showing up 2nd page
Post by: hadesflames on March 29, 2010, 12:57:16 PM
It depends on the search params for me...
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 29, 2010, 02:03:57 PM
It's whether they have a space in or not. Without spaces works fine because the space isn't erroneously re-encoded as a +.

Heck it'd even work fine in Curve without a space.
Title: Re: Search not showing up 2nd page
Post by: flapjack on March 29, 2010, 03:28:17 PM
yes, but the point is it's not working WITH the space :D
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 29, 2010, 03:29:28 PM
/me sighs. I thought we already established that...
Title: Re: Search not showing up 2nd page
Post by: flapjack on March 29, 2010, 03:58:42 PM
I know, just fooling around, sorry for OT
Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on March 29, 2010, 06:28:47 PM
I get something different with 2 search terms (attachment one).

If I take time to make a screen shot, then hit the back button to go back to the original search, I can go to page 2 (attachment 2).

And if I just wait more than the 5 seconds, I can go to page 2.

Title: Re: Search not showing up 2nd page
Post by: Arantor on March 29, 2010, 06:29:54 PM
You're just special. It doesn't work when I try that.
Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on March 29, 2010, 06:34:29 PM
Quote from: Arantor on March 29, 2010, 06:29:54 PM
You're just special.

I know that, but thanks anyway.    ;D

Quote
It doesn't work when I try that.

That's what I'm getting with Core.  My other post (http://www.simplemachines.org/community/index.php?topic=373077.0) was my result with Curve.
Title: Re: Search not showing up 2nd page
Post by: Arantor on March 29, 2010, 06:37:27 PM
I tried it with Core!
Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on March 29, 2010, 06:39:58 PM
Quote from: Arantor on March 29, 2010, 06:37:27 PM
I tried it with Core!

So sorry!  Maybe it is an intermittent thing?

(Darn you, Arantor, you're turning me into a forum spammer now too!  lol.)
Title: Re: Search not showing up 2nd page
Post by: butchs on March 31, 2010, 09:04:29 AM
Hey didn't I complain about the search the other week and was told it was working fine?  My feeling is hurt.   :P

Quote from: AncientDragonfly on March 29, 2010, 06:39:58 PM
Quote from: Arantor on March 29, 2010, 06:37:27 PM
I tried it with Core!

So sorry!  Maybe it is an intermittent thing?

(Darn you, Arantor, you're turning me into a forum spammer now too!  lol.)

Do not make me put yall on the spam list.
Title: Re: Search not showing up 2nd page
Post by: cutelover007 on April 08, 2010, 02:11:00 AM
hmmmmmmmmm...
Title: Re: Search not showing up 2nd page
Post by: Brettflan on April 08, 2010, 09:46:33 PM
There is a related problem with searching for posts by members with a space in their name, as reported here:
http://www.simplemachines.org/community/index.php?topic=375016.msg2573774#msg2573774


A workaround fix for both problems is to replace this line in /Sources/Search.php:
$temp_params = explode('|"|', strtr((!empty($temp_params2) ? $temp_params2 : $temp_params), array(' ' => '+')));
with this:
$temp_params = explode('|"|', (!empty($temp_params2) ? $temp_params2 : $temp_params));

However, I expect there was some reason that character replacement (' ' => '+') was added in the first place, so there could well be repercussions to my workaround. Use it at your own risk, though it seems to work fine for me.
Title: Re: Search not showing up 2nd page
Post by: cutelover007 on April 09, 2010, 04:47:49 AM
wow.,,,you are too genius ...hmmmm and there are also many genius in this website....i am happy to be a member of smf....

Title: Re: Search not showing up 2nd page
Post by: AncientDragonfly on April 10, 2010, 05:00:24 PM
Quote from: Brettflan on April 08, 2010, 09:46:33 PM
There is a related problem with searching for posts by members with a space in their name, as reported here:
http://www.simplemachines.org/community/index.php?topic=375016.msg2573774#msg2573774


A workaround fix for both problems is to replace this line in /Sources/Search.php:
$temp_params = explode('|"|', strtr((!empty($temp_params2) ? $temp_params2 : $temp_params), array(' ' => '+')));
with this:
$temp_params = explode('|"|', (!empty($temp_params2) ? $temp_params2 : $temp_params));

However, I expect there was some reason that character replacement (' ' => '+') was added in the first place, so there could well be repercussions to my workaround. Use it at your own risk, though it seems to work fine for me.

Thank you very much, Brettflan!
Title: Re: [4275]Search not showing up 2nd page
Post by: Norv on April 25, 2010, 02:40:58 AM
Thank you for the report!

Like the other thread, tracked as http://dev.simplemachines.org/mantis/view.php?id=4275
Title: Re: [4275]Search not showing up 2nd page
Post by: gevv on August 08, 2010, 03:41:34 AM
Thanks @Brettflan
Title: Re: [4275]Search not showing up 2nd page
Post by: gevv on August 18, 2010, 01:27:47 AM
Hello

Show new posts on this solution. It could not be part affect?

sample;


or;

Title: Re: [4275]Search not showing up 2nd page
Post by: qwerty2013 on October 01, 2010, 06:36:11 AM
It doesn't work for me!!! :(

Still has one page of search result

Can you help me?
Title: Re: [4275]Search not showing up 2nd page
Post by: Brettflan on October 01, 2010, 08:40:17 AM
Quote from: qwerty2013 on October 01, 2010, 06:36:11 AM
It doesn't work for me!!! :(

Still has one page of search result

Can you help me?

By "one page of search result", do you mean you're only getting one page worth of results shown, or that the links to further pages (2, 3, etc.) don't work correctly? If the latter, did you try my workaround above?


gevv: sorry, I missed your post before now. You're asking if that workaround in Search.php could cause incorrect number of posts showing up using the "unread posts" feature? I don't see how it could based on the nature of the change and the specific location (only in the Search function code); anything's possible, though.
Title: Re: [4275]Search not showing up 2nd page
Post by: qwerty2013 on October 02, 2010, 06:02:08 AM
QuoteBy "one page of search result", do you mean you're only getting one page worth of results shown, or that the links to further pages (2, 3, etc.) don't work correctly? If the latter, did you try my workaround above?

Yes! I'm getting one page worth of results shown... And the links not shown up to further pages (2, 3, etc.)...I dont see them. :-\

Also I did your workaround above!
==========================
I use SMF 2.0 RC3

Please see my screenshot:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2F208.73.51.25%2Fscreen.png&hash=88d89d19e1a161b050ec58d884d91c26d37ca4c3)
Title: Re: [4275]Search not showing up 2nd page
Post by: Brettflan on October 02, 2010, 11:54:18 PM
Quote from: qwerty2013 on October 02, 2010, 06:02:08 AM
Yes! I'm getting one page worth of results shown... And the links not shown up to further pages (2, 3, etc.)...I dont see them. :-\

In that case, you're encountering an entirely different problem if it indeed is a problem. The problem addressed in this topic is to do with the additional page links (2, 3, etc.) being shown but not working due to a problem with space characters (" ") in the search terms being wrongly encoded.