Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Bigguy on February 27, 2018, 07:51:50 PM

Title: iurl
Post by: Bigguy on February 27, 2018, 07:51:50 PM
Why is it that when using the wysiwyg editor in 2.1 and pressing the link button to add a link makes it iurl instead of url. See screen shot, but what I usually do to create a link is take a word like "News", highlight it and then press the link button in the editor and paste my link in there and it's done. I just noticed that the editor makes those link iurl. Which means when the link is click it takes people away from the site. Was this intentional or is there a way to get the editor to open those links with url tags instead of iurl. Just thought I would ask.
Title: Re: iurl
Post by: Shambles on February 28, 2018, 02:44:12 AM
Quote from: Bigguy... the editor makes those link iurl. Which means when the link is click it takes people away from the site ...

I thought [iurl] is meant to keep your clicker onsite?
Title: Re: iurl
Post by: Illori on February 28, 2018, 05:05:59 AM
Quote from: Shambles on February 28, 2018, 02:44:12 AM
Quote from: Bigguy... the editor makes those link iurl. Which means when the link is click it takes people away from the site ...

I thought [iurl] is meant to keep your clicker onsite?

right iurl is for internal URL's or those that you dont want opened in a new tab.

for example
What is repair_settings.php? (http://wiki.simplemachines.org/smf/Repair_settings.php) is made with iurl.

are you using the WYSISYG editor? if so then i think this is a bug. using the button and filling in the URL is making it an iurl vs url bbc. if you dont use WYSISYG editor it puts the link correctly.
Title: Re: iurl
Post by: Bigguy on February 28, 2018, 07:05:01 AM
Yes that's right. If not using the editor all is good. So this is a bug in the editor then, ok. That's all I wanted to know.
Title: Re: iurl
Post by: Illori on February 28, 2018, 07:18:29 AM
this should be reported on github so the devs can fix it.
Title: Re: iurl
Post by: Bigguy on February 28, 2018, 07:25:10 AM
Ok, I'll give it a shot. :)
Title: Re: iurl
Post by: Bigguy on February 28, 2018, 07:29:28 AM
Ok, I posted an issue there with a link back to here. I know they were thinking of updating the editor. I read that in one of the posts on github. Maybe that would take care of this.
Title: Re: iurl
Post by: Gwenwyfar on February 28, 2018, 10:24:01 AM
Thanks for the bug report :)

It helps if you can link the issue here also, so we can track it both ways: https://github.com/SimpleMachines/SMF2.1/issues/4575
Title: Re: iurl
Post by: Bigguy on February 28, 2018, 06:23:42 PM
Ok, sorry about that. Next time I will.
Title: Re: iurl
Post by: Sesquipedalian on February 28, 2018, 11:53:24 PM
Fixed in #4576 (https://github.com/SimpleMachines/SMF2.1/pull/4576).
Title: Re: iurl
Post by: Bigguy on March 01, 2018, 12:42:20 AM
Hey, great to hear. With all these changes bein done, I'm gonna have to upgrade soon. :)