Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: MOCA CPU on January 24, 2015, 06:42:19 PM

Title: News Fader Not Working In Chrome
Post by: MOCA CPU on January 24, 2015, 06:42:19 PM
Hi gang.  Anyone having trouble with the news fader not working in chrome?  Was fine yesterday but nana today. 

On all three of our sites, listed below.  All on version 2.0.9  Fader works fine on firefox and IE

Any suggestions?

http://nswcorvettes.com.au/forum/

http://www.mustang.org.au/forum/

http://www.americanmusclecarsaustralia.com/forum/
Title: Re: News Fader Not Working In Chrome
Post by: Kindred on January 24, 2015, 06:55:08 PM
Well, if it only has that effect in one browser, then it suggests that it is a browser issue, not a site issue...
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on January 24, 2015, 06:58:39 PM
Yes I know that  :)  Was just wandering if anyone has encountered it and have a remedy.

If I have posted this question in the wrong section please move or advise to which section I should post it in.

Many Thanks  :D 
Title: Re: News Fader Not Working In Chrome
Post by: Bruce the Shark on January 24, 2015, 10:02:55 PM
yes i noticed this myself.

I can not say as i just recently yesterday have had some updates myself with my browsers and some through my windows 8.1 operating system as well so i can not compare the difference from what was before and after..

I do know some time ago i needed to enable some plugins through Chrome as i was having some flash issues and needed to set my   chrome://plugins/   but wasn't able this time to establish the cause to your issue.

You may wish to go into Chrome and type this in   chrome://plugins/  into your browser
and make sure all plugins are enable. Try it out and see how it goes but i have my suspicions, that Chrome has JUST RECENTLY disable something for this to have happened.
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on January 24, 2015, 10:13:02 PM
It's chrome all right not windows.  I fired up an old laptop and the ticker worked fine.  Then updated chrome and bingo. I'm sure they do this just to make my life difficult  :P

I'll keep digging but if anyone comes up with a solution please post it.

edit: will do squire  :)
Title: Re: News Fader Not Working In Chrome
Post by: Bruce the Shark on January 24, 2015, 10:36:00 PM
They are not replying back to you because this is a Chrome issue and not a SMF issue thats why no one has yet to answer your question.
There are forums on Google Chrome where you can post your issue there. Not here
Be the very first since this just recently happened.
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on January 24, 2015, 10:41:53 PM
Ahhhh.  Thanks.  :)  I'll go digging
Title: Re: News Fader Not Working In Chrome
Post by: Steve on January 25, 2015, 08:09:12 AM
I'll go ahead and mark this solved even though it isn't really. It just lets the wizards know at a glance that this isn't a support issue they need to look into.

It would be interesting to know what you find out though. :)
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on January 25, 2015, 08:26:51 AM
If I do get to the bottom of it I'll let ya know.  :)
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on January 25, 2015, 09:31:05 AM
I'm not surprised this is broken, I'm only surprised it didn't happen sooner. The code was written before Chrome was even a thing - and now Chrome has decided to go standards compliant.

Needs a rewrite to work in Chrome.
Title: Re: News Fader Not Working In Chrome
Post by: node777 on January 25, 2015, 07:42:19 PM
disable or delete 74 and 85 lines in fader.js
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on January 25, 2015, 07:46:42 PM
That seems like it would break how it's supposed to work.

It really needs a rewrite to use opacity rather than colour matching.
Title: Re: News Fader Not Working In Chrome
Post by: Dragon41673 on January 27, 2015, 10:42:21 AM
I'm having this same issue, and although I agree it's a Chrome issue...Google is most likely not going to resolve the issue, so would this not warranty a patch from SMF to provide this functionality again for us Chrome users?
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on January 27, 2015, 10:45:21 AM
In theory, sure, in practice... maybe not. It's not a simple thing to just tweak.
Title: Re: News Fader Not Working In Chrome
Post by: Dragon41673 on January 27, 2015, 10:47:22 AM
Ah ok...hopefully something can be done. I've checked and the majority of my members use Chrome, then Firefox, then Internet Explorer. There's others they use, but those are the main 3 by a large margin...but the difference between Chrome and anything else is huge. More than Firefox & IE put together.
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on January 27, 2015, 10:51:54 AM
Yes, I realise this. I'm trying to point out how much effort it is for what is considered a minor feature at best - and is disabled by the majority of users as far as we know.
Title: Re: News Fader Not Working In Chrome
Post by: Dragon41673 on January 27, 2015, 11:01:37 AM
Ah, I didn't know most people disable it. I belong to another forum that uses SMF & the news feature, and I find it very helpful. For my own site, I use it to provide a link to advertised specials on my webstore.

Hopefully, someday, it will be resolved...but I for one appreciate everything you guys do. I came from Kunena forums software, and it was a disaster. I almost sided with PHPbb...but their support was lacking when I was asking for help. Every time I came here, help was usually not much longer than a few minutes away, and probably 99% of the issues were resolved almost immediately. This is most definitely the best of the forum software out there...so I thank you for yours, and everyone else's efforts.
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on January 27, 2015, 11:05:37 AM
Well, I will hopefully have some time tonight to sit and look at it properly, maybe I'll figure out a quick way to rewrite it that can later go on to be an SMF patch.
Title: Re: News Fader Not Working In Chrome
Post by: Dragon41673 on January 27, 2015, 11:09:26 AM
Awesome...thank you Arantor!
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on January 27, 2015, 05:14:10 PM
Ditto  :)
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on January 27, 2015, 07:22:32 PM
OK, so here's what I came up with. Tested in current Chrome, Firefox, MS IE and just for fun in Opera 12. I assume it works in current Opera too.

I'm surprised, I genuinely thought it had no opacity support, but it was like 4 years ago when I last looked at this and replaced it what seemed like a dozen lines of jQuery. Anyway. Changes to scripts/fader.js.

Code (find) Select
// Try to find the fore- and background colors.
if ('currentStyle' in this.oFaderHandle)


Code (replace) Select
// Try to find the fore- and background colors.
var modern_browser = 'MozOpacity' in this.oFaderHandle.style || 'Opacity' in this.oFaderHandle.style || 'filter' in this.oFaderHandle.style;
if ('currentStyle' in this.oFaderHandle && !modern_browser)


Code (find) Select
else if (!('opera' in window) && 'defaultView' in document)

Code (replace) Select
else if (!('opera' in window) && 'defaultView' in document && !modern_browser)

All this says is: if the browser supports opacity, we'll use that later, otherwise fetch the colour because we will need that.
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on January 28, 2015, 02:28:35 AM
Cool :)  Ill see if mere novice here can implement that  :P

Many Thanks
Title: Re: News Fader Not Working In Chrome
Post by: Sea Mac on February 22, 2015, 05:18:59 PM
Quote from: Arantor on January 27, 2015, 10:51:54 AM
Yes, I realize this. I'm trying to point out how much effort it is for what is considered a minor feature at best - and is disabled by the majority of users as far as we know.
Well, I WAS using the news fader on all 3 of my sites - until a couple of days ago when I glimpsed how Chrome puts all hundred some odd news items at the top of the site - and I was forced to switch it OFF.

Just one more reason I won't use Chrome ... but I can not control what browser my visitors use!

Too bad it is broken ... I had use for it!
Title: Re: News Fader Not Working In Chrome
Post by: Dragon41673 on February 22, 2015, 05:40:01 PM
I apologize, I could have sworn I posted here.

Arantor...your fix worked perfectly! Thank you very much for your help!
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on February 22, 2015, 06:13:34 PM
Quote from: Sea Mac on February 22, 2015, 05:18:59 PM
Quote from: Arantor on January 27, 2015, 10:51:54 AM
Yes, I realize this. I'm trying to point out how much effort it is for what is considered a minor feature at best - and is disabled by the majority of users as far as we know.
Well, I WAS using the news fader on all 3 of my sites - until a couple of days ago when I glimpsed how Chrome puts all hundred some odd news items at the top of the site - and I was forced to switch it OFF.

Just one more reason I won't use Chrome ... but I can not control what browser my visitors use!

Too bad it is broken ... I had use for it!


Too bad you didn't look up and see how to fix it, too.
Title: Re: News Fader Not Working In Chrome
Post by: Sea Mac on February 22, 2015, 06:34:12 PM
I will try changing all that code for those 3 forums ... it is that important to me ...

Thank you! 
Title: Re: News Fader Not Working In Chrome
Post by: Sea Mac on February 22, 2015, 06:50:36 PM
Success!

I'll copy the one I modified to the other two forums ... Thank you again.

The attached .js is the one I'm using now. Simply replace the file found at ~/Themes/default/scripts/ with this one.
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on February 23, 2015, 12:42:28 AM
I hope you have no mods that edited this file, or indeed that it was from a 2.0.9 forum since patches  have touched this file.
Title: Re: News Fader Not Working In Chrome
Post by: Sea Mac on February 23, 2015, 12:52:58 AM
I got this from the default Theme in my SMF 2.0.9 Installation. The MODs in use by that forum are

OS & Browser Detection 1.5
Simple Audio Video Embedder     3.1
SCEditor4Smf     0.5.1
and  httpBL     2.5.1

Do any of those MODs alter the fader.js?
Title: Re: News Fader Not Working In Chrome
Post by: Arantor on February 23, 2015, 12:54:11 AM
I don't know, don't think they do, but you never know.

More of a case that I don't really have the time to go investigate properly.
Title: Re: News Fader Not Working In Chrome
Post by: Sea Mac on February 23, 2015, 01:03:18 AM
At least one of those javascripts had a tilde ~ at the end of its name ... if I remember correctly one of the FTP settings was to 'make a backup of changed files' by marking the depreciated original with a tilde ...

I checked ... there was no fader.js~ file in there so I feel that no MOD got to it ... it is likely that no MOD did touch it or I'd have a backup with a tilde after it. (The 'editor.js' was MODded on October 14th last year - no other .js file has a tilde after it.)
Title: Re: News Fader Not Working In Chrome
Post by: Steve on February 23, 2015, 09:55:50 AM
Those are smf generated backup/temp files.
Title: Re: News Fader Not Working In Chrome
Post by: Miker1029 on March 31, 2015, 02:26:18 PM
Hey All,

Googled this issue and Ended up Here...

I have the Same Problem, In FireFox News Fader works great, In Chrome & I.E. It shows on the bottom of the News window....

And Maybe this might be Pertinent, And I find Is strange, I've been adding social Media, And Buttons and Such....

In Firefox (Latest), Only Login/Register Button that Shows Is Google+ Log-In, (I Have Google+, Twitter, Facebook), In the Forums, G+1 Button Doesn't show, But Twitter Does....

In Chrome All Log-In Buttons show, and All G+1, And Twitter Buttons Show, And Yes, Compared, I'd live with the News Fade not working...

BUT, To me, It's a Programming thing with SMF, BTW I'm On 2.0.9, If Chrome Is Running and Showing Everything as it should, the the News fade is the problem....

In Firefox, Buttons don't show, And Etc, Etc, Haven't tried I.E. To see if the Twit & +1 Buttons are there (Hate I.E.)....

But as I said, If the Only thing wrong with Chrome getting it right, Must be a Programming Issue... And Fixable??

Yes?

Just My 2 Cents....

Mike

EDIT:

Okay Came to the end of this post and seen there might be a Fix I'll try and report back...  Sorry for the Rash Post....
Title: Re: News Fader Not Working In Chrome
Post by: Kindred on March 31, 2015, 02:30:01 PM
Maybe... Or maybe it's just another case of a browser programming being completely stupid and breaking functionality because they were not careful enough with updates but now they expect everyone to cater to their changes
Title: Re: News Fader Not Working In Chrome
Post by: margarett on March 31, 2015, 02:32:47 PM
We have been noticing that latest versions of most "big" browsers are breaking a lot of JS :(

Those login buttons you have are not part of SMF so you should ask for support in the mod support topic. But IMO, same problem applies: it heavily relies on JS and browsers are breaking it :(

Kindred is totally correct. Unfortunately they just don't care..
Title: Re: News Fader Not Working In Chrome
Post by: Miker1029 on March 31, 2015, 02:43:17 PM
I don't see what the point is of asking the mod developer, it works in some that browsers and not others, Browsers should know....

But I just put that Out there to show how some things are working....Chrome Buttons Mods Add-ins are working..

FireFox There Not....

Chrome News Fader (Built Into SMF 2.0.9) Is NOT working

FireFox news fader is working....

Just trying to put the Info Out there...

If you have an Idea to Fix it in CHROME, Cause Screw F.F., Use chrome, But I'd like it all to atleast work like it should in 1 browser...

Know what I mean?

Or should I try the fix on the top of this page, Hell, I'm more then willing...

Mike 8-)
Title: Re: News Fader Not Working In Chrome
Post by: Miker1029 on March 31, 2015, 02:48:41 PM
Sorry you all are posting as I am So it's making it diffucult to talk...I'll give it a few, and yes kindred I Agree, But there should be a way to make it work... (Yes just got your Post after I posted my 2nd one....)

Mike
Title: Re: News Fader Not Working In Chrome
Post by: Shambles on March 31, 2015, 03:03:57 PM
Hang on. Isn't this someone else's already-solved topic?
Title: Re: News Fader Not Working In Chrome
Post by: margarett on April 01, 2015, 10:26:05 AM
Quote from: Shambles on March 31, 2015, 03:03:57 PM
Hang on. Isn't this someone else's already-solved topic?
It is. But it's also perfectly on-topic (because, all and all, the issue is the same ;) )

Proceeding :)

Quote from: Miker1029 on March 31, 2015, 02:43:17 PM
it works in some that browsers and not others, Browsers should know....
That's the thing: browsers are changing the way they interpret JavaScript and not assuring compatibility to older syntax. To make it worse, each browser is supporting different things. That's why "it works in some browsers and not others". That's why the news fader it's failing only in Chrome: because Chrome is not supporting opacity anymore, while others (still) do.

So, in the same way we (SMF) will have to make our JavaScript compatible with newer browsers, so will MOD authors. Because you can be sure that browsers will not care about SMF (or any other software, for what matters).
Title: Re: News Fader Not Working In Chrome
Post by: Miker1029 on April 02, 2015, 09:58:35 AM
Ya, so much for the "Standard" across multi-platforms Huh?

Guess I'll just have to figure a way around it, gonna try the solve here see if I can get it working, for now...

Thanks,

Mike
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on May 09, 2015, 12:17:27 AM
Many thanks for including the patch for this in the latest update.  Well done.  :)
Title: Re: News Fader Not Working In Chrome
Post by: imbakiller on May 09, 2015, 12:20:28 AM
i think its a problem about ur connection problem!
Title: Re: News Fader Not Working In Chrome
Post by: MOCA CPU on May 09, 2015, 12:26:52 AM
Nup.  All solved with their latest up date on 2.0.10.  Excellent job by the team  :)