Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: SlammedDime on July 13, 2007, 05:48:20 AM

Title: QuickEdit bug...
Post by: SlammedDime on July 13, 2007, 05:48:20 AM
When SMF changed the QuoteFast query for 1.1.3, a closing ')' was put in the wrong spot, causing users that cannot moderate a board not being able to QuickEdit a post in that board.

Line 2037 in Post.php AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards)) . ')' . ')') . "

should be

AND (t.locked = 0' . (empty($moderate_boards) ? '' : ' OR b.ID_BOARD IN (' . implode(', ', $moderate_boards) . ')') . ')') . "
Title: Re: QuickEdit bug...
Post by: SlammedDime on July 13, 2007, 06:11:33 AM
Been added in bug tracker.
Title: Re: QuickEdit bug...
Post by: joh87swe on July 19, 2007, 12:14:38 PM
Does this solve this error in log files?
http://www.mydomain(not my domain).com/index.php?action=quotefast;quote=13843;sesc;modify;xml 
Database error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')
LIMIT 1' at line 8
Fil: /var/www/html/smf/Sources/Post.php
Rad: 2038
Title: Re: QuickEdit bug...
Post by: SlammedDime on July 19, 2007, 03:00:34 PM
Yes.
Title: Re: QuickEdit bug...
Post by: joh87swe on July 19, 2007, 03:10:02 PM
Great!!
Title: Re: QuickEdit bug...
Post by: nitins60 on July 20, 2007, 11:30:32 AM
Ah, frequently i am getting this error from 1.1.1 series!

There s a big topic n this board @[Bug] Possible Database Error!

I reported many times, these errors are occuring suddenly when i use quick mod options, can't be reproduced. Thank god, you figured it out, waiting for next SMF Update :)
Title: Re: QuickEdit bug...
Post by: SlammedDime on July 20, 2007, 02:38:06 PM
This issue is purely in the 1.1.3 version.  Your issue is something different, which is very difficult to reproduce, and for another topic.
Title: Re: QuickEdit bug...
Post by: Mr.CoWbOy on July 28, 2007, 12:49:11 PM
i cant find that code in my post.php (!)

version 1.1.3
Title: Re: QuickEdit bug...
Post by: SlammedDime on July 28, 2007, 01:52:53 PM
If that isn't on line 2037, then you've had mods that have modified Post.php, you'll need to just do a text search in the file to find it.
Title: Re: QuickEdit bug...
Post by: FrEaK@ZoiD !!! on July 30, 2007, 04:21:11 PM
quickedit = edit inline icon, isn´t right?

If the answer is yes, that didn´t work with my SMF 1.1.3...

The inline edit button works, but don´t edit anything....

Anyone can help?

Thanx !
Title: Re: QuickEdit bug...
Post by: SleePy on July 31, 2007, 04:21:05 PM
This isn't a board for support. its for reporting bugs. This bug if I remember right has been already reported. 
Title: Re: QuickEdit bug...
Post by: joh87swe on August 02, 2007, 10:55:16 AM
I have another bug now.
When I'm editing a topic and waiting until I'm not logged in any longer and ther click save I have this:
http://www.com/index.php?action=post2;start=0;msg=1172;sesc;board=28 
Database error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 1' at line 5
File: /var/www/html/smf/Sources/Post.php
Line: 575
Title: Re: QuickEdit bug...
Post by: nitins60 on August 02, 2007, 11:58:48 AM
Atleast now Developers should realize this error!! Many users are reporting this Database Error, why developers are not even responding to these posts? :(
Title: Re: QuickEdit bug...
Post by: mytreo on August 03, 2007, 10:53:39 AM
Man, SO glad I found this.

I've been scratching my head over this and was just about to post it as a bug report. I figured the SQL was wrong but couldn't work out how to fix it. Thanks for the fix!
Title: Re: QuickEdit bug...
Post by: SleePy on August 03, 2007, 12:12:02 PM
Quote from: nitins60 on August 02, 2007, 11:58:48 AM
Atleast now Developers should realize this error!! Many users are reporting this Database Error, why developers are not even responding to these posts? :(

It is in the bug tracker and they will look at this.
Title: Re: QuickEdit bug...
Post by: Grudge on August 03, 2007, 05:49:28 PM
This is a known bug and is fixed in CVS - we have not yet determined how best to roll out the fix (It is a shame to release a 1.1.4 instantly - we'd rather patch a few other 1.1.3 bugs rather than rush it out if possible)
Title: Re: QuickEdit bug...
Post by: Georgeg on August 13, 2007, 03:28:42 PM
found the line in My post.php.

did the edit. Got this.

Parse error: parse error, unexpected T_VARIABLE in /home/content/f/x/a/fxaw1/html/Sources/Post.php on line 1728
:(
Title: Re: QuickEdit bug...
Post by: SlammedDime on August 13, 2007, 03:53:57 PM
This does not edit line 1728.  Make sure the entire file was uploaded and not cut off at line 1728.
Title: Re: QuickEdit bug...
Post by: Georgeg on August 14, 2007, 11:14:51 AM
Sorry. I edited line 1728, as it was the line including the bugged code. However I must have done something incorrect using NVU as I can no longer post.

I have removed mods, Ant the upgrade to 1.1.3 Back to 1.1.2

I am attempting to re upgrade & then put back the mods & fix my code.
My post.php does not come close to 2000 lines.

Here is a time when the suggested fix caused a total crash. No response from helpdesk after My fopah. & I have a weather site. TS Dean was just announced.
Title: Re: QuickEdit bug...
Post by: KTamas on September 14, 2007, 04:16:39 AM
Thank you very, very much. Edited the php file, now all's well.