Simple Machines Community Forum

Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=939)

Doesn't add (or update) an "Edited By" line when an admin or moderator edits a post.

Previous admin/moderator edits will retain their "Edited By" line.  If an admin/mod edits a post that already has an "Edited By" line, the line will be left alone (it won't update to reflect the admin edit, nor will it be removed from the post - whoever previously edited it will still be shown as having last edited it).

This mod is not retroactive - any posts that have already been edited by a mod or admin will retain the "Edited By" line showing the admin edit.

Version 1.0
  - Actually a re-release of a previously rejected mod
  - Cleaned up code and documentation from the old version
  - Support for SMF v1.1.3 added, support for older versions removed

Is there any chance of you updating this for 1.1.4? I've installed the mod successfully, but it continues to show any new edits I make.

Edit: It seems it doesn't work if you make your edit using the Inline Edit option.

Quote from: Rhadamanthus on October 04, 2007, 04:39:31 AM
Edit: It seems it doesn't work if you make your edit using the Inline Edit option.

This is a must have feature or this mod is practically useless...

And I'm on 1.1.3 and it doesn't work in inline OR normal edit.

Quote from: L.G.S on October 05, 2007, 03:52:41 PM
And I'm on 1.1.3 and it doesn't work in inline OR normal edit.

Same result here!

"The package you are trying to download or install is either corrupt or not compatible with this version of SMF."

Newest download available, for me.

I get the same message as above

Quote from: Dr. Jones on September 27, 2007, 05:55:31 PM
Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=939)

Doesn't add (or update) an "Edited By" line when an admin or moderator edits a post.

Previous admin/moderator edits will retain their "Edited By" line.  If an admin/mod edits a post that already has an "Edited By" line, the line will be left alone (it won't update to reflect the admin edit, nor will it be removed from the post - whoever previously edited it will still be shown as having last edited it).

This mod is not retroactive - any posts that have already been edited by a mod or admin will retain the "Edited By" line showing the admin edit.

Version 1.0
  - Actually a re-release of a previously rejected mod
  - Cleaned up code and documentation from the old version
  - Support for SMF v1.1.3 added, support for older versions removed

Hey doc, this mod looks like a treat, but we need it to work for 1.1.4 hows about an update please?

I've since done this via the tips and trick section. I had to do it manually, but found lots of help there :) thanks

Has some one updated it to work for the 1.1.4 version yet?

To use this for 1.1.4 you can do a simple & quick edit of the Post.php yourself.

Go to your installation directory & then to sources directory so should be something like 'SMF>Sources'.
Find the Post.php file, make a backup of it (just in case) and then open the Post.php in editor

Amongst all the jumble find... (its easier if you copy and paste the code into your favourite html editor and use the find tool)
// Have admins allowed people to hide their screwups?
if (time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

And replace it with...
// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
    && (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

Easy huh

What about hiding the message at inline editing as well?
Thanks.

I'd like to install this mod, but I am getting this error in 1.1.4:
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

How do I get this to install?

Thanks,
Matt

I'd like to use this mod too. I'm getting the same error as Matt. Any help would be great. Thanks. I've updated to 1.1.5, I wonder if this can be changed just as the same as 1.1.4, as dream1 indicated? I think I'll look into it.

Matt, looked at your site, had to laugh, not another dog site(kidding). lol Great, love it!

Yep, that did it. Thanks dream1, your instructions worked perfectly. Again, just to remind everyone, your currently edited posts will still display the edited info. Any new edits will not show as being edited.

Here is a compatible version of this mod for 1.1.5.

Made a change. Used the comp version for 1.1.5. Worked no problem, thanks ccbtimewiz

Hi,
I upgraded ny forum to 1.1.5, and installed the new version of this mod.  Now it works!
Great mod!
Thanks,
Matt

Hi!

When I try to download the mod for the 1.1.5 version I get the following message:

QuoteAn Error Has Occurred!
Sorry, but this modification does not appear to be compatible with the selected version.

What am I doing wrong? Or what can I do to get the mod for 1.1.5?

Well, are you using SMF 1.1.5?  :P

Yes, I do.

What modifications do you have installed already? Also, do you have any errors in the error log?

Well, I can´t download the mod.
The message comes when I try to download it, not when I try to instal it.

Is it right to download it there: http://custom.simplemachines.org/mods/index.php?mod=939?

Wait, what?

I'm afraid I don't understand you. You haven't downloaded this modification?

Yes, when I try to download the mod, then I get this message. A friend of mine too. But only with the 1.1.5 mod version. The older versions I can easily download.

Can you try it for me?

It is still the same.  :(

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg66.imageshack.us%2Fimg66%2F5204%2Ferrorip6.th.jpg&hash=99a9c27761481ff81c62b00236749ce0cb5df325) (http://img66.imageshack.us/my.php?image=errorip6.jpg)

... Click the actual package, not the submit button.

The actual package dont works in my forum.  :(

Here is a picture (sorry German), you can see all installed packages.

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg296.imageshack.us%2Fimg296%2F4847%2Fforumfd8.th.jpg&hash=dce31d4773c2c8867a872801038db255c0ba2737) (http://img296.imageshack.us/my.php?image=forumfd8.jpg)

Sie können deutsch sprechen?

Okay, ich werde Ihnen native Unterstützung. Sie werden benötigt zur Bearbeitung der package-infol.xml installieren. Das beinhaltet den Code, liest, was SMF-Version ist das Paket zu installieren. Einfach ändern Sie diesen Wert auf 1.1.5.

Etwa so:

<install for="{numbers}">

   
Ersetzen Sie mit diesem:

<install for="1.1.5">

Dann Reupload das Paket.  :)

Hi!

Thanks very much for your assistance. You can continue to write in English. :)

Well, I have changed the xml-file, as you said, but its still the same, it does not work.

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg384.imageshack.us%2Fimg384%2F8233%2Fxmlvh6.th.jpg&hash=d775125e95857a439666ac4b356d592d1b9fa6dc) (http://img384.imageshack.us/my.php?image=xmlvh6.jpg)

When I try to install it, its said that there is minimum one error.

I have although installed, but well... it does not work.

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg74.imageshack.us%2Fimg74%2F7748%2Ferroraa1.th.jpg&hash=12ea7d3c3420319bd7f0fba108b1125afca9ffaf) (http://img74.imageshack.us/my.php?image=erroraa1.jpg)

What file failed?

SMF 1.1.5
Error message:
8: Undefined variable: message
File: /.../....../....../...../Themes/default/languages/ModHidePost.english.php (eval?)
Line: 437

Looks like this mod is failing to work...

I'll remake this modification. I'll upload as soon as I have time.

Installed OK but editing a post (would that be considered INLINE editing?) still shows the mod info... !!!

Any fix for that?

EDIT - I found that the manual solution offered at reply #9 worked perfectly.

http://www.simplemachines.org/community/index.php?topic=197282.msg1462899

Quote from: rbar on July 14, 2008, 10:24:17 AM
EDIT - I found that the manual solution offered at reply #9 worked perfectly.

Not here. :(

same here,installed correctly but not at all working,i checked it and it shows same mesg---post edited by.....

pls is there any option where i can hide---post edited by admin.

Find:
// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
&#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> &#187;';

Replace with:
// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']) && $message['member']['group']['id'] != 1)
echo '
&#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> &#187;';

I can not find it in "install_1-1-3" or in "package-info".  ???

Quote from: install_1-1-3<modification xmlns="http://www.simplemachines.org/xml/modification" xmlns:smf="http://www.simplemachines.org/">
   <id>DrJones:HideModEdit</id>
   <version>1.0</version>

   <file name="$sourcedir/Post.php">
      <operation>
           <search position="replace"><![CDATA[
      // Have admins allowed people to hide their screwups?
      if (time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
      {
         $msgOptions['modify_time'] = time();
         $msgOptions['modify_name'] = addslashes($user_info['name']);
      }]]></search>
         <replace><![CDATA[
      // Have admins allowed people to hide their screwups?
      if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
          && (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
      {
         $msgOptions['modify_time'] = time();
         $msgOptions['modify_name'] = addslashes($user_info['name']);
      }]]></replace>
       </operation>
   </file>
</modification>

Quote from: package-info<?xml version="1.0"?>
<!DOCTYPE package-info SYSTEM "http://www.simplemachines.org/xml/package-info">
<package-info xmlns="http://www.simplemachines.org/xml/package-info" xmlns:smf="http://www.simplemachines.org/">
        <name>Hide mod and admin edits</name>
        <id>DrJones:HideModEdit</id>
        <type>modification</type>
        <version>1.0</version>
        <install for="1.1.3">
         <readme>readme.txt</readme>
         <modification>install_1-1-3.xml</modification>
        </install>
        <uninstall for="1.1.3">
         <modification reverse="true">install_1-1-3.xml</modification>
        </uninstall>
</package-info>

<install for="1.1.3">

Change this value to

<install for="1.1.3, 1.1.4, 1.1.5">

I have already made this long ago, but it dont helps. (Look at your reply #26)

Quote from: ccbtimewiz on July 24, 2008, 02:04:05 PM
Find:

Code (display.template.php) Select Expand

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
&#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> &#187;';

Where I can find this?  ???

Around line 800 or so.

Well, it doesn't work anyway (SMF 1.1.5).
I tried to install it manually. I've changed < replace > tag to < add > in install pacage (because replace tag causes errors after uninstall - it undesirebly adds modified code to the beginning of php file - before < ? php) and tried to install again. I even modified display.template.php as it was suggested above.
No result.
The worst is that idea of this mod is really good. It is necessary, I think.
So, let's hope that mod's author will make a newer version, which will work correctly in SMF 1.5.5, or SMF team will make the same feature in SMF 2 release.

I hope it too.

I have successfully installed this mod, but can you make it admin-only ? Or maybe founder-only if the former is not possible ? Because I don't want my mods to screw up some topics :D

This works for me in 1.1.6

Find
// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
&& (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

modifyPost($msgOptions, $topicOptions, $posterOptions);

}

Replace with
// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
&& (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

modifyPost($msgOptions, $topicOptions, $posterOptions);

}

;)

do i have to add that on post.php manually? i have installed the 'reason for editing' mod too, if i replace that part, it will disable my reason for editing mod right?

Quote from: Necto on October 06, 2008, 09:24:13 AM
This works for me in 1.1.6

Find

Code Select Expand

// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
&& (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

modifyPost($msgOptions, $topicOptions, $posterOptions);

}

Replace with

Code Select Expand

// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
&& (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

modifyPost($msgOptions, $topicOptions, $posterOptions);

}

;)

Aren't those two pieces of code identical? 

any news with 1.1.7 ?

Quote from: pinoypetfinder on November 19, 2008, 09:38:11 PM
any news with 1.1.7 ?

I did it manually for 1.1.7 and it worked fine.


// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
    && (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}


replaces:

// Have admins allowed people to hide their screwups?
if (time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

in Post.php

and

// Show "« Last Edit: Time by Person »" if this post was edited.
      if ($settings['show_modify'] && !empty($message['modified']['name']) && $message['member']['group']['id'] != 1)
         echo '
                           &#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> &#187;';

replaces:

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';


in display.template.php


- -
Okay,
Father Luke

any changes needed for 1.1.6?

Father Luke.
I have 1.1.7. and tried what you suggested, but it didn't work for me. The code you have listed as already being in the display.template.php is different for mine. This is what I have.

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
&#171; <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> &#187;';

Not sure what to change this to. What do you think? Thanks in advance.

@ forummaker :

That looks like it's already had the mod applied.
What about the rest?


- -
Okay,
Father Luke

Quote from: Father Luke on December 31, 2008, 09:15:25 AM

Quote from: pinoypetfinder on November 19, 2008, 09:38:11 PM
any news with 1.1.7 ?

I did it manually for 1.1.7 and it worked fine.

Code Select Expand

// Have admins allowed people to hide their screwups?
if ((time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
    && (!in_array('moderate_board',$user_info['permissions']) && !$user_info['is_admin']))
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}


replaces:

Code Select Expand

// Have admins allowed people to hide their screwups?
if (time() - $row['posterTime'] > $modSettings['edit_wait_time'] || $ID_MEMBER != $row['ID_MEMBER'])
{
$msgOptions['modify_time'] = time();
$msgOptions['modify_name'] = addslashes($user_info['name']);
}

in Post.php

and

Code Select Expand

// Show "« Last Edit: Time by Person »" if this post was edited.
      if ($settings['show_modify'] && !empty($message['modified']['name']) && $message['member']['group']['id'] != 1)
         echo '
                           « <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';

replaces:

Code Select Expand

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';


in display.template.php


- -
Okay,
Father Luke

Worked here also, thanks!

As we show a Reason For Edit had to tweak your hints a bit in order not to lose that feature.

Kind regards,

Rattler

FAO Father Luke:

While your code does exactly what I want to have done, I get an error in the error log every time someone looks at a post

Error: 8: Uninitialized string offset: 0
File: ./Themes/default/Display.template.php (main sub template - eval?)
Line: 480

which in my case is

if ($settings['show_modify'] && !empty($message['modified']['name']) && $message['member']['group']['id'] != 1)

I guess this is only a notice, as nothing seems not to be working as it should in the forum overall, but it is at least annoying to have pages and pages of error log to clear every day.

Any ideas why php would be screaming "unitialized string"? Can I force a set to get rid of the error?

Kind regards,

Rattler

@Rattler:

You could go:
Configuration - -  >Features and Options - -  > uncheck Enable error logging.


- -
Okay,
Father Luke

Quote from: Father Luke on January 30, 2009, 06:52:14 PM
@Rattler:

You could go:
Configuration - -  >Features and Options - -  > uncheck Enable error logging.
- -
Okay,
Father Luke

Indeed!  ;)

Better: I found it finally, a small typo, the "1" in the end of line does not like a space in front, the following now works w/o more errors:

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']) && $message['member']['group']['id'] !=1)

:D

Kind regards,

Rattler

@ Rattler:

Good work.  (https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.mysmiley.net%2Fimgs%2Fsmile%2Fsign%2Fsign0201.gif&hash=38d538ff0608d275cebaac8ba7dd76d9a77813e5)

- -
Okay,
Father Luke

Quote from: Father Luke on January 30, 2009, 07:45:47 PM
@ Rattler:
Good work.

Father Luke

Well. turns out it only solved it for admins/mds looking at a post.

For guests and other non-staff members the error perisists...  ::)

Any more ideas?

Rattler

That worked but Did Not Hide The Edits Of Regular users, Any Idea?, Thanks!

     How can  hide only admin edit.Thank,

Quote from: Kob Ob Ob on July 05, 2009, 12:57:57 PM
     How can  hide only admin edit.Thank,

Same here.
Please.

I need this mode for SMF2.0RC3 please :(

Quote from: amiralib on July 09, 2010, 03:38:45 PM
I need this mode for SMF2.0RC3 please :(

yes...