Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: vbgamer45 on May 19, 2008, 02:35:52 AM

Title: Ignore Topics
Post by: vbgamer45 on May 19, 2008, 02:35:52 AM
Link to the mod (https://custom.simplemachines.org/index.php?mod=1193)

(http://bit.ly/kZVDB6)

IGNORE TOPICS
Developed by 4kstore (https://www.smfsimple.com/index.php?action=profile;u=55) for SMFSimple.com (https://www.smfsimple.com/)
Created by Karl Benson (http://custom.simplemachines.org/mods/index.php?action=profile;u=63186)
24



El soporte oficial de los desarrolladores de nuestros mods lo encontraras en SMFSimple.com



Description:
Adds the ability to ignore individual topics for the purposes of RecentPosts/Recent/UnreadReplies/Unread sections of SMF.
¡You will need to enable Quick Moderation to use the feature. (which enables the checkboxes)!

Descripcion:
Agrega la funcionalidad de ignorar cada topic de la lista de Temas Recientes/Respuesta No Leidas/Temas No Leidos
¡Debe activar la moderacion rapida para usar el mod (usando los checkboxes)!


Features:
o IgnoreTopics Profile Section
- Select to Un-Ignore topics
- Un-Ignore All My Ignored Topics
o Settings (via Admin > Boards > Settings)
- Enable mod
- (int) Limit allowed no. of ignored topics
- Function to Clear ALL ignored topics for all users.
o Permissions (Admin > Permissions
- Permission for ignore topics
- Permission to allow unlimited ignored topics
o Alters RecentPosts/Recent/UnreadReplies/Unread sections of SMF to enable Ignore Topics
o Need to enable your Quick Moderation checkboxes via Profile > Look and Layout

Caracteristicas:
o Perfil Seccion: IgnoreTopics
- Seleccionar Designorar Temas
- Designorar todos los temas ignorados
o Configuracion: (via Admin > Boards > Settings)
- Habilitar Mod
- (int) Limitar el numero de temas ignorados
- Funcion que permite designorar todos los temas de todos los usuarios
o Permisos: Admin > Permissions
- Permisos para ignorar temas
- Permiso para ignorar ilimitados temas
o Necesita activar la moderacion rapida (Checkboxes) en Perfil > Look and Layout



Screenshots | Imagenes

(http://i.imgur.com/4yhP2.png)   
(http://i.imgur.com/uprlE.png)
(http://i.imgur.com/913Ub.png)
(http://i.imgur.com/ycDhB.png)
(http://i.imgur.com/oHl0S.png)


Language Support | Lenguajes Soportados

English & English British
Spanish Latin - Es
More Translations (http://www.smfsimple.com/index.php/topic,4667.msg23003.html#msg23003)



IGNORE TOPICS

Copyright 2011 | SMFSimple.com (https://www.smfsimple.com/)

(http://i.creativecommons.org/l/by-nc-sa/3.0/88x31.png) (http://creativecommons.org/licenses/by-nc-sa/3.0/)
Title: Re: Ignore Topics
Post by: ne.miguelito on May 19, 2008, 04:19:35 AM
An Error Has Occurred!

Sorry but no mod was found
Title: Re: Ignore Topics
Post by: niko on May 19, 2008, 04:22:20 AM
Quote from: ne.miguelito on May 19, 2008, 04:19:35 AM
An Error Has Occurred!

Sorry but no mod was found

http://custom.simplemachines.org/mods/index.php?mod=1193
Title: Re: Ignore Topics
Post by: [SiNaN] on May 19, 2008, 01:05:15 PM
Hımmm, at last you released it by yourself Karl.

I very useful mod. Hope to see it here also.
Title: Re: Ignore Topics
Post by: karlbenson on May 19, 2008, 01:50:57 PM
I thought it best to just submit it and get it approved.
Title: Re: Ignore Topics
Post by: psi0 on May 19, 2008, 08:36:58 PM
Useful mod.

Maybe in next version can ignore boards also :)

I will try in my forum.

Thanks
Title: Re: Ignore Topics
Post by: karlbenson on May 19, 2008, 08:43:14 PM
Ignore Boards is a default 2.x feature.

Ignoring boards should hide the topics in those boards from the same areas.
Title: Re: Ignore Topics
Post by: Apllicmz on May 19, 2008, 11:09:39 PM
Nice Mod
Good Work

Translate Portguese and brazilian suporte utf8

<file name="$languagedir/Modifications.portuguese-utf8.php" error="skip">
<!--// Adds the language strings used by this modification //-->
<operation>
<search position="end" />
<add><![CDATA[
$txt['ignoretopics_empty'] = 'Un-ignore todos os t&oacute;picos';
$txt['date_ignored'] = 'Data Ignorada';
$txt['ignore_topics_none'] = 'N&atilde;o h&aacute; t&oacute;picos actualmente ignorados';
$txt['ignoretopicsdisallowed'] = 'Ignorar os t&oacute;picos desativados';
$txt['ignoretopics'] = 'Ignorar os t&oacute;picos e op&ccedil;&otilde;es';
$txt['ignore_topics'] = 'Ignorar t&oacute;picos';
$txt['unignore_topics'] = 'Un-ignore t&oacute;picos';
$txt['ignoretopics_info'] = 'Voc&ecirc; pode ignorar determinados t&oacute;picos para que eles n&atilde;o ir&atilde;o aparecer em como n&atilde;o lidos/UnreadReplies nem a recente.<br />
No entanto eles ainda aparecer&atilde;o na BoardIndex e MessageIndex e voc&ecirc; ainda ser&aacute; capaz de acessar os t&oacute;picos.';
$txt['topics_not_found'] = 'N&atilde;o foram encontrados t&oacute;picos';
]]></add>
</operation>
</file>

<file name="$languagedir/Modifications.brazilian-utf8.php" error="skip">
<!--// Adds the language strings used by this modification //-->
<operation>
<search position="end" />
<add><![CDATA[
$txt['ignoretopics_empty'] = 'Un-ignore todos os t&oacute;picos';
$txt['date_ignored'] = 'Data Ignorada';
$txt['ignore_topics_none'] = 'N&atilde;o h&aacute; t&oacute;picos actualmente ignorados';
$txt['ignoretopicsdisallowed'] = 'Ignorar os t&oacute;picos desativados';
$txt['ignoretopics'] = 'Ignorar os t&oacute;picos e op&ccedil;&otilde;es';
$txt['ignore_topics'] = 'Ignorar t&oacute;picos';
$txt['unignore_topics'] = 'Un-ignore t&oacute;picos';
$txt['ignoretopics_info'] = 'Voc&ecirc; pode ignorar determinados t&oacute;picos para que eles n&atilde;o ir&atilde;o aparecer em como n&atilde;o lidos/UnreadReplies nem a recente.<br />
No entanto eles ainda aparecer&atilde;o na BoardIndex e MessageIndex e voc&ecirc; ainda ser&aacute; capaz de acessar os t&oacute;picos.';
$txt['topics_not_found'] = 'N&atilde;o foram encontrados t&oacute;picos';
]]></add>
</operation>
</file>



<file name="$languagedir/Modifications.portuguese.php" error="skip">
<!--// Adds the language strings used by this modification //-->
<operation>
<search position="end" />
<add><![CDATA[
$txt['ignoretopics_empty'] = 'Un-ignore todos os tópicos';
$txt['date_ignored'] = 'Data Ignorada';
$txt['ignore_topics_none'] = 'Não há tópicos actualmente ignorados';
$txt['ignoretopicsdisallowed'] = 'Ignorar os tópicos desativados';
$txt['ignoretopics'] = 'Ignorar os tópicos e opções';
$txt['ignore_topics'] = 'Ignorar tópicos';
$txt['unignore_topics'] = 'Un-ignore tópicos';
$txt['ignoretopics_info'] = 'Você pode ignorar determinados tópicos para que eles não irão aparecer em como não lidos/UnreadReplies nem a recente.<br />
No entanto eles ainda aparecerão na BoardIndex e MessageIndex e você ainda será capaz de acessar os tópicos.';
$txt['topics_not_found'] = 'Não foram encontrados tópicos';
]]></add>
</operation>
</file>

<file name="$languagedir/Modifications.brazilian.php" error="skip">
<!--// Adds the language strings used by this modification //-->
<operation>
<search position="end" />
<add><![CDATA[
$txt['ignoretopics_empty'] = 'Un-ignore todos os tópicos';
$txt['date_ignored'] = 'Data Ignorada';
$txt['ignore_topics_none'] = 'Não há tópicos actualmente ignorados';
$txt['ignoretopicsdisallowed'] = 'Ignorar os tópicos desativados';
$txt['ignoretopics'] = 'Ignorar os tópicos e opções';
$txt['ignore_topics'] = 'Ignorar tópicos';
$txt['unignore_topics'] = 'Un-ignore tópicos';
$txt['ignoretopics_info'] = 'Você pode ignorar determinados tópicos para que eles não irão aparecer em como não lidos/UnreadReplies nem a recente.<br />
No entanto eles ainda aparecerão na BoardIndex e MessageIndex e você ainda será capaz de acessar os tópicos.';
$txt['topics_not_found'] = 'Não foram encontrados tópicos';
]]></add>
</operation>
</file>
Title: Re: Ignore Topics
Post by: tk2012 on July 30, 2008, 05:21:13 PM
I just installed this.  How do you actually mark Topics in order to ignore them?

I see the profile section where it will list the ones you did ignore, but how do you actually get something in that list?
Title: Re: Ignore Topics
Post by: karlbenson on July 30, 2008, 05:26:54 PM
You need to enable quick moderation.
Profile > Look and layout (select checkboxes).

Then when your on unread or unreadrepies page. Check the ones you want to ignore down the right hand side, and click Ignore Selected at the bottom.
Title: Re: Ignore Topics
Post by: tk2012 on July 30, 2008, 05:35:01 PM
My bad, I enabled the quick reply instead of the quick moderation!!

sorry for the trouble!  and THANK YOU.  My members have been wanting this!
Title: Re: Ignore Topics
Post by: tk2012 on September 03, 2008, 09:23:59 PM
Question...

Shouldn't there be an option to ignore a topic after you read it instead of before it is read?  Currently, I am able to mark something to ignore it via the unread posts.  But, this is before I can actually read the post to decide whether or not I want to ignore it.  Once it is read, it is no longer selectable to be ignored.  Is there a way that I don't understand to ignore a topic once it is read?  Or, is there a plan to remedy this if there is not a way?

I'm trying to write a tutorial to my members on how to ignore topics and I'm sure people are going to ask me how they know they want to ignore a topic if they haven't read it yet...

BTW - I love your work!
Title: Re: Ignore Topics
Post by: karlbenson on September 04, 2008, 09:59:43 AM
Generally the mod wasn't intended to be used on the same scale as marking posts as read.

It was intended for topics you may have posted in. But it is now at 1000 posts, and everyday gets put back on your unread posts list because there have been replies.  And as a soon as you've marked it read, somebody replies again.

(So generally it is meant for topics that you are already aware of what its about)
Title: Re: Ignore Topics
Post by: tk2012 on September 07, 2008, 11:37:59 AM
gotcha.. thanks for the info!
Title: Re: Ignore Topics
Post by: robg2251 on May 21, 2009, 12:11:27 PM
We're trying to get this to work in the recent RC1 release.   See the following post for the whole scoop:

http://www.simplemachines.org/community/index.php?topic=304982.0

Update there if you could, or here, whichever. I'll check back to both.   Thanks!
Title: Re: Ignore Topics
Post by: ~DS~ on April 04, 2010, 03:57:34 PM
I bet Arantor wants that installed here. :P
Title: Re: Ignore Topics
Post by: kat on April 04, 2010, 03:59:33 PM
I think it should be, too. ;)
Title: Re: Ignore Topics
Post by: vbgamer45 on April 04, 2010, 04:02:13 PM
I thought this was built into SMF 2.0 so that's why I didn't bother to update it. Then I had a couple team members as to getting it installed on this site.
Title: Re: Ignore Topics
Post by: kat on April 04, 2010, 04:03:24 PM
/me gives vbgamer admin access... ;)
Title: Re: Ignore Topics
Post by: ~DS~ on April 04, 2010, 04:05:07 PM
Quote from: vbgamer45 on April 04, 2010, 04:02:13 PM
I thought this was built into SMF 2.0 so that's why I didn't bother to update it. Then I had a couple team members as to getting it installed on this site.
Which why you noticed Arantor was fed up on some topics because it show up on his unread relies. :P
Title: Re: Ignore Topics
Post by: vbgamer45 on April 04, 2010, 04:07:08 PM
Quote from: Kat on April 04, 2010, 04:03:24 PM
/me gives vbgamer admin access... ;)
I wish I would fix a couple things on this site mainly for performance.
Title: Re: Ignore Topics
Post by: Arantor on April 04, 2010, 04:12:34 PM
Yay, I can stop work on the almost finished first paid mod I was going to do.

Though mine's actually smaller and faster than this, all I needed to add to it was quick moderation access and an interface to view them; I already fixed the whole process of ignoring topics without any kind of speed penalty whatsoever... and with far fewer edits too...
Title: Re: Ignore Topics
Post by: TurtleKicker on April 05, 2010, 04:10:22 PM
Bummer that there's a known way out there to do this faster/better...
Title: Re: Ignore Topics
Post by: Arantor on April 05, 2010, 04:16:15 PM
Wouldn't say 'better', though I can't deny it is faster because it makes no DB changes, and does nothing to the query that SMF runs out of the box. All it does is fudge the 'last message I read in that topic' to be the highest possible ID that SMF can have safely.
Title: Re: Ignore Topics
Post by: Arantor on April 10, 2010, 05:11:04 AM
If anyone's interested, here's the hack I did for my forum. It's not complete, though, since there's no way to view what topics are ignored, and there are fringe cases that aren't very pretty (marking unread unignores it, but I kinda figured that was the case)

Just as food for thought, anyway.


EDIT: I figured out why this worked for me; I forgot to add english.xml. Since I'm not at home I just remade the file.
Title: Re: Ignore Topics
Post by: ~DS~ on April 10, 2010, 02:27:31 PM
Quote from: Arantor on April 10, 2010, 05:11:04 AM
If anyone's interested, here's the hack I did for my forum. It's not complete, though, since there's no way to view what topics are ignored, and there are fringe cases that aren't very pretty (marking unread unignores it, but I kinda figured that was the case)

Just as food for thought, anyway.
:P
Title: Re: Ignore Topics
Post by: Arantor on April 10, 2010, 02:27:51 PM
Huh. Worked for me just fine.
Title: Re: Ignore Topics
Post by: Chas Large on April 19, 2010, 04:01:39 PM
Quote from: vbgamer45 on May 19, 2008, 02:35:52 AM
...
You will also need to copy the images into each Theme
Themes/{themename}/images/icons/ignore_topic.gif
...
Can't find this graphic even though the mod installed OK. Can't find it in the install instructions either. Is it a typo?
Title: Re: Ignore Topics
Post by: Chas Large on April 19, 2010, 04:43:38 PM
I have installed this now on two 2.0 RC3 forums and it works OK on both except that on one, when I click show new replies to your posts I get the following error:

Unknown column 'pi.id_topic' in 'on clause'
File: /home/nas05l/f/fiftyplusforum.co.uk/user/htdocs/forum/Sources/Recent.php
Line: 1093


I have compared the Recent.php file between the two forums (which are basically identical, one live, one test) and the two files are the same.

If I disable Ignore Topics in the Admin > Boards > Settings then the show new replies works OK. Tried several times and each time IT is enabled the error appears.

Any ideas ?

[EDIT]
Here's the error log entry too.


http://www.fiftyplusforum.co.uk/forum/index.php?action=unreadreplies
Database Error: Unknown column 'pi.id_topic' in 'on clause'
File: /home/nas05l/f/fiftyplusforum.co.uk/user/htdocs/forum/Sources/Recent.php
Line: 1093
Title: Re: Ignore Topics
Post by: Chas Large on April 26, 2010, 07:29:22 AM
*Bump*

Anyone any ideas about this error please  ???
Title: Re: Ignore Topics
Post by: Chas Large on May 18, 2010, 04:32:05 AM
** Second Bump Up **

Come on vbGamer, give us a clue, please?  :(
Title: Re: Ignore Topics
Post by: Arantor on May 18, 2010, 04:39:45 AM
Care to attach the file it's complaining about?
Title: Re: Ignore Topics
Post by: Chas Large on May 18, 2010, 04:54:36 AM
Quote from: Arantor on May 18, 2010, 04:39:45 AM
Care to attach the file it's complaining about?
Here is the recent.php file. I couldn't see any problem with it compared to the forum that is working but thanks for taking a look.
Title: Re: Ignore Topics
Post by: Arantor on May 18, 2010, 05:06:19 AM
Any other mods on the site it doesn't work properly on?

Also, for the purposes of debugging, please turn on Admin > Security > Include database query in the error log and reproduce the error so I can see the whole query in question.

Thing is, I can't see any relevance whatsoever on line 1093, almost as if it's the wrong file :(
Title: Re: Ignore Topics
Post by: Chas Large on May 18, 2010, 05:09:45 AM
My Apologies, I must have uninstalled it but it failed in some way. When I compared the file (just downloaded from the site) against my test site, I can see there is no relevance. So I checked and it appeared to be installed. So I uninstalled and then reinstalled and enabled it. It's working but gives the error as above still.

Attached now is the very latest version of Recent.php. I have quickly compared this to the manual install instructions and all the mod seems to have been installed correctly.

All other mods in the site are working fine.
Title: Re: Ignore Topics
Post by: Arantor on May 18, 2010, 05:14:15 AM
Bingo, now I can see the problem. The query that finishes on line 1093 is broken.

Here's the product query:
$request = $smcFunc['db_query']('', '
SELECT t.id_topic
FROM {db_prefix}topics_posted_in AS t
LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = pi.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board . '
AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
'. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
ORDER BY {raw:order}
LIMIT {int:offset}, {int:limit}',
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
'offset' => $_REQUEST['start'],
'limit' => $context['topics_per_page'],
))
);


And it's saying that it doesn't know pi.id_topic - well, here it doesn't because we never defined pi as a table alias. Should be:

$request = $smcFunc['db_query']('', '
SELECT t.id_topic
FROM {db_prefix}topics_posted_in AS t
LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = t.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board . '
AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
'. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
ORDER BY {raw:order}
LIMIT {int:offset}, {int:limit}',
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
'offset' => $_REQUEST['start'],
'limit' => $context['topics_per_page'],
))
);
Title: Re: Ignore Topics
Post by: Chas Large on May 18, 2010, 05:24:43 AM
Thanks Arantor, Now for the oddity.

I uploaded the file that I gave you here to my test site and it's working fine, it only appears to be a problem with the main forum site.

I changed the code and uploaded it to the main forum and it's fixed in the main forum now too. Thank you.

My question is, how come it worked in one site but not another? Could it have been some mod clash? I have the same mods in both forums. The test site is used to test the mods before I make them live for the users.
Title: Re: Ignore Topics
Post by: Arantor on May 18, 2010, 05:28:53 AM
Is likely a mod clash. Not quite sure what went on though.
Title: Re: Ignore Topics
Post by: Chas Large on May 19, 2010, 04:02:49 AM
Arantor Help!

Just discovered another bug. If I click the NEW Indicator on the forum index I get the following error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IFNULL(it.id_topic, 0) = 0
AND t.id_last_msg > 143234
AND IFNULL(lt.id_m' at line 6
File: /home/nas05l/f/fiftyplusforum.co.uk/user/htdocs/forum/Sources/Recent.php
Line: 878


Clicking the NEW indicator on the unread and show new... lists works fine.
Title: Re: Ignore Topics
Post by: Arantor on May 19, 2010, 07:17:57 AM
Recent.php
Code (find) Select
$request = $smcFunc['db_query']('', '
SELECT COUNT(*), MIN(t.id_last_msg)
FROM {db_prefix}topics AS t' . (!empty($have_temp_table) ? '
LEFT JOIN {db_prefix}log_topics_unread AS lt ON (lt.id_topic = t.id_topic)' : '
LEFT JOIN {db_prefix}log_topics AS lt ON (lt.id_topic = t.id_topic AND lt.id_member = {int:current_member})') . '
LEFT JOIN {db_prefix}log_mark_read AS lmr ON (lmr.id_board = t.id_board AND lmr.id_member = {int:current_member})
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = t.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board .
($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .
($context['showing_all_topics'] && !empty($earliest_msg) ? '
AND t.id_last_msg > {int:earliest_msg}' : (!$context['showing_all_topics'] && empty($_SESSION['first_login']) ? '
AND t.id_last_msg > {int:id_msg_last_visit}' : '')) . '
AND IFNULL(lt.id_msg, IFNULL(lmr.id_msg, 0)) < t.id_last_msg' . ($modSettings['postmod_active'] ? '
AND t.approved = {int:is_approved}' : ''),
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'earliest_msg' => !empty($earliest_msg) ? $earliest_msg : 0,
'id_msg_last_visit' => $_SESSION['id_msg_last_visit'],
'is_approved' => 1,
))
);


Code (replace) Select
$request = $smcFunc['db_query']('', '
SELECT COUNT(*), MIN(t.id_last_msg)
FROM {db_prefix}topics AS t' . (!empty($have_temp_table) ? '
LEFT JOIN {db_prefix}log_topics_unread AS lt ON (lt.id_topic = t.id_topic)' : '
LEFT JOIN {db_prefix}log_topics AS lt ON (lt.id_topic = t.id_topic AND lt.id_member = {int:current_member})') . '
LEFT JOIN {db_prefix}log_mark_read AS lmr ON (lmr.id_board = t.id_board AND lmr.id_member = {int:current_member})
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = t.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board .
($can_ignore ? '
AND IFNULL(it.id_topic, 0) = 0' : '') .
($context['showing_all_topics'] && !empty($earliest_msg) ? '
AND t.id_last_msg > {int:earliest_msg}' : (!$context['showing_all_topics'] && empty($_SESSION['first_login']) ? '
AND t.id_last_msg > {int:id_msg_last_visit}' : '')) . '
AND IFNULL(lt.id_msg, IFNULL(lmr.id_msg, 0)) < t.id_last_msg' . ($modSettings['postmod_active'] ? '
AND t.approved = {int:is_approved}' : ''),
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'earliest_msg' => !empty($earliest_msg) ? $earliest_msg : 0,
'id_msg_last_visit' => $_SESSION['id_msg_last_visit'],
'is_approved' => 1,
))
);


vbgamer: Without being funny, was this mod actually tested when it was refitted for 2.0 RC3?
Title: Re: Ignore Topics
Post by: Chas Large on May 19, 2010, 09:24:28 AM
Thanks once again Arantor.

/me wipes sweat from brow
Title: Re: Ignore Topics
Post by: goombapatrol on June 01, 2010, 01:52:09 AM
would there be any way to make this compatible with 1.1?
i didn't see any others like it that would work quite the same as this mod.

thanks :)
Title: Re: Ignore Topics
Post by: Arantor on June 06, 2010, 07:24:44 PM
Not without a total rewrite of either piece of code, and since both are complex, not gonna happen any time soon.
Title: Re: Ignore Topics
Post by: Chas Large on June 29, 2010, 07:50:16 AM
It appears there is another bug with this mod. Initially I thought it was a bug in the SMF software but it was pointed out to me, that this mod was the cause. Here is my post in the SMF bug report forum:

Quote from: Chas Large on June 17, 2010, 08:00:26 AM
A couple of my members reported seeing the following error message:

QuoteYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IFNULL(it.id_topic, 0) = 0
AND t.id_last_msg > 116521
AND IFNULL(lt.id_m' at line 7
File: /home/nas05l/f/fiftyplusforum.co.uk/user/htdocs/forum/Sources/Recent.php
Line: 796

At first I could not replicate this error but now I can.

Any browser

In forum view, click on the NEW indicator for a child board
If no UNREAD topics are found you get the message

No unread topics found since your last visit. Click here to try all unread topics.

If you click the last part of the message "Click here to try all unread topics." you get the error above.

I've optimised the tables, run error check and both appear OK. So think it's a bug somewhere. There are several like it reported in the bug tracker but wasn't sure if this was until it could be replicated elsewhere.

I'm running 2.0 RC3.

If the Ignore Topics mod is disabled, this error does not appear. It is repeatable.

Any ideas?
Title: Re: Ignore Topics
Post by: Chas Large on July 12, 2010, 07:23:54 AM
Quote from: Chas Large on June 29, 2010, 07:50:16 AM
It appears there is another bug with this mod. Initially I thought it was a bug in the SMF software but it was pointed out to me, that this mod was the cause. Here is my post in the SMF bug report forum:

Quote from: Chas Large on June 17, 2010, 08:00:26 AM
A couple of my members reported seeing the following error message:

QuoteYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IFNULL(it.id_topic, 0) = 0
AND t.id_last_msg > 116521
AND IFNULL(lt.id_m' at line 7
File: /home/nas05l/f/fiftyplusforum.co.uk/user/htdocs/forum/Sources/Recent.php
Line: 796

At first I could not replicate this error but now I can.

Any browser

In forum view, click on the NEW indicator for a child board
If no UNREAD topics are found you get the message

No unread topics found since your last visit. Click here to try all unread topics.

If you click the last part of the message "Click here to try all unread topics." you get the error above.

I've optimised the tables, run error check and both appear OK. So think it's a bug somewhere. There are several like it reported in the bug tracker but wasn't sure if this was until it could be replicated elsewhere.

I'm running 2.0 RC3.

If the Ignore Topics mod is disabled, this error does not appear. It is repeatable.

Any ideas?
Bump
Anyone?
Title: Re: Ignore Topics
Post by: Nao 尚 on July 12, 2010, 07:43:14 AM
There's another Unread Topics mod which I wrote and a beta tester kindly packaged for me. I'll have to publish it at some point... It's a tentative "official" mod that should be integrated into SMF 2.1 if all goes well.
Title: Re: Ignore Topics
Post by: Chas Large on July 14, 2010, 05:26:50 AM
Quote from: Nao on July 12, 2010, 07:43:14 AM
There's another Unread Topics mod which I wrote and a beta tester kindly packaged for me. I'll have to publish it at some point... It's a tentative "official" mod that should be integrated into SMF 2.1 if all goes well.
Sounds good Nao. at the moment, this mod is working well except for this error but not many members click that link so it only shows up rarely. I'd have a go at fixing it myself if I could understand the script but I can't work it out. Too old I guess :)

Look forward to either your mod or 2.1 version.
Title: Re: Ignore Topics
Post by: Brande on July 18, 2010, 11:00:30 AM
Quote from: Arantor on May 18, 2010, 05:14:15 AM
Bingo, now I can see the problem. The query that finishes on line 1093 is broken.

Here's the product query:
$request = $smcFunc['db_query']('', '
SELECT t.id_topic
FROM {db_prefix}topics_posted_in AS t
LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = pi.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board . '
AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
'. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
ORDER BY {raw:order}
LIMIT {int:offset}, {int:limit}',
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
'offset' => $_REQUEST['start'],
'limit' => $context['topics_per_page'],
))
);


And it's saying that it doesn't know pi.id_topic - well, here it doesn't because we never defined pi as a table alias. Should be:

$request = $smcFunc['db_query']('', '
SELECT t.id_topic
FROM {db_prefix}topics_posted_in AS t
LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = t.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board . '
AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
'. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
ORDER BY {raw:order}
LIMIT {int:offset}, {int:limit}',
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
'offset' => $_REQUEST['start'],
'limit' => $context['topics_per_page'],
))
);


Thanks a lot! Resolve my problem!
Title: Re: Ignore Topics
Post by: b4pjoe on July 28, 2010, 06:17:01 PM
I have installed this mod on SMF 2.0 RC3 and it installs without any errors but I see nothing anywhere that you can mark any topics to ignore. Quick Moderation is enabled and I'm using the Default Theme. Here is a screen shot of where I think the button should be but it is not. Any ideas at all?
Title: Re: Ignore Topics
Post by: Brande on July 28, 2010, 06:24:41 PM
Joe,

You need enable quick moderation in your perfil to see this mod ...



Title: Re: Ignore Topics
Post by: b4pjoe on July 28, 2010, 07:02:49 PM
Quote from: Brande on July 28, 2010, 06:24:41 PM
Joe,

You need enable quick moderation in your perfil to see this mod ...

Yes, Quick Moderation is enabled as you can see by the checkboxes in the screen shot I posted.
Title: Re: Ignore Topics
Post by: Brande on July 28, 2010, 09:49:27 PM
Quote from: joec88 on July 28, 2010, 07:02:49 PM
Quote from: Brande on July 28, 2010, 06:24:41 PM
Joe,

You need enable quick moderation in your perfil to see this mod ...

Yes, Quick Moderation is enabled as you can see by the checkboxes in the screen shot I posted.

Joe, all right. I understand now! The button "Ignore Topics" show only in "/index.php?action=unreadreplies"

Title: Re: Ignore Topics
Post by: b4pjoe on July 28, 2010, 10:12:58 PM
Quote from: Brande on July 28, 2010, 09:49:27 PM
Quote from: joec88 on July 28, 2010, 07:02:49 PM
Quote from: Brande on July 28, 2010, 06:24:41 PM
Joe,

You need enable quick moderation in your perfil to see this mod ...

Yes, Quick Moderation is enabled as you can see by the checkboxes in the screen shot I posted.

Joe, all right. I understand now! The button "Ignore Topics" show only in "/index.php?action=unreadreplies"



Thanks for the reply. Unfortunately that doesn't work for me either:

(Edited to add...I also did a fresh install of SMF 2.0 RC3, installed the mod and I still get nothing.)
Title: Re: Ignore Topics
Post by: Chas Large on July 30, 2010, 03:36:29 PM
You need to enable the new feature:

Admin >> Forum >> Boards >> Settings and check the box

Enable Ignore-Topics mod
Title: Re: Ignore Topics
Post by: b4pjoe on July 30, 2010, 07:55:37 PM
Quote from: Chas Large on July 30, 2010, 03:36:29 PM
You need to enable the new feature:

Admin >> Forum >> Boards >> Settings and check the box

Enable Ignore-Topics mod

Thank you. That was it.
Title: Re: Ignore Topics
Post by: Raffoz on September 19, 2010, 01:16:17 PM
just a question...

but the mod is just usable by single users?
can't i set some "ignored topics" so any user doesn't see it in the list of recents?
Title: Re: Ignore Topics
Post by: anidea on September 21, 2010, 01:53:16 PM
Hi all!

So I have this mod installed, and it looks great!  But...

200 members...I want to change their settings to "Display Quick Mod"=1, so that everyone will have the ability.

I can do a query, but I can't seem to find that field in the database?  Is there anyway to globally change their profile to have the ignore feature visible to them?
Title: Re: Ignore Topics
Post by: Chas Large on September 21, 2010, 02:41:01 PM
Quote from: anidea on September 21, 2010, 01:53:16 PM
Hi all!

So I have this mod installed, and it looks great!  But...

200 members...I want to change their settings to "Display Quick Mod"=1, so that everyone will have the ability.

I can do a query, but I can't seem to find that field in the database?  Is there anyway to globally change their profile to have the ignore feature visible to them?
If you're running SMF 2.0 then this can be done via:
Admin >> Configuration >> Themes and Layout >> Member Options >>
Select the Theme then click Change current options for all members using this theme
Select Change on the Show quick-moderation as line and select Checkboxes. Finally click Save.
Repeat for all themes in use.
Title: Re: Ignore Topics
Post by: anidea on September 21, 2010, 03:36:55 PM
Quote from: Chas Large on September 21, 2010, 02:41:01 PM
Quote from: anidea on September 21, 2010, 01:53:16 PM
Hi all!

So I have this mod installed, and it looks great!  But...

200 members...I want to change their settings to "Display Quick Mod"=1, so that everyone will have the ability.

I can do a query, but I can't seem to find that field in the database?  Is there anyway to globally change their profile to have the ignore feature visible to them?
If you're running SMF 2.0 then this can be done via:
Admin >> Configuration >> Themes and Layout >> Member Options >>
Select the Theme then click Change current options for all members using this theme
Select Change on the Show quick-moderation as line and select Checkboxes. Finally click Save.
Repeat for all themes in use.

Perfect!  Thanks :)
Title: Re: Ignore Topics
Post by: rhack382 on September 22, 2010, 09:04:10 AM
Quote from: Brande on July 18, 2010, 11:00:30 AM
Quote from: Arantor on May 18, 2010, 05:14:15 AM
Bingo, now I can see the problem. The query that finishes on line 1093 is broken.

Here's the product query:
$request = $smcFunc['db_query']('', '
SELECT t.id_topic
FROM {db_prefix}topics_posted_in AS t
LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = pi.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board . '
AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
'. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
ORDER BY {raw:order}
LIMIT {int:offset}, {int:limit}',
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
'offset' => $_REQUEST['start'],
'limit' => $context['topics_per_page'],
))
);


And it's saying that it doesn't know pi.id_topic - well, here it doesn't because we never defined pi as a table alias. Should be:

$request = $smcFunc['db_query']('', '
SELECT t.id_topic
FROM {db_prefix}topics_posted_in AS t
LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
'. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = t.id_topic AND it.id_member = {int:current_member})' : '') .'
WHERE t.' . $query_this_board . '
AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
'. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
ORDER BY {raw:order}
LIMIT {int:offset}, {int:limit}',
array_merge($query_parameters, array(
'current_member' => $user_info['id'],
'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
'offset' => $_REQUEST['start'],
'limit' => $context['topics_per_page'],
))
);


Thanks a lot! Resolve my problem!

What file doe this get inserted into?  Time to cut and paste.... [;D oh yes.. Recent.php... ?]
Title: Re: Ignore Topics
Post by: anidea on September 27, 2010, 12:39:48 PM
I just recently noticed a handful of the following errors, before I make any changes, can someone confirm that the above correction is what I'm looking for?

http://www.mysite.org/smf/index.php?action=unread;board=12
Database Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IFNULL(it.id_topic, 0) = 0
AND t.id_last_msg > 5385
AND IFNULL(lt.id_msg' at line 6
File: /f5/mysite/public/smf/Sources/Recent.php
Line: 878
Title: Re: Ignore Topics
Post by: anidea on October 05, 2010, 10:20:13 AM
Well, I went ahead and made the prescribed change.  But it doesn't seem to have helped.  When I click on the New button in a child board, I get the following error message (on screen, although also under Errors):

Database Error
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IFNULL(it.id_topic, 0) = 0
AND t.id_last_msg > 6375
AND IFNULL(lt.id_msg' at line 6
File: /mysite/public/smf/Sources/Recent.php
Line: 878
Title: Re: Ignore Topics
Post by: ACAMS on October 15, 2010, 01:25:28 PM
I have SMF 2.0 RC3

I have this installed, and everything works fine until we click "Show new replies to your posts." then we get this error.

Database Error   Unknown column 'pi.id_topic' in 'on clause'
File: /home/gametechmods/gametechmods.com/forums/Sources/Recent.php
Line: 1124

Here are lines 1107 to 1124 and I don't see anything wrong


   
   if (!empty($have_temp_table))
   $request = $smcFunc['db_query']('', '
    SELECT t.id_topic
    FROM {db_prefix}topics_posted_in AS t
     LEFT JOIN {db_prefix}log_topics_posted_in AS lt ON (lt.id_topic = t.id_topic)
     '. ($can_ignore ? 'LEFT JOIN {db_prefix}ignore_topics AS it ON (it.id_topic = pi.id_topic AND it.id_member = {int:current_member})' : '') .'
    WHERE t.' . $query_this_board . '
     AND IFNULL(lt.id_msg, t.id_msg) < t.id_last_msg
     '. ($can_ignore ? 'AND IFNULL(it.id_topic, 0) = 0' : '') .'
    ORDER BY {raw:order}
    LIMIT {int:offset}, {int:limit}',
    array_merge($query_parameters, array(
     'current_member' => $user_info['id'],
     'order' => (in_array($_REQUEST['sort'], array('t.id_last_msg', 't.id_topic')) ? $_REQUEST['sort'] : 't.sort_key') . ($ascending ? '' : ' DESC'),
     'offset' => $_REQUEST['start'],
     'limit' => $context['topics_per_page'],
    ))
   );




Anybody have any idea what may be wrong?
Title: Re: Ignore Topics
Post by: Oya on October 15, 2010, 01:44:48 PM
the mod is broken and the mod author/maintainer is not interested in fixing it - it looks like its been broken for months
Title: Re: Ignore Topics
Post by: ACAMS on October 16, 2010, 07:05:29 PM
Maybe they will see this and do something....I have no clue what to even look for.
Title: Re: Ignore Topics
Post by: Oya on October 16, 2010, 07:23:12 PM
Quote from: ACAMS on October 16, 2010, 07:05:29 PM
Maybe they will see this and do something....I have no clue what to even look for.

i doubt it, the bugs were pointed out months and months ago and nothing's been done about it
i even reported the mod as unsafe before and still it didn't get dealt with
Title: Re: Ignore Topics
Post by: MS Modders Team on November 02, 2010, 11:55:18 AM
What do you mean by "as it was done by the S-M-F Modders Team"?
Title: Re: Ignore Topics
Post by: rhack382 on November 03, 2010, 04:40:03 PM
These changes did not help me much... But looking at the Mods Page there was an update on Sept. 22 - which comes after my original inquiry. 

I will uninstall old and install the newer version...
Title: Re: Ignore Topics
Post by: Oya on November 03, 2010, 05:52:35 PM
i don't think the file was updated, i think the mod was simply altered as that would have been when it changed hands to the smf modders team
Title: Re: Ignore Topics
Post by: DirtRider on November 04, 2010, 01:25:38 AM
I really just don't get it. I have installed this mod on two different forums and nothing. I did the enable Quick Moderation thing still nothing. Tried looking on the SMF default theme for RC3 still nothing. Looked in the profile settings still nothing. Looks like I am not the only one that is having major issues with it  :-\
Title: Re: Ignore Topics
Post by: rhack382 on November 04, 2010, 09:17:40 AM
It does work but you have to enable ignored topics globally:

admin->forum->boards->settings->Enable Ignore-Topics mod

The problem after install of this mod is the "new" icon when clicked on child boards in the main index yields a syntax error, but when clicking on the adjacent text it works perfectly...
Title: Re: Ignore Topics
Post by: DirtRider on November 04, 2010, 12:08:07 PM
Ok thank I did not know you needed to enable it. I did look and when I could not find anything I gave up. However if it still has this other bug maybe I will wait until that is fixed
Title: Re: Ignore Topics
Post by: Oya on November 04, 2010, 12:08:33 PM
doesn't seem to have been fixed for months :( id love this mod
Title: Re: Ignore Topics
Post by: DirtRider on November 04, 2010, 01:52:01 PM
Yeah I need to use this one pity it is not being sorted out  :(
Title: Re: Ignore Topics
Post by: Chas Large on December 06, 2010, 10:20:37 AM
Any chance this mod can be updated to RC4? It worked on RC3 but comes up with lots of errors when trying to install it on RC4. I think the coding has changed quite a bit between RC3 & 4.

Thanks

Chas
Title: Re: Ignore Topics
Post by: MS Modders Team on December 18, 2010, 01:47:54 AM
Not for RC4. But for 2.0 Final, definitely.
Title: Re: Ignore Topics
Post by: Arantor on December 18, 2010, 06:26:36 AM
Are you going to actually fix the errors in it when updating it? I'd hate to have to report this mod, again, for being unsafe, only for the report to be ignored, again.
Title: Re: Ignore Topics
Post by: ascaland on February 26, 2011, 10:35:31 PM
I have just finished fixing the errors with RC4-RC5 and have updated the mod page. If there are any problems please feel free to post here.

A lot more will be done soon such as some new features and possibly some SMF 1.1.x compatibility.
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 03:53:06 AM
Just went to install the latest RC5 version and it came up with several errors. It's a good working RC5 test forum with only a couple of mods installed. I didn't proceed.

I'll look at where the errors failed to see if any of my mods have touched those areas beforehand.
Title: Re: Ignore Topics
Post by: Spoogs on February 27, 2011, 09:50:05 AM
Installs just fine on a fresh and a fairly modded RC5 for me so... so yes one of those mods you have already edited those files
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 10:09:16 AM
Quote from: Spoogs on February 27, 2011, 09:50:05 AM
Installs just fine on a fresh and a fairly modded RC5 for me so... so yes one of those mods you have already edited those files
Thanks for confirming this Spoogs, however I have done a manual search of my Recent.php file (attached) compared to the manual install details and the two failed items mentioned above are both there and are in their original state, i.e., no other mod has touched them. Can this be confirmed please?
Strike all that, I had inadvertently left the parser set to RC2. Resetting to RC5 and the mod installs OK. Sorry folks.
Title: Re: Ignore Topics
Post by: Spoogs on February 27, 2011, 10:16:16 AM
 8)
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 10:23:41 AM
OK Installed and working but on my test forum if I click Recent unread replies I get the following error:

Database Error
Unknown column 'pi.id_topic' in 'on clause'
File: D:\EasyPHP_Site3\Sources\Recent.php
Line: 1130


[edit]
Also in the error log
http://127.0.0.1/FPF_Local/index.php?action=unreadreplies
Database Error: Unknown column 'pi.id_topic' in 'on clause'
File: D:/EasyPHP_Site3/Sources/Recent.php
Line: 1130
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 10:29:52 AM
Quote from: Chas Large on February 27, 2011, 10:23:41 AM
OK Installed and working but on my test forum if I click "New replies to your posts" I get the following error:

Database Error
Unknown column 'pi.id_topic' in 'on clause'
File: D:\EasyPHP_Site3\Sources\Recent.php
Line: 1130


[edit]
Also in the error log
http://127.0.0.1/FPF_Local/index.php?action=unreadreplies
Database Error: Unknown column 'pi.id_topic' in 'on clause'
File: D:/EasyPHP_Site3/Sources/Recent.php
Line: 1130


[edit 2] corrected above "New replies to your posts"
Title: Re: Ignore Topics
Post by: ascaland on February 27, 2011, 11:47:40 AM
Great to see the mod being used actively again. :)
Im also open for any suggestions or requests for the mod.
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 01:33:44 PM
Quote from: Chas Large on February 27, 2011, 10:23:41 AM
OK Installed and working but on my test forum if I click "new replies to your posts" I get the following error:

Database Error
Unknown column 'pi.id_topic' in 'on clause'
File: D:\EasyPHP_Site3\Sources\Recent.php
Line: 1130


[edit]
Also in the error log
http://127.0.0.1/FPF_Local/index.php?action=unreadreplies
Database Error: Unknown column 'pi.id_topic' in 'on clause'
File: D:/EasyPHP_Site3/Sources/Recent.php
Line: 1130

Further to the above I have carried out some tests.
1. Installed the mod onto a clean new test forum and it works fine, no errors.
2. Going back to the test forum, I removed all mods then reinstalled just this mod and still got the error.
3. I removed the mod and reinstalled the RC5 upgrade effectively making the forum as new with all new Source and Themes\Default files. I then reinstalled this mod and again get the error when clicking "new replies to your posts"
4. Ran all the standard dB maintenance routines and cleared the cache.

My conclusion therefore is that I have a problem with my database in some way. This database is two years old having first been a 1.1.08 version and has been upgraded through to 1.1.11 before upgrading to 2.0 RC2 then through to RC5. So something somewhere is not right with it but I don't know what to look for. When I did the RC5 upgrade I included the save backup tables so will now remove these from the dB to see if that makes any difference.
Title: Re: Ignore Topics
Post by: Arantor on February 27, 2011, 01:34:24 PM
No, it looks like the bug that was uncovered months ago with this mod still isn't fixed :(
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 01:46:32 PM
Quote from: Arantor on February 27, 2011, 01:34:24 PM
No, it looks like the bug that was uncovered months ago with this mod still isn't fixed :(
Seems that way. I dropped all the backup tables from the dB then re-ran all the maintenance functions and the error is still there. Odd that it works on a new clean install though?
Title: Re: Ignore Topics
Post by: ascaland on February 27, 2011, 01:53:48 PM
Hmm, okay I managed to replicate the error myself I will get to it.
Title: Re: Ignore Topics
Post by: ascaland on February 27, 2011, 03:00:56 PM
Alright guys, test out the new package I uploaded to the mod site. 8)
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 03:34:22 PM
Quote from: Project Evolution on February 27, 2011, 03:00:56 PM
Alright guys, test out the new package I uploaded to the mod site. 8)
No, sorry, still getting an error: I uninstalled the mod, downloaded the zip file, (btw still shows _v1 and the install shows as version 2.0 ? ) and then reinstalled it. Is the one on the mod site actually the new one? it could do with a sub version number to be sure, like 2.1 etc.

Unknown column 'pi.id_topic' in 'on clause'
File: D:\EasyPHP_Site3\Sources\Recent.php
Line: 1130


http://127.0.0.1/FPF_Local/index.php?action=unreadreplies
Database Error: Unknown column 'pi.id_topic' in 'on clause'
File: D:/EasyPHP_Site3/Sources/Recent.php
Line: 1130
Title: Re: Ignore Topics
Post by: ascaland on February 27, 2011, 03:42:57 PM
I thought the only problem was with this,
Quote from: rhack382 on November 04, 2010, 09:17:40 AM
The problem after install of this mod is the "new" icon when clicked on child boards in the main index yields a syntax error, but when clicking on the adjacent text it works perfectly...

Which should be fixed now. But I cant seem to replicate the error you keep receiving. May I ask for the steps you take which give you this error?

And yes good idea, I will add the sub version.
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 03:45:52 PM
Quote from: Project Evolution on February 27, 2011, 03:42:57 PM
I thought the only problem was with this,
Quote from: rhack382 on November 04, 2010, 09:17:40 AM
The problem after install of this mod is the "new" icon when clicked on child boards in the main index yields a syntax error, but when clicking on the adjacent text it works perfectly...

Which should be fixed now. But I cant seem to replicate the error you keep receiving. May I ask for the steps you take which give you this error?

And yes good idea, I will add the sub version.
Simply I click the "show new replies to your posts" link. Using the Default curve theme, top left.
Title: Re: Ignore Topics
Post by: ascaland on February 27, 2011, 04:10:53 PM
Aha! I see now, I had to make some adjustments to get that error showing. Time to get back to work (what is this, the third time now? :P).
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 04:18:29 PM
Quote from: Project Evolution on February 27, 2011, 04:10:53 PM
Aha! I see now, I had to make some adjustments to get that error showing. Time to get back to work (what is this, the third time now? :P).
Good luck (http://www.fiftyplusforum.co.uk/forum/Smileys/LightB/thumbup.gif)
Title: Re: Ignore Topics
Post by: ascaland on February 27, 2011, 04:22:35 PM
Ok, reuploaded and hopefully fixed for you.
Title: Re: Ignore Topics
Post by: Chas Large on February 27, 2011, 04:43:11 PM
Quote from: Project Evolution on February 27, 2011, 04:22:35 PM
Ok, reuploaded and hopefully fixed for you.
Yep, that seems to have fixed it, well done (http://www.fiftyplusforum.co.uk/forum/Smileys/LightB/thumbup.gif) (http://www.fiftyplusforum.co.uk/forum/Smileys/LightB/thumbup.gif) (http://www.fiftyplusforum.co.uk/forum/Smileys/LightB/thumbup.gif)
Title: Re: Ignore Topics
Post by: Chas Large on March 02, 2011, 12:34:59 PM
Sadly another error has cropped up.

From the forum index, click on an orange New indicator, in this case the Cinema board

(http://i880.photobucket.com/albums/ac2/Hal9000_bucket/BoardIndexNEWindicators.png)

board opens and shows "No unread topics found, click here to try all unread topics"

(http://i880.photobucket.com/albums/ac2/Hal9000_bucket/Boardnotopicsfound.png)

"Clicking here" produces this error.

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IFNULL(it.id_topic, 0) = 0
AND t.id_last_msg > 116521
AND IFNULL(lt.id_m' at line 7
File: /home/fiftyplu/public_html/forum/Sources/Recent.php
Line: 821


Back to you....
Title: Re: Ignore Topics
Post by: ascaland on March 02, 2011, 01:06:36 PM
Thanks for the heads up Chas Large. I will get to this problem when im back home in a couple hours.
Jeez I didnt think taking over this mod would be such a task. :P
Title: Re: Ignore Topics
Post by: Arantor on March 02, 2011, 01:14:20 PM
Quote from: Project Evolution on March 02, 2011, 01:06:36 PM
Thanks for the heads up Chas Large. I will get to this problem when im back home in a couple hours.
Jeez I didnt think taking over this mod would be such a task. :P

Now you know why I made mention of the bug fixes involved :P I'm glad someone is interested enough to take care of this mod though.
Title: Re: Ignore Topics
Post by: ascaland on March 03, 2011, 05:51:57 PM
Updated the package.
Title: Re: Ignore Topics
Post by: Chas Large on March 06, 2011, 11:46:55 AM
Thanks PE, that's fixed it. :)
Title: Re: Ignore Topics
Post by: Selroth on March 16, 2011, 10:27:43 PM
I'm a retard, and spent forever trying to figure out why the mod wasn't working.  Came down to $modSettings['allow_ignore_topics'] and I couldn't find where to toggle it.  Had to parse the mod to see it put it in ManageBoards.


Wouldn't this setting be more appropriate in Topic Settings or even miscellaneous mod settings?  Maybe it's just me, but I find Board settings counter-intuitive.


May also want to make a note to enable the mod in the mod info.


Hope this idea helps some!
Title: Re: Ignore Topics
Post by: TJ2011 on April 26, 2011, 12:48:31 PM
Quote from: b4pjoe on July 28, 2010, 07:02:49 PM
Quote from: Brande on July 28, 2010, 06:24:41 PM
Joe,

You need enable quick moderation in your perfil to see this mod ...

Yes, Quick Moderation is enabled as you can see by the checkboxes in the screen shot I posted.


I've installed it in RC5, and enabled quick moderation, but still cannot see it. Is it not compatible with RC5, and is there a way where (when/if I can get it to work) I can make that an option for everyone, without each user having to go into quick moderation to activate it themselves?
Title: Re: Ignore Topics
Post by: ascaland on April 26, 2011, 07:15:01 PM
The modification only allows you to set the topics to ignore in the recent posts page (unless im missing something too :P). I will update this mod with few extra things in the coming weeks.
Title: Re: Ignore Topics
Post by: TJ2011 on April 27, 2011, 03:42:30 PM
Oh ok, so topics previously are not within it's scope, even if they should in the unread posts since last visit link? And, do all users need to enable quick moderation to use it?
Title: Re: Ignore Topics
Post by: TJ2011 on April 27, 2011, 03:54:11 PM
Actually just took a look at a new topic created today, and no option to put it on ignore either?
Title: Re: Ignore Topics
Post by: Chas Large on April 27, 2011, 04:15:22 PM
Quote from: TJ2011 on April 27, 2011, 03:54:11 PM
Actually just took a look at a new topic created today, and no option to put it on ignore either?
Are you using the default theme? if not then the mod may not be enabled for the theme you use.

In the Admin > Forum > Boards > Settings section have you checked "Enable Ignore-Topics mod" ? and set a maximum number and also in Admin > Members > Permissions > General Permissions > Regular Members > General area, is Ignore Topics checked?

If neither of these are checked then no-one will see the ignore topics button at the top of the Unread Posts or New Replies lists, it does not show on the Forum / Board list of topics.

And yes, members do need to have Simple Moderation >> checkboxes enabled to be able to select the topic to be ignored.
Title: Re: Ignore Topics
Post by: TJ2011 on April 27, 2011, 04:19:43 PM
Quote from: Chas Large on April 27, 2011, 04:15:22 PM
Quote from: TJ2011 on April 27, 2011, 03:54:11 PM
Actually just took a look at a new topic created today, and no option to put it on ignore either?
Are you using the default theme? if not then the mod may not be enabled for the theme you use.

In the Admin > Forum > Boards > Settings section have you checked "Enable Ignore-Topics mod" ? and set a maximum number and also in Admin > Members > Permissions > General Permissions > Regular Members > General area, is Ignore Topics checked?

This was it ^^

Quote
And yes, members do need to have Simple Moderation >> checkboxes enabled to be able to select the topic to be ignored.

OK, will let them know. Thanks!!
Title: Re: Ignore Topics
Post by: Chas Large on April 27, 2011, 04:27:46 PM
Glad that sorted it. It's quite common where new features are added that a permission is required to use it but it's not documented. Hint hint to all mod developers ;)
Title: Re: Ignore Topics
Post by: TJ2011 on April 27, 2011, 05:11:35 PM
lol, true...thanks
Title: Re: Ignore Topics
Post by: newtoallthis on May 15, 2011, 02:23:00 PM
Have just had this ignore thread installed:-

http://custom.simplemachines.org/mods/index.php?mod=1193

Nothing at all is showing up on site and all file edits have been checked and are in place.

We have the forum default theme set.

Any ideas what may be the problem?
Title: Re: Ignore Topics
Post by: ascaland on May 15, 2011, 02:26:04 PM
Quote from: Chas LargeIn the Admin > Forum > Boards > Settings section have you checked "Enable Ignore-Topics mod" ? and set a maximum number and also in Admin > Members > Permissions > General Permissions > Regular Members > General area, is Ignore Topics checked?

If neither of these are checked then no-one will see the ignore topics button at the top of the Unread Posts or New Replies lists, it does not show on the Forum / Board list of topics.

And yes, members do need to have Simple Moderation >> checkboxes enabled to be able to select the topic to be ignored.

Have you made sure those are all checked?
Title: Re: Ignore Topics
Post by: newtoallthis on May 15, 2011, 02:55:25 PM
Quote from: Project Evolution on May 15, 2011, 02:26:04 PM
Quote from: Chas LargeIn the Admin > Forum > Boards > Settings section have you checked "Enable Ignore-Topics mod" ? and set a maximum number and also in Admin > Members > Permissions > General Permissions > Regular Members > General area, is Ignore Topics checked?

If neither of these are checked then no-one will see the ignore topics button at the top of the Unread Posts or New Replies lists, it does not show on the Forum / Board list of topics.

And yes, members do need to have Simple Moderation >> checkboxes enabled to be able to select the topic to be ignored.

Have you made sure those are all checked?

OK. I've enabled "Enable Ignore-Topics mod" and set the figure at 50 and saved the change.

I've also enabled Ignore Topics in General Permissions > Regular Members are.

But where is 'Simple Moderation >> checkboxes enabled'.



Title: Re: Ignore Topics
Post by: newtoallthis on May 15, 2011, 03:04:20 PM
Sorted. Didn't realise you meant personal profile changes. Now working, thanks.
Title: Re: Ignore Topics
Post by: newtoallthis on May 16, 2011, 07:45:23 AM
Should this mod hide ignored topics in the 'Recent Posts' Simple Portal block?
Title: Re: Ignore Topics
Post by: Chas Large on May 16, 2011, 09:03:30 AM
Quote from: newtoallthis on May 16, 2011, 07:45:23 AM
Should this mod hide ignored topics in the 'Recent Posts' Simple Portal block?
No and it doesn't hid it in the Info Centre either, it's a user function for users to ignore topics in the unread Posts and New Replies lists ONLY AFAIK. That's the way it works on my forum anyway and no-one's ever complained that ignored topics are appearing on the front page (SP Block) or in the Info Centre. :)
Title: Re: Ignore Topics
Post by: newtoallthis on May 16, 2011, 09:12:20 AM
Quote from: Chas Large on May 16, 2011, 09:03:30 AM
Quote from: newtoallthis on May 16, 2011, 07:45:23 AM
Should this mod hide ignored topics in the 'Recent Posts' Simple Portal block?
No and it doesn't hid it in the Info Centre either, it's a user function for users to ignore topics in the unread Posts and New Replies lists ONLY AFAIK. That's the way it works on my forum anyway and no-one's ever complained that ignored topics are appearing on the front page (SP Block) or in the Info Centre. :)

Thank you for the explanation.
Title: Re: Ignore Topics
Post by: DannyE on July 11, 2011, 03:08:10 PM
I'm trying to deploy this on a 2.0 (just upgraded from RC2) installation

The Package Manager stalls on the first 2 changes to Recent.php

It fails (in pre-install test) on:

Quote// Find the 10 most recent messages they can *view*.
   // !!!SLOW This query is really slow still, probably?

Those lines are in the Recent.php; I even replaced the existing lines with the 2 above mentioned by the Package Manager

and on
QuoteSELECT m.id_msg
      FROM {db_prefix}messages AS m
         INNER JOIN {db_prefix}boards AS b ON (b.id_board = m.id_board)
      WHERE ' . $query_this_board . '
         AND m.approved = {int:is_approved}
      ORDER BY m.id_msg DESC
      LIMIT {int:offset}, {int:limit}',
      array_merge($query_parameters, array(
         'is_approved' => 1,

I'm no MOD specialist (this is the second one I'm installing) but comfortable with PHP

Can I savely hit Install or should I fix something first?

TNX

Danny
Title: Re: Ignore Topics
Post by: ascaland on July 16, 2011, 10:31:23 PM
This could probably create a problem with having the topics display properly when members go to use the page. I havnt updated or made any changes to this for SMF 2 yet, so if you can, stay patient and bear with me.
Title: Re: Ignore Topics
Post by: Eclipse16V on August 05, 2011, 09:00:53 AM
Thanks for this MOD
Title: Re: Ignore Topics
Post by: yggi49 on September 05, 2011, 05:54:01 AM
Hi,

I installed this mod, and it basically works fine—good work!  I am experiencing one problem though: the "click here for all unread messages" list doesn't work properly anymore, although the "unread since last visit" list does.

Example: I am clicking "unread topics since last visit", and then read all the topics listed there.  Afterwards, this list is empty.  Now I am clicking on "click here for all unread messages"—and there, all the topics I just read are listed again.

Any ideas?
Title: Re: Ignore Topics
Post by: SSimple Team on September 26, 2011, 03:59:15 PM
2.0.1 Updated.
Please report any error and any translation are welcome
Cheers!
Title: Re: Ignore Topics
Post by: Help12345 on September 26, 2011, 04:14:50 PM
Quote from: ne.miguelito on May 19, 2008, 04:19:35 AM
An Error Has Occurred!

Sorry but no mod was found
and me
Title: Re: Ignore Topics
Post by: 4Kstore on September 26, 2011, 04:29:26 PM
Quote from: Help12345 on September 26, 2011, 04:14:50 PM
Quote from: ne.miguelito on May 19, 2008, 04:19:35 AM
An Error Has Occurred!

Sorry but no mod was found
and me

Hello Help12345, you can found the mod here: http://custom.simplemachines.org/mods/index.php?mod=1193
Grettings!
Title: Re: Ignore Topics
Post by: yggi49 on September 27, 2011, 05:26:43 AM
Thanks for the new version!  Unfortunately, it doesn't solve my problem:

Quote from: yggi49 on September 05, 2011, 05:54:01 AM
[...] the "click here for all unread messages" list doesn't work properly anymore, although the "unread since last visit" list does.

Example: I am clicking "unread topics since last visit", and then read all the topics listed there.  Afterwards, this list is empty.  Now I am clicking on "click here for all unread messages"—and there, all the topics I just read are listed again.

The list with all unread topics only gets emptied if I click "mark all messages as read"—but this shouldn't be necessary as I had already read them before...
Title: Re: Ignore Topics
Post by: 4Kstore on September 27, 2011, 10:16:36 AM
Quote from: yggi49 on September 05, 2011, 05:54:01 AM
Hi,

I installed this mod, and it basically works fine—good work!  I am experiencing one problem though: the "click here for all unread messages" list doesn't work properly anymore, although the "unread since last visit" list does.

Example: I am clicking "unread topics since last visit", and then read all the topics listed there.  Afterwards, this list is empty.  Now I am clicking on "click here for all unread messages"—and there, all the topics I just read are listed again.

Any ideas?

Hello yggi49, I tried to represent the error that comment and could not really see.
Show unread posts in the last visit since. shows all the new posts that were made since the last time you went until you loggin
Show new replies to your posts. shows the responses that were made in the posts that you created
The two links do not show the same content
Title: Re: Ignore Topics
Post by: yggi49 on September 29, 2011, 01:07:32 AM
Quote from: 4kstore on September 27, 2011, 10:16:36 AM
Quote from: yggi49 on September 05, 2011, 05:54:01 AM
Hi,

I installed this mod, and it basically works fine—good work!  I am experiencing one problem though: the "click here for all unread messages" list doesn't work properly anymore, although the "unread since last visit" list does.

Example: I am clicking "unread topics since last visit", and then read all the topics listed there.  Afterwards, this list is empty.  Now I am clicking on "click here for all unread messages"—and there, all the topics I just read are listed again.

Any ideas?

Hello yggi49, I tried to represent the error that comment and could not really see.
Show unread posts in the last visit since. shows all the new posts that were made since the last time you went until you loggin
Show new replies to your posts. shows the responses that were made in the posts that you created
The two links do not show the same content

I probably explained it badly.  Let me try to re-phrase.


For the sake of completeness, here is my list of other installed packages, though I doubt that they have any influence on this—after all, just uninstalling the "Ignore Topics" mod reverts the forum to its correct behavior.

Title: Re: Ignore Topics
Post by: anakmacan on December 26, 2011, 07:55:06 PM
How to set ignore to certain boards by default?

Some boards're automatically ignored once members registered. So members will have to UNignore it instead of checking some boards to be ignored one by one.
Title: Re: Ignore Topics
Post by: chadon on January 10, 2012, 09:32:57 AM
QuoteI probably explained it badly.  Let me try to re-phrase.

I click Show unread posts since last visit in my forum, and the function does just that.
I click on the first topic and read it.
I go back to the list—naturally, the topic I just read doesn't show up any more.
When I have read all unread topics, it says No unread topics found since your last visit. Click here to try all unread topics.
I click Click here to try all unread topics, and suddenly all the topics I have just read show up again.  This behavior is reproducibly different than without the mod installed.
Furthermore, clicking on each topic again, i.e. 're-reading' all the topics doesn't remove them from this all unread topics list.  They only disappear for good when I click the mark all messages read link.
I am having the same problem and here are the mods I have in common with yggi49.
- Google Member Map
- Ultimate Profile

The mod is installed on SMF 2.0.2
The bug appears on the default theme and on other themes with no mods installed.
Title: Re: Ignore Topics
Post by: uolj on March 02, 2012, 04:10:39 PM
Quote from: 4Kstore on September 27, 2011, 10:16:36 AM
Quote from: yggi49 on September 05, 2011, 05:54:01 AM
Hi,

I installed this mod, and it basically works fine—good work!  I am experiencing one problem though: the "click here for all unread messages" list doesn't work properly anymore, although the "unread since last visit" list does.

Example: I am clicking "unread topics since last visit", and then read all the topics listed there.  Afterwards, this list is empty.  Now I am clicking on "click here for all unread messages"—and there, all the topics I just read are listed again.

Any ideas?

Hello yggi49, I tried to represent the error that comment and could not really see.
Show unread posts in the last visit since. shows all the new posts that were made since the last time you went until you loggin
Show new replies to your posts. shows the responses that were made in the posts that you created
The two links do not show the same content

This mod was added to two different forums that I am a user (not an admin) on. Thanks!

But the above bug is definitely occurring on both forums since the mod was installed.

Please note that it is not the "Show unread posts since last visit" link that has the problem, it is the "All Unread Topics" page. They are different. The only way I know of to go to the All Unread Topics page is as yggi49 described (by reading all threads in the "Show new replies to your posts" page), or by going directly.

On this forum, here are the links:


It is the third one that is having the problem, not the first two. The first two are the ones that are modified by this mod to include the Ignore Topics change, but they are working correctly.
Title: Re: Ignore Topics
Post by: dudi_ on March 10, 2012, 09:29:47 AM
I found an error in this mod, but I am unable to find the solution.

Everything was working fine until my board reached 100.000 posts. When people exceeded this magic number when I click "show unread posts" I see lots of old topics marked as read. Reading this topic again doesn't help, topics are visible as unread all the time.

I can't find myself where is the bug...


EDIT: sorry, I see that this problem was reported.

On my site problem is only above 100k posts. Under 100k everything works fine. Maybe this information can help with solving the problem.
Title: Re: Ignore Topics
Post by: rawonam on July 15, 2012, 05:01:47 PM
Hello, I'm considering applying this mod, but there's certainly something that I need and it's missing: "Ignore topic" button on the topic display page (DisplayTemplate.php). Has anyone implemented something like this?
Title: Re: Ignore Topics
Post by: Geor'G on August 02, 2012, 09:15:42 AM
Nice mod.

Translate Russian.

<file name="$languagedir/Modifications.russian.php">
<!--// Adds the language strings used by this modification //-->
<operation>
<search position="end" />
<add><![CDATA[
$txt['ignoretopics_empty'] = 'Отменить игнорирования по всему списку тем';
$txt['permissionname_ignore_topics'] = 'Игнорировать темы';
$txt['permissionhelp_ignore_topics'] = 'Игнорирование тем, включая функции "Новые сообщения с последнего визита" и "Новые ответы на ваши сообщения".';
$txt['permissionname_unlimited_ignore_topics'] = 'Разрешить неограниченное число игнорируемых тем';
$txt['permissionhelp_unlimited_ignore_topics'] = 'Пользователи могут игнорировать темы в любом количестве (без ограничений).';
$txt['date_ignored'] = 'По дате';
$txt['ignore_topics_none'] = 'В настоящие время, нет игнорируемых тем';
$txt['ignoretopicsdisallowed'] = 'Разрешить игнорировать темы';
$txt['ignoretopics'] = 'Игнорирование тем';
$txt['ignore_topics'] = 'Игнорировать темы';
$txt['unignore_topics'] = 'Не игнорировать';
$txt['ignoretopics_info'] = 'При игнорирование тем, вы не сможете их видеть в списке тем, по опциям форума - "Новые сообщения с последнего визита" и "Новые ответы на ваши сообщения".<br />Однако вы все равно будете видеть эти темы, в списке тем раздела.';
$txt['topics_not_found'] = 'Нет тем';
$txt['unignored_all_topics'] = 'Список игнорируемых тем - очищен.';
$txt['ignored_topics_updated'] = 'Список игнорируемых тем, обновлён';
$txt['allow_ignore_topics'] = 'Включить игнорирование тем<div class="smalltext">В настоящие время, игнорируется %d тем, с числом записей - %d, у %d пользователей</div>
<br /><div class="smalltext">(<a href="%s">Все</a> - отменить)</div>';
$txt['limit_ignore_topics'] = 'Максимальное число, игнорируемых тем<div class="smalltext">Не действует на пользователей с включеный опцией - "неограниченное число игнорируемых тем" (см. Права доступа).</div>';
$txt['ignoretopics_info_limited'] = 'У вас уже есть <strong>%d</strong> игнорируемых тем. Вы можете иметь максимум - %d игнорируемых тем. Когда игнорируемых тем превысит ваш лимит, самые старые, будут заменятся новыми (Так что вы никогда не превысите свой лимит).';
]]></add>
</operation>
</file>
Title: Re: Ignore Topics
Post by: lean on September 29, 2012, 10:36:44 AM
Sorry, SSimple Team not supported in English language at the moment.
In SMFSimple.com We are looking for partners with this language to provide better support to all.
Thanks for understanding.
Title: Re: Ignore Topics
Post by: gunnymcduck on March 10, 2013, 02:21:25 PM

The buttons in the forums to ignore topics/boards is missing:

What it should look like:
(http://i.imgur.com/4yhP2.png)

What it does look like:
(https://dl.dropbox.com/u/22236609/3-10-2013%201-44-48%20PM.png)

I reverted back to the default theme, it didn't work there either.


The thing is, the in-profile buttons are there:

(https://dl.dropbox.com/u/22236609/3-10-2013%202-02-57%20PM.png)

I made sure I had the required setting under "Look-and-feel" as well:

(https://dl.dropbox.com/u/22236609/3-10-2013%202-20-37%20PM.png)
Title: Re: Ignore Topics
Post by: Nightcat on May 07, 2014, 05:08:57 PM
Quote from: gunnymcduck on March 10, 2013, 02:21:25 PM

The buttons in the forums to ignore topics/boards is missing:
Same problem
Title: Re: Ignore Topics
Post by: @rjen on July 23, 2014, 06:22:13 AM
Quote from: dudi_ on March 10, 2012, 09:29:47 AM
I found an error in this mod, but I am unable to find the solution.

Everything was working fine until my board reached 100.000 posts. When people exceeded this magic number when I click "show unread posts" I see lots of old topics marked as read. Reading this topic again doesn't help, topics are visible as unread all the time.

I can't find myself where is the bug...


EDIT: sorry, I see that this problem was reported.

On my site problem is only above 100k posts. Under 100k everything works fine. Maybe this information can help with solving the problem.

Hi, I ran into the same issue this week when my forum hit the 100.000 messages limit. Took me quite some time to figure this out.
Now this issues still is unresolved, the question arises. Is there anyone still looking for a solution? 

Obviously the code issue is in the 'recent.php' part that gets triggered when the number of messages exceeds 100.000.
If there is no support I will have to remove the MOD and find some alternative...

Thanks in advance for any reply...
Title: Re: Ignore Topics
Post by: thernlund on September 08, 2014, 02:19:25 AM
^^ I've hit the same problem.  Forum tops 100,000 posts and topics listed under "All Unread Topics" are never marked read.

I've uninstalled this mod and the problem went away.  I can't use this mod until the problem is rectified.  Judging from the fact that this issue to 2 years old, I'm going to guess that this mod is no longer maintained?


-T.
Title: Re: Ignore Topics
Post by: vbgamer45 on September 09, 2014, 04:01:45 PM
I believe you have to make an edit to recent.php to increase the 100000 limit to a higher number change it to a million
Title: Re: Ignore Topics
Post by: @rjen on October 07, 2014, 05:39:21 AM
Quote from: vbgamer45 on September 09, 2014, 04:01:45 PM
I believe you have to make an edit to recent.php to increase the 100000 limit to a higher number change it to a million

The thought crossed my mind, but the question is then, WHY is the standard SMF code using the 100.000 limit? I can update it no problem, but would there be any unwanted knock-on effects in future when we hit the 500.000 or so?

I have about 1500 users (maximum active at a given time about 65), and they will ALL use the unread all function.
Performance issues?
Title: Re: Ignore Topics
Post by: Ninja ZX-10RR on October 25, 2014, 11:39:50 AM
Got 2 errors in the error log, not really sure how he could do them, pretty sure it's related to this though.
QuoteGuest
Type of error: Undefined
http://vige.altervista.org/forum/index.php?action=recent;start=90A
8: Undefined variable: can_ignore
File: /membri/vige/forum/Sources/Recent.php
Line: 311

Guest
Type of error: Undefined
http://vige.altervista.org/forum/index.php?action=recent;start=90
8: Undefined variable: can_ignore
File: /membri/vige/forum/Sources/Recent.php
Line: 309

Could you please fix these vbgamer? Thanks in advance :)
Title: Re: Ignore Topics
Post by: margarett on October 25, 2014, 12:33:35 PM
This is not vbgamer's mod :P
Title: Re: Ignore Topics
Post by: Ninja ZX-10RR on October 25, 2014, 12:45:44 PM
I keep confusing the relative sites -_- sorry then, then I will say "mod author" can you please fix it? :)
Ty margie :)
Title: Re: Ignore Topics
Post by: Jade Elizabeth on August 20, 2015, 09:10:17 AM
Quote from: uolj on March 02, 2012, 04:10:39 PM
Quote from: 4Kstore on September 27, 2011, 10:16:36 AM
Quote from: yggi49 on September 05, 2011, 05:54:01 AM
Hi,

I installed this mod, and it basically works fine—good work!  I am experiencing one problem though: the "click here for all unread messages" list doesn't work properly anymore, although the "unread since last visit" list does.

Example: I am clicking "unread topics since last visit", and then read all the topics listed there.  Afterwards, this list is empty.  Now I am clicking on "click here for all unread messages"—and there, all the topics I just read are listed again.

Any ideas?

Hello yggi49, I tried to represent the error that comment and could not really see.
Show unread posts in the last visit since. shows all the new posts that were made since the last time you went until you loggin
Show new replies to your posts. shows the responses that were made in the posts that you created
The two links do not show the same content

This mod was added to two different forums that I am a user (not an admin) on. Thanks!

But the above bug is definitely occurring on both forums since the mod was installed.

Please note that it is not the "Show unread posts since last visit" link that has the problem, it is the "All Unread Topics" page. They are different. The only way I know of to go to the All Unread Topics page is as yggi49 described (by reading all threads in the "Show new replies to your posts" page), or by going directly.

On this forum, here are the links:


  • Show unread posts since last visit: http://www.simplemachines.org/community/index.php?action=unread
  • Show new replies to your posts: http://www.simplemachines.org/community/index.php?action=unreadreplies
  • All Unread Topics: http://www.simplemachines.org/community/index.php?action=unread;all;start=0

It is the third one that is having the problem, not the first two. The first two are the ones that are modified by this mod to include the Ignore Topics change, but they are working correctly.

Same issue here, to be more specific it's showing topics that I have myself replied to, or at least read.

Attached screenshots..the one with blue is the one that should be showing, but is not.

Title: Re: Ignore Topics
Post by: StarredSkies on July 04, 2018, 08:31:26 PM
Hello! I have been experiencing some problems with this modification. This is NOT a permissions problem(from what I can tell), as that has been double/triple/quad checked, but I am still open to checking these things upon request. Other admins, moderators, and regular users have been experiencing problems. As of right now, we use the subaccounts modification and the Reseller theme, along with 2.0.15. Anyways, here is my problem...

As of recent, I installed this mod in hopes that it could ignore topics and boards. For some users, it works just fine, but for others, it does not have the check boxes on their recent unread topics tab. We have not been able to find a specific indicator of what leads to this problem as of right now.  Any answers?
Title: Re: Ignore Topics
Post by: Arantor on July 05, 2018, 02:52:09 AM
That is likely a problem related to the fact you have subaccounts more than anything, because each sub account is its own physical account - double check all the details between accounts.

The whole implementation of subaccounts the way pretty much everyone does it is a Bad Idea(tm) for so many reasons, but not least problems like this.

In the case of ignoring boards, that's a core feature but you'd have to set it up once per subaccount.
Title: Re: Ignore Topics
Post by: vbgamer45 on October 09, 2021, 06:44:04 PM
Version 2.4
Updated with support for PHP 7.4+ removed create_function call
Title: Re: Ignore Topics
Post by: Melonking on September 13, 2024, 08:17:48 AM
I'd really like to use this mod; but is there a way to just add an "(Un)Ignore This Topic" button along side the Reply and Notify buttons on the topics page? That seems like it would be a much more intuitive place to put it, instead of depending on the quick moderation system that doesn't work on some themes.

Iv had multiple people request the ability to ignore topics, so I'm surprised there are not more mods focused on this!

Something along the lines of this: (Note the new ignore link)
(https://nonit.me/external/images/ignore-idea.png)