Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=1491)
Obsolete
Ahh something I wished was in the core. :) Nice job!
This is a very minor modification but I just want to add a comment of explanation.
I sometimes open up a topic for viewing and then I forget which posts are new and which I have already read. This mod tags the titles of the unread messages with the familiar "new" tag, to show you which ones you are seeing for the first time.
Thanks.
Quote from: ShaDow82x on November 06, 2008, 06:59:16 PM
Ahh something I wished was in the core. :) Nice job!
It's funny that we all have different reactions. This was so minor a change that I had some reservations of even submitting the mod, but yet you evidently love it! :D
Actually I don't see why it couldn't be part of the core code. It seems reasonable to write the code this way, costs little or nothing yet improves the utility of the read out.
It will be interesting to see which mods make the 2.0 gold release, if any. I understand the words "feature locked" but some changes are so trivial to implement. It's harder to encode the mod package because it must work over multiple versions of SMF. The actual code changes must only work with the release.
Quote from: evil-angelist on November 06, 2008, 07:03:08 PM
Thanks.
Hiya EA! You must think a lot like me since I see your comments in many of my mod topics. I like to think that we agree simply because we are both reasonable and thoughtful people. :)
Quote from: Deprecated on November 06, 2008, 07:07:47 PM
Quote from: evil-angelist on November 06, 2008, 07:03:08 PM
Thanks.
Hiya EA! You must think a lot like me since I see your comments in many of my mod topics. I like to think that we agree simply because we are both reasonable and thoughtful people. :)
Your mods are the best that are currently being made, I dont post here much but just showing some appreciation and keeping up the encouragement to make more. ;)
Very cool.
Thanx.
Well thank you everybody. The mod makes sense to me too. One nice thing about these small mods, they cover such a small area that they are very unlikely to conflict with any other mod packages.
I hope those aren't famous last words. :)
In guests shows the "new" icon permanently...
Quote from: dimdom on November 07, 2008, 09:58:11 AM
In guests shows the "new" icon permanently...
I was unable to reproduce your observation.
Quote from: Deprecated on November 07, 2008, 03:08:29 PM
Quote from: dimdom on November 07, 2008, 09:58:11 AM
In guests shows the "new" icon permanently...
I was unable to reproduce your observation.
I have the same problem than dimdom, the "new" icon shows in every message of the page, not only in the new message.
Here two images so that you can see the error:
Please try out the upgraded package that I've attached to my post. I've fixed it so that guests should never see the "New" tag.
If this works for you I'll replace the 1.0 version with this new 1.1 version. Let me know how it works!
No, the problem continues, the "new" icon continues appearing as much for the companies as in all the messages of the page although they are not new.
Brilliant idea for a mod yet again Deprecated 8)
Thanks mate :)
Sabre, it is working now.
No "new" for guests. :)
Okay, evidently I was overly tired when I updated that and I used the $message version of the variable instead of the $context version...
I've fixed the file on the Mod Site so go ahead and please download and install that modification instead. Please let me know if the one on the site works okay for you.
Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=1491)
Thanks Sabre. Please delete your file attachment so as to not confuse people.
hahaa thats 2 minds overly tired.
Ive just woken up at the keyboard, and noticed your comment.
Because of a statement I read of yours, about you repackaging mods when they fail the install etc etc I thought that was a brilliant idea, and took that advice on board.
Since I tore my previous site down... what better time to try than on a fresh site.
Anyway, instead of just mentioning $context, I uploaded my package ?? lol
Luckily thats the only thing to touch that area so far, or I couldve made a lil mess of someones forum. lol
Sorry about that mate, and deleted.
4.20am now mate, so Im back off to la la land... zzzzZZzzzz
But after I try something.
Great when you dream you're tweaking a mod, and wake up wanting to try it lol
That's no problem Sabre, and you're one of my online buddies. I appreciate your help, particularly when I'm asleep at the code. :)
Anyway the package is fixed now, and is available at the Mod Site. Anybody who has any further problems should (1) verify they have the latest version, and if they do (2) post here in the support topic.
Thanks, working now. T_T
Thanks for the report back. I feel better knowing there are no open trouble reports. Have fun! :)
Not sure if it was there before I installed/uninstalled this mod but when I went through the Display template it looks to me like there are already plans in place to have a new message marker. It looks like the first new message is not assigned the 'topborder' class to the div which makes me think they have plans to have some other marker put in there. I did add my own code to make it put a red top border on the first new post but it seems to always class the last post of read threads as a new post.
I think I may have found a problem...
If you click the Mark All Messages As Read button on the board index, ALL messages in EVERY thread show the "New" icon.
Any idea why that might happen?
ETA: Seems to do the same thing if you click the Mark Read button in a specific forum...
I installed mod manualy but, have a error
Parse error: syntax error, unexpected T_NEW, expecting ',' or ';' in .../Themes/default/Display.template.php on line 378
369: </div>
370: </td>
371: <td valign="top" width="85%" height="100%">
372: <table width="100%" border="0"><tr>
373: <td valign="middle"><a href="', $message['href'], '"><img src="', $message['icon_url'] . '" alt="" border="0" /></a></td>
374: <td valign="middle">
375: <span style="font-weight: bold;" id="subject_', $message['id'], '">
376: <a href="', $message['href'], '">', $message['id'], '</a>
377: // New message? If so, show the new.gif image after the message title, but not for guests.
378: if ($message['new'] && $context['user']['is_logged'])
379: echo '
380: <img src="', $settings['images_url'], '/', $context['user']['language'], '/new.gif" title="', $txt[302], '" alt="" />';
381: echo '
382: </span>';
At the end of line 376, try adding this ';
Hopefully that fixes your issue.
For future reference, it would be a good idea to read [THIS] (http://docs.simplemachines.org/index.php?topic=494) :)
Sabre™, thanks for help :)
My pleasure netoya.
Enjoy :)
Quote from: probinson77 on November 18, 2008, 11:39:22 AM
I think I may have found a problem...
If you click the Mark All Messages As Read button on the board index, ALL messages in EVERY thread show the "New" icon.
Any idea why that might happen?
ETA: Seems to do the same thing if you click the Mark Read button in a specific forum...
I am noticing the same problem any idea on a fix for this yet?
I had this working fine on Beta 4, now im on RC1 in the topic view its fine but when reading a post i get 3 new img's next to the new post.
How can i resolve this?
Hey there D,
For some reason, in my installation the word "New" shows but not the image. Any thoughts?
Flap
Old I know, but meh :P
@ mattchewone
Just a guess, but check for duplicate code in your display.template.php
@ Flapman
Is this via a custom theme?
If so, change this section ['images_url'] to ['default_images_url'] in your custom themes display.template.php
Hi guys
Please see this topic for some background on my issue - http://www.simplemachines.org/community/index.php?topic=310444.0
This problem is driving me nuts. Every time I visit a topic it has the new image on every single post. Obviously if I uninstall this mod they disappear but I really really like this mod (it should be a core feature).
Does anyone have any ideas what might be causing this and how to fix it? If it's a conflict with another mod I don't hold out much hope, I have 90+ installed on my 1.1.9 forum.
This only started happening about 3 weeks ago and I noticed it after the config changes you can read about in that topic I linked to.
Please help!!!
Mate, I'd love to say I could help you with this, but I have no idea why your forum is doing this.
So to "Mark all as read" isnt working for you.... just a shot in the woods, but have you tried running your maintenance options?
Are you using version v1.1 of this mod?
I tried your changes made in your other thread, and couldn't replicate your issue.
May I have a look at your display.template.php? <~~just curious ;)
I'll check back tomorrow, as it is fairly late here.
Cheers :)
Hey Sabre
Yeah mark all as read doesn't work, except for genuinely new unread posts.
Using v1.1 of the mod, I even uninstalled it (several times) and download a fresh copy from the mod site.
Run all my maintenance options. Mate, I've tried EVERYTHING that I can think of.
It's really weird - when I read a thread with new posts, all the posts will show the new image. If I open that thread again on the same login they're gone (unless there are more new posts, which will show the image), but later on (probably on a fresh login) they're back again. It's bizarre and it's driving me frickin' nuts.
Thanks for any help you can offer, here's the file. I'm 100% sure the mod edits are correct.
Cheers
lol I had no doubt your edits were indeed correct, I was hoping I could see if 1 of your 90+ mods were effecting the attitude of this, or the portal you were using, but again I could not replicate your error.
Anything I mention would be just reaching in the dark, trial n error, and Im sure you would have already done most of what I'd suggest. Such as disabling and enabling the "hide" mod you have installed, then each one until you find one that conflicts etc...
Sorry mate, but it seems Im gonna have to leave this for one of the more experienced to look at.
Besides returning your forum/db back to the state it was before your changes(saving your members and messages tables of course lol), then Im out of other thoughts.
Good luck buddy, and I'll watch your progress and see how you go.
regards
Thanks Sabre. I'm gonna have to do some super-sleuthing. Some small change (perhaps nothing more than a ' or ; or /) has caused this. I've uninstalled the 2 or 3 mods I'd installed in the days immediately leading up to this and I've pored over the code in a couple of templates comparing it to slightly earlier versions...to no avail.
I have another error that's giving me the ******s too - http://www.simplemachines.org/community/index.php?topic=305378.0
If I can fix these two I'll be very happy.
Still no joy with this issue. Every post in every thread on the entire board shows the new image. After I've viewed a topic they will go away only to return at some point.
Like probinson77 & oridyne above, if I click Mark ALL messages as Read on the main index or mark read in a board then the bloody things return...it's like the EXACT OPPOSITE of what should happen!
Deprecated, I know you still read these boards occasionally and Sabre, you've been a tremendous help in the past - do you have ANY more ideas?
As much as I love this mod, I've had to uninstall it. I'd really like to have it back, but not at the current cost of 30,000 new images on my forum.
On the technical side - the code for this mod is so simple (and small) I just know it's not the mod causing the problem. Something else is, I'm sure of it. Either another mod, a setting or perhaps something in upgrade code (I think I originally installed this on 1.1.6).
It's really weird how marking all as read seems to trigger the return of the image...like I said, the opposite of what SHOULD happen. The even weirder thing is that actual real new messages work normally....i.e. when there is a new message in a topic I've looked at recently that doesn't have the new image on any previous posts then the new image will show on the legit new message. All other "show unread posts" and associated functions work properly too.
Rant over. I wish I could fix this. Now more cos I hate being beaten than anything else.....
Will there be an update of this for SMF 2 RC2?
This installed and worked in RC1.2, and my users are missing it now that I have RC2 installed.
Thanks!
ok i am using a theme called 2nd and installed this
on the theme there is no image just the word new that is if i view the page in firefox if i view the page in i.e. there is the word NEW bit a box woth a red x in it
it seems like the image is missing or something
Updated package for RC2 attached.
Will remove on request/update.
sattninja, see if your theme has an 'english' folder in your 'images' folder. If so, is the new.gif in there?
If the folder doesn't exist, try copying it in there from your default theme.
i do have the image in there but like said it just shows the word new
what do i do with this update how do i install it
The update is for SMF 2.0 RC2, so people using that version can install this mod also.
Could you attach your display.template.php mate, and I'll have a look at the code.
At the moment, my mind is blank as to why it isnt showing for you.
here is the php and a screen shot
(http://img255.imageshack.us/img255/3371/newt.jpg)
Are you sure that's the correct template buddy?
The mod wasn't installed in it, and it is for smf1.1.x not smfRC2.
I've added the edits into this template anyhow, let me know how it goes :)
sorry wrong topic actially the new button is still not working
(http://img137.imageshack.us/img137/5766/2capture.jpg)
i have attached another trmplate.php and my styles.css
For what have you attached them templates?
This mod does not use those templates.
Quote from: sattninja on December 04, 2009, 01:37:36 PM
.... the new button is still not working
Have you tried the template I attached? :)
i just installed your template in my theme and the default theme folder and it is still the same i am attaching my display template for you to look at this is the one out of my theme 2nd
Here you go :)
If this doesn't work, and you've checked that your new.gif is within your images/english folder(both your default and custom theme), then the issue lies somewhere else, and I have no idea where.
Good luck with this one though.
neither worked and image files are there thats ok i will live with it
Sorry I couldn't be of more assistance mate.
Maybe somebody will see this thread and know what is going on.
All the best :)
Excellent mod.
We likes it, me preshussssss. (http://t2.gstatic.com/images?q=tbn:5OmqUhgE45i0JM:http://www.fordite.com/Images/Fordite.com%20pics/Copy%20of%20gollum.jpg)
Great mod.. Thanks Sabre for making it compatible for RC2..
My pleasure mate :)
Deprecated has been updating a few of his mods for rc2, so feel free to check out his other ones if they offer something you'd need.
Enjoy :)
@ sattninja
One more thing you could try buddy, in your themes images folder, copy the english folder and rename it to english-utf8.
Since you've copied the folder and its content, the new.gif should be within it.
That is, I'm assuming your theme(custom) ONLY has the new.gif within. That is all you need in the english-utf8 folder
See if that does anything.
Cheers :)
FYI, tests fail under 2.0 RC4 (previsouly worked under RC3).
Would be nice for an update, thanks!
Quote from: imrich on January 07, 2011, 12:54:18 PM
FYI, tests fail under 2.0 RC4 (previsouly worked under RC3).
Would be nice for an update, thanks!
Same with 2.0.2. Don't feel like having to manually add this into my site that I mod (prefer to have it automated), but I might have to since there hasn't been an update to this mod in a long time. :(
The only reason it fails, is because the line it looks for, has ONE extra space where the space isn't there in the file. Just had to clean one extra space in the install xml file.
in the file it has
Find
<a href="', $message['href'], '" rel="nofollow">', $message['subject'], '</a>
when it should be
Find
<a href="', $message['href'], '" rel="nofollow">', $message['subject'], '</a>
Try the attached package, will work for all versions of 2.x.x
Thanks man! Just installed that fix and it's working perfectly. :) Really appreciate it. :)