Simple Machines Community Forum

General Community => Site Comments, Issues and Concerns => Topic started by: Goosemoose on February 19, 2005, 02:45:41 AM

Title: Bookmark Mod
Post by: Goosemoose on February 19, 2005, 02:45:41 AM
Any chance of getting a bookmark mod installed on this site? I, like many others have heavily modified my site based on code hacks, mods, etc, and every time there is an update that requires us to redo all this it's hard to recreate the steps. If we had that mod I could bookmark those threads so I could find them quickly and easily. I started to write them down but often people create updates for the new versions of smf which could be quickly found as well.
Title: Re: Bookmark Mod
Post by: kriskd on May 17, 2006, 11:26:58 AM
I support this as well.  There is so much info on this site to keep track of.  I'm using notifications to "bookmark" important threads now, but I don't really care to get e-mail notifications when there is a new post on those topics.  I just need a way to keep track of things here.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 18, 2006, 06:11:03 AM
working on it!!!!!, getting cool people, hold on, it will be released in a couple of days!!!!!

the bookmark page:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.phpscripters.net%2Fpics%2Fbookmark.jpg&hash=1e387eec0be8805cfb275e61b362cf2c96beb5ee)

added bookmark message:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.phpscripters.net%2Fpics%2Fbookmark_add.jpg&hash=37e7da151e03ea2073e3871a29d2d36429c7f646)

bookmark button:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.phpscripters.net%2Fpics%2Fbookmark_button1.jpg&hash=97c8c984f8ade82e978f7a1bf28744a40a20c2df)

allready bookmarked
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.phpscripters.net%2Fpics%2Fbookmark_failed.jpg&hash=440227d2fd6f7d341ecf538fbf86e69dd3baca97)

topic that no longer exists
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.phpscripters.net%2Fpics%2Fbookmark_auto_delete.jpg&hash=b2430b98db72a1dd8cb177af55f2ceb63998ff0d)


Title: Re: Bookmark Mod
Post by: Zorn on May 18, 2006, 07:49:56 AM
great job!!
Title: Re: Bookmark Mod
Post by: Leipe Po on May 18, 2006, 08:41:53 AM
well, wait untill its finnished...
Title: Re: Bookmark Mod
Post by: snork13 on May 18, 2006, 06:47:15 PM
Looks Cool, how's it coming:)

-Snork13
Title: Re: Bookmark Mod
Post by: Leipe Po on May 18, 2006, 06:49:43 PM
good, good, only need to add a page refresh after a user deletes a bookmark, otherwhise it says its deleted, and it is deleted, but the page does not update, so its still showing, can i just use: header(location: blaat) or has smf a special function for that(redirectexit?)
Title: Re: Bookmark Mod
Post by: Tony Reid on May 18, 2006, 06:59:23 PM
Good going Leipe Po,

I've missed this ever since we moved over from the YabbSE supprt site.

It will be great to bookmark things - and especially be usefull to find things again, what with the  the poor performance of the search function here.

Title: Re: Bookmark Mod
Post by: Leipe Po on May 18, 2006, 07:06:46 PM
if they are willing to use it!, but hey, its nice to do, i was looking for a mod to get my attention, its a good first practice and would be my first mod for smf, if recieved well, i'm planning of making more...
Title: Re: Bookmark Mod
Post by: Jorin on May 19, 2006, 03:20:31 AM
Looks great!  :D Will be very happy if this will be a modification soon. Can be test person, if you need some and can translate the language files to german...  ;)
Title: Re: Bookmark Mod
Post by: Leipe Po on May 19, 2006, 03:58:47 AM
well things are allmost ready, putting the last toutches on the code, then need to build the xml file,
this mod would be a rc2 exclusive, maybe someone else can port it to 1.0.7,
as for multi language support i will see what i can do...
this is the first time i need to build a .xml, so lets cross our fingers...
Title: Re: Bookmark Mod
Post by: Goosemoose on May 20, 2006, 12:07:14 AM
Looks awesome Leipe Po. Let me know when you finish it and submit it so I can test it out and approve it.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 20, 2006, 03:05:31 AM
sure thing, going to build the xml package right now, hope i dont forget anything...

this is the first time i'm giving back to the community, a real proud moment for me, even my girl has catched the smf flue from me: http://www.mugje.com/ (dutch site)  :D
Title: Re: Bookmark Mod
Post by: Leipe Po on May 20, 2006, 10:43:01 AM
is submitted to the database, please note that there were someproblems with the mod, eldacar and i discussed this and agreed the package manager had a problem, and since my 3(!!!) others hosts, doenst allow all files to be writable, i really cant test if its just my localhost or not,

[bug]
Bookmark.template.php is moven but left empty.

[fix]
unzip the package, and copy and paste all the code inside to the empty file.

please also see readme.txt and ToDo.txt,

thank you, Leipe_Po
Title: Re: Bookmark Mod
Post by: Vinspire on May 20, 2006, 02:17:40 PM
Kewl. Would love to have this mods in my site  ;D ;D ;D :D

Hopefully the bookmark page interface would look more kewl once it is released.  :P :P :P
Title: Re: Bookmark Mod
Post by: Leipe Po on May 20, 2006, 02:57:50 PM
it is released, only it needs to reviewed by a someone on the modteam,
still needs some work, but the base is set for a potentialy great mod...  ;D
Title: Re: Bookmark Mod
Post by: winrules on May 20, 2006, 05:54:39 PM
Quote from: Leipe Po on May 20, 2006, 02:57:50 PM
it is released, only it needs to reviewed by a someone on the modteam,
still needs some work, but the base is set for a potentialy great mod...  ;D
Can't wait to see it. I'm also waiting for approval :)
Title: Re: Bookmark Mod
Post by: Leipe Po on May 22, 2006, 10:19:19 AM
still waiting voor mod review, hope its ok, if not, i hope they also gonna inform me about that, but i hope it will be reviewed before 1.5  :P
Title: Re: Bookmark Mod
Post by: winrules on May 22, 2006, 04:41:26 PM
Quote from: Leipe Po on May 22, 2006, 10:19:19 AM
still waiting voor mod review, hope its ok, if not, i hope they also gonna inform me about that, but i hope it will be reviewed before 1.5  :P
Yeah, it takes a while :(
Title: Re: Bookmark Mod
Post by: JayBachatero on May 22, 2006, 05:26:06 PM
Quote from: Leipe Po on May 20, 2006, 10:43:01 AM
is submitted to the database, please note that there were someproblems with the mod, eldacar and i discussed this and agreed the package manager had a problem, and since my 3(!!!) others hosts, doenst allow all files to be writable, i really cant test if its just my localhost or not,

[bug]
Bookmark.template.php is moven but left empty.

[fix]
unzip the package, and copy and paste all the code inside to the empty file.

please also see readme.txt and ToDo.txt,

thank you, Leipe_Po

Are you by any change using Ark or command line to create the archive?
Title: Re: Bookmark Mod
Post by: Leipe Po on May 22, 2006, 05:43:45 PM
nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?
Title: Re: Bookmark Mod
Post by: winrules on May 22, 2006, 06:03:22 PM
Quote from: Leipe Po on May 22, 2006, 05:43:45 PM
nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?
Could you upload it to your own site so we can use it before it's approved?
Title: Re: Bookmark Mod
Post by: JayBachatero on May 22, 2006, 06:08:10 PM
Quote from: Leipe Po on May 22, 2006, 05:43:45 PM
nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss
I ask because I am having the same problem when I create an archive on Linux.  When passed to SMF it creates an empty file.  Owdy had the same problem with one of his theme.

Quote
edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?
No I have't looked at it.  Can't download it till it's approved.  Looking good though.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 22, 2006, 06:22:28 PM
Quote from: winrules on May 22, 2006, 06:03:22 PM
Quote from: Leipe Po on May 22, 2006, 05:43:45 PM
nope, winrar, normal compression level,
i also had problems with context, didnt pace tabs or left blank lines in files, so the package manager couldnt find em, good old notepad did the trick for me!,

programming php, no problem!!!

useing a package manager, pain in the *ss

edit:
btw jay, you had a look at the code?
the thing is i really want to know if the code base is right, so i can develop further on it, or do i need to adjust something?
Could you upload it to your own site so we can use it before it's approved?
well i could do that, but whats the point to having sutch a system at smf,
this is my first mod that gets released, that why i am that ciorious of how they like the coding, and thats also the reason that i dont release it on my site, i dont want you getting hacked and its my fault,
when i get more confident that my coding style meets smf standarts, i will pre-release mod(have some big ones in mind), but this as a first timer... nah...
Title: Re: Bookmark Mod
Post by: Goosemoose on May 22, 2006, 11:53:22 PM
This mod has been approved and can be viewed here: http://mods.simplemachines.org/index.php?mod=350

Leipe Po, I fixed the bookmark.php problem. I fixed a few things so I'm not exactly sure what it was that fixed it. I believe it was the fact that your mod was within a folder in the zip. You were also missing CDATA for your readme inline. Anyways, it looks great, installs great, and I will be putting it on my own board soon ;)
Title: Re: Bookmark Mod
Post by: Goosemoose on May 23, 2006, 12:01:08 AM
One more thing. You should think about making it look similar to the notifications page, and increase the font size for the second column.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 02:12:11 AM
what do you mean, that its asks if you really want to add a bookmark? before its added?

thank you allot for fixing up some stuff, never thought that its creates a new folder for it, but glad its just a simple thing!!!, what other stuff did you changed? i'm curious!!!  :P

but hey, my first mod is approved!!!! thanks allot, this calls for a little celebration!!!!

*Leipe_Po does the happy dance*
Title: Re: Bookmark Mod
Post by: sbarnes on May 23, 2006, 04:00:48 AM
What a great mod, works really well apart from one main problem on my setup. Not sure if this a problem with the mod or a conflict with one of many other mods.

When I add a topic to the bookmarks, it adds the first post and also all replies to that post. So for a topic that has say 20 replies, I get the first post plus 20 RE: the first posts in the bookmarks.

If I can get that sorted I would be very pleased. Any ideas?
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 04:13:27 AM
ife replyed to your post on the mods and packages board, pleas adress the post there  :)
Title: Re: Bookmark Mod
Post by: kriskd on May 23, 2006, 05:34:00 AM
Leipe Po -- congrats on completing your first mod!

Goose Moose -- your link to the mod didn't work for me.  ???
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 05:36:42 AM
yeah i accedenly deleted the mod, yeah i know, how stubid can you be, huh?

my greatest appologies, there were some bug's that needed sorted out, they are now corrected(version 1.2)
only dont know if they can un-delete it,

sorry for my n00bie-ness,

Leipe_Po
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 09:48:39 AM
i am really sorry for bouncing a topic this early,
but could somebody correct my mistake, i cant, cause i dont have right, or should i submit it again to the mod site?, cause now people have buggy bookmark, not just me  :(
Title: Re: Bookmark Mod
Post by: Thantos on May 23, 2006, 09:58:29 AM
Restored.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 09:59:05 AM
thank you, i you were i woman, i would kiss you!!!  :-*
Title: Re: Bookmark Mod
Post by: sbarnes on May 23, 2006, 10:10:39 AM
Excellant, works a treat. Thanks for your hard work.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 10:13:50 AM
no problem, just wait whats comming!!!!
i should be carefull not to make it to bloated....
Title: Re: Bookmark Mod
Post by: Goosemoose on May 23, 2006, 03:53:16 PM
Leipe Po, all the changes where in the main package file. Just compare it to your version.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 07:21:32 PM
thank you Goosemoose and Thantos for your support!!!,
if you dont mind, i like to stay a while here if thats ok with you guy's  :P
Title: Re: Bookmark Mod
Post by: Thantos on May 23, 2006, 07:25:06 PM
I dunno.... Did you bring ale and wenches?
Title: Re: Bookmark Mod
Post by: Leipe Po on May 23, 2006, 07:26:50 PM
Quote from: Thantos on May 23, 2006, 07:25:06 PM
I dunno.... Did you bring ale and wenches?

what is ale and wenches?

i can code, and donate some good italian wine and food....



.... and cookies offcource
Title: Re: Bookmark Mod
Post by: Goosemoose on May 23, 2006, 08:46:23 PM
Hmm cookies..... Ok, I'll be in Italy in a month so I'll make sure to stop by and pick mine up.
Title: Re: Bookmark Mod
Post by: Leipe Po on May 24, 2006, 03:34:57 AM
sure thing we are there in week 31 and 32  :D
Title: Re: Bookmark Mod
Post by: Leipe Po on May 24, 2006, 10:53:44 AM
ohh and is this mod going to be implemented on this forum, or does it need more options?
if so, witch ones?....
Title: Re: Bookmark Mod
Post by: Goosemoose on May 24, 2006, 09:29:20 PM
More than likely it would not be. The goal is to keep this forum as close to the default as possible so people don't think certain items are included in the forum itself, that aren't.
Title: Re: Bookmark Mod
Post by: mytreo on May 24, 2006, 09:35:41 PM
nice mod leipe po i have been waiting for this since the last bookmark mod vanished.

Will you be making it compatible with 1.0.7? If not then I'll take a look and if I do it I'll send you the modifications.

Chris
Title: Re: Bookmark Mod
Post by: Leipe Po on May 25, 2006, 05:33:59 AM
thank you, hope you like it,
i will look into into version 1.0.7 in weekend, dont have time right now,
if you make it compatible pleas let me know on time,
also if you do that, please add you credits to the readme file,
and i will add them to the mod site then  ;)

Greetz Leipe_Po
Title: Re: Bookmark Mod
Post by: Vinspire on May 25, 2006, 05:44:21 AM
where can i download this mod ?  :o :o :o
Title: Re: Bookmark Mod
Post by: Leipe Po on May 25, 2006, 02:16:16 PM
Quote from: Goosemoose on May 24, 2006, 09:29:20 PM
More than likely it would not be. The goal is to keep this forum as close to the default as possible so people don't think certain items are included in the forum itself, that aren't.

so why did you request it then ???
Title: Re: Bookmark Mod
Post by: Grudge on May 25, 2006, 08:04:35 PM
Leipe Po,

I'm sure you appreciate if we were to dsire such a mod here we'd write it ourselves to ensure it's properly optimised. As it is running mods on the site is a hastle (We have one or two) so it's unlikely we would run it. That said it's good to see you taking an often requested feature and making it real. Personally I'd have adapted the notification table in some way but i guess I look at things from a central as opposed to a mod perspective. Well done - it's nice!!

Grudge
Title: Re: Bookmark Mod
Post by: Leipe Po on May 26, 2006, 11:33:21 AM
glad you like it, wait till 1.5 , upcomming versions will have some new features like pagination and order by name, i was also thinking of a most clickt thingy, and a plugin for the Most bookmarked topic, but donno if that would be bloat or not,

but thank you,

Leipe_Po
Title: Re: Bookmark Mod
Post by: Goosemoose on May 26, 2006, 01:06:51 PM
I requested it because I wanted to use it on my site, http://www.goosemoose.com ;)
Title: Re: Bookmark Mod
Post by: Leipe Po on May 26, 2006, 01:58:08 PM
ok well hope you like it!!!  :)
and feel free to review it :P
Title: Re: Bookmark Mod
Post by: richardfranks152 on June 14, 2006, 03:00:13 PM
Like the mod :)

only thing i might add would be that maybe you could add a function that told you if they had new posts. Kinda like new replies to topics you've posted in?

Just a suggestion - I like it though :)
Title: Re: Bookmark Mod
Post by: zackman2002 on July 01, 2006, 01:10:05 AM
Is this mod compatible with 1.0x yet?  Thanks.