Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: dwd2000 on April 21, 2009, 11:22:35 PM

Title: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 21, 2009, 11:22:35 PM
Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=1788)

Fieldset Quotes

Yes, this looks a lot like Balloon-Shaped Frame Quote (http://custom.simplemachines.org/mods/index.php?mod=1701) by hhy89 (http://www.simplemachines.org/community/index.php?action=profile;u=160298), but uses the html tag "frameset" instead of images.

You will need to SUCCESSFULLY uninstall "Balloon-Shaped Frame Quote", Fieldset Quotes 1.0
or any other mod that alters quotes in your forums and/or personal messages before installing "Fieldset Quotes 1.1".

INTERNET EXPLORER USERS WILL SEE SQUARE CORNERS (another reason to use something else)


Unfortunately, I neglected to test this on Internet Explorer (IE) before releasing version 1.0.
I've been using Firefox for quite a while and I assumed IE would read it properly, but I was wrong.
I did some homework before making changes and releasing version 1.1 and fixed a few things IE was screwing up.
IE users will continue to see square corners. There are ways to do it, but I want to keep this
as simple as possible and I'm not going to bend over backwards for IE. 

To uninstall Fieldset Quotes 1.0:
Use the normal uninstall routine, then
manually remove the Fieldset Quotes section from the style.css at the bottom.
(won't uninstall automatically - sorry) (fixed in version 1.1)
Fieldset Quotes 1.1 will install the section near the top.

This is the section in the "style.css" that you can edit to suit your tastes.
Quote/* These are the settings for the Fieldset Quotes. */
/* Edit to your liking. */
/*At this time Internet Explorer users will ONLY SEE SQUARE CORNERS. */
fieldset {
    position: relative;
    margin-top:5px;
   border-radius: 8px;
    -moz-border-radius: 8px;
   -webkit-border-radius: 8px;
    padding:20px;
   border: 2px solid red;
   background-color: white;
}
/* The background colour in the legend will fill the whole legend */
/* You CAN have a different colour than the fieldset */
legend {
    position:absolute;
    top: -.7em;
    left: .5em;
   border-radius: 8px;
    -moz-border-radius: 8px;
   -webkit-border-radius: 8px;
    background-color: white;
    border: 1px solid red;
   padding-left: 5px;
   padding-right: 5px;
   padding-bottom: 1px;
}
/* End of Fieldset Quotes. */


Blah blah stuff:

I am more of a tweaker than a coder, so it is quite an accomplishment for me to actually submit something other than an avatar pack.

This mod is one way of giving something back to the SMF community for their support.

Thanks and enjoy.
Title: Re: Fieldset Quotes
Post by: robbie93 on April 22, 2009, 01:13:21 AM
Cool mod  :D

I am having a problem with the main body of the quote box,  I installed the mod with no probs,  yet the main body is square and not rounded like as the screen shots show on the mod page,  I have also tried the fix for this ( as posted above ) and still the quote box appears square not rounded at the edges,  the main box appears square,  viewed both in ie and ff before and after the fix.

http://robbie93andhotchildxox.com/themesite/index.php?topic=8.msg35#new

Thanks.  :D
Title: Re: Fieldset Quotes
Post by: dwd2000 on April 22, 2009, 01:32:09 AM
Quote from: robbie93 on April 22, 2009, 01:13:21 AM
Cool mod  :D

I am having a problem with the main body of the quote box,  I installed the mod with no probs,  yet the main body is square and not rounded like as the screen shots show on the mod page,  I have also tried the fix for this ( as posted above ) and still the quote box appears square not rounded at the edges,  the main box appears square,  viewed both in ie and ff before and after the fix.

http://robbie93andhotchildxox.com/themesite/index.php?topic=8.msg35#new

Thanks.  :D

I also noticed there is no border around the legend on your test site. (using Firefox)
At the moment, I'll try to find out why the border isn't showing up.

Looks like I have some homework to do.  >:(
Title: Re: Fieldset Quotes
Post by: robbie93 on April 22, 2009, 01:37:56 AM
Quote from: dwd2000 on April 22, 2009, 01:32:09 AM
Quote from: robbie93 on April 22, 2009, 01:13:21 AM
Cool mod  :D

I am having a problem with the main body of the quote box,  I installed the mod with no probs,  yet the main body is square and not rounded like as the screen shots show on the mod page,  I have also tried the fix for this ( as posted above ) and still the quote box appears square not rounded at the edges,  the main box appears square,  viewed both in ie and ff before and after the fix.

http://robbie93andhotchildxox.com/themesite/index.php?topic=8.msg35#new

Thanks.  :D

I also noticed there is no border around the legend on your test site. (using Firefox)
At the moment, I'll try to find out why the border isn't showing up.

Looks like I have some homework to do.  >:(


Ok,  thanks for you're help  8)
Title: Re: Fieldset Quotes
Post by: Sudhakar Arjunan on April 22, 2009, 06:51:12 AM
Good Work dwd2000.
Title: Re: Fieldset Quotes
Post by: dwd2000 on April 22, 2009, 03:47:45 PM
Quote from: A.SK on April 22, 2009, 06:51:12 AM
Good Work dwd2000.

Thanks.
Maybe next time I'll do my homework before releasing something.  :-[

Robbie93: (and anyone else who has installed version 1.0)

Follow the uninstall instructions in the first post and install version 1.1.

It may also help to suggest to your members to use something other than IE. (joke)(maybe)
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: robbie93 on April 22, 2009, 04:16:01 PM
dwd,   I uninstalled 1.0 and installed 1.1 and there is still no change to the quote box

See here

http://robbie93andhotchildxox.com/themesite/index.php?topic=8.msg35#new

Here is the code from my themes/default/style.css

Any idea as to why the quote box is still not round in both firefox and ie?  thanks for you're help :D

* These are the settings for the Fieldset Quotes. */
/* Edit to your liking. */
/*At this time Internet Explorer users will ONLY SEE SQUARE CORNERS. */
fieldset {
    position: relative;
    margin-top:5px;
border-radius: 8px;
    -moz-border-radius: 8px;
-webkit-border-radius: 8px;
    padding:20px;
border: 2px solid red;
background-color: white;
}
/* The background colour in the legend will fill the whole legend */
/* You CAN have a different colour than the fieldset */
legend {
    position:absolute;
    top: -.7em;
    left: .5em;
border-radius: 8px;
    -moz-border-radius: 8px;
-webkit-border-radius: 8px;
    background-color: white;
    border: 1px solid red;
padding-left: 5px;
padding-right: 5px;
padding-bottom: 1px;
}
/* End of Fieldset Quotes. */

Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 04:26:45 PM
Quotedwd,   I uninstalled 1.0 and installed 1.1 and there is still no change to the quote box

Have you tried using the default theme?
You may have to add the style.css stuff to the style.css for the theme(s) you are using.
Let me know.

QuoteAny idea as to why the quote box is still not round in both firefox and ie?

Yes...IE SUCKS doesn't have allowances for the code "radius", so IE users will see square corners.
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 04:39:10 PM
Quotedwd,   I uninstalled 1.0 and installed 1.1 and there is still no change to the quote box

I see the style.css thing worked. (I refreshed the page)
You can adjust the spacing around the text within the fieldset (main box) by lowering the padding numbers here: padding:20px;
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: robbie93 on April 22, 2009, 04:39:52 PM
A switch to the default theme made the quotes show perfect  :D

I then manually put in this code into themes/ MY THEME /style.css and it is all looking good now on my theme of choice.  8)

/* These are the settings for the Fieldset Quotes. */
/* Edit to your liking. */
/*At this time Internet Explorer users will ONLY SEE SQUARE CORNERS. */
fieldset {
    position: relative;
    margin-top:5px;
border-radius: 8px;
    -moz-border-radius: 8px;
-webkit-border-radius: 8px;
    padding:20px;
border: 2px solid red;
background-color: white;
}
/* The background colour in the legend will fill the whole legend */
/* You CAN have a different colour than the fieldset */
legend {
    position:absolute;
    top: -.7em;
    left: .5em;
border-radius: 8px;
    -moz-border-radius: 8px;
-webkit-border-radius: 8px;
    background-color: white;
    border: 1px solid red;
padding-left: 5px;
padding-right: 5px;
padding-bottom: 1px;
}
/* End of Fieldset Quotes. */


Looking good on firefox,  no rounded corners on ie though,  I agree ie is crap  :P

Now all I need to do is change the colour and width of the box,  thanks for you're help dwd  ;D
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: robbie93 on April 22, 2009, 04:56:53 PM
Quote from: dwd2000 on April 22, 2009, 04:39:10 PM
Quotedwd,   I uninstalled 1.0 and installed 1.1 and there is still no change to the quote box

I see the style.css thing worked. (I refreshed the page)
You can adjust the spacing around the text within the fieldset (main box) by lowering the padding numbers here: padding:20px;

Yep,  looking good now dwd  :D I adjusted the padding:20px to 10 px and changed the border colour and background to suite the theme using and it's all looking good  :D

Quote from: dwd2000 on April 22, 2009, 12:36:44 AM
For those of you who would like rounded corners on the legend part:
(Internet Explorer doesn't seem to like making rounded corners, but Firefox does)

Add -moz-border-radius: 8px; to the legend part.

Quote/* These are the settings for the Fieldset Quotes. */
/* Edit to your liking. */
fieldset {
    -moz-border-radius: 8px;
    padding: 8px;
   border: 2px solid red;
   background-color: white;
}
/* The background colour in the legend will fill the whole legend */
/* You CAN have a different colour than the fieldset */
legend {
   -moz-border-radius: 8px;
    background-color: white;
    border: 1px solid red;
    padding: 1px 4px 3px 4px;
}
/* End of Fieldset Quotes. */

In the above code, I have also changed the fieldset border to 2px and adjusted the padding a little from the original code.

Use your imagination and try different things.



Does this edit still apply to version 1.1 to get the corners to show up in ie? only prob now is that there is still no rounded corners in ie.

Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 05:04:10 PM
Just some notes on how you can edit this:

The alterations are not limited to the choices that were included in the style.css.
You can change the font, (style, size, colour) border properties, (dash, dot) or anything else you can do with css.
You may even try background images.

Feel free to post any alterations you've made.
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 05:11:26 PM
QuoteDoes this edit still apply to version 1.1 to get the corners to show up in ie? only prob now is that there is still no rounded corners in ie.

Take a look at the preview images I submitted with 1.1. (I changed them) and the new first post here.

Until IE makes allowances, IE users will only see square corners.
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 05:16:34 PM
robbie93:

Try this for your background colours - #363636

I use it on Friends-Alumni.
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: robbie93 on April 22, 2009, 05:24:27 PM
Quote from: dwd2000 on April 22, 2009, 05:16:34 PM
robbie93:

Try this for your background colours - #363636

I use it on Friends-Alumni.

Thanks for the input dwd  :D I just tried the grey,  what do you think?  I prefer the black myself though.

http://robbie93andhotchildxox.com/themesite/index.php?topic=8.msg37#new

Quote from: dwd2000 on April 22, 2009, 05:11:26 PM
QuoteDoes this edit still apply to version 1.1 to get the corners to show up in ie? only prob now is that there is still no rounded corners in ie.

Take a look at the preview images I submitted with 1.1. (I changed them) and the new first post here.

Until IE makes allowances, IE users will only see square corners.

Just tested this in a variety of browsers and the edges are square in opera and ie,  google chrome,  ff,  and safari,  are rounded didnt try any other browsers as yet though.  Even with the square edges this quote box looks better than the default one,  I will be using this on our forums from now on,  good work dwd!!!
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 05:31:35 PM
QuoteThanks for the input dwd  :D I just tried the grey,  what do you think?  I prefer the black myself though.

You're right.
I was just thinking of a way to make it stand out a little, or differentiate it from the rest of the post.
Play with the colours a bit. You'll find something.

Try this: http://www.hypergurl.com/colormatch.php
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: robbie93 on April 22, 2009, 05:36:57 PM
QuoteYou're right.
I was just thinking of a way to make it stand out a little, or differentiate it from the rest of the post.
Play with the colours a bit. You'll find something.

Will do dwd  ;D in the meanwhile I will switch it back to black,  I think the black looks good 8) it depends on the individual theme though of course :P thanks for a cool mod. 
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 05:41:05 PM
Quote from: robbie93 on April 22, 2009, 05:36:57 PM
QuoteYou're right.
I was just thinking of a way to make it stand out a little, or differentiate it from the rest of the post.
Play with the colours a bit. You'll find something.

Will do dwd  ;D in the meanwhile I will switch it back to black,  I think the black looks good 8) it depends on the individual theme though of course :P thanks for a cool mod.

Enjoy.
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 22, 2009, 06:25:18 PM
Quote
Quote
Quote from: dwd2000 on Today at 12:36:44 AM

    For those of you who would like rounded corners on the legend part:
    (Internet Explorer doesn't seem to like making rounded corners, but Firefox does)

    Add -moz-border-radius: 8px; to the legend part.

    Quote

        /* These are the settings for the Fieldset Quotes. */
        /* Edit to your liking. */
        fieldset {
            -moz-border-radius: 8px;
            padding: 8px;
           border: 2px solid red;
           background-color: white;
        }
        /* The background colour in the legend will fill the whole legend */
        /* You CAN have a different colour than the fieldset */
        legend {
           -moz-border-radius: 8px;
            background-color: white;
            border: 1px solid red;
            padding: 1px 4px 3px 4px;
        }
        /* End of Fieldset Quotes. */


    In the above code, I have also changed the fieldset border to 2px and adjusted the padding a little from the original code.

    Use your imagination and try different things.



Does this edit still apply to version 1.1 to get the corners to show up in ie? only prob now is that there is still no rounded corners in ie.

No, this post was for 1.0.
I already added this in 1.1.

Remember that IE was created by the same person/company that said, "640K ought to be enough for anybody."
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 23, 2009, 12:32:20 AM
Just to let everyone know, I'm working on something I found on the web:

DD_roundies (http://www.dillerdesign.com/experiment/DD_roundies/#usage) uses a script to get around IE's inability to create round corners. It works great with simple html, but at the moment, I can't get it to work with SMF.

I am working with the writer of the above script to find a solution. (I guess I am bending over backwards for IE)
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: robbie93 on April 23, 2009, 12:53:33 AM
Good work dwd  :D I find it strange that a lot of people are still using IE,  but they are,  you only have to look at you're users online to see that a lot of guests are still fans of IE  :-X

edit:   I'm a firefox fan myself  :D
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: dwd2000 on April 23, 2009, 01:21:38 AM
Quote from: robbie93 on April 23, 2009, 12:53:33 AM
Good work dwd  :D I find it strange that a lot of people are still using IE,  but they are,  you only have to look at you're users online to see that a lot of guests are still fans of IE  :-X

edit:   I'm a firefox fan myself  :D

I don't think they're fans as much as they are not willing to find something else.
My wife doesn't care about what browser she uses, as long as she can do what she wants on the web. IE came with Vista, so she uses it. If she had a computer running Ubuntu, she'd be using Firefox. She wouldn't care. I think most people are like her.
Title: Re: Fieldset Quotes - 1.1 released with fixes
Post by: OnlineFunCorner on August 20, 2010, 02:17:16 AM
I Have This Problem Within Firefox 3.6.8
Check Attached Image