Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Orstio on July 12, 2009, 08:13:41 AM

Title: [4871] OpenID doesn't work with Google
Post by: Orstio on July 12, 2009, 08:13:41 AM
QuoteThe requested identifier did not return the proper information.

That's what happens when I use my Google URL set up for my OpenID to try to login.
Title: Re: OpenID doesn't work with Google
Post by: Orstio on July 12, 2009, 08:32:21 AM
Yep, doesn't work with Yahoo OpenID either.
Title: Re: OpenID doesn't work with Google
Post by: karlbenson on July 12, 2009, 10:12:22 AM
I think its related to http://dev.simplemachines.org/mantis/view.php?id=3034 (private, but you should still be able to see it orstio)

It appears smf currently only supports Open Id v1.1
Whereas several sites inc Google/Yahoo support Open Id v2

Which includes that our open id doesn't support https://
Title: Re: OpenID doesn't work with Google
Post by: Orstio on July 12, 2009, 12:31:40 PM
quote]Access Denied. ;)

The Yahoo OpenID is https, but the Google one is not.
Title: Re: OpenID doesn't work with Google
Post by: karlbenson on August 08, 2009, 03:55:32 PM
Ortsio, this may now be fixed in the svn version as Winrules has committed a fix for the bug I mentioned earlier.
Title: Re: OpenID doesn't work with Google
Post by: pjrobertson on November 13, 2009, 05:14:58 PM
Is there any news on this?

I've just been trying to get it to work on a test forum, but can't login with google
Title: Re: OpenID doesn't work with Google
Post by: Arantor on November 13, 2009, 07:24:12 PM
Have you tried this in RC2 public?
Title: Re: OpenID doesn't work with Google
Post by: pjrobertson on November 13, 2009, 07:36:57 PM
Yep, that's what I've just installed - literally a few hours ago. Using google's URL:
https://www.google.com/accounts/o8/id

I get the error: "The requested identifier did not return the proper information."

Edit:
If you go to http://openid-provider.appspot.com/ you can get a personally generated ID, but still, signing up gives a database error
Title: Re: OpenID doesn't work with Google
Post by: Orstio on November 13, 2009, 07:42:06 PM
Not solved at all then.  Can you also confirm it is still broken with Yahoo OpenID?
Title: Re: OpenID doesn't work with Google
Post by: pjrobertson on November 13, 2009, 07:48:29 PM
Nope, doesn't work either. I get this message with yahoo OpenID:

The database value you're trying to insert does not exist: email_address
Title: Re: OpenID doesn't work with Google
Post by: perplexed on December 03, 2009, 04:56:43 PM
I just got my first one of these today.  Upgraded to 2.0 RC2 yesterday. The message is in the error log

Quote

http://www.mysite.com/forum/index.php?action=login2

The requested identifier did not return the proper information 


Title: Re: OpenID doesn't work with Google
Post by: GazOutEast on January 02, 2010, 10:19:24 PM
I'm getting around 200 errors per day in the log on a site with less than 100 members (SMF 2.0 RC2)

Quote

Type of error : general

http://www.sitename.com/board/index.php?action=login2 (http://www.sitename.com/board/index.php?action=login2)

The requested identifier did not return the proper information.


I'll have to assume that it's related to the OpenID system then?  Was I imagining it when I thought I saw a way in admin to switch off OpenID so I can test if that's the cause?

Gaz


Edit: Found it - Admin - Registration - Settings
Have disabled OpenID registration, will monitor it for a few days to see if the errors stop (or reduce).
Title: Re: OpenID doesn't work with Google
Post by: Arantor on January 03, 2010, 05:23:06 AM
You won't get the error at all if OpenID is disabled. But that's something we're looking at.
Title: Re: OpenID doesn't work with Google
Post by: GazOutEast on January 03, 2010, 12:36:39 PM
Thanks Arantor - so far, so good - the error message hasn't re-occured since I disable Open-ID (just hope none of my members were using it).

Gaz
Title: Re: OpenID doesn't work with Google
Post by: gjoseph on June 02, 2010, 02:52:15 PM
Has there been any progress on this ?
The way I understand it, Google has ONE single OpenID url, which would be hxxps://www.google.com/accounts/o8/id - tried this, tried [email protected] and hxxp://[email protected]/, all of which returned the same "The requested identifier did not return the proper information." error message. Am I missing something? Is there anything else I can try or should look at to fix this ?

Using 2.0RC3, and unfortunately, I can't view the bug report mentioned earlier.

Title: Re: OpenID doesn't work with Google
Post by: Norv on July 17, 2010, 04:48:07 PM
Thank you for the acknowledgement and information.
I think it may be worth testing on the latest svn/latest build, I will do so as soon as possible, unless somebody else gets to it. :)
Title: Re: OpenID doesn't work with Google
Post by: Dharshan on September 15, 2010, 02:24:40 AM
I have 39 pages in my error log with this error. and yes i have open ID enabled. does any one know whether this has been fixed?
Title: Re: OpenID doesn't work with Google
Post by: Joshua Dickerson on October 03, 2011, 08:55:40 PM
Has this been fixed? If not, has it been tracked?
Title: Re: OpenID doesn't work with Google
Post by: emanuele on November 11, 2011, 06:03:00 PM
As far as I can see it doesn't seem to be fixed and I can't find it tracked.

It fails here:
// Some OpenID servers have strange but still valid HTML which makes our job hard.
if (preg_match_all('~<link([\s\S]*?)/?>~i', $webdata, $link_matches) == 0)
fatal_lang_error('openid_server_bad_response');


google's response doesn't contain any <link>, it is in the form:
<?xml version="1.0" encoding="UTF-8"?>
<xrds:XRDS xmlns:xrds="xri://$xrds" xmlns="xri://$xrd*($v*2.0)">
  <XRD>
  <Service priority="0">
  <Type>http://specs.openid.net/auth/2.0/server</Type>
  <Type>http://openid.net/srv/ax/1.0</Type>
  <Type>http://specs.openid.net/extensions/ui/1.0/mode/popup</Type>
  <Type>http://specs.openid.net/extensions/ui/1.0/icon</Type>
  <Type>http://specs.openid.net/extensions/pape/1.0</Type>
  <URI>https://www.google.com/accounts/o8/ud</URI>
  </Service>
  </XRD>
</xrds:XRDS>
Title: Re: [4871] OpenID doesn't work with Google
Post by: nend on November 15, 2011, 03:38:11 AM
The reason there is no <link rel=blah blah blah is because the format changed from HTML to XML in 2.0. Also compatibility with older versions of OpenID is not required. Google and Yahoo dropped support for older versions of OpenID.

What needs to be done is update the code to be compatible with OpenID 2.0 standards while keeping support for older 1.x servers also.
Title: Re: [4871] OpenID doesn't work with Google
Post by: ziycon on January 16, 2014, 05:30:49 AM
Related to https://github.com/SimpleMachines/SMF2.1/issues/151

QuoteImportant: Google has deprecated its support for OAuth 1.0. If you are using OpenID 2.0 + OAuth 1.0, we recommend that you switch to Google+ Sign-In. Google+ Sign-In provides the OAuth 2.0 authentication mechanism with rich social features and access to additional Google desktop and mobile features. It supports all Google users and transparent migration. For details, see the Migration of Google authentication.
Title: Re: [4871] OpenID doesn't work with Google
Post by: Arantor on January 16, 2014, 10:54:24 AM
Given that we weren't using OpenID 2.0 before, this part is perhaps less of an issue.

It's not like OpenID was ever that exciting... these days, FB, G+ and Twitter login would actually be more useful in practice.
Title: Re: [4871] OpenID doesn't work with Google
Post by: Arantor on February 08, 2014, 09:23:07 PM
This is covered under https://github.com/SimpleMachines/SMF2.1/issues/151 and should be centrally tracked there.