Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Sverre on November 03, 2009, 01:08:20 AM

Title: [4791] [Curve] Issues when browsing with images disabled
Post by: Sverre on November 03, 2009, 01:08:20 AM
Due to widespread use of background-color: transparent;, Curve is rendered almost unreadable if images are disabled.

(http://img682.imageshack.us/img682/7606/imagesdisabled.png) (http://img682.imageshack.us/img682/7606/imagesdisabled.png)

As long as the main_block.png isn't transparent, a different background colour can be applied to several of the problem areas without any negative side effects. It's not perfect, but a few minor changes definitely makes browsing with images disabled a much more pleasant experience:

(http://img682.imageshack.us/img682/2715/imagesdisabled2.png) (http://img682.imageshack.us/img682/2715/imagesdisabled2.png)

The only conflict I've found so far is with

h3, h4 {
padding-bottom: 3px;
}


which makes a small strip of the background colour visible beneath the background image of certain titlebgs and catbgs. This seems to be easy to fix by removing the bottom padding from h3 and h4 and adding a top margin of 3px to .topslice, .description, .calendar_table and possibly a few other places I haven't found yet/don't have access to instead though.

As an added bonus, this also fixes the slight alignment issue currently seen when the Info Center is collapsed:

(http://img148.imageshack.us/img148/6399/infocentercollapsed.png) (http://img148.imageshack.us/img148/6399/infocentercollapsed.png)

vs.

(http://img682.imageshack.us/img682/6770/infocentercollapsed2.png) (http://img682.imageshack.us/img682/6770/infocentercollapsed2.png)

If .content_section is given a different background colour, like I've done in my screen shot, the colour of

.buttonlist ul li a.active:hover {
color: #ddddff;
}
.buttonlist ul li a.active {
color: #ffffff;


should also be reversed in order to make the "New Topic" and "Reply" buttons visible without hovering over them.

Another unfortunate issue with images disabled is overflow from Display's mini profiles into posts, as seen here:

(http://img141.imageshack.us/img141/9107/miniprofilee.png) (http://img141.imageshack.us/img141/9107/miniprofilee.png)

An overflow value for .poster could fix this, but it may cause other problems or cross-browser issues which I'm unable to test until I get my hands on Curve.
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Antechinus on November 08, 2009, 01:06:47 AM
I had already made a noise about the main background so that now has a hex code set for it. The other details are worth doing too so I'll make sure they happen. Hopefully for RC2 but certainly before the next release. We can't use hidden overflow for the poster div (or at least I don't think so as I can see problems with that) but we should be able to work out another solution.
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Sverre on November 08, 2009, 01:20:30 AM
Quote from: Antechinus on November 08, 2009, 01:06:47 AMWe can't use hidden overflow for the poster div (or at least I don't think so as I can see problems with that) but we should be able to work out another solution.

If overflow is used to fix this, I would definitely choose auto instead of hidden.
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Antechinus on November 08, 2009, 01:44:48 AM
Hmm. Scrollbars though. They look damned nasty. Better if we can think of something else.

ETA: Well I suppose it wouldn't be that bad, since images are gone anyway and we aren't going for max eye candy. It would be better if it could be done with a <br /> or something though so that scrolling wasn't needed.
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Joshua Dickerson on July 05, 2011, 08:07:55 PM
hmmm... it is kind of stupid that we have "Recent Posts" and then "Recent Posts". There should be a better solution for that (use a sprite is what I would probably say). No idea how to fix those IM issues.
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Antechinus on July 05, 2011, 08:19:32 PM
The recent posts thingis cause by the tiny icon being linked to the recent posts page but the header title not being linked, which I frankly always thought was silly. An icon as background image for the anchor, with the header text linked, would be best I think. There are a couple of other examples too.

IM issues could be dealt with by changing the markup to call the basic text to start with (MSN Thingy) and with the actual address contained in the title tag so it shows on hover.

I'll track this to Mantis. http://dev.simplemachines.org/mantis/view.php?id=4791
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Antechinus on July 07, 2011, 04:55:35 AM
Hey:

Quote from: MSNAntechinus says:
oh those silly icons in the header bars in the info centre
I never even realised they were linked to recent posts and who's online etc
until about six months or so after I started using SMF
when I wanted to hack BoardIndex.template
It was only when I saw the html for the anchors that I realised they did something
great interface design

Norv says:
which which?

Antechinus says:
info centre
recent post and who's online titlebg header bars
the tiny little grotty gif icons are linked for functionality
never realised until I started hacking the code

Norv says:
Ooh.
lol.
I didn't know.

Antechinus says:
ROFLMAO
see
great interface design

Norv says:
yup

Antechinus says:
quote this to bug reportz ;D

Norv says:
(it's not like I should know :P )
go ahead 
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Sverre on July 13, 2011, 02:25:30 PM
Quote from: Antechinus on July 05, 2011, 08:19:32 PM
The recent posts thingis cause by the tiny icon being linked to the recent posts page but the header title not being linked, which I frankly always thought was silly. An icon as background image for the anchor, with the header text linked, would be best I think.

Personally, I've just removed those images and added the link to the text instead.
Title: Re: [Curve] Issues when browsing with images disabled
Post by: Antechinus on July 13, 2011, 06:12:26 PM
Yes that works too, but some people like icons as well. Easy enough to call them in the css. That way they're easy to remove too. :)
Title: Re: [4791] [Curve] Issues when browsing with images disabled
Post by: emanuele on August 18, 2012, 08:05:05 AM
With the new theme everything seems fine.
Moving this to fixed and closing the bug.