Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Vekseid on November 30, 2009, 11:37:55 PM

Title: [4059][SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Vekseid on November 30, 2009, 11:37:55 PM
Occurs in all browsers

To duplicate, create a new private message, type out someone's full username (don't hover over the dropdown) and hit 'enter'. In RC1 and prior, this would just add the username. Now it attempts to send the (usually blank or useless) message.

A simple attempt at a fix did not solve the issue.
Title: Re: [SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Norv on December 01, 2009, 07:43:25 AM
I cannot replicate this anymore on the latest svn, it might have been solved meanwhile.
Typing the full name and hitting enter (without using the dropdown at all), sends the message to the user with the respective name.
Title: Re: [SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Vekseid on December 01, 2009, 09:32:25 PM
Except that's not usually the desired behavior.

A lot of quoted replies with no content are being sent >_>
Title: Re: [SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Norv on December 01, 2009, 09:38:55 PM
Yes, it could stop at choosing the member, I suppose. I'll add it to the tracker, perhaps it will be re-considered.
Title: Re: [SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Norv on December 05, 2009, 11:52:36 AM
http://dev.simplemachines.org/mantis/view.php?id=4059
Title: Re: [4059][SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Nao 尚 on May 25, 2010, 01:06:28 PM
Norv, I fixed this one. (Yay.)
You may want to look into my implementation (rev 9928). I'm not a Javascript hero, and definitely not fluent in OOP stuff, so I may not have been using the right coding conventions/guidelines. Feel free to change anything.
(I like my "is_opera ? ... : ..." though... It looks kinda cool 8))
Title: Re: [4059][SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Norv on May 27, 2010, 08:31:10 AM
Thank you!
Marking as solved then.
Title: Re: [4059][SMF 2.0 RC2 Curve] Enter key no longer trapped in To and BCC PM fields
Post by: Nao 尚 on May 27, 2010, 08:35:29 AM
I'd just like to make sure it works on all browsers, BTW... Since basically I only was able to reproduce the bug in Opera, and Vekseid said it happened in all browsers.