Simple Machines Community Forum

SMF Development => Feature Requests => Applied or Declined Requests => Topic started by: Tim on August 05, 2003, 09:15:29 PM

Title: [Accepted] Recycle Bin
Post by: Tim on August 05, 2003, 09:15:29 PM
Forgive me if I've been out of the loop too long, but what about a recycle bin?

When a topic is deleted, it's send to a "recycle bin" where it remains untill it's removed, or the bin is emptied.
Title: Re:Recycle Bin
Post by: [Unknown] on August 05, 2003, 09:18:43 PM
Personally, I'd rather do it like we do here - except, when you delete a topic it automatically should get sent to the board, and then you have to delete it from there to really delete it.

In other words... (psuedo)

if ($board = $recycleBin_board)
  delete();
else
  move();

-[Unknown]
Title: Re:Recycle Bin
Post by: Killer Possum on August 05, 2003, 09:19:14 PM
That is an excellent idea, I don't know how many times I have deleted a post on accedent and was not able to "unerase" it :(
Title: Re:Recycle Bin
Post by: Metho on August 05, 2003, 09:19:29 PM
I thought I already say that this was being considered...(was a mod already on previous board), if it did get implimented, I'd surely suggest it be an ADMIN configurable option. People on my board use the im system like it was a chat client...thousands and thousands of messages...ugh.

Methonis
Title: Re:Recycle Bin
Post by: Tim on August 05, 2003, 09:20:42 PM
like I said, I was out of the loop

@[unknown]:
That's about the same idea I had :)
Title: Re:Recycle Bin
Post by: Douglas on August 05, 2003, 09:45:54 PM
VOTE from me!  OMG, a HUGE vote!
Title: Re:Recycle Bin
Post by: [Unknown] on August 05, 2003, 10:00:46 PM
Quote from: Douglas on August 05, 2003, 09:45:54 PM
VOTE from me!  OMG, a HUGE vote!

I think all the women you're used to readin the posts of are bleeding into your posting style :P :P :P

j/k. (REALLY kidding, I'm not saying anything, I'm making fun of society's preconceptions.)

-[Unknown]
Title: Re:Recycle Bin
Post by: Aquilo on August 06, 2003, 01:27:36 AM
Quote from: Metho on August 05, 2003, 09:19:29 PM
I thought I already say that this was being considered...(was a mod already on previous board), if it did get implimented, I'd surely suggest it be an ADMIN configurable option. People on my board use the im system like it was a chat client...thousands and thousands of messages...ugh.

Methonis

This IS a problem!
I think the IM system should have an admin setting for the max KB for all posts or max number of posts before they are either removed oldest first... or the IM system let's the sender know them User's IM box is full to try again later, also an option for the user to archive messages that wouldn't be removed as it would in the inbox.
and a spam filter for [unknown] 400+ IM's! ;D

Aquilo

[edit] I just noticed this has been discussed in "Topic: Instant Message folders" they have a great idea!!  ;D
Title: Re:Recycle Bin
Post by: Douglas on August 06, 2003, 01:40:06 AM
Quote from: [Unknown] on August 05, 2003, 10:00:46 PMI think all the women you're used to readin the posts of are bleeding into your posting style :P :P :P

j/k. (REALLY kidding, I'm not saying anything, I'm making fun of society's preconceptions.)
Actually, he's speaking of my site, Fractured.net, which is running a heavily modified YSE system.  Out of the 463 members, only 10 of us are men.  ::chuckles::
Title: Re:Recycle Bin
Post by: hedging on August 06, 2003, 03:21:52 AM
Vote from me 2. Greate idea!
Title: Re:Recycle Bin
Post by: Overseer on August 06, 2003, 07:02:36 AM
sounds good... question tho.


if somethings 'deleted to a recycle bin board' how would you know what board to restore it to?

i'd also like indication of who deleted it.
Title: Re:Recycle Bin
Post by: Ben_S on August 06, 2003, 07:11:16 AM
You would restore it to the most appropriate board I suppose :P
Title: Re:Recycle Bin
Post by: Overseer on August 06, 2003, 07:18:18 AM
question had to be asked... never rely on suppositions ;)
Title: Re:Recycle Bin
Post by: BiErLeEuW on August 06, 2003, 07:21:06 AM
good idea! :) You always can get back topics that were delete :) And the postcounts will not change...
Title: Re:Recycle Bin
Post by: Compuart on August 16, 2003, 02:30:59 PM
Done :)

In modsettings just select a board where you want all recycled topics to be moved to...
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.kyrandia.nl%2Ftest%2Frecycle1.jpg&hash=f414863d52d7db069b61f021b930f96adf4a49d0)

and all messages and topics that are deleted will be moved to this board
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.kyrandia.nl%2Ftest%2Frecycle2.jpg&hash=e66c7a0af0c2f2d83b17c5444e33f60ad8a7c947)
Title: Re:Recycle Bin
Post by: klumy on August 16, 2003, 02:33:03 PM
great

thanks for the job compuart !!  :)
Title: Re:Recycle Bin
Post by: Compuart on August 16, 2003, 02:44:16 PM
(added a few screenshots on the previous page)
Title: Re:Recycle Bin
Post by: Anguz on December 25, 2003, 08:19:21 PM
Quote from: Overseer on August 06, 2003, 07:02:36 AM
if somethings 'deleted to a recycle bin board' how would you know what board to restore it to?

i'd also like indication of who deleted it.

this is a good point, I don't know if something was done on this though

maybe something like this could be done: when delething the thread, the function adds a "reply" at the end of the thread, without sending notifications, "posted" by the person deleting the thread, with the date/time it was done, like any other reply, and with a link to "undo" to put the thread back where it was...

this link would have the board it originally belonged to and as action, it could call a new function that does this "undo", including the removal of this undo-reply at the end of the thread

if it's not included as a feature, it'd make a nice mod :)
Title: Re: [Accepted] Recycle Bin
Post by: David on December 25, 2003, 08:57:05 PM
Well coupled with moderation logging you should be able to track down every action.
Title: Re: [Accepted] Recycle Bin
Post by: Anguz on December 25, 2003, 10:13:41 PM
Quote from: David on December 25, 2003, 08:57:05 PM
Well coupled with moderation logging you should be able to track down every action.

ooooh... very nice... didn't know about moderation logging :D
Title: Re: [Accepted] Recycle Bin
Post by: MrCue on December 26, 2003, 06:59:23 AM
I like Anguz's idea, it just makes things so simple.
Title: Re: [Accepted] Recycle Bin
Post by: Tomer on December 26, 2003, 07:29:55 AM
Good Job compaurt!
Title: Re: [Accepted] Recycle Bin
Post by: Ryan on February 24, 2004, 09:01:29 PM
When moving the deleted topic back... It leaves the recycle bin image there.. is this suposed to happen or isit a mistake lol.. i dunno
Title: Re: [Accepted] Recycle Bin
Post by: Gobalopper on February 25, 2004, 02:35:04 AM
Well moving never changes the topic icon. You can just modify the post to change it though.
Title: Re: [Accepted] Recycle Bin
Post by: pulpitfire on February 25, 2004, 10:31:10 AM
why go to all the trouble of moving a deleted topic around, if you want the option to restore it?  why not just leave it where it is, and UPDATE it with some kind of tag or status column, so the queries won't call it?  then, it just stays where it is, unrecognized, until you click to remove the tag, or update the column that tells the thread status.
Title: Re: [Accepted] Recycle Bin
Post by: Elden on February 25, 2004, 10:44:04 AM
Admin/Moderator/Author Option (editable after setting):  Auto Expire (delete) / Lock thread in X days.

Notice on posting page:  "This thread will expire/lock in X days."

Just a thought.
Title: Re: [Accepted] Recycle Bin
Post by: Compuart on February 25, 2004, 10:44:29 AM
Quote from: pege on February 25, 2004, 10:31:10 AM
why go to all the trouble of moving a deleted topic around, if you want the option to restore it?  why not just leave it where it is, and UPDATE it with some kind of tag or status column, so the queries won't call it?  then, it just stays where it is, unrecognized, until you click to remove the tag, or update the column that tells the thread status.
The current sollution is imo the least bloated. Any other sollution would require modifications in backbone queries, additional interfaces and database modifications.
Title: Re: [Accepted] Recycle Bin
Post by: Burpee on September 05, 2004, 01:24:04 PM
Hmm... the "restore" function is something which I do believe should be fixed. Returning something from the recycle bin just leaves several things messed up such as:
1. Message icons (why change them in the first place??)
2. User post count

Also, when moving something to the recycle board it does not get subtracted from the total count of messages on the board, does it?

I do think that these are things that should certainly be looked at, but I have no time to think about it anymore as I had to leave 5 minutes ago... :D
Title: Re: [Accepted] Recycle Bin
Post by: Ben_S on September 05, 2004, 01:39:32 PM
Quote from: Burpee on September 05, 2004, 01:24:04 PM
Hmm... the "restore" function is something which I do believe should be fixed. Returning something from the recycle bin just leaves several things messed up such as:
1. Message icons (why change them in the first place??)

To show that it has been deleted and restored.
Title: Re: [Accepted] Recycle Bin
Post by: Burpee on September 05, 2004, 04:39:59 PM
Okay, that's an advantage if you want that...

I'd think that people would rather want to be able to restore the posts back to their original state with ease than to show to the whole world that apparently they made a mistake deleting a post and had to get it back out of the recycle bin...


To be honest... the current Recycle Bin feature is just too buggy... I'm thinking about disabling the feature on my board because it just doesn't do at all what I want it to do...
Title: Re: [Accepted] Recycle Bin
Post by: [Unknown] on September 05, 2004, 04:54:32 PM
How is it buggy?  If you move it out, it does not increase anyone's post count - but it doesn't decrease it again if you delete it either.

-[Unknown]
Title: Re: [Accepted] Recycle Bin
Post by: Burpee on September 05, 2004, 05:15:49 PM
Quote from: [Unknown] on September 05, 2004, 04:54:32 PM
How is it buggy?  If you move it out, it does not increase anyone's post count - but it doesn't decrease it again if you delete it either.

-[Unknown]

I may be mistaken, but isn't that wrong behaviour?
If the post is back in the public forum the post count should be restored as well...
The reason I'm taking this so heavily is that right now I have a thread with 4 posts from one person that has a post count of 1... Which just shows that there is obviously something wrong...

Is it possible to create an extra check when moving posts that checks if the board where the post is coming from is the Recycle Bin and if so the post count increases as well?

As for the total count.. I don't know how you could fix it but right now I've got a recycle-bin that has 1000 posts and as you saw before my board only has 5000 posts... so that means that 20% of that total is in the Recycle Bin... I don't know about you, but that just feels like a bug to me :(
Title: Re: [Accepted] Recycle Bin
Post by: [Unknown] on September 05, 2004, 05:25:41 PM
Why is that a bug?  It's the way it was intended.

A bug is something working a way it was not intended to.  A design flaw is something working the way it was meant to, but that way being bad.

You don't like the way it was designed, in other words.

-[Unknown]
Title: Re: [Accepted] Recycle Bin
Post by: Burpee on September 05, 2004, 05:48:55 PM
Okay...

My complaint changes then: Read all the above and replace all complaints about "bugs" and change it to "illogic behaviour" and then see if this is a case of illogical behaviour

Otherwise, explain to me why the way that it's behaving right now would be considered logical. I might just be using the feature the wrong way, you never know...

But please remember... I'm here to criticize your work... with the intention of improving it... I do not mean to imply that you're doing a crappy job, I think you guys are all doing a great job...
Title: Re: [Accepted] Recycle Bin
Post by: [Unknown] on September 05, 2004, 06:08:12 PM
See, the way I view "delete" is, I must assume, more permanent than you do.

If a post is deleted, and then "resurrected" I view it as a "zombie".  I don't think of it as "just the same as before" because it *WAS* deleted.  It's a zombie now - living dead.  And I'd best remember to stay away 'cuz it'll try to eat my brains.

So, having the post count decrease on delete and then never change again makes complete sense to me.  Having a member with 4 zombie posts and only one listed post... also seems logical to me.

-[Unknown]
Title: Re: [Accepted] Recycle Bin
Post by: Anguz on September 05, 2004, 06:54:55 PM
Maybe have a checkbox in forum settings to have restored topics/posts from the Recycle Bin restore counts or not?
Title: Re: [Accepted] Recycle Bin
Post by: Amacythe on September 05, 2004, 07:28:17 PM
How about leaving it as it is and training your MODs and Admins not to delete posts that shouldn't be deleted?
Title: Re: [Accepted] Recycle Bin
Post by: Burpee on September 08, 2004, 03:52:53 PM
Quote from: [Unknown] on September 05, 2004, 06:08:12 PM
See, the way I view "delete" is, I must assume, more permanent than you do.

If a post is deleted, and then "resurrected" I view it as a "zombie".  I don't think of it as "just the same as before" because it *WAS* deleted.  It's a zombie now - living dead.  And I'd best remember to stay away 'cuz it'll try to eat my brains.

So, having the post count decrease on delete and then never change again makes complete sense to me.  Having a member with 4 zombie posts and only one listed post... also seems logical to me.

-[Unknown]

Nice story :D
I still don't believe it's fair to punish users for our mistakes...
Let's say I were to create a poll in public and ask for the general public's opinion on the best description of the functionality you would expect from a recycle-bin... who do you think will get the most votes?

Quote from: Amacythe on September 05, 2004, 07:28:17 PM
How about leaving it as it is and training your MODs and Admins not to delete posts that shouldn't be deleted?
Sorry Amacythe, but if you can manage to do that, I'd love to see you teach all people that drive cars not to have any accidents...
Title: Re: [Accepted] Recycle Bin
Post by: dschwab9 on September 08, 2004, 04:16:01 PM
If you want the users post count to say 4, just edit their profile and change it.
Title: Re: [Accepted] Recycle Bin
Post by: Amacythe on September 08, 2004, 10:50:53 PM
Well, on my board, all forums have two mods, and they are all instructed not to delete any post without a second opinion.  They can move it to a Moderator only forum, to discuss it with others when the other MODs are available.  It has worked well thus far :) 

As for those drivers having accidents... let's get rid of all drivers under the age of 30 and over the age of 50... no let's refine that... Let's get rid of all drivers except ME ;)
Title: Re: [Accepted] Recycle Bin
Post by: Burpee on September 09, 2004, 04:27:32 AM
:D

Well, the average visitor leaves 10 completely useless posts before posting 1 useful post. So asking for a second opinion on every deletion would take up so much time I'd probably lose all my moderators. On average we delete about 15 posts per day. Having the recycle bin actually IS like a second opinion, all mods check out the recycle bin to see if anything has been wrongfully deleted...
Title: Re: [Accepted] Recycle Bin
Post by: debragrant on August 02, 2007, 07:07:45 AM
where is the recycle  bin?
Title: Re: [Accepted] Recycle Bin
Post by: Ben_S on August 02, 2007, 07:10:38 AM
Search the online manual.
Title: Re: [Accepted] Recycle Bin
Post by: debragrant on August 02, 2007, 08:28:47 AM
all I get is its in Moderation Tools but I can't find it in there
Title: Re: [Accepted] Recycle Bin
Post by: Killer Possum on August 02, 2007, 10:32:28 AM
http://docs.simplemachines.org/index.php?topic=113.0
Title: Re: [Accepted] Recycle Bin
Post by: shentino on August 12, 2007, 04:50:15 PM
Hmm...

How about a permission to bypass the recycle bin?

Like regular users could only make them go to the recycle bin, and possibly mods.

High level staffers and gmods would however be able to nuke a topic completely if they had the "bypass recycle bin" permission.
Title: Re: [Accepted] Recycle Bin
Post by: Peter Duggan on August 12, 2007, 04:55:48 PM
Quote from: shentino on August 12, 2007, 04:50:15 PM
High level staffers and gmods would however be able to nuke a topic completely if they had the "bypass recycle bin" permission.

Since it's already possible to give them the permission to delete from it, wouldn't that do?
Title: Re: [Accepted] Recycle Bin
Post by: shentino on August 12, 2007, 04:58:44 PM
If I understand you correctly, they'd still have to hop to the recycle bin and delete it again.  If I'm going to be removing obvious garbage, I'd rather not have to play board hopscotch to do it.

Also, high level staffers may very well not want to have to review their own deletes and sift through the recycle bin for deletions they were already certain of when they deleted them the first time.

Suggestion:  Let deletes bypass the recycle bin entirely if they have permission to delete from the recycle bin.  No added permission needed, just a convenient shortcut for something they could play hopscotch to do anyway.
Title: Re: [Accepted] Recycle Bin
Post by: Col on August 13, 2007, 12:20:31 PM
Disable the recycle bin.

Disable deletion by all groups (so that you don't potentially loose posts to permanent deletion that you may wish to retrieve)

As an Administrator, delete the posts and threads you wish to permanently delete.

Reinstate the recycle bin and deletion privileges.
Title: Re: [Accepted] Recycle Bin
Post by: shentino on August 14, 2007, 04:42:23 PM
I think you want to disable deletions BEFORE you disable the recycle bin.  Who knows what random webmonkey will come along at exactly the wrong time?

lol.

And anyway, that still sounds like playing hopscotch.
Title: Re: [Accepted] Recycle Bin
Post by: Consle 4 talk on May 10, 2008, 07:41:04 AM
Exelent idea!