Simple Machines Community Forum

SMF Development => Feature Requests => Applied or Declined Requests => Topic started by: nobby-ka on January 06, 2011, 04:48:08 AM

Title: Wanted: More functions for personal messages
Post by: nobby-ka on January 06, 2011, 04:48:08 AM
Hello,

first of all: Excuse my bad english! I only had english at school for 6 years and didn't speak english since that time. I hope, I find the correct words to explain my wish.

The functions for personal messages let me miss a feature:
Seeing, wich message was sent, but not readed yet. In phpBB-forums is there an additional folder called sended messages. The p m's in this folder are sent, but not readed by the recipient.
In smf-forum 1.1.12 exist two folders: in and out.

Is it possible to enhance the functions or is there coming an "P M-Upgrade" in 2.0?
Title: Re: Wanted: More functions for personal messages
Post by: Arantor on January 06, 2011, 05:13:42 AM
Well, in 2.0 it's inbox and sent items, but there's no direct functionality for that.

Simple hack for 2.0 PersonalMessage.php (even in RC4), though, to make it show up in your sent items whether they've been read or not (unread in bold)

Code (find) Select
if ($context['folder'] == 'sent' || empty($row['bcc']))
$recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . $row['to_name'] . '</a>';


Code (replace) Select
$do_bold = ($context['folder'] == 'sent' && $row['is_read'] == 0);
if ($context['folder'] == 'sent' || empty($row['bcc']))
$recipients[$row['id_pm']][empty($row['bcc']) ? 'to' : 'bcc'][] = empty($row['id_member_to']) ? $txt['guest_title'] : '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member_to'] . '">' . ($do_bold ? '<b>' . $row['to_name'] . '</b>' : $row['to_name']) . '</a>';



The team will not change its functionality any further in 2.0 now though.
Title: Re: Wanted: More functions for personal messages
Post by: Illori on January 06, 2011, 06:00:03 AM
you could also take a look at http://custom.simplemachines.org/mods/index.php?mod=1629
Title: Re: Wanted: More functions for personal messages
Post by: Kindred on January 06, 2011, 11:00:05 AM
more importantly....  SMF 2.0 is feature fixed.
Title: Re: Wanted: More functions for personal messages
Post by: Norv on January 14, 2011, 08:23:03 PM
I'm not sure I'm comfortable with this feature. Even email clients (IIRC) may have an option to allow users to send notification that they read a message or not - not only let you know it was read, or not all the time. That has a privacy implication, so I'd rather not see one implemented without the other.
On the other hand, if it gets this detailed, I'd have to note that SMF is not a full email client, and I doubt it should support these.
Title: Re: Wanted: More functions for personal messages
Post by: Arantor on January 14, 2011, 08:25:42 PM
Thing is, SMF's already working out that information, all that hack does is display it - note the $row['is_read'] is evaluated per recipient, and there is, AFAIK, no actual use for that from the sent items page.
Title: Re: Wanted: More functions for personal messages
Post by: Norv on January 14, 2011, 08:36:34 PM
That doesn't change the fact that simply displaying it can be considered to have privacy implications. TBH, I am not comfortable with that.
Of course admins can mod their forum as they want in the end, that's the whole purpose of it, I was referring solely to the SMF features as provided by default (or officially developed and supported).
Title: Re: Wanted: More functions for personal messages
Post by: Arantor on January 14, 2011, 08:40:17 PM
On the other hand, why process it in the first place? I see where you're coming from though.