Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: The Craw on January 08, 2012, 07:41:03 PM

Title: Inline CSS (Not Much, But a Little)
Post by: The Craw on January 08, 2012, 07:41:03 PM
Only one property declaration, but still, I'm of the opinion that all CSS should be in an external file.

~/Themes/default/Display.template.php
Line: 694

<form action="', $scripturl, '?board=', $context['current_board'], ';action=post2" method="post" accept-charset="', $context['character_set'], '" name="postmodify" id="postmodify" onsubmit="submitonce(this);" style="margin: 0;">


Very last attribute in the form tag. I noticed this when I went to make an ajax reply mod.
Title: Re: Inline CSS (Not Much, But a Little)
Post by: Antechinus on January 08, 2012, 09:35:48 PM
Yup. Shouldn't be there. :)
Title: Re: Inline CSS (Not Much, But a Little)
Post by: ledaladdin.com on January 09, 2012, 09:53:06 PM
CSS can better control the site. Flexible
Title: Re: Inline CSS (Not Much, But a Little)
Post by: Matthew K. on January 09, 2012, 09:54:43 PM
Quote from: ledaladdin.com on January 09, 2012, 09:53:06 PM
CSS can better control the site. Flexible
He was never saying remove CSS? You can't validly style an XHTML document without CSS...The Craw is a good developer, he knows what he's talking about.

Although there are SOME rare scenarios where inline CSS is necessary.
Title: Re: Inline CSS (Not Much, But a Little)
Post by: Alexes19 on January 11, 2012, 08:00:46 AM
Quote from: Labradoodle-360 on January 09, 2012, 09:54:43 PM
Quote from: ledaladdin.com on January 09, 2012, 09:53:06 PM
CSS can better control the site. Flexible
He was never saying remove CSS? You can't validly style an XHTML document without CSS...The Craw is a good developer, he knows what he's talking about.

Although there are SOME rare scenarios where inline CSS is necessary.
Thanks for great explanation

Title: Re: Inline CSS (Not Much, But a Little)
Post by: Arantor on December 25, 2013, 11:53:41 PM
This one is fixed in 2.1.