Link to the theme (https://custom.simplemachines.org/index.php?theme=2612)
(https://custom.simplemachines.org/index.php?action=download;theme=2612;attach=205512;image;thumb)
BloQcs is a light, modern-type theme with 6 color variants built-in, and option to add pure links to various social sites. Source PSD file to customize further are available at http://www.blocweb.net/index.php?topic=31.0.
DEMO: http://www.blocweb.net/index.php?theme=4
Nice theme bro
Good to see ya back even tho you dont know me :p
Another great theme Bloc, keep up the good work. I can't wait to see your next one :).
Very very nice. I can tell you put a lot of work into this one. The one thing that kinda bugs me though is the focus border for the search field. Well done on everything else. :D
Nice Theme Bloc! (http://media.simplemachinesweb.com/smf/default/images/post/thumbup.gif)
wouldn't it be a better idea to get rid of hard coded alt text from the index.template.php?
if(!empty($settings['rs_icon']))
echo '
<a href="' , $scripturl , '?action=.xml;type=rss"><img src="' , $settings['images_url'] , '/icons/rs.png" alt="RSS" /></a>';
if(!empty($settings['fb_icon']))
echo '
<a href="' , $settings['fb_icon'] , '"><img src="' , $settings['images_url'] , '/icons/fb.png" alt="Facebook" /></a>';
if(!empty($settings['ln_icon']))
echo '
<a href="' , $settings['ln_icon'] , '"><img src="' , $settings['images_url'] , '/icons/ln.png" alt="LinkedIn" /></a>';
if(!empty($settings['tw_icon']))
echo '
<a href="' , $settings['tw_icon'] , '"><img src="' , $settings['images_url'] , '/icons/tw.png" alt="Twitter" /></a>';
if(!empty($settings['my_icon']))
echo '
<a href="' , $settings['my_icon'] , '"><img src="' , $settings['images_url'] , '/icons/my.png" alt="MySpace" /></a>';
Why? Do you have other names for them in for example Spanish? ;D AFAIk Facebook is Facebook in any language. And RSS is a global term.
Bloc your themes are awesome!
Quote from: Bloc on July 14, 2012, 09:37:56 PM
Why? Do you have other names for them in for example Spanish? ;D AFAIk Facebook is Facebook in any language. And RSS is a global term.
no, but it's irrelevant since the guidelines specifically mentions this kind of hard coding
Quote from: Orangine on July 15, 2012, 06:42:09 AM
Quote from: Bloc on July 14, 2012, 09:37:56 PM
Why? Do you have other names for them in for example Spanish? ;D AFAIk Facebook is Facebook in any language. And RSS is a global term.
no, but it's irrelevant since the guidelines specifically mentions this kind of hard coding
Heh. Well, the guidelines are just that: guides.
UPDATE - new zip file uploaded with following fixes:
- added missing boardicons for childboards
- changed guest login style to normal, was always uppercase
For simple update: upload the extra images, and the changed css/index.css.
http://wiki.simplemachines.org/smf/Customization_approval_guidelines
QuoteNo Hardcoded Text
"Hardcoded text" means any literal text strings intended for display to members. Hardcoded Text makes translation to different languages very difficult. Instead, please use language strings (the $txt[] array) defined in language files. This rule applies even if you provide your customization only in one language. You may choose to use Modifications.english.php, or to add other language files to your install file using the error="skip" attribute.
So what's the story here? It looks to me this is pretty straight forward - do as we say, or your theme won't be published. How come this one slipped through?
Ask them then.
Those letters/words aren't considered as hard-coded text since they are websites/companies names globally recognized rather than single lose words.
That must be the most ridiculous answer you could provide.
Thank you, you don't have to like it if you don't want.
Have a nice and productive day :)
It's actually a very good answer, Suki! The strings in question are static elements, not things like "Reply" or "Preview" but rather company names. Orangine, what exactly are you having issues with? The block of code you quoted doesn't really violate the guidelines.
I have two issues. One, this is against the rules some of you clearly put there. And two, anyone wanting to change those links to suit them will be forced to play with not only the theme language file, like it's supposed to be (again, if you follow the rules), but will have to find and change the code in the template files.
But from what I can see, not everyone is bound to obey the rules here. Not a very good practice.
Quote"Hardcoded text" means any literal text strings intended for display to members.
Alt text isn't displayed to members (unless you're using a screen reader). Also, from the code, it looks like those are theme settings and can be disabled via a checkbox.
I am sorry, but you are wrong. If you take your time to disable the images in your browser, or use text only browser, you will see that this code is being displayed. Also, do not forget that alt code is used when the website is being used with a screen reader (i.e. visual impaired people).
I could partially understand if it was some text somewhere in the admin panel, but this text is there for everyone.
OK, what is Spanish for RSS, Facebook, LinkedIn, Twitter? :)
Did you at least bother to read my argumentation? I'm not here to exchange funny comments, I'm simply asking why put the rules when you have no intention on following them?
I did tonnes of research before finally submitting my theme to this site and after that I found out not everyone seems to be following the rules. I'm only asking what's the point?
There's actually a very good reason why they are allowed.
The whole point of hardcoded text avoidance is for translations. Hardcoded text, by definition, can't be translated through SMF's language files. But Facebook, LinkedIn, etc. won't be any different in any other language, forcing them to be in the language files just results in making the language files larger and slower for a string that will never be translated under any circumstances.
That's the beauty of the guidelines, they are guidelines and rules that are applied with a little intelligence, by their spirit, not their letter.
let me repeat myself:
Quote from: Orangine on July 15, 2012, 01:53:23 PM
I have two issues. One, this is against the rules some of you clearly put there. And two, anyone wanting to change those links to suit them will be forced to play with not only the theme language file, like it's supposed to be (again, if you follow the rules), but will have to find and change the code in the template files.
But from what I can see, not everyone is bound to obey the rules here. Not a very good practice.
If they want to change the links, they'll have to edit the theme file anyway seeing how the image is also set up that way (e.g. the FB link uses the FB image)
Meaning that any apparent advantage to using the theme language file is completely negated whatever you do, and as I stated before, that would have been taken into account by the person approving the theme because the guidelines are *GUIDE* lines, rather than hard rules.
Believe me, if you approve mods by having a stick up your posterior, you are seriously not appreciated for doing it. And I'm sure the team will be quite happy to point out that was exactly how I used to do mod approvals, and it wasn't appreciated by mod authors.
Quote from: Orangine on July 15, 2012, 02:19:20 PM
let me repeat myself:
Quote from: Orangine on July 15, 2012, 01:53:23 PM
I have two issues. One, this is against the rules some of you clearly put there. And two, anyone wanting to change those links to suit them will be forced to play with not only the theme language file, like it's supposed to be (again, if you follow the rules), but will have to find and change the code in the template files.
But from what I can see, not everyone is bound to obey the rules here. Not a very good practice.
Do you want to change the LINKS? They are not possible to change in a language file in this theme and don't belong there either. And here I thought you talking about the names lol. ::)
If you are looking to change the whole thing - well, i am sorry, but you just have to dismantle the template files then. Its after all just direct links/buttons to these web services, not a custom-url-with-button-to-anything.
My gues though, is that you are just looking for things to justify your anger towards your own theme submission and moderating of it. Well, tough, but I have had hardcoded text pointed out to me before, and just had to change them if I wanted the theme onsite here. I suggest you do the same.
Your guess is wrong then, as I kept all the text in language files.
Even the URLs to the pictures?
Especially them :D
Well, that's just great for you then, isn't it? Let's pollute the language files with non language data, wonderful.
In any case, everyone else is quite happy with editing the theme file to change the pictures, and they'll change the tooltip when they change the theme file. There are advantages to doing it that way, like not polluting the smf_themes table, not consuming the extra memory every single page in $settings and it does actually encourage people to get their hands dirty occasionally.
I give up. But somehow I feel sooner or later I will find out that whoever approves mods/themes may not be as lenient to me as is to 'veterans' here.
The team are generally more tough on veterans because they should know better, and that's been true for the last few years.
Since I'm the person that originally approved the theme to begin with, I'll maintain the comments that Suki posted, that those items are fine as is. (Company) names and acronyms are examples of something aren't really worth putting in language files.
The Guidelines are just that, guidelines. They aren't etched in stone. The approval process looks at each customisation individually and approves or rejects it on it's own merits.
I will agree with what Bloc and Arantor have already said, URLs to icons don't belong in the language files. They belong in the templates.
Great theme Bloc, thanks for sharing yet another one 8)
Nice theme, thanks for sharing! :)
Nice theme. Thanks.
One question how can I have the header to be already shrinked and not expanded in other words not to display initialy the search box and the avatar, guest text etc and if a user wants to expand it?
Anyway I finally remove it completely.
For anyone that wants also to do this:
Open index.template.php file and remove on line 184
<img id="upshrink" src="', $settings['images_url'], '/upshrink.png" alt="*" title="', $txt['upshrink_description'], '" style="display: none; clear: right;" />
Also remove all the lines from // Show a random news item? until echo '
', sprintf($txt['welcome_guest'], $txt['guest_title']);
}
echo '
</div>
</div>';
Bloc site requires admin approval so posted here...
Changing the colour of the template from red to another option doesn't change the sub menus which stubbornly remain red .... would be nice if they matched.
Cleaning smf cache and browser caches doesn't make any difference. Same logging out and back in.
Last thing was uninstalling the theme changer and carbonate theme, cleaning out all caches but no difference. Screenshot attached.
Latest firefox and chrome.
New install of smf 2.0.2
Installed themes:
bloqcs_smf202-d.zip (default)
carbonate202-c.zip (uninstalled no change)
Installed mod:
SMF Theme Changer 1.0.1 (uninstalled no change)
In regards to this theme, which I think is bl00dy brilliant by the way!
I would like to know if anyone manged to fix the broken search highlight in the navigation menu.
I am using the theme currently and the search highlight doesn't show in align to the text (white) zone.
Hopefully someone can help.
Thank you, Charlie