Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: vbgamer45 on November 12, 2018, 11:20:32 AM

Title: SMF Upgrader styles break on SSL 2.0.15
Post by: vbgamer45 on November 12, 2018, 11:20:32 AM
SMF Upgrader styles break on SSL 2.0.15

upgrade.php
Change

$smfsite = 'http://www.simplemachines.org/smf';

To

$smfsite = 'https://www.simplemachines.org/smf';
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: live627 on November 12, 2018, 07:25:17 PM
lolwut how does that break stylizing?? Confused. And amused.
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: vbgamer45 on November 12, 2018, 07:42:22 PM
If they are running the their forum on SSL the css/graphics won't load since it is fetched from http:// so the upgrade will appear odd to them same issue with the convertors.
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: live627 on November 13, 2018, 12:37:26 AM
The plot thickens.

upgrade.php:52: $smfsite = 'http://www.simplemachines.org/smf';
upgrade.php:3471: global $modSettings, $txt, $smfsite, $settings, $upcontext, $upgradeurl;
Found 2 matches for "smfsite".


Am I looking in the wrong file?
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: vbgamer45 on November 13, 2018, 12:56:00 AM
Nope that is the bad line right there missing https://

upgrade.php:52: $smfsite = 'http://www.simplemachines.org/smf';
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: Sesquipedalian on November 13, 2018, 02:53:11 AM
Fix has been submitted for 2.0.16
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: albertlast on November 13, 2018, 10:50:52 AM
Would be nice when you fix also the postgres setup,
this literial not work,
because of the wrong escape char for the holidays -> \' = wrong '' = right
look how it the 2.1 setup do.
Title: Re: SMF Upgrader styles break on SSL 2.0.15
Post by: shawnb61 on December 28, 2019, 02:57:40 PM
Fixed in 2.0.16.