Text only | Text with Images

Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: Sir Osis of Liver on March 19, 2020, 04:42:18 PM

Title: inline editor borks unicode characters
Post by: Sir Osis of Liver on March 19, 2020, 04:42:18 PM
If I post this -

test •• test

load it in inline editor and save, it changes to this -

test %u2022%u2022 test

Happens in clean test install and here.
Title: Re: inline editor borks unicode characters
Post by: shawnb61 on March 19, 2020, 04:48:33 PM
Bug & fix noted here:
https://www.simplemachines.org/community/index.php?topic=571082.msg4042818#msg4042818

In said thread, this bug was actually compared to a terrorist attack...
Title: Re: inline editor borks unicode characters
Post by: shawnb61 on March 19, 2020, 04:58:16 PM
Just as an FYI - the same fix is needed for the "why do I have to login twice?" issue:
https://www.simplemachines.org/community/index.php?topic=571384.0

Specifically, this impacts users with multi-byte chars in their passwords. 
Title: Re: inline editor borks unicode characters
Post by: Sir Osis of Liver on March 19, 2020, 05:03:12 PM
Will package manager flag an error for script.js if fix is not removed before installing .18 patch?  Remembering things is not something I'm good at.
Title: Re: inline editor borks unicode characters
Post by: shawnb61 on March 19, 2020, 05:31:18 PM
Possibly.  I wouldn't bank on it.  There is risk associated with telling the package manager to ignore errors. 

It is smartest to save a copy of that source w/date before making the changes. 
Title: Re: inline editor borks unicode characters
Post by: Sir Osis of Liver on March 19, 2020, 05:46:33 PM
Basically would be looking for pm errors just as a reminder that code had been changed.  Would save backup copy of original in any case.  It's not a major problem, will see what they want to do.

Thanks.
Text only | Text with Images