I don't see active links on my site.
In Admin -> Configuration -> Bulletin Board Code
"Automatically link posted URLs" is activated but does not work. For example https://www.rapaleando.com/foros/index.php?topic=14097.600
It has happened just after upgrading to 2.1.1 from 2.0.X.
What can I do?
Best regards.
(https://i.ibb.co/9pNJ7DG/image.png)
Any mods installed yet that might work with urls or bbc?
Not sure if this will do any good, but just in case try to empty your forum's file cache.
Admin -> Maintenance -> Forum Maintenance -> Routine -> Empty SMF's cache
Then check that topic again.
Thank you. That task did not work.
I just tried to install the Simple Audio Video Embedder but it doesn't work because this mod needs links, and after updating I don't have automatic links.
Are you getting any errors in your logs?
0 errors in SMF admin panel.
I have discovered another detail.
If I hit reply, on the reply page and when I scroll down the page I see other people's posts, the links do work.
Okay, there's something apparently broken - But without any visible clues, and with no errors, I'm really unsure what exactly. Is the Simple Audio Video Embedder still installed? What if you uninstall it for now?
Thank you for your response. The mod is uninstalled and now nothing is installed.
In case it helps: in SMF 2.0.X I had Responsive Curve and Simple Audio Video Embedder.
In preview message the links do work.
(https://i.ibb.co/c1HkHZB/image.png)
By FTP I uploaded again all the files from a clean installation except install.php and settings.php but the problem persists.
If you manually add the url tags to a link, does that work normally?
I'm really grasping at straws here though,
@Sesquipedalian @shawnb61 - Good ideas would be welcome.
Yeah, odd.
First couple of questions:
- Have you tried clearing the cache?
- Are all links affected?
- PHP version?
Do you have WordPress on that site?
Do you have any ad managers running?
If autolinking works correctly in preview but not in the topic display, then the problem is not the autolinker. Whatever is causing the problem is occurring at some later stage.
I suspect that either something else is causing invalid HTML in the topic display, or that some JavaScript is breaking things. To test the former, use the W3C's HTML validator to see if any errors come up for an affected page of your forum. To check the latter, try disabling JavaScript in your browser and then reloading the page.
Thanks guys :)
@shawnb61 @Sesquipedalian @Aleksi "Lex" Kilpinen
Thank you very much for your kindness. I don't have much idea about this and not feeling alone reassures me.
I have news (hopefully good news hahaha).
The links do work if I create or edit them after creating the post,
but only using QUICK EDIT. With normal editing, the one that opens another page, the links do not end up working. I hope I have explained myself, I use a translator, sorry for the language.
In the forum options, server settings, general, I don't have SSL mode enabled, should I?
I clearing the cache in the forum settings.
I don't have an ad manager.
The PHP version is 7.4 although I have tested and the forum also works on 8.1. I went back to 7.4
With Java disabled the links still don't work.
I do have a WordPress at the root of the domain.
About the W3C its put that it is this:
(https://i.ibb.co/mJcySv4/image.png)
Greetings and thanks.
Given your site is served up https, yes, you should enable SSL.
We do sometimes see flakiness when things are out of sync there, so please go ahead & try that.
Quote from: shawnb61 on February 22, 2022, 01:29:10 PMGiven your site is served up https, yes, you should enable SSL.
We do sometimes see flakiness when things are out of sync there, so please go ahead & try that.
Thank you.
I have enabled SSL but the link problem remains unless the user uses quick edit.
Please attach copies of your Subs.php, Display.php, and Display.template.php files so that we can inspect them.
When I did the upgrade from 2.0.19 to 2.1.1 on my test site the images I had attached would not work either.
I had to 'Modify' the post and then remove the code for the original attachment and then re-attach the image again then it worked OK.
I'm not sure if that helps you or not and I didn't report it as I thought it was just because of the different versions.
No, sorry, but I'm afraid that information about attachments doesn't help us understand your current issue.
In order to figure out what is going wrong on your forum, we need to see the actual files you are using. So, please attach copies of your Subs.php, Display.php, and Display.template.php files to your next reply to this topic.
Quote from: Sesquipedalian on February 23, 2022, 02:59:09 AMNo, sorry, but I'm afraid that information about attachments doesn't help us understand your current issue.
In order to figure out what is going wrong on your forum, we need to see the actual files you are using. So, please attach copies of your Subs.php, Display.php, and Display.template.php files to your next reply to this topic.
Sesq I take it that you're talking to the OP about posting files rather than my post?
Quote from: Sesquipedalian on February 22, 2022, 03:42:06 PMPlease attach copies of your Subs.php, Display.php, and Display.template.php files so that we can inspect them.
Thank you.
I add photos as there are files with similar name, with the symbol
~ and I don't know if that is correct.
Subs.php Subs.php
(https://i.ibb.co/cFF2Ppj/image.png)
Display.php Display.php
(https://i.ibb.co/MndKgkC/image.png)
In /foros/themes/default
Display.template.php Display.template.php
(https://i.ibb.co/dt6P3Rw/image.png)
Files with ~ are backups made of those files before a mod was installed.
Quote from: Dave J on February 23, 2022, 03:06:21 AMSesq I take it that you're talking to the OP about posting files rather than my post?
Derp. Yes. That's what I get for posting while suffering from insomnia, I guess. :laugh:
Hm. Well, there is nothing wrong with any of those files.
In the screenshot that you posted,
@rapalero, I can see several other files named "Display.template.php.conlocalizacion", "Display.template.php.orig", and "Display.template.php.sinlocalizacion". Where did those files come from?
Hello
@Sesquipedalian I don't know where those files come from. As they are Spanish words, maybe they were old modifications that were made, I don't remember. They are from 2016.
I have more information. The old links still don't work but now when users put a link without extra code it works. If I put it with a user account it works. But if I put it with my administrator account it does not work.
https://www.rapaleando.com/foros/index.php?topic=20235.msg265469#msg265469
Has the location of the forum changed in the past?
Does repair_settings.php (https://wiki.simplemachines.org/smf/Repair_settings.php) show any discrepancies?
Quote from: rapalero on February 24, 2022, 06:45:11 AMHello @Sesquipedalian
I don't know where those files come from. As they are Spanish words, maybe they were old modifications that were made, I don't remember. They are from 2016.
I have more information. The old links still don't work but now when users put a link without extra code it works. If I put it with a user account it works. But if I put it with my administrator account it does not work.
https://www.rapaleando.com/foros/index.php?topic=20235.msg265469#msg265469
This keeps getting more and more strange.
Please save the following PHP code into a temporary PHP file in your forum directory, and then visit it in a browser.
<?php
require_once('SSI.php');
$request = $smcFunc['db_query']('', '
SHOW FULL COLUMNS
FROM {db_prefix}messages
LIKE {string:body_like}',
array(
'body_like' => 'body',
)
);
$column_info = $smcFunc['db_fetch_assoc']($request);
$smcFunc['db_free_result']($request);
echo '<pre>';
var_export($column_info);
echo '</pre>';That should print out information something like this:
array (
'Field' => 'body',
'Type' => 'text',
'Collation' => 'utf8_general_ci',
'Null' => 'NO',
'Key' => 'MUL',
'Default' => NULL,
'Extra' => '',
'Privileges' => 'select,insert,update,references',
'Comment' => '',
)
Please reply with your results of this test. Afterwards, you can delete the temporary PHP file.
Thanks
@Sesquipedalian (https://i.ibb.co/F3w0Hvr/image.png)
array (
'Field' => 'body',
'Type' => 'text',
'Collation' => 'utf8_general_ci',
'Null' => 'NO',
'Key' => '',
'Default' => NULL,
'Extra' => '',
'Privileges' => 'select,insert,update,references',
'Comment' => '',
)
Quote from: rapalero on February 24, 2022, 06:45:11 AMThe old links still don't work but now when users put a link without extra code it works. If I put it with a user account it works.
What do you mean by "without extra code"?
Can you show an example of one that doesn't work and one that does?
Quote from: shawnb61 on February 25, 2022, 10:11:01 AMQuote from: rapalero on February 24, 2022, 06:45:11 AMThe old links still don't work but now when users put a link without extra code it works. If I put it with a user account it works.
What do you mean by "without extra code"?
Can you show an example of one that doesn't work and one that does?
With this works in my admin account:
(https://i.ibb.co/DWzDbPr/image.png)
Let me ask this another way...
If you modify the posts, and can see the BBC, is there a visible difference between the links that work and the links that do not work?
E.g., do they look like this?
facebook.com
Or this?
[url="http://facebook.com/"]Facebook link[/url]
Or this?
[url]http://facebook.com[/url]
Thank you for your response. This is frustrating, now none of the 3 options work for me. I have tried in different subforums and with normal user and administrator user. On the other hand, it seems that the links without codes to other users do work as you can see in https://www.rapaleando.com/foros/index.php?topic=20235.msg265469#msg265469
Quote from: rapalero on February 25, 2022, 05:23:59 AMThanks @Sesquipedalian
array (
'Field' => 'body',
'Type' => 'text',
'Collation' => 'utf8_general_ci',
'Null' => 'NO',
'Key' => '',
'Default' => NULL,
'Extra' => '',
'Privileges' => 'select,insert,update,references',
'Comment' => '',
)
Thank you for that information. Next, please tell me the result you get from the following PHP code:
<?php
require_once('SSI.php');
$msgs = array();
$request = $smcFunc['db_query']('', '
SELECT id_msg, body
FROM {db_prefix}messages
WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg',
array(
'message_list' => array(260503, 265469),
)
);
while ($row = $smcFunc['db_fetch_assoc']($request))
{
$msgs[$row['id_msg']] = htmlspecialchars(mb_encode_numericentity($row['body'], array(0x80,0x10FFFF,0x0,0xFFFFFF), 'UTF-8'));
}
echo '<pre>';
var_export($msgs);
echo '</pre>';
Quote from: Sesquipedalian on February 25, 2022, 02:01:53 PMQuote from: rapalero on February 25, 2022, 05:23:59 AMThanks @Sesquipedalian
array (
'Field' => 'body',
'Type' => 'text',
'Collation' => 'utf8_general_ci',
'Null' => 'NO',
'Key' => '',
'Default' => NULL,
'Extra' => '',
'Privileges' => 'select,insert,update,references',
'Comment' => '',
)
Thank you for that information. Next, please tell me the result you get from the following PHP code:
<?php
require_once('SSI.php');
$msgs = array();
$request = $smcFunc['db_query']('', '
SELECT id_msg, body
FROM {db_prefix}messages
WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg',
array(
'message_list' => array(260503, 265469),
)
);
while ($row = $smcFunc['db_fetch_assoc']($request))
{
$msgs[$row['id_msg']] = htmlspecialchars(mb_encode_numericentity($row['body'], array(0x80,0x10FFFF,0x0,0xFFFFFF), 'UTF-8'));
}
echo '<pre>';
var_export($msgs);
echo '</pre>';
array (
260503 => '<br />https://m.youtube.com/watch?v=EHV0zs0kVGg',
265469 => '[quote author=SierraParty link=msg=265467 date=1645688024]<br>[quote author=Ghostlabrax link=msg=265459 date=1645636522]<br>Mírate el DT5016 de D1.<br><br>No sé qué tamaño estás buscando<br><br>€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g<br>https://a.aliexpress.com/_voS2lz<br>[/quote]<br><br>Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.<br><br>Gracias por adelantado<br><br><br>[/quote]<br><br>Buenas,<br><br>Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico. <br><br>Puedes preguntarle a Alberto que tiene una review en su canal<br><br>https://youtu.be/e_kjcsDpAmY<br><br>Un saludo',
)
Quote from: shawnb61 on February 25, 2022, 12:08:51 PMIf you modify the posts, and can see the BBC, is there a visible difference between the links that work and the links that do not work?
E.g., do they look like this?
Can you share examples of what they look like? The ones that work & the ones that don't?
Quote from: shawnb61 on February 25, 2022, 02:44:58 PMQuote from: shawnb61 on February 25, 2022, 12:08:51 PMIf you modify the posts, and can see the BBC, is there a visible difference between the links that work and the links that do not work?
E.g., do they look like this?
Can you share examples of what they look like? The ones that work & the ones that don't?
Your codes.
(https://i.ibb.co/tJKCtWN/image.png)
Your codes after using QUICK EDIT.
(https://i.ibb.co/Ph2Xpxr/image.png)
Something is clearly interfering while posts are being processed in Display.php but not in other situations.
When you use Quick Edit, for example, the edited text is passed through a different set of functions than when a post is initially prepared for display. Likewise, I notice that when I view posts in your forum's Recent Topics (https://www.rapaleando.com/foros/index.php?action=recent) page, the automatic links always work, even if they do not work when the same post is viewed in the topic display.
Since the problem appears to be specific to the topic display, but there were no changes in your Display.php file, I now suspect that an integration hook is somehow involved.
Please go to Administration Center ► Forum Maintenance ► Integration Hooks and get a list of all integration hooks listed there, then share that with us.
Yeah, but he says they work everywhere after he removes 'the extra stuff'...
I am wondering if maybe an old 2.0 mod altered the url tag somehow.
I am trying (and failing miserably... ::) ) to understand what the difference is between the links that work and the links that do not...
@rapalero - I do not want to see the links I provided. Those were just examples. I want to see YOUR links... Which ones work & which ones don't. What do YOUR links look like - good & bad?
Quote from: Sesquipedalian on February 25, 2022, 04:20:43 PMSomething is clearly interfering while posts are being processed in Display.php but not in other situations.
When you use Quick Edit, for example, the edited text is passed through a different set of functions than when a post is initially prepared for display. Likewise, I notice that when I view posts in your forum's Recent Topics (https://www.rapaleando.com/foros/index.php?action=recent) page, the automatic links always work, even if they do not work when the same post is viewed in the topic display.
Since the problem appears to be specific to the topic display, but there were no changes in your Display.php file, I now suspect that an integration hook is somehow involved.
Please go to Administration Center ► Forum Maintenance ► Integration Hooks and get a list of all integration hooks listed there, then share that with us.
There are no hooks.
(https://i.ibb.co/kGyyrqS/image.png)
Quote from: shawnb61 on February 25, 2022, 04:34:55 PMYeah, but he says they work everywhere after he removes 'the extra stuff'...
I am wondering if maybe an old 2.0 mod altered the url tag somehow.
I am trying (and failing miserably... ::) ) to understand what the difference is between the links that work and the links that do not...
@rapalero - I do not want to see the links I provided. Those were just examples. I want to see YOUR links... Which ones work & which ones don't. What do YOUR links look like - good & bad?
Thank you for your patience. Currently the links I post are not working. With or without code, they do not work. No way, only QUICK EDIT.
Hm. This is really weird.
Please run this test for me. It is very similar to the previous one, but it will include more information.
<?php
require_once('SSI.php');
$msgs = array();
$request = $smcFunc['db_query']('', '
SELECT id_msg, body
FROM {db_prefix}messages
WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg',
array(
'message_list' => array(260503, 265469, 265506, 265517),
)
);
while ($row = $smcFunc['db_fetch_assoc']($request))
{
$msgs[$row['id_msg']]['raw'] = htmlspecialchars(mb_encode_numericentity($row['body'], array(0x80,0x10FFFF,0x0,0xFFFFFF), 'UTF-8'));
$msgs[$row['id_msg']]['cached'] = parse_bbc($row['body'], true, $row['id_msg']);
$msgs[$row['id_msg']]['parsed'] = parse_bbc($row['body'], true);
}
echo '<pre>';
var_export($msgs);
echo '</pre>';
Quote from: Sesquipedalian on February 27, 2022, 08:16:16 PMHm. This is really weird.
Please run this test for me. It is very similar to the previous one, but it will include more information.
<?php
require_once('SSI.php');
$msgs = array();
$request = $smcFunc['db_query']('', '
SELECT id_msg, body
FROM {db_prefix}messages
WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg',
array(
'message_list' => array(260503, 265469, 265506, 265517),
)
);
while ($row = $smcFunc['db_fetch_assoc']($request))
{
$msgs[$row['id_msg']]['raw'] = htmlspecialchars(mb_encode_numericentity($row['body'], array(0x80,0x10FFFF,0x0,0xFFFFFF), 'UTF-8'));
$msgs[$row['id_msg']]['cached'] = parse_bbc($row['body'], true, $row['id_msg']);
$msgs[$row['id_msg']]['parsed'] = parse_bbc($row['body'], true);
}
echo '<pre>';
var_export($msgs);
echo '</pre>';
Thanks.
array (
260503 =>
array (
'raw' => '<br />https://m.youtube.com/watch?v=EHV0zs0kVGg',
'cached' => '
https://m.youtube.com/watch?v=EHV0zs0kVGg',
'parsed' => '
https://m.youtube.com/watch?v=EHV0zs0kVGg',
),
265469 =>
array (
'raw' => '[quote author=SierraParty link=msg=265467 date=1645688024]<br>[quote author=Ghostlabrax link=msg=265459 date=1645636522]<br>Mírate el DT5016 de D1.<br><br>No sé qué tamaño estás buscando<br><br>€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g<br>https://a.aliexpress.com/_voS2lz<br>[/quote]<br><br>Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.<br><br>Gracias por adelantado<br><br><br>[/quote]<br><br>Buenas,<br><br>Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico. <br><br>Puedes preguntarle a Alberto que tiene una review en su canal<br><br>https://youtu.be/e_kjcsDpAmY<br><br>Un saludo',
'cached' => '
Cita de: SierraParty en 24 de Febrero de 2022, 07:33:44 AM
Cita de: Ghostlabrax en 23 de Febrero de 2022, 17:15:22 PMMírate el DT5016 de D1.
No sé qué tamaño estás buscando
€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g
https://a.aliexpress.com/_voS2lz
Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.
Gracias por adelantado
Buenas,
Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico.
Puedes preguntarle a Alberto que tiene una review en su canal
https://youtu.be/e_kjcsDpAmY
Un saludo',
'parsed' => '
Cita de: SierraParty en 24 de Febrero de 2022, 07:33:44 AM
Cita de: Ghostlabrax en 23 de Febrero de 2022, 17:15:22 PMMírate el DT5016 de D1.
No sé qué tamaño estás buscando
€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g
https://a.aliexpress.com/_voS2lz
Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.
Gracias por adelantado
Buenas,
Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico.
Puedes preguntarle a Alberto que tiene una review en su canal
https://youtu.be/e_kjcsDpAmY
Un saludo',
),
265506 =>
array (
'raw' => '[quote author=Toni.v link=msg=265502 date=1645878067]<br>alguien sabe si hay alguna copia decente del fakie dog el de 90mm.tenia 2 originales y los e perdido.<br>[/quote]<br><br>En 70mm tienes este: https://s.click.aliexpress.com/e/_A7wjG1<br><br>Después en 90mm te recomendaría este otro: https://s.click.aliexpress.com/e/_9yqN8t<br>Es más bien una copia del pugachev pero muy similar al fakie y con efectividad contrastada. Lance y movimiento de 10.',
'cached' => '
Cita de: Toni.v en 26 de Febrero de 2022, 12:21:07 PMalguien sabe si hay alguna copia decente del fakie dog el de 90mm.tenia 2 originales y los e perdido.
En 70mm tienes este: https://s.click.aliexpress.com/e/_A7wjG1
Después en 90mm te recomendaría este otro: https://s.click.aliexpress.com/e/_9yqN8t
Es más bien una copia del pugachev pero muy similar al fakie y con efectividad contrastada. Lance y movimiento de 10.',
'parsed' => '
Cita de: Toni.v en 26 de Febrero de 2022, 12:21:07 PMalguien sabe si hay alguna copia decente del fakie dog el de 90mm.tenia 2 originales y los e perdido.
En 70mm tienes este: https://s.click.aliexpress.com/e/_A7wjG1
Después en 90mm te recomendaría este otro: https://s.click.aliexpress.com/e/_9yqN8t
Es más bien una copia del pugachev pero muy similar al fakie y con efectividad contrastada. Lance y movimiento de 10.',
),
265517 =>
array (
'raw' => 'Yo tengo la copia en 70 que te han puesto arriba y se mueve bastante bien, pero de TODO aliexpress con el que estoy sacando el 80% de mis capturas es el Sparrow. Es mi killer, mi quita bolos, el infalible, si hay lubinas en mi zona le zumban (costa de Girona).<br><br>https://a.aliexpress.com/_v5col3<br><br>',
'cached' => 'Yo tengo la copia en 70 que te han puesto arriba y se mueve bastante bien, pero de TODO aliexpress con el que estoy sacando el 80% de mis capturas es el Sparrow. Es mi killer, mi quita bolos, el infalible, si hay lubinas en mi zona le zumban (costa de Girona).
https://a.aliexpress.com/_v5col3
',
'parsed' => 'Yo tengo la copia en 70 que te han puesto arriba y se mueve bastante bien, pero de TODO aliexpress con el que estoy sacando el 80% de mis capturas es el Sparrow. Es mi killer, mi quita bolos, el infalible, si hay lubinas en mi zona le zumban (costa de Girona).
https://a.aliexpress.com/_v5col3
',
),
)
Does it work if you change the <br /> to <br>, removing the space & /?
Quote from: shawnb61 on February 28, 2022, 10:20:40 AMDoes it work if you change the <br /> to <br>, removing the space & /?
Excuse me, can you be more specific? I got lost.
instead of removing, just do a global replace in the signature field of the database of all <br /> to be <br>
@rapalero - when you edit one of the messages with the problem, and you see this somewhere in the message:
<br />
If you change it to:
<br>
...does the link then work?
More questions:
What browser are you using? Have you tried a different browser?
Quote from: shawnb61 on March 01, 2022, 10:11:50 AM@rapalero - when you edit one of the messages with the problem, and you see this somewhere in the message:
<br />
If you change it to:
<br>
...does the link then work?
More questions:
What browser are you using? Have you tried a different browser?
Understood. Thank you. The messages do not contain the
br
Quote from: Kindred on March 01, 2022, 10:05:07 AMinstead of removing, just do a global replace in the signature field of the database of all <br /> to be <br>
Thank you for your response.
Would you be so kind as to direct me how I can do that?
Another question:
Do you have "Enable basic HTML in posts" checked in your BBC settings?
If it's not enabled, please enable it and see if the issue goes away.
Quote from: shawnb61 on March 01, 2022, 10:28:22 AMAnother question:
Do you have "Enable basic HTML in posts" checked in your BBC settings?
If it's not enabled, please enable it and see if the issue goes away.
Yes, enabled all in "BBC CODES".
I use Chrome or Edge.
Quote from: rapalero on March 01, 2022, 10:50:29 AMYes, enabled all in "BBC CODES".
This is not one of the BBC codes, it is an option to enable html at the top of the bbc settings page. See the attached.
Could you enable this & report back?
(I can reproduce this problem by having basic html
disabled and having basic html (such as <br />) adjacent to the links in question...)
Quote from: shawnb61 on March 01, 2022, 11:57:16 AMQuote from: rapalero on March 01, 2022, 10:50:29 AMYes, enabled all in "BBC CODES".
This is not one of the BBC codes, it is an option to enable html at the top of the bbc settings page. See the attached.
Could you enable this & report back?
(I can reproduce this problem by having basic html disabled and having basic html (such as <br />) adjacent to the links in question...)
Always enabled.
One more test, again similar to the previous one:
<?php
require_once('SSI.php');
$msgs = array();
$request = $smcFunc['db_query']('', '
SELECT id_msg, body
FROM {db_prefix}messages
WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg',
array(
'message_list' => array(260503, 265469, 265506, 265517),
)
);
while ($row = $smcFunc['db_fetch_assoc']($request))
{
$msgs[$row['id_msg']]['raw'] = htmlspecialchars(mb_encode_numericentity($row['body'], array(0x80,0x10FFFF,0x0,0xFFFFFF), 'UTF-8'));
$msgs[$row['id_msg']]['cached'] = htmlspecialchars(parse_bbc($row['body'], true, $row['id_msg']));
$msgs[$row['id_msg']]['parsed'] = htmlspecialchars(parse_bbc($row['body'], true));
}
echo '<pre>';
var_export($msgs);
echo '</pre>';
Quote from: Sesquipedalian on March 01, 2022, 01:22:18 PMOne more test, again similar to the previous one:
<?php
require_once('SSI.php');
$msgs = array();
$request = $smcFunc['db_query']('', '
SELECT id_msg, body
FROM {db_prefix}messages
WHERE id_msg IN ({array_int:message_list})
ORDER BY id_msg',
array(
'message_list' => array(260503, 265469, 265506, 265517),
)
);
while ($row = $smcFunc['db_fetch_assoc']($request))
{
$msgs[$row['id_msg']]['raw'] = htmlspecialchars(mb_encode_numericentity($row['body'], array(0x80,0x10FFFF,0x0,0xFFFFFF), 'UTF-8'));
$msgs[$row['id_msg']]['cached'] = htmlspecialchars(parse_bbc($row['body'], true, $row['id_msg']));
$msgs[$row['id_msg']]['parsed'] = htmlspecialchars(parse_bbc($row['body'], true));
}
echo '<pre>';
var_export($msgs);
echo '</pre>';
Thanks.
array (
260503 =>
array (
'raw' => '<br />https://m.youtube.com/watch?v=EHV0zs0kVGg',
'cached' => '<br /><a href="https://m.youtube.com/watch?v=EHV0zs0kVGg" class="bbc_link" target="_blank" rel="noopener">https://m.youtube.com/watch?v=EHV0zs0kVGg</a>',
'parsed' => '<br /><a href="https://m.youtube.com/watch?v=EHV0zs0kVGg" class="bbc_link" target="_blank" rel="noopener">https://m.youtube.com/watch?v=EHV0zs0kVGg</a>',
),
265469 =>
array (
'raw' => '[quote author=SierraParty link=msg=265467 date=1645688024]<br>[quote author=Ghostlabrax link=msg=265459 date=1645636522]<br>Mírate el DT5016 de D1.<br><br>No sé qué tamaño estás buscando<br><br>€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g<br>https://a.aliexpress.com/_voS2lz<br>[/quote]<br><br>Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.<br><br>Gracias por adelantado<br><br><br>[/quote]<br><br>Buenas,<br><br>Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico. <br><br>Puedes preguntarle a Alberto que tiene una review en su canal<br><br>https://youtu.be/e_kjcsDpAmY<br><br>Un saludo',
'cached' => '<blockquote class="bbc_standard_quote"><cite><a href="https://www.rapaleando.com/foros/index.php?msg=265467">Cita de: SierraParty en 24 de Febrero de 2022, 07:33:44 AM</a></cite><blockquote class="bbc_alternate_quote"><cite><a href="https://www.rapaleando.com/foros/index.php?msg=265459">Cita de: Ghostlabrax en 23 de Febrero de 2022, 17:15:22 PM</a></cite>Mírate el DT5016 de D1.<br><br>No sé qué tamaño estás buscando<br><br>€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g<br><a href="https://a.aliexpress.com/_voS2lz" class="bbc_link" target="_blank" rel="noopener">https://a.aliexpress.com/_voS2lz</a><br></blockquote><br>Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.<br><br>Gracias por adelantado<br><br><br></blockquote><br>Buenas,<br><br>Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico. <br><br>Puedes preguntarle a Alberto que tiene una review en su canal<br><br><a href="https://youtu.be/e_kjcsDpAmY" class="bbc_link" target="_blank" rel="noopener">https://youtu.be/e_kjcsDpAmY</a><br><br>Un saludo',
'parsed' => '<blockquote class="bbc_standard_quote"><cite><a href="https://www.rapaleando.com/foros/index.php?msg=265467">Cita de: SierraParty en 24 de Febrero de 2022, 07:33:44 AM</a></cite><blockquote class="bbc_alternate_quote"><cite><a href="https://www.rapaleando.com/foros/index.php?msg=265459">Cita de: Ghostlabrax en 23 de Febrero de 2022, 17:15:22 PM</a></cite>Mírate el DT5016 de D1.<br><br>No sé qué tamaño estás buscando<br><br>€ 8,79 30%de DESCUENTO | D1-señuelo de Pesca de Mar, DT5016, 190mm, 37g<br><a href="https://a.aliexpress.com/_voS2lz" class="bbc_link" target="_blank" rel="noopener">https://a.aliexpress.com/_voS2lz</a><br></blockquote><br>Disculpa, por preguntarte de nuevo ¿Qué tal lance tiene? Por que pregunté ayer por él y ahora una de las tiendas me ofrece enviarme algunos gratis para probar a cambio de fotos. No quiero comprometerme si luego sólo hace el "helicóptero" a cada lance.<br><br>Gracias por adelantado<br><br><br></blockquote><br>Buenas,<br><br>Pues yo no lo he probado pues se aleja del tipo de señuelos/pesca que practico. <br><br>Puedes preguntarle a Alberto que tiene una review en su canal<br><br><a href="https://youtu.be/e_kjcsDpAmY" class="bbc_link" target="_blank" rel="noopener">https://youtu.be/e_kjcsDpAmY</a><br><br>Un saludo',
),
265506 =>
array (
'raw' => '[quote author=Toni.v link=msg=265502 date=1645878067]<br>alguien sabe si hay alguna copia decente del fakie dog el de 90mm.tenia 2 originales y los e perdido.<br>[/quote]<br><br>En 70mm tienes este: https://s.click.aliexpress.com/e/_A7wjG1<br><br>Después en 90mm te recomendaría este otro: https://s.click.aliexpress.com/e/_9yqN8t<br>Es más bien una copia del pugachev pero muy similar al fakie y con efectividad contrastada. Lance y movimiento de 10.',
'cached' => '<blockquote class="bbc_standard_quote"><cite><a href="https://www.rapaleando.com/foros/index.php?msg=265502">Cita de: Toni.v en 26 de Febrero de 2022, 12:21:07 PM</a></cite>alguien sabe si hay alguna copia decente del fakie dog el de 90mm.tenia 2 originales y los e perdido.<br></blockquote><br>En 70mm tienes este: <a href="https://s.click.aliexpress.com/e/_A7wjG1" class="bbc_link" target="_blank" rel="noopener">https://s.click.aliexpress.com/e/_A7wjG1</a><br><br>Después en 90mm te recomendaría este otro: <a href="https://s.click.aliexpress.com/e/_9yqN8t" class="bbc_link" target="_blank" rel="noopener">https://s.click.aliexpress.com/e/_9yqN8t</a><br>Es más bien una copia del pugachev pero muy similar al fakie y con efectividad contrastada. Lance y movimiento de 10.',
'parsed' => '<blockquote class="bbc_standard_quote"><cite><a href="https://www.rapaleando.com/foros/index.php?msg=265502">Cita de: Toni.v en 26 de Febrero de 2022, 12:21:07 PM</a></cite>alguien sabe si hay alguna copia decente del fakie dog el de 90mm.tenia 2 originales y los e perdido.<br></blockquote><br>En 70mm tienes este: <a href="https://s.click.aliexpress.com/e/_A7wjG1" class="bbc_link" target="_blank" rel="noopener">https://s.click.aliexpress.com/e/_A7wjG1</a><br><br>Después en 90mm te recomendaría este otro: <a href="https://s.click.aliexpress.com/e/_9yqN8t" class="bbc_link" target="_blank" rel="noopener">https://s.click.aliexpress.com/e/_9yqN8t</a><br>Es más bien una copia del pugachev pero muy similar al fakie y con efectividad contrastada. Lance y movimiento de 10.',
),
265517 =>
array (
'raw' => 'Yo tengo la copia en 70 que te han puesto arriba y se mueve bastante bien, pero de TODO aliexpress con el que estoy sacando el 80% de mis capturas es el Sparrow. Es mi killer, mi quita bolos, el infalible, si hay lubinas en mi zona le zumban (costa de Girona).<br><br>https://a.aliexpress.com/_v5col3<br><br>',
'cached' => 'Yo tengo la copia en 70 que te han puesto arriba y se mueve bastante bien, pero de TODO aliexpress con el que estoy sacando el 80% de mis capturas es el Sparrow. Es mi killer, mi quita bolos, el infalible, si hay lubinas en mi zona le zumban (costa de Girona).<br><br><a href="https://a.aliexpress.com/_v5col3" class="bbc_link" target="_blank" rel="noopener">https://a.aliexpress.com/_v5col3</a><br><br>',
'parsed' => 'Yo tengo la copia en 70 que te han puesto arriba y se mueve bastante bien, pero de TODO aliexpress con el que estoy sacando el 80% de mis capturas es el Sparrow. Es mi killer, mi quita bolos, el infalible, si hay lubinas en mi zona le zumban (costa de Girona).<br><br><a href="https://a.aliexpress.com/_v5col3" class="bbc_link" target="_blank" rel="noopener">https://a.aliexpress.com/_v5col3</a><br><br>',
),
)
Thanks,
@rapalero. That last test confirms for me that the problem is not with parsing the messages in general, but rather that it is something specific to the topic display pages. The exact nature of the problem remains a mystery at this point, but this does help to narrow down the range of possibilities.
i have same problem.
Quote from: Plus on March 13, 2022, 10:35:27 AMi have same problem.
Did you also update to 2.1.1 from 2.0.x? Do you have the same mods as the OP? Are your BBC settings identical? Do you see the same behavior with regards to preview, editing, and manually adding URL tags?
Maybe this report will help someone...
I had this problem (no active link).
I was using the normal RC4, upgraded to 2.1.0, then I installed Patch 2.1.1. Then I discovered this problem...
I reinstalled my RC4 DB and upgraded 2.1.1 straight.
The problem disappeared. The error stayed in the old DB!
One user having this issue provided some more details.
Apparently disabling the URL bbc's for signatures will cause this. Could this also be your problem?
Tested.
All links in topics stop working and not just in the signature!
Well if you disable the url bbcode then none of the links will work...
Well, based on the settings signatures should be separate from the posts - So that smells like a bug to me.
Quote from: Arantor on March 30, 2022, 04:00:06 AMWell if you disable the url bbcode then none of the links will work...
Yes.
But this would be signature only!
Quote from: Aleksi on March 30, 2022, 06:24:22 AMWell, based on the settings signatures should be separate from the posts - So that smells like a bug to me.
I also think. Not the "general" bbc
I just tried this setting on my forum (2.1.1) and it works as it should: setting for signatures did not affect url s in Posts ...
Interesting. I just tried and it did break urls for new posts.
My test case, both the signature and the post works if signatures are allowed the URL BBC https://smf.kilpinenonline.net/smf21/index.php?topic=1.msg3#new
This makes sense, the list of bbcodes for signatures is loaded (loadMemberData/loadMemberContext) ahead of posts (prepareDisplayContext) and apparently kept.
I seem to recall SMF 2.0 separating these and treating signatures as a sub-case of "specify which bbcodes to use" which means the bbcode array shouldn't be cached, but decent chunks of the parser were overhauled in 2.1.
In my case it's not just "new" links. It's all of them. Some 4, 5 years old.
Quote from: marcosbr on March 30, 2022, 10:58:14 AMIn my case it's not just "new" links. It's all of them. Some 4, 5 years old.
I just did a test post on a clean install, so I didn't mean to say only new posts,
just that I only tested with a new post specifically.
Why would it make a difference between old or new? The parser doesn't get told how old a post is, it's just given the text to process bbcode :)
Quote from: @rjen on March 30, 2022, 09:05:26 AMI just tried this setting on my forum (2.1.1) and it works as it should: setting for signatures did not affect url s in Posts ...
It's just information. It doesn't seem to have reached everyone. I only inform and await your corrections ;)
Went to track this, noticed someone beat me to it :) Thanks isaak! #7404 (https://github.com/SimpleMachines/SMF2.1/issues/7404)
Quote from: marcosbr on March 29, 2022, 07:18:56 PMTested.
All links in topics stop working and not just in the signature!
Works!!!
(https://c.tenor.com/N3WYIkTYQ7YAAAAS/happy-cheerful.gif)
I also have problem that insert link works fine during preview but not after posting, however if I go to quick edit and hit save link is formatted correctly and works.
I see you have double posted about this problem here (https://www.simplemachines.org/community/index.php?topic=583085.0). Let's continue the support at the other topic. :)
Fixed in 2.1.3.