Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Steve on April 19, 2022, 02:18:21 PM

Title: Merge Topics Bug?
Post by: Steve on April 19, 2022, 02:18:21 PM
I tried to merge this topic:

https://www.simplemachines.org/community/index.php?topic=581906.0

and this topic:

https://www.simplemachines.org/community/index.php?topic=576301.0

and got this error:

Merge topics requires at least two topics to merge.

Bug or something else?

[edit] link fixed --Illori
Title: Re: Merge Topics Bug?
Post by: Diego Andrés on April 19, 2022, 02:20:35 PM
Perhaps is because the topic is pending approval?
Title: Re: Merge Topics Bug?
Post by: Arantor on April 19, 2022, 02:24:51 PM
You should be able to merge even unapproved topics if you are the merger have permission to approve posts in the board where the target topic will end up.
Title: Re: Merge Topics Bug?
Post by: Diego Andrés on April 19, 2022, 02:29:26 PM
I noticed the first post is linking to a different topic that the intended one, it's supposed to be this one:
https://www.simplemachines.org/community/index.php?topic=581906.0

Not that it makes any difference I suppose.
Title: Re: Merge Topics Bug?
Post by: Arantor on April 19, 2022, 02:32:10 PM
Also, I'm not sure merging things into mod threads is necessarily a good idea? Though I haven't seen the code for the new mod site - but in the old mod site Bad Things could happen if this were done incorrectly.
Title: Re: Merge Topics Bug?
Post by: Diego Andrés on April 19, 2022, 02:37:35 PM
Tried locally with no issues, shows up as an unapproved post in the mod topic, so no clues at the moment.
Title: Re: Merge Topics Bug?
Post by: Illori on April 19, 2022, 02:56:25 PM
When you go to merge the 2 topics it only shows you one topic to merge. It should have 2 topics here instead of one. Screenshot_20220419-145439.png
Title: Re: Merge Topics Bug?
Post by: Arantor on April 19, 2022, 03:05:25 PM
Do you have permission to merge topics in the relevant board? The mod board's permissions are special IIRC.
Title: Re: Merge Topics Bug?
Post by: Illori on April 19, 2022, 03:09:13 PM
Looks like I do.
Title: Re: Merge Topics Bug?
Post by: Steve on April 19, 2022, 03:38:17 PM
Thanks for the correction Diego. The one you linked to is actually the one I tried to merge with the other my first post. And I tried merging in either direction, i.e. starting with https://www.simplemachines.org/community/index.php?topic=581906.0 and when that didn't work I tried it the other way, starting with https://www.simplemachines.org/community/index.php?topic=576301.0 ... same error.
Title: Re: Merge Topics Bug?
Post by: Steve on April 19, 2022, 03:41:30 PM
Quote from: Diego Andrés on April 19, 2022, 02:20:35 PMPerhaps is because the topic is pending approval?
Apparently the topic must be approved first. I approved it and the merge went without a hitch.