Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: Sir Osis of Liver on January 16, 2023, 08:17:40 PM

Title: 2.1 attachments
Post by: Sir Osis of Liver on January 16, 2023, 08:17:40 PM
Shortly after 2.1 was officially released last year, there were several efforts in progress to modify the attachments feature.  I have one running on a test install (still using 2.0 in production), but memory being what it is (or isn't), not comfortable trying to replicate it on client forum.  Antechinus did a more extensive rewrite, and there were a couple others.  Question is, were any of the variants packaged as mods?
Title: Re: 2.1 attachments
Post by: Kindred on January 16, 2023, 10:46:14 PM
I don't believe so
Title: Re: 2.1 attachments
Post by: Antechinus on January 23, 2023, 04:55:05 AM
Frankly, I've lost interest. At the time the 2.1 attachments system was full of bugs, and I don't actually have a use for an SMF forum at the moment anyway. The only sites I'm using happen to be running phpBB, which is not my first preference but, hey ho, that's what they use.

Anyone is obviously welcome to rip and to modify any code I have posted here. You might even be able to get me to answers some questions, if there are any.
Title: Re: 2.1 attachments
Post by: Diego Andrés on January 24, 2023, 12:05:18 AM
Could try the possibly new UI for attachments @Sir Osis of Liver
Maybe you'd have suggestions too.

https://github.com/SimpleMachines/SMF/pull/7676
Title: Re: 2.1 attachments
Post by: Sir Osis of Liver on January 24, 2023, 04:11:15 PM
That's interesting.  It was my understanding that there would be no significant changes in attachments in 2.1, no matter how awful it was.  Is that code packaged for download?

Title: Re: 2.1 attachments
Post by: @rjen on January 24, 2023, 04:13:49 PM
No, it's a PR waiting to be merged for 2.1.4
Title: Re: 2.1 attachments
Post by: Sesquipedalian on January 25, 2023, 11:55:30 AM
Quote from: Sir Osis of Liver on January 24, 2023, 04:11:15 PMIt was my understanding that there would be no significant changes in attachments in 2.1.

@shawnb61 decided otherwise.
Title: Re: 2.1 attachments
Post by: Sir Osis of Liver on January 25, 2023, 12:02:44 PM
Good call.  Looking forward to seeing it in 2.1.4.
Title: Re: 2.1 attachments
Post by: Sesquipedalian on January 25, 2023, 12:38:40 PM
As a rule, changes to the default theme's files are avoided in patch releases because they carry a high risk of breaking any existing custom themes. But in this case I was able to figure out a way to maintain backward compatibility. If I hadn't been able to do that, this probably would have had to wait until 2.2.