Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: User2 on January 18, 2023, 09:10:45 AM

Title: Replace the "Quick edit" button with "Modify".
Post by: User2 on January 18, 2023, 09:10:45 AM
Hello.
I have hidden "Quick replay" and therefore I don't need the "Quick edit" button.
What should I do to display the "Modify" button instead of the "Quick edit" button?
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 18, 2023, 11:37:38 AM
Quick reply and quick edit are two different things.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: User2 on January 18, 2023, 12:00:20 PM
Sir Osis of Liver, the "Quick edit" button is not working on my forum right now: I click on it and nothing happens. I understand that the command is passed to the "Quick replay" window. Or am I wrong?
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 18, 2023, 12:03:18 PM
No, it opens an edit window in the post, not in quick reply.  Try it here.  Are you seeing any errors in forum error log?

If you have javascript disabled in your browser, nothing will happen when you click quick edit.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: User2 on January 18, 2023, 12:21:16 PM
Sir Osis of Liver, I hid the "Quick Reply" window with a tip from this topic, message #14: https://www.simplemachines.org/community/index.php?msg=4143361
After that, the "Quick edit" button stopped working.

Quote from: Sir Osis of Liver on January 18, 2023, 12:03:18 PMAre you seeing any errors in forum error log?
I'm just a user and sometimes I go to the Admin Panel, so I don't know where to look.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Kindred on January 18, 2023, 06:57:29 PM
If quick edit is not working, then the forum either has broken Javascript or you have Javascript turned off in your browser.


If you edited code, then you probably broke something
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 18, 2023, 08:04:46 PM
Does quick edit work for you in this topic?

Edit: test of quick edit
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Steve on January 18, 2023, 08:14:03 PM
Yep.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 18, 2023, 08:30:10 PM
Well, the question is for the OP to try it here, to determine if it's a browser issue.  I know it works for you, Steve.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Steve on January 18, 2023, 09:46:10 PM
Sorry, excuse the interruption.  :P
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: User2 on January 19, 2023, 09:10:29 AM
The "Quick edit" button stops working when I hide the "Quick replay".
If I don't hide the "Quick replay", then the "Quick edit" button works.

I hid the "Quick Reply" window with a tip from this topic, message #14: https://www.simplemachines.org/community/index.php?msg=4143361
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 19, 2023, 03:29:49 PM
Confirmed, that edit breaks quit edit.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Diego Andrés on January 19, 2023, 03:35:11 PM
Some script must be inside that sub_template?

I guess the edit should be different.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 19, 2023, 03:45:10 PM
Not finding it.  >:(
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Diego Andrés on January 19, 2023, 03:49:47 PM
I only see some quote references  ???
Would need to test it later.

Could also use this mod to hide the quick reply: https://custom.simplemachines.org/index.php?mod=4351
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 19, 2023, 04:37:37 PM
index.css


/* Styles for the quick reply area. */
#quickreply {
    clear: both;
    display: none;
}



   (https://thekrashsite.com/pics/fp.gif)

Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Illori on January 19, 2023, 04:48:07 PM
That does not redirect the quote function to the full editor, it would just silently fail.
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 19, 2023, 04:51:03 PM
Yes, you'd pointed that out once before.  Forgot that, too.  :(

So you can't remove quick reply without fixing the redirect.

Diego's mod does that, use the mod.

Title: Re: Replace the "Quick edit" button with "Modify".
Post by: User2 on January 20, 2023, 04:38:12 AM
Yes, the "Enhanced Quick Reply" MOD solved the problem.
But I would like to make more changes. I would like the "Modify" button to be displayed so that it is visible, and not so that the visitor navigates through "MORE..." in the menu.
Кнопку "Quick edit" или вообще удалить (так хотелось бы) или если удалить нельзя, то спрятать в меню "MORE...".
How to do it?
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: User2 on January 20, 2023, 06:55:41 AM
The "Quick edit" button or delete it altogether (I would like to), or if you can't delete it, then hide it in the "MORE..." menu.
How to do it?
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Steve on January 20, 2023, 08:35:52 AM
You're starting to getting into redesigning the system. For these type of questions, they should really be asked here: SMF Coding Discussion (https://www.simplemachines.org/community/index.php?board=60.0)
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 20, 2023, 12:14:26 PM
So basically you want to replace Quick Edit with Modify?  (Not a bad idea.)

https://www.simplemachines.org/community/index.php?topic=584814.msg4143648#msg4143648

Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Kindred on January 20, 2023, 02:47:49 PM
personally, I think it's a terrible idea.   most of the time, when I modify an existing message, I want it done INLINE, without another pageload
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Sir Osis of Liver on January 20, 2023, 08:28:59 PM
I think it's more a matter of experience level.  If you're running a forum that's populated by people who are unfamiliar with forums, or you have an older membership, a simpler ui makes life easier for them.  Once you've removed quick reply and quick edit, all post edits are done in the reply post editor, so it's always the same.  This is one of those things where it's really up to the forum owner and his members to decide if it's a good or bad idea.  It doesn't break anything, and is simple to undo.

Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Kindred on January 20, 2023, 08:56:09 PM
Of course, that's why I prefaced the statement with "personally,  in think..."
Statement of opinion
Title: Re: Replace the "Quick edit" button with "Modify".
Post by: Steve on January 21, 2023, 07:23:50 AM
Marking this solved as he has posted his question here: SMF Coding Discussion (https://www.simplemachines.org/community/index.php?board=60.0)