Hi all,
I've posted a few times over the past few days, for the first time in a very long time. I have experienced several problems editing my posts here before actually posting them. If I need to go back earlier in the post to change something, the cursor immediately skips to the end of the line or sentence. The only workaround is to go back further, enter a return, edit the offending passage, and the remove the return. I think this has occurred three times in about ten posts.
I experienced similar problem with SMF 2, which is why I disabled it our forum. I will be upgrading to SMF 2.1 soon, and was looking forward to a properly functioning text editor for members. Looks like this is not the case.
Windows 10 and 11; Firefox.
Source view or wysiwyg?
Any browser addons that might affect page contents?
Windows 10 and FF here as well, no issues with the editor.
Quote from: Aleksi on February 22, 2023, 10:38:27 AMSource view or wysiwyg?
Any browser addons that might affect page contents?
Windows 10 and FF here as well, no issues with the editor.
Hi
@Aleksi "Lex" Kilpinen. This computer is Windows 10, with two add-ons (both previously disabled).
I'm having the same problem AGAIN! I was about to edit the above sentence to add this as my initial comment: WYSIWYG.
Okay, I avoid wysiwyg features myself so I'm always running in source view. This may go some length to explaining why I don't see the same behaviour - But it would be nice, if you tried a couple of things to narrow things down a bit.
One) Just empty your browser cache. Then do a hard refresh inside the topic, and see how the editor behaves after.
Two) If it still is not behaving, try turning off wysiwyg and see if the editor stops acting up.
OK. I did not clear my cache, but I an now in an Incognito window. I've also hard refreshed.
Some random thoughts for testing purposes: I have been a long-time user of SMF - since 2004. I disabled the WYSIWYG editor in SMF 2 because I found that too buggy; I think this one is even worse. I am about to upgrade to 2.1, but this is almost a killer. I mean, it will not stop me (since I am not using WYSIWYG is 2.0), but it does make me consider moving to another software.
The bug has not kicked in yet. It seems to occur in about a third of my posts. So, I might have give up on this test. But I'll continue to post using this incognito window and see what happens.
well, we acknowledge that the WYSIWYG editor in 2.0 was sub-par... but SCEditor is pretty mature and doesn't have all that many issues.
I can't see to reproduce your issue in my Win10/FF usage, but I'll recheck again.
Hi
@Aleksi "Lex" Kilpinen.
Quote from: Kindred on February 22, 2023, 11:59:01 AMwell, we acknowledge that the WYSIWYG editor in 2.0 was sub-par... but SCEditor is pretty mature and doesn't have all that many issues.
I can't see to reproduce your issue in my Win10/FF usage, but I'll recheck again.
Thanks,
@Kindred. I'll keep trying.
I can confirm when you go to edit a post the cursor starts at the end.. However I don't think that is a bug. That is just default behavior .
If I click somewhere earlier in the post while editing, it doesn't move or jump anywhere. It stays where I clicked and allows me to edit. Using Windows 11 and OpenSuse with Firefox.
-------
Just for confirmation, are you saying if you click elsewhere in the post while editing, it jumps to the end again?
Quote from: Col on February 22, 2023, 11:09:14 AMI mean, it will not stop me (since I am not using WYSIWYG is 2.0), but it does make me consider moving to another software.
1. Most of the places I go to that has posting has about the same thing with cursor going to the end. Maybe because it loads the message and it just puts it at the end due to the loading. Who knows, and I do get the idea of the editor needing improvement, but that there is not enough of an issue.
2. If you feel that switching to another forum software is worth considering just because of the editor, then by all means, do so. However, you're more likely to find the same issues as well as others that you have not even considered yet.
Quote from: TwitchisMental on February 22, 2023, 01:09:12 PMI can confirm when you go to edit a post the cursor starts at the end.. However I don't think that is a bug. That is just default behavior .
If I click somewhere earlier in the post while editing, it doesn't move or jump anywhere. It stays where I clicked and allows me to edit. Using Windows 11 and OpenSuse with Firefox.
-------
Just for confirmation, are you saying if you click elsewhere in the post while editing, it jumps to the end again?
Exactly this. It is almost impossible to edit the post. It seems to affect parts of the post (I think). So, if I try editing a later sentence, it will or might work (I think). I'll have to wait until it happens again to be sure. I'd say that this happened in at least four of my posts here over the past few days. And, on two different computers.
(Apologies for the second thread. After a day, it seemed that my post here was not going to gain any traction.)
Quote from: DeadMan... on February 22, 2023, 02:14:22 PMQuote from: Col on February 22, 2023, 11:09:14 AMI mean, it will not stop me (since I am not using WYSIWYG is 2.0), but it does make me consider moving to another software.
1. Most of the places I go to that has posting has about the same thing with cursor going to the end. Maybe because it loads the message and it just puts it at the end due to the loading. Who knows, and I do get the idea of the editor needing improvement, but that there is not enough of an issue.
2. If you feel that switching to another forum software is worth considering just because of the editor, then by all means, do so. However, you're more likely to find the same issues as well as others that you have not even considered yet.
As I just explained, this bug makes the editor (in WYSIWYG mode) practically unusable. When using the text editor in maybe a quarter or a third of my recent posts here, when I try editing some of the text I have already entered, the cursor immediately skips to the end of the text (or maybe sentence/paragraph). I had already disabled the text editor in my 2.0 forum for really buggy behavior - I was looking forward to providing members with a WYSIWYG editor which works (ne the whole, my members are not technically included, so dealing with tags is difficult for many of them). So, for this reason, I have to wonder if I should instead be looking to migrate rather than upgrade. (Since this is occurring on two different computers, with really standard setups, with different operating systems (Windows 10 & 11), it is difficult to imagine this bug only affecting me). I don't imagine it will come to me migrating to something else (after all, I could disable the editor in this version too), but it is frustrating (to me, at least) that the editor has major bugs in two different versions of this forum software.
For what it is worth, I've asked a few of my members to test out the editor here. Maybe it is just me being affected (on two different computers) for some unfathomable reason.
Quote from: Col on February 22, 2023, 02:44:12 PMQuote from: TwitchisMental on February 22, 2023, 01:09:12 PMI can confirm when you go to edit a post the cursor starts at the end.. However I don't think that is a bug. That is just default behavior .
If I click somewhere earlier in the post while editing, it doesn't move or jump anywhere. It stays where I clicked and allows me to edit. Using Windows 11 and OpenSuse with Firefox.
-------
Just for confirmation, are you saying if you click elsewhere in the post while editing, it jumps to the end again?
(Apologies for the second thread. After a day, it seemed that my post here was not going to gain any traction.)
It is important to note that we are all volunteers here, so responses can take some time. This is especially true when it comes to bug reports because we try our best to confirm the issue. We can all understand the frustration, but let's work together to get this issue resolved(no matter the cause).
Since you do mention Firefox specifically, have you by chance tried any other browsers such as Edge or Chrome?
I noticed that you have also mentioned not having the issue(so far at-least) while using incognito mode. So this can possibly be a settings and/or addon issue.
Of course I understand that you all here are volunteering your help. It is the same at my forum too. I was being impatient. I was also very frustrated because I was struggling get out many of posts here.
Two add-ons installed with FF on this computer, but both were already disabled. I've not noticed any problems in my last few posts (incognito mode). But
if this is down to a corrupt file, it is distinctly odd (highly unlikely) that I was similarly affected on two different computers with two different operating systems, at the same time.
I'll try some better organised tests tomorrow to determine the cause or where/when the situation arises. No problem with this post either. (Again, in incognito mode - different cache).
Thanks,
@TwitchisMental and all.
Quote from: Col on February 22, 2023, 03:00:03 PMAs I just explained, this bug makes the editor (in WYSIWYG mode) practically unusable. When using the text editor in maybe a quarter or a third of my recent posts here, when I try editing some of the text I have already entered, the cursor immediately skips to the end of the text (or maybe sentence/paragraph). I had already disabled the text editor in my 2.0 forum for really buggy behavior - I was looking forward to providing members with a WYSIWYG editor which works (ne the whole, my members are not technically included, so dealing with tags is difficult for many of them). So, for this reason, I have to wonder if I should instead be looking to migrate rather than upgrade. (Since this is occurring on two different computers, with really standard setups, with different operating systems (Windows 10 & 11), it is difficult to imagine this bug only affecting me). I don't imagine it will come to me migrating to something else (after all, I could disable the editor in this version too), but it is frustrating (to me, at least) that the editor has major bugs in two different versions of this forum software.
For what it is worth, I've asked a few of my members to test out the editor here. Maybe it is just me being affected (on two different computers) for some unfathomable reason.
I've used SMF, and others and have never had that issue.
But then again, I never use FireFox anymore, either.
(EDIT: Trying with FF, and not able to confirm any issue.)
If happening on 2 PC's with the same browser, you may have something that's synced between them, if you are logged into FireFox. Sounds like it's going to be mainly a FireFox issue, especially if not have addons enabled.
Edited: Testing FireFox. Able to edit with no cursor jumping.
This is a test post, using the second computer - I have not cleared the cache or switched to incognito. It will be interesting to see if I can trigger similar errant behaviour from the text editor.
Nothing synched, between these two computers,
@DeadMan... I'll now try to edit the first paragraph -
No problem this time!
As unlikely as it would seem, I guess the problem is at my end if no one else is experiencing behaviour. I'll keep investigating to see if I can determine any common factors.
Quote from: Col on February 22, 2023, 04:49:34 PMAs unlikely as it would seem
As unlikely as it would seem to you, maybe, but the fact that others cannot duplicate your problem using the same OS and browser does, in fact, mean the problem is on your end.
You, in fact, proved it with this:
Quote from: Col on February 22, 2023, 04:49:34 PMI'll now try to edit the first paragraph - No problem this time!
Marking this solved and moving to 'Fixed or Bogus Bugs'.
I'll keep testing this, so far no luck.
Quote from: Steve on February 22, 2023, 07:06:02 PMQuote from: Col on February 22, 2023, 04:49:34 PMAs unlikely as it would seem
As unlikely as it would seem to you, maybe, but the fact that others cannot duplicate your problem using the same OS and browser does, in fact, mean the problem is on your end.
You, in fact, proved it with this:
Quote from: Col on February 22, 2023, 04:49:34 PMI'll now try to edit the first paragraph - No problem this time!
Marking this solved and moving to 'Fixed or Bogus Bugs'.
I suggest that it proves nothing. As I have previously stated (more than once) the problem was always intermittent. And the reason I write 'improbable' is because the same problem is/was occurring on two different computers with two different OSs.
Quote from: Diego Andrés on February 22, 2023, 08:26:06 PMI'll keep testing this, so far no luck.
I'll try some more systematic tests later today, not in incognito mode. If the bug reappears, I'll clearing the cache (again, not incognito) to rule our a corrupted file. It is still odd that it affects/affected two different computers.
Hm... does it make a difference if the post contains a mention?
@Sesquipedalian I don't think that's the trigger, but I don't know for sure. I was intending to perform some tests today, but I was too busy.
I was able to place my cursor in the above. But maybe where the mention is paced matters too. If I try mentioning you here,
@Sesquipedalian, will this trigger the problem? And, yes, it just happened again. I cannot go back to any point after the mention earlier in the paragraph. I can go to prior sentences and and the previous paragraph. What made you think of it,
@Sesquipedalian? And one last attempt - still happening with latest mention. And if go to after the second one, the cursor skips to just before the third mention.
Yup, I think this can now be classified as a legitimate, reproducible bug. Inserting mentions in WYSIWYG mode messes with the cursor position when trying to edit the same paragraph that the mention appears in.
As for how I thought of it,
@Col, I remember encountering a similar issue with mentions and WYSIWYG mode at some point way back during earlier phases of SMF 2.1's development. I don't recall seeing it for a long while, but either it has resurfaced recently, or perhaps I just haven't done anything to trigger it in a long time.
This is for testing purposes.
edit edit
@Sesquipedalian Lorem Ipsum
Stuff and things.
Edit : Humm not reproducing the error myself.
If someone else can reproduce this and give specifics, we can get this logged on GitHub :) .
To reproduce:
- Put the following text into the quick reply (replace "@test1" with a username on your test forum):
Lorem ipsum dolor sit amet, consectetuer adipiscing elit. @test1 Aenean tempus justo sed arcu. Sed ut neque. Nam quis odio in nulla dapibus laoreet. Suspendisse interdum volutpat ligula.
Nullam sagittis nunc quis massa. @test1 Curabitur a pede vel risus mollis dignissim. Aenean nec massa. Vivamus at tellus. Sed ac nunc. Pellentesque feugiat ultricies quam. Ut porta turpis commodo pede dignissim laoreet. - Click the preview button to go to the full post authoring form.
- Click somewhere after the mention in the second paragraph.
- Observe how the cursor jumps to the end of the paragraph.
Anyway, after digging around a bit, I think I have found the culprit. I'll open an issue and submit a PR on GitHub shortly.
Lorem ipsum dolor sit amet, consectetuer adipiscing elit.
@Sesquipedalian Aenean tempus justo sed arcu. Sed ut neque. Nam quis odio in nulla dapibus laoreet. Suspendisse interdum volutpat ligula.
Nullam sagittis nunc quis massa.
@Sesquipedalian Curabitur a pede vel risus mollis dignissim. Aenean nec massa. Vivamus at tellus. Sed ac nunc. Pellentesque feugiat ultricies quam. Ut porta turpis commodo pede dignissim laoreet.
Confirmed for me, too. Good find.
Issue filed: #7687 (https://github.com/SimpleMachines/SMF2.1/issues/7687)
Pending fix: #7688 (https://github.com/SimpleMachines/SMF2.1/pull/7688)
Quote from: Sesquipedalian on February 23, 2023, 08:34:56 PMIssue filed: #7687 (https://github.com/SimpleMachines/SMF2.1/issues/7687)
Pending fix: #7688 (https://github.com/SimpleMachines/SMF2.1/pull/7688)
Good job, Sesquipedalian. Reading your pending fix, is this a recent introduction of the bug? Presumably, it is.
Actually, no. The bug just seems to have gone largely unnoticed for all this time. That's probably because it only occurs under certain conditions and not others. My guess is that you have encountered it repeatedly because your particular usage patterns often lead to the triggering conditions. Someone following different usage patterns might rarely ever find their way into the triggering conditions.
Quote from: Sesquipedalian on February 24, 2023, 03:15:10 PMSomeone following different usage patterns might rarely ever find their way into the triggering conditions.
*waves hand* Oooh, pick me, pick me!
I almost never mention people, which is why I never noticed this. Good looking fix though.
Yup. In my tests, at least, it only happened when I used a mention, and used WYSIWYG mode, and used the post preview function to view the post, and then tried editing the post text. It didn't happen if I tried editing an already existing post; it didn't happen in the quick reply form before I clicked preview; etc. There may very well be other paths that lead to the triggering conditions besides the one I found, but many paths don't lead there at all.
Quote from: Col on February 24, 2023, 02:44:57 AMis this a recent introduction of the bug?
looks like teh affected code is there since 2014 (nine years!)
Quote from: Sesquipedalian on February 23, 2023, 08:34:56 PMIssue filed: #7687 (https://github.com/SimpleMachines/SMF2.1/issues/7687)
Pending fix: #7688 (https://github.com/SimpleMachines/SMF2.1/pull/7688)
Is this a fix that maybe can be made into a mod and posted here for the OP to use until it gets into a future update? This way, the OP, who seems to be the one that mostly gets this issue, can have relief until the next update.
Constructing a whole modification package would be overkill in this case. If
@Col wants to implement the fix on their own forum now, they can just delete the relevant lines in their local copy of mentions.js.
Quote from: Sesquipedalian on February 24, 2023, 03:53:06 PMConstructing a whole modification package would be overkill in this case. If @Col wants to implement the fix on their own forum now, they can just delete the relevant lines in their local copy of mentions.js.
It's been done in the past for some 2.0.x fixes, I believe Shawn did it for both the birthday issue and something else.
If someone wants to do it 'right' feel free to do so and share it, but keep in mind it will have to be reverted/uninstalled once the fix makes it onto an actual patch.
Quote from: Diego Andrés on February 24, 2023, 04:54:42 PMIt's been done in the past for some 2.0.x fixes, I believe Shawn did it for both the birthday issue and something else.
Yes. Allow me to rephrase:
Quote from: Sesquipedalian on February 24, 2023, 03:53:06 PMConstructing a whole modification package would be overkill in this case would require more effort than I am willing to exert for something so easy for admins to do locally themselves, especially since making the local edit would itself require less effort from the admin than going through all the steps of installing a mod.
Manual fix, or mod, it'll still have to be reverted before updating.
Unless, in the update, it can skip if the fix is already done.
It is true that if the change isn't reverted before the next official patch is installed, then SMF's package manager will report that a test failed. In this particular case, however, it would be safe to ignore the warning and proceed to install the patch anyway. That is almost never true, but this is the rare exception.
Quote from: Sesquipedalian on February 24, 2023, 03:15:10 PMActually, no. The bug just seems to have gone largely unnoticed for all this time. That's probably because it only occurs under certain conditions and not others. My guess is that you have encountered it repeatedly because your particular usage patterns often lead to the triggering conditions. Someone following different usage patterns might rarely ever find their way into the triggering conditions.
My usage pattern here is not even
my regular usage patterns. Because I experienced bugs in the past with SMF's WYSIWYG editor when I upgraded to 2.0 (I no longer recall the specifics of the bug), I disabled WYSIWYG at my SMF forum. Many of my members struggle with tags, and have made negative comments about it, so trying out WYSIWYG here was on my testing list prior to upgrading to 2.1, as was the use of mentions.
Irrespective of my particular usage here over the past few days, it is odd that it has, apparently, taken 9 years for this bug to come to light.
Thank you, everyone, for your persistence. And, particularly you, Sesquipedalian.
Quote from: Sesquipedalian on February 24, 2023, 03:53:06 PMConstructing a whole modification package would be overkill in this case. If @Col wants to implement the fix on their own forum now, they can just delete the relevant lines in their local copy of mentions.js.
That's what I will do. My members are not, on the whole, remotely technical. They will make heavy use of the WYSIWYG editor and, I expect, mentions too.
Quote from: Col on February 25, 2023, 05:37:09 AMit is odd that it has, apparently, taken 9 years for this bug to come to light.
Not really; the mainstream release of 2.1 was last year - in the period of 2011-2022, the (vast) majority of the people using it were devs and fringe communities, both of whom probably habitually use non-WYSIWYG.
Can confirm—I always use source mode.
Quote from: Arantor on February 25, 2023, 06:04:37 AMQuote from: Col on February 25, 2023, 05:37:09 AMit is odd that it has, apparently, taken 9 years for this bug to come to light.
Not really; the mainstream release of 2.1 was last year - in the period of 2011-2022, the (vast) majority of the people using it were devs and fringe communities, both of whom probably habitually use non-WYSIWYG.
You make a reasonable point, there. I do not usually use WYSIWYG myself.