Simple Machines Community Forum

SMF Support => SMF 2.1.x Support => Topic started by: Edwar Colt on February 22, 2023, 04:29:06 PM

Title: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on February 22, 2023, 04:29:06 PM

Hi..

I did the installation at https://atrack.live and the > SMF Gallery icon > https://custom.simplemachines.org/index.php?mod=473 (https://custom.simplemachines.org/index.php?mod=473) does not appear in the theme > Smf 2.1 Steyle-V4 Dark > https://custom.simplemachines.org/index.php?theme=3011 (https://custom.simplemachines.org/index.php?theme=3011)

I couldn't find the correct dropmenu to make the correction. the image is loaded by codes > fa fa-mlist fa-lg <

tks
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: vbgamer45 on February 22, 2023, 05:05:53 PM
Is is a theme/mod issue.

By default we use an icon gallery.png file. But looks like theme is using font awesome icons.
It is little trickier in SMF 2.1 as it requires modifying the menu hook call to adjust. Sources/GalleryHooks.php
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on February 22, 2023, 05:44:36 PM
So we found a small incompatibility in version 2.1 still unresolved?
my knowledge is still not enough to replace the call in GalleryHooks.php , but I'll do some tests. If I find the solution, I'll come back here in this thread.

Thanks
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Arantor on February 22, 2023, 07:19:49 PM
It's not an incompatibility between the gallery and 2.1, it's something between the gallery and your theme that doesn't follow how SMF 2.1 does things.
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on February 23, 2023, 04:22:46 AM
I mean version 2.1 being the link between the gallery and the theme. Both were developed to meet the latest version of the forum.
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Arantor on February 23, 2023, 04:24:37 AM
Yes but the theme does things in a way that SMF itself doesn't. SNF itself doesn't use Font Awesome for anything - while this theme does.

Any other mod you install that adds a menu item will have the same problem.
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on February 23, 2023, 04:48:54 AM
Exactly. I installed a contact page mod and it had the same problem. the icon did not appear in the menu of this theme
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Arantor on February 23, 2023, 05:56:45 AM
It might be worth asking the theme author how you should set the icons - it's not really the responsibility of each mod to make sure they set an icon for one specific theme that doesn't work the same way as SMF does out of the box.
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on February 23, 2023, 06:28:36 AM
Yes, it would be impossible to fit all existing mods to one theme. I think that the use of these icons over time in other themes will make an adaptation to the problem arise.

In this theme in particular, it seems that the programmer stopped doing this work according to this post I found on the author's forum linked to the theme. webtiryaki.com/threads/peacock-theme-smf-2-1-rc4.943/post-3589
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on February 25, 2023, 05:46:14 AM
The solution I found that ended up solving the problem with this theme better was to remove the other icons from the menu. The result was very good. and in the case of installing new mods the problem does not interfere again in the menu.
Title: Re: SMF Gallery icon not showing in Smf 2.1 Steyle-V4 Dark theme
Post by: Edwar Colt on April 21, 2023, 09:56:50 PM
In order not to leave unresolved

The definitive solution for the icons not existing in the menu of this theme is in the answer from @webtiryaki in
https://www.simplemachines.org/community/index.php?msg=4147808