2.1.3 installation.
Search appears to work fully in forum, board, and topic... as it does on the SMF site here...
HOWEVER....
Set post moderation to "Can create but requires approval" for that board for the regular members group.
Save
Log in as a normal user
go to the board
search for "test"
-- I get 7 results displayed (correct)
Go to a topic
search for "development"
-- I get 1 result displayed (correct) (result is in the first post of the topic)
Search for "laddies"
-- I get the error "Sorry, no matches were found" (result should be in the 5th post of the topic)
from admin account, Set post moderation to "Can create"
Save
from test user account, Search for "laddies" again
-- I get the error "Sorry, no matches were found" (result should be in the 5th post of the topic)
Once the in-topic search fails, (maybe because of post-moderation) the search within the topic never works again, even after turning OFF post-moderation.
Is test user in that group, so that test user is moderated?
And admin is not moderated, obviously.
Question: if you set the setting then have the test user log out and log back in, does it work as expected?
I'm suspecting the mod cache got tainted somewhere abs that vs the board access lookup wasn't tested properly after its late-RC rewrite.
Question: does this happen with the same behaviours on 2.0.x?
Question: does it happen across none/full text/custom? (Ignore here for now, it's not on any of those)
Quick side question - should the topic title be 2.1.3 instead of 2.0.13?
Corrected title. Was writing while in a business meeting. Lol
I'll check the logout.. but guests get the same error when searching the topic
Have not retested on 2.0.x
More testing tomorrow
I suspected as much but didn't want to change the post of my team lead.
If this has been confirmed, can someone add it up on GitHub?