Simple Machines Community Forum

SMF Development => Bug Reports => Topic started by: KittyGalore on June 08, 2024, 07:44:52 AM

Title: Merging Topics redirect link
Post by: KittyGalore on June 08, 2024, 07:44:52 AM
I think this is a bug you guys can check it out but on a brand new 2.1.4 test forum no mods when you merge 2 topics together and if you uncheck to automatically redirect to the merged topic when you go to the new merged topic and it says This topic has been merged into when you press on that link that it has been merged into the url at the top will be enclosed in quotation marks and the page will says


This site can't be reached
Check if there is a typo in "https.
If spelling is correct, try running Windows Network Diagnostics.
DNS_PROBE_FINISHED_NXDOMAIN

If i posted this here by mistake i apologize as i have checked a few times before posting here so i think it might be a bug or something.

If i go to edit the link from the post and remove this symbol at either end of the address url is solves the problem
"https//www.xxxxxxxxx/index.php?topic=5.0"

It should be this
https//www.xxxxxxxxx/index.php?topic=5.0
Title: Re: Merging Topics redirect link
Post by: Kindred on June 08, 2024, 12:16:50 PM
Sounds like a windows server error. I can't recreate the issue on a Linux webserver
Title: Re: Merging Topics redirect link
Post by: shawnb61 on June 08, 2024, 12:47:20 PM
It's a bug.  I can confirm this on Linux.  The link is broken. 

When reproducing, it's important to uncheck the auto redirect box.

Different browsers show wildly different behavior:
- Chrome reports the error above
- FF just ignores the link
- Edge says the link is not found and adds a 2nd https// in front...

The broken link looks like:
<a href="//%22https://myxyz.com/van21/index.php?topic=91.0%22" class="bbc_link">asdfasdfasdf</a>
brokenlink.png

SMF 2.1.4; PHP 8.2.18
Title: Re: Merging Topics redirect link
Post by: shawnb61 on June 12, 2024, 01:06:48 PM
Logged up on GitHub.  Issue exists in 2.1 & 3.0:
https://github.com/SimpleMachines/SMF/issues/8249