Simple Machines Community Forum

Customizing SMF => SMF Coding Discussion => Topic started by: Chris Curran on January 21, 2006, 11:14:33 AM

Title: Calendar mods
Post by: Chris Curran on January 21, 2006, 11:14:33 AM
Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=655)



Hi, Hello:

I'm a new SMF user. I dl'ed and installed 1.1 RC2 a few days ago and so far no troubles.

One question though: I needed a calendar app that allowed repeating events - the span thing just didn't cut it for our needs (an astro club). I took a theme from Bloc (Black22) and modified the Post.template.php and Calendar.template.php files as needed, however, due to the addition fields I'm using I needed to modify the calendar table structure (added columns) and the Post.php and Calendar.php files (to support the new columns related to repeating events).

Here's the question: How do I share these mods with the rest of the community? Since my mods are not limited to the "template" files I'm not sure what to do. Diff files? Is there a cvs this can be posted to? What question am I forgetting to ask? Sorry if I've missed a document that covers this - I poked around and don't see anything obvious...

salute and happy days,
Chris Curran

A cropped screen-print of the mod:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.stpeteastronomyclub.org%2Fimages%2FeditEvent.jpg&hash=5554e0e94fb8bd4847a4850c1e5e8d48329aa19b)
Title: Re: Calendar mods
Post by: HEB XI 1 on January 21, 2006, 02:46:14 PM
can't answer your question about how to share it, but once you've got that answered, I'd LOVE to be one of the first to grab it.  I've waited for something like this since I started using SMF ... I just can't hack code that well :)
Title: Re: Calendar mods
Post by: Chris Curran on January 21, 2006, 10:56:52 PM
Did I post this in the wrong forum? Are there any SMF developers out there that can comment on the above questions?

thanks,
Chris
Title: Re: Calendar mods
Post by: Kindred on January 22, 2006, 04:12:28 AM
You need to look at the mod package design and package this up into an archive, with an XML load sheet and an XML instruction set to tell the system what files to modify and how... (and a sql file for it to execute to tell it how to modify the tables)
Title: Re: Calendar mods
Post by: Chris Curran on January 22, 2006, 10:01:07 AM
Thanks Kindred. Is there doc somewhere that outlines the "mod package design"? The only thing I am able to find is a two msg thread regarding how to make a new theme...

cheers,
Chris

Quote from: Kindred on January 22, 2006, 04:12:28 AM
You need to look at the mod package design and package this up into an archive, with an XML load sheet and an XML instruction set to tell the system what files to modify and how... (and a sql file for it to execute to tell it how to modify the tables)
Title: Re: Calendar mods
Post by: Chris Curran on January 22, 2006, 10:50:58 AM
OK, I dl'ed a mod and took a look at the structure. First thing I noticed is that the themes are .gz and the mods are .zip - the inconsistency seemed odd. What I still don't "get" are the nuts & bolts of this - what are the "rules"? What other commands/functions are available to the MOD file? Can I auto-execute the sql mods, or do I instruct the user to run a script outside the current environment? I can't seem to find a HOWTO type document/thread on how to make a package. Is there one?

thx,
Chris
Title: Re: Calendar mods
Post by: Kindred on January 22, 2006, 10:52:56 AM
it's here...
[Unknown]'s package SDK (http://www.simplemachines.org/community/index.php?topic=20319.0)


also.. BTW: Would you mind If I rolled this mod into another calendar mod that I was working on?
(the PhatCalendarPack)  I had actually just started looking into the recurring events. :)
But since you've done it, I would like to roll it in, so that there won't be any conflicts between the two mods.  All credit on this portion definitiely going to you...

Let me know if you're OK with that...  (or not...)
Title: Re: Calendar mods
Post by: Prasad007 on January 22, 2006, 11:14:34 AM
oooh sweeet
thank you! :)
Title: Re: Calendar mods
Post by: Chris Curran on January 22, 2006, 11:45:28 AM
Yes, of course. I'd like to package this up as it's own mod for my own education though. Thanks for the link - I'll check it out and get back to you after the games...

cheers,
Chris

Quote from: Kindred on January 22, 2006, 10:52:56 AM
it's here...
[Unknown]'s package SDK (http://www.simplemachines.org/community/index.php?topic=20319.0)


also.. BTW: Would you mind If I rolled this mod into another calendar mod that I was working on?
(the PhatCalendarPack)  I had actually just started looking into the recurring events. :)
But since you've done it, I would like to roll it in, so that there won't be any conflicts between the two mods.  All credit on this portion definitiely going to you...

Let me know if you're OK with that...  (or not...)

Title: Re: Calendar mods
Post by: Chris Curran on January 23, 2006, 11:48:02 AM
OK, I got the "SDK" and have started looking into packaging this up. However, I must admit to being somewhat disappointed. This is not a "SDK" in the sense that I'm used to seeing/using SDK's. Moreover, I find it *very* odd that the "SDK" is not a sticky thread in this forum - why hide it in the noise of chatter? SMF seems to pride itself on how easy it is to install mods and themes - where's the beef for us programmers? I'm sure there are ways to make getting started as a SMF developer more difficult and frustrating, but I'm not sure how you go about it...

cheers,
Chris

Quote from: Kindred on January 22, 2006, 10:52:56 AM
it's here...
[Unknown]'s package SDK (http://www.simplemachines.org/community/index.php?topic=20319.0)
Title: Re: Calendar mods
Post by: Kindred on January 24, 2006, 02:25:37 PM
Chris,

Can you email me or PM me regarding the coding for this?   I am planning to release the PhatCalPack around the end of the month and I (and all the users) would love it if recurring events could be included. :)

thanks!
Title: Re: Calendar mods
Post by: Chris Curran on January 25, 2006, 10:34:48 AM
Kindred,

I haven't finished making the xml mod files (or tested same). Are you asking for the source raw (which I can do)? BTW: I do a search for "PhatCalPack" and don't find anything - where is it?

Chris

Quote from: Kindred on January 24, 2006, 02:25:37 PM
Chris,

Can you email me or PM me regarding the coding for this?   I am planning to release the PhatCalPack around the end of the month and I (and all the users) would love it if recurring events could be included. :)

thanks!
Title: Re: Calendar mods
Post by: Kindred on January 25, 2006, 11:06:46 AM
it was actually originally titled: Jack's Phat Calendar Pack (http://www.simplemachines.org/community/index.php?topic=37907.0)

Jack was gone for a while and I updated the pack for the 1.0.x series.

Since I did some updates, a bunch of people came in with requests to be added for the RC2 release. :)
Title: Re: Calendar mods
Post by: sugarbeth on January 25, 2006, 12:49:28 PM
Oooh...just what I need! Thanks for doing this, Chris! :) I'll be anxiously awaiting!
Title: Re: Calendar mods
Post by: Chris Curran on January 26, 2006, 11:40:38 AM
I don't know if this will interest anyone... I've worked out auto-generating events for the moon phases (our board is for an astro club, so moon phase is important to us). I wrote a small script to dl the data from USNO, then created a mysql table for those data. Those data are used to display the time of the four quarters of the moon, on the proper date, with UT conversion to local time (EST here).

here it is in action: http://www.stpeteastronomyclub.org/forum/index.php?action=calendar

cheers,
Chris

PS: I'm leaving town in a few hours until Tue. Q's will have to wait until then....
Title: Re: Calendar mods
Post by: Kindred on January 26, 2006, 11:43:47 AM
Chris... you are amazing!  That is so totally cool!

I have a moon phase graphic for my main portal that is a javascript, but so far, for the calendar, one of the moderators has been inserting the new/full moon dates.

I am definitely interesed in that script for my own board as well!
Title: Re: Calendar mods
Post by: Chris Curran on January 26, 2006, 01:27:32 PM
Thanks Kindred. It's worth noting that the reason I used USNO data is that the algo for calculating moon phases isn't as simple as one might think. I had originally written the code to pull the data dynamically from USNO (http://aa.usno.navy.mil/data/docs/MoonPhase.html) but the USNO doesn't provide data on a monthly basis (year by year only). Thant meant 1) connecting to USNO for each calendar page refresh - yuk, and 2) parsing a full year of data each time for one months worth of info - double yuk. That's when I morphed the code into writing it into a table so I could read it back later. I wound up sucking data for 2000 to 2035 - that should cover the immediate needs ;).

If you like, I can send you the source (when I get back next week) for these mods to include in your phat project. In fact, if it works for you, I'd prefer you handle the packaging of these mods - I just don't have the time to dig into this packaging thing right now (or anytime in the near future).

cheers,
Chris
Title: Re: Calendar mods
Post by: rpalmer68 on April 22, 2006, 11:14:27 AM
Hi Chris,

Is your mod for recurring calendar events available for 1.1 RC2?

This is all I need, I don't need the additional stuff in kindred's mod (also yet to be released)

Cheers
Richard
Sydney, Australia
Title: Re: Calendar mods
Post by: Chris Curran on May 01, 2006, 09:48:10 AM
I don't have a "mod" package for my code. I'll make the code available to anyone that wants to make a "mod" package....

Chris

Quote from: rpalmer68 on April 22, 2006, 11:14:27 AM
Hi Chris,

Is your mod for recurring calendar events available for 1.1 RC2?

This is all I need, I don't need the additional stuff in kindred's mod (also yet to be released)

Cheers
Richard
Sydney, Australia
Title: Re: Calendar mods
Post by: circles on July 05, 2006, 01:54:04 PM
Did anybody make a mod pkg for this? I'd like it if it exists.

Thanks,
Allison
Title: Re: Calendar mods
Post by: Chris Curran on July 07, 2006, 09:30:47 AM
Nope. And I don't know if there ever will be one - those who I've asked for help seem to have forgotten....

cheers,
Chris

Quote from: circles on July 05, 2006, 01:54:04 PM
Did anybody make a mod pkg for this? I'd like it if it exists.

Thanks,
Allison

Title: Re: Calendar mods
Post by: Kindred on July 07, 2006, 09:52:05 AM
Chris,

I have not forgotten. I have just been overwhelmed with a case of "life" (who would've thunk it)

My real-life boss is on leave, so I am holding down both her job as well as all my own tasks... :(
Title: Re: Calendar mods
Post by: Chris Curran on July 08, 2006, 09:31:10 AM
:)... I'm always amused by folks who discover just how hard "life" really is. I have a wife, three kids (one still at home) and a grandkid, I'm the PM of seven programmers (i.e. seven egos) on a project that debuts at the NAMM show on the 14'th, I haven't seen a vacation in years and I never miss a New Moon weekend with my astro buddies. Don't talk to me about "life".... :)

Psst: old school organizational tip: Get yourself some of those small pocket sized spiral-bound notebooks (the paper kind, not electronic). They come in packs of 10 for about 3 bucks. Write it down and you'll be amazed at how much more you accomplish. I stopped trusting my memory after enjoying the 70's a bit too much...

cheers,
Chris

Quote from: Kindred on July 07, 2006, 09:52:05 AM
Chris,

I have not forgotten. I have just been overwhelmed with a case of "life" (who would've thunk it)

My real-life boss is on leave, so I am holding down both her job as well as all my own tasks... :(
Title: Re: Calendar mods
Post by: cyberbillp on August 07, 2006, 08:24:13 PM
Quote from: Chris Curran on May 01, 2006, 09:48:10 AM
I don't have a "mod" package for my code. I'll make the code available to anyone that wants to make a "mod" package....

Chris

Quote from: rpalmer68 on April 22, 2006, 11:14:27 AM
Hi Chris,

Is your mod for recurring calendar events available for 1.1 RC2?

This is all I need, I don't need the additional stuff in kindred's mod (also yet to be released)

Cheers
Richard
Sydney, Australia

I'd like to try and make a package from your code. Where can I get your post.php and calendar.php files?
Title: Re: Calendar mods
Post by: Chris Curran on August 09, 2006, 10:11:56 AM
Check your PM's....

Quote from: cyberbillp on August 07, 2006, 08:24:13 PM
I'd like to try and make a package from your code. Where can I get your post.php and calendar.php files?
Title: Re: Calendar mods
Post by: satterwc on August 25, 2006, 01:04:20 PM
I keep doing a search on the forums here every couple of weeks in hopes that this has been packaged by someone. The lack of recurring events is killing me since we schedule daily activites, some that happen every week. Arrggh!! ;)

Will a small donation help get this moving?
Title: Re: Calendar mods
Post by: Chris Curran on August 26, 2006, 07:07:49 AM
I understand. I have gotten numerous requests for this feature via email, but so far no one has stepped up to the plate... Send a note to the SMF development staff - maybe they will get involved if they know there are enough folks out there that want this type of mod?

cheers,
Chris

Quote from: satterwc on August 25, 2006, 01:04:20 PM
I keep doing a search on the forums here every couple of weeks in hopes that this has been packaged by someone. The lack of recurring events is killing me since we schedule daily activites, some that happen every week. Arrggh!! ;)

Will a small donation help get this moving?
Title: Re: Calendar mods
Post by: farzad on August 30, 2006, 02:43:25 PM
why chris's modifications wouldnt be built into the default build is beyond me.

:(
Title: Re: Calendar mods
Post by: Chris Curran on February 02, 2007, 04:23:13 PM
Good news, and more good news:

1) I have updated my repeating events and moon phase code (for the Calendar) to support SMF 1.1.1.

2) I finally sat down and wrote a mod package for this! It needs beta testing - anyone?

cheers,
Chris Curran
Title: Re: Calendar mods
Post by: ooop on February 02, 2007, 05:20:07 PM
sure - i'm free to test it (inside and out) --- where should i begin?
Title: Re: Calendar mods
Post by: Chris Curran on February 03, 2007, 12:31:50 AM
Here: http://www.planetcurran.com/smf/repeatEvents_1_0.zip
Title: Re: Calendar mods
Post by: Chris Curran on February 03, 2007, 11:19:28 AM
I uploaded the mod to the system last night:

http://custom.simplemachines.org/mods/index.php?mod=655

It awaits approval from those who do that sort of thing here....

cheers.
Chris
Title: Re: Calendar mods
Post by: ooop on February 03, 2007, 02:43:46 PM
GREAT WORK!!!

I've just been checking it out just a little (so far).
on the surface it functions near 100%...

one issue is while this mod is installed, when entering to edit an existing event > the edit form does not reflect original dates - and so dates need to be re-entered upon every edit (not the case without this mod)

there seems to be some other issues too, but i gotta double check 'em
- like at sometime existing events that were spanned lost their span somehow (during unistall or reinstall)
- we probably can swing more efficient use of DB while installed
- i also wonder about leaving the DB modified after uninstall (not the best thing)
- questionable if such is a real "issue" (i can't reproduce such easially - maybe such is due to my own customizations) but one time the moon cycles were mixed in with upcoming posted events on the board index (didn't look good)

[ click for full size ]
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fthisparticular.com%2Fsmfstuff%2Fupcomingonindex.gif&hash=2139ad9b5056ef676177c1d9de53122d225e2757) (http://thisparticular.com/smfstuff/upcomingonindex.gif)
note: this issue might be an effect caused by an interaction with some not fully dev'ed mods that i'm currently working on < reason why i use multible test beds - i'm checking to see if i can get this effect on a default smf install (so far - so good)...

the "issue" i mentioned above sorta intergrates with a new feature request and the following feature request below - it might be nice to have the option to display current month moonphases in its own stat box on the board index (homepage)

basically the mod does two unrelated things > makes events repeatable and displays moon phases - i think once installed displaying moonphases should be optional - i know it was one of the driving factors behind the mod's creation, but the repeatable aspect is strong enough - the repeating event aspect is inheirently optional (during post creation) so that's fine...

now consider this is feedback after a quick look (on a few test beds) - i'll be looking much deeper into this in the coming days (weeks, months ;) ) - i'm also gonna check out what other calender mods do (danny just came out with one) and see if any have some stuff here or there that might help - finally, all this stuff is right up my alley, so when i mention "issues" or "feature request" i mean either i or we can look into such, i'm not passing all the work back to you - unless you're greedy :)

ooop

Edit to post: modified to include image of effect on info center
Title: Re: Calendar mods
Post by: Chris Curran on February 03, 2007, 03:10:07 PM
Quote from: ooop on February 03, 2007, 02:43:46 PM
GREAT WORK!!!

Thanks!

Quote
one issue is while this mod is installed, when entering to edit an existing event > the edit form does not reflect original dates - and so dates need to be re-entered upon every edit (not the case without this mod)

I just checked my virgin install and it seems to be working as I expect. All previously entered dates show up as I expect them too.

Quote
- like at sometime existing events that were spanned lost their span somehow (during unistall or reinstall)

I tossed out that "span" logic as it is outdated in this methodology. Yea, it probably breaks old events, but I didn't care. :)

Quote
- we probably can swing more efficient use of DB while installed

Huh? Like what?

Quote
- i also wonder about leaving the DB modified after uninstall (not the best thing)

SOP. Read this: http://www.simplemachines.org/community/index.php?topic=117819.0

Quote
- one time (and i can't reproduce such easially) the moon cycles were mixed in with upcoming posted events on the board index (didn't look good)

Not sure what you mean here....

Quote
the last issue i mentioned above sorta intergrates with a new feature request and the following feature request below - it might be nice to have the option to display current month moonphases in its own stat box on the board index (homepage)

I don't disagree, however, this is the first mod I've ever packaged up, and as you will note, it's HUGE! As you'll also note, I've asked for help with packaging this mod for close to a year now and no one ever stepped up to the plate, so I had to plow through it last night guessing at what the best practice was...

Quote
basically the mod does two unrelated things > makes events repeatable and displays moon phases - i think once installed displaying moonphases should be optional - i know it was one of the driving factors behind the mod's creation, but the repeatable aspect is strong enough - the repeating event aspect is

:) I can see how most would consider it "unrelated"..... The reality is that I needed to upgrade our astro club forum from RC2 to 1.1.1, and I didn't want to hand code it (yet again). So, I sat down yesterday and gutted through the mod process. Since our club is an "astro" club (see my homepage), the Moon Phase status is darn near as important to us as the repeating events! I live for New Moon weekends!

Breaking this mod into two separate packages is probably the right thing to do at some point, but right now since I'm rowing alone, it's going to be one package.

Quote
so when i mention "issues" or "feature request" i mean either i or we can look into such, i'm not passing all the work back to you - unless you're greedy :)

The more the merrier.... I'm a (recently) retired programmer and way past caring about "glory". I really don't want to get bogged down with a lot of feature requests that I don't have time for. Having time for my family and telescopes is what I care about.

cheers,
Chris

Title: Re: Calendar mods
Post by: Chris Curran on February 03, 2007, 04:03:14 PM
ooop,

One feature that is not included in this mod is "exceptions". For example, our astro club has regular meetings on the fourth Fri of every month, *except* in Nov and Dec. I have some prelim code for this, but it's not in the mod. Let me know if you need something to do... :)

Chris
Title: Re: Calendar mods
Post by: ooop on February 03, 2007, 05:57:41 PM
Re: "exceptions" and other stuff i had mentioned...

yeah - i saw all the neglect you had experienced on this project, kinda tragic - however, i personally don't forget/neglect things so easily and so > yeah, you can kinda think of me as on your team now - and not sooo "relaxed"...

i'll return shortly to address a few more of the things you touched on, but actually, i wanted to bring up another feature request (and don't forget, all my feature requests i will attempt to fulfill personally ;) ) - i thought of mentioning this in my last post > basically i think an added feature of a different kind of "exception" would really add to this mod's flexibility > a kinda "repeat template" where once a repeat item has been added then each appearance of such can be individually appended/edited...

example:
if say each monday there was a lecture listed - then each individual listing can be uniquely appended to display lecture's topic, speaker, and what not:

Feb  4 - Lecture: How SMF was started
Feb 11 - Lecture: Who's who in SMF team
Feb 18 - Lecture: SMF features
Feb 25 - Lecture: How to break SMF

anywho - how to figure out how to do stuff like that (AND make such user friendly) is one of my strengths (spelling isn't ;) ) - i'll look into the type of "exceptions" you mentioned as well...

and yeah i saw that within the Mod Guidelines
QuoteMust leave nothing more behind on uninstall then language strings, database tables, and database rows
still don't like it - but it's not really a big issue - just wondered...

lot's more to cover -- i'll be back - soonish - perhaps by monday i'll even have solutions for some things...

just mainly wanted to express i'm not likely to leave you/project high and dry.
Title: Re: Calendar mods
Post by: Chris Curran on February 03, 2007, 06:56:10 PM
Quote
Feb  4 - Lecture: How SMF was started
Feb 11 - Lecture: Who's who in SMF team
Feb 18 - Lecture: SMF features
Feb 25 - Lecture: How to break SMF

Currently, 'calendarInsertEvent()' (in Sources/Calendar.php) writes a single record to the db. Let the user click something that tells the code to write a record for each event to the db....


I added two options that control the display of the Moon Phase. Look under 'Features and Options', 'Layout and Options' in admin.

The updated package is here: http://www.planetcurran.com/smf/repeatEvents_1_1.zip

Uninstall 1.0 first..... Good thing the db doesn't get reset when you uninstall - you'd lose any repeating events you've already entered!

cheers,
Chris
Title: Re: Calendar mods
Post by: ooop on February 03, 2007, 07:00:33 PM
OK - just tripled checked, on a 2nd virgin install....

while this mod is installed, when entering to edit an existing event > the edit form does not reflect original dates - and so dates need to be re-entered upon every edit (not the case without this mod)

note event date of Feb 7
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fthisparticular.com%2Fsmfstuff%2Ffeb7event.gif&hash=787fec33a9b852ad06041d1e2e80da1a915a44aa)
when i click the red asterisk to edit the event i get the following
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fthisparticular.com%2Fsmfstuff%2Feditevent.gif&hash=d0a528d69759b1c80c03d05711e143dea4bd2dc3)
notice how it reflects earliest date of smf's default install > January 1st 2004 - instead of event's actual date of Feb 7 2007

this effect takes place on 'one time events' (have not checked other type of events yet) - this effect is caused by the mod.

i shall get to the bottom of this effect ;)
Title: Re: Calendar mods
Post by: Chris Curran on February 03, 2007, 07:05:19 PM
Quote from: ooop on February 03, 2007, 07:00:33 PM
this effect takes place on 'one time events' (have not checked other type of events yet) - this effect is caused by the mod.

i shall get to the bottom of this effect ;)

I just tried to dup and it still works fine here.... I wonder what we're doing diff.... After you enter the event, can you please chk the db raw to see if it's being written to the db correctly?

Chris
Title: Re: Calendar mods
Post by: ooop on February 03, 2007, 07:15:00 PM
ahh - i didn't see your last post up there
LOL! > "you'd lose any repeating events you've already entered!" < yeah, i thought bout that - my "wonderings" are pretty unfounded > given the size of smf's DB - but if it was more complex then such would be an issue...

i'll check out 1.1, thx ;)

i'm gonna PM you info to my default install so you can check out the effect i speak of (went up minutes ago) -- gimme a few minutes to type the PM > i type slow...  
Title: Re: Calendar mods
Post by: ooop on February 04, 2007, 03:21:19 AM
Soooo.....

i had some time to check out the issue i mentioned concerning how when editing an event it does not retain original dates >>> would you believe it >>> it's a browser thing - turns out it, what i was speaking of, has effect i mentioned (doesn't work properly) on the most popular browser there is >>> the dreaded IE6 - yup, that's right - with the mod installed, somehow original dates are not retained in the event edit form while using IE6 >>> can you believe it? :)
Title: Re: Calendar mods
Post by: Knome on February 05, 2007, 02:04:36 AM
This mod doesn't seem to work with any other skins, can you give a list of things modified so i can implement them on my skin.  
Title: Re: Calendar mods
Post by: Kindred on February 05, 2007, 08:23:00 AM
open up the mod zipfile and view the install file inside it...   this has instructions on what code to add, change or remove.
Title: Re: Calendar mods
Post by: Chris Curran on February 08, 2007, 06:52:36 PM
I can confirm that it's an IE6 issue (I use Firefox). I have it fixed and will be posting an update soon...

Quote from: ooop on February 04, 2007, 03:21:19 AM
Soooo.....

i had some time to check out the issue i mentioned concerning how when editing an event it does not retain original dates >>> would you believe it >>> it's a browser thing - turns out it, what i was speaking of, has effect i mentioned (doesn't work properly) on the most popular browser there is >>> the dreaded IE6 - yup, that's right - with the mod installed, somehow original dates are not retained in the event edit form while using IE6 >>> can you believe it? :)
Title: Re: Calendar mods
Post by: ooop on February 08, 2007, 09:51:23 PM
cool...

what a "weird" surprise/"bug" - huh?
Title: Re: Calendar mods
Post by: Chris Curran on March 01, 2007, 11:54:49 PM
I've posted an update of this mod: http://www.planetcurran.com/smf/repeatEvents_1_2.zip

This version corrects a IE display error and adds a few config items. To turn the display of the Moon Phases on/off, go to Admin|Calendar and scroll to the bottom of the list:

Display Moon phases:    Turns the display of the Moon Phases on/off
Moon Phase text color:   The color of the text used to display the Moon Phase info.

Tested with 1.1.1 and 1.1.2.

Enjoy!
Chris

Title: Re: Calendar mods
Post by: ksieg on March 02, 2007, 10:47:27 PM
Hi Chris,

I just tried to install this using the package manager and got the following results:

QuoteInstalling this package will perform the following actions:
   Type    Action    Description
1.    Execute Modification    ./Themes/default/languages/index.english.php    Test successful
2.    Execute Modification    ./Sources/Calendar.php    Test successful
3.    Execute Modification    ./Sources/Post.php    Test successful
4.    Execute Modification    ./Themes/default/Calendar.template.php    Test failed
5.    Execute Modification    ./Themes/default/Post.template.php    Test successful
6.    Execute Modification    ./Themes/default/languages/ManageCalendar.english.php    Test successful
7.    Execute Modification    ./Themes/default/ManageCalendar.template.php    Test successful
8.    Execute Modification    ./Sources/ManageCalendar.php    Test successful
9.    Execute Code    add_settings.php    
10.    Execute Code    repeatEvents_modifyTables.php

Any ideas?

P.S.

Thank you very much for putting this mod together.  I'm shocked that this hasn't been done already by the dev team and, after reading this thread and others requesting recurring events as far back as 2005, I'm wondering if the dev team isn't listening to the community.  I'm very thankful to them for all the work they've done with SMF and it's an amazing piece of software so I'm not trying to bust their chops.

I'm looking forward to seeing this mod approved -- it's long past due that recurring events be added to the best piece of Forum software I've found out there -- SMF.
Title: Re: Calendar mods
Post by: Chris Curran on March 03, 2007, 12:06:20 AM
What version of SMF and what mods do you have installed?
Title: Re: Calendar mods
Post by: ooop on March 03, 2007, 12:20:10 AM
same thing here...
Quote4. Execute Modification   ./Themes/default/Calendar.template.php      Test failed  
Title: Re: Calendar mods
Post by: Chris Curran on March 03, 2007, 12:26:02 AM
Quote from: ooop on March 03, 2007, 12:20:10 AM
same thing here...
Quote4. Execute Modification   ./Themes/default/Calendar.template.php      Test failed  

Same question: what version of SMF and what mods are installed?
Title: Re: Calendar mods
Post by: ooop on March 03, 2007, 08:08:59 AM
sorry, i missed that Q....

i tried it on SMF 1.1.1
Title: Re: Calendar mods
Post by: Chris Curran on March 03, 2007, 09:10:21 AM
Quote from: ooop on March 03, 2007, 08:08:59 AM
sorry, i missed that Q....

i tried it on SMF 1.1.1

What mods are installed?
Title: Re: Calendar mods
Post by: ooop on March 03, 2007, 09:26:02 AM
none > virgin install...

i believe the problem is CDATA stuff in xml syntax:

repeatEvents_1_2.xml

in the middle of the last <add> for <file name="$themedir/Calendar.template.php" error="fatal"> is the following:

Quote]]>]]<![CDATA[
not commented out properly, or something (just a guess)

that old nesting the CDATA problem (at least i think that's the problem) ;)
Title: Re: Calendar mods
Post by: Chris Curran on March 03, 2007, 10:35:52 AM
Quote from: ooop on March 03, 2007, 09:26:02 AM
none > virgin install...

i believe the problem is CDATA stuff in xml syntax:

repeatEvents_1_2.xml

in the middle of the last <add> for <file name="$themedir/Calendar.template.php" error="fatal"> is the following:

Quote]]>]]<![CDATA[
not commented out properly, or something (just a guess)

that old nesting the CDATA problem (at least i think that's the problem) ;)

I do not think this is the issue. Again, what mods do you have installed?
Title: Re: Calendar mods
Post by: Chris Curran on March 03, 2007, 11:23:58 AM
Quote from: ooop on March 03, 2007, 09:26:02 AM
none > virgin install...


Missed this the first time... Do me a favor then. Extract the xml from the zip and run it through "test_modification.php". It should give a better clue as to what's the problem....

thx,
Chris
Title: Re: Calendar mods
Post by: ksieg on March 03, 2007, 01:27:58 PM
Chris,

I also have a virgin install with NO mods installed.  The version I've installed is 1.1.2.

Thanks,

--Ken
Title: Re: Calendar mods
Post by: ksieg on March 04, 2007, 06:17:06 PM
Chris, any updates on this?
Title: Re: Calendar mods
Post by: ooop on March 04, 2007, 08:33:03 PM
i have not yet run it through test_modification.php yet --- but i will say this - my suspicion that it was the nested CDATA stuff > does not seem to be the problem (it might be, but if it is, well then, there be another problem too - but chances are the "other" problem is the only one < did that make sense?)
Title: Re: Calendar mods
Post by: Chris Curran on March 04, 2007, 09:43:43 PM
Quote from: ksieg on March 04, 2007, 06:17:06 PM
Chris, any updates on this?


No, I'm waiting to here the results of running it through "test_modification.php"....
Title: Re: Calendar mods
Post by: ksieg on March 05, 2007, 12:34:34 AM
Hi Chris, I don't know how to run it through "test_modification.php" if you tell me I'll be happy to try it.

Thanks,

--Ken
Title: Re: Calendar mods
Post by: dawyndham on March 05, 2007, 05:23:17 PM
Chris,

Here are the results:

The following could not be found (or should not have been) in /......./Themes/default/Calendar.template.php: (note that it may not look like you typed it, this is normal.)
Quote\
      \';
\}

\?\>

It's this part of the code that's causing it.  The last operation to Calendar.template.php

Quote
<operation>
         <search position="replace"><![CDATA[
         </table>
      </form>';
}

?>
]]></search>
            <add><![CDATA[
         </table>
      </form>';

    if ($context['event']['repeating']=='0')
       echo '
        <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
           swapEndDate(\'none\');
        // ]]>]]<![CDATA[></script>';
}

?>

]]></add>
      </operation>
Title: Re: Calendar mods
Post by: ksieg on March 05, 2007, 06:36:55 PM
I'm really looking forward to using this mod.  Chris, if there's anything I can do at all to help please let me know.

Thanks again for the hard work.

--Ken
Title: Re: Calendar mods
Post by: ooop on March 05, 2007, 11:02:35 PM
thanks dawyndham - i think i got it (right in the area you 'pointed' to)....

i THINK the problem is the last search operation to Calendar.template.php looks for "line feed" (or a "CR" - carraige return) after "?>"

____________________________

?>( RIGHT HERE )
]]></search>
____________________________

BUT in Calendar.template.php there is no "line feed" after the last "?>"
- it stops dead right after that last "?>"

SO i changed:
_________________________________

      <operation>
         <search position="replace"><![CDATA[
         </table>
      </form>';
}

?>
]]></search>
            <add><![CDATA[
         </table>
      </form>';

    if ($context['event']['repeating']=='0')
       echo '
        <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
           swapEndDate(\'none\');
        // ]]>]]<![CDATA[></script>';
}

?>

]]></add>
      </operation>
_________________________________

TO:
_________________________________

      <operation>
         <search position="replace"><![CDATA[
                  </table>
               </td>
            </tr>
         </table>
      </form>';
}
]]></search>
            <add><![CDATA[
                  </table>
               </td>
            </tr>
         </table>
      </form>';

    if ($context['event']['repeating']=='0')
       echo '
        <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
           swapEndDate(\'none\');
        // ]]>]]<![CDATA[></script>';
}
]]></add>
      </operation>
_________________________________

in search function i simply dropped "?>" and reached up higher in the file (php) to assure unique hit (may not be best - but creates quick fix)

AND NOW all "Test successful" - also (BTW) installing now gives "The package was installed successfully. You should now be able to use whatever functionality it adds or changes; or not be able to use functionality it removes." - in other words > all looks good (so far, as far as installation ;) )

the resulting effect to Calendar.template.php (at its end/bottom) is...
(note i grabbed a little more of file to show context):
_________________________________

   echo '
                  </table>
               </td>
            </tr>
         </table>
      </form>';

    if ($context['event']['repeating']=='0')
       echo '
        <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
           swapEndDate(\'none\');
        // ]]></script>';
}

?>
_________________________________

Title: Re: Calendar mods
Post by: ooop on March 05, 2007, 11:09:51 PM
lol -- oddly in trying to get code to look good in my post above i used 'pre' tags > but lost 'returns' in its display --- lol

so please don't take above code display literally :)
Title: Re: Calendar mods
Post by: ooop on March 05, 2007, 11:30:00 PM
hmmm > since the echo statement is enclosed in single quotes would double quotes work for the parameter being passed to swapEndDate - i know double quotes work fine in echo's using single quotes without the need to escape them, but i don't know exactly (as yet) what or how you want swapEndDate's parameter to be passed - would double quotes work for this??

e.g.
swapEndDate("none");
Title: Re: Calendar mods
Post by: dawyndham on March 05, 2007, 11:41:30 PM
OK, It tested OK, and installed but there is a bug.

When I add an event it doesn't respect the end date.  The first time I tried it crashed the system by adding an event every day until infinity.  I removed the mod and tried again, this time with a monthly event, spanning three months and there are at least 6 that I have found so far.
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 12:30:17 AM
dawyndhah and ooop,

The CDATA issue was addressed here a few days ago:

http://tinyurl.com/yujqza

Another pair of eyes could verify that I did what I was instructed to do. ooop, you had the previous version of the mod installed - you did remember to uninstall it before trying this one, right? Why you guys are having troubles with the mod is very confusing in a number of ways.

1) I have a virgin install of 1.1.1 here. The mod installs and operates properly during my tests.

2) When I install the 1.1.2 mod (effectively upgrading it to 1.1.2) I can also install and operate the calendar mod. I rather doubt the 1.1.2 upgrade is causing problems, but even if it was it doesn't explain the 1.1.1 problems ooop is having. So.... WTF?

dawyndhah, Let me work through this install thing first...

Chris
Title: Re: Calendar mods
Post by: ooop on March 06, 2007, 02:17:18 AM
Chris --- when i say "virgin install" of smf i mean virginal in every sense --- to give your work proper attention (even though i'm pretty busy), i create a fresh/new/virgin install -- then proceed with latest version of your mod....

and note i'm not the only one with the issues mentioned...
why some expeience such issues and some (you for instance) do not, i can only venture to guess - and lamely at that >> type of server maybe????
Title: Re: Calendar mods
Post by: ooop on March 06, 2007, 02:49:10 AM
also i have to admit my ignorance as far as how "anal" smf's package manager is - but when i had checked out repeatEvents_1_2.xml in my editor that indicates/displays "End of Line" i noticed:
________________________

}[CR][LF]
[CR][LF]
?>[CR][LF]
________________________

where as Calendar.template.php (of smf 1.1.1) is:
________________________

}[LF]
[LF]
?>
________________________

WITH NOTHING (NO "End of Line" OF ANY KIND) AFTER THAT FINAL "?>"

Sooo - i figured i'd give it a spin and like i said -- it did the trick...
Title: Re: Calendar mods
Post by: Kindred on March 06, 2007, 07:26:07 AM
SMF's files are typically written in linux text, which does not use <cr><lf>

and the ?> should never have anything after it, since that can actually cause issues with the compiling of the file.
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 09:56:17 AM
Quote from: ooop on March 06, 2007, 02:17:18 AM
type of server maybe????

Beats me. After I ingest some coffee, I'm going to jump back into this from the start and re-check everything. So far, I'm the only one that seems to be able to install v1.2. Due to the results of that conversation in the Package SDK thread, I changed some settings in my editor - maybe that's burning me. But I STILL don't understand why I'm not able to dup these issues. I'm running this on a FC4 Linux server with Apache 2.2.3 and PHP 5.1.6. I'm also using the zip file on planetcurran.com as the test.
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 09:58:49 AM
Quote from: ooop on March 06, 2007, 02:49:10 AM
also i have to admit my ignorance as far as how "anal" smf's package manager is

Don't talk to me about the package manager right now - GRRRRR... :) It's very anal, and worst yet, not completely documented.
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 10:07:56 AM
Quote from: Kindred on March 06, 2007, 07:26:07 AM
SMF's files are typically written in linux text, which does not use <cr><lf>

Yea, that was asked and answered a few days ago in that Package SDK thread link I posted earlier. I was editing the suspect file in both vi and tse, maybe that's botched up something....

Quote
and the ?> should never have anything after it, since that can actually cause issues with the compiling of the file.

I presume you meant to say "parse" not "compile" as PHP code isn't "compiled". How do you figure? The "?>" simply turns the php mode off returning to standard html mode which is fine with CR's. PHP is fine with CR's, so I'm not sure what issues you refer to....
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 10:15:35 AM
Quote from: dawyndham on March 05, 2007, 11:41:30 PM
OK, It tested OK, and installed but there is a bug.

When I add an event it doesn't respect the end date.  The first time I tried it crashed the system by adding an event every day until infinity.  I removed the mod and tried again, this time with a monthly event, spanning three months and there are at least 6 that I have found so far.

Could you please check to see if v1.1 installs and operates properly on your system?

http://www.planetcurran.com/smf/repeatEvents_1_1.zip
Title: Re: Calendar mods
Post by: Kindred on March 06, 2007, 11:33:14 AM
yes, I meant to say parse...

empty <cr>s after the closing ?> tag can cause some servers to have problems.   We've seen it alot in the joomla bridge...
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 12:02:51 PM
Quote from: Kindred on March 06, 2007, 11:33:14 AM
yes, I meant to say parse...

empty <cr>s after the closing ?> tag can cause some servers to have problems.   We've seen it alot in the joomla bridge...

Really!? Sounds like a bug in the server sw to me. Reading in a LOC is trivial and handling the various EOL formats is also trivial (e.g. fgets()). Hmmm. When you say "server" are you referring to Linux vs Windows vs etc, or Apache vs IIS vs etc?
Title: Re: Calendar mods
Post by: ooop on March 06, 2007, 12:07:07 PM
> ah - got a notice that someone posted while i was typing this - i'll post anyway and see if it fits ;) <

kindred posted > "empty <cr>s after the closing ?> tag can cause some servers to have problems.   We've seen it alot in the joomla bridge" < WOW! blow my socks off
[ above is after edit ]

Quote from: Chris Curran on March 06, 2007, 10:07:56 AM
How do you figure? The "?>" simply turns the php mode off returning to standard html mode which is fine with CR's. PHP is fine with CR's, so I'm not sure what issues you refer to....
i wondered the same thing...
i've seen tons of php files that continue beyond php's final ?>

both with blank 'run on' and HTML to file's end.

it seems to me, as you said, Chris, at such point standard HTML simply starts - and a few blank "lines/CR/LF" doesn't interfere with HTML display at all (well in very rare cases it does > sometimes creating a space in page's display where it's undesired)....

let's not forget the real issue - not how EOL effects php and all -- but > is it real search creteria (at least with some systems

what all this really gets me wondering about is what and where is the regular expression engine that smf uses --- what i wonder now is it possible the package manager is calling an external search 'utility' and that is the variable that is different on all our systems -------- specifically, perhaps one 'engine' looks for a trailing LF wher perhaps another one doesn't < stab in the dark....

basically, the above, however, is now a mute point - in that both the simple, and now seeming proper, thing to do is merely match search string not only line by line, but also LF by LF (without them neato RC's) < that i think pretty much would cure all "simple" mod install issues - besides, the thing to do seems to be to match the smf LF convention anyway....

a good 'Find and Replace' app would make doing such child's play....    :P
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 01:53:52 PM
Quote from: ooop on March 06, 2007, 12:07:07 PM
a good 'Find and Replace' app would make doing such child's play....    :P

Actually, 'dos2unix filename' from the linux command line works even easier. :)

Removing the CR's is simple, certainly. However, before I run off and remove them, I'd like to try and understand how I got here to begin with. I'm also trying to understand why I can install on both 1.1.1 and 1.1.2 and (seemingly) no one else can.... My first guess was that I was working from a different zip than you guys, but I've checked that more than once....
Title: Re: Calendar mods
Post by: dawyndham on March 06, 2007, 05:02:25 PM
Quote from: Chris Curran on March 06, 2007, 10:15:35 AM

Could you please check to see if v1.1 installs and operates properly on your system?

http://www.planetcurran.com/smf/repeatEvents_1_1.zip

Chris,

1.1 Installs without a problem, and doesn't seem to have the same bug that I'm seeing.  What 1.2 is doing is when I try select an end date for the repeating it doesn't de-select the box that says no end date.
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 05:42:10 PM
Quote from: dawyndham on March 06, 2007, 05:02:25 PM
Chris,

1.1 Installs without a problem, and doesn't seem to have the same bug that I'm seeing.  What 1.2 is doing is when I try select an end date for the repeating it doesn't de-select the box that says no end date.

10-4 & thx.
Title: Re: Calendar mods
Post by: Chris Curran on March 06, 2007, 05:46:32 PM
Quote from: ooop on March 06, 2007, 12:07:07 PM
string not only line by line, but also LF by LF (without them neato RC's)

What does a Ritchie Chretien have to do with this? :D I agree, they're really neat... (http://www.rcopticalsystems.com)
Title: Re: Calendar mods
Post by: ooop on March 06, 2007, 07:50:25 PM
LOL - is that the thing you've been using to inspect the php? - it looks like a telescope - LOL

:D :D :D

hey there - anybody got the word on the search engine the package manager uses --- clueless >> is it PHP version "depended" (main PHP install)
Title: Re: Calendar mods
Post by: Chris Curran on March 07, 2007, 10:52:32 AM
<sigh>.... OK, I think I have a handle on what's going on. I uninstalled everything, bringing me back to 1.1.1 and looked at Calendar.template.php - it had a pair of CR/LF after the the closing ?>. I looked at Calendar.template.php in the original zip that I installed from and it does NOT have the CR/LF after the closing ?>. The only answer that makes sense is that I must had added those blank lines after the closing ?> - nothing else holds water. Since it was at the EOF, I wouldn't have noticed it and it would not have interfered with previous versions of this mod (i.e. 1.0 and 1.1 install fine for everyone).

To start correcting things, I yanked the Calendar.template.php from the install zip and started over with the 1.2 mod (now 1.2.1). During that process I discovered how I got into the CR/LF problem to start with. Calendar.template.php (from the org install zip) has a mix of CR/LF and LF EOL formats! The editor I use has a "smart" EOL option - if it loads a file and detects only LF's, it will use LF's as the EOL char. If it detects only CR's, it uses that. And if it detects CR/LF, it will use that EOL format. Upon loading Calendar.template.php my editor detected the CR/LF in the file and switched into "DOS" mode EOL format!

I'm working on packaging this up.....
Title: Re: Calendar mods
Post by: ooop on March 07, 2007, 05:02:08 PM
sheesh - wow -- Chris you're doing awsome...

i wonder if a "new" release calls for a new thread?
Title: Re: Calendar mods
Post by: Chris Curran on March 08, 2007, 12:26:07 AM
OK, lets give this one a whirl:

http://www.planetcurran.com/smf/repeatEvents_1_2_1.zip

See the readme for an added feature.
Title: Re: Calendar mods
Post by: dawyndham on March 08, 2007, 12:38:53 AM
Yeah, it installs and works OK.

One thing I did notice though.  If I place a recurring event to happen every day with no end it really kills the server I'm running on.  Just can't handle writing that many events to the SQL DB or something.

Thanks a bunch Chris.  I've been waiting for this functionality for the past 12 months, and your timing is immaculate.  Just as Uni started again and our weekly kayaking sessions resumed.  I just wish I knew more about php and xml could have helped you with your issues before.
Title: Re: Calendar mods
Post by: Chris Curran on March 08, 2007, 12:51:38 AM
Hmmm. That's odd. I just tried that here at it seems to work fine (repeating every day, no end). I'm not sure why your server would be slowing down either - my old 450SMP w/512mb is running real snappy, even with the test event. BTW, there is only one entry in the DB for an event. Repeating events are created on the fly (for the current month only).

ooop, anyone else, would you pls try this test?

Quote from: dawyndham on March 08, 2007, 12:38:53 AM
Yeah, it installs and works OK.

One thing I did notice though.  If I place a recurring event to happen every day with no end it really kills the server I'm running on.  Just can't handle writing that many events to the SQL DB or something.

Thanks a bunch Chris.  I've been waiting for this functionality for the past 12 months, and your timing is immaculate.  Just as Uni started again and our weekly kayaking sessions resumed.  I just wish I knew more about php and xml could have helped you with your issues before.
Title: Re: Calendar mods
Post by: dawyndham on March 08, 2007, 01:00:27 AM
Hmm, Interesting.  It may have been something to do with the dodgy slow connection here at work then, and I incorrectly assumed it was related to the forum server.

It seems to be working well though, it really does blow my mind that this hasn't been added as a default function considering the length of time people have been asking for it.
Title: Re: Calendar mods
Post by: ksieg on March 08, 2007, 03:06:03 AM
Hi Chris,

I just installed on v1.1.2 and it works great!  Thank you for a much needed mod!

The only problem I'm having is that I can't turn off moon phases or change the moon phase text color. 

I change them in the calendar admin section and it doesn't change on the site at all.

I was looking for the code to change it in the files and can't seem to find it.

Thanks again, great mod!

--Ken
Title: Re: Calendar mods
Post by: Chris Curran on March 08, 2007, 05:44:23 PM
Quote from: ksieg on March 08, 2007, 03:06:03 AM
The only problem I'm having is that I can't turn off moon phases or change the moon phase text color. 

I can't reproduce this. I wonder if you have to do like I do and hit the "Save" button twice before it works? This doesn't (seem to) happen with IE, but it does with Firefox (1.5.0.10)...
Title: Re: Calendar mods
Post by: Kindred on March 09, 2007, 03:34:07 PM
BTW: I installed the version on the mod site into my test system (1.1.2) (bridged with joomla, BTW) and it seems to work perfectly.


tested:  
Moon Phases activate/deactivate
Moon phases colours
recurring event - every day: no end date
deleted recurring event - every day: no end date
recurring event - every day: 5 days
changed recurring event - every day: 5 days to be 3 days
recurring event - every other week: til May (linked to post)




Revised:

I just noticed some undefined notices in my smf error log
action=calendar;sa=post 
8: Undefined offset: 4
File: /.../Themes/default/Post.template.php (eval?)
Line: 493

the undefined offsets are for 4, 5, 6, 7

Title: Re: Calendar mods
Post by: Chris Curran on March 09, 2007, 10:17:35 PM
Thanks Kindred. I'm not sure how you found that with all the other errors SMF is generating! Here is the updated mod package that fixers that error and also removes "span" from the ManageCalendar code/admin screen:

http://www.planetcurran.com/smf/repeatEvents_1_2_2.zip

Here are the errors that dominate my log:


8: Undefined index: topic
File: /opt/www2/htdocs/spac/forum/Sources/BoardIndex.php
Line: 508


Every visit to the forum home generates four of these errors (line 508, 515, 516, 521).
Title: Re: Calendar mods
Post by: Kindred on March 09, 2007, 11:17:25 PM
interestingly enough, that error is generated on one of my systems, but only for people with global mod or admin access...   regular users don't cause the errors.

-edit-   looked at it quickly tonight....

seems to be a few other things popping up now. :(

8: Undefined index: cal_maxspan
File: /.../Sources/ManageCalendar.php
Line: 259
2: Missing argument 3 for db_query()
File: /.../Sources/Subs.php
Line: 238
2: Missing argument 2 for db_query()
File: /.../Sources/Subs.php
Line: 238

Title: Re: Calendar mods
Post by: Chris Curran on March 09, 2007, 11:35:27 PM
Hmmm. Yep, I forgot to remove the 'span' code from ManageCalendar.php:


            'cal_allowspan' => isset($_POST['cal_allowspan']) ? '1' : '0',
            'cal_maxspan' => (int) $_POST['cal_maxspan'],


I'll have it in the next posting (it's not critical so I won't repost for that right now). The last two errors in Subs.php - that's not me (right?).
Title: Re: Calendar mods
Post by: Kindred on March 09, 2007, 11:36:56 PM
I think those are related to the mod, since they only appeared after the installation, when I went to view the calendar....
Title: Re: Calendar mods
Post by: Chris Curran on March 09, 2007, 11:53:17 PM
I dunno about that.... I checked all the files I touched and all have the proper format for db_query(). Moreover, when I view the calendar no errors are generated in my log. Head scratcher...
Title: Re: Calendar mods
Post by: Kindred on March 09, 2007, 11:56:01 PM
hrm....   it's a fresh install... (I just over-wrote everything today while attempting to clean up some other junk)

I'll try 1.2.3 when you post it and see if it happens again....
Title: Re: Calendar mods
Post by: Chris Curran on March 10, 2007, 12:00:20 AM
Kindred,

I have a calendar feature I need to add for our club use that seems rather close to your attendees mod. I need to be able to have (for lack of a better name) event "coordinators" and event "participants". To clarify:

Event participant: Any user who has agreed (or been volunteered<g>) to participate in an event.

Event coordinator: The person(s) in charge of the event. They are the main contact point and person(s) to see when things change. They can modify the event details, and can add/remove participants. They can also elevate event participants to coordinator status (allowing for multiple coordinators).

Common to coordinators and participants: PM's can be "broadcast" to all event members.

Events: Any changes to event details provides the option to send notifications to all event members. A 'max number of participants' field needs to be added.

It seems that my "participants" is very close in concept to your "attendees". My "coordinators" are attendees with special privileges. Now the question: Do you think that you're going to be able to find time to work on your mod in the next few weeks? If not, I'm going to jump into this (I am retired ya know :)).
Title: Re: Calendar mods
Post by: Kindred on March 10, 2007, 12:40:03 AM
Chris,

You know, ever since I promized to update the phatcalpack, I have found myself incredibly busy and the niggling little last details have taken me months.

What I am trying to say is...   PLEASE! You are welcome to do your mod, since I have no idea when I will be able to actually finish up the phatcalpack. :(

If you do that, the only thing left for the phatcalpack would be the ability to upload a holiday list (originally done by Grudge early in 1.0)...

Actually, your concept of the attendees is more sleek than mine. I took JackRabbit's original and just clutzed it together for 1.0...
Title: Re: Calendar mods
Post by: Kindred on March 10, 2007, 12:01:26 PM
Interesting...

I uploaded a fresh copy of SMF 1.1.2 (full install), overwriting everything.

All of my
8: Undefined index: topic
File: /.../Sources/BoardIndex.php
Line: 508

messages stopped...

I think it may have had something to do with an interaction between the 1.1.2 update mod package and one of the other installed mods.
Title: Re: Calendar mods
Post by: dawyndham on March 12, 2007, 01:21:22 AM
Hmmm,

It seems to be interferring with previously posted events in the calendar.  When i install the mod, any events that currenly span multiple days cease to span.

I'm getting the following errors too:

Quote
..../index.php?action=packages;sa=install2;package=repeatEvents_1_2_2.zip

2: Missing argument 2 for db_query(), called in ...../Packages/temp/add_settings.php on line 35 and defined
File: ...../Sources/Subs.php
Line: 238

Quote
..../index.php?action=packages;sa=install2;package=repeatEvents_1_2_2.zip

2: Missing argument 3 for db_query(), called in ...../Packages/temp/add_settings.php on line 35 and defined
File: ...../Sources/Subs.php
Line: 238

Seems strange to me as the mod doesn't touch subs.php

I'm also still losing the calendar every time I post a recurring event.  If I try and display any month that has a recurring event it just displays a blank screen.
Title: Re: Calendar mods
Post by: Chris Curran on March 12, 2007, 10:46:50 AM
Quote from: dawyndham on March 12, 2007, 01:21:22 AM
Hmmm,

It seems to be interferring with previously posted events in the calendar.  When i install the mod, any events that currenly span multiple days cease to span.

That is normal. The 'span' logic has been replaced with true repeating events.

Quote
..../index.php?action=packages;sa=install2;package=repeatEvents_1_2_2.zip

2: Missing argument 2 for db_query(), called in ...../Packages/temp/add_settings.php on line 35 and defined
File: ...../Sources/Subs.php
Line: 238

v1.2.3 has a fix for the 'add_settings.php' issue. This file (add_settings.php) is taken from the SDK, and is obviously broken....

Quote
I'm also still losing the calendar every time I post a recurring event.  If I try and display any month that has a recurring event it just displays a blank screen.

Dunno. Can you look at your http server logs to see if there is some error?
Title: Re: Calendar mods
Post by: Chris Curran on March 12, 2007, 11:01:34 AM
Kindred,

OK, then I'll start thinking in that direction. If I may:

1) What names should these roles be titled? My names of 'coordinator' and 'participant' are a bit wordy. I came up with these names to reflect the nature of our intended use - general event handling and a classroom/instructor/student type of interaction. Are there better terms for these two roles?

2) I've never looked at your prev implementation of this feature. What UI mechanism did you use?

3) Did the event have to be linked to a post before it was available to 'attendees'? Events that are not linked have no href to click on, so I presume this is the case?

4) I (think I) saw somewhere that the attendee id was stored in a TEXT field in the event db. I'm not sure which is better - two TEXT fields in the db for each event (coordinators and participants), or, a separate table linked to the event id. The former means easier/less code, but wastes some db space; the latter is more efficient wrt db space usage, but is a little more code and maybe a (very) tiny performance hit. Opinions?

Title: Re: Calendar mods
Post by: Kindred on March 12, 2007, 11:50:17 AM
1- Honestly, I think coordinator and participant are probably the best solutions...  However, you could make the actual terms definable on a per installation basis in the admin section (?)

2- It was just a display at the top of the post (similar to the way Polls display) that indicated current attendees and had a link to add/remove your name form the list.

3- yes, the event for attendees had to be linked to a post...

4- Hmmm...    I would actually suggest the second option. Having now managed a site that runs with a database in the hundreds of gigabytes, I have to say that anything that decreases db overhead is a good idea.
Title: Re: Calendar mods
Post by: Chris Curran on March 16, 2007, 09:48:20 AM
Quote from: Kindred on March 12, 2007, 11:50:17 AM
4- Hmmm...    I would actually suggest the second option. Having now managed a site that runs with a database in the hundreds of gigabytes, I have to say that anything that decreases db overhead is a good idea.

I certainly understand that dynamic. Before retiring, I was CTO at Tyler Retail, Inc (tylernet.com) and one of our customers is Tweeter. Talk about monster db's! Everything is measured in terabytes there... :)

Upon further reflection, I've decided to include the new event fields into the standard calendar db table. There is only one record (row) for each event, and I don't think there's going to be enough event records (rows) to warrant the added complexity of a shadow db. If anyone has a strong argument against this, speak up....

I'm off for the New Moon weekend and will check back in on Tue or Wed....

cheers,
Chris
Title: Re: Calendar mods
Post by: Chris Curran on March 26, 2007, 08:33:38 AM
Quote from: Chris Curran on March 16, 2007, 09:48:20 AM
Upon further reflection, I've decided to include the new event fields into the standard calendar db table. There is only one record (row) for each event, and I don't think there's going to be enough event records (rows) to warrant the added complexity of a shadow db. If anyone has a strong argument against this, speak up....

Since no one seems to have an objection, I'm going to start down this road....
Title: Re: Calendar mods
Post by: Leszer on April 11, 2007, 11:17:07 AM
Hey Chris.

I've been using SMF at work for my particular group to help in with our communication and I have the calendar mod already installed but was curious if the attendees code would be added soon?
Title: Re: Calendar mods
Post by: c3vettes on April 12, 2007, 10:24:59 PM
I'm glad you're doing this, Chris. I too have been waiting for some time for this very feature. Tnx! I'll be using this on a car club site where members attend events, such as car shows and cruises, and many area businesses hold cruise-ins, so this area stays pretty busy, and the cruise-ins are all recurring events. The attendees list will also be awesome!

8) 8) 8)
Title: Re: Calendar mods
Post by: Jesse Jericho on April 12, 2007, 10:46:17 PM
Definitely looking forward to this mod!
Title: Re: Calendar mods
Post by: Kindred on April 12, 2007, 11:00:23 PM
Jesse,

the recurring events mod is already released. See the link in the first post.
Title: Re: Calendar mods
Post by: Jesse Jericho on April 12, 2007, 11:46:33 PM
Quote from: Kindred on April 12, 2007, 11:00:23 PM
Jesse,

the recurring events mod is already released. See the link in the first post.

Oh I was referring to the organizer/attendee part :)
Title: Re: Calendar mods
Post by: brelwit on April 15, 2007, 01:09:40 AM
I am logged-in as Admin and am experiencing some errors after I installed this mod in my fresh installation of SMF 1.1.2.  Below are screenshots and explanations on errors experienced:

PHP tag appearing on the top of the Calendar Page:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg184.imageshack.us%2Fimg184%2F7950%2Fsmf1fi5.jpg&hash=abb772479cb7326930ab646182fd0116bce5a853)

Upon clicking the "Link To Calender" button, I was redirected to the Edit page for that Calendar event then saw the second screen (see image in the bottom). Some codes about Javascript appears at this Edit page. Can these codes be removed from being displayed?  Has anyone experienced this?

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg405.imageshack.us%2Fimg405%2F2264%2Fsmf2oe0.jpg&hash=9f45deeb9426111645423474f6113cc46319775d)

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg402.imageshack.us%2Fimg402%2F3032%2Fsmf3ur2.jpg&hash=5665052c1b582ef7e2a803f0525a55b9cc5c72af)

Hope anybody can help me. Thank you.
Title: Re: Calendar mods
Post by: brelwit on April 15, 2007, 09:18:21 AM
Also do you know where I can find the tag to change the text color of Holidays?  I can't seem to find it anyhere.  I've looked in the templates css file and index already.  The color is: #000080.  Thank you.  :)
Title: Re: Calendar mods
Post by: Kindred on April 15, 2007, 09:37:13 AM
the holiday colour is defined in SMF admin > calendar > holiday color
Title: Re: Calendar mods
Post by: dman63119 on April 15, 2007, 11:56:01 AM
Quote from: brelwit on April 15, 2007, 01:09:40 AM
PHP tag appearing on the top of the Calendar Page:

I am getting the exact same tags showing on the Calendar page. However, I have version 1.1.1. I'm guessing this is being caused by sources/Calendar.php?

QuoteHope anybody can help me. Thank you.

Same here.

thanks,
Adam
Title: Re: Calendar mods
Post by: dawyndham on April 15, 2007, 06:52:50 PM
Quote from: dman63119 on April 15, 2007, 11:56:01 AM
Quote from: brelwit on April 15, 2007, 01:09:40 AM
PHP tag appearing on the top of the Calendar Page:

I am getting the exact same tags showing on the Calendar page. However, I have version 1.1.1. I'm guessing this is being caused by sources/Calendar.php?

QuoteHope anybody can help me. Thank you.

Same here.

thanks,
Adam

Yeah, those are the tags I was seeing when I was having the problems I discussed a month or so ago.  I thought I was the only one.
Title: Re: Calendar mods
Post by: citron on April 18, 2007, 01:48:03 PM
Quote from: dawyndham on April 15, 2007, 06:52:50 PM
Quote from: dman63119 on April 15, 2007, 11:56:01 AM
Quote from: brelwit on April 15, 2007, 01:09:40 AM
PHP tag appearing on the top of the Calendar Page:

I am getting the exact same tags showing on the Calendar page. However, I have version 1.1.1. I'm guessing this is being caused by sources/Calendar.php?

QuoteHope anybody can help me. Thank you.

Same here.

thanks,
Adam

Yeah, those are the tags I was seeing when I was having the problems I discussed a month or so ago.  I thought I was the only one.

I'm having the same issue (PHP tag appearing on the top of the calendar page).
Title: Re: Calendar mods
Post by: brelwit on April 18, 2007, 11:48:46 PM
Quote from: Kindred on April 15, 2007, 09:37:13 AM
the holiday colour is defined in SMF admin > calendar > holiday color

Got it.  Thanks!  :)
Title: Re: Calendar mods
Post by: brelwit on April 18, 2007, 11:54:36 PM
I've been looking for a forum software with excellent Calendar Features.  This mod made me consider SMF.  It would be great too if the Attendee Listing is someday included in the mod. 

If the errors I mentioned above will be fixed, I will probably replace my old e107 powered website.  Hope someone knows how to fix this mod's errors.  :)
Title: Re: Calendar mods
Post by: Chris Curran on April 19, 2007, 06:41:23 AM
Pardon the brevity of this post - I'm camping and using a cell phone attached to my laptop to access the net (as in S L O W). For future reference, if it's near New Moon, I'm almost always unavailable. I go camping for about a week around that time of the month....

I think the rouge tag has already been fixed - it's posted somewhere back in this thread with a link to the zip on my home page. I'll check in more detail when I return (Sunday).
Title: Re: Calendar mods
Post by: Kindred on April 19, 2007, 07:58:20 AM
when you get back, chris, maybe you can upload an update the mod available for d/l on the mod site?

for everyone else...
Quote
Here is the updated mod package that fixers that error and also removes "span" from the ManageCalendar code/admin screen:

http://www.planetcurran.com/smf/repeatEvents_1_2_2.zip
Title: Re: Calendar mods
Post by: citron on April 19, 2007, 09:36:52 AM
Quote from: Kindred on April 19, 2007, 07:58:20 AM
when you get back, chris, maybe you can upload an update the mod available for d/l on the mod site?

for everyone else...
Quote
Here is the updated mod package that fixers that error and also removes "span" from the ManageCalendar code/admin screen:

http://www.planetcurran.com/smf/repeatEvents_1_2_2.zip

I can confirm version 1.2.2 removes the PHP bracket from the top left, but the script code is still displayed at the bottom of the Post Event screen.

It says, "<script language="JavaScript" type="text/javascript"><![CDATA[ swapEndDate('none'); // ]]></script>".&nbsp; A previous poster (brelwit) in this thread provided a screen shot of the error.
Title: "Force default board in events" issue
Post by: citron on April 20, 2007, 11:08:45 AM
(Maybe this should be broken out to a new thread?  If so, could a moderator please perform that action?)

Short explanation: The "Force default board in events" setting in the "Repeating Calendar Events" mod does not function on the second Post Event screen.

1. Is this a bug or feature?
2. Can anybody confirm my findings?

Long explanation:
Environment
- SMF 1.1.2
- Default theme
- Repeating Calendar Events v1.2.2

The calendar options are configured as shown...
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg377.imageshack.us%2Fimg377%2F4884%2Fpostevent0on8.jpg&hash=d157adcce7d05462ddeadc1efe10849a10c0e4a7)
http://img377.imageshack.us/img377/4884/postevent0on8.jpg

On the first Post Event screen, as expected, the Post In field is grayed out...
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg377.imageshack.us%2Fimg377%2F7504%2Fpostevent1dq6.jpg&hash=c6462ff483b7998ea14374ce82d8acf476a21a1c)
http://img377.imageshack.us/img377/7504/postevent1dq6.jpg

But, on the second Post Event screen (reached after clicking Post on the first screen), the Post In field defaulted to the first alphabetical board (not the board selected in the Calendar settings), and is not grayed out...
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg383.imageshack.us%2Fimg383%2F7629%2Fpostevent2lk2.jpg&hash=db94494d983c8dd3a9d933da0f3c7d56671b6667)
http://img383.imageshack.us/img383/7629/postevent2lk2.jpg
Title: Re: Calendar mods
Post by: EdwinN on April 21, 2007, 03:28:57 AM
Can someone tell me how to code/configure it so it works on/with dutch language.

It works, but i cant see the written lines in dutch language. Wich files do i need to edit?
Title: Re: Calendar mods
Post by: Kindred on April 21, 2007, 07:25:13 AM
you will need to open modifications.english.php, find all of the strings added by this mod and then add the saem (translated) strings to modifications.dutch.php
Title: Re: Calendar mods
Post by: rosiem on April 21, 2007, 07:44:18 PM
At the top of my forum there's a ?>
How can I get rid of it?
Title: Re: Calendar mods
Post by: Kindred on April 21, 2007, 10:54:34 PM
Try reading a few posts back?

Quote from: Kindred on April 19, 2007, 07:58:20 AM
for everyone else...
Quote
Here is the updated mod package that fixers that error and also removes "span" from the ManageCalendar code/admin screen:

http://www.planetcurran.com/smf/repeatEvents_1_2_2.zip
Title: Re: Calendar mods
Post by: rosiem on April 22, 2007, 12:29:04 PM
oops sorry. :) Thanks!
Title: Re: Calendar mods
Post by: Chris Curran on April 22, 2007, 09:49:52 PM
I'm back, but whipped. I'll address the q's & c's tomorrow....
Title: Re: Calendar mods
Post by: brelwit on April 26, 2007, 05:42:46 AM
Quote from: Chris Curran on April 22, 2007, 09:49:52 PM
I'm back, but whipped. I'll address the q's & c's tomorrow....

Ok, hope these errors are easy to fix.  Thanks Chris! :)
Title: Re: Calendar mods
Post by: Poreman on April 27, 2007, 09:55:51 AM
After installing  Repeating Events for Calendar
I am running SMF 1.1.2

8: Undefined index: event
File: /home/xxxxx/xxxxxxxx/forums/Themes/default/Post.template.php
Line: 855

The Line refered to is:
if ($context['event']['repeating']=='0')

The error is showing up in admin error logs
Ideas?
Thanks
Poreman
Title: Re: Calendar mods
Post by: citron on May 02, 2007, 02:48:51 PM
Was anybody able to confirm the findings I reported in Reply #122 of this thread?
Title: Re: Calendar mods
Post by: brelwit on May 07, 2007, 10:37:29 AM
Quote from: citron on May 02, 2007, 02:48:51 PM
Was anybody able to confirm the findings I reported in Reply #122 of this thread?

Yep, I confirm that this bug also exists along with the "CDDATA..." code that appears at the bottom of some of the Calendar pages.  These bugs are what's keeping me from using SMF.  If these can be fixed then SMF is the only open source forum that I know of with a working Repeating Calendar.
Title: Re: Calendar mods
Post by: citron on May 08, 2007, 01:34:33 PM
Quote from: brelwit on May 07, 2007, 10:37:29 AM
Quote from: citron on May 02, 2007, 02:48:51 PM
Was anybody able to confirm the findings I reported in Reply #122 of this thread?

Yep, I confirm that this bug also exists along with the "CDDATA..." code that appears at the bottom of some of the Calendar pages.&nbsp; These bugs are what's keeping me from using SMF.&nbsp; If these can be fixed then SMF is the only open source forum that I know of with a working Repeating Calendar.

Thanks for the confirmation.  Yes, these two bugs are the reasons keeping me from using this mod.
Title: Re: Calendar mods
Post by: farzad on May 10, 2007, 08:35:42 AM
sweet
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 09:43:26 AM
OK folks, update posted. Let me know how it works out for ya.......
Title: Re: Calendar mods
Post by: farzad on May 10, 2007, 09:49:37 AM
if i uninstall the original mod and install the mod again will i lose all my repeating events?
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 10:07:25 AM
Quote from: farzad on May 10, 2007, 09:49:37 AM
if i uninstall the original mod and install the mod again will i lose all my repeating events?

No
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 10:45:16 AM
Quote from: citron on May 02, 2007, 02:48:51 PM
Was anybody able to confirm the findings I reported in Reply #122 of this thread?

I forgot to include the fix for this in v1.2.3 that I posted a few minutes ago. v1.2.4 is now posted...
Title: Re: Calendar mods
Post by: farzad on May 10, 2007, 10:52:34 AM
hurray!  nice work!
Title: Re: Calendar mods
Post by: Poreman on May 10, 2007, 02:48:06 PM
Using SMF V 1.1.2

After trying the previous versions of the repeating events I unInstalled due to multiple error log messages.  Seeing a new version I decided to try it again with same results as last Multiple error messages.  Below is the errors line numbers of BoardIndex.php of source directory.  BoardIndex.php seems to be the only file outputting errors.

Errors

8: Undefined index: topic
File: /home/MySite/RootDir/forums/Sources/BoardIndex.php
Line: 593

8: Undefined index: topic
File: /home/MySite/RootDir/forums/Sources/BoardIndex.php
Line: 589


8: Undefined index: topic
File: /home/MySite/RootDir/forums/Sources/BoardIndex.php
Line: 588


8: Undefined index: topic
File: /home/MySite/RootDir/forums/Sources/BoardIndex.php
Line: 587

8: Undefined index: topic
File: /home/MySite/RootDir/forums/Sources/BoardIndex.php
Line: 580



Line 580 - if (isset($duplicates[$events[strftime('%Y-%m-%d', $i)][$ev]['topic'] . $events[strftime('%Y-%m-%d', $i)][$ev]['title']]))
Line 581 -{
Line 582 -unset($events[strftime('%Y-%m-%d', $i)][$ev]);
Line 583 - continue;
Line 584 - }
Line 585
Line 586 - $this_event = &$events[strftime('%Y-%m-%d', $i)][$ev];
Line 587 - $this_event['href'] = $this_event['topic'] == 0 ? '' : $scripturl . '?topic=' . $this_event['topic'] . '.0';
Line 588 - $this_event['modify_href'] = $scripturl . '?action=' . ($this_event['topic'] == 0 ? 'calendar;sa=post;' : 'post;msg=' . $this_event['msg'] . ';topic=' . $this_event['topic'] . '.0;calendar;') . 'eventid=' . $this_event['id'] . ';sesc=' . $sc;
Line 589 - $this_event['can_edit'] = allowedTo('calendar_edit_any') || ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own'));
Line 590 - $this_event['is_today'] = (strftime('%Y-%m-%d', $i)) == strftime('%Y-%m-%d', forum_time());
Line 591 - $this_event['date'] = strftime('%Y-%m-%d', $i);
Line 592
Line 593 - $duplicates[$this_event['topic'] . $this_event['title']] = true;
Line 594 - }


I get these error messages added into error log each time a member log enters the forums.

Can anyone tell me what is causing the errors and what is needed to fix this issue?
Your help will be appreciated

Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 03:44:41 PM
Quote from: Poreman on May 10, 2007, 02:48:06 PM
8: Undefined index: topic
File: /home/MySite/RootDir/forums/Sources/BoardIndex.php
Line: 593

See post #99 of this thread (bottom of page 5).

BTW, why are you line numbers so high in BoardIndex? That chunk of code you quoted is line number 508 for me (your line number 580)....
Title: Re: Calendar mods
Post by: Poreman on May 10, 2007, 06:03:20 PM
Quote from: Chris Curran on May 10, 2007, 03:44:41 PM
BTW, why are you line numbers so high in BoardIndex? That chunk of code you quoted is line number 508 for me (your line number 580)....
I Have  "Users online today" Mod installed, which included about 71 Lines of in the BoardIndex.php, which could be a problem, I am not a php guru so I wouldn't know.  Here is the code below if anyone wishes to examine and tell me if it is causing the 8: Undefined index: topic errors


// Load the users online today.
$date = @getdate(forum_time(false));
$midnight = mktime(0, 0, 0, $date['mon'], $date['mday'], $date['year']) - ($modSettings['time_offset'] * 3600);

$s = strpos($user_info['time_format'], '%S') === false ? '' : ':%S';
if (strpos($user_info['time_format'], '%H') === false && strpos($user_info['time_format'], '%T') === false)
$time_fmt = '%I:%M' . $s . ' %p';
else
$time_fmt = '%H:%M' . $s;

$result = db_query("
SELECT
mem.ID_MEMBER, mem.lastLogin, mem.realName, mem.memberName, mem.showOnline,
mg.onlineColor, mg.ID_GROUP, mg.groupName
FROM {$db_prefix}members AS mem
LEFT JOIN {$db_prefix}membergroups AS mg ON (mg.ID_GROUP = IF(mem.ID_GROUP = 0, mem.ID_POST_GROUP, mem.ID_GROUP)) WHERE mem.lastLogin >= $midnight", __FILE__, __LINE__);

$context['num_hidden_users_online_today'] = 0;
$context['users_online_today'] = array();
$context['list_users_online_today'] = array();

while ($row = mysql_fetch_assoc($result))
{
if (empty($row['showOnline']))
{
$context['num_hidden_users_online_today'] = $context['num_hidden_users_online_today'] + 1;
if (!$user_info['is_admin']) continue;
}

$userday = strftime('%d', forum_time(true));
$loginday = strftime('%d', forum_time(true, $row['lastLogin']));
$yesterday = $userday == $loginday ? '' : $txt['uot_yesterday'];

$lastLogin = $yesterday . strftime($time_fmt, forum_time(true, $row['lastLogin']));
$title = ' title="' . $lastLogin . '"';

// Some basic color coding...
if (!empty($row['onlineColor']))
$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['ID_MEMBER'] . '"' . $title . ' style="color: ' . $row['onlineColor'] . ';">' . $row['realName'] . '</a>';
else
$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['ID_MEMBER'] . '"' . $title . '>' . $row['realName'] . '</a>';

$is_buddy = in_array($row['ID_MEMBER'], $user_info['buddies']);
if ($is_buddy)
{
$link = '<b>' . $link . '</b>';
}

$context['users_online_today'][$row['lastLogin'] . $row['memberName']] = array(
'id' => $row['ID_MEMBER'],
'username' => $row['memberName'],
'name' => $row['realName'],
'group' => $row['ID_GROUP'],
'href' => $scripturl . '?action=profile;u=' . $row['ID_MEMBER'],
'link' => $link,
'is_buddy' => $is_buddy,
'hidden' => empty($row['showOnline']),
);

$context['list_users_online_today'][$row['lastLogin'] . $row['memberName']] = empty($row['showOnline']) ? '<i>' . $link . '</i>' : $link;
}
mysql_free_result($result);

krsort($context['users_online_today']);
krsort($context['list_users_online_today']);

$context['num_users_online_today'] = count($context['users_online_today']);
if (!$user_info['is_admin'])
{
$context['num_users_online_today'] = $context['num_users_online_today'] + $context['num_hidden_users_online_today'];
}]]>


Thanks
Title: Re: Calendar mods
Post by: calv on May 10, 2007, 06:29:10 PM
Hi,
Ive installed repeatEvents_1_2_1.zip on 1.1.2 manually as it failed totally though the package manager... Though when I got the the calander now I get the following msg:
Unknown column 'cal.repeating' in 'field list'
File: /home/qldcic/public_html/forum/Sources/Calendar.php
Line: 449

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.2, while your database is at version 1.1.1. The above error might possibly go away if you execute the latest version of upgrade.php.

My code is as follows:
430   // read repeating events from the calendar file
431   $result = db_query("
432      SELECT
433         cal.ID_EVENT, cal.startDate, cal.endDate, cal.title, cal.ID_MEMBER, cal.ID_TOPIC,
434         cal.ID_BOARD,
435         cal.repeating,
436         cal.repeat1_parm1,
437         cal.repeat1_parm2,
438         cal.repeat2_parm1,
439         cal.repeat2_parm2,
440         cal.repeat2_parm3,
441         cal.repeat_end_type,
442         b.memberGroups, t.ID_FIRST_MSG
443      FROM {$db_prefix}calendar AS cal
444         LEFT JOIN {$db_prefix}boards AS b ON (b.ID_BOARD = cal.ID_BOARD)
445         LEFT JOIN {$db_prefix}topics AS t ON (t.ID_TOPIC = cal.ID_TOPIC)
446      WHERE repeating!='0'
447          AND cal.startDate <= '$high_date' " .
448         ($use_permissions ?
449          "AND (cal.ID_BOARD=0 OR $user_info[query_see_board])" : ''), __FILE__, __LINE__);

whats the structure of the table smf_calander required so I can make the changes needed?

TIA
Title: Re: Calendar mods
Post by: Poreman on May 10, 2007, 07:57:41 PM
Quote from: calv on May 10, 2007, 06:29:10 PM
Hi,
Ive installed repeatEvents_1_2_1.zip on 1.1.2 manually as it failed totally though the package manager... Though when I got the the calander now I get the following msg:
Unknown column 'cal.repeating' in 'field list'
File: /home/qldcic/public_html/forum/Sources/Calendar.php
Line: 449

TIA


Did you somehow add the tables and info in mysql which is in the # repeatEvents_modifyTables.php
Title: Re: Calendar mods
Post by: calv on May 10, 2007, 08:27:07 PM
Hi Poreman,
No i havnt, I just manually installed repeatEvents_1_2_1.xml.
but just looking at repeatEvents_modifyTables.php this is the table info I require  ;D Give me a few hours and I'll let you know if it worked...

Thanks!
Title: Re: Calendar mods
Post by: Kindred on May 10, 2007, 08:43:06 PM
you really need to install v1.2.4 instead of 1.2.1
Title: Re: Calendar mods
Post by: Poreman on May 10, 2007, 09:00:07 PM
still need to see if anyone can figure out conflict from repeating events and Mod Users online today as stated in message #142

any php gurus out their that can figure this out
Appreciated
Poreman
Title: Re: Calendar mods
Post by: calv on May 10, 2007, 09:03:16 PM
updating the tables has worked! as poreman found... added it via phpmysql.


Thanks!

1.2.4 isnt avaliable from the mods? I always like the most up to date versions...
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 09:53:58 PM
calv,

Quote
Ive installed repeatEvents_1_2_1.zip on 1.1.2 manually as it failed totally though the package manager...
OK, generally speaking, what you're doing isn't a good idea (what did you do to handle the add_settings.php script?). If the package manager is failing, that's where the focus should be...

Quote
Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.2, while your database is at version 1.1.1. The above error might possibly go away if you execute the latest version of upgrade.php.

Huh?
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 09:54:49 PM
Quote from: calv on May 10, 2007, 09:03:16 PM
1.2.4 isnt avaliable from the mods? I always like the most up to date versions...

Uh, yea, it is.... I posted it myself this morning.
Title: Re: Calendar mods
Post by: calv on May 10, 2007, 10:32:59 PM
Quote from: Chris Curran on May 10, 2007, 09:54:49 PM
Quote from: calv on May 10, 2007, 09:03:16 PM
1.2.4 isnt avaliable from the mods? I always like the most up to date versions...

Uh, yea, it is.... I posted it myself this morning.

oh well, Ive been trying to get this going for quite a bit longer than that...
Havnt done anything with the settings.php just learning this smf system! Now that you point it out I'll just update the file like your script would :)

tks!
Title: Re: Calendar mods
Post by: calv on May 10, 2007, 10:46:26 PM
updates db_settings!
thanks, didnt seem to cause any probs though? just didnt give me the moons  8)
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 10:58:12 PM
calv,

Well, if you're new to SMF, the last thing you should be doing is by-passing the package manager. I thought I was going to be a smarty pants when I started fooling with SMF last year and use CVS instead. Forget it. Stick to the package manager and don't by-pass it.

Also, I ran across that thread you created today (smf_calendar table stucture 1.1.2) - man, you need to S L O W down! :) You've got 10 other mods installed you forgot to mention when you told us the calendar mod wouldn't install via the package manager....

cheers,
Chris
Title: Re: Calendar mods
Post by: calv on May 10, 2007, 11:04:43 PM
lol, I get impatient! thanks for your replies... US time difference and been playing for about a week... Got people waiting  :-X

Im sure the package manager is best in a perfect world!

cheers
Title: Re: Calendar mods
Post by: Chris Curran on May 10, 2007, 11:18:19 PM
Quote from: calv on May 10, 2007, 11:04:43 PM
Im sure the package manager is best in a perfect world!

:D Lets not get carried away now...
Title: Re: Calendar mods
Post by: Chris Curran on May 11, 2007, 01:05:16 AM
Quote from: Poreman on May 10, 2007, 09:00:07 PM
still need to see if anyone can figure out conflict from repeating events and Mod Users online today as stated in message #142

any php gurus out their that can figure this out
Appreciated
Poreman

v1.2.5 is posted.

1) When entering a new linked event, the post subject defaults to the event title.
2) Fixed the various error log issues.
Title: Re: Calendar mods
Post by: brelwit on May 11, 2007, 03:11:28 AM
Wow thanks for the new update! :)

I just made a quick test for version 1.2.4 and found the "CDATA..." snippet error does not appear anymore but also found out that there seems to be an error when posting an event that is "forced" to a specific topic.&nbsp; The related forum thread is not being created. I'll download the new version and test it further.
Title: Re: Calendar mods
Post by: Chris Curran on May 11, 2007, 07:23:22 AM
Quote from: brelwit on May 11, 2007, 03:11:28 AM
I just made a quick test for version 1.2.4 and found the "CDATA..." snippet error does not appear anymore but also found out that there seems to be an error when posting an event that is "forced" to a specific topic.&nbsp; The related forum thread is not being created. I'll download the new version and test it further.

That's a new one to me.... I doubt 1.2.5 fixes this. Let me try to dup and I'll get back.

Psst: I've been sick these past few weeks (pneumonia), so I'm not at 100% yet. I may need a day or two extra while I re-charge my batteries. The wife is already fussing at me about being up & around too much now....
Title: Re: Calendar mods
Post by: Chris Curran on May 11, 2007, 09:52:00 AM
Quote from: brelwit on May 11, 2007, 03:11:28 AM
also found out that there seems to be an error when posting an event that is "forced" to a specific topic.&nbsp; The related forum thread is not being created. I'll download the new version and test it further.

Yea, something odd is going on here....
Title: Re: Calendar mods
Post by: brelwit on May 11, 2007, 11:34:01 AM
It's ok Chris, I appreciate that you have made several updates to this mod already.  Just take it easy and get well soon.  :P

I may have some idea why the new error is happening.  It may be that when the related field "Post In" is disabled in the second screen, the value for that field was not passed on when you click the Post button... because the field is DISABLED. 

If we just make the visible "Post In" field as a dummy meaning rename the field to something different than "board" for display purposes only then create a new HIDDEN field that stores the real value and name that field "board", it might work.  I want to do this but I don't know how or where to start modifying the codes... so I can just suggest.
Title: Re: Calendar mods
Post by: Chris Curran on May 11, 2007, 01:24:58 PM
Yea, that's what it is. Since the 'board' field is disabled, $_REQUEST has no 'board' element and that freaks out a bunch of things. To verify, I added a onclick="setLinked(0)" to the Post button and it doesn't die now. Problem is that if you use the back button, the 'board' field is enabled and available for selection - not what we want....

I suppose fudging in a hidden field is the only option left. Kindred, what do you think?

cheers,
Chris
Title: Re: Calendar mods
Post by: Kindred on May 11, 2007, 01:30:36 PM
yeah, SMF actually uses hidden fields alot this way, so I think that is the way to do it...
Title: Re: Calendar mods
Post by: Chris Curran on May 11, 2007, 02:12:20 PM
v1.2.6 is posted.

1) Fixed bug with forced forums in events.

No more additions or fixes for a few days folks. Enjoy!
Title: Re: Calendar mods
Post by: brelwit on May 11, 2007, 10:53:20 PM
Alright it now works!  :D  With this, SMF should now be the best free/open-source bulletin board system if you are looking for a Repeating Calendar module.  This module is one of the reason that sets SMF apart and above from the others.  I hope this module or similar one will be included in the next version of SMF as well.

Thanks Chris!  :)
Title: Re: Calendar mods
Post by: Poreman on May 12, 2007, 12:02:02 AM
Chris
You have done a tremendous job the last couple of days, I was about to give up, I tried this one when it first come out hoping it would work for me.  Had a lot of bugs, but you seemed to have some powerful bug spray cause it is working as I hoped.  I have a event that I post every third Tuesday of the month I have been manually putting in if I remembered.  With this no more problems.
Again
Thanks
Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 12, 2007, 08:36:34 AM
Well, I wouldn't call two bugs (one old, one recent) "a lot", but thanks anyway. :D Bug spray? Debugging SMF is easy compared to hardware drivers for the Linux kernel (http://tinyurl.com/yv4pxv)!

<channel change>

Kindred,

1) Do you have any experience with the PM subsystem in SMF? Is it documented anywhere? I need to be able to PM attendees...

2) Once I add the attendee stuff, this mod will have outgrown it's name. What's the procedure? I'm certainly not going back through that gauntlet called 'mod approval'....

cheers,
me
Title: Re: Calendar mods
Post by: Chris Curran on May 12, 2007, 08:53:18 AM
Kindred,

There's a (so called) mod online for LDAP authentication (http://custom.simplemachines.org/mods/index.php?mod=213). It's not really a 'mod' in that there is no packaging (it's just a source file that you dump to your system - yuk). Do you know if anyone is doing anything with LDAP here (or possibly updating the previously mention 'mod')?

cheers,
me
Title: Re: Calendar mods
Post by: Chris Curran on May 12, 2007, 08:59:30 AM
Poreman,

Well, I'm obviously going to Hades! I click on the link above your "Please Visit' and I get a "Permission Denied"! :D :D :D
Title: Re: Calendar mods
Post by: Kindred on May 12, 2007, 05:04:48 PM
Chris,

The LDAP file change is the only one I know about that has been doing anything with LDAP. However, if I recall, the changes to the source were still being reviewed by the team, last time I looked.

As for the adding attendees...   give the enhanced mod to me, and I'll see what I can do about getting it released as an "enhancement" to an approved mod. Especially since you are doing the work  on the attendees which I slacked on with the PhatCalPack... :)

It'll need some testing on virgin systems (i.e. send it to me and one or two others to beta test for you) but you shouldn't have quite the delay of the original mod.

As for the PM system...
hmm.....   I have not done anything with it... but i know there are more hooks built into the source than in any previous version.
you can check out
http://support.simplemachines.org/function_db/index.php and skim down to personalmessage.php

specifically
http://support.simplemachines.org/function_db/index.php?action=view_function;function=655
looks like it may be useful....

Title: Re: Calendar mods
Post by: Chris Curran on May 13, 2007, 08:46:15 AM
Kindred,

Thanks. Slacked? Now you're being too hard on yourself. What I see is that you're pretty busy helping a lot of other folks on this board....

That LDAP file is being reviewed? It's pretty old - you sure? I need LDAP connectivity and was going to hack it soon, but if it's going to be a standard feature of 2.0 then I can wait.

Attendees... I was thinking more of a rename or new name or something. "Repeating Events" doesn't really encompass what this is morphing into here. Something clever and original like "Calendar Mods" perhaps?

PM's... Thx, but I think I'll ignore the printed doc and read the source. :D Grep is your friend....

cheers,
me
Title: Re: Calendar mods
Post by: SchaOn on May 14, 2007, 06:18:47 PM
Ok... I manually installed the MOD... and this is what I'm getting now... any ideas???

"Parse error: parse error, unexpected $end in ...\Sources\Calendar.php on line 1279"
Title: Re: Calendar mods
Post by: Chris Curran on May 14, 2007, 06:23:26 PM
What happened? A whole page of q&a is missing.. ????
Title: Re: Calendar mods
Post by: SchaOn on May 14, 2007, 06:25:37 PM
Before the $end error... I was getting this error:

"Parse error: parse error, unexpected T_FUNCTION, expecting '{' in ...\Sources\Calendar.php on line 385"

But then I did the { in front of "function calendarRepeatingEventArray($events, $low_date, $high_date," though, not sure where it closes???
Title: Re: Calendar mods
Post by: anroth on May 14, 2007, 06:26:20 PM
Kindred split the discussion into another topic: http://www.simplemachines.org/community/index.php?topic=171237.0

But on another note: Being desperate, I copied the modified files from the test board on that other server to my newly installed test board on the astronomy club server, and now I have the modifications installed, and they appear to be working. Maybe there's something weird with the server configuration, so I can't run the mod through the package manager, but at least I can install it manually. Hopefully, I can implement it into the astronomy club board without hassle...
Title: Re: Calendar mods
Post by: SchaOn on May 14, 2007, 06:33:55 PM
Hum... I'll try that also Anroth... thanks for the idea :)
Title: Re: Calendar mods
Post by: SchaOn on May 14, 2007, 06:40:27 PM
That didn't work :( Odd... is it possible for someone to just send me the mod'd files??? I'm hoping I only need the Source/Calendar.php file???
Title: Re: Calendar mods
Post by: anroth on May 14, 2007, 06:48:40 PM
There are three modified files in /Sources, another three in /Themes/default and two in /Themes/default/languages. I extracted them from a freshly installed SMF 1.1.2, so they should work fine if you have a fresh board installation as well. If you have other mods installed, you'd have to extract the changes manually, I guess...
Title: Re: Calendar mods
Post by: Chris Curran on May 14, 2007, 06:49:20 PM
Andreas,

10-4 on the split. Good luck on the board.....
Title: Re: Calendar mods
Post by: Chris Curran on May 14, 2007, 06:49:52 PM
Quote from: SchaOn on May 14, 2007, 06:40:27 PM
That didn't work :( Odd... is it possible for someone to just send me the mod'd files??? I'm hoping I only need the Source/Calendar.php file???

I tossed this together real quick (hope I didn't miss anything). Compare to this: http://www.planetcurran.com/smf/1.2.6_files.zip
Title: Re: Calendar mods
Post by: Poreman on May 14, 2007, 06:51:31 PM
Nearly hate to interupt yawl's discussion But I am getting an error only on guest

Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Line: 589
$this_event['can_edit'] = allowedTo('calendar_edit_any') || ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own'));

If you got time to look it over
Thanks
Poreman
Title: Re: Calendar mods
Post by: SchaOn on May 14, 2007, 07:00:22 PM
Thank you VERY MUCH Chris & Anroth...

I replaced the Calendar.php file... and BAM... it works!!!!!!!! :) :) :) :) :) :) <<<----- very happy... LOL.
Title: Re: Calendar mods
Post by: anroth on May 14, 2007, 07:46:46 PM
I'm happy as well - I transferred all changes to my files and even managed to do a translation. :)

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg508.imageshack.us%2Fimg508%2F7799%2Fsmfmoonphasespc1.th.gif&hash=e22daa1da650608e7f1da87a4f33b0548c11c6f4) (http://img508.imageshack.us/my.php?image=smfmoonphasespc1.gif)

Thanks a lot for your time, Chris, now we can plan our observing sessions and guest visits according to the moon phases finally, without the need of an external source. :)
Title: Re: Calendar mods
Post by: Chris Curran on May 14, 2007, 10:12:49 PM
Quote from: Poreman on May 14, 2007, 06:51:31 PM
Nearly hate to interupt yawl's discussion But I am getting an error only on guest

Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Line: 589
$this_event['can_edit'] = allowedTo('calendar_edit_any') || ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own'));

If you got time to look it over
Thanks
Poreman

This appears to be bug in the original code. That'll take longer to track down...
Title: Re: Calendar mods
Post by: Chris Curran on May 15, 2007, 08:12:25 AM
Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Yep - this is a bug that exists in the 1.1.2 codeset (probably prior versions too - I didn't check). Is there a procedure here at SMF, or do I just fix it (I already have the fix)? I don't want to step on any toes....

cheers,
me
Title: Re: Calendar mods
Post by: Kindred on May 15, 2007, 10:08:37 AM
you can make a post in the bugs board along with your recommended fix. :)
Title: Re: Calendar mods
Post by: anroth on May 15, 2007, 10:17:03 AM
Sorry to bother you again, but I ran into a small issue. At first, I thought it was because I missed something when copying your code, but I tried it on the board where the installation went successfully, and I had the same problem. So here it goes:

I use the calendar with "Show days as links to 'Post Event'" enabled, and I created a separate board for calendar events, because I usually provide some additional information that wouldn't fit in the calendar overview. "Default board to post events in:" is set to the calendar board. After installing your mod, the calendar board isn't selected anymore when posting new events, but the first board in the board overview (the one at the top). I can still select any other board, but it's rather annoying to do so.

I assume that's why you added the "Force default board in events:" option, which disables the drop down box in the "post event" dialogue, but it's not the calendar board that is selected, but still the first board in the overview. I thought "fine, so let's move the calendar board to the top", and now it was selected as desired. But to my surprise, I wasn't able to edit events anymore, the board told me that they were off-limit to me (being admin with all permissions!). The only way to get rid of them was deleting them manually from the database with phpMyAdmin.

For now, I leave my calendar board at the top, so it gets selected automatically in the drop-down box, and disable the "Force default board in events:" option. Does anybody else have the same issue? As I said, it happens with the board where the mod got properly installed, and it's the same with the board that I modded manually. Or is it related to the bug posted above? As usual, it's all gibberish for me again. ;)
Title: Re: Calendar mods
Post by: Poreman on May 15, 2007, 11:07:01 AM
I seem to have the same problem, I have the "Default board to post events in" set to "Informational - Events" which I had created for the Events, I checked the "Force default board in events" If the Forced default is checked it doesn't go to the selected default, in my case it was "   ID_BOARD = 0" which is a non=existant board it should have read if it had put the event to the chosen board "   ID_BOARD = 24" the id of the events board.  This is why you got the error it was trying to access something that wasn't there.  I unchecked the "forced default", which lets you manually select where you want the event posted, that will work for me until a solution is posted.  It seems to be a problem assigning the event to the chosen board for the event in default mode.

Thanks
Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 15, 2007, 11:32:21 AM
Andreas & Poreman,

I can't reproduce your reports. I tried it with different boards in both IE and Firefox. Everything appears and operates as expected. All db files are in expected state (no 0's in board column). Dunno what to tell you to try next...
Title: Re: Calendar mods
Post by: Kindred on May 15, 2007, 11:34:32 AM
I will install v.1.2.4 tomorrow and test on my site...
Title: Re: Calendar mods
Post by: johnburkett on May 15, 2007, 11:49:53 AM
Hi Guys

Hope I am in the right place for help on Chris's Repeating Events Mod.

I have a virtually brand new install of SMF 1.1.2.&nbsp; Have installed the Repeating events mod (1.2.6) via the package manager.&nbsp; The problem is that no labels are displaying for any of the new fields added to either the Add Event page or Calendar Admin page.&nbsp; Also on the Add Event page nothing is coming up in the drop down lists for setting up recurrences, although the boxes are there.

Clearly something is not right.&nbsp; I have uninstalled and reinstalled the mod but with same result.&nbsp; Any pointers or fixes very much appreciated!

Thanks
John B
Title: Re: Calendar mods
Post by: Kindred on May 15, 2007, 11:51:01 AM
1- uninstalling and reinstalling will not do anythign different.  Computers don't learn by repetition...

2- Are you using a UTF-8 language?
Title: Re: Calendar mods
Post by: johnburkett on May 15, 2007, 11:54:40 AM
Thanks Kindred

1 - True, but sometimes I do! (mega newbie at this stuff).

2- Yes

John
Title: Re: Calendar mods
Post by: Chris Curran on May 15, 2007, 11:56:41 AM
Quote from: johnburkett on May 15, 2007, 11:54:40 AM
2- Yes

English? If yes, then PM me the page source.....
Title: Re: Calendar mods
Post by: Kindred on May 15, 2007, 12:02:01 PM
UTF...   that's the problem.

The mod (and most mods, actually) only installs strings in the *.english.php files...
Title: Re: Calendar mods
Post by: johnburkett on May 15, 2007, 12:14:00 PM
Default Forum Language is set to 'English-utf8'

Is there another setting I should try?

I have sent Chris the page code.

John B.
Title: Re: Calendar mods
Post by: Chris Curran on May 15, 2007, 01:31:08 PM
Q: Should the attendee logic apply to repeating events with no end date?

In my use of repeating events, these types of events aren't the kind that requires management of attendees (club meetings, board meetings, etc). Allowing folks to 'attend' a never-ending event sounds like a problem waiting to happen. Non-repeating and repeating events with an end date seem like the only event types that should allow attendee management... Yes, no?

cheers,
me
Title: Re: Calendar mods
Post by: Kindred on May 15, 2007, 01:35:25 PM
That brings up an interesting point...   

What happens if you choose to attend a meeting that is recurring?

I asusme, the current design adds you as an attendee for all recurrences.
What if you only plan to attend ONE of the meetings?

Is that possible, or is the logic to handle that just not even present in the SMF event code?
Title: Re: Calendar mods
Post by: johnburkett on May 15, 2007, 01:49:09 PM
Kindred/Chris

Enlightenment has dawned!  Changed the setting to 'English' and all is well.

I will now disappear back into my novice user corner!

Many thanks
Regards
JohnB
Title: Re: Calendar mods
Post by: Chris Curran on May 15, 2007, 01:51:19 PM
Kindred,

Good point. That level of granularity isn't present at this time. Maybe later... It would only work for recurring events w/ end dates... The general strategy might be to determine date range, populate a combox box with those dates, allow user to select one or more, save those selections for later reaction... I think.
Title: Re: Calendar mods
Post by: Chris Curran on May 15, 2007, 01:54:44 PM
Quote from: johnburkett on May 15, 2007, 01:49:09 PM
I will now disappear back into my novice user corner!

We are all fools, only in different ways....

   -- Will Rogers

Title: Re: Calendar mods
Post by: citron on May 15, 2007, 01:58:17 PM
Quote from: Chris Curran on May 15, 2007, 11:32:21 AM
Andreas & Poreman,

I can't reproduce your reports. I tried it with different boards in both IE and Firefox. Everything appears and operates as expected. All db files are in expected state (no 0's in board column). Dunno what to tell you to try next...

I can't reproduce their issues either.  The "Force default board in events:" is using the board I have selected in "Default board to post events in:".
Title: Re: Calendar mods
Post by: Poreman on May 15, 2007, 06:13:36 PM
Quote from: Chris Curran on May 15, 2007, 11:32:21 AM
Andreas & Poreman,

I can't reproduce your reports. I tried it with different boards in both IE and Firefox. Everything appears and operates as expected. All db files are in expected state (no 0's in board column). Dunno what to tell you to try next...

Here is some data I got from errors log maybe this will help


8: Undefined index: board
File: /home/mysite/public_html/forums/Sources/Post.php
Line: 304
$context['event']['board'] = $_REQUEST['board'];




8: Undefined index: repeating
File: /home/mysite/public_html/forums/Sources/Post.php
Line: 305
$context['event']['repeating']     =  $_REQUEST['repeating'];




Apply Filter: Only show the errors with the same message
8: Undefined index: repeat1_parm1
File: /home/mysite/public_html/forums/Sources/Post.php
Line: 306
$context['event']['repeat1_parm1'] =  $_REQUEST['repeat1_parm1'];




Seems like it follows this pattern through all this section of code.

Code (from sources/post.php) Select

$context['event']['board'] = $_REQUEST['board'];
$context['event']['repeating']     =  $_REQUEST['repeating'];
$context['event']['repeat1_parm1'] =  $_REQUEST['repeat1_parm1'];
$context['event']['repeat1_parm2'] =  $_REQUEST['repeat1_parm2'];
$context['event']['repeat2_parm1'] =  $_REQUEST['repeat2_parm1'];
$context['event']['repeat2_parm2'] =  $_REQUEST['repeat2_parm2'];
$context['event']['repeat2_parm3'] =  $_REQUEST['repeat2_parm3'];
$context['event']['repeat_end_type']= $_REQUEST['repeat_end_type'];
$context['event']['repeat_end_month']=$_REQUEST['repeat_end_month'];
$context['event']['repeat_end_day'] = $_REQUEST['repeat_end_day'];
$context['event']['repeat_end_year']= $_REQUEST['repeat_end_year'];


Maybe this will help corral the error!

Thanks
Poreman

Title: Re: Calendar mods
Post by: Poreman on May 15, 2007, 07:03:47 PM
Quote from: Chris Curran on May 15, 2007, 08:12:25 AM
Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Yep - this is a bug that exists in the 1.1.2 codeset (probably prior versions too - I didn't check). Is there a procedure here at SMF, or do I just fix it (I already have the fix)? I don't want to step on any toes....

cheers,
me

Can you share the fix? Maybe it will straighten up some of the other problems.

Thanks
Poreman
Title: Re: Calendar mods
Post by: brelwit on May 16, 2007, 05:13:31 AM
Quote from: Chris Curran on May 15, 2007, 01:31:08 PM
Q: Should the attendee logic apply to repeating events with no end date?

In my use of repeating events, these types of events aren't the kind that requires management of attendees (club meetings, board meetings, etc). Allowing folks to 'attend' a never-ending event sounds like a problem waiting to happen. Non-repeating and repeating events with an end date seem like the only event types that should allow attendee management... Yes, no?

cheers,
me

Good point.  Basically, I feel there should be one unique Attendee List per Day if its possible.  So irregardless whether an Event is repeating or not, it can contain an Attendee List per day.

Here is how I think it may work although I'm not sure if this is possible with SMF:

[01] The Owner of the Event can check a box to enable the Attendee List when creating an Event.  This is just a simple flag with a value of 0 (disabled) or 1 (enabled).

[02] After the Event (repeating or not) has been created and the user clicks on a related date link on the Calendar for more details, the user is either redirected to the linked Forum Topic page (if enabled) OR to the related Attendee List page (if enabled).  If user was redirected to the Forum Topic, there should be a link/button there to access the related Attendee List page and vice-versa.  If the Forum Topic was not enabled, the user is immediately redirected to the related Attendee List page for that date.  If both Forum Topic and Attendee List page is enabled, user is first redirected to the linked Forum Topic as default.  The logged-in user can only register once to be included as Attendee per date.  He should also be able to un-register as attendee per date anytime he wants.

[03]  The database record for the Attendee List per date is created ONLY upon the first registration of an Attendee PER DAY.  So maybe the code checks if the user is the first to register as an attendant for that day and thereafter creates the necessary matching attendee record.

[04] The Owner of the Event may of course still normally click the edit link (*) per day to manage the Event details and corresponding Attendee List (if enabled).

NOTE:  This may just work as the Attendee List is created only upon the registration of the first Attendee per date.
Title: Re: Calendar mods
Post by: Kindred on May 16, 2007, 07:48:40 AM
Brelwit...

we just discussed that...   SMF's logic/design does not currently support it.

(also, side note, irregardless is not a word, the word is regardless)
Title: Re: Calendar mods
Post by: Chris Curran on May 16, 2007, 08:31:49 AM
Poreman,

Here is some data I got from errors log maybe this will help

No, not really. Your situation appears to be unique. Do you have other mods installed? From your post I'm guessing that $_REQUEST is being destroyed somehow. What sequence of events leads to these error log entries?

Can you share the fix? Maybe it will straighten up some of the other problems.

The fix is below, BUT, it will have no effect on your issues (the cause of those entries is rather minor). Note that you should save a copy of BoardIndex.php before you change anything - if you don't you won't be able to install the next release of this codeset...

In BoardIndex.php: replace this


$this_event['can_edit'] = allowedTo('calendar_edit_any') || ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own'));


with this:


$this_event['can_edit'] = allowedTo('calendar_edit_any') || (isset($this_event['poster']) && ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own')));


cheers,
me
Title: Re: Calendar mods
Post by: Chris Curran on May 16, 2007, 08:36:08 AM
belwit,

To expand on the exchange Kindred and I were having prior to your post.... The calendar events are not stored in the db on a 'per day' basis. Only the event definition is saved to the db, and all day entries on a calendar are generated 'on the fly'. Take a look at the data in your calendar table with some kind of mysql tool and you'll see what I mean....

cheers,
me
Title: Re: Calendar mods
Post by: Chris Curran on May 16, 2007, 08:37:52 AM
(also, side note, irregardless is not a word, the word is regardless)

Ha! Another Strunk & White aficionado! :D
Title: Re: Calendar mods
Post by: Chris Curran on May 16, 2007, 08:42:26 AM
OK folks, it's that time of the month again. No, not that - New Moon. :) I'll be leaving town tomorrow until at least next Sunday - maybe Monday depending on how the skies are. I'll be in/out today running errands, but I don't expect to get anything else done until early next week....

cheers,
me

EDIT: check out today's APOD: http://antwrp.gsfc.nasa.gov/apod/ap070516.html
Title: Re: Calendar mods
Post by: brelwit on May 16, 2007, 09:19:32 AM
Quote from: Kindred on May 16, 2007, 07:48:40 AM
Brelwit...

we just discussed that...&nbsp;&nbsp; SMF's logic/design does not currently support it.

(also, side note, irregardless is not a word, the word is regardless)

Aha! You thought you got me there eh? hehehe :D There is such a word. Checkout: http://webster.com/dictionary/irregardless

I'm not sure what you meant about SMF's logic/design not supporting it etc. But now I do since Chris explained it clearer.  I'm now happy how the current Calendar works though.   If anybody needs the Attendee List badly, you may just post it in the linked Forum Topic as a workaround.  :P
Title: Re: Calendar mods
Post by: Chris Curran on May 16, 2007, 09:24:29 AM
Quote from: brelwit on May 16, 2007, 09:19:32 AM
Aha! You thought you got me there eh?   hehehe  :D  There is such a word.  Checkout: http://webster.com/dictionary/irregardless

And here is the correct definition: http://dictionary.reference.com/search?q=irregardless

However, the authoritative source is Strunk & White. Page 50 of the third edition... :D
Title: Re: Calendar mods
Post by: brelwit on May 16, 2007, 09:34:22 AM
Quote from: Chris Curran on May 16, 2007, 09:24:29 AM
Quote from: brelwit on May 16, 2007, 09:19:32 AM
Aha! You thought you got me there eh?&nbsp; &nbsp;hehehe&nbsp; :D&nbsp; There is such a word.&nbsp; Checkout: http://webster.com/dictionary/irregardless

And here is the correct definition: http://dictionary.reference.com/search?q=irregardless

However, the authoritative source is Strunk & White. Page 50 of the third edition... :D

Alright, I love this board.  I learn so many things hehe :P


Quote from: Chris Curran on May 16, 2007, 08:36:08 AM
belwit,

To expand on the exchange Kindred and I were having prior to your post.... The calendar events are not stored in the db on a 'per day' basis. Only the event definition is saved to the db, and all day entries on a calendar are generated 'on the fly'. Take a look at the data in your calendar table with some kind of mysql tool and you'll see what I mean....

cheers,
me


Yaiks! I see. Thanks for the explanation. :D But is it possible to pass the value for the complete Current Date clicked and Event ID in the href of the clickable day in the Calendar in real-time? If it is, the Attendee List feature may be possible but a new table may be needed for this I guess. hmm... Just a wild thought.
Title: Re: Calendar mods
Post by: Kindred on May 16, 2007, 01:11:29 PM
yes, if Chris were to go the route of allowing an attendee for one session of a recurring event, this would require a new table that would associate:

UniqueID | EventID | Date of Event | Attendee/organizer user ID | attendee/organizer flag

this list could then be assembled on the fly each time the attendee list for a specific event is viewed.
Title: Re: Calendar mods
Post by: Poreman on May 17, 2007, 02:11:38 PM
Something is definitly interefering with the repeating event.
The Mods I am running is

Bible Tag
Users Online Today
Global Announcements
Trim Url
Streaming 3
Contact Page

uninstalled repeating events, will wait to see what kind of updates and what problems if any someone else comes up with.  Very good program, just won't work with what I have.
Thanks
Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 21, 2007, 11:05:33 PM
Poreman,

I agree with you - one of the mods you have installed is interfering with my calendar mod. Note that while there are no planed updates to this mod, if you determine which mod and how it's interfering, I may be able to help.

cheers,
me
Title: Repeat Events manual install and resize
Post by: WindWraith on May 24, 2007, 01:58:10 PM
Hello

I have the dreaded Modification Parse Error.

Where can I locate instructions to apply this great mod manually?

Also how do I make the xml file into smaller ones for  php 5.2 size bug?

Thank you
David
Title: Re: Calendar mods
Post by: Chris Curran on May 24, 2007, 05:19:19 PM
Quote from: WindWraith on May 24, 2007, 01:58:10 PM
I have the dreaded Modification Parse Error.

Where can I locate instructions to apply this great mod manually?

There are no manual install instructions. Report the error here:
http://www.simplemachines.org/community/index.php?topic=171237

Quote
Also how do I make the xml file into smaller ones for  php 5.2 size bug?

Upgrade to 5.2.2? What bug are you referring to?

cheers,
me
Title: Re: Calendar mods
Post by: WindWraith on May 24, 2007, 05:29:31 PM
I read there is a problem with xml files larger than 28.?kb but I cant for the life of me relocate the post detailing how to split up a xml file to try and install it that way.
Title: Re: Calendar mods
Post by: Chris Curran on May 25, 2007, 08:45:20 AM
Kindred,

Regarding this "Modification Parse Error" problem... Is there something users can do to help the staff debug this issue? Does test_modification.php exhibit the same problems? Is there a debug mode for the PM? Anything besides an idiot light indicator?

tia,
me
Title: Re: Calendar mods
Post by: WindWraith on May 25, 2007, 11:00:55 AM
Sorry to have bothered you when my "idiot light" went off. Some of us don't know how to program.
Title: Re: Calendar mods
Post by: Chris Curran on May 25, 2007, 09:41:28 PM
Quote from: WindWraith on May 25, 2007, 11:00:55 AM
Sorry to have bothered you when my "idiot light" went off. Some of us don't know how to program.

Calm down and have a beer. An "idiot light" is an old automotive term meaning a warning light that tells you nothing. Google it or read this for more:

http://en.wikipedia.org/wiki/Idiot_light
Title: Re: Calendar mods
Post by: Kindred on May 26, 2007, 08:06:45 AM
Windwraith:
you can try this...
http://www.simplemachines.org/community/index.php?topic=167318.msg1105313#msg1105313


Chris, we'd love any help on this.  We can't quite figure out why it works on some systems and not on others (it works on nearly every (if not every) team member's site)
Title: Re: Calendar mods
Post by: Chris Curran on May 26, 2007, 09:43:20 AM
Quote from: Kindred on May 26, 2007, 08:06:45 AM
you can try this...
http://www.simplemachines.org/community/index.php?topic=167318.msg1105313#msg1105313

Old UNIX hack goes screaming into the forest... NO!!!!!! Don't EVER use permissions of 777 to install ANYTHING! If you need that permissions config to install, then you have some other problem (usually ownership) that needs to be found/fixed first. What user/group is the HTTP server running under in these problem systems (in the apache config)? If Apache can't create a 'temp' dir in 'packages', check the ownership and perms of 'packages' and it's parents (to match the user/group that apache is running under). Also, what are the <Directory> settings in apache config for these problem installs? Lastly, is PHP being run in 'safe_mode' on these problem systems?

The problem with telling inexperienced users to use 777 perms is that you really, really need to know what you're doing to run a system with perms of 777. It's akin to telling a newb to install everything as 'root'.... bad idea. Real bad idea.


QuoteChris, we'd love any help on this.

Can the PM help us out by providing something more than "Modification Parse Error"? Like maybe what the error is? With the PM operating in "idiot light" mode, there's really nothing anyone can do on this end.

cheers,
me
Title: Re: Calendar mods
Post by: Kindred on May 26, 2007, 06:23:11 PM
this is getting off topic from the calendar mod...   but usually the requirement to use chmod 777 is due to the HOST's configuration, running php as "nobody" rather than running php in CGI mode and/or as the site owner.


typically chmod 777 is not really that big a security risk. I had a site running with every file and directory set to 777 for 4 years with no problems.
Title: Re: Calendar mods
Post by: Chris Curran on May 27, 2007, 08:07:42 AM
I drove a vehicle for 20+ years before I started wearing a seat belt. Nothing ever happened - I guess seat belts are really required? :D Proper security is a process, not an item. Blindly setting perms to 777 is considered bad practice by all unix security experts, for the past 40+ years. It may not burn you today, next year or four years from now, but, it could burn down everything you care about in an instant. Why run that risk when there are safer ways to do the same thing?

At any rate, we could all be chasing our tails here, not knowing exactly what the error is. If only the package manager had a debug mode.....

cheers,
me

BTW: The results of last weekend: www.planetcurran.com/displayImg.php?img=ngc5139
Title: Re: Calendar mods
Post by: Chris Curran on May 29, 2007, 08:22:29 AM
Here is the base I'm working from for the new package. I created this for a number of reasons, but one is so that I can test out features of the PM I'd not used before (e.g. adding new files).

http://www.planetcurran.com/smf/essentialCalendarMods_0_1.zip

The version number of 0.1 reflects the beta status of this package (I consider anything < 1.0 to be a beta version number). Remove any previous install of "Repeating Events" and install as normal. Please let me know if I missed something obvious.

cheers,
me
Title: Re: Calendar mods
Post by: Poreman on May 29, 2007, 01:35:50 PM
Does anyone have any Idea what is going on and what to do to correct so I don't fill up my error log?

SMF -> Version 1.1.2
Mod -> essentialCalendarMods_0_1.zip
PHP -> Version 5.1.6
MySQL -> Client API version 5.0.27

I did a test install with smf 1.1.2 clean install as packaged.  Loaded only the essentialCalendarMods_0_1.zip mod.  First mod no other mods loaded and still got an abundance of errors in error log.
Code (admin forum error log) Select
http://mysite/testsmf/index.php?action=calendar;sa=post;month=5;year=2007;day=16;sesc

8: Undefined index: repeat_end_year
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 314

8: Undefined index: repeat_end_day
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 313

8: Undefined index: repeat_end_month
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 312

8: Undefined index: repeat_end_type
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 311

8: Undefined index: repeat2_parm3
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 310

8: Undefined index: repeat2_parm2
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 309

8: Undefined index: repeat2_parm1
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 308

8: Undefined index: repeat1_parm2
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 307

8: Undefined index: repeat1_parm1
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 306

8: Undefined index: repeating
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 305

8: Undefined index: board
File: /home/mysite/public_html/testsmf/Sources/Post.php
Line: 304


Code (source/post.php edited via package manager) Select
Line - 304 - $context['event']['board'] = $_REQUEST['board'];
Line - 305 - $context['event']['repeating']     =  $_REQUEST['repeating'];
Line - 306 - $context['event']['repeat1_parm1'] =  $_REQUEST['repeat1_parm1'];
Line - 307 - $context['event']['repeat1_parm2'] =  $_REQUEST['repeat1_parm2'];
Line - 308 - $context['event']['repeat2_parm1'] =  $_REQUEST['repeat2_parm1'];
Line - 309 - $context['event']['repeat2_parm2'] =  $_REQUEST['repeat2_parm2'];
Line - 310 - $context['event']['repeat2_parm3'] =  $_REQUEST['repeat2_parm3'];
Line - 311 - $context['event']['repeat_end_type']= $_REQUEST['repeat_end_type'];
Line - 312 - $context['event']['repeat_end_month']=$_REQUEST['repeat_end_month'];
Line - 313 - $context['event']['repeat_end_day'] = $_REQUEST['repeat_end_day'];
Line - 314 - $context['event']['repeat_end_year']= $_REQUEST['repeat_end_year'];


Any Ideas or help appreciated
Regards
Poreman
Title: Re: Calendar mods
Post by: Kindred on May 29, 2007, 03:01:56 PM
you realize that the mod you downloaded is a true beta?

On the other hand, the code that you are referencing is part of the older mod and those variable indexes should be defined...
Title: Re: Calendar mods
Post by: Poreman on May 29, 2007, 04:13:40 PM
OK I'll uninstall that one and install repeatEvents_1_2_6.zip.  And I will reiterate That this is a completely clean upload all code came from the essentialCalendarMods_0_1.zip mod.  I created a testsmf directory, uploaded a downloaded today smf 1.1.2.zipinstalled with a newly created a testsmf sql database logged into admin installed the essentialCalendarMods_0_1.zip mod only, nothing else and got the errors, so the code had to come from the mod I installed.  Old code or not?

QuoteOn the other hand, the code that you are referencing is part of the older mod and those variable indexes should be defined...

will let you know how it turns out.
Poreman
Title: Re: Calendar mods
Post by: cferd on May 29, 2007, 04:16:35 PM
I think there's an xml file missing from the package. I'm about to download and try it out. I need annual events on my site and this might just do the trick....if it works &nbsp;;)

Edit: nevermind about the missing file. I was comparing to the repeatevents mod and missed the second one, but it's there.
Title: Re: Calendar mods
Post by: Poreman on May 29, 2007, 04:37:32 PM
OK, uninstalled the essentialCalendarMods_0_1.zip mod. using package manager, results shows successful, installed repeatEvents_1_2_6.zip Via package manager, installed shows successful through entire process.  Went to calendar events post via calendar by clicking on date for event.  went to admin error log.  Log shows exactly the same errors as I listed above per-bata so something is amiss I'm not a php programmer, but I can tell that somewhere something is wrong, I just don't know what.
Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 29, 2007, 05:51:10 PM
Poreman,

What theme are you using? If you're not using the default theme, I think it might cause these errors...
Title: Re: Calendar mods
Post by: Poreman on May 29, 2007, 05:59:47 PM
Quote from: Chris Curran on May 29, 2007, 05:51:10 PM
Poreman,

What theme are you using? If you're not using the default theme, I think it might cause these errors...

I'm using default, I haven't changed any settings at all left everything default from existing install,  Only thing I did was turn on calendar as it is default off.  I am using the smf 1.1.2 right out of the box nothing changed from the default settings.
Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 29, 2007, 06:08:50 PM
Dave,

OK, re-install the essential mod, zip up the files changed by the mod and send them to curran dot chris at gmail dot com. Let me see if there's a difference....

cheers,
me
Title: Re: Calendar mods
Post by: cferd on May 29, 2007, 06:17:26 PM
I'm getting those same errors using the default 1.1.2 theme.

I also had to manually modify the calendar.php file and remove it from essentialCalendarMods_0.1.xml before installing. No biggie.

Tested the annual events and it seems to be what I wanted. So far, so good.
Title: Re: Calendar mods
Post by: cferd on May 29, 2007, 06:27:33 PM
One other thing. It's not respecting the "Default board to post events in" selected in Calendar settings. It seems to be picking the first board on the forum as default.
Title: Re: Calendar mods
Post by: Poreman on May 29, 2007, 06:57:02 PM
Quote from: cferd on May 29, 2007, 06:27:33 PM
One other thing. It's not respecting the "Default board to post events in" selected in Calendar settings. It seems to be picking the first board on the forum as default.

This is an old issue I couldn't get solved either.
Poreman
Title: Re: Calendar mods
Post by: Chris Curran on May 29, 2007, 06:58:15 PM
Quote from: cferd on May 29, 2007, 06:27:33 PM
One other thing. It's not respecting the "Default board to post events in" selected in Calendar settings. It seems to be picking the first board on the forum as default.

cferd,

Someone else reported this before, but I and others were never able to dup the issue. Are you comfortable putting a few lines of debug code into a few of your source files?
Title: Re: Calendar mods
Post by: Poreman on May 29, 2007, 07:08:15 PM
I Am, I would like to see what's up
Poreman
Title: Re: Calendar mods
Post by: cferd on May 29, 2007, 07:14:18 PM
I managed to get it working correctly by commenting out line 286 in Post.php and uncommenting line 346.
$context['event']['board'] = !empty($board) ? $board : $modSettings['cal_defaultboard'];
Title: Re: Calendar mods
Post by: cferd on May 30, 2007, 06:02:15 PM
Ok. I was able to get rid of all errors on my site by modifying the Post.php file. So far it's all working as it should except I have an event module in Joomla, which SMF is bridged to, and new events don't show up there immediately. I'll have to check on that.

In the mean time, please let me know if this may cause me issues in the future. Thanks.

I changed from this code:
if (!isset($_REQUEST['year']))
$_REQUEST['year'] = $today['year'];

$context['event']['month'] = (int) $_REQUEST['month'];
$context['event']['year'] = (int) $_REQUEST['year'];
$context['event']['day'] = isset($_REQUEST['day']) ? $_REQUEST['day'] : ($_REQUEST['month'] == $today['mon'] ? $today['mday'] : 0);
//$context['event']['span'] = isset($_REQUEST['span']) ? $_REQUEST['span'] : 1;
$context['event']['board'] = $_REQUEST['board'];
$context['event']['repeating']     =  $_REQUEST['repeating'];
$context['event']['repeat1_parm1'] =  $_REQUEST['repeat1_parm1'];
$context['event']['repeat1_parm2'] =  $_REQUEST['repeat1_parm2'];
$context['event']['repeat2_parm1'] =  $_REQUEST['repeat2_parm1'];
$context['event']['repeat2_parm2'] =  $_REQUEST['repeat2_parm2'];
$context['event']['repeat2_parm3'] =  $_REQUEST['repeat2_parm3'];
$context['event']['repeat_end_type']= $_REQUEST['repeat_end_type'];
$context['event']['repeat_end_month']=$_REQUEST['repeat_end_month'];
$context['event']['repeat_end_day'] = $_REQUEST['repeat_end_day'];
$context['event']['repeat_end_year']= $_REQUEST['repeat_end_year'];

To this:
if (!isset($_REQUEST['year']))
$_REQUEST['year'] = $today['year'];

$context['event']['month'] = (int) $_REQUEST['month'];
$context['event']['year'] = (int) $_REQUEST['year'];
$context['event']['day'] = isset($_REQUEST['day']) ? $_REQUEST['day'] : ($_REQUEST['month'] == $today['mon'] ? $today['mday'] : 0);
//$context['event']['span'] = isset($_REQUEST['span']) ? $_REQUEST['span'] : 1;
$context['event']['board'] = isset($_REQUEST['board']) ? $_REQUEST['board'] : 0;
$context['event']['repeating'] = isset($_REQUEST['repeating']) ? $_REQUEST['repeating'] : 0;
$context['event']['repeat1_parm1'] = isset($_REQUEST['repeat1_parm1']) ? $_REQUEST['repeat1_parm1'] : 0;
$context['event']['repeat1_parm2'] = isset($_REQUEST['repeat1_parm2']) ? $_REQUEST['repeat1_parm2'] : 0;
$context['event']['repeat2_parm1'] = isset($_REQUEST['repeat2_parm1']) ? $_REQUEST['repeat2_parm1'] : 0;
$context['event']['repeat2_parm2'] = isset($_REQUEST['repeat2_parm2']) ? $_REQUEST['repeat2_parm2'] : 0;
$context['event']['repeat2_parm3'] = isset($_REQUEST['repeat2_parm3']) ? $_REQUEST['repeat2_parm3'] : 0;
$context['event']['repeat_end_type'] = isset($_REQUEST['repeat_end_type']) ? $_REQUEST['repeat_end_type'] : 0;
$context['event']['repeat_end_month'] = isset($_REQUEST['repeat_end_month']) ? $_REQUEST['repeat_end_month'] : 0;
$context['event']['repeat_end_day'] = isset($_REQUEST['repeat_end_day']) ? $_REQUEST['repeat_end_day'] : 0;
$context['event']['repeat_end_year'] = isset($_REQUEST['repeat_end_year']) ? $_REQUEST['repeat_end_year'] : 0;
Title: Re: Calendar mods
Post by: Chris Curran on May 31, 2007, 07:36:31 AM
This will stop the error messages in the log, but, it is an improper fix and will introduce a bug. The problem you (and Dave) seem to have is that $_REQUEST does not contain the expected data. Load up Post.php and search for '$context['event']['board']' to see what I mean....

Quote from: cferd on May 29, 2007, 07:14:18 PM
I managed to get it working correctly by commenting out line 286 in Post.php and uncommenting line 346.
$context['event']['board'] = !empty($board) ? $board : $modSettings['cal_defaultboard'];
Title: Re: Calendar mods
Post by: Chris Curran on May 31, 2007, 07:40:21 AM
Quote from: cferd on May 30, 2007, 06:02:15 PM
In the mean time, please let me know if this may cause me issues in the future. Thanks.

It will cause issues. :). All you're doing here is keeping the error out of the log - it does not fix the root cause, which is missing data from $_REQUEST. If you're up to playing, grab this: http://reallyshiny.com/scripts/php-dump.txt and dump the contents of $_REQUEST to the screen - lets see what's really in there....

cheers,
me
Title: Re: Calendar mods
Post by: Poreman on May 31, 2007, 01:43:53 PM
Quote from: Chris Curran on May 31, 2007, 07:40:21 AM
If you're up to playing, grab this: http://reallyshiny.com/scripts/php-dump.txt and dump the contents of $_REQUEST to the screen - lets see what's really in there....

cheers,
me


Just how do you use this?
Tried making a php file put in root ran came up with blank screen evidently this isn't how it is used, can you enlighten me a little on how to utilize the dump?
Thanks
Dave
Title: Re: Calendar mods
Post by: Chris Curran on May 31, 2007, 02:24:12 PM
You have to edit the source. I'll assume that the linked file is saved as 'phpDump.php' and it's in the same directory as 'Post.php'. Right after:


if (!isset($_REQUEST['year']))
    $_REQUEST['year'] = $today['year'];


in Post.php (about line 298) add the following:


require_once("phpDump.php");
dump($_REQUEST);
Title: Re: Calendar mods
Post by: cferd on May 31, 2007, 04:10:47 PM
Quote from: Chris Curran on May 31, 2007, 07:40:21 AM
If you're up to playing, grab this: http://reallyshiny.com/scripts/php-dump.txt and dump the contents of $_REQUEST to the screen - lets see what's really in there....
Ok. Here's what I get:
QuoteArray : Dimension 1
action calendar
sa post
month 5
year 2007
day 9
sesc a2f5a8639d7bb941201aabd525fe9cfc
start 0
calendar 1
Title: Re: Calendar mods
Post by: Poreman on May 31, 2007, 07:01:24 PM
I get basicly the same as cferd
Quote
action   calendar
sa   post
month   5
year   2007
sesc   3dc8dfeed9a4474de641642290b93dcc
start   0
calendar   1

I don't know if it makes a differance but to find out what values the variables had before input I clicked on post without input of course it came back telling me what I needed to fill in but below is what I ended up with.
Quote
evtitle   Empty String
calendar   1
month   5
day   31
year   2007
board   1
repeating   Empty String
repeat1_parm1   Empty String
repeat1_parm2   Empty String
repeat2_parm1   Empty String
repeat2_parm2   Empty String
repeat2_parm3   Empty String
repeat_end_type   Empty String
repeat_end_month   5
repeat_end_day   31
repeat_end_year   2007
subject   Empty String
icon   xx
message   Empty String
notify   Empty String
lock   Empty String
sticky   Empty String
move   Empty String
post   Post
additional_options   Empty String
sc   3dc8dfeed9a4474de641642290b93dcc
seqnum   7065051
action   post2
start   0
preview   True

Thanks
Dave
Title: Re: Calendar mods
Post by: Chris Curran on June 01, 2007, 07:45:58 AM
cferd & Dave,

Those $_REQUEST dumps are abnormal. The ones you guys posted is what $_REQUEST should look like *before* clicking on the 'Post' button. In this case, $_REQUEST is loaded in the function 'template_event_post()' in Calendar.template.php (about line 244 - look for the '<form' statement). It gets handed off a number of times before it reaches Post.php - I can't tell if it's not being set, or if it's being destroyed along the way.

Lets also take the time to be sure that we're all starting from the same point, and progressing along the same path. I'm testing the reports as follows:

1) Go to calendar and click on a day number. I'm using June 8 in this example.
2) I give the event a title, resulting in this:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.planetcurran.com%2Fimg%2Fsmf%2Fphase1.jpg&hash=563f532c12ae3a8e70528f79cb48c9390213c004)

3) I click on the 'Post' button and that takes me to here:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.planetcurran.com%2Fimg%2Fsmf%2Fphase2.jpg&hash=9229fe9150f0e50fe748466612e21e6d5319d9a4)

Are we all on the same path so far? Do my screens match what you're seeing? Anything odd in the above that we're not mentioning?

For fun I removed the dump code in Post.php and moved it to index.php. Be careful - you want /forum/index.php. Right after the call to 'loadPermissions();', I added the debug code:


require_once("phpDump.php");
dump($_REQUEST);


Make sure the path to 'phpDump.php' is correct. Does this give you the same $_REQUEST dump as before? Following is what my $_REQUST dump looks like (after hitting the POST button on the 1st phase of entry - #2 above):

eventid   -1
evtitle   sssssssssssssssssss
month   6
day   8
calendar   1
year   2007
link_to_board   on
repeating   Empty String
repeat1_parm1   Empty String
repeat1_parm2   Empty String
repeat2_parm1   Empty String
repeat2_parm2   Empty String
repeat2_parm3   Empty String
repeat_end_type   Empty String
repeat_end_month   6
repeat_end_day   8
repeat_end_year   2007
board   10
sc   d2189cb8d35839f0c6e672bf9d3def84
action   calendar
sa   post
start   0


Hey: Anyone know why the board seems to be resizing inline images? Is that normal behavior?

cheers,
me
Title: Re: Calendar mods
Post by: Kindred on June 01, 2007, 07:57:51 AM
(yes, it is normal for the board to resize images... this prevents people from posting images which break the template.)
Title: Re: Calendar mods
Post by: Chris Curran on June 01, 2007, 08:18:23 AM
Quote from: Kindred on June 01, 2007, 07:57:51 AM
(yes, it is normal for the board to resize images... this prevents people from posting images which break the template.)

10-4 & thx. It'd be nice if that same logic was applied to those goofy long links that extend fifteen feet out to the right of your screen! :D
Title: Re: Calendar mods
Post by: Poreman on June 01, 2007, 09:36:16 AM
Quote from: Chris Curran on June 01, 2007, 08:18:23 AM
10-4 & thx. It'd be nice if that same logic was applied to those goofy long links that extend fifteen feet out to the right of your screen! :D

On my main board I installed Trim Url it takes care of that issue.  Hope someday to be able to use repeating events without filling up the error log.

Quote
Those $_REQUEST dumps are abnormal. The ones you guys posted is what $_REQUEST should look like *before* clicking on the 'Post' button.

for  me this is prior to post, when I posted the event, the dump didn't show up.

Dave
Title: Re: Calendar mods
Post by: Chris Curran on June 01, 2007, 09:53:44 AM
Quote from: Poreman on June 01, 2007, 09:36:16 AM
On my main board I installed Trim Url it takes care of that issue.  Hope someday to be able to use repeating events without filling up the error log.

Thanks, but I try to run without any other mods. It just makes my life so much easier. I would also like to find out why two of you seem to have the same problem, yet a few hundred have no issues at all. In my experience, we'll find out why sooner or later, and when we do, it'll probably be something very simple and we'll all slap our foreheads...

Quote
for  me this is prior to post, when I posted the event, the dump didn't show up.

I'm confused. If you put the debug code into Post.php, there's no way for you to see a dump prior to clicking that first 'Post' button. What am I missing?
Title: Re: Calendar mods
Post by: cferd on June 01, 2007, 10:00:59 AM
Chris,

I go to Calendar, click on June 8 and that takes me to the "Post in:" page, rather than the "Link Event to Post:" page. Could it have something to do with Calendar settings?
Title: Re: Calendar mods
Post by: Poreman on June 01, 2007, 10:23:09 AM
Quote from: cferd on June 01, 2007, 10:00:59 AM
Chris,

I go to Calendar, click on June 8 and that takes me to the "Post in:" page, rather than the "Link Event to Post:" page. Could it have something to do with Calendar settings?
I may have found a break through with the errors.
If the Allow events not linked to posts: is not checked I get the errors in log, with it checked like Chris's illustration above No errors in log.  So it seems to be something tied to the Events not linked to post.
Hope I found Something useful
Dave   
Title: Re: Calendar mods
Post by: Chris Curran on June 01, 2007, 10:37:26 AM
cferd & Dave,

Sounds like a real solid clue. Thanks and I'll get back to this in a few hours (dr appt to go to now).....
Title: Re: Calendar mods
Post by: Poreman on June 01, 2007, 11:27:16 AM
Quote from: Chris Curran on June 01, 2007, 10:37:26 AM
cferd & Dave,

Sounds like a real solid clue. Thanks and I'll get back to this in a few hours (dr appt to go to now).....

Glad this may help.
BTW
I installed mod on main board with all the other mods I have installed, I use a different theme and manually edited the post.template.php and the Calendar.template.php uploaded the moon phase images to the chosen template images. Made sure the Allow events not linked to posts:was checked, everything worked like a champ. I can live with this setting fine gives you some space to debug the unchecked mode.
Happy Camper  ;D
Thanks for your effort if I hadn't found out your settings would still be looking.
Dave
Title: Re: Calendar mods
Post by: Poreman on June 01, 2007, 11:46:53 PM
I ran across another error which is effecting both my main forum and the testsmf forum I set up.  I posted an event, and then a member commented on the event and it left an error in log.  So I duplicated the the action by posting to and event on the testsmf board that is running with no mods nothing but the repeating calendar and got this error.

8: Undefined index: event
File: /home/mysite/public_html/testsmf/Themes/default/Post.template.php
Line: 860


    if ($context['event']['repeating']=='0')


Round two LOL
Thanks
Dave
Title: Re: Calendar mods
Post by: anroth on June 02, 2007, 10:47:47 PM
Hello there,

I haven't been here for a while, but lately, I checked my error log as well, and found the same log entries as described here. They don't seem to affect the functionality of the board at all, but there's surely something wrong. :( I observed my log a bit and found out the following:

- I was getting log entries with "8: unserialize() [<a href='function.unserialize'>function.unserialize</a>]: Error at offset 65487 of 65534 bytes ... /Sources/BoardIndex.php" - apparently, this stopped when I disabled the display of upcoming events on the index page (so they are just displayed in the calendar).

- I'm still getting "8: Undefined index: event ... /Themes/default/languages/Post.german.php" errors, though, like the one Poreman described above. I have also some events that got a comment from someone else, so this could be the trigger indeed.

I haven't modified my installation since last time; still running the calendar mod version 1.2.6 on SMF 1.1.2 without any further updates.
Title: Re: Calendar mods
Post by: cferd on June 03, 2007, 12:10:06 PM
Poreman,

I changed that code to:
    if (!isset($context['event']['repeating']))

I think I got everything working fine on my test site. Had to remove and change some code around to make it all go.

"Allow events not linked to posts" is now ok checked or unchecked, but unless I leave it checked, "force_defaultboard" causes errors. With both checked, everything works without a hitch. Time to go live.
Title: Re: Calendar mods
Post by: Chris Curran on June 05, 2007, 08:22:35 AM
Medical issues have me sidelined for a few days. I'll address the above issues as I can later this week. Cferd - I think that last "fix" you posted will cause a bug. What execution path will the code take if $context['event']['repeating'] is equal to '1'?

me
Title: Re: Calendar mods
Post by: cferd on June 05, 2007, 01:18:08 PM
Hey Chris,

I was mistakenly under the impression that 0 was the same as unset, but it isn't.

Still, everything seems to be posting properly without errors. What would happen if I get rid of that if statement  altogether?

Remember, personal life does and always should come first. There's no rush whatsoever.
Title: Re: Calendar mods
Post by: Poreman on June 05, 2007, 05:55:35 PM
I think I am going to wait until Chris has time to see if he can figure out what is happening, seems when I try a work around I start getting errors somewhere else.  I guess I will have to put my patients to work.  I love the mod and it will be good as we have prison ministries every third Tuesday of the month and wanted to use the repeating mod for that purpose.  Someday I am sure it will load and run with one install.
Waiting LOL
Dave
Title: Re: Calendar mods
Post by: Terrell Smith on June 09, 2007, 01:42:50 PM
I have smf 1.1.2, but when I try to download the package "48. Repeating Events for Calendar" through the Package Manager I get "An Error has Occurred! The package you are trying to download or install is either corrupt or not compatible with this version of SMF."

Is it in fact, corrupt, or do I need to do a manual install?
Title: Re: Calendar mods
Post by: Pers on June 10, 2007, 03:18:25 PM
@ Terrell Smith:

Make your Packages folder "writable".  It should install then.
Title: Re: Calendar mods
Post by: Evil Penguin on June 12, 2007, 08:03:39 AM
I get the following error:

4. Execute Modification ./Themes/default/Calendar.template.php Test failed

Help?
Title: Re: Calendar mods
Post by: Kindred on June 12, 2007, 12:02:33 PM
sounds like you have installed some othe rmod package which already modified the calendar.template.php file...

You will have to apply the code by hand...
Title: Re: Calendar mods
Post by: Evil Penguin on June 12, 2007, 07:55:19 PM
The only other calendar mod I have is the Enhanced Calendar.
Title: Re: Calendar mods
Post by: Kindred on June 13, 2007, 01:01:20 AM
and we have a winner....  that mod modified the code that THIS mod is looking for. hence the error.

Quote
You will have to apply the code by hand...
Title: Re: Calendar mods
Post by: Evil Penguin on June 13, 2007, 01:06:35 AM
Quote from: Kindred on June 13, 2007, 01:01:20 AM
and we have a winner....  that mod modified the code that THIS mod is looking for. hence the error.

Quote
You will have to apply the code by hand...

I uninstalled the mod and reinstalled the Repeating event one, it installed successfully but I do not have an option when creating a calendar event to have it repeating.
Title: Re: Calendar mods
Post by: MiniWarLord on June 15, 2007, 05:05:24 AM
I love the concept of this MOD and it works for the most part.
I am using 1.2.6 with SMF 1.1.2.  All of the events that I set as recurring work just fine until I link it to a post.  As soon as I link it to a post, I am left with only the event on the original date and no recurrence.  Any ideas?
Title: Re: Calendar mods
Post by: cferd on June 15, 2007, 12:35:38 PM
I've never tried 1.2.6, but have this one installed: http://www.simplemachines.org/community/index.php?topic=66939.msg1108839#msg1108839

It's working more or less the way I want. I believe in the Calendar settings, you would need to have "Allow events not linked to posts" checked. At least until the few bugs that exist are fixed.
Title: Re: Calendar mods
Post by: MiniWarLord on June 15, 2007, 09:11:59 PM
I just uninstalled 1.2.6 and installed the one you pointed me too and got the same result.  If I link the event to a post, no replication takes place.
Title: Re: Calendar mods
Post by: cferd on June 16, 2007, 01:33:31 AM
Hmm. It could be that your expectations and mine are a little different.

If, for example, I create an event to occur on June 18, 2007 and then choose to have it repeat every month, the event will show on the Calendar for July 18, August 18, and so on. But when going to read the post, the "Linked Event" will only say June 18, 2007. Is that more or less what you get too?
Title: Re: Calendar mods
Post by: MiniWarLord on June 16, 2007, 02:03:08 AM
No.  When I create an event on the calendar to start June 18 and set it to repete every week for the next two months, it works fine.
If I create the same event, but this time I link it to a post with more details for the event, it will only show in the calendar on the 18th of June and no where else.  All of the settings are the same except for the link to the post.
Title: Re: Calendar mods
Post by: cferd on June 16, 2007, 12:14:29 PM
I just tried your identical setup. June 18, to repeat every week, ending August 18. I see the event every Monday for the next 2 months on the Calendar.

I can't find what I might have played with to make it work, maybe nothing, I don't know.
Title: Re: Calendar mods
Post by: MiniWarLord on June 16, 2007, 03:21:03 PM
Did you do it with a link to a post for the event?
Without a post, it works fine.
Title: Re: Calendar mods
Post by: cferd on June 16, 2007, 06:39:31 PM
Yes. The checkbox is pre-selected and the it posts fine on the appropriate board.

In the Calendar settings, I have both "Force default board in events:" and "Allow events not linked to posts:" selected.
Title: Re: Calendar mods
Post by: MiniWarLord on June 17, 2007, 12:46:58 AM
So what you're telling me is that my problem is an anomaly isolated to the board I am trying to use it on.  Figures.  I am back to doing each event one at a time i guess.
Thanks for the help.  I do appreciate it.
Title: Re: Calendar mods
Post by: brelwit on June 17, 2007, 08:02:48 AM
I discovered more bugs for the Repeating Events ver.1.2.6 module. When in the 'New Topic', 'Reply', 'Modify', 'Quote', and 'Link To Calendar' screen in the forum, the ff. Javascript error appears in the bottom of my browser (Status Bar in Internet Explorer) with the corresponding errors in the Admin's Forum Error Logs page:

---------------------------

NEW TOPIC

Javascript Error:

Line: 272
Char: 33
Error: 'document.getElementById(...)' is null or not an object
Code: 0
URL: http://localhost/tabletopwars2007/bb/index.php?action=post;board=1.0


Forum Error Log:

admin Today at 07:46:19 pm
127.0.0.1 d5eae2af7afe029238cc6674d10e265d
http://localhost/tabletopwars2007/bb/index.php?action=post;board=1.0
8: Undefined index: event
File: c:\easyphp\www\tabletopwars2007\bb\Themes\default\languages\Post.english.php (eval?)
Line: 860

admin&nbsp; &nbsp;Today at 11:30:36 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;board=19.0&nbsp;
8: Undefined index: event
File: c:\easyphp\www\tabletopwars2007\bb\Themes\default\Post.template.php (eval?)
Line: 620


---------------------------

REPLY

Javascript Error:

Line: 274
Char: 33
Error: 'document.getElementById(...)' is null or not an object
Code: 0
URL: http://localhost/tabletopwars2007/bb/index.php?action=post;topic=13.0;num_replies=0


Forum Error Log:

admin&nbsp; &nbsp;Today at 11:32:31 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;topic=13.0;num_replies=0&nbsp;
8: Undefined index: event
File: c:\easyphp\www\tabletopwars2007\bb\Themes\default\languages\Post.english.php (eval?)
Line: 860


---------------------------

MODIFY

Javascript Error:

Line: 274
Char: 33
Error: 'document.getElementById(...)' is null or not an object
Code: 0
URL: http://localhost/tabletopwars2007/bb/index.php?action=post;msg=43;topic=13.0;sesc=2e808ff2428f8930a1ffa3a2e86ef49f


Forum Error Log:

admin&nbsp; &nbsp;Today at 11:35:15 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: event
File: c:\easyphp\www\tabletopwars2007\bb\Themes\default\languages\Post.english.php (eval?)
Line: 860


---------------------------

QUOTE

Javascript Error:

Line: 274
Char: 33
Error: 'document.getElementById(...)' is null or not an object
Code: 0
URL: http://localhost/tabletopwars2007/bb/index.php?action=post;quote=43;topic=13.0;num_replies=0;sesc=2e808ff2428f8930a1ffa3a2e86ef49f


Forum Error Log:

admin&nbsp; &nbsp;Today at 11:38:07 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;quote=43;topic=13.0;num_replies=0;sesc&nbsp;
8: Undefined index: event
File: c:\easyphp\www\tabletopwars2007\bb\Themes\default\languages\Post.english.php (eval?)
Line: 860


---------------------------

LINK TO CALENDAR

Javascript Error:

Line: 274
Char: 33
Error: 'document.getElementById(...)' is null or not an object
Code: 0
URL: http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc=2e808ff2428f8930a1ffa3a2e86ef49f


Forum Error Log:

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat_end_year
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 314

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat_end_day
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 313

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat_end_month
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 312

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat_end_type
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 311

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat2_parm3
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 310

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat2_parm2
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 309

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat2_parm1
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 308

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat1_parm2
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 307

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeat1_parm1
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 306

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: repeating
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 305

admin&nbsp; &nbsp;Today at 11:40:56 pm&nbsp;
127.0.0.1&nbsp; &nbsp; &nbsp;2e808ff2428f8930a1ffa3a2e86ef49f&nbsp;
http://localhost/tabletopwars2007/bb/index.php?action=post;calendar;msg=43;topic=13.0;sesc&nbsp;
8: Undefined index: board
File: c:\easyphp\www\tabletopwars2007\bb\Sources\Post.php
Line: 304


---------------------------

I uninstalled the Repeating Events module and the errors disappeared. I then reinstalled it and the errors reappeared so I know it has something to do with this mod.&nbsp; I am using SMF v.1.1.2.&nbsp; Hope somebody can help.&nbsp; Thanks!
Title: Re: Calendar mods
Post by: cferd on June 17, 2007, 01:08:52 PM
I get the script errors too, but nothing in the forum error log. They may be unrelated to the script errors.

While waiting for the bug-fixed versions, and realizing that anything associated with events on the forum is conditional, I changed the following codes to eliminate the script errors.
Note: Haven't thoroughly tested it, so make backups if using.

In Post.template.php
from:
echo '
function swapEndDate(swap)
{
document.getElementById("calendar_repeat_endTTL").style.display = swap;
document.getElementById("calendar_repeat_end2").style.display = swap;
}

function setLinked(state)
{
document.getElementById("board").disabled = state;
}
';

to:
echo '
function swapEndDate(swap)
{
if(document.getElementById("calendar_repeat_endTTL"))
document.getElementById("calendar_repeat_endTTL").style.display = swap;
if(document.getElementById("calendar_repeat_end2"))
document.getElementById("calendar_repeat_end2").style.display = swap;
}

function setLinked(state)
{
if(document.getElementById("board"))
document.getElementById("board").disabled = state;
}
';

In Calendar.template.php
from:
function swapEndDate(swap)
{
document.getElementById("calendar_repeat_endTTL").style.display = swap;
document.getElementById("calendar_repeat_end2").style.display = swap;
document.getElementById("calendar_repeat_end3").style.display = swap;
}

function toggleLinked(form, cal_force_defaultboard)
{
if (cal_force_defaultboard == 0)
form.board.disabled = !form.link_to_board.checked;
}
function setLinked(state)
{
document.getElementById("board").disabled = state;
}

to:
function swapEndDate(swap)
{
if(document.getElementById("calendar_repeat_endTTL"))
document.getElementById("calendar_repeat_endTTL").style.display = swap;
if(document.getElementById("calendar_repeat_end2"))
document.getElementById("calendar_repeat_end2").style.display = swap;
if(document.getElementById("calendar_repeat_end3"))
document.getElementById("calendar_repeat_end3").style.display = swap;
}

function toggleLinked(form, cal_force_defaultboard)
{
if (cal_force_defaultboard == 0)
form.board.disabled = !form.link_to_board.checked;
}
function setLinked(state)
{
if(document.getElementById("board"))
document.getElementById("board").disabled = state;
}
Title: Re: Calendar mods
Post by: brelwit on June 18, 2007, 12:22:21 PM
Thanks for the fix cferd, it worked!  No more Javascript errors.  But I still have all the errors in my Forum Error Logs.
Title: Re: Calendar mods
Post by: MiniWarLord on June 20, 2007, 08:36:36 AM
I just moved to a different calendar solution.  Errors resolved.
This is not a negative hit on this MOD.  I did not care for the built in calendar to start with. Sorry
Title: Re: Calendar mods
Post by: brelwit on June 24, 2007, 11:47:16 AM
Quote from: MiniWarLord on June 20, 2007, 08:36:36 AM
I just moved to a different calendar solution.  Errors resolved.
This is not a negative hit on this MOD.  I did not care for the built in calendar to start with. Sorry

I'm just curious, what  is the other Calendar solution did you use?
Title: Re: Calendar mods
Post by: brelwit on June 24, 2007, 12:32:39 PM
Alas! Fixed the errors in my Forum Error Logs which I reported on page 14 (http://www.simplemachines.org/community/index.php?topic=66939.260). Please backup the two files below before tampering with them as I won't be held liable for damages. Anyways, this solution worked for me and removed the errors being generated in my Forum Error Logs admin page. Here's what I did...

STEP #1:

In Themes/default/Post.template.php, add these codes...


$context['event']['title'] = (isset($context['event']['title']))?$context['event']['title']:'';
$context['event']['repeating'] = (isset($context['event']['repeating']))?$context['event']['repeating']:'';


just before...


$subj = ($context['subject'] == '')?$context['event']['title']:$context['subject'];




STEP #2:

In Sources/Post.php, replace these codes...


$context['event']['board'] = $_REQUEST['board'];
$context['event']['repeating'] = $_REQUEST['repeating'];
$context['event']['repeat1_parm1'] = $_REQUEST['repeat1_parm1'];
$context['event']['repeat1_parm2'] = $_REQUEST['repeat1_parm2'];
$context['event']['repeat2_parm1'] = $_REQUEST['repeat2_parm1'];
$context['event']['repeat2_parm2'] = $_REQUEST['repeat2_parm2'];
$context['event']['repeat2_parm3'] = $_REQUEST['repeat2_parm3'];
$context['event']['repeat_end_type'] = $_REQUEST['repeat_end_type'];
$context['event']['repeat_end_month'] = $_REQUEST['repeat_end_month'];
$context['event']['repeat_end_day'] = $_REQUEST['repeat_end_day'];
$context['event']['repeat_end_year'] = $_REQUEST['repeat_end_year'];


with the codes below...


$context['event']["board"] = (isset($_REQUEST['board']))?$_REQUEST['board']:'';
$context['event']["repeating"] = (isset($_REQUEST['repeating']))?$_REQUEST['repeating']:'';
$context['event']["repeat1_parm1"] = (isset($_REQUEST['repeat1_parm1']))?$_REQUEST['repeat1_parm1']:'';
$context['event']["repeat1_parm2"] = (isset($_REQUEST['repeat1_parm2']))?$_REQUEST['repeat1_parm2']:'';
$context['event']["repeat2_parm1"] = (isset($_REQUEST['repeat2_parm1']))?$_REQUEST['repeat2_parm1']:'';
$context['event']["repeat2_parm2"] = (isset($_REQUEST['repeat2_parm2']))?$_REQUEST['repeat2_parm2']:'';
$context['event']["repeat2_parm3"] = (isset($_REQUEST['repeat2_parm3']))?$_REQUEST['repeat2_parm3']:'';
$context['event']["repeat_end_type"] = (isset($_REQUEST['repeat_end_type']))?$_REQUEST['repeat_end_type']:'';
$context['event']["repeat_end_month"] = (isset($_REQUEST['repeat_end_month']))?$_REQUEST['repeat_end_month']:'';
$context['event']["repeat_end_day"] = (isset($_REQUEST['repeat_end_day']))?$_REQUEST['repeat_end_day']:'';
$context['event']["repeat_end_year"] = (isset($_REQUEST['repeat_end_year']))?$_REQUEST['repeat_end_year']:'';


That's it! :) It is important to remember that whenever a variable is newly specified, you have to define it too beforehand by including a code that says "If the said variable exists or has a corresponding value, then store it with the said variable name else store blank."

I guess all of these trouble defining a variable is because of the ERROR REPORTING (error_reporting(E_ALL ^ E_NOTICE)) being turned on for SMF.  Undefined variables are reported in the Forum Error Logs.
Title: Re: Calendar mods
Post by: MiniWarLord on June 29, 2007, 05:13:08 AM
Quote from: brelwit on June 24, 2007, 11:47:16 AM
I'm just curious, what  is the other Calendar solution did you use?
I just realized that my comment was a little misleading.  I am using SMF bridged into Joomla, so I switched to a Joomla calendar called JEvent and moved my calendar out of the forum entirely.  I am surprised to see that there are no third party calendars for SMF though.
Title: Re: Calendar mods
Post by: Pers on June 29, 2007, 08:46:55 PM
@brelwit,

Thanks for that.   I've added the changes and so far ...... <keeps fingers crossed>
Title: Re: Calendar mods undefined function: gregoriantojd()
Post by: BJT on July 03, 2007, 04:10:34 AM
have just installed this mod, 1.2.6, but when trying to set up an event get the following error

Fatal error: Call to undefined function: gregoriantojd() in /home/t/e/telfordb/public_html/forum/Sources/Calendar.php on line 546

This happens with all events.
Have searched Calendar.php and can't find any reference to this function?

BJT
Title: Re: Calendar mods
Post by: cferd on July 03, 2007, 07:28:28 AM
There are a few references to that function in Calendar.php so double check it, it may not have installed properly.

In my case, I couldn't get Calendar.php to pass the test while installing the Mod and had to manually insert the code.
Title: Re: Calendar mods undefined function: gregoriantojd()
Post by: BJT on July 03, 2007, 10:33:53 AM
Have found a few calls to the function gregoriantojd(), but can't find where the function is defined.
have just discovered that I am getting this error by just trying to view the calendar.
I have searched all the obvious files and can't find the function definition.
Title: Re: Calendar mods Call to undefined function: gregoriantojd() in /h
Post by: BJT on July 03, 2007, 12:52:42 PM
I'm in stupid mode today  :-[ hadn't realised that this is a built in PHP function. So it must be a problem with my host. I checked the PHP ebsite and that lists it as available in PHP4 & PHP5 my host is runninig 4.4.1 so it should work ,shouldn't it?
Title: Re: Calendar mods
Post by: cferd on July 03, 2007, 01:41:06 PM
 :) We're both kinda in the same boat. I have a habit of replying to the last line of a post and forgetting the rest.

The problem, as you said, is probably with your host. Have them make sure the calendar extension is being loaded.
Title: Re: Calendar mods Not repeating when linked to post
Post by: BJT on July 05, 2007, 01:56:17 AM
I have now changed servers and script error has gone away BUT if I enter an event and link it to a post it doesn't repeat. None linked events repeat fine.

Title: Re: Calendar mods
Post by: BJT on July 05, 2007, 04:11:30 AM
If I change to the default theme it works fine.
Now sorted. Copied the relevant code from themes/default/post.Template.php to
to themes/classic/post.template.php and it all works :D
Title: Re: Calendar mods
Post by: Rozak on July 12, 2007, 07:12:28 AM
Quote from: brelwit on June 24, 2007, 12:32:39 PM
Alas! Fixed the errors in my Forum Error Logs which I reported on page 14 (http://www.simplemachines.org/community/index.php?topic=66939.260). Please backup the two files below before tampering with them as I won't be held liable for damages. Anyways, this solution worked for me and removed the errors being generated in my Forum Error Logs admin page. Here's what I did...
...

ok this is basically the same fix posted earlier - and of course this does what the author said - it covers up the error... the problem comes from an incorrect request array being passed post mod applicaiton - this can come from TWO places - the actual calendar code itself (you forgot do edit something in the calendar code) - or where we are seeing it is from the Calendar Link button on the bottom of the thread display. When you create a calendar entry (repeating or not) and attach a post - anyone going to edit the entry clicks on the calendar link - and there is an incorrect REQUEST array in there - not sure how to fix so I am applying the cover up errors patch for now.

I think the nett effect of this is that if you go to edit a repeating event from the Calendar link at the bottom of the thread the event will have its repeat details removed.
Title: Re: Calendar mods
Post by: Rozak on July 12, 2007, 07:20:39 AM
Quote from: Chris Curran on June 01, 2007, 07:45:58 AM
cferd & Dave,

Those $_REQUEST dumps are abnormal. The ones you guys posted is what $_REQUEST should look like *before* clicking on the 'Post' button. In this case, $_REQUEST is loaded in the function 'template_event_post()' in Calendar.template.php (about line 244 - look for the '<form' statement). It gets handed off a number of times before it reaches Post.php - I can't tell if it's not being set, or if it's being destroyed along the way.

Lets also take the time to be sure that we're all starting from the same point, and progressing along the same path. I'm testing the reports as follows:

1) Go to calendar and click on a day number. I'm using June 8 in this example.
2) I give the event a title, resulting in this:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.planetcurran.com%2Fimg%2Fsmf%2Fphase1.jpg&hash=563f532c12ae3a8e70528f79cb48c9390213c004)

3) I click on the 'Post' button and that takes me to here:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.planetcurran.com%2Fimg%2Fsmf%2Fphase2.jpg&hash=9229fe9150f0e50fe748466612e21e6d5319d9a4)

Are we all on the same path so far? Do my screens match what you're seeing? Anything odd in the above that we're not mentioning?

...

This is the point :) You can generate those errors quite happily by going to the bottom of a posted topic and clicking on the calendar link, as Display template has not been changed to update the calendar link - somewhere around line 1228 (look for if ($context['calendar_post']) )  and of course the context array will have to be constructed correctly before diving into that template....

Title: Re: Calendar mods
Post by: Rozak on July 12, 2007, 07:39:57 AM
Quote from: Poreman on May 15, 2007, 07:03:47 PM
Quote from: Chris Curran on May 15, 2007, 08:12:25 AM
Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Yep - this is a bug that exists in the 1.1.2 codeset (probably prior versions too - I didn't check). Is there a procedure here at SMF, or do I just fix it (I already have the fix)? I don't want to step on any toes....

cheers,
me

Can you share the fix? Maybe it will straighten up some of the other problems.

Thanks
Poreman

/bump - share the fix??
Title: Re: Calendar mods
Post by: Ryuoh on August 06, 2007, 09:21:17 AM
i get a repeating error on my board index with show events on board index and calendar turned on

8: unserialize() [<a href='function.unserialize'>function.unserialize</a>]: Error at offset 65532 of 65534 bytes
File: ..../Sources/BoardIndex.php
Line: 604

anyone have this same problem or know how to fix this?

im running 1.1.3
with
1.     TinyPortal      0.983      
2.    View Any Topic Permission Mod
3.    Users Online Today Mod 
4.    Member Color Link    
5.    Custom Action Mod    
6.    SMF Arcade    
7.    YouTube BBC Tag (XHTML Compliant)
8.    Ultimate Shoutbox
9.    Repeating Calendar Events
10.    SMF Ajax Registration Feedback
Title: Re: Calendar mods
Post by: oridyne on August 15, 2007, 12:25:58 PM
Quote from: Rozak on July 12, 2007, 07:39:57 AM
Quote from: Poreman on May 15, 2007, 07:03:47 PM
Quote from: Chris Curran on May 15, 2007, 08:12:25 AM
Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Yep - this is a bug that exists in the 1.1.2 codeset (probably prior versions too - I didn't check). Is there a procedure here at SMF, or do I just fix it (I already have the fix)? I don't want to step on any toes....

cheers,
me

Can you share the fix? Maybe it will straighten up some of the other problems.

Thanks
Poreman

/bump - share the fix??

Any News on this fix? I seem to be getting the same error messages in the logs and would like to fix them..

Thanks...
Title: Re: Calendar mods
Post by: Merecraft on September 13, 2007, 09:22:18 AM
Quote from: oridyne on August 15, 2007, 12:25:58 PM
Quote from: Rozak on July 12, 2007, 07:39:57 AM
Quote from: Poreman on May 15, 2007, 07:03:47 PM
Quote from: Chris Curran on May 15, 2007, 08:12:25 AM
Quote from: SMF ERROR Log
8: Undefined index: poster
File: /home/MySite/public_html/forums/Sources/BoardIndex.php
Line: 589

Yep - this is a bug that exists in the 1.1.2 codeset (probably prior versions too - I didn't check). Is there a procedure here at SMF, or do I just fix it (I already have the fix)? I don't want to step on any toes....

cheers,
me

Can you share the fix? Maybe it will straighten up some of the other problems.

Thanks
Poreman

/bump - share the fix??

Any News on this fix? I seem to be getting the same error messages in the logs and would like to fix them..

Thanks...


Also waiting on a fix. Thanks!

Edit: Found it sorry: http://www.simplemachines.org/community/index.php?topic=66939.msg1094026#msg1094026
Title: Re: Calendar mods
Post by: marcool on September 13, 2007, 01:27:41 PM
Hi,

I've read somewhere that this mod would support user registration to event soon.
Any idea when this feature will be added?

thanks
Title: Re: Calendar mods
Post by: farzad on September 18, 2007, 09:25:19 AM
would be nice if the mod would create multiple Forum Threads when the repeating event is posted.  In other words,  say i have a Geek Convention from October 5 through October 7th - Three threads would be created for this event.  Perhaps one way to make the threads unique would be to add the date before the event.

10.05.07 / Geek Convention
10.06.07 / Geek Convention
10.07.07 / Geek Convention

same thing holds true for weekly or monthly events.   add the date to the subject and create the forum threads.

is this possible?
Title: Re: Calendar mods
Post by: Onicat on September 21, 2007, 03:02:26 AM
8: unserialize() [<a href='function.unserialize'>function.unserialize</a>]: Error at offset 65533 of 65538 bytes
File: /media/mccforum/public_html/SSI.php
Line: 1464


That is an error I continue to Get. I have been able to trace the issue to the Calendar Mod...
And have been asking questions on this thread... http://www.simplemachines.org/community/index.php?topic=175619.20
I was directed to ask my question here on this thread.

This appears to be the only error I get on my forum. www.akcommunity.com. On the home page on the left side Under Up Comming Events. It should give a list of all the recent events that are comming. But it does not. The only time it show's that is when I click on the Calendar tab, and go to the Calendar page.

I have checked for events that repeat every day (I was told this may cause the error) and I dont have any that repeat every day. I have a few that repeat every week, or monthly. But nothing Daily.

Would any one have an idea as to how I might be able to fix this problem? Any help would be greatful.

Thanks

~Oni
Title: Re: Calendar mods
Post by: maros on September 30, 2007, 05:49:00 AM
Hey... great work Chris! I have looked high and low for this kind of mod since starting to use SMF (a little over a year ago now) but i could'nt find anything as good as this.

Just curious about the attendees addition... how is the work coming along with all the bugfixing?

Keep up the good work!

/Martin
Title: Re: Calendar mods
Post by: rosey on October 03, 2007, 05:01:31 PM
just subbing to this thread, interested in the attendees feature as well!
Title: Re: Calendar mods
Post by: Onicat on October 08, 2007, 10:23:40 PM
Does this mod work with 1.1.4? Or is there going to be an update comming out soon?
I ask cause my server eneded up with a fresh new install of smf on it, and I am trying to avoid the same problem I had before, but really like this mod. It helps alot with my website.
Title: Re: Calendar mods
Post by: Posters United on October 20, 2007, 05:33:04 PM
Whats rc2
Title: Re: Calendar mods
Post by: NEMINI on October 21, 2007, 03:01:29 AM
works fine for me on 1.1.4
Title: Re: Calendar mods
Post by: Onicat on October 21, 2007, 01:48:34 PM
I am still having the same problem. ... Any one have any other idea's?
Title: Re: Calendar mods
Post by: Serendipity on November 02, 2007, 12:17:29 PM
This is pretty much what I've been looking for- thank you for such a great calendar mod. I am letting the members post their attendance in the forum link associated with the calendar =) I currently have SMF 1.1.4 and it works just fine. I even use TP and so far no bugs or any other issues. Thanks again. (this saved me a lot of work >.> )
Title: Re: Calendar mods
Post by: farzad on November 07, 2007, 11:13:38 AM
is anyones calendar taking 20+ seconds to load?   this is the only mod i'm running on 1.1.4 and i have very long calendar load times 20 seconds or more usually

Page created in 20.138 seconds with 16 queries. 

when i uninstall the mod:

Page created in 0.596 seconds with 13 queries. 

when i add $db_show_debug = true;

to my Settings.php file

i see a HUGE amount of information being set to the DB by the
REPLACE INTO smf_settings
         (variable, value)
      VALUES (SUBSTRING('cal_today_event', 1, 255),

command adding 20+ seconds to the calendar load time.

anyone have any feedback on this?
Title: Re: Calendar mods
Post by: katdillon on November 13, 2007, 07:29:55 AM
I tried installing this with 1.1.4 and had the huge load time for the calendar.  In addition, when the calendar page finally comes up, it's blank. 
Title: Re: Calendar mods
Post by: farzad on November 13, 2007, 08:37:38 AM
i'm running 1.1.4  as well
Title: Re: Calendar mods
Post by: imrich on December 06, 2007, 09:15:20 AM
Quote from: Poreman on June 01, 2007, 10:23:09 AM
Quote from: cferd on June 01, 2007, 10:00:59 AM
Chris,

I go to Calendar, click on June 8 and that takes me to the "Post in:" page, rather than the "Link Event to Post:" page. Could it have something to do with Calendar settings?
I may have found a break through with the errors.
If the Allow events not linked to posts: is not checked I get the errors in log, with it checked like Chris's illustration above No errors in log.  So it seems to be something tied to the Events not linked to post.
Hope I found Something useful
Dave   


I just installed this repeating calendar mod 1.2.6 (which I think should be in the core release of SMF as it's sorely needed!) on smf 1.1.4.

The only other mod I have is Auto Embed Video Clips 1.6

I am seeing a similar error to above, that is a lot of error messages about undefined variables in my log when "Allow events not linked to posts" is unchecked.

If I check "Allow events not linked to posts", then the errors do not appear.

Also, when I had "Force default board in events" checked along with unchecking 'allow events not linked to posts", my posts would get lost in an unexisting board (I guess my SMF does not have a board with id of 0).

I noticed that Chris hasn't been around since saying "I'll be back after my Dr's appointment". I hope he is well!!

Has anyone found a fix for these event log issues when "Allow Events not linked to posts" is checked?

Also, as a separate thing, how can we petition the SMF staff to get this 'repeating calendar' feature into the next SMF release? :)
Title: Re: Calendar mods
Post by: farzad on December 06, 2007, 09:44:30 AM
its already been petitioned many times
Title: Re: Calendar mods
Post by: imrich on December 06, 2007, 10:59:54 AM
By the way, I don't have the load time issue people have mentioned.
Title: Re: Calendar mods
Post by: farzad on December 06, 2007, 11:33:46 AM
do you have alot of events in your calendar?
Title: Re: Calendar mods
Post by: imrich on December 06, 2007, 11:47:45 AM
Quote from: Chris Curran on June 05, 2007, 08:22:35 AM
Medical issues have me sidelined for a few days. I'll address the above issues as I can later this week. Cferd - I think that last "fix" you posted will cause a bug. What execution path will the code take if $context['event']['repeating'] is equal to '1'?

me

Chris,

We haven't heard from you since this post, are you ok?
Title: Re: Calendar mods
Post by: imrich on December 07, 2007, 07:21:03 AM
I'm also seeing errors when people simply post a message to my forum:

8: Undefined index: event
File: /home/username/domains/domain.tld/public_html/forum/Themes/default/Post.template.php (eval?)
Line: 620

I'd love to use this mod, but my error log is still filling up.
Title: Re: Calendar mods
Post by: acynonyxx on December 10, 2007, 09:16:40 PM
Will this work with the new 1.1.4 Version?
Title: Re: Calendar mods
Post by: acynonyxx on December 10, 2007, 09:34:57 PM
OK actually it does work, but i have a new question:

How do you delete a repeating event???????

I made a "test event" to see if it works and I dont see any way to delete it.
Title: Re: Calendar mods
Post by: EkSeS on December 28, 2007, 11:04:51 AM
Quote from: acynonyxx on December 10, 2007, 09:34:57 PM
...
How do you delete a repeating event?
...

Show your Calendar  :)
Normal as the other events.
Click-> *<- left from event and modify or delete.

It works with smf 1.1.4  8)
Title: Re: Calendar mods
Post by: runebergen on January 14, 2008, 06:47:15 PM


Anyone know how to fix the gregoriantojd error ?

Please please :) I really want this mod to work

Thanx :)
Title: Re: Calendar mods
Post by: Onicat on January 17, 2008, 05:13:37 PM
Quote8: unserialize() [<a href='function.unserialize'>function.unserialize</a>]: Error at offset 65524 of 65538 bytes

That is the error that I get.

Quoteglobal $scripturl;
$now = mktime();
         $today = date('j',$now);
         $year = date("Y",$now);
         $month = date("n",$now);
         $days = array($today=>array(NULL,NULL,'<a class="smalltext" style="color: steelblue; font-weight: bold; border: solid 1px black; background-color: white; padding: 0px 4px 0px 4px;" href="'.$scripturl.'?action=calendar;sa=post;month='.$month.';year='.$year.';day='.$today.'" target="_self">'.$today.'</a>'));

         $day_name_length = 3;
         $month_href = $scripturl . '?action=calendar';
         $first_day = 1;
         $pn = array();

$first_of_month = gmmktime(0,0,0,$month,1,$year);
#remember that mktime will automatically correct if invalid dates are entered
# for instance, mktime(0,0,0,12,32,1997) will be the date for Jan 1, 1998
# this provides a built in "rounding" feature to generate_calendar()

$day_names = array(); #generate all the day names according to the current locale
for($n=0,$t=(3+$first_day)*86400; $n<7; $n++,$t+=86400) #January 4, 1970 was a Sunday
$day_names[$n] = ucfirst(gmstrftime('%A',$t)); #%A means full textual day name

list($month, $year, $month_name, $weekday) = explode(',',gmstrftime('%m,%Y,%B,%w',$first_of_month));
$weekday = ($weekday + 7 - $first_day) % 7; #adjust for $first_day
$title   = htmlentities(ucfirst($month_name)).' '.$year;  #note that some locales don't capitalize month and day names

#Begin calendar. Uses a real <caption>. See http://diveintomark.org/archives/2002/07/03
@list($p, $pl) = each($pn); @list($n, $nl) = each($pn); #previous and next links, if applicable
if($p) $p = '<span class="smalltext">'.($pl ? '<a href="'.htmlspecialchars($pl).'">'.$p.'</a>' : $p).'</span> ';
if($n) $n = ' <span class="smalltext">'.($nl ? '<a href="'.htmlspecialchars($nl).'">'.$n.'</a>' : $n).'</span>';
$calendar = '<table>'."\n".
'<caption >'.$p.($month_href ? '<a href="'.htmlspecialchars($month_href).'">'.$title.'</a>' : $title).$n."</caption>\n<tr>";

if($day_name_length){ #if the day names should be shown ($day_name_length > 0)
#if day_name_length is >3, the full name of the day will be printed
foreach($day_names as $d)
$calendar .= '<th class="smalltext" abbr="'.htmlentities($d).'">'.htmlentities($day_name_length < 4 ? substr($d,0,$day_name_length) : $d).'</th>';
$calendar .= "</tr>\n<tr style=\"text-align:right;\">";
}

if($weekday > 0) $calendar .= '<td class="smalltext" colspan="'.$weekday.'"> </td>'; #initial 'empty' days
for($day=1,$days_in_month=gmdate('t',$first_of_month); $day<=$days_in_month; $day++,$weekday++){
if($weekday == 7){
$weekday   = 0; #start a new week
$calendar .= "</tr>\n<tr style=\"text-align:right;\">";
}
if(isset($days[$day]) and is_array($days[$day])){
@list($link, $classes, $content) = $days[$day];
if(is_null($content))  $content  = $day;
$calendar .= '<td "'.($classes ? ' class="'.htmlspecialchars($classes).'">' : '>').
($link ? '<a href="'.htmlspecialchars($link).'">'.$content.'</a>' : $content).'</td>';
}
else
{
$calendar .= "<td class=\"smalltext\" style=\"padding-right:4px;\"><a";
if(((($weekday+$first_day) % 7)==0)||((($weekday+$first_day) % 7)==6))
{
$calendar .= ' style="color:#C00000;"';
}
$calendar .= " href=\"".$scripturl."?action=calendar;sa=post;month=".$month.";year=".$year.";day=".$day."\" target=\"_self\">$day</a></td>";
}
}
if($weekday != 7) $calendar .= '<td class="smalltext" colspan="'.(7-$weekday).'"> </td>'; #remaining "empty" days
echo $calendar.'</tr>';

if (ssi_todaysBirthdays('')) {
  echo '<tr><td><hr></td><td colspan="5" class="smalltext" align="center">Birthdays</td><td><hr></td></tr><td colspan="7" class="smalltext">';
  ssi_todaysBirthdays();
  echo '</td></tr>';
}

if (ssi_todaysCalendar('')) {
  echo '<tr><td><hr></td><td colspan="5" class="smalltext" align="center">Upcoming Events</td><td><hr></td></tr><td colspan="7" class="smalltext">';
  ssi_todaysCalendar();
  echo '</td></tr>';
}

echo '</table>';

That is the Calendar Box Code I am using.

http://custom.simplemachines.org/mods/index.php?mod=655

That is the Repeating Calendar mod I am using with SMF and TP.

My website is www.akcommunity.com.

Ok thats I think all the important info upfront. Now for my question. hehe

If you go to the homepage and scroll down, on the left side will be the Calendar block. You will notice that it is not showing the events, just the calendar. But when you click the Calendar tab  up top and scroll down to that same spot. You will notice it is showing the events along with the calendar.

I have tried various calendar scripts...and end up with the same problem, even tried adjusting the amount of days in advance that it will show. I would like to keep it at least at 7 days. Cause as you can see my calendar is rather active. LOL.

Anyway. I am pretty sure that the error is linked to that script some how, cause when I dont use the repeating events, and that script, then I don't get the error...but I also dont get my calendar displayed on the front page.

Any one have any idea's as to how I could fix said problem?

Get the events to show on the front page were they should, and get rid of said error.
Title: Re: Calendar mods
Post by: andrewteg on January 20, 2008, 09:56:30 PM
It looks like the root of the problem is your ssi_todaysCalendar function, which has probably gotten changed somwhere along the line. If you go to http://www.akcommunity.com/ssi_examples.php you'll see that it is blank but it should not be.

Goto SMF's at http://www.simplemachines.org/community/ssi_examples.php and search for ssi_todaysCalendar and you'll see it is full of upcoming birthdays.

My test ssi_todaysCalendar at http://www.andrewteg.com/tp/ssi_examples.php also has some events, so I would put your ssi_todaysCalendar (function at http://www.akcommunity.com/SSI.php) back to the original one from SMF and see if it works on http://www.akcommunity.com/ssi_examples.php and if so, then see if it works on your homepage. If all that works, you know the problem is that SSI function got changed.

I'm just starting to get into modifying the SMF calendar so I don't know a lot yet but will hopefully get up to speed soon.

HTH,
Andrew
Title: Re: Calendar mods
Post by: Onicat on January 25, 2008, 09:29:13 PM
I tried replacing the SSI file with the origional...but that did not work iether. ....
Title: Re: Calendar mods
Post by: jmatlock on January 29, 2008, 02:29:34 PM
Hey Gang,
First of all, we love the mod,.. it works flawlessly!

I have one question regarding functionality.... We have a recurring event every week, and it is posted correctly. However, say on Mother's Day, we want to make an annual recurring for that date, which works fine also.. BUT, then we have both the standard event and the Special Mother's Day event showing at the same time on May 11th (we won't hold the reg. event, but the Mother's Day event instead)... So, when we delete the regular event for that date.. so only the Mother's day event shows.. it deletes ALL the recurring weekly regular events... not just that one, on that day...

Is there a way, to just delete ONE of the recurring event items... ex: you have a weekly recurring event, but it will not be held next week... so you can go in and delete that one, not the series????

Thanks again! SMF rocks
Title: Re: Calendar mods
Post by: Kindred on January 29, 2008, 03:11:49 PM
I believe, the way that this mod currently works, that the recurring event is a single entry, so there is no way to delete one day of that entry.

Perhaps, after 2.0 is released in RC, I will be able to take back this mod (since Chris has apparently abandoned it). However, It definitely will not happen before 2.0 RC1 is released publically.
Title: Re: Calendar mods
Post by: imrich on January 29, 2008, 07:15:53 PM
Kindred,

I was hoping you were going to say that this mod's features have been included in the SMF 2.0 core. Wow, that would be great and is sorely needed IMHO!  8)

Since not, I'll be looking forward to you taking over this mod as there are a few issues with it and I even tried to email Chris, but never received an answer from him. I hope his previously mentioned medical appointment wasn't the reason why we never heard from him again.
Title: Re: Calendar mods
Post by: Onicat on January 30, 2008, 06:30:32 PM
http://www.akcommunity.com/ssi_examples.php With help from a friend of mine we got the ssi working properly. But we are still getting that error in the error log...and the same problem between the front page, and the calendar page, with regards to the block.
Title: Re: Calendar mods
Post by: Tarheel on February 05, 2008, 12:33:36 PM
I installed the Calendar modification successully but when I call up the Calendar in SMF, I get the following:  http://ncmotorcyclists.com/calendar.htm.  The Repeating and End Date form fields are incomplete.  I am using SMF 1.1.4 and Gallery 2.2.2. installed via cPanel Fantastico Deluxe.

What do you believe the problem is and how would you recommend that I solve it?  Thanks!

Title: Re: Calendar mods
Post by: Sapient on February 12, 2008, 07:27:24 AM

Greetings all,
   What is the latest on this?  Does it work with 1.1.4?  Does it work with all templates? 

I noticed in the Mod's section that no Calendar Mod reflects supporting 1.1.4...  Is this true or are these just not updated in the description?


Thanks for the work and support.

-b
Title: Re: Calendar mods
Post by: imrich on February 12, 2008, 12:23:46 PM
This seems to work, but it will fill your error logs with error messages.

I removed this mod until these errors are fixed. Unfortunately the Mod author seems to be lost now.
Title: Re: Calendar mods
Post by: Eric S. on February 13, 2008, 12:55:45 AM
I have this exact same problem, the fields are blank. I'm brand new to SMF and would appreciate some assistance.
Thank you.

Quote from: Tarheel on February 05, 2008, 12:33:36 PM
I installed the Calendar modification successully but when I call up the Calendar in SMF, I get the following:  http://ncmotorcyclists.com/calendar.htm.  The Repeating and End Date form fields are incomplete.  I am using SMF 1.1.4 and Gallery 2.2.2. installed via cPanel Fantastico Deluxe.

What do you believe the problem is and how would you recommend that I solve it?  Thanks!


Title: Re: Calendar mods
Post by: Kindred on February 13, 2008, 08:45:24 AM
I would bet that this is because you are using "english utf-8".

Mods only install in "english" (no utf-8) by default, and I believe fantastico uses english utf-8 for some reason.

Either switch your forum to "english" (no utf-8) or add the $txt strings currently in modifications.english.php to your modifications.englishutf8.php.
Title: Re: Calendar mods
Post by: Eric S. on February 13, 2008, 10:44:16 AM
Bingo! Thank you! I did use the fantastico install on my site. Changing to English worked. I did do an uninstall last night so I don't know if that was necessary but I set Language to English and installed the mod again and it works fine now.

Quote from: Kindred on February 13, 2008, 08:45:24 AM
I would bet that this is because you are using "english utf-8".

Mods only install in "english" (no utf-8) by default, and I believe fantastico uses english utf-8 for some reason.

Either switch your forum to "english" (no utf-8) or add the $txt strings currently in modifications.english.php to your modifications.englishutf8.php.

Title: Re: Calendar mods
Post by: myaicons on February 13, 2008, 03:13:39 PM
very nice mod... installed perfectly on 1.1.4 :)
Title: Re: Calendar mods
Post by: Sapient on February 13, 2008, 03:25:40 PM
If you do not mind me asking, how do your error logs look?

Thanks,
b
Title: Re: Calendar mods
Post by: myaicons on February 13, 2008, 04:02:11 PM
argh... NOT PERFECT!!!  >:(

what does this mean???

thsi is filling up my error log!

8: Undefined index: poster
File: /home/content/html/sforum/Sources/BoardIndex.php
Line: 517


help!  :'(
Title: Re: Calendar mods
Post by: imrich on February 13, 2008, 05:08:24 PM
Quote from: myaicons on February 13, 2008, 04:02:11 PM
argh... NOT PERFECT!!!  >:(

what does this mean???

thsi is filling up my error log!

8: Undefined index: poster
File: /home/content/html/sforum/Sources/BoardIndex.php
Line: 517


help!  :'(

This is the problem with this fantastic mod, it fills the error logs!!! I wish this could be fixed. I started looking into it myself, but ran out of time and understanding.
Title: Re: Calendar mods
Post by: myaicons on February 13, 2008, 05:21:48 PM
it was too good to be true....

i wonder if this error is enough to be a problem as far as the overall functionality of the forum ???

can anybody look into fixing this?  mod author huntdown?



such a waste to have something good but not complete.
Title: Re: Calendar mods
Post by: Delsa on March 15, 2008, 10:40:03 AM
Love the mod, been using it since it came out! Have a weird problem though.  I have a repeating event that's spans to the first day of the next month, but it's not showing up.  I have another repeating event that spans [well] into the next month that's working just fine.  Not sure why this one isn't working properly.

Also getting this in the error log.
http://[deleted]/index.php?action=calendar
8: Undefined index: poster
File: /[deleted]/MQWeb/SSI.php
Line: 1511

SMF 1.1.4
Repeating Events 1.2.6

If you need access to the site, PM me.
Title: Re: Calendar mods
Post by: imrich on March 15, 2008, 12:50:29 PM
I guess no one will address the filling of the error logs. I tried to look into it but can't find it yet.
Title: Re: Calendar mods
Post by: Rifugio on March 24, 2008, 09:27:51 AM
This mod does seem to generate errors in some installs.  It has taken me a while to pin it down to this mod as I'm new to SMF, when I'm feeling a bit braver I will back-up and uninstall the Mod to see if it solves the problem.  I agree with everyone though it's a shame as it's an extremely useful calendar mod.

8: Undefined index: event
File: /home/santuari/public_html/forum/Themes/default/languages/Post.english.php (main sub template - eval?)
Line: 882

Title: Re: Calendar mods
Post by: myaicons on March 27, 2008, 06:55:15 PM
yes such a shame... i hope someone resolves this issue!   c'mon brainiacs.. theres gotta be someone that can fix it or create a better version of it as it looks like the author has abondoned it...

(on a side note... i have a dated ssi events output which it does not completly comply with... it lists it correctly but it retains the date the reocurring event started and not the upcoming date the reocurring event is upcoming... but this is for another time lol)

Title: Re: Calendar mods
Post by: hosehead on April 02, 2008, 03:26:05 PM
Quote from: myaicons on March 27, 2008, 06:55:15 PM
yes such a shame... i hope someone resolves this issue!   c'mon brainiacs.. theres gotta be someone that can fix it or create a better version of it as it looks like the author has abondoned it...

Agreed.  This needs to be part of 2.0.  Or at least a working mod to get it going for heavily theme'd sites.
Title: Re: Calendar mods
Post by: Kindred on April 02, 2008, 03:48:09 PM
2.0 is feature frozen.

If I have time, I may re-look at the calendar pack for 2.0 now that the public beta has been released.... but don't expect anything for at least a month.
Title: Re: Calendar mods
Post by: EBeers on April 16, 2008, 01:28:49 PM
If, and when someone is going to change this MOD. I have some feature requests.

Possibility to repeat every week on selected days. For instace: repeat every week on monday, wednesday and friday.

Possibility to delete certain occurrences from a repeating event without deleting all occurrences.

I really could use such features...

Thanks...
Title: Re: Calendar mods
Post by: EBeers on April 16, 2008, 05:14:28 PM
Quote from: Rifugio on March 24, 2008, 09:27:51 AM
This mod does seem to generate errors in some installs.  It has taken me a while to pin it down to this mod as I'm new to SMF, when I'm feeling a bit braver I will back-up and uninstall the Mod to see if it solves the problem.  I agree with everyone though it's a shame as it's an extremely useful calendar mod.

8: Undefined index: event
File: /home/santuari/public_html/forum/Themes/default/languages/Post.english.php (main sub template - eval?)
Line: 882



I also get this error... It has to to something with the Post.template.php file... This is in that file:

    if ($context['event']['repeating']=='0')
    echo '
        <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
        swapEndDate(\'none\');
        // ]]></script>';

Title: Re: Calendar mods
Post by: 2Ntense on May 09, 2008, 09:52:25 PM
It's not terribly surprising there's problems with it... I threw it at a couple of package parsers and they both blew up.  Looks like he has a comment that's not terminated, and quite likely any of the modification after that didn't get done.  Why it didn't throw errors during the install is a mystery.

I'll look at it, but ONLY TO FIX IT.  I'm *not* adding any new mis-features, and I'm *not* offering to take over support for it.

edit: I'll attach a new file once I correct another error I found.  In Display.template.php, repeating events shown at the top of a thread should show the *next* event date, not the original event.

Apparently somebody didn't have their TABS set to TABS, so there was a hell of a lot of spaces making up all of the whitespace.  I converted every 4 spaces to a tab, removed all of the comments and viola! the package parsers were happy with it.  It installs and runs without any obvious problems.

With the original copy, I was getting some odd EVAL errors pretty frequently. 
Title: Re: Calendar mods
Post by: 2Ntense on May 10, 2008, 11:22:15 AM
Well, I didn't see anything in the error log last night, but I see a few of the same error today (Undefined index: poster in Sources/BoardIndex.php)

I'll walk that one down.  Looks like it only happened when a GUEST was doing something with the calendar in my case.
Title: Re: Calendar mods
Post by: 2Ntense on May 10, 2008, 12:44:33 PM
Here's a crude fix for the error.  It works, but there's probably a nicer way to do it.

in $sources/BoardIndex.php
find:
$this_event['can_edit'] = allowedTo('calendar_edit_any') || ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own'));


replace with:
if($context['user']['is_logged'])
$this_event['can_edit'] = allowedTo('calendar_edit_any') || ($this_event['poster'] == $ID_MEMBER && allowedTo('calendar_edit_own'));


The problem is that it's checking for permissions to see if a GUEST can edit the calendar event.  By adding if($context['user']['is_logged']) it skips the check if they're not logged in.

BTW, this is for current SMF 1.1.5 sources, but should work with earlier versions.
Title: Re: Calendar mods
Post by: Jumpmasterrt on May 27, 2008, 01:41:19 AM
2Ntense, did you make mods to the original package or just to your install and then post the fixes here?

If you wouldn't mind, could you mod the package with your fixes and resubmit with the caveat you placed above?

Or, send it to me and I'll do it and look and see if it's something I can support if you or Kindred don't want to.
Title: Re: Calendar mods
Post by: seattleda on May 27, 2008, 01:20:21 PM
SMF from Mosul, eh?  8)

Hmmm - according to SMF's site (http://custom.simplemachines.org/mods/index.php?mod=655) it looks like the mod was last updated on the 15th, 6 days after 2Ntense said he'd post the changes.  So, I'm thinking maybe that's it.

Would you happen to know if this mod works with 1.1.4?  The mod page says its only compatible with 1.1.1 & 1.1.2.

Thanks!!
Title: Re: Calendar mods
Post by: Kindred on May 27, 2008, 01:50:12 PM
may 15, 2007...

(look at the year)
Title: Re: Calendar mods
Post by: seattleda on May 27, 2008, 04:20:28 PM
D'oh!  :o
Title: Re: Calendar mods
Post by: Jumpmasterrt on May 27, 2008, 08:25:20 PM
Quote from: seattleda on May 27, 2008, 04:20:28 PM
D'oh!  :o
Yeah, it's ok, it happens. LOL

Yeah, from Mosul. It was a pain to set up though because my connection is soooooo slow (256k). Once it got set up (server host did it for me) it ran like a champ.

I seem to remember someone a few pages back had it installed on 1.1.4, I'm not sure. I haven't seen any mods that work on a 1.1.1 that didn't work on all 1.1.x (of course, I could always be wrong)
Title: Re: Calendar mods
Post by: Ni©holąś™ on May 29, 2008, 10:16:05 AM
thanks!
Title: Re: Calendar mods
Post by: Akyhne on July 20, 2008, 04:53:51 AM
My log is filled with these errors when adding something in the calendar:

8: Undefined index: repeat_end_day
8: Undefined index: repeat_end_month
8: Undefined index: repeat_end_year
8: Undefined index: repeat2_parm3
..etc.

I'm running a standard 1.1.5 English SMF forum with nothing but a Youtube adding mod.
Title: Re: Calendar mods
Post by: Kindred on July 20, 2008, 07:58:39 AM
The author of this mod has disappeared and the mod has no further support.

I will be incorporating it back into the Phat Cal pack when I rebuild it for 2.0 (after RC is released), but it is doubtful that there will ever be a supported version for 1.1.5
Title: Re: Calendar mods
Post by: luvencl on July 20, 2008, 09:52:23 AM
Perfect timing.
I was just looking for a way to have a couple of weekly items repeat themeselves and send an email reminder 60 minute prior the event. Is that something that this might do?
Title: Re: Calendar mods
Post by: Akyhne on July 20, 2008, 11:18:54 AM
I know he dissapeared, but somebody might know the reason to these errors.
Title: Re: Calendar mods
Post by: Kindred on July 20, 2008, 10:11:39 PM
luvencl,

While you can set the items to repeat, neither this mod nor the one I am redesigning will send email reminders.

akyhne,

Try reading through the thread....   I believe the answer is no.
Title: Re: Calendar mods
Post by: 2Ntense on July 31, 2008, 01:48:31 PM
Weird... sorry 'bout that, I thought I'd attached the slightly cleaned-up version I'd played with earlier on in the thread, but I don't see it (attached again below).

Other than a couple of minor mistakes that I'd added in from other comments in the thread, this version is mostly just the whole original package with spaces converted to tabs so that it doesn't make the package parsers gag and choke.

I gave up in disgust on this mod 'cos there was still so much remaining to be done to make it worthwhile.  I finally chopped the whole CALENDAR out of the forum I was working on and dropped the SourceForge WebCalendar (http://sourceforge.net/projects/webcalendar/) in it's place.  It's a standalone 'events calendar' that's not interfacing with the SMF database, but at least the darned thing WORKS.  Note: the SourceForge 1.1.5 release code insists on register_globals = ON  (which my host doesn't support for obvious security reasons) so I had to run the 1.2b1 code instead.
Title: Re: Calendar mods
Post by: Ims on August 09, 2008, 11:29:44 PM
Quote from: Chris Curran on January 21, 2006, 11:14:33 AM
Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=655)



Hi, Hello:

I'm a new SMF user. I dl'ed and installed 1.1 RC2 a few days ago and so far no troubles.

One question though: I needed a calendar app that allowed repeating events - the span thing just didn't cut it for our needs (an astro club). I took a theme from Bloc (Black22) and modified the Post.template.php and Calendar.template.php files as needed, however, due to the addition fields I'm using I needed to modify the calendar table structure (added columns) and the Post.php and Calendar.php files (to support the new columns related to repeating events).

Here's the question: How do I share these mods with the rest of the community? Since my mods are not limited to the "template" files I'm not sure what to do. Diff files? Is there a cvs this can be posted to? What question am I forgetting to ask? Sorry if I've missed a document that covers this - I poked around and don't see anything obvious...

salute and happy days,
Chris Curran

A cropped screen-print of the mod:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.stpeteastronomyclub.org%2Fimages%2FeditEvent.jpg&hash=5554e0e94fb8bd4847a4850c1e5e8d48329aa19b)
??? ??? ??? ??? ??? ??? ???

I'm Thai
Title: Re: Calendar mods
Post by: [SiNaN] on August 10, 2008, 09:55:18 AM
If you have difficulties in understanding English, try our Language Support Boards:

http://www.simplemachines.org/community/index.php?board=12.0
Title: Re: Calendar mods
Post by: Kindred on August 11, 2008, 02:46:09 PM
but, to answer the question I ASSUME you were asking with that completely out of context quote...


The repeating events mod is currently dead.

I intend to re-write is when SMF 2.0 RC is released.
Title: Re: Calendar mods
Post by: Akyhne on August 11, 2008, 02:47:57 PM
That would be really great
Title: Re: Calendar mods
Post by: Smoothbrain on September 15, 2008, 12:00:25 PM
Hi I just uploaded this mod and I realize the author is not supporting any more but I have a question about cal mods in general.  Does anyone know of a way to add the time to your calendar?  For example, I want an event to start a certain time, how do I input that in? Thanks for any and all help in advance.
Title: Re: Calendar mods
Post by: Kindred on September 15, 2008, 12:51:53 PM
you can not without re-coding...   Please ask in the smf coding board if yo have the capability to do it yourself.
Title: Re: Calendar mods
Post by: Smoothbrain on September 15, 2008, 02:07:40 PM
Thank you.
Title: Re: Calendar mods
Post by: EkSeS on October 02, 2008, 11:23:44 PM
Quote from: Kindred on July 20, 2008, 07:58:39 AM
...
I will be incorporating it back into the Phat Cal pack when I rebuild it for 2.0 (after RC is released), but it is doubtful that there will ever be a supported version for 1.1.5


   
have you for SMF x 2 Beta?
I would like to "test" it ;)
Title: Re: Calendar mods
Post by: Kindred on October 03, 2008, 07:53:13 AM
Quote from: Kindred on July 20, 2008, 07:58:39 AM
... when I rebuild it for 2.0 (after RC is released)
Title: Re: Calendar mods
Post by: brtz on October 22, 2008, 01:52:28 PM
Excuse me for the bump, but i was wondering if the 'attendees' function is in this mod?Or is it something that might come?

Asking since someone talked about it in this topic
http://www.simplemachines.org/community/index.php?topic=66939.msg1093187;topicseen#msg1093187 :)
Title: Re: Calendar mods
Post by: Kindred on October 22, 2008, 03:12:07 PM
I am considering it for the 2.0 release of the phatCalPack
Title: Re: Calendar mods
Post by: brtz on October 22, 2008, 04:25:20 PM
ok, thanks for the heads up. Really looking forward to it :)
Title: Re: Calendar mods
Post by: SNewman on November 06, 2008, 12:14:04 PM
It would be AWESOME if someone could update this for SMF 2.0 Beta 4.  I've tried the manual install instructions but it doesn't work...too much has changed from SMF 1 to SMF 2.
Title: Re: Calendar mods
Post by: Kindred on November 06, 2008, 08:23:30 PM
I will not be releasing this until 2.0RC1 is released. I will not be making a version for beta4
Title: Re: Calendar mods
Post by: PhatTyres on November 07, 2008, 11:25:42 PM
Quote from: Kindred on November 06, 2008, 08:23:30 PM
I will not be releasing this until 2.0RC1 is released. I will not be making a version for beta4

No disrespect Kindred (your time and work is appreciated)...

How likely is the revamp of the Phat Cal Pack for 2.0?

I was holding my breath for over a year for the 1.1 revamp...finally gasped for air and gave up

Held on to my 1.0 forum until last week just to keep the Phat Cal Pack, finally gave up and upgraded the forum to keep the spam registrations away!

I really miss the Phat Cal.

Thanks,
Dan
Title: Re: Calendar mods
Post by: Kindred on November 08, 2008, 12:25:30 PM
I *WILL* be making a version for 2.0, once RC1 is released. I have half of the code working on my RC1 beta test. :)

I never updated for 1.1 because Chris Curran has released something (but then he disappeared. :( ) and then we (SMF Team) started work on 2.0, which changes all of the code structures.

So, it is coming.
Title: Re: Calendar mods
Post by: QueenTiye on December 26, 2008, 12:20:32 AM
Is this event current for SMF 1.1.7?  I'm wanting a mod to add religious holidays to the calendar beyond what's there - and I'd like them to repeat when they can. 

Doable?

QT
Title: Re: Calendar mods
Post by: Kindred on December 26, 2008, 09:07:21 AM
did you even read any of the previous posts?


No, this will not work for 1.1.7.
No, there will be no version for 1.1.7.
I will release a new version when 2.0RC1 is released.
Title: Re: Calendar mods
Post by: Galedon on January 21, 2009, 05:40:47 AM
Quote from: Kindred on December 26, 2008, 09:07:21 AM
did you even read any of the previous posts?


No, this will not work for 1.1.7.
No, there will be no version for 1.1.7.
I will release a new version when 2.0RC1 is released.

question:

have the mod a signup function for event´s ?!

and can i test this version ;)

great
Title: Re: Calendar mods
Post by: Kindred on January 21, 2009, 05:22:12 PM
when RC1 is stable and released, I will be re-releasing the PhatCalPack

This includes
Attendees
recurring events
Import/export holiday management
Title: Re: Calendar mods
Post by: Galedon on January 22, 2009, 12:38:02 AM
Quote from: Kindred on January 21, 2009, 05:22:12 PM
when RC1 is stable and released, I will be re-releasing the PhatCalPack

This includes
Attendees
recurring events
Import/export holiday management

ok - and when comes the RC1 ?!

any idea ?




Title: Re: Calendar mods
Post by: NEMINI on January 22, 2009, 12:46:58 AM
Quote from: Galedon on January 22, 2009, 12:38:02 AM


ok - and when comes the RC1 ?!

any idea ?

when its ready?

RC1 is in the hands of Charter members already so it shouldn't be too long.  though I know of at least one major bug that needs to be fixed (again) before its released publicly.
Title: Re: Calendar mods
Post by: Onicat on February 04, 2009, 05:38:43 PM
To current. I have done everything I can think of including going through 1 by 1 adding the mods with no errors. It seems that once they are all in though I start to have errors.

I have not updated the Database on my test site to the one I am using on the main site as I want to get these issues worked out first.

Quote
Modification Packages
   Mod Name   Version
1.   SMF Gallery Lite   1.9.4
2.   Repeating Calendar Events v1.2.6   1.2.6
3.   Contact Page   1.1
4.   SMF Links   1.7
5.   SMF 1.0.15 / 1.1.7 Update   1.0
6.   Favicon   1.2
7.   Reg Bar   1.0.2
8.   Auto Embed Video/Audio Clips   3.1.2
9.   Stars And Badges   2.1
10.   Global Headers Footers   1.4.1
11.   TinyPortal   1.063
12.   Age and Gender Board Filter   1.2.1
13.   SMF Staff Page   1.6


Here are the current errors I am having with out using the Database from the Main site.

QuoteQuote
8: Undefined variable: bullet
File: /home/akcommunity/public_html/Themes/default/TPortal.template.php (tp_above sub template - eval?)
Line: 423

8: Undefined variable: bullet
File: /home/akcommunity/public_html/Themes/default/MessageIndex.template.php (tp_above sub template - eval?)
Line: 423

8: Undefined variable: bullet
File: /home/akcommunity/public_html/Themes/default/Post.template.php (tp_above sub template - eval?)
Line: 423

8: Undefined index: repeat_end_year
File: /home/akcommunity/public_html/Sources/Post.php
Line: 314

8: Undefined index: repeat_end_day
File: /home/akcommunity/public_html/Sources/Post.php
Line: 313

8: Undefined index: repeat_end_month
File: /home/akcommunity/public_html/Sources/Post.php
Line: 312

8: Undefined index: repeat_end_type
File: /home/akcommunity/public_html/Sources/Post.php
Line: 311

8: Undefined index: repeat2_parm3
File: /home/akcommunity/public_html/Sources/Post.php
Line: 310

8: Undefined index: repeat2_parm2
File: /home/akcommunity/public_html/Sources/Post.php
Line: 309

8: Undefined index: repeat2_parm1
File: /home/akcommunity/public_html/Sources/Post.php
Line: 308

8: Undefined index: repeat1_parm2
File: /home/akcommunity/public_html/Sources/Post.php
Line: 307

8: Undefined index: repeat1_parm1
File: /home/akcommunity/public_html/Sources/Post.php
Line: 306

I am thinking the first three are being created because of the Calendar Mod.


I am sure the "repeat" ones have to do with the "   Repeating Calendar Events v1.2.6"

I just can't figure out why I am the only one having these issues....

I have tried posting on the SMF and TP website, but I keep getting bounced back and fourth. Frustrating as that is, I still want to get my site running correctly. After a long while I decided to come back to it and try it again. Any help or advise would be appreciated.

Once I have these issues worked out I want to transfer the Database of the main site over to my test site and work from there.

I have a good plan I am just having trouble getting there.

On a side note does anybody know any good open source  Database comparison programs.

Thanks.

~Oni

I will be glad to supply any other information that is needed.
Title: Re: Calendar mods
Post by: Kindred on February 04, 2009, 05:41:38 PM
1- this mod is no longer supported and was never designed for 1.1.7

2- this mod will never be supported for the 1.1.x series any more.

3- I am working on a version of this mod for 2.0. I estimate 3-4 weeks.
Title: Re: Calendar mods
Post by: Onicat on February 04, 2009, 05:51:42 PM
Thanks very much for the input that solves most likely a lot of my problems right there. 

I can't wait for the 2.0 release.
Title: Re: Calendar mods
Post by: Galedon on February 05, 2009, 02:05:40 AM
Quote from: Kindred on January 21, 2009, 05:22:12 PM
when RC1 is stable and released, I will be re-releasing the PhatCalPack

This includes
Attendees
recurring events
Import/export holiday management

RC1 is out :D

Can i now test your mod !?

please :(
Title: Re: Calendar mods
Post by: Kindred on February 05, 2009, 02:17:16 AM
Quote from: Kindred on February 04, 2009, 05:41:38 PM
3- I am working on a version of this mod for 2.0. I estimate 3-4 weeks.


why do people not read?
Title: Re: Calendar mods
Post by: ceewee on February 08, 2009, 03:12:32 PM
Quote from: Kindred on February 04, 2009, 05:41:38 PM
1- this mod is no longer supported and was never designed for 1.1.7

2- this mod will never be supported for the 1.1.x series any more.

3- I am working on a version of this mod for 2.0. I estimate 3-4 weeks.

Mod: chris currian  repeateventmoonphase mod

This mod works for me in 1.1.7 and 1.1.8 (have 5 smf's and tested this in smf with already 65 mods installed)
Title: Re: Calendar mods
Post by: Akyhne on February 08, 2009, 05:14:01 PM
... but it doesn't work for me and a lot of other people. As I remember I got a huge amount of errors showing up in the error log.
Title: Re: Calendar mods
Post by: Galedon on February 16, 2009, 04:45:41 AM
Quote from: Kindred on February 05, 2009, 02:17:16 AM
Quote from: Kindred on February 04, 2009, 05:41:38 PM
3- I am working on a version of this mod for 2.0. I estimate 3-4 weeks.


why do people not read?

ok - sorry :(

Question:
the calendar now have only the function that i can change the year/month/day
Can i with your mod to insert a time - start / end time for a event ?!

thx
Title: Re: Calendar mods
Post by: Kindred on February 16, 2009, 07:47:16 AM
right now, I have the start time as a free test field (i.e. you can MARK the start/end time, but it has no effect on sort or anything like that)
Title: Re: Calendar mods
Post by: Bobn on February 22, 2009, 09:56:14 AM
Hi,

Seems as though this mod wont allow choosing of the default board for new additions. Anybody know a work around?
Title: Re: Calendar mods
Post by: Kindred on February 22, 2009, 10:12:05 AM
Quote from: Kindred on February 04, 2009, 05:41:38 PM
1- this mod is no longer supported and was never designed for 1.1.7
Title: Re: Calendar mods
Post by: Bobn on February 22, 2009, 10:38:01 AM
Quote from: Kindred on February 22, 2009, 10:12:05 AM
Quote from: Kindred on February 04, 2009, 05:41:38 PM
1- this mod is no longer supported and was never designed for 1.1.7

Thanks, is there another working mod like this?
Title: Re: Calendar mods
Post by: Jukka Ahonen on March 02, 2009, 08:33:54 AM
Any updates on this one? Im desperately seeking attendance function for our calendar, as monitoring attendance from threads gets more than a bit messy when you have 3-4 weekly recurring events... (its essentially a calendar for a sports team, and we need to know who is going to attend which practice etc)
Title: Re: Calendar mods
Post by: [elenor] on March 06, 2009, 08:30:17 AM
rc1 ?
Title: Re: Calendar mods
Post by: EkSeS on March 09, 2009, 12:45:55 AM
Quote from: Kindred on February 04, 2009, 05:41:38 PM
1- this mod is no longer supported and was never designed for 1.1.7

2- this mod will never be supported for the 1.1.x series any more.

3- I am working on a version of this mod for 2.0. I estimate 3-4 weeks.

We still waiting for you  ;)
Title: Re: Calendar mods
Post by: Knome on March 23, 2009, 05:15:41 AM
Well the manual install instructions do not work. Any updates yet? 
Title: Re: Calendar mods
Post by: dgali on March 30, 2009, 02:05:07 PM
is there any news on when this might be done? i've ready everything around that i could find on this, and am just wondering about an update.

any additional information would be helpful and appreciated.

thank you!

dgali
Title: Re: Calendar mods
Post by: rgarrison on March 30, 2009, 06:11:02 PM
Has there been any progress on this mod for 2.0 
Title: Re: Calendar mods
Post by: Kindred on March 30, 2009, 08:34:14 PM
I was working on it.... but I ran into a glitch and then real life happened.   I plan to pick this back up this week.
Title: Re: Calendar mods
Post by: aragornelessar86 on March 31, 2009, 10:48:50 PM
Quote from: Kindred on March 30, 2009, 08:34:14 PM
I was working on it.... but I ran into a glitch and then real life happened.   I plan to pick this back up this week.
You're a god Kindred. I would love to get my hands on this mod. I run a forum for an airsoft team and it would be awesome to be able to track who's going and who's not.
Title: Re: Calendar mods
Post by: RustyBarnacle on April 07, 2009, 06:57:55 PM
Oooh, another mod for 2.0 only that I really want.
Title: Re: Calendar mods
Post by: Galedon on April 08, 2009, 03:08:59 AM
Quote from: RustyBarnacle on April 07, 2009, 06:57:55 PM
Oooh, another mod for 2.0 only that I really want.

i too :D
Title: Re: Calendar mods
Post by: casevos on April 08, 2009, 09:35:43 AM
Hi Thanks for this mod--does it work with smf 2.0?

Title: Re: Calendar mods
Post by: aragornelessar86 on April 08, 2009, 03:02:48 PM
Quote from: casevos on April 08, 2009, 09:35:43 AM
Hi Thanks for this mod--does it work with smf 2.0?
Please, read the thread a little before posting.

However, I'll be nice and answer anyway. At this point, no, it doesn't work with 2.0. However, Kindred is working to get it compatible.

Like I said, read the thread before posting. It'll probably answer your question.
Title: Re: Calendar mods
Post by: Bobn on April 29, 2009, 06:55:54 AM
Hello,

For some reason the calendar mod will not allow me to force a default board when checked with version 1.8

Using 1.8
I set the board to default in the calendar settings but it always goes to the first board in the list.
If I check force default board I get this error:
Board ID is missing.
Title: Re: Calendar mods
Post by: Bobn on April 29, 2009, 07:01:31 PM
Anybody know why this is?
Title: Re: Calendar mods
Post by: aragornelessar86 on April 29, 2009, 08:30:22 PM
Quote from: Bobn on April 29, 2009, 06:55:54 AM
Hello,

For some reason the calendar mod will not allow me to force a default board when checked with version 1.8

Using 1.8
I set the board to default in the calendar settings but it always goes to the first board in the list.
If I check force default board I get this error:
Board ID is missing.
Sounds like it's having trouble finding the board you're telling it to default to. Might be a DB issue? Could also be a spelling or capitalization mismatch. I'd check both of those first thing.
Title: Re: Calendar mods
Post by: Bobn on April 29, 2009, 08:35:21 PM
Quote from: aragornelessar86 on April 29, 2009, 08:30:22 PM
Quote from: Bobn on April 29, 2009, 06:55:54 AM
Hello,

For some reason the calendar mod will not allow me to force a default board when checked with version 1.8

Using 1.8
I set the board to default in the calendar settings but it always goes to the first board in the list.
If I check force default board I get this error:
Board ID is missing.
Sounds like it's having trouble finding the board you're telling it to default to. Might be a DB issue? Could also be a spelling or capitalization mismatch. I'd check both of those first thing.

Dont know how to check the DB and the board shows in the pull down list and is highlighted.
Title: Re: Calendar mods
Post by: casevos on May 01, 2009, 12:16:17 AM
Quote from: Kindred on March 30, 2009, 08:34:14 PM
I was working on it.... but I ran into a glitch and then real life happened.   I plan to pick this back up this week.

Hi Kindred--is there any beta code we can work on or futz with....
Title: Re: Calendar mods
Post by: Bobn on May 04, 2009, 03:02:54 PM
Quote from: Bobn on April 29, 2009, 08:35:21 PM
Quote from: aragornelessar86 on April 29, 2009, 08:30:22 PM
Quote from: Bobn on April 29, 2009, 06:55:54 AM
Hello,

For some reason the calendar mod will not allow me to force a default board when checked with version 1.8

Using 1.8
I set the board to default in the calendar settings but it always goes to the first board in the list.
If I check force default board I get this error:
Board ID is missing.
Sounds like it's having trouble finding the board you're telling it to default to. Might be a DB issue? Could also be a spelling or capitalization mismatch. I'd check both of those first thing.

Dont know how to check the DB and the board shows in the pull down list and is highlighted.

Anybody?
Title: Re: Calendar mods
Post by: Kindred on May 04, 2009, 06:12:32 PM
Chris has not been an active user here for a LONG time...   And I never got his mod to fully work...   so I think the best answer is "no one right now knows the answer".

As for the 2.0 version...   yes, I know I keep syaing "just around the corner" but I am sitting down eahc evening this week to actively work on it. For real.
Title: Re: Calendar mods
Post by: Crossfire2142 on May 12, 2009, 05:52:51 PM
I have successfully modified the original recurring events mod to work on SMF2 (RC1), and will package it up so others can have it soon :)
Title: Re: Calendar mods
Post by: EkSeS on May 25, 2009, 02:18:29 PM
What's happen with this mod now? Who and when make it anyone?
Title: Re: Calendar mods
Post by: WDT_Elwood on June 04, 2009, 03:33:04 PM
Yes, recurring events would be awesome! ASAP! I'll paypal you some beer money if it will help.

Would it be difficult to also include an "RSVP" function so users coudl easily indicate they would be attending?
Title: Re: Calendar mods
Post by: darth_dionysus on June 22, 2009, 10:45:58 AM
Quote from: Crossfire2142 on May 12, 2009, 05:52:51 PM
I have successfully modified the original recurring events mod to work on SMF2 (RC1), and will package it up so others can have it soon :)

Any update on this?
Title: Re: Calendar mods
Post by: lochnar on July 12, 2009, 03:02:17 PM
Hi, I'm receiving an error message (Undefined index: event), and it may be related to the "Repeating Calendar Events v1.2.6" mod.

Please see this topic I created in the 1.1.X support board:

http://www.simplemachines.org/community/index.php?topic=323400.msg2155643#msg2155643

Please see attachments.

Here is the code being flagged in post.template.php:

620:                                                                  $subj = $context['subject'] == '' ? $context['event']['title'] : $context['subject'];

882:      if ($context['event']['repeating']=='0')
Any insight or advice is greatly appreciated!

Thanks.
Title: Re: Calendar mods
Post by: Kindred on July 12, 2009, 03:08:54 PM
there are a lot of problems with the current version of this mod (plus the "current" version is ancient)

the author has disappeared.... and I have not yet completed my update for the functionality (which will only be done for 2.0 when I am done)
Title: Re: Calendar mods
Post by: sepulchre on July 23, 2009, 04:34:45 AM
looking forward to seeing this make it to 2.0  8)
Title: Re: Calendar mods
Post by: mandukar on August 13, 2009, 05:41:00 AM
is there any news yet on the progress for this for 2.0 RC1.2
Title: Re: Calendar mods
Post by: george_park on August 17, 2009, 02:04:06 PM
Very interested in an RSVP feature as well, would like to hear an update too.

I would also like to see something that can collect feedback after an event (just a simple question or poll for instance).

This will be a great addition to the calendar in SMF, one of the reasons I ditched my other forum software... last thing needed is rsvp (and maybe event categories, etc.).

Regards,
gp
Title: Re: Calendar mods
Post by: darth_dionysus on August 17, 2009, 02:20:40 PM
The only thing I need is the recurring events for 2.0 RC1.2. That would make me a very happy camper, indeed.

I would think that would be built in already, but I guess maybe it's not important enough to put into the new build.
Title: Re: Calendar mods
Post by: mandukar on August 18, 2009, 04:03:40 AM
Quotewould think that would be built in already, but I guess maybe it's not important enough to put into the new build.
in 2.0 and above they do  have a smaller ver of the calendar but its only days, not months or weeks etc.
Title: Re: Calendar mods
Post by: darth_dionysus on August 18, 2009, 08:00:53 AM
Quote from: mandukar on August 18, 2009, 04:03:40 AM
Quotewould think that would be built in already, but I guess maybe it's not important enough to put into the new build.
in 2.0 and above they do  have a smaller ver of the calendar but its only days, not months or weeks etc.

In my SMF 2.0 RC1.2 forum I have the full calendar, showing a full month, with the preceding and following month as well, just like I had in my ver 1 forum.  Only birthdays and holidays are considered as recurring events.  As it is now I have to enter all other events I want to reoccur as holidays so I can have them repeat every year.
Title: Re: Calendar mods
Post by: varmandra on September 11, 2009, 05:02:35 PM
Quote from: mandukar on August 18, 2009, 04:03:40 AM
Quotewould think that would be built in already, but I guess maybe it's not important enough to put into the new build.
in 2.0 and above they do  have a smaller ver of the calendar but its only days, not months or weeks etc.
I don´t find it, there is no repeating, only event for more than one day. there is nothing like "every day" or "every week"

BdT
Varmandra
Title: Re: Calendar mods
Post by: mandukar on September 12, 2009, 01:51:22 PM
you mean every other day or week?.

Title: Re: Calendar mods
Post by: varmandra on September 13, 2009, 08:06:35 AM
I have a SMF2.12 without any mod, and on the attached picture you can see there is no repeating.

Only Title, Date, Number of Days, Post in, Subject,....so no repeating, so we still have to wait for a mod update :)
Title: Re: Calendar mods
Post by: shoepixie on October 06, 2009, 07:11:00 PM
Just a quick note: I'm yet one another user that would LOVE to see this mod succeed!  So far I haven't been able to find anything that increases the functionality of the calendar, and I'd love to be able to do more with it.  Repeating events would be fantastic, as would events that reminded people that they existed, somehow.  I'm not sure how any of that would happen - I'm not a coder - but if anyone's working on it, I'd be happy to be a tester and offer feedback!
Title: Re: Calendar mods
Post by: Achilleas on October 13, 2009, 02:58:28 PM
Any new about this mod???
Title: Re: Calendar mods
Post by: mandukar on October 27, 2009, 01:05:22 PM
echo's Achilleas ??
Title: Re: Calendar mods
Post by: kiel on November 28, 2009, 10:05:06 AM
For my sins I'll be updating this mod for 2.0 RC1.2.

Similarily I need Moonphases and reoccuring events not for astronomy but for astrology and Esbats, festivals and events - I administrate a community of Pagans in Birmingham, UK: www dot pagancentral dot org

If anyone would like to collaborate on this project, feel free to email me at [email protected]
Title: Re: Calendar mods
Post by: Arantor on November 28, 2009, 10:16:34 AM
Just a word of advice: you won't be able to publish it on the SMF mod site unless it works on the current versions at the time, i.e. 2.0 RC2 or 1.1.10.
Title: Re: Calendar mods
Post by: mandukar on December 01, 2009, 04:37:24 PM
it would be nice to see it appear in the mod list, I know a lot of people would like to see it too.
Title: Re: Calendar mods
Post by: _sebas_ on December 04, 2009, 07:30:49 AM
hi,
I have a mystery to solve,
Why on the calendar times of lunar phenomena, was obtained with a systematic advancement of 7 hours?

just have to insert table from code "repeatEvents_modifyTables.php", why it fails?
Title: Re: Calendar mods
Post by: Garry1953 on December 10, 2009, 11:01:44 PM
I'm also in favour of Repeating Events for SMF 2.0

I run an Art Forum, and we have annual listings of competitions and shows, and some Bi-Annual events also.
Title: Re: Calendar mods
Post by: _sebas_ on December 31, 2009, 02:26:38 AM

hi !

in advice display board index:

Lunar events disappears in current day of phase.

Title: Re: Calendar mods
Post by: Joff on January 24, 2010, 03:53:19 PM
How are the displayed events sorted?

I have added three events to a day in this format:

10.30am - Family Service
4.30pm - AGM
6pm - Worship and the Word

It doesn't seem to matter in what order I enter them, 4.30pm always appears as the first entry! I want it to display in order of time.
Title: Re: Calendar mods
Post by: Bobn on March 04, 2010, 05:46:49 AM
Anyone having trouble with this mod not allowing some posts to be seen when using SSI? I have a page linked to the board where the calendar posts to and everything is fine then for some unknown reason when an event is posted it causes the SSI to only read a partial list of events.
Title: Re: Calendar mods
Post by: _sebas_ on March 08, 2010, 05:52:43 PM

this mod is little dangerouse
Title: Re: Calendar mods
Post by: Kindred on March 08, 2010, 07:18:46 PM
Quote from: sebtor on March 08, 2010, 05:52:43 PM

this mod is little dangerouse

???
Title: Re: Calendar mods
Post by: nivlac on March 11, 2010, 08:16:57 PM
Where did all the time go?
Quote« Reply #417 on: May 04, 2009, 06:12:32 PM »
Chris has not been an active user here for a LONG time...   And I never got his mod to fully work...   so I think the best answer is "no one right now knows the answer".

As for the 2.0 version...   yes, I know I keep syaing "just around the corner" but I am sitting down eahc evening this week to actively work on it. For real.

« Reply #423 on: July 12, 2009, 03:08:54 PM »
there are a lot of problems with the current version of this mod (plus the "current" version is ancient)

the author has disappeared.... and I have not yet completed my update for the functionality (which will only be done for 2.0 when I am done)

"Time flies like an arrow. Fruitflies like banana." :P

Any word on your progress with this mod Kindred? (He asked, as Kindred resists the urge to scream.) No sweat, I know how life can creep up on you and the next thing you know a year has gone by.

My forum Administrator wanted to upgrade to 2.0 RC2, which I did, and now... you guessed it. We were using the "Repeating Events" calendar mod, even though it was a little buggy with SMF 1.1.11. So now she says, "All the birthdays I put in the calendar and made repeating are gone!" No, says I. They're still there in the database, you just can't see them because the mod isn't updated yet, but there is a person working on it, you just have to wait because he also works for a living and that comes first. So that's my reason for asking.

I wish I could offer some help, but I know just enough PHP to drive me insane and accidently pull data from alternate realities. It has to be, because no one can understand it.

And, I just want to say, I truly appreciate people such as yourself that do the thing you do to make our lives as forum owners, administrators and webmasters easier. Atta boy!

Thanks...
Title: Re: Calendar mods
Post by: Kindred on March 11, 2010, 09:20:49 PM
I had this partially working with RC1...  then RC2 went and changed everyting and the SMF staff blow-up happened.
The last few months have been full of me managing the SMF project itself and I have had no time to code even my more simple mods up to RC2 standards.

If someone else with coding knowledge wants to take over this mod, I consider Chris to have abandoned it and I offer my interest in it to someone who is willing to take it over. Otherwise, I will re-start work on this in about a month or so.
Title: Re: Calendar mods
Post by: nivlac on March 11, 2010, 10:00:10 PM
Thanks Kindred. It grieves me that all that drama is going on over SMF. :(  I don't personally know anyone involved and I'm not saying those at the root of the problems are bad people either, but sometimes people tend to get themselves caught up in things because they allow things like power, pride or greed to keep them from being a better person.

Based on what I've read here and on other sites, it seems that some need to realize that the issues in their personal world are insignificant because the reality is that their actions affect the thousands of users that have come to love SMF in the real world. The users and the team are in a symbiotic relationship and each group can cause the other group to die off. As the Star Trek character Spock said, "...logic clearly dictates that the needs of the many outweigh the needs of the few." Magnanimousness is needed in this instance, and not megalomania.

May I recommend live627 as a possible candidate to take over the repeating events mod? I was trying to get a password on registration mod updated to 2.0 RC2 which had similar circumstances in which the author had seemingly abandoned the mod, and live627 coded a new mod from scratch which provided the needed function. However, I don't know his schedule or if he would be interested in taking it over. Perhaps you could PM him and inquire.
Title: Re: Calendar mods
Post by: TheDragon on March 16, 2010, 04:59:09 PM
Quote from: Joff on January 24, 2010, 03:53:19 PM
How are the displayed events sorted?

I have added three events to a day in this format:

10.30am - Family Service
4.30pm - AGM
6pm - Worship and the Word

It doesn't seem to matter in what order I enter them, 4.30pm always appears as the first entry! I want it to display in order of time.

2 possible solutions:

#1, use Military time
#2. preface each time with an index
eg
1 10.30am - Family Service
2 4.30pm - AGM
3 6pm - Worship and the Word
Title: Re: Calendar mods
Post by: CiQ on April 08, 2010, 05:30:43 PM
yo.
fast recode of "Repeating Events for Calendar" done. 3 hrs of my life  :'(
test pls and tell me about bugs.
Title: Re: Calendar mods
Post by: Kindred on April 08, 2010, 07:33:37 PM
please submit that to the mod site?\ so that it can be validated by the mod team and provided in its own thread?
Title: Re: Calendar mods
Post by: Arantor on April 08, 2010, 07:39:50 PM
If it's an update of an existing mod it will require original author's permission first before it can be uploaded, but if it's a fresh rewrite it's probably OK.
Title: Re: Calendar mods
Post by: Kindred on April 08, 2010, 07:42:23 PM
Chris took the mod over from me...   and has since abandoned it...   I consider this mod fair game...
Title: Re: Calendar mods
Post by: Arantor on April 09, 2010, 03:17:56 AM
Sounds more than reasonable to me :)
Title: Re: Calendar mods
Post by: CiQ on April 09, 2010, 03:38:28 AM
i rewrite this mod for my site and i thought that others would be interested.
Title: Re: Calendar mods
Post by: Kindred on April 09, 2010, 07:55:49 AM
thank you CiQ...

Quote from: Kindred on April 08, 2010, 07:33:37 PM
please submit that to the mod site?\ so that it can be validated by the mod team and provided in its own thread?
Title: Re: Calendar mods
Post by: CiQ on April 09, 2010, 10:55:06 AM
Submited. Waiting for approve. 
Title: Re: Calendar mods
Post by: doughboy99 on April 10, 2010, 03:19:00 PM
I don't suppose the changes included making this compatible with SMF 2 did they?? ;)
Title: Re: Calendar mods
Post by: CiQ on April 10, 2010, 03:58:14 PM
only 1.1.x compatible. i don't use smf2 :)
Title: Re: Calendar mods
Post by: canadiancray on May 29, 2010, 08:16:30 AM
ANything yet for newer versions of SMF? It would seem like a no brainer to me that this should have been added right from the begining since so many other forums have this feature.
Title: Re: Calendar mods
Post by: NoBite on June 04, 2010, 08:47:52 PM
I administer a forum of Doberman dog owners. The birthdays of the forum members automatically get added to the calendar as repeating events. I have recently added two score dog birthdays to the calendar as events. There seems to be no way to make them annual repeating events. However, I suppose I could add them as Holidays, which I can make annually repeat.

I yearn for a mod that will enable repeating events, however.

I am no programmer and so will watch this topic to learn of updates to the process. Thanks to all that are programming!
Title: Re: Calendar mods
Post by: Chris Curran on October 14, 2010, 08:25:07 AM
Been fighting Prostate Cancer. That's where I "disappeared" to. This code is not "buggy" either - when run on the proper version of SMF, without a ton of other (buggy) mods installed. If you guys want it for 2.x, then dl the code and modify it (then fight with the lords to be about the position of the curly braces). I did the heavy lifting already...

Over 40? Get your PSA tested. Just effing do it.


Quote from: nivlac on March 11, 2010, 08:16:57 PM
Where did all the time go?
Quote« Reply #417 on: May 04, 2009, 06:12:32 PM »
Chris has not been an active user here for a LONG time...   And I never got his mod to fully work...   so I think the best answer is "no one right now knows the answer".

As for the 2.0 version...   yes, I know I keep syaing "just around the corner" but I am sitting down eahc evening this week to actively work on it. For real.

« Reply #423 on: July 12, 2009, 03:08:54 PM »
there are a lot of problems with the current version of this mod (plus the "current" version is ancient)

the author has disappeared.... and I have not yet completed my update for the functionality (which will only be done for 2.0 when I am done)

"Time flies like an arrow. Fruitflies like banana." :P

Any word on your progress with this mod Kindred? (He asked, as Kindred resists the urge to scream.) No sweat, I know how life can creep up on you and the next thing you know a year has gone by.

My forum Administrator wanted to upgrade to 2.0 RC2, which I did, and now... you guessed it. We were using the "Repeating Events" calendar mod, even though it was a little buggy with SMF 1.1.11. So now she says, "All the birthdays I put in the calendar and made repeating are gone!" No, says I. They're still there in the database, you just can't see them because the mod isn't updated yet, but there is a person working on it, you just have to wait because he also works for a living and that comes first. So that's my reason for asking.

I wish I could offer some help, but I know just enough PHP to drive me insane and accidently pull data from alternate realities. It has to be, because no one can understand it.

And, I just want to say, I truly appreciate people such as yourself that do the thing you do to make our lives as forum owners, administrators and webmasters easier. Atta boy!

Thanks...
Title: Re: Calendar mods
Post by: Chris Curran on October 14, 2010, 08:36:15 AM
A tool like www.reachpeople.com might be more appropriate for this use case...

Quote from: NoBite on June 04, 2010, 08:47:52 PM
I administer a forum of Doberman dog owners. The birthdays of the forum members automatically get added to the calendar as repeating events. I have recently added two score dog birthdays to the calendar as events. There seems to be no way to make them annual repeating events. However, I suppose I could add them as Holidays, which I can make annually repeat.

I yearn for a mod that will enable repeating events, however.

I am no programmer and so will watch this topic to learn of updates to the process. Thanks to all that are programming!
Title: Re: Calendar mods
Post by: Kindred on October 14, 2010, 10:22:52 AM
WOW!   Hi Chris. Sorry to hear about the cancer. Is it in remission now?

I have been busy doing SMF corporate stuff and RL myself... so I haven't gone anywhere with this code either. :)
Title: Re: Calendar mods
Post by: Chris Curran on November 10, 2010, 06:56:28 PM
Yes, I'm cancer free for six months now. :) Problem is that the cure is almost as bad as the disease. :( It's physically brutal.

I will not be doing anything with this code for SMF. The model used here is, uh, "broken" and I don't feel like fighting with kids who think they know how to code better than everyone else. Patching source code to implement addon's is problematic at best...

Over 40? Get your PSA tested. It's a blood test. No finger up the rear. Don't be a puss - do it.

Quote from: Kindred on October 14, 2010, 10:22:52 AM
WOW!   Hi Chris. Sorry to hear about the cancer. Is it in remission now?

I have been busy doing SMF corporate stuff and RL myself... so I haven't gone anywhere with this code either. :)

Title: Re: Calendar mods
Post by: Snaky_Love on November 22, 2010, 09:33:24 AM
hi,

I would like to recheck here - i need iCal for the forum calendar - is there somewhere a mod that does it?

Thanks!

Title: Re: Calendar mods
Post by: Kindred on November 22, 2010, 09:37:12 AM
not currently
Title: Re: Calendar mods
Post by: Huskyteer on January 10, 2011, 10:10:07 AM
I hope some kind person does code this for version 2 - it would be incredibly useful for me.
Title: Re: Calendar mods
Post by: Thomllama1 on June 29, 2011, 11:03:41 AM
Quote from: Huskyteer on January 10, 2011, 10:10:07 AM
I hope some kind person does code this for version 2 - it would be incredibly useful for me.

this was very helpful to our non profit site before upgrading to 2.0 gold...  :-\  Wish someone would edit/rewrite it!!  honestly I think it should be part of the main code for the forum software but the calendar isn't a high priority so I can see why it isn't
Title: Re: Calendar mods
Post by: Kindred on June 29, 2011, 11:26:29 AM
Well, Calendar enhancements ARE on the schedule for future releases, although, currently, the plan it to remove the calendar as a standard function (only about 50% of the sites use the calendar) and the release an "official" plugin with several enhancements.

Recurring Events, Sign Up/Attendance, and time-of-day are three of the most requested enhancements.
Title: Re: Calendar mods
Post by: Thomllama1 on June 29, 2011, 11:34:59 AM
Quote from: Kindred on June 29, 2011, 11:26:29 AM
Well, Calendar enhancements ARE on the schedule for future releases, although, currently, the plan it to remove the calendar as a standard function (only about 50% of the sites use the calendar) and the release an "official" plugin with several enhancements.

Recurring Events, Sign Up/Attendance, and time-of-day are three of the most requested enhancements.

So the calendar it's self would be a plug in, but would have all those features?  sounds good to me.. i know it's hard to say, but got a general time frame? this yr? :-\
Title: Re: Calendar mods
Post by: Kindred on June 29, 2011, 11:57:47 AM
sorry...   we don't release any sort of release dates for the reason that this is a volunteer project and people may or may not get to things quickly (or slowly)

I'd LIKE to see it this year, but I am not committing the devs to anything.
Title: Re: Calendar mods
Post by: toolbox on September 23, 2011, 10:09:43 AM
Quote from: Kindred on June 29, 2011, 11:26:29 AM
Well, Calendar enhancements ARE on the schedule for future releases, although, currently, the plan it to remove the calendar as a standard function (only about 50% of the sites use the calendar) and the release an "official" plugin with several enhancements.

Recurring Events, Sign Up/Attendance, and time-of-day are three of the most requested enhancements.

That would be good to see as we use the calendar for our club forum and members use this alot.
Title: Re: Calendar mods
Post by: demlak on January 15, 2013, 12:44:33 PM
Quote from: Kindred on June 29, 2011, 11:26:29 AM
Well, Calendar enhancements ARE on the schedule for future releases, although, currently, the plan it to remove the calendar as a standard function (only about 50% of the sites use the calendar) and the release an "official" plugin with several enhancements.

Recurring Events, Sign Up/Attendance, and time-of-day are three of the most requested enhancements.

is this still in progress? are developers still looking for seperating the calendar to a mod/plugin? and of course the enhancements =)
Title: Re: Calendar mods
Post by: Arantor on January 15, 2013, 12:51:07 PM
It's still there in 2.1 at present. Converting it to a plugin is a very huge task, probably greater than most would suspect.
Title: Re: Calendar mods
Post by: demlak on January 15, 2013, 05:58:19 PM
2.1 *grml*
i don´t wanna wait a year or so =)
Title: Re: Calendar mods
Post by: Arantor on January 15, 2013, 06:00:04 PM
Do you know how much effort it would take to make it into a plugin? (Assuming SMF had a sane plugin interface, which at this time, it does not)
Title: Re: Calendar mods
Post by: demlak on January 16, 2013, 09:35:13 AM
i can imagine...
but.. world-freedom is also a difficult thingy.. but i like it to get it tomorrow =)
whatever.. i know what you mean..
Title: Re: Calendar mods
Post by: Arantor on January 16, 2013, 09:47:17 AM
I'm not sure you do know what I mean.

I'm probably going to get hell for this, but so be it. http://wedge.org/pub/feats/6108/new-revs/msg270482/#msg270482 is where I documented how much change had occurred in removing it from an SMF fork. And that's just literally the changelog entry - it's even more massive than that in practice, and remember you still have to have the infrastructure to support it being pluggable after that.

SMF 2.1 is better but IMO it still doesn't have the infrastructure to properly handle plugins, too much work is still required by plugins to achieve anything.

And I wouldn't say that I was new to SMF's code or anything...
Title: Re: Calendar mods
Post by: mickjav on August 08, 2021, 09:22:44 AM
Does This mod work with 2.0.18 As would be exactly what I need for my Artists sections.

don't know if I need the moon part though

It does parse but a very big mod from the looks of it?

thanks mick
Title: Re: Calendar mods
Post by: shadav on August 08, 2021, 01:36:57 PM
Quote from: mickjav on August 08, 2021, 09:22:44 AM
Does This mod work with 2.0.18 As would be exactly what I need for my Artists sections.

don't know if I need the moon part though

It does parse but a very big mod from the looks of it?

thanks mick

as per the mod page, no
QuoteCompatible With:
1.1.1, 1.1.2
the calendar already allows you to add an event for every year
Title: Re: Calendar mods
Post by: mickjav on August 08, 2021, 02:15:20 PM
Was wonder but i selected 2.0.18 and it parsed

Just Looked It does allow admin but not allow other members.

maybe I could create a page that allows selected groups to add to that list?

mick
Title: Re: Calendar mods
Post by: shadav on August 08, 2021, 02:25:00 PM
Quote from: mickjav on August 08, 2021, 02:15:20 PM
Was wonder but i selected 2.0.18 and it parsed

Just Looked It does allow admin but not allow other members.

maybe I could create a page that allows selected groups to add to that list?

mick

not sure what exactly you are trying to achieve but here's 2 mods that may help
Event Registration for SMF2 (https://custom.simplemachines.org/mods/?mod=3238)
Calendar Event Reminder (https://custom.simplemachines.org/mods/?mod=2860)
Title: Re: Calendar mods
Post by: mickjav on August 08, 2021, 02:49:06 PM
What i want to do is allow members of one or more groups to add a reoccurring birthday for different artists like the members birthdays.

So I could show a list of artists births for a given day or the current day.
Title: Re: Calendar mods
Post by: shadav on August 08, 2021, 03:01:55 PM
your best bet would be to ask in the Help Wanted (not for support) (https://www.simplemachines.org/community/index.php?board=50.0)
Title: Re: Calendar mods
Post by: mickjav on August 08, 2021, 03:10:09 PM
I'm going to start work on a simple mod to show a list of charts added its the simplest one which will be good for my first ill add the calender to the list thanks

Mick
Title: Re: Calendar mods
Post by: shadav on August 08, 2021, 03:45:01 PM
you should be able to, I believe
in your admin under members, under permissions
for each group that you want click on modify
set
Create events in the calendar         
Edit events in the calendar

[edit]nevermind as the name implies that's only for events not actual like holidays and such
Title: Re: Calendar mods
Post by: mickjav on August 08, 2021, 03:48:02 PM
Yes understand that but it creates a standard event i need them to create reoccurring event which seem to write to a different table
Title: Re: Calendar mods
Post by: Illori on August 08, 2021, 04:00:03 PM
in the admin panel under calendar, you can add a new "holiday" these would repeat each year.
Title: Re: Calendar mods
Post by: mickjav on August 08, 2021, 04:05:51 PM
Yes I can but not members with lower permissions than admin thats what I would be aiming at doing thanks mick
Title: Re: Calendar mods
Post by: Sesquipedalian on August 09, 2021, 02:10:49 AM
SMF's calendar system does not support recurring events at all. No mod could change that without completely rewriting the entire calendar system, and to my knowledge no mod exists that even attempts to do so.

Creating holidays or creating dummy accounts to record the birthday data are the only ways to do what you want. Neither option is something that your regular users can do.

You could try requesting a mod to build an alternate way to add and edit entries in the holidays table, but such a mod would need to include some very careful permissions checks—there's a reason, after all, why permission to edit holidays is restricted to admins only.
Title: Re: Calendar mods
Post by: mickjav on August 09, 2021, 02:15:26 AM
Thanks Looks Like I'll be adding them myself Lol but only for those artists with home pages.

thanks mick
Title: Re: Calendar mods
Post by: Kindred on August 09, 2021, 05:01:15 AM
Sesq...  we actually had a recurring event mod on 1.0 and sorta for 1.1

I just never had the capacity/capability to rewrite it for 2.0

Title: Re: Calendar mods
Post by: Sesquipedalian on August 09, 2021, 03:30:12 PM
Quote from: Kindred on August 09, 2021, 05:01:15 AM
Sesq...  we actually had a recurring event mod on 1.0 and sorta for 1.1

I just never had the capacity/capability to rewrite it for 2.0

I'd love to see that code.
Title: Re: Calendar mods
Post by: Kindred on August 09, 2021, 04:57:18 PM
calendar mod -- never got to finish the repeating events though
https://custom.simplemachines.org/mods/index.php?mod=138
This also had an importer which let you easily load a CSV import of holidays (I used to run a pagan board, so we needed as way to easily add all of the various holidays into the holiday list.)




here's the one that I handed off which added repeating events
https://custom.simplemachines.org/mods/index.php?mod=655
(ironically, the start of this thread (page 1) is about that mod

Then it looks liek Chris gave up and someone else picked up
https://custom.simplemachines.org/mods/index.php?mod=2520

Another one that claims to have repeating events but never got approved
https://custom.simplemachines.org/mods/index.php?mod=1843



also:
event registration
https://custom.simplemachines.org/mods/index.php?mod=2024