Simple Machines Community Forum

Link to Mod (http://mods.simplemachines.org/index.php?mod=472)
Rate this Mod (http://mods.simplemachines.org/index.php?action=review;sa=add;mod=472)

This mod will give users the option to mark only selected topics/replies as read.

sound useful, ill give it a shot.

hey jay i realy like ur mods, u always get new features... thanx

Quote from: denislici on September 16, 2006, 06:13:27 AM

hey jay i realy like ur mods, u always get new features... thanx

So true.  Just wait for the new "Awards Mod" thats coming out.  I'm using it now, but it should go public in the next couple of days :)  His mods are just fanatastic!  I'm a mod lover of all types lol.  I have like 40 lol.

Hi,

I've just installed this mod without error but can't see any changes inside the forum pages, doesn't seem markselectedread.gif anywhere. Can anyone who installed this mod put the screenshot?

1.1 RC3, Default theme

When you go to unread replies  or unread topics you don't see check boxes?  That image is there for people that use Babylon theme. 

I think i was looking at wrong place inside the forum. Now, it's ok, i did see the checkboxes. Thanks for mod, great job Jay ;-)

nice mod

is there any chance to get a version for SMF 1.08 ?

Problem INstalling mod

Apply Mod
Please remember to always make regular backups of your sources and database before installing mods, especially beta versions. 


!!Error in Package Installation

At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.
Install Actions
Installations actions for "Mark Selected Topics As Read":
Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./Sources/Subs-Boards.php Test successful
2. Execute Modification ./Themes/default/Recent.template.php Test failed

What version of SMF are you using?

Forum version: SMF 1.1 RC2
Current SMF version: SMF 1.1 RC3

You have to manually install the mod.

call me stupid, but can you direct me to instructions  on manually installing mods.

Quote from: richiehale on October 12, 2006, 06:48:04 AM
call me stupid, but can you direct me to instructions  on manually installing mods.

http://docs.simplemachines.org/index.php?topic=402

thank you Nemini.

question...... since the one test passed, can i install it, and then just do the modifications to the one file manually?

Yes you can do that.

Any 1.1 update for this mod? I'm using this for 1.1RC3 and am planning to upgrade to 1.1 but I don't wanna lose this mod.

This mod should work on 1.1.

Hi. This mod works for smf rc 1.2  ???

Thanks a lot.

You really shouldn't be running 1.1 RC2.  I suggest taht you upgrade to 1.1.1 asap.

Wonderful mod..
Another masterpiece by Jay!

I received this error when i tried to install it

Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./Sources/Subs-Boards.php Test successful
2. Execute Modification ./Themes/default/Recent.template.php Test failed

SMF Version: 1.1.1

Any ideas??

Sweet, it worked!   8)

Quote from: gome on February 10, 2007, 12:27:32 AM
I received this error when i tried to install it

Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./Sources/Subs-Boards.php Test successful
2. Execute Modification ./Themes/default/Recent.template.php Test failed

SMF Version: 1.1.1

Any ideas??

You'll probably need to manually make the updates to that file.

Thanks i fixed it :D

I notice that when someone uses this mod I get this in the error log

8: Undefined index: topics
File: /forum/Sources/Subs-Boards.php
Line: 239

How can I fix this?

Post your Subs-Boards.php file.

Quote from: JayBachatero on February 14, 2007, 03:54:37 PM
Post your Subs-Boards.php file.

Here it is here.  Thanks!

That looks correct.  Are you using this on t custom theme?

Quote from: JayBachatero on February 14, 2007, 04:03:02 PM
That looks correct.  Are you using this on t custom theme?

Yes I am.  But I stripped all duplicate files from the custom mod so files such as display.template, boardindex.template, etc. are all pointing to the default theme.

Can't you PM me a test account so that I can look into it?

Quote from: JayBachatero on February 14, 2007, 04:21:58 PM
Can't you PM me a test account so that I can look into it?

PM sent, thanks!   

Here is your problem. "<option value="markread">Mark selected read</option>".  You made your own dropdown menu but you got the name wrong for the field.  It should be mark_selected_read.

Quote from: JayBachatero on February 14, 2007, 04:44:05 PM
Here is your problem. "<option value="markread">Mark selected read</option>".  You made your own dropdown menu but you got the name wrong for the field.  It should be mark_selected_read.

What file is that in?  I check index.template.php and subs-board.php and didn't see it there.

I found this in my Recent.template.php file:

// Mark selection as read?
   if (isset($context['topics_to_mark']))
      echo '
   <form action="', $scripturl, '?action=markasread;sa=unreadreplies;sesc=', $context['session_id'], ';ut" method="post" name="markasread" accept-charset="', $context['character_set'], '" style="margin: 0;">
      <input type="hidden" name="mark_selected_read" value="1" />';

It's in the Recent.template.php. Post the whole file.

Quote from: JayBachatero on February 14, 2007, 09:06:50 PM
It's in the Recent.template.php. Post the whole file.

Thanks again.  See attached.

I took a quick glance and couldn't spot the error.  I'll look at it tom.

Quote from: JayBachatero on February 15, 2007, 12:13:12 AM
I took a quick glance and couldn't spot the error.  I'll look at it tom.

no problem, thanks.  sorry for the late response.  was out for V-day.   ;D

I haven't forgotten about this.  Been too busy to take a closer look at it.  I'll try to get back to you soon.

Quote from: JayBachatero on March 08, 2007, 11:44:36 PM
I haven't forgotten about this.  Been too busy to take a closer look at it.  I'll try to get back to you soon.

thanks Jay  8)

nice mod .
it work's in SMF 1.1.2 default
thanks !

hmm.....

i have successfully installed in custom theme but i can't see anythings happen....no checkbox that you all mention.....hmmm...

Firstly when adding mods always use the default theme !
Second all (or at least 95% of ) mods add their codes and modifications only in the default theme !
That means that if you use a custom theme you must make the mod's changes manually !!!
for more info look here :   http://docs.simplemachines.org/index.php?topic=402

i see nothing in recent-topic template

the errrorlog looks like that:

8: Undefined index: topics_to_mark
Datei: /is/htdocs/wp1005029_D2DFQN8UC8/p3dnow/akos/wowkos/kosforum/Themes/default/Recent.template.php
Zeile: 287

can anybody help

Please manually check that all edits the mod makes are properly in place...it looks likely that they are not judging by your report.

Quote from: JayBachatero on March 08, 2007, 11:44:36 PM
I haven't forgotten about this.  Been too busy to take a closer look at it.  I'll try to get back to you soon.

I think the problem is in your first search and replace in your mod.

Shouldn't this....

// Check if it's a $_POST var or $_REQUEST
if (isset($_POST['topics'], $_POST['mark_selected_read']))
$topics = $_POST['topics'];
// Make sure all the boards are integers!
else
$topics = explode('-', $_REQUEST['topics']);




be...

// Check if it's a $_POST var or $_REQUEST
if (isset($_POST['topics'], $_POST['mark_selected_read']))
$topics = $_POST['topics'];
// Make sure all the boards are integers!
else
           $topics = $_POST['topics'];
$topics = explode('-', $_REQUEST['topics']);



.. "topics" is not defined in the else statement.

Let me know if I am right OR WRONG!  :p

Thanks,
digit

Topics is defined.

else
$topics = explode('-', $_REQUEST['topics']);


I'm not sure if I understand too well what you mean though.

This is BY FAR - one of the BEST mods!!! THANK YOU for making it. All 7 of my mods/gmods now think I am the greatest admin in the world hehehehe

It installed and works perfectly on 1.1.5, using both TP and a custom theme. (Blue Ace)

update... found a major glitch in it. (well its major for my site)..lol. Went today and clicked on Show Unread Posts Since Last Visit and then I scrolled down and clicked on "All Unread Posts" so I could see all of them not just those. I always start at the very last page and work forward. Read a few on the last page, the rest were not ones I needed to read so I selected them - and "marked selected read". My page refreshed but it went back to where it was only showing "unread posts since last visit" not all the unread posts. You have to scroll back down and click on All Unread every time you select some and mark them as being read.


Any fix for this so it wont kep reverting back to just the unread since last visit?

Thanks :)

Quote from: JayBachatero on February 18, 2008, 01:50:03 PM
Topics is defined.

Code Select Expand


else
$topics = explode('-', $_REQUEST['topics']);


I'm not sure if I understand too well what you mean though.

Wow...  sorry I didn't respond sooner. 

I am getting this error in my forum error log...

8: Undefined index: topics
File: /users/Sources/Subs-Boards.php
Line: 239

after doing this... according to the mod...



<search position="replace"><![CDATA[ // Make sure all the boards are integers!
$topics = explode('-', $_REQUEST['topics']);]]></search>
<add><![CDATA[ // Check if it's a $_POST var or $_REQUEST
if (isset($_POST['topics'], $_POST['mark_selected_read']))
$topics = $_POST['topics'];
// Make sure all the boards are integers!
else
$topics = explode('-', $_REQUEST['topics']);]]></add> ## LINE 239
</operation>


Getting errors in my log:

8: Undefined index: topics
File: /Sources/Subs-Boards.php
Line: 239

Any ideas?

Still getting this error in my log :

8: Undefined index: topics
File: /home/xx/xx/Sources/Subs-Boards.php
Line: 239

as well as this one when I do maintenance on the forum to check for any errors:

Topic #0 is marked as read for one or more people, but does not exist.

The number of times that I see each error is the same - is there something in the mod that is calling/looking for topic #0 and it shouldnt be (being as their isnt one)? (I'm not that good at coding but it seems the two are related).

Quote from: Kimmie on June 17, 2008, 10:44:20 AM
Still getting this error in my log :

8: Undefined index: topics
File: /home/xx/xx/Sources/Subs-Boards.php
Line: 239

as well as this one when I do maintenance on the forum to check for any errors:

Topic #0 is marked as read for one or more people, but does not exist.

The number of times that I see each error is the same - is there something in the mod that is calling/looking for topic #0 and it shouldnt be (being as their isnt one)? (I'm not that good at coding but it seems the two are related).

bumping this up because its been a month with no response from the mod creator on how to fix this issue and I am still looking for the solution to the problem.

Kimmie.

May I ask why you are using this mod?  SMF 1.1.x has this functionality built in

Quote from: karlbenson on July 18, 2008, 01:18:39 PM
Kimmie.

May I ask why you are using this mod?  SMF 1.1.x has this functionality built in

No, SMF only has the funtion to mark "all" messages as read all at one time via the "Show unread posts since last visit" page. This mod allows you to select "specific topics" on that list as mark only those topics as read instead by placing checkboxes on those pages and adds the function at the bottom to "mark selected topics as read". A valuable tool for my staff members who are responsible for only reading specific areas.

Every time someone uses the select feature, it renders errors regarding a topic (topic #0) that is non existant. Every time this error occurs, I have to do maintenance to repair all errors, fix those errors, and then remove the errors from my log. It trying to detect "topic #0" is the issue that needs to be fixed within the mod but I dont know how to fix it.

There is also another issue with it returning to just the unread posts since last visit page so you have to keep clicking on the "Show All" at the bottom every time, but they can probably live with that.

No smf has it.
You just need to enable Quick Moderation > Show Checkboxes in your Profile > Look and Layout
eg
http://img337.imageshack.us/img337/4569/kimiexd5.png
for both 1.1.x and 2.x

I'm not sure whether there is a fix for your issue. I'm not sure whether Jay is even still supporting this mod {since smf has the functionality}.  It could be that the default version and the mod are incompatible.

Quote from: karlbenson on July 18, 2008, 07:51:26 PM
No smf has it.
You just need to enable Quick Moderation > Show Checkboxes in your Profile > Look and Layout
eg
http://img337.imageshack.us/img337/4569/kimiexd5.png
for both 1.1.x and 2.x

I'm not sure whether there is a fix for your issue. I'm not sure whether Jay is even still supporting this mod {since smf has the functionality}.  It could be that the default version and the mod are incompatible.

You must be using Beta2.0 because 1.X's (including 1.1.5 which is what I am currently using) quick mod fuction doesnt put checkboxes on the show unread posts since last page - it only puts them on topics when you are in topic view. Thats the whole reason why this mod was created and why I installed this mod to begin with.  ;)

This is another forum I have that doesnt have the mod installed:
This shows that I have Quick moderation turned on (this is topic view inside a board): http://i38.tinypic.com/23wmpmp.jpg
This shows My SHow Unread Posts Page and there are no checkboxes: http://i34.tinypic.com/2150lfk.jpg

Compatibility isnt the issue. The issue is that the mod is "looking for a topic #0" and marking a non existant topic as read. Topic #0 doesnt exist on "anyones" forums. Topics start with Topic #1. All I need to know is how to change the code so that it no longer looks for topic #0 because when it does and cant find it, its returning errors.

I'm guessing Jay probably stopped supprting this mod if its a default feature on 2.0. Oh well. Maybe I can play with the code and figure it out myself. I wont be going to 2.0 anytime soon, its not compatible with TP and TP wont make a TP version that is compatible with 2.0 until their sure its stable/free of bugs and based on what I have seen over there, unfortunately. its gonna be a while.   :-\

I am with the same error...

if any checkboxes be not selected i get this error:

QuoteUndefined index: topics
Ficheiro: /home/nemigue/public_html/Sources/Subs-Boards.php
Linha: 239

and

QuoteThe following errors are fouling up your forum:
Topic #0 is marked as read for one or more people, but does not exist.

Would you like to fix these errors?
Yes - No

some ideas?

this MOD is very important for me...

Does this work on 2.0 beta 4? I used to use this and loved it.

Very nice!!
I change something in the mod because I saw some errors at this line (for me line 239):

$topics = explode('-', $_REQUEST['topics']);

I'd like to know if you think to update SMF 2.0, if no, I can make the update to the mod.

In the next week I must to test SMF 2.0 in my test forum... and I'd to continue to use this mod.

I read that 2.0 beta 4 put checkbox in unread topic if you set the

Show quick-moderation on message index as

checkboxes

In the 1.1.x not...

Quote from: ne.miguelito on July 25, 2008, 03:42:35 AM
I am with the same error...

if any checkboxes be not selected i get this error:

QuoteUndefined index: topics
Ficheiro: /home/nemigue/public_html/Sources/Subs-Boards.php
Linha: 239

and

QuoteThe following errors are fouling up your forum:
Topic #0 is marked as read for one or more people, but does not exist.

Would you like to fix these errors?
Yes - No

some ideas?

this MOD is very important for me...

I have this problems too.  :(
I'm using version 1.1.7 and dilbermc theme.
How can I solved this  ???

*bump*

anyone solved this problems ?

Quote from: ITA003 on October 22, 2008, 05:41:32 PM

I change something in the mod because I saw some errors at this line (for me line 239):

Code Select Expand

$topics = explode('-', $_REQUEST['topics']);

Is THIS the fix?  (it sounds like you solved it somehow - but that line IS line 239)

The error is still occurring for me.....

SIGH

Thanks.

I wrote the following code with inspiration from this mod. This is for 1.1.10, although it might work for earlier. Make sure you understand what I'm doing so you don't mess the code up, since my instructions can be a bit ambiguous.

KEEP A BACKUP. PLEASE. I'M WARNING YOU. I applied changes directly to my forum, so I'm unsure if this list of instructions is correct or complete. Use at your own risk.

Recent.template.php
Repeat the following for both the template_unread() function and the template_replies() function. They are both extremely similar, and so we are applying the same changes to both. Follow the below instructions twice for each of the two functions.


1. Find the $mark_read array and add this item to it:
'markselected' => array('text' => 'mark_selected', 'lang' => true, 'url' => 'javascript:document.quickModForm.submit();')


2. Find this right after it...
echo '
</tr>
</table>

...And add this form element:
<form action="', $scripturl, '?action=markasread;sa=unreadreplies;return=', urlencode(base64_encode(serialize($_GET))), ';sesc=', $context['session_id'], '" method="post" accept-charset="', $context['character_set'], '" name="quickModForm" id="quickModForm" style="margin: 0;">


3. For template_unread(), find:
</td><td width="24%">
<a href="', $scripturl, '?action=unread', $context['showing_all_topics'] ? ';all' : '', $context['querystring_board_limits'], ';sort=last_post', $context['sort_by'] == 'last_post' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[111], $context['sort_by'] == 'last_post' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" border="0" />' : '', '</a>
</td>
For template_replies(), find:
<td width="24%"><a href="', $scripturl, '?action=unreadreplies', $context['querystring_board_limits'], ';sort=last_post', $context['sort_by'] == 'last_post' && $context['sort_direction'] == 'up' ? ';desc' : '', '">', $txt[111], $context['sort_by'] == 'last_post' ? ' <img src="' . $settings['images_url'] . '/sort_' . $context['sort_direction'] . '.gif" alt="" border="0" />' : '', '</a></td>

Add after that:

<td class="windowbg2" valign="middle" width="4%" align="center">
<input type="checkbox" onclick="invertAll(this, this.form, \'topic_array[]\');" class="check" />
</td>


4. Find:
<td class="windowbg2" valign="middle" width="22%">
<a href="', $topic['last_post']['href'], '"><img src="', $settings['images_url'], '/icons/last_post.gif" alt="', $txt[111], '" title="', $txt[111], '" style="float: right;" /></a>
<span class="smalltext">
', $topic['last_post']['time'], '<br />
', $txt[525], ' ', $topic['last_post']['member']['link'], '
</span>
</td>

Add after:

<td class="windowbg2" valign="middle" width="4%" align="center">
<input type="checkbox" name="topic_array[]" class="check" value="', $topic['id'], '" />
</td>


5. Find:

echo '
</table>
</td></tr>
</table>

And add after:
</form>


6. Replace any...
colspan="7"
...in the function with...
colspan="8"



Modifications.english.php
Add this to it:
$txt['mark_selected'] = 'Mark Selected as Read';



Subs-Boards.php.

Find:
// Make sure all the boards are integers!

Replace the line after with:
$topics = !empty($_POST['topic_array']) ? $_POST['topic_array'] : explode('-', !empty($_REQUEST['topics']) ? $_REQUEST['topics'] : '');


Find:

if (isset($_SESSION['topicseen_cache']))
$_SESSION['topicseen_cache'] = array();

Replace the redirectexit() line with:

if (!empty($_REQUEST['return'])) {
$link = '';
foreach (unserialize(base64_decode($_REQUEST['return'])) as $i => $value)
$link .= $i . '=' . $value . ';';
} else
$link = 'action=unreadreplies';

redirectexit($link);
      
And that should do it. Test it.

If you understood that, then you are probably capable of writing a mod, so if you would like to distribute these edits as a mod, feel free to do so. You must link to this post, if you do though.

Quote from: Kimmie on May 17, 2008, 01:48:20 AM
update... found a major glitch in it. (well its major for my site)..lol. Went today and clicked on Show Unread Posts Since Last Visit and then I scrolled down and clicked on "All Unread Posts" so I could see all of them not just those. I always start at the very last page and work forward. Read a few on the last page, the rest were not ones I needed to read so I selected them - and "marked selected read". My page refreshed but it went back to where it was only showing "unread posts since last visit" not all the unread posts. You have to scroll back down and click on All Unread every time you select some and mark them as being read.


Any fix for this so it wont kep reverting back to just the unread since last visit?

Thanks :)

Sorry for bringing up this old problem but I am looking for a solution for the exact same thing. Any advice is most appreciated. Thank you!

In Recent.template.php
find:
<form action="', $scripturl, '?action=markasread;sa=unreadreplies;sesc=', $context['session_id'], ';ut" method="post" name="markasread" accept-charset="', $context['character_set'], '" style="margin: 0;">
replace with:
<form action="', $scripturl, '?action=markasread' , $context['showing_all_topics'] ? ';all' : '' , ';sa=unreadreplies;sesc=', $context['session_id'], ';ut" method="post" name="markasread" accept-charset="', $context['character_set'], '" style="margin: 0;">

find:
<form action="', $scripturl, '?action=markasread;sa=unreadreplies;sesc=', $context['session_id'], '" method="post" name="markasread" accept-charset="', $context['character_set'], '" style="margin: 0;">
replace with:
<form action="', $scripturl, '?action=markasread' , $context['showing_all_topics'] ? ';all' : '' , ';sa=unreadreplies;sesc=', $context['session_id'], '" method="post" name="markasread" accept-charset="', $context['character_set'], '" style="margin: 0;">

In Subs-Boards.php
find:
if (isset($_REQUEST['ut']))
redirectexit('action=unread');
replace with:
if (isset($_REQUEST['ut']))
redirectexit('action=unread' . ((isset($_REQUEST['all'])) ? ';all' : ''));

It should work. :)

Thank you so much! It works excellent now! You really releaved me from a severe headache! Thanks a lot!

I have been using this mod with great joy on a SMF 1.1 Board and wonder if there is something similar available for SMF 2.0?

You could turn on quick moderation as checkboxes from your profile, which will let you select topics to mark as read from boards/unread/unread replies.

Works for non-moderators too to mark things read - I have it set that way here even though I'm not a moderator, just so I can mark a bunch of threads read without having to visit them.

Great! Thank you very much!