(http://www.smfpacks.com)
Move Topic Notification v1.2 - Developed by NIBOGO - Created by Valodim
Will add an option to the move topic dialogue to notify the original poster of the thread via PM.
Support topic (http://www.simplemachines.org/community/index.php?topic=158934.0) | Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=708) | My Mods (http://custom.simplemachines.org/mods/index.php?action=search;author=126412) | Website (http://www.smfpacks.com) | Donate (http://www.smfpacks.com/donate.php)
Important Info:
o This Mod was created by SMFPacks.com - The #1 Website for the Customziation of your SMF.
SMFPacks.com Provides Other Great Packages:
- Reason for Editing Mod.
- Yet Another Global Announcements Mod.
- SMF Social Groups.
- SMF Links Directory.
- SMF Downloads Directory.
- SMF Dynamic Directory.
- Advanced Topic Prefix Mod.
- Advanced Invitations System.
- Move Topic Notification.
- PM to New Members.
- Permissions Info.
- Next Post Level.
- Karma Buttons.
- SMF Multi Quote.
- Attachments in Topics.
- and much more visit us on SMFPacks.com
Author:
- NIBOGO
Features:
o Notify the author of his topic has been moved by PM.
o The PM Notification option does not show up for own topics, or topics posted by guests!
o Simple and friendly interface to set the PM Body.
o Easy to use commands like {topic}, {prev_board}, {subject} and {board}.
Manual Edit:Try to use the parser:
SMF 1.1.X Parser (http://custom.simplemachines.org/mods/index.php?action=parse;mod=708;attach=103214;smf_version=1.1.9)
SMF 2.0 Parser (http://custom.simplemachines.org/mods/index.php?action=parse;mod=708;attach=103214;smf_version=2.0_RC1-1)
Languages:
- English/English-utf8
- Spanish_es/Spanish_latin - Spanish_es-utf8/Spanish_latin-utf8
- Portuguse_pt/Portuguese_brazilian/Portuguese_pt-utf8/Portuguese_brazilian-utf8 by Sakae
- Turkish/Turkish-utf8 by Daydreamer
- Greek/Greek-utf8
- Russian/Russian-utf8 by Bugo
Compatibility:
o SMF 2.0
o SMF 1.1.X
Special Thanks:
- Valodim (http://www.simplemachines.org/community/index.php?action=profile;u=5346): Original author of the mod and the idea.
- sayfam: He translate the mod to turkish/turkish-utf8
Changelog:1.2 - 08 Mar 2010o Added support for SMF 2.0 RC3
o Replaced commands now you can use {topic}, {prev_board}, {subject} and {board}.
o Added explanation of each command in the Move Topic Page.
o Mod renamed to "Move Topic Notification"
1.1.3 - 22 Nov 2009o Added support for SMF 2.0 RC2
o Fixed issue sending the PM caused for an error in the installation.
1.1.2 - 08 Oct 2009o Added support for SMF 1.1.10
1.1 - 23 June 2009o Fixed a big bug on SMF 2.0 RC1 & SMF 2.0 RC1-1. Please upgrade (Uninstall the last version and install this one)
o Changed the strings in Turkish and Portuguese
o Fixed a little bug in the installation with the greek language
1.0 - 18 June 2009o Now mod developed by NIBOGO
o Changed all the strings to Modifications.{language}.php
o Added Support for SMF 2.0 RC1-1 & SMF 1.1.9 and below versions
o Added Spanish/Spanish-UTF8, Spanish Latin/Spanish Latin-UTF8, Spanish Es/ Spanish Es-UTF8, Greek-UTF8, Portuguese, English-UTF8 and Turkish-UTF8
0.901o Mod created by Valodim (http://www.simplemachines.org/community/index.php?action=profile;u=5346)
o No PM notify if topic starter is guest, added turkish language strings, and moved to xml mod format
Very cool, i like it! 8)
THANKS!!! :D :D
Very good mod, i like to go to board maintenance and remove MOVED thread notices that are over 5 days old, some of our members may not login for a week or more so may miss the MOVED notice.
One thing i would like to do is alter the default PM message, where can i edit that?
Ok, i found it, its here,
http://www.YOUR_URL.com/forum/Themes/default/languages/index.english.php
Its one of the last lines of code at the bottom.
Thanks :)
hihi..somehow this doesn't work after i installed it..
Are there any permissions that i need to enable?
works great!
one thing, how do I change the default message?
it's in the txt language files.
This is a great mod! 8)
Is there any way i can set it up so that it PM's all members in the forum regarding the move and not just the creator?
Thanks,
Miyagi
No, but that would indeed be a useful option. I'll consider adding it when I get to working on this one again :)
Does i have to set permissions or something?
I installed it in a 1.1.2 with the Package Manager - without problems, but while moving a thread - there is no checkbox...
Could you help me out?
Surfy
Not working for me either, 1.1.2, using a modified theme.
wow, thanks! i've always sent PM's manually about this
Quote from: Surfy on May 10, 2007, 06:45:10 PM
Does i have to set permissions or something?
I installed it in a 1.1.2 with the Package Manager - without problems, but while moving a thread - there is no checkbox...
Could you help me out?
Surfy
Same problem for me !
Any solutions?
that's probably caused by a custom template. you'll have to adapt that manually.
Great mod, installed in 1.1.2 and got working.
Quote from: Miyagi on May 05, 2007, 10:20:09 PM
This is a great mod! 8)
Is there any way i can set it up so that it PM's all members in the forum regarding the move and not just the creator?
Thanks,
Miyagi
Wont this just create an overload?
I mean if you had a thousand users and 10 moved topics a day.
I think he means all people who posted in the thread. Not really worth it either, though
What I should do to install on smf 1.1.3 ???
Doesn't install for 1.1.3
So somebody do update, please ? :)
This mod dosn't work on smf 1.1.3 :(
It looks like you have to uninstall this modification for 1.1.3! Too bad, because I really liked it.
Actually, can someone tell me how to uninstall this modification? When I try to uninstall it, I get the following message:
This package cannot be uninstalled, because there is no uninstaller!
Please contact the mod author for more information.
OK, this message is my way of contacting the mod author!
if you installed 1.1.3 using the patch, you'd better not touch the uninstall thing, unless something isn't working properly for you. that's why it tells you to uninstall all mods prior to upgrading :P
Valodim,
Well, I'm still somewhat new at this. So, now that I made this mistake, what should I do to fix it?
Thanks!
So, this mod wont be updated to work with 1.1.3?..
it works fine with 1.1.3 already... updated xml file to reflect that :P
Well.. it says "Compatible With: 1.1.2, 1.1.3" but when I install on 1.1.3... there are no problems! :P
But.. It doesn't work though :(
I don't get the "Send PM notiication" when I want to Move the topic..
I got the same. I have done everything correctly.
Huh? It works for me... do you use a custom template?
Also note that it doesn't show up for your own topics (why would you notify yourself by pm :P)
Aaah.. that's it probably..!
I'm in a testing-stage of my Forum.. and I only have one topic.. created by myself.
Ok.. I'll try with a TEST account..
Edit: Works fine! ;)
great feature. thank you :)
Quote
Also note that it doesn't show up for your own topics (why would you notify yourself by pm :P)
Oh man thanks for help :P
This mod works :D
Ok, working great now on 1.1.3, modified default theme.
Thanks for the excellent mod!
:D :D :D :D :D
Would it be possible to update this mod for 1.1.4? It would be very useful on my board.
Thank you in advance. :)
Yes, 1.1.4 support would be appreciated!
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.
Has anyone created a 1.1.4 version of this yet?
Quote from: pinkfreak on February 17, 2008, 09:55:20 PM
Has anyone created a 1.1.4 version of this yet?
I believe it's just a matter of changing the XML file, albeit I don't really know how to do this myself, but I think it's rather simple if you just search around for it, or ask how to do it. But really, the question you should be asking is "will this mod be made compatible with 2.0!?" ;)
works fine with 1.1.4
I am getting this error with 1.1.4 :
Installationaction for "vMoveTopic Notify by PM":
there are no Installationaction defined !
What can i do?
Quote from: kristien on March 14, 2008, 08:44:33 PM
I am getting this error with 1.1.4 :
Installationaction for "vMoveTopic Notify by PM":
there are no Installationaction defined !
What can i do?
All you have to do is to open the package-info.xml with Notepad++ and edit the install and uninstall lines. Put 1.1.4 on it and everything will be fine.
I'm using SMF 1.1.4 and it works smoothly. Though I've made some personal changes to fit in my personal use.
ANy updates for this to work with 1.1.5?
This mod would be perfect if you could have the option to insert the pm message that gets sent, right there instead of it sending the same default message to every topic starter you have to move a topic on. That way, you can personalize it to reflect the "actual" reason your moving that particular topic. If all they get is a default message, their gonna end up pming staff to find out why it was moved so your gonna end up talking to them via pm anyways. You might as well just send them a pm..lol.
tekgik
Just modify the package_info.xml file's "Install" and "Uninstall" lines to reflect 1.1.5 and it will install for you.
Can this little mod be ported to SMF 2.0 ? I think there is just minor settings to change in the code.... (or maybe it works like it is but i am afraid to make the test in my deeply modificated forum)
when have time update portuguese
<file name="$themedir/languages/index.portuguese_pt.php" error="skip">
<operation>
<search position="end"><![CDATA[
$txt['ajax_in_progress'] = 'Loading...';]]></search>
<add><![CDATA[
$txt['moveTopic5'] = 'Enviar notificação PM';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Digite o texto da notificação, que será enviada para o poster original por pm.';
$txt['movetopic_notify_default'] = 'O tópico que você criou no [PREVBOARD] chamado [TOPIC] foi deslocado para [BOARD]. Por favor, entenda que isto tenha sido feito para manter a ordem no fórum.' . ".\n\n" . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Tópico movido';]]></add>
</operation>
</file>
<file name="$themedir/languages/index.portuguese.php" error="skip">
<operation>
<search position="before"><![CDATA[
$txt['ajax_in_progress'] = 'Loading...';]]></search>
<add><![CDATA[
$txt['moveTopic5'] = 'Enviar notificação PM';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Digite o texto da notificação, que será enviada para o poster original por pm.';
$txt['movetopic_notify_default'] = 'O tópico que você criou no [PREVBOARD] chamado [TOPIC] foi deslocado para [BOARD]. Por favor, entenda que isto tenha sido feito para manter a ordem no fórum.' . ".\n\n" . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Tópico movido';]]></add>
</operation>
</file>
I have install this mod manually, but this don't work for me, don't send a pm :(
I'm using version 1.1.7 and dilbermc theme.
Anyone could help me ???
*bump*
anyone could help ?
I modify the package for smf 1.1.7 i cant add more versions because i do that on my cell phone
Hello nibogo. I see you "love SMF 2.0 RC1". I love it too. Can you port this modification to 2.0 RC1 like you did with 1.1.7? Thanks!
Quote from: shumilica on February 23, 2009, 03:47:27 PM
Hello nibogo. I see you "love SMF 2.0 RC1". I love it too. Can you port this modification to 2.0 RC1 like you did with 1.1.7? Thanks!
Maybe in the future :P
I will wait drooling :) even if this means i will reduce my percentage of water in my body by half :)
Quote from: Kimmie on September 01, 2008, 02:56:06 AM
This mod would be perfect if you could have the option to insert the pm message that gets sent, right there instead of it sending the same default message to every topic starter you have to move a topic on. That way, you can personalize it to reflect the "actual" reason your moving that particular topic. If all they get is a default message, their gonna end up pming staff to find out why it was moved so your gonna end up talking to them via pm anyways. You might as well just send them a pm..lol.
Im able to edit it like how you mention .. i can edit before the message is actually sent
2.0 RC1-1 support please.
Quote from: NIBOGO on January 05, 2009, 11:48:10 AM
I modify the package for smf 1.1.7 i cant add more versions because i do that on my cell phone
Quote from: NIBOGO on June 11, 2009, 07:29:15 PM
Quote from: <<Anadolu>> on June 11, 2009, 06:46:32 PM
2.0 RC1-1 support please.
Will be uploaded tonight ;)
Hello and sorry for the question.
Have anyone this mod in 1.1.9 ?
Or have a working version NIBOGO ?
Thanks
Yes I have this mod working in 1.1.9.
You need to edit the package-info.xml file to install & uninstall for 1.1.9 and it will work fine.
thanks i will try
Οκ
Work very good
Here is the greek-utf8 translate
<file name="$themedir/languages/index.greek-utf8.php">
<operation>
<search position="before"><![CDATA[
$txt['ajax_in_progress'] = 'Φόρτωση...';]]></search>
<add><![CDATA[
$txt['moveTopic5'] = 'Στείλε ειδοποίηση με ΠΜ';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Παρακαλώ γράψε το μήνυμα που θα σταλεί στον συγγραφέα του θέματος με ΠΜ.';
$txt['movetopic_notify_default'] = 'Το θεμα που ξεκινήσατε στον πίνακα [PREVBOARD] με ονομασία [TOPIC] μετακινήθηκε στον πίνακα [BOARD]. Παρακαλώ σημειώστε ότι αυτό γίνεται για την εύρυθμη λειτουργία του ΦΟΡΟΥΜ.' . ".\n\n" . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Moved Topic';]]></add>
</operation>
</file>
</modification>
Changelogs:
1.0 - 18 June 2009
o Now mod developed by NIBOGO
o Changed all the strings to Modifications.{language}.php
o Added Support for SMF 2.0 RC1-1 & SMF 1.1.9 and below versions
o Added Spanish/Spanish-UTF8, Spanish Latin/Spanish Latin-UTF8, Spanish Es/ Spanish Es-UTF8, English-UTF8 and Turkish-UTF8
NIBOGO, the mod turkish translation is suck and very bad.
Can you update from this ?
$txt['moveTopic5'] = 'İleti gönder';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Konuyu başlatana taşıma ile ilgili bilgiyi buraya yazınız.';
$txt['movetopic_notify_default'] = '[PREVBOARD] bölümünde oluşturduğunuz [TOPIC] isimli konu [BOARD] bölümüne taşınmıştır. Forumun daha düzenli olması için yapılan bu değişikliği lütfen anlayışla karşılayın.' . ".\n\n" . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Konuyu Taşı';
And in my forum(2.0 rc1) , pm not sended. Are you forget one code ? =)
Awesome update, thank you very much!!
Modifications.portuguese_brazilian-utf8.php
Modifications.brazilian-utf8.php
// vMoveTopic Notify by PM Mod Begins
$txt['moveTopic5'] = 'Notificar por MP';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Digite o texto de notificação, que será enviado para o autor original via mensagem privada.';
$txt['movetopic_notify_default'] = 'O tópico que você criou no fórum [PREVBOARD] com o título [TOPIC] foi movido para o fórum [BOARD]. Não leve para o lado pessoal, estamos apenas organizando melhor o fórum :).' . ".\n\n" . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Tópico movido';
// vMoveTopic Notify by PM Mod Die
Modifications.portuguese_brazilian.php
Modifications.brazilian.php
// vMoveTopic Notify by PM Mod Begins
$txt['moveTopic5'] = 'Notificar por MP';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Digite o texto de notificação, que será enviado para o autor original via mensagem privada.';
$txt['movetopic_notify_default'] = 'O tópico que você criou no fórum [PREVBOARD] com o título [TOPIC] foi movido para o fórum [BOARD]. Não leve para o lado pessoal, estamos apenas organizando melhor o fórum :).' . ".\n\n" . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Tópico movido';
// vMoveTopic Notify by PM Mod Die
Keep the good work.
Nice and Useful Mod nibogo.
Thanks [Daydreamer] and Sakas for the translations ;)
@[Daydreamer]: It's true I make a fatal mistake when I package it and I forgot to add the code of sends the PM :P fixed in the new version
Changelogs:
1.1 - 23 June 2009
o Fixed a big bug on SMF 2.0 RC1 & SMF 2.0 RC1-1. Please upgrade (Uninstall the last version and install this one)
o Changed the strings in Turkish and Portuguese
o Fixed a little bug in the installation with the greek language
simply and useful mod
i cannot get it working on RC1-1
edited my files manually, it shows the checkbox to send a notify to user, but they don`t receive the pm
Quote from: silverf0x on June 28, 2009, 01:59:06 PM
i cannot get it working on RC1-1
edited my files manually, it shows the checkbox to send a notify to user, but they don`t receive the pm
Try the v1.1 of this mod ;)
Quote from: edi67 on June 28, 2009, 04:21:14 AM
simply and useful mod
Glad you like it
I just tried to upload this mod but it says not comaptible to 1.1.10 even tho the package says so.
Thanks NIBOGO (http://index.php?action=profile;u=126412) its super mod,
but the mod didn't work in my forum , because there isn't a way to active this:'Notify the author of his topic has been moved by PM in':
featuresettings
----------------------
this is the Translation to Arabic
arabic.php
// vMoveTopic Notify by PM Mod Begins
$txt['moveTopic5'] = 'ارسال تنبيه عبر الرسائل الشخصية';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'من فضلك ادخل تقرير التنبيه هنا, الذي سيتم ارساله لصاحب الموضوع الاصلي بواسطة الرسائل الشخصية.';
$txt['movetopic_notify_default'] = 'الموضوع الذي ارسلته في منتدى [PREVBOARD] بعنوان [TOPIC] تم نقله الى منتدى [BOARD]. من فضلك نرجوا التفهم بان الموضوع تم نقله للمنتدى المناسب له.' . ". " . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'موضوع منقول';
// vMoveTopic Notify by PM Mod Die
arabic-utf8.php
// vMoveTopic Notify by PM Mod Begins
$txt['moveTopic5'] = 'ط§ط±ط³ط§ظ,, طھظ†ط¨ظٹظ‡ ط¹ط¨ط± ط§ظ,,ط±ط³ط§ط¦ظ,, ط§ظ,,ط´ط®طµظٹط©';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'ظ...ظ† ظپط¶ظ,,ظƒ ط§ط¯ط®ظ,, طھظ,ط±ظٹط± ط§ظ,,طھظ†ط¨ظٹظ‡ ظ‡ظ†ط§, ط§ظ,,ط°ظٹ ط³ظٹطھظ... ط§ط±ط³ط§ظ,,ظ‡ ظ,,طµط§طط¨ ط§ظ,,ظ...ظˆط¶ظˆط¹ ط§ظ,,ط§طµظ,,ظٹ ط¨ظˆط§ط³ط·ط© ط§ظ,,ط±ط³ط§ط¦ظ,, ط§ظ,,ط´ط®طµظٹط©.';
$txt['movetopic_notify_default'] = 'ط§ظ,,ظ...ظˆط¶ظˆط¹ ط§ظ,,ط°ظٹ ط§ط±ط³ظ,,طھظ‡ ظپظٹ ظ...ظ†طھط¯ظ‰ [PREVBOARD] ط¨ط¹ظ†ظˆط§ظ† [TOPIC] طھظ... ظ†ظ,ظ,,ظ‡ ط§ظ,,ظ‰ ظ...ظ†طھط¯ظ‰ [BOARD]. ظ...ظ† ظپط¶ظ,,ظƒ ظ†ط±ط¬ظˆط§ ط§ظ,,طھظپظ‡ظ... ط¨ط§ظ† ط§ظ,,ظ...ظˆط¶ظˆط¹ طھظ... ظ†ظ,ظ,,ظ‡ ظ,,ظ,,ظ...ظ†طھط¯ظ‰ ط§ظ,,ظ...ظ†ط§ط³ط¨ ظ,,ظ‡.' . ". " . '[TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'ظ...ظˆط¶ظˆط¹ ظ...ظ†ظ,ظˆظ,,';
// vMoveTopic Notify by PM Mod Die
or in this files
Thanks for the translation and you must enable this option in the move topic window not in features and settings
Quote from: NIBOGO on July 21, 2009, 03:32:55 PM
Thanks for the translation and you must enable this option in the move topic window not in features and settings
If you want I post the arabic translation to your mods in the topics of each mod
thanks for the explain, but how?
this photo after the install
Quote from: BlueDevil on July 15, 2009, 11:02:28 PM
I just tried to upload this mod but it says not comaptible to 1.1.10 even tho the package says so.
Same here. Is this mod compatible with 1.1.10?
It is a very useful mod and I hope it is. Thanks!
Quote from: bbmtalk on July 28, 2009, 05:58:43 PM
Quote from: BlueDevil on July 15, 2009, 11:02:28 PM
I just tried to upload this mod but it says not comaptible to 1.1.10 even tho the package says so.
Same here. Is this mod compatible with 1.1.10?
It is a very useful mod and I hope it is. Thanks!
Yes it is
Quote from: NIBOGO on July 28, 2009, 05:59:29 PM
Yes it is
But when I tried to install it, it said not comaptible to 1.1.10?
same here says not compatible with 1.1.10
is there anychance u could get it compatible...
Thanks
I am running SMF 2.0 RC1.2 and I see the option to PM the member when I move the topic, but they aren't getting the PM. All tests were successful when I installed it and there are no errors in the error log
Quote from: flamechica on August 14, 2009, 05:38:41 PM
I am running SMF 2.0 RC1.2 and I see the option to PM the member when I move the topic, but they aren't getting the PM. All tests were successful when I installed it and there are no errors in the error log
To my happens me the same, the instalacion was correct, but no envia the mp, that can be happening? A greeting and Graces, expect his answer, since me serious very util this Mod.
The same problem here... i Have SMF 2.0 RC 1.2 and it doent send the MP , i hace installed the last version of this mod...
New version uploaded now supporting SMF 1.1.10, if you have installed this mod you don't need to upgrade
Great mod, thanks.
Russian translation:
Quote$txt['moveTopic5'] = 'Отправить уведомление по ЛС';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Пожалуйста, введите текст уведомления, это сообщение будет отправлено автору темы используя личные сообщения.';
$txt['movetopic_notify_default'] = 'Созданная Вами тема [url=http://[TOPIC LINK]][TOPIC][/url] в [PREVBOARD] перенесена в другой раздел: [BOARD]. Это сделано для соблюдения порядка на форуме. Спасибо за понимание.' . "\n\n" . 'Перейти в тему: [TOPIC LINK]';
$txt['movetopic_notify_subject'] = 'Ваша тема перенесена';
Quote from: flamechica on August 14, 2009, 05:38:41 PM
I am running SMF 2.0 RC1.2 and I see the option to PM the member when I move the topic, but they aren't getting the PM. All tests were successful when I installed it and there are no errors in the error log
And the same here :(
What is the reason?
Anyone? :(
Changelogs:
1.1.3 - 22 Nov 2009
o Added support for SMF 2.0 RC2
o Fixed issue sending the PM caused for an error in the installation.
[?] (http://www.simplemachines.org/community/index.php?topic=158934.msg2370460#msg2370460)
QuoteChangelogs
Thanks, now the notification works, but there is a few issues...
* The PM subject (title) is always the same as moved topic title (i thought it should be taken from $txt['movetopic_notify_subject'], wich i think is also should accept [TOPIC] variable).
* Variables [BOARD] and [TOPIC LINK] does not expanded in PM body:
QuoteThe topic you created at General Discussion named Test has been moved to [BOARD]. Please understand that this has been done to keep order in the forum..
[TOPIC LINK]
P.SI posted a russian translation few posts ago (http://www.simplemachines.org/community/index.php?topic=158934.msg2329045#msg2329045), perhaps you would like to add it to the package
I'll check it because yesterday the mod was working great on my localhost (I mean the second issue was not reproduce it) and about the first sugguest I'll think about it.
Best Regards
Good mod! Thanks to the author.
Quote from: MrCreatoR on November 23, 2009, 06:34:01 AM
[?] (http://www.simplemachines.org/community/index.php?topic=158934.msg2370460#msg2370460) QuoteChangelogs
Thanks, now the notification works, but there is a few issues...
* The PM subject (title) is always the same as moved topic title (i thought it should be taken from $txt['movetopic_notify_subject'], wich i think is also should accept [TOPIC] variable).
* Variables [BOARD] and [TOPIC LINK] does not expanded in PM body:
QuoteThe topic you created at General Discussion named Test has been moved to [BOARD]. Please understand that this has been done to keep order in the forum..
[TOPIC LINK]
P.S
I posted a russian translation few posts ago (http://www.simplemachines.org/community/index.php?topic=158934.msg2329045#msg2329045), perhaps you would like to add it to the package
I confirm variables [BOARD] and [TOPIC LINK] don't work on SMF 2.0 RC2. Waiting for update.
Well, here's the french translation for the MOD :
<file name="$languagedir/Modifications.french-utf8.php">
<operation>
<search position="end" />
<add><![CDATA[
// vMoveTopic Notify by PM Mod Begins
$txt['moveTopic5'] = 'Notification par PM';
$txt['movetopic_auto_prevboard'] = '[PREVBOARD]';
$txt['movetopic_auto_topic2'] = '[TOPIC]';
$txt['movetopic_notify_desc'] = 'Entrer le texte de notification qui sera transmis par PM au créateur du sujet.';
$txt['movetopic_notify_default'] = 'Bonjour,' . "\n\n" . 'Le sujet \'[TOPIC]\' que vous avez créé en section \'[PREVBOARD]\' a été déplacé vers la section \'[BOARD]\', ceci uniquement dans le cadre de la réorganisation régulière du forum.' . "\n\n" . 'Voici le lien vers nouvel emplacement : [TOPIC LINK]'. "\n\n" . 'Merci pour votre participation.';
$txt['movetopic_notify_subject'] = 'Déplacement d\'un de vos sujets';
// vMoveTopic Notify by PM Mod Die
]]></add>
</operation>
</file>
Yes... thanks I waiting for update.
Changelog:
1.2 - 08 Mar 2010
o Added support for SMF 2.0 RC3
o Replaced commands now you can use {topic}, {prev_board}, {subject} and {board}.
o Added explanation of each command in the Move Topic Page.
o Mod renamed to "Move Topic Notification"
Please all the translations need to be updated, only these line:
$txt['movetopic_notify_desc'] = 'Please enter the notification text, which will be sent to the original poster by pm.<br />{topic} - Link to the Topic Url<br />{new_board} - Link to the New Board<br />{subject} - Subject of the Topic<br />{prev_board} - Previous Board';
Leave the <br />
RC2 don´t work :/
PM´s look this:
QuoteThe topic you created at {prev_board} named {subject} has been moved to {new_board}. Please understand that this has been done to keep order in the forum..
{topic}
I tested on RC3 Fresh Install and works great for me
...but RC2 don´t work ;)
Hi,
i have this errors on install.
SMF 2.0RC3
Just do the manual edit for the changes that cannot be done with the package manager
Russian translation:
this for languages-utf8.xml (encoded to UTF8 w\o BOM)
<file name="$languagedir/Modifications.russian-utf8.php" error="skip">
<operation>
<search position="end" />
<add><![CDATA[
// Move Topic Notification by SMFPacks.com
$txt['moveTopic5'] = 'Отправлять ЛС автору с уведомлением о перемещении темы';
$txt['movetopic_notify_desc'] = 'Пожалуйста, введите текст уведомления, которое будет отправлено автору темы.<br />{topic} - Ссылка на тему<br />{new_board} - Ссылка на новый раздел<br />{subject} - Название темы<br />{prev_board} - Предыдущий раздел';
$txt['movetopic_notify_default'] = 'Тема {subject}, созданная Вами в разделе {prev_board}, перемещена в {new_board}. Пожалуйста, отнеситесь к этому с пониманием — на форуме должен поддерживаться порядок.' . ".\n\n" . '{topic}';
$txt['movetopic_notify_subject'] = 'Перемещённая тема';
// Move Topic Notification by SMFPacks.com
]]></add>
</operation>
</file>
and this for languages.xml (encoded to ANSI):
<file name="$languagedir/Modifications.russian.php" error="skip">
<operation>
<search position="end"></search>
<add><![CDATA[
// Move Topic Notification by SMFPacks.com
$txt['moveTopic5'] = 'Отправлять ЛС автору с уведомлением о перемещении темы';
$txt['movetopic_notify_desc'] = 'Пожалуйста, введите текст уведомления, которое будет отправлено автору темы.<br />{topic} - Ссылка на тему<br />{new_board} - Ссылка на новый раздел<br />{subject} - Название темы<br />{prev_board} - Предыдущий раздел';
$txt['movetopic_notify_default'] = 'Тема {subject}, созданная Вами в разделе {prev_board}, перемещена в {new_board}. Пожалуйста, отнеситесь к этому с пониманием — на форуме должен поддерживаться порядок.' . ".\n\n" . '{topic}';
$txt['movetopic_notify_subject'] = 'Перемещённая тема';
// Move Topic Notification by SMFPacks.com
]]></add>
</operation>
</file>
Thanks Bugo package uploaded with Russian Translation
Unfortunately, with the Russian translation isn't so simple. I also painted the above in detail, as it should be done - in different files with different encodings! :)
Otherwise, the use of Russian (not UTF8) translation users see strange characters (or simply question marks).
This is a very helpful mod for my forum and it does work... but often when doing this I get the error "Hacking attempt...". The error log says this
x'ing out personal info
INSERT INTO smf_personal_messages
(ID_MEMBER_FROM, deletedBySender, fromName, msgtime, subject, body)
VALUES (316, 1, SUBSTRING('xxxxx', 1, 255), 1269496452, SUBSTRING('xthreadx', 1, 255), SUBSTRING('The topic you created at [url=http://www.xxxxx.com/index.php?board=48]xBoardx[/url] named xthreadx has been moved to [url=http://www.xxxxx.com/index.php?board=88]xBoardx[/url]. Please understand that this has been done to keep order in the forum..
[iurl=http://www.xxxxxxx.com/index.php?topic=38525.0]http://www.xxxxxx.com/index.php?topic=38525.0[/iurl]', 1, 65534))
File: /home/xxxxx/public_html/Sources/Subs-Post.php
Line: 845'
Any advice/help would be appreciated.
One of my favorite mods... just installed on rc3 8)
I installed the MOD but I can't find where to edit it... or to enable it. When the MOD got installed it redirected me to the "Miscellaneous" page but I don't see anything in there that is related to the MOD... No errors during installation... What could be happening?
This mod has no settings. Try moving some topic and you'll see that this mod adds.
Bug report:
QuoteYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Power Fan' Header', 1, 255), SUBSTRING('This is an automated message to inform y' at line 3
File: /home/gamerlk/gamer.lk/Sources/Subs-Post.php
Line: 863
Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.11, while your database is at version 1.1.2. The above error might possibly go away if you execute the latest version of upgrade.php.
The topic title has a apostrophe in it ('). Title is
[HELP] 'Power Fan' Header
That's because it's not being sanitised properly before going into the database and not making use of proper string protections.
Can anyone help me out with my last post? Still having the same issue.
http://www.simplemachines.org/community/index.php?topic=158934.msg2554288#msg2554288
Hi, i cannot find this code:
</div>
<br />
.
There is move.topic.template.php file:
<?php
// Version: 2.0 RC3; MoveTopic
// Show an interface for selecting which board to move a post to.
function template_main()
{
global $context, $settings, $options, $txt, $scripturl;
echo '
<div id="move_topic" class="lower_padding">
<form action="', $scripturl, '?action=movetopic2;topic=', $context['current_topic'], '.0" method="post" accept-charset="', $context['character_set'], '" onsubmit="submitonce(this);">
<div class="cat_bar">
<h3 class="catbg">', $txt['move_topic'], '</h3>
</div>
<div class="windowbg centertext">
<span class="topslice"><span></span></span>
<div class="content">
<div class="move_topic">
<dl class="settings">
<dt>
<strong>', $txt['move_to'], ':</strong>
</dt>
<dd>
<select name="toboard">';
foreach ($context['categories'] as $category)
{
echo '
<optgroup label="', $category['name'], '">';
foreach ($category['boards'] as $board)
echo '
<option value="', $board['id'], '"', $board['selected'] ? ' selected="selected"' : '', $board['id'] == $context['current_board'] ? ' disabled="disabled"' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level']-1) . '=> ' : '', $board['name'], '</option>';
echo '
</optgroup>';
}
echo '
</select>
</dd>';
// Disable the reason textarea when the postRedirect checkbox is unchecked...
echo '
</dl>
<label for="reset_subject"><input type="checkbox" name="reset_subject" id="reset_subject" onclick="document.getElementById(\'subjectArea\').style.display = this.checked ? \'block\' : \'none\';" class="input_check" /> ', $txt['moveTopic2'], '.</label><br />
<fieldset id="subjectArea" style="display: none;">
<dl class="settings">
<dt><strong>', $txt['moveTopic3'], ':</strong></dt>
<dd><input type="text" name="custom_subject" size="30" value="', $context['subject'], '" class="input_text" /></dd>
</dl>
<label for="enforce_subject"><input type="checkbox" name="enforce_subject" id="enforce_subject" class="input_check" /> ', $txt['moveTopic4'], '.</label>
</fieldset>
<label for="postRedirect"><input type="checkbox" name="postRedirect" id="postRedirect" ', $context['is_approved'] ? 'checked="checked"' : '', ' onclick="', $context['is_approved'] ? '' : 'if (this.checked && !confirm(\'' . $txt['move_topic_unapproved_js'] . '\')) return false; ', 'document.getElementById(\'reasonArea\').style.display = this.checked ? \'block\' : \'none\';" class="input_check" /> ', $txt['moveTopic1'], '.</label>
<fieldset id="reasonArea" style="margin-top: 1ex;', $context['is_approved'] ? '' : 'display: none;', '">
<dl class="settings">
<dt>
', $txt['moved_why'], '
</dt>
<dd>
<textarea name="reason" rows="3" cols="40">', $txt['movetopic_default'], '</textarea>
</dd>
</dl>
</fieldset>';
// PM Notification text.
if($context['allow_notify'])
echo'<br class="clear" /><label for="postNotify"><input type="checkbox" name="postNotify" id="postNotify" onclick="document.getElementById(\'notifyArea\').style.display = this.checked ? \'block\' : \'none\';" class="input_check" /> ', $txt['moveTopic5'], '.</label>
<fieldset id="notifyArea" style="margin-top: 1ex; display: none;">
<dl class="settings">
<dt>
', $txt['movetopic_notify_desc'], '
</dt>
<dd>
<textarea name="notify" rows="3" cols="40">', $txt['movetopic_notify_default'], '</textarea>
</dd>
</dl>
</fieldset>';
echo'
<div class="righttext">
<input type="submit" value="', $txt['move_topic'], '" onclick="return submitThisOnce(this);" accesskey="s" class="button_submit" />
</div>
</div>
</div>
<span class="botslice"><span></span></span>
</div>';
if ($context['back_to_topic'])
echo '
<input type="hidden" name="goback" value="1" />';
echo '
<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '" />
<input type="hidden" name="seqnum" value="', $context['form_sequence_number'], '" />
</form>
</div>';
}
?>
How can i add this edit then?:
</div>
<br />';
// PM Notification text.
if($context['allow_notify'])
echo '
<label for="postNotify"><input type="checkbox" name="postNotify" id="postNotify" checked="checked" onclick="document.getElementById(\'notifyArea\').style.display = this.checked ? \'block\' : \'none\';" class="check" /> ', $txt['moveTopic5'], '.</label><br />
<div id="notifyArea" style="margin-top: 1ex;">
', $txt['movetopic_notify_desc'], '<br />
<textarea name="notify" rows="5" cols="40">', $txt['movetopic_notify_default'], '</textarea><br />
</div>
<br />';
echo '
Quote from: Autumn13 on March 25, 2010, 02:00:46 AM
This is a very helpful mod for my forum and it does work... but often when doing this I get the error "Hacking attempt...". The error log says this
x'ing out personal info
INSERT INTO smf_personal_messages
(ID_MEMBER_FROM, deletedBySender, fromName, msgtime, subject, body)
VALUES (316, 1, SUBSTRING('xxxxx', 1, 255), 1269496452, SUBSTRING('xthreadx', 1, 255), SUBSTRING('The topic you created at [url=http://www.xxxxx.com/index.php?board=48]xBoardx[/url] named xthreadx has been moved to [url=http://www.xxxxx.com/index.php?board=88]xBoardx[/url]. Please understand that this has been done to keep order in the forum..
[iurl=http://www.xxxxxxx.com/index.php?topic=38525.0]http://www.xxxxxx.com/index.php?topic=38525.0[/iurl]', 1, 65534))
File: /home/xxxxx/public_html/Sources/Subs-Post.php
Line: 845'
Any advice/help would be appreciated.
I have this mod installed a month or so ago and it worked flawlessly, but this week i received the same message and i'm unable to move the topic in question.
Any word on this?
Nibogo &
BugoIn the russian translation there is one small mistake:
Quote....на форуме должен поддерживаться порядок.' . ".\n\n"....
there is two dots generated when the PM is sent :)
And one more issue - is there any plans to use
$txt['movetopic_notify_subject']? it would be usefull to set different title for the PMs instead of only moved topic subject. But also the data in
$txt['movetopic_notify_subject'] should accept all variables (commands) to make the PM subject be more informative.
Quote from: frozenas on July 30, 2010, 02:00:27 PM
Hi, i cannot find this code:
</div>
<br />
.
There is move.topic.template.php file:
<?php
// Version: 2.0 RC3; MoveTopic
// Show an interface for selecting which board to move a post to.
function template_main()
{
global $context, $settings, $options, $txt, $scripturl;
echo '
<div id="move_topic" class="lower_padding">
<form action="', $scripturl, '?action=movetopic2;topic=', $context['current_topic'], '.0" method="post" accept-charset="', $context['character_set'], '" onsubmit="submitonce(this);">
<div class="cat_bar">
<h3 class="catbg">', $txt['move_topic'], '</h3>
</div>
<div class="windowbg centertext">
<span class="topslice"><span></span></span>
<div class="content">
<div class="move_topic">
<dl class="settings">
<dt>
<strong>', $txt['move_to'], ':</strong>
</dt>
<dd>
<select name="toboard">';
foreach ($context['categories'] as $category)
{
echo '
<optgroup label="', $category['name'], '">';
foreach ($category['boards'] as $board)
echo '
<option value="', $board['id'], '"', $board['selected'] ? ' selected="selected"' : '', $board['id'] == $context['current_board'] ? ' disabled="disabled"' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level']-1) . '=> ' : '', $board['name'], '</option>';
echo '
</optgroup>';
}
echo '
</select>
</dd>';
// Disable the reason textarea when the postRedirect checkbox is unchecked...
echo '
</dl>
<label for="reset_subject"><input type="checkbox" name="reset_subject" id="reset_subject" onclick="document.getElementById(\'subjectArea\').style.display = this.checked ? \'block\' : \'none\';" class="input_check" /> ', $txt['moveTopic2'], '.</label><br />
<fieldset id="subjectArea" style="display: none;">
<dl class="settings">
<dt><strong>', $txt['moveTopic3'], ':</strong></dt>
<dd><input type="text" name="custom_subject" size="30" value="', $context['subject'], '" class="input_text" /></dd>
</dl>
<label for="enforce_subject"><input type="checkbox" name="enforce_subject" id="enforce_subject" class="input_check" /> ', $txt['moveTopic4'], '.</label>
</fieldset>
<label for="postRedirect"><input type="checkbox" name="postRedirect" id="postRedirect" ', $context['is_approved'] ? 'checked="checked"' : '', ' onclick="', $context['is_approved'] ? '' : 'if (this.checked && !confirm(\'' . $txt['move_topic_unapproved_js'] . '\')) return false; ', 'document.getElementById(\'reasonArea\').style.display = this.checked ? \'block\' : \'none\';" class="input_check" /> ', $txt['moveTopic1'], '.</label>
<fieldset id="reasonArea" style="margin-top: 1ex;', $context['is_approved'] ? '' : 'display: none;', '">
<dl class="settings">
<dt>
', $txt['moved_why'], '
</dt>
<dd>
<textarea name="reason" rows="3" cols="40">', $txt['movetopic_default'], '</textarea>
</dd>
</dl>
</fieldset>';
// PM Notification text.
if($context['allow_notify'])
echo'<br class="clear" /><label for="postNotify"><input type="checkbox" name="postNotify" id="postNotify" onclick="document.getElementById(\'notifyArea\').style.display = this.checked ? \'block\' : \'none\';" class="input_check" /> ', $txt['moveTopic5'], '.</label>
<fieldset id="notifyArea" style="margin-top: 1ex; display: none;">
<dl class="settings">
<dt>
', $txt['movetopic_notify_desc'], '
</dt>
<dd>
<textarea name="notify" rows="3" cols="40">', $txt['movetopic_notify_default'], '</textarea>
</dd>
</dl>
</fieldset>';
echo'
<div class="righttext">
<input type="submit" value="', $txt['move_topic'], '" onclick="return submitThisOnce(this);" accesskey="s" class="button_submit" />
</div>
</div>
</div>
<span class="botslice"><span></span></span>
</div>';
if ($context['back_to_topic'])
echo '
<input type="hidden" name="goback" value="1" />';
echo '
<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '" />
<input type="hidden" name="seqnum" value="', $context['form_sequence_number'], '" />
</form>
</div>';
}
?>
How can i add this edit then?:
</div>
<br />';
// PM Notification text.
if($context['allow_notify'])
echo '
<label for="postNotify"><input type="checkbox" name="postNotify" id="postNotify" checked="checked" onclick="document.getElementById(\'notifyArea\').style.display = this.checked ? \'block\' : \'none\';" class="check" /> ', $txt['moveTopic5'], '.</label><br />
<div id="notifyArea" style="margin-top: 1ex;">
', $txt['movetopic_notify_desc'], '<br />
<textarea name="notify" rows="5" cols="40">', $txt['movetopic_notify_default'], '</textarea><br />
</div>
<br />';
echo '
Same problem.. How to fix this? :)
Quote from: FragaCampos on July 31, 2010, 08:57:06 AM
Quote from: Autumn13 on March 25, 2010, 02:00:46 AM
This is a very helpful mod for my forum and it does work... but often when doing this I get the error "Hacking attempt...". The error log says this
x'ing out personal info
INSERT INTO smf_personal_messages
(ID_MEMBER_FROM, deletedBySender, fromName, msgtime, subject, body)
VALUES (316, 1, SUBSTRING('xxxxx', 1, 255), 1269496452, SUBSTRING('xthreadx', 1, 255), SUBSTRING('The topic you created at [url=http://www.xxxxx.com/index.php?board=48]xBoardx[/url] named xthreadx has been moved to [url=http://www.xxxxx.com/index.php?board=88]xBoardx[/url]. Please understand that this has been done to keep order in the forum..
[iurl=http://www.xxxxxxx.com/index.php?topic=38525.0]http://www.xxxxxx.com/index.php?topic=38525.0[/iurl]', 1, 65534))
File: /home/xxxxx/public_html/Sources/Subs-Post.php
Line: 845'
Any advice/help would be appreciated.
I have this mod installed a month or so ago and it worked flawlessly, but this week i received the same message and i'm unable to move the topic in question.
Any word on this?
Bump :P
Quote from: Rav33n on April 08, 2010, 02:11:14 AM
Bug report:
QuoteYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'Power Fan' Header', 1, 255), SUBSTRING('This is an automated message to inform y' at line 3
File: /home/gamerlk/gamer.lk/Sources/Subs-Post.php
Line: 863
The topic title has a apostrophe in it ('). Title is [HELP] 'Power Fan' Header
As well as ' in the subject not inserting, " also doesn't get inserted correctly and displays as "
Here is a fix:
./Sources/MoveTopic.phpFind:
$pm_move_topic_body = preg_replace('~<br(?: /)?' . '>~', "\n", $pm_move_topic_body);
$pm_move_topic_body = un_htmlspecialchars($pm_move_topic_body);
Add after:
// floydpink EDIT - re format " and ' so they insert into database
$subject = un_htmlspecialchars($subject);
$subject = preg_replace("/'/",''',$subject);
Thanks for this fix, floydpink.
Quote from: FragaCampos on October 16, 2010, 07:19:56 PMThanks for this fix, floydpink.
As far as I can see, $txt['movetopic_notify_subject'] isn't used, but the actual topic subject.
I've just installed this on my testforum, posted a message "test" and moved it as admin.
The email subject says "New Personal Message: test"
And ofcourse the PM subject says "test"
This, in stead of the variable in the XML.
I'd like to see the variable before the actual subject, so a notification for a moved topic named "test" will become "Moved topic : test".
Is this possible?
I've cobbled together some code to do a similar thing when a post is merged: Merge Post Notification by PM (http://www.simplemachines.org/community/index.php?topic=406018.0)
It might make an interesting addition to the next release of Move Topic Notification.
;)
I got the same errors again, and several of the moderators on my forum also. I am using SMF 1.1.11
Hacking attempt...
INSERT INTO smf_personal_messages
(ID_MEMBER_FROM, deletedBySender, fromName, msgtime, subject, body)
VALUES (670, 1, SUBSTRING('crazyer', 1, 255), 1291600677, SUBSTRING('A'IE Delight with electric CBT', 1, 255), SUBSTRING('The topic you created at general named A\'IE Delight with electric CBT has been moved to the Bin. Please understand that this has been done to keep order in the forum..
The image is not working.', 1, 65534))
File: /home/sharks/sea/smf/Sources/Subs-Post.php
Line: 831
This is getting so annoying. The error above doesn't happen every time a topic is moved, but it seems random. The only way to be able to move a topic when you see that error is to log out, and then back in again. Sometimes you need to do that several times and clear the browser cache and cookies, in order to get that topic finally moved. As the admin of my forum, i am under a lot of pressure to fix that annoying error that is plaguing the normal operation of my forum. Moving topics is important, as i have other 200k topics and my team needs to keep the forum tidy. PLEASE HELP!
Hopefully someone will fix the package and re-upload it as an attachment so that all those who are having this problem can get their forum back to being properly moderated.
Yes, it is annoying, although it doens't happen for some time now in my forum. When it does, i just move it in the normal way and send a PM to the author...
Quote from: FragaCampos on December 06, 2010, 09:18:58 AM
Yes, it is annoying, although it doens't happen for some time now in my forum. When it does, i just move it in the normal way and send a PM to the author...
So, there still exists no solution this problem? Amazing... With all the talent on this, nobody has yet been able to figure this out.
I'll try to fix it as soon as possible, I have several issues in my real life at the moment, so please have some patience.
Quote from: Nibogo on December 06, 2010, 10:49:59 AM
I'll try to fix it as soon as possible, I have several issues in my real life at the moment, so please have some patience.
It's been more than a month since your last reply, and my forum is still crippled with these "hacked" errors as my forum moderators can't move topics without fearing that they are breaking the forum. Can you please fix this serious bug, ASAP?
You should uninstall it
Quote from: Nibogo on January 11, 2011, 05:47:15 PM
You should uninstall it
Does that mean you've abandoned this mod also?
Dunno yet, maybe, maybe not.
Quote from: sharks on December 06, 2010, 04:49:02 AMI got the same errors again, and several of the moderators on my forum also. I am using SMF 1.1.11
Hacking attempt...
INSERT INTO smf_personal_messages
(ID_MEMBER_FROM, deletedBySender, fromName, msgtime, subject, body)
VALUES (670, 1, SUBSTRING('crazyer', 1, 255), 1291600677, SUBSTRING('A'IE Delight with electric CBT', 1, 255), SUBSTRING('The topic you created at general named A\'IE Delight with electric CBT has been moved to the Bin. Please understand that this has been done to keep order in the forum..
The image is not working.', 1, 65534))
File: /home/sharks/sea/smf/Sources/Subs-Post.php
Line: 831
This seems to have something to do with apostrophes in the subject : A
'IE Delight with electric CBT, it's difficult to see it, I made it bold, red and a bit larger.
I'll see what I can do since Nibogo doesn't seem to support his own mods anymore......
This seems to work for me :
// This is the one that will go in their inbox.
$htmlmessage = $func['htmlspecialchars']($message, ENT_QUOTES);
$htmlsubject = $func['htmlspecialchars']($subject);
preparsecode($htmlmessage);
// This is the one that will go in their inbox.
$htmlmessage = $func['htmlspecialchars']($message, ENT_QUOTES);
$htmlsubject = $func['htmlspecialchars']($subject);
$htmlsubject = addslashes($subject);
preparsecode($htmlmessage);
The extra line $htmlsubject = addslashes($subject); adds slashes before ' and " which are needed in SQL queries.
Thanks a lot for your invaluable help to fix this long overdue and forever annoying bug, HunterP. Can you please tell me what file to edit for the code above?
I will try this fix and will leave feedback if the "hacking" bug shows up again.
Quote from: sharks on January 13, 2011, 06:27:49 PM
Thanks a lot for your invaluable help to fix this long overdue and forever annoying bug, HunterP. Can you please tell me what file to edit for the code above?
I will try this fix and will leave feedback if the "hacking" bug shows up again.
Sorry, that's the Subs-Post.php
I've just noticed that this does fixes the Hacking message, but shows slashes before the apostrophes in the subject. Anyhow, that seems better than an error, doesn't it? I'll have to see if this can be fixed to. Done this previously with an other mod, but have to find a bit more time.
Ok, i have made the modifications. Now we wait and see if the error happens again. Hopefully never again! :)
I hope you can further improve this mod, HunterP.
Unfortunately I'm not yet able to get rid of the backslashes in the subject, but more important is that the hacking error doesn't occur anymore. You can just test it on a topic which contains one or more ' in the subject. Try it with and without the extra line.
Ok, better is this change :
// This is the one that will go in their inbox.
$htmlmessage = $func['htmlspecialchars']($message, ENT_QUOTES);
$htmlsubject = $func['htmlspecialchars']($subject);
preparsecode($htmlmessage);
// This is the one that will go in their inbox.
$htmlmessage = $func['htmlspecialchars']($message, ENT_QUOTES);
$htmlsubject = $func['htmlspecialchars'](addslashes($subject));
preparsecode($htmlmessage);
The find might not be correct anymore if you'd already apply the previous change, but I think you'll understand it. The only difference is that this saves one line, that's all.
But the weirdest thing is that no backslashes appear when a PM is being sent (so the problem is fixed), but when someone replies to such a message (with a ' in the subject), then it gets backslahsed again, so that has to be a little bug in the PM-function itself. You can test this by PM'ing yourself with a ' in the subject. The received PM will show \'
I have replaced the previous code with the updated one above.
For those who might be wondering where to find the Subs-Post.php file to edit, go to the Sources folder.
Thanks again for the updated fix, HunterP. :D Finally got rid of this really old and annoying bug is a real relief!
Sorry, I don't want to make it unnecessarily difficult, but forget about my previous 'hack' and use this one, which is only related to this specific modification :
In MoveTopic.php :
$pm_move_topic_body = preg_replace('~<br(?: /)?' . '>~', "\n", $pm_move_topic_body);
$pm_move_topic_body = un_htmlspecialchars($pm_move_topic_body);
$subject = addslashes($subject);
This adds slashes before the notification goes to Subs-Post.php and does not add slashes when normal PM's are sent.
Done. I'll leave feedback if anything crops up, but i think this problem is now as settled as it can be. Hopefully. :)
will this be updated to RC5
How can i make one of the lines from the PM message to turn red? I know it must be quite simple, but i don't know PHP. I know how to make line breaks and smalltext, but not change colours.
Any help?
Updated to SMF 2.0
Quote from: Nibogo on June 29, 2011, 03:07:40 PM
Updated to SMF 2.0
Does this include any bug fixes? Also, you should edit the title of the first post, as it still says: "Move Topic Notification [Now with SMF RC3 Support & Commands Fixed]" so i think you should remove the mention of RC3 so as to let people know that it has been finally updated for 2.0 final.
Quote from: sharks on June 30, 2011, 09:37:52 AM
Quote from: Nibogo on June 29, 2011, 03:07:40 PM
Updated to SMF 2.0
Does this include any bug fixes? Also, you should edit the title of the first post, as it still says: "Move Topic Notification [Now with SMF RC3 Support & Commands Fixed]" so i think you should remove the mention of RC3 so as to let people know that it has been finally updated for 2.0 final.
Thanks, could you update the remaining bugs please?
Nibogo, here is one of the major issues that i've encountered and which HunterP resolved. I think it would be wise if you could integrate this fix into your 2.0 mod so others won't have errors when moving topics.
Quote from: HunterP on January 14, 2011, 01:23:20 PM
Sorry, I don't want to make it unnecessarily difficult, but forget about my previous 'hack' and use this one, which is only related to this specific modification :
In MoveTopic.php :
$pm_move_topic_body = preg_replace('~<br(?: /)?' . '>~', "\n", $pm_move_topic_body);
$pm_move_topic_body = un_htmlspecialchars($pm_move_topic_body);
$subject = addslashes($subject);
This adds slashes before the notification goes to Subs-Post.php and does not add slashes when normal PM's are sent.
I've re-uploaded a package with that fix included, I didn't even tested due to lack of time, but I trust you so I just implemented
Quote from: Nibogo on June 30, 2011, 12:44:37 PM
I've re-uploaded a package with that fix included, I didn't even tested due to lack of time, but I trust you so I just implemented
I have been using that fix ever since it was posted by HunterP, and encountered zero errors since then, so it must be right! Thanks for implementing it into the official mod package - that will make it easier for other users, especially newbies. :)
Hello,
I installed your MOD on Version 2.0 Gold. Everything was successully when it installed. I click "Move Topic" and got the same OLD Move Post, etc.. see screenshot
Have I missed something in Settings, etc
I'm using the SMF Default Theme - Curve
any idea would be appreciated. Thanks
Quote from: Martingonnella on August 02, 2011, 02:03:20 PM
I installed your MOD on Version 2.0 Gold. Everything was successully when it installed. I click "Move Topic" and got the same OLD Move Post, etc.. see screenshot
If you are testing on a topic which YOU have started, you can't notify yourself :)
Hi,
I installed this mod without an error. It operates correctly except giving me this error in error log when me or a moderator try to move a topic
Quotehttp://xxx.com/index.php?action=movetopic;topic=1270.0
8: Undefined index: child_level
File: ../Themes/default/MoveTopic.template.php
Line: 42
this is the line
35 foreach ($context['categories'] as $category)
36 {
37 echo '
38 <optgroup label="', $category['name'], '">';
39
40 foreach ($category['boards'] as $board)
41 echo '
42 <option value="', $board['id'], '"', $board['selected'] ? ' selected="selected"' : '', $board['id'] == $context['current_board'] ? ' disabled="disabled"' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level']-1) . '=> ' : '', $board['name'], '</option>';
43 echo '
44 </optgroup>';
45 }
any idea what needs to be changed to bypass the error?
thanks
I checked all edit of this mod (only three) are all ok. the only one I did not find is this
Find: [Select]
</div>
<br />
Replace With: [Select]
</div>
<br />';
// PM Notification text.
if($context['allow_notify'])
echo '
<label for="postNotify"><input type="checkbox" name="postNotify" id="postNotify" checked="checked" onclick="document.getElementById(\'notifyArea\').style.display = this.checked ? \'block\' : \'none\';" class="check" /> ', $txt['moveTopic5'], '.</label><br />
<div id="notifyArea" style="margin-top: 1ex;">
', $txt['movetopic_notify_desc'], '<br />
<textarea name="notify" rows="5" cols="40">', $txt['movetopic_notify_default'], '</textarea><br />
</div>
<br />';
echo '
This operation isn't vital to the installation of this mod.
:-\
Quote from: BaghdadGhost on July 10, 2012, 01:40:24 AM
Hi,
I installed this mod without an error. It operates correctly except giving me this error in error log when me or a moderator try to move a topic
Quotehttp://xxx.com/index.php?action=movetopic;topic=1270.0
8: Undefined index: child_level
File: ../Themes/default/MoveTopic.template.php
Line: 42
this is the line
35 foreach ($context['categories'] as $category)
36 {
37 echo '
38 <optgroup label="', $category['name'], '">';
39
40 foreach ($category['boards'] as $board)
41 echo '
42 <option value="', $board['id'], '"', $board['selected'] ? ' selected="selected"' : '', $board['id'] == $context['current_board'] ? ' disabled="disabled"' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level']-1) . '=> ' : '', $board['name'], '</option>';
43 echo '
44 </optgroup>';
45 }
any idea what needs to be changed to bypass the error?
thanks
I have the same problem.
how to make this default active?
This mod is in need of a revision. I tried to use with SMF 2.07. More without success :(
Emulating should do it.
Quote from: DSystem on March 02, 2014, 04:23:19 PM
This mod is in need of a revision. I tried to use with SMF 2.07. More without success :(
I agree- would really like to see this updated for 2.0.7
will this be updated to 2.1
Don't work on 2.14
Failed to load "main" template when click on "move topic" button. :(
It's not compatible with 2.1.x as stated in the compatible versions.
In 2.1.x there's a similar functionality built-in, sending alerts instead.
Quote from: Diego Andrés on October 26, 2023, 10:49:45 PMIt's not compatible with 2.1.x as stated in the compatible versions.
In 2.1.x there's a similar functionality built-in, sending alerts instead.
I can't find this function, what is?
In the notification settings.
See attached.
It's not exactly the same :'(