Simple Machines Community Forum

SMF Development => Feature Requests => Applied or Declined Requests => Topic started by: Mike Bobbitt on September 28, 2004, 02:54:17 PM

Title: PM Inbox Full Notification
Post by: Mike Bobbitt on September 28, 2004, 02:54:17 PM
I've had a few users with full inboxes, and it got me thinking. Maybe replace

QuoteHey, Mike Bobbitt, you have 228 messages, 0 are new.

with

QuoteHey, Mike Bobbitt, you have 228 messages, 0 are new. Your Inbox is full!

When a user's PM inbox is full...


Thanks
Mike
Title: Re: PM Inbox Full Notification
Post by: [Unknown] on September 28, 2004, 03:22:19 PM
I think I can talk Compuart into this for 1.0.

-[Unknown]
Title: Re: PM Inbox Full Notification
Post by: Mike Bobbitt on September 28, 2004, 03:26:20 PM
:D
Title: Re: PM Inbox Full Notification
Post by: Owdy on September 28, 2004, 03:27:44 PM
Finally :D
Title: Re: PM Inbox Full Notification
Post by: Tristan Perry on September 28, 2004, 03:59:13 PM
Finally! I was waiting for something like this.  :) Also I know there's hardly any space to do so, but would a percentage bar see it's way into 1.0? Or would this be the only thing? Because suddenely having a full inbox would get very annoying and would be un-excepted, but having a percentages bar or even a small piece of text saying how close you are to filling your outbox might be much better..
Title: Re: PM Inbox Full Notification
Post by: Cypher7 on September 28, 2004, 06:34:13 PM
Quote from: Tau Online on September 28, 2004, 03:59:13 PM
Finally! I was waiting for something like this.  :) Also I know there's hardly any space to do so, but would a percentage bar see it's way into 1.0? Or would this be the only thing? Because suddenely having a full inbox would get very annoying and would be un-excepted, but having a percentages bar or even a small piece of text saying how close you are to filling your outbox might be much better..

Or rather than a percentage bar, you could display the limit somewhere on the page of the inbox.

eg, "Total amount of received messages allowed XXX". ??
Title: Re: PM Inbox Full Notification
Post by: Tom on September 28, 2004, 06:46:35 PM
However it's done, this is a feature I have been waiting for for a long time.  :)
Title: Re: PM Inbox Full Notification
Post by: Tristan Perry on September 29, 2004, 01:03:54 PM
Quote from: Cypher7 on September 28, 2004, 06:34:13 PM
Or rather than a percentage bar, you could display the limit somewhere on the page of the inbox.

eg, "Total amount of received messages allowed XXX". ??
Yeah that may be cool.  :) Some kind of way to tell if your close to the limit or not would be much better. I'd actually give my members a PM quota then!
Title: Re: PM Inbox Full Notification
Post by: Cypher7 on September 29, 2004, 01:23:51 PM
Quote from: Tau Online on September 29, 2004, 01:03:54 PM
Quote from: Cypher7 on September 28, 2004, 06:34:13 PM
Or rather than a percentage bar, you could display the limit somewhere on the page of the inbox.

eg, "Total amount of received messages allowed XXX". ??
Yeah that may be cool.  :) Some kind of way to tell if your close to the limit or not would be much better. I'd actually give my members a PM quota then!

"Inbox capacity: XXX messages. You have XXX messages in your inbox"  Maybe!?!?
Title: Re: PM Inbox Full Notification
Post by: Tristan Perry on September 29, 2004, 01:28:06 PM
Quote from: Cypher7 on September 29, 2004, 01:23:51 PM

"Inbox capacity: XXX messages. You have XXX messages in your inbox"  Maybe!?!?
That'd be cool  :) I'd really like a bar like this, otherwise the feature is kind of useless IMO..
Title: Re: PM Inbox Full Notification
Post by: FaSan on September 29, 2004, 07:30:23 PM
The Moderators may send IM if the user is full ?
Title: Re: PM Inbox Full Notification
Post by: Mike Bobbitt on September 29, 2004, 07:56:58 PM
I believe mods (or at least admins) can already send PMs even if the PM box is full...
Title: Re: PM Inbox Full Notification
Post by: Tom on September 29, 2004, 10:22:30 PM
For each member group you can have a different PM limit (or no limit at all).
Title: Re: PM Inbox Full Notification
Post by: FaSan on January 02, 2005, 12:37:17 PM
This feature has not been more made ?
Title: Re: PM Inbox Full Notification
Post by: mytreo on January 02, 2005, 12:44:09 PM
Hi SMF,

I agree here that an Inbox full notification is definately needed, and a graphical indication of how much storage is remaining would be even better. A storage folder in the private messages would also be useful.

Did I read somewhere that there is plans for major enhancements to the Personal Message system? I'm sure I read that somewhere... :)

Best
Chris
Title: Re: PM Inbox Full Notification
Post by: FaSan on January 02, 2005, 02:02:39 PM
Ok ... i've made a little changes for notification :

Sources/Load.php :


Search

SELECT mem.*, IFNULL(a.ID_ATTACH, 0) AS ID_ATTACH


Replace

SELECT mem.*, IFNULL(a.ID_ATTACH, 0) AS ID_ATTACH, mg.maxMessages


Search

LEFT JOIN {$db_prefix}attachments AS a ON (a.ID_MEMBER = $ID_MEMBER)


Add After

LEFT JOIN {$db_prefix}membergroups AS mg ON (mg.ID_GROUP = mem.ID_GROUP OR (mem.ID_GROUP = 0 AND mg.ID_GROUP = mem.ID_POST_GROUP))


Search

'total_time_logged_in' => empty($user_settings['totalTimeLoggedIn']) ? 0 : $user_settings['totalTimeLoggedIn'],


Add After

'maxMessages' => empty($user_settings['maxMessages']) ? 0 : $user_settings['maxMessages'],



In Themes/default/index.template.php


Search

global $context, $settings, $options, $scripturl, $txt, $modSettings;


Add After

global $user_info;


Search

// Is the forum in maintenance mode?


Add Before

if ($user_info['maxMessages'] !=0 && ($user_info['maxMessages'] - $context['user']['messages']) == 0)
echo '&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<font color="#FF0000"><b><i>' . $txt['IM_Full'] . '</i></b></font>';



In Theme/default/languages/Modifications.english.php :

Search

?>


Add Before

$txt['IM_Full'] = 'Your IM Inbox is Full !!';






FaSan
Title: Re: PM Inbox Full Notification
Post by: Owdy on January 02, 2005, 02:06:31 PM
Quote from: mytreo on January 02, 2005, 12:44:09 PM
I agree here that an Inbox full notification is definately needed, and a graphical indication of how much storage is remaining would be even better. A storage folder in the private messages would also be useful.
SMF 1.1 is going to have this i 'v been told. In 1.0 user never know if his/her pm box is full.
Title: Re: PM Inbox Full Notification
Post by: FaSan on January 02, 2005, 02:11:44 PM
Quote from: Owdy on January 02, 2005, 02:06:31 PM
Quote from: mytreo on January 02, 2005, 12:44:09 PM
I agree here that an Inbox full notification is definately needed, and a graphical indication of how much storage is remaining would be even better. A storage folder in the private messages would also be useful.
SMF 1.1 is going to have this i 'v been told. In 1.0 user never know if his/her pm box is full.


Good ;)
Title: Re: PM Inbox Full Notification
Post by: Anguz on January 02, 2005, 05:47:10 PM
I believe that determining how full an inbox is by number of messages is wrong. It should be measured in bytes.
Title: Re: PM Inbox Full Notification
Post by: FaSan on January 02, 2005, 08:23:26 PM
 :-\

On MemberGroup's Setting is set for number...  ;)
Title: Re: PM Inbox Full Notification
Post by: torkil on January 28, 2005, 03:17:55 AM
I would also appreciate an option where users could choose one of the following option in their profile:

Inbox management:
(  ) Manual: Don't manage my personal messages, just give me a notice when my inbox is full. [  ] PM notice    [  ] Email notice
(  ) Automatic: When my inbox is full, automatically delete the oldest message to make room for new incoming messages. (FIFO)

In that way, users can choose the automatic option, meaning that they will never have to worry about PMs not reaching their inbox because it is full.
Title: Re: PM Inbox Full Notification
Post by: bluesyrio on March 16, 2005, 10:39:47 AM
I think Torkil's suggestions are really good.

I hope that 1.1 comes soon and with a great MP system. :)
Title: Re: PM Inbox Full Notification
Post by: geezmo on August 03, 2006, 03:15:00 AM
Can somebody confirm if the code below works for 1.1 RC2? Thanks.

Quote from: FaSan on January 02, 2005, 02:02:39 PM
Ok ... i've made a little changes for notification :

Sources/Load.php :


Search

SELECT mem.*, IFNULL(a.ID_ATTACH, 0) AS ID_ATTACH


Replace

SELECT mem.*, IFNULL(a.ID_ATTACH, 0) AS ID_ATTACH, mg.maxMessages


Search

LEFT JOIN {$db_prefix}attachments AS a ON (a.ID_MEMBER = $ID_MEMBER)


Add After

LEFT JOIN {$db_prefix}membergroups AS mg ON (mg.ID_GROUP = mem.ID_GROUP OR (mem.ID_GROUP = 0 AND mg.ID_GROUP = mem.ID_POST_GROUP))


Search

'total_time_logged_in' => empty($user_settings['totalTimeLoggedIn']) ? 0 : $user_settings['totalTimeLoggedIn'],


Add After

'maxMessages' => empty($user_settings['maxMessages']) ? 0 : $user_settings['maxMessages'],



In Themes/default/index.template.php


Search

global $context, $settings, $options, $scripturl, $txt, $modSettings;


Add After

global $user_info;


Search

// Is the forum in maintenance mode?


Add Before

if ($user_info['maxMessages'] !=0 && ($user_info['maxMessages'] - $context['user']['messages']) == 0)
echo '&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<font color="#FF0000"><b><i>' . $txt['IM_Full'] . '</i></b></font>';



In Theme/default/languages/Modifications.english.php :

Search

?>


Add Before

$txt['IM_Full'] = 'Your IM Inbox is Full !!';






FaSan
Title: Re: PM Inbox Full Notification
Post by: Owdy on August 03, 2006, 03:28:41 AM
This is built in feature in 1.1. You dont need this mod.
Title: Re: PM Inbox Full Notification
Post by: geezmo on August 03, 2006, 03:42:28 AM
I can't upgrade to 1.1 beta yet that's why I need this mod for 1.1 rc2
Title: Re: PM Inbox Full Notification
Post by: Owdy on August 03, 2006, 03:57:27 AM
Its built in feature in SMF 1.1 RC2
Title: Re: PM Inbox Full Notification
Post by: geezmo on August 03, 2006, 04:10:00 AM
Huh? I'm using 1.1RC2 Default Theme but this does not appear in my forum. My members are complaining that their inbox is full but they get no notification about it or a warning that their inbox is full. Any link to a screenshot of this in 1.1RC2 or link to SMF FAQ that mentions this. I searched FAQ and Online Manual but didn't see anything that mentions about Full PM Inbox notifications.
Title: Re: PM Inbox Full Notification
Post by: Owdy on August 03, 2006, 04:15:57 AM
Quote from: geezmo on August 03, 2006, 04:10:00 AM
Any link to a screenshot of this in 1.1RC2
Sure. Users who has limitations, should see that bar like in attacment.
Title: Re: PM Inbox Full Notification
Post by: geezmo on August 03, 2006, 04:17:36 AM
Wow, cool. I don't have that, and I'm using 1.1RC2. What a surprise! How can I add this? Should I edit/add the codes? Or download the latest 1.1RC2 version, if ever there is one?
Title: Re: PM Inbox Full Notification
Post by: Owdy on August 03, 2006, 04:20:05 AM
Quote from: geezmo on August 03, 2006, 04:17:36 AM
Wow, cool. I don't have that, and I'm using 1.1RC2.
You have it if you have SMF 1.1 RC2. Just set the limits and users should see them. If you dont have limits, you dont see it.
Title: Re: PM Inbox Full Notification
Post by: geezmo on August 03, 2006, 04:28:43 AM
Ok I think I know what the problem is. Several of my members complain that they can't see that inbox warning so that means they don't have inbox limits right? But at the same time they confirmed that some members can't send them PMs because they supposedly have exceeded quota. Is this possible?

I'm thinking it's because of usergroups. As member of Usegroup 1, they have PM quotas. But if they are members of Usergroup 2 which doesn't have quotas, they can't see the PM warning. So they actually have PM quotas because they still belong to Usergroup 1 but can't see the warning because they are also in Usergroup 2. Does this make sense? ???
Title: Re: PM Inbox Full Notification
Post by: Assistance on November 06, 2006, 05:42:36 AM
was this taken out in 1.1RC3 ? as I do not see it
even with a member of 1 group with only allowed 25
Title: Re: PM Inbox Full Notification
Post by: FinsandFur on November 08, 2006, 11:50:29 AM
wondering the same thing  :(
Title: Re: PM Inbox Full Notification
Post by: Oldiesmann on November 08, 2006, 03:27:54 PM
Administrators are immune to PM limits, even if you have a limit set for that group. It is still there and will show up as long as the PM limit applies to you (ie you're not an administrator and all of the groups you're in have a PM limit).
Title: Re: PM Inbox Full Notification
Post by: Assistance on November 09, 2006, 01:44:44 AM
my bad

had my test account as a mod :(
Title: Re: PM Inbox Full Notification
Post by: bebe on November 15, 2006, 09:44:18 PM
Quote from: Assistance on November 06, 2006, 05:42:36 AM
was this taken out in 1.1RC3 ? as I do not see it
even with a member of 1 group with only allowed 25

Please refer to this (http://www.simplemachines.org/community/index.php?topic=123696.msg812913#msg812913). Please remember you need to set the PM limits for the "Post count based groups" too even if you don't use any of them, or the PM bar things won't work.
Title: Re: PM Inbox Full Notification
Post by: Assistance on November 16, 2006, 02:36:34 AM
lol please refer to my post above yours

ty anyways ;)