Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: Matthew K. on July 16, 2007, 01:07:24 PM

Title: Bookmarks
Post by: Matthew K. on July 16, 2007, 01:07:24 PM
Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=864)

A simple mod that allows users to easily keep track of their favourite topics.

Features:

Screenshots:
Title: Re: Bookmarks
Post by: shadow82x on July 16, 2007, 01:51:34 PM
Very nice mod.
Title: Re: Bookmarks
Post by: Garry1953 on July 16, 2007, 08:10:57 PM
Works perfect. (http://skins.hotbar.com/skins/mailskins/em/google_emoticons/emoti_384.gif)
Thanks
Title: Re: Bookmarks
Post by: ES23 on July 17, 2007, 06:25:21 AM
Hi!I tried applying this mod but an error occurred.I'm using SMF 1.1.3 currently.Below are the packages I have installed in my forum.Can u pls assist me and tell me how can I correct my error??HELP!!!

1.     Registered Links      1.0       [ Uninstall ]  [ List Files ]  [ Delete ]
2.    Related Topics    1.1.1    [ Uninstall ] [ List Files ] [ Delete ]
3.    SMF Gallery Lite    1.7.5.1    [ Uninstall ] [ List Files ] [ Delete ]
4.    View Only Boards    1.1    [ Uninstall ] [ List Files ] [ Delete ]
5.    Custom Edit Times    1.1    [ Uninstall ] [ List Files ] [ Delete ]
6.    Attachment File Renamer    1.1.0    [ Uninstall ] [ List Files ] [ Delete ]
7.    SMF Links    1.6.3    [ Uninstall ] [ List Files ] [ Delete ]
8.    Bookmarks    1.0    [ Apply Mod ] [ List Files ] [ Delete ]
9.    View Topic Permissions    1.1.0a    [ Uninstall ] [ List Files ] [ Delete ]
10.    Avatars at Index Mod    1.4    [ Uninstall ] [ List Files ] [ Delete ]
11.    mp3 Flash Player BBC Tag (XHTML Compliant)    1.0    [ Uninstall ] [ List Files ] [ Delete ]
12.    Member Notepad    1.0    [ Uninstall ] [ List Files ] [ Delete ]
13.    Updated Registration Agreement    1.0    [ Uninstall ] [ List Files ] [ Delete ]
14.    Enhanced Password Reminder    1.0    [ Uninstall ] [ List Files ] [ Delete ]
15.    Alternativ Protocol Fix    1.0.0    [ Uninstall ] [ List Files ] [ Delete ]
16.    LogModAccountEdits    1.9    [ Uninstall ] [ List Files ] [ Delete ]
17.    ed2k links support    3.0.1    [ Uninstall ] [ List Files ] [ Delete ]
18.    Default Membergroup on Registration    1.0    [ Uninstall ] [ List Files ] [ Delete ]
19.    Profil Moderator Managment    1.0.0    [ Uninstall ] [ List Files ] [ Delete ]
20.    Select Admin for Notifications    1.1    [ Uninstall ] [ List Files ] [ Delete ]
21.    RedoPackageAction    1.3    [ Uninstall ] [ List Files ] [ Delete ]
22.    New Topic Button    1.0    [ Uninstall ] [ List Files ] [ Delete ]
23.    Enhanced Forum Statistics    1.0    [ Uninstall ] [ List Files ] [ Delete ]
24.    SMF Sitemap    1.1.3    [ Uninstall ] [ List Files ] [ Delete ]
25.    Spam Black List    0.2.1    [ List Files ] [ Delete ]
26.    No Reply Emails    1.0    [ Uninstall ] [ List Files ] [ Delete ]
27.    Reg Bar    1.0    [ Uninstall ] [ List Files ] [ Delete ]
28.    Enchanced post template    1.0.2    [ Uninstall ] [ List Files ] [ Delete ]
29.    Profile Comments    1.2.1    [ Uninstall ] [ List Files ] [ Delete ]
30.    Ignore Boards    2.0.1    [ Uninstall ] [ List Files ] [ Delete ]
31.    Signature Option Post    1.1    [ Uninstall ] [ List Files ] [ Delete ]
32.    SMF Staff Page    1.5.1    [ Uninstall ] [ List Files ] [ Delete ]
33.    Tagging System    1.0.3    [ Uninstall ] [ List Files ] [ Delete ]
34.    Topic Member Post Count    1.0.0    [ Uninstall ] [ List Files ] [ Delete ]
35.    Website Button    1.1.4    [ Uninstall ] [ List Files ] [ Delete ]
36.    Allowed Groups Embedded Flash    1.2.0    [ Uninstall ] [ List Files ] [ Delete ]
37.    Custom Profile Field Mod    3.16    [ Uninstall ] [ List Files ] [ Delete ]
38.    Admin Notepad    1.0    [ Uninstall ] [ List Files ] [ Delete ]
39.    Enhanced User Statistics    1.0    [ Uninstall ] [ List Files ] [ Delete ]
40.    Move Old Topics    1.2    [ Uninstall ] [ List Files ] [ Delete ]
41.    Ad Managment    2.3    [ Uninstall ] [ List Files ] [ Delete ]
42.    Display Age and Location next to posts    1.0    [ Uninstall ] [ List Files ] [ Delete ]
43.    YouTube BBC Tag (XHTML Compliant)    1.0    [ Uninstall ] [ List Files ] [ Delete ]
44.    Thank-O-Matic    1.0.1    [ Uninstall ] [ List Files ] [ Delete ]

This is the error that occurred.
3.     Execute Modification     ./Themes/default/index.template.php     Test failed

Thanks very much!!
Title: Re: Bookmarks
Post by: TrueSatan on July 17, 2007, 06:55:50 AM
This is a varient on what is the most common problems to be reported on these pages...some of your other mods have already edited the files this mod seeks to edit thus it doesn't find them in the form it expects and it reports a fail. The solution to such problems is always the same...do a manual installation of the mod...please see:

http://docs.simplemachines.org/index.php?topic=402.msg531#msg531 (http://docs.simplemachines.org/index.php?topic=402.msg531#msg531)

You may also find it helpful to use:

http://modparser.dev.dansoftaustralia.net/ (http://modparser.dev.dansoftaustralia.net/)
Title: Re: Bookmarks
Post by: nolageek on July 17, 2007, 07:43:10 AM
"bookmarking a page" usually refers to saving a page as a bookmark or favorite in your browser.. perhaps you should use the term 'track this topic' or something similar so that it doesn't confuse users?  Just a thought.
Title: Re: Bookmarks
Post by: tonzi on July 17, 2007, 08:29:31 AM
$txt['bookmarks'] = 'My Bookmarks'; $txt['bookmark_list'] = 'Bookmarks'; $txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.'; $txt['bookmark_open_window'] = 'Open in new window'; $txt['bookmark_delete'] = 'Delete bookmark'; $txt['bookmark_delete_success'] = 'The bookmark was deleted successfully!'; $txt['bookmark_delete_failure'] = 'The bookmark couldn\'t be deleted.'; $txt['bookmark_add'] = 'Add bookmark'; $txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!'; $txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!'; $txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';

this appears above of my forum
Title: Re: Bookmarks
Post by: tonzi on July 17, 2007, 09:24:28 AM
i get rid of it but it seems not working. is there an admin for this mod?
Title: Re: Bookmarks
Post by: shadow82x on July 17, 2007, 10:14:54 AM
It looks like its interfering with other mods.
Title: Re: Bookmarks
Post by: TrueSatan on July 17, 2007, 10:30:54 AM
@ tonzi

You have the same problem here as you had with the friendly YouTube mod. I posted the solution to it there for you.
Title: Re: Bookmarks
Post by: tonzi on July 17, 2007, 10:40:07 AM
youtube is working fine now coz i just get rid of the codes that showed above my forum. and i did the same in bookmark but the prob is, the function of this mod didnt showed up or work.
Title: Re: Bookmarks
Post by: TrueSatan on July 17, 2007, 11:00:45 AM
Had you followed what I told you to do it would work!
Title: Re: Bookmarks
Post by: tonzi on July 17, 2007, 11:06:31 AM
yah to have ?>  once.
Title: Re: Bookmarks
Post by: TrueSatan on July 17, 2007, 11:25:38 AM
Note...You should have

?>

...not only shown once but, as previously, and repeatedly, stated at the end of the file on a line of its own. This mod now failing to work appears to be because you decided to remove the code you quoted above instead of taking the action previously advised:


$txt['bookmarks'] = 'My Bookmarks';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.';
$txt['bookmark_open_window'] = 'Open in new window';
$txt['bookmark_delete'] = 'Delete bookmark';
$txt['bookmark_delete_success'] = 'The bookmark was deleted successfully!';
$txt['bookmark_delete_failure'] = 'The bookmark couldn\'t be deleted.';
$txt['bookmark_add'] = 'Add bookmark';
$txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!';
$txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!';
$txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';


This code is needed, it should not have been removed. You need to replace the code and then make sure that:

?>

...appears once only, at the end of the file and on a line of its own.
Title: Re: Bookmarks
Post by: Ataraxicstorm on July 17, 2007, 12:30:29 PM
-- sorry.. deleted message while i sort it :) --
Title: Re: Bookmarks
Post by: TrueSatan on July 17, 2007, 12:35:01 PM
 I'd first try making the install file run manually...extract install.php from the package then upload it to your forum root...next simply load the file in your browser by going to it...that should make it add the tables to your database. This is quite a common issue with some mods...arcade mod for instance.

Just read the install.php in a text editor to see what tables it adds if you land up having to do the work via phpMyAdmin
Title: Re: Bookmarks
Post by: Ataraxicstorm on July 17, 2007, 12:38:02 PM
Quote from: TrueSatan on July 17, 2007, 12:35:01 PM
I'd first try making the install file run manually...extract install.php from the package then upload it to your forum root...next simply load the file in your browser by going to it...that should make it add the tables to your database. This is quite a common issue with some mods...arcade mod for instance.

Just read the install.php in a text editor to see what tables it adds if you land up having to do the work via phpMyAdmin

ok thanks... turned out it had created the tables ( i jus missed them )

this is the error imgetting

QuoteUnknown column 'b.ID_TOPIC' in 'field list'
File: /home/content/R/a/v/Ravers/html/forum/Sources/Bookmarks.php
Line: 48
Title: Re: Bookmarks
Post by: Ataraxicstorm on July 17, 2007, 12:44:25 PM
Quote from: TubeRavers on July 17, 2007, 12:38:02 PM


ok thanks... turned out it had created the tables ( i jus missed them )

this is the error imgetting

QuoteUnknown column 'b.ID_TOPIC' in 'field list'
File: /home/content/R/a/v/Ravers/html/forum/Sources/Bookmarks.php
Line: 48

fixed it...

the tables needed are ID_MEMBER and ID_TOPIC, but it created user_id and topic_id.. not sure what happened there :S

either way its all good now
Title: Re: Bookmarks
Post by: TrueSatan on July 17, 2007, 12:50:32 PM
OK...glad you got it sorted out.
Title: Re: Bookmarks
Post by: tonzi on July 17, 2007, 10:12:53 PM
Quote from: TrueSatan on July 17, 2007, 11:25:38 AM
Note...You should have

?>

...not only shown once but, as previously, and repeatedly, stated at the end of the file on a line of its own. This mod now failing to work appears to be because you decided to remove the code you quoted above instead of taking the action previously advised:


$txt['bookmarks'] = 'My Bookmarks';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.';
$txt['bookmark_open_window'] = 'Open in new window';
$txt['bookmark_delete'] = 'Delete bookmark';
$txt['bookmark_delete_success'] = 'The bookmark was deleted successfully!';
$txt['bookmark_delete_failure'] = 'The bookmark couldn\'t be deleted.';
$txt['bookmark_add'] = 'Add bookmark';
$txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!';
$txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!';
$txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';


This code is needed, it should not have been removed. You need to replace the code and then make sure that:

?>

...appears once only, at the end of the file and on a line of its own.

sorry but I think I did that but still didnt work im now confused can you please place a code on what should i exactly place on my modifications.english.php? plsss thanks.
Title: Re: Bookmarks
Post by: tonzi on July 17, 2007, 10:24:19 PM
nvm I fixed it there was a ; exceded thats why i am having a template parse error i just removed it and put back the bookmarks codes that i removed and put ?> at the end of its line and it showed up now its working perfectly. thank you very much for the help. :)
Title: Re: Bookmarks
Post by: xOraclex on July 18, 2007, 05:26:02 AM
Works fine.
Thanks.
Title: Re: Bookmarks
Post by: medflux on July 18, 2007, 08:45:36 PM
plz people i have a problem here... i've installed the mod and the installation was just perfect , but when i went to check it , i didn't find the buttons of the mod neither in the toics nor "my bookmarks" at the top bar .... i think i know the cause , that is i'm using a different theme for my forum which is "New Damage"...I tested the mod with the default SMF theme and it worked just fine

my forum theme can be found here:
http://custom.simplemachines.org/themes/index.php?lemma=107

and it's demo here : http://www.webtechnica.net/demoforum/index.php?action=forum;theme=4

Just can anyone tell me how can i make the theme display the new buttons both in the topics and in the top bar??? i think i should add them but don't know how ???

Hope you can help me or refer me to a topic or something ,

Thanks a bunch!
Title: Re: Bookmarks
Post by: TrueSatan on July 18, 2007, 09:59:30 PM
Yep:

http://docs.simplemachines.org/index.php?topic=402.msg531#msg531 (http://docs.simplemachines.org/index.php?topic=402.msg531#msg531)

...and you might find this useful too:

http://modparser.dev.dansoftaustralia.net/ (http://modparser.dev.dansoftaustralia.net/)
Title: Re: Bookmarks
Post by: medflux on July 19, 2007, 01:45:19 PM
thanks a zillion TrueSatan...i read the topics and it was useful , but after i apply this , should i design new buttons to incorporate them into their respective bars , i mean to maintain the same look of the forum theme? and how i link to them???
thanks again and hope you can help me
Title: Re: Bookmarks
Post by: TrueSatan on July 19, 2007, 09:04:11 PM
If you want to maintain aesthetics then new buttons are likely to be needed (I'm sure there's a automatic button generator somewhere on the theme related pages here.)

I suspect that you'd be better looking in theme support for this sort of advice though...not really my area (actually I only use one theme...it's called SMF Default and everything installs into it without a hitch.)
Title: Re: Bookmarks
Post by: Ataraxicstorm on July 20, 2007, 12:39:40 PM
how easy would it be to get this mod to say if there was new replies to a bookmark? Its an awesome mod, very needed on my forum, and that would be the only missing feature I think.
Title: Re: Bookmarks
Post by: Aaron on July 20, 2007, 04:59:07 PM
Good request! It'll mean some extra code, but that's definitely worth it. I'll put it on my todo list.
Title: Re: Bookmarks
Post by: Pranav on July 23, 2007, 09:06:01 AM
I get this error :

Quote3.     Execute Modification     ./Themes/default/index.template.php     Test failed

I have installed :

SMFShop 3.0
SMF Shoutbox      1.16
Users Online Today Mod      1.4.0
SMF Links      1.6.3
PM On Registration      1.0.2
Googlebot & Spiders Mod      2.0.3
Ad Managment      2.3
Global Announcements      1.0
SMF Trader System      1.1
Member Color Link      2.0.0

And i am using SMF 1.1.3 .
Title: Re: Bookmarks
Post by: karlbenson on July 25, 2007, 01:34:13 PM
Aaron, may I ask what is the difference between this and the other bookmark mod?
Title: Re: Bookmarks
Post by: Aaron on July 25, 2007, 02:13:37 PM
The one by LeipePo, you mean? Sure, I'll try to describe why I felt it necessary to make my own mod instead of adapting his.

That's about it. :)
Title: Re: Bookmarks
Post by: karlbenson on July 25, 2007, 03:43:03 PM
Thanks for that.
I'm currently using a modified version of LeipePo's which I posted in thats mods bookmark topic.

I just wondered whether you had taken over that modification.
Title: Re: Bookmarks
Post by: TrueSatan on July 25, 2007, 05:21:43 PM
Actually I'm still supporting LeipePo's version...no harm in giving choice to users...and have a newer revision of it available via SMF Helper. LeipePo posted allowing his mod to be taken over and I've credited karlbenson in the read me for the additional code revision he provided (thanks again Karl.)

If the revised version continues to lack any reports of problems (so far zero) I'll ask SMF to let me take it over formally.
Title: Re: Bookmarks
Post by: karlbenson on July 25, 2007, 06:51:39 PM
No worries truesatan.

I'm glad you've been able to take it over.  Btw, don't feel you need to credit me.

Best of luck with both bookmark mods. (maybe with improvements and expansions of both, they may end up differing quite a bit, and smf much the better for it).
Title: Re: Bookmarks
Post by: jeffest123 on July 26, 2007, 04:37:06 PM
I Love this mod but I noticed it's available if I enter my forum as a guest and I would prefer a visitor register first before having access to that. Is there any way to change it so it's only available for registered users? Thanks.

jEFF =)
Title: Re: Bookmarks
Post by: Aaron on July 26, 2007, 04:38:44 PM
Quote from: jeffest123 on July 26, 2007, 04:37:06 PM
I Love this mod but I noticed it's available if I enter my forum as a guest and I would prefer a visitor register first before having access to that. Is there any way to change it so it's only available for registered users? Thanks.

Now that is a big oops. Will fix that immediately.
Title: Re: Bookmarks
Post by: jeffest123 on July 26, 2007, 04:45:00 PM
Very cool, thanks.  :)
Title: Re: Bookmarks
Post by: Aaron on July 26, 2007, 04:57:45 PM
Alright, made a quick fix for it. You can download it from this page (http://custom.simplemachines.org/mods/index.php?mod=864).

Any bookmarks guests may have added can be removed by running the following query in PHPMyAdmin:
DELETE FROM `smf_bookmarks` WHERE `ID_MEMBER` = 0

Note that you'll need to replace "smf_" with the forum table prefix you're using.

I apologize for any inconvenience this bug may have caused.
Title: Re: Bookmarks
Post by: jeffest123 on July 26, 2007, 05:20:43 PM
Thanks for the quick fix. I'm still building my forum so no active members besides myself yet. One thing though, instead of a message, is there any way to simply not have the tag visible for guests? I suppose I could live with it as is though since it would encourage guests to register, but having it there is kind of a tease. Either way is fine - it's a great feature.

jEFF =)
Title: Re: Bookmarks
Post by: Aaron on July 26, 2007, 05:28:30 PM
Open index.template.php and find:

'bookmark' => array('text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


Replace that line with:

'bookmark' => array('text' => 'bookmark_add', 'test' => 'edit_profile', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


That should hide the button for members who don't have permission to edit their profiles.

Note: I'm planning to include a real permission (something like can_manage_bookmarks) in the next version (1.1). So then you have more control over which membergroups can and which membergroups cannot add bookmarks. :) As I plan to make that sometime this week, I didn't include the fix mentioned above in version 1.0.1. :)
Title: Re: Bookmarks
Post by: jeffest123 on July 26, 2007, 05:58:04 PM
I thought I was going blind because I couldn't find that line in Index.template.php but then I found it in Display.template.php (I assume that's the file you meant), however changing it removed the bookmark tag for everyone so I changed it back. I can live with it until the new version comes out. Thanks again for your quick responses. 

Oh yeah, the message that comes up for guests has a slight mispelling so you might want to fix that for the next version.:)
QuoteSorry, only registred members of this community can use the bookmarks feature!
Title: Re: Bookmarks
Post by: diegolyanky on July 28, 2007, 12:26:14 PM
Installed but don't work on helios_multi theme, and is very hard to midify manually, be cause helios_multi has index.template.php and display.template.php are very differents.

Any ideas ?
Title: Re: Bookmarks
Post by: naturalwoman on July 28, 2007, 10:53:08 PM
can anyone tell my why the test failed. using smf113

Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/RemoveTopic.php Test successful
3. Execute Modification ./Themes/default/index.template.php Test failed
4. Execute Modification ./Themes/default/Display.template.php Test successful
5. Execute Modification ./Themes/default/languages/Modifications.dutch.php Test successful
6. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
7. Extract File ./Sources/Bookmarks.php 
8. Extract File ./Themes/default/Bookmarks.template.php 
9. Execute Code install.php 

i need to do a manual install??
Title: Re: Bookmarks
Post by: ~Kikoish~ on August 09, 2007, 06:02:05 AM
It doesn't work with mine.

It says:
Quote
530 Login authentication failed

So how to resolve this?
Title: Re: Bookmarks
Post by: Aaron on August 09, 2007, 06:05:07 AM
Quote from: ~Kikoish~ on August 09, 2007, 06:02:05 AM
It doesn't work with mine.

It says:
Quote
530 Login authentication failed

So how to resolve this?

The FTP credentials (username/password) you specified in the package manager are incorrect.
Title: Re: Bookmarks
Post by: saosangmo on August 17, 2007, 08:24:39 AM
I have just complete installation, version 101, I test for adding some bookmarks, but when i click on My Bookmarks, It report
"You don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics."
how to fix?
Title: Re: Bookmarks
Post by: Aaron on August 17, 2007, 09:07:37 AM
That message is completely normal. You simply haven't add any bookmarks yet! I assume you're looking for the button? Here's how to fix it.

Open up your custom theme's Display.template.php, and find:


'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Add after:


'bookmark' => array('text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


Save the file, and the button should appear in topics.
Title: Re: Bookmarks
Post by: saosangmo on August 17, 2007, 01:03:47 PM
my code in Display.template.php

   // Build the normal button array.
   $normal_buttons = array(
      'new_topic' => array((allowedTo('post_new')) ? 1 : 'test' => 'nothinglol', 'text' => 'smf258', 'image' => 'new_topic.gif', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0'),
      'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
'bookmark' => array('text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
      'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
      'custom' => array(),
      'send' => array('test' => 'can_send_topic', 'text' => 707, 'image' => 'sendtopic.gif', 'lang' => true, 'url' => $scripturl . '?action=sendtopic;topic=' . $context['current_topic'] . '.0'),
      'print' => array('text' => 465, 'image' => 'print.gif', 'lang' => true, 'custom' => 'target="_blank"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'),


when I add one bookmark in one topic. It reports:

This topic is already listed in your bookmarks!

Bookmarks
You don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics.
Title: Re: Bookmarks
Post by: redactor007 on August 18, 2007, 10:40:42 AM
Quote from: naturalwoman on July 28, 2007, 10:53:08 PM
can anyone tell my why the test failed. using smf113

Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/RemoveTopic.php Test successful
3. Execute Modification ./Themes/default/index.template.php Test failed
4. Execute Modification ./Themes/default/Display.template.php Test successful
5. Execute Modification ./Themes/default/languages/Modifications.dutch.php Test successful
6. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
7. Extract File ./Sources/Bookmarks.php 
8. Extract File ./Themes/default/Bookmarks.template.php 
9. Execute Code install.php 

i need to do a manual install??

I have the same problem and I'm using 1.1.3.  Any suggestions?
Title: Re: Bookmarks
Post by: saosangmo on August 18, 2007, 02:04:10 PM
I'm using pretty-URL mod, this may cause the message "This topic is already listed in your bookmarks!" whenever I click on "Add Bookmark" button in every topic.
any idea?
Title: Re: Bookmarks
Post by: psiva on August 26, 2007, 11:21:14 PM
Hi,

Am not able to see any of the bookmark mod buttons even after I had made changes to the custom theme. The script is somehow I believe not able to pick up the values in the modifications.english.php.

Can anybody help me out with this? Am I missing something here.
Title: Re: Bookmarks
Post by: slackerpunk on August 27, 2007, 01:34:16 AM
where do you actually see the bookmarked list? I am unable to add and delete bookmarks but do not know where to see the list
Title: Re: Bookmarks
Post by: RoccoGD on August 27, 2007, 05:16:03 AM
the mod worked fine for me, but only in the english version.
we have german as standard language in the board, and there are no bookmark icons in the german theme.
what can i edit to see the buttons also in the german language version (standard theme)

EDIT: ok i found the solution bymyself.
in folder Themes/default/languages
is the language file - Modifications.german.php, this file should look like this in the german version.


<?php
// Version: 1.1; Modifications

$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast im Moment keine Lesezeichen. Klick auf \'Lesezeichen hinzufuegen\' in den Beitraegen.';
$txt['bookmark_open_window'] = 'In neuem Fenster oeffnen';
$txt['bookmark_delete'] = 'Lesezeichen loeschen';
$txt['bookmark_delete_success'] = 'Das Lesezeichen wurde geloescht!';
$txt['bookmark_delete_failure'] = 'Das Lesezeichen konnte nicht geloescht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzufuegen';
$txt['bookmark_add_success'] = 'Der Beitrag wurde zu deinen Lesezeichen hinzugefuegt!';
$txt['bookmark_add_exists'] = 'Dieser Beitrag ist bereits in deinen Lesezeichen vorhanden!';
$txt['bookmark_add_failed'] = 'Lesezeichen für diesen Beitrag konnte nicht hinzugefuegt werden.';
?>



Title: Re: Bookmarks
Post by: tatore on August 27, 2007, 02:59:04 PM
How to add, in this context

$buttonArray = array();
if ($context['can_reply'])
$buttonArray[] = '<a href="' . $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/reply.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';
if ($context['can_mark_notify'])
$buttonArray[] = '<a href="' . $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id'] . '" onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/notify.gif" alt="' . $txt[131] . '" border="0" />' : $txt[131]) . '</a>';

the modification
$normal_buttons = array(
'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
'bookmark' => array('text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
?


Edit: nevermind..solved.
Title: Re: Bookmarks
Post by: slackerpunk on August 28, 2007, 12:48:03 AM
anyone got any answers for my query?

once added where do you actually see the list of your bookmarked threads?
Title: Re: Bookmarks
Post by: psiva on August 28, 2007, 01:25:47 AM
I could solve the problem. I moved the text from Modifications.engilsh.php to Modifications.engish-utf8.php. And it worked. :)
Title: Re: Bookmarks
Post by: psiva on August 28, 2007, 10:40:27 AM
@slackerpunk

You can find the list of your bookmarks in the My Bookmarks section. Once you have succesfully installed the mod, you shlould be able to find ' My Bookmarks' in the header menu.

Title: Re: Bookmarks
Post by: slackerpunk on August 28, 2007, 10:59:32 AM
that is the thing I am missing I cannot see the my bookmarks menu
Title: Re: Bookmarks
Post by: psiva on August 28, 2007, 10:52:05 PM
If you are using any custom theme, then you need to manually apply the changes for the menu to appear.
Title: Re: Bookmarks
Post by: sennad on September 06, 2007, 05:06:49 AM
Great idea, sure, but it is not of a maximum use if users can't see if there are new replies on posts. I can bookmark topics in my browser and get same thing as this.

What would be great is that this mod shows in which of topics are new replies ("new" icon), or if it would show ony bookmarked topics that has new replies (like in "Show unread posts since last visit", but just for bookmarked topics).
Title: Re: Bookmarks
Post by: Ra__ on September 21, 2007, 11:54:06 AM
If and when you update this mod, can you add an SSI function?
Title: Re: Bookmarks
Post by: edi67 on September 21, 2007, 04:34:59 PM
nice mod thx
Title: Re: Bookmarks
Post by: Jacque on September 24, 2007, 02:17:57 AM
Hi,
I was going to ask help in solving my problem, but I'm diligent, and tried a few more things.  I found the problem, and thought I'd post it here.

I had no bookmark item on the topic menu, and forum error messages were:

8: Undefined index: bookmarks
File: /forum/Themes/default/BoardIndex.template.php (eval?)
Line: 580

8: Undefined index: bookmarks
File: /forum/Themes/default/Errors.template.php (eval?)
Line: 580

8: Undefined index: bookmarks
File: /forum/Themes/default/BoardIndex.template.php (eval?)
Line: 580


8: Undefined index: bookmark_add
File: /forum/Themes/default/Display.template.php (eval?)
Line: 643

8: Undefined index: bookmarks
File: /forum/Themes/default/MessageIndex.template.php (eval?)
Line: 580


What fixed everything was editing the file /Themes/default/languages/Modifications.english.php  to Modifications.english-utf8.php

Just in case it helps someone else out there.

Jacque
Title: Re: Bookmarks
Post by: Paracelsus on September 24, 2007, 10:23:21 AM
Quote from: sennad on September 06, 2007, 05:06:49 AM
Great idea, sure, but it is not of a maximum use if users can't see if there are new replies on posts. I can bookmark topics in my browser and get same thing as this.

What would be great is that this mod shows in which of topics are new replies ("new" icon), or if it would show ony bookmarked topics that has new replies (like in "Show unread posts since last visit", but just for bookmarked topics).

I'm trying to mod this MOD ;) because I'm also looking for this function. I believe that the answer lies in the way the topics and boards notification list is made.
Title: Re: Bookmarks
Post by: alex111 on September 25, 2007, 09:47:30 PM
Great mod. I installed it by hand and it works perfectly.

Two things that I hope that you will consider adding (along with showing which topics have new replies):

1) folders: add the ability for users to create folders, add new bookmarks to specific folders and sort their bookmarks into folders

2) pagination: create a "page 2" after 100 or so bookmarks so that a huge bookmark list doesn't take a while to load

These are features that my users have repeatedly asked for when using our old bookmark hack.
Title: Re: Bookmarks
Post by: Paracelsus on September 28, 2007, 10:24:45 AM
I'm getting back on this because my PHP skills aren't still good enough...  ;)

So, the goal is to make the "New" button appear in front of topics with new messages in the bookmark topic list... So, I've checked the Notifications code which has this function working perfectly and found in Profile.template.php this piece of code to call that button:

foreach ($context['topic_notifications'] as $topic)
{
echo '
<tr>
<td class="windowbg" valign="middle" width="48%">
', $topic['link'];

if ($topic['new'])
echo ' <a href="', $topic['new_href'], '"><img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/new.gif" alt="', $txt[302], '" /></a>';



The problem is I can't get this to work together with the code in Bookmark.template.php:



// Show the bookmarks if there are any



if (isset($context['bookmarks']))



{





// Show each bookmark





foreach($context['bookmarks'] as $bookmark)





{





    echo '



            <tr>
                    <td class="windowbg"><a href="', $scripturl, '?topic=', $bookmark['id'], '.new">', $bookmark['title'], '</a></td>
                    <td class="windowbg2" width="30"><a href="', $scripturl, '?topic=', $bookmark['id'], '.0" target="_blank"><img src="', $settings['images_url'], '/buttons/im_reply.gif" title="', $txt['bookmark_open_window'], '" alt="', $txt['bookmark_open_window'], '" /></a></td>
               



<td class="windowbg2" width="30"><a href="', $scripturl, '?action=bookmarks;sa=delete;topic=', $bookmark['id'], '"><img src="', $settings['images_url'], '/buttons/delete.gif" title="', $txt['bookmark_delete'], '" alt="', $txt['bookmark_delete'], '" /></a></td>



            </tr>';





}



}


Can someone with expertise in PHP help with this?
Title: Re: Bookmarks
Post by: RoboO on September 30, 2007, 12:25:08 AM
Quote from: diegolyanky on July 28, 2007, 12:26:14 PM
Installed but don't work on helios_multi theme, and is very hard to midify manually, be cause helios_multi has index.template.php and display.template.php are very differents.

Any ideas ?

I'm having this same problem.  Did you ever find a fix for it?
Title: Re: Bookmarks
Post by: Alpay on November 05, 2007, 06:05:47 AM
help ..

Unknown column 'b.ID_TOPIC' in 'field list'
Dosya: /..../Sources/Bookmarks.php
Satır: 52

(http://www.simplemachines.org/community/Smileys/simple/sad.gif)
ok fixed tablo drop... new tablo =)
Title: Re: Bookmarks
Post by: Altair on November 08, 2007, 11:20:10 AM
Quote from: Paracelsus on September 28, 2007, 10:24:45 AM
I'm getting back on this because my PHP skills aren't still good enough...  ;)

So, the goal is to make the "New" button appear in front of topics with new messages in the bookmark topic list... So, I've checked the Notifications code which has this function working perfectly and found in Profile.template.php this piece of code to call that button:

foreach ($context['topic_notifications'] as $topic)
{
echo '
<tr>
<td class="windowbg" valign="middle" width="48%">
', $topic['link'];

if ($topic['new'])
echo ' <a href="', $topic['new_href'], '"><img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/new.gif" alt="', $txt[302], '" /></a>';



The problem is I can't get this to work together with the code in Bookmark.template.php:



// Show the bookmarks if there are any



if (isset($context['bookmarks']))



{





// Show each bookmark





foreach($context['bookmarks'] as $bookmark)





{





    echo '



            <tr>
                    <td class="windowbg"><a href="', $scripturl, '?topic=', $bookmark['id'], '.new">', $bookmark['title'], '</a></td>
                    <td class="windowbg2" width="30"><a href="', $scripturl, '?topic=', $bookmark['id'], '.0" target="_blank"><img src="', $settings['images_url'], '/buttons/im_reply.gif" title="', $txt['bookmark_open_window'], '" alt="', $txt['bookmark_open_window'], '" /></a></td>
               



<td class="windowbg2" width="30"><a href="', $scripturl, '?action=bookmarks;sa=delete;topic=', $bookmark['id'], '"><img src="', $settings['images_url'], '/buttons/delete.gif" title="', $txt['bookmark_delete'], '" alt="', $txt['bookmark_delete'], '" /></a></td>



            </tr>';





}



}


Can someone with expertise in PHP help with this?

Please, i would LOVE this feature. :)
Title: Re: Bookmarks
Post by: Altair on November 10, 2007, 08:20:57 PM
-poke-
Title: Re: Bookmarks
Post by: Alpay on November 11, 2007, 11:28:39 AM
Sorry
is a themes error =)
Tenk u mod..
Title: Re: Bookmarks
Post by: Altair on November 11, 2007, 11:40:27 PM
-poke-
Title: Re: Bookmarks
Post by: Altair on November 13, 2007, 06:14:05 PM
Quote from: Paracelsus on September 28, 2007, 10:24:45 AM
I'm getting back on this because my PHP skills aren't still good enough...  ;)

So, the goal is to make the "New" button appear in front of topics with new messages in the bookmark topic list... So, I've checked the Notifications code which has this function working perfectly and found in Profile.template.php this piece of code to call that button:

foreach ($context['topic_notifications'] as $topic)
{
echo '
<tr>
<td class="windowbg" valign="middle" width="48%">
', $topic['link'];

if ($topic['new'])
echo ' <a href="', $topic['new_href'], '"><img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/new.gif" alt="', $txt[302], '" /></a>';



The problem is I can't get this to work together with the code in Bookmark.template.php:



// Show the bookmarks if there are any



if (isset($context['bookmarks']))



{





// Show each bookmark





foreach($context['bookmarks'] as $bookmark)





{





    echo '



            <tr>
                    <td class="windowbg"><a href="', $scripturl, '?topic=', $bookmark['id'], '.new">', $bookmark['title'], '</a></td>
                    <td class="windowbg2" width="30"><a href="', $scripturl, '?topic=', $bookmark['id'], '.0" target="_blank"><img src="', $settings['images_url'], '/buttons/im_reply.gif" title="', $txt['bookmark_open_window'], '" alt="', $txt['bookmark_open_window'], '" /></a></td>
               



<td class="windowbg2" width="30"><a href="', $scripturl, '?action=bookmarks;sa=delete;topic=', $bookmark['id'], '"><img src="', $settings['images_url'], '/buttons/delete.gif" title="', $txt['bookmark_delete'], '" alt="', $txt['bookmark_delete'], '" /></a></td>



            </tr>';





}



}


Can someone with expertise in PHP help with this?

Please, i would LOVE this feature. :)
Title: Re: Bookmarks
Post by: Aaron on November 17, 2007, 06:02:16 PM
I finally found some spare time to update this mod, filling a few feature requests. Here's the changelog for version 1.1:

Version 1.1

Link to mod (http://custom.simplemachines.org/mods/index.php?mod=864)
Title: Re: Bookmarks
Post by: Paracelsus on November 18, 2007, 07:02:55 AM
Thanks Aäron... it works flawlessly! (http://www.forumscp.com/Smileys/phpbb/Great.gif)
Title: Re: Bookmarks
Post by: gavin on November 18, 2007, 07:09:08 PM
Good job and cheers, it works nicely.
Title: Re: Bookmarks
Post by: Altair on November 19, 2007, 04:47:49 PM
Thanks for Updating this Aaron, is it also possible to show WHO posted the latest post?
Title: Re: Bookmarks
Post by: Nibogo on November 21, 2007, 08:34:58 PM
I try to install but nothing happend i do all the things of i have to do

what i can do??
Title: Re: Bookmarks
Post by: Nibogo on November 25, 2007, 02:05:29 PM
I try to install but the file install.php cant be used:

Fatal error: Call to undefined function db_query()
Title: Re: Bookmarks
Post by: Aileen on November 28, 2007, 04:19:44 AM
Nice Mod. Where can I find my saved bookmarks
Title: Re: Bookmarks
Post by: Aaron on December 01, 2007, 08:49:45 AM
Sorry it took me so long to reply here, guys. 'Real life' is demanding attention. :(

Quote from: Altair on November 19, 2007, 04:47:49 PM
Thanks for Updating this Aaron, is it also possible to show WHO posted the latest post?

Yeah, sure. I'll put that on my todo list for the next version, haven't got the time to look into it now, sorry.




Quote from: will888 on November 28, 2007, 04:19:44 AM
Nice Mod. Where can I find my saved bookmarks

You're probably using a custom Display.template.php. Open up that file, and find:


// Build the normal button array.
$normal_buttons = array(
'new_topic' => array((allowedTo('post_new')) ? 1 : 'test' => 'nothinglol', 'text' => 'smf258', 'image' => 'new_topic.gif', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0'),
'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Add after:

'bookmark' => array('text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


That should do it. :)
Title: Re: Bookmarks
Post by: RoboO on December 01, 2007, 12:50:17 PM
Quote from: diegolyanky on July 28, 2007, 12:26:14 PM
Installed but don't work on helios_multi theme, and is very hard to midify manually, be cause helios_multi has index.template.php and display.template.php are very differents.

Any ideas ?

I'm having this same problem.  Do you know a fix for this Aaron?
Title: Re: Bookmarks
Post by: Hoochie Coochie Man on December 04, 2007, 06:39:26 AM
Thank you for mod
and these are the Turkish Language

Modifications.turkish.php
$txt['bookmarks'] = 'Favori Konularım';
$txt['bookmark_not_for_guests'] = 'Üzgünüm, Bu Forumda Sadece Üyeler \'Favori Konular\' özelliğini kullanabilir!';
$txt['bookmark_list'] = 'Favori Konular';
$txt['bookmark_list_empty'] = 'Şuan Hiç Favori Konunuz Yok!. Mesajdaki \'Favorilerime ekle\' butonunu kullanarak ekleyebilirsiniz.';
$txt['bookmark_open_window'] = 'Yeni Pencerede Aç';
$txt['bookmark_delete'] = 'Favori Konuyu Sil';
$txt['bookmark_delete_success'] = 'Favori Konu Silindi!';
$txt['bookmark_delete_failure'] = 'Favori Konu Silinemedi!';
$txt['bookmark_add'] = 'Favorilerime Ekle';
$txt['bookmark_add_success'] = 'Konu, Favori Konularınıza eklendi!';
$txt['bookmark_add_exists'] = 'Bu Konu Zaten Favori Konularınızda Var!';
$txt['bookmark_add_failed'] = 'Favori Konu Eklemede Hata!';
Title: Re: Bookmarks
Post by: emrahdincer on December 10, 2007, 03:20:21 AM
Hi Friends,

I am using  1.1.4 "Classic YaBB SE Theme"  in my forum.  I installed Bookmarks  MOD  ,  but like other users   I cant see any button to add bookmark on my forum.  I tried something which is  described in this Topic ,  but I cant solve my problem.
Forum language is Turkish.

www.KarTutkusu.com

Sample code from my  Display.template.php.   I add   "global $bar_exps, $bar_posts;"  line in it but noting was change :(


function theme_show_main_buttons()
{
   global $context, $settings, $options, $txt, $scripturl;
   global $bar_exps, $bar_posts;         

   $buttonArray = array();
   if ($context['can_reply'])
      $buttonArray[] = '<a href="' . $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/reply.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';


Title: Re: Bookmarks
Post by: Javaman56 on December 11, 2007, 09:31:08 PM
Helllppp!! :(

I have SMF 1.1.4 and have tried to use this mod over the past 3 days. I have installed it properly etc. [according to the package manager] yet cannot see it anywhere on any theme.
This last time I checked the error log and the following is what I get.

512: package_flush_cache(): some files are still not writable
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1905

2: fopen(d:\home\hnt5a095\forum/Sources/Bookmarks.php) [<a href='function.fopen'>function.fopen</a>]: failed to open stream: No such file or directory
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1901

2: copy(d:\home\hnt5a095\forum/Sources/Bookmarks.php) [<a href='function.copy'>function.copy</a>]: failed to open stream: Permission denied
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1025

2: fclose(): supplied argument is not a valid stream resource
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1908

2: fopen(d:\home\hnt5a095\forum/Sources/RemoveTopic.php) [<a href='function.fopen'>function.fopen</a>]: failed to open stream: Permission denied
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1901

What do I need to do?????
Title: Re: Bookmarks
Post by: bruno.cunha on December 12, 2007, 09:27:26 AM
I can see the bookmark button on the default smf 114 theme, but when I change the server language to portuguese it disapeares. How can I correct this?
Thanks
Title: Re: Bookmarks
Post by: emrahdincer on December 14, 2007, 08:48:28 AM
Can any one  help me ??   I  still waiting your solutions...
Title: Re: Bookmarks
Post by: TrueSatan on December 14, 2007, 09:15:52 AM
Quote from: bruno.cunha on December 12, 2007, 09:27:26 AM
I can see the bookmark button on the default smf 114 theme, but when I change the server language to portuguese it disapeares. How can I correct this?
Thanks

As per the Turkish translation discussed earlier in this topic you need to make a translation of the mod.
Title: Re: Bookmarks
Post by: TrueSatan on December 14, 2007, 09:17:50 AM
Quote from: Rough-Hewn on December 11, 2007, 09:31:08 PM
Helllppp!! :(

I have SMF 1.1.4 and have tried to use this mod over the past 3 days. I have installed it properly etc. [according to the package manager] yet cannot see it anywhere on any theme.
This last time I checked the error log and the following is what I get.

512: package_flush_cache(): some files are still not writable
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1905

2: fopen(d:\home\hnt5a095\forum/Sources/Bookmarks.php) [<a href='function.fopen'>function.fopen</a>]: failed to open stream: No such file or directory
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1901

2: copy(d:\home\hnt5a095\forum/Sources/Bookmarks.php) [<a href='function.copy'>function.copy</a>]: failed to open stream: Permission denied
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1025

2: fclose(): supplied argument is not a valid stream resource
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1908

2: fopen(d:\home\hnt5a095\forum/Sources/RemoveTopic.php) [<a href='function.fopen'>function.fopen</a>]: failed to open stream: Permission denied
File: d:\home\hnt5a095\forum\Sources\Subs-Package.php
Line: 1901

What do I need to do?????

Your host appears to have fopen disabled...contact them if you wish that to be changed otherwise you will not be able to use this mod.
Title: Re: Bookmarks
Post by: TrueSatan on December 14, 2007, 09:19:25 AM
Quote from: emrahdincer on December 10, 2007, 03:20:21 AM
Hi Friends,

I am using  1.1.4 "Classic YaBB SE Theme"  in my forum.  I installed Bookmarks  MOD  ,  but like other users   I cant see any button to add bookmark on my forum.  I tried something which is  described in this Topic ,  but I cant solve my problem.
Forum language is Turkish.

www.KarTutkusu.com

Sample code from my  Display.template.php.   I add   "global $bar_exps, $bar_posts;"  line in it but noting was change :(


function theme_show_main_buttons()
{
   global $context, $settings, $options, $txt, $scripturl;
   global $bar_exps, $bar_posts;         

   $buttonArray = array();
   if ($context['can_reply'])
      $buttonArray[] = '<a href="' . $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/reply.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';




Like almost all mods this mod only installs automatically into the SMF default theme. You will need to manually install into all other, custom, themes.

Please read:

http://docs.simplemachines.org/index.php?topic=402.msg531#msg531 (http://docs.simplemachines.org/index.php?topic=402.msg531#msg531)

http://www.simplemachines.org/community/index.php?topic=34526.0 (http://www.simplemachines.org/community/index.php?topic=34526.0)

The following may also prove helpful:

http://modparser.dev.dansoftaustralia.net/ (http://modparser.dev.dansoftaustralia.net/)

Mirror of the last link:

http://www.smfhacks.com/smf-package-parser.html (http://www.smfhacks.com/smf-package-parser.html)
Title: Re: Bookmarks
Post by: Ambasador on December 14, 2007, 11:57:54 AM
Hi, thanx for the mod, it's great! Works without problems!

I'll post here the serbian translation as soon as I find out a better way to translate the word bookmark.
Title: Re: Bookmarks
Post by: Altair on December 15, 2007, 01:28:30 AM
Quote from: Aäron on December 01, 2007, 08:49:45 AM
Quote from: Altair on November 19, 2007, 04:47:49 PM
Thanks for Updating this Aaron, is it also possible to show WHO posted the latest post?

Yeah, sure. I'll put that on my todo list for the next version, haven't got the time to look into it now, sorry.

Thank Aaron, do you think you can update this mod to be compatible with 2.0 when it comes out also?
Title: Re: Bookmarks
Post by: dannbass on January 07, 2008, 06:19:38 PM
Aäron, is there a possibility of using cURL or fsockopen instead of fopen?
Title: Re: Bookmarks
Post by: gamerxgirl on January 13, 2008, 07:59:00 PM
Great mod, I was wondering if you could add a new feature or if someone could code something up as to how to add this to the Profile menu.
Title: Re: Bookmarks
Post by: Aaron on January 14, 2008, 02:49:03 PM
No updates on the mods yet, sorry.

Quote from: dannbass on January 07, 2008, 06:19:38 PM
Aäron, is there a possibility of using cURL or fsockopen instead of fopen?

I don't recall using fopen() anywhere in the bookmarks mod, so it's probably an SMF related issue. Is the $boarddir of your forum correct? You can check via Admin -> Server Settings -> Forum Directory
Title: Re: Bookmarks
Post by: dannbass on January 14, 2008, 03:07:29 PM
I actually haven't installed it yet... I just read this message (http://www.simplemachines.org/community/index.php?topic=182923.msg1339885#msg1339885) and got the idea that it needed fopen() but anyway... I'll install it then!

Thanks a lot Aäron!
Title: Re: Bookmarks
Post by: woolly bugger on January 17, 2008, 10:25:01 AM
I had this mod in 1.4 and it worked okay! But then I was messing around in the index.template.php and now the "button" is missing for "My Bookmarks"

I tried to uninstall but get an error on the index.template.php

Next I looked and the xml and tried to do a manual install on the index.template.php but couldn't find the code and need some help...

this is from the mod
<file name="$themedir/index.template.php">
<operation>
<search position="before"><![CDATA[
if (in_array($context['current_action'], array('search',]]></search>
<add><![CDATA[ 'bookmarks',]]></add>
</operation>

<operation>
<search position="after"><![CDATA[
// The [calendar]!]]></search>
<add><![CDATA[
    // The [bookmarks] button
if ($context['user']['is_logged'])
echo ($current_action == 'bookmarks' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'bookmarks' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=bookmarks">' , $txt['bookmarks'] , '</a>
</td>' , $current_action == 'bookmarks' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';
]]></add>
</operation>
</file>


this is the index.template.php (the part where I think the code goes?????)
// Show the menu up top. Something like [home] [help] [profile] [logout]...
function template_menu()
{
global $context, $settings, $options, $scripturl, $txt;

// Work out where we currently are.
$current_action = 'home';
if (in_array($context['current_action'], array('admin', 'ban', 'boardrecount', 'cleanperms', 'detailedversion', 'dumpdb', 'featuresettings', 'featuresettings2', 'findmember', 'maintain', 'manageattachments', 'manageboards', 'managecalendar', 'managesearch', 'membergroups', 'modlog', 'news', 'optimizetables', 'packageget', 'packages', 'permissions', 'pgdownload', 'postsettings', 'regcenter', 'repairboards', 'reports', 'serversettings', 'serversettings2', 'smileys', 'viewErrorLog', 'viewmembers')))
$current_action = 'admin';
if (in_array($context['current_action'], array('search', 'admin', 'calendar', 'profile', 'mlist', 'register', 'login', 'help', 'pm')))
$current_action = $context['current_action'];
if ($context['current_action'] == 'search2')
$current_action = 'search';
if ($context['current_action'] == 'theme')
$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';

if ($context['current_action'] == 'chat')
$current_action = 'chat';

// Are we using right-to-left orientation?
if ($context['right_to_left'])
{
$first = 'last';
$last = 'first';
}
else
{
$first = 'first';
$last = 'last';
}

// Show the start of the tab section.
echo '
<table cellpadding="0" cellspacing="0" border="0" style="margin-left: 10px;">
<tr>
<td class="maintab_' , $first , '">&nbsp;</td>';

// Show the [home] button.
echo ($current_action=='home' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'home' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '">' , $txt[103] , '</a>
</td>' , $current_action == 'home' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// Show the [help] button.
echo ($current_action == 'help' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'help' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=help">' , $txt[119] , '</a>
</td>' , $current_action == 'help' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// How about the [search] button?
if ($context['allow_search'])
echo ($current_action == 'search' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'search' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=search">' , $txt[182] , '</a>
</td>' , $current_action == 'search' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// Is the user allowed to administrate at all? ([admin])
if ($context['allow_admin'])
echo ($current_action == 'admin' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'admin' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=admin">' , $txt[2] , '</a>
</td>' , $current_action == 'admin' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// Edit Profile... [profile]
if ($context['allow_edit_profile'])
echo ($current_action == 'profile' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'profile' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=profile">' , $txt[79] , '</a>
</td>' , $current_action == 'profile' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// Go to PM center... [pm]
if ($context['user']['is_logged'] && $context['allow_pm'])
echo ($current_action == 'pm' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'pm' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=pm">' , $txt['pm_short'] , ' ', $context['user']['unread_messages'] > 0 ? '[<strong>'. $context['user']['unread_messages'] . '</strong>]' : '' , '</a>
</td>' , $current_action == 'pm' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// The [calendar]!
if ($context['allow_calendar'])
echo ($current_action == 'calendar' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'calendar' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=calendar">' , $txt['calendar24'] , '</a>
</td>' , $current_action == 'calendar' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// FlashChat!
global $modSettings;
if ($context['user']['is_logged'])
echo ($current_action == 'chat' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'chat' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=chat"', (!empty($modSettings['fc_newWindow']) ? ' target="_blank"' : ''), '>', $txt['fc_chat'], (!empty($modSettings['fc_showUserCount']) && !empty($context['num_chat']) ? ' [<strong>' . $context['num_chat'] . ' ' . ($context['num_chat'] == 1 ? $txt['user'] : $txt['users']) . '</strong>]' : ''), '</a>
</td>' , $current_action == 'chat' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// the [member] list button
if ($context['allow_memberlist'])
echo ($current_action == 'mlist' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'mlist' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=mlist">' , $txt[331] , '</a>
</td>' , $current_action == 'mlist' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


// If the user is a guest, show [login] button.
if ($context['user']['is_guest'])
echo ($current_action == 'login' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'login' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=login">' , $txt[34] , '</a>
</td>' , $current_action == 'login' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


// If the user is a guest, also show [register] button.
if ($context['user']['is_guest'])
echo ($current_action == 'register' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'register' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=register">' , $txt[97] , '</a>
</td>' , $current_action == 'register' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


// Otherwise, they might want to [logout]...
if ($context['user']['is_logged'])
echo ($current_action == 'logout' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'logout' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=logout;sesc=', $context['session_id'], '">' , $txt[108] , '</a>
</td>' , $current_action == 'logout' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

// The end of tab section.
echo '
<td class="maintab_' , $last , '">&nbsp;</td>
</tr>
</table>';

}

// Generate a strip of buttons.
function template_button_strip($button_strip, $direction = 'top', $force_reset = false, $custom_td = '')
{
global $settings, $buttons, $context, $txt, $scripturl;

// Create the buttons...
foreach ($button_strip as $key => $value)
{
if (isset($value['test']) && empty($context[$value['test']]))
{
unset($button_strip[$key]);
continue;
}
elseif (!isset($buttons[$key]) || $force_reset)
$buttons[$key] = '<a href="' . $value['url'] . '" ' .( isset($value['custom']) ? $value['custom'] : '') . '>' . $txt[$value['text']] . '</a>';

$button_strip[$key] = $buttons[$key];
}

if (empty($button_strip))
return '<td>&nbsp;</td>';

echo '
<td class="', $direction == 'top' ? 'main' : 'mirror', 'tab_' , $context['right_to_left'] ? 'last' : 'first' , '">&nbsp;</td>
<td class="', $direction == 'top' ? 'main' : 'mirror', 'tab_back">', implode(' &nbsp;|&nbsp; ', $button_strip) , '</td>
<td class="', $direction == 'top' ? 'main' : 'mirror', 'tab_' , $context['right_to_left'] ? 'first' : 'last' , '">&nbsp;</td>';
}

?>

Title: Re: Bookmarks
Post by: slackerpunk on January 19, 2008, 06:21:21 AM
is it just me or anyone else is having this problem I cannot download the mod from the link to mod link
Title: Re: Bookmarks
Post by: Aaron on January 19, 2008, 06:24:46 AM
I just reuploaded the mod, so it should be working again now. :)
Title: Re: Bookmarks
Post by: slackerpunk on January 19, 2008, 06:26:28 AM
ei thanks... was that a site bug?
Title: Re: Bookmarks
Post by: slackerpunk on January 19, 2008, 06:37:39 AM
hi i have it installed successfully I see ADD BOOKMARK on the menu on top when you open up a thread but where do I get the My Bookmarks link
Title: Re: Bookmarks
Post by: Aaron on January 19, 2008, 06:45:49 AM
Quote from: slackerpunk on January 19, 2008, 06:26:28 AM
ei thanks... was that a site bug?

Yep. Server problems the other day.

Quote from: slackerpunk on January 19, 2008, 06:37:39 AM
hi i have it installed successfully I see ADD BOOKMARK on the menu on top when you open up a thread but where do I get the My Bookmarks link

You need to edit your custom theme's index.template.php to include the bookmark button in the template_menu() function.
Title: Re: Bookmarks
Post by: slackerpunk on January 19, 2008, 06:52:18 AM
do I edit index.template.php or display.template.php?
Title: Re: Bookmarks
Post by: slackerpunk on January 19, 2008, 06:55:07 AM
by the way my current theme is only using index.template.php no other
Title: Re: Bookmarks
Post by: Aaron on January 19, 2008, 07:01:02 AM
index.template.php.

Find:

if (in_array($context['current_action'], array('search',


Replace with:

if (in_array($context['current_action'], array('search','bookmarks',


Find:

// The [calendar]!


Add before:

    // The [bookmarks] button
if ($context['user']['is_logged'])
echo ($current_action == 'bookmarks' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'bookmarks' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=bookmarks">' , $txt['bookmarks'] , '</a>
</td>' , $current_action == 'bookmarks' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';
Title: Re: Bookmarks
Post by: slackerpunk on January 19, 2008, 07:14:59 AM
hey thanks I read that rather late hehe browsed docs and checked the modification and found it.. nice mod keep it up thanks a lot
Title: Re: Bookmarks
Post by: woolly bugger on January 20, 2008, 12:55:06 AM
Thanks Aäron!

That's just what I needed!!!
Title: Re: Bookmarks
Post by: vlindertje on January 20, 2008, 03:20:35 PM
Quote from: Aäron on January 19, 2008, 07:01:02 AM
index.template.php.

Find:

if (in_array($context['current_action'], array('search',


Replace with:

if (in_array($context['current_action'], array('search','bookmarks',


Find:

// The [calendar]!


Add before:

    // The [bookmarks] button
if ($context['user']['is_logged'])
echo ($current_action == 'bookmarks' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
<td valign="top" class="maintab_' , $current_action == 'bookmarks' ? 'active_back' : 'back' , '">
<a href="', $scripturl, '?action=bookmarks">' , $txt['bookmarks'] , '</a>
</td>' , $current_action == 'bookmarks' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


I quote this part, because i get problems, when i follow this.   :o
My code is a little different, so thats maybe it goes wrong.

I will write here my code of this part (index.template.php).

This is with the first thing what i have to change, you can see its a little different that wat you say. So i don't know where i have to change it in my code:
// How about the [search] button?
if ($context['allow_search'])
echo '
<a href="', $scripturl, '?action=search">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/search.gif" alt="' . $txt[182] . '" border="0" />' : $txt[182]), '</a>', $context['menu_separator'];


Then we have the second part of adding the bookmark code before the calender:

// The [calendar]!
if ($context['allow_calendar'])
echo '
<a href="', $scripturl, '?action=calendar">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/calendar.gif" alt="' . $txt['calendar24'] . '" border="0" />' : $txt['calendar24']), '</a>', $context['menu_separator'];


What you can see, my code is different that your code. And when i do exactly what you write, i get errors in this those parts. So i really like if you can tell me how to change and add it in my kind of code. :D
Title: Re: Bookmarks
Post by: Aaron on January 20, 2008, 03:24:31 PM
You've got images instead of text links, so yes, you need to do add a different piece of code, plus you'll need to make an extra image for the bookmarks button. :)

Find the code for the calendar button:

// The [calendar]!
if ($context['allow_calendar'])
echo '
<a href="', $scripturl, '?action=calendar">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/calendar.gif" alt="' . $txt['calendar24'] . '" border="0" />' : $txt['calendar24']), '</a>', $context['menu_separator'];


And add before that:

// The [bookmarks]!
if ($context['user']['is_logged'])
echo '
<a href="', $scripturl, '?action=bookmarks">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmarks.gif" alt="' . $txt['bookmarks'] . '" border="0" />' : $txt['bookmarks']), '</a>', $context['menu_separator'];


That should do the trick. Don't forget to put a bookmarks.gif in /Themes/themename/images/dutch! :)
Title: Re: Bookmarks
Post by: vlindertje on January 20, 2008, 05:15:01 PM
This really helps me, thanx :D
I see also what you changed, so for the next time for other things, i can change it at the same way.
This part of the mod works now :D

Only there is another part it doesn't work. Thats the button in the topic to get it in the bookmarks.

I also used this site: http://www.smfhacks.com/packageparser/package.php
And there i found that i have to change in the display.template.php

And there i found also different codes instead what the site says.

In file Themes/[your theme]/Display.template.php
Find: 
   $normal_buttons = array(
'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Replace with:

   $normal_buttons = array(
'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
'bookmark' => array('text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


And then my code on this part, what looks like the same a little:

$buttonArray = array();
if ($context['can_reply'])
$buttonArray[] = '<a href="' . $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/reply.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';


I hope that i give now the right information, because i couldn't find something else what look like the same.
Title: Re: Bookmarks
Post by: vlindertje on January 21, 2008, 08:27:23 AM
Hello,

Yesterday is was to tired, but today i take my time.  So i set all the codes on a row. And then i take a look what can i change. And i try it and yes, i have the right code :D

I made:

$buttonArray = array();
if ($context['can_reply'])
$buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmarks.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';


And Aäron very thanx for your help. It works very fine now :D
Title: Re: Bookmarks
Post by: Krysia on January 21, 2008, 07:01:18 PM
Hi Aäron,

I've installed everything manually, and I have the text where it should be in the index.template.php and display.template.php files... But no Bookmarks option appears. Is there a conflict with the "Contact" mod?

~ Krysia
Title: Re: Bookmarks
Post by: Krysia on January 21, 2008, 07:17:39 PM
In addition, I tried doing the table manually for the bookmarks mod, because it doesn't look like a table exists for it, and I get this error:

QuoteError
SQL query:

db_query(
"
   CREATE TABLE IF NOT EXISTS {$db_prefix}bookmarks
   (
      `ID_MEMBER` mediumint(8) unsigned NOT NULL,
      `ID_TOPIC` mediumint(8) unsigned NOT NULL,
      UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
   )", __FILE__, __LINE__
)

MySQL said:

#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'db_query("
    CREATE TABLE IF NOT EXISTS {$db_prefix}bookmarks
     
Title: Re: Bookmarks
Post by: Aaron on January 22, 2008, 02:33:36 PM
If you run this query manually in PHPMyAdmin:


CREATE TABLE smf_bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
);


It should work just fine. :) Note that if you use a table prefix other than "smf_", you'll need to change that part of the query. :)
Title: Re: Bookmarks
Post by: Krysia on January 22, 2008, 08:11:53 PM
Thank you... That did the trick insofar as table creation. :)

Unfortunately, I still see nothing (there isn't any text in the header, or anywhere, for that matter), nor do I see any setting in the Admin center for it.

I don't understand it, as I rechecked the manual install several times.

Where am I supposed to look for the settings, etc? Is it in the Features section in the Admin panel?
Title: Re: Bookmarks
Post by: vlindertje on January 23, 2008, 03:35:28 AM
Quote from: Krysia on January 22, 2008, 08:11:53 PM
Where am I supposed to look for the settings, etc? Is it in the Features section in the Admin panel?

I also install it few days ago. But there is no features section in the admin. And by my works fine now :D

Which theme you used?
Did you change the things in your own theme? Because in the first time i didn't see also on my own theme nothing.
Title: Re: Bookmarks
Post by: Krysia on January 23, 2008, 09:14:35 PM
Quote from: vlindertje on January 23, 2008, 03:35:28 AM
Quote from: Krysia on January 22, 2008, 08:11:53 PM
Where am I supposed to look for the settings, etc? Is it in the Features section in the Admin panel?

I also install it few days ago. But there is no features section in the admin. And by my works fine now :D

Which theme you used?
Did you change the things in your own theme? Because in the first time i didn't see also on my own theme nothing.
I used my own theme which is essentially the default with different graphic colors.

I've installed 24 mods; more than half manually; you'd think I'd have a handle on it by now. I don't get it.
Title: Re: Bookmarks
Post by: Aaron on January 24, 2008, 10:52:55 AM
Quote from: vlindertje on January 23, 2008, 03:35:28 AM
I also install it few days ago. But there is no features section in the admin.

There isn't supposed to be any, either! ;D

Quote from: Krysia on January 23, 2008, 09:14:35 PM
I used my own theme which is essentially the default with different graphic colors.

I've installed 24 mods; more than half manually; you'd think I'd have a handle on it by now. I don't get it.

Have you modified your index.template.php and Display.template.php, though? If you haven't, the buttons won't appear in your own theme.
Title: Re: Bookmarks
Post by: Altair on January 24, 2008, 03:54:58 PM
Hey Aaron, Altair again. Do you plan on updating this mod for SMF 2?
Title: Re: Bookmarks
Post by: Aaron on January 24, 2008, 03:58:58 PM
Already have, actually, for one of my own forums that runs on SMF 2.0. :D
Title: Re: Bookmarks
Post by: Krysia on January 24, 2008, 08:35:29 PM
Quote from: Aäron on January 24, 2008, 10:52:55 AM
Quote from: vlindertje on January 23, 2008, 03:35:28 AM
I also install it few days ago. But there is no features section in the admin.

There isn't supposed to be any, either! ;D

Quote from: Krysia on January 23, 2008, 09:14:35 PM
I used my own theme which is essentially the default with different graphic colors.

I've installed 24 mods; more than half manually; you'd think I'd have a handle on it by now. I don't get it.

Have you modified your index.template.php and Display.template.php, though? If you haven't, the buttons won't appear in your own theme.
Checking...

Display.template.php, yes.
Index.template.php, yes.
:(
Title: Re: Bookmarks
Post by: yrral on February 09, 2008, 05:54:55 PM
Hi,

Can anyone tell me what filename is for the image/button that you use on this mod?

at the moment I only have the IMG ALT "Add bookmark" but no image.... it only shows red "X" in place... right clicking it and clicking on properties just giving me this: http://www.domain-name.com/Themes/oxygen11final_tp/images/english/ <==no image filename here.

Edit:

What part of the file I can change the image filename? I've already created a custom Add Bookmark button.


Thanks!
Title: Re: Bookmarks
Post by: yrral on February 09, 2008, 06:38:38 PM
Never mind... found it! Thanks...
Title: Re: Bookmarks
Post by: Krysia on February 10, 2008, 01:10:47 PM
Still no luck w/Bookmarks not showing.

I don't get it.


Title: Re: Bookmarks
Post by: senyorito on February 14, 2008, 10:50:10 AM
Hi!  I installed this bookmarks mod and everything is fine on the default theme -- Core.  However, on my custom theme (Novelty TP -- a text link), the add bookmark text link appears normally.  But I don't have the "My Bookmark" menu.  The thing is, my custom theme's index.template.php is using a different code.  Can somebody help me what to do on this?  Below is the custom index.template.php.

// Show the menu up top. Something like [home] [help] [profile] [logout]...
function template_menu()
{
global $context, $settings, $options, $scripturl, $txt;

// add buttons here
$context['menubox'] = array();

/*
'title' - the string the link will have
'link' - the actual link
'chosen' - which "current_action" this button belongs to.
'memberonly' - show it JUST for members
'guestonly' - show it JUST for guests
'permission' - any permission you want to check before displaying the button

*/

// home button
$context['menubox'][]=array(
'title' => $txt[103],
'link' => $scripturl,
'chosen' => '',
'memberonly' => false,
'guestonly' => false,
'permission' => '',
);

// forum button
$context['menubox'][]=array(
'title' => $txt['tp-forum'],
'link' => $scripturl.'?action=forum',
'chosen' => 'forum',
'memberonly' => false,
'guestonly' => false,
'permission' => '',
);
// help button
$context['menubox'][]=array(
'title' => $txt[119],
'link' => $scripturl.'?action=help',
'chosen' => 'help',
'memberonly' => false,
'guestonly' => false,
'permission' => '',
);


// search button
$context['menubox'][]=array(
'title' => $txt[182],
'link' => $scripturl.'?action=search',
'chosen' => 'search',
'memberonly' => false,
'guestonly' => false,
'permission' => '',
);

// admin button.This one have permission check for admin as well
$context['menubox'][]=array(
'title' => $txt[2],
'link' => $scripturl.'?action=admin',
'chosen' => 'admin',
'memberonly' => false,
'guestonly' => false,
'permission' => 'allow_admin',
);

// profile button
$context['menubox'][]=array(
'title' => $txt[79],
'link' => $scripturl.'?action=profile',
'chosen' => 'profile',
'memberonly' => false,
'guestonly' => false,
'permission' => 'allow_edit_profile',
);

// PM button
$context['menubox'][]=array(
'title' => $txt['pm_short'] . ' '. ($context['user']['unread_messages'] > 0 ? '[<strong>'. $context['user']['unread_messages'] . '</strong>]' : ''),
'link' => $scripturl.'?action=pm',
'chosen' => 'pm',
'memberonly' => true,
'guestonly' => false,
'permission' => 'allow_pm',
);

// calendar button
$context['menubox'][]=array(
'title' => $txt['calendar24'],
'link' => $scripturl.'?action=calendar',
'chosen' => 'calendar',
'memberonly' => false,
'guestonly' => false,
'permission' => 'allow_calendar',
);


Hope someone could help me.

Thanks in advanced!
Title: Re: Bookmarks
Post by: senyorito on February 21, 2008, 01:18:21 AM
Never mind, I got it.
Title: Re: Bookmarks
Post by: EduardoP737 on March 07, 2008, 08:18:06 PM
In spanish
Quote
// Bookmarks
$txt['bookmarks'] = 'Mis Favoritos';
$txt['bookmark_not_for_guests'] = 'Lo sentimos, solo miembros registrados pueden agregar favoritos!';
$txt['bookmark_list'] = 'Favoritos';
$txt['bookmark_list_empty'] = 'No tienes ningun favorito en el momento. Agregalos haciendo click en el boton \'Agregar Favorito\' en la parte superior de los mensajes, justo al lado del boton de Responder.';
$txt['bookmark_open_window'] = 'Abrir en ventana nueva';
$txt['bookmark_delete'] = 'Borrar favoritos seleccionados';
$txt['bookmark_delete_success'] = '%1$s Favoritos fueron borrads exitosamente!';
$txt['bookmark_delete_failure'] = 'No todos los favoritos pudieron borrarse.';
$txt['bookmark_add'] = 'Agregar Favorito';
$txt['bookmark_add_success'] = 'El mensaje fue agregado exitosamente a tus favoritos!';
$txt['bookmark_add_exists'] = 'Este mensaje ya ha sido agregado a tus favoritos!';
$txt['bookmark_add_failed'] = 'Error al intentar agregar el mensaje a tus favoritos.';
?>

Where is the botton "My Favorites"????? That must be in the Index forum

http://custom.simplemachines.org/mods/index.php?action=download;mod=864;id=47029;image

I know where is the "ADD" button but If I want first to see the favorites that I already added???
Title: Re: Bookmarks
Post by: EduardoP737 on March 07, 2008, 09:03:55 PM
Ouch... well, It`s a theme problem.

We must add some code to each theme. In my case:

In Index.template.php of  Usbb Port Theme

I add a code between 516 and 517 lines

   
Quote// Show the [bookmarks] button.
   echo '<li><a href="', $scripturl, '?action=bookmarks">' , $txt[331111] , '</a></li>';

Oh, and in the default theme folder, in the index.spanish.php I add

$txt[331111] = 'Mis Favoritos';
Title: Re: Bookmarks
Post by: Spasm on March 12, 2008, 07:05:24 PM
I get an error after clicking the bookmarks button...


Unknown column 'bm.ID_MEMBER' in 'where clause'
File: /home/spasm/public_html/combat/Sources/Bookmarks.php
Line: 57
Title: Re: Bookmarks
Post by: Aaron on March 14, 2008, 01:36:27 PM
Are you sure the mod's installed correctly? If you have access to PHPMyAdmin, could you check whether the bookmarks table exists?
Title: Re: Bookmarks
Post by: Krysia on March 15, 2008, 05:32:34 PM
Quote from: senyorito on February 21, 2008, 01:18:21 AM
Never mind, I got it.
What did you do, because I still don't have it. :(
Title: Re: Bookmarks
Post by: 58tbird on March 16, 2008, 08:02:52 PM
Hi Aaron!  This is a neat idea - thank you!  I successfully installed your mod, but I don't see the Bookmark button in the topics or "my bookmarks" at the top bar.  Is there something I need to do to activate it?  I'm very new at this and don't know much about code, etc.

I logged out, and logged back in.  Now there appears to be a space between "Reply" and "Notify" for the "Bookmarks" link.

Curiousor and curiousor...I'm registered as an Administrator, 2 Global Moderators, and a Newbie account on my board.  Now I see that when I'm logged in as the Admin or one of the 2 Global Moderators, there's no Bookmark button or "My Bookmarks" link (but there is that small gap between "Reply" and "Notify").  When I'm logged in as the other Global Moderator or the Newbie, both are present and operable.

I'm using the standard core theme, and these are my mod packages:
1.     Registered Links      1.0      
2.    Easy Edit Meta Data    1.0
3.    Registration - Show Gender mod    1.0.0    
4.    FavIcon    1.1    
5.    BoardHover Mod    1.1.0    
6.    Custom Profile Field Mod    3.17    
7.    Bookmarks    1.1    
8.    Ad Managment    2.3    
9.    Admin member list registration date    1.0    
10.    SMF 1.0.12 / 1.1.4 / 2.0 b1.1 Update    1.0    
11.    SMF 1.1.4 Search "brd" Bug Fix (1.0.1)    1.0.1
12.    Avatar on Member List    1.0    
13.    Enhanced Password Reminder    1.0    

Looks like I have 17 pages of errors related to the bookmarks mod, all in relation to these two accounts (the Administrator & the one Global Moderator), and they all have to do with
Quote8: Undefined index: bookmarks
File: /home/auditor1/public_html/Themes/default/Themes.template.php (main_above sub template - eval?)
Line: 649
or
QuoteMessageIndex.template.php (main_above sub template - eval?)
or
QuoteBoardIndex.template.php (main_above sub template - eval?)
or
QuoteAdmin.template.php (main_above sub template - eval?)
Title: Re: Bookmarks
Post by: Aaron on March 17, 2008, 02:47:26 PM
Looks like the mod didn't modify the Modifications-file of the language you're using. Perhaps you're using English-UTF8? In that case, open /Themes/default/languages/Modifications.english-utf8.php and add (just above ?>):


$txt['bookmarks'] = 'My Bookmarks';
$txt['bookmark_not_for_guests'] = 'Sorry, only registred members of this community can use the bookmarks feature!';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.';
$txt['bookmark_open_window'] = 'Open in new window';
$txt['bookmark_delete'] = 'Delete selected bookmarks';
$txt['bookmark_delete_success'] = '%1$s bookmarks were deleted successfully!';
$txt['bookmark_delete_failure'] = 'Not all bookmarks could be deleted.';
$txt['bookmark_add'] = 'Add bookmark';
$txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!';
$txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!';
$txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';


Save the file and reupload if necessary. That should solve your problem! :)
Title: Re: Bookmarks
Post by: 58tbird on March 17, 2008, 04:47:52 PM
Hi Aaron!  Thank you for that.  I am on English, however (that caused some problem 3-4 weeks ago for something else and I was told to switch from English-UTF8 to English and I did).

Does this make a difference in your advice, or should I go ahead with the fix you suggested?

I realize you may not be able to get back to me right away - good luck in your studies  :)
Title: Re: Bookmarks
Post by: Aaron on March 18, 2008, 02:38:42 AM
In that case, try adding the strings to Modifications.english.php. That should help.

In other news: I added Bookmarks v. 2.0, for use with SMF 2.0 beta 3 public, to the mod site.
Title: Re: Bookmarks
Post by: 58tbird on March 18, 2008, 02:30:03 PM
Hi Aaron!

Thank you for taking time from your studies to assist on this.  I probably should have done this earlier, but here are the current contents of my Modifications.english.php file:

<?php
// Version: 1.1; Modifications

// Registration - Show Gender mod
$txt['registration_gender_admin_field'] = 'Show gender on registration form?';
$txt['registration_gender_template_field'] = 'Gender';
$txt['registration_gender_all_label'] = 'Gender';
// Registration - Show Gender mod

$txt['header_favicon_url'] = 'Favicon Image Url:';
$txt['header_favicon_url_desc'] = 'Must be a 16x16 png/gif/ico image
<br />Use .ico for best compatibility (eg IE7)
<br />Leave blank to disable
<br />(<a href="http://en.wikipedia.org/wiki/Favicon" target="_blank">Help</a>)'
;

$txt['bookmarks'] = 'My Bookmarks';
$txt['bookmark_not_for_guests'] = 'Sorry, only registred members of this community can use the bookmarks feature!';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.';
$txt['bookmark_open_window'] = 'Open in new window';
$txt['bookmark_delete'] = 'Delete selected bookmarks';
$txt['bookmark_delete_success'] = '%1$s bookmarks were deleted successfully!';
$txt['bookmark_delete_failure'] = 'Not all bookmarks could be deleted.';
$txt['bookmark_add'] = 'Add bookmark';
$txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!';
$txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!';
$txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';
$txt['avatar'] = 'Avatar';
//Begin Reg Links
$txt['no_view_links'] = 'You are not allowed to view links.';
//END Reg Links Text Strings

?>


I already have the information you posted, but I also have some additional stuff in there (to limit guests from viewing links, & to add gender to registration).  I thought I'd better show this to you to see if you had any advice on what I should do.  I appreciate your help - don't interrupt your studies for this - reply when you can.

In helping me with another issue here (http://www.simplemachines.org/community/index.php?topic=229712.0), the solution seems to have resolved this problem as well - I now have access to the Bookmarks feature for all users.  Thank you Aaron for all your help.  I hope your studies are going well.

This really is a terrific mod! :)
Title: Re: Bookmarks
Post by: Basie on March 18, 2008, 03:02:13 PM
Quote from: Aäron on March 18, 2008, 02:38:42 AM
In other news: I added Bookmarks v. 2.0, for use with SMF 2.0 beta 3 public, to the mod site.

I'm still on 1.1.4 - Which version of this mod should I use?
Title: Re: Bookmarks
Post by: senyorito on March 19, 2008, 01:11:22 AM
Quote from: seek2501 on March 18, 2008, 03:02:13 PM
Quote from: Aäron on March 18, 2008, 02:38:42 AM
In other news: I added Bookmarks v. 2.0, for use with SMF 2.0 beta 3 public, to the mod site.

I'm still on 1.1.4 - Which version of this mod should I use?

Download and install:

bookmarks11.zip
Title: Re: Bookmarks
Post by: Basie on March 19, 2008, 02:17:06 AM
Several people in this thread (at least 4) have had this error...

3.     Execute Modification     ./Themes/default/index.template.php     Test failed

But their questions have been ignored by the OP.

I would also like to use this mod, but get the error. Please advise.


I'm using the following other mods...


1.     Who Voted What?      1.1.4       [ Uninstall ]  [ List Files ]  [ Delete ]
2.    BoardHover Mod    1.1.0    [ Uninstall ] [ List Files ] [ Delete ]
3.    Todays Birthday    0.1    [ Uninstall ] [ List Files ] [ Delete ]
4.    SMF Links    1.6.7    [ Uninstall ] [ List Files ] [ Delete ]
5.    Bookmarks    1.1    [ Apply Mod ] [ List Files ] [ Delete ]
6.    MCLegendII    1.1    [ Uninstall ] [ List Files ] [ Delete ]
7.    Ad Managment    2.3    [ Uninstall ] [ List Files ] [ Delete ]
8.    Avatar Under Membergroups Rank    1.1    [ List Files ] [ Delete ]
9.    FavIcon    1.1    [ Uninstall ] [ List Files ] [ Delete ]
10.    TopicCountOnDispla    1.1.5    [ Uninstall ] [ List Files ] [ Delete ]
11.    Contact Page    1.1    [ Uninstall ] [ List Files ] [ Delete ]
12.    Country Flags    1.0.1    [ Apply Mod ] [ List Files ] [ Delete ]
13.    Website Button    1.1.4    [ Uninstall ] [ List Files ] [ Delete ]
14.    Spoiler Show And Hide    1.0.3    [ Uninstall ] [ List Files ] [ Delete ]
15.    Signature Dropdown Choices    1.0    [ Uninstall ] [ List Files ] [ Delete ]
16.    SMF 1.1.4 Search "brd" Bug Fix (1.0.1)    1.0.1    [ Uninstall ] [ List Files ] [ Delete ]
17.    Profile Comments    1.3.6    [ Uninstall ] [ List Files ] [ Delete ]
18.    SMF Shoutbox    1.16b    [ Uninstall ] [ List Files ] [ Delete ]
19.    Users Online Today Mod    1.4.0    [ Uninstall ] [ List Files ] [ Delete ]
20.    Avatar Under Membergroups Rank    1.1a
Title: Re: Bookmarks
Post by: SunilDVR on March 21, 2008, 06:13:33 PM
This is an excellent mod - thank you!

I assume that because the data is stored in a separate table, when a forum is upgraded to 2.0 (with the SMF2 version of the mod) it will be preserved?

Sunil

Title: Re: Bookmarks
Post by: Aaron on March 21, 2008, 06:16:39 PM
Quote from: SunilDVR on March 21, 2008, 06:13:33 PM
This is an excellent mod - thank you!

Thanks for the kind words! :)

Quote from: SunilDVR on March 21, 2008, 06:13:33 PM
I assume that because the data is stored in a separate table, when a forum is upgraded to 2.0 (with the SMF2 version of the mod) it will be preserved?

That is correct! :)
Title: Re: Bookmarks
Post by: SunilDVR on March 21, 2008, 06:26:44 PM
Quote from: Aäron on March 21, 2008, 06:16:39 PM
Quote from: SunilDVR on March 21, 2008, 06:13:33 PM
I assume that because the data is stored in a separate table, when a forum is upgraded to 2.0 (with the SMF2 version of the mod) it will be preserved?

That is correct! :)

You're welcome - and that's great to hear.

Sunil
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on March 24, 2008, 01:29:18 AM
Aaron.. i tried out this mod tonight on my beta.. i have a small problem, and I have asked BigGuy about this.. if you wouldnt mind, here is the thread from his forum, perhaps you can look and tell me what is going on? it installs with no errors, it un installs with no errors, but when i go to make a book mark, it gives me a error, and then when you click on the bookmark tab, it errors..

here is the link for the whole thread, so you can see what went on:

http://www.smfhelper.info/forum/index.php?topic=2509.msg21942#msg21942

too many errors for me to list here. im wondering how did you get this to work. I have a few other mods installed also, but up till now, now errors.

here is a list of what mods i have:


Auto Embed Video Clips      2.1.5       [ Uninstall ]  [ List Files ]  [ Delete ]
2.    Internal Links Use Same Window    1.2    [ Uninstall ] [ List Files ] [ Delete ]
3.    DNS Blocklist Bans    1.4    [ Uninstall ] [ List Files ] [ Delete ]
4.    Save PM as HTML    1.0.6    [ Uninstall ] [ List Files ] [ Delete ]
5.    MCLegendII for SMF2.0    1.1.2    [ Uninstall ] [ List Files ] [ Delete ]
6.    Users Online Today

perhaps one of the other mods is interfering? but i dont think that is the case, as i would get an error installing or deleting, right? please look into this, as i would love to have the book mark mod on my site, it would be really helpful.. thanks!
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on March 27, 2008, 07:47:05 PM
mmm no one has looked into this?? would love for it to work with my site.. will not put it back on till someone can look at this. it isnt making the changes needed in the db.. please help.. thanks.. ;)
Title: Re: Bookmarks
Post by: SAMm on March 27, 2008, 11:10:01 PM
this mod is excellent
one question
how can i add in every line of each post in the bookmark, the icon of the post itself
like de default (http://www.simplemachines.org/community/Themes/smsite/images/post/xx.gif)


example

(http://i25.tinypic.com/29inex.png)
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on March 28, 2008, 02:24:44 PM
Aaron, any fix to my issue yet??
Title: Re: Bookmarks
Post by: SunilDVR on March 28, 2008, 04:10:34 PM
Just for anyone who is wanting to use this with the Helios theme, another user (MrGoodbar) has posted a step-by-step here (http://www.simplemachines.org/community/index.php?topic=229821.0). It applies to the TinyPortal version of the theme, but I've tested it on the regular version and it seems to work fine - see my post in that thread.

Sunil
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on March 28, 2008, 05:24:03 PM
im looking for a comment for the beta 3 errors im getting, but perhaps Aaron is fixing them now as i type.. hope so..  ;)
Title: Re: Bookmarks
Post by: SAMm on March 28, 2008, 07:19:14 PM
i just want the icons :(
Title: Re: Bookmarks
Post by: chrisb on March 29, 2008, 07:13:19 AM
Quote from: Aäron on January 22, 2008, 02:33:36 PM
If you run this query manually in PHPMyAdmin:


CREATE TABLE smf_bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
);


It should work just fine. :) Note that if you use a table prefix other than "smf_", you'll need to change that part of the query. :)

i was getting that error message and it now works a treat, and no error message when remove topic
Title: Re: Bookmarks
Post by: chrisb on March 29, 2008, 07:26:45 AM
I have installed the Bookmarks mods 1.1 and i am unable to locate the bookmark mod anywhere on the forum. I cant  see any button for that at all. shouldnt it show up in the menu on the top at all.   :(

here is the sample of of the site

Title: Re: Bookmarks
Post by: chrisb on March 29, 2008, 08:02:41 AM
there are the errors from the error logs we are getting now

8: Undefined index: bookmarks
File: /home/cxtxtsju/public_html/forum/Themes/default/ManageAttachments.template.php (main_above sub template - eval?)
Line: 651
Title: Re: Bookmarks
Post by: Charles Hill on March 29, 2008, 12:09:27 PM
I really like this mod.  I added something cool to it.  Perhaps you would like to add it as well.  Well here's a description of what I did...

I wanted to allow users to access their bookmarks quickly through a pop-out drop-down menu by simply hovering over the My Bookmarks link in the main menu.  I modified the main menu in my forum to do this a while ago, so it wasn't too difficult to add it for My Bookmarks as well.  When a user hovers over the My Bookmarks a drop-down menu appears that says 'None' if they have no bookmarks and displays each of their bookmarks as a list if they do have at least one bookmark.  I'll add the code here after I eat some lunch.


edit-

Quote from: chrisb on March 29, 2008, 07:26:45 AM
I have installed the Bookmarks mods 1.1 and i am unable to locate the bookmark mod anywhere on the forum. I cant  see any button for that at all. shouldnt it show up in the menu on the top at all.   :(

here is the sample of of the site



Sounds like you need to check the language files in your theme's language directory (http://www.yoursite.com/forum/Theme/yourtheme/languages)... make sure that all the language files that need to  have the bookmark mod's $txt variables added have them.
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on March 29, 2008, 05:25:15 PM
Quote from: chrisb on March 29, 2008, 07:26:45 AM
I have installed the Bookmarks mods 1.1 and i am unable to locate the bookmark mod anywhere on the forum. I cant  see any button for that at all. shouldnt it show up in the menu on the top at all.   :(

here is the sample of of the site




looks like you will have to make a button for the theme as well as edit the theme itself.. since it is a custom theme..

meantime im still waiting on help with the beta bookmarks mod.. pops open a lounge chair and umbrella.. :)
Title: Re: Bookmarks
Post by: chrisb on March 29, 2008, 06:45:23 PM
what file do i need to edit in the language file and what should go in this file
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on March 29, 2008, 07:37:43 PM
Chris, you could go here, and reading the bookmark's xml file it will tell you how and what toi edit for your custom theme  ;)

http://www.smfhelper.info/forum/index.php?topic=590.msg3548#msg3548

Title: Re: Bookmarks
Post by: rmachado on March 30, 2008, 12:35:14 PM
Well, I trying to put this to work in Portuguese and in a custom theme based on Babylon.

It almost works except I can no see the topic name on the list, and the delete seems not to be working.

Any ideias on this?
Title: Re: Bookmarks
Post by: rmachado on March 31, 2008, 11:25:57 AM
Anyone?

Title: Re: Bookmarks
Post by: Aaron on April 02, 2008, 05:05:12 AM
@SmokyBlue: apparently the bookmarks table wasn't created when you installed the mod. Try running the following query in PHPMyAdmin:

CREATE TABLE smf_bookmarks
(
`id_member` mediumint(8) unsigned NOT NULL,
`id_topic` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `id_member` (`id_member`,`id_topic`)
);

It should work fine when that table is created.

@chrisb: all language strings for the bookmark mod are stored the Modifications language file of the language you're using. It only adds them for the English and Dutch language by default.

@rmachado: which version of SMF are you using? Also, could you post a screenshot of the bookmark list?
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on April 02, 2008, 01:59:36 PM
ok will do that Aaron, and thank you for the help.. will post again if i have any issues again..

thanks!!  ;)
Title: Re: Bookmarks
Post by: SAMm on April 02, 2008, 09:33:46 PM
Quote from: SAMm on March 27, 2008, 11:10:01 PM
this mod is excellent
one question
how can i add in every line of each post in the bookmark, the icon of the post itself
like de default (http://www.simplemachines.org/community/Themes/smsite/images/post/xx.gif)


example

(http://i25.tinypic.com/29inex.png)


pleasee!!! can anyone help me with this ?  :(
Title: Re: Bookmarks
Post by: rmachado on April 03, 2008, 12:38:30 PM
Aaron
1.1.4

I will post an image later on (I don't have it here)
Title: Re: Bookmarks
Post by: aldo on April 09, 2008, 12:33:33 AM
It doesn't work :/

Quote
Table 'northsalemcrew_ms.smf_bookmarks' doesn't exist
File: /My/Dir/htdocs/Sources/Bookmarks.php
Line: 62
Title: Re: Bookmarks
Post by: Aaron on April 09, 2008, 02:15:19 PM
@aldo: a solution for your problem problem has been given quite some times before, even on the previous page. ;)
Title: Re: Bookmarks
Post by: sjmarsha on April 15, 2008, 09:48:55 AM
I am getting this error when I, or my members, click on the bookmarks button

Unknown column 'bm.ID_MEMBER' in 'where clause'
File: /home/****/public_html/forum/Sources/Bookmarks.php
Line: 57

I saw that someone else had the same problem, but I didn't see that there was any solution given.

Thanks for any help.
Title: Re: Bookmarks
Post by: Chachafance on April 18, 2008, 12:56:35 AM
Every time I try to install this on 1.1.4, it just goes to a blank white page. :(
Title: Re: Bookmarks
Post by: sorosh1 on April 18, 2008, 09:51:31 AM
Quote from: Chachafance on April 18, 2008, 12:56:35 AM
Every time I try to install this on 1.1.4, it just goes to a blank white page. :(

Yes with me to!
Title: Re: Bookmarks
Post by: malcomxar on April 18, 2008, 05:41:49 PM
Mine too :(
Title: Re: Bookmarks
Post by: Aaron on April 18, 2008, 07:31:41 PM
Apparently something on your server is preventing you from installing the mod. Try the manual install instructions found on the page on the mod site (http://custom.simplemachines.org/mods/index.php?mod=864).
Title: Re: Bookmarks
Post by: Krysia on April 20, 2008, 02:29:11 PM
Quote from: Aäron on March 17, 2008, 02:47:26 PM
Looks like the mod didn't modify the Modifications-file of the language you're using. Perhaps you're using English-UTF8? In that case, open /Themes/default/languages/Modifications.english-utf8.php and add (just above ?>):


$txt['bookmarks'] = 'My Bookmarks';
$txt['bookmark_not_for_guests'] = 'Sorry, only registred members of this community can use the bookmarks feature!';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.';
$txt['bookmark_open_window'] = 'Open in new window';
$txt['bookmark_delete'] = 'Delete selected bookmarks';
$txt['bookmark_delete_success'] = '%1$s bookmarks were deleted successfully!';
$txt['bookmark_delete_failure'] = 'Not all bookmarks could be deleted.';
$txt['bookmark_add'] = 'Add bookmark';
$txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!';
$txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!';
$txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';


Save the file and reupload if necessary. That should solve your problem! :)
That was it. :) I added it to the modifications.english.php file and voila.
Der.
I both love it and hate it when the solution is that simple. LOL.
Thank you.
Title: Re: Bookmarks
Post by: PrizeLive.com on April 21, 2008, 07:29:40 PM
When I click Apply Mod (using 1.1.4), it takes me to a blank white screen.
Title: Re: Bookmarks
Post by: PrizeLive.com on April 22, 2008, 09:53:26 AM
I'm looking at the manual edits for version 1.1.4 and the first one says to find "'attachapprove' => array('ManageAttachments.php', 'ApproveAttach'),", however I can't find that in my index.php file. Since it's not there, where can I add it, or should I just not add it?
Title: Re: Bookmarks
Post by: Aaron on April 22, 2008, 12:25:37 PM
Quote from: MoneyTalkPro.com on April 22, 2008, 09:53:26 AM
I'm looking at the manual edits for version 1.1.4 and the first one says to find "'attachapprove' => array('ManageAttachments.php', 'ApproveAttach'),", however I can't find that in my index.php file. Since it's not there, where can I add it, or should I just not add it?

You should use bookmarks version 1.1, not version 2.0. Bookmarks 2.0 is for use with SMF 2.0 only!
Title: Re: Bookmarks
Post by: PrizeLive.com on April 22, 2008, 12:27:08 PM
Quote from: Aäron on April 22, 2008, 12:25:37 PM
You should use bookmarks version 1.1, not version 2.0. Bookmarks 2.0 is for use with SMF 2.0 only!

Oops, gotcha. I forgot to check the radio button next to version 1.1. Thanks!
Title: Re: Bookmarks
Post by: PrizeLive.com on April 22, 2008, 01:42:56 PM
Just wanted to update this saying that the Bookmark mod is successfully working on my forum and it's great. Thanks!
Title: Re: Bookmarks
Post by: Jed C on April 25, 2008, 02:18:29 PM
tried to install this mod on 1-4 but got the attached error
i think i know what the problem is, i have install a button for the gallery.
on my test forum without the gallery button it installs ok
i have run the package parser but sorry it means nothing to me  :-[
can you tell what i do please
Title: Re: Bookmarks
Post by: Jed C on April 26, 2008, 04:18:12 PM
no takers  :(
Title: Re: Bookmarks
Post by: SAMm on April 27, 2008, 09:08:36 AM
waiting :(
Title: Re: Bookmarks
Post by: Marcus Forsberg on April 28, 2008, 02:17:56 PM
Swedish translation

$txt['bookmarks'] = 'Mina bokm&auml;rken';
$txt['bookmark_not_for_guests'] = 'Ledsen, men bara medlemar kan spara bokm&auml;rken!';
$txt['bookmark_list'] = 'Bokm&auml;rken';
$txt['bookmark_list_empty'] = 'Du har inga bokm&auml;rken &auml;nnu. L&auml;gg till ett genom att klicka p&aring; L&auml;gg till bokm&auml;rke i ett &auml;mne.';
$txt['bookmark_open_window'] = '&Ouml;ppna i ett nytt f&ouml;nster';
$txt['bookmark_delete'] = 'Radera de markerade bokm&auml;rkena';
$txt['bookmark_delete_success'] = '%1$s bokm&auml;rken togs bort utan problem!';
$txt['bookmark_delete_failure'] = 'Alla bokm&auml;rken kunde inte raderas.';
$txt['bookmark_add'] = 'L&auml;gg till bokm&auml;rke';
$txt['bookmark_add_success'] = '&Auml;mnet har lagts till bland dina bokm&auml;rken!';
$txt['bookmark_add_exists'] = 'Deth&auml;r &auml;mnet finns redan bland dina bokm&auml;rken!';
$txt['bookmark_add_failed'] = 'Kunde inte l&auml;gga till bokm&auml;rket.';
Title: Re: Bookmarks
Post by: Spike50 on May 01, 2008, 04:31:24 AM
Table 'DB284637.smf_bookmarks' doesn't exist
File: /mnt/web1/31/05/5538905/htdocs/unitedrant/Sources/Bookmarks.php
Line: 115

Is what I get when I try to bookmark anything...
Title: Re: Bookmarks
Post by: Aaron on May 01, 2008, 05:37:56 AM
Quote from: MTF95 on April 28, 2008, 02:17:56 PM
Swedish translation

Thanks, I'll include it in the next version! :D

Quote from: Spike50 on May 01, 2008, 04:31:24 AM
Table 'DB284637.smf_bookmarks' doesn't exist
File: /mnt/web1/31/05/5538905/htdocs/unitedrant/Sources/Bookmarks.php
Line: 115

Is what I get when I try to bookmark anything...

Run this query manually in PHPMyAdmin:


CREATE TABLE smf_bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
);
Title: Re: Bookmarks
Post by: Alan S on May 09, 2008, 04:05:39 PM
Hey aaron , just wondering , any solution for for the

[quote]
Unknown column 'bm.ID_MEMBER' in 'where clause'
File: /home/theftacl/public_html/smf/Sources/Bookmarks.php
Line: 57


problem?
Title: Re: Bookmarks
Post by: Aaron on May 09, 2008, 04:07:17 PM
Yes, and the solution is actually in the post above yours. ::)
Title: Re: Bookmarks
Post by: Jed C on May 13, 2008, 04:02:08 PM
no help for me then  ::)
Title: Re: Bookmarks
Post by: Aaron on May 13, 2008, 04:27:46 PM
Sorry, I must've overlooked your post. Just install the mod despite the warning, and then add the button manually to the display template, by opening Display.template.php and replacing:


$normal_buttons = array(
'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


With:

$normal_buttons = array(
'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


If another mod modified the bit of code cited above, be a bit creative. :)
Title: Re: Bookmarks
Post by: Jed C on May 13, 2008, 07:45:34 PM
cheers Aaron will try that tomorrow  ;)
Title: Re: Bookmarks
Post by: Jed C on May 15, 2008, 04:46:04 PM
Tried that Aaron but it did not work  ::)
here is copy of my display.template if thats any use

[code]<?php
// Version: 1.1; Display

function template_main()
{
        global $context, $settings, $options, $txt, $scripturl, $modSettings;

        // Show the anchor for the top and for the first message. If the first message is new, say so.
        echo '
<a name="top"></a>
<a name="msg', $context['first_message'], '"></a>', $context['first_new_message'] ? '<a name="new"></a>' : '';

                // Show the linktree
        echo '
<div>', theme_linktree(), '</div>';

        // Is this topic also a poll?
        if ($context['is_poll'])
        {
                echo '
<table cellpadding="3" cellspacing="0" border="0" width="100%" class="tborder" style="padding-top: 0; margin-bottom: 2ex;">
        <tr>
                <td class="titlebg" colspan="2" valign="middle" style="padding-left: 6px;">
                        <img src="', $settings['images_url'], '/topic/', $context['poll']['is_locked'] ? 'normal_poll_locked' : 'normal_poll', '.gif" alt="" align="bottom" /> ', $txt['smf43'], '
                </td>
        </tr>
        <tr>
                <td width="5%" valign="top" class="windowbg"><b>', $txt['smf21'], ':</b></td>
                <td class="windowbg">
                        ', $context['poll']['question'];
                if (!empty($context['poll']['expire_time']))
                        echo '
                                        &nbsp;(', ($context['poll']['is_expired'] ? $txt['poll_expired_on'] : $txt['poll_expires_on']), ': ', $context['poll']['expire_time'], ')';

                // Are they not allowed to vote but allowed to view the options?
                if ($context['poll']['show_results'] || !$context['allow_vote'])
                {
                        echo '
                        <table>
                                <tr>
                                        <td style="padding-top: 2ex;">
                                                <table border="0" cellpadding="' . ($modSettings['whovotedwhatMode'] != 'disabled' ? 5 : 0) . '" cellspacing="0">';

                                // Show each option with its corresponding percentage bar.
                        foreach ($context['poll']['options'] as $option)
                        {
        if (!allowedTo('poll_view_voters') || $modSettings['whovotedwhatMode'] == 'disabled')
        {
                                  echo '
                                                        <tr>
                                                                <td style="padding-right: 2ex;', $option['voted_this'] ? 'font-weight: bold;' : '', '">', $option['option'], '</td>', $context['allow_poll_view'] ? '
                                                                <td nowrap="nowrap">' . $option['bar'] . ' ' . $option['votes'] . ' (' . $option['percent'] . '%)</td>' : '', '
                                                        </tr>';
        }
        else {
          switch ($modSettings['whovotedwhatMode'])
          {
            case 'select':
                                      echo '
                                                        <tr>
                                                                <td style="padding-right: 2ex;', $option['voted_this'] ? 'font-weight: bold;' : '', '">', $option['option'], '</td>', $context['allow_poll_view'] ? '
                                                                <td nowrap="nowrap">' . $option['bar'] . ' ' . $option['votes'] . ' (' . $option['percent'] . '%)</td>' : '', '
                <td style="padding-left: 2ex;">
                  <select id="jumpto" name="voters' . $option['ID_OPTION'] . '" onchange="if (this.selectedIndex > 0 &amp;&amp; this.options[this.selectedIndex].value) window.location.href = smf_scripturl + this.options[this.selectedIndex].value.substr(smf_scripturl.indexOf(\'?\') == -1 || this.options[this.selectedIndex].value.substr(0, 1) != \'?\' ? 0 : 1);" style="width: 150px;">';
              if (!empty($context['poll']['options'][$option['ID_OPTION']]['voters']))
              {
                echo '
                    <option selected="selected" value="#">' . $txt['poll_view_voters_expand_to_view'] . '</option>
                    <option disabled="disabled" value="">----------------------</option>';
                foreach ($context['poll']['options'][$option['ID_OPTION']]['voters'] as $voter)
                {
                  echo '
                    <option value="?action=profile;u=' . $voter['ID_MEMBER'] . '"> => ' . $voter['realName'] . '</option>';
                }
                echo '
                    <option disabled="disabled" value="">----------------------</option>
                    <option disabled="disabled" value="">' . $txt['poll_view_voters_expanded_help1'] . '</option>
                    <option disabled="disabled" value="">' . $txt['poll_view_voters_expanded_help2'] . '</option>';
              }
              else
              {
                echo '
                    <option selected="selected" value="">----------------------</option>';
              }
              echo '
                  </select>
                </td>
                                                        </tr>';
              break;
            case 'table':
              echo '
              <tr>
                <td style="padding-right: 4ex; vertical-align: top;', $option['voted_this'] ? 'font-weight: bold;' : '', '">', $option['option'], '</td>
                <td style="padding-right: 4ex;">
                  ', $option['bar'], '<br />';
              if (!empty($context['poll']['options'][$option['ID_OPTION']]['voters']))
              {
                foreach ($context['poll']['options'][$option['ID_OPTION']]['voters'] as $voter)
                {
                  echo '<small><a href="?action=profile;u=' . $voter['ID_MEMBER'] . '">', $voter['realName'], '</a></small> ';
                }
              }
              echo '
                </td>
                <td style="padding-left: 2ex; padding-right: 2ex; text-align: center; vertical-align: top;">', $option['votes'], '</td>
                <td style="padding-left: 4ex; text-align: right; vertical-align: top;">', $option['percent'], '%</td>
              </tr>';
              break;
          }
        }
                        }

                        echo '
                                                </table>
                                        </td>
                                        <td valign="bottom" style="padding-left: 15px;">';

                        // If they are allowed to revote - show them a link!
                        if ($context['allow_change_vote'])
                                echo '
                                        <a href="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], ';sesc=', $context['session_id'], '">', $txt['poll_change_vote'], '</a><br />';

                        // If we're viewing the results... maybe we want to go back and vote?
                        if ($context['poll']['show_results'] && $context['allow_vote'])
                                echo '
                                                <a href="', $scripturl, '?topic=', $context['current_topic'], '.', $context['start'], '">', $txt['poll_return_vote'], '</a><br />';

                        // If they're allowed to lock the poll, show a link!
                        if ($context['poll']['lock'])
                                echo '
                                                <a href="', $scripturl, '?action=lockVoting;topic=', $context['current_topic'], '.', $context['start'], ';sesc=', $context['session_id'], '">', !$context['poll']['is_locked'] ? $txt['smf30'] : $txt['smf30b'], '</a><br />';

                        // If they're allowed to edit the poll... guess what... show a link!
                        if ($context['poll']['edit'])
                                echo '
                                                <a href="', $scripturl, '?action=editpoll;topic=', $context['current_topic'], '.', $context['start'], '">', $txt['smf39'], '</a>';

                        echo '
                                        </td>
                                </tr>', $context['allow_poll_view'] ? '
                                <tr>
                                        <td colspan="2"><b>' . $txt['smf24'] . ': ' . $context['poll']['total_votes'] . '</b></td>
                                </tr>' : '', '
                        </table><br />';
                }
                // They are allowed to vote! Go to it!
                else
                {
                        echo '
                        <form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '" style="margin: 0px;">
                                <table>
                                        <tr>
                                                <td colspan="2">';

                        // Show a warning if they are allowed more than one option.
                        if ($context['poll']['allowed_warning'])
                                echo '
                                                        ', $context['poll']['allowed_warning'], '
                                                </td>
                                        </tr><tr>
                                                <td>';

                        // Show each option with its button - a radio likely.
                        foreach ($context['poll']['options'] as $option)
                                echo '
                                                        ', $option['vote_button'], ' ', $option['option'], '<br />';

                        echo '
                                                </td>
                                                <td valign="bottom" style="padding-left: 15px;">';

                        // Allowed to view the results? (without voting!)
                        if ($context['allow_poll_view'])
                                echo '
                                                        <a href="', $scripturl, '?topic=', $context['current_topic'], '.', $context['start'], ';viewResults">', $txt['smf29'], '</a><br />';

                        // Show a link for locking the poll as well...
                        if ($context['poll']['lock'])
                                echo '
                                                        <a href="', $scripturl, '?action=lockVoting;topic=', $context['current_topic'], '.', $context['start'], ';sesc=', $context['session_id'], '">', (!$context['poll']['is_locked'] ? $txt['smf30'] : $txt['smf30b']), '</a><br />';

                        // Want to edit it? Click right here......
                        if ($context['poll']['edit'])
                                echo '
                                                        <a href="', $scripturl, '?action=editpoll;topic=', $context['current_topic'], '.', $context['start'], '">', $txt['smf39'], '</a>';

                                echo '
                                                </td>
                                        </tr><tr>
                                                <td colspan="2"><input type="submit" value="', $txt['smf23'], '" /></td>
                                        </tr>
                                </table>
                                <input type="hidden" name="sc" value="', $context['session_id'], '" />
                        </form>';
                }

                echo '
                </td>
        </tr>
</table>';
        }

        // Does this topic have some events linked to it?
        if (!empty($context['linked_calendar_events']))
        {
                echo '
<table cellpadding="3" cellspacing="0" border="0" width="100%" class="tborder" style="padding-top: 0; margin-bottom: 3ex;">
                <tr>
                                <td class="titlebg" valign="middle" align="left" style="padding-left: 6px;">
                                                ', $txt['calendar_linked_events'], '
                                </td>
                </tr>
                <tr>
                                <td width="5%" valign="top" class="windowbg">
                                                <ul>';
                foreach ($context['linked_calendar_events'] as $event)
                        echo '
                                                                <li>
                                                                        ', ($event['can_edit'] ? '<a href="' . $event['modify_href'] . '" style="color: red;">*</a> ' : ''), '<b>', $event['title'], '</b>: ', $event['start_date'], ($event['start_date'] != $event['end_date'] ? ' - ' . $event['end_date'] : ''), '
                                                                </li>';
                echo '
                                                </ul>
                                </td>
                </tr>
</table>';
        }

        // Build the normal button array.
        $normal_buttons = array(
                'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
                'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
                'custom' => array(),
                'send' => array('test' => 'can_send_topic', 'text' => 707, 'image' => 'sendtopic.gif', 'lang' => true, 'url' => $scripturl . '?action=sendtopic;topic=' . $context['current_topic'] . '.0'),
                'print' => array('text' => 465, 'image' => 'print.gif', 'lang' => true, 'custom' => 'target="_blank"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'),
        );

        // Special case for the custom one.
        if ($context['user']['is_logged'] && $settings['show_mark_read'])
                $normal_buttons['custom'] = array('text' => 'mark_unread', 'image' => 'markunread.gif', 'lang' => true, 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']);
        elseif ($context['can_add_poll'])
                $normal_buttons['custom'] = array('text' => 'add_poll', 'image' => 'add_poll.gif', 'lang' => true, 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']);
        else
                unset($normal_buttons['custom']);

        // Show the page index... "Pages: [1]".
        echo '
<table width="100%" cellpadding="0" cellspacing="0" border="0">
        <tr>
                <td class="middletext" valign="bottom" style="padding-bottom: 4px;">', $txt[139], ': ', $context['page_index'], !empty($modSettings['topbottomEnable']) ? $context['menu_separator'] . ' &nbsp;&nbsp;<a href="#lastPost"><b>' . $txt['topbottom5'] . '</b></a>' : '', '</td>
                <td align="right" style="padding-right: 1ex;">
                        <div class="nav" style="margin-bottom: 2px;"> ', $context['previous_next'], '</div>
                        <table cellpadding="0" cellspacing="0">
                                <tr>
                                        ', template_button_strip($normal_buttons, 'bottom'), '
                                </tr>
                        </table>
                </td>
        </tr>
</table>';

        // Show the topic information - icon, subject, etc.
        echo '
<table width="100%" cellpadding="3" cellspacing="0" border="0" class="tborder" style="border-bottom: 0;">
                <tr class="catbg3">
                                <td valign="middle" width="2%" style="padding-left: 6px;">
                                                <img src="', $settings['images_url'], '/topic/', $context['class'], '.gif" align="bottom" alt="" />
                                </td>
                                <td width="13%"> ', $txt[29], '</td>
                                <td valign="middle" width="85%" style="padding-left: 6px;" id="top_subject">
                                                ', $txt[118], ': ', $context['subject'], ' &nbsp;(', $txt[641], ' ', $context['num_views'], ' ', $txt[642], ')
                                </td>
                </tr>';
        if (!empty($settings['display_who_viewing']))
        {
                echo '
                <tr>
                                <td colspan="3" class="smalltext">';

                // Show just numbers...?
                if ($settings['display_who_viewing'] == 1)
                                echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt[19];
                // Or show the actual people viewing the topic?
                else
                        echo empty($context['view_members_list']) ? '0 ' . $txt[19] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')');

                // Now show how many guests are here too.
                echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_topic'], '
                                </td>
                </tr>';
        }

        echo '
</table>';

        echo '
<form action="', $scripturl, '?action=quickmod2;topic=', $context['current_topic'], '.', $context['start'], '" method="post" accept-charset="', $context['character_set'], '" name="quickModForm" id="quickModForm" style="margin: 0;" onsubmit="return in_edit_mode == 1 ? modify_save(\'' . $context['session_id'] . '\') : confirm(\'' . $txt['quickmod_confirm'] . '\');">';

        // These are some cache image buttons we may want.
        $reply_button = create_button('quote.gif', 145, 'smf240', 'align="middle"');
        $modify_button = create_button('modify.gif', 66, 17, 'align="middle"');
        $remove_button = create_button('delete.gif', 121, 31, 'align="middle"');
        $split_button = create_button('split.gif', 'smf251', 'smf251', 'align="middle"');

// Time to display all the posts
        echo '
<table cellpadding="0" cellspacing="0" border="0" width="100%" class="bordercolor">';

        // Get all the messages...
        while ($message = $context['get_message']())
        {
                echo '
        <tr><td style="padding: 1px 1px 0 1px;">';

                // Show the message anchor and a "new" anchor if this message is new.
                if ($message['id'] != $context['first_message'])
                        echo '
                <a name="msg', $message['id'], '"></a>', $message['first_new'] ? '<a name="new"></a>' : '';

                echo '
                <table width="100%" cellpadding="3" cellspacing="0" border="0">
                        <tr><td class="', $message['alternate'] == 0 ? 'windowbg' : 'windowbg2', '">';

                // Show information about the poster of this message.
                echo '
                                <table width="100%" cellpadding="5" cellspacing="0" style="table-layout: fixed;">
                                        <tr>
                                                <td valign="top" width="16%" rowspan="2" style="overflow: hidden;">
                                                        <b>', $message['member']['link'], '</b>
                                                        <div class="smalltext">';

                // Show the member's custom title, if they have one.
                if (isset($message['member']['title']) && $message['member']['title'] != '')
                        echo '
                                                                ', $message['member']['title'], '<br />';

                // Show the member's primary group (like 'Administrator') if they have one.
                if (isset($message['member']['group']) && $message['member']['group'] != '')
                        echo '
                                                                ', $message['member']['group'], '<br />';

                // Don't show these things for guests.
                if (!$message['member']['is_guest'])
                {
                        // Show the post group if and only if they have no other group or the option is on, and they are in a post group.
                        if ((empty($settings['hide_post_group']) || $message['member']['group'] == '') && $message['member']['post_group'] != '')
                                echo '
                                                                ', $message['member']['post_group'], '<br />';
                        echo '
                                                                ', $message['member']['group_stars'], '<br />';

                        // Is karma display enabled?  Total or +/-?
                        if ($modSettings['karmaMode'] == '1')
                                echo '
                                                                <br />
                                                                ', $modSettings['karmaLabel'], ' ', $message['member']['karma']['good'] - $message['member']['karma']['bad'], '<br />';
                        elseif ($modSettings['karmaMode'] == '2')
                                echo '
                                                                <br />
                                                                ', $modSettings['karmaLabel'], ' +', $message['member']['karma']['good'], '/-', $message['member']['karma']['bad'], '<br />';

                        // Is this user allowed to modify this member's karma?
                        if ($message['member']['karma']['allow'])
                                echo '
                                                                <a href="', $scripturl, '?action=modifykarma;sa=applaud;uid=', $message['member']['id'], ';topic=', $context['current_topic'], '.' . $context['start'], ';m=', $message['id'], ';sesc=', $context['session_id'], '">', $modSettings['karmaApplaudLabel'], '</a>
                                                                <a href="', $scripturl, '?action=modifykarma;sa=smite;uid=', $message['member']['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';m=', $message['id'], ';sesc=', $context['session_id'], '">', $modSettings['karmaSmiteLabel'], '</a><br />';

                        // Show online and offline buttons?
                        if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest'])
                                echo '
                                                                ', $context['can_send_pm'] ? '<a href="' . $message['member']['online']['href'] . '" title="' . $message['member']['online']['label'] . '">' : '', $settings['use_image_buttons'] ? '<img src="' . $message['member']['online']['image_href'] . '" alt="' . $message['member']['online']['text'] . '" border="0" style="margin-top: 2px;" />' : $message['member']['online']['text'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $message['member']['online']['text'] . '</span>' : '', '<br /><br />';

                        // Show the member's gender icon?
                        if (!empty($settings['show_gender']) && $message['member']['gender']['image'] != '')
                                echo '
                                                                ', $txt[231], ': ', $message['member']['gender']['image'], '<br />';

                                require_once($GLOBALS['sourcedir'] . '/CustomProfile.php');
                                displayCustomFieldsPost($message);

                        // Show how many posts they have made.
                        echo '
                                                                ', $txt[26], ': ', $message['member']['posts'], '<br />
                                                                <br />';

                        // Show avatars, images, etc.?
                        if (!empty($settings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image']))
                                echo '
                                                                <div style="overflow: auto; width: 100%;">', $message['member']['avatar']['image'], '</div><br />';

                        // Show their personal text?
                        if (!empty($settings['show_blurb']) && $message['member']['blurb'] != '')
                                echo '
                                                                ', $message['member']['blurb'], '<br />
                                                                <br />';

                        // This shows the popular messaging icons.
                        echo '
                                                                ', $message['member']['icq']['link'], '
                                                                ', $message['member']['msn']['link'], '
                                                                ', $message['member']['aim']['link'], '
                                                                ', $message['member']['yim']['link'], '<br />';

                        // Show the profile, website, email address, and personal message buttons.
                        if ($settings['show_profile_buttons'])
                        {
                                // Don't show the profile button if you're not allowed to view the profile.
                                if ($message['member']['can_view_profile'])
                                        echo '
                                                                <a href="', $message['member']['href'], '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/icons/profile_sm.gif" alt="' . $txt[27] . '" title="' . $txt[27] . '" border="0" />' : $txt[27]), '</a>';

                                // Don't show an icon if they haven't specified a website.
                                if ($message['member']['website']['url'] != '')
                                        echo '
                                                                <a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/www_sm.gif" alt="' . $txt[515] . '" border="0" />' : $txt[515]), '</a>';

                                // Don't show the email address if they want it hidden.
                                if (empty($message['member']['hide_email']))
                                        echo '
                                                                <a href="mailto:', $message['member']['email'], '">', ($settings['use_image_buttons']
Title: Re: Bookmarks
Post by: Aaron on May 15, 2008, 04:52:06 PM
Find (yes, it really is there):

        $normal_buttons = array(
                'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Add after:

                'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


That should do the trick.
Title: Re: Bookmarks
Post by: ccbtimewiz on May 15, 2008, 04:54:15 PM
... you didn't do what he told you to do.

Find:
Code (display.template.php) Select
// Build the normal button array.
        $normal_buttons = array(
                'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
                'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
                'custom' => array(),
                'send' => array('test' => 'can_send_topic', 'text' => 707, 'image' => 'sendtopic.gif', 'lang' => true, 'url' => $scripturl . '?action=sendtopic;topic=' . $context['current_topic'] . '.0'),
                'print' => array('text' => 465, 'image' => 'print.gif', 'lang' => true, 'custom' => 'target="_blank"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'),
        );


And replace it with:

// Build the normal button array.
        $normal_buttons = array(
                'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
                'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
                'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
                'custom' => array(),
                'send' => array('test' => 'can_send_topic', 'text' => 707, 'image' => 'sendtopic.gif', 'lang' => true, 'url' => $scripturl . '?action=sendtopic;topic=' . $context['current_topic'] . '.0'),
                'print' => array('text' => 465, 'image' => 'print.gif', 'lang' => true, 'custom' => 'target="_blank"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'),
        );


Make sure the edits are done on whatever theme you're editing if you're not using the default theme.
Title: Re: Bookmarks
Post by: Jed C on May 15, 2008, 05:16:03 PM
thats the original un-modified  ::) ;)
Title: Re: Bookmarks
Post by: ccbtimewiz on May 15, 2008, 05:19:19 PM
Quote from: steve b on May 15, 2008, 05:16:03 PM
thats the original un-modified  ::) ;)

Any errors in the error log?
Title: Re: Bookmarks
Post by: Jed C on May 16, 2008, 03:01:26 PM
yep but don't know what they mean  ::)

Quote
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:44:22 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=modlog
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:44:22 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=modlog
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Admin.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:44:08 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=reports
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:44:08 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=reports
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Admin.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:44:00 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=reports
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:44:00 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=reports
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Admin.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:56 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=viewErrorLog;desc
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:56 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=viewErrorLog;desc
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Errors.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:26 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=viewErrorLog;desc
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:26 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=viewErrorLog;desc
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Errors.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:19 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=admin
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:19 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=admin
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Admin.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:16 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=admin
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:16 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php?action=admin
Apply Filter: Only show the errors with the same message
8: Undefined index: elgm4
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Themes\default\Login.template.php (eval?)
Line: 575
   
Apply Filter: Only show the error messages of this member nobodys fool    Today at 07:42:09 pm
Apply Filter: Only show the error messages of this IP address 90.203.215.213      Apply Filter: Only show the error messages of this session 0bb48ca9ddf58175a14c1cea6a0ba6a4
Apply Filter: Only show the error messages of this URL http://ecmdrivers.org/ecmforumbackup/index.php
Apply Filter: Only show the errors with the same message
8: Undefined index: REQUEST_URI
File: d:\Domains\ecmdrivers.org\wwwroot\ecmforumbackup\Sources\Subs.php
Line: 3336
Title: Re: Bookmarks
Post by: Jed C on May 16, 2008, 03:10:52 PM
and modified display.template

Quote<?php
// Version: 1.1; Display

function template_main()
{
        global $context, $settings, $options, $txt, $scripturl, $modSettings;

        // Show the anchor for the top and for the first message. If the first message is new, say so.
        echo '
<a name="top"></a>
<a name="msg', $context['first_message'], '"></a>', $context['first_new_message'] ? '<a name="new"></a>' : '';

                // Show the linktree
        echo '
<div>', theme_linktree(), '</div>';

        // Is this topic also a poll?
        if ($context['is_poll'])
        {
                echo '
<table cellpadding="3" cellspacing="0" border="0" width="100%" class="tborder" style="padding-top: 0; margin-bottom: 2ex;">
        <tr>
                <td class="titlebg" colspan="2" valign="middle" style="padding-left: 6px;">
                        <img src="', $settings['images_url'], '/topic/', $context['poll']['is_locked'] ? 'normal_poll_locked' : 'normal_poll', '.gif" alt="" align="bottom" /> ', $txt['smf43'], '
                </td>
        </tr>
        <tr>
                <td width="5%" valign="top" class="windowbg"><b>', $txt['smf21'], ':</b></td>
                <td class="windowbg">
                        ', $context['poll']['question'];
                if (!empty($context['poll']['expire_time']))
                        echo '
                                        &nbsp;(', ($context['poll']['is_expired'] ? $txt['poll_expired_on'] : $txt['poll_expires_on']), ': ', $context['poll']['expire_time'], ')';

                // Are they not allowed to vote but allowed to view the options?
                if ($context['poll']['show_results'] || !$context['allow_vote'])
                {
                        echo '
                        <table>
                                <tr>
                                        <td style="padding-top: 2ex;">
                                                <table border="0" cellpadding="' . ($modSettings['whovotedwhatMode'] != 'disabled' ? 5 : 0) . '" cellspacing="0">';

                                // Show each option with its corresponding percentage bar.
                        foreach ($context['poll']['options'] as $option)
                        {
        if (!allowedTo('poll_view_voters') || $modSettings['whovotedwhatMode'] == 'disabled')
        {
                                  echo '
                                                        <tr>
                                                                <td style="padding-right: 2ex;', $option['voted_this'] ? 'font-weight: bold;' : '', '">', $option['option'], '</td>', $context['allow_poll_view'] ? '
                                                                <td nowrap="nowrap">' . $option['bar'] . ' ' . $option['votes'] . ' (' . $option['percent'] . '%)</td>' : '', '
                                                        </tr>';
        }
        else {
          switch ($modSettings['whovotedwhatMode'])
          {
            case 'select':
                                      echo '
                                                        <tr>
                                                                <td style="padding-right: 2ex;', $option['voted_this'] ? 'font-weight: bold;' : '', '">', $option['option'], '</td>', $context['allow_poll_view'] ? '
                                                                <td nowrap="nowrap">' . $option['bar'] . ' ' . $option['votes'] . ' (' . $option['percent'] . '%)</td>' : '', '
                <td style="padding-left: 2ex;">
                  <select id="jumpto" name="voters' . $option['ID_OPTION'] . '" onchange="if (this.selectedIndex > 0 &amp;&amp; this.options[this.selectedIndex].value) window.location.href = smf_scripturl + this.options[this.selectedIndex].value.substr(smf_scripturl.indexOf(\'?\') == -1 || this.options[this.selectedIndex].value.substr(0, 1) != \'?\' ? 0 : 1);" style="width: 150px;">';
              if (!empty($context['poll']['options'][$option['ID_OPTION']]['voters']))
              {
                echo '
                    <option selected="selected" value="#">' . $txt['poll_view_voters_expand_to_view'] . '</option>
                    <option disabled="disabled" value="">----------------------</option>';
                foreach ($context['poll']['options'][$option['ID_OPTION']]['voters'] as $voter)
                {
                  echo '
                    <option value="?action=profile;u=' . $voter['ID_MEMBER'] . '"> => ' . $voter['realName'] . '</option>';
                }
                echo '
                    <option disabled="disabled" value="">----------------------</option>
                    <option disabled="disabled" value="">' . $txt['poll_view_voters_expanded_help1'] . '</option>
                    <option disabled="disabled" value="">' . $txt['poll_view_voters_expanded_help2'] . '</option>';
              }
              else
              {
                echo '
                    <option selected="selected" value="">----------------------</option>';
              }
              echo '
                  </select>
                </td>
                                                        </tr>';
              break;
            case 'table':
              echo '
              <tr>
                <td style="padding-right: 4ex; vertical-align: top;', $option['voted_this'] ? 'font-weight: bold;' : '', '">', $option['option'], '</td>
                <td style="padding-right: 4ex;">
                  ', $option['bar'], '<br />';
              if (!empty($context['poll']['options'][$option['ID_OPTION']]['voters']))
              {
                foreach ($context['poll']['options'][$option['ID_OPTION']]['voters'] as $voter)
                {
                  echo '<small><a href="?action=profile;u=' . $voter['ID_MEMBER'] . '">', $voter['realName'], '</a></small> ';
                }
              }
              echo '
                </td>
                <td style="padding-left: 2ex; padding-right: 2ex; text-align: center; vertical-align: top;">', $option['votes'], '</td>
                <td style="padding-left: 4ex; text-align: right; vertical-align: top;">', $option['percent'], '%</td>
              </tr>';
              break;
          }
        }
                        }

                        echo '
                                                </table>
                                        </td>
                                        <td valign="bottom" style="padding-left: 15px;">';

                        // If they are allowed to revote - show them a link!
                        if ($context['allow_change_vote'])
                                echo '
                                        <a href="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], ';sesc=', $context['session_id'], '">', $txt['poll_change_vote'], '</a><br />';

                        // If we're viewing the results... maybe we want to go back and vote?
                        if ($context['poll']['show_results'] && $context['allow_vote'])
                                echo '
                                                <a href="', $scripturl, '?topic=', $context['current_topic'], '.', $context['start'], '">', $txt['poll_return_vote'], '</a><br />';

                        // If they're allowed to lock the poll, show a link!
                        if ($context['poll']['lock'])
                                echo '
                                                <a href="', $scripturl, '?action=lockVoting;topic=', $context['current_topic'], '.', $context['start'], ';sesc=', $context['session_id'], '">', !$context['poll']['is_locked'] ? $txt['smf30'] : $txt['smf30b'], '</a><br />';

                        // If they're allowed to edit the poll... guess what... show a link!
                        if ($context['poll']['edit'])
                                echo '
                                                <a href="', $scripturl, '?action=editpoll;topic=', $context['current_topic'], '.', $context['start'], '">', $txt['smf39'], '</a>';

                        echo '
                                        </td>
                                </tr>', $context['allow_poll_view'] ? '
                                <tr>
                                        <td colspan="2"><b>' . $txt['smf24'] . ': ' . $context['poll']['total_votes'] . '</b></td>
                                </tr>' : '', '
                        </table><br />';
                }
                // They are allowed to vote! Go to it!
                else
                {
                        echo '
                        <form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '" style="margin: 0px;">
                                <table>
                                        <tr>
                                                <td colspan="2">';

                        // Show a warning if they are allowed more than one option.
                        if ($context['poll']['allowed_warning'])
                                echo '
                                                        ', $context['poll']['allowed_warning'], '
                                                </td>
                                        </tr><tr>
                                                <td>';

                        // Show each option with its button - a radio likely.
                        foreach ($context['poll']['options'] as $option)
                                echo '
                                                        ', $option['vote_button'], ' ', $option['option'], '<br />';

                        echo '
                                                </td>
                                                <td valign="bottom" style="padding-left: 15px;">';

                        // Allowed to view the results? (without voting!)
                        if ($context['allow_poll_view'])
                                echo '
                                                        <a href="', $scripturl, '?topic=', $context['current_topic'], '.', $context['start'], ';viewResults">', $txt['smf29'], '</a><br />';

                        // Show a link for locking the poll as well...
                        if ($context['poll']['lock'])
                                echo '
                                                        <a href="', $scripturl, '?action=lockVoting;topic=', $context['current_topic'], '.', $context['start'], ';sesc=', $context['session_id'], '">', (!$context['poll']['is_locked'] ? $txt['smf30'] : $txt['smf30b']), '</a><br />';

                        // Want to edit it? Click right here......
                        if ($context['poll']['edit'])
                                echo '
                                                        <a href="', $scripturl, '?action=editpoll;topic=', $context['current_topic'], '.', $context['start'], '">', $txt['smf39'], '</a>';

                                echo '
                                                </td>
                                        </tr><tr>
                                                <td colspan="2"><input type="submit" value="', $txt['smf23'], '" /></td>
                                        </tr>
                                </table>
                                <input type="hidden" name="sc" value="', $context['session_id'], '" />
                        </form>';
                }

                echo '
                </td>
        </tr>
</table>';
        }

        // Does this topic have some events linked to it?
        if (!empty($context['linked_calendar_events']))
        {
                echo '
<table cellpadding="3" cellspacing="0" border="0" width="100%" class="tborder" style="padding-top: 0; margin-bottom: 3ex;">
                <tr>
                                <td class="titlebg" valign="middle" align="left" style="padding-left: 6px;">
                                                ', $txt['calendar_linked_events'], '
                                </td>
                </tr>
                <tr>
                                <td width="5%" valign="top" class="windowbg">
                                                <ul>';
                foreach ($context['linked_calendar_events'] as $event)
                        echo '
                                                                <li>
                                                                        ', ($event['can_edit'] ? '<a href="' . $event['modify_href'] . '" style="color: red;">*</a> ' : ''), '<b>', $event['title'], '</b>: ', $event['start_date'], ($event['start_date'] != $event['end_date'] ? ' - ' . $event['end_date'] : ''), '
                                                                </li>';
                echo '
                                                </ul>
                                </td>
                </tr>
</table>';
        }

      // Build the normal button array.
        $normal_buttons = array(
                'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
                'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
                'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
                'custom' => array(),
                'send' => array('test' => 'can_send_topic', 'text' => 707, 'image' => 'sendtopic.gif', 'lang' => true, 'url' => $scripturl . '?action=sendtopic;topic=' . $context['current_topic'] . '.0'),
                'print' => array('text' => 465, 'image' => 'print.gif', 'lang' => true, 'custom' => 'target="_blank"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'),
        );

        // Special case for the custom one.
        if ($context['user']['is_logged'] && $settings['show_mark_read'])
                $normal_buttons['custom'] = array('text' => 'mark_unread', 'image' => 'markunread.gif', 'lang' => true, 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']);
        elseif ($context['can_add_poll'])
                $normal_buttons['custom'] = array('text' => 'add_poll', 'image' => 'add_poll.gif', 'lang' => true, 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']);
        else
                unset($normal_buttons['custom']);

        // Show the page index... "Pages: [1]".
        echo '
<table width="100%" cellpadding="0" cellspacing="0" border="0">
        <tr>
                <td class="middletext" valign="bottom" style="padding-bottom: 4px;">', $txt[139], ': ', $context['page_index'], !empty($modSettings['topbottomEnable']) ? $context['menu_separator'] . ' &nbsp;&nbsp;<a href="#lastPost"><b>' . $txt['topbottom5'] . '</b></a>' : '', '</td>
                <td align="right" style="padding-right: 1ex;">
                        <div class="nav" style="margin-bottom: 2px;"> ', $context['previous_next'], '</div>
                        <table cellpadding="0" cellspacing="0">
                                <tr>
                                        ', template_button_strip($normal_buttons, 'bottom'), '
                                </tr>
                        </table>
                </td>
        </tr>
</table>';

        // Show the topic information - icon, subject, etc.
        echo '
<table width="100%" cellpadding="3" cellspacing="0" border="0" class="tborder" style="border-bottom: 0;">
                <tr class="catbg3">
                                <td valign="middle" width="2%" style="padding-left: 6px;">
                                                <img src="', $settings['images_url'], '/topic/', $context['class'], '.gif" align="bottom" alt="" />
                                </td>
                                <td width="13%"> ', $txt[29], '</td>
                                <td valign="middle" width="85%" style="padding-left: 6px;" id="top_subject">
                                                ', $txt[118], ': ', $context['subject'], ' &nbsp;(', $txt[641], ' ', $context['num_views'], ' ', $txt[642], ')
                                </td>
                </tr>';
        if (!empty($settings['display_who_viewing']))
        {
                echo '
                <tr>
                                <td colspan="3" class="smalltext">';

                // Show just numbers...?
                if ($settings['display_who_viewing'] == 1)
                                echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt[19];
                // Or show the actual people viewing the topic?
                else
                        echo empty($context['view_members_list']) ? '0 ' . $txt[19] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')');

                // Now show how many guests are here too.
                echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_topic'], '
                                </td>
                </tr>';
        }

        echo '
</table>';

        echo '
<form action="', $scripturl, '?action=quickmod2;topic=', $context['current_topic'], '.', $context['start'], '" method="post" accept-charset="', $context['character_set'], '" name="quickModForm" id="quickModForm" style="margin: 0;" onsubmit="return in_edit_mode == 1 ? modify_save(\'' . $context['session_id'] . '\') : confirm(\'' . $txt['quickmod_confirm'] . '\');">';

        // These are some cache image buttons we may want.
        $reply_button = create_button('quote.gif', 145, 'smf240', 'align="middle"');
        $modify_button = create_button('modify.gif', 66, 17, 'align="middle"');
        $remove_button = create_button('delete.gif', 121, 31, 'align="middle"');
        $split_button = create_button('split.gif', 'smf251', 'smf251', 'align="middle"');

// Time to display all the posts
        echo '
<table cellpadding="0" cellspacing="0" border="0" width="100%" class="bordercolor">';

        // Get all the messages...
        while ($message = $context['get_message']())
        {
                echo '
        <tr><td style="padding: 1px 1px 0 1px;">';

                // Show the message anchor and a "new" anchor if this message is new.
                if ($message['id'] != $context['first_message'])
                        echo '
                <a name="msg', $message['id'], '"></a>', $message['first_new'] ? '<a name="new"></a>' : '';

                echo '
                <table width="100%" cellpadding="3" cellspacing="0" border="0">
                        <tr><td class="', $message['alternate'] == 0 ? 'windowbg' : 'windowbg2', '">';

                // Show information about the poster of this message.
                echo '
                                <table width="100%" cellpadding="5" cellspacing="0" style="table-layout: fixed;">
                                        <tr>
                                                <td valign="top" width="16%" rowspan="2" style="overflow: hidden;">
                                                        <b>', $message['member']['link'], '</b>
                                                        <div class="smalltext">';

                // Show the member's custom title, if they have one.
                if (isset($message['member']['title']) && $message['member']['title'] != '')
                        echo '
                                                                ', $message['member']['title'], '<br />';

                // Show the member's primary group (like 'Administrator') if they have one.
                if (isset($message['member']['group']) && $message['member']['group'] != '')
                        echo '
                                                                ', $message['member']['group'], '<br />';

                // Don't show these things for guests.
                if (!$message['member']['is_guest'])
                {
                        // Show the post group if and only if they have no other group or the option is on, and they are in a post group.
                        if ((empty($settings['hide_post_group']) || $message['member']['group'] == '') && $message['member']['post_group'] != '')
                                echo '
                                                                ', $message['member']['post_group'], '<br />';
                        echo '
                                                                ', $message['member']['group_stars'], '<br />';

                        // Is karma display enabled?  Total or +/-?
                        if ($modSettings['karmaMode'] == '1')
                                echo '
                                                                <br />
                                                                ', $modSettings['karmaLabel'], ' ', $message['member']['karma']['good'] - $message['member']['karma']['bad'], '<br />';
                        elseif ($modSettings['karmaMode'] == '2')
                                echo '
                                                                <br />
                                                                ', $modSettings['karmaLabel'], ' +', $message['member']['karma']['good'], '/-', $message['member']['karma']['bad'], '<br />';

                        // Is this user allowed to modify this member's karma?
                        if ($message['member']['karma']['allow'])
                                echo '
                                                                <a href="', $scripturl, '?action=modifykarma;sa=applaud;uid=', $message['member']['id'], ';topic=', $context['current_topic'], '.' . $context['start'], ';m=', $message['id'], ';sesc=', $context['session_id'], '">', $modSettings['karmaApplaudLabel'], '</a>
                                                                <a href="', $scripturl, '?action=modifykarma;sa=smite;uid=', $message['member']['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';m=', $message['id'], ';sesc=', $context['session_id'], '">', $modSettings['karmaSmiteLabel'], '</a><br />';

                        // Show online and offline buttons?
                        if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest'])
                                echo '
                                                                ', $context['can_send_pm'] ? '<a href="' . $message['member']['online']['href'] . '" title="' . $message['member']['online']['label'] . '">' : '', $settings['use_image_buttons'] ? '<img src="' . $message['member']['online']['image_href'] . '" alt="' . $message['member']['online']['text'] . '" border="0" style="margin-top: 2px;" />' : $message['member']['online']['text'], $context['can_send_pm'] ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $message['member']['online']['text'] . '</span>' : '', '<br /><br />';

                        // Show the member's gender icon?
                        if (!empty($settings['show_gender']) && $message['member']['gender']['image'] != '')
                                echo '
                                                                ', $txt[231], ': ', $message['member']['gender']['image'], '<br />';

                                require_once($GLOBALS['sourcedir'] . '/CustomProfile.php');
                                displayCustomFieldsPost($message);

                        // Show how many posts they have made.
                        echo '
                                                                ', $txt[26], ': ', $message['member']['posts'], '<br />
                                                                <br />';

                        // Show avatars, images, etc.?
                        if (!empty($settings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image']))
                                echo '
                                                                <div style="overflow: auto; width: 100%;">', $message['member']['avatar']['image'], '</div><br />';

                        // Show their personal text?
                        if (!empty($settings['show_blurb']) && $message['member']['blurb'] != '')
                                echo '
                                                                ', $message['member']['blurb'], '<br />
                                                                <br />';

                        // This shows the popular messaging icons.
                        echo '
                                                                ', $message['member']['icq']['link'], '
                                                                ', $message['member']['msn']['link'], '
                                                                ', $message['member']['aim']['link'], '
                                                                ', $message['member']['yim']['link'], '<br />';

                        // Show the profile, website, email address, and personal message buttons.
                        if ($settings['show_profile_buttons'])
                        {
                                // Don't show the profile button if you're not allowed to view the profile.
                                if ($message['member']['can_view_profile'])
                                        echo '
                                                                <a href="', $message['member']['href'], '">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/icons/profile_sm.gif" alt="' . $txt[27] . '" title="' . $txt[27] . '" border="0" />' : $txt[27]), '</a>';

                                // Don't show an icon if they haven't specified a website.
                                if ($message['member']['website']['url'] != '')
                                        echo '
                                                                <a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/www_sm.gif" alt="' . $txt[515] . '" border="0" />' : $txt[515]), '</a>';

                                // Don't show the email address if they want it hidden.
                                if (empty($message['member']['hide_email']))
                                        echo '
                                  &nbs
Title: Re: Bookmarks
Post by: Jed C on May 20, 2008, 05:21:33 PM
no takers  ::)
Title: Re: Bookmarks
Post by: SwapsRulez on May 24, 2008, 06:41:33 AM
Hi there, i've tried adding the custom table through phpmyadmin, but still no luck.
i've created the table mentioned here.

http://www.simplemachines.org/community/index.php?topic=182923.msg1526314#msg1526314

I'm getting successfull addition to bookmarks message, but still its not showing any bookmarks. Please help.
Thanks in advance.
Title: Re: Bookmarks
Post by: Aaron on May 24, 2008, 09:06:54 AM
Quote from: SwapsRulez on May 24, 2008, 06:41:33 AM
I'm getting successfull addition to bookmarks message, but still its not showing any bookmarks. Please help.
Thanks in advance.

Any errors related to the bookmarks mod in the forum's error log?
Title: Re: Bookmarks
Post by: SwapsRulez on May 25, 2008, 02:15:19 AM
Quote from: Aäron on May 24, 2008, 09:06:54 AM
Quote from: SwapsRulez on May 24, 2008, 06:41:33 AM
I'm getting successfull addition to bookmarks message, but still its not showing any bookmarks. Please help.
Thanks in advance.

Any errors related to the bookmarks mod in the forum's error log?

Database Error: Table 'b8_1764301_smf.bookmarks' doesn't exist


SELECT
IFNULL(lt.id_msg, IFNULL(lmr.id_msg, -1)) + 1 AS new_from, b.id_board, b.name,
t.id_topic, ms.subject, ms.id_member, IFNULL(mem.real_name, ms.poster_name) AS real_name,
ml.id_msg_modified, ml.poster_time, ml.id_member AS id_member_updated,
IFNULL(mem2.real_name, ml.poster_name) AS last_real_name
FROM bookmarks AS bm
INNER JOIN topics AS t ON (t.id_topic = bm.id_topic AND t.approved = 1)
INNER JOIN boards AS b ON (b.id_board = t.id_board AND 1=1)
INNER JOIN messages AS ms ON (ms.id_msg = t.id_first_msg)
INNER JOIN messages AS ml ON (ml.id_msg = t.id_last_msg)
LEFT JOIN members AS mem ON (mem.id_member = ms.id_member)
LEFT JOIN members AS mem2 ON (mem2.id_member = ml.id_member)
LEFT JOIN log_topics AS lt ON (lt.id_topic = t.id_topic AND lt.id_member = 1)
LEFT JOIN log_mark_read AS lmr ON (lmr.id_board = b.id_board AND lmr.id_member = 1)
WHERE bm.id_member = 1
ORDER BY ms.subject ASC

File: /home/vol5/byethost8.com/b8_1764301/project-bb.org/htdocs/Sources/Bookmarks.php
Line: 62



& this

http://www.project-bb.org/index.php?pretty;board=civil-engineering;topic=smart-materials-and-smart-structures-t2121.0&amp;action=bookmarks;sa=add

Database Error: Table 'b8_1764301_smf.bookmarks' doesn't exist


SELECT *
FROM bookmarks
WHERE
id_member = 1 AND
id_topic = 0
LIMIT 1

File: /home/vol5/byethost8.com/b8_1764301/project-bb.org/htdocs/Sources/Bookmarks.php
Line: 115
Title: Re: Bookmarks
Post by: Aaron on May 25, 2008, 05:45:01 AM
Quote from: SwapsRulez on May 25, 2008, 02:15:19 AM
Database Error: Table 'b8_1764301_smf.bookmarks' doesn't exist


SELECT *
FROM bookmarks
WHERE
id_member = 1 AND
id_topic = 0
LIMIT 1

File: /home/vol5/byethost8.com/b8_1764301/project-bb.org/htdocs/Sources/Bookmarks.php
Line: 115

You probably created a table named 'smf_bookmarks', whilst you should've named it just 'bookmarks', because you're not using a table prefix. :)


CREATE TABLE bookmarks
(
   `id_member` mediumint(8) unsigned NOT NULL,
   `id_topic` mediumint(8) unsigned NOT NULL,
   UNIQUE KEY `id_member` (`id_member`,`id_topic`)
);


That query should do the trick. :)
Title: Re: Bookmarks
Post by: SwapsRulez on May 25, 2008, 07:21:55 AM
QuoteYou probably created a table named 'smf_bookmarks', whilst you should've named it just 'bookmarks', because you're not using a table prefix. :)


CREATE TABLE bookmarks
(
   `id_member` mediumint(8) unsigned NOT NULL,
   `id_topic` mediumint(8) unsigned NOT NULL,
   UNIQUE KEY `id_member` (`id_member`,`id_topic`)
);


That query should do the trick. :)

Thanks mate, but still it isnt solving the problem of the bookmarks. I created the above table. But still no luck. I uninstalled the MOD & created once again. Also created the "bookmarks" table again, but whenever i'm going to "My Bookmarks" Tab, it is showing me the following error message,

QuoteYou don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics.

I added the few topics to the bookmark, but it always says,

QuoteThe topic was successfully added to your bookmarks!

But below that it shows,

QuoteYou don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics.

I think the records are not get added in the table or they might not be displaying. Donno what id the actual problem. Also when i installed the MOD, there was no "smf_bookmarks" table in the database.
Now, i do have bookmarks table with me. :)
I think i'm missing something. Thanks for the above help, but still no luck.

Thanks in advance :)
Title: Re: Bookmarks
Post by: 127.0.0.1 on May 28, 2008, 11:20:03 AM
Hi,

I am making a bookmark function, ssi_bookmarks($userID,$display_amount), for the SSI.php.

I want to take the original query code from Bookmarks.php

    // Load this user's bookmarks
    $request = db_query("
        SELECT
            IFNULL(lt.ID_MSG, IFNULL(lmr.ID_MSG, -1)) + 1 AS new_from, b.ID_BOARD, b.name,
            t.ID_TOPIC, ms.subject, ms.ID_MEMBER, IFNULL(mem.realName, ms.posterName) AS realName,
            ml.ID_MSG_MODIFIED
        FROM ({$db_prefix}bookmarks AS bm, {$db_prefix}boards AS b, {$db_prefix}topics AS t, {$db_prefix}messages AS ms, {$db_prefix}messages AS ml)
            LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER = ms.ID_MEMBER)
            LEFT JOIN {$db_prefix}log_topics AS lt ON (lt.ID_TOPIC = t.ID_TOPIC AND lt.ID_MEMBER = $ID_MEMBER)
            LEFT JOIN {$db_prefix}log_mark_read AS lmr ON (lmr.ID_BOARD = b.ID_BOARD AND lmr.ID_MEMBER = $ID_MEMBER)
        WHERE bm.ID_MEMBER = $ID_MEMBER
            AND t.ID_TOPIC = bm.ID_TOPIC
            AND ms.ID_MSG = t.ID_FIRST_MSG
            AND ml.ID_MSG = t.ID_LAST_MSG
            AND b.ID_BOARD = t.ID_BOARD
            AND $user_info[query_see_board]
        ORDER BY ms.subject ASC", __FILE__, __LINE__);


and trim it down to its bare essentials to provide only this information:

    $context['bookmarks'] = array();
    while ($row = mysql_fetch_assoc($request))
    {
        censorText($row['subject']);

        $context['bookmarks'][] = array(
            'id' => $row['ID_TOPIC'],
            'subject' => $row['subject'],
            'href' => $scripturl . '?topic=' . $row['ID_TOPIC'] . '.0',
            'link' => '<a href="' . $scripturl . '?topic=' . $row['ID_TOPIC'] . '.0">' . $row['subject'] . '</a>',
        );
    }


So what would the new db_query be?

Also I currently I have the above db_query as is in the SSI.php and a list of bookmarks are displayed on the side of the page. However, when I access the ?action=bookmarks, it does not show any bookmarks unless I remove the function that is displaying them on the side of the page.
Title: Re: Bookmarks
Post by: 127.0.0.1 on May 29, 2008, 02:38:36 PM
When deleting a topic,

QuoteFatal error:  Function name must be a string in forum/Sources/RemoveTopic.php on line 380

Line 380 is the first line in this block of code,    $smcFunc['db_query']('', '
        DELETE FROM {db_prefix}bookmarks
        WHERE id_topic IN ({array_int:topics})',
            array(
                'topics' => $topics,
            )
    );


I am using SMF 1.1.1
Title: Re: Bookmarks
Post by: Aaron on June 04, 2008, 08:33:42 AM
Quote from: 127.0.0.1 on May 29, 2008, 02:38:36 PM
When deleting a topic,

QuoteFatal error:  Function name must be a string in forum/Sources/RemoveTopic.php on line 380

I am using SMF 1.1.1

You downloaded and installed the wrong version of the bookmarks mod. Version 1.x of the bookmarks mod is for SMF 1.1.x, and version 2.x is for SMF 2.0 beta 3!
Title: Re: Bookmarks
Post by: 127.0.0.1 on June 04, 2008, 02:19:09 PM
Thanks for taking the time to reply.

I did download and install bookmarks11.zip. The package manager also reported a successful installation.

I also looked at the manual installation instructions exclusively for version 1.1.1: Bookmarks (http://custom.simplemachines.org/mods/index.php?mod=864) - Installation Instructions for 1.1.1. (http://custom.simplemachines.org/mods/index.php?action=parse;mod=864;attach=51752;smf_version=1.1.1)

The instructions say to,


./Sources/Subs.php

Find: [Select]
'login' => array(
'title' => $txt['login'],
'href' => $scripturl . '?action=login',
'show' => $user_info['is_guest'],
'sub_buttons' => array(
),
),
Add After: [Select]
'bookmarks' => array(
'title' => $txt['bookmarks'],
'href' => $scripturl . '?action=bookmarks',
'show' => !$user_info['is_guest'],
'sub_buttons' => array(
),
),


But I cannot find that anywhere in my Subs.php. I searched for 'login' => array and it is found nowhere in my Subs.php
Title: Re: Bookmarks
Post by: Aaron on June 04, 2008, 05:43:26 PM
Seeing those instructions, that's definitely the version for SMF 2.0 you've downloaded.
Title: Re: Bookmarks
Post by: christinedlrp on June 18, 2008, 04:27:05 AM
What is the actual file name of the the bookmark button for the default theme?  I don't see it anywhere?  ???
Title: Re: Bookmarks
Post by: 127.0.0.1 on June 19, 2008, 04:32:33 AM
I am having problems with this mod and SQL. The mod installed fine and works great now. However, a problem arises here when I try to import my form database using phpMyAdmin.

I export the database in SMF's forum maintainance section. Then on my local web server using phpMyAdmin I import the database file and I get the following message...


Error

SQL query:

CREATE  TABLE  `bbs_bookmarks` (ID_MEMBER mediumint( 8  )  unsigned NOT  NULL default  '',
ID_TOPIC mediumint( 8  )  unsigned NOT  NULL default  '',
UNIQUE ID_MEMBER( ID_MEMBER, ID_TOPIC ) ) TYPE  =  MYISAM ;

     
     MySQL said: (http://localhost/phpmyadmin/themes/original/img/b_help.png) (http://dev.mysql.com/doc/refman/5.0/en/error-messages-server.html)   #1067 - Invalid default value for 'ID_MEMBER'

-------------------
Bookmarks1.1 / SMF 1.1.1 / PHP5 / Apache2 / phpMyAdmin 2.11.6
Title: Re: Bookmarks
Post by: ccbtimewiz on June 19, 2008, 11:23:11 AM
When you made a backup of the database, did you include table structure?
Title: Re: Bookmarks
Post by: Greenarts on June 22, 2008, 09:41:17 AM
Is there a bookmarks.gif for the Babylon theme somewhere?
Title: Re: Bookmarks
Post by: FireFreezer on June 25, 2008, 09:25:55 AM
german translation:


<file name="$languagedir/Modifications.german.php" error="ignore">
<operation error="ignore">
<search position="end" />
        <add><![CDATA[
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_not_for_guests'] = 'Sorry, nur registrierte User können diese Funktion nutzen!';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzufügen\' in den Threads erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster öffnen';
$txt['bookmark_delete'] = 'Lesezeichen löschen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gelöscht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gelöscht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzufügen';
$txt['bookmark_add_success'] = 'Thread erfolgreich Deinen Lesezeichen hinzugefügt!';
$txt['bookmark_add_exists'] = 'Dieser Thread befindet sich bereits in Deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim hinzufügen des Threads zu Deinen Lesezeichen aufgetreten!';
]]></add>
    </operation>
</file>

<file name="$languagedir/Modifications.german-utf8.php" error="ignore">
<operation error="ignore">
<search position="end" />
        <add><![CDATA[
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_not_for_guests'] = 'Sorry, nur registrierte User k&ouml;nnen diese Funktion nutzen!';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzuf&uuml;gen\' in den Threads erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster &ouml;ffnen';
$txt['bookmark_delete'] = 'Lesezeichen l&ouml;schen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gel&ouml;scht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gel&ouml;scht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzuf&uuml;gen';
$txt['bookmark_add_success'] = 'Thread erfolgreich Deinen Lesezeichen hinzugef&uuml;gt!';
$txt['bookmark_add_exists'] = 'Dieser Thread befindet sich bereits in Deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim hinzuf&uuml;gen des Threads zu Deinen Lesezeichen aufgetreten!';
]]></add>
    </operation>
</file>


greets and thx for this mod :)
Title: Re: Bookmarks
Post by: Aaron on June 25, 2008, 08:44:31 PM
Quote from: Greenarts on June 22, 2008, 09:41:17 AM
Is there a bookmarks.gif for the Babylon theme somewhere?

I've attached one to this post. :)

Quote from: FireFreezer on June 25, 2008, 09:25:55 AM
german translation:

greets and thx for this mod :)

Thanks, FireFeeler!
Title: Re: Bookmarks
Post by: SunilDVR on June 28, 2008, 03:02:14 PM
Hi Aäron,

I've been using this mod for several months on a reasonably well-frequented boards, and I've been very happy with it so far. I've done the default install with the package installer, but also manually installed it into Helios Multi.

I've only just checked the Error log for the first time since then (not needed to, I probably should more often!) and there are 998 pages of errors...

... the vast majority of them (well, that I can see!) seem to be in index.php referencing the Helios display_template, and one of two types:

Quote
8: Undefined index: Bookmark
File: <path>/forum/Themes/helios_multi11final/Display.template.php (main sub template - eval?)
Line: 234

Quote
8: Use of undefined constant Bookmark - assumed 'Bookmark'
File: <path>/forum/Themes/helios_multi11final/Display.template.php (main sub template - eval?)
Line: 234

Have you come across this before, and do you know of a "quick fix"? I could probably work it out given some time, but I'm not that familiar with the internal workings of themes so it would take a while. I'm happy to do this, but if you've come across the problem before and know how to sort it out quickly, that would be very helpful!

Thanks,

Sunil

Title: Re: Bookmarks
Post by: Aaron on June 28, 2008, 08:20:47 PM
Hi Sunil,

Could you post line 234 and the surrounding lines in the Display.template.php file here please?

Aaron
Title: Re: Bookmarks
Post by: LinK187 on June 28, 2008, 11:03:14 PM
this is the result of the pre-install test:

Quote
1. Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/RemoveTopic.php Test successful
3. Execute Modification ./Themes/default/index.template.php Test failed
4. Execute Modification ./Themes/default/Display.template.php Test successful
5. Execute Modification ./Themes/default/languages/Modifications.dutch.php Test successful
6. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
7. Extract File ./Sources/Bookmarks.php 
8. Extract File ./Themes/default/Bookmarks.template.php 
9. Execute Code install.php

Do i procede anyway?
Title: Re: Bookmarks
Post by: ccbtimewiz on June 28, 2008, 11:25:46 PM
Proceed and attach your index.template.php file.
Title: Re: Bookmarks
Post by: LinK187 on June 29, 2008, 12:24:46 AM
Would it not be wiser to post the index.template.php first instead of ******ing up my forum first?
Title: Re: Bookmarks
Post by: SunilDVR on June 29, 2008, 04:35:43 AM
Quote from: Aäron on June 28, 2008, 08:20:47 PM
Could you post line 234 and the surrounding lines in the Display.template.php file here please?

Hi Aaron,

Here are lines 232-236. Line 234 is the one beginning "$buttonArray[]" immediately after "if($context['can_reply'])"


//Helios bookmarks Edit here
        if ($context['can_reply'])
                $buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '.' . $context['start'] . '.0;do=Bookmark' . $context['bookmark_message'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/addbm1.gif" alt="' . $txt[Bookmark] . '" border="0" />' : $txt[Bookmark]) . '</a>';       
        if ($context['can_mark_notify'])
                $buttonArray[] = '<a href="' . $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id'] . '" onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/notify.gif" alt="' . $txt[131] . '" border="0" />' : $txt[131]) . '</a>';



Thanks,

Sunil
Title: Re: Bookmarks
Post by: Eddy Matthews on June 30, 2008, 04:35:12 AM
Is it possible to have this mod so that it can be used to "bookmark" individual messages, rather than an entire topic? That would be much more useful for my users if it was possible....

Regards
Eddy

Title: Re: Bookmarks
Post by: cr34t1v3 on July 02, 2008, 10:07:47 AM
Hi Aaron,
I installed this mod and just realize that it isn't working in my site.
I've checked the installation manually, and found nothing wrong.
Here is the case, I try to bookmark a topic, but my bookmark list says: You don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics.
I tried to re-bookmark that topic again, and it says: This topic is already listed in your bookmarks! and below that: You don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics.

Am I missing something?
i run on 1.1.5+tp0.9.8
Title: Re: Bookmarks
Post by: Aaron on July 04, 2008, 06:34:04 PM
Quote from: Eddy Matthews on June 30, 2008, 04:35:12 AM
Is it possible to have this mod so that it can be used to "bookmark" individual messages, rather than an entire topic? That would be much more useful for my users if it was possible....

Not at the moment, sorry. I might add something like that in the future, though.

Quote from: cr34t1v3 on July 02, 2008, 10:07:47 AM
I tried to re-bookmark that topic again, and it says: This topic is already listed in your bookmarks! and below that: You don't have any bookmarks at the moment. Add one by clicking 'Add bookmark' in topics.

Am I missing something?
i run on 1.1.5+tp0.9.8

Which version of PHP and MySQL power your server? You can find this information in Admin -> Support and Credits.
Title: Re: Bookmarks
Post by: cr34t1v3 on July 06, 2008, 10:57:02 AM
Quote from: Aäron on July 04, 2008, 06:34:04 PM
Which version of PHP and MySQL power your server? You can find this information in Admin -> Support and Credits.

Forum version: SMF 1.1.5 (more detailed)
Current SMF version: SMF 1.1.5
PHP version: 5.2.5
MySQL version: 5.0.51a-community
Server version: Apache/2.0.63 (Unix) mod_ssl/2.0.63 OpenSSL/0.9.7a mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635
GD version: bundled (2.0.34 compatible)

Title: Re: Bookmarks
Post by: LinK187 on July 07, 2008, 12:20:32 AM
Is it possible someone could answer my previous post? Just scroll up.

thx  8)
Title: Re: Bookmarks
Post by: Antechinus on July 11, 2008, 07:01:07 AM
Quote from: Charles Hill on March 29, 2008, 12:09:27 PM
I really like this mod.  I added something cool to it.  Perhaps you would like to add it as well.  Well here's a description of what I did...

I wanted to allow users to access their bookmarks quickly through a pop-out drop-down menu by simply hovering over the My Bookmarks link in the main menu.  I modified the main menu in my forum to do this a while ago, so it wasn't too difficult to add it for My Bookmarks as well.  When a user hovers over the My Bookmarks a drop-down menu appears that says 'None' if they have no bookmarks and displays each of their bookmarks as a list if they do have at least one bookmark.  I'll add the code here after I eat some lunch.

You've been eating lunch for  three months? That's some lunch you have there.
How about the code then?  :P
Title: Re: Bookmarks
Post by: eforhan on July 11, 2008, 08:18:37 PM
This is the first time I've tried installing this on my board.  I'm getting a fatal error when navigating to a message. In fact, it only shows the template parse error, and nothing else.

SMF 1.15
Default theme
It says it successfully installs.

Error (it highlights LN 168):
QuoteTemplate Parse Error!
There was a problem loading the /Themes/default/Display.template.php template or language file. Please check the syntax and try again - remember, single quotes (') often have to be escaped with a slash (\). To see more specific error information from PHP, try accessing the file directly.

You may want to try to refresh this page or use the default theme.
Parse error: syntax error, unexpected T_DOUBLE_ARROW in .../Themes/default/Display.template.php on line 168

159: </li>';
160: echo '
161: </ul>
162: </td>
163: </tr>
164: </table>';
165: }
166:
167: // Build the normal button array.

168: 'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

169: $normal_buttons = array(
170: 'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
171: 'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
172: 'custom' => array(),



My installed add-ons:
1.     FlashChat Integration     1.0     [ Uninstall ]
2.    Futurama Avatars    1.0    [ Uninstall ]
3.    Spoiler Show And Hide    1.0.3    [ Uninstall ]
4.    BoardHover Mod    1.2    [ Uninstall ]
5.    ColorizePost    1.2    [ Uninstall ]
6.    Topic Member Post Count    1.1.5    [ Uninstall ]
7.    Enhanced Quick Reply Box 2.0.2    2.0.2    [ Uninstall ]
8.    Google Member Map    0.1    [ Uninstall ]
9.    Attachments Positioning    1.2    [ Uninstall ]
10.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ Uninstall ]
11.    Auto Embed Video Clips    2.2
Title: Re: Bookmarks
Post by: Angelotus on July 12, 2008, 11:41:22 AM
Hi,

I have to install the bookmarks database table manually.
What code to use in phpmyadmin??
Title: Re: Bookmarks
Post by: Aaron on July 12, 2008, 11:44:25 AM
Quote from: eforhan on July 11, 2008, 08:18:37 PM
This is the first time I've tried installing this on my board.  I'm getting a fatal error when navigating to a message. In fact, it only shows the template parse error, and nothing else.

Replace:

    // Build the normal button array.

       'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

    $normal_buttons = array(
       'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


With:

    // Build the normal button array.
    $normal_buttons = array(
       'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
       'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


Quote from: Angelotus on July 12, 2008, 11:41:22 AM
I have to install the bookmarks database table manually.
What code to use in phpmyadmin??

That's been said at least ten times already. :P Anyway:

CREATE TABLE smf_bookmarks
(
   `ID_MEMBER` mediumint(8) unsigned NOT NULL,
   `ID_TOPIC` mediumint(8) unsigned NOT NULL,
   UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
);
Title: Re: Bookmarks
Post by: Angelotus on July 12, 2008, 11:49:18 AM
Wow, that's fast! Thanks for you reply, that worked!
Title: Re: Bookmarks
Post by: SunilDVR on July 13, 2008, 10:32:52 AM
Hi Aaron,

I don't know if you missed my reply on 29th June - you asked me to post the section of the code which was giving an error, and I did so here (http://www.simplemachines.org/community/index.php?topic=182923.msg1595785#msg1595785).

Any help appreciated!

Thanks

Sunil
Title: Re: Bookmarks
Post by: Aaron on July 13, 2008, 11:59:07 AM
Quote from: SunilDVR on July 13, 2008, 10:32:52 AM
I don't know if you missed my reply on 29th June - you asked me to post the section of the code which was giving an error, and I did so here (http://www.simplemachines.org/community/index.php?topic=182923.msg1595785#msg1595785).

Sorry, yes, I must've missed that.

Find:

        if ($context['can_reply'])
                $buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '.' . $context['start'] . '.0;do=Bookmark' . $context['bookmark_message'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/addbm1.gif" alt="' . $txt[Bookmark] . '" border="0" />' : $txt[Bookmark]) . '</a>';       


Replace with:

        if ($context['can_reply'])
                $buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '.' . $context['start'] . '.0">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/addbm1.gif" alt="' . $txt['bookmark_add'] . '" border="0" />' : $txt['bookmark_add']) . '</a>';


That should work.
Title: Re: Bookmarks
Post by: Angelotus on July 13, 2008, 02:16:08 PM
Quick Question.

I'd like to add a SSI feature to my frontpage (www.weeklyfun.nl) to show 5 favorite topics added by the logged in member.

In 1.1.5 I used this code:

// Show favorites.
function ssi_favorieten($output_method = 'echo')
{



global $ID_MEMBER, $scripturl, $db_prefix;
$request = db_query("SELECT t.ID_TOPIC, m.subject, mem.ID_MEMBER, mem.realName
FROM {$db_prefix}topics AS t
INNER JOIN {$db_prefix}bookmarks AS bm ON (bm.ID_TOPIC = t.ID_TOPIC AND bm.ID_MEMBER = $ID_MEMBER)
INNER JOIN {$db_prefix}messages AS m ON (m.ID_MSG = t.ID_FIRST_MSG)
LEFT JOIN {$db_prefix}members AS mem ON (mem.ID_MEMBER = m.ID_MEMBER)
ORDER BY RAND()
LIMIT 5",__FILE__,__LINE__);
$topics = array();
while($row = mysql_fetch_assoc($request)) {
$topics[] = '<td valign="top" align="left"><div class="smalltext"><img src="http://www.nessekrekers.nl/favorieten.gif" border="0" alt="Mijn Favorieten">&nbsp;<a href="'.$scripturl.'?topic='.$row['ID_TOPIC'].'">'.$row['subject'].'</a></div></td><td valign="top" align="right"><div class="smalltext"><a href="'.$scripturl.'?action=profile;u='.$row['ID_MEMBER'].'">'.$row['realName'].'</a></div></td>';
}
mysql_free_result($request);
foreach($topics as $t)
echo '<tr onmouseover="this.style.backgroundColor=\'#efefef\';" onmouseout="this.style.backgroundColor=\'transparent\';">',$t,'</tr>';

}


And that worked fine. Now I use 2.0 and it doesn't work anymore.
What is wrong with this code?
Title: Re: Bookmarks
Post by: Aaron on July 13, 2008, 06:03:23 PM
The database structure of SMF 2.0 differs from SMF 1.1, so you'd need to change the field names to reflect their SMF 2.0 equivalents. For example, 'realName' should be 'real_name' and 'ID_MEMBER' should be 'id_member'.
Title: Re: Bookmarks
Post by: Angelotus on July 14, 2008, 01:23:28 AM
ok, that's it! Thanks!
Title: Re: Bookmarks
Post by: cr34t1v3 on July 14, 2008, 04:06:14 AM
Quote from: cr34t1v3 on July 06, 2008, 10:57:02 AM
Quote from: Aäron on July 04, 2008, 06:34:04 PM
Which version of PHP and MySQL power your server? You can find this information in Admin -> Support and Credits.

Forum version: SMF 1.1.5 (more detailed)
Current SMF version: SMF 1.1.5
PHP version: 5.2.5
MySQL version: 5.0.51a-community
Server version: Apache/2.0.63 (Unix) mod_ssl/2.0.63 OpenSSL/0.9.7a mod_auth_passthrough/2.1 mod_bwlimited/1.4 FrontPage/5.0.2.2635
GD version: bundled (2.0.34 compatible)

Hi Aaron, any idea on my case?
Title: Re: Bookmarks
Post by: Angelotus on July 14, 2008, 05:01:03 AM
Quote from: Aäron on July 13, 2008, 06:03:23 PM
The database structure of SMF 2.0 differs from SMF 1.1, so you'd need to change the field names to reflect their SMF 2.0 equivalents. For example, 'realName' should be 'real_name' and 'ID_MEMBER' should be 'id_member'.

I have taken a look at the code and de db structure. The table bookmarks still works with ID_MEMBER instead of the 2.0 id_member, as same voor topics.

So I changed the code into:
// Show favorites.
function ssi_favorieten($output_method = 'echo')
{
global $id_member, $scripturl, $db_prefix;

$request = db_query("SELECT t.id_topic, m.subject, mem.id_member, mem.real_name
FROM {$db_prefix}topics AS t
INNER JOIN {$db_prefix}bookmarks AS bm ON (bm.ID_TOPIC = t.ID_TOPIC AND bm.ID_MEMBER = $ID_MEMBER)
INNER JOIN {$db_prefix}messages AS m ON (m.id_msg = t.id_first_msg)
LEFT JOIN {$db_prefix}members AS mem ON (mem.id_member = m.id_member)
ORDER BY RAND()
LIMIT 5",__FILE__,__LINE__);
$topics = array();
while($row = mysql_fetch_assoc($request))
{
$topics[] = '<td valign="top" align="left"><div class="smalltext"><img src="http://www.nessekrekers.nl/favorieten.gif" border="0" alt="Mijn Favorieten">&nbsp;<a href="'.$scripturl.'?topic='.$row['ID_TOPIC'].'">'.$row['subject'].'</a></div></td><td valign="top" align="right"><div class="smalltext"><a href="'.$scripturl.'?action=profile;u='.$row['id_member'].'">'.$row['real_name'].'</a></div></td>';
}
mysql_free_result($request);
foreach($topics as $t)
echo '<tr onmouseover="this.style.backgroundColor=\'#efefef\';" onmouseout="this.style.backgroundColor=\'transparent\';">',$t,'</tr>';
}


I can't get it to work...help please..
Title: Re: Bookmarks
Post by: Aaron on July 14, 2008, 11:07:32 AM
SMF 2.0 also doesn't have a db_query function anymore. You should use $smcFunc['db_query'] instead. Try something like this instead:


// Show favorites.
function ssi_favorieten($output_method = 'echo')
{
global $id_member, $scripturl, $db_prefix;

$request = $smcFunc['db_query']('', "SELECT t.id_topic, m.subject, mem.id_member, mem.real_name
FROM {db_prefix}topics AS t
INNER JOIN {db_prefix}bookmarks AS bm ON (bm.ID_TOPIC = t.id_topic AND bm.ID_MEMBER = {int:id_member})
INNER JOIN {db_prefix}messages AS m ON (m.id_msg = t.id_first_msg)
LEFT JOIN {db_prefix}members AS mem ON (mem.id_member = m.id_member)
ORDER BY RAND()
LIMIT 5", array('id_member' => $ID_MEMBER);
$topics = array();
while($row = mysql_fetch_assoc($request))
{
$topics[] = '<td valign="top" align="left"><div class="smalltext"><img src="http://www.nessekrekers.nl/favorieten.gif" border="0" alt="Mijn Favorieten">&nbsp;<a href="'.$scripturl.'?topic='.$row['ID_TOPIC'].'">'.$row['subject'].'</a></div></td><td valign="top" align="right"><div class="smalltext"><a href="'.$scripturl.'?action=profile;u='.$row['id_member'].'">'.$row['real_name'].'</a></div></td>';
}
mysql_free_result($request);
foreach($topics as $t)
echo '<tr onmouseover="this.style.backgroundColor=\'#efefef\';" onmouseout="this.style.backgroundColor=\'transparent\';">',$t,'</tr>';
}
Title: Re: Bookmarks
Post by: Angelotus on July 15, 2008, 03:33:33 AM
Thanks for your help so far Aaron. This code gives me a internal server error (500).
Title: Re: Bookmarks
Post by: SunilDVR on July 15, 2008, 06:38:56 AM
Quote from: Aäron on July 13, 2008, 11:59:07 AM

Sorry, yes, I must've missed that.

Find:

        if ($context['can_reply'])
                $buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '.' . $context['start'] . '.0;do=Bookmark' . $context['bookmark_message'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/addbm1.gif" alt="' . $txt[Bookmark] . '" border="0" />' : $txt[Bookmark]) . '</a>';      


Replace with:

        if ($context['can_reply'])
                $buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '.' . $context['start'] . '.0">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/addbm1.gif" alt="' . $txt['bookmark_add'] . '" border="0" />' : $txt['bookmark_add']) . '</a>';


That should work.

Hi Aaron,

That solved the error messages in the log - thanks very much!

Sunil
Title: Re: Bookmarks
Post by: AlenNS on July 15, 2008, 09:19:36 PM
Why I can't install this mod on my forum?
When I try it says that package is corrupted or not compatible with my forum.

I have SMF 2.0 Beta 3.1 public.

Also, when I tried to install it manual I can't find some part of Display.template.php.

$normal_buttons = array(
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl .


It just doesn't exist. Not on default theme, not on Babylon I'm using.
Title: Re: Bookmarks
Post by: AlenNS on July 17, 2008, 02:47:41 PM
Any suggestion?
Title: Re: Bookmarks
Post by: Angelotus on July 18, 2008, 01:23:11 AM
Quote from: AlenNS on July 17, 2008, 02:47:41 PM
Any suggestion?

I use this

Quote
// Can the user bookmark the contents of this post?
      if ($context['can_reply'])
         echo ' | <a href="', $scripturl, '?action=bookmarks;sa=add;topic=' . $context['current_topic'], '"><img src="http://www.nessekrekers.nl/favorieten.gif" border="0"/>&nbsp;Bookmark</a>';
Title: Re: Bookmarks
Post by: AlenNS on July 18, 2008, 09:02:00 AM
@Angelotus I've tried this and it show bookmark link, but when I try to add bookmark or to view bookmark list it shows blank pages.

Does anyone knows that this mod is not compatible with SMF 2.x?
Even the parser tells you that the mod isn't compatible with SMF 2.x.

And on Mod site it says that the mod is for SMF 1.1.x and SMF 2.x...

Can anyone fix this?

http://custom.simplemachines.org/mods/index.php?mod=864
Title: Re: Bookmarks
Post by: Matthew Schenker on July 18, 2008, 09:27:44 AM
Good Morning,
This looks like a great modification!

Is there a way to make it so only certain membergroups have permission to set bookmarks?

Thanks,
Matthew
Title: Re: Bookmarks
Post by: AlenNS on July 18, 2008, 02:44:16 PM
Quote from: Angelotus on July 18, 2008, 01:23:11 AM
Quote from: AlenNS on July 17, 2008, 02:47:41 PM
Any suggestion?

I use this

Quote
// Can the user bookmark the contents of this post?
      if ($context['can_reply'])
         echo ' | <a href="', $scripturl, '?action=bookmarks;sa=add;topic=' . $context['current_topic'], '"><img src="http://www.nessekrekers.nl/favorieten.gif" border="0"/>&nbsp;Bookmark</a>';
Thanks. I managed to install this mod with little change in the code you gave me.

I've made this for different type of languages.

Quote// Can the user bookmark the contents of this post?
      if ($context['can_reply'])
         echo ' <a href="', $scripturl, '?action=bookmarks;sa=add;topic=' . $context['current_topic'], '"><img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmarks2.gif" alt="' . $txt['bookmark'] . '" border="0" /></a>';
Title: Re: Bookmarks
Post by: Angelotus on July 18, 2008, 02:48:19 PM
Your welcome! I edited the code for my own needs indeed! Thanks for commercialize the code ;D
Title: Re: Bookmarks
Post by: AlenNS on July 18, 2008, 02:49:33 PM
No problem. We're here to help each other. :)
Title: Re: Bookmarks
Post by: Matthew Schenker on July 19, 2008, 08:13:36 AM
Good Morning,
Does that code shown above also allow me to set who has permission to use bookmarks?
Thanks,
Matthew
Title: Re: Bookmarks
Post by: Angelotus on July 19, 2008, 09:55:28 AM
Yes. if someone can reply, then they can bookmark.
Title: Re: Bookmarks
Post by: AlenNS on July 19, 2008, 10:01:18 AM
Well, this code allows all of the users who can reply to bookmark the topic, this part of code is telling you that.

if ($context['can_reply'])

Maybe you could make through ManagePermissions.php from the sources folder to limit to some membergroups to bookmark the topics.

EDIT: I didn't sew that Angelotus replied. Sorry
Title: Re: Bookmarks
Post by: Leeloo5E on July 24, 2008, 03:29:38 AM
Yesterday I downloaded this great mod and installed it successfully on my smf 1.1.5...

Where can I add this

Quote// Can the user bookmark the contents of this post?
      if ($context['can_reply'])
         echo ' <a href="', $scripturl, '?action=bookmarks;sa=add;topic=' . $context['current_topic'], '"><img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmarks2.gif" alt="' . $txt['bookmark'] . '" border="0" /></a>';

But I also find some errors and something seems to be missing ...

1. While trying I got an error ... I found out, that in bookmark11.xml there was a "after" instead of an "before". Sometimes I found it very mistakable to set position to "after" while inserting "before" and reversed.

Set the after to before on line 57 in bookmark11.xml
<search position="before"><![CDATA[

2.  In Bookmark.template.php line 34 or so you add a coloumn for Last Pots.
<td class="titlebg" width="24%">', $txt[659], '</td>

But while adding the bookmarked topics in the next rows, there is no coloumn for adding the last post data of the bookmarked topic. I found it very usefull to have this. But when you load the user's bookmarks at line 42ff in Bookmarks.php you do not add a key for last posts on the selected topics. So I can't add this in the template.

3. For deleting a bookmark entry you are using a form with check boxes and a button. It would be very nice, if there was a link above and under the bookmark table like it is overall in smf.

Thanks.
Leeloo
Title: Re: Bookmarks
Post by: AlenNS on July 24, 2008, 06:52:31 AM
Quote from: Leeloo5E on July 24, 2008, 03:29:38 AM
Where can I add this

Quote// Can the user bookmark the contents of this post?
      if ($context['can_reply'])
         echo ' <a href="', $scripturl, '?action=bookmarks;sa=add;topic=' . $context['current_topic'], '"><img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmarks2.gif" alt="' . $txt['bookmark'] . '" border="0" /></a>';
Display.template.php
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on July 25, 2008, 09:08:00 AM
Aaron, i am now trying to add this to the beta 3.. it uploads alright, but then i get this message, when applying:

Quote

Installations actions for "Bookmarks":
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.


hope we can get this fixed ;)
Title: Re: Bookmarks
Post by: AlenNS on July 25, 2008, 09:18:37 AM
I've reported that several times in this tread but no answer. :)

http://www.simplemachines.org/community/index.php?topic=182923.msg1617194#msg1617194

It is possible to install that package but manual and with little change that Angelotus and I have been writing couple a days ago.

There is a mistake in package for SMF 2.x because there isn't this part:

$normal_buttons = array(
      'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl .
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on July 25, 2008, 07:05:32 PM
ok.. thanks AlenNS  ;)
Title: Re: Bookmarks
Post by: AlenNS on July 26, 2008, 06:32:50 AM
No, problem. I hope that helped you! :)
Title: Re: Bookmarks
Post by: Smoky "Rider" Blue on July 27, 2008, 08:05:38 AM
it helped, but im thinking i will wait on this.. makes sense to, since there are more updates to the beta so i can wait..   but thanks again.. i do miss the mod!! ;)
Title: Re: Bookmarks
Post by: DSollick on August 03, 2008, 08:12:25 PM
Upon installing this mod and attempting to load a topic, I got a lovely parse error!

[Good thing I installed this on a test server before going live x_x.  That would have been bad.]

In a nutshell it says this:

Template Parse Error!
There was a problem loading the /Themes/default/Display.template.php template or language file.  [Insert other stuff here.]

Parse error: syntax error, unexpected T_DOUBLE_ARROW in .../Themes/default/Display.template.php on line 168

[This is the line that is highlighted.]  168             'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

I'm just using SMF 1.1.5 with a few other packages installed [As it is a test server.]

The entirety of the parse error content is quoted below.  I didn't look through the topic to see if anyone else had this problem, so I don't know if there's an easy fix or not, so if there is, just kindly link it to me or reply with it :)

QuoteTemplate Parse Error!
There was a problem loading the /Themes/default/Display.template.php template or language file. Please check the syntax and try again - remember, single quotes (') often have to be escaped with a slash (\). To see more specific error information from PHP, try accessing the file directly.

You may want to try to refresh this page or use the default theme.

Parse error: syntax error, unexpected T_DOUBLE_ARROW in .../Themes/default/Display.template.php on line 168
159:                         </li>';
160:       echo '
161:                   </ul>
162:             </td>
163:       </tr>
164: </table>';
165:    }
166:
167:    // Build the normal button array.
168:       'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
169:    $normal_buttons = array(
170:       'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
171:       'notify' => array('test' => 'can_mark_notify', 'text' => 125, 'image' => 'notify.gif', 'lang' => true, 'custom' => 'onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');"', 'url' => $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id']),
172:       'custom' => array(),
Title: Re: Bookmarks
Post by: ccbtimewiz on August 03, 2008, 08:13:46 PM
// Build the normal button array.
       'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
    $normal_buttons = array(
       'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Should be
// Build the normal button array.
    $normal_buttons = array(
       'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
       'bookmark' => array('text' => 'bookmark_add', 'test' => 'can_reply', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
Title: Re: Bookmarks
Post by: AlenNS on August 05, 2008, 05:31:29 PM
I need a help.

I've edited Bookmarks.template.php and tried to add more information for bookmarked topic but didn't succeed.

I've used codes from MessageIndex.template.php of Babylon Theme and got empty cells with no information.

Only Subject, Board and Starter are in there.

Replies, Views and last message and it's time are not there.

I've tried several options and nothing.

Also and topic and post icons are not there. I've putted same icon for all bookmarked topic, but that shouldn't be a goal.

Please if there is someone who could help me with this...

I've attached edited Bookmarks.template.php
Title: Re: Bookmarks
Post by: AlenNS on August 06, 2008, 07:59:17 PM
Bump!

Please if someone could help me with this. I'm going on vacation on friday and I wouldn't like to leave this empty.

Thanks.
Title: Re: Bookmarks
Post by: Aaron on August 07, 2008, 09:46:50 AM
Quote from: AlenNS on August 05, 2008, 05:31:29 PM
I've used codes from MessageIndex.template.php of Babylon Theme and got empty cells with no information.

That's because the rest isn't loaded in Bookmarks.php. You can easily add it to the query though.
Title: Re: Bookmarks
Post by: AlenNS on August 07, 2008, 07:20:04 PM
Any suggestion?
I've tried to make some changes to Bookmarks.php but no result.
Title: Re: Bookmarks
Post by: tk2012 on August 12, 2008, 04:48:38 PM
I have read all 13 pages and especially read the last two pages here about 2.0 3.1.  I'm at a loss.  Does this work with 2.0 3.1 or does it not?

I got the following errors.. even when trying to get the manual edits from this site...

Title: Re: Bookmarks
Post by: ccbtimewiz on August 12, 2008, 05:07:20 PM
It doesn't work with SMF 2.0.
Title: Re: Bookmarks
Post by: tk2012 on August 12, 2008, 05:25:48 PM
Thanks for the info.  I was just going on what was posted on the mod site saying it was compatible.  Too bad, I wanted this one.  It is a great feature which I thought would have been standard for a forum.

Oh well  :(
Title: Re: Bookmarks
Post by: Aaron on August 13, 2008, 12:11:30 PM
Quote from: ccbtimewiz on August 12, 2008, 05:07:20 PM
It doesn't work with SMF 2.0.

It does work with SMF 2.0, actually.

tk2012, what's the exact version of SMF you're using?
Title: Re: Bookmarks
Post by: ccbtimewiz on August 13, 2008, 12:13:13 PM
Quote from: Aäron on August 13, 2008, 12:11:30 PM
Quote from: ccbtimewiz on August 12, 2008, 05:07:20 PM
It doesn't work with SMF 2.0.

It does work with SMF 2.0, actually. What's the exact version of SMF you're using?

o_O

Then why do I keep getting a "this mod will not work for your SMF version" when I install it to a 2.0 test forum?
Title: Re: Bookmarks
Post by: Aaron on August 13, 2008, 01:01:24 PM
Quote from: ccbtimewiz on August 13, 2008, 12:13:13 PM
Then why do I keep getting a "this mod will not work for your SMF version" when I install it to a 2.0 test forum?

'Cause it wasn't compatible with 2.0 Beta 3.1 Public. Darn suffix. :P

Edit: I just uploaded a package that fixes this version number problem. :)
Title: Re: Bookmarks
Post by: tk2012 on August 13, 2008, 03:03:55 PM
Well, I'm sure it is totally unrelated, but yesterday after trying to install the package for this mod, my forum has some kind of database error.  I had just finished trying to upload when I got the error message I attached in a previous post.  Then, I went to go back to my "HOME" tab wo take me to the Index and booom.. can't get into it.  I'm sure it was just coincidence since the package never got installed.  (Can see what I'm talking about here: http://www.simplemachines.org/community/index.php?topic=255196.msg1657908#msg1657908 )

To answer your question, I'm using v2.0 b3.1 Public.  I guess they don't have an area for you guys to post your modifications if they aren't public versions, yet.  That may have helped if they did.  This way things that aren't released to the public aren't mixed with those which are.
Title: Re: Bookmarks
Post by: Aaron on August 13, 2008, 03:06:11 PM
Totally unrelated indeed. Looks like it's your custom forms mod that's causing you those problems. Try removing it via the package manager.
Title: Re: Bookmarks
Post by: justy_ on August 13, 2008, 04:35:49 PM
Hi aaron.

i've installed the mod on our site. we have 1.1.5. Says installation was successful etc., but its not showing up on the forum. Any idea why?  We dont have any old one in....
Title: Re: Bookmarks
Post by: Aaron on August 13, 2008, 04:38:18 PM
Yes, I have. It's been said at least ten times already, but if you're using a custom theme, you need to add the button to the bookmarks page manually. You can find instructions on how to do this on the mod's page - look for manual installation instructions. :)
Title: Re: Bookmarks
Post by: justy_ on August 13, 2008, 04:40:33 PM
okay. thank you. i apologize for a repeated question.
Title: Re: Bookmarks
Post by: Aaron on August 13, 2008, 04:45:32 PM
No problem at all. It's my own fault, really, as I should write a FAQ where I can point people to. :)
Title: Re: Bookmarks
Post by: tk2012 on August 15, 2008, 01:56:04 AM
I decided to give it a go.  It said that it was successfully installed.  When I went to hit My Bookmarks, I got an error saying tha tthe table was not found.

I went into MyPHPadmin and sure enough, no table.   

I used the query that you posted somewhere around page 6 or so and got the following error that I am attaching:

the query was
        CREATE TABLE motorstorm-rpms_org_community_bookmarks
   (
      `ID_MEMBER` mediumint(8) unsigned NOT NULL,
      `ID_TOPIC` mediumint(8) unsigned NOT NULL,
      UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
   );


the error is below
Title: Re: Bookmarks
Post by: tk2012 on August 15, 2008, 02:00:26 AM
AHHHH!! Nevermind.. I see what I did.. I forgot to take out the dash!!!! 
Title: Re: Bookmarks
Post by: ccbtimewiz on August 15, 2008, 02:01:43 AM
Quote from: tk2012 on August 15, 2008, 02:00:26 AM
AHHHH!! Nevermind.. I see what I did.. I forgot to take out the dash!!!! 

About to say. :P
Title: Re: Bookmarks
Post by: tk2012 on August 15, 2008, 02:13:17 AM
Hey.. go make fun of me in another thread entitled "Parse Error -- Yippee" in support for 2.0  ;)
Title: Re: Bookmarks
Post by: tk2012 on August 15, 2008, 02:39:22 AM
@aaron

I did get the table created and everything was working, but when I went to try it out I got a parse error.  The error is attached in case anyone else gets this before it is fixed.

With help from someone, I was instructed to do the following which corrected the error:

Find:
// Build the normal button array.
      'bookmark' => array('test' => 'can_reply', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),
   $normal_buttons = array(
      'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Replace:
// Build the normal button array.
   $normal_buttons = array(
      'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
                'bookmark' => array('test' => 'can_reply', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


Now, everything is working from what I can tell.  My forum isn't live, yet.  I'm just doing the build, so once I have people posting I'll be able to fully see the effects.  Great mod.  Been wanting this for a long time, but haven't been installing anything on my 1.1.5 site since I've been creating a new one with 2.0 3.1.

Thanks everyone!

-TK
Title: Re: Bookmarks
Post by: Kimmie on August 16, 2008, 08:30:10 PM
I got that same parse error.. so when I went and checked the display file, that code is already like that, so I am confused as to how replacing it with the same exact thing will fix it


actually, that first code isnt even in there so the initial find part doesnt do any good  (??)

this part :  'bookmark' => array('test' => 'can_reply', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']), doesnt get put in the file.


Edit: Thats not the same parse error I get. I attached the one I get. Its weird tho because when I go to look up the line of code mine shows in the error, its not even in the file..lol
Title: Re: Bookmarks
Post by: Aaron on August 17, 2008, 05:41:58 AM
Version 2.1.2 fixes the parse error problem. If you're experiencing parse errors after installing version 2.1.1, uninstall it and install 2.1.2 instead. That should fix it.
Title: Re: Bookmarks
Post by: LinK187 on August 17, 2008, 08:51:26 AM
Hi, I hope my question(s) hasn't/haven't already been answered. If they have pls just link me to the post(s). I didn't have the time to read all the pages in this thread.

I was confused by this: http://docs.simplemachines.org/index.php?topic=402.msg531#msg531

I was wondering if someone could just straight up post the exact modifications I need to put into the themes:

AA_A_New_Damage: http://custom.simplemachines.org/themes/?lemma=107

and

FanTheme: http://custom.simplemachines.org/themes/index.php?lemma=875

To make the bookmark functionality visible. I'm using SMF 1.1.5

Thx  8)
Title: Re: Bookmarks
Post by: Kimmie on August 18, 2008, 05:43:05 AM
that seemed to have fixed the parse error but now I get these errors in my log

8: Undefined index: bookmark_add
File: /home//public_html/Themes/default/languages/Profile.english.php (main sub template - eval?)
Line: 662

8: Undefined index: bookmark_add
File: /home//public_html/Themes/default/languages/ThankYouPost.english.php (main sub template - eval?)
Line: 662


These errors happen a soon as someone views a topic. They appear to be stemming from users who are using a custom theme. I edited the files, but the add bookmark button isnt showing up on that theme (its fine on the other 2).

*I also cannot get the button on the menu bar to show up no matter which code I use (the one on the parser for the index.template file, or copying the code for a button that already there and changing it to bookmarks.)

Any ideas?
Title: Re: Bookmarks
Post by: wayneh on August 18, 2008, 05:25:58 PM
Hi -

I just installed your mod in SMF 1.1.5.
The installation went ok (auto install), but I can't see any changes to my Forum.

I am NOT using a custom theme, in fact, I'm using the SMF default theme.

Any ideas what might be the problem?

--Added notes:

On the Main Manu, I am seeing the added separator between "My Messages" and "Calendar", but no text or link for Bookmarks.

On the Topic Menu, I am seeing the added separator between "Reply" and "Notify", but no text or link for Bookmarks.
Title: Re: Bookmarks
Post by: wayneh on August 18, 2008, 06:16:49 PM
OK - nevermind, I found the problem.

It seems that the 'translations.xml' file had content that was put into the 'Modifications.english.php' file, but NOT into the 'Modifications.english-utf8.php' file.

Once I copied the text strings into the 'utf8' file, everything works perfectly.

Title: Re: Bookmarks
Post by: ccbtimewiz on August 18, 2008, 06:44:45 PM
Quote from: LinK187 on August 17, 2008, 08:51:26 AM
Hi, I hope my question(s) hasn't/haven't already been answered. If they have pls just link me to the post(s). I didn't have the time to read all the pages in this thread.

I was confused by this: http://docs.simplemachines.org/index.php?topic=402.msg531#msg531

I was wondering if someone could just straight up post the exact modifications I need to put into the themes:

AA_A_New_Damage: http://custom.simplemachines.org/themes/?lemma=107

and

FanTheme: http://custom.simplemachines.org/themes/index.php?lemma=875

To make the bookmark functionality visible. I'm using SMF 1.1.5

Thx  8)

You need to make your own edits manually.

Quote from: Kimmie on August 18, 2008, 05:43:05 AM
that seemed to have fixed the parse error but now I get these errors in my log

8: Undefined index: bookmark_add
File: /home//public_html/Themes/default/languages/Profile.english.php (main sub template - eval?)
Line: 662

8: Undefined index: bookmark_add
File: /home//public_html/Themes/default/languages/ThankYouPost.english.php (main sub template - eval?)
Line: 662


These errors happen a soon as someone views a topic. They appear to be stemming from users who are using a custom theme. I edited the files, but the add bookmark button isnt showing up on that theme (its fine on the other 2).

*I also cannot get the button on the menu bar to show up no matter which code I use (the one on the parser for the index.template file, or copying the code for a button that already there and changing it to bookmarks.)

Any ideas?

Link to site?
Title: Re: Bookmarks
Post by: LinK187 on August 18, 2008, 06:57:50 PM
Quote from: ccbtimewiz
You need to make your own edits manually.

No $hit. I'm asking for help in doing so.
Title: Re: Bookmarks
Post by: ccbtimewiz on August 18, 2008, 06:58:36 PM
Quote from: LinK187 on August 18, 2008, 06:57:50 PM
Quote from: ccbtimewiz
You need to make your own edits manually.

No ******. I'm asking for help in doing so.

If you're asking for help to manually install this mod, then attach your files.
Title: Re: Bookmarks
Post by: LinK187 on August 18, 2008, 07:00:03 PM
Quote from: ccbtimewiz on August 18, 2008, 06:58:36 PM
Quote from: LinK187 on August 18, 2008, 06:57:50 PM
Quote from: ccbtimewiz
You need to make your own edits manually.

No ******. I'm asking for help in doing so.

If you're asking for help to manually install this mod, then attach your files.

I have the mod installed, I need the tweaks to add to the above mentioned themes so the bookmark functionality is visible and clickable to users. I do believe I provided links to the themes.
Title: Re: Bookmarks
Post by: ccbtimewiz on August 18, 2008, 07:02:09 PM
Quote from: LinK187 on August 18, 2008, 07:00:03 PM
Quote from: ccbtimewiz on August 18, 2008, 06:58:36 PM
Quote from: LinK187 on August 18, 2008, 06:57:50 PM
Quote from: ccbtimewiz
You need to make your own edits manually.

No ******. I'm asking for help in doing so.

If you're asking for help to manually install this mod, then attach your files.

I have the mod installed, I need the tweaks to add to the above mentioned themes so the bookmark functionality is visible and clickable to users. I do believe I provided links to the themes.

Please provide the files-- as editing the files from the theme itself will not preserve the other mods you already have installed.
Title: Re: Bookmarks
Post by: LinK187 on August 18, 2008, 07:14:49 PM
Quote from: ccbtimewiz on August 18, 2008, 07:02:09 PM
Quote from: LinK187 on August 18, 2008, 07:00:03 PM
Quote from: ccbtimewiz on August 18, 2008, 06:58:36 PM
Quote from: LinK187 on August 18, 2008, 06:57:50 PM
Quote from: ccbtimewiz
You need to make your own edits manually.

No ******. I'm asking for help in doing so.

If you're asking for help to manually install this mod, then attach your files.

I have the mod installed, I need the tweaks to add to the above mentioned themes so the bookmark functionality is visible and clickable to users. I do believe I provided links to the themes.

Please provide the files-- as editing the files from the theme itself will not preserve the other mods you already have installed.

Which files do you need?
Title: Re: Bookmarks
Post by: Kimmie on August 18, 2008, 07:43:39 PM
Quote from: ccbtimewiz on August 18, 2008, 06:44:45 PM
Quote from: Kimmie on August 18, 2008, 05:43:05 AM
that seemed to have fixed the parse error but now I get these errors in my log

8: Undefined index: bookmark_add
File: /home//public_html/Themes/default/languages/Profile.english.php (main sub template - eval?)
Line: 662

8: Undefined index: bookmark_add
File: /home//public_html/Themes/default/languages/ThankYouPost.english.php (main sub template - eval?)
Line: 662


These errors happen a soon as someone views a topic. They appear to be stemming from users who are using a custom theme. I edited the files, but the add bookmark button isnt showing up on that theme (its fine on the other 2).

*I also cannot get the button on the menu bar to show up no matter which code I use (the one on the parser for the index.template file, or copying the code for a button that already there and changing it to bookmarks.)

Any ideas?

Link to site?

patriotgames2.info. However, I have temporarily uninstalled the mod because every time someone viewed a topic it threw both those errors in the log (2 errors for every view added up fast). If you would like me to reinstall it, let me know when you will be available to be on to actaully look at it so I can have minimal time on receiving errors.

Title: Re: Bookmarks
Post by: chinaren on August 19, 2008, 10:08:54 AM
Hello. I've just downloaded this, but when I go to the installer, I get the following:

Quote3.   Execute Modification   ./Themes/default/index.template.php   Test failed

I've checked, and the index.template.php file is where it should be.  I'm running the basic theme, with a couple of mods installed. 

Any ideas? 

Title: Re: Bookmarks
Post by: Kimmie on August 20, 2008, 01:46:20 AM
Quote from: chinaren on August 19, 2008, 10:08:54 AM
Hello. I've just downloaded this, but when I go to the installer, I get the following:

Quote3.   Execute Modification   ./Themes/default/index.template.php   Test failed

I've checked, and the index.template.php file is where it should be.  I'm running the basic theme, with a couple of mods installed. 

Any ideas? 



that means that one of the mods you already have installed has modified that file. You will have to manually install the code for that particular file.
Title: Re: Bookmarks
Post by: chinaren on August 20, 2008, 02:00:49 AM
Ah, got it. Thanks.
Title: Re: Bookmarks
Post by: AlenNS on August 20, 2008, 07:41:28 AM
Quote from: Aäron on August 07, 2008, 09:46:50 AM
Quote from: AlenNS on August 05, 2008, 05:31:29 PM
I've used codes from MessageIndex.template.php of Babylon Theme and got empty cells with no information.

That's because the rest isn't loaded in Bookmarks.php. You can easily add it to the query though.
Please Aäron, could you help me with this. It is empty for a month. :(
Title: Re: Bookmarks
Post by: Kimmie on August 23, 2008, 12:22:29 AM
I as able to get all the issues resolved and the mod works great on both my default and 2 custom themes. :)
Title: Re: Bookmarks
Post by: Ncen on August 23, 2008, 12:43:11 PM
Could people with admin-access be able to view other peoples bookmarks? I'm planing on using that to view my other accounts bookmarks, and both accounts have admin-access. ^^' Because adding the same bookmarks for both accounts is going to be problematic since i have so many on my main account. ^^

Hm, and is it possible to add somekind of counter at the bottom of the page telling you how many bookmarks you have? :)
Title: Re: Bookmarks
Post by: AlenNS on August 23, 2008, 12:53:23 PM
Quote from: AlenNS on August 20, 2008, 07:41:28 AM
Quote from: Aäron on August 07, 2008, 09:46:50 AM
Quote from: AlenNS on August 05, 2008, 05:31:29 PM
I've used codes from MessageIndex.template.php of Babylon Theme and got empty cells with no information.

That's because the rest isn't loaded in Bookmarks.php. You can easily add it to the query though.
Please Aäron, could you help me with this. It is empty for a month. :(
Bump!
Title: Re: Bookmarks
Post by: Aaron on August 23, 2008, 01:51:28 PM
Quote from: AlenNS on August 20, 2008, 07:41:28 AM
Please Aäron, could you help me with this. It is empty for a month. :(

Has it occured to you that you could just revert to the unmodified version of the mod? ::)

Okay, you want replies, views, the last message and its time in it. That's four extra things to load. You can't expect them to work after only adding them to the templates, as they aren't loaded in the query in my version of the mod. You'll have to modify both the query and the definition of the bookmarks array just after the query, too. If you're not sure how to do this, I suggest you have a look at the query in MessageIndex.php, which queries everything you want to show, except it's for a specific board instead of the bookmarks table.
Title: Re: Bookmarks
Post by: busterone on August 24, 2008, 12:01:59 PM
Hi Aäron. I just installed the bookmarks mod and all went as it should. However, even though it is working for my users, it is constantly giving me this error.

8: Undefined index: bookmark_add
File: /homepages/31/d250717583/htdocs/Themes/default/Display.template.php (main sub template - eval?)
Line: 1232

My Display.template.php only has 692 lines. This one is confusing the heck out of me.
Title: Re: Bookmarks
Post by: Aaron on August 24, 2008, 05:03:23 PM
Are you using a language pack other than English? Then you have to modify the corresponding Modifications language file manually. Note that the mod only modifies the non-UTF8 versions of the language files, so even if you are using English but in UTF8, you'd have to modify Modifications.english-utf8.php manually. :)
Title: Re: Bookmarks
Post by: busterone on August 24, 2008, 06:19:47 PM
Thanks. It is strange, I don't use utf-8, so I didn't bother to manually add it to that file in the start.  The file has never been used. It did not even have the correct <?php in the beginning or ?> at the end. I added them and the correct code and the  errors stopped. I have no idea why, but it worked. Thanks again.  :)
Title: Re: Bookmarks
Post by: busterone on August 24, 2008, 09:15:13 PM
They have all returned again. Evidently, no one was using the bookmark function for awhile. Now the same error is back- 4 pages worth in less than an hour.
Title: Re: Bookmarks
Post by: Sakae on August 25, 2008, 12:19:20 AM
Hi, I've read half of the topic (the last half), so sorry if someone asked before, but is any chance to see "Top X bookmarked topics" SSI function?
Title: Re: Bookmarks
Post by: busterone on August 27, 2008, 12:43:46 AM
Problem solved.  :)
Title: Re: Bookmarks
Post by: digger on September 06, 2008, 07:00:01 PM
Russian lang for Bookmarks
Title: Re: Bookmarks
Post by: Sakae on September 07, 2008, 07:24:00 PM
Quote from: softcore on August 25, 2008, 12:19:20 AM
Hi, I've read half of the topic (the last half), so sorry if someone asked before, but is any chance to see "Top X bookmarked topics" SSI function?

Bump?
Title: Re: Bookmarks
Post by: jepot5 on September 18, 2008, 01:45:30 AM
Quote from: Aäron on August 23, 2008, 01:51:28 PM
Quote from: AlenNS on August 20, 2008, 07:41:28 AM
Please Aäron, could you help me with this. It is empty for a month. :(

Has it occured to you that you could just revert to the unmodified version of the mod? ::)

Okay, you want replies, views, the last message and its time in it. That's four extra things to load. You can't expect them to work after only adding them to the templates, as they aren't loaded in the query in my version of the mod. You'll have to modify both the query and the definition of the bookmarks array just after the query, too. If you're not sure how to do this, I suggest you have a look at the query in MessageIndex.php, which queries everything you want to show, except it's for a specific board instead of the bookmarks table.

Can anyone help me with this? I want to see the code for the query, and I also tried putting the code for 'last_post' array in Bookmarks.php but I am not sure if its right.
Title: Re: Bookmarks
Post by: AlenNS on September 18, 2008, 08:07:57 AM
It doesn't work for me.

I've tried several changes with no success .
Also asked Aaron for help but didn't get any.

I hope this time will have more lucky. :)

Here's my edited files.

Title: Re: Bookmarks
Post by: AlenNS on September 19, 2008, 09:23:21 AM
Bump!
Title: Re: Bookmarks
Post by: tridirk on September 26, 2008, 12:51:36 AM
Will this work for 1.1.16?  and I tried installing and got the error message about incompatibility.
Title: Re: Bookmarks
Post by: Ravac on September 26, 2008, 02:05:08 AM
Modifications.serbian-utf8.php (Latinic)


$txt['bookmarks'] = 'Moji Bookmarks-i';
$txt['bookmark_not_for_guests'] = 'Izvini te, ali jedino registrovani članovi mogu koristiti bookmark opciju!';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'Trenutno nemate ni jedan bookmark sačuvan. Dodaj klikom na \'Add bookmark\' u topiku.';
$txt['bookmark_open_window'] = 'Otvori u novom prozoru';
$txt['bookmark_delete'] = 'Izbriši selektovane bookmarks-e';
$txt['bookmark_delete_success'] = '%1$s bookmarks-i su uspešno obrisani!';
$txt['bookmark_delete_failure'] = 'Nemogu se obrisati neki bookmarks-i.';
$txt['bookmark_add'] = 'Dodaj bookmark';
$txt['bookmark_add_success'] = 'Ovaj topik uspešno je dodat u vaš bookmarks!';
$txt['bookmark_add_exists'] = 'Ovaj topik se već nalazi u vašem bookmarks-u!';
$txt['bookmark_add_failed'] = 'Neuspelo dodavanje topik-a u bookmarks.';
Title: Re: Bookmarks
Post by: squad on September 27, 2008, 02:09:08 PM
Quote from: tridirk on September 26, 2008, 12:51:36 AM
Will this work for 1.1.16?  and I tried installing and got the error message about incompatibility.

I managed to get it to work on 1.1.6 Core only.

I need to know, please, will work with 2.0 Beta 4 and should I be able to install it
easily via the mod site, since my Package Manager is not presently working?

Thank you, this is such a great mod for a site like mine :)
Title: Re: Bookmarks
Post by: squad on September 30, 2008, 05:14:37 AM
Quote from: squad on September 27, 2008, 02:09:08 PM
Quote from: tridirk on September 26, 2008, 12:51:36 AM
Will this work for 1.1.16?  and I tried installing and got the error message about incompatibility.

I managed to get it to work on 1.1.6 Core only.

I need to know, please, will work with 2.0 Beta 4 and should I be able to install it
easily via the mod site, since my Package Manager is not presently working?

Thank you, this is such a great mod for a site like mine :)

ANyine know if it will work on 2.0 Beta 4 and will it work on all preinstalled themes,
ie; Core, as well as Babylon and Classic YaBB SE Theme

Please :)
Title: Re: Bookmarks
Post by: Frozt on October 01, 2008, 05:16:59 PM
Quote from: chinaren on August 19, 2008, 10:08:54 AM
Hello. I've just downloaded this, but when I go to the installer, I get the following:

Quote3.   Execute Modification   ./Themes/default/index.template.php   Test failed

I've checked, and the index.template.php file is where it should be.  I'm running the basic theme, with a couple of mods installed. 

Any ideas?

I installed bookmarks 2.1.2 in SMF 1.1.6 and I have the same warning

I see that is a piece of code that change the code in the file that do the warning, the mods "Tagging System" (in 1.1.1 version happen to me) or with mod "Google Tagged" ( version 1.4)  change this file:

/Themes/default/index.template.php

that mods change this line:

if (in_array($context['current_action'], array('search',

"Tagging System" change it to:

if (in_array($context['current_action'], array('tags','search',

"Google Tagged" change it to:
if (in_array($context['current_action'], array('tagged','search',

so the bookmarks mod cant install



1) I unzip the bookmarks212.zip file

2) and edit this file:

bookmarks11.xml

(for smf 1.1.6 versions)

and I search for:

if (in_array($context['current_action'], array('search',

3) and change it by:

if (in_array($context['current_action'], array('tags','search',

then save the changes in the file

and do a repacked of all files of that mod in a zip called bookmarks212.zip

then I can install it :)



in the case of have the "Google Tagged" mod, the line of stage 3 is:

if (in_array($context['current_action'], array('tagged','search',



work good, the only problem is in the last column of last post, there are a problem with the table, is possible that one of the mods that I have installed altered it
this is an image of it:
img241 dot imageshack dot us/my.php?image=bookmarksdh5.jpg
Title: Re: Bookmarks
Post by: Frozt on October 06, 2008, 01:58:13 PM
Quote from: Aäron on July 12, 2008, 11:44:25 AM
Quote from: Angelotus on July 12, 2008, 11:41:22 AM
I have to install the bookmarks database table manually.
What code to use in phpmyadmin??

That's been said at least ten times already. :P Anyway:

CREATE TABLE smf_bookmarks
(
   `ID_MEMBER` mediumint(8) unsigned NOT NULL,
   `ID_TOPIC` mediumint(8) unsigned NOT NULL,
   UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
);


this is for 2.0 Beta 4 too?

I haven´t problems when I installed the mod, and work fine when add topics to bookmarks in 2.0 Beta 4

but when I go to see "My Bookmarks" appear this:

Database Error
Table 'forum.smf_bookmarks' dont exist
File: ...\Sources\Bookmarks.php
Line: 62



with 1.1.6 I havent this problem but I would like to install the mod in 2.0 Beta 4

I see in the install of smf20 file that is a bit different of the version smf11 so I would like to know if I do something wrong if I try to add the table manually
Title: Re: Bookmarks
Post by: InternetMafia on October 09, 2008, 06:59:02 PM
Any plans to make this compatible with 1.1.6
Title: Re: Bookmarks
Post by: digger on October 09, 2008, 08:21:22 PM
Quote from: InternetMafia on October 09, 2008, 06:59:02 PM
Any plans to make this compatible with 1.1.6
It works with 1.1.6
Title: Re: Bookmarks
Post by: bn7 on October 10, 2008, 04:43:00 PM
It works with 1.1.6 for me... but ONLY with admin account. Users can't view [BOOKMARK ADD] in Display.template.php.

Any idea?

Thanks
Title: Re: Bookmarks
Post by: Sakae on October 10, 2008, 05:03:27 PM
bn7, try to add "view bookmark" permission on manage permissions admin page.
Title: Re: Bookmarks
Post by: bn7 on October 10, 2008, 05:26:58 PM
In Member->Permissions there isn't any bookmark related voice...
Title: Re: Bookmarks
Post by: bn7 on October 11, 2008, 03:49:44 PM
Understand. Problem is that i have forum with only read permission.
If you have a board without write/posts permission, mod works (with manual link to bookmark_add page) but don't appear in template.
However softcore thanks for your support :)
Title: Re: Bookmarks
Post by: bn7 on October 11, 2008, 04:06:20 PM
So, now a little question:

for example, if i set a forum in read mode only,  [REPLY] link disappear.
For bookmark is the same and [ADD BOOKMARK] link disappear.
I wish that this link remain with logged users (but obviously not for visitors).
Please, can you help me?

Thanks
Title: Re: Bookmarks
Post by: Aaron on October 13, 2008, 10:54:33 AM
Okay, I just released version 2.2 of the bookmarks mod, which features a new 'My bookmarks' template and a proper way to (dis)allow users to make new bookmarks. :)

@bn7 and AlenNS: this release was made with your comments in mind. I hope you'll excuse the fact that you had to wait for it this long - my priorities have changed recently, as you'll probably have noticed.

Changelog for version 2.2:

As usually, the new package can be downloaded from the mod site (http://custom.simplemachines.org/mods/index.php?mod=864). :)
Title: Re: Bookmarks
Post by: Paracelsus on October 13, 2008, 02:11:08 PM
Aäron,

How is it for those who have the previous version of Bookmarks? Uninstall and install the new package or try to update it manually?
Title: Re: Bookmarks
Post by: Aaron on October 13, 2008, 02:13:23 PM
If you uninstall the previous version and install the new version, then that should do the trick. :)
Title: Re: Bookmarks
Post by: tridirk on October 13, 2008, 03:56:14 PM
When I install this on the smf forum, I still get an error message telling me to stop and not install, as it is not for my 1.1.16 version?

What do I need to do?
Title: Re: Bookmarks
Post by: Aaron on October 13, 2008, 04:45:05 PM
It should be compatible with SMF 1.1.6. You probably have other mods installed that conflict with this one. Try the manual installation instructions found on the mod page.
Title: Re: Bookmarks
Post by: bn7 on October 13, 2008, 08:47:27 PM
Very thanks Aäron :)

However i've another problem with logged users.

Now [ADD BOOKMARKS] link is ok but i receive an error with db if i try try to add a bookmark.

Error is in index.LANGUAGE.php and call this 2 lines:

// Use numeric entities in the below string.
$txt[1001] = 'Database Error';
$txt[1002] = 'Please try again.  If you come back to this error screen, report the error to an administrator.';

(uhm wow!...i must report error to myself :( ...and then? )  -->ok little humor :)

Another thanks Aäron for your great mod and for your support!

:)
Title: Re: Bookmarks
Post by: Garry1953 on October 14, 2008, 01:25:25 AM
Hi
When Accessing: Admin/Calendar/Calendar Settings     
I Get the below error.

Parse error: syntax error, unexpected ',' in /home/My Site in Here/public_html/art-forum/Sources/ManagePermissions.php on line 2189

This is caused by the Bookmark mod.
Once I uninstall Bookmark 2.2 the Parse error goes away.

I hope you can sort this out, as i really like this mod.
Garry

P.S. I tested this on a clean install of SMF v2.0 beta 4 with no other mods installed.
Title: Re: Bookmarks
Post by: Frozt on October 14, 2008, 06:13:18 AM
I can install the new version 2.2 in 2.0 Beta 4 without problems
thanks  :D
Title: Re: Bookmarks
Post by: Frozt on October 14, 2008, 02:37:51 PM
Calendar work for me in 2.0 Beta 4

but not Admin > Member > Permissions

Appear this error when I try to access it:

Parse error: parse error, unexpected ',' in ..\Sources\ManagePermissions.php on line 2155

and when I try to add a board the same error
Title: Re: Bookmarks
Post by: tk2012 on October 14, 2008, 06:46:37 PM
I installed on my b4.0 forum!  I went back and checked line by line to make sure and all was good.  But, when I try to go into ADMIN > BOARDS > Modify board I can't edit the boards.  When I uninstall the mod, I can get in there.  Also, when installed, the ADMIN > MODIFICATIONS > Custom Forms tab doesn't work, but when I uninstall Bookmarks it works again.

Do I still need to make that code change in the .xml file?
Title: Re: Bookmarks
Post by: somebody-else on October 16, 2008, 12:11:45 AM
This mod doesn't work for me.
I use SMF 1.1.6 with the Classic YaBB SE Theme installed with a slightly tweaked css stylesheet. Installed (and working) mods so far :
- Remove MySQL, PHP & W3C images to minimize footer size
- Custom Copyright

I uploaded the package, installed it (no error messages) and did the manual changes.

The bookmark link does not appear anywhere. I have to say that i did not do the instructions in the Code section ...
Code
smf11/install.php
This file should not be able to execute standalone. You may have to run the following queries manually.

Query: [Select]

CREATE TABLE IF NOT EXISTS {$db_prefix}bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)

That is because i didn't really understand what i was supposed to do.

If that is the problem, could somebody please give me more details on how to do that step. Or if that is not the problem give me some pointer as to what might be the problem.



Thank you.
Title: Re: Bookmarks
Post by: Frozt on October 16, 2008, 05:37:53 AM
You have to enter in your database manager, your hosting must have one, usually is phpmyadmin

If you do all the installation manually you need to have the database table of Bookmarks in your database for work the mod

if you have phpmyadmin enter the database of the forum
first see in your database if appear the database table of Bookmarks:
"smf_bookmarks"
if appear then it doesnt the problem and dont do the next
if not appear that database table you have to insert it manually
you have insert it in SQL section, see a horizontal menu in the top,
click in "SQL", will appear a textarea "Execute sql query..."
copy that code of the instructions and pasted it there,
then click in continue button and that include the database table of Bookmarks in your database
Title: Re: Bookmarks
Post by: somebody-else on October 16, 2008, 06:11:12 PM
I checked, smf_bookmarks waspresent and looked correct. Still, the bookmarks are not working yet.

Any help would be appreciated.


Thanks.
Title: Re: Bookmarks
Post by: bn7 on October 17, 2008, 10:00:28 AM
I made some tests. I think i'll must return to the old bookmark mod, because now, in any topics (with and without write permission) with logged user i receive this error:

"Please try again.  If you come back to this error screen, report the error to an administrator."

Any other idea would be appreciated.

Thanks in advance :)

EDIT/ADD: No problem and no db error with an admin account.
Title: Re: Bookmarks
Post by: efil59 on October 17, 2008, 10:52:50 AM
Hi,
Where can i set Permissions?
Title: Re: Bookmarks
Post by: Aaron on October 17, 2008, 11:05:22 AM
Quote from: bn7 on October 17, 2008, 10:00:28 AM
I made some tests. I think i'll must return to the old bookmark mod, because now, in any topics (with and without write permission) with logged user i receive this error:

Which version of SMF are you using? I tested both the version for SMF 1.1 and 2.0 from an admin perspective, and both seemed to be working alright.

Quote from: efil59 on October 17, 2008, 10:52:50 AM
Hi,
Where can i set Permissions?

Go to the admin center and click the 'permissions' link.
Title: Re: Bookmarks
Post by: efil59 on October 17, 2008, 11:27:49 AM

QuoteGo to the admin center and click the 'permissions' link.


Can't find there.
The mod i working good but only for the admin.
maybe somthing in the installation went wrong.
Title: Re: Bookmarks
Post by: AlenNS on October 17, 2008, 12:49:41 PM
Quote from: Aäron on October 13, 2008, 10:54:33 AM
Okay, I just released version 2.2 of the bookmarks mod, which features a new 'My bookmarks' template and a proper way to (dis)allow users to make new bookmarks. :)

@bn7 and AlenNS: this release was made with your comments in mind. I hope you'll excuse the fact that you had to wait for it this long - my priorities have changed recently, as you'll probably have noticed.

Changelog for version 2.2:

  • + Extended the database query for the 'view bookmarks' screen to allow better customization of the bookmarks template.
  • & Enhanced the layout of the 'view bookmarks' template to include replies, views and last post.
  • * Added Serbian translation.
  • + Whether users can create bookmarks or not, now relies on a unique permission (make_bookmarks) instead of the can_reply permission.
  • * Added a few strings to the translations to support the above.
  • ! Made the mod installable on SMF 2.0 Beta 4.

As usually, the new package can be downloaded from the mod site (http://custom.simplemachines.org/mods/index.php?mod=864). :)
Aaron, thank you very much for this modification of your mod. It's fantastic! :)
Title: Re: Bookmarks
Post by: efil59 on October 17, 2008, 04:48:54 PM
Quote from: efil59 on October 17, 2008, 11:27:49 AM

QuoteGo to the admin center and click the 'permissions' link.


Can't find there.
The mod i working good but only for the admin.
maybe somthing in the installation went wrong.

Ok I found the problem.
But now it's working only for the admin.
When my users try to use the mod thay get this:
QuoteDatabase Error
Please try again. If you come back to this error screen, report the error to an administrator.
Title: Re: Bookmarks
Post by: bn7 on October 17, 2008, 04:56:13 PM
Quote from: Aäron on October 17, 2008, 11:05:22 AM
Which version of SMF are you using? I tested both the version for SMF 1.1 and 2.0 from an admin perspective, and both seemed to be working alright.

First off i set permissions (flag the option for create bookmarks for the topic).
Then link in template appear but isn't usable.

I use SMF 1.1.6

With previous mod this problems wasn't present.
Only problems with board in read mode like explain in previous posts.
Title: Re: Bookmarks
Post by: Nathaniel on October 18, 2008, 05:07:35 AM
As pointed out by Garry1953 (http://www.simplemachines.org/community/index.php?topic=182923.msg1751451#msg1751451) and Frozt (http://www.simplemachines.org/community/index.php?topic=182923.msg1752226#msg1752226), there is an error with the 2.2 version of this mod for SMF 2 Beta.

Line 46 of 'bookmarks22.xml' is:
            <search position="after"><![CDATA[
It should be:
            <search position="before"><![CDATA[
Title: Re: Bookmarks
Post by: Frozt on October 18, 2008, 06:17:03 AM
Thanks LHVWB

Now work well  :) :) :)

Title: Re: Bookmarks
Post by: Garry1953 on October 18, 2008, 02:28:08 PM
LHVWB
Your change to the code fixes the problem.
Thanks :D
Title: Re: Bookmarks
Post by: efil59 on October 19, 2008, 12:50:15 AM
Quote from: efil59 on October 17, 2008, 04:48:54 PM
Quote from: efil59 on October 17, 2008, 11:27:49 AM

QuoteGo to the admin center and click the 'permissions' link.


Can't find there.
The mod i working good but only for the admin.
maybe somthing in the installation went wrong.

Ok I found the problem.
But now it's working only for the admin.
When my users try to use the mod thay get this:
QuoteDatabase Error
Please try again. If you come back to this error screen, report the error to an administrator.

Can someone help me?
Title: Re: Bookmarks
Post by: tk2012 on October 19, 2008, 11:31:33 AM
For those who don't know how to edit the .xml file and then zip it back up, I have attached it here.

This is the correct package for v2.0 b4.0  which makes the changes addressed above.

Title: Re: Bookmarks
Post by: gexposito on October 20, 2008, 10:19:46 AM
Hi,

I have the same  error.   This mod work fine  only for Admin.

When my users try to use the mod thay get this:
    Database Error
    Please try again. If you come back to this error screen, report the error to an administrator.

But the data ( id_user and id post) is inserted in the sql correctly.

The user have activated the permissions.

I have 1.1.6 ver.

any idea?
Title: Re: Bookmarks
Post by: trailmyx on October 20, 2008, 02:39:38 PM
Perhaps this will help Aaron debug this issue for those using SMF 1.1.6 and are having the:

Quote
Database Error
Please try again. If you come back to this error screen, report the error to an administrator.

Correct installation allows the admin to add bookmarks fine, but no other user to do so (yes, permissions have been granted for each group).

If you look at the forum error log, you find:

Quote
http://www.myforum.com/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Unknown column 'b.memberGroups' in 'where clause'
File: /www.myforum.com/smf/Sources/Bookmarks.php
Line: 65

This happens when you just click the "My Bookmarks" or try to add one using "Add Bookmarks"

Hope this helps.

TM
Title: Re: Bookmarks
Post by: gexposito on October 20, 2008, 03:32:59 PM
Trailmix,  very thanks.

I solved this error ( I believe ):

Bookmarks.php

near line 65:
ORIGINAL:

   bm.ID_MEMBER = {$ID_MEMBER}

         AND {$user_info['query_see_board']}            <<<<<<<<<<< delete this line.

      ORDER BY t.id_last_msg DESC",

      __FILE__, __LINE__);



NOW:
WHERE
                        bm.ID_MEMBER = $ID_MEMBER

                ORDER BY t.id_last_msg DESC",
                __FILE__, __LINE__);


It work fine for me.

somebody can verify this and comment it?

Title: Re: Bookmarks
Post by: Aaron on October 20, 2008, 04:00:22 PM
Thanks for the feedback everyone. The problems mentioned should be fixed in version 2.2.1. :)
Title: Re: Bookmarks
Post by: trailmyx on October 20, 2008, 04:22:41 PM
Quote from: Aäron on October 20, 2008, 04:00:22 PM
Thanks for the feedback everyone. The problems mentioned should be fixed in version 2.2.1. :)

Beautiful!  That worked perfectly.  Now my Moderator can stop whining.  eheh.

Thank you for your effort; great mod!

TM
Title: Re: Bookmarks
Post by: DocPixel on October 20, 2008, 10:03:34 PM
I'm trying to install this mod, and I get these errors;
Execute Modification      ./Sources/ManagePermissions.php     Test failed

5.    Execute Modification    ./Themes/default/index.template.php    Test failed

I'm running SMF 1.1.6 and the mod version is the newly updated one from today; 221.


I'm not sure whether I should install it or not.  Aäron, what do you think is causing these errors?
Title: Re: Bookmarks
Post by: trailmyx on October 21, 2008, 12:29:46 AM
One thing you have to keep in mind is that after you install a few other mods, you run the risk of breaking the installation of other packages. 

This mod didn't install for me either, but I've gotten used to  modifying installation packages to adjust for possible differences.  You really need to look at what the install package (for you would be bookmarks11.xml) is trying to change (changes to index.template.php) and be sure the item being searched for exists in your present site installation.  If not, it probably still exists, but you'll need to modify it a bit.

The problem here is that it's subjective to your installation and what packages you presently have.
Title: Re: Bookmarks
Post by: DocPixel on October 21, 2008, 01:42:46 AM
Would it be helpful if I posted the specific list of mods I've installed?

Mainly, I want to be sure that if I go ahead, I won't break anything that's already working fine. The bookmark isn't a huge priority for me.

I can do simple edits, but I need my hand held for anything more than that.
Title: Re: Bookmarks
Post by: efil59 on October 21, 2008, 01:43:08 AM
Quote from: Aäron on October 20, 2008, 04:00:22 PM
Thanks for the feedback everyone. The problems mentioned should be fixed in version 2.2.1. :)

Working great! :)

Title: Re: Bookmarks
Post by: trailmyx on October 21, 2008, 12:27:12 PM
Quote from: DocPixel on October 21, 2008, 01:42:46 AM
Would it be helpful if I posted the specific list of mods I've installed?


That's always helpful.  But first, think about the other mods you've installed.  Judging from the error you are having, it has something to do with the modifications that are being made to your toolbar.  What other mods have you added to your site that have affected the toolbar?  For me, it was the File Download mod and a "by hand" mod to add a "New Posts" button.
Title: Re: Bookmarks
Post by: hansdampf on October 21, 2008, 02:33:22 PM
Thanks for this mod, working great.

If I may suggest a slightly better German translation:

$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzuf&uuml;gen\' in den Threads erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster &ouml;ffnen';
$txt['bookmark_delete'] = 'Lesezeichen l&ouml;schen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gel&ouml;scht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gel&ouml;scht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzuf&uuml;gen';
$txt['bookmark_add_success'] = 'Thread wurde erfolgreich zu deinen Lesezeichen hinzugef&uuml;gt!';
$txt['bookmark_add_exists'] = 'Dieser Thread befindet sich bereits in deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim Hinzuf&uuml;gen des Threads zu Deinen Lesezeichen aufgetreten!';
// Untranslated!
$txt['permissionname_make_bookmarks'] = 'Darf Bookmarks zu Themen anlegen.';
$txt['cannot_make_bookmarks'] = 'Dir fehlt leider die Berechtigung Bookmarks anzulegen!';
Title: Re: Bookmarks
Post by: DocPixel on October 21, 2008, 05:46:29 PM
Quote from: trailmyx on October 21, 2008, 12:27:12 PM
Quote from: DocPixel on October 21, 2008, 01:42:46 AM
Would it be helpful if I posted the specific list of mods I've installed?


That's always helpful.  But first, think about the other mods you've installed.  Judging from the error you are having, it has something to do with the modifications that are being made to your toolbar.  What other mods have you added to your site that have affected the toolbar?  For me, it was the File Download mod and a "by hand" mod to add a "New Posts" button.

Trailmyx, I'll post the mod list and a screen shot of my toolbar. I installed the "draft" mod, which adds a button below. Is that considered part of the toolbar?

And I'm attaching the two files in question - I've looked, but can't seem to unravel what it's looking for. 

Mod Name     Version     
1.    SMF Gallery Lite    1.7.1    [ List Files ] [ Delete ]
2.    SMF 1.1.2 Update Package    1.1.2    [ List Files ] [ Delete ]
3.    SMF 1.0.12 / 1.1.4 / 2.0 b1.1 Update    1.0    [ List Files ] [ Delete ]
4.    SMF 1.0.11 / 1.1.3 Update    1.1    [ List Files ] [ Delete ]
5.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
6.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
7.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
8.    Global Headers Footers    1.3    [ Uninstall ] [ List Files ] [ Delete ]
9.    Paid Subscriptions    0.18    [ Uninstall ] [ List Files ] [ Delete ]
10.    Tagging System    1.0.5    [ Uninstall ] [ List Files ] [ Delete ]
11.    TinyPortal    1.052    [ Uninstall ] [ List Files ] [ Delete ]
12.    SMF 1.0.14 / 1.1.6 Update    1.0    [ Uninstall ] [ List Files ] [ Delete ]
13.    SMF Sitemap    1.2.2    [ Uninstall ] [ List Files ] [ Delete ]
14.    Admin Notepad    1.0    [ Uninstall ] [ List Files ] [ Delete ]
15.    SMF Gallery Pro    1.4.0.3    [ Uninstall ] [ List Files ] [ Delete ]
16.    Newsletter Pro    1.0.2    [ Uninstall ] [ List Files ] [ Delete ]
17.    Drafts (for 1.1.x)    1.08    [ Uninstall ] [ List Files ] [ Delete ]
18.    Bookmarks    2.2.1    [ Apply Mod ] [ List Files ] [ Delete ]

And thanks.  :)
Title: Re: Bookmarks
Post by: trailmyx on October 22, 2008, 01:20:39 AM
Hmm, well my theory was wrong in your case.  For the index.template.php section of the bookmarks11.xml file of the mod package it looks for two changes, and both of the places in your index.template.php have not been corrupted by another package.  So I don't see a reason why this section would fail for you.  You seem to have a different problem than I did.

Thanks for posting your index.template.php file, that helped me check that for you easily.

Unfortunately, I'm pretty new to this and have already spent all my silver bullets... :)  It's time for a PRO to help ya.  heh

Title: Re: Bookmarks
Post by: DocPixel on October 22, 2008, 01:32:45 AM
I appreciate your time and effort, Trailmyx, and learned some stuff too. You obviously know a lot!

I hope Aäron will have time soon to take a look.  ;)
Title: Re: Bookmarks
Post by: Forte on October 22, 2008, 03:45:25 PM
There's a problem with mine for some reason. No one is able to access it, and it gives the error message that they're not allowed to have bookmarks, but there's no permissions for it in either the database or on the forums. Is something supposed to be changed somewhere else?
Title: Re: Bookmarks
Post by: Frozt on October 22, 2008, 05:16:03 PM
Quote from: Forte on October 22, 2008, 03:45:25 PM
There's a problem with mine for some reason. No one is able to access it, and it gives the error message that they're not allowed to have bookmarks, but there's no permissions for it in either the database or on the forums. Is something supposed to be changed somewhere else?

see this for see if why show that error:

http://www.simplemachines.org/community/index.php?topic=182923.msg1757032#msg1757032
Title: Re: Bookmarks
Post by: Forte on October 22, 2008, 09:39:39 PM
Must not be the problem, it's correct in mine.
Title: Re: Bookmarks
Post by: Armin2008 on November 07, 2008, 12:01:29 AM
I got a problem with this mod. The problem is it wont show the link for the bookmark. Is there a settings option that i have to enable? if so where is it. I looked everywhere for it.

I am using SMF 1.7, and these mods:

Quote1.     Bookmarks      2.2.1       [ Uninstall ]  [ List Files ]  [ Delete ]
2.    SMFShop    3.0    [ Uninstall ] [ List Files ] [ Delete ]
3.    nneonneo's AJAX ShoutBox    1.21    [ Uninstall ] [ List Files ] [ Delete ]
4.    Limit A Guests Daily PageViews Mod    1.0    [ Uninstall ] [ List Files ] [ Delete ]
5.    Member Color Link    3.0.5a    [ Uninstall ] [ List Files ] [ Delete ]
6.    Auto Embed Video/Audio Clips    4.0.2    [ Uninstall ] [ List Files ] [ Delete ]
Title: Re: Bookmarks
Post by: efil59 on November 09, 2008, 11:05:25 AM
Hi,
After I upgrade to 1.1.7 the mod is not working.
Title: Re: Bookmarks
Post by: Sudhakar Arjunan on November 15, 2008, 11:50:42 PM
As i could see many reported here,

Error Log, No one could use bookmark.

http://sitename.com/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Unknown column 'b.member_groups' in 'where clause'
Apply Filter: Only show the errors from this file
File: /home/sitename/public_html/forum/Sources/Bookmarks.php
Line: 70

I have compared with this post http://www.simplemachines.org/community/index.php?topic=182923.msg1760818#msg1760818 ,

And found the codes are different in our 2.0. beta 4 .

here the sample line which is there in our file.


Line 62 to 70 :

bm.id_member = {int:current_member}' . (!$modSettings['postmod_active'] || allowedTo('approve_posts') ? '' : '
AND (t.approved = {int:is_approved} OR t.id_member_started = {int:current_member})') . '
AND {query_see_board}
ORDER BY t.id_last_msg DESC',
array(
'current_member' => $user_info['id'],
'is_approved' => 1,
)
);


Any suggestions for it.
Title: Re: Bookmarks
Post by: Carlos Gandra on November 16, 2008, 02:48:02 PM
Hi,

Can someone help me with this?
http://www.simplemachines.org/community/index.php?topic=274716.0

That's a conflict between Pretty URLs and Bookmarks :)

Thanks
Title: Re: Bookmarks
Post by: tk2012 on November 20, 2008, 11:12:28 AM
Quote from: A.SK on November 15, 2008, 11:50:42 PM
As i could see many reported here,

Error Log, No one could use bookmark.

http://sitename.com/index.php?action=bookmarks
Apply Filter: Only show the errors with the same message
Database Error: Unknown column 'b.member_groups' in 'where clause'
Apply Filter: Only show the errors from this file
File: /home/sitename/public_html/forum/Sources/Bookmarks.php
Line: 70

I have compared with this post http://www.simplemachines.org/community/index.php?topic=182923.msg1760818#msg1760818 ,

And found the codes are different in our 2.0. beta 4 .

here the sample line which is there in our file.


Line 62 to 70 :

bm.id_member = {int:current_member}' . (!$modSettings['postmod_active'] || allowedTo('approve_posts') ? '' : '
AND (t.approved = {int:is_approved} OR t.id_member_started = {int:current_member})') . '
AND {query_see_board}
ORDER BY t.id_last_msg DESC',
array(
'current_member' => $user_info['id'],
'is_approved' => 1,
)
);


Any suggestions for it.

I just got this same error on my forum as well.  I'm not sure how to correct.
Title: Re: Bookmarks
Post by: tk2012 on November 28, 2008, 12:47:37 PM
@ A.SK

Are you still getting the database errors for this modification that you posted?  I'm getting at least 3 or 4 a week with the same info posted above.
Title: Re: Bookmarks
Post by: Sudhakar Arjunan on December 03, 2008, 06:18:23 AM
Quote from: tk2012 on November 28, 2008, 12:47:37 PM
@ A.SK

Are you still getting the database errors for this modification that you posted?  I'm getting at least 3 or 4 a week with the same info posted above.

Yes i am still getting. Even permission were there, all users were getting this issue on clicking the My Bookmarks from menu.
Title: Re: Bookmarks
Post by: netoya on December 08, 2008, 11:55:44 AM
I use a modified theme based on a classic theme, so i cant manualy modify files index.template.php and Display.template.php becouse they dont contain code to find.  :(
Quoteindex.template.php
    Find:



       if (in_array($context['current_action'], array('search',
    Add After:


    'bookmarks',

    Find:



       // The [calendar]!
    Add Before:


        // The [bookmarks] button
       if (allowedTo('make_bookmarks'))
          echo ($current_action == 'bookmarks' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
                <td valign="top" class="maintab_' , $current_action == 'bookmarks' ? 'active_back' : 'back' , '">
                   <a href="', $scripturl, '?action=bookmarks">' , $txt['bookmarks'] , '</a>
                </td>' , $current_action == 'bookmarks' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';


    Display.template.php
    Find:


          'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),
    Add After:


          'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

my files attached
Title: Re: Bookmarks
Post by: tripl3r on December 11, 2008, 03:22:17 AM
I can only seem to view the bookmark section on my admin account no other, why is this?
Title: Re: Bookmarks
Post by: AlenNS on December 11, 2008, 11:09:37 AM
You need to add permissions for other membergroups.
Title: Re: Bookmarks
Post by: tripl3r on December 11, 2008, 04:37:48 PM
Thank you buddy i couldnt seem to find it in there before but have now, cheers for your time
Title: Re: Bookmarks
Post by: AlenNS on December 11, 2008, 05:16:06 PM
No problem at all. :)
Title: Re: Bookmarks
Post by: willerby on January 06, 2009, 12:56:40 PM
I installed this mod on v2.0 b4 today and struggled as to why the 'Add Bookmark' link did not appear in the topic menu. As admin the permissions were automatically set so nothing to do with them.

It turns out that I use the default and custom themes with images instead of text links and the Display.Template.php changes crucially have a missing image tag as follows:

'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),

should read...

'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', , 'image' => 'add_bookmark.gif',  'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic']),


You will also need to add a suitble image gif file named 'add_bookmark.gif' into ...Themes/<Theme Name>/images/english folder (or other language as appropriate)


Then it works!!!   :)
Title: Re: Bookmarks
Post by: Whimsical on January 10, 2009, 03:08:48 AM
Have just installed this on v1.1.7 and works great

Thank you! :)
Title: Re: Bookmarks
Post by: Dr Web on January 15, 2009, 06:46:48 AM
I've tried to install this MOD on a 1.1.5 SMF forum and I've got this error below.

3.     Execute Modification     ./Sources/ManagePermissions.php     Test failed

All the rest was successful, what can I do to install this successfully?

Thanks for any help.
Title: Re: Bookmarks
Post by: Jackson Cage on January 29, 2009, 09:50:14 AM
Quote from: AlenNS on December 11, 2008, 11:09:37 AM
You need to add permissions for other membergroups.

Where is that option. I can't seem to find it in the permissions.
Title: Re: Bookmarks
Post by: floydpink on January 31, 2009, 04:48:44 AM
Installed in 1.1.7 and works fine.
Great Mod, thanks!

Members requested the ability to sort by subject. Achieved this with the following edits:
Sources/Bookmarks.php
Findglobal $txt, $context, $scripturl, $settings, $modSettings, $user_info, $ID_MEMBER, $return, $smcFunc, $db_prefix;
Add After: // Floydpink INSERT - Add code to sort by subject
global $sort;
if (isset($_REQUEST['sort']))
$sortkey = "mf.subject ASC";
else
$sortkey = "t.id_last_msg DESC";


FindORDER BY t.id_last_msg DESC

Replace with ORDER BY $sortkey

Themes/Default/bookmarks.template.php
Find global $context, $settings, $scripturl, $txt, $return;

Add After: // Floydpink INSERT - get sort parameter from URL and set default to subject
global $sort;
if (!isset($_REQUEST['sort']))
$_REQUEST['sort'] = 'subject';

Find
<td class="titlebg">', $txt[70], '</td>

Replace with:
<!-- Floydpink INSERT - Add sort by Subject -->
<td class="titlebg"><a href="', $scripturl, '?action=bookmarks;sort=subject">', $txt[70], $_REQUEST['sort'] != 'last_post' ? ' <img src="' . $settings['images_url'] . '/sort_down.gif" alt="" />' : '','</a></td>


Find<td class="titlebg" width="22%">', $txt[111], '</td>

Replace with
<!-- Floydpink INSERT - Add sort by Last Post -->
<td class="titlebg" width="22%"><a href="', $scripturl, '?action=bookmarks;sort=last_post">', $txt[111], $_REQUEST['sort'] == 'last_post' ? ' <img src="' . $settings['images_url'] . '/sort_down.gif" alt="" />' : '','</a></td>


;D
Title: Re: Bookmarks
Post by: p1tereq on January 31, 2009, 01:42:58 PM
Fresh polish translation...

1. Polish translation 4yaa

Quote$txt['bookmarks'] = 'Lista śledzonych tematów';
$txt['bookmark_list'] = 'Śledzone tematy';
$txt['bookmark_list_empty'] = 'Nie obserwujesz obecnie żadnych wątków. Dodaj temat, klikając w przycisk \'Śledź temat\' w przeglądzie wątku.';
$txt['bookmark_open_window'] = 'Otwórz w nowym oknie';
$txt['bookmark_delete'] = 'Usuń obserwację wybranych wątków';
$txt['bookmark_delete_success'] = '%1$s śledzeń zostało usuniętych!';
$txt['bookmark_delete_failure'] = 'Niektóre tematy nie zostały usunięte z listy śledzonych wątków.';
$txt['bookmark_add'] = 'Śledź temat';
$txt['bookmark_add_success'] = 'Wybrany wątek został pomyślnie dodany do listy śledzonych przez Ciebie tematów';
$txt['bookmark_add_exists'] = 'Ten wątek już znajduje się na liście Twoich śledzonych tematów!';
$txt['bookmark_add_failed'] = 'Błąd! Wątek nie został dodany do listy śledzonych tematów.';
$txt['permissionname_make_bookmarks'] = 'Użytkownik może używać funkcji "Śledź temat';
$txt['cannot_make_bookmarks'] = 'Przepraszamy! Nie możesz korzystać z funkcji śledzenia tematów.';

2. Polish UTF-8

Quote$txt['bookmarks'] = 'Lista &#347;ledzonych temat&#243;w';
$txt['bookmark_list'] = '&#346;ledzone tematy';
$txt['bookmark_list_empty'] = 'Nie obserwujesz obecnie &#324;adnych w&#261;tk&#243;w. Dodaj temat, klikaj&#261;c w przycisk \'&#346;led&#378; temat\' w przegl&#261;dzie w&#261;tku.';
$txt['bookmark_open_window'] = 'Otw&#243;rz w nowym oknie';
$txt['bookmark_delete'] = 'Usu&#324; obserwacj&#281; wybranych w&#261;tk&#243;w';
$txt['bookmark_delete_success'] = '%1$s &#347;ledze&#324; zosta&#322;o usuni&#281;tych!';
$txt['bookmark_delete_failure'] = 'Niekt&#243;re tematy nie zosta&#322;y usuni&#281;te z listy &#347;ledzonych w&#261;tk&#243;w.';
$txt['bookmark_add'] = '&#346;led&#378; temat';
$txt['bookmark_add_success'] = 'Wybrany w&#261;tek zosta&#322; pomy&#347;lnie dodany do listy &#347;ledzonych przez Ciebie temat&#243;w';
$txt['bookmark_add_exists'] = 'Ten w&#261;tek ju&#324; znajduje si&#281; na li&#347;cie Twoich &#347;ledzonych temat&#243;w!';
$txt['bookmark_add_failed'] = 'B&#322;&#261;d! W&#261;tek nie zosta&#322; dodany do listy &#347;ledzonych temat&#243;w.';
$txt['permissionname_make_bookmarks'] = 'U&#324;ytkownik mo&#324;e u&#324;ywa&#263; funkcji "&#346;led&#378; temat';
$txt['cannot_make_bookmarks'] = 'Przepraszamy! Nie mo&#324;esz korzysta&#263; z funkcji &#347;ledzenia temat&#243;w.';

Best luck, Pete.
Title: Re: Bookmarks
Post by: Jolene on February 03, 2009, 10:03:58 AM
Please forgive me if this is a repeat question.  I have scanned the posts here and I gather that the package install for SMF (using v 1.1.7) isn't working for this mod.  That's the experience I had and I came over here to see what was up.  Many posts have said for now we just need to install the mod manually.

Doing this requires editing many php files, it seems.  I'm not quite up to this yet, and am taking baby steps at learning this whole admin business.  I am concerned that if I mess with my code too much I'll genuinely mess something up (yes, I run weekly backups just in case).

So my question is this:  Do we anticipate that there will be a package friendly version of this mod out in the somewhat near future?  Or should I get help with it/wait until I am more confident with mod stuff?

Thank you!

Jo
Title: Re: Bookmarks
Post by: floydpink on February 04, 2009, 12:07:10 AM
I used the install package and it worked fine for 1.1.7.
Give it a go. When you Apply the Mod in SMF it runs a test first and tells you if any of the updates fail.
Only if they do will you need at the manual instructions for that particular php file to complete the install.
The instructions are quite easy to follow. BUT make sure you backup each file before you edit it so that if you make a mistake you can easily revert to the orginal one.
Instructions are on the mod's home page http://custom.simplemachines.org/mods/index.php?mod=864 top right hand corner under the download - select 1.1.7 from the dropdown and Submit.
Title: Re: Bookmarks
Post by: Jolene on February 04, 2009, 01:08:28 PM
Quote from: floydpink on February 04, 2009, 12:07:10 AM
I used the install package and it worked fine for 1.1.7.
Give it a go. When you Apply the Mod in SMF it runs a test first and tells you if any of the updates fail.
Only if they do will you need at the manual instructions for that particular php file to complete the install.
The instructions are quite easy to follow. BUT make sure you backup each file before you edit it so that if you make a mistake you can easily revert to the orginal one.
Instructions are on the mod's home page http://custom.simplemachines.org/mods/index.php?mod=864 top right hand corner under the download - select 1.1.7 from the dropdown and Submit.

Right.  I did install it as a package before.  It said it was successful.  But then the "bookmark" button didn't show up at all.  It was when I was looking for information on this problem that I found a few threads talking about difficulties with some package installs.
Title: Re: Bookmarks
Post by: Jolene on February 04, 2009, 01:18:57 PM
Here...I installed again so I could show you what I mean.  See how you can see where the bookmark tab would be...but it's not there?

(http://farm4.static.flickr.com/3357/3253878686_9ce0151806_o.jpg)
Title: Re: Bookmarks
Post by: Jolene on February 04, 2009, 02:53:15 PM
argh! 

So I just uninstalled the package and forced myself to install it manually.  It was scary...but I'm pretty sure I did everything correctly.  And it looks just the same as before.  I can see where it goes...but it's not there. 

Any suggestions?
Title: Re: Bookmarks
Post by: Jolene on February 05, 2009, 10:42:55 AM
Wait...I forgot to run that query at the bottom.....


Ok....new question.

Does anyone know what this means? If you try to run a query on your smf database?

Thank you for witnessing my confusion...and offering helpful advice.   :)

MySQL said: Documentation
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{$db_prefix}bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC' at line 1
Title: Re: Bookmarks
Post by: FireFreezer on February 09, 2009, 07:32:41 AM
update of my german translation + adding utf8 version:

Quote from: Modifications.german.php
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzufügen\' in den Themen erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster öffnen';
$txt['bookmark_delete'] = 'Lesezeichen löschen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gelöscht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gelöscht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzufügen';
$txt['bookmark_add_success'] = 'Thread erfolgreich Deinen Lesezeichen hinzugefügt!';
$txt['bookmark_add_exists'] = 'Dieses Thema befindet sich bereits in Deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim hinzufügen des Themas zu Deinen Lesezeichen aufgetreten!';
$txt['permissionname_make_bookmarks'] = 'Lesezeichen für Themen anlegen';
$txt['cannot_make_bookmarks'] = 'Sorry, Du darfst keine Lesezeichen anlegen!';

Quote from: Modifications.german-utf8.php
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzuf&#252;gen\' in den Themen erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster &#246;ffnen';
$txt['bookmark_delete'] = 'Lesezeichen l&#246;schen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gel&#246;scht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gel&#246;scht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzuf&#252;gen';
$txt['bookmark_add_success'] = 'Thread erfolgreich Deinen Lesezeichen hinzugef&#252;gt!';
$txt['bookmark_add_exists'] = 'Dieses Thema befindet sich bereits in Deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim hinzuf&#252;gen des Themas zu Deinen Lesezeichen aufgetreten!';
$txt['permissionname_make_bookmarks'] = 'Lesezeichen f&#252;r Themen anlegen';
$txt['cannot_make_bookmarks'] = 'Sorry, Du darfst keine Lesezeichen anlegen!';
Title: Re: Bookmarks
Post by: floydpink on February 10, 2009, 02:52:39 AM
If you don't want to always see the 'Bookmark added/deleted successfully' message (I find that it doesn't really fit in with the approach taken in other pages and its obvious from the list if it was successful or not) it's easy to delete:
Bookmarks.template.php
Find and delete if (!empty($return))
{
echo '
<table align="center" cellpadding="15" cellspacing="0" class="tborder">
<tr>
<td class="windowbg">', $return, '</td>
</tr>
</table>
<br />';
}



Jolene: You need to replace ''{$db_prefix}' with the actual 'Database Tables Prefix'  that your database is using  (look in Admin - Server Settings). You'd have found it much easier if you'd installed the mod first and then made edits to fix any issues rather than doing everything by hand.
Title: Re: Bookmarks
Post by: SurrealKilla on February 11, 2009, 06:15:58 AM
Been trying to install thi sfor a few months. I have to do it manually, first prob i had was sorting the db. now i have another prob! There is nowhere on my index template where i can add the manual changes? I have a heavily modified theme so whether this has anything to do with i dont but im trying to add,

this

(http://i534.photobucket.com/albums/ee350/surrealkiller_photos/indextemplate.jpg)

to this, (index template)
Quoteindex.template.php
File Type: PHP script text

<?php

// Version: 1.1; index



/* This template is, perhaps, the most important template in the theme. It

contains the main template layer that displays the header and footer of

the forum, namely with main_above and main_below. It also contains the

menu sub template, which appropriately displays the menu; the init sub

template, which is there to set the theme up; (init can be missing.) and

the linktree sub template, which sorts out the link tree.



The init sub template should load any data and set any hardcoded options.



The main_above sub template is what is shown above the main content, and

should contain anything that should be shown up there.



The main_below sub template, conversely, is shown after the main content.

It should probably contain the copyright statement and some other things.



The linktree sub template should display the link tree, using the data

in the $context['linktree'] variable.



The menu sub template should display all the relevant buttons the user

wants and or needs.



For more information on the templating system, please see the site at:

http://www.simplemachines.org/

*/



// Initialize the template... mainly little settings.

function template_init()

{

global $context$settings$options$txt;



/* Use images from default theme when using templates from the default theme?

if this is 'always', images from the default theme will be used.

if this is 'defaults', images from the default theme will only be used with default templates.

if this is 'never' or isn't set at all, images from the default theme will not be used. */

$settings['use_default_images'] = 'never';



/* What document type definition is being used? (for font size and other issues.)

'xhtml' for an XHTML 1.0 document type definition.

'html' for an HTML 4.01 document type definition. */

$settings['doctype'] = 'xhtml';



/* The version this template/theme is for.

This should probably be the version of SMF it was created for. */

$settings['theme_version'] = '1.1.4';



/* Set a setting that tells the theme that it can render the tabs. */

$settings['use_tabs'] = true;



/* Use plain buttons - as oppossed to text buttons? */

$settings['use_buttons'] = true;



/* Show sticky and lock status seperate from topic icons? */

$settings['seperate_sticky_lock'] = true;

}



// The main sub template above the content.

function template_main_above()

{

global $context$settings$options$scripturl$txt$modSettings;



// Show right to left and the character set for ease of translating.

echo '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"'
$context['right_to_left'] ? ' dir="rtl"' '''><head>

<meta http-equiv="Content-Type" content="text/html; charset='
$context['character_set'], '" />

<meta name="description" content="'
$context['page_title'], '" />', empty($context['robot_no_index']) ? '' '

<meta name="robots" content="noindex" />'
'

<meta name="keywords" content="PHP, MySQL, bulletin, board, free, open, source, smf, simple, machines, forum" />

<script language="JavaScript" type="text/javascript" src="'
$settings['default_theme_url'], '/script.js?fin11"></script>

<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[

var smf_theme_url = "'
$settings['theme_url'], '";

var smf_images_url = "'
$settings['images_url'], '";

var smf_scripturl = "'
$scripturl'";

var smf_iso_case_folding = '
$context['server']['iso_case_folding'] ? 'true' 'false'';

var smf_charset = "'
$context['character_set'], '";

// ]]></script>

<title>'
$context['page_title'], '</title>';



// The ?fin11 part of this link is just here to make sure browsers don't cache it wrongly.

echo '

<link rel="stylesheet" type="text/css" href="'
$settings['theme_url'], '/style.css?fin11" />

<link rel="stylesheet" type="text/css" href="'
$settings['default_theme_url'], '/print.css?fin11" media="print" />';



/* Internet Explorer 4/5 and Opera 6 just don't do font sizes properly. (they are big...)

Thus, in Internet Explorer 4, 5, and Opera 6 this will show fonts one size smaller than usual.

Note that this is affected by whether IE 6 is in standards compliance mode.. if not, it will also be big.

Standards compliance mode happens when you use xhtml... */

if ($context['browser']['needs_size_fix'])

echo '

<link rel="stylesheet" type="text/css" href="'
$settings['default_theme_url'], '/fonts-compat.css" />';



// Show all the relative links, such as help, search, contents, and the like.

echo '

<link rel="help" href="'
$scripturl'?action=help" target="_blank" />

<link rel="search" href="' 
$scripturl '?action=search" />

<link rel="contents" href="'
$scripturl'" />';



// If RSS feeds are enabled, advertise the presence of one.

if (!empty($modSettings['xmlnews_enable']))

echo '

<link rel="alternate" type="application/rss+xml" title="'
$context['forum_name'], ' - RSS" href="'$scripturl'?type=rss;action=.xml" />';



// If we're viewing a topic, these should be the previous and next topics, respectively.

if (!empty($context['current_topic']))

echo '

<link rel="prev" href="'
$scripturl'?topic='$context['current_topic'], '.0;prev_next=prev" />

<link rel="next" href="'
$scripturl'?topic='$context['current_topic'], '.0;prev_next=next" />';



// If we're in a board, or a topic for that matter, the index will be the board's index.

if (!empty($context['current_board']))

echo '

<link rel="index" href="' 
$scripturl '?board=' $context['current_board'] . '.0" />';

// YSHOUT HERE - <head> code
global $boardurl,$shoutFile;
$shoutFile='home';
$scripturlparsed parse_url($scripturl);
$scriptpath=isset($scripturlparsed['path'])?$scripturlparsed['path']:'/';
$args='';
foreach($_GET as $key => $value// passthrough $_GET
$args.='&'.urlencode($key).'='.urlencode($value);
echo '
<script src="'
,$boardurl,'/yshout/js/moo.ajax.js" type="text/javascript"></script>
<script src="'
,$boardurl,'/yshout/settings.js" type="text/javascript"></script>
<script type="text/javascript"><!-- // --><![CDATA[
window.onload=function(){loadChat();};
var shoutFile="'
,$shoutFile,'";
var yshout_php="'
,$scriptpath,'?yshout',$args,'";
// ]]></script>
<script src="'
,$boardurl,'/yshout/js/yshout.js?July062008" type="text/javascript"></script>
<style type="text/css">
#yshout {
font-size: 10px;
overflow: hidden;
color: white;
}
#yshout #yshout-toollinks { /* tool links (History, Commands, etc.) */
}
#yshout #shouts { /* main shouts area */
}
#yshout .shout { /* one shout */
margin: 0 0 0; /* Top Bottom Linespacing */
line-height: 1;
}
#yshout .shout-timestamp {
font-style: normal;
font-weight: normal;
}
#yshout .shout-adminlinks { /* del and ban buttons */
font-size: 6pt;
color: #141414;
}
#yshout #shout-form {
margin: 0;
padding: 0;
}
#yshout #shout-form fieldset {
border: none;
}
#yshout #forum-name {
width: 70px;
margin-right: 5px;
}
#yshout #shout-text {
width: 310px;
margin-right: 5px;
}
#yshout #shout-button {
width: 55px;
}
#yshout .shout-invalid { /* invalid shout (shout textbox) */
background: #FFFDD1;
}
</style>'
;
// YSHOUT END - <head> code

// We'll have to use the cookie to remember the header...

if ($context['user']['is_guest'])

$options['collapse_header'] = !empty($_COOKIE['upshrink']);



// Output any remaining HTML headers. (from mods, maybe?)

echo $context['html_headers'], '

<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[

var current_header = '
, empty($options['collapse_header']) ? 'false' 'true'';



function shrinkHeader(mode)

{'
;



// Guests don't have theme options!!

if ($context['user']['is_guest'])

echo '

document.cookie = "upshrink=" + (mode ? 1 : 0);'
;

else

echo '

smf_setThemeOption("collapse_header", mode ? 1 : 0, null, "'
$context['session_id'], '");';



echo '

document.getElementById("upshrink").src = smf_images_url + (mode ? "/upshrink2.gif" : "/upshrink.gif");



document.getElementById("upshrinkHeader").style.display = mode ? "none" : "";

document.getElementById("upshrinkHeader2").style.display = mode ? "none" : "";



current_header = mode;

}

// ]]></script>'
;



// the routine for the info center upshrink

echo '

<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[

var current_header_ic = '
, empty($options['collapse_header_ic']) ? 'false' 'true'';



function shrinkHeaderIC(mode)

{'
;



if ($context['user']['is_guest'])

echo '

document.cookie = "upshrinkIC=" + (mode ? 1 : 0);'
;

else

echo '

smf_setThemeOption("collapse_header_ic", mode ? 1 : 0, null, "'
$context['session_id'], '");';



echo '

document.getElementById("upshrink_ic").src = smf_images_url + (mode ? "/expand.gif" : "/collapse.gif");



document.getElementById("upshrinkHeaderIC").style.display = mode ? "none" : "";



current_header_ic = mode;

}

// ]]></script>'
;

echo 
'
<script type="text/javascript">

<!--
function MM_findObj(n, d) { //v4.01
  var p,i,x;  if(!d) d=document; if((p=n.indexOf("?"))>0&&parent.frames.length) {
 d=parent.frames[n.substring(p+1)].document; n=n.substring(0,p);}
  if(!(x=d[n])&&d.all) x=d.all[n]; for (i=0;!x&&i<d.forms.length;i++) x=d.forms[i][n];
  for(i=0;!x&&d.layers&&i<d.layers.length;i++) x=MM_findObj(n,d.layers[i].document);
  if(!x && d.getElementById) x=d.getElementById(n); return x;

}
function MM_preloadImages() { //v3.0
  var d=document; if(d.images){ if(!d.MM_p) d.MM_p=new Array();
 var i,j=d.MM_p.length,a=MM_preloadImages.arguments; for(i=0; i<a.length; i++)
 if (a[i].indexOf("#")!=0){ d.MM_p[j]=new Image; d.MM_p[j++].src=a[i];}}

}
function MM_swapImgRestore() { //v3.0
  var i,x,a=document.MM_sr; for(i=0;a&&i<a.length&&(x=a[i])&&x.oSrc;i++) x.src=x.oSrc;

}
function MM_swapImage() { //v3.0
  var i,j=0,x,a=MM_swapImage.arguments; document.MM_sr=new Array; for(i=0;i<(a.length-2);i+=3)
if ((x=MM_findObj(a[i]))!=null){document.MM_sr[j++]=x; if(!x.oSrc) x.oSrc=x.src; x.src=a[i+2];}
}
//-->
</script>
<script src="'
$settings['theme_url'], '/AC_RunActiveContent.js" type="text/javascript"></script>
</head>

 <body>

  <div id="wrapper">

<div style="position:relative;left:-8px;"><img src="'
,$settings['images_url'],'/headBanner.png" alt="The Poker Pod - TPP" /></div>
'
,template_menu(),'  <br />
<div align="right">'
;
if($context['user']['is_logged'])
echo ' <span class="middletext" style="color:White">'
$context['allow_pm'] ? '<b>' $txt[152] . ' <a href="' $scripturl '?action=pm">' $context['user']['messages'] . ' ' . ($context['user']['messages'] != $txt[153] : $txt[471]) . '</a>' $txt['newmessages4'] . ' ' $context['user']['unread_messages'] . ' ' . ($context['user']['unread_messages'] == $txt['newmessages0'] : $txt['newmessages1']).'</b>' '<br/>''.
</span>'
;
echo '
</div>


  <div id="mainarea">

<div id="sag">

 <div id="sol">

  <div id="alt">

<div id="altsag">

 <div id="altsol">

  <div id="ust">

<div id="ustsag">

 <div id="ustsol">'
;

}

function 
template_main_below()

{

global $context$settings$options$scripturl$txt;



  echo '

</div>

  </div>

 </div>

</div>

  </div>

 </div>

</div>

  </div>

 </div>'
;



// Show the "Powered by" and "Valid" logos, as well as the copyright. Remember, the copyright must be somewhere!

echo '

  <div id="footer">

  <div id="footer-l">

<div id="footer-r">

<div id="footerarea">

<span class="smalltext">'
theme_copyright(), '<br /><font color="#454545">Theme </font><font color="#6E0101"><b>Dark4 By</b></font> <a href="http://www.fussilet.com" target="_blank">Fussilet</a></span>';



// Show the load time?

if ($context['show_load_time'])

echo '

<p align="center"><span class="smalltext">'
$txt['smf301'], $context['load_time'], $txt['smf302'], $context['load_queries'], $txt['smf302b'], '</span></p>';



// This is an interesting bug in Internet Explorer AND Safari. Rather annoying, it makes overflows just not tall enough.

if (($context['browser']['is_ie'] && !$context['browser']['is_ie4']) || $context['browser']['is_mac_ie'] || $context['browser']['is_safari'] || $context['browser']['is_firefox'])

{

// The purpose of this code is to fix the height of overflow: auto div blocks, because IE can't figure it out for itself.

echo '

<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA['
;



// Unfortunately, Safari does not have a "getComputedStyle" implementation yet, so we have to just do it to code...

if ($context['browser']['is_safari'])

echo '

window.addEventListener("load", smf_codeFix, false);



function smf_codeFix()

{

var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");



for (var i = 0; i < codeFix.length; i++)

{

if ((codeFix[i].className == "code" || codeFix[i].className == "post" || codeFix[i].className == "signature") && codeFix[i].offsetHeight < 20)

codeFix[i].style.height = (codeFix[i].offsetHeight + 20) + "px";

}

}'
;

elseif ($context['browser']['is_firefox'])

echo '

window.addEventListener("load", smf_codeFix, false);

function smf_codeFix()

{

var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");



for (var i = 0; i < codeFix.length; i++)

{

if (codeFix[i].className == "code" && (codeFix[i].scrollWidth > codeFix[i].clientWidth || codeFix[i].clientWidth == 0))

codeFix[i].style.overflow = "scroll";

}

}'
;

else

echo '

var window_oldOnload = window.onload;

window.onload = smf_codeFix;



function smf_codeFix()

{

var codeFix = document.getElementsByTagName ? document.getElementsByTagName("div") : document.all.tags("div");



for (var i = codeFix.length - 1; i > 0; i--)

{

if (codeFix[i].currentStyle.overflow == "auto" && (codeFix[i].currentStyle.height == "" || codeFix[i].currentStyle.height == "auto") && (codeFix[i].scrollWidth > codeFix[i].clientWidth || codeFix[i].clientWidth == 0) && (codeFix[i].offsetHeight != 0 || codeFix[i].className == "code"))

codeFix[i].style.height = (codeFix[i].offsetHeight + 36) + "px";

}



if (window_oldOnload)

{

window_oldOnload();

window_oldOnload = null;

}

}'
;



echo '

// ]]></script>'
;

}



echo '

</div>

  </div>

 </div>

</div>'
;



// The following will be used to let the user know that some AJAX process is running

echo '

<div id="ajax_in_progress" style="display: none;'
$context['browser']['is_ie'] && !$context['browser']['is_ie7'] ? 'position: absolute;' '''">'$txt['ajax_in_progress'], '</div>';

echo 
'

 </body>

</html>'
;

}



// Show a linktree. This is that thing that shows "My Community | General Category | General Discussion"..

function theme_linktree()

{

global $context$settings$options;



echo '<div class="nav" style="font-size: smaller; margin-bottom: 2ex; margin-top: 0ex; padding-bottom: 0ex; padding-left: 2ex;">';



// Each tree item has a URL and name. Some may have extra_before and extra_after.

foreach ($context['linktree'] as $link_num => $tree)

{

// Show something before the link?

if (isset($tree['extra_before']))

echo $tree['extra_before'];



// Show the link, including a URL if it should have one.

echo '<b>'$settings['linktree_link'] && isset($tree['url']) ? '<a href="' $tree['url'] . '" class="nav">' $tree['name'] . '</a>' $tree['name'], '</b>';



// Show something after the link...?

if (isset($tree['extra_after']))

echo $tree['extra_after'];



// Don't show a separator for the last one.

if ($link_num != count($context['linktree']) - 1)

echo '&nbsp;|&nbsp;';

}



echo '</div>';

}



// Show the menu up top. Something like [home] [help] [profile] [logout]...

function template_menu()

{

global $context$settings$options$scripturl$txt;



?>

<table align="center" id="newmenu" cellspacing="0" cellpadding="0" border="0">
<tr>
<td valign="top">
<img src="Themes/dark_4/images/english/firsttab.png" width="28" height="43" border="0" />
</td>
<td>
<a href="http://thepokerpod.com/podforum/index.php" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('pokerpod','','Themes/dark_4/images/english/pokerpodRO.png',1)">
<img src="Themes/dark_4/images/english/pokerpod.png" name="pokerpod" width="98" height="43" border="0" />
</a>
</td>
<td>
<a href="index.php?action=forum" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('index','','Themes/dark_4/images/english/indexRO.png',1)">
<img src="Themes/dark_4/images/english/index.png" name="index" width="101" height="43" border="0" />
</a>
</td>
<?
if(!$context['user']['is_guest'])
{
?>
<td>
<a href="index.php?action=profile" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('profile','','Themes/dark_4/images/english/profileRO.png',1)">
<img src="Themes/dark_4/images/english/profile.png" name="profile" width="100" height="43" border="0" />
</a>
</td>
<td>
<a href="index.php?action=calendar" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('calendar','','Themes/dark_4/images/english/calendarRO.png',1)">
<img src="Themes/dark_4/images/english/calendar.png" name="calendar" width="99" height="43" border="0" />
</a>
</td>
<td>
<a href="http://thepokerpod.com/podforum/index.php?action=gallery" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('gallery','','Themes/dark_4/images/english/galleryRO.png',1)">
<img src="Themes/dark_4/images/english/gallery.png" name="gallery" width="102" height="43" border="0" />
</a>
</td>
<td>
<a onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('chat','','Themes/dark_4/images/english/chatRO.png',1)" target="_self" href="http://www.thepokerpod.com/podforum/index.php?page=64">
<img src="Themes/dark_4/images/english/chat.png" name="chat" width="98" height="43" border="0" /></a><a href="http://www.thepokerpod.com/podforum/index.php?page=64"  onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('chat','','Themes/dark_4/images/english/chatRO.png',1)">
</a>
</td>
<td>
<a href="http://www.thepokerpod.com/podforum/index.php?action=gallery;cat=19" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('videos','','Themes/dark_4/images/english/videosRO.png',1)">
<img src="Themes/dark_4/images/english/videos.png" name="videos" width="100" height="43" border="0" />
</a>
</td>
<td>
<a href="index.php?action=mlist" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('members','','Themes/dark_4/images/english/membersRO.png',1)">
<img src="Themes/dark_4/images/english/members.png" name="members" width="103" height="43" border="0" />
</a>
</td>
<?
echo '
<td>
<a href="index.php?action=logout;sesc=', $context['session_id'], '"'; ?> onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('logout','','Themes/dark_4/images/english/logoutRO.png',1)">
<img src="Themes/dark_4/images/english/logout.png" name="logout" width="98" height="43" border="0" />
</a>
</td>
<?
}
if($context['user']['is_guest'])
{
?>
<td>
<a href="index.php?action=login" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('login','','Themes/dark_4/images/english/loginRO.png',1)">
<img src="Themes/dark_4/images/english/login.png" name="login" width="101" height="43" border="0" />
</a>
</td>
<td>
<a href="index.php?action=register" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('register','','Themes/dark_4/images/english/registerRO.png',1)">
<img src="Themes/dark_4/images/english/register.png" name="register" width="101" height="43" border="0" />
</a>
</td>
<td>
<a href="mailto:info@thepokerpod.com" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('contact','','Themes/dark_4/images/english/contactRO.png',1)">
<img src="Themes/dark_4/images/english/contact.png" name="contact" width="100" height="43" border="0" />
</a>
</td>
<?
}
?>
<td>
<a href="index.php?action=help" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('help','','Themes/dark_4/images/english/helpRO.png',1)">
<img src="Themes/dark_4/images/english/help.png" name="help" width="99" height="43" border="0" />
</a>
</td>
<?
if($context['allow_admin'])
{
?>
<td>
<a href="index.php?action=admin" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('admin','','Themes/dark_4/images/english/adminRO.png',1)">
<img src="Themes/dark_4/images/english/admin.png" name="admin" width="101" height="43" border="0" />
</a>
</td>
<?
}
?>
<!--<td>
<a href="index.php?action=pm" onmouseout="MM_swapImgRestore()" onmouseover="MM_swapImage('messages','','Themes/dark_4/images/english/messagesRO.png',1)">
<img src="Themes/dark_4/images/english/messages.png" name="messages" width="116" height="43" border="0" />
</a>
</td>-->

<td valign="top">
<img src="Themes/dark_4/images/english/lasttab.png" width="44" height="43" border="0" />
</td>
</tr>
</table>


<?

}

// Generate a strip of buttons.

function template_button_strip($button_strip, $direction = 'top', $force_reset = false, $custom_td = '')

{

global $settings, $buttons, $context, $txt, $scripturl;



// Create the buttons...

foreach ($button_strip as $key => $value)

{

if (isset($value['test']) && empty($context[$value['test']]))

{

unset($button_strip[$key]);

continue;

}

elseif (!isset($buttons[$key]) || $force_reset)

$buttons[$key] = '<a href="' . $value['url'] . '" ' .( isset($value['custom']) ? $value['custom'] : '') . '>' . $txt[$value['text']] . '</a>';



$button_strip[$key] = $buttons[$key];

}



if (empty($button_strip))

return '<td> </td>';



echo '

<td class="', $direction == 'top' ? 'main' : 'mirror', 'tab_' , $context['right_to_left'] ? 'last' : 'first' , '"> </td>

<td class="', $direction == 'top' ? 'main' : 'mirror', 'tab_back">', implode('  |  ', $button_strip) , '</td>

<td class="', $direction == 'top' ? 'main' : 'mirror', 'tab_' , $context['right_to_left'] ? 'first' : 'last' , '"> </td>';

}



?>

[/quote]


Its a custom template not the default, and im using 1.17 (not upgraded to 8 yet)


thx for any help or guidance ;)
Title: Re: Bookmarks
Post by: Jolene on February 19, 2009, 10:06:13 AM
QuoteJolene: You need to replace ''{$db_prefix}' with the actual 'Database Tables Prefix'  that your database is using  (look in Admin - Server Settings). You'd have found it much easier if you'd installed the mod first and then made edits to fix any issues rather than doing everything by hand.

Thanks!  With your advice, I successfully ran that query...although I don't see any changes...there is still no bookmarking option on my site.  As for installing in first...I did!  I only manually installed it because I couldn't get the automatic one to work for me.  And judging from the physical appearance of the site, there is no difference between the two installs. 

As for what to do next....perhaps there is still a step I'm missing?

Title: Re: Bookmarks
Post by: kat on February 20, 2009, 04:02:41 PM
Imjust cleared Jo's site. It's a virgin install, now, file-wise.

We installed the mod, which went as it should (So it said), yet still, there're no buttons, at all.

I checked the files, manually. They seem to be as they ought to be. Except the line that should be showing in index.php is showing THREE times...

"Confused" ain't the word for it!
Title: Re: Bookmarks
Post by: busterone on February 20, 2009, 04:52:48 PM
Odd install of PHP on the server perhaps?
Title: Re: Bookmarks
Post by: kat on February 20, 2009, 04:54:41 PM
Could be. How would we find that out, busterone?
Title: Re: Bookmarks
Post by: busterone on February 20, 2009, 05:14:20 PM
That totally depends on the host. They all are pretty standardized, but sometimes, especially with free and cheap hosts, they cut corners on resources by not installing everything needed in Apache to support a site, or PHP itself. Still, it depends on each host and how much access to the server they allow or will reveal to you.
Title: Re: Bookmarks
Post by: kat on February 20, 2009, 05:20:36 PM
I'll ask Jo to ask her host.

Cheers, Buster!
Title: Re: Bookmarks
Post by: Jolene on February 23, 2009, 02:10:48 PM
Thanks guys.  I will ask my host about this.  I'm hoping they'll be able to help me out.  I did pay a bit more for this site because review sites told me they have excellent customer service that you can contact 24/7.  Although last time I asked them about help with an SQL error I was getting they told me it was an SMF issue.  I still don't think it is...I still get the error occasionally but it doesn't seem to be interfering with anything.  So I'll try them on this issue and see how it goes.
Title: Re: Bookmarks
Post by: AlenNS on February 23, 2009, 02:28:41 PM
Can I use this mod on RC1 without any errors?
Title: Re: Bookmarks
Post by: willerby on February 23, 2009, 05:54:11 PM
Worked straight out of the box for me on RC1 on default and Shadow People theme
Title: Re: Bookmarks
Post by: TomW on February 24, 2009, 08:15:04 AM
This is a great mod !  I had to modify index.template.php and display.template.php because I am using corp-lt116 theme, and it works beautifully !
Title: Re: Bookmarks
Post by: silber112 on March 02, 2009, 07:51:29 PM
Is there any way to put in the staticks the most added posts to bookmarks?¿
Title: Re: Bookmarks
Post by: AlenNS on March 02, 2009, 07:54:51 PM
Quote from: AlenNS on February 23, 2009, 02:28:41 PM
Can I use this mod on RC1 without any errors?
bump
Title: Re: Bookmarks
Post by: vristang on March 09, 2009, 11:32:15 PM
I'd like to hear from anyone using the Babylon theme and has been able to make this mod work.
I ran the installation from the Admin section of my Board, then went through the instructions to make sure my template files were modified correctly.

Here are my problems.

The instructions indicate...
./Themes/default/index.template.php
Since I'm using the babylon template, so I go to....
./ Themes / babylon / index.template.php
and find
if (in_array($context['current_action'], array('search',

However, this section of code in the babylon theme does not appear to exist in my babylon index.template.php file.

Am I accessing the wrong file?


Also,
The instructions indicate file...
./Themes/default/Display.template.php

Since I'm using babylon, I access the following...
./Themes/babylon/Display.template.php

But the code in the instructions is not listed.

'reply' => array('test' => 'can_reply', 'text' => 146, 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies']),


Instead of the above code, I find array button code that looks like this....
$buttonArray = array();
if ($context['can_reply'])
$buttonArray[] = '<a href="' . $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/reply.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';

If I need to modify this code, then I have no idea how to do that.
Could someone help me out?


Also from the instructions....
At the end of the instructions, it says to move 2 files beginning with 'smf11' to specific folder locations.
Where do I find these 2 files?  They don't seem to be in the zipped file that I downloaded.


I didn't have any trouble pasting the code into the language file
./Themes/default/languages/Modifications.english.php


I'm sure you guys can tell I am new to this stuff  ;)
I greatly appreciate any help.  I think my members will really appreciate this mod.
Thanks,
jason
Title: Re: Bookmarks
Post by: AlenNS on March 11, 2009, 09:57:29 PM
Any update for RC1?
Title: Re: Bookmarks
Post by: TomW on March 11, 2009, 11:41:21 PM
vristang, I am using corp-lt, which had a similar problem.  Here is the code that I used; hopefully this helps you:
function theme_show_normal_buttons() {
  global $context, $settings, $options, $txt, $scripturl, $modSettings;
 
  $buttonArray = array();
if ($context['can_reply'])
$buttonArray[] = '<a href="' . $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/reply.gif" alt="' . $txt[146] . '" border="0" />' : $txt[146]) . '</a>';

// bookmarks add
        if ($context['can_make_bookmarks'])
$buttonArray[] = '<a href="' . $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . '">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmark.gif" alt="' . $txt['bookmark_add'] . '" border="0" />' : $txt['bookmark_add']) . '</a>';
// end bookmarks

if ($context['can_mark_notify'])
$buttonArray[] = '<a href="' . $scripturl . '?action=notify;sa=' . ($context['is_marked_notify'] ? 'off' : 'on') . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';sesc=' . $context['session_id'] . '" onclick="return confirm(\'' . ($context['is_marked_notify'] ? $txt['notification_disable_topic'] : $txt['notification_enable_topic']) . '\');">' . ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/notify.gif" alt="' . $txt[131] . '" border="0" />' : $txt[131]) . '</a>';

You will need to find a bookmark.gif, or create your own, if you are using buttons.  I am attaching the one that was created for me plus my display.template.php.  Note that I have other mods which I install manually - and add comments.  So, the bookmark changes should be easy for you to find.
Title: Re: Bookmarks
Post by: vristang on March 13, 2009, 01:03:16 AM
Tom,
That worked great in my Display.Template.php...
I now have a button in the threads to add a bookmark.

Still struggling with the Index.Template.php changes though...

Instead of displaying the bookmarks.gif button that I am using, I only get the text 'My Bookmarks'.
Here is the code I am using... which came from the instructions for this mod...

  // The [bookmarks] button
   if (allowedTo('make_bookmarks'))
      echo ($current_action == 'bookmarks' || $context['browser']['is_ie4']) ? '<td class="maintab_active_' . $first . '">&nbsp;</td>' : '' , '
            <td valign="top" class="maintab_' , $current_action == 'bookmarks' ? 'active_back' : 'back' , '">
               <a href="', $scripturl, '?action=bookmarks">' , $txt['bookmarks'], '</a>
            </td>' , $current_action == 'bookmarks' ? '<td class="maintab_active_' . $last . '">&nbsp;</td>' : '';

I think I see where the text is specified, but I haven't been able to change this to display the gif instead of the text.


Functionally, everything else seems to work perfectly.

Thanks for the help,
jason
Title: Re: Bookmarks
Post by: vristang on March 13, 2009, 01:38:09 AM
I added the following code into the Index.template.php
   // Edit Bookmark... [bookmark]
   if (allowedTo('make_bookmarks'))
      echo '
            <a href="', $scripturl, '?action=bookmarks">', ($settings['use_image_buttons'] ? '<img src="' . $settings['images_url'] . '/' . $context['user']['language'] . '/bookmarks.gif" alt="' . $txt[79] . '" style="margin: 2px 0;" border="0" />' : $txt[467]), '</a>', $context['menu_separator'];


The button now shows, and every thing works properly.


I'm sure the above code could be cleaned up, as I copied most of it from the profile button code in the index.template file.

It does work though  :D



EDIT:
I also had to add the code for Display.template file a second time, for the row of buttons that show at the bottom of the thread.
Title: Re: Bookmarks
Post by: michelangelo on March 13, 2009, 05:37:38 PM
Please put the fix in a new version and add 1.1.8 support.
Title: Re: Bookmarks
Post by: vristang on March 13, 2009, 07:29:36 PM
Quote from: michelangelo on March 13, 2009, 05:37:38 PM
Please put the fix in a new version and add 1.1.8 support.
I don't know about adding the fix for the babylon template, but I am using 1.1.8  :P



Since I am using the standard Babylon buttons, I had to resize the button Bookmark button provided earlier in this thread.
The attachments are as follows
1. Provided Bookmark, which had extra width on the right of the image that made the spacing look uneven.
2. This button has been shortened to the appropriate width, to match the rest of the buttons that show at the top and bottom of the threads.
3. This button has been shortened as well, but has also been reduced in height to match the size of the buttons in the main array, below the 'User Info' section at the top of the page.



(I still haven't loaded these to my site, but should get to it later tonight)
Title: Re: Bookmarks
Post by: busterone on March 13, 2009, 10:58:42 PM
This mod works perfectly in 1.1.8
I have it installed on 12 user selectable themes with no problems at all.
Title: Re: Bookmarks
Post by: vristang on March 22, 2009, 12:43:12 AM
Just FYI for others using the Babylon Theme...

As I stated previously, there are 2 image sizes for the buttons: thread button is 18pixel tall, and the main button is 16pixel tall

Resizing the image in this thread (with the red admin star), left the text of the image pixelated.  It looked bad on the board.

I created a new image here...
http://www.marcovanveelen.nl/buttongenerator/
Which created the button in the 16pixel size.
I then copied the image/icon/logo from this button to an 18pixel image in photoshop (actually I had a family member help with this...)
Resizing the icon didn't seem to affect the icon quality.

Attached are the 2 images I am now using, which match the rest of my board perfectly...
Title: Re: Bookmarks
Post by: Rumboogy on April 21, 2009, 09:16:48 PM
I also would like this updated to RC1 if possible.

Thanks,

Wally
Title: Re: Bookmarks
Post by: willerby on April 22, 2009, 02:54:50 AM
2.0 b4 version works fine on RC1
Title: Re: Bookmarks
Post by: Rumboogy on April 23, 2009, 11:22:26 AM
Then I am having trouble with "permissions". I can see the bookmarks, and a menu item appears for me (Admin)...however, they do not show up for regular members...is there a way to check my permissions?

Thanks for any help on this...

Wally
Title: Re: Bookmarks
Post by: coolfx350 on May 20, 2009, 08:35:59 AM
I have installed this mods many times, works great.

I recently made a new forum and trying to install this mod again, everything works, but ...

when a topic is bookmarked, it doesn't display the topic heading, the Started by column is also blank.

I do have pretty url mod installed.  Maybe it's conflict.

what to do?
Title: Re: Bookmarks
Post by: usa4all on May 23, 2009, 06:57:12 AM
MOd installed fine, but it doesn't show up in the SAFMC theme..  What goes wrong? My Default langauage is Dutch.
Title: Re: Bookmarks
Post by: dj_pont on May 28, 2009, 05:31:53 PM
Установил на RC1-1, под админом всё впорядке, всё отбражается и работает. А у обычных пользователей ничего не отображается. Что-то с правами доступа, где их менять для этого мода?
Title: Re: Bookmarks
Post by: digger on May 28, 2009, 06:07:29 PM
Quote from: dj_pont on May 28, 2009, 05:31:53 PM
Установил на RC1-1, под админом всё впорядке, всё отбражается и работает. А у обычных пользователей ничего не отображается. Что-то с правами доступа, где их менять для этого мода?

Не смущает что вокруг все по нерусски пишут?

В правах доступа для группы обычных пользователей - Create bookmarks for topics
Title: Re: Bookmarks
Post by: dj_pont on May 28, 2009, 06:13:03 PM
Quote from: digger on May 28, 2009, 06:07:29 PM
Quote from: dj_pont on May 28, 2009, 05:31:53 PM
Установил на RC1-1, под админом всё впорядке, всё отбражается и работает. А у обычных пользователей ничего не отображается. Что-то с правами доступа, где их менять для этого мода?

Не смущает что вокруг все по нерусски пишут?

В правах доступа для группы обычных пользователей - Create bookmarks for topics

Неа, не смущает=)))

Спасибо за инфу, нашёл! )
Title: Re: Bookmarks
Post by: MCK on May 31, 2009, 09:28:59 AM
Hi. Is this mod compatible with RC 1.1? mods page says so but installer refuses to play. Any ideas? Thanks in advance for all your help.
Title: Re: Bookmarks
Post by: karls on June 04, 2009, 03:28:42 AM
Hi,

I cannot see any new option after installing this package.

Why?

Karl
Title: Re: Bookmarks
Post by: lampidona on June 10, 2009, 07:57:03 AM
Is this mod only working with the default theme? I use another theme and I tried to modify the Index.template.php and the Display.template.php files with the additions you suggest in manually installation (I have 1.1.9 version) but I couldn't find where to make the modifications because the code is a little different from the default. I use the amber theme! If it is something easy but my skill isn' t enough to find it, could you help me to have the mod right installed to the theme I use?  :D
Title: Re: Bookmarks
Post by: Sakae on June 17, 2009, 01:37:52 PM
lampidona, do you know anything about html? It's, like, replacing some div's for some table's and stuff.

The hardcode remains the same, but the template code might be different some times...
Title: Re: Bookmarks
Post by: kreativekarma on June 18, 2009, 11:57:08 AM
This mod was working on my forum but stopped about 6 months ago. I tried downloading and installing again but it has errors. I am still on 2.0 Beta 3.1 Public
Title: Re: Bookmarks
Post by: MissyNL on June 22, 2009, 05:06:07 PM
Hi.. when a topic has been moved to a board where the members does not have acces to anymore... what error will you see? Or will that link also be automaticly deleted?
Title: Re: Bookmarks
Post by: dansmark on June 24, 2009, 03:53:38 PM
I installed "Bookmark 2.1.1", but don't find any evidence of it's existance (other than the "Package Manager").

Does anybody know where I can turn the bookmark mod "on"?
I went ot "Modifications" and found the "Miscellaneous" tab, but nothing shows-up there either.

Thanks!
Title: Re: Bookmarks
Post by: willerby on June 24, 2009, 06:07:22 PM
Quote from: MissyNL on June 22, 2009, 05:06:07 PM
Hi.. when a topic has been moved to a board where the members does not have acces to anymore... what error will you see? Or will that link also be automaticly deleted?

Just tested this as I didn't know the answer. No error - the bookmark automatically disappears from the list.

W
Title: Re: Bookmarks
Post by: TomW on June 24, 2009, 07:20:39 PM
Quote from: dansmark on June 24, 2009, 03:53:38 PM
I installed "Bookmark 2.1.1", but don't find any evidence of it's existance (other than the "Package Manager").

Does anybody know where I can turn the bookmark mod "on"?
I went ot "Modifications" and found the "Miscellaneous" tab, but nothing shows-up there either.

Thanks!
Using the Admin page, click on 'Permissions' under Members category, then click on Modify' to the right of Regular Members. It is the 5th item under General.
Title: Re: Bookmarks
Post by: Sakae on June 25, 2009, 02:21:03 AM
Hi. Any chances to "hack" this MOD to work together with Arcade (favorite games)?
Title: Re: Bookmarks
Post by: Arkangel on June 25, 2009, 03:20:36 AM
   
show ... favorite number?¿?¿

Title: Re: Bookmarks
Post by: dansmark on June 25, 2009, 07:47:39 AM
Quote from: TomW on June 24, 2009, 07:20:39 PM
Quote from: dansmark on June 24, 2009, 03:53:38 PM
I installed "Bookmark 2.1.1", but don't find any evidence of it's existance (other than the "Package Manager").

Does anybody know where I can turn the bookmark mod "on"?
I went ot "Modifications" and found the "Miscellaneous" tab, but nothing shows-up there either.

Thanks!
Using the Admin page, click on 'Permissions' under Members category, then click on Modify' to the right of Regular Members. It is the 5th item under General.

I'm not sure what is showing in your fourm, in the path you showed me for turning on the "Bookmark Mod", but it ain't there in mine!

It seems that none of the mods I've installed actually work.
I stated a topic in 2.0 support called "Package Manager looks like it's working, but it's not! ".

So far nobody knows anything...
Title: Re: Bookmarks
Post by: MissyNL on June 29, 2009, 06:34:43 AM
Quote from: willerby on June 24, 2009, 06:07:22 PM
Quote from: MissyNL on June 22, 2009, 05:06:07 PM
Hi.. when a topic has been moved to a board where the members does not have acces to anymore... what error will you see? Or will that link also be automaticly deleted?

Just tested this as I didn't know the answer. No error - the bookmark automatically disappears from the list.

W

Oh.. oke :D thank you for the reply
Title: Re: Bookmarks
Post by: dansmark on July 02, 2009, 08:12:15 PM
Update!!!!!

I'm having a lot of problems with my forum...
No mods will work...  yet the base forum, seems to operate just fine.

Not one "Mod" I install, shows up in "Modifications"

I'm not investing any more time in it!

Thanks everyone for the help!!!

Case closed!
Title: Re: Bookmarks
Post by: fff on July 09, 2009, 09:27:32 AM
I am trying to install bookmarks mod manually. I did everythink except this:
Code
smf11/install.php
This file should not be able to execute standalone. You may have to run the following queries manually.
Query: [Select]

CREATE TABLE IF NOT EXISTS {$db_prefix}bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
)


I dont know what this means. How to run the previous queries manually?

BTW when I open my 1.1.9 forum http://trustedptc.ueuo.com/ and click on "my bookmarks" it says:
Database Error
Table '225383.smf_bookmarks' doesn't exist
File: /home/vhosts/trustedptc.ueuo.com/Sources/Bookmarks.php
Line: 65

When I try to "add bookmark" it says:
Database Error
Table '225383.smf_bookmarks' doesn't exist
File: /home/vhosts/trustedptc.ueuo.com/Sources/Bookmarks.php
Line: 143


What is the problem
Title: Re: Bookmarks
Post by: gbsothere on July 09, 2009, 09:33:03 AM
fff, if you have access to your database through MySQL (or your particular control panel) that is where you will run your query.  You will need to change {$db_prefix}bookmarks to whatever prefix you use for your tables, such as smf_bookmarks.  When you view your tables, you will see what your prefix is.  Your server techs will usually talk you through it, if you've never run a query before.

Running the query will create the table that you are currently missing. 
Title: Re: Bookmarks
Post by: fff on July 18, 2009, 02:48:53 PM
I succesfully installed bookmarks mod on my maistrafego theme on my forum http://trustedptc.ueuo.com/
But maistrafego theme is not the default theme of SMF. Because of that " my bookmarks" button is not as same as the other buttons of my maistrafego theme like "home" , '' help'' , ''register''  ...
(http://img146.imageshack.us/img146/4697/71872055.th.jpg) (http://img146.imageshack.us/i/71872055.jpg/)

What I have to do to solve this problem? I want "my bookmarks " button to looks like the other butoons
Title: Re: Bookmarks
Post by: gbsothere on July 18, 2009, 03:16:30 PM
You may want to attach the index.template.php for your theme so someone can take a look at it?  You need to manually edit the particular files (index.template.php and display.template.php) for your theme according to the mod's parsing instructions for your version of SMF.

Title: Re: Bookmarks
Post by: fff on July 19, 2009, 07:08:14 AM
Ok.  Here are the files.   Please tell me exactly what you will modify because I want to learn how you do that.
Title: Re: Bookmarks
Post by: gbsothere on July 19, 2009, 08:54:56 AM
Actually, both your index.template.php and Display.template.php files look fine (as far as I can tell).  What language are you using?
Title: Re: Bookmarks
Post by: fff on July 19, 2009, 09:22:50 AM
Quote from: gbsothere on July 19, 2009, 08:54:56 AM
Actually, both your index.template.php and Display.template.php files look fine (as far as I can tell).  What language are you using?
I am using English
Title: Re: Bookmarks
Post by: gbsothere on July 19, 2009, 09:37:09 AM
Did you make this edit to your Modifications.english.php file?

Find at the end of the file:

?>

Add before that:


$txt['bookmarks'] = 'My Bookmarks';
$txt['bookmark_list'] = 'Bookmarks';
$txt['bookmark_list_empty'] = 'You don\'t have any bookmarks at the moment. Add one by clicking \'Add bookmark\' in topics.';
$txt['bookmark_open_window'] = 'Open in new window';
$txt['bookmark_delete'] = 'Delete selected bookmarks';
$txt['bookmark_delete_success'] = '%1$s bookmarks were deleted successfully!';
$txt['bookmark_delete_failure'] = 'Not all bookmarks could be deleted.';
$txt['bookmark_add'] = 'Add bookmark';
$txt['bookmark_add_success'] = 'The topic was successfully added to your bookmarks!';
$txt['bookmark_add_exists'] = 'This topic is already listed in your bookmarks!';
$txt['bookmark_add_failed'] = 'Failed to add the topic to your bookmarks.';
$txt['permissionname_make_bookmarks'] = 'Create bookmarks for topics';
$txt['cannot_make_bookmarks'] = 'Sorry, you don\'t have permission to make bookmarks.';


In fact, fff, I would go to the mod page here:

http://custom.simplemachines.org/mods/index.php?mod=864 (http://custom.simplemachines.org/mods/index.php?mod=864)

And set the pull-down menu for 1.1.9 (if I remember correctly, that's your version, but set it to your version) and click Parse, then check all your files against those for correct parsing.  Also remember to move the two included files Bookmarks.php and Bookmarks.template.php to their proper directories. 
Title: Re: Bookmarks
Post by: fff on July 19, 2009, 03:46:12 PM
Actually I made the previous edit to ./Themes/maistrafego/languages/ThemeStrings.english.php
I attached that file down.
I didnt make the previous edit to Modifications.english.php because there isnt such file in Maistrafego theme but I think that ThemeStrings.english.php is same file as Modifications.english.php

BTW I think that I did everything correctly because I tried to istall bookamrks mod several times and the result is the same
Title: Re: Bookmarks
Post by: gbsothere on July 19, 2009, 03:59:48 PM
I'm really stumped, fff.  What browser are you viewing your site with?  Have you tried dumping the cache and relaunching it and also trying other browsers in addition to what you normally use, to see if it appears the same with them?

Of course, Aäron is the guy with the answers, so hopefully, he'll be able to weigh in on whether or not this can work with your theme as you're hoping.

Title: Re: Bookmarks
Post by: fff on July 19, 2009, 05:47:27 PM
 ;D I am using Mozila Firefox. But last time I viewed my site with Internet Explorer and everything is OK.  So when I am using Internet explorer everything is good with my forum. :D
But if Aäron had a solution for my problem, I would like to tell me what I have to do to solve the problem about viewing my forum with Firefox.
Title: Re: Bookmarks
Post by: Sabre™ on July 19, 2009, 06:01:17 PM
Your button problem has nothing to do with your browser.
Try the attached index.template
Title: Re: Bookmarks
Post by: gbsothere on July 19, 2009, 06:36:44 PM
That's definitely different than the parsing instructions for editing that file.   :) 

*eager to hear the results*
Title: Re: Bookmarks
Post by: Sabre™ on July 19, 2009, 06:44:08 PM
Yeah, the nav menu layout for that theme isn't set as the default theme is.
It should work as designed, but....  the message under my avy says it all! lol ;)
Title: Re: Bookmarks
Post by: plusev on July 24, 2009, 12:06:05 PM
I get the following error when trying to install:

The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

Please advise

2 RC1.2

Tried reverting to 2 rc1.1 and still the same.
Title: Re: Bookmarks
Post by: willerby on July 25, 2009, 01:22:25 PM
Same problem after reinstalling from scratch RC1.2...

Any helpers or is this manual install only now?
Title: Re: Bookmarks
Post by: willerby on July 29, 2009, 03:06:14 PM
Well as no reply i've manually installed but parser only has 2.0 b4 compatible mod despite RC1-1 being listed.

All works fine on manual install with SMF2 RC1-2 but parser and download need looking at otherwise this is a dead mod for most people. That would be a shame as its a good one.
Title: Re: Bookmarks
Post by: fff on August 01, 2009, 03:27:52 PM
Quote from: Sabre™ on July 19, 2009, 06:01:17 PM
Your button problem has nothing to do with your browser.
Try the attached index.template
Sorry because I didn't answer for some time. I was on holiday. 
Yesterday I upload the index.template file and everything is OK with ''my bookmarks" button. Thank you. :D
Title: Re: Bookmarks
Post by: Sabre™ on August 05, 2009, 06:24:00 AM
No worries champ :D
Title: Re: Bookmarks
Post by: plusev on August 08, 2009, 10:53:07 PM
Will this Mod be available for 2 rc 1.2 any time soon? Maybe a manual edit? Tried the revert to 2 rc 1.1 but that didn't work. Its truly an excellent mod I'd love to get running.

Thx
Title: Re: Bookmarks
Post by: Sabre™ on August 09, 2009, 11:58:18 PM
The manual edits should be the same/similar, I'll try later on tonight to confirm for you
Title: Re: Bookmarks
Post by: ElectroPheonix on August 13, 2009, 10:35:36 AM
I've installed the mod with no issues. It's a very useful mod so thanks very much  :D I'm using a custom theme on 1.1.10

I do have one small issue with it. It does not show up in the Who's Online list when people are looking at the bookmark page... instead it shows it as "Unknown Action".

I know something has to change in the Who.php and maybe a piece of code like the following might be needed...

<?php
 
include_once('../forum/SSI.php');
 
$online=ssi_logOnline('array');
 
?>


I have checked the instructions in the who.php file and tbh I can't understand what's what in there...

Some help to get the online list to say "Bookmarks" would be awesome!

Thanks in advance.
Title: Re: Bookmarks
Post by: plusev on August 13, 2009, 12:14:04 PM
Quote from: Sabre™ on August 09, 2009, 11:58:18 PM
The manual edits should be the same/similar, I'll try later on tonight to confirm for you

Thx, I'd appreciate that.
Title: Re: Bookmarks
Post by: willerby on August 13, 2009, 02:51:04 PM
Quote from: plusev on August 13, 2009, 12:14:04 PM
Quote from: Sabre™ on August 09, 2009, 11:58:18 PM
The manual edits should be the same/similar, I'll try later on tonight to confirm for you

Thx, I'd appreciate that.

Manual install works fine on RC1-2 (http://www.simplemachines.org/community/index.php?topic=182923.msg2183142#msg2183142)
Title: Re: Bookmarks
Post by: plusev on August 13, 2009, 03:51:34 PM
Quote from: willerby on August 13, 2009, 02:51:04 PM
Quote from: plusev on August 13, 2009, 12:14:04 PM
Quote from: Sabre™ on August 09, 2009, 11:58:18 PM
The manual edits should be the same/similar, I'll try later on tonight to confirm for you

Thx, I'd appreciate that.

Manual install works fine on RC1-2 (http://www.simplemachines.org/community/index.php?topic=182923.msg2183142#msg2183142)

Ok thx. I found the parse for 2 rc1. At the end it states:

Code
smf20/install.php
This file should not be able to execute standalone. You may have to run the following queries manually.


File Operations
Move the included file "smf20/Bookmarks.php" to "./Sources".
Move the included file "smf20/Bookmarks.template.php" to "./Themes/default".


Not sure what that means. Is the manual install the same for a custom theme? Thx, +EV
Title: Re: Bookmarks
Post by: willerby on August 13, 2009, 05:32:57 PM
Themes will pick up the bookmarks.template.php from the default Theme if it does not exist in their folder. Try it. Different themes display pages differently but this is a simple mod which should display fine on any theme.

Always keep a backup of the files before you amend them (inserting a ~ tild on the end of each original file brefore uploading the new version). Very easy to then go back to working state.

It works fine on Shadow People theme (which was for v2.0b4)

W
Title: Re: Bookmarks
Post by: busterone on August 13, 2009, 07:14:27 PM
I can also concur that this mod works very well on 2 RC1.2 with a manual install. Follow the parser step by step and it does work.
Title: Re: Bookmarks
Post by: Altair on August 14, 2009, 04:02:53 PM
I think I will wait for the author to update this Mod before I install it. I know Aaron is still around, sure he will get back to it in time.
Title: Re: Bookmarks
Post by: danielwmoore on August 29, 2009, 10:58:27 AM
I went into the "package-info.xml" file, and changed 2 lines.

Find:
<install for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1">

Replace with:
<install for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC1-1, 2.0 RC1.2">

Find:
<uninstall for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1">

Replace with:
<uninstall for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC1-1, 2.0 RC1.2">

It worked flawlessly this way for my 2.0 RC1.2 installation, and I already have about 28 mods.  This is a great mod.  The only update it needs is the one I've just shown above, as far as I can tell.

Aäron, I encourage you to incorporate this simple change.  That way, only those who have a mod conflict would have to do the manual install.  I made this change before I attempted install, and it was a flawless automatic package install for my 2.0 RC1.2.
Title: Re: Bookmarks
Post by: Sabre™ on August 29, 2009, 11:26:42 AM
You could also eliminate all of that and just have <install> & <uninstall> for further updates to smf2, so you dont need to keep updating it with each version update.
Also the uninstall button will always be visible ;)
Title: Re: Bookmarks
Post by: plusev on August 29, 2009, 05:19:48 PM
confirmed
Title: Re: Bookmarks
Post by: Arantor on August 29, 2009, 05:34:21 PM
Alternatively you could use the Advanced button in the Package Manager to override the version and enter 2.0 RC1 and it would have installed just fine anyway.
Title: Re: Bookmarks
Post by: Prosoi on September 17, 2009, 02:30:33 AM
Hi, what about feature-request: add ability to add single post (reply) to bookmarks, instead of all topic.
Title: Re: Bookmarks
Post by: Arantor on September 17, 2009, 07:28:31 AM
If I remember the mod correctly, this isn't so much a minor tweak but a fairly large overhaul.

Though I can't speak for the developer, I would believe he is busy working on SMF 2 RC2 rather than supporting his mods at present - but if he gets chance he may be able to overhaul it.
Title: Re: Bookmarks
Post by: fff on September 20, 2009, 10:49:27 AM
is this mod compatibile with 1.1.10 version ?
Title: Re: Bookmarks
Post by: Arantor on September 20, 2009, 10:52:06 AM
It should be - there are no changes between 1.1.9 and 1.1.10 that this mod would affect IIRC, so you should be able to just install it.
Title: Re: Bookmarks
Post by: fff on September 21, 2009, 01:46:49 PM
managepermissions.php
Find: [Select]

'karma_edit' => false,
),
'pm' => array(


Replace With: [Select]

'make_bookmarks' => false,
'karma_edit' => false,
),
'pm' => array(


I have installed manually Ad management mod. Because of that the code in managepermissions.php is
'karma_edit' => false,
),
'ad_manage' => array(
'ad_manageperm' => false,
),
'pm' => array(


So how should I replace the previous code with this code
'make_bookmarks' => false,
'karma_edit' => false,
),
'pm' => array(



Title: Re: Bookmarks
Post by: Arantor on September 21, 2009, 02:31:11 PM
Just add the 'make_bookmarks' line above the 'karma_edit' line.
Title: Re: Bookmarks
Post by: gitchuone on October 09, 2009, 08:07:36 PM
I got the mod installed no problem, but it is only working on my Admin account and I cannot find where I can set it for any other membergroup. Anyone have any idea what I need to do to allow this?
Title: Re: Bookmarks
Post by: Hiver101 on October 28, 2009, 07:11:34 AM
is this mod works on SMF 2.0 RC1.2? please let me know
Title: Re: Bookmarks
Post by: Arantor on October 28, 2009, 07:37:22 AM
Yes it does.

Go into Admin > Packages > Browse Packages, select the little 'Advanced' option in the lower right corner, and enter 2.0 RC1 instead of 2.0 RC1.2.
Title: Re: Bookmarks
Post by: TurtleKicker on November 12, 2009, 02:36:29 PM
Any chance of support for SMF2 RC2?
Title: Re: Bookmarks
Post by: LG965 on November 13, 2009, 06:27:16 AM
I use on my smf 1.1.10 this mod with pleasure!  :)
I have a suggestion for next relise: insert an icon in 3d that I added to my bookmarks. 8)
Thanks Aaron  ;)
Title: Re: Bookmarks
Post by: Hoodie on November 18, 2009, 05:35:57 PM
Quote from: sremick on November 12, 2009, 02:36:29 PM
Any chance of support for SMF2 RC2?

Agreed..  RC2 support soon please..
Title: Re: Bookmarks
Post by: Tanks on November 22, 2009, 01:58:20 AM
Would love to have this on my 2.0 RC2 forum. Cheers ;)
Title: Re: Bookmarks
Post by: Vekseid on November 22, 2009, 11:23:12 AM
Real quick patch job here: http://elliquiy.com/pics/bookmarks222.zip

It only works with RC2 because of the new default template.
Title: Re: Bookmarks
Post by: Eclipse16V on December 02, 2009, 06:21:18 AM
Quote from: Vekseid on November 22, 2009, 11:23:12 AM
Real quick patch job here: http://elliquiy.com/pics/bookmarks222.zip

It only works with RC2 because of the new default template.

Nice but there is a DB Error after the install.

Run this after the install in your DB
ALTER TABLE `bookmarks` RENAME `smf_bookmarks` ;
After it works great.
Title: Re: Bookmarks
Post by: Tanks on December 02, 2009, 03:21:00 PM
I rather not go into my DB - I am not that comfortable with it.

Also i think my DB has Bookmarks in it because i used this mod back in the days.
Title: Re: Bookmarks
Post by: Altair on December 02, 2009, 07:14:30 PM
Quote from: Tanks on December 02, 2009, 03:21:00 PM
I rather not go into my DB - I am not that comfortable with it.

Also i think my DB has Bookmarks in it because i used this mod back in the days.

If you are comfortable with php or SQL, you can always run a query to drop the table "smf_bookmarks" if you are no longer using it.
Title: Re: Bookmarks
Post by: Greywolfdoc on December 03, 2009, 09:49:34 AM
Quote from: Eclipse16V on December 02, 2009, 06:21:18 AM

Nice but there is a DB Error after the install.

Run this after the install in your DB
ALTER TABLE `bookmarks` RENAME `smf_bookmarks` ;
After it works great.

There are also two other problems.

1. The linktree is repeated twice with consequent interruption of the background image.

To eliminate the repetition of linktree just delete this part of code


./Themes/default/Bookmarks.template.php

Search and delete:

// Show the linktree
echo '
<div>', theme_linktree(), '</div>';



2. The title bar hasn't rounded corners 



(http://img708.imageshack.us/img708/641/bookmarkserror.jpg)
Title: Re: Bookmarks
Post by: Eclipse16V on December 03, 2009, 04:31:47 PM
1. and 2. have I edit in my template file.

Here my bookmarks.template.php and it works great.
<?php
function template_main()
{
global $context$settings$scripturl$txt$return;

// Show $return when it's set
if (!empty($return))
{
echo '
<table align="center" cellpadding="15" cellspacing="0" class="tborder">
<tr>
<td class="windowbg">'
$return'</td>
</tr>
</table>
<br />'
;
}

// Show the bookmark table title
echo '
<h3 class="catbg"><span class="left"></span>'
$txt['bookmark_list'], '</h3>
<form action="'
$scripturl'?action=bookmarks;sa=delete" method="post">';

// Show the bookmarks if there are any
if (!empty($context['bookmarks']))
{
echo '
<div class="tborder topic_table" id="messageindex">
<table class="table_grid" cellspacing="0">
<thead>
<tr>
<th scope="col" class="smalltext first_th" width="8%">&nbsp;</th>
<th scope="col" class="smalltext">'
$txt['subject'], '</th>
<th scope="col" class="smalltext" width="11%">'
$txt['started_by'], '</th>
<th scope="col" class="smalltext" width="4%">'
$txt['replies'], '</th>
<th scope="col" class="smalltext" width="4%">'
$txt['views'], '</th>
<th scope="col" class="smalltext" width="22%">'
$txt['latest_post'], '</th>
<th scope="col" class="smalltext last_th" width="8%" align="center"><input type="checkbox" class="check" onclick="invertAll(this, this.form);" /></th>
</tr>
</thead>
<tbody>'
;

foreach ($context['bookmarks'] as $topic)
{
// Show the topic's subject
echo '
<tr>
<td class="windowbg2" align="center">
<img src="'
$topic['first_post']['icon_url'], '" alt="" />
</td>
<td class="windowbg" valign="middle">
'
$topic['first_post']['link'];

// Any new replies?
if ($topic['new'])
echo '
<a href="'
$topic['new_href'], '"><img src="'$settings['images_url'], '/'$context['user']['language'], '/new.gif" alt="'$txt['new'], '" /></a>';

// Show the board the topic was posted in, as well as a link to the profile of the topic starter
echo '
<br />
<span class="smalltext"><i>'
$txt['in'], ' '$topic['board']['link'], '</i></span>
</td>
<td class="windowbg2" valign="middle">'
$topic['first_post']['member']['link'], '</td>
<td class="windowbg" valign="middle" align="center">'
$topic['replies'], '</td>
<td class="windowbg" valign="middle" align="center">'
$topic['views'], '</td>
<td class="windowbg2" valign="middle">
<a href="'
$topic['last_post']['href'], '"><img src="'$settings['images_url'], '/icons/last_post.gif" alt="'$txt['last_post'], '" title="'$txt['last_post'], '" style="float: right;" /></a>
<span class="smalltext">
'
$topic['last_post']['time'], '<br />
'
$txt['by'], ' '$topic['last_post']['member']['link'], '
</span>
</td>
<td class="windowbg2" valign="middle" align="center"><input type="checkbox" name="remove_bookmarks[]" value="'
$topic['id'], '" class="check" /></td>
</tr>'
;
}

echo '
<tr>
<td colspan="7" class="windowbg2" align="right">
<input type="submit" name="send" value="'
$txt['bookmark_delete'], '" />
</td>
</tr>
</tbody>
</table>'
;
}
// Show a message saying there aren't any bookmarks yet
else
{
echo '
<div id="help_container">
<div class="windowbg2">
<span class="topslice"><span></span></span>
<div id="helpmain">
'
$txt['bookmark_list_empty'], '
</div>
<span class="botslice"><span></span></span>
</div>
</div>'
;
}

echo '
</form>'
;

}
?>
Title: Re: Bookmarks
Post by: TomW on December 30, 2009, 05:43:48 PM
I see that there is a 2.0 RC1 version available.  Will the manual changes mentioned in this thread make this mod compatible with 2.0 RC2 ?
Title: Re: Bookmarks
Post by: Arantor on December 30, 2009, 05:49:43 PM
Quote from: TomW on December 30, 2009, 05:43:48 PM
I see that there is a 2.0 RC1 version available.  Will the manual changes mentioned in this thread make this mod compatible with 2.0 RC2 ?

I believe they should. Note that the changes in this thread are not any supported or applied by the original author.
Title: Re: Bookmarks
Post by: ChaosEnergy on December 30, 2009, 05:51:07 PM
I have it running on rc2 with the changes above
Title: Re: Bookmarks
Post by: TomW on December 30, 2009, 06:42:11 PM
Thank you Arantor & ChaosEnergy for the quick responses !
Title: Re: Bookmarks
Post by: Tanks on December 31, 2009, 04:38:32 AM
I did this and got it working on 2.0 RC2

Thanks, great mod ;)
Title: Re: Bookmarks
Post by: Vveb.ws on January 01, 2010, 09:01:35 AM
Thanks, good needed mod. I have installed it in my forum.


Add please russian translate for
/Themes/default/languages/Modifications.russian.php
$txt['bookmarks'] = 'Закладки';
$txt['bookmark_list'] = 'Закладки';
$txt['bookmark_list_empty'] = 'У Вас нет закладок в данный момент. Добавляйте закладки, нажав "Добавить в закладки" вверху и внизу любой темы';
$txt['bookmark_open_window'] = 'Открыть в новом окне';
$txt['bookmark_delete'] = 'Удалить выделенные закладки';
$txt['bookmark_delete_success'] = '%1$s закладки были удалены';
$txt['bookmark_delete_failure'] = 'Закладки не могут быть удалены';
$txt['bookmark_add'] = 'Добавить в закладки';
$txt['bookmark_add_success'] = 'Тема добавлена в Закладки';
$txt['bookmark_add_exists'] = 'Эта тема уже есть в Закладках';
$txt['bookmark_add_failed'] = 'Невозможно добавить тему в Закладки';
$txt['permissionname_make_bookmarks'] = 'Создавать закладки для тем';
$txt['cannot_make_bookmarks'] = 'Извините, у Вас нет прав для создания закладок';


Add please switch Permissions
Eng
QuoteIt need to switching on bookmarks in admin panel:
Members: Permissions -> Permissions for the group -> Normal users Edit -> switch Create bookmarks for topics
Rus
QuoteНАДО ВКЛЮЧИТЬ ЗАКЛАДКИ  в админке:
Пользователи: Права доступа -> Права доступа по группам -> Обычные пользователи Изменить -> Галка Create bookmarks for topics


server Denwer
Eng
QuoteFor Denver does not work and the normal install, and queries SQL, it need to create a table in phpMyAdmin
Create a new table in your database:
Name: yourprefix_bookmarks
Margins: 2
and filling it
Rus
QuoteДля Денвера не работает и обычная установка, и запросы SQL, надо создавать таблицу  в phpMyAdmin
Создать новую таблицу в вашей БД:
Имя: вашпрефикс_bookmarks
Поля: 2
и заполнить её


Eng
QuoteSuggestions:
I'd love to see the creation of categories in the bookmarks, so not all in one pile to keep.
Rus:
QuoteПожелания:
Очень хотелось бы увидеть создание категорий в закладках, чтобы не всё в одну кучу сохранять.
Title: Re: Bookmarks
Post by: Vveb.ws on January 03, 2010, 09:29:13 AM
I recently encountered the following problem - hoster moved to a new server, which is a later version of PHP Version 5.2.12
I use SMF 1.1.11, win-1251
 
I put the mod Bookmarks - http://ozdorovlenie.vveb.ws/index.php?action=bookmarks, a couple of days ago it worked fine, as in Denver (I have install this mod correct), and
1) now writes error:
QuoteDatabase Error
Please try again. If the problem continues to recur, contact the Administrator.

2) sometimes gives another error
QuoteTable 'vvebw701_ozd.ozd_bookmarks' doesn't exist
File: / home/.../ozdorovlenie/Sources/Bookmarks.php
Line: 65

3) sometimes gives another error
QuoteTable 'vvebw701_ozd.ozd_bookmarks' doesn't exist
File: /home/vvebw701/domains/vveb.ws/public_html/ozdorovlenie/Sources/Bookmarks.php
Line: 143

because of what it?

I don't know why is error is changed -  Database Error,  Line: 143, Line: 65
,
 
To see this, you must enter the forum.
User
A5bnTer6k  
 
What I must to do ? Rewrite all the old scripts, including mods to SMF, in general, unrealistic.
Search for hosting with the old version of PHP?
Title: Re: Bookmarks
Post by: TomW on January 03, 2010, 11:03:41 AM
It appears that SMF cannot find your bookmarks table.  Is it named correctly ?  It is looking for odz_bookmarks as the table name. 
Title: Re: Bookmarks
Post by: Vveb.ws on January 03, 2010, 11:56:27 AM
I have all make right! This table really is. All named correctly.

The DataBase coping from hosting to Denwer.
This mod works on Denwer and not on hosting!


It is something with hosting...

I can show DB:
Quote--
-- Structure table `ozd_bookmarks`
--

CREATE TABLE IF NOT EXISTS `ozd_bookmarks` (
  `ID_MEMBER` mediumint(8) unsigned NOT NULL,
  `ID_TOPIC` mediumint(8) unsigned NOT NULL,
  UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
) ENGINE=MyISAM DEFAULT CHARSET=cp1251;

I have install it by SQL-question in PHPMyAdmin (install.php not works), I have some remake original SQL-question


Hosting kink, toad! Yesterday I have remake index.php to view russian letter instead ???????????? - this problem became with new server. Nothing astonishing...



PS (month later)


Mod "Bookmarks" works good!

I realized what was going on! I switched to a new hosting service, took DB from old hosting, and it turned out, this table is really not! On the new hosting, I created a new table in the database and everything works!

Hoster moved, and at that time were available two PHPMyAdmin
Maybe I made a new table on the old server, and Web hosting has already undergone all DB on the new server, but the old server was still available for some time.
Or, if everything worked and then stopped, Hoster took NOT the most recent backup database for the move (which have not table for bookmarks).
In general, the problem is not in Mod, but in the relocation of the hoster.
Title: Re: Bookmarks
Post by: Bugo on January 12, 2010, 10:16:43 AM
Russian translation:

// Bookmarks
$txt['bookmarks'] = 'Избранное';
$txt['bookmark_list'] = 'Избранные темы';
$txt['bookmark_list_empty'] = 'В настоящий момент ни одна тема не добавлена в Избранное. Для добавления просто кликните &laquo;Добавить в Избранное&raquo; в нужной теме.';
$txt['bookmark_open_window'] = 'Открыть в новом окне';
$txt['bookmark_delete'] = 'Удалить выбранные темы из списка';
$txt['bookmark_delete_success'] = 'Чистота — залог здоровья :)';
$txt['bookmark_delete_failure'] = 'Не все темы были удалены из Избранного.';
$txt['bookmark_add'] = 'Добавить в Избранное';
$txt['bookmark_add_success'] = 'Тема была успешно добавлена в Избранное!';
$txt['bookmark_add_exists'] = 'Эта тема уже есть в Избранном!';
$txt['bookmark_add_failed'] = 'Добавление темы в Избранное не удалось.';
$txt['permissionname_make_bookmarks'] = 'Добавление тем в Избранное';
$txt['cannot_make_bookmarks'] = 'Извините, Вам не разрешили добавлять темы в Избранное :)';
Title: Re: Bookmarks
Post by: willerby on January 13, 2010, 03:28:12 AM
Would appear you have table name error - ozd_bookmarks vs odz_bookmarks?
Title: Re: Bookmarks
Post by: KensonPlays on January 18, 2010, 07:24:14 PM
Will this be made for 2.0RC2?
Title: Re: Bookmarks
Post by: Eclipse16V on January 19, 2010, 12:12:51 AM
Work on 2.0RC2
Title: Re: Bookmarks
Post by: Mick. on January 28, 2010, 05:11:29 PM
Quote from: Eclipse16V on January 19, 2010, 12:12:51 AM
Work on 2.0RC2

Yes indeed.
Title: Re: Bookmarks
Post by: searchgr on January 29, 2010, 01:58:22 AM
Quote from: BlueDevil on January 28, 2010, 05:11:29 PM
Quote from: Eclipse16V on January 19, 2010, 12:12:51 AM
Work on 2.0RC2

Yes indeed.

It doesn't work here. smf 2.0 rc2
Aäron, can you please update it?
Title: Re: Bookmarks
Post by: Mick. on January 29, 2010, 08:40:53 AM
Quote from: searchgr on January 29, 2010, 01:58:22 AM
Quote from: BlueDevil on January 28, 2010, 05:11:29 PM
Quote from: Eclipse16V on January 19, 2010, 12:12:51 AM
Work on 2.0RC2

Yes indeed.

It doesn't work here. smf 2.0 rc2
Aäron, can you please update it?

It does work if installed manually using the parser.
Title: Re: Bookmarks
Post by: p1tereq on January 29, 2010, 10:15:24 AM
Problem is that the parser is not working for SMF 2.0 RC2.
Title: Re: Bookmarks
Post by: KensonPlays on January 29, 2010, 10:48:40 AM
And I don't like using the parser, manually editing takes too much time...
Title: Re: Bookmarks
Post by: Mick. on January 29, 2010, 11:25:36 AM
Quote from: p1tereq on January 29, 2010, 10:15:24 AM
Problem is that the parser is not working for SMF 2.0 RC2.

True.   Use the parser for 2.0 Beta 4   

I believe thats the one i used for my RC2 forum.
Title: Re: Bookmarks
Post by: p1tereq on January 30, 2010, 02:20:58 AM
Quote from: BlueDevil on January 29, 2010, 11:25:36 AM
Quote from: p1tereq on January 29, 2010, 10:15:24 AM
Problem is that the parser is not working for SMF 2.0 RC2.

True.   Use the parser for 2.0 Beta 4   

I believe thats the one i used for my RC2 forum.

Yeah, it's working - thanks buddy.
Title: Re: Bookmarks
Post by: Mick. on January 30, 2010, 08:47:03 AM
Quote from: p1tereq on January 30, 2010, 02:20:58 AM
Quote from: BlueDevil on January 29, 2010, 11:25:36 AM
Quote from: p1tereq on January 29, 2010, 10:15:24 AM
Problem is that the parser is not working for SMF 2.0 RC2.

True.   Use the parser for 2.0 Beta 4   

I believe thats the one i used for my RC2 forum.

Yeah, it's working - thanks buddy.
No problem.
Title: Re: Bookmarks
Post by: rgecy on February 04, 2010, 07:58:29 AM
Any word if this mod will be released for rc2?  I am trying to keep manual edits to a minimum!

Thanks,

RGecy
Title: Re: Bookmarks
Post by: KensonPlays on February 04, 2010, 12:29:24 PM
Quote from: rgecy on February 04, 2010, 07:58:29 AM
Any word if this mod will be released for rc2?  I am trying to keep manual edits to a minimum!
DITTO!!
Title: Re: Bookmarks
Post by: rgecy on February 09, 2010, 04:24:09 PM
Ok, I installed the mod by manually inserting the code, am I missing something?  Somehow the database fields need to be created.  I am getting this error:

Table 'sid0908711353209.smf_bookmarks' doesn't exist
File: /home/content/*/*/*/*****/html/forums/Sources/Bookmarks.php
Line: 153

What did I miss?

Also, is there a way to make it so the SMF Installer would not check the file version or can we make it so the package is not set to a specific version of 2.0 so it will install on RC2?

Thanks,

RGecy
Title: Re: Bookmarks
Post by: Arantor on February 09, 2010, 04:27:37 PM
You didn't run the install script - it's a PHP file inside the mod package. Find the one for your SMF version, IIRC you put it into the folder where SSI.php and just browse to it (though its been a while)
Title: Re: Bookmarks
Post by: rgecy on February 09, 2010, 04:56:16 PM
Ok, Now I am getting this error.  I had tried this last night and got the same thing.

Fatal error: Function name must be a string in /home/content/*/*/*/*****/html/forums/install.php on line 4

This is the code in the Install.php.

<?php
global $smcFunc;

$smcFunc['db_create_table']('bookmarks',
array(
array(
'name' => 'id_member',
'type' => 'mediumint',
'size' => 8,
),
array(
'name' => 'id_topic',
'type' => 'mediumint',
'size' => 8,
),
),
array(
array(
'name' => 'bookmark',
'type' => 'unique',
'columns' => array('id_member''id_topic'),
),
),
array(),
'ignore');
?>




Robert
Title: Re: Bookmarks
Post by: searchgr on February 10, 2010, 02:41:42 AM
It;s a pity that this mod has not been updated yet.
Title: Re: Bookmarks
Post by: Arantor on February 10, 2010, 04:15:21 AM
rgecy: Argh.

Code (find) Select
global $smcFunc;

Code (add before it) Select
require('SSI.php');

searchgr: The author is busy trying to work on SMF itself... which would you rather have, SMF 2.0 RC3 get a bit closer to release, or this mod updated for RC2?
Title: Re: Bookmarks
Post by: rgecy on February 10, 2010, 10:47:41 AM
Arantor,

I got the same error, just now on Line 5 of the code!

Robert
Title: Re: Bookmarks
Post by: Arantor on February 10, 2010, 01:36:28 PM
So what's line 5 of the code now?
Title: Re: Bookmarks
Post by: rgecy on February 10, 2010, 06:19:23 PM
Same as above, it just moved down one line when I inserted the code!

$smcFunc['db_create_table']('bookmarks',
Title: Re: Bookmarks
Post by: Arantor on February 10, 2010, 06:24:25 PM
So you included the require statement?

OK, I forgot something.

After require('SSI.php');, add:
dbextend('packages');
Title: Re: Bookmarks
Post by: rgecy on February 10, 2010, 08:47:54 PM
Ok, I am missing something here.  I have copied the install.php to the /forums dir where the SSI.php is.  I made the modifications you said, but I am still getting an error.

QuoteFatal error: Call to undefined function dbextend() in /home/content/r/g/e/rgecy1/html/forums/install.php on line 3

Quote<?php
require('SSI.php');
dbextend('packages');
global $smcFunc;

$smcFunc['db_create_table']('bookmarks',
   array(
      array(
         'name' => 'id_member',
         'type' => 'mediumint',
         'size' => 8,
      ),
      array(
         'name' => 'id_topic',
         'type' => 'mediumint',
         'size' => 8,
      ),      
   ),
   array(
      array(
         'name' => 'bookmark',
         'type' => 'unique',
         'columns' => array('id_member', 'id_topic'),
      ),
   ),
   array(),
   'ignore');
?>

What am I missing? 

I really like this mod and a lot of my users have requested it.  Is there a way to just change the installer package to accept 2.0 RC2 or just ignor it.  The code will work from what I have seen.  All the edits were correct.

Robert
Title: Re: Bookmarks
Post by: Arantor on February 11, 2010, 02:21:15 AM
(Please use the code tag, not quote tag, when posting code, please)

That's because I'm running on far too little sleep and didn't treble check things.

<?php
require('SSI.php');
db_extend('packages');
global 
$smcFunc;

$smcFunc['db_create_table']('{db_prefix}bookmarks',
array(
array(
'name' => 'id_member',
'type' => 'mediumint',
'size' => 8,
),
array(
'name' => 'id_topic',
'type' => 'mediumint',
'size' => 8,
),
),
array(
array(
'name' => 'bookmark',
'type' => 'unique',
'columns' => array('id_member''id_topic'),
),
),
array(),
'ignore');
?>


You cannot use the Advanced option in the package manager to override the version check for mods like this.
Title: Re: Bookmarks
Post by: kicky on February 11, 2010, 04:56:04 AM
Great Mod

I Installed it in my SMF 1.1.11
And work properly

Thanks
Title: Re: Bookmarks
Post by: searchgr on February 11, 2010, 08:37:08 AM
Quote from: Arantor on February 10, 2010, 04:15:21 AM
searchgr: The author is busy trying to work on SMF itself... which would you rather have, SMF 2.0 RC3 get a bit closer to release, or this mod updated for RC2?

I want to install it on smf 2.0 rc2
Title: Re: Bookmarks
Post by: Arantor on February 11, 2010, 08:38:33 AM
So you'd rather delay RC3 then?
Title: Re: Bookmarks
Post by: searchgr on February 11, 2010, 08:44:40 AM
yes
Title: Re: Bookmarks
Post by: Arantor on February 11, 2010, 08:48:40 AM
Great, so let me get this straight: you want to pull one of the remaining SMF team (developers, I might add) off working on RC3 which has hundreds of bug fixes and HOLDS EVERYONE ELSE UP, just because you won't follow the instructions in the last page on how to add the mod for RC2? Gee, I hope no-one else agrees with you. I'd much rather have RC3.

Do the parser for 2.0b4, and replace the 2.0 installer with the one I outline in http://www.simplemachines.org/community/index.php?topic=182923.msg2496503#msg2496503
Title: Re: Bookmarks
Post by: searchgr on February 11, 2010, 08:56:30 AM
ok, i can wait... i'm not in a hurry
Title: Re: Bookmarks
Post by: Eclipse16V on March 15, 2010, 01:48:39 AM
Nice Mod

Please update it for SMF 2.0RC3  ;)

Thanks
Title: Re: Bookmarks
Post by: jsamples on March 16, 2010, 01:39:31 AM

The problem I have is that I have is that I had the "Failed" warning with default/index.template.php, so I tried to install manually only to find this file did not have a string "if (in_array($context['current_action'], array('search'," anywhere inside. In fact the file did not even have a string of "search" anywhere in it.

For the most part I am up to date with ver 1.1.11, and I originally came here looking for a fix, but when I just now looked at the version of the "index.template" it said merely 1.1.  So I am now perplexed as to why the file was not updated in the first place to later versions, as well as why is it that I am missing the basic peices to apply your mod.   So, I guess this is just a heads up to you that your mod will not work if the Index.Template is v1.1.

Thanks for the mod anyways... :-)


Title: Re: Bookmarks
Post by: Bugo on March 21, 2010, 06:12:43 AM
It is updated mod, compatible with SMF 2.0 RC3 (added russian translation)


moderator note: Attachment has not been validated by the mod team, nor approved by the mod author. It has been removed pending review.
Title: Re: Bookmarks
Post by: Eclipse16V on March 21, 2010, 06:32:06 AM
Thanks Bugo

Here the edit German UTF8
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst Du mit \'Lesezeichen hinzufügen\' in den einzelnen Themen machen.';
$txt['bookmark_open_window'] = 'In neuem Fenster öffnen';
$txt['bookmark_delete'] = 'Lesezeichen löschen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurde(n) erfolgreich gelöscht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gelöscht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzufügen';
$txt['bookmark_add_success'] = 'Thema erfolgreich zu Deinen Lesezeichen hinzugefügt!';
$txt['bookmark_add_exists'] = 'Dieses Thema befindet sich bereits in Deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim hinzufügen des Themas zu Deinen Lesezeichen aufgetreten!';
$txt['permissionname_make_bookmarks'] = 'Lesezeichen speichern';
$txt['cannot_make_bookmarks'] = 'Sorry, aber Du hast keine Berechtigung Lesezeichen zu speichern.';
Title: Re: Bookmarks
Post by: Eclipse16V on March 21, 2010, 12:18:04 PM
i`ve been update the template

look at the attachments
Title: Re: Bookmarks
Post by: kizer on March 22, 2010, 06:29:14 PM
Quote from: Bugo on March 21, 2010, 06:12:43 AM
It is updated mod, compatible with SMF 2.0 RC3 (added russian translation)

Thank you for your effort and covering the author un-offically. ;)
Works great.
Title: Re: Bookmarks
Post by: Kindred on March 22, 2010, 06:37:37 PM
Buggo,

1- please do not release mods which are currently owned by someone else
2- do not release mods as attachments in the thread. Only mods submitted to the mod site are validated  by the team. Attachments may contain poorly coded updates or malicious coding.

Pending approval by Aaron, I have removed your attachments
Title: Re: Bookmarks
Post by: Arantor on March 23, 2010, 03:40:46 AM
Bugo:
1. Kindred is incredibly busy trying to sort out the mess. I'm surprised he bothers to drop into the forum at all to be honest.

2. He personally hasn't insulted anybody.

3. I appreciate the effort you've put in to updating mods but strictly speaking he is correct; unless the author says they are happy for mods to be updated, any mod in a thread is at best unofficial, it can pose a security risk, and is of questionable legality because you are modifying a file that you do not hold the copyright on (especially since unless explicitly stated otherwise, mods fall pretty much into the SMF licence which says no redistribution except from original source)

4. Aaron, the mod's author, has not had time to update this officially for RC2 let alone RC3 because he's been busy working on SMF itself.
Title: Re: Bookmarks
Post by: Kindred on March 23, 2010, 09:07:08 AM
sorry about the name... one g becomes two gs easily when you are typing fast. :P

Arantor has said the rest.
Title: Re: Bookmarks
Post by: TurtleKicker on March 23, 2010, 10:04:05 AM
If this is the new policy a ton of unofficial updates for long-abandoned mods are going to get blacklisted and a ton of people who have become dependent on said unofficial updates are going to get very upset.

Considering how SMF mods need to be updated for every minor update/beta/RC/etc, and how many important and useful mods have been abandoned with no continuity established, it has been a long-standing tradition on these forums for other people to step up to the plate and post unofficial updates that contain the necessary fixes to make these mods continue to work with the latest SMF releases. I've lost track of how many dozens I've seen continue that way for months or even a year or more. It's gone on for so long with so many mods that I got the impression that it was "accepted" as a necessary consequence of SMF's license (or, lack of user-friend mod license) and SMF's version-dependent mod system.

I'd mention their names but now I fear for their safety.
Title: Re: Bookmarks
Post by: Arantor on March 23, 2010, 10:24:45 AM
Actually, this is nothing new. Several mod authors do already ask for this anyway.

But actually mods don't always need to be updated for every minor update. Most of mine required little or no change going from 1.1.10 to 1.1.11 and with 80% of my mods I could have actually avoided doing anything at all by setting the version ahead of time, just I'm not that trusting.

It is perfectly OK - and always has been - to publish notes on making it compatible. Repackaging is borderline, depends on the author. I'd be offended if someone repackaged a mod of mine without asking me first. The key word is permission - if you have people who are long since gone, odds are they don't care.

But if they're still active, it would be prudent to ask first.
Title: Re: Bookmarks
Post by: Kindred on March 23, 2010, 11:11:49 AM
this is getting off topic, but to address the issue

As Arantor says, this is nothing new. This has ALWAYS been the policy.
If a mod author has not been active in a long time, then a user may send a message to the customization team asking if the mod qualifies as "abandoned" and may be given permission to re-publish. Sometimes, the authors will specifically state that they have given up support of the mod: in which case there are two scenarios 1- the author gives up support but does not grant permission to continue. In this case, the mod will eventually be taken down from the site or 2) as in that case of my two mods, the author posts that anyone who is interested should step forward and be given permission to take it over.
Title: Re: Bookmarks
Post by: Prosoi on March 23, 2010, 11:29:51 PM
Thanks! Mod works on my SMF2.0 RC2 and RC3. I've just edited Subs/Display.php manually and language/Modifications.russian-utf8.php

$txt['bookmarks'] = 'Закладки';
$txt['bookmark_list'] = 'Закладки';
$txt['bookmark_list_empty'] = 'У Вас ещё нет закладок. Добавить закладки можно нажав на ссылку "Добавить закладку" внутри топиков.';
$txt['bookmark_open_window'] = 'Открыть в новом окне';
$txt['bookmark_delete'] = 'Удалить выделенные';
$txt['bookmark_delete_success'] = 'Было удалено закладок: %1$s!';
$txt['bookmark_delete_failure'] = 'Не все закладки удалились.';
$txt['bookmark_add'] = 'Добавить закладку';
$txt['bookmark_add_success'] = 'Топик был успешно добавлен в Ваши закладки!';
$txt['bookmark_add_exists'] = 'Этот топик уже есть в Ваших закладках!';
$txt['bookmark_add_failed'] = 'При добавлении закладки произошла ошибка.';
$txt['permissionname_make_bookmarks'] = 'Создавать закладки для топиков';
$txt['cannot_make_bookmarks'] = 'Извините, у Вас нет разрешения добавлять закладки.';
Title: Re: Bookmarks
Post by: Eddy Matthews on March 26, 2010, 06:54:10 AM
Would it be possible to modify this mod so it bookmarks individual messages OR entire topics? It would be much more useful if it could be done?

Regards
Eddy
Title: Re: Bookmarks
Post by: Bugo on March 26, 2010, 12:27:38 PM
Please update mod => translations for UTF8
Title: Re: Bookmarks
Post by: ●[¤«HuGo»¤]● on March 27, 2010, 12:57:43 AM
Best translation in Spanish :)


$txt['bookmarks'] = 'Mis Favoritos';
$txt['bookmark_list'] = 'Favoritos';
$txt['bookmark_list_empty'] = 'No tienes ningun favorito en el momento. Agregalos haciendo click en el boton \'Agregar Favorito\' en la parte superior de los mensajes, justo al lado del boton de Responder.';
$txt['bookmark_open_window'] = 'Abrir en una ventana nueva';
$txt['bookmark_delete'] = 'Borrar favoritos seleccionados';
$txt['bookmark_delete_success'] = '%1$s Favoritos fueron borrados exitosamente!';
$txt['bookmark_delete_failure'] = 'No todos los favoritos pudieron borrarse.';
$txt['bookmark_add'] = 'Agregar Favorito';
$txt['bookmark_add_success'] = 'El mensaje fue agregado exitosamente a tus favoritos!';
$txt['bookmark_add_exists'] = 'Este mensaje ya ha sido agregado a tus favoritos!';
$txt['bookmark_add_failed'] = 'Error al intentar agregar el mensaje a tus favoritos.';
// Untranslated!
$txt['permissionname_make_bookmarks'] = 'Crear marcadores para temas';
$txt['cannot_make_bookmarks'] = 'Lo sentimos, no tiene permiso para agregar favoritos.';
Title: Re: Bookmarks
Post by: jdvarner on April 01, 2010, 07:29:01 AM
for me when i install it on smf 1.1.11 it goes to a blank screen after i click apply mod.
Title: Re: Bookmarks
Post by: Hoodie on April 03, 2010, 08:30:48 PM
Quote from: jdvarner on April 01, 2010, 07:29:01 AM
for me when i install it on smf 1.1.11 it goes to a blank screen after i click apply mod.

That's exactly what I'm getting and don't know what's wrong with the install file..  Here's the errors I'm getting:

256: parse_path(): There should never be an empty filename
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 1116


1024: Undefined XML attribute: destination from /home/automot5/public_html/test/Sources/Subs-Package.php on line 874
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 2355


1024: Undefined XML attribute: name from /home/automot5/public_html/test/Sources/Subs-Package.php on line 868
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 2355
Title: Re: Bookmarks
Post by: noelksmall on April 05, 2010, 03:29:03 PM
I've downloaded this mod and installed it successfully, i can see the bookmarks at the top of the form, but when i go into a topic, i don't see "add bookmark" button, the package manager said it installed ok, im using 2 RC2

any help greatly appreciated!
Title: Re: Bookmarks
Post by: Kindred on April 05, 2010, 03:30:23 PM
did you install it into your custom theme?
Title: Re: Bookmarks
Post by: noelksmall on April 05, 2010, 03:36:55 PM
I installed it into SMF Default Theme - Core

Regards

Noel
Title: Re: Bookmarks
Post by: Eddy Matthews on April 05, 2010, 03:39:51 PM
Quote from: Eddy Matthews on March 26, 2010, 06:54:10 AM
Would it be possible to modify this mod so it bookmarks individual messages OR entire topics? It would be much more useful if it could be done?

Regards
Eddy

Bump!

Can this be done, or am I asking for the impossible?

Regards
Eddy
Title: Re: Bookmarks
Post by: Kindred on April 05, 2010, 04:16:22 PM
since the owner of this mod has withdrawn from the community for health reasons, ther eis unlikely to be any additional features.   Nearly anything *CAN* be done... but what you are asking for requires additional coding... so you would have to find someone who is willing to code it for you.
Title: Re: Bookmarks
Post by: noelksmall on April 05, 2010, 04:30:00 PM
Quote from: Kindred on April 05, 2010, 04:16:22 PM
since the owner of this mod has withdrawn from the community for health reasons, ther eis unlikely to be any additional features.   Nearly anything *CAN* be done... but what you are asking for requires additional coding... so you would have to find someone who is willing to code it for you.

Thank You for your help.

I've modified my Display.Template file and added the code for the button as its working, well fingers crossed so far!

Thanks Again
Title: Re: Bookmarks
Post by: LondonDragon on April 13, 2010, 07:25:28 AM
Great mod guys,

Anyway I can remove the "My Bookmarks" icon from the main menu and place is in the menu of the users profile instead?

Already have way too many icons on the forum as it stands, thanks
Title: Re: Bookmarks
Post by: Arantor on April 13, 2010, 07:26:53 AM
Not without a substantial reworking of the mod.
Title: Re: Bookmarks
Post by: LondonDragon on April 13, 2010, 07:31:39 AM
Quote from: Arantor on April 13, 2010, 07:26:53 AM
Not without a substantial reworking of the mod.
Thanks for that, how about moving the link from the menu to the user Control Panel just below "Hello Nickname"?
Title: Re: Bookmarks
Post by: Kindred on April 13, 2010, 08:43:27 AM
Quote from: Arantor on April 13, 2010, 07:26:53 AM
Not without a substantial reworking of the mod.


What I did is, I used the UserCP mod and added the bookmark link as one of the four manually added items
Title: Re: Bookmarks
Post by: searchgr on April 13, 2010, 08:51:13 AM
correct, this is the best solution Kindred :)
Title: Re: Bookmarks
Post by: LondonDragon on April 13, 2010, 09:08:17 AM
Quote from: Kindred on April 13, 2010, 08:43:27 AM
What I did is, I used the UserCP mod and added the bookmark link as one of the four manually added items
Just had a quick search and could not find the "UserCP mod" could you provide a link, thanks
Title: Re: Bookmarks
Post by: Kindred on April 13, 2010, 10:29:56 AM
http://custom.simplemachines.org/mods/index.php?mod=698
Title: Re: Bookmarks
Post by: Scratching my Head on April 16, 2010, 12:31:53 AM
You guys ever work this out, because I'm getting the same thing.

Quote from: Hoodie on April 03, 2010, 08:30:48 PM
Quote from: jdvarner on April 01, 2010, 07:29:01 AM
for me when i install it on smf 1.1.11 it goes to a blank screen after i click apply mod.

That's exactly what I'm getting and don't know what's wrong with the install file..  Here's the errors I'm getting:

256: parse_path(): There should never be an empty filename
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 1116


1024: Undefined XML attribute: destination from /home/automot5/public_html/test/Sources/Subs-Package.php on line 874
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 2355


1024: Undefined XML attribute: name from /home/automot5/public_html/test/Sources/Subs-Package.php on line 868
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 2355

Title: Re: Bookmarks
Post by: sbt on May 10, 2010, 05:36:38 PM
This is a great mod, we got it installed and working correct on 2.0 RC3 except for the fact that it keeps the add bookmark button and then the message  The topic was successfully added to your bookmarks! every time for same topic. There are no errors in the logs, and we are using our own themes based on the 2.0 RC3 core theme.
On our test forum with same specs as this one, it works wonderful by removing the add button after bookmarking.
Every file has added all correct edits, and we tried copying the bookmarks.template.php to every themes folder.

Any ideas please?
Title: Re: Bookmarks
Post by: Sakae on May 12, 2010, 10:36:49 PM
Awesome MOD.

Translation for portuguese_brazilian-utf8:

$txt['bookmarks'] = 'Meus favoritos';
$txt['bookmark_list'] = 'Favoritos';
$txt['bookmark_list_empty'] = 'Voc&ecirc; n&atilde;o tem nenhum t&oacute;pico favorito.';
$txt['bookmark_open_window'] = 'Abrir em nova janela';
$txt['bookmark_delete'] = 'Deletar favoritos selecionados';
$txt['bookmark_delete_success'] = '%1$ favoritos foram apagados!';
$txt['bookmark_delete_failure'] = 'Nenhum favorito foi apagado.';
$txt['bookmark_add'] = 'Favoritar';
$txt['bookmark_add_success'] = 'T&oacute;pico adicionado aos seus favoritos!';
$txt['bookmark_add_exists'] = 'Este t&oacute;pico j&aacute; faz parte dos seus favoritos!';
$txt['bookmark_add_failed'] = 'Falha! Contate o administrador.';
$txt['permissionname_make_bookmarks'] = 'Favoritar t&oacute;picos';
$txt['cannot_make_bookmarks'] = 'Voc&ecirc; n&atilde;o tem acesso a esta fun&ccedil;&atilde;o.';

Title: Re: Bookmarks
Post by: FragaCampos on July 07, 2010, 10:51:29 AM
Quote from: Scratching my Head on April 16, 2010, 12:31:53 AM
You guys ever work this out, because I'm getting the same thing.

Quote from: Hoodie on April 03, 2010, 08:30:48 PM
Quote from: jdvarner on April 01, 2010, 07:29:01 AM
for me when i install it on smf 1.1.11 it goes to a blank screen after i click apply mod.

That's exactly what I'm getting and don't know what's wrong with the install file..  Here's the errors I'm getting:

256: parse_path(): There should never be an empty filename
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 1116


1024: Undefined XML attribute: destination from /home/automot5/public_html/test/Sources/Subs-Package.php on line 874
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 2355


1024: Undefined XML attribute: name from /home/automot5/public_html/test/Sources/Subs-Package.php on line 868
File: /home/*****/public_html/test/Sources/Subs-Package.php
Line: 2355


Yup... same error here with SMF 1.1.11 :(
Title: Re: Bookmarks
Post by: IlliniCrusader on July 19, 2010, 03:49:19 PM
Quote from: noelksmall on April 05, 2010, 03:29:03 PM
I've downloaded this mod and installed it successfully, i can see the bookmarks at the top of the form, but when i go into a topic, i don't see "add bookmark" button, the package manager said it installed ok, im using 2 RC2

any help greatly appreciated!

Same here.  The mod seems to install correctly - I see the "My Bookmarks" in my menu.  But, there isn't a button to actually add anything to "My Bookmarks." 

Anyone have any ideas or a solution?

Thanks a lot.
Title: Re: Bookmarks
Post by: searchgr on July 19, 2010, 03:56:22 PM
check the permissions of your membergroups
Title: Re: Bookmarks
Post by: Kindred on July 19, 2010, 04:39:03 PM
more likely... check the custom theme that you are probably using and make the modifications manually to display.template.php
Title: Re: Bookmarks
Post by: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything).  Couldn't figure this one out, so I proceeded with the manual install instead, which wasn't hard.

However, I'm now getting hung up on the database operations:

Through phpMyAdmin, I attempted to run the following query string as instructed:

CREATE TABLE IF NOT EXISTS {$db_prefix}bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT NULL,
`ID_TOPIC` mediumint(8) unsigned NOT NULL,
UNIQUE KEY `ID_MEMBER` (`ID_MEMBER`,`ID_TOPIC`)
)


But I'm getting the following error:

MySQL said:
#1064 - You have an error in your SQL syntax.  Check the manual that corresponds to your MySQL server version for the right syntax to use near '{$db_prefix}bookmarks
(
`ID_MEMBER` mediumint(8) unsigned NOT


I'm using phpMyAdmin v. 2.11.1 and I'm working with a MySQL4 database, if those factors make any difference (I suspect that at least the MySQL version does).

Any help would be greatly appreciated!!

Thank you,
Marc Berman
www.rageacrossthecape.com/forums
Title: Re: Bookmarks
Post by: Kindred on July 25, 2010, 10:42:38 PM
you need to change
{$db_prefix}bookmarks
to use the ACTUAL db prefix that your database is set to use...

i.e. smf_bookmarks
Title: Re: Bookmarks
Post by: marcberm on July 25, 2010, 11:00:47 PM
Thanks!

I'm an idiot, and should really have been able to figure that one out on my own before posting :)

Quote from: Kindred on July 25, 2010, 10:42:38 PM
you need to change
{$db_prefix}bookmarks
to use the ACTUAL db prefix that your database is set to use...

i.e. smf_bookmarks
Title: Re: Bookmarks
Post by: KensonPlays on July 26, 2010, 12:14:17 AM
even if this is a paid new feature, if you could add the ability to lets say "google bookmark" type thing, with a bookmarklet that would be awesome!
Title: Re: Bookmarks
Post by: Kindred on July 26, 2010, 01:59:51 AM
???  google bookmark?  This feature creates a list of bookmarks stored in the DB for a user, there is no external interface with any outside source.

Also, I do not think that Aaron is doing any development on this any more... (could be wrong, though)
Title: Re: Bookmarks
Post by: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>
Title: Re: Bookmarks
Post by: coolfx350 on October 18, 2010, 09:49:52 AM
I got a blank screen as well when I tried to install this package.

Same package was working fine in the past, not sure what changed.
Title: Re: Bookmarks
Post by: busterone on October 18, 2010, 06:18:41 PM
What version are you using and what mods are installed?
I have it installed on a heavily modified 2.0 RC3 with no issues. I just tried it on a fresh install 2.0 RC3, it installed with no errors.
There is a conflict in your existing installation somewhere.
Title: Re: Bookmarks
Post by: FragaCampos on October 20, 2010, 07:27:28 AM
DarioBros gave the answer 4 messages before...
Title: Re: Bookmarks
Post by: coolfx350 on October 29, 2010, 11:19:34 AM

this doesn't work for me, any other ideas, after i changed, i zip them up again, but it's telling me files are corrupted.

Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>
Title: Re: Bookmarks
Post by: DarioBros on October 30, 2010, 08:58:08 PM
Quote from: petecheng on October 29, 2010, 11:19:34 AM

this doesn't work for me, any other ideas, after i changed, i zip them up again, but it's telling me files are corrupted.

Maybe it's a problem of the program that you use to zip/unzip: try winrar.
And make sure that the position of files in the new archive is the same than the old one: the modified file must be in the root of the archive, and not contained in a folder.
Title: Re: Bookmarks
Post by: whoey on November 05, 2010, 12:24:41 PM
to make 2.0 RC4 compatible:

edit package-info.xml on line 9 replace with:
<install for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC2, 2.0 RC3, 2.0 RC4">
Line 25 replace with:
<uninstall for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC2, 2.0 RC3, 2.0 RC4">
(all we're doing is making the mod be accepted by rc4)

In bookmarks20.xml replace lines 100 & 108 with:
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true),]]></search>
(this is taken from the default theme, I showed an error here even though it was ignored, so maybe the format or syntax changed a bit)

that fixed it all for me, seems to work just fine.
Title: Re: Bookmarks
Post by: Melissa524 on November 05, 2010, 01:28:02 PM
Is there anyway that we can get it packaged to work for rc4?  I am a bit code stupid when it comes to these things.
Title: Re: Bookmarks
Post by: Kindred on November 05, 2010, 01:34:04 PM
in RC4, there is an option in the package manager to "emulate" a different version.....   pick RC3
Title: Re: Bookmarks
Post by: busterone on November 05, 2010, 05:12:33 PM
Confirmed that emulation works. There is no code change needed for the mod itself.
Title: Re: Bookmarks
Post by: Nuks on November 05, 2010, 07:59:29 PM
Updated code to avoid use of emulation, i also added french-utf8 translation.
Title: Re: Bookmarks
Post by: Kindred on November 05, 2010, 08:34:22 PM
sorry... standard mod authorship rights do not allow others to modify or distribute other people's mods
Title: Re: Bookmarks
Post by: Nuks on November 05, 2010, 09:45:55 PM
Whoops. Sorry, didn't know that !
Title: Re: Bookmarks
Post by: whoey on November 08, 2010, 08:23:48 AM
that's why I offered the fixes, and not the files :D
Title: Re: Bookmarks
Post by: panicattack on November 26, 2010, 06:45:53 PM
Using 1.1.12 SFW.

Only Administrators are seeing the bookmark button.  Regular members are unable to see them.  Is there a setting that I am missing?

Thanks!
Title: Re: Bookmarks
Post by: Illori on November 26, 2010, 07:10:53 PM
you need to enable the permission for each group.
Title: Re: Bookmarks
Post by: Jayne Louise on December 10, 2010, 08:17:40 PM
Quote from: noelksmall on April 05, 2010, 03:29:03 PM
I've downloaded this mod and installed it successfully, i can see the bookmarks at the top of the form, but when i go into a topic, i don't see "add bookmark" button, the package manager said it installed ok, im using 2 RC2

Quote from: noelksmall on April 05, 2010, 04:30:00 PM
I've modified my Display.Template file and added the code for the button as its working, well fingers crossed so far!

Having the same problem here with RC4; there is no Add Bookmark button. Permissions are fine. What do I need to put into the display template for the add bookmark button to appear?

Thanks.
Title: Re: Bookmarks
Post by: Illori on December 11, 2010, 06:18:24 AM
<file name="$themedir/Display.template.php">
<!-- Add a button for making bookmarks, Curve style. Optional. -->
<operation error="ignore">
<search position="before"><![CDATA[
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';num_replies=' . $context['num_replies'], 'active' => true),]]></search>
<add><![CDATA[
'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']),]]></add>
</operation>
Title: Re: Bookmarks
Post by: Jayne Louise on December 11, 2010, 09:03:01 AM
Many thanks Illori, that seems to be working perfectly now :)
Title: Re: Bookmarks
Post by: sharks on December 23, 2010, 04:17:33 AM
Hi guys

First, i want to say that this is an excellent idea for a mod and i plan to use it as soon as possible.

I uploaded the latest package for my SMF 1.1.11 and SMF 1.1.12 installations, but after clicking on the [Apply Mod] button, i see a blank page for both installations. Did the package get corrupted? Other mods installed fine, so i suppose that this mod was badly packaged?
Title: Re: Bookmarks
Post by: Illori on December 23, 2010, 05:55:17 AM
Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>
Title: Re: Bookmarks
Post by: sharks on December 23, 2010, 11:44:54 AM
Thanks for the help, Illori. :) Tested and works!

I have attached the fixed package to my reply for all those who like this modification. Please encourage its development! ;)



(admin edit - attachment removed, see explanation below)
Title: Re: Bookmarks
Post by: Illori on December 23, 2010, 12:36:02 PM
please remove the attachment.

Quote from: Kindred on November 05, 2010, 08:34:22 PM
sorry... standard mod authorship rights do not allow others to modify or distribute other people's mods
Title: Re: Bookmarks
Post by: sharks on December 24, 2010, 09:43:07 AM
Illorim, what you're saying doesn't make any sense. I've just fixed it so others won't have trouble installing it. I have made no changes other than that. Also, the creator of this mod is offline since November 20, 2010 and like so many other mods, this mod has most probably been abandoned as well, which is becoming clearer now... why nobody else is picking up abandoned mods because of your "fantastic" rule. Ah ha! :D
Title: Re: Bookmarks
Post by: Illori on December 24, 2010, 10:25:01 AM
it is not allowed to post attachments of mods with any changes done to them without authors permission which we do not have. also 1 month off line is not much time compared to some mod authors.
Title: Re: Bookmarks
Post by: Kindred on December 24, 2010, 11:41:38 AM
it's not Illori's rule.... it is actually SM's rule.

Mods are owned by the mod author. Unless that author has specified an open license, the mod is not allowed to be distributed by anyone else. In addition, attaching mods in a thread means that they bypass the normal checks and balances (i.e. they are not checked by the cust team, you can not report them as unsafe, etc)

So, as a general rule....  users are not allowed to post their revisions to the mod as an attachment. You can post your changes in code tags in a message, but not as a full-blown install package/attachment.

I've said this in MANY other threads as well.
Title: Re: Bookmarks
Post by: samurai-lupin on December 28, 2010, 03:25:09 AM
Quote from: Kindred on December 24, 2010, 11:41:38 AM
it's not Illori's rule.... it is actually SM's rule.

Mods are owned by the mod author. Unless that author has specified an open license, the mod is not allowed to be distributed by anyone else. In addition, attaching mods in a thread means that they bypass the normal checks and balances (i.e. they are not checked by the cust team, you can not report them as unsafe, etc)

So, as a general rule....  users are not allowed to post their revisions to the mod as an attachment. You can post your changes in code tags in a message, but not as a full-blown install package/attachment.

I've said this in MANY other threads as well.

This is very silly and why I nowadays regret having choosen SMF many years ago ...

I see abandoned and not working mods all over the place and if some great guy wishes to help he gets kicked in the teeth ...
Title: Re: Bookmarks
Post by: Arantor on January 07, 2011, 07:46:56 PM
QuoteI see abandoned and not working mods all over the place and if some great guy wishes to help he gets kicked in the teeth ...

It's actually the law. Mods written by someone are legally copyrighted to that person and unless they give permission, the works cannot legally be modified or redistributed. Only the instructions to change them (as Kindred says) can.
Title: Re: Bookmarks
Post by: sharks on January 15, 2011, 03:41:44 AM
Quote from: Arantor on January 07, 2011, 07:46:56 PM
It's actually the law. Mods written by someone are legally copyrighted to that person and unless they give permission, the works cannot legally be modified or redistributed. Only the instructions to change them (as Kindred says) can.

But what if the author of the mod is offline for a long time and might never return, or has been deleted and is now showing as Guest user?
Title: Re: Bookmarks
Post by: Arantor on January 15, 2011, 06:48:45 AM
Doesn't matter. Under the terms of countries following the Berne Convention, which includes the US where the servers here are located (and thus the team are kind of bound to uphold them!), copyright is assigned at the moment of creation, so the moment code is written it's copyrighted. And unless there is something explicitly granting the right of takeover, such as a licence document, no takeover can be done in any form without the permission of the author.

This is why, for example, SlammedDime recently listed all his mods as under the Mozilla Public Licence, so that if he's not available, someone else can take over and modify/update the mods or branch off and make derived works. The law doesn't grant such rights but the licence applied to the works *does*.

Just because an author is absent doesn't prevent the work being copyrighted, though in some territories there are grounds for transferral in absentia, but unless you have someone who knows the laws in all related areas (original author's country/state, the states where SMF is based, which includes Arizona, Nevada and wherever the servers are, and the subsequent author's country/state) and can give a qualified legal opinion, it's safer just to not do so.
Title: Re: Bookmarks
Post by: ret on January 17, 2011, 12:47:25 AM
I can uninstall and reinstall v1.0.1 of this mod with no issues, but cannot get this updated version to work. Either:

1. blank screen as per other respondents above, or
2. after making the database => code change, the zip-file refuses to install at all, with "The package you tried to upload either is not a valid package or has become corrupted."

I've edited the file with vim, and I'm pretty confident I haven't broken it by changing line-endings etc.
Title: Re: Bookmarks
Post by: Jessica. on January 20, 2011, 03:39:42 PM
when I clicked on Apply Mod (using 1.1.12) I get a blank page......
Title: Re: Bookmarks
Post by: TeaTephi on January 21, 2011, 01:09:31 PM
Ok I read through this last page here and tried editing the "package-info.xml", as suggested.  It doesn't work for SMF 2.0 RC4.  Still get "....this package is corrupted...."

Title: Re: Bookmarks
Post by: antoniosaucedo on February 09, 2011, 09:46:39 PM
Quote from: Jessica C on January 20, 2011, 03:39:42 PM
when I clicked on Apply Mod (using 1.1.12) I get a blank page......

Hi, I have the same ... a blank page.   Tried on 09 feb 11
Title: Re: Bookmarks
Post by: SeaChaser on February 12, 2011, 03:51:58 PM
I got the white page of death on this mod using 1.1.13 (sames result before using 1.1.12) so I tried DarioBros fix tto the xml file and got this error:

1. Execute Modification ./index.php Test successful
2. Execute Modification ./Sources/Display.php Test successful
3. Execute Modification ./Sources/ManagePermissions.php Test successful
4. Execute Modification ./Sources/RemoveTopic.php Test successful
5. Execute Modification ./Themes/default/index.template.php Test failed
6. Execute Modification ./Themes/default/Display.template.php Test successful
7. Execute Modification ./Themes/default/languages/Modifications.dutch.php Skipping file
8. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
9. Execute Modification ./Themes/default/languages/Modifications.swedish.php Skipping file
10. Execute Modification ./Themes/default/languages/Modifications.german.php Skipping file
11. Execute Modification ./Themes/default/languages/Modifications.turkish.php Skipping file
12. Execute Modification ./Themes/default/languages/Modifications.serbian.php Skipping file
13. Execute Modification ./Themes/default/languages/Modifications.spanish.php Skipping file
14. Execute Modification ./Themes/default/languages/Modifications.russian.php Skipping file
15. Extract File ./Sources/Bookmarks.php 
16. Extract File ./Themes/default/Bookmarks.template.php 
17. Execute Code smf11/install.php


Any help would be appreciated.
Title: Re: Bookmarks
Post by: Kindred on February 12, 2011, 04:23:53 PM
http://wiki.simplemachines.org/smf/Error_in_mod_installation
Title: Re: Bookmarks
Post by: SeaChaser on February 12, 2011, 05:13:43 PM
Thanks!

That led me through how to address the situation. I guess that 1.1.12 doesn't have the edit button does it?
Title: Re: Bookmarks
Post by: Kindred on February 12, 2011, 05:17:32 PM
ah... no.   Use the package parser and find the edits
Title: Re: Bookmarks
Post by: harmoni on February 25, 2011, 08:07:40 AM
I am using SMF 1.1.6. Have uploaded this mod then applied it. The browser status bar message indicate Done but nothing happen. It only brings to this url http://www.harmoni-my.org/forum/index.php?action=packages;sa=install;package=bookmarks23.zip
I have repeated the process of deleting the mod and reinstaling..still the same.. No joy.  Below are some mods installed on my forum..

1.    Minimum Characters/Words Per Post    1.0.0    [ Uninstall ] [ List Files ] [ Delete ]
2.    Welcome Topic Mod    2.1    [ Apply Mod ] [ List Files ] [ Delete ]
3.    Colorized Membergroups    1.0    [ Uninstall ] [ List Files ] [ Delete ]
4.    Simple Theme Changer    1.0.2    [ Apply Mod ] [ List Files ] [ Delete ]
5.    Save PM as HTML    1.0.6    [ Uninstall ] [ List Files ] [ Delete ]
6.    SMF 1.0.11 / 1.1.3 Update    1.1    [ List Files ] [ Delete ]
7.    Activity_Bar    1.0.1.2    [ Apply Mod ] [ List Files ] [ Delete ]
8.    Karma Buttons    1.1    [ Uninstall ] [ List Files ] [ Delete ]
9.    SMF 1.0.13 / 1.1.5 / 2.0 b3.1 Update    1.0    [ List Files ] [ Delete ]
10.    Googlebot & Spiders Mod    2.0.4    [ Uninstall ] [ List Files ] [ Delete ]
11.    Custom Board Sort    1.0.1    [ Uninstall ] [ List Files ] [ Delete ]
12.    Global Headers Footers    1.4.1    [ Uninstall ] [ List Files ] [ Delete ]
13.    Users Online Today Mod    1.4.0    [ Uninstall ] [ List Files ] [ Delete ]
14.    delete inactive users    1.0.3    [ Uninstall ] [ List Files ] [ Delete ]
15.    Password Protect Boards    0.2    [ Uninstall ] [ List Files ] [ Delete ]
16.    Previous and Next Links for Page Index    1.0    [ Uninstall ] [ List Files ] [ Delete ]
17.    Hide Info Center From Guests    1.0    [ Uninstall ] [ List Files ] [ Delete ]
18.    SMF 1.0.14 / 1.1.6 Update    1.0    [ Uninstall ] [ List Files ] [ Delete ]
19.    Ad Managment    2.3    [ Uninstall ] [ List Files ] [ Delete ]
20.    Topic starter    1.4    [ Uninstall ] [ List Files ] [ Delete ]
21.    SMF Shoutbox    1.16    [ Uninstall ] [ List Files ] [ Delete ]
22.    TextSizer    1.5    [ Apply Mod ] [ List Files ] [ Delete ]
23.    PM Popup - Uses Active Window    1.4    [ Uninstall ] [ List Files ] [ Delete ]
24.    Expand Pages Mod    1.0    [ Uninstall ] [ List Files ] [ Delete ]
25.    Add Domaintools to TrackIP    1.0    [ Uninstall ] [ List Files ] [ Delete ]
26.    TinyPortal    0.983    [ List Files ] [ Delete ]
27.    SMF 1.0.12 / 1.1.4 / 2.0 b1.1 Update    1.0    [ List Files ] [ Delete ]
28.    Page Number    2.0    [ Uninstall ] [ List Files ] [ Delete ]
29.    Most Popular Topic Today    1.0    [ Uninstall ] [ List Files ] [ Delete ]
30.    Do not enter    1.1    [ Uninstall ] [ List Files ] [ Delete ]
31.    AvatarOnBoard    2.1    [ Uninstall ] [ List Files ] [ Delete ]
32.    SMF 1.0.12 / 1.1.4 / 2.0 b1.1 Update    1.0    [ List Files ] [ Delete ]
33.    SMF Arcade    2.0.16    [ Uninstall ] [ List Files ] [ Delete ]
34.    Images On Board    1.1    [ Uninstall ] [ List Files ] [ Delete ]
35.    Quran Flash    1.5    [ Uninstall ] [ List Files ] [ Delete ]
36.    YouTube BBCode    2.3    [ Uninstall ] [ List Files ] [ Delete ]
37.    Thank You Mod    1.2.1    [ List Files ] [ Delete ]
38.    Member Color Link    2.1.6    [ List Files ] [ Delete ]
39.    Time Logged-In    3.0    [ Uninstall ] [ List Files ] [ Delete ]

Please advice.
Title: Re: Bookmarks
Post by: Illori on February 25, 2011, 08:29:00 AM
please upgrade your forum to 1.1.13, and browse this thread for reasons for that error.
Title: Re: Bookmarks
Post by: Kindred on February 25, 2011, 08:40:39 AM
more specifically,

First:
Update to 1.1.13 ASAP. 1.1.6 has known security issues that have been patched in the 7 versions since then.

second:
You download/upload the mod, and then click installl/apply mod.  You then view the list of installation test results (all tests successful?) and click Install?

Are you using the default theme and the English language? (English utf-8 is different from English)
Title: Re: Bookmarks
Post by: Illori on February 25, 2011, 08:42:41 AM
please read this:

Quote from: Illori on December 23, 2010, 05:55:17 AM
Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>
Title: Re: Bookmarks
Post by: harmoni on February 25, 2011, 10:51:59 AM
Quote from: Illori on February 25, 2011, 08:42:41 AM
please read this:

Quote from: Illori on December 23, 2010, 05:55:17 AM
Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for ....

The same thing happens to me....

Thanks.

I have read and edit the said file. And uploaded the new editted package. Upon clicking apply mod there lies an error on para 3 below.

1.    Execute Modification    ./index.php    Test successful
2.    Execute Modification    ./Sources/Display.php    Test successful
3.    Execute Modification    ./Sources/ManagePermissions.php    Test failed
4.    Execute Modification    ./Sources/RemoveTopic.php    Test successful
5.    Execute Modification    ./Themes/default/index.template.php    Test successful
6.    Execute Modification    ./Themes/default/Display.template.php    Test successful
7.    Execute Modification    ./Themes/default/languages/Modifications.dutch.php    Skipping file
8.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful
9.    Execute Modification    ./Themes/default/languages/Modifications.swedish.php    Skipping file
10.    Execute Modification    ./Themes/default/languages/Modifications.german.php    Skipping file
11.    Execute Modification    ./Themes/default/languages/Modifications.turkish.php    Skipping file
12.    Execute Modification    ./Themes/default/languages/Modifications.serbian.php    Skipping file
13.    Execute Modification    ./Themes/default/languages/Modifications.spanish.php    Test successful
14.    Execute Modification    ./Themes/default/languages/Modifications.russian.php    Skipping file
15.    Extract File    ./Sources/Bookmarks.php    
16.    Extract File    ./Themes/default/Bookmarks.template.php    
17.    Execute Code    smf11/install.php

What should I do next? TQ.
Title: Re: Bookmarks
Post by: Illori on February 25, 2011, 11:16:53 AM
take a look at this Manual Installation of Mods (http://docs.simplemachines.org/index.php?topic=402.0) you will need to manually edit that file.
Title: Re: Bookmarks
Post by: Kindred on February 25, 2011, 11:27:41 AM
new wiki article

http://wiki.simplemachines.org/smf/Error_in_mod_installation
Title: Re: Bookmarks
Post by: harmoni on February 25, 2011, 11:52:03 AM
Quote from: Illori on February 25, 2011, 11:16:53 AM
take a look at this Manual Installation of Mods (http://docs.simplemachines.org/index.php?topic=402.0) you will need to manually edit that file.

Quote from: Kindred on February 25, 2011, 11:27:41 AM
new wiki article

http://wiki.simplemachines.org/smf/Error_in_mod_installation

Editted. Can see the My Bookmarks menu. When I click the My Bookmarks this error appears.

Unknown column 'bm.ID_MEMBER' in 'where clause'
File: /home/harmoni/public_html/forum/Sources/Bookmarks.php
Line: 65

----------------------------------------------------
line 65:        __FILE__, __LINE__);

Title: Re: Bookmarks
Post by: harmoni on February 25, 2011, 11:57:35 AM
1st and foremost...thanks for the quick reply guys.
Title: Re: Bookmarks
Post by: Kindred on February 25, 2011, 12:08:10 PM
looks like the database portion did not run when you installed the mod.

Extract the database file, place it in your forum root (the same directory where SSI.php sits) and then run it (navigate to it in your browser)

--remember to delete that file after the database edits are run
Title: Re: Bookmarks
Post by: harmoni on February 25, 2011, 12:18:15 PM
Have copied as instructed...again err.

Fatal error: Call to undefined function db_query() in /home/harmoni/public_html/forum/install.php on line 2
Title: Re: Bookmarks
Post by: Kindred on February 25, 2011, 12:20:09 PM
did you copy the right version of the install for your version of SMF?
Title: Re: Bookmarks
Post by: harmoni on February 25, 2011, 12:31:52 PM
Quote from: Kindred on February 25, 2011, 12:20:09 PM
did you copy the right version of the install for your version of SMF?

Yup.. problem settled. TQ Kindred.

Actually I noticed that the bookmarks database already exist with the field user_id and topic_id. I change both field name to id_members and id_topic respectively.  Then only it works... MAJESTIC my friend...
Title: Re: Bookmarks
Post by: henrik1782 on February 25, 2011, 06:08:53 PM
Will this version go for RC5? I tried to install but I dont see to get the bookmark button in topic.

Danish translation
<file name="$languagedir/Modifications.danish-utf8.php" error="skip">
<operation error="skip">
<search position="end" />
        <add><![CDATA[
$txt['bookmarks'] = 'Mine bogmærker';
$txt['bookmark_list'] = 'Bogmærker';
$txt['bookmark_list_empty'] = 'Du har ikke oprettet nogen bogmærker. Tilføj et ved at klikke på \'Tilføj bogmærke\' under emner.';
$txt['bookmark_open_window'] = 'Åben i nyt vindue';
$txt['bookmark_delete'] = 'Slet valgte bogmærker';
$txt['bookmark_delete_success'] = '%1$s bogmæker blev slettet!';
$txt['bookmark_delete_failure'] = 'Ingen bogmærker blev slettet.';
$txt['bookmark_add'] = 'Tilføj bogmærk';
$txt['bookmark_add_success'] = 'Emner blev tilføjet til dine bogmærker!';
$txt['bookmark_add_exists'] = 'Dette emner er har du allerede som bogmærke!';
$txt['bookmark_add_failed'] = 'Tilføjelse af bogmærke fejlede.';
$txt['permissionname_make_bookmarks'] = 'Bogmærke for emner';
$txt['cannot_make_bookmarks'] = 'Beklager, du har ikke rettigheder til at tilføje bogmærker.';
]]></add>
    </operation>
</file>
<file name="$languagedir/Modifications.danish.php" error="skip">
<operation error="skip">
<search position="end" />
        <add><![CDATA[
$txt['bookmarks'] = 'Mine bogmærker';
$txt['bookmark_list'] = 'Bogmærker';
$txt['bookmark_list_empty'] = 'Du har ikke oprettet nogen bogmærker. Tilføj et ved at klikke på \'Tilføj bogmærke\' under emner.';
$txt['bookmark_open_window'] = 'Ã...ben i nyt vindue';
$txt['bookmark_delete'] = 'Slet valgte bogmærker';
$txt['bookmark_delete_success'] = '%1$s bogmæker blev slettet!';
$txt['bookmark_delete_failure'] = 'Ingen bogmærker blev slettet.';
$txt['bookmark_add'] = 'Tilføj bogmærk';
$txt['bookmark_add_success'] = 'Emner blev tilføjet til dine bogmærker!';
$txt['bookmark_add_exists'] = 'Dette emner er har du allerede som bogmærke!';
$txt['bookmark_add_failed'] = 'Tilføjelse af bogmærke fejlede.';
$txt['permissionname_make_bookmarks'] = 'Bogmærke for emner';
$txt['cannot_make_bookmarks'] = 'Beklager, du har ikke rettigheder til at tilføje bogmærker.';
]]></add>
    </operation>
</file>
Title: Re: Bookmarks
Post by: Illori on February 25, 2011, 07:08:04 PM
it installed just fine on my RC5 install, menu option included.
Title: Re: Bookmarks
Post by: henrik1782 on February 25, 2011, 08:36:09 PM
Strange...
Title: Re: Bookmarks
Post by: noaccess on March 11, 2011, 03:10:20 AM
What do I need to change to make this work in 2.0 RC5? because right now it says that it's not made for this version.
Title: Re: Bookmarks
Post by: Kindred on March 11, 2011, 07:02:54 AM
2.0 has an emulation option built in. Click advanced at the package manager screen
Title: Re: Bookmarks
Post by: noaccess on March 20, 2011, 06:14:22 AM
I used the emulation button, it installed without any errors. However, there is no "Add bookmarks" button, only the main my bookmarks page is visible.
Title: Re: Bookmarks
Post by: Illori on March 20, 2011, 07:09:18 AM
then you need to manually add that button, and it should work just fine. parse the mod and find the edit then add it.
Title: Re: Bookmarks
Post by: ccentre on March 28, 2011, 02:31:44 PM
Quote from: Illori on March 20, 2011, 07:09:18 AM
then you need to manually add that button, and it should work just fine. parse the mod and find the edit then add it.

How to add the button manually?
Title: Re: Bookmarks
Post by: Kindred on March 28, 2011, 02:47:02 PM
run the manual-parse instructions and install the code into the appropriate template files for your custom theme.
Title: Re: Bookmarks
Post by: henrik1782 on March 30, 2011, 05:16:54 AM
QuoteHow to add the button manually?

Install the mod with emulation option.

In Display.template.php find
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true),

and replace with
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true),
'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']),


and everything works just fine.
Title: Re: Bookmarks
Post by: NHWD on April 02, 2011, 06:42:40 AM
I'm not sure if this does.. but it would be useful if it also added bookmarks to the member's list of notification topics. Does it?
Title: Re: Bookmarks
Post by: Illori on April 02, 2011, 06:44:22 AM
no it does not. and at this time it seems like this mod is no longer supported by its author.
Title: Re: Bookmarks
Post by: NHWD on April 02, 2011, 07:04:18 AM
Ah ok
Title: Re: Bookmarks
Post by: cosmicxxx on April 22, 2011, 03:52:06 AM
my first post...

please can anybody help me out here. i have smf 1.1.11 and follow the parse file instruction for it


the problem is, the My Bookmark menu is only visible when admin account is logged in.

ive check the permission page in admin settings, but there is no settings to set for bookmarks

therefore, i cant permit any group to access the my bookmarks mod.

Title: Re: Bookmarks
Post by: TomW on April 29, 2011, 11:55:10 PM
Quote from: cosmicxxx on April 22, 2011, 03:52:06 AM
my first post...

please can anybody help me out here. i have smf 1.1.11 and follow the parse file instruction for it


the problem is, the My Bookmark menu is only visible when admin account is logged in.

ive check the permission page in admin settings, but there is no settings to set for bookmarks

therefore, i cant permit any group to access the my bookmarks mod.

You need to set the permissions for each membergroup.  That will take care of it.
Title: Re: Bookmarks
Post by: cosmicxxx on April 30, 2011, 12:52:53 PM
Solved!

I have custom theme... need to edit those too.
Title: Re: Bookmarks
Post by: ChaosEnergy on June 16, 2011, 03:57:02 PM
Quote from: henrik1782 on March 30, 2011, 05:16:54 AM
QuoteHow to add the button manually?

Install the mod with emulation option.

In Display.template.php find
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true),

and replace with
'reply' => array('test' => 'can_reply', 'text' => 'reply', 'image' => 'reply.gif', 'lang' => true, 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true),
'bookmark' => array('test' => 'can_make_bookmarks', 'text' => 'bookmark_add', 'lang' => true, 'url' => $scripturl . '?action=bookmarks;sa=add;topic=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']),


and everything works just fine.

Thanks, it helped for 2.0 final
Title: Re: Bookmarks
Post by: Jessica. on June 19, 2011, 06:46:11 PM
edit: never mind. for some reason the code to add the button didn't get applied
Title: Re: Bookmarks
Post by: lazylivin on June 21, 2011, 07:59:16 PM
Just wanted you to know my forum members love this mod. Hope to have it available on SMF 2.0 Gold soon.
Title: Re: Bookmarks
Post by: Inti31 on June 22, 2011, 01:00:37 AM
@lazylivin
it still runs fine on 2.0 Gold...
I've implemented that mod in my testforum, everything okay...

I modified the whole package (german only) that the installation runs in standard mode (2.0 Gold)  so there is no need to use the compatible mode...

Modification-german-utf8.php

// Start  Lesezeichen
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzuf&#252;gen\' in den Threads erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster &#246;ffnen';
$txt['bookmark_delete'] = 'Lesezeichen l&#246;schen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gel&#246;scht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gel&#246;scht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzuf&#252;gen';
$txt['bookmark_add_success'] = 'Thread erfolgreich Deinen Lesezeichen hinzugef&#252;gt!';
$txt['bookmark_add_exists'] = 'Dieser Thread befindet sich bereits in Deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim Hinzuf&#252;gen des Threads zu Deinen Lesezeichen aufgetreten!';
$txt['permissionname_make_bookmarks'] = 'Erstelle Lesezeichen f&#252;r Theads';
$txt['cannot_make_bookmarks'] = 'Du hast keine Berechtigung, Lesezeichen zu erstellen.';
// Ende Lesezeichen
Title: Re: Bookmarks
Post by: wwwserfer on June 24, 2011, 10:31:37 AM
Hi!

try to install this mod on SMF 1.1.14...
on pressing install ---> blank screen... & nothing...

in error logs:

Quote256: parse_path(): There should never be an empty filename
File: /home/...../site.com/docs/Sources/Subs-Package.php
Line: 1126

1024: Undefined XML attribute: destination from /home/...../site.com/docs/Sources/Subs-Package.php on line 867
File: /home/......./site.com/docs/Sources/Subs-Package.php
Line: 2365

1024: Undefined XML attribute: name from /home/....../site.com/docs/Sources/Subs-Package.php on line 861
File: /home/......./site.com/docs/Sources/Subs-Package.php
Line: 2365

v.1.1.14 not supported? or other...? ???
Title: Re: Bookmarks
Post by: Illori on June 24, 2011, 10:35:34 AM
Quote from: Illori on February 25, 2011, 08:42:41 AM
please read this:

Quote from: Illori on December 23, 2010, 05:55:17 AM
Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>
Title: Re: Bookmarks
Post by: wwwserfer on June 24, 2011, 11:11:17 AM
Quote from: Illori on June 24, 2011, 10:35:34 AM
Quote from: Illori on February 25, 2011, 08:42:41 AM
please read this:

Quote from: Illori on December 23, 2010, 05:55:17 AM
Quote from: DarioBros on October 12, 2010, 06:31:49 AM
Quote from: marcberm on July 25, 2010, 10:03:07 PM
So for some reason, when I attempt to install this package automatically through the SMF interface, instead of proceeding to the screen where the file tests are displayed, I get just a blank white screen (refresh doesn't do anything). 

The same thing happens to me.

I resolved this issue modifying the file "package-info.xml" contained in the archive.

In this file, I replaced every istance of
<database type="file">
with
<code>

and
</database>
was replaced by
</code>

Thanks!!
Title: Re: Bookmarks
Post by: frx on June 24, 2011, 11:12:50 AM
Quote from: Inti31 on June 22, 2011, 01:00:37 AM
@lazylivin
it still runs fine on 2.0 Gold...
I've implemented that mod in my testforum, everything okay...

How did you do it ?
Whe i do a package parse for 2.0 it says it isn't compatible with my version (2.0 Gold)...

Thanks
Title: Re: Bookmarks
Post by: Jessica. on June 24, 2011, 11:16:38 AM
emulate it to the version(s) it's compatible with, that is what I did

bottom of Browse Packages (Advanced)
Title: Re: Bookmarks
Post by: Inti31 on June 28, 2011, 08:48:28 AM
Quote from: frx on June 24, 2011, 11:12:50 AM
Quote from: Inti31 on June 22, 2011, 01:00:37 AM
it still runs fine on 2.0 Gold...
I've implemented that mod in my testforum, everything okay...

How did you do it ?
Where I do a package parse for 2.0 it says it isn't compatible with my version (2.0 Gold)...

Thanks

it's simple...
I just did that for nearly each mod I installed (50 mods now in 2.0 Gold)... - I upgraded also now my main board (epica-forum.de) with all mods - took only minutes to get everything working...



1: download the modification
2: open it with 7Zip (I use a portable version) - this works with every zip file or also tar.gz or gz - don't close 7Zip...
3: extract package-info.xml and translation.xml - use to open the files this app: notepad++ (my recommendation, I also have a portable version of that)
4: modify the install header in file package-info.xml and add , 2.0 at the end of that line
ex: <install for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC2, 2.0 RC3, 2.0">
5 close and save it - then open translation.xml file - if you use another language than English:
6: find a language string or maybe rename an exisiting one like I did:
e.g: <file name="$languagedir/Modifications.german-utf8.php">
do your translation

save that file also - now drag both files back to the open 7zip file - save it - done
Now upload the modified 7zip file and start the installation without using the compatible mode

The file package-info.xml is the "setup" file - standard in smf for every mod...
see which steps and files are included  - mybe delete language-files you don't need.

Greets inti31
Title: Re: Bookmarks
Post by: Kindred on June 28, 2011, 11:07:19 AM
in 2.0, there is no need to do that.

Click the "advanced" link at the bottom of the package list screen and change the "version" listing there to something that matches the mod's predefined versions.
Title: Re: Bookmarks
Post by: Inti31 on June 28, 2011, 12:06:19 PM
Quote from: Kindred on June 28, 2011, 11:07:19 AM
in 2.0, there is no need to do that.
I know that - bu I'd like to know what will happen during the installation process so I nearly read everything first before  I install a mod - and because mostly each package does not include my favorite language (German) and I don't like having a Portuguese, Turkish, French or Spanish file on my webserver - that's how it goes.
Its so easy to add a skip parameter to lines are proceeded by the installer (or to remove these lines/files are not needed).

Also - I have a testboard - not every mod works with 2.0 Gold....

This is just a hint for people feels like me... - if it is working fine then there is no need to use the advanced link... - too much clicks :)

I've got huge respect for modworkers - I wish I could do in the same matter like all the experts who share all the useful mods with the community... @all - thx for that...

Well, reading what will happen is part of learning how SMF works and how things come together...

Inti31 - a German SMF fan :)
Title: Re: Bookmarks
Post by: cloksin on July 08, 2011, 01:24:51 PM
I've modified the package-info.xml file to work on 2.0 for those people that either can't do the change themselves of can't figure out how to make the emulator work.

USE AT YOUR OWN RISK!!!!!!
Title: Re: Bookmarks
Post by: Illori on July 08, 2011, 01:27:40 PM
sorry you are not allowed to distribute the mod made by someone else without their permission. your attachment has been removed.
Title: Re: Bookmarks
Post by: Major Wood on July 22, 2011, 05:48:25 PM
I tried installing this on a 2.0 gold installation and the majority of the tests fail. This happens regardless of what version I set the emulation to.
Title: Re: Bookmarks
Post by: Illori on July 22, 2011, 07:03:09 PM
this mod has not yet been fully updated to 2.0 so you may need to do some tweaking to get it installed.
Title: Re: Bookmarks
Post by: live627 on July 22, 2011, 08:13:49 PM
If that's the case, then why did I install it on multiple 2.0 installs without err?
Title: Re: Bookmarks
Post by: Illori on July 22, 2011, 09:12:09 PM
no idea, i know i had to do some tweaking to get it to install on my 2.0 forum.
Title: Re: Bookmarks
Post by: Biology Forums on July 24, 2011, 11:00:57 PM
To the author:

Could you help me add a number next to the My Bookmark in the menu that denotes how many bookmarks you have? Kind of like when you have mail, it has the number in brackets Messages (2)... But rather have something like My BookMarks (4)...

Could you help, I'm using 1.1.14
Title: Re: Bookmarks
Post by: frx on July 29, 2011, 08:21:04 AM
I can't see this botton:
http://custom.simplemachines.org/mods/index.php?action=download;mod=864;id=138967;image

In the Top Menu, the button appears, but the add button doesn't. :(
I've emulated it into smf 2.0 RC3, to work in a SMF 2.0 Gold.
Title: Re: Bookmarks
Post by: Illori on July 29, 2011, 08:23:41 AM
parse the mod and manually add the code
Title: Re: Bookmarks
Post by: frx on July 29, 2011, 08:34:48 AM
Quote from: Illori on July 29, 2011, 08:23:41 AM
parse the mod and manually add the code

It only said it wasn't possible to add the code in the subs.php (i added it manually).

The rest of codes were all ok.
But i'll check it later, to see if it has been added or not. Thanks.
Title: Re: Bookmarks
Post by: frx on July 29, 2011, 09:24:25 AM
It's done!
Thanks :)
Title: Re: Bookmarks
Post by: Aaron on July 30, 2011, 07:50:02 AM
I have uploaded a new version of this mod to the mod site. :)

This version should install on SMF 2.0 and above without the use of version emulation and should do a better job at adding the 'Add Bookmark' button to the (topic) display template.
Title: Re: Bookmarks
Post by: Illori on July 30, 2011, 08:20:41 AM
you have again set the edits for Display.template.php as optional, without these edits no one can add a thread to the bookmarks. this issue was seen above a few posts. please change this.

you also made the edits to modifications.english.php optional this would cause many undefined errors as a result if the edits are not made.
Title: Re: Bookmarks
Post by: Siirist on July 30, 2011, 10:23:55 AM
Quote from: Aaron on July 30, 2011, 07:50:02 AM
I have uploaded a new version of this mod to the mod site. :)

This version should install on SMF 2.0 and above without the use of version emulation and should do a better job at adding the 'Add Bookmark' button to the (topic) display template.

Aaron,
This is AWESOME!!!
Saw it was updated for ver 2.0 Final and installed it via Package Manager (except for ../Sources/Subs.php
1) Add before

did that manually with the parse and "Ta Da"!!  Works Awesome. I even added a bookmark to test it.

However, is there a way to Un-BookMark a topic?

I know it will Un-BookMark if the topic is deleted, but I don't want to delete the topic I used to test the BookMark Mod.

Thanks for your help in advance.

Be Well,
Cloud  8)
Title: Re: Bookmarks
Post by: Illori on July 30, 2011, 10:29:07 AM
once you add the bookmark check your bookmark list there is a checkbox/button to delete it.
Title: Re: Bookmarks
Post by: Siirist on July 30, 2011, 10:45:42 AM
Quote from: Illori on July 30, 2011, 10:29:07 AM
once you add the bookmark check your bookmark list there is a checkbox/button to delete it.

Thank you Illori.

That was easy. Here's a more difficult one.  :P

I want to add an icon for BookMarks, should I post about this over in the Menu Icons Mod Topic, er is this something that can be solved here?

I attached a SS.

Thanks.

Be Well,
Cloud  8)
Title: Re: Bookmarks
Post by: Illori on July 30, 2011, 11:33:36 AM
you would be best to ask in the graphics/templates board if you want an icon made or even help wanted.
Title: Re: Bookmarks
Post by: Cheese Head on July 30, 2011, 01:20:51 PM
INFO

Just installed works great, many thanks!

Note to other users, after installing it works great from your Admin account but is not visible to your Members.

I had to search but finally found the switch to turn it on for your Members, from your Admin account, go Admin > Members Permissions > Regular members Modify, then under "Use basic forum functionality", check the option beside "Create bookmarks for topics" then Save new settings.
Title: Re: Bookmarks
Post by: Slug1 on July 30, 2011, 08:37:15 PM
Quote from: A_Survivor of abuse on July 30, 2011, 10:23:55 AM
Quote from: Aaron on July 30, 2011, 07:50:02 AM
I have uploaded a new version of this mod to the mod site. :)

This version should install on SMF 2.0 and above without the use of version emulation and should do a better job at adding the 'Add Bookmark' button to the (topic) display template.

Aaron,
This is AWESOME!!!
Saw it was updated for ver 2.0 Final and installed it via Package Manager (except for ../Sources/Subs.php
1) Add before

did that manually with the parse and "Ta Da"!!  Works Awesome. I even added a bookmark to test it.

Be Well,
Cloud  8)


Since I don't know about manually doing all this... is there instructions somewhere on this site that I can read through to figure this out?

Thanks!
Title: Re: Bookmarks
Post by: Kindred on July 30, 2011, 08:55:19 PM
Go to the mod Downwload page and use the parse button
Title: Re: Bookmarks
Post by: Slug1 on July 30, 2011, 10:43:02 PM
Quote from: Kindred on July 30, 2011, 08:55:19 PM
Go to the mod Downwload page and use the parse button

OK... so do I install the Mod with the errors and then do all according what is displayed on that parse page?

I also noticed when I did the install, it has a portion at the sub.php line of install something like "find" this and replace "after" also.

Is that really all that I need to do is with just the sub.php file after I do the install anyway?
Title: Re: Bookmarks
Post by: Siirist on July 31, 2011, 06:28:18 AM
Quote from: Illori on July 30, 2011, 11:33:36 AM
you would be best to ask in the graphics/templates board if you want an icon made or even help wanted.

Will do.

Thanks for pointing me in the right direction.

Be Well,
Cloud  8)
Title: Re: Bookmarks
Post by: Siirist on July 31, 2011, 07:27:15 AM
Quote from: Slug1 on July 30, 2011, 10:43:02 PM
Quote from: Kindred on July 30, 2011, 08:55:19 PM
Go to the mod Download page and use the parse button

OK... so do I install the Mod with the errors and then do all according what is displayed on that parse page?

I also noticed when I did the install, it has a portion at the sub.php line of install something like "find" this and replace "after" also.

Is that really all that I need to do is with just the sub.php file after I do the install anyway?

Slug 1,

I will NOT say this is the right way or the only way, but it is my way of parsing a mod.

A) I write down the directory and the files that Failed
ei, .../Sources/Subs.php

B) I write down the sequence that Failed
ei, 1) Replace,
     2) Add before
     3) Add after

C)I install the mod (when the box says Some files failed and will not be modified. Do you want to install any way? I select "Yes").

D) I open the parse of the mod.

E) I then go to my host's server,

F) launch the File Manager,

G) find the directory and the file that did not get modified,

H) I open the file,

I) I use Alt+Tab to switch to the mod's Parse screen, select, and copy the code in the "Find" box

J) I use Alt+Tab to switch to the file I opened

K) I use Ctrl+F and Ctrl+V to locate the code

L) I use Alt+Tab to switch to the mod's Parse screen, select, and copy the code in the "Replace" or "Add" box

M) I use Alt+Tab to switch to the file I opened

N) I continue this procedure for the remaining modifications that "Failed" until all changes are made to that file

O) I save the file and then move on to the next directory and files that need to be changed and use the same procedure to until all files that "Failed" have been changed.


Perhaps I should find the link to the "proper" instructions on how to parse a mod and place it in my signature.  :-[

Best of luck in your life.  ;)

Be Well,
Cloud  8)
Title: Re: Bookmarks
Post by: Slug1 on July 31, 2011, 04:22:53 PM
Quote from: A_Survivor of abuse on July 31, 2011, 07:27:15 AM
Quote from: Slug1 on July 30, 2011, 10:43:02 PM
Quote from: Kindred on July 30, 2011, 08:55:19 PM
Go to the mod Download page and use the parse button

OK... so do I install the Mod with the errors and then do all according what is displayed on that parse page?

I also noticed when I did the install, it has a portion at the sub.php line of install something like "find" this and replace "after" also.

Is that really all that I need to do is with just the sub.php file after I do the install anyway?

Slug 1,

I will NOT say this is the right way or the only way, but it is my way of parsing a mod.
<snip>

Best of luck in your life.  ;)

Be Well,
Cloud  8)

OK... I got the idea since I've done some very minor edits in a few php files before, usually for cosmetic reasons.

Thanks for the help. I'll be sure to save the original file elsewhere before I begin editing.
Title: Re: Bookmarks
Post by: Siirist on August 01, 2011, 08:29:12 AM
Slug1,

Yeah, typed it the way I do it, which is usually "forgetting" to back-up.  :-[

Readers - I back-up daily. ALWAYS REMEMBER TO BACK-UP BEFORE adding mods or making changes to your forum.

Be Well,
Cloud  8)
Title: Re: Bookmarks
Post by: cosmicxxx on August 16, 2011, 09:28:06 AM
hi aaron, this mod is awesome. thank you very much for creating such mod.

i hope you can help me with my idea... i want to integrate your bookmark mod with another mod. im not a coder, but i know how to edit php files.

i want to integrate your bookmark mod with smfclassifieds, done by smfhacks dot com.

i want to use the mod to bookmark the classified ads listings, separate bookmark for topics and separate for ad listings.

i hope you may spare some time. thanks.
Title: Re: Bookmarks
Post by: Biology Forums on August 16, 2011, 01:46:33 PM
Quote from: shuban on July 24, 2011, 11:00:57 PM
To the author:

Could you help me add a number next to the My Bookmark in the menu that denotes how many bookmarks you have? Kind of like when you have mail, it has the number in brackets Messages (2)... But rather have something like My BookMarks (4)...

Could you help, I'm using 1.1.14

Anyone know how to do this?
Title: Re: Bookmarks
Post by: Kindred on August 16, 2011, 01:58:58 PM
cosmicxxx,
what you are asking for would require a fair amount of additional coding, since the classifieds are not even stored in the same table or format as the messages.

shuban,
conceptually, you would have to open the database table, read the number of bookmarks for that person and write is back out.
The problem that I see is that that information would then be loaded for each and every page load, since the menu is loaded and reloaded each time. This increases the database overhead.
Mind you, you could read the result into the user array.... but then that would take more additional coding.
Title: Re: Bookmarks
Post by: Biology Forums on August 16, 2011, 02:35:58 PM
It's a great idea, and it reminds us that we actually have bookmarks.

I wish I knew how to code. :-[
Title: Re: Bookmarks
Post by: Kindred on August 16, 2011, 03:02:41 PM
actually, I completed got rid of the bookmark menu item...    The only place my users see their bookmarks is in their profiles.
Title: Re: Bookmarks
Post by: Biology Forums on August 16, 2011, 04:18:48 PM
Quote from: Kindred on August 16, 2011, 03:02:41 PM
actually, I completed got rid of the bookmark menu item...    The only place my users see their bookmarks is in their profiles.

It's not in the menu for me either.
Title: Re: Bookmarks
Post by: cosmicxxx on August 16, 2011, 07:16:18 PM
Quote from: Kindred on August 16, 2011, 03:02:41 PM
actually, I completed got rid of the bookmark menu item...    The only place my users see their bookmarks is in their profiles.

im interested how you did it... are you willing to share how did you accomplished that?
Title: Re: Bookmarks
Post by: Kindred on August 16, 2011, 09:49:16 PM
How I did what? Removed the bookmark item from the menu or linked it in the profile?
Title: Re: Bookmarks
Post by: cosmicxxx on August 16, 2011, 10:21:12 PM
both...

remove it from the navigation menu and put it in the profile instead.


Title: Re: Bookmarks
Post by: Kindred on August 17, 2011, 12:18:51 AM
Removing from the menu is easy...   Edit the menu array in subs.php and comment out or delete the bookmarks section.

I use the user control panel for the profiles and this allows me to add icons to the usercp for up to 4 additional links, once of which I targeted to the user's bookmarks page.

Alternatively, it wouldn't be terrible hard toad it as a subscreen of the profile template.
Title: Re: Bookmarks
Post by: cosmicxxx on August 17, 2011, 03:25:44 AM
any further newbie friendly instruction. i think i can do the subs.php part but, i don't think i can for the other steps. i'm not a coder, but i'm learning bit by bit through instructions.
Title: Re: Bookmarks
Post by: iPhoneDestek on October 23, 2011, 03:12:16 PM
Translation by MOD Translator iPhoneDestek.org in turkish languages







<file name="$themedir/languages/Modifications.turkish.php" error="skip">
<operation>
<search position="end" />
<add><![CDATA[
// Beginn Booksmarks MOD Trasnlation by iPhoneDestek.org
$txt['bookmarks'] = 'Favori Konularim';
$txt['bookmark_not_for_guests'] = 'Üzgünüm, Bu Forumda Sadece Üyeler \'Favori Konular\' özelligini kullanabilir!';
$txt['bookmark_list'] = 'Favori Konular';
$txt['bookmark_list_empty'] = 'Suan Hiç Favori Konunuz Yok!. Mesajdaki \'Favorilerime ekle\' butonunu kullanarak ekleyebilirsiniz.';
$txt['bookmark_open_window'] = 'Yeni Pencerede Aç';
$txt['bookmark_delete'] = 'Favori Konuyu Sil';
$txt['bookmark_delete_success'] = 'Favori Konu Silindi!';
$txt['bookmark_delete_failure'] = 'Favori Konu Silinemedi!';
$txt['bookmark_add'] = 'Favorilerime Ekle';
$txt['bookmark_add_success'] = 'Konu, Favori Konulariniza eklendi!';
$txt['bookmark_add_exists'] = 'Bu Konu Zaten Favori Konularinizda Var!';
$txt['bookmark_add_failed'] = 'Favori Konu Eklemede Hata!';
$txt['permissionname_make_bookmarks'] = 'Favoriler icin konu olusturabilir';
// End Booksmarks MOD Trasnlation by iPhoneDestek.org
]]></add>
</operation>
</file>


Title: Re: Bookmarks
Post by: KensonPlays on October 23, 2011, 06:16:53 PM
Quote from: Kindred on July 26, 2010, 01:59:51 AM
???  google bookmark?  This feature creates a list of bookmarks stored in the DB for a user, there is no external interface with any outside source.

Also, I do not think that Aaron is doing any development on this any more... (could be wrong, though)
Nevermind... you don't understand what I mean...
Title: Re: Bookmarks
Post by: TheListener on October 23, 2011, 06:38:25 PM

Nevermind... you don't understand what I mean...
[/quote]

Nobody does.
Title: Re: Bookmarks
Post by: cloksin on October 23, 2011, 09:45:22 PM
Is there any way to get the page numbers to display under the topic title for threads that have more than one page?  When I click on bookmarks and see my list of bookmarks, I don't want to be taken to the first page of every thread I have bookmarked, at the very least I'd like to be able to go to the last page of each thread, and in a perfect world, be able to select the page.  Sometimes we have threads that move very fast and can move a couple of pages in the matter of just an hour or two, I'd like to be able to start at the page I left off last time I logged in, read all the posts from that point to get caught up, then post my reply.
Title: Re: Bookmarks
Post by: cosmicxxx on October 24, 2011, 09:51:51 AM
thanks to all who responded...
Title: Re: Bookmarks
Post by: Manu.G on November 11, 2011, 10:00:46 AM
There is a problem with the Russian and German translation of this mod.


http://i44.tinypic.com/1pv421.jpg (http://i44.tinypic.com/1pv421.jpg)


The Cyrillic isn't displayed correctly and the German umlauts are displayed incorrect too :)


Here is the correct German translation (non-utf8)
$txt['bookmarks'] = 'Meine Lesezeichen';
$txt['bookmark_list'] = 'Lesezeichen';
$txt['bookmark_list_empty'] = 'Du hast momentan keine Lesezeichen angelegt. Dies kannst du mit \'Lesezeichen hinzuf&uuml;gen\' in den Threads erledigen.';
$txt['bookmark_open_window'] = 'In neuem Fenster &ouml;ffnen';
$txt['bookmark_delete'] = 'Lesezeichen l&ouml;schen';
$txt['bookmark_delete_success'] = '%1$s Lesezeichen wurden erfolgreich gel&ouml;scht!';
$txt['bookmark_delete_failure'] = 'Nicht alle Lesezeichen konnten gel&ouml;scht werden.';
$txt['bookmark_add'] = 'Lesezeichen hinzuf&uuml;gen';
$txt['bookmark_add_success'] = 'Thread erfolgreich Deinen Lesezeichen hinzugef&uuml;gt!';
$txt['bookmark_add_exists'] = 'Dieser Thread befindet sich bereits in deinen Lesezeichen!';
$txt['bookmark_add_failed'] = 'Es ist ein Fehler beim hinzuf&uuml;gen des Threads zu deinen Lesezeichen aufgetreten!';
$txt['permissionname_make_bookmarks'] = 'Erstellt Lesezeichen f&uuml;r Threads';
$txt['cannot_make_bookmarks'] = 'Sorry, du hast nicht die Berechtigung Lesezeichen zu erstellen.';
Title: Re: Bookmarks
Post by: Robert. on November 11, 2011, 01:40:56 PM
You can fix that by simply translating the button to Russian or any other Cyrillic language. :)
Title: Re: Bookmarks
Post by: Manu.G on November 11, 2011, 02:38:35 PM
I fixed it, because we have a lot of Russian members on the forum.
Could be it isn't the correct way, but now the Cyrillic is displayed correct ;)
 
Russian (non-utf8) in the attachment
Title: Re: Bookmarks
Post by: Eyesman on November 18, 2011, 03:15:10 AM
Hello all,

I have tried to install this nice mod today but I get the following error:

"The package you are trying to download or install is either corrupt or not compatible with this version of SMF."

My forum version: SMF 2.0 RC5

Any help to make this mod works is much appreciated.

Thank you for your time.
Title: Re: Bookmarks
Post by: cloksin on November 18, 2011, 06:16:51 AM
check out this link for version emulation

http://wiki.simplemachines.org/smf/How_can_install_a_mod_that_doesn%27t_work_in_my_SMF_version
Title: Re: Bookmarks
Post by: Eyesman on November 18, 2011, 06:31:14 AM
thank you cloksin.. which version shall I emulate for this mod? what version should I type there?

thanx again!
Title: Re: Bookmarks
Post by: Eyesman on November 18, 2011, 06:35:32 AM
Quote from: Aaron on July 30, 2011, 07:50:02 AM
I have uploaded a new version of this mod to the mod site. :)

This version should install on SMF 2.0 and above without the use of version emulation and should do a better job at adding the 'Add Bookmark' button to the (topic) display template.

Where can I find this new version?

thank you.
Title: Re: Bookmarks
Post by: cloksin on November 18, 2011, 07:04:36 AM
This is a link to the latest version, version 2.4

http://custom.simplemachines.org/mods/index.php?mod=864

I looked at the package-info.xml file which lists the versions of smf it is compatible with, here is what it has.

<install for="2.0 Beta 3, 2.0 Beta 3 Public, 2.0 Beta 3.1, 2.0 Beta 3.1 Public, 2.0 Beta 4, 2.0 Beta 4 Public, 2.0 RC1, 2.0 RC2, 2.0 RC3, 2.0 - 2.0.99">

so you have three options, the more advanced option is to extract that file from the zip file, add 2.0 RC5 to that list, then zip it back into the package, you would then be able to install the package without using the emulator.

Option 2 is to emulate any of the versions listed there, I would go with RC3, so type "SMF 2.0 RC3" without the quotes into the emulator text box,

and the third option, which you'll hear a lot around here (but never really answers any questions) is to upgrade to 2.0.1.

I know from personal experience that this is not always an option, and can be an arduous task in and of itself (although it is a more stable version and lots of things were fixed in it) so I suggest option two.  Don't forget to set the emulator back to default when you are done.
Title: Re: Bookmarks
Post by: Kindred on November 18, 2011, 07:28:00 AM
more importantly....  update your forum installation ASAP!   2.0RC5 has know security issues which have been fixes in 2.0 and 2.0.1
Title: Re: Bookmarks
Post by: cloksin on November 18, 2011, 08:01:53 AM
Quote from: Kindred on November 18, 2011, 07:28:00 AM
more importantly....  update your forum installation ASAP!   2.0RC5 has know security issues which have been fixes in 2.0 and 2.0.1

See what I mean?  Its a typical response around here "update your forum", to hell with giving you the answer you asked for.

Unfortunately, the people who recite this till they're blue in the face must have all the time in the world to spend the many many hours it takes to do an upgrade of this magnitude on a large, live forum.  They obviously don't even bother to read the posts before they submit their dribble, or he would have seen that I already addressed that in my previous post.  Its just a way to inflate their post count, so they can say "look how many posts I have, I MUST know what I'm talking about"

It has been my experience that people with insanely large post counts don't give as good information on the questions posed as people with lower posts counts, but actually read the questions posed and try to answer the actual question.  If you wanted to hear them beat the dead horse about upgrading you can read the news and updates topic.
Title: Re: Bookmarks
Post by: Kindred on November 18, 2011, 10:26:36 AM
Cloksin,

Actually, I don't give a damn about post count. I didn't add anything else because the other issue (which version to emulate) had already been handled - and, though you pointed it out as an option, you did not indicate that it was actually an IMPORTANT THING TO DO. I **DO* know what I am talking about, since I have been admining forums for 20+ years and have been on staff here for 5+ (and I have had several forums hacked over the years because I did not perform the upgrades)

As for updating and time...   I admin 5 forums currently. I spent last weekend updating one of them and Wednesday updating the other 4... Updating from 2.0RC5 to 2.0.1 is a minimal effort update.
Title: Re: Bookmarks
Post by: Eyesman on November 21, 2011, 02:54:49 AM
Thank you cloksin! I have installed it using the emulator. :)
Title: Re: Bookmarks
Post by: RAULVK on December 31, 2011, 04:21:02 AM
Bookmarks 2.4 in SMF 2.0 no exist??

if ($alreadyAdded)
return $txt['bookmark_add_exists'];


has been eliminated?
Title: Re: Bookmarks
Post by: biohazard388 on January 02, 2012, 09:06:58 PM
I just tried installing on 2.0.2 and got the following text at the top of my forum. After uninstalling it and looking through the installation menus, display.template shows up with only the second edit as successful. Numbers 1 and 3 are 'test failed'.



Here's a screen shot:
(http://i44.photobucket.com/albums/f26/Biohazard388/forumfailure.jpg)




I'm wondering, should I just go in and hand-code in the 1st and 3rd edits manually? This is only a live forum, so I don't want to risk breaking anything.
Title: Re: Bookmarks
Post by: Kindred on January 02, 2012, 10:28:59 PM
Somehow your text strings got added after the ?> in the strings file? Move it back to he nd to fix it....  And try using search next time. ;)
Title: Re: Bookmarks
Post by: Biology Forums on January 03, 2012, 01:47:40 AM
Quote from: Kindred on August 16, 2011, 01:58:58 PM
cosmicxxx,
what you are asking for would require a fair amount of additional coding, since the classifieds are not even stored in the same table or format as the messages.

shuban,
conceptually, you would have to open the database table, read the number of bookmarks for that person and write is back out.
The problem that I see is that that information would then be loaded for each and every page load, since the menu is loaded and reloaded each time. This increases the database overhead.
Mind you, you could read the result into the user array.... but then that would take more additional coding.

How much time would it take to code something as simple as this? I really like this change because it makes the modification more user friendly and important.

:(
Title: Re: Bookmarks
Post by: live627 on January 04, 2012, 12:55:13 AM
Less than an hour I think
Title: Re: Bookmarks
Post by: Biology Forums on January 04, 2012, 01:38:17 AM
Quote from: live627 on January 04, 2012, 12:55:13 AM
Less than an hour I think

I found this mod: Count unread topics on index... Which does exactly what I want but for the unread topics - not the bookmarks. If I knew how to code well, I would simply rearrange the changes to suit the bookmarks. :(
Title: Re: Bookmarks
Post by: wynnyelle on January 05, 2012, 12:56:00 AM
My server shows VERY high usage of CPU for bookmarks, yet I cannot find an error on the admin panel where it does so. Would you know what might be the problem?
Title: Re: Bookmarks
Post by: teos55 on January 09, 2012, 03:35:26 PM
SMF 2.0.2  Simple Portal 2.3.4    Default theme

  Installed  bookmars2.4 sucssesfuly. No error messages, only subs.php failed due to some other mod's change so I manually added the code before calendar as indicated.

  Now, only admin sees the buttons but not the normal users.

What to check ?

It's urgent,  since I announced the mod to the users !!! 

--------------------------------------

FOUND ...


  in permissions, it has to be enabled for normal users. It's not mentioned anywhere, did I miss it ?
Title: Re: Bookmarks
Post by: Kindred on January 09, 2012, 07:10:32 PM
almost every mod has a permissions setting.... it should usually be assumed.
Title: Re: Bookmarks
Post by: whatsit on January 24, 2012, 03:00:11 AM
Quote from: teos55 on January 09, 2012, 03:35:26 PM
SMF 2.0.2  Simple Portal 2.3.4    Default theme

  Installed  bookmars2.4 sucssesfuly. No error messages, only subs.php failed due to some other mod's change so I manually added the code before calendar as indicated.

  Now, only admin sees the buttons but not the normal users.

What to check ?

It's urgent,  since I announced the mod to the users !!! 

--------------------------------------

FOUND ...


  in permissions, it has to be enabled for normal users. It's not mentioned anywhere, did I missed it ?

Thank you so much for that info.

I had NO IDEA about having to set permissions for all the mods. I don't know where it says that but it was not apparent to me.

You're a life saver - thank you.
Title: Re: Bookmarks
Post by: Ray Cardillo on January 27, 2012, 01:04:58 PM
I have been helping to maintain & improve a forum that's used for a private team site.  This bookmark mod was great, but it was not working on the old "core" theme on a 2.0 install (2.0.2 to be precise).  I had to make a quick change to the packaging info so I updated the version as well (even the 2.4 version published on the SMF mods site was incorrectly marked as 2.3 internally).  See attached 2.5 version that works on 2.0 "curve" and "core" themes.

By the way, if the original author is not around anymore, are there any Moderators around that can help turn this over as opensource so everyone can help maintain it?  Also, is there any way to give attribution to other contributors?

I'm kinda new to the SMF mod community, but I have another mod I'm currently working on that I intend to publish soon, and I would like to submit it to the community so others can help maintain it once I'm done just like what I've done with Bookmarks... my way of giving back to the community.  :)  So any advice would be appreciated.

Title: Re: Bookmarks
Post by: Herman's Mixen on January 27, 2012, 01:13:35 PM
Aaron is sometimes around here you could pm him here to authorize maintenance of his mod if he is willing to do that ;) 
Title: Re: Bookmarks
Post by: Illori on January 27, 2012, 01:24:39 PM
sorry only the original author can give anyone else approval to update the mod and distribute it so your version has been removed.
Title: Re: Bookmarks
Post by: Ray Cardillo on January 27, 2012, 02:04:21 PM
Quote from: Illori on January 27, 2012, 01:24:39 PM
sorry only the original author can give anyone else approval to update the mod and distribute it so your version has been removed.

Oh, sorry, did not realize that... I didn't see any license agreement in the zip file or anything like that so I assumed it was an open license.  I think it's obvious that I was just trying to help.  Other communities do stuff like this to help their "mod community" grow and be self-maintained.  Does SimpleMachines have any sourceforge sites to fulfill this purpose or anything like that?  It would be a great way to have the community grow "organically" without any one author needing to always be responsible... everyone benefits and can contribute as they have time... plus the old "if I were hit by a bus tomorrow" argument... it would suck if nobody else in the community were allowed to make contributions.

So if it's not being done already, I think it would definitely be considered.  Thoughts?
Title: Re: Bookmarks
Post by: Illori on January 27, 2012, 02:24:31 PM
we dont have any like sf, and the mods unless they include a license are considered be a closed license.

we have to go along with the license, even if the author does not update the mod it is still their property.
Title: Re: Bookmarks
Post by: Aaron on February 07, 2012, 02:20:17 PM
Version 2.5 was released minutes ago. It's changelog reads:
Title: Re: Bookmarks
Post by: Matthew K. on February 07, 2012, 02:42:39 PM
Nice to see you stopping back in occasionally, Aaron! :)
Title: Re: Bookmarks
Post by: Illori on February 07, 2012, 05:17:41 PM
for some reason the mod will not parse on the mod site

"Sorry, but the modification could not be parsed."
Title: Re: Bookmarks
Post by: Herman's Mixen on February 07, 2012, 05:23:11 PM
coz of some of the changes what are made into the mod site ;)
Title: Re: Bookmarks
Post by: Illori on February 07, 2012, 05:25:34 PM
Quote from: The Burglar! on February 07, 2012, 05:23:11 PM
coz of some of the changes what are made into the mod site ;)

and what does that mean? there have not been changes to the mod site recently that would break the parser.
Title: Re: Bookmarks
Post by: Herman's Mixen on February 07, 2012, 05:39:47 PM
i'll have seen more mods who didnt parse the last few days ;) so i assumed they ware working on it as ricky said if i am right not sure dont remember the bits
Title: Re: Bookmarks
Post by: Illori on February 07, 2012, 05:41:09 PM
they are not working on the mod site currently, if a mod does not parse report it to the author so they can look into it.
Title: Re: Bookmarks
Post by: Coyote Keith on February 09, 2012, 01:32:38 PM
v2.0.2 and I can't seem to load this mod. When I try to upload the zip from my local PC I get this message

Package upload failed due to the following error:
"Although the package was downloaded to the server it appears to be empty. Please check the Packages directory, and the "temp" sub-directory are both writable. If you continue to experience this problem you should try extracting the package on your PC and uploading the extracted files into a subdirectory in your Packages directory and try again. For example, if the package was called shout.tar.gz you should:
1) Download the package to your local PC and extract it into files.
2) Using an FTP client create a new directory in your "Packages" folder,