Simple Machines Community Forum

Customizing SMF => SMF Coding Discussion => Topic started by: Old Lynx on July 09, 2008, 06:50:06 AM

Title: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 06:50:06 AM
Hello everyone

I have managed to get an  Auto Link Checker Bot for phpbb from another forum, and I really want it installed on my forum which is running SMF. So I am looking for someone to convert it for me to SMF, not for free of course :) I am willing to pay $50 to whoever does it :)

If anyone is interested then please let me know. the bot is attached to this post of mine.

I have it for phpBB2 and phpBB3.

Mod/Admin: if this is the wrong section to post this in, please forgive me and move this topic to the correct area.

Thanks, any help would be GREATLY appreciated.

Thanks Guys

*mod file was removed - but I now see permission has been granted - feel free to reattach it.*
Title: Re: Converting a phpBB bot for SMF
Post by: Night09 on July 09, 2008, 07:05:54 AM
Not sure if its intentional or your unaware the attachment has got password protection so no one will be able to look at the code.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 07:09:05 AM
oooops sorry nightbre :)

you are right :) the password is {{ hawke@warez-bb.org }}

I forgot to put it :)
Title: Re: Converting a phpBB bot for SMF
Post by: Eliana Tamerin on July 09, 2008, 10:42:08 AM
You would need to obtain the original author's permission to do this. A mod cannot be converted without permission.

I'm a little suspicious about why it was distributed on warez-bb.org. Makes me wonder if the mod is supposed to be paid for. If that's true, then you're illegally in possession of such a mod, and should dispose of the files until you obtain it legally.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 10:47:23 AM
do you want me to link you to the topic on Warez-BB ?? I read it and the original guys who worked on this said I could convert it to SMF .. not a problem as long as I give them credit for it :) (i.e. not say I made this Mod ... etc etc)

The whole topic on there is called { Auto Link Checker Bot - Link Detective (Script Released!) }

its 66 pages and I read them all :) Our good man Hawke has released it to the public as you can see from the topic subject :) However just to prove to you that I ain't lying Dear Eliana (nice name by the way) here is a link :)

http://www.warez-bb.org/viewtopic.php?t=969901&start=0

Thanks

Ohh by the way Can you do it ? lol
Title: Re: Converting a phpBB bot for SMF
Post by: Eliana Tamerin on July 09, 2008, 11:08:21 AM
Well, here's the suspicious part: http://www.tamilfusion.net/forum/viewtopic.php?t=648

Looks like a copy/paste to me. Which users on warez-bb are notorious for, along with every other warez sharing site. I'd suggest contacting the author's email listed in the install.xml and obtaining permission that way.

And btw, I read your request for a conversion on that topic, and the "author" (if that is him) never actually gave you permission.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 11:14:05 AM
hmm Ok I'll do that ! I'll open the install.xml and look for an e-mail in there.

Once I find the e-mail in there >> I'll send him an e-mail and ask him if I can convert it to SMF. I'll quote his reply on here :) Is that the correct way ? if not, and I've missed something let me know please ! :)

I don't understand though.. why would Hawke on W-BB say " Hi Guys just thought id post some info on a script that ive been writing, as its now fully working on my tes site. "

That seems evil to me :( and he doesn't look like the evil type
Title: Re: Converting a phpBB bot for SMF
Post by: Eliana Tamerin on July 09, 2008, 11:21:10 AM
I wouldn't dare underestimate the ability of some people to steal credit and claim as their own, even going so far to support it. It seems far fetched, but it's happened.

Anyways, yes, that would be the correct procedure. Besides, he never did reply to your post, so this way you'll be sure he sees your request.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 11:30:47 AM
OK I'm in the middle of writing the e-mail to him :) I'll be back here when I get his reply

Thanks Eliana for showing me the correct way to do things ;) MUCH APPRECIATED :)
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 11:39:56 AM
Eliana in the install.xml it shows this ...

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi36.tinypic.com%2F2gtdkz6.jpg&hash=e30083d028f0ecf3b7480f9505aa654a)

I try sending e-mails to that e-mail address but I keep getting a failure notification from hotmail, which suggests the e-mail address is either wrong or doesn't exist :(
Title: Re: Converting a phpBB bot for SMF
Post by: Night09 on July 09, 2008, 07:09:11 PM
See if you can find the mod anywhere else to check if theres updated details listed in a new version maybe
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 09, 2008, 08:50:56 PM
I've checked a couple of sites and the Author info is the same on all of them !
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 11, 2008, 07:49:28 PM
Hi again :)

Ok here is what I got from the great guys at W-BB.

Quote
Tell em I say its ok. :D

This script is not stolen as the mod author posted this thread with the links to download his mod (Updated versions somewhere around page 60ish) and wrote this himself so if it is stolen, Hawke stole it from himself. lol

With the help of a few members, We just updated took over and updated it where he left off and he has been very supportive with us updating it.

Hawke is super busy with other behind the scenes stuff here and doenst have much time to check the thread but I am sure he wont mind. Maybe PM me the site or point them to this thread. As long as all the credit is left in place in the files as is now then all is good. :D

CONVERT AWAY ALREADY! :D Plus, I might set up a SMF test forum and if this would work with it and I like SMF I might make the switch.

Now can someone help me !! :( ....PLEASEEEEEEEEEEE
Title: Re: Converting a phpBB bot for SMF
Post by: Hippie459MN on July 11, 2008, 09:41:21 PM
First of all I would like to say hello.

Next I would like to say that it is ok for this to be converted as I have worked on this with Hawke recently and this mod is his and he has publicly released it so no it is not stolen or anything of that nature. The only think we ask is that all the correct credit goes out to everyone in the original pbpBB install files.

I myself would convert this but I have no clue about SMF at all and my job right now does not allow me much time so even if I did myself it would be a year before I got it done. lol

You would need to obtain the original author's permission to do this. A mod cannot be converted without permission.

I'm a little suspicious about why it was distributed on warez-bb.org. Makes me wonder if the mod is supposed to be paid for. If that's true, then you're illegally in possession of such a mod, and should dispose of the files until you obtain it legally.

The reason it was distibuted on WBB is that he is one of the Deleloper Team Leaders at warez-bb and does alot of the phpbb coding for them.

Again, Hawke has made this version a public release.


Well, here's the suspicious part: http://www.tamilfusion.net/forum/viewtopic.php?t=648

Looks like a copy/paste to me. Which users on warez-bb are notorious for, along with every other warez sharing site. I'd suggest contacting the author's email listed in the install.xml and obtaining permission that way.

And btw, I read your request for a conversion on that topic, and the "author" (if that is him) never actually gave you permission.

Look again... Download the file and you will see that the person apears to be taking credit for everything in the post but if he is he forgot to change the install files so it shows himself as the mod developer and not Hawke as the mod developer. Looks like the person at that link is the guilty one of copy paste. Better check you facts before you say that someone is guilty of riping it off when in fact its the person in the link you posted that is the one riping it off. :D

Thats is a major copy past from WBB.

By the way, I do agree on the most users are great for that copy paste thing. Not just at warez sites (Just seems that way) but anywhere. :)


I wouldn't dare underestimate the ability of some people to steal credit and claim as their own, even going so far to support it. It seems far fetched, but it's happened.

Anyways, yes, that would be the correct procedure. Besides, he never did reply to your post, so this way you'll be sure he sees your request.

Again, Hawke did not steal anything from anyone. He wrote this mod and with the help of a few others, Myself included.


See if you can find the mod anywhere else to check if theres updated details listed in a new version maybe

Yes there is an updated version. If you like I can post the link to download the file or the link the post on WBB. Just let me know. :D

Eliana in the install.xml it shows this ...

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi36.tinypic.com%2F2gtdkz6.jpg&hash=e30083d028f0ecf3b7480f9505aa654a)

I try sending e-mails to that e-mail address but I keep getting a failure notification from hotmail, which suggests the e-mail address is either wrong or doesn't exist :(

That email is no good anymore and to respect him I will not be posting it. Sorry. :(

With all that said, Convert away!!! I wanna see it in action when your done if someone is willing to take on the task. :D
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 12, 2008, 05:31:05 AM
awesome thanks Hippie459MN :)

Sorry about the e-mail friend :)

OK now that Mr. Hippie459MN had made it all CLEAR.....NOW can someone convert it to SMF ???? PLEASE !!

Thanks Guys
Title: Re: Converting a phpBB bot for SMF
Post by: Eliana Tamerin on July 12, 2008, 10:35:59 AM
Thanks for the clarification, Hippie459MN. We can never be too careful here, people think up all kinds of nasty ways to get even if they think somebody has stolen their code. It's just easier to ensure that we have the right permissions first. And I apologize for my suspicion on the warez site, I hate to have to do that but it is unusual for something to be distributed on a warez site with full permissions and such.

Old Lynx, if somebody wants to convert it.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 13, 2008, 06:22:52 PM
I've just updated my first post with the latest version of the script. the latest version where Mr Hippie459MN and others worked on improving the script.

So can someone PLEASE convert this for us !! PLEASE :(
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on July 17, 2008, 12:40:15 PM
Someone Please help :(
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 07, 2008, 02:04:51 PM
Someone Please help :(
Hi,
this mod is something I also need at my own SMF 1.1.5 forum.

I have downloaded the phpbb mod and looked into the code and its not easy to understand cause the structure of phpbb and SMF is slightly different 8).

But I will give it a try and look if I can convert it to an SMF mod.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on August 07, 2008, 06:04:33 PM
AWESOME

finally someone who is willing to help

Thank You Lanthan :)
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 13, 2008, 03:44:35 PM
Hi folks,
okay a little status update...

basic functionality is running, the system logs every rs-link and the linkchecker checks against rs and marks the rs-links as alive or dead.

So stay tuned.
Lanthan
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on August 13, 2008, 06:19:59 PM
Wow AWESOME :)

thank you Lanthan

I'm getting VERY excited :D
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on August 14, 2008, 05:54:53 AM
yay thanks to the tiopic cretor as well as Lanthan for converting the mod i will be waitng for this mod ....as my site has many dead links :D
Title: Re: Converting a phpBB bot for SMF
Post by: DomDom Skye on August 21, 2008, 03:09:48 PM
I'm searching also a mod for SMF like this. Hope it will come out soon.

Dom
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 21, 2008, 07:53:14 PM
Okay folks,
the next status update:
basic functionality is implemented, sorry for the delay but the coding guidelines of SMF had to be implemented.
The only thing that is missing is the admin panel, all parameters are hardcoded at this point.

If someone want to do an alpha test, he can give me an PM, but keep in mind at this point of development you can only install it manual.
I think I can release a first paket install next week for testing.
Title: Re: Converting a phpBB bot for SMF
Post by: Old Lynx on August 22, 2008, 03:57:46 AM
Awesome bro

to us who have Warez Forums you are an angle sent from above :) lol THANK YOU THANK YOU THANK YOU :D
Title: Re: Converting a phpBB bot for SMF
Post by: matasanos on August 22, 2008, 10:05:10 AM
awesome!!!!!!!!!!!!

waiting for it

thanks
Title: Re: Converting a phpBB bot for SMF
Post by: [SiNaN] on August 23, 2008, 11:30:03 AM
Well, I was unaware of this topic and we in the Turkish Language Support board were working a bot that has the same functionality.

What I did so far is that, it checks the rs link is dead or not. If dead, leaves a message and sends pm/mail to the author of post.

As you are working on this mod, I'll not work on it anymore. If you need help in admin panel, just ask.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 25, 2008, 10:54:14 AM
If you need help in admin panel, just ask.
Thanks SiNaN, but I think I have solved my problems at the weekend with the Admin CP.
At this time I'm testing it, together with Eliana Tamerin (many thanks for her quickly build package!).

I think if all goes okay, I will release it here in the next days for beta-testing, cause all features have been implemented.

Attached you find a screen of the admin cp.
Title: Re: Converting a phpBB bot for SMF
Post by: [SiNaN] on August 25, 2008, 11:00:45 AM
Okay, good luck with it.
Title: Re: Converting a phpBB bot for SMF
Post by: BuЯЯЯЯaK on August 25, 2008, 11:05:36 AM
Good work I'm waiting for mod .
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 25, 2008, 11:14:06 AM
Okay, good luck with it.
Thanks, I hope I will have ;)

If you want you could provide me with a turkish language file, so I could attach it to the mod.
By the way, is there an easy way to add a custom button at the modsetting page, I could use it for manual executing the RS-Linkchecker?
Title: Re: Converting a phpBB bot for SMF
Post by: [SiNaN] on August 25, 2008, 11:19:06 AM
Well, as far as I know; there is only one way to add a button to the mod settings.

Burak will provide the Turkish translation I hope.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 25, 2008, 11:30:58 AM
Well, as far as I know; there is only one way to add a button to the mod settings.
And its easy to implement or do I have to edit the template for that?

Burak will provide the Turkish translation I hope.
That would be great...
Title: Re: Converting a phpBB bot for SMF
Post by: [SiNaN] on August 25, 2008, 11:48:39 AM
Ahh, I just got what you mean. I usually use my own templates in the mods. But as you just need a single button; you can make it to display a button in template_show_settings() sub template in Admin.template.php. Of course with an if statement, cause that sub template is used almost in every section on Admin CP. It will not make it hard to install cause custom themes *mostly* do not include an Admin.template.php file.
Title: Re: Converting a phpBB bot for SMF
Post by: matasanos on August 26, 2008, 02:43:53 PM
i can provide spanish translation

good work!!
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 26, 2008, 03:51:07 PM
i can provide spanish translation

good work!!
Great, download the language file above, and if you send me the translation I will put it into the package...
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 26, 2008, 04:41:00 PM
Okay folks I need help!
I have a problem with a part of the original code of hawke.
It's a problem in the display of checked Links.
In display.php the code modifies the displayed links to show the status of a rs link.
This is done by parsing the message['body'] for the rs-link.
This normally works as expected, but if you use formatting codes for the tag of the link, it fails.
The parsing is done by a regular expression, so I would need help from someone who is a regular expression crack.
This is the code:
Code: [Select]
   $pattern = '|(<a href=")?(http://(www\.)?rapidshare\.com/files/([0-9]+)/([^\s<>",]+))(("[^>]*>)([^<]+)</a>)?|i';
   $message['body'] = preg_replace_callback($pattern, 'Linkbot', $message['body']);

The function linkbot:
Code: [Select]
function Linkbot($matches) {
//            01           2    3                                4        5            67        8
//$pattern = '|(<a href=")?(http://(www\.)?rapidshare\.com/files/([0-9]+)/([^\s<>",]+))(("[^>]*>)([^<]+)</a>)?|i';
echo ' : ' . $matches[8];
if ($matches[1] != '') {
$GLOBALS['links_to_check'][$matches[4]] = $matches[2];
$GLOBALS['anchor_text'][$matches[4]] = $matches[8];
// <a href=""> type
return $matches[1] . $matches[2] . $matches[7] . 'testRsComLink{' . $matches[4] . '}</a>';
} else {
$GLOBALS['links_to_check'][$matches[4]] = $matches[0];
// Plain text url type
return 'testRsComLink{' . $matches[4] . '}';
}
}

To give an example of which code is working, and which is not:
This works:
Code: [Select]
<a href="http://rapidshare.com/files/123456789/test.rar" target="_blank">Testlink1</a>
This not:
Code: [Select]
<a href="http://rapidshare.com/files/137196798/Publ1-1.rar" target="_blank"><b>Testlink2</b></a>

Hope someone can help, cause if not I'll have to disable this feature.

Best Regards
Lanthan
Title: Re: Converting a phpBB bot for SMF
Post by: matasanos on August 29, 2008, 09:40:07 AM
no luck?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 29, 2008, 11:05:47 AM
no luck?
No, unfortunatly not.

So I will disable the feature for customized Links.
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 29, 2008, 04:24:32 PM
so basically it will only work for rs links?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 29, 2008, 05:21:52 PM
so basically it will only work for rs links?
Yes, cause it uses a web api of rapidshare to check the status of the links.
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 29, 2008, 09:23:12 PM
maybe you can look at the rapidleech script for some examples.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 30, 2008, 05:45:17 AM
I will have a look at it in the future, but for now ist only for RS.
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 30, 2008, 10:36:29 AM
works for me.....can you give an estimated percentage of completion?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 30, 2008, 10:51:06 AM
Yes off course...
I'm finishing the last feature fo this mod for version 1.0 at this moment.
I have found the bug in the regular expressions, so that the links are working again.

So I will release it as a beta at this weekend.

But one question hadesflames, the rapidleech script is able to check the existence of megaupload files? Or ist it only able to copy the files and if it does not exist anymore on the server it gives an error?
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 30, 2008, 11:22:51 AM
idk I don't use rapidleech =/ although i would think it would give an error if the file is no longer available on MU.....thats something you might want to ask to the coders of rapidleech at their website
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 30, 2008, 11:43:50 AM
idk I don't use rapidleech =/ although i would think it would give an error if the file is no longer available on MU.....thats something you might want to ask to the coders of rapidleech at their website
So I think its not possible to use it with other filehosts. The point is , that rapidshare has an own web function to check for the existence of a file. The script uses this function, it does not try to catch the file and then reacts on the error message.

Btw I have finished the work and will release a Beta for testing soon.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 30, 2008, 11:55:38 AM
Okay folks,
this is the first beta release of RSLinkchecker.
Its Version is 0.9, and its feature complete. If beta works okay, the version is raised to 1.0

Rapidshare LinkChecker 0.9.2 Beta
based on the work of hawke

Features:
Configurable messages for dead links PM and moved topics replys.
Configurable percentage for both, sending a PM and moving the topic.
Configurable board to which a dead link topic is moved (global setting).
Configurable board to which a dead link topic is moved (board setting, it overwrites global setting).
No move and PM for already moved topics.
uninstall script

You have to install a cronjob on your server to hav it working ($boarddir."/cronrschecker.php").

Configuration of the mod:
Create a new user for the linkbot.
Create a new board (or more), or use an existing, for the moved topics

The complete configuration is controlled thru the Admin Panel. You can find the Panel at the global Forum Features and Options.
Additional you can configure a specific Board to move dead links to at the board configuration.
ATTENTION!
If you use the board depending setting you MUST specify at the move board itself as the target move board!
If you don't do that, it will be moved to the board in the global setting.

Use it at your own risk, tested only on clean installed SMF 1.1.5

Turkish translation provided by Burak
Thanks to Eliana Tamerin
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 30, 2008, 06:49:50 PM
I shall be your first beta tester =] let you know if i run into anything wierd =P
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 30, 2008, 07:01:20 PM
Heres your first feedback:

when running "cronrschecker.php" file fails because linkbot.php is not available to open.

to fix the problem you must either chnage the file name in /Sources/linkbot.php to Linkbot.php (L is not capitalized)

other solution change the link in the cronrschecker.php to Sources/Linkbot.php

I have attached a new install addressing the above error.

EDIT:

ok i tried out the bot after fixing the above error, and did so by posting a dead link (it is the ONLY link available in the post but the bot does not bin it.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 30, 2008, 07:36:30 PM
Ups. damn windows.. on my windows xampp testing machine this didn't came up, sorry!
I've corrected this and attached a fixed version, thank you for your correction.

okay, to the other problem. You have made the post with an inactiv link. Then you have started the cronrschecker.php, If you view the post again, there must be a message at the bottom of the post mentioning the status of the links. What do you see at the bottom is there anything?

One thing to mention, the checker only rechecks the links if the last check is 60 minutes gone.
To make it quicker check you have to erase the content of rs_links table.

Another thing is, you need the CURL library activated for php for checking the links. On my host its activated by default, but I don't know if its activated on your machine.

Thanks for your feedback!
Lanthan
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 30, 2008, 10:11:00 PM
well theres nothing posted under it and it is supposed to bin it because i set it to board 24...I'll ask about CURL
Title: Re: Converting a phpBB bot for SMF
Post by: enarsee on August 30, 2008, 11:24:35 PM
didnt bin it

hey n one more thing if the link is working

does it post

"Link Checker @ xyz time"?
Title: Re: Converting a phpBB bot for SMF
Post by: enarsee on August 30, 2008, 11:51:02 PM
and i didnt get a mail that cronjob is running
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 31, 2008, 12:03:06 AM
for that you would have to ask your server host =P
Title: Re: Converting a phpBB bot for SMF
Post by: enarsee on August 31, 2008, 01:16:24 AM
i added a cronjob

home/username/public_html/forum/cronrschecker.php

Every hour
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 31, 2008, 07:24:02 AM
@hadesflames and enarsee,
you can check for curl with phpinfo.php. There are two ways to run it, first the usual way, copy the phpinfo.php to your forumdirectory and execute ist, second you can try to install this smf mod:
http://custom.simplemachines.org/mods/index.php?mod=574 (http://custom.simplemachines.org/mods/index.php?mod=574)
It's for 1.1.4 and it should install if you modify the packageinfo file.

To execute the cronrschecker by hand, you can call it thru your web browser.
Code: [Select]
www.yourforumurl.com/cronrschecker.php

But as I look at my code, I see something.... URGH....
First there is a hidden feature, that I implemented for testing, and this is enabled in your version, but it shouldn't. Second I have found a big bug in examing links that need a refresh of the status.

Sorry for that, I attached a fixed version, please uninstall the old one and install this new one.

Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 31, 2008, 09:12:37 AM
After testing with this fixed version all is working fine with me =]

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi37.tinypic.com%2F2hwhheh.jpg&hash=4de822b08d8e456a3cfde4ee0b963050)
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on August 31, 2008, 11:14:40 AM
Okay folks next little update..

Thanks to hadesflames for his help!

This is only a minor update which has an additional spanish language file, and adds the forgotten turkish version.
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on August 31, 2008, 11:35:19 AM
according to my tests all features are working for now =]
Title: Re: Converting a phpBB bot for SMF
Post by: matasanos on September 03, 2008, 04:16:27 PM
probing...
Title: Re: Converting a phpBB bot for SMF
Post by: jOkErGuEsT on September 07, 2008, 07:20:01 AM
Has anyone had a problem about link checker bot?

Shall we use it?
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on September 07, 2008, 10:54:39 PM
everything is working fine with me cept cron (this is server issue nothing to do with the bot)
Title: Re: Converting a phpBB bot for SMF
Post by: Tick Tock on September 09, 2008, 09:32:58 AM
Can i take manuel install for this beta ? It doesn't work with SMF package parser...
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 10, 2008, 03:59:48 PM
The bot doesnt show "Links checked at (time) and 0% is dead, any idea why?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 11, 2008, 05:16:02 PM
The bot doesnt show "Links checked at (time) and 0% is dead, any idea why?
Are the links in the rs_links or rs_checker table?
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 16, 2008, 02:05:28 AM
ok i have installed this mod ....installed witout any problem....but it isnt detecting any dead links ...will it chk  link only of the post made after the mod installed or all the post in Db ?? ....help
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 16, 2008, 06:52:39 AM
ok i have installed this mod ....installed witout any problem....but it isnt detecting any dead links ...will it chk  link only of the post made after the mod installed or all the post in Db ?? ....help
Only viewed Links are checked. Do you have installed a cronjob, and did it run?
Title: Re: Converting a phpBB bot for SMF
Post by: tampaba1 on September 16, 2008, 07:13:15 AM
I've installed this mod on my board and it's working fine. It would be nice, though, if it could be expanded to include other hosting sites.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 16, 2008, 08:49:00 AM

Only viewed Links are checked. Do you have installed a cronjob, and did it run?

okay what do u meant by "viewed links"

yup i placed the cronrschecker.php in my sites root directory and when i run it i got rs link checker bot or something ...i dont rember exactly .... :)


okay i have started receving some pms  of dead link but to how many peorsons does the LC bot sneds the pm only the author or the  whole staff or the anyone who posted/viewed the thread
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 16, 2008, 09:55:01 AM
"Viewed" means that someone must have read the post with the links in it.
PM's are only send to the author of the post. After a check, the script will wait 60 minutes to check the links again, but only if someone read the post again.
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 16, 2008, 11:23:14 AM
The bot doesnt show "Links checked at (time) and 0% is dead, any idea why?
Are the links in the rs_links or rs_checker table?

Yes it is.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 16, 2008, 11:48:51 AM
Yes it is.
In which one? If they are in the rs_checker, then the script does not run.
The script copies all checked links from the rs_checker to the rs_links table.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 16, 2008, 12:21:38 PM
ok i most of my sites post have at least one view or more but many of them have not been checked by the LC bot ..... it picks up and check random posts :( ......
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 16, 2008, 12:31:56 PM
ok i most of my sites post have at least one view or more but many of them have not been checked by the LC bot ..... it picks up and check random posts :( ......
Random? I don't think so, cause he fetches from the table the link without specific order, he should use the order in which they have been viewed and therfore put in the table.

How much links are it? He only checks 100 at one time.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 16, 2008, 12:48:04 PM
well if u are asking about no of links per post .the average would be 10 links... is there anyway u could make the cp of Lc bot to show the no of links checked ... and no of dead links found .... :)
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 16, 2008, 02:16:25 PM
well if u are asking about no of links per post .the average would be 10 links... is there anyway u could make the cp of Lc bot to show the no of links checked ... and no of dead links found .... :)
The total Number in the Threads, no, but I can put the numbers of Links to check (rs_checker) and the total number of checked links and the total number of dead links (rs_links) in the admin panel. Good idea for next version!
At this time you can only query it by hand. Open the phpmyadmin and open your database. If your SMF table Prefix ist the standard this would give you the amount of unchecked links
Code: [Select]
SELECT COUNT(*) FROM smf_rs_checker

The Amount of all checked links:
Code: [Select]
SELECT COUNT(*) FROM smf_rs_links

The Amount of all checked links which are online:
Code: [Select]
SELECT COUNT(*) FROM smf_rs_links WHERE status=1

The Amount of all checked links which are dead:
Code: [Select]
SELECT COUNT(*) FROM smf_rs_links WHERE status=0
Title: Re: Converting a phpBB bot for SMF
Post by: DomDom Skye on September 17, 2008, 03:01:18 AM
Hi!

Where is the mod to test it?

Dom
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 17, 2008, 03:19:10 AM
http://www.simplemachines.org/community/index.php?action=dlattach;topic=248717.0;attach=66746

click on the above link to download it ....
Title: Re: Converting a phpBB bot for SMF
Post by: DomDom Skye on September 17, 2008, 03:33:41 AM
Thx!

Dom
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 17, 2008, 06:52:09 AM
any way to make this bot checkk each and evry thread of the forum regardless wheather it has been viewed or not :)
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 08:15:15 AM
Hmmm.. not so easy... but I understand what you want.
It's a precheck, or initialisation whats needed.

So give this little script a try:
precheckallrslinks.php

I have attached it to this post, you have to copy it to the boarddir where the cronrschecker script is located. Then call it from your browser. It should scan all your messages on the forum and put the unchecked ones into rs_checker.
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 17, 2008, 08:26:48 AM
Yes it is.
In which one? If they are in the rs_checker, then the script does not run.
The script copies all checked links from the rs_checker to the rs_links table.

Its links in rs_links and not in rs_checker, the bot does bin, but it doesnt edit a message in a topic "0% of the links are dead"
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 08:39:03 AM
Do you see the "0% of the links are dead" at the bottom of the post?
If yes, so all Links are valid, which you can see in rs_links in the field status (Value=1).
If no, do you have a custome theme which needs editing (display.template.php)?
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 17, 2008, 08:50:30 AM
okay i did what u said ..when i called the file from browser i  get "All Links fetched"  but when i go to post it still doesnt show the message that lc has checked the post etc etc
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 09:05:56 AM
okay i did what u said ..when i called the file from browser i  get "All Links fetched"  but when i go to post it still doesnt show the message that lc has checked the post etc etc
And did you call the cronrscheckerscript after that script? The submitted script only fills the rs_checker table with the links which needs checking, not more.
And remember, if you have more then 100 Links in it, you must call the cronrschecker script multiple times, until the rs_checker table is empty.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 17, 2008, 09:21:39 AM
okay it worked but its sending pm eveery staff member and not only the topic starter .... please help
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 09:33:04 AM
it should only send a PM to the post creator.. Not to the staff members.
But if you have a thread with e.g. 10 posts and every post is from a different Member, you would get 10 PM's in total to this members. One PM for every post.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 17, 2008, 09:35:36 AM
ohh...k but this could be a problem with popular thread .... which  has no of replies in them .... i think u should change it to make it alert only the author ,,,
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 09:41:40 AM
That would not make sense, cause the Thread Starter is only able to edit his own posts, not the posts of other members.
If you don't want at this time the bot to send PM's, disable it at the modsettings. After that no PM's are send. This is a feature for the first time when to much PM's would be send. After a week or so when all old links are checked, you can switch it on again.
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 17, 2008, 12:17:19 PM
Do you see the "0% of the links are dead" at the bottom of the post?
If yes, so all Links are valid, which you can see in rs_links in the field status (Value=1).
If no, do you have a custome theme which needs editing (display.template.php)?

Value=0 so I guess I need to edit the theme, but where in display.template do I need to edit?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 12:25:46 PM
Value=0 so I guess I need to edit the theme, but where in display.template do I need to edit?

Hope this works for you:
Code: [Select]
Display.template.php:
Search for this:
echo '
</td>
</tr><tr>
<td valign="bottom" class="smalltext" id="modified_', $message['id'], '">';

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';


Add before:
// RS Linkchecker Display the bot message
echo '
</td>
</tr><tr>
<td valign="bottom" class="smalltext" >';
if (!empty($message['botcheck']))
echo '
', $message['botcheck'];
      // End RS Linkchecker Display the bot message
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 17, 2008, 12:58:32 PM
Value=0 so I guess I need to edit the theme, but where in display.template do I need to edit?

Hope this works for you:
Code: [Select]
Display.template.php:
Search for this:
echo '
</td>
</tr><tr>
<td valign="bottom" class="smalltext" id="modified_', $message['id'], '">';

// Show "« Last Edit: Time by Person »" if this post was edited.
if ($settings['show_modify'] && !empty($message['modified']['name']))
echo '
« <i>', $txt[211], ': ', $message['modified']['time'], ' ', $txt[525], ' ', $message['modified']['name'], '</i> »';


Add before:
// RS Linkchecker Display the bot message
echo '
</td>
</tr><tr>
<td valign="bottom" class="smalltext" >';
if (!empty($message['botcheck']))
echo '
', $message['botcheck'];
      // End RS Linkchecker Display the bot message

Yeah it works, one little thing, Its Says 'forum name'(where the topic is inside) Bot checked this like at ....

how do I remove the 'forum name' from the bot message?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 17, 2008, 02:00:22 PM
For this you have to edit the display.php, thats the only way and will prevent the script to uninstall properly!
Code: [Select]
Find this in diplay.php
         $bottext = "<b>" . $board_info['name']. " " .$linkbot_name. " " .$txt['rslinkbot_body_start'] . " " . timeformat($message['botchecktime']) . " ".$txt['rslinkbot_body_middle']." " . $message['botpercentdead'] . $txt['rslinkbot_body_end']. "</b>";

change it to:
         $bottext = "<b>" .$linkbot_name. " " .$txt['rslinkbot_body_start'] . " " . timeformat($message['botchecktime']) . " ".$txt['rslinkbot_body_middle']." " . $message['botpercentdead'] . $txt['rslinkbot_body_end']. "</b>";
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 18, 2008, 05:30:19 AM
any chances of making this work with .... all the popular file uploading servcies....and one more silly question ...it is just out of curiosity .....


to check the rs links the bot must connect to rs server and to that some coding would be required......


is there any way that i can get the code for all the other popular file sharing services and add it in the mod and it checks all those file services also ....  ;) ;)
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 18, 2008, 09:27:47 AM
I have found a similar script from another team which is able to check other upload sites. I'll get in contact with them, asking if I can use their regular expessions to check for more links.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 18, 2008, 12:22:24 PM
i think that team would be maxwcoders ....as they also have their LCB posted at warez-bb ...if yes it is the team.... i know the code who coded that boot and if u want  i can ask him... for that...
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 18, 2008, 12:25:50 PM
You're right, I'm in contact with dman at this moment.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 18, 2008, 03:08:13 PM
And I have a GO from him.

So this will be one of the next features I'll implement.

But now, I'm waiting for approval of this mod (Vers. 1.0) from the SMF-Team. So I have made a feature freeze at this time.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 19, 2008, 02:34:14 AM
yay,,,waiting for the updated version.... :)
Title: Re: Converting a phpBB bot for SMF
Post by: Dman91 on September 19, 2008, 07:57:10 AM
Great Work Lanthan :)
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 20, 2008, 05:34:31 AM
i uninstalled and installed the mod again and got a error in mod settings.php ....what are the edits need t be made there??
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 20, 2008, 06:36:53 AM
@dman91: Thank you.

@keshav: The package installer raises an error?
Code: [Select]
in ModSettings.php find:
$context['page_title'] = $txt['modSettings_title'];
$context['sub_template'] = 'show_settings';

$subActions = array(
'basic' => 'ModifyBasicSettings',
'layout' => 'ModifyLayoutSettings',
'karma' => 'ModifyKarmaSettings',

Add After:
'rslinkchecker' => 'RSLinkcheckerSettings',

Find:
$sourcedir . '/ManageServer.php');

$subActions = array(
'basic' => 'ModifyBasicSettings',
'layout' => 'ModifyLayoutSettings',
'karma' => 'ModifyKarmaSettings',

Add after:
'rslinkchecker' => 'RSLinkcheckerSettings',

Find:
'is_last' => true,
),

Replace it with:
),
'rslinkchecker' => array(
'title' => $txt['rslinkbot_managesettings'],
'href' => $scripturl . '?action=featuresettings;sa=rslinkchecker;sesc=' . $context['session_id'],
'is_last' => true,
),

Find:
?>

Add before:
// Modify all settings related to the RSLinkChecker.
function RSLinkcheckerSettings()
{
global $txt, $scripturl, $context, $settings, $sc;

$config_vars = array(
//RSLinkchecker Settings?
array('check', 'rslinkbot_enable'),
array('text', 'rslinkbot_name'),
array('int', 'rslinkbot_userid'),
'',
array('check', 'rslinkbot_sendpm'),
array('int', 'rslinkbot_post_percentage'),
array('check', 'rslinkbot_movetopic'),
array('int', 'rslinkbot_thread_percentage'),
array('int', 'rslinkbot_deadboardid'),
$txt['rslinkbot_post_settings'],
array('text', 'rslinkbot_dead_postsubject','40'),
array('large_text', 'rslinkbot_dead_postbody','10'),
$txt['rslinkbot_pm_settings'],
array('text', 'rslinkbot_dead_pmsubject','40'),
array('large_text', 'rslinkbot_dead_pmbody','10'),
);

// Saving?
if (isset($_GET['save']))
{
saveDBSettings($config_vars);
redirectexit('action=featuresettings;sa=rslinkchecker');
}

$context['post_url'] = $scripturl . '?action=featuresettings2;save;sa=rslinkchecker';
$context['settings_title'] = $txt['rslinkbot_managesettings'];

prepareDBSettingContext($config_vars);
}

Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 20, 2008, 06:49:06 AM
thanks for it .... but the modifications had already been done in mod setings.php  dont know why it showed the error ...and thank you very much for this excellent mod... :)
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 20, 2008, 06:53:41 AM
hmm... after isntallation it is recechking all the links which were allready binned by  it earlier :((
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 20, 2008, 09:02:15 AM
Yepp.. its a "complete uninstall". It drops all tables it creates. If you want to prevent this, you have to make a backup of the rs_links/messages tables BEFORE you deinstall the mod.
As an alternative you can delete the file remove_settings.php from the installation file before you install it the first time.

I have attached 2 Versions of the install file for version 1.0 to this post. The one is with complete deinastallation, the other one leaves the settings untouched.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 20, 2008, 09:23:23 AM
thanks for it .... but the modifications had already been done in mod setings.php  dont know why it showed the error ...and thank you very much for this excellent mod... :)
What error comes up in the modsettings?
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 20, 2008, 10:28:33 AM
Code: [Select]
Dead RS-Links found in
« Sent to: ~Mr DJ~, Nitish, jitesh11, *Shubham*, Ridhima-The Princess, monsterofblack, Exiles on: Today at 07:53:57 PM »

this pm was sent to me by the LCB there was only one post no reply was posted in the thread but it still sends the email to so many member.... why???

Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 20, 2008, 11:04:38 AM
hey man please check this mod sometimes it gets out of control.....i disabled pm sending and still it sends pm...... disabled the mod itself but it still kept checking the links ...... ultimately i had to uninstall it again......
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on September 20, 2008, 01:11:38 PM
good to see you released 1.0.0 =D have u added to the mod dl page?
Title: Re: Converting a phpBB bot for SMF
Post by: ne.miguelito on September 20, 2008, 02:25:43 PM
Can I post links inside code with the rapidshare links, like links of megaupload?

The mod keeps working fine if I do that?

One more thing, there is some possibility on the mod send a personal message only to the member who sent the topic, and if there is the option to don't move the topic and do not send answer to the topic?

Thanks for the mod.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 20, 2008, 02:54:15 PM
good to see you released 1.0.0 =D have u added to the mod dl page?
Yes I have submited it, but yet its not approved by the SMF team.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 20, 2008, 03:03:16 PM
hey man please check this mod sometimes it gets out of control.....i disabled pm sending and still it sends pm...... disabled the mod itself but it still kept checking the links ...... ultimately i had to uninstall it again......
Ohh I know what happend... Please search in table "settings" for the following:
Field Variable, Values (without quotes):
'rslinkbot_enable'
'rslinkbot_post_percentage'
'rslinkbot_thread_percentage'
'rslinkbot_userid'
'rslinkbot_name'
'rslinkbot_deadboardid'
'rslinkbot_dead_postsubject'
'rslinkbot_dead_postbody'
'rslinkbot_dead_pmsubject'
'rslinkbot_dead_pmbody'
'rslinkbot_sendpm'
'rslinkbot_movetopic'

They all should be twice in the table. Always delete one of them, this should fix your problem, after reapplying your settings.

Regarding the double PM's I have to check the code, I don't understand yet why it happens.

Little Update, you can use the script remove_and_reapply_settings.php in the attachment to do this. I have also attached a little modification of the linkbot.php script. Please tell me if with this script the double PM's are gone.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 21, 2008, 12:28:05 AM
Code: [Select]
Warning: Invalid argument supplied for foreach() in /home/dalegend/public_html/Sources/Subs-Post.php on line 717

Warning: Invalid argument supplied for foreach() in /home/dalegend/public_html/Sources/Subs-Post.php on line 717

Warning: array_unique() [function.array-unique]: The argument should be an array in /home/dalegend/public_html/Sources/Subs-Post.php on line 755

Warning: array_unique() [function.array-unique]: The argument should be an array in /home/dalegend/public_html/Sources/Subs-Post.php on line 758

Warning: array_diff() [function.array-diff]: Argument #1 is not an array in /home/dalegend/public_html/Sources/Subs-Post.php on line 758

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in /home/dalegend/public_html/Sources/Subs-Post.php on line 761

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in /home/dalegend/public_html/Sources/Subs-Post.php on line 761

Warning: implode() [function.implode]: Invalid arguments passed in /home/dalegend/public_html/Sources/Subs-Post.php on line 772

after installig v1.0 i get these errors when i run that cronrschecker.php
Code: [Select]
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')
ORDER BY mem.lngfile
LIMIT 0' at line 8
File: /home/dalegend/public_html/Sources/Subs-Post.php
Line: 774
look at this picutre for better understanding... :)
http://img87.imageshack.us/img87/8866/76463942en1.jpg


and do check your pm also......
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 21, 2008, 07:21:52 AM
Hi keshav,
I have found the issue with the PM's, it adresses the mentionend errors too.

Use the attached linkbot.php and copy it to the sources dir.
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 21, 2008, 08:14:49 AM
okay gonna try it and post a feddfack soon.. :D
Title: Re: Converting a phpBB bot for SMF
Post by: DareDevil1990 on September 21, 2008, 08:24:17 AM
okay now i think its working fine...but i will ask the sam equestion again...when can we epect it to check other file uploading site... :P


update: now it seems to send no  pms at all...  :'(
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 21, 2008, 09:42:30 AM
That's something I can't believe. I have checked it at my testsite and he sends me the pm's.
But only if 60 minutes have elapsed since last time he checked it, and the links are not in the bin board.
Title: Re: Converting a phpBB bot for SMF
Post by: M@nNiak on September 24, 2008, 07:02:03 PM
Hi lanthan great job, I have a request, can you put the instructions so i can install this mod in my smf forum manually?

thanks.
Title: Re: Converting a phpBB bot for SMF
Post by: Tick Tock on September 25, 2008, 05:19:48 AM
By the way it doesn't work for my forum, but thanks for pms Lanthan.Im waiting for mod.Maybe its will work...
Title: Re: Converting a phpBB bot for SMF
Post by: owvvwo on September 26, 2008, 01:34:01 PM
hello,
great work you doing... thankyou


i face some problem

e.g (check the attachment image)

i cant understand how this check base on?
Title: Re: Converting a phpBB bot for SMF
Post by: owvvwo on September 27, 2008, 04:23:07 AM
i have another error (worning message)
Code: [Select]
Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245

Warning: Division by zero in /home/xxxxxxxx/public_html/xxxxxxxxxxx/Sources/Linkbot.php on line 245
RS Linkchecker Bot
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 28, 2008, 05:30:16 AM
The bot bin one topic and then it creates like 20 new topics with 20 posts in each in the dust bin just saying dead links found over and over again, can you fix that please?
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 28, 2008, 07:58:03 AM
hello,
great work you doing... thankyou
Thanks!

i face some problem
  • i am using "Automatically link posted URLs" option and "Registered Links" mods.. this cause problem links looking different

e.g (check the attachment image)
I know this problem.. Its caused by parsing the URL Code with regular expression and extracting the links to make a different colour for the view of the post. depending on the style of the html url code, sometimes the inserted colour commands break the html view. I'm really sorry about that, but I have not found a solution yet which works correctly on all links. I think I have to recode the complete part, because this is a behaviour of the original phpbb mod also and I had only made a conversion to smf.

  • how many topic it can check in one time run? ( i need this information because cronjob time depend with this information)
100 topics are checked at one time.

  • some times checks old posts and some time checks recent ten post

i cant understand how this check base on?
Correct, it checks only links that are viewed by members. If the members don't view a post, it will not be checked.

Regarding the warning message: This is caused by doubled links. Different members has posted the same link in their posts. The bot identifies the rs links by the rslinkid. This id is unique for every uploaded file. If different members post the same link it will be put only one time into database with the message_id from the first member. If now another member post this link the bot identifies the link in the database but is not able to count the links of this new member, cause he only finds the wrong first member.
This needs a complete recoding also, like above its from the orignal code.
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 28, 2008, 08:08:49 AM
The bot bin one topic and then it creates like 20 new topics with 20 posts in each in the dust bin just saying dead links found over and over again, can you fix that please?
Do you have put the boardid of the dead bin board into the settings of the dead bin board for moving? If not, you will have check the bot all posts in this board over and over again, as written in the readme.

I have also made a little correction to the bot, that should prevent him to make more then one reply to the moved thread. But this has nothing todo with cyclic checks as written above.

I have attached three files. Version1.0.1 with complete uninstall, 1.0.1 without deleting the settings and tables of the linkchecker, and for update, the linkbot.php file alone. This must be copied to your sources dir.
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 28, 2008, 11:47:01 AM
Thanks, works great now, although is it possible to make this

 Today at 03:00:04 PM
: Dead RS-Links found
: Dr. Linkbot "

look like this:

 Today at 03:00:04 PM
: ~Topic name here~
: Dr. Linkbot

so just change the ": Dead RS-Links found" to the topic name?

and is it possible to make a setting so it will skip some forums?

and if if the bot doenst bin the post count increase like hell, it has binned 2 posts and got a post count of 27 posts
Title: Re: Converting a phpBB bot for SMF
Post by: Lanthan on September 28, 2008, 01:54:13 PM
Thanks, works great now, although is it possible to make this
I'm glad to hear this.

Today at 03:00:04 PM
: Dead RS-Links found
: Dr. Linkbot "

look like this:

 Today at 03:00:04 PM
: ~Topic name here~
: Dr. Linkbot

so just change the ": Dead RS-Links found" to the topic name?
Good idea, I have took this into the list for the next version 1.1.

and is it possible to make a setting so it will skip some forums?
This is already planned for one of the next versions.

and if if the bot doenst bin the post count increase like hell, it has binned 2 posts and got a post count of 27 posts
First, now it should not increase the post count more then the posts the bot made. Second, you can disable the count of posts in the settings of the bin board.

Some good news for all. I'm in contact with the SMF Customization Team to get it into the official mod section. I have to make some small modifications to the code to get it approved.
So stay tuned for official release!
If this is done I can code and release version 1.1 with new features.
Title: Re: Converting a phpBB bot for SMF
Post by: Rhine on September 29, 2008, 11:28:10 AM
I've disabled the post count in dust bin but the topic number of the dust bin increases without any posts are made the bot posts is also increasing any idea how to stop that?
Title: Re: Converting a phpBB bot for SMF
Post by: owvvwo on October 02, 2008, 06:25:23 AM
On my website
one topic deleted for rs-deadlinks
then i search new working links and replaced with new one
then i move the topic from recycle board to some other board

but next time  rs-bot  view that topic and delete that topic even that topic have good working link
why?
please correct it....
Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on October 08, 2008, 09:48:38 PM
hey lanthan you should make it so that the bot checks ALL most, not just the ones with views.
Title: Re: Converting a phpBB bot for SMF
Post by: owvvwo on October 23, 2008, 10:40:10 PM
this mod is using wrong deleting method and  posting method so smf face lot of problems
Title: Re: Converting a phpBB bot for SMF
Post by: nikosuk on November 03, 2008, 08:28:24 AM
hello everyone,
First of all thanks for the awesome script :)

I am trying to make this mod work on a custom theme.. SMF 1.1.6
when installing , it failed the modsettings.php ( i edited this manually)
I have created the user, and think that the configuration is ok.
On my DB i have the tables and with the precheckallrslinks.php i get "All Links fetched"
when i try to run the cronrsschcker.php i get an 500 Error

Code: [Select]
Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator...blah blah blah

I am a noob in coding but i suspect something is wrong with my Hosting Company?

Is there something else i could do?
Please help!
Title: Re: Converting a phpBB bot for SMF
Post by: nikosuk on November 08, 2008, 08:55:19 AM
nobody?
BUMP
Title: Re: Converting a phpBB bot for SMF
Post by: tampaba1 on November 15, 2008, 11:10:49 PM
Lanthan hasn't been active since September 29, 2008 so, unless someone else picks this up,  the mod development seems to be dead.

Title: Re: Converting a phpBB bot for SMF
Post by: hadesflames on November 19, 2008, 06:11:35 PM
it seems to be working pretty good for the most part....I use it myself every hour on the hour every day with a cron and it never fails =P
Title: Re: Converting a phpBB bot for SMF
Post by: madman71 on November 29, 2008, 12:26:39 AM
Guys,

Im having a link checker made for me. Im paying someone for it. I should be getting it around the first of Dec. I gave him permission to release it to the SMF community.
Here's my request http://www.simplemachines.org/community/index.php?topic=271395.0
Title: Re: Converting a phpBB bot for SMF
Post by: tampaba1 on November 29, 2008, 12:42:40 AM
Very kind of you madman71. Been hoping someone would pick this up or make one of their own.

Thank you,
Title: Re: Converting a phpBB bot for SMF
Post by: 4Kstore on December 02, 2008, 09:48:26 AM
I install this but i have some problem with hide mod.... any suggestion?

Thanks.Baiis!
Title: Re: Converting a phpBB bot for SMF
Post by: imno007 on December 20, 2008, 05:06:33 PM
Anyone still working on this?
Title: Re: Converting a phpBB bot for SMF
Post by: scenerip2k on December 25, 2008, 12:47:59 PM
anyone got it working?
Title: Re: Converting a phpBB bot for SMF
Post by: M@nNiak on January 29, 2009, 07:06:29 AM
any updates?
Title: Re: Converting a phpBB bot for SMF
Post by: scenerip2k on January 30, 2009, 12:12:11 AM
im waiting too
Title: Re: Converting a phpBB bot for SMF
Post by: NHWD on January 31, 2009, 12:05:31 AM
yeah waiting for an update also
Title: Re: Converting a phpBB bot for SMF
Post by: lizardqueen on March 11, 2009, 06:36:20 PM
seems to be dead here :/
Title: Re: Converting a phpBB bot for SMF
Post by: ɔɔɔɔɔɔuɥoɾ on March 30, 2010, 08:13:05 PM
Sorry to bump, but I'm Sure I want to  :P

If I saw this thread when M-DVD (http://custom.simplemachines.org/mods/index.php?action=profile;u=148997) made his Link-Checker Mod, He completed his, I'm sure he could have converted it, he made his own practically from scratch, sigh...