Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: pooya on November 19, 2008, 08:18:08 PM

Title: 2 Quote Buttons - Different actions
Post by: pooya on November 19, 2008, 08:18:08 PM
Hi, i got two quote buttons, one makes the quote in the quick reply, the other quotes it in advanced.

Duno how this happened.. Any help ?
Title: Re: 2 Quote Buttons - Different actions
Post by: ccbtimewiz on November 19, 2008, 08:20:42 PM
It's supposed to be like that.
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 10:52:45 AM
Quote from: ccbtimewiz on November 19, 2008, 08:20:42 PM
It's supposed to be like that.

That was the funniest post I've read all day.

He's right :). Just like there are two edit buttons ;D.
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 03:43:47 PM
Umm no, one edit button is termed modify, and the other is an icon with no text on it, with new members not knowing why its there cause no title is shown on mouse over, secondly its an ajax edit.

Back to my topic, both say the same, and look the same. Confusing for my members. No way i can remove the quote on the quick reply tab and just have it opened in a normal reply page ?
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 05:00:58 PM
Quote from: pooya on November 20, 2008, 03:43:47 PM
Umm no, one edit button is termed modify, and the other is an icon with no text on it, with new members not knowing why its there cause no title is shown on mouse over, secondly its an ajax edit.

Well yes, but they both EDIT the post. No need to get technical.

QuoteBack to my topic, both say the same, and look the same. Confusing for my members. No way i can remove the quote on the quick reply tab and just have it opened in a normal reply page ?

That would annoy me senseless. It goes to quick reply if quick reply is enabled, otherwise it goes to long reply. Show me a screenshot of what you mean please.
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:02:33 PM
Ummmm ill show you my site http://www.warcraftpk.com/forums

Regarding the edit buttons, i have a valid point :p AJAX and Normal Reply are two different structures yes.

Plus i remember i had edited the code of display file and removed the quick reply in the if statement lol, is it cause of that ?
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:05:21 PM
PM me a test account? Or just screenshot and highlight the two buttons in question?
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:15:54 PM
Sent you the test account, hoping positive results.
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:19:31 PM
LOL how did you do that?!

Send me your display.template.php lol..

Just attach it here :D
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:25:13 PM
Geniass aint I ?

Wanted to ask another question if its okay to do so in the same topic.
Q: My host has limited 2mb uploads on http :(" how do i by pass  this ? currently looking at a download system mod, duno if it does the trick.
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:29:21 PM
...Get an FTP program? They SURELY cannot limit that, and if they do, GET A NEW HOST!!! That's terrible! I mean understandable for like attachments sort of uploading, but gees..

I recommend filezilla, but there are heaps out there :)


Give me a minute to talk to your file ;)
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:34:21 PM
Here you go, try this :D
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:35:49 PM
God, i said http upload didint i ? ...

Only way is to alter the php.ini file and there is a code used in .htaccess but google isnt being friends with me :(

Sure talk in persian though, thank you.
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:37:18 PM
OMG, where did my quote button go .. !!!!!!!! NOOOOOOOOO ! .. bring it backkkkkkk ! lol.
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:38:26 PM
I dunno the difference lol :P

If your host limits it then no, if he allows you to change the limit then yes, through php.ini....ask him :).

Quote from: pooya on November 20, 2008, 08:37:18 PM
OMG, where did my quote button go .. !!!!!!!! NOOOOOOOOO ! .. bring it backkkkkkk ! lol.

LOL..hold on  :-X
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:40:23 PM
Okay, try this..

And let me know what happens.
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:43:27 PM
Okay i brought this back to original and its fine now, the extra quote button is gone.
Quote
// Can they reply? Have they turned on quick reply?
      if ($context['can_reply'] && !empty($options['display_quick_reply']))
         echo '
                  <li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';num_replies=', $context['num_replies'], ';sesc=', $context['session_id'], '" onclick="return oQuickReply.quote(', $message['id'], ', \'', $context['session_id'], '\', true);">', $reply_button, '</a></li>';

      // So... quick reply is off, but they *can* reply?
      elseif ($context['can_reply'])
         echo '
                  <li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';num_replies=', $context['num_replies'], ';sesc=', $context['session_id'], '">', $reply_button, '</a></li>';

Soooo what does your edit do again ?
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 08:46:06 PM
Well. What do you want exactly?

Replace above with this maybe:

// Can they reply? Have they turned on quick reply?
if ($context['can_reply'])
echo '<li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';num_replies=', $context['num_replies'], ';sesc=', $context['session_id'], '">', $reply_button, '</a></li><li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';num_replies=', $context['num_replies'], ';sesc=', $context['session_id'], '" onclick="return oQuickReply.quote(', $message['id'], ', \'', $context['session_id'], '\', true);">', $reply_button, '</a></li>';
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 20, 2008, 08:48:46 PM
Problem solved i guess..

Nice experience here :) and good help too :)
Title: Re: 2 Quote Buttons - Different actions
Post by: Jade Elizabeth on November 20, 2008, 09:04:20 PM
Awesome, glad it worked. I got confused for a second, then I realised :D

Sorry I didnt understand the first time, I'm glad it's solved now :D.
Title: Re: 2 Quote Buttons - Different actions
Post by: pooya on November 21, 2008, 06:54:32 AM
Understood the sarcasm right :p

Anyways it did help me, i figured out the bug lol.