Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: Branko. on December 06, 2008, 05:23:42 AM

Title: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on December 06, 2008, 05:23:42 AM
OS & Browser Detection
by X3mE (http://www.simplemachines.org/community/index.php?action=profile;u=154415), version 1.5

Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=1515) | Demo Website (http://x3me.iz.rs/) | Support Topic (http://www.simplemachines.org/community/index.php?topic=278770.0)



Description



This modification will show the OS & Browser used by the user while posting. This information is gathered from the browser's user agent sent during posting time. It is not changed after editing the post.

You can choose in the Admin Control Panel which membergroups are allowed to view detected information.

There are many operating systems and browsers supported, but if you wish to add some new to the list, please use the modification support thread (http://www.simplemachines.org/community/index.php?topic=278770.0) and leave your user agent.


Screenshot



(http://i20.photobucket.com/albums/b242/x3me88/Noname-5.jpg)

Live Demo: http://x3me.iz.rs/index.php?board=2.0


Changelog



* version 1.5 (20. 09. 2010.)
- Added SMF 2.0 RC3 compatibility (thanks to everyone in the support topic who posted their comments, especially cieplutki & snoopy_virtual), not working with earlier SMF 2.0 branch anymore, use 1.4 instead!
- Updated the base detection engine for new releases of browsers and operating systems
- Spanish translation updated (thanks to snoopy_virtual)
- Russian translation added (thanks to Gladman)
- Turkish translation added (thanks to ოկtђ)
- Thai translation added (thanks to Rid-rop)
- Italian translation added (thanks to CrazyHorse80)

* version 1.4 (29. 04. 2009.)
- Added a membergroup permission to view detected information
- Ubuntu 9.04 Jaunty detection added
- Installation code reorganized
- Finnish translation updated (thanks to LexArma)
- German translation added (thanks to Eclipse16V)

* version 1.3 (10. 04. 2009.)
- Fixed undefined errors in SMF 1.1.x
- Finnish language added (thanks to LexArma)

* version 1.2 (05. 02. 2009.)
- Updated to work with SMF 2.0 RC1 (Removed compatibility with 2.0 Beta 4)
- Fixed a layout issue in SMF 1.1.x
- SMF 1 & 2 installs in same package, AUMR version no longer needed

* Version 1.1 (18. 01. 2009.)
- Fixed Unefined index error in Subs-Post.php (SMF 2.x)
- Windows 7 support included
- Swedish translation added (thanks to P_cool)
- Portugeese translation added (thanks to joomlamz)
- Polish translation added (thanks to saneone)
- Spanish translation added (thanks to M-DVD)

* Version 1.0 (19. 11. 2008.)
- Initial version for SMF 2.0 Beta 4 and SMF 1.1.7


Credits



Based on Web Browser Identifier v0.9, by Marcin Krol.


Notes



Normally, you upload and install OS_Browser_Detection_vX.X.zip (for SMF 2.0 RC3 or SMF 1.1.x).

If you have SMF up to 2.0 RC1, please use version 1.4 of the mod, and if you have Advanced Reputation System installed, please use the file with the ARS extension (up to 2.0 RC1 only!).

Please be aware that if you wish to uninstall ARS later, you will have to uninstall OS & Browser Detection first (however, your database settings will be saved if you wish to reinstall it later).

Note that this mod will only show OS & Browser for posts created after installation. Before installing it, this information was never stored in the database.

If you are switching from K-Detection, refer to this post (http://www.simplemachines.org/community/index.php?topic=278770.msg1884533#msg1884533) for instructions how to preserve and import existing data into OS & Browser detection.

Please post all your support questions and comments in the support thread (http://www.simplemachines.org/community/index.php?topic=278770.0). You can also use the Issue Tracker (http://x3me.iz.rs/index.php?project=1) on the Demo Website (http://x3me.iz.rs/).


Languages



Languages included:
- English (english, english-utf8)
- Finnish (finnish)
- German (german)
- Italian (italian)
- Polish (polish)
- Portuguese (portuguese_pt-utf8)
- Russian (russian)
- Serbian (serbian, serbian-utf8, serbian-utf8-lat, serbian_latin-utf8)
- Spanish (spanish, spanish-utf8, spanish_es, spanish_es-utf8, spanish_latin, spanish_latin-utf8)
- Swedish (swedish-utf8)
- Thai (thai)
- Turkish (turkish)

To translate it to your own language, add the translation for:

$txt['OS_Browser_Compatible'] = 'compatible';
$txt['OS_Browser_OS'] = 'OS';
$txt['OS_Browser_Unknown'] = 'Unknown';
$txt['OS_Browser_Browser'] = 'Browser';
$txt['permissiongroup_simple_view_os_browser'] = 'View detected OS & Browser in posts';
$txt['permissionname_view_os_browser'] = 'View detected OS & Browser in posts';
$txt['permissionhelp_view_os_browser'] = 'If enabled, the member will see the detected OS & Browser for each post, if they are detected.';


in the appropriate Modifications.language.php file. You are welcome to post your translations in the support topic (http://www.simplemachines.org/community/index.php?topic=278770.0).


Donations



If you like this mod, please donate to support its further development. Any amount would be highly appreciated. Thank you.

(https://www.paypal.com/en_US/i/btn/btn_donateCC_LG_global.gif) (https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=2EV33MU7KLM5A&lc=GB&item_name=SMF%20modifications&item_number=smf&currency_code=EUR&bn=PP%2dDonationsBF%3abtn_donateCC_LG_global%2egif%3aNonHosted)
Title: Re: OS & Browser Detection mod
Post by: villasg on December 06, 2008, 06:23:25 AM
Thanks work good
A litle problem with the folder os_browser_detection in images dir ( th mod  canot transfer the images  i make manual )
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 06, 2008, 09:16:16 AM
It has to be writable in order to transfer the folder ;)
Title: Re: OS & Browser Detection mod
Post by: setthedark on December 06, 2008, 05:04:24 PM
I got problem i am running it on 1.1.7 and nothing is displayed in member profil on posts!
Any suggestion? Is it possible that it malfuction with some other mod?
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 06, 2008, 05:06:39 PM
Did it install correctly? What other mods do you have?
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 06, 2008, 09:28:50 PM
Hi there,

Great Mod ;) but I have the same problem that setthedark :( I had to had manually one code to display.php since one of my mod had changed it.
I use 2 beta 4 and mods i use are:
Registration redirection      0.1       [ Desinstalar ]  [ Listar Ficheiros ]  [ Apagar ]
2.    SimplePortal - Portuguese    1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
3.    Irritate lurkers with 0 posts    0.1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
4.    Downloads System    1.1.3    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
5.    Karma Buttons    1.1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
6.    PDF Tag    1.1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
7.    No More Ugly Avatar Scrollbars    1.0    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
8.    SMF Gallery Lite    2.0.4    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
9.    JPG Thumbnails    2.0    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
10.    [user] BBC Tag    1.0.1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
11.    Separated Birthdays from Events    1.0    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
12.    New Style Message Icon    1.1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
13.    Advanced AJAX Shoutbox    1.22    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
14.    OS & Browser Detection    1.0    [ Aplicar Mod ] [ Listar Ficheiros ] [ Apagar ]
15.    Hide Tag    2.2.3    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
16.    YouTube BBCode    2.4    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
17.    Auto Merge Double Post    1.0    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
18.    Thank-O-Matic    2.0 Beta 4    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
19.    Last Topics of Person    1.0    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
20.    Pm_Informer    2.0    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
21.    SimplePortal    2.1.1    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
22.    The Rules    1.2    [ Desinstalar ] [ Listar Ficheiros ] [ Apagar ]
23.    JPG Thumbnails    2.0

By the way, here it is the Portuguese Translation (modifications.portuguese.php or modifications.portuguese_pt.php)
$txt['OS_Browser_Compatible'] = 'compatível';
$txt['OS_Browser_OS'] = 'SO';
$txt['OS_Browser_Unknown'] = 'Não Identificado';
$txt['OS_Browser_Browser'] = 'Navegador';

Title: Re: OS & Browser Detection mod
Post by: X3mE on December 06, 2008, 09:42:04 PM
Thank you :)
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 06, 2008, 10:16:04 PM
Quote from: X3mE on December 06, 2008, 09:42:04 PM
Thank you :)

I just edited my first post. Can you help me? :D
Title: Re: OS & Browser Detection mod
Post by: [unplugged] on December 07, 2008, 02:59:55 AM
Hello. Installed the mod on SMF 2.0 Beta 4 and it went flawlessly. However, nothing actually shows anywhere. I have a fairly heavily modded site, but the install was without errors.

Any help would be appreciated.
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 07, 2008, 07:28:48 AM
Quote from: DeviDarkL on December 06, 2008, 10:16:04 PM
I just edited my first post. Can you help me? :D

Could you attach display.php so that I could have a look?

Quote from: SunKing on December 07, 2008, 02:59:55 AM
Hello. Installed the mod on SMF 2.0 Beta 4 and it went flawlessly. However, nothing actually shows anywhere. I have a fairly heavily modded site, but the install was without errors.

Any help would be appreciated.

Ok, check your database first to see if there are 4 new columns in the messages table (ua_os, ua_browser, ua_os_icon and ua_browser_icon). Check some of your latest records to see if they are filled properly.

If they are, then attach display.php from your sources folder and display.template.php from your theme folder and I'll have a look.
Title: Re: OS & Browser Detection mod
Post by: AlenNS on December 07, 2008, 08:33:55 AM
Great work X3me!!!

I had an error while installing your mod in source file Display.php and I made a change in installation package. It's caused by some mod I don't know which.

Quote<file name="$sourcedir/Display.php">
        <operation>
            <search position="before"><![CDATA[
        $messages_request = $smcFunc['db_query']('', '
            SELECT
                id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body,
                smileys_enabled, poster_name, poster_email, approved,
                id_msg_modified < {int:new_from} AS is_read
]]></search>

            <add><![CDATA[
        , ua_os, ua_browser, ua_os_icon, ua_browser_icon
]]></add>
        </operation>

Instead of this I had to do this:

Quote<file name="$sourcedir/Display.php">
        <operation>
            <search position="before"><![CDATA[
        $messages_request = $smcFunc['db_query']('', '
            SELECT
                m.id_msg, m.icon, m.subject, m.poster_time, m.poster_ip, m.id_member, m.modified_time, m.modified_name, m.body,
                m.smileys_enabled, m.poster_name, m.poster_email, m.approved,
                m.id_msg_modified < {int:new_from} AS is_read, k.message AS is_repped
]]></search>

            <add><![CDATA[
        , ua_os, ua_browser, ua_os_icon, ua_browser_icon
]]></add>
        </operation>

Mod works fine by now, but I would like to hear have I done good thing with this?

Thanks in advance. :)
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 07, 2008, 08:42:44 AM
Thanks :)

It works, so you've done a good job :)

Title: Re: OS & Browser Detection mod
Post by: AlenNS on December 07, 2008, 08:47:26 AM
Thanks for the answer. :)
Title: Re: OS & Browser Detection mod
Post by: [unplugged] on December 07, 2008, 10:53:33 AM
Quote from: X3mE on December 07, 2008, 07:28:48 AM
Ok, check your database first to see if there are 4 new columns in the messages table (ua_os, ua_browser, ua_os_icon and ua_browser_icon). Check some of your latest records to see if they are filled properly.

Everything is working fine.  ;)   I didn't realize the mod only applied to posts made after it was installed. Great mod!!
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 07, 2008, 11:03:17 AM
Here is my Display.php

Also, I'm using a different theme which hasn't display.template.php ::)
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 07, 2008, 01:39:03 PM
Quote from: SunKing on December 07, 2008, 10:53:33 AM
Quote from: X3mE on December 07, 2008, 07:28:48 AM
Ok, check your database first to see if there are 4 new columns in the messages table (ua_os, ua_browser, ua_os_icon and ua_browser_icon). Check some of your latest records to see if they are filled properly.

Everything is working fine.  ;)   I didn't realize the mod only applied to posts made after it was installed. Great mod!!

I'm glad it's working :)

Quote from: DeviDarkL on December 07, 2008, 11:03:17 AM
Here is my Display.php

I've edited the file for you, and I've attached it below.

Quote from: DeviDarkL on December 07, 2008, 11:03:17 AM
Also, I'm using a different theme which hasn't display.template.php ::)

:o

You must have a display.template.php file, how else could your posts be displayed? :S

Actually, 3rd party themes for SMF 2 usually come without it I think (at least those I've tried did), but the one from the default theme is used. Attach the one from the default theme and I'll edit it.

Btw, try inserting this Display.php first, maybe it'll work right away (if the display.template.php file is already edited).
Title: Re: OS & Browser Detection mod
Post by: M-DVD on December 07, 2008, 02:51:31 PM
Good MOD :)

spanish (SMF 1.1.X), spanish_es (SMF 2.0 b), spanish_latin. [normal & UTF-8]

$txt['OS_Browser_Compatible'] = 'Compatible';
$txt['OS_Browser_OS'] = 'Sistema Operativo';
$txt['OS_Browser_Unknown'] = 'Desconocido';
$txt['OS_Browser_Browser'] = 'Navegador';

Title: Re: OS & Browser Detection mod
Post by: X3mE on December 07, 2008, 02:53:18 PM
Thanks :)
Title: Re: OS & Browser Detection mod
Post by: dannys on December 08, 2008, 03:41:17 AM
i install manualy but when try to execute mysql syntax give me a error ALTER TABLE {$db_prefix}messages ADD COLUMN ua_os TINYTEXT NOT NULL
Error

SQL query:

ALTER TABLE {$db_prefix}messages ADD COLUMN ua_os TINYTEXT NOT NULL

MySQL said: Documentation
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{$db_prefix}messages ADD COLUMN ua_os TINYTEXT NOT NULL' at line 1

and now i cant see the posts :(  http://sidux.gr/forum/index.php/topic,113.0.html its empty
i use smf 1.1.7
what i do wrong? thanx!

"edit" 
<< i recover from backup files (Post.php~ etc)>>
Title: Re: OS & Browser Detection mod
Post by: saneone on December 08, 2008, 05:15:46 AM
Polish Translation:

//OS, Browser
$txt['OS_Browser_Compatible'] = 'kompatybilny';
$txt['OS_Browser_OS'] = 'System Operacyjny';
$txt['OS_Browser_Unknown'] = 'Nieznany';
$txt['OS_Browser_Browser'] = 'Przeglądarka';
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 08, 2008, 05:17:55 AM
Quote from: dannys on December 08, 2008, 03:41:17 AM
i install manualy but when try to execute mysql syntax give me a error ALTER TABLE {$db_prefix}messages ADD COLUMN ua_os TINYTEXT NOT NULL
Error

SQL query:

ALTER TABLE {$db_prefix}messages ADD COLUMN ua_os TINYTEXT NOT NULL

MySQL said: Documentation
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{$db_prefix}messages ADD COLUMN ua_os TINYTEXT NOT NULL' at line 1


You need to type the actual prefix, instead of the "{$db_prefix}" part. So, it'll be something like:

ALTER TABLE smf_messages ADD COLUMN ua_os TINYTEXT NOT NULL

Note the "smf_" prefix, which is the actual prefix for all your SMF tables in the database.


saneone, thanks ;)
Title: Re: OS & Browser Detection mod
Post by: dannys on December 08, 2008, 05:50:07 AM
οκ X3mE thanx work perfect thanx :)
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 08, 2008, 12:38:07 PM
It works! :D thanks X3mE 8)
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 08, 2008, 04:47:02 PM
Glad I could help :)
Title: Re: OS & Browser Detection mod
Post by: quiz_modder on December 08, 2008, 05:21:18 PM
I am using SMF 2B4 and think I may have found a problem with this mod. When I try to move a post on my forum I am getting the following error:

The database value you're trying to insert does not exist: ua_os

This is definitely related to this mod. Any suggestions on fixes welcome.

Thanks
Title: Re: OS & Browser Detection mod
Post by: quiz_modder on December 08, 2008, 05:24:38 PM
Also, just noticed a lot of errors in the admin error log such as:

Undefined index: ua_browser

Undefined index: ua_os

Undefined index: ua_os_icon

I think you need to add a few isset or empty checks.
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 08, 2008, 05:35:53 PM
Quote from: m4tthall on December 08, 2008, 05:21:18 PM
I am using SMF 2B4 and think I may have found a problem with this mod. When I try to move a post on my forum I am getting the following error:

The database value you're trying to insert does not exist: ua_os

This is definitely related to this mod. Any suggestions on fixes welcome.

Thanks

Well, I just moved a few posts around and all went fine...

Are there any more details on that error (file, line number)?

Quote from: m4tthall on December 08, 2008, 05:24:38 PM
Also, just noticed a lot of errors in the admin error log such as:

Undefined index: ua_browser

Undefined index: ua_os

Undefined index: ua_os_icon

I think you need to add a few isset or empty checks.

Checked my error logs, didn't get any of those. I'll do some more testing.
Title: Re: OS & Browser Detection mod
Post by: quiz_modder on December 08, 2008, 05:40:43 PM
OK, more information.

Error 1 - The database value you're trying to insert does not exist: ua_os Function: createPost
File: Sources/Subs-Post.php
Line: 1825

Error 2 - Undefined index: ua_browser_icon
File: Sources/Subs-Post.php
Line: 1822

Error 3 - Undefined index: ua_os_icon
File: Sources/Subs-Post.php
Line: 1822

Error 4 - Undefined index: ua_browser
File: Sources/Subs-Post.php
Line: 1822

Error 5 - Undefined index: ua_os
File: Sources/Subs-Post.php
Line: 1822

Seems most are related to one line.

Cheers
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 08, 2008, 06:10:06 PM
Thanks, I will look into it.
Title: Re: OS & Browser Detection mod
Post by: Martingonnella on December 08, 2008, 09:25:02 PM
Hi,

Like the the sound of your mod, Installed it in to my 1.1.7 and posted a post. Didn't detect.

What's wrong?

I installed the "1.1.x one.

Help?
Title: Re: OS & Browser Detection mod
Post by: [unplugged] on December 08, 2008, 09:29:03 PM
It will not affect posts already made....only new posts after the mod has been installed.

At least that was my oversight when I installed this great mod. :P
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 09, 2008, 06:20:13 AM
Quote from: Martingonnella on December 08, 2008, 09:25:02 PM
Hi,

Like the the sound of your mod, Installed it in to my 1.1.7 and posted a post. Didn't detect.

What's wrong?

I installed the "1.1.x one.

Help?

Are you talking about new posts? If so, did it install correctly? Check your database to see if there are 4 new columns in the messages table (ua_os, ua_browser, ua_os_icon and ua_browser_icon). Check some of your latest records to see if they are filled properly.

If they are, then attach display.php from your sources folder and display.template.php from your theme folder and I'll have a look.
Title: Re: OS & Browser Detection mod
Post by: tyhgdgh on December 10, 2008, 03:38:57 AM
thi only works on newest posts after this is installed, is this normal??
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 10, 2008, 05:48:39 AM
It cannot guess which os & browser were used before it was installed :)
Title: Re: OS & Browser Detection mod
Post by: tyhgdgh on December 10, 2008, 04:15:47 PM
A swith change would be better, post when using firefox, the login with chrome, changes
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 10, 2008, 06:08:31 PM
I'm not quite sure I understood what you tried to say :/

The mod is intended to record the OS & Browser used when posting a particular message, it stores that information in the database along with every post (after installing it, of course), and doesn't change it later.
Title: Re: OS & Browser Detection mod
Post by: AlenNS on December 11, 2008, 11:04:59 AM
Tonight I've got a critical error in my log:

Quotehttp://www.baklja.com/forum/index.php?action=movetopic2;topic=5628.0
The database value you're trying to insert does not exist: ua_os
Function: createPost
Datoteka: /home/baklja/public_html/forum/Sources/Subs-Post.php
Linija: 1842
Title: Re: OS & Browser Detection mod
Post by: X3mE on December 11, 2008, 03:52:20 PM
What's on line 1842?
Title: Re: OS & Browser Detection mod
Post by: AlenNS on December 11, 2008, 04:23:30 PM
1841: ORDER BY ' .$sticky_sort. ' id_msg ' . ($ascending ? '' : 'DESC') . ($context['messages_per_page'] == -1 ? '' : '

Now it's on 1841. I don't know how...
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 11, 2008, 08:10:04 PM
Hi again X3mE

I have Download System mod installed and I want, when you put an item at downloads to create a post at the forums (automatic) . But it's not working since your mod doesn't recognize the OS or the browser.

Is there a way to add an "if" like: «If don't recognize, dont put ua_os and ua_browser»

The problem is that I don't know php :(

Here it is the Subs-post.php attached (line 1814 and 1821 are from your mod. Don't know which needs to be changed)

Thanks in advance ;D

PS: Sorry for my English >:(
Title: Re: OS & Browser Detection mod
Post by: Apllicmz on December 11, 2008, 08:54:42 PM
Yes
good work
for mi work 100%....portuguese_pt-utf8

<file name="$languagedir/Modifications.portuguese_pt-utf8.php" error="skip">
        <operation>
            <search position="end" />
            <add><![CDATA[
    $txt['OS_Browser_Compatible'] = 'compat&iacute;veis';
    $txt['OS_Browser_OS'] = 'OS';
    $txt['OS_Browser_Unknown'] = 'N&atilde;o Identificado';
    $txt['OS_Browser_Browser'] = 'Navegador';
]]></add>
        </operation>
    </file>
Title: Re: OS & Browser Detection mod
Post by: villasg on December 12, 2008, 03:20:54 AM
Today i see in my error log that :
1) A new member activate acount.
(http://www.thai.gr/forum/index.php?action=activate;u=656;code=c2744da987)
The time in activate acount i take this errors

2) A moderator MOVE a topik
( http://www.thai.gr/forum/index.php?action=movetopic2;topic=441.0 )
Again take thiw errors

Undefined index: ua_browser_icon
Undefined index: ua_os_icon
Undefined index: ua_browser
Undefined index: ua_os


8: Undefined index: ua_browser_icon
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


AND

Undefined index: ua_os
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


And
Undefined index: ua_os_icon
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


Line 1538 is :
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',


inside in
// Insert the post.
db_query("
INSERT INTO {$db_prefix}messages
(ua_os, ua_browser, ua_os_icon, ua_browser_icon,
ID_BOARD, ID_TOPIC, ID_MEMBER, subject, body, posterName, posterEmail, posterTime,
posterIP, smileysEnabled, modifiedName, icon)
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',
$topicOptions[board], $topicOptions[id], $posterOptions[id], SUBSTRING('$msgOptions[subject]', 1, 255), SUBSTRING('$msgOptions[body]', 1, 65534), SUBSTRING('$posterOptions[name]', 1, 255), SUBSTRING('$posterOptions[email]', 1, 255), " . time() . ",
SUBSTRING('$posterOptions[ip]', 1, 255), " . ($msgOptions['smileys_enabled'] ? '1' : '0') . ", '', SUBSTRING('$msgOptions[icon]', 1, 16))", __FILE__, __LINE__);
$msgOptions['id'] = db_insert_id();
Title: Re: OS & Browser Detection mod
Post by: Robi052 on December 13, 2008, 02:46:06 PM
And I have same error. Undefined index: ua_browser_icon, ua_os_icon, ua_browser, ua_os
Title: Re: OS & Browser Detection mod
Post by: AlenNS on December 16, 2008, 10:53:58 AM
Quotehttp://www.baklja.com/forum/index.php?action=movetopic2;topic=9938.0 (http://www.baklja.com/forum/index.php?action=movetopic2;topic=9938.0)
The database value you're trying to insert does not exist: ua_os
Function: createPost
File: /home/baklja/public_html/forum/Sources/Subs-Post.php
Line: 1842
Title: Re: OS & Browser Detection mod
Post by: GIMWD on December 19, 2008, 01:50:54 AM
i installed this mod in my SMF 1.1.7.but it is not working with my current theme.but it is working with my default theme without any problem.what is the problem.we have to make any changes for other themes.then help me...
Title: Re: OS & Browser Detection mod
Post by: edi67 on December 20, 2008, 04:55:36 PM
Quote from: AlenNS on December 16, 2008, 10:53:58 AM
Quotehttp://www.baklja.com/forum/index.php?action=movetopic2;topic=9938.0 (http://www.baklja.com/forum/index.php?action=movetopic2;topic=9938.0)
The database value you're trying to insert does not exist: ua_os
Function: createPost
File: /home/baklja/public_html/forum/Sources/Subs-Post.php
Line: 1842

Same error for me when moderator try to move one topic

The database value you're trying to insert does not exist: ua_os
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 21, 2008, 08:31:47 PM
Same to me  :'( Need some help  >:(
Title: Re: OS & Browser Detection mod
Post by: DeviDarkL on December 22, 2008, 10:26:20 PM
I solved the problem :D

In MoveTopic.php find:
// Add a URL onto the message.
$_POST['reason'] = strtr($_POST['reason'], array(
$txt['movetopic_auto_board'] => '[url=' . $scripturl . '?board=' . $_POST['toboard'] . '.0]' . $board_name . '[/url]',
$txt['movetopic_auto_topic'] => '[iurl]' . $scripturl . '?topic=' . $topic . '.0[/iurl]'
));

$msgOptions = array(
'subject' => $txt['moved'] . ': ' . $subject,
'body' => $_POST['reason'],
'icon' => 'moved',
'smileys_enabled' => 1,
);
$topicOptions = array(
'board' => $board,
'lock_mode' => 1,
'mark_as_read' => true,
);
$posterOptions = array(
'id' => $user_info['id'],
'update_post_count' => !empty($pcounter),
);
createPost($msgOptions, $topicOptions, $posterOptions);
}


replace with:
// Add a URL onto the message.
$_POST['reason'] = strtr($_POST['reason'], array(
$txt['movetopic_auto_board'] => '[url=' . $scripturl . '?board=' . $_POST['toboard'] . '.0]' . $board_name . '[/url]',
$txt['movetopic_auto_topic'] => '[iurl]' . $scripturl . '?topic=' . $topic . '.0[/iurl]'
));

$msgOptions = array(
'subject' => $txt['moved'] . ': ' . $subject,
'body' => $_POST['reason'],
'icon' => 'moved',
'smileys_enabled' => 1,
'ua_os' => 'Servidor',
'ua_browser' => 'Movido',
'ua_os_icon' => 'servidor',
'ua_browser_icon' => 'move',
);
$topicOptions = array(
'board' => $board,
'lock_mode' => 1,
'mark_as_read' => true,
'ua_os' => 'Servidor',
'ua_browser' => 'Movido',
'ua_os_icon' => 'servidor',
'ua_browser_icon' => 'move',
);
$posterOptions = array(
'id' => $user_info['id'],
'update_post_count' => !empty($pcounter),
'ua_os' => 'Servidor',
'ua_browser' => 'Movido',
'ua_os_icon' => 'servidor',
'ua_browser_icon' => 'move',
);
createPost($msgOptions, $topicOptions, $posterOptions);
}


The only problem is that I don't know php enough to know how the server finds your OS or Browser so I just added the image of my OS and Browser since I'm the only one who moves topics.

Hope it helped  ;)
Title: Re: OS & Browser Detection mod
Post by: HR on December 24, 2008, 08:33:46 AM

      elseif($tmp_array[1] == "6.0")
        {
        $client_data['system'] = "Windows Vista";
        $client_data['system_icon'] = "win_new";
        }
Title: Re: OS & Browser Detection mod
Post by: villasg on December 25, 2008, 06:09:30 AM
@HR what is this and how make ?

@X3mE solution for the errors please ?
Title: Re: OS & Browser Detection mod
Post by: HR on December 25, 2008, 06:21:41 PM
Quote from: villasg on December 25, 2008, 06:09:30 AM
@HR what is this and how make ?

THat is the detection sceme for Vista in the OS area  and its added to os_browser_detection.php in Sources under the OS area.
Title: Re: OS & Browser Detection mod
Post by: C.Jack on December 28, 2008, 06:49:39 PM
Thx for the MOD.  :D

I have it working perfectly on 2.0B4 with several themes. Be sure to copy the os_browser_detection folder from /Themes/default/images to your custom themes' image folders to which this MOD is applied or you'll get the dreaded red "x" syndrome.
Title: Re: OS & Browser Detection mod
Post by: HR on December 30, 2008, 07:31:54 AM
To the gent who wrote the mod.. I have a bit of php I use in my sig.. you really want to trick this out?

// Language (I just use basics here....)
$language = $_SERVER["HTTP_ACCEPT_LANGUAGE"];
if ( strstr($language, "en") ) $lang = "English";
elseif ( strstr($language, "es") ) $lang = "Spanish";
elseif ( strstr($language, "de") ) $lang = "German";
elseif ( strstr($language, "fr") ) $lang = "French";
elseif ( strstr($language, "it") ) $lang = "Italian";
elseif ( strstr($language, "ru") ) $lang = "Russian";
elseif ( strstr($language, "zh") ) $lang = "Chinese";
  else $lang = "Unknown";

// IP Data (Some like the danasoft sig but with my own special tweaks...)
$ip = $REMOTE_ADDR;
$resolved = gethostbyaddr ($REMOTE_ADDR);
// Check for Unresolved IP and Rip Domain (ISP/Host) if Resolved
if ($resolved == $ip) {
$isp = ".. Can't Resolve IP";
}
else
{
$str = preg_split("/\./", $resolved);
$i = count($str);
$x = $i - 1;
$n = $i - 2;
$z = $i - 3;
$isp = $str[$z] . "." . $str[$n] . "." . $str[$x];
}
Title: Re: OS & Browser Detection mod
Post by: villasg on December 30, 2008, 07:49:06 AM
Quote from: HR on December 24, 2008, 08:33:46 AM

      elseif($tmp_array[1] == "6.0")
        {
        $client_data['system'] = "Windows Vista";
        $client_data['system_icon'] = "win_new";
        }


Why add that ?
In the file os_browser_detection.php
have this
{
        $client_data['system'] = "Windows Vista";
        $client_data['system_icon'] = "vista";
        }
Title: Re: OS & Browser Detection mod
Post by: mitz on December 30, 2008, 08:23:17 PM
Hi guys I have read all these posts and tried some but it does not work for mine .. I have version 1.1.5 and I am using the babylon theme. Can someone give me a clue as to what to edit to get this mod going..

I have installed the mod with no problems...but will not show up
BK-SMF Sub-Board 1.5   
OS & Browser Detection 1.0
Anti-Spam Verification Questions 1.02
YouTube BBCode 2.4

I have attached my display.php and my display.template.php

Also do i have to put the images into a certain folder?

Any help would be greatly appreciated!!!! :)
Title: Re: OS & Browser Detection mod
Post by: HR on December 30, 2008, 08:27:06 PM
Quote from: villasg on December 30, 2008, 07:49:06 AM
Quote from: HR on December 24, 2008, 08:33:46 AM

      elseif($tmp_array[1] == "6.0")
        {
        $client_data['system'] = "Windows Vista";
        $client_data['system_icon'] = "win_new";
        }


Why add that ?
In the file os_browser_detection.php
have this
{
        $client_data['system'] = "Windows Vista";
        $client_data['system_icon'] = "vista";
        }


I had not noticed that in the version I downloaded.
Title: Re: OS & Browser Detection mod
Post by: P_cool on January 01, 2009, 05:31:00 AM
Have translated it into Swedish-utf8!

Modifications.swedish-utf8.php:
$txt['OS_Browser_Compatible'] = 'kompatibel';
$txt['OS_Browser_OS'] = 'OS';
$txt['OS_Browser_Unknown'] = 'Ok&auml;nd';
$txt['OS_Browser_Browser'] = 'Webbl&auml;sare';
Title: Re: OS & Browser Detection mod
Post by: villasg on January 01, 2009, 06:02:13 AM
Quote from: villasg on December 12, 2008, 03:20:54 AM
Today i see in my error log that :
1) A new member activate acount.
(http://www.thai.gr/forum/index.php?action=activate;u=656;code=c2744da987)
The time in activate acount i take this errors

2) A moderator MOVE a topik
( http://www.thai.gr/forum/index.php?action=movetopic2;topic=441.0 )
Again take thiw errors

Undefined index: ua_browser_icon
Undefined index: ua_os_icon
Undefined index: ua_browser
Undefined index: ua_os


8: Undefined index: ua_browser_icon
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


AND

Undefined index: ua_os
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


And
Undefined index: ua_os_icon
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


Line 1538 is :
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',


inside in
// Insert the post.
db_query("
INSERT INTO {$db_prefix}messages
(ua_os, ua_browser, ua_os_icon, ua_browser_icon,
ID_BOARD, ID_TOPIC, ID_MEMBER, subject, body, posterName, posterEmail, posterTime,
posterIP, smileysEnabled, modifiedName, icon)
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',
$topicOptions[board], $topicOptions[id], $posterOptions[id], SUBSTRING('$msgOptions[subject]', 1, 255), SUBSTRING('$msgOptions[body]', 1, 65534), SUBSTRING('$posterOptions[name]', 1, 255), SUBSTRING('$posterOptions[email]', 1, 255), " . time() . ",
SUBSTRING('$posterOptions[ip]', 1, 255), " . ($msgOptions['smileys_enabled'] ? '1' : '0') . ", '', SUBSTRING('$msgOptions[icon]', 1, 16))", __FILE__, __LINE__);
$msgOptions['id'] = db_insert_id();


@X3mE any solution for the errors please ?
Title: Re: OS & Browser Detection mod
Post by: X3mE on January 12, 2009, 02:51:47 PM
Thanks P_cool for the translation and thanks DeviDarkL for your solution to that moving topic error. I will test when I find some time.

I've been AFK for the last ~20 days, due to holidays and some real life obligations, and now my exam term has started, so I don't have much free time :/

I do promise to try and fix all those problems and publish an update as soon as possible.
Title: Re: OS & Browser Detection mod
Post by: digger on January 13, 2009, 07:57:09 PM
Quote from: edi67 on December 20, 2008, 04:55:36 PM
Quote from: AlenNS on December 16, 2008, 10:53:58 AM
Quotehttp://www.baklja.com/forum/index.php?action=movetopic2;topic=9938.0 (http://www.baklja.com/forum/index.php?action=movetopic2;topic=9938.0)
The database value you're trying to insert does not exist: ua_os
Function: createPost
File: /home/baklja/public_html/forum/Sources/Subs-Post.php
Line: 1842

Same error for me when moderator try to move one topic

The database value you're trying to insert does not exist: ua_os

There's some cases when $posterOptions['ua_os'] and other ua_* not defined. For example, RSS Feeder when bot posts rss articles or some moderators actions.
The reason of this errors is not defined $posterOptions['ua_*'] in $smcFunc['db_insert'].


Title: Re: OS & Browser Detection mod
Post by: AlenNS on January 14, 2009, 12:45:48 PM
???
Title: Re: OS & Browser Detection mod
Post by: X3mE on January 18, 2009, 04:18:46 PM
Version 1.1 is out! :)

I've managed to fix the undefined index error. Please update to the latest version.

Changelog:

* Version 1.1 (18. 01. 2009.)
- Fixed Unefined index error in Subs-Post.php (SMF 2.x)
- Windows 7 support included
- Swedish translation added (thanks to P_cool)
- Portugeese translation added (thanks to joomlamz)
- Polish translation added (thanks to saneone)
- Spanish translation added (thanks to M-DVD)


Please report if you find any further errors.
Title: Re: OS & Browser Detection mod
Post by: X3mE on January 18, 2009, 04:46:04 PM
Here is the Display.template.php for you to insert. Sorry it took this long. Btw, your Display.php is ok.

Quote from: mitz on December 30, 2008, 08:23:17 PM
Hi guys I have read all these posts and tried some but it does not work for mine .. I have version 1.1.5 and I am using the babylon theme. Can someone give me a clue as to what to edit to get this mod going..

I have installed the mod with no problems...but will not show up
BK-SMF Sub-Board 1.5   
OS & Browser Detection 1.0
Anti-Spam Verification Questions 1.02
YouTube BBCode 2.4

I have attached my display.php and my display.template.php

Also do i have to put the images into a certain folder?

Any help would be greatly appreciated!!!! :)
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on January 18, 2009, 06:31:16 PM
HowTo: Switch from K-Detection to OS & Browser Detection
(SMF 1.1.x)

If you already have K-Detection and wish to switch to OS & Browser Detection, here's how to do it and keep existing K-Detection Data into OS & Browser Detection.

This is not recommended if you haven't manipulated your database directly (through phpMyAdmin for example) before, as you will be doing it now.

1. Backup your database.

2. It's best to put your forum in maintenance mode for a while, this only takes a minute, but the forum will be unusable (you cannot view any topic) until you complete the procedure.

3. Do not uninstall K-Detection yet! Uninstalling will erase data from the database, we want to ensure we will be using it first.

4. Open up the database in phpMyAdmin (or whatever other way you use) and go to the SQL query window.

5. Perform the following query:

ALTER TABLE smf_messages CHANGE k_os ua_os TINYTEXT NOT NULL ,
CHANGE k_br ua_browser TINYTEXT NOT NULL ,
CHANGE k_os_ico ua_os_icon TINYTEXT NOT NULL ,
CHANGE k_br_ico ua_browser_icon TINYTEXT NOT NULL;


Note: If your table prefix is not smf_, be sure to replace it.

6. Now go to the admin panel and uninstall K-Detection.

7. Install OS & Browser Detection.

8. Done! Now restore the forum from maintenance mode, if you'd put it there.

This generally applies to 1.1.x, but could also be used in 2.x if your database still has K-Detection columns in the messages table, and you haven't installed OS & Browser Detection yet.

Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: Cal O'Shaw on January 19, 2009, 02:29:49 AM
Hello,

Can this information be restricted to be viewed only by Admins or certain membergroups?
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on January 19, 2009, 07:25:21 AM
Yes, but you'll have to do the edits yourself, as I don't believe this would be implemented any time soon. You just need to edit Display.template.php and add a membergroup check before the line:

//OS & Browser Detection
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: edi67 on January 19, 2009, 04:55:45 PM
Now work perfectly without erros ;)
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: KahneFan on January 21, 2009, 10:12:29 PM
Quote from: Cal O'Shaw on January 19, 2009, 02:29:49 AM
Hello,

Can this information be restricted to be viewed only by Admins or certain membergroups?

X3, I saw your answer, but wanted to ditto this request, as I don't think it's necessary for all users to see this info for all users.
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on January 25, 2009, 11:53:09 PM
Ok, I will implement a permission system for membergroups to view that information, but it'll have to wait for my exam term to end.

I also had in mind to enable users to hide their information to everyone (exept the admin) from their profile, regardless of permissions other membergroups have.
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: Cal O'Shaw on January 26, 2009, 12:25:27 AM
Sounds excellent!  Can you give us a rough idea when your exam term ends, so we don't bug you?

Grazie!
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on January 26, 2009, 06:44:30 AM
In about ~20 days. :)
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: InjecteD on January 26, 2009, 09:30:35 AM
Hi, i have a problem, X3mE i can't see the Navegator / OS in my forum, i have Languaje Spanish & DilberMC Theme (1.1.7)..

If you can help me please my msn is: [email protected]


Thnx,
InjecteD.
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on January 26, 2009, 02:22:42 PM
Post your Display.template.php here and I'll edit it to show them.
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: Peludo_08 on February 05, 2009, 12:31:50 PM
detect windows seven?

screen of my forum..

(http://i39.tinypic.com/swu2cg.jpg)

he use windows seven (7)
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on February 05, 2009, 01:00:59 PM
Download version 1.1 from the mod site, it's implemented there.
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: villasg on February 05, 2009, 01:07:42 PM
Ι unistall the old .
Install the new .
All ok
With a little problem
In my forum need manually tranfer the files in  the folder  {os_browser_detection}

Thanks
Title: Re: OS & Browser Detection mod (Version 1.1 is out) [18. 01. 2009.]
Post by: X3mE on February 05, 2009, 02:41:59 PM
A new version is out: 1.2!

* version 1.2 (05. 02. 2009.)
- Updated to work with SMF 2.0 RC1 (Removed compatibility with 2.0 Beta 4)
- Fixed a layout issue in SMF 1.1.x
- SMF 1 & 2 installs in same package, AUMR version no longer needed

Other that that, all remained the same, for now.

Since I completely reorganized the packages, I removed all the old ones from the mod site to avoid confusion. Now there are two variations only.

This means you can't install it in 2.0 Beta 4 anymore. If someone needs it for 2.0 B4, PM me.
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: sley on February 14, 2009, 06:01:24 PM
Hi!

I would like to add the Linux Mint OS in the Browser list.

How can I do that?
Could somebody help me?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: riker on February 15, 2009, 06:47:17 AM
How do I add IE8 to the list ?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 15, 2009, 06:13:54 PM
Please leave your user agents from IE8 and Mint. You can find them out eg here: http://tinyurl.com/6yn8ek
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: riker on February 15, 2009, 07:19:56 PM
Quote from: X3mE on February 15, 2009, 06:13:54 PM
Please leave your user agents from IE8 and Mint. You can find them out eg here: http://tinyurl.com/6yn8ek

Err this -

QuoteYour browser user agent ID: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0
?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: riker on February 16, 2009, 06:42:47 AM
It's showing now, is this information stored remotely then ?

EDIT: There now showing as IE7 again!,  How can some of my posts show as IE8 and then others IE7 again?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: lookang on February 19, 2009, 10:11:56 PM
Great mod , i like a lot. thx!

by the way, i have a small problem

reference:
http://66.7.205.91/~lookangc/index.php?topic=933.0

i seems to have 3 times the display

any  idea how i can get it to work with just one time?

Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: villasg on February 20, 2009, 03:05:53 AM
Plz if u can make a small edit.
The :Microsoft Internet Explorer is too long
Maybe need to change like Microsoft I.E...

And something else .
I have the new 1.2 and the previus errors is the same
Quote from: villasg on December 12, 2008, 03:20:54 AM
Today i see in my error log that :
1) A new member activate acount.
(http://www.thai.gr/forum/index.php?action=activate;u=656;code=c2744da987)
The time in activate acount i take this errors

2) A moderator MOVE a topik
( http://www.thai.gr/forum/index.php?action=movetopic2;topic=441.0 )
Again take thiw errors

Undefined index: ua_browser_icon
Undefined index: ua_os_icon
Undefined index: ua_browser
Undefined index: ua_os


8: Undefined index: ua_browser_icon
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


AND

Undefined index: ua_os
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


And
Undefined index: ua_os_icon
Αρχείο: /****/*****/****/forum/Sources/Subs-Post.php
Γραμμή: 1538


Line 1538 is :
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',


inside in
// Insert the post.
db_query("
INSERT INTO {$db_prefix}messages
(ua_os, ua_browser, ua_os_icon, ua_browser_icon,
ID_BOARD, ID_TOPIC, ID_MEMBER, subject, body, posterName, posterEmail, posterTime,
posterIP, smileysEnabled, modifiedName, icon)
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',
$topicOptions[board], $topicOptions[id], $posterOptions[id], SUBSTRING('$msgOptions[subject]', 1, 255), SUBSTRING('$msgOptions[body]', 1, 65534), SUBSTRING('$posterOptions[name]', 1, 255), SUBSTRING('$posterOptions[email]', 1, 255), " . time() . ",
SUBSTRING('$posterOptions[ip]', 1, 255), " . ($msgOptions['smileys_enabled'] ? '1' : '0') . ", '', SUBSTRING('$msgOptions[icon]', 1, 16))", __FILE__, __LINE__);
$msgOptions['id'] = db_insert_id();

Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 20, 2009, 07:31:19 AM
Quote from: riker on February 16, 2009, 06:42:47 AM
It's showing now, is this information stored remotely then ?

EDIT: There now showing as IE7 again!,  How can some of my posts show as IE8 and then others IE7 again?

The script detects "MSIE" in the user agent and shows the number which follows it as the version number. The versions aren't hardcoded. I think the problem is in the IE itself, there's not much I can do if the wrong user agent is being sent... Maybe some addon, toolbar or something is causing the problem?

Quote from: lookang on February 19, 2009, 10:11:56 PM
Great mod , i like a lot. thx!

by the way, i have a small problem

reference:
http://66.7.205.91/~lookangc/index.php?topic=933.0

i seems to have 3 times the display

any  idea how i can get it to work with just one time?

Please attach your display.template.php and I'll fix it for you.

Quote from: villasg on February 20, 2009, 03:05:53 AM
Plz if u can make a small edit.
The :Microsoft Internet Explorer is too long
Maybe need to change like Microsoft I.E...

I'll change it to MS Internet Explorer.

Quote from: villasg on February 20, 2009, 03:05:53 AM
And something else .
I have the new 1.2 and the previus errors is the same

I'll fix it, I thought it wasn't happening in 1.1.x, only in 2.0.
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: villasg on February 20, 2009, 10:31:00 AM
I use 1.1.8

in
http://www.thai.gr/forum/index.php?action=movetopic2;topic=2063.0

have error
8: Undefined index: ua_browser_icon
Αρχείο: /home/thai.gr/********/Sources/Subs-Post.php
Γραμμή: 1535


8: Undefined index: ua_os_icon
Αρχείο: /home/thai.gr/******/Sources/Subs-Post.php
Γραμμή: 1535


8: Undefined index: ua_browser
Αρχείο: /home/thai.gr/*******/Sources/Subs-Post.php
Γραμμή: 1535


8: Undefined index: ua_os
Αρχείο: /home/thai.gr/*****/Sources/Subs-Post.php
Γραμμή: 1535
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: lookang on February 21, 2009, 06:23:13 AM
Quote from: X3mE on February 20, 2009, 07:31:19 AM
Quote from: riker on February 16, 2009, 06:42:47 AM

Quote from: lookang on February 19, 2009, 10:11:56 PM
Great mod , i like a lot. thx!

by the way, i have a small problem

reference:
http://66.7.205.91/~lookangc/index.php?topic=933.0

i seems to have 3 times the display

any  idea how i can get it to work with just one time?

Please attach your display.template.php and I'll fix it for you.
Thanks!

I found it at C:.............\Themes\default\Display.template.php
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 21, 2009, 07:12:21 AM
Replace it with this one ;)
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: villasg on February 21, 2009, 12:03:33 PM
errors is in
http://www.thai.gr/forum/index.php?action=movetopic2;topic=2077.0
http://www.thai.gr/forum/index.php?action=activate;u=753;code=434b57ed91
And here is the line 535 from subs-post.php

VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',


and here is all from 529 until 538
// Insert the post.
db_query("
INSERT INTO {$db_prefix}messages
(ua_os, ua_browser, ua_os_icon, ua_browser_icon,
ID_BOARD, ID_TOPIC, ID_MEMBER, subject, body, posterName, posterEmail, posterTime,
posterIP, smileysEnabled, modifiedName, icon)
VALUES ('$posterOptions[ua_os]', '$posterOptions[ua_browser]', '$posterOptions[ua_os_icon]', '$posterOptions[ua_browser_icon]',
$topicOptions[board], $topicOptions[id], $posterOptions[id], SUBSTRING('$msgOptions[subject]', 1, 255), SUBSTRING('$msgOptions[body]', 1, 65534), SUBSTRING('$posterOptions[name]', 1, 255), SUBSTRING('$posterOptions[email]', 1, 255), " . time() . ",
SUBSTRING('$posterOptions[ip]', 1, 255), " . ($msgOptions['smileys_enabled'] ? '1' : '0') . ", '', SUBSTRING('$msgOptions[icon]', 1, 16))", __FILE__, __LINE__);
$msgOptions['id'] = db_insert_id();
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 21, 2009, 12:45:36 PM
There's a new version probably coming soon, the fix will be included. Alternately, if development takes too long, I will probably release a minor upgrade just fixing this. There's a long list of planned changes to be done.

Thanks for the heads up once again.
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: lookang on February 21, 2009, 09:10:42 PM
Quote from: X3mE on February 21, 2009, 07:12:21 AM
Replace it with this one ;)

thanks!! it is very nice fix
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on February 22, 2009, 11:28:28 AM
Thanks for this mod..! I tried and it works for me..! However, the result is not an image but only a text...!

OS:
Linux (Ubuntu 8.04 LTS Hardy Heron) Linux (Ubuntu 8.04 LTS Hardy Heron)
Browser:
Firefox 3.0.5 Firefox 3.0.5
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 22, 2009, 11:38:46 AM
You have to upload the folder with the icons to your theme's images folder manually, and you'll see them ;)
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on February 22, 2009, 07:30:21 PM
Quote from: X3mE on February 22, 2009, 11:38:46 AM
You have to upload the folder with the icons to your theme's images folder manually, and you'll see them ;)

Oh I see..!Thanks for the info X3mE...! Anyway, where can I get this images..? What is the ideal size of each image bro..?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 22, 2009, 09:12:31 PM
Unpack the installation package and you will find all the required images there :)
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on February 22, 2009, 11:04:40 PM
Got it..! Nice mod and thanks...!

One more query, can I shorten the display name of the OS..? After the Ubuntu image, I got Linux (Ubuntu 8.04 LTS Hardy Heron) so I'm thinking to shorten this like Linux (Ubuntu 8.04) or the like....!

Thank you so much...!
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on February 23, 2009, 05:26:18 AM
You can open os_browser_detection.php from the Sources folder and edit any hard coded strings you like :)
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on February 23, 2009, 07:23:45 PM
Thanks bro...! I made it...! Great mod..!
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: nurikosh on March 05, 2009, 04:25:06 AM
Hi X3mE
Icons do not work,can you help me?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on March 05, 2009, 05:37:46 AM
Extract the installation package, find the folder with all the icons and upload it to your theme's images folder ;)
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: nurikosh on March 06, 2009, 02:50:07 AM
Thanks !!!
It is worked
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on March 15, 2009, 01:16:42 PM
@ bro X3mE, are the following errors related to your mod?

--> 8: Undefined index: ua_browser_icon
      File: /home/vol1/php0h.com/p0_2837090/htdocs/Sources/Subs-Post.php
      Line: 1535
 
--> 8: Undefined index: ua_os_icon
      File: /home/vol1/php0h.com/p0_2837090/htdocs/Sources/Subs-Post.php
      Line: 1535

--> 8: Undefined index: ua_browser
      File: /home/vol1/php0h.com/p0_2837090/htdocs/Sources/Subs-Post.php
      Line: 1535

--> 8: Undefined index: ua_os
      File: /home/vol1/php0h.com/p0_2837090/htdocs/Sources/Subs-Post.php
      Line: 1535

If so, how do I fixed these errors?

Thank you so much...!

Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: riker on March 20, 2009, 06:54:16 PM
Quote from: X3mE on February 20, 2009, 07:31:19 AM
Quote from: riker on February 16, 2009, 06:42:47 AM
It's showing now, is this information stored remotely then ?

EDIT: There now showing as IE7 again!,  How can some of my posts show as IE8 and then others IE7 again?

The script detects "MSIE" in the user agent and shows the number which follows it as the version number. The versions aren't hardcoded. I think the problem is in the IE itself, there's not much I can do if the wrong user agent is being sent... Maybe some addon, toolbar or something is causing the problem?

Well on IE8 final now and this is still picking it up as IE7
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on March 25, 2009, 01:15:58 PM
Any updates on my queries above?
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on April 03, 2009, 07:21:22 PM
Quote from: riker on March 20, 2009, 06:54:16 PM
Well on IE8 final now and this is still picking it up as IE7

Could you please check and post your user agent from IE8?

Quote from: ysNoi on March 25, 2009, 01:15:58 PM
Any updates on my queries above?

Sorry, I've been absent for some time, I'm aware of it and will do a fix asap.
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: ysNoi on April 04, 2009, 07:50:27 AM
Quote from: X3mE on April 03, 2009, 07:21:22 PM
Sorry, I've been absent for some time, I'm aware of it and will do a fix asap.

Thanks bro...! I'll be waiting for the updates...! Thanks again...!
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: riker on April 06, 2009, 06:12:38 AM
Quote from: X3mE on April 03, 2009, 07:21:22 PM
Could you please check and post your user agent from IE8?

I thought I did a page back.  Is this what you mean

QuoteYour browser user agent ID: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0

PS don't know why it's saying NT 6 (vista) is NT 5.1 (XP)
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: Aleksi "Lex" Kilpinen on April 06, 2009, 06:24:53 AM
Code (Modifications.finnish.php) Select

$txt['OS_Browser_Compatible'] = 'yhteensopiva';
$txt['OS_Browser_OS'] = 'Käyttöjärjestelmä';
$txt['OS_Browser_Unknown'] = 'Tuntematon';
$txt['OS_Browser_Browser'] = 'Selain';
Title: Re: OS & Browser Detection (Version 1.2 RC1 compatible is out) [05. 02. 2009.]
Post by: X3mE on April 09, 2009, 09:36:09 PM
Ok, version 1.3 is out, check the first page for the link to the mod site in order to download it. Nothing major changed, just fixed the undefided errors (affects SMF 1.1.x only) and added finnish language.

Could you check and see if the errors are still there?

LexArma, thanks ;)

riker, I really don't know... It is supposed to read the version number which follows the MSIE string, and this is working for all previous versions of IE (and should be working for all future versions, unless MS changes something). I see that it is showing 8.0, but I don't have a clue why it is being read as IE 7... I haven't tried it on IE 8 yet, but like I said, the detection code is the same for all previous versions, it's working, and nothing has changed in the user agent IE sends as far as I could see...
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 09, 2009, 10:00:29 PM
Thanks bro X3mE for the updates..! Uninstalling of previous version on my SMF is on-going, I'll update you later...!
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 09, 2009, 10:21:40 PM
Just updated to Version 1.3...! Thanks a lot bro X3mE....!

Quote from: X3mE on April 09, 2009, 09:36:09 PM
Could you check and see if the errors are still there?

I'll update you soon if there are still errors..!

Edit : Bro, I have two times display...! Two OSes and two browsers... How do I fixed it...?

Thanks in a million...
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 09, 2009, 11:13:42 PM
Post your Display.template.php and I'll fix it :)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 09, 2009, 11:19:44 PM
Quote from: X3mE on April 09, 2009, 11:13:42 PM
Post your Display.template.php and I'll fix it :)

File attached bro X3mE...! Thank you so much....  :)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 09, 2009, 11:24:12 PM
Try it with this one.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 10, 2009, 12:46:45 AM
Done bro..! Thanks for the hands..!

I love it...!
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 10, 2009, 09:35:52 AM
No problem :)

Btw, I've just tested with IE8, works fine:

(http://i39.tinypic.com/33awako.png)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 10, 2009, 09:52:48 PM
Bro X3mE, good day...

I have one more question...I tested another browser but the same OS, it seems the OS also changed...

(http://i249.photobucket.com/albums/gg226/ysnoi_lacroxste/pHF/os1.png)

(http://i249.photobucket.com/albums/gg226/ysnoi_lacroxste/pHF/os2.png)

I used Ubuntu on my two posts....

Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 10, 2009, 11:12:22 PM
Well, it only shows the information the browser is giving it, and I suppose the browser is doing it wrong :)

Post your user agents from both of your browsers and I'll have a look.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: riker on April 11, 2009, 06:32:10 AM
Quote from: X3mE on April 10, 2009, 09:35:52 AM
No problem :)

Btw, I've just tested with IE8, works fine:

(http://i39.tinypic.com/33awako.png)
Mines now showing as IE8 again,  this mod seems to have an mind of it's own
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 11, 2009, 08:28:13 AM
I really don't have a clue why :/
There is no number 7 nowhere in the useragent string, so I don't know how could it show it...

If it gets detected sometimes as IE8 and sometimes as IE7, I think it's a bug in IE8.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: Aleksi "Lex" Kilpinen on April 11, 2009, 08:31:08 AM
Just a thought, but have you checked if the compatibility mode of IE8 has anything to do with it?
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 11, 2009, 08:37:33 AM
TBH, I haven't played much with IE8, cause I installed it at work just to test it with the script. But it is very possible that a compatibility mode could be the cause of the problem. Either way, there's nothing I can do if IE 8 doesn't show that it actually is IE 8 through the user agent.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: Aleksi "Lex" Kilpinen on April 11, 2009, 08:40:46 AM
Quote from: X3mE on April 11, 2009, 08:37:33 AM
there's nothing I can do if IE 8 doesn't show that it actually is IE 8 through the user agent.
That's kind of my point, it might be that the compatibility mode hides the real version completely ;)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 11, 2009, 08:45:22 AM
Quote from: X3mE on April 10, 2009, 11:12:22 PM
Well, it only shows the information the browser is giving it, and I suppose the browser is doing it wrong :)

Post your user agents from both of your browsers and I'll have a look.

What do you mean bro...!? I can't seem to get what you mean...!
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 11, 2009, 09:24:10 AM
Check the user agent from both browsers (you can see the user agent the browser is sending to the server here: http://www.useragent.org/).

And post the results here :).
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 11, 2009, 07:39:16 PM
1. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009020911 Ubuntu/8.04 (hardy) Firefox/3.0.6

2. Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.10 (like Gecko) (Kubuntu)

3. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.17) Gecko/20080829 SeaMonkey/1.1.12 (Ubuntu-1.1.12+nobinonly-0ubuntu0.8.04.1)

I'm using Ubuntu 8.04....
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 12, 2009, 07:45:33 AM
Quote from: ysNoi on April 11, 2009, 07:39:16 PM
2. Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.10 (like Gecko) (Kubuntu)

Konqueror shows that it's running on Kubuntu, as you can see.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 13, 2009, 01:53:09 AM
Quote from: X3mE on April 12, 2009, 07:45:33 AM
Quote from: ysNoi on April 11, 2009, 07:39:16 PM
2. Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.10 (like Gecko) (Kubuntu)

Konqueror shows that it's running on Kubuntu, as you can see.

Yeah....! But I used Ubuntu 8.04 on it bro...!
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 13, 2009, 10:41:44 AM
Well, Konqueror obviously isn't aware of that :)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 13, 2009, 06:53:17 PM
Not a big problem..!

ANyway, my errors before were solved...! Thanks for the updates X3mE...!
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: duder673 on April 13, 2009, 07:31:37 PM
When I installed it didn't place the OS/Browsers on past posts.
And it looks like this:
(http://i43.tinypic.com/20hx14w.png)
I am assuming that it is in duplicate because it is a placeholder value for the images that aren't showing up.

Can anyone help?
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 13, 2009, 08:41:23 PM
It doesn't show on "old" posts because SMF wasn't tracking that information prior to install of this mod.

And you're right, the images aren't showing up. Extract the package, you'll find a folder with the required images there. Copy that folder to the images folder of your theme.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: riker on April 14, 2009, 08:07:42 PM
Quote from: X3mE on April 11, 2009, 08:28:13 AM
I really don't have a clue why :/
There is no number 7 nowhere in the useragent string, so I don't know how could it show it...

If it gets detected sometimes as IE8 and sometimes as IE7, I think it's a bug in IE8.

Yup it's now showing as IE7 again

(http://img245.imageshack.us/img245/1102/exam.jpg)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: Cal O'Shaw on April 18, 2009, 02:05:15 AM
Hello,

Would it possible for the next version to include the option to allow either just Admins or specific groups to see this information?  I would find it useful for troubleshooting, most of my users would find it a confusing bother.

Grazie,

Cal
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 18, 2009, 08:56:24 AM
Hi,

It is planned, and will be implemented when I find some free time.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: genusis on April 21, 2009, 08:40:06 AM
Hi umm when i install this mod and then try to post i get this error, anyway to fix it so that way i can use your mod.

when its installed it throws this error when trying to post
An Error Has Occurred!
The database value you're trying to insert does not exist: id_board

but when i uninstall it the post work fine, but i would really like to use this mod, any ideas on how to fix this?

I am using RC and have several mods installed.

Next Post Level
last login in post
Glossary
Custom Fields On Memberlist
New Login Field
Center User Info In Posts
clickableImagebbcode
Admin color in topic view
Posting_Announcement
AllCaps Notifier
Global Headers Footers
Notify Modification Last Post
Profil Moderator Managment
MessagePreviewOnHover
Zuper Admin RC1
RateThatTopic
SMF Articles
Global Topics
eNinja - Custom Pages
Affiliates
AjaxChat Integration
SMF Links
NoFollow BBCode
Alternativ Protocol Fix
SMF Staff Page
Topic Solved
Aeva ~ Auto-Embed Video & Audio
Box BBCode
Hack's Park Color Picker
jQLightbox
CheckBeforePosting
Wiki Links
Users Online Today
Share this topic - SMF Mod
More Spiders
Quick PM
Downloads System
Hide Post
New Style Message Icon
Best 3
PM to New Members
Pm Number in All Pages
Separate Sticky and Normal Topic
Page_Reload_Mod
Off-Topic_BBC_Tag
Heading to Category
MCLegendII RC1
Advance SEF Urls

any ideas please =[.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 21, 2009, 06:06:43 PM
Wow, that's a lot of mods... Some of them is definitely causing it. :)

Did it show any errors during install?
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: genusis on April 22, 2009, 07:31:44 AM
The only installation error i had was it could not add this

, ua_os, ua_browser, ua_os_icon, ua_browser_icon

But that can manually be added easily. Other than that i had this installed before and older version and i uninstalled it and deleted it and installed the newer one. i will go and look thought the code maybe there is a double code form the other installation i had on there. But that's is all i know.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 22, 2009, 08:04:30 AM
Ok, attach your Subs-Post.php and I'll have a look. I think the error comes from there.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: genusis on April 22, 2009, 08:14:05 AM
its ok now i fixed it it was a doubling in the code, the old installation didn't uninstall it all because of a pos mod i added after it. But i got that fixed, And Please when making a mod instead of searching for a huge thing that can change like in display.php

Instead of using this

$messages_request = $smcFunc['db_query']('', ' SELECT id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body, smileys_enabled, poster_name, poster_email, approved, id_msg_modified < {int:new_from} AS is_read

use this

id_msg_modified < {int:new_from} AS is_read

Just stuff like that will make the mod even better, and uninstall more accurately like for example instead of searching for

$messages_request = $smcFunc['db_query']('', ' SELECT id_msg, icon, subject, poster_time, poster_ip, id_member, modified_time, modified_name, body, smileys_enabled, poster_name, poster_email, approved, id_msg_modified < {int:new_from} AS is_read

search for instead this and remove just this.

, ua_os, ua_browser, ua_os_icon, ua_browser_icon  Unless you have to search for something else like example

foreach ($temp as $row)
            $attachments[$row['id_msg']][] = $row;

you changed it to

foreach ($temp as $row)
            $attachments[$row['Blahh']][] = $row;
                               $Blahh[$row['id_msg']][] = $row;

then you would search the whole thing. Makes installing and uninstalling better.
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 27, 2009, 12:59:51 PM
Thanks for the suggestion, I always tend to search for smaller blocks, but this was my first mod, so there's definitely room for improvement there. I'll make sure to fix that.


Btw, can someone post some user agents from the new Ubuntu?
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: Mystery? on April 28, 2009, 12:00:01 PM
Can you set permissions to who can see the OS and Browser info? If not... why not add that feature?
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: ysNoi on April 28, 2009, 07:02:53 PM
Quote from: X3mE on April 27, 2009, 12:59:51 PM
Btw, can someone post some user agents from the new Ubuntu?

Hello X3me, good day....

Here is my check system on Linux...How do I add a new version of Ubuntu on it, i.e., (Ubuntu 9.04 Jaunty)...?

// Linux
    if(preg_match('/linux/si', $user_agent) && !$client_data['system'])
      {
      $client_data['system'] = "Linux";
      $client_data['system_icon'] = "linux";
      if(preg_match('/mdk/si', $user_agent))
        {
        $client_data['system'] .= " (Mandrake)";
        $client_data['system_icon'] = "mandrake";
        }
      elseif(preg_match('/kanotix/si', $user_agent))
        {
        $client_data['system'] .= " (Kanotix)";
        $client_data['system_icon'] = "kanotix";
        }
      elseif(preg_match('/lycoris/si', $user_agent))
        {
        $client_data['system'] .= " (Lycoris)";
        $client_data['system_icon'] = "lycoris";
        }
      elseif(preg_match('/knoppix/si', $user_agent))
        {
        $client_data['system'] .= " (Knoppix)";
        $client_data['system_icon'] = "knoppix";
        }
      elseif(preg_match('/centos/si', $user_agent))
        {
        $client_data['system'] .= " (CentOS)";
        $client_data['system_icon'] = "centos";
        }
      elseif(preg_match('/gentoo/si', $user_agent))
        {
        $client_data['system'] .= " (Gentoo)";
        $client_data['system_icon'] = "gentoo";
        }
      elseif(preg_match('/fedora/si', $user_agent))
        {
        $client_data['system'] .= " (Fedora)";
        $client_data['system_icon'] = "fedora";
        }
      elseif(preg_match('/ubuntu/si', $user_agent))
        {
        // Which *ubuntu do we have?
        if(preg_match('/kubuntu/si', $user_agent))
          {
          $client_data['system'] .= " (Kubuntu";
          $client_data['system_icon'] = "kubuntu";
          }
        elseif(preg_match('/xubuntu/si', $user_agent))
          {
          $client_data['system'] .= " (Xubuntu";
          $client_data['system_icon'] = "xubuntu";
          }
   else
          {
          $client_data['system'] .= " (Ubuntu";
          $client_data['system_icon'] = "ubuntu";
          }
        // Try to detect version
        if(preg_match('/intrepid/si', $user_agent))
          {
          $client_data['system'] .= " 8.10 Intrepid)";
          }
        elseif(preg_match('/hardy/si', $user_agent))
          {
          $client_data['system'] .= " 8.04 LTS Hardy Heron)";
          }
        elseif(preg_match('/gutsy/si', $user_agent))
          {
          $client_data['system'] .= " 7.10 Gutsy Gibbon)";
          }
        elseif(preg_match('/ubuntu.feist/si', $user_agent))
          {
          $client_data['system'] .= " 7.04 Feisty Fawn)";
          }
        elseif(preg_match('/ubuntu.edgy/si', $user_agent))
          {
          $client_data['system'] .= " 6.10 Edgy Eft)";
          }
        elseif(preg_match('/ubuntu.dapper/si', $user_agent))
          {
          $client_data['system'] .= " 6.06 LTS Dapper Drake)";
          }
        elseif(preg_match('/ubuntu.breezy/si', $user_agent))
          {
          $client_data['system'] .= " 5.10 Breezy Badger)";
          }
        else
     {
          $client_data['system'] .= ")";
     }
        }
      elseif(preg_match('/slackware/si', $user_agent))
        {
        $client_data['system'] .= " (Slackware)";
        $client_data['system_icon'] = "slackware";
        }
      elseif(preg_match('/suse/si', $user_agent))
        {
        $client_data['system'] .= " (Suse)";
        $client_data['system_icon'] = "suse";
        }
      elseif(preg_match('/redhat/si', $user_agent))
        {
        $client_data['system'] .= " (Redhat)";
        $client_data['system_icon'] = "redhat";
        }
      elseif(preg_match('/debian/si', $user_agent))
        {
        $client_data['system'] .= " (Debian)";
        $client_data['system_icon'] = "debian";
        }
      elseif(preg_match('/PLD\/([0-9.]*) \(([a-z]{2})\)/si', $user_agent, $tmp_array))
        {
        $client_data['system'] .= " (PLD".($tmp_array[1] ? " ".$tmp_array[1] : "").($tmp_array[2] ? " ".$tmp_array[2] : "").")";
        $client_data['system_icon'] = "pld";
        }
      elseif(preg_match('/PLD\/([a-zA-Z.]*)/si', $user_agent, $tmp_array))
        {
        $client_data['system'] .= " (PLD".($tmp_array[1] ? " ".$tmp_array[1] : "").")";
        $client_data['system_icon'] = "pld";
        }
      }

See here : PHF (http://ysnoi.co.cc/index.php?topic=181.msg2021;topicseen#lastPost)
Title: Re: OS & Browser Detection (version 1.3 is out) [10. 04. 2009.]
Post by: X3mE on April 29, 2009, 09:29:07 AM
Quote from: Mystery? on April 28, 2009, 12:00:01 PM
Can you set permissions to who can see the OS and Browser info? If not... why not add that feature?

It is planned and will be implemented.

Quote from: ysNoi on April 28, 2009, 07:02:53 PM
Quote from: X3mE on April 27, 2009, 12:59:51 PM
Btw, can someone post some user agents from the new Ubuntu?

Hello X3me, good day....

Here is my check system on Linux...How do I add a new version of Ubuntu on it, i.e., (Ubuntu 9.04 Jaunty)...?

There will be a revision coming out today, with Jaunty support. Stay tuned :)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: X3mE on April 29, 2009, 01:41:13 PM
Okay people, new version out: 1.4. Changelog:

* version 1.4 (29. 04. 2009.)
- Added a membergroup permission to view detected information
- Ubuntu 9.04 Jaunty detection added
- Installation code reorganized

I would also like to ask the translators to update translations, as there are 3 new strings:

$txt['permissiongroup_simple_view_os_browser'] = 'View detected OS & Browser in posts';
$txt['permissionname_view_os_browser'] = 'View detected OS & Browser in posts';
$txt['permissionhelp_view_os_browser'] = 'If enabled, the member will see the detected OS & Browser for each post, if they are detected.';



P.S. By default all membergroups will be able to view the info. You can turn it off for whichever membergroup you want in the Admin Control Panel.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Cal O'Shaw on April 29, 2009, 04:55:16 PM
Quote from: X3mE on April 29, 2009, 01:41:13 PM
P.S. By default all membergroups will be able to view the info. You can turn it off for whichever membergroup you want in the Admin Control Panel.

And WHERE is that control in AdminCP?  I couldn't find it anywhere.  I checked Membergroups and General Features.

Would you consider setting the default as hidden instead of showing everyone?  I just yanked it from my site when I couldn't find the
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ysNoi on April 29, 2009, 06:45:14 PM
Quote from: X3mE on April 29, 2009, 09:29:07 AM
Quote from: Mystery? on April 28, 2009, 12:00:01 PM
Can you set permissions to who can see the OS and Browser info? If not... why not add that feature?

It is planned and will be implemented.

Quote from: ysNoi on April 28, 2009, 07:02:53 PM
Quote from: X3mE on April 27, 2009, 12:59:51 PM
Btw, can someone post some user agents from the new Ubuntu?

Hello X3me, good day....

Here is my check system on Linux...How do I add a new version of Ubuntu on it, i.e., (Ubuntu 9.04 Jaunty)...?

There will be a revision coming out today, with Jaunty support. Stay tuned :)

Okey bro, I'll check it out...! Thanks for the hands..!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: X3mE on April 29, 2009, 07:25:14 PM
Quote from: Cal O'Shaw on April 29, 2009, 04:55:16 PM
Quote from: X3mE on April 29, 2009, 01:41:13 PM
P.S. By default all membergroups will be able to view the info. You can turn it off for whichever membergroup you want in the Admin Control Panel.

And WHERE is that control in AdminCP?  I couldn't find it anywhere.  I checked Membergroups and General Features.

Would you consider setting the default as hidden instead of showing everyone?  I just yanked it from my site when I couldn't find the

Admin - Permissions - Modify desired group - View detected OS & Browser in posts
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ysNoi on April 29, 2009, 10:12:50 PM
Update successful....!

Quote from: X3mE on April 29, 2009, 01:41:13 PM
- Added a membergroup permission to view detected information

Confirmed...! Thanks for the updates X3mE..!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: blanix on April 30, 2009, 12:00:44 AM
any chance to show the browser-resolution ?

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Cal O'Shaw on April 30, 2009, 01:18:33 AM
Hello,

Everything appears to be fine with the install, but I did find this error in my logs, and thought you might want to know about it.

Code (Error Log Entry) Select
http://---.org/forum/index.php?action=packages;sa=install2;package=OS_Browser_Detection_v1.4_SMF_1.x_SMF_2.x.zip

2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/---/public_html/forum/Packages/temp/install_1.php
Line: 85


Thank you for the MOD.  It's going to be very helpful in troubleshooting.  Grazie!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Eclipse16V on April 30, 2009, 04:49:00 AM
Here is the German

$txt['OS_Browser_Compatible'] = 'kompatibel';
$txt['OS_Browser_OS'] = 'Betriebssystem';
$txt['OS_Browser_Unknown'] = 'Unbekannt';
$txt['OS_Browser_Browser'] = 'Browser';
$txt['permissiongroup_simple_view_os_browser'] = 'Betriebssystem & Browser im Beitrag anzeigen';
$txt['permissionname_view_os_browser'] = 'Betriebssystem & Browser im Beitrag anzeigen';
$txt['permissionhelp_view_os_browser'] = 'Wenn diese Funktion aktiv ist, kann man im Beitrag sehen welches Betriebssystem und welchen Browser der User nutzt.';
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Aleksi "Lex" Kilpinen on April 30, 2009, 05:04:18 AM
Code (Modifications.finnish.php) Select

$txt['OS_Browser_Compatible'] = 'yhteensopiva';
$txt['OS_Browser_OS'] = 'Käyttöjärjestelmä';
$txt['OS_Browser_Unknown'] = 'Tuntematon';
$txt['OS_Browser_Browser'] = 'Selain';
$txt['permissiongroup_simple_view_os_browser'] = 'Näkee järjestelmä- ja selaintiedot viesteissä';
$txt['permissionname_view_os_browser'] = ''Näkee järjestelmä- ja selaintiedot viesteissä'';
$txt['permissionhelp_view_os_browser'] = 'Mikäli sallittu, käyttäjä näkee havaitut järjestelmän ja selaimen tiedot kaikissa viesteissä, joissa tiedot on saatavilla.';
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: X3mE on April 30, 2009, 10:13:27 AM
Quote from: ysNoi on April 29, 2009, 10:12:50 PM
Update successful....!

Quote from: X3mE on April 29, 2009, 01:41:13 PM
- Added a membergroup permission to view detected information

Confirmed...! Thanks for the updates X3mE..!

;)

Quote from: blanix on April 30, 2009, 12:00:44 AM
any chance to show the browser-resolution ?

That kind of information isn't stored in the user agent string. Although there are other ways to find it out, it would only complicate the mod. I actually don't see why this should be displayed next to posts, you can use Google Analytics or something if you want to track that, while OS & Browser could have a lot of useful usage scenarios.

Quote from: Cal O'Shaw on April 30, 2009, 01:18:33 AM
Hello,

Everything appears to be fine with the install, but I did find this error in my logs, and thought you might want to know about it.

Code (Error Log Entry) Select
http://---.org/forum/index.php?action=packages;sa=install2;package=OS_Browser_Detection_v1.4_SMF_1.x_SMF_2.x.zip

2: mysql_free_result(): supplied argument is not a valid MySQL result resource
File: /home/---/public_html/forum/Packages/temp/install_1.php
Line: 85


Thank you for the MOD.  It's going to be very helpful in troubleshooting.  Grazie!

Thank you, I'll check it out. As far as I can see, this could only happen during install and won't bother your error log no more, and won't affect installing either, but I'll make sure to sort it out.

@Eclipse16V & LexArma

Thanks ;)

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: CrazyHorse80 on May 02, 2009, 12:31:56 PM
Here is the Italian translation:

Quote
//OS & Browser detection
$txt['OS_Browser_Compatible'] = 'compatibile';
$txt['OS_Browser_OS'] = 'OS';
$txt['OS_Browser_Unknown'] = 'Sconosciuto';
$txt['OS_Browser_Browser'] = 'Browser';
$txt['permissiongroup_simple_view_os_browser'] = 'Visualizza OS & Browser rilevati nei posts';
$txt['permissionname_view_os_browser'] = 'Visualizza OS & Browser rilevati nei posts';
$txt['permissionhelp_view_os_browser'] = 'Se abilitato, l\'utente vedrà OS & Browser rilevati per ogni post.';

Thank for your great job!
Bye,
PS
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: X3mE on May 02, 2009, 05:22:00 PM
Thanks ;)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: mulat on May 13, 2009, 08:05:00 AM
Hi!

I have a problem with mod, i don't see icons :( I've checked icon folder and all is fine.
In my Display.template.php i found:
//OS & Browser Detection
if (allowedTo('view_os_browser')){
if ($message['ua_os'] || $message['ua_browser']){ //Do not display if both are unknown

if ($message['ua_os']) {
echo '
<b>', $txt['OS_Browser_OS'], ':</b>
<br /><img src="', $settings['images_url'], '/os_browser_detection/icon_', $message['ua_os_icon'], '.png" align="top" alt="','" /> ', $message['ua_os'], '<br />';
} else {
echo '
<b>', $txt['OS_Browser_OS'], ':</b>
<br /><img src="', $settings['images_url'], '/os_browser_detection/icon_unknown.png" align="top" alt="','" /> ', $txt['OS_Browser_Unknown'], '<br />';
}

if ($message['ua_browser']) {
echo '
<b>', $txt['OS_Browser_Browser'], ':</b>
<br /><img src="', $settings['images_url'], '/os_browser_detection/icon_', $message['ua_browser_icon'], '.png" align="top" alt="', '" /> ', $message['ua_browser'], '<br /><br />';
} else {
echo '
<b>', $txt['OS_Browser_Browser'], ':</b>
<br /><img src="', $settings['images_url'], '/os_browser_detection/icon_unknown.png" align="top" alt="', '" /> ', $txt['OS_Browser_Unknown'], '<br /><br />';
}

}
}


Any ideas?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: X3mE on May 13, 2009, 09:47:40 AM
Open the page source and check if the image URLs are correct.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: mulat on May 13, 2009, 10:15:11 AM
Quote from: X3mE on May 13, 2009, 09:47:40 AM
Open the page source and check if the image URLs are correct.
SOLVED! Mod using source from my style not default style!

Thanks!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Cal O'Shaw on May 21, 2009, 09:29:08 PM
One of my moderators found a problem.

I have the OS / Browser info set to be seen ONLY by Admins by going through each group and unchecking the option to show the info.

However, my moderator found that she can see the info on the board she moderates.  And the Moderator group has no way to disable seeing the OS info.


Would you consider setting the default on showing info to OFF?  Could you see how to disable showing info to the Moderator group.

Grazie,

Cal
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Joe N on May 22, 2009, 11:28:11 AM
Awesome Mod!

Joe
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ოկtђ on May 22, 2009, 11:52:13 AM
Turkish translate:

$txt['OS_Browser_Compatible'] = 'uyumlu';
$txt['OS_Browser_OS'] = 'İşletim Sistemi';
$txt['OS_Browser_Unknown'] = 'Bilinmiyor';
$txt['OS_Browser_Browser'] = 'Tarayıcı';
$txt['permissiongroup_simple_view_os_browser'] = 'Mesajlarda işletim sistemi ve tarayıcıyı görüntüle';
$txt['permissionname_view_os_browser'] = 'Mesajlarda işletim sistemi ve tarayıcıyı görüntüle;
$txt['permissionhelp_view_os_browser'] = 'Eğer etkinleştirirseniz mesajlardaki profil alanlarında kullanıcının kullandığı işletim sistemi ve internet tarayıcısı görünür.';
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: dzinerfusion on June 02, 2009, 07:09:18 PM
hi How come my images won't show. P.S the text shows but not the image
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Cal O'Shaw on June 03, 2009, 12:08:28 AM
If you are not using the default theme, have you made sure the icons are in the correct directory for that theme?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: AseAse on June 13, 2009, 11:11:51 PM
Thai translate:


$txt['OS_Browser_Compatible'] = 'อยู่รวมกันได้';
$txt['OS_Browser_OS'] = 'ระบบปฏิบัติการ:';
$txt['OS_Browser_Unknown'] = 'ไม่ทราบ';
$txt['OS_Browser_Browser'] = 'บราวเซอร์:';
$txt['permissiongroup_simple_view_os_browser'] = 'สามารถดู  ระบบปฏิบัติการ & บราวเซอร์ ในกระทู้ได้';
$txt['permissionname_view_os_browser'] = 'สามารถดู  ระบบปฏิบัติการ & บราวเซอร์ ในกระทู้ได้';
$txt['permissionhelp_view_os_browser'] = 'หากเปิดใช้ สมาชิกจะเห็นการตรวจสอบบราวเซอร์และระบบปฏิบัติการ สำหรับแต่ละกระทู้หากมีการตรวจพบ';
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ws4570 on July 04, 2009, 09:14:40 PM
Constant errors in the logs.

Quote8: Undefined index: k_br_ico
File: xxx/Sources/Display.php
Line: 950

8: Undefined index: k_os_ico
File: .../Sources/Display.php
Line: 949

8: Undefined index: k_br
File: .../Sources/Display.php
Line: 948

8: Undefined index: k_os
File: .../Sources/Display.php
Line: 947

Display.php:

// Compose the memory eat- I mean message array.
   $output = array(
      'attachment' => loadAttachmentContext($message['ID_MSG']),
      'alternate' => $counter % 2,
      'id' => $message['ID_MSG'],
      'href' => $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'],
      'link' => '<a href="' . $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'] . '">' . $message['subject'] . '</a>',
      'member' => &$memberContext[$message['ID_MEMBER']],
      'icon' => $message['icon'],
      'icon_url' => $settings[$context['icon_sources'][$message['icon']]] . '/post/' . $message['icon'] . '.gif',
      'subject' => $message['subject'],
      'time' => timeformat($message['posterTime']),
      'timestamp' => forum_time(true, $message['posterTime']),
      'counter' => $counter,
      'modified' => array(
         'time' => timeformat($message['modifiedTime']),
         'timestamp' => forum_time(true, $message['modifiedTime']),
         'name' => $message['modifiedName']
      ),
      'body' => $message['body'],
      'ua_os' => $message['ua_os'],
      'ua_browser' => $message['ua_browser'],
      'ua_os_icon' => $message['ua_os_icon'],
      'ua_browser_icon' => $message['ua_browser_icon'],
           947'k_os' => $message['k_os'],
   948'k_br' => $message['k_br'],
   949'k_os_ico' => $message['k_os_ico'],
   950'k_br_ico' => $message['k_br_ico'],
      'new' => empty($message['isRead']),
      'first_new' => isset($context['start_from']) && $context['start_from'] == $counter,
      'can_modify' => (!$context['is_locked'] || allowedTo('moderate_board')) && (allowedTo('modify_any') || (allowedTo('modify_replies') && $context['user']['started']) || (allowedTo('modify_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_disable_time'] * 60 > time()))),
      'can_remove' => allowedTo('delete_any') || (allowedTo('delete_replies') && $context['user']['started']) || (allowedTo('delete_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_disable_time'] * 60 > time())),
      'can_see_ip' => allowedTo('moderate_forum') || ($message['ID_MEMBER'] == $ID_MEMBER && !empty($ID_MEMBER)),
   );

   if (empty($options['view_newest_first']))
      $counter++;
   else
      $counter--;

   return $output;
}



What is the problem?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on July 05, 2009, 04:24:46 AM
You have [THIS] (http://custom.simplemachines.org/mods/index.php?mod=487) mod installed also.
Try uninstalling it and see if that helps.
You only need one of these mods installed to receive the desired result.

Good luck :)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ws4570 on July 05, 2009, 04:46:36 AM
You're right. Thank you. :)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on July 05, 2009, 04:55:32 AM
Anytime mate :)
If you still receive errors, post back and we'll work through them.
Good luck :)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: akosiparusa on July 15, 2009, 04:00:48 AM
Is there a way a member may block this to work?

Currently one user, who's a newbie ain't showing up. I isolated the problem but no avail.

I tried ACP > Permission > User and enabled/allowed "View detected OS & Browser in posts", which was disabled earlier. but still, it ain't working only on this specific user. is he just playing around or what?

I hope I can find a clarification.

Thanks
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: JeremyB. on July 15, 2009, 04:02:55 AM
They shouldn't be able to.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Cal O'Shaw on July 15, 2009, 04:08:08 AM
Check your error log and find out from the user what his OS and browser are.  Maybe they aren't recognised by the code, or they trap out somehow.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on July 15, 2009, 04:13:24 AM
Yep, possibly details that haven't been added to the code.
Often bot or WAP device agents etc etc...   I also send my own info to servers Im not comfortable with.
You could check/log his useragent and add it.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: akosiparusa on July 15, 2009, 04:15:22 AM
yeah, I know, that is weird.

is he/she a show off because I will ban him/her immediately if that's the case. lol

---

I've check my 'Forum Error Log' but there's no error regarding that user.

---

I've thought of that also that he's on WAP or mobile. how to add the useragent thing?

Thanks guys
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on July 15, 2009, 04:50:10 AM
You would have to know what the agent is first lol

Getting their agent is only a couple edits
You can try a simple approach of this [HERE] (http://www.simplemachines.org/community/index.php?topic=289753.0)
Do the complete edits, or use only the $agent=strtolower($_SERVER['HTTP_USER_AGENT']); edits

Good luck :)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: akosiparusa on July 15, 2009, 05:54:47 AM
asking the member is hard because he/she is an a$$.

and, i thought the coding part would be simple, im just a noob. lol

---

ok, he answered: opera running under debian
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: LOVELORD on July 16, 2009, 09:37:57 PM
There is a new version of some browser witch detect as other..

ex. Flock 2.5 as Firefox 3.0.10
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: LHW on July 16, 2009, 10:03:24 PM
Nice Mod.

Thank you!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: dark_warriorxx8 on August 23, 2009, 01:50:57 PM
   
where is the option to activate the mod???

already installed but not seen anything and install correctly.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: TwitchisMental on August 23, 2009, 04:17:59 PM
Quote from: dark_warriorxx8 on August 23, 2009, 01:50:57 PM
   
where is the option to activate the mod???

already installed but not seen anything and install correctly.

I am wondering this aswell...
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on August 23, 2009, 05:27:39 PM
There is no activation option, apart from the member permission allowance.
The mod will start displaying for new posts, not for your old posts in your board.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ws4570 on September 08, 2009, 08:11:59 PM
Not see 10 opera.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Gladman on September 19, 2009, 10:46:37 AM
X3mE, thanks for mod  ;)

translation into Russian:

// OS & Browser Detection mod
$txt['OS_Browser_Compatible'] = 'совместимость';
$txt['OS_Browser_OS'] = 'ОС';
$txt['OS_Browser_Unknown'] = 'Неизвестно';
$txt['OS_Browser_Browser'] = 'Браузер';
$txt['permissiongroup_simple_view_os_browser'] = 'Отображать данные об ОС и браузере в постах';
$txt['permissionname_view_os_browser'] = 'Отображать данные об ОС и браузере в постах';
$txt['permissionhelp_view_os_browser'] = 'Если включено, пользователь увидит инфу об ОС и браузере в постах.';
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Pinball Nation on September 23, 2009, 07:45:17 PM
Will this mod work with smf 1.1.10?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on September 23, 2009, 07:58:20 PM
Yes
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: c23_Mike on October 18, 2009, 03:50:13 PM
Hi there !

Is there already a port to RC2 in work? Can we know which timeframe it is planned to release? Since it will not install on RC2 ...
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: vsebir on November 15, 2009, 10:30:13 AM
please make a version for rc2
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: c23_Mike on November 16, 2009, 12:55:09 PM
Hi there !

Yes pleeeeaaaaaasseeee  ;)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Eclipse16V on November 17, 2009, 09:15:42 AM
Hi

yes. Pleas make it for RC2
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: AliG on November 18, 2009, 05:37:47 AM
Hi,
I am not sure if someone already mentioned ... but there is a bug in "install.php"

you should use
$smcFunc['db_add_column']("{db_prefix}messages",
not
$smcFunc['db_add_column']("messages",

the "{db_prefix}" is essencial ;)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Milossh on November 19, 2009, 02:47:44 AM
I mentioned, but didn't know how to fix it... Anyway, I have changed it following your suggestion, and now it's all working :) Thanks to both you and mod author :)

PS. I have attached changed file, if you want to use it.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: WilK on December 17, 2009, 04:03:56 AM
Quote from: ws4570 on September 08, 2009, 08:11:59 PM
Not see 10 opera.

In os_browser.detection_php

Find
// Opera
    if((preg_match('/mozilla.*opera ([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) || preg_match('/^opera\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array)) && !$client_data['browser'])
      {
      $client_data['browser'] = "Opera" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'opera';
      if(preg_match('/opera mini/si', $user_agent))
        {
        preg_match('/opera mini\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array);
        $client_data['browser'] .= " (Opera Mini" . ($tmp_array[1] ? " ".$tmp_array[1] : "") . ")";
        }
    }


Replace with
// Opera
    if((preg_match('/mozilla.*opera ([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) || preg_match('/^opera\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array)) && !$client_data['browser'])
      {
      $client_data['browser'] = "Opera" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'opera';
      if(preg_match('/opera mini/si', $user_agent))
        {
        preg_match('/opera mini\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array);
        $client_data['browser'] .= " (Opera Mini" . ($tmp_array[1] ? " ".$tmp_array[1] : "") . ")";
        }
      if(preg_match('/Version\/([0-9]+\.[0-9]+)/', $user_agent, $tmp_array))
        {
        $client_data['browser'] = "Opera " . $tmp_array[1];
        }
    }
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Arantor on December 17, 2009, 04:05:48 AM
Quote from: AliG on November 18, 2009, 05:37:47 AM
Hi,
I am not sure if someone already mentioned ... but there is a bug in "install.php"

you should use
$smcFunc['db_add_column']("{db_prefix}messages",
not
$smcFunc['db_add_column']("messages",

the "{db_prefix}" is essencial ;)

It wasn't essential prior to RC2.


I wonder why this mod goes to all this trouble when SMF does some of the detection itself, and need only do further detection in specific cases.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Kreator on January 12, 2010, 03:45:55 PM
has anybody got this mod working on RC2?

I keep stumbling on it, most of the dbase inserts do not work
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on January 16, 2010, 06:24:15 PM
Yes work fine on rc 2 added icon windows 7
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: coldy316 on January 17, 2010, 05:54:36 AM
I am using windows 7 and ie 8 with smf version 2.0RC2 and the mod detects windows 7 but not
the internet explorer 8. It shows up as IE6 what could be causing this problem..

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~DS~ on January 17, 2010, 06:27:09 AM
it's showing duplicates.

EDIT: Never mind since I need to upload the images for it to work. It here a way to detect mobile phone?

While posting from my iPhone instead it detected it as Mac and Safari.  :o
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Arantor on January 17, 2010, 07:13:02 AM
Quote from: coldy316 on January 17, 2010, 05:54:36 AM
I am using windows 7 and ie 8 with smf version 2.0RC2 and the mod detects windows 7 but not
the internet explorer 8. It shows up as IE6 what could be causing this problem..

Because plenty of versions of IE8 identify themselves as IE6 as well as IE8.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Dzonny on January 20, 2010, 02:23:57 PM
Hello there.
Is there a code, update or smth, that will make this mod show win 7, and newer browsers as opera 10?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on January 21, 2010, 03:55:05 AM
Working on smf 2 rc 2 repack by me
support windows 7 with transparet icon //edit look at attachment black background
recognize opera 10

all on attachments

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Dzonny on January 21, 2010, 04:32:32 AM
I already use that mod, but is there some update for newer versions of OS and Browsers?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~DS~ on January 21, 2010, 07:31:09 AM
How about some iPhone love?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~DS~ on January 21, 2010, 05:17:41 PM
Quote from: Dzonny on January 21, 2010, 04:32:32 AM
I already use that mod, but is there some update for newer versions of OS and Browsers?
It works fine on my end...
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: catfished on January 21, 2010, 06:25:48 PM
I was going to try this mod but according to the mod page:
Mod Name:OS & Browser Detection (http://custom.simplemachines.org/mods/index.php?mod=1515)
Created By:X3mE (http://www.simplemachines.org/community/index.php?action=profile;u=154415) (http://www.simplemachines.org/community/Themes/default/images/filter.gif) (http://custom.simplemachines.org/mods/index.php?action=profile;u=154415)
Type:New Feature (http://www.simplemachines.org/community/Themes/default/images/filter.gif) (http://custom.simplemachines.org/mods/index.php?action=search;type=1)
First Created:November 19, 2008, 04:56:01 PM
Last Modified:April 30, 2009, 09:20:26 AM
Latest Version:1.4
Compatible With:1.1.7, 1.1.8, 2.0 RC1
I have 1.1.11 and 2.0 RC2 forums so I guess I'm out of luck so far. :(
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on January 21, 2010, 06:28:56 PM
Unless you read back atleast one page and see that somebody has packaged an updated version. ;)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~DS~ on January 21, 2010, 06:29:18 PM
Quote from: catfished on January 21, 2010, 06:25:48 PM
I was going to try this mod but according to the mod page:
Mod Name:OS & Browser Detection (http://custom.simplemachines.org/mods/index.php?mod=1515)
Created By:X3mE (http://www.simplemachines.org/community/index.php?action=profile;u=154415) (http://www.simplemachines.org/community/Themes/default/images/filter.gif) (http://custom.simplemachines.org/mods/index.php?action=profile;u=154415)
Type:New Feature (http://www.simplemachines.org/community/Themes/default/images/filter.gif) (http://custom.simplemachines.org/mods/index.php?action=search;type=1)
First Created:November 19, 2008, 04:56:01 PM
Last Modified:April 30, 2009, 09:20:26 AM
Latest Version:1.4
Compatible With:1.1.7, 1.1.8, 2.0 RC1
I have 1.1.11 and 2.0 RC2 forums so I guess I'm out of luck so far. :(

You can try the unofficial release:
http://www.simplemachines.org/community/index.php?topic=278770.msg2466415#msg2466415

EDIT: Ninja'd by Sabre™
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: catfished on January 21, 2010, 06:45:34 PM
Thanks Sabre and Dismal Shadow, I evidently missed that. :-[
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Sabre™ on January 21, 2010, 06:46:28 PM
hahaa no probs, it happens :)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: catfished on January 21, 2010, 07:33:17 PM
I installed it on one of my 1.1.11 forums and it works fine, thanks again.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on January 22, 2010, 04:11:51 PM
no problem  ;)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Darkstar1337 on January 25, 2010, 06:39:32 AM
How do you get this working on RC2 ?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: catfished on January 25, 2010, 11:09:54 AM
Quote from: Darkstar1337 on January 25, 2010, 06:39:32 AM
How do you get this working on RC2 ?

Apparently you cannot until it's upgraded to work on RC2:
Compatible With:1.1.7, 1.1.8, 2.0 RC1
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on January 28, 2010, 07:37:42 AM
Quote
How do you get this working on RC2 ?

update source and added windows 7 and opera 10.0 

download working on smf 1.x and 2.0 rc2 (http://www.simplemachines.org/community/index.php?topic=278770.msg2466415#msg2466415)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~DS~ on January 28, 2010, 07:57:49 AM
Quote from: cieplutki on January 28, 2010, 07:37:42 AM
Quote
How do you get this working on RC2 ?

update source and added windows 7 and opera 10.0 

download working on smf 1.x and 2.0 rc2 (http://www.simplemachines.org/community/index.php?topic=278770.msg2466415#msg2466415)

Source...? You mean it is update automatically from within a source?

Can you make it to detect iPhone?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on January 29, 2010, 09:55:47 AM
Try this but icon iPhone not transparen
it's works ?

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~DS~ on January 29, 2010, 05:52:21 PM
Quote from: cieplutki on January 29, 2010, 09:55:47 AM
Try this but icon iPhone not transparen
it's works ?
Sadly it doesn't.
It shows Mac and Safari.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: libra_86930 on February 27, 2010, 07:08:55 AM
I updated my forum from smf 1.1.x but I can't seem to install os browser anymore. it says :

Table '*****_IC_20090212_101441.messages' doesn't exist
File: /hermes/bosweb/web025/b259/*****/public_html/forum/Packages/temp/install.php
Line: 19

Can you help me with this?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ShadoWind on March 12, 2010, 06:44:34 AM
I've tried installing the unofficial version of this as the original version wouldn't work on my 1.1.11 based forum and this
version won't work as I get the following error:

Installing this package will perform the following actions:  Type Action Description
1. Execute Modification ./Sources/Post.php Test successful
2. Execute Modification ./Sources/Subs-Post.php Test failed
3. Execute Modification ./Sources/Display.php Test successful
4. Execute Modification ./Sources/ManagePermissions.php Test successful
5. Execute Modification ./Themes/default/Display.template.php Test successful
6. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
7. Execute Modification ./Themes/default/languages/Modifications.english-utf8.php Test successful
8. Execute Modification ./Themes/default/languages/Modifications.finnish.php.php Skipping file
9. Execute Modification ./Themes/default/languages/Modifications.german.php Skipping file
10. Execute Modification ./Themes/default/languages/Modifications.polish.php Skipping file
11. Execute Modification ./Themes/default/languages/Modifications.portuguese_pt-utf8.php Test successful
12. Execute Modification ./Themes/default/languages/Modifications.serbian.php Skipping file
13. Execute Modification ./Themes/default/languages/Modifications.serbian-utf8.php Skipping file
14. Execute Modification ./Themes/default/languages/Modifications.serbian-utf8-lat.php Skipping file
15. Execute Modification ./Themes/default/languages/Modifications.serbian_latin-utf8.php Test successful
16. Execute Modification ./Themes/default/languages/Modifications.spanish.php Skipping file
17. Execute Modification ./Themes/default/languages/Modifications.spanish-utf8.php Skipping file
18. Execute Modification ./Themes/default/languages/Modifications.spanish_es.php Skipping file
19. Execute Modification ./Themes/default/languages/Modifications.spanish_es-utf8.php Test successful
20. Execute Modification ./Themes/default/languages/Modifications.spanish_latin.php Skipping file
21. Execute Modification ./Themes/default/languages/Modifications.spanish_latin-utf8.php Test successful
22. Execute Modification ./Themes/default/languages/Modifications.swedish-utf8.php Test successful
23. Extract File ./Sources/os_browser_detection.php 
24. Extract Tree ./Themes/default/images/os_browser_detection 
25. Execute Code install_1.php

-----------------------------------------------------------------------------------------------------------------------------------------
I'm using the following Mods if anybody needs to know if any of these are clashing with this Mod:

Mod Name Version 
1. Xbox LIVE GamerTag BBC 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
2. Ultimate Profile 0.9   [ Uninstall ] [ List Files ] [ Delete ] 
3. FontandSizeDropdown_1.3 1.3  [ Apply Mod ] [ List Files ] [ Delete ] 
4. Enhanced Profile 1.1.5  [ Apply Mod ] [ List Files ] [ Delete ] 
5. Profile Comments 2.0  [ Apply Mod ] [ List Files ] [ Delete ] 
6. MySpace Field 2.5  [ List Files ] [ Delete ] 
7. Aeva Media 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
8. Akismet Spam Blocking 1.2 Beta 2   [ Uninstall ] [ List Files ] [ Delete ] 
9. OS & Browser Detection 1.4  [ Apply Mod ] [ List Files ] [ Delete ] 
10. Clickable Avatars 1.1.0   [ Uninstall ] [ List Files ] [ Delete ] 
11. httpBL 2.3.4   [ Uninstall ] [ List Files ] [ Delete ] 
12. Enhanced Profile Header Language Pack 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
13. Lay out change 0.1   [ Uninstall ] [ List Files ] [ Delete ] 
14. Advanced XFire Field 2.0a  [ Apply Mod ] [ List Files ] [ Delete ] 
15. Ad Managment 2.3.6.1   [ Uninstall ] [ List Files ] [ Delete ] 
16. reCAPTCHA for SMF 0.9.7   [ Uninstall ] [ List Files ] [ Delete ] 
17. Advanced Popup Xbox Gamertag 1.2   [ Uninstall ] [ List Files ] [ Delete ] 
18. Last Post On MemberList 1.01  [ List Files ] [ Delete ] 
19. Social Bookmarks 2.0   [ Uninstall ] [ List Files ] [ Delete ] 
20. PM Popup - Uses Active Window 1.4   [ Uninstall ] [ List Files ] [ Delete ] 
21. Audible PM 1.5   [ Uninstall ] [ List Files ] [ Delete ] 
22. Skype Integration 2.1.1   [ Uninstall ] [ List Files ] [ Delete ] 
23. Enhanced Profile Header 1.2.3   [ List Files ] [ Delete ] 
24. Admin color in topic view 0.1   [ Uninstall ] [ List Files ] [ Delete ] 
25. BK-SMF StatCounter 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
26. Unread and Replies Tabs in Main Menu 3.0   [ Uninstall ] [ List Files ] [ Delete ] 
27. Board Notification Mod 1.1.6   [ Uninstall ] [ List Files ] [ Delete ] 
28. Search Board and Topic texts 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
29. Twitter and Facebook Publisher mod 2.2   [ Uninstall ] [ List Files ] [ Delete ] 
30. Pm Number in All Pages 1.0  [ List Files ] [ Delete ] 
31. Timezone Select 1.1.2  [ List Files ] [ Delete ] 
32. Favicon 1.3   [ Uninstall ] [ List Files ] [ Delete ] 
33. Caps_Lock_Detection_on_Login 1.1.0.1   [ Uninstall ] [ List Files ] [ Delete ] 
34. TinyPortal 1.083  [ Apply Mod ] [ List Files ] [ Delete ] 
35. Ban Link in Post 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
36. Link Thumbnail 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
37. Remove MySQL, PHP & W3C images to minimize footer size 1.2  [ Apply Mod ] [ List Files ] [ Delete ] 
38. AjaxChat Integration 3.2.1  [ Apply Mod ] [ List Files ] [ Delete ] 
39. Blabberizer 2.1u   [ Uninstall ] [ List Files ] [ Delete ] 
40. Select All And Copy 'Code' To Clipboard [BETA] 1.3  [ List Files ] [ Delete ] 
41. PM Readed 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
42. Auto Complete Search 1.0  [ List Files ] [ Delete ] 
43. Enhanced Dropdown 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
44. Enhanced PM Warning Message 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
45. Advanced Reputation System 0.1.5  [ Apply Mod ] [ List Files ] [ Delete ] 
46. Twitter Profile Field 2.2  [ List Files ] [ Delete ] 
47. AJAX Personal Text 1.0.2  [ List Files ] [ Delete ] 
48. SMF 1.0.19 / 1.1.11 Update 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
49. BK-SMF Sub-Board 1.5   [ Uninstall ] [ List Files ] [ Delete ] 
50. cbi, 1.0 1.5.7  [ Apply Mod ] [ List Files ] [ Delete ] 
51. AJAX Instant Quick Reply 1.0.2  [ Apply Mod ] [ List Files ] [ Delete ] 
52. No More Ugly Avatar Scrollbars 1.0  [ Apply Mod ] [ List Files ] [ Delete ] 
53. SimplePortal 2.3.1  [ Apply Mod ] [ List Files ] [ Delete ] 
54. Country Flags 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
55. PSN GamerCard BBC 1.5  [ List Files ] [ Delete ] 

If anybody has any suggestions on how I can fix it, I'd like to hear them...
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Eclipse16V on March 15, 2010, 02:18:28 AM
Nice Mod

Please update it for SMF 2.0RC3  ;)

Thanks
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: booch_21 on March 17, 2010, 01:09:27 PM
Quote from: cieplutki on January 16, 2010, 06:24:15 PM
Yes work fine on rc 2 added icon windows 7
Thank you for making this update!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Eclipse16V on March 24, 2010, 04:53:33 AM
Work fine on 2.0 RC3
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: MrCrow on March 25, 2010, 12:52:21 PM
I have read here in few old post that if it doesn't show images next to the name of the OS and browser to copy manually those images in my theme/images folder, but that still didn't work, i am using smf 1.1.11 and tp 1.0 beta4

--------------------------------------------------------
nvm i managed to fix it by uploading images along with folder os_browser_detection
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: rjckE on March 25, 2010, 11:56:19 PM
Quote from: Eclipse16V on March 24, 2010, 04:53:33 AM
Work fine on 2.0 RC3

Thanks, useful information
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: c23_Mike on April 05, 2010, 07:21:38 PM
Hi there !

Wanted today update my site to RC3, also done, but when installing this mod it comes until:

Datenbankfehler
Table 'smf2.messages' doesn't exist
Datei: /var/www/c23/cgi-bin/portal/Packages/temp/install.php
Zeile: 19

at installation.
What to do?

In my database I see there is a table smf messages? Something wrong at the install script?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: eKro on April 10, 2010, 12:38:37 PM
Quote from: c23_Mike on April 05, 2010, 07:21:38 PM
Hi there !

Wanted today update my site to RC3, also done, but when installing this mod it comes until:

Datenbankfehler
Table 'smf2.messages' doesn't exist
Datei: /var/www/c23/cgi-bin/portal/Packages/temp/install.php
Zeile: 19

at installation.
What to do?

In my database I see there is a table smf messages? Something wrong at the install script?

same thing here... Please I NEED THIS PLUG-IN ITS AWSOME!

Table 'appleteketech.messages' doesn't exist
Dosya: /var/www/vhosts/teknoturkey.com/subdomains/forum/httpdocs/Packages/temp/install.php
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Arantor on April 10, 2010, 02:30:22 PM
Yes, there's something wrong with the install script because of a change to how the database instructions were done.

If you look in the package for 2.0, you will see install.php and in it are several instances of this line:
$smcFunc['db_add_column']("messages",

Change every one of them to:
$smcFunc['db_add_column']("{db_prefix}messages",
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: c23_Mike on April 10, 2010, 08:58:53 PM
Hi there!

Wonderful, that was the correct hint! The install file should be corrected for version 2 ...
But tnx a lot!!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: rd on April 10, 2010, 09:11:00 PM
This mod is pretty cool, I use it in my 2.0 RC3 forum with a custom theme.

http://duke.xadro.net
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Arantor on April 11, 2010, 05:27:54 AM
Quote from: c23_Mike on April 10, 2010, 08:58:53 PM
Hi there!

Wonderful, that was the correct hint! The install file should be corrected for version 2 ...
But tnx a lot!!

Requires that the original author come online and modify it - this package was last updated about a year ago.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: kaansef on May 29, 2010, 07:15:48 AM
Hello,

I'm Turkish and this mod not work in RC3.

Please help me.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: c23_Mike on May 29, 2010, 09:22:42 AM
Hi there!

Read thze several last post. That you are turkish is no excuse.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Masterd on June 15, 2010, 07:20:56 AM
I installed this manualy on SMF 2.0 RC3 and I can't run the query.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on June 24, 2010, 11:42:28 AM
This is a very good mod. It make our poster's information look nicer. Anyway, I found that the icons are of different height and that caused the icons' image not being diplayed inline properly. So I took the liberty to modify all the icons to a specific height of 16 pixel only. I attach them here in a zipped file so that others can use it if they want too. You will need to extract it inside the default/images/os_browser_detection folder so that it will replace your current one. All the best.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Masterd on August 02, 2010, 10:17:21 AM
I solved my problem.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on August 02, 2010, 01:23:58 PM
working version on smf 2.0 rc3
demo on ewmapa.pl (http://ewmapa.pl/index.php/topic,27.0.html)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: diamondred123 on August 02, 2010, 01:45:41 PM
Quote from: cieplutki on August 02, 2010, 01:23:58 PM
working version on smf 2.0 rc3
demo on ewmapa.pl (http://ewmapa.pl/index.php/topic,27.0.html)
worked
thanks
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Deezel on August 04, 2010, 07:14:17 AM
Quote from: cieplutki on August 02, 2010, 01:23:58 PM
working version on smf 2.0 rc3
demo on ewmapa.pl (http://ewmapa.pl/index.php/topic,27.0.html)

Thanks, that one worked.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Leto Atreides II on August 12, 2010, 11:01:27 PM
I tried installing this a couple of times and kept getting the same error message:

Quote6.     Execute Modification     ./Sources/Display.php     Test failed
Apparently in /Sources/Display.php, I'm supposed to find:

Find[Select]
k.message AS is_repped

Add After[Select]
, m.ua_os, m.ua_browser, m.ua_os_icon, m.ua_browser_icon

... I opened /Sources/Display.php manually, there is no 'k.message AS is_repped' anywhere in the code. I even searched for parts of it - 'message' and 'repped' - in case the coding was there but different; but I couldn't find any of it.

I'm running SMF 2.0 RC3 on this particular forum:

http://www.kriegbrut.org/boards/board/index.php
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on August 13, 2010, 03:56:50 AM
/Sources/Display.php

find
id_msg_modified < {int:new_from} AS is_read

its near 981 line  ;)

and replace for this

id_msg_modified < {int:new_from} AS is_read,
ua_os, ua_browser, ua_os_icon, ua_browser_icon


8)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Leto Atreides II on August 13, 2010, 03:05:29 PM
I tried that... then when I installed, I got this message:

QuoteTable 'kriegbru_2smf.messages' doesn't exist
File: /home/kriegbru/domains/kriegbrut.org/public_html/boards/board/Packages/temp/install.php
Line: 19

Plus, when I went to view a thread, I got this message:

QuoteUnknown column 'ua_os' in 'field list'
File: /home/kriegbru/domains/kriegbrut.org/public_html/boards/board/Sources/Display.php
Line: 990
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on August 14, 2010, 05:19:13 AM
Try on "/Packages" create new folder and name them "temp", used 755 or 777 chmod and try again install mod or try another maybe you something wrong ith Your install forum

//edit
chmod not 775 but 755 sorry for my mystake
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: sinner-rus on August 14, 2010, 01:19:56 PM
When will be update base? Mod can't see my iPhone, iPad, new Opera, Symbian .... it is bad!)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on August 14, 2010, 03:14:17 PM
Quote from: sinner-rus on August 14, 2010, 01:19:56 PM
When will be update base? Mod can't see my iPhone, iPad, new Opera, Symbian .... it is bad!)

Well you try as autor: X3mE (http://www.simplemachines.org/community/index.php?action=profile;u=154415) this moda
I update only source  O:)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Leto Atreides II on August 14, 2010, 03:23:25 PM
Quote from: cieplutki on August 14, 2010, 05:19:13 AM
Try on "/Packages" create new folder and name them "temp", used 775 or 777 chmod and try again install mod or try another maybe you something wrong ith Your install forum
My Packages folder already contains a folder called 'temp' at 777. It includes some files left by the OS & Browser Detection mod.

I suspect something is fundamentally wrong with this mod, I'm going to uninstall it for now.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on August 15, 2010, 05:54:03 AM
As you wish on my forum this mod working fine

example topic (http://ewmapa.pl/index.php/topic,90.0.html)
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~Dragon~ on August 20, 2010, 06:03:15 PM
I don't understand what is exactly problem http://custom.simplemachines.org/mods/index.php?mod=1515 permission change? I am not sure how do you know I need to practice study how do you know pretty sound  hard! i guess not easy! I have mess damn it. where is find it! I need to find fix on really problem?  permission is 777? or exactly not work?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: rgpatton on August 24, 2010, 09:34:30 AM
When trying to install this package in SMF 2.0 RC3, I keep getting this error. Can you please help? I have tried this on my test site and active site. with other packages installed and with out. I have even tried it with default theme and with custom. I keep getting the same error. Please help, Thanks.

Error:
Table 'ccccccccxxxxxx38.messages' doesn't exist
File: /home/content/x/x/x/xxxxxxxxxx/html/SMF2/Packages/temp/install.php
Line: 19

I do not fully understand code, but when I look up this file, install.php, I do not find that message any where. Is there something I need to do in my database to make this work as I have seen it in action elsewhere and even on the theme I want to use.

Thank you for your time on this as I really would like to use this mod.

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Dani88 on September 04, 2010, 01:45:15 PM
I can not get it to work ... I installed it all but nothing appears in the profile box, or images up anything, my theme has templante display, it can be for that? Help me
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on September 04, 2010, 04:32:08 PM
hmmm
lets look on your ftp and find Directory \themes\default\images\os_browser_detection
copy all on hdd and copy on all them
\themes\another them\images\
like that

(http://www.divshare.com/img/12461864-ff1.png)

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Dani88 on September 04, 2010, 05:36:47 PM
No case or in the default theme are changes, it's like to be installed but not


EDIT: sorry, true that the mod worked once posted something, I expect to see in the topics that were already
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: katb on September 07, 2010, 04:32:31 PM
i am getting following error ,

Duplicate column name 'ua_os'
File: /home/forum/public_html/New/Packages/temp/install_1.php
Line: 22

Note: It appears that your database may require an upgrade. Your forum's files are currently at version SMF 1.1.11, while your database is at version 1.1.6. The above error might possibly go away if you execute the latest version of upgrade.php.

Please tell me how to resolve this. Thanks in advance
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~Dragon~ on September 14, 2010, 06:09:10 PM
Database Error: Table 'smithtr_v3.messages' doesn't existFile: /home/xxxx/public_html/Packages/temp/install.php
Line: 19

tell me about to problem! I have database?
where is tell me not work

Doesn't work?

but I wonder? stranger? i am not sure aware how install.php?? code?

Thank ASAP
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: snoopy_virtual on September 17, 2010, 01:31:49 PM
Quote from: smithtr on September 14, 2010, 06:09:10 PM
Database Error: Table 'smithtr_v3.messages' doesn't existFile: /home/xxxx/public_html/Packages/temp/install.php
Line: 19

tell me about to problem! I have database?
where is tell me not work

Doesn't work?

but I wonder? stranger? i am not sure aware how install.php?? code?

Thank ASAP

Hi smithtr,

I was talking today with your friend Dharshan. He asked me for help with this issue you have here.

I have been thinking about it all afternoon and I think I have found the solution:

This mod is not compatible with SMF 2.0 RC3 and it needs a few changes in it.

The problem is the mod creator X3mE apparently has not been very active in SMF during the last year.

I have sent him a PM anyway telling him what changes I think need to be done, because it is his mod, so I think is him who is supposed to do a new version if he consider it necessary, but if he doesn't answer in a couple of days I can do a new version myself and publish it here.

We will see.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 17, 2010, 01:41:19 PM
There is an update for that mod in this support thread. I've already advised him when I did the installation from him last time (several times already). I have also created a test site for him (on his own hosting) and have advised that he do all the trial there instead of on a live site. I just noted that he keep on making a new site all the time. So I stopped helping with the hope that he will learn this time round.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: snoopy_virtual on September 17, 2010, 03:46:34 PM
OMG

I didn't read the full thread (as I normally do with any new mod I'm going to install) because I assumed smithtr already had done that.

Anyway I didn't know this mod before, and investigating it I found out I liked it, so I have read the full thread, I have downloaded the new version published by cieplutki here: http://www.simplemachines.org/community/index.php?topic=278770.msg2728368#msg2728368 with the new icons made by ahrasis here: http://www.simplemachines.org/community/index.php?topic=278770.msg2678792#msg2678792 and installed it on 2 of my forums. One using SMF 1.1.11 and other one using SMF 2.0 RC2

No problems at all with any of them.

==========================

Anyway I have done a couple of small modifications:

I have seen the Spanish translations are not complete.
Any Spanish speaking user need to add these 3 lines inside the file languages.xml to all the Spanish languages:


$txt['permissiongroup_simple_view_os_browser'] = 'Ver el SO y el Navegador detectado en los mensajes';
$txt['permissionname_view_os_browser'] = 'Ver el SO y el Navegador detectado en los mensajes';
$txt['permissionhelp_view_os_browser'] = 'Si se activa, este usuario podrá ver en todos los mensajes los Sistemas Operativos y los Navegadores, si es que son detectados.';


Also if you want you can add inside os_browser_detection.php support for the last 2 Ubuntu versions, Karmic and Lucid:

Find around line 724 the code:


        // Try to detect version
if(preg_match('/jaunty/si', $user_agent))
          {
          $client_data['system'] .= " 9.04 Jaunty)";
          }


Replace with:


        // Try to detect version
        if(preg_match('/lucid/si', $user_agent))
          {
          $client_data['system'] .= " 10.04 Lucid)";
          }
        elseif(preg_match('/karmic/si', $user_agent))
          {
          $client_data['system'] .= " 9.10 Karmic)";
          }       
elseif(preg_match('/jaunty/si', $user_agent))
          {
          $client_data['system'] .= " 9.04 Jaunty)";
          }
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on September 18, 2010, 03:43:24 AM
last 2 Ubuntu versions, Karmic and Lucid added to os&browser detection
thx @snoopy_virtual
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 18, 2010, 08:25:46 AM
Quote from: cieplutki on September 18, 2010, 03:43:24 AM
last 2 Ubuntu versions, Karmic and Lucid added to os&browser detection
thx @snoopy_virtual
Thanks for the update. I suggest you post the mod update to mod site. I hope SMF Customizer team can see this and consider a take over since original maker is not around for quite sometimes.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Dharshan on September 18, 2010, 12:02:00 PM
Thanks snoopy_virtual,

this is for taking your time to help out a stranger, these kinda qualities are, well ..hard to come by these days..

cheers!
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: snoopy_virtual on September 19, 2010, 10:49:08 AM
I would do another small modification.

I have been reading again the full thread and I have seen there are some people having problems with the folder you need to put the icons.

The problem is when you install the mod all the icons go to the folder /Themes/default/images/os_browser_detection/ but when you are using the mod, the file Display.template.php doesn't try to find the icons in that folder, but inside the folder of the particular Theme you are using.

Of course, for people who have been using SMF for some time is very easy to understand you need to copy the folder with all the icons (os_browser_detection) from the default Theme to your particular Theme, but for noobs with very few experience in SMF this is not something easy to understand.

The solution though is very easy and I normally use it in my mods:

If you have put the icons inside the default Theme folder, why you want to read them from other folder?

I mean, instead of using $settings['images_url'] (path to the images folder inside your particular Theme) why not use $settings['default_images_url'] (path to the images folder inside the default Theme)?

So the solution is to open the files modification.xml and modification_smf1.xml, find inside them every variable:


$settings['images_url']


(They appear 4 times in each file)

And replace them with:


$settings['default_images_url']
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 19, 2010, 12:13:58 PM
I am not sure I get this. May be I read again next time.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Dharshan on September 19, 2010, 01:45:04 PM
@ Snoopy_vertual... That's Nice..
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 19, 2010, 02:14:05 PM
Ok. Now I get it. It must be the line its modify and add inside Display.template.php then. Yeah, I also think this should be updated.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: cieplutki on September 19, 2010, 02:32:45 PM
Quote
I mean, instead of using $settings['images_url'] (path to the images folder inside your particular Theme) why not use $settings['default_images_url'] (path to the images folder inside the default Theme)?

So the solution is to open the files modification.xml and modification_smf1.xml, find inside them every variable:


$settings['images_url']


(They appear 4 times in each file)

And replace them with:


$settings['default_images_url']


yes it's work fine on smf 2.0 RC3
update mod on attachments
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 19, 2010, 02:37:32 PM
You are really fast cieplutki. Consider taking over this mod please!  :D And thanks again for all the "working" updates.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: snoopy_virtual on September 19, 2010, 04:17:29 PM
Quote from: cieplutki on September 19, 2010, 02:32:45 PM
yes it's work fine on smf 2.0 RC3
update mod on attachments

It works also in SMF 1.1.11
I have checked it.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: X3mE on September 19, 2010, 10:40:51 PM
Ok people, I'm sorry I was absent, but I didn't have time for SMF due to many obligations IRL.

Thank you all for your comments and contributions, and finally we have an official new version!

Here's the changelog:

* version 1.5 (20. 09. 2010.)
- Added SMF 2.0 RC3 compatibility (thanks to everyone in the support topic who posted their comments, especially cieplutki & snoopy_virtual), not working with earlier SMF 2.0 branch anymore, use 1.4 instead!
- Updated the base detection engine for new releases of browsers and operating systems
- Spanish translation updated (thanks to snoopy_virtual)
- Russian translation added (thanks to Gladman)
- Turkish translation added (thanks to ოկtђ)
- Thai translation added (thanks to Rid-rop)
- Italian translation added (thanks to CrazyHorse80)

Feedback is always appreciated, even if it takes some time for me to read it :)

I hope I will update my other mods soon, and add some new ones I've been planing for a while.
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: snoopy_virtual on September 19, 2010, 11:31:16 PM
I have done another small modification.

I am always very paranoid with the security, always watching for hackers trying to do something on my webs, spammers attacking my forums, etc, so I was watching today in one of my forums the page "Who's online", tracking a couple of suspicious visitors to see what they were doing on the forum, and then I thought: "It's a pity I cannot see also what OS & Browser they have, as I can see now every time somebody post anything."

And then I thought: "Why not? With the mod OS & Browser Detection installed I already have all the tools I need, I only need to add a few lines to the file Who.template.php to be able to see that."

OK, it's very nice to see in every post the OS & Browser the poster was using, but it's even more useful to see the OS & Browser every visitor has even if they are not posting anything.

Also, as the page "Who's online" is changing all the time, displaying only the visitors on-line every time we watch it, there is no need to add anything to the database. We just need a few lines of code to parse the user agent and display the detected info.

I have done a new package (attached) with the version number 1.4.1

==========================

OK, I was just writing this when suddenly I saw X3mE has published his version 1.5

So suddenly my package is already obsolete.

Anyway, I leave it here so you can see the changes I have done and apply them to the mod if you want, beacuse thay are not in version 1.5

The new changes are inside the files modification.xml and modification_smf1.xml. All the final part from:


<file name="$themedir/Who.template.php">


Now I will need to download the new version 1.5 and check it out  ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Cal O'Shaw on September 20, 2010, 03:09:52 AM
Perhaps X3mE will find your work interesting enough to integrate?
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 20, 2010, 05:15:36 AM
Quote from: X3mE on September 19, 2010, 10:40:51 PM
Ok people, I'm sorry I was absent, but I didn't have time for SMF due to many obligations IRL.

Thank you all for your comments and contributions, and finally we have an official new version!

Here's the changelog:

* version 1.5 (20. 09. 2010.)
- Added SMF 2.0 RC3 compatibility (thanks to everyone in the support topic who posted their comments, especially cieplutki & snoopy_virtual), not working with earlier SMF 2.0 branch anymore, use 1.4 instead!
- Updated the base detection engine for new releases of browsers and operating systems
- Spanish translation updated (thanks to snoopy_virtual)
- Russian translation added (thanks to Gladman)
- Turkish translation added (thanks to ოկtђ)
- Thai translation added (thanks to Rid-rop)
- Italian translation added (thanks to CrazyHorse80)

Feedback is always appreciated, even if it takes some time for me to read it :)

I hope I will update my other mods soon, and add some new ones I've been planing for a while.
Have you included all the updates made by cieplutki & snoopy_virtual? I haven't tried your new one yet but surely will do soon.

By the way, are you still using the old icons (which is of different height) or the new that I posted somewhere in the few pages back. I really don't like it being of different height as it looks ugly.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: X3mE on September 20, 2010, 07:47:46 AM
Quote from: Cal O'Shaw on September 20, 2010, 03:09:52 AM
Perhaps X3mE will find your work interesting enough to integrate?

I will have a look. Maybe I'll integrate it, maybe it could be a standalone addon? I suppose not all forum owners would like something like that. Anyway I'll give it a thought.

Quote from: ahrasis on September 20, 2010, 05:15:36 AM
Have you included all the updates made by cieplutki & snoopy_virtual? I haven't tried your new one yet but surely will do soon.

By the way, are you still using the old icons (which is of different height) or the new that I posted somewhere in the few pages back. I really don't like it being of different height as it looks ugly.

Yes, I've revised all comments and attachments posted here and changed the code accordingly.

But I've missed the new icons. Haven't changed anything there. I'll give it a look. Thanks ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on September 20, 2010, 08:29:17 AM
Quote from: X3mE on September 20, 2010, 07:47:46 AM
I will have a look. Maybe I'll integrate it, maybe it could be a standalone addon? I suppose not all forum owners would like something like that. Anyway I'll give it a thought.

It's up to you. Just let me know what you are doing.

If you are not using it I will consider to release it as a standalone mod, but I'm not sure about it, because just for a few new lines of code I would need to include in it again the file os_browser_detection.php plus the folder with all the icons, the language files, etc. Too many repeated files maybe.  ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Dharshan on September 20, 2010, 09:06:47 AM
well done all. :)

and thanks snoopy_virtual for adding in the extra code....

and check what i got scanning my guests... (whose online list)

you have a IE 5.5  :o and a Windows NT4  :o
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on September 20, 2010, 12:14:38 PM
Quote from: Dharshan on September 20, 2010, 09:06:47 AM
well done all. :)
you have a IE 5.5  :o and a Windows NT4  :o

That must be somebody else.

I have Ubuntu Lucid 10.04 and Firefox 3.6.10  ;D
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: roonekoos on September 21, 2010, 10:35:33 AM
The mod is not working on my forum, test forum works fine but on my live forum I have more mod's installed.

I had to do manual add on the file Subs-Post.php , all other files were installed fine.
I see the admin options and all seems fine but I don't see anything added with new posts.
Error log don't show anything eighter.

I hope somebody can help me out.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on September 21, 2010, 11:18:58 AM
Quote from: roonekoos on September 21, 2010, 10:35:33 AM
The mod is not working on my forum, test forum works fine but on my live forum I have more mod's installed.

I had to do manual add on the file Subs-Post.php , all other files were installed fine.
I see the admin options and all seems fine but I don't see anything added with new posts.
Error log don't show anything eighter.

I hope somebody can help me out.

Check if you have the file Display.template.php inside the Theme you are using.

If you have you will need to edit it manually, because the mod's installer only edit the default Theme.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: roonekoos on September 22, 2010, 03:07:02 PM
Quote from: snoopy_virtual on September 21, 2010, 11:18:58 AM
Quote from: roonekoos on September 21, 2010, 10:35:33 AM
The mod is not working on my forum, test forum works fine but on my live forum I have more mod's installed.

I had to do manual add on the file Subs-Post.php , all other files were installed fine.
I see the admin options and all seems fine but I don't see anything added with new posts.
Error log don't show anything eighter.

I hope somebody can help me out.

Check if you have the file Display.template.php inside the Theme you are using.

If you have you will need to edit it manually, because the mod's installer only edit the default Theme.


On my test forum it works fine with the same theme I use on my live forum.
That theme is pro curve , display.template.php from default is used by this theme
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: -=[Vyorel]=- on September 22, 2010, 03:32:01 PM
Romanian translate:

$txt['OS_Browser_Compatible'] = 'compatibil';
$txt['OS_Browser_OS'] = 'Sistem de Operare';
$txt['OS_Browser_Unknown'] = 'Necunoscut';
$txt['OS_Browser_Browser'] = 'Browser';
$txt['permissiongroup_simple_view_os_browser'] = 'Vizualizeaza detectat OS & Browser in mesajele postate';
$txt['permissionname_view_os_browser'] = 'Vizualizeaza detectat OS & Browser in mesajele postate';
$txt['permissionhelp_view_os_browser'] = 'Daca este activat, membrul va vedea detectat OS & Browser in fiecare mesaj postat, daca sunt detectate.';
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: uninvited13th on September 22, 2010, 11:05:13 PM
help..

can you make other install.php?

cos when i run it it says hacking attempt..

im using smf 2.0rc3
Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: ~Dragon~ on September 23, 2010, 12:18:42 AM
Quote from: snoopy_virtual on September 17, 2010, 01:31:49 PM
Quote from: smithtr on September 14, 2010, 06:09:10 PM
Database Error: Table 'smithtr_v3.messages' doesn't existFile: /home/xxxx/public_html/Packages/temp/install.php
Line: 19

tell me about to problem! I have database?
where is tell me not work

Doesn't work?

but I wonder? stranger? i am not sure aware how install.php?? code?

Thank ASAP

Hi smithtr,

I was talking today with your friend Dharshan. He asked me for help with this issue you have here.

I have been thinking about it all afternoon and I think I have found the solution:

This mod is not compatible with SMF 2.0 RC3 and it needs a few changes in it.

The problem is the mod creator X3mE apparently has not been very active in SMF during the last year.

I have sent him a PM anyway telling him what changes I think need to be done, because it is his mod, so I think is him who is supposed to do a new version if he consider it necessary, but if he doesn't answer in a couple of days I can do a new version myself and publish it here.

We will see.


I have successfully! I have work my mod is very work successfully I have solve mark!
cheer
successfully work mod
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: coldy316 on September 23, 2010, 01:17:40 AM
Maybe i'm having the problem or the mod is having a problem.

I'm running windows 7 the mod detects that fine but not the browser. its reading the browser
as windows ie 7 when its not ie 7. matter of fact i'm using IE8 how can i fix this slight problem

I'm running smf 2.rc3 forum software with default curve

Title: Re: OS & Browser Detection (version 1.4 is out) [29. 04. 2009.]
Post by: Hj Ahmad Rasyid Hj Ismail on September 23, 2010, 05:43:05 AM
Quote from: smithtr on September 23, 2010, 12:18:42 AM
I have successfully! I have work my mod is very work successfully I have solve mark!
cheer
successfully work mod
Nice to hear that you are finally managing things and successfully doing them all by yourself. Congratulations smithtr!
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: coldy316 on September 23, 2010, 09:55:52 PM
still need an answer from my topic, can someone please explain what could be the problem

Quote

Maybe i'm having the problem or the mod is having a problem.

I'm running windows 7 the mod detects that fine but not the browser. its reading the browser
as windows ie 7 when its not ie 7. matter of fact i'm using IE8 how can i fix this slight problem

I'm running smf 2.rc3 forum software with default curve

Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Cal O'Shaw on September 24, 2010, 01:26:57 AM
Hello,

I've run into a problem trying to upgrade my SMF 1.1.11 forum from v1.4 to 1.5.  It looks like some other MOD altered code so that install fails.  Don't know which MOD did it (wish some sort of comments or tracking were added to the php files), but as an example, here is the first string that install tries to match in Display.php:
                m.ID_MSG_MODIFIED < $topicinfo[new_from] AS isRead

Note the "m." at the start.

Anyway, I was wondering, as a visual compare of the 1.4 and 1.5 PARSE appear identical, can I just extract the os_browser_detection.php file and all the png files and just copy them into the proper places? (a stripped down install package to do that would be wonderful but this is probably a one-off situation and I already appreciate you putting in the time on this MOD, which has been really handy)

Grazie,

Cal
Title: I can't enable it only for Admin
Post by: Loginsvarios on September 30, 2010, 10:07:06 AM
Greetings.
I installed this fantastic mod (I love that it shows my dear Linux Mandriva 2010.1 OS) and it works right.

But when a enter as a Global Moderator (permission OFF in Membergroups) I can see my OS and the Admin OS.

Any tip?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on October 01, 2010, 04:34:53 PM
If any of you is using (as I do) the icons ahrasis re-sized here (http://www.simplemachines.org/community/index.php?topic=278770.msg2678792#msg2678792),  you may have notice that in the new 1.5 version X3mE is not using them, and you may have noticed also that there are now 3 more icons, because  the mod now recognizes more OS & Browsers.

Just in case you want to continue using the icons ahrasis re-sized instead of the mod original ones, you are missing the 3 new ones, so I have just re-size the 3 new icons in the file attached.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sea Mac on October 11, 2010, 09:37:05 PM
I Love this MOD! Thank You very Much!

But I used to use a Custom Who.template.php MOD that did a great job of sorting each page into Users/Guests/Spiders categories.   http://www.simplemachines.org/community/index.php?topic=19243.0

Long unsupported, it basically worked fine on everything in the 1.1.x branch.  Is there any way I can merge the functionality of this MOD with that old Template?

Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Cal O'Shaw on October 12, 2010, 01:58:51 AM
Hello,

Still wondering if I can just replace the icons and engine php file as some other MOD altered the code and prevents uninstalling 1.4 and installing 1.5.  Can anyone confirm the code that modifies SMF php files did NOT change going from 1.4 to 1.5 for 1.1.x sites?

Just saw the version I have is identifying some XP users as Vista and IE9 as IE7.  I really would like to record this info accurately.

Running SMF 1.1.11.

Grazie,

Cal
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on October 12, 2010, 01:49:11 PM
Quote from: Sea Mac on October 11, 2010, 09:37:05 PM
I Love this MOD! Thank You very Much!

But I used to use a Custom Who.template.php MOD that did a great job of sorting each page into Users/Guests/Spiders categories.   http://www.simplemachines.org/community/index.php?topic=19243.0

Long unsupported, it basically worked fine on everything in the 1.1.x branch.  Is there any way I can merge the functionality of this MOD with that old Template?



This mod doesn't change anything inside Who.template.php

The only version that has anything to do with Who.template.php is a small modification I did some time ago, but X3mE (the mod owner) said he was not going to put it inside his mod, so I have added it instead to my mod httpBL.

I have answered you inside my mod support thread.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on October 12, 2010, 01:53:15 PM
Quote from: Cal O'Shaw on October 12, 2010, 01:58:51 AM
Can anyone confirm the code that modifies SMF php files did NOT change going from 1.4 to 1.5 for 1.1.x sites?

There are a lot of changes from version 1.4 to version 1.5 and yes the code that modifies SMF php files did change a lot.

Quote from: Cal O'Shaw on October 12, 2010, 01:58:51 AM
Just saw the version I have is identifying some XP users as Vista and IE9 as IE7.  I really would like to record this info accurately.

In my forums I see it identify everything correctly. I don't understand why it's not doing it in your forum.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Cal O'Shaw on October 13, 2010, 12:58:49 AM
My problem is, as noted in Reply 282 above, some other MOD altered code that prevents uninstalling.  And you said MOD code has changed.

Question: Are the edits to .\Sources\Display.php and .\Sources\ManagePermissions.php changed from 1.4 to 1.5?  If not, then I should be able to uninstall 1.4, ignoring the warnings about the 2 files.  Then install 1.5, still ignoring the warnings for those 2 files.

And it turns out my user admitted he was running Vista.  But the IE9 Beta is showing as IE7, which I am looking forward to fixing with 1.5.

Cal
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on October 13, 2010, 09:52:56 AM
Quote from: snoopy_virtual on October 12, 2010, 01:53:15 PM
Quote from: Cal O'Shaw on October 12, 2010, 01:58:51 AM
Can anyone confirm the code that modifies SMF php files did NOT change going from 1.4 to 1.5 for 1.1.x sites?

There are a lot of changes from version 1.4 to version 1.5 and yes the code that modifies SMF php files did change a lot.

I am very sorry Cal, I made a mistake. I was comparing the wrong files.

Instead of comparing the files from the 1.4 version with the files of the original 1.5 version from X3mE, I was comparing them with the files of the version 1.5 I have actually installed in my forum and of course there are a lot of differences because I always change a lot of things in all the mods I install. I almost never install the mods the way they come, but always change them to suit my needs.

Of course I always keep a copy of the original files for future references, but this time I made a mistake and I was looking at the wrong files. I was trying to do too many things at the same time and when I compared the files and saw there was a lot of changes I didn't double check to be sure, so I didn't realize I wasn't looking at the proper files I should.

Today, when I read you were asking for the particular differences in the files Display.php and ManagePermissions.php I went to check that and found out the mistake I did yesterday.

OK, I have double checked again (looking at the proper files) and I have seen there aren't any important changes in SMF 1.1.11 between versions 1.4 and 1.5. All the big changes have been only for SMF 2.0

For SMF 1.1.11 there has been only one change really: The mod now look for the icons inside the default Theme folder instead of inside the folder of the particular Theme you are using, so the people who install the mod now (like a new mod) don't need to copy the icons from one folder to the other.

But if you have already the icons copied from the default Theme to your Theme, you can forget about this change and just continue using version 1.4

So the only thing you really need is to download the file OS_Browser_Detection_v1.5_SMF_1.x_SMF_2.x.zip, unzip it and extract from it the file os_browser_detection.php

That's the file that do the actual checking looking for the OS & Browser. Upload this file to the Sources folder in your forum overwriting the file you already should have there.

There are also 3 new icons in version 1.5 you need to add to the folder where you have the old ones inside your Theme images folder:


If you are using the icons ahrasis did on reply #232 you can download these 3 new icons from my reply #284
If you are using the original icons from X3mE just find them in the package 1.5

==================================

With just these 2 things you will have your mod working almost like everybody else.

As I said the only difference you will have is your mod will look for the icons inside the images folder of the particular Theme you are using instead of the default Theme (like it's doing for the rest of the people). It's not a very important difference really, but if you want to change that also (to have the mod as everybody) just read my reply #258 and follow the instructions to edit your file Display.template.php

If you are going to edit it, look first inside the folder of the Theme you are using (to see if there is a file Display.template.php there) and if it's there modify it. If it's not there, look inside the default Theme and edit the file Display.template.php in that folder.

Remember also (if you make this change) the mod will look for the icons inside the default Theme folder, so you will need to copy the 3 new icons there.

Quote from: snoopy_virtual on October 12, 2010, 01:53:15 PM
Quote from: Cal O'Shaw on October 12, 2010, 01:58:51 AM
Just saw the version I have is identifying some XP users as Vista and IE9 as IE7.  I really would like to record this info accurately.

In my forums I see it identify everything correctly. I don't understand why it's not doing it in your forum.

As I have already realized I have made a mistake when I was answering you yesterday, I have double checked also this point today. Yesterday I was answering you too quickly and didn't really thought too much about it.

Well, now I'm not really so sure about it.

I am sure about the OS. I can see a lot of examples in my forum of people using Windows XP, Vista and 7 and all of them are detected properly.

But not so sure really about the browser.

I thought I had seen somebody using IE9 but when I have double checked today, looking one by one carefully to all the entries there in no one IE9 there. A lot of IE7 and IE8, but no IE9 at all. So maybe you are right there and the mod is detecting it wrong.

Can you do the changes I told you above and ask your friend (the one who uses IE9) to write something in your forum so you can check if it's detecting it properly now or not?

The problem is I cannot check it myself because I don't have IE9 installed in any of my computers, but if there is a problem with that I will like to confirm it to sort it.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Saxtus on October 27, 2010, 09:02:35 AM
Can you add Pale Moon browser? (palemoon.org)

USER-AGENT: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.11) Gecko/20101023 BTRS35926 Firefox/3.6.11 (Palemoon/3.6.11)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on October 31, 2010, 09:06:53 AM
Croatian utf-8 translation:

$txt['OS_Browser_Compatible'] = 'Kompaktibilan';
$txt['OS_Browser_OS'] = 'OS';
$txt['OS_Browser_Unknown'] = 'Nepoznat';
$txt['OS_Browser_Browser'] = 'Preglednik';
$txt['permissiongroup_simple_view_os_browser'] = 'Vidjeti detektirani OS & Preglednik u postu ';
$txt['permissionname_view_os_browser'] = 'Vidjeti detektirani OS & Preglednik u postu';
$txt['permissionhelp_view_os_browser'] = 'Ako je omogućeno, član će vidjeti detektirani OS i Preglednik za svaki post, ako su detektirani';
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: coldy316 on November 05, 2010, 09:44:07 PM
Quote from: coldy316 on September 23, 2010, 09:55:52 PM
still need an answer from my topic, can someone please explain what could be the problem

Quote

Maybe i'm having the problem or the mod is having a problem.

I'm running windows 7 the mod detects that fine but not the browser. its reading the browser
as windows ie 7 when its not ie 7. matter of fact i'm using IE8 how can i fix this slight problem

I'm running smf 2.rc3 forum software with default curve


considering no one has replied to this or suggested any help towards me i guess i have to bump this up again

I know everyone has problems and i understand that. I really thought it would go in order wise for help..
   I'm really just asking for a simple modification on this, i'm sure its just something small to adjust.

majority of the other information doesnt relate to my problem
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on November 06, 2010, 07:32:47 AM
Quote from: coldy316 on November 05, 2010, 09:44:07 PM
I'm running windows 7 the mod detects that fine but not the browser. its reading the browser
as windows ie 7 when its not ie 7. matter of fact i'm using IE8 how can i fix this slight problem

   I'm really just asking for a simple modification on this, i'm sure its just something small to adjust.

Well, I don't think it's a simple modification, as nobody else has this problem. Assuming of course you have already updated your mod to the latest version.

To fix this I will need to see the inside of your forum to check what's wrong.

Can you contact me through Skype?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: GazOutEast on November 22, 2010, 12:55:03 PM
Is there any prediction about when it will be released for SMF 2.0 RC4?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on November 22, 2010, 01:30:00 PM
I have just installed it in a 2.0 RC4 forum and didn't see any errors at all.

Have you seen any?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: #Pascal on November 22, 2010, 01:30:31 PM
Quote from: GazOutEast on November 22, 2010, 12:55:03 PM
Is there any prediction about when it will be released for SMF 2.0 RC4?
It works under RC4 without any problem (use version emulation in order to install it in admin CP)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on December 18, 2010, 11:43:28 PM
Having a little bit of an issue with the Users Online listing. It's displaying the OS and Browser twice for each user, even spiders, rather than once each. Any ideas on this? Using SMF2 RC4.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: DSK-Googler on December 19, 2010, 09:46:11 AM
i hv installed this mod....
installation successful .. but i cant find where to enable this mod...
im using silent wave theme /smf2.0RC4
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Exsharaen on December 28, 2010, 12:33:37 PM
At first installation I was quite surprised... the information has already been translated to Indonesian! I checked here but no translation yet... I think it's because I translated snoopy_virtual's httpBL mod :D

Here's my translation for Indonesian (UTF-8 if you don't mind):

Quote$txt['OS_Browser_Compatible'] = 'kompatibel';
$txt['OS_Browser_OS'] = 'Sistem Operasi';
$txt['OS_Browser_Unknown'] = 'Tidak Diketahui';
$txt['OS_Browser_Browser'] = 'Peramban';
$txt['permissiongroup_simple_view_os_browser'] = 'Lihat sistem operasi & peramban terdeteksi pada tulisan';
$txt['permissionname_view_os_browser'] = 'Lihat sistem operasi & peramban terdeteksi pada tulisan';
$txt['permissionhelp_view_os_browser'] = 'Jika aktif, anggota akan melihat sistem operasi dan peramban pada tiap tulisan, jika terdeteksi.'

Thanks for the mod :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on December 28, 2010, 12:37:44 PM
Simple Browser is detected as IE, for everybody's interest.

I didn't feel like digging even more into VB to just change SB's engine name from IE to SB.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Jorge D. Fuentes on December 28, 2010, 08:31:01 PM
I installed this solely because it would help me with HTTP-BL.
However, HTTP-BL's new version comes with a mini-version of this which lets me know the info without it going to the user's profile info when they post/reply.

So I uninstalled this... but I have a problem.  The area under the Member where this info goes... is now a long empty batch of space.
Here's an example of what happened.  Again, right now both the OS/Browser Plugin (yours), as well as the HTTP-BL Plugin, are uninstalled, but the table seems permanently changed:
(http://www.inverteddungeon.com/jorgefuentes/images3/OSBrowser-error.png)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on December 28, 2010, 08:44:48 PM
I answered you in the httpBL thread.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: shakaran on January 08, 2011, 03:48:05 PM
Could you update for SMF 2.0 RC4? Thanks.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on January 08, 2011, 07:05:51 PM
Quote from: Jorge D. Fuentes on December 28, 2010, 08:31:01 PM
I installed this solely because it would help me with HTTP-BL.
However, HTTP-BL's new version comes with a mini-version of this which lets me know the info without it going to the user's profile info when they post/reply.

So I uninstalled this... but I have a problem.  The area under the Member where this info goes... is now a long empty batch of space.
Here's an example of what happened.  Again, right now both the OS/Browser Plugin (yours), as well as the HTTP-BL Plugin, are uninstalled, but the table seems permanently changed:
(http://www.inverteddungeon.com/jorgefuentes/images3/OSBrowser-error.png)
Is there anyone with a big avatar?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on January 09, 2011, 12:50:55 PM
Quote from: shakaran on January 08, 2011, 03:48:05 PM
Could you update for SMF 2.0 RC4? Thanks.

It works on SMF 2.0 RC4.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: jmpenasse on January 21, 2011, 08:02:34 PM
Hi !

First, many thanks for this mod !  :)

here is my small contribution :

french translation :

$txt['OS_Browser_Compatible'] = 'compatible';
$txt['OS_Browser_OS'] = 'OS';
$txt['OS_Browser_Unknown'] = 'Inconnu';
$txt['OS_Browser_Browser'] = 'Navigateur';
$txt['permissiongroup_simple_view_os_browser'] = 'Voir dans les messages le Navigateur et l\'OS détectés';
$txt['permissionname_view_os_browser'] = 'Voir dans les messages le Navigateur et l\'OS détectés';
$txt['permissionhelp_view_os_browser'] = 'Si activé, le membre verra dans chaque message le Navigateur et l\'OS détectés, si disponibles.';



I've something to suggest : could you add the langage used by the browser ?

My own OS is detected as "Windows Server Home/Server 2003". In fact my OS is :
Windows XP Professional x64 Edition Version 2003 Service Pack 2
For information, my browser useragent  string is :
Mozilla/5.0 (Windows; U; Windows NT 5.2; fr; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
HTH

cheers
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on January 22, 2011, 07:27:46 AM
Mod has been installed yet despite setting permissions and checking all files intact nothing shows.

Am using RC4
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: żεχเ๏ภ on January 23, 2011, 02:11:28 AM
I'm using the latest version of Flock, which is indeed a version of Chrome... It but it is different. And it detects my browser as "Browser:
Chrome 7.0.517.442"

So.. It's no big deal, just saying. Thought someone might want to know.




Jason
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on January 25, 2011, 10:14:04 AM
Quote from: Brack1 on January 22, 2011, 07:27:46 AM
Mod has been installed yet despite setting permissions and checking all files intact nothing shows.

Am using RC4

BUMP
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on January 25, 2011, 02:50:44 PM
Do you have anything in your error log?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on January 25, 2011, 10:37:05 PM
Quote from: Masterd on January 25, 2011, 02:50:44 PM
Do you have anything in your error log?

No errors in the error log.

The annoying thing is the mod works perfect on the test forum.

(Looks good too.)

Edit: Sorted the problem out. It now works on the main forum. I cheated by using the test forums display template file.

:o
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on January 27, 2011, 01:14:10 PM
It's good to know that you solved your problem.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on February 23, 2011, 06:48:51 AM
Quote from: Inter on February 19, 2011, 11:24:28 AM
SMF 2.0 RC5  ???

What about SMF 2.0 RC5?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on February 23, 2011, 07:49:32 AM
I believe that was a question only missing the politeness and detail - whether this is going to be updated for 2.0 RC5 or not.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on February 23, 2011, 08:05:40 AM
This mod is compatible with SMF 2.0 RC5.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Enc0der on March 08, 2011, 07:34:54 AM
Quote from: Leto Atreides II on August 12, 2010, 11:01:27 PM
I tried installing this a couple of times and kept getting the same error message:

Quote6.     Execute Modification     ./Sources/Display.php     Test failed
Apparently in /Sources/Display.php, I'm supposed to find:

Find[Select]
k.message AS is_repped

Add After[Select]
, m.ua_os, m.ua_browser, m.ua_os_icon, m.ua_browser_icon

... I opened /Sources/Display.php manually, there is no 'k.message AS is_repped' anywhere in the code. I even searched for parts of it - 'message' and 'repped' - in case the coding was there but different; but I couldn't find any of it.

I'm running SMF 2.0 RC3 on this particular forum:

http://www.kriegbrut.org/boards/board/index.php


Same here.
Please fix and make this mod compatible with RC5.

Thank you
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on March 08, 2011, 09:07:38 AM
Try searching for "k."
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on March 16, 2011, 08:51:49 PM
Quote from: Enc0der on March 08, 2011, 07:34:54 AM
Same here.
Please fix and make this mod compatible with RC5.

It's working just fine on my SMF 2.0 RC5 forum. Can you attach your Display.php?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Hj Ahmad Rasyid Hj Ismail on March 20, 2011, 08:16:12 AM
Yup... I think it should work fine with RC5 as RC5 is not updating any Display files at all.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: MATTEK on March 20, 2011, 01:21:36 PM
Mod works great. But I noticed it removes the IM and Blog buttons on a user profile and replaces it with the OS/Browser.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on March 20, 2011, 03:48:35 PM
Quote from: MATTEK on March 20, 2011, 01:21:36 PM
Mod works great. But I noticed it removes the IM and Blog buttons on a user profile and replaces it with the OS/Browser.
Blog button...?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: jaisi on May 05, 2011, 04:57:03 PM
There is three version
OS_Browser_Detection_v1.4_SMF_2.x_ARS.zip
OS_Browser_Detection_v1.4_SMF_1.x_SMF_2.x.zip    
OS_Browser_Detection_v1.5_SMF_1.x_SMF_2.x.zip

Which  version i need to installed ??? my forum Version is Rc5

Thanks In Advance
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on May 06, 2011, 04:38:29 AM
You need to install the latest version.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: c23_Mike on June 13, 2011, 02:27:37 PM
Hi there!

Is that mod already compatible with SMF 2.0? Anyone tested?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Deezel on June 13, 2011, 03:22:10 PM
Works on my site
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on June 14, 2011, 05:01:28 PM
Working well  :laugh: on smf 2.0

(http://img690.imageshack.us/img690/9499/osbrowserdetection.png)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: 017 on June 14, 2011, 05:43:59 PM
It's working on 2.0 RC5, but I am getting reports from a few of my members that it is reporting their OS/browsers incorrectly. Anyone know how to fix this?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on June 15, 2011, 06:32:01 AM
Well, that depends on the actual detection script.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: dougiefresh on June 15, 2011, 02:58:43 PM
Thank you for the wonderful mod!  I thought I'd let everybody know that when I updated my forum from 2.0 RC5 to 2.0 Gold, I had to reinstall all my mods.  This mod installed without issues and without emulation.  Hope this info helps someone!
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: drotha2 on June 16, 2011, 11:41:14 AM
Hello,
help me install it on SMF 2.0 Final?
Thank you very much!
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Masterd on June 16, 2011, 12:53:48 PM
Use the package manager.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: drotha2 on June 16, 2011, 02:19:19 PM
Hello,

Bring to install but fails, please, could you tell me that I have to change or look?

Sorry for the inconvenience and for my bad English

Thank you very much!

Greetings.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: drotha2 on June 22, 2011, 02:59:48 PM
Hello,

I think I'm a little awkward, try to install it with emulation RC5 does not work. I think I will wait to update and is compatible with SMF 2.0 gold, will be watching because I think these things are well in the user profile.
I appreciate this great mod.

thank you very much
regards
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on June 25, 2011, 07:35:12 AM
Quote from: drotha2 on June 22, 2011, 02:59:48 PM
Hello,

I think I'm a little awkward, try to install it with emulation RC5 does not work. I think I will wait to update and is compatible with SMF 2.0 gold, will be watching because I think these things are well in the user profile.
I appreciate this great mod.

thank you very much
regards
The newest version is compatible with SMF 2.0 Gold already ;)
Just make sure you uninstall it and any other mods BEFORE you upgrade, then reinstall the latest versions after.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Eclipse16V on June 26, 2011, 04:38:45 AM
Yes, works fine on my 2.0
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: ~Dragon~ on July 15, 2011, 09:59:33 PM
everything my work sites fine
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Hj Ahmad Rasyid Hj Ismail on July 16, 2011, 04:59:12 AM
Great to hear that it's working in 2.0 gold.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: sharks on July 16, 2011, 12:33:44 PM
This mod appears to have been abandoned. Too bad. I use it for years on my forum. I am wondering if i upgrade my SMF 1.1 forum to 2.0 and install this script again, will it retain the browser data from all the topics and posts from the SMF 1.1 installation?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on July 16, 2011, 01:08:12 PM
I see no reason why it shouldn't.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: PLAYBOY on July 17, 2011, 12:09:57 AM
Good job. Very nice Mod.

Questions:

1- Will it install 2.0 without a problem or emulation? <<< Update: Yes it will. Just tested.
2- How up-to-date is the browser database? <<< Update: Very up-to-date It has FF 5.0.

3- Will it be possible to add more features like Computername, useragent, system language, Screen Resolution etc.
An example of what i am talking about;
http://techpatterns.com/downloads/php_browser_detection.php
look at "Your Computer" information on the left side

Something like this feature would be very helpful to spot if one person having multiple memberships who also has a dynamic ip adress.




Update: Bug Found
no ' after $txt['permissionname_view_os_browser'] = 'Mesajlarda isletim sistemi ve tarayiciyi görüntüle; in modifications.turkish.php
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: sharks on July 17, 2011, 10:05:10 AM
Quote from: PLAYBOY on July 17, 2011, 12:09:57 AM
Will it be possible to add more features like Computername, useragent, system language, Screen Resolution etc.
An example of what i am talking about;
http://techpatterns.com/downloads/php_browser_detection.php
look at "Your Computer" information on the left side

Something like this feature would be very helpful to spot if one person having multiple memberships who also has a dynamic ip adress.

I like the idea but i definitely don't want to clutter my forum pages with excess information, especially when these info are commonly regarded as sensitive and may put the members' privacy at risk. It would be best to have any extra info as optional in the admin section, where you can have a menu to select which other features to display beneath the avatar when viewing posts.

All that said, i always encourage new and improved features but in this case, i honestly don't see the point of having extra info displayed other than the OS and browser detection. This mod is perfect as it is. Any extra info display is unnecessary. It just needs to be polished in some corners with a few bug fixes and the mod page updated to display full compatibility with SMF 2.0 final.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: PLAYBOY on July 17, 2011, 10:20:04 AM
I totally agree with you. I wouldnt want any extra or excess info on the pages. That is why i requested this to be added in somewhere in admin panel. It could be an option or it could be just a small box next to IP adresses the member have used.

I can see you forum is not under so much attack from people who has dynamic ips.
This feature would be very helpful for people like me to spot the attackers, stalkers and people with multiple memberships.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: sharks on July 19, 2011, 01:44:41 AM
Quote from: PLAYBOY on July 17, 2011, 10:20:04 AM
I can see you forum is not under so much attack from people who has dynamic ips.
This feature would be very helpful for people like me to spot the attackers, stalkers and people with multiple memberships.
In that case, it could be best implemented as "visible only to admin" (based on privileges set in the admin panel). I can see that as very useful to everyone concerned about the security of their forums. I also get spammers registering on my forum every now and then. IPs used by members in their posts are already set such that these are only visible to admins, so adding a few more features there would be a big help.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Cal O'Shaw on July 19, 2011, 01:54:16 AM
Hello,

Running it on 2.0 Gold as well.

A very useful MOD and I really appreciate all you've done with it.

If there were anything I could request, it would be that by default the permission to see it would be OFF.  My members don't like it, and a few feel a touch paranoid (what else is being tracked?).  Please do NOT get rid of the permissions settings, but if it could just be set to hide for everyone except Admin, that would make things easier for me when installing or creating groups.

Grazie mille!

Cal
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on July 28, 2011, 04:01:22 PM
Quote from: Cal O'Shaw on July 19, 2011, 01:54:16 AM
Hello,

Running it on 2.0 Gold as well.

A very useful MOD and I really appreciate all you've done with it.

If there were anything I could request, it would be that by default the permission to see it would be OFF.  My members don't like it, and a few feel a touch paranoid (what else is being tracked?).  Please do NOT get rid of the permissions settings, but if it could just be set to hide for everyone except Admin, that would make things easier for me when installing or creating groups.

Grazie mille!

Cal
Agreed. It's a nice option so I don't want to see it removed, but a shortcut button for Admins-only would be nice as well!
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Dayjo on August 22, 2011, 11:17:26 AM
Agree with the permissions options.

Also it would be nice if it registered if IE was in compatibility mode. So rather than just saying it's IE7, it should say it's IE9 in IE7 compatibility mode or something :)

Having issues installing this on 2.0 but working on manually installing it at the moment.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Shadow Queen on August 31, 2011, 03:47:37 AM
I am trying to install it on my forum.

Every test come back fine but getting a data base error

Table 'xxxxxxx_test.messages' doesn't exist
File: /home/xxxxxx/public_html/test/Packages/temp/install.php
Line: 19
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Martine M on August 31, 2011, 12:14:31 PM
I installed OS & Browser Detection 1.5 on SMF 2.0 and Argentum theme with default language English.

It installed without any problems, but I can't see in people's post any browser / OS info.

However I have httpBL installed and I checked the option to view that info in the user online today screen, witch it does.
How come I can't see it in peoples posts?

Oh and BTW, I agree with the default option of to.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on August 31, 2011, 12:33:34 PM
The mod won't show in posts until the next post is made.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Martine M on August 31, 2011, 02:11:45 PM
Yes I know that but there are already lots of posts made after I installed it
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: #Pascal on September 28, 2011, 06:49:16 AM
Patch for detecting Android and iOS

// Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

  // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on September 28, 2011, 10:52:18 AM
Like the idea but you don't explain where these edits should be.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Eclipse16V on September 28, 2011, 02:11:06 PM
Quote from: PascalCX on September 28, 2011, 06:49:16 AM
Patch for detecting Android and iOS

// Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

  // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }

Doesn´t work with Android.
Display Linux and not Android.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on September 28, 2011, 05:13:39 PM
Just a heads up, this mod works perfectly in SMF 2.0.1 still. :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on September 28, 2011, 05:26:06 PM
Quote from: Eclipse16V on September 28, 2011, 02:11:06 PM
Quote from: PascalCX on September 28, 2011, 06:49:16 AM
Patch for detecting Android and iOS

// Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

  // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }

Doesn´t work with Android.
Display Linux and not Android.

It work's for me :s

In Sources/os_browser_detection.php
Find:
    // Samsung
    if(preg_match('/samsung\-([0-9a-zA-Z\+\-\.]+){0,1}\//si', $user_agent, $tmp_array))
      {
      if(!$client_data['system'])
        {
$client_data['system'] = "Samsung" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
$client_data['system_icon'] = "mobile";
}
      else
        {
$client_data['system'] .= " / Samsung" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
}
      }


Add After:
    // Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

    // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }


Upload the icon_iphone.png + icon_android.php to Themes/default/images/os_browser_detection.

If it's okay with everyone I could upload the package.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Eclipse16V on September 29, 2011, 03:50:05 PM
Quote from: Reaper.CSF. on September 28, 2011, 05:26:06 PM
Quote from: Eclipse16V on September 28, 2011, 02:11:06 PM
Quote from: PascalCX on September 28, 2011, 06:49:16 AM
Patch for detecting Android and iOS

// Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

  // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }

Doesn´t work with Android.
Display Linux and not Android.

It work's for me :s

In Sources/os_browser_detection.php
Find:
    // Samsung
    if(preg_match('/samsung\-([0-9a-zA-Z\+\-\.]+){0,1}\//si', $user_agent, $tmp_array))
      {
      if(!$client_data['system'])
        {
$client_data['system'] = "Samsung" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
$client_data['system_icon'] = "mobile";
}
      else
        {
$client_data['system'] .= " / Samsung" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
}
      }


Add After:
    // Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

    // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }


Upload the icon_iphone.png + icon_android.php to Themes/default/images/os_browser_detection.

If it's okay with everyone I could upload the package.
Uppps sorry.
I add it on the first place in the file before // Camino.
So I edit it but with my HTC (Android / FireFox 7) it will be display Lunix / FireFox 7.
Then I use the HTC Browser and it display Android / Safari. This OK but with Firefox it is wrong.

Sorry for the bad english.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on September 29, 2011, 04:20:35 PM
I will install firefox from android market and I will experiment.

I will post my findings ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: #Pascal on September 30, 2011, 03:09:22 AM
2 Eclipse16V

Please post "User agent" from Android / FireFox 7
I'll see what can I do

You cat learn you "User Agent data" at this page for example
http://whatsmyuseragent.com/
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on September 30, 2011, 08:32:07 AM
included android and ios to source
pack on attach
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Eclipse16V on September 30, 2011, 12:01:58 PM
@ PascalCX

Mozilla/5.0 (Android; Linux armv7l; rv:7.0) Gecko/20110922 Firefox/7.0 Fennec/7.0
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on September 30, 2011, 08:09:43 PM
@ Eclipse16V

I can see the problem, I tested using default browser in my android and os detector picks up Android.
Soon as I use Firefox it picks it up as Linux. Odd.

@ cieplutki
That's great ;) but I have already made a package :P
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: #Pascal on October 01, 2011, 12:29:10 PM
firefox doesn't announce android version in user agent, so that it doesn't match the regex in the code.
I can fix firefox detection, wait for a while
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: #Pascal on October 01, 2011, 01:08:34 PM
Android detection(fixed)


// Android
    if(preg_match('/android/si', $user_agent))
    {
    $client_data['system'] = "Android";
    $client_data['system_icon'] = "android";
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      }
    }

Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on October 01, 2011, 02:19:48 PM
Thanks PascalCX ;)

Attached is the package with all the changes.
I have taken the liberty edit the readme file to include the new changes ;D
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Eclipse16V on October 02, 2011, 05:48:09 AM
Thanks PascalCX

It works now fine.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: ddabcd277 on October 02, 2011, 02:31:25 PM
So far so good.  Why don't you name it version 1.6?  :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on October 02, 2011, 02:47:16 PM
I agree. That'd be awesome to have a new version including these additional browsers/OS'es :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on October 02, 2011, 08:46:33 PM
Okay that's easy ;)

package attached :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on October 05, 2011, 02:35:25 PM
Hi, Reaper.CSF.
I found several errors in languages.xml , e.g.
- line 38    <file name="$languagedir/Modifications.finnish.php.php" error="skip">
- line 122  <file name="$languagedir/Modifications.serbian.php" error="skip">
- line 137  <file name="$languagedir/Modifications.serbian-utf8.php" error="skip">
- line 152  <file name="$languagedir/Modifications.serbian-utf8-lat.php" error="skip">
Also added serbian_cyrillic and croatian translation, both iso/utf8

Here is modified languages.xml and readme.txt
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on October 06, 2011, 04:40:41 PM
Quote from: Branko. on October 05, 2011, 02:35:25 PM
Hi, Reaper.CSF.
I found several errors in languages.xml , e.g.
- line 38    <file name="$languagedir/Modifications.finnish.php.php" error="skip">
- line 122  <file name="$languagedir/Modifications.serbian.php" error="skip">
- line 137  <file name="$languagedir/Modifications.serbian-utf8.php" error="skip">
- line 152  <file name="$languagedir/Modifications.serbian-utf8-lat.php" error="skip">
Also added serbian_cyrillic and croatian translation, both iso/utf8

Here is modified languages.xml and readme.txt

Thanks m8 ;)

Package Attached

Perhaps i should take over this mod, if the mod owner is no longer around ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on October 06, 2011, 05:33:32 PM
I think you're right ...I tried to find him, but it is not on his forum.I think that he abandoned all.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on October 07, 2011, 03:03:06 AM
Thx installed Version 1.6,
We are using Modification tapatalk on our Forum, still waiting for test results if OS & Browsers detection works when users are using tapatalk i.c.w the Galaxy S GT-I9000 (Running android 2.1)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: #Pascal on October 07, 2011, 03:06:08 AM
French
I suppose that tapatalk doesn't compatable with this mod
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on October 07, 2011, 04:01:21 AM
Oke thanks Pascal ....I suppose it might be better to submit questions about compatibility to community/forum tapatalk  ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on October 09, 2011, 10:39:13 AM
Quote from: Branko. on October 06, 2011, 05:33:32 PM
I think you're right ...I tried to find him, but it is not on his forum.I think that he abandoned all.

He is still registered in these forums X3mE (http://www.simplemachines.org/community/index.php?action=profile;u=154415)

Date last seen in this topic = 13th May 2009 :o
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on October 09, 2011, 11:08:47 AM
Yes, I know..and last login  20-09-2010 .I think it's gone forever  :-\
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on October 10, 2011, 04:15:01 AM
Still looking to get system_icon LinuxMint in Mod OS & Browser.
edit this line   elseif(preg_match('/linuxmint/si', $user_agent))
        {
        $client_data['system'] .= " (Linuxmint)";
        $client_data['system_icon'] = "linuxmint"

in os_browser_detection.php,but unfortunately the system icon didn´t change
Info My User Agent.
Your User Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

Also looking for the same issue when using Bodhi Linux (Waiting for User Agent info by one of the Bodhi Linux users)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on October 10, 2011, 05:11:59 AM
Quote from: French on October 10, 2011, 04:15:01 AM
Still looking to get system_icon LinuxMint in Mod OS & Browser.
edit this line   elseif(preg_match('/linuxmint/si', $user_agent))
        {
        $client_data['system'] .= " (Linuxmint)";
        $client_data['system_icon'] = "linuxmint"

in os_browser_detection.php,but unfortunately the system icon didn´t change
Info My User Agent.
Your User Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

Also looking for the same issue when using Bodhi Linux (Waiting for User Agent info by one of the Bodhi Linux users)


I'm sure I got this right
      elseif(preg_match('/mint/si', $user_agent))
        {
      $client_data['system'] = " (Linux Mint)";
      $client_data['system_icon'] = "mint";
        }


Attached is the icon that goes in /Themes/default/images/os_browser_detection/
Also attached is the full package that includes the changes.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on October 10, 2011, 05:50:42 AM
Quote from: Reaper.CSF.Attached is the icon that goes in /Themes/default/images/os_browser_detection/
Also attached is the full package that includes the changes.
Great thanks for your time.
Check everything twice icon Mint is in default/images/os_browser_detection,full package includes the changes installed after uninstalled the last one.
Still no Mint icon
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on October 10, 2011, 06:31:25 AM
Yes found it
    }
      elseif(preg_match('/linux/si', $user_agent))
        {
      $client_data['system'] .= " (Linux mint)";
      $client_data['system_icon'] = "mint";

instead of
    }
      elseif(preg_match('/mint/si', $user_agent))
        {
      $client_data['system'] .= " (Linux mint)";
      $client_data['system_icon'] = "mint";
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Doburpally on October 10, 2011, 07:45:56 AM
Quote from: French on October 10, 2011, 06:31:25 AM
Yes found it
    }
      elseif(preg_match('/linux/si', $user_agent))
        {
      $client_data['system'] .= " (Linux mint)";
      $client_data['system_icon'] = "mint";

instead of
    }
      elseif(preg_match('/mint/si', $user_agent))
        {
      $client_data['system'] .= " (Linux mint)";
      $client_data['system_icon'] = "mint";


Thanks m8 ;)

The new package is attached ;)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on October 18, 2011, 05:55:46 AM
hi all my forum cant see a symbian os [Nokia C5 03] Symbian60v5
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on January 09, 2012, 07:36:30 PM
SMF 2.0 Gold, 2.0.1, and 2.0.2 are all good to go!
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on January 10, 2012, 09:33:43 AM
Quote from: cieplutki on October 18, 2011, 05:55:46 AM
hi all my forum cant see a symbian os [Nokia C5 03] Symbian60v5
What does it report? SMF version? Does it detect all other systems? If not, what other systems does it fail to report?

We need more information :(

@SugarD-x: Great to know :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Vlada87 on February 02, 2012, 07:52:22 PM
Can someone made Blackbeery and Tapatalk (BB, iOS, andorid) detection!?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on February 02, 2012, 07:53:54 PM
Tapatalk isn't a browser.

Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on February 02, 2012, 07:55:14 PM
Quote from: Old Fossil on February 02, 2012, 07:53:54 PM
Tapatalk isn't a browser.
I think they are still requesting it since it's an app specifically made for browsing forums, just as if a user were using a web browser to do the same thing.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on February 02, 2012, 07:56:59 PM
Then I'd advise looking at the tapatalk support thread or www.tapatalk.com
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Vlada87 on February 05, 2012, 06:34:02 AM
One more thing...

People on my board saying that detection for OS is wrong:

When using debian it show like Mint
When using ubuntu it show like Mint
When using Slackware it show like Mint

Can someone fix this!?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on February 05, 2012, 09:13:40 AM
Quote from: Vlada87 on February 05, 2012, 06:34:02 AM
One more thing...

People on my board saying that detection for OS is wrong:

When using debian it show like Mint
When using ubuntu it show like Mint
When using Slackware it show like Mint

Can someone fix this!?
Ubuntu should show up like Ubuntu.

Are you sure that your installations are up-to-date?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on February 05, 2012, 11:32:54 AM
Ubuntu shows up for me as Linux.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on February 05, 2012, 01:16:35 PM
Quote from: Old Fossil on February 05, 2012, 11:32:54 AM
Ubuntu shows up for me as Linux.
Oh heh my bad ;D
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Vlada87 on February 06, 2012, 06:33:52 PM
Quote from: Yoshi2889 on February 05, 2012, 09:13:40 AM
Quote from: Vlada87 on February 05, 2012, 06:34:02 AM
One more thing...

People on my board saying that detection for OS is wrong:

When using debian it show like Mint
When using ubuntu it show like Mint
When using Slackware it show like Mint

Can someone fix this!?
Ubuntu should show up like Ubuntu.

Are you sure that your installations are up-to-date?

What version you suggest that work well!?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lucifur on February 10, 2012, 06:58:32 AM
/*  Modification.thai-utf8.php   */


<?php

$txt['OS_Browser_Compatible'] = 'ตระกูล: ';
$txt['OS_Browser_OS'] = 'ระบบปฏิบัติการ:';
$txt['OS_Browser_Unknown'] = 'ไม่ทราบ';
$txt['OS_Browser_Browser'] = 'บราวเซอร์:';
$txt['permissiongroup_simple_view_os_browser'] = 'สามารถดู  ระบบปฏิบัติการ & บราวเซอร์ ในกระทู้ได้';
$txt['permissionname_view_os_browser'] = 'สามารถดู  ระบบปฏิบัติการ & บราวเซอร์ ในกระทู้ได้';
$txt['permissionhelp_view_os_browser'] = 'หากเปิดใช้ สมาชิกจะเห็นการตรวจสอบบราวเซอร์และระบบปฏิบัติการ สำหรับแต่ละกระทู้หากมีการตรวจพบ';

?>
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Vlada87 on February 20, 2012, 07:14:45 PM
Nobody fix this plugin!?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Zuća on April 11, 2012, 11:01:57 AM
I use ubuntu and it says that I use linux mint  ...bug O.o ?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on April 11, 2012, 11:37:26 AM
Linux Mint == Ubuntu.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Zuća on April 11, 2012, 12:10:38 PM
no, this is not the same
mint and ubuntu is quite different.....should be separated
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on April 11, 2012, 03:13:07 PM
Linux Mint is based on Ubuntu and uses almost the same kernel modules, so really, that's why it identifies Ubuntu as Mint. Should be the other way around though, I guess.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: MrPrise on July 22, 2012, 04:46:02 AM
I have upgraded this mod to work with SMF 2.0.2
Anyone is interested testing it?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Eclipse16V on July 24, 2012, 07:36:32 AM
Works fine with 2.0.2
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: MrPrise on July 25, 2012, 03:20:41 AM
I meant the one which does not.  OS_Browser_Detection_v1.4_SMF_2.x_ARS.zip
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: mrfaraday on August 09, 2012, 12:31:39 AM
Quote from: MrPrise on July 22, 2012, 04:46:02 AM
I have upgraded this mod to work with SMF 2.0.2
Anyone is interested testing it?

please i need it ......
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: MrPrise on August 09, 2012, 08:44:35 AM
Here it is.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on October 26, 2012, 01:02:06 PM
Windows 8 out and my suggestion
on os_browser_detection.php find
      if($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  

replace
      if($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8/Server 2012";
        $client_data['system_icon'] = "Win8";
        }  
      elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Hj Ahmad Rasyid Hj Ismail on October 26, 2012, 08:50:54 PM
Nice one cieplutki. Thanks for the update.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on October 31, 2012, 04:57:16 PM
Quote from: cieplutki on October 26, 2012, 01:02:06 PM
Windows 8 out and my suggestion
on os_browser_detection.php find
      if($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  

replace
      if($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8/Server 2012";
        $client_data['system_icon'] = "Win8";
        }  
      elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  


the correct is :
replace
      if($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8/Server 2012";
        $client_data['system_icon'] = "win8";
        }  
      elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  


because the $client_data['system_icon'] = "win8"; is with small w not capital
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on October 31, 2012, 05:30:50 PM
 :D its perfect  8)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on December 17, 2012, 01:33:19 PM
Anyone know if this mod is compatible with SMF 2.0.3? I'm assuming so, but I haven't tested it yet.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Hj Ahmad Rasyid Hj Ismail on January 17, 2013, 04:06:22 AM
Check from this post onwards for the latest modifications: http://www.simplemachines.org/community/index.php?topic=278770.msg3387285#msg3387285
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on January 17, 2013, 03:23:02 PM
Forgot to mention, I got sick of waiting for someone to confirm on the compatibility, so I just said screw it and tested it. It's working beautifully in SMF 2.0.3 still. I also added Cieplutki's mod, and it too is working beautifully. Thanks so much guys!

Can't wait to see an official update to this thing, though! :D
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: EliasAlucard on March 12, 2013, 07:06:54 AM
Hello, I'm the developer of UADisplay:

vbulletin.org/forum/showthread.php?t=295667

UADisplay is based on OS/Browser Display in Postbits, by nhawk:

vbulletin.org/forum/showthread.php?t=280899

Which in turn, was based on OS & Browser Detection by X3mE. Problem here is with X3mE's plugin, is that it is not released under the GNU GPL v3, as it's supposed to be, because it is based on Marcin Krol's GPLed software:

id.furud.net/

In the os_browser_detection.php, it says "License: free for non-commercial use", whereas in Marcin Krol's original software, it very specifically said the software was released under the GNU GPL v3:

// Web Browser Identifier v0.9
// Written by Marcin Krol <[email protected]>
// License: GPL

X3mE's plugin:

// Web Browser Identifier v0.9
// Written by Marcin Krol <[email protected]>
// License: free for non-commercial use
//
// URL: id.furud.net/
// Modified by X3mE

^^ This must be rectified. Is there any possible way for the SMF community to fix this? That way, future developers can avoid the issues me and nhawk had over the license (which have now been solved between me and him).

Edit:

I couldn't post links, so I had to remove the http stuff.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: PixelPusher on March 13, 2013, 08:42:21 PM
When trying to install this in SMF 2.0.4, I am getting a test failure at step 6, modifying ./Sources/Display.php.

It is looking for a line that says "k.message AS is_repped", but it is not found.

Any ideas?

-Thom
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on March 14, 2013, 05:16:55 AM
Quote from: PixelPusher on March 13, 2013, 08:42:21 PM
When trying to install this in SMF 2.0.4, I am getting a test failure at step 6, modifying ./Sources/Display.php.

It is looking for a line that says "k.message AS is_repped", but it is not found.

Any ideas?

-Thom
I've never seen anything like that before, but as before with the other topic, this mod is completely compatible, so you have a conflicting mod or corrupt file issue. :(
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: PixelPusher on March 14, 2013, 08:06:54 PM
Do you know what line number that change is targeting? I could look for it that way, but I searched Display.php for k.message and did not find it anywhere.

-Thom
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on March 14, 2013, 10:17:09 PM
Quote from: PixelPusher on March 14, 2013, 08:06:54 PM
Do you know what line number that change is targeting? I could look for it that way, but I searched Display.php for k.message and did not find it anywhere.

-Thom
I actually have no clue, in all honesty. I'm sorry man.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on March 14, 2013, 11:28:38 PM
k.message isn't a standard thing in SMF anywhere as far as I remember.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lukaszuk1995 on August 31, 2013, 04:13:01 AM
My update for Windows 8.1 & Windows 8 :
Find:
      if($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  

Replace with:
{if($tmp_array[1] == "6.3")
        {
        $client_data['system'] = "Windows 8.1";
        $client_data['system_icon'] = "win81";
        }
      elseif($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8";
        $client_data['system_icon'] = "win8";
        }  
        elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7";
        $client_data['system_icon'] = "win7";
        }
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on September 01, 2013, 07:27:30 AM
Thanks man
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on December 02, 2013, 11:54:27 PM
Seems to be a new issue.  Since the release of IE 11, OSBD 1.5 is showing IE 11 as "Mozilla compatible".  Is there any way to fix that?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on December 03, 2013, 12:02:35 AM
The mod hasn't been updated in 3 years, I doubt they will update it now.

The reason for this is because Microsoft, for the first time ever, decided it would be great to remove 'MSIE' from the browser identification.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on December 07, 2013, 03:07:15 AM
Hi how to added windows phone ?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on December 08, 2013, 06:02:46 AM
Added before:
    // Catchall for all other windozez

// Windows Mobile
    if(preg_match('/windows phone ([0-9\.]+).*/si', $user_agent, $tmp_array) || preg_match('/phone([0-9\.]+).*/si', $user_agent, $tmp_array) && !$client_data['system'])
      {
      $client_data['system'] = "Windows Phone";
      $client_data['system_icon'] = "win_phone";
      }


and it looks like in the attach
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on December 08, 2013, 10:44:47 PM
So is there any way to detect IE 11?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on December 15, 2013, 02:49:10 PM
Quote
So is there any way to detect IE 11?

also want to know
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on December 29, 2013, 04:15:29 PM
anyone who knows how to display IE11
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on December 31, 2013, 09:44:58 PM
We really need to start compiling all of these updates into one post and update the mod. :P
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on December 31, 2013, 09:46:57 PM
The mod hasn't been updated in over 3 years, the author's site is no more, and if you did update it we'd have to remove it for being updated without appropriate permissions as far as I can see :(

Needs someone to take it by the horns and write a fresh one.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on December 31, 2013, 09:49:19 PM
The author's last online date:
"Last Active: November 17, 2013, 04:40:40 PM"

Seems we are just being ignored. :(
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 01, 2014, 05:40:42 AM
hello,

who can test the BlackBerry OS

find:
// SonyEricsson & Ericsson
add before:
//Blackberry
if(preg_match('/blackberry/si', $user_agent))
      {
      $client_data['system'] = "BlackBerry OS";
      $client_data['system_icon'] = "blackberry";
      if(preg_match('/blackberry ([0-9.]+).*/si', $user_agent, $tmp_array))
        {
        $client_data['system'] = "BlackBerry OS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
        }


currently no icon.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on January 01, 2014, 06:12:02 AM
I tried my best to compile the new detections, (no code changes/translations), that were made since the final release stated by this topic's title. The icons included are attached to this post, directly from the quoted locations. Both versions of the Microsoft Windows 8 icons are included too. Enjoy:

Quote from: #Pascal on September 28, 2011, 06:49:16 AM
Patch for detecting Android and iOS

// Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

  // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }


Quote from: Grimm.CSF. on September 28, 2011, 05:26:06 PM
Quote from: Eclipse16V on September 28, 2011, 02:11:06 PM
Quote from: PascalCX on September 28, 2011, 06:49:16 AM
Patch for detecting Android and iOS

// Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

  // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }

Doesn´t work with Android.
Display Linux and not Android.

It work's for me :s

In Sources/os_browser_detection.php
Find:
    // Samsung
    if(preg_match('/samsung\-([0-9a-zA-Z\+\-\.]+){0,1}\//si', $user_agent, $tmp_array))
      {
      if(!$client_data['system'])
        {
$client_data['system'] = "Samsung" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
$client_data['system_icon'] = "mobile";
}
      else
        {
$client_data['system'] .= " / Samsung" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
}
      }


Add After:
    // Android
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "android";
      }

    // iOS
     if((preg_match('/iphone|ipad/si', $user_agent)) && (preg_match('/OS ([0-9_]+).*/si', $user_agent, $tmp_array)))
      {
      $tmp_array = str_replace("_", ".", $tmp_array);
      $client_data['system'] = "iOS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['system_icon'] = "iphone";
      }


Upload the icon_iphone.png + icon_android.php to Themes/default/images/os_browser_detection.

If it's okay with everyone I could upload the package.

Quote from: #Pascal on October 01, 2011, 01:08:34 PM
Android detection(fixed)


// Android
    if(preg_match('/android/si', $user_agent))
    {
    $client_data['system'] = "Android";
    $client_data['system_icon'] = "android";
    if(preg_match('/android ([0-9.]+).*/si', $user_agent, $tmp_array))
      {
      $client_data['system'] = "Android" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      }
    }


Quote from: Grimm.CSF. on October 10, 2011, 05:11:59 AM
Quote from: French on October 10, 2011, 04:15:01 AM
Still looking to get system_icon LinuxMint in Mod OS & Browser.
edit this line   elseif(preg_match('/linuxmint/si', $user_agent))
        {
        $client_data['system'] .= " (Linuxmint)";
        $client_data['system_icon'] = "linuxmint"

in os_browser_detection.php,but unfortunately the system icon didn´t change
Info My User Agent.
Your User Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

Also looking for the same issue when using Bodhi Linux (Waiting for User Agent info by one of the Bodhi Linux users)


I'm sure I got this right
      elseif(preg_match('/mint/si', $user_agent))
        {
      $client_data['system'] = " (Linux Mint)";
      $client_data['system_icon'] = "mint";
        }


Attached is the icon that goes in /Themes/default/images/os_browser_detection/
Also attached is the full package that includes the changes.

Quote from: villasg on October 31, 2012, 04:57:16 PM
Quote from: cieplutki on October 26, 2012, 01:02:06 PM
Windows 8 out and my suggestion
on os_browser_detection.php find
      if($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  

replace
      if($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8/Server 2012";
        $client_data['system_icon'] = "Win8";
        }  
      elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  


the correct is :
replace
      if($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8/Server 2012";
        $client_data['system_icon'] = "win8";
        }  
      elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  


because the $client_data['system_icon'] = "win8"; is with small w not capital

Quote from: lukaszuk1995 on August 31, 2013, 04:13:01 AM
My update for Windows 8.1 & Windows 8 :
Find:
      if($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7/Server 2008 R2";
        $client_data['system_icon'] = "vista";
        }  

Replace with:
{if($tmp_array[1] == "6.3")
        {
        $client_data['system'] = "Windows 8.1";
        $client_data['system_icon'] = "win81";
        }
      elseif($tmp_array[1] == "6.2")
        {
        $client_data['system'] = "Windows 8";
        $client_data['system_icon'] = "win8";
        }  
        elseif($tmp_array[1] == "6.1")
        {
        $client_data['system'] = "Windows 7";
        $client_data['system_icon'] = "win7";
        }


Quote from: cieplutki on December 08, 2013, 06:02:46 AM
Added before:
    // Catchall for all other windozez

// Windows Mobile
    if(preg_match('/windows phone ([0-9\.]+).*/si', $user_agent, $tmp_array) || preg_match('/phone([0-9\.]+).*/si', $user_agent, $tmp_array) && !$client_data['system'])
      {
      $client_data['system'] = "Windows Phone";
      $client_data['system_icon'] = "win_phone";
      }


and it looks like in the attach

Quote from: cieplutki on January 01, 2014, 05:40:42 AM
hello,

who can test the BlackBerry OS

find:
// SonyEricsson & Ericsson
add before:
//Blackberry
if(preg_match('/blackberry/si', $user_agent))
      {
      $client_data['system'] = "BlackBerry OS";
      $client_data['system_icon'] = "blackberry";
      if(preg_match('/blackberry ([0-9.]+).*/si', $user_agent, $tmp_array))
        {
        $client_data['system'] = "BlackBerry OS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
        }


currently no icon.

Quote from: cieplutki on January 01, 2014, 06:59:49 AM
blackberry icon on attach
and who check Linux Mint
find:
elseif(preg_match('/mdk/si', $user_agent))
        {
        $client_data['system'] .= " (Mandrake)";
        $client_data['system_icon'] = "mandriva";
        }

add before:
elseif(preg_match('/mint/si', $user_agent))
        {
$client_data['system'] = " (Linux Mint)";
$client_data['system_icon'] = "mint";
        }


I will be grateful for checking if it works  8)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 01, 2014, 06:59:49 AM
blackberry icon on attach
and who check Linux Mint
find:
elseif(preg_match('/mdk/si', $user_agent))
        {
        $client_data['system'] .= " (Mandrake)";
        $client_data['system_icon'] = "mandriva";
        }

add before:
elseif(preg_match('/mint/si', $user_agent))
        {
$client_data['system'] = " (Linux Mint)";
$client_data['system_icon'] = "mint";
        }


I will be grateful for checking if it works  8)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on January 01, 2014, 07:27:28 AM
Quote from: cieplutki on January 01, 2014, 06:59:49 AM
blackberry icon on attach
and who check Linux Mint
find:
elseif(preg_match('/mdk/si', $user_agent))
        {
        $client_data['system'] .= " (Mandrake)";
        $client_data['system_icon'] = "mandriva";
        }

add before:
elseif(preg_match('/mint/si', $user_agent))
        {
$client_data['system'] = " (Linux Mint)";
$client_data['system_icon'] = "mint";
        }


I will be grateful for checking if it works  8)
Added to my massive post for future referencing. :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 01, 2014, 03:19:23 PM
So no IE 11 detection method yet?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on January 01, 2014, 08:16:45 PM
Quote from: Sandmansa on January 01, 2014, 03:19:23 PM
So no IE 11 detection method yet?
Sadly no one has made it yet.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lukaszuk1995 on January 04, 2014, 03:29:13 AM
Quote from: cieplutki on January 01, 2014, 05:40:42 AM
hello,

who can test the BlackBerry OS

find:
// SonyEricsson & Ericsson
add before:
//Blackberry
if(preg_match('/blackberry/si', $user_agent))
      {
      $client_data['system'] = "BlackBerry OS";
      $client_data['system_icon'] = "blackberry";
      if(preg_match('/blackberry ([0-9.]+).*/si', $user_agent, $tmp_array))
        {
        $client_data['system'] = "BlackBerry OS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
        }


currently no icon.
It doesn't work for me, I have syntax error, also Windows Phone useragent detect only WP 8.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 04, 2014, 04:26:29 AM
Hi,

try my os_broweser file on attach
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lukaszuk1995 on January 04, 2014, 05:03:22 AM
Thanks for this, it works for me :P
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 04, 2014, 08:12:44 AM
seriously BlackBerry OS and Win Phone ...
who confirms linux mint  ???
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on January 04, 2014, 08:49:33 AM
Quote from: cieplutkiwho confirms linux mint  ???

Code (adding this) Select
 
      elseif(preg_match('/linux/si', $user_agent))
        {
      $client_data['system'] = " (Linux Mint)";
      $client_data['system_icon'] = "mint";
        }

Code (instead of) Select
elseif(preg_match('/mint/si', $user_agent))
        {
$client_data['system'] = " (Linux Mint)";
$client_data['system_icon'] = "mint";
        }



When i analysis on client SW type (browser, webcrawler, anonymizer etc.), and which OS is used (using User agent info)

We get this information

That's because Linux Mint is based on Ubuntu,That,s why I did it this way to get the Linux Mint ico.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 04, 2014, 10:11:57 AM
Hi,

on my os_browser_detection.php no code you write

    // Linux
    if(preg_match('/linux/si', $user_agent) && !$client_data['system'])
      {
      $client_data['system'] = "Linux";
      $client_data['system_icon'] = "linux";
      if(preg_match('/mdv/si', $user_agent) || preg_match('/mandriva/si', $user_agent))
        {
        $client_data['system'] .= " (Mandriva";
        $client_data['system_icon'] = "mandriva";
        // Try to detect version
        if(preg_match('/mdv([0-9.]*)/si', $user_agent, $tmp_array))
          {
          $client_data['system'] .= ($tmp_array[1] ? " ".$tmp_array[1].")" : ")");
          }
        else
  {
          $client_data['system'] .= ")";
  }
        }
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lukaszuk1995 on January 05, 2014, 07:18:02 AM
This is a line which the useragent which uses IE 11.
    // Catchall for other Mozilla compatible browsers
    if(preg_match('/mozilla/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Mozilla " . $txt['OS_Browser_Compatible'];
      $client_data['browser_icon'] = 'mozilla';
      }
     

This is IE 11 useragent :
Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; Touch; rv:11.0) like Gecko
How to modify it to Internet Explorer 11 ?
It must be something like this :if(preg_match('/mozilla.*rv:[11.0\.]+.*gecko\/[0-9]+.* Trident/7.0\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) && !$client_data['browser'])
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 05, 2014, 09:18:22 PM
That detection method doesn't work.  Good try though lukaszuk.  You gave me an idea though and it does seem to work for me.

What I did is changed this:

    // Catchall for other Mozilla compatible browsers
    if(preg_match('/mozilla/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Mozilla " . $txt['OS_Browser_Compatible'];
      $client_data['browser_icon'] = 'mozilla';
      }
     


To this:

    // Catchall for other Mozilla compatible browsers
    if(preg_match('/mozilla/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "MS Internet Explorer 11 " . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }



It's just a temporary work around until someone comes up with something better.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on January 05, 2014, 09:19:25 PM
Considering that every single browser out there - even most of the spam bots - states itself as Mozilla compatible (and thus begins with 'Mozilla'), that's really not going to work that well.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 05, 2014, 09:24:33 PM
I am aware of that Arantor.  Is there anything you can do to help find a workable detection method?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on January 05, 2014, 09:34:10 PM
The entire mod needs a rewrite, and I don't really have the time to do that right now.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 05, 2014, 10:01:16 PM
Please don't take what I am about to say as insulting or anything like that, because it is not intended to be.

I understand that your time is very limited.  That goes without saying.  And a lot of mods around here could use some attention from one degree or another, not just this one.  So we (the community) are trying to work with what is still available to us.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on January 05, 2014, 10:23:29 PM
Right, which is why I added what I did have to hand that was useful: detecting MSIE 11 based on 'Mozilla' in the user agent is terrible. At least test for Trident in the user agent instead... every version of MSIE, even the ones that clearly mark themselves as MSIE should be indicating themselves with the word Trident (which is the internal HTML renderer, in the same way Chrome uses Webkit and later, Blink)

Though a mod that works by inefficient regexes needs more than patchwork... it really does need rewriting from scratch. Maybe one day I'll find the time... :/
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 05, 2014, 10:41:34 PM
Thanks for the tip Arantor.  That actually works.


    // MSIE 11
    if(preg_match('/Trident\/7.0/', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "MS Internet Explorer 11.0" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }



Funny though, /Trident/7.0 didn't work.  ???
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on January 05, 2014, 10:45:50 PM
In regex, the first character is a container, you use that to mark out the entire string. Since you're using / for all the container characters, you have to escape it inside the string, e.g. /Trident\/7.0/ (since the si part is outside the regex and tells PHP how to treat the rest of the regex, in this case, i means case insensitive and the s means to treat . a slightly different way to normal... but . has a ton of special meaning of its own anyway so you should generally escape that too)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 05, 2014, 10:56:32 PM
Thanks again for your help.  That worked out great.  I updated my last post.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 06, 2014, 04:03:10 AM
Quote from: Sandmansa on January 05, 2014, 10:41:34 PM
Thanks for the tip Arantor.  That actually works.


    // MSIE 11
    if(preg_match('/Trident\/7.0/', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "MS Internet Explorer 11 " . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }



Funny though, /Trident/7.0 didn't work.  ???

It's works Thanks,

We have a similar problem with the new version of the opera who fix that  ???
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: French on January 06, 2014, 11:58:31 AM
Quote from: cieplutkion my os_browser_detection.php no code you write
It's my own editing  ;).......Modification have never been upgrade or rewritten
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 06, 2014, 12:55:16 PM
Ok,
collected all updates  ;D
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on January 06, 2014, 12:59:01 PM
I'm sorry, I had to remove your attachment. We cannot allow you to re-package modified mods unless the author explicitly allows it. Documenting changes is fine but creating a composite work is not legal.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 06, 2014, 02:29:52 PM
Ok,
I understand  :-[
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lukaszuk1995 on January 07, 2014, 02:26:33 AM
It works for me, thanks. I have error:
Fatal error: Call to undefined function sys_template() in /usr/home/pcvortal/domains/betaportal.ct8.pl/public_html/Sources/Load.php(2170) : eval()'d code on line 306
Can anyone help me ?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on January 07, 2014, 05:00:58 AM
Quote from: Arantor Beeblebrox the First on January 06, 2014, 12:59:01 PM
I'm sorry, I had to remove your attachment. We cannot allow you to re-package modified mods unless the author explicitly allows it. Documenting changes is fine but creating a composite work is not legal.

Actualy the problem with the copyright has been solved a long time ago. I have approval for any modifications made by Miloš Ranđelović aka X3mE (http://www.simplemachines.org/community/index.php?action=profile;u=154415). All necessary data are stored in my personal email archive. If you have enough free time to continue working on this modification, then everything is fine.  :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on January 07, 2014, 08:27:21 AM
Where has that been stated?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 07, 2014, 10:34:32 PM
Yeah.  I would like to know that too.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 12, 2014, 01:28:22 AM
Made a small adjustment to the IE 11 detection.  My initial code was generating offset 1 error in the logs.  Here is the fix.


    // MSIE 11
    if(preg_match('/Trident\/7.0/', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "MS Internet Explorer 11.0";
      $client_data['browser_icon'] = 'msie';
      }

Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on January 12, 2014, 08:08:21 AM
Quote from: Sir Cumber-Patcher on January 07, 2014, 08:27:21 AM
Where has that been stated?

Quote from: Sandmansa on January 07, 2014, 10:34:32 PM
Yeah.  I would like to know that too.
Solved.  :)
Latest Updates (http://custom.simplemachines.org/mods/index.php?action=search;type=0-;sort=modified;desc) look for OS & Browser Detection (http://custom.simplemachines.org/mods/index.php?mod=1515)

@cieplutki, now you can add your changes
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 12, 2014, 08:36:44 AM
Ok

Quote* version 1.7 (12. 01. 2013.)
- Windows 8 support included (thanks to lukaszuk1995)
- Windows Phone support included
- Blackberry support included
- Linux Mint support included (thanks to Freñçh)
- Internet Explorer 11 support included (thanks to Sandmansa)

need help with the new version of Opera 18
QuoteMozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36 OPR/18.0.1284.68 (Edition Campaign 21)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on January 12, 2014, 07:25:31 PM
cieplutki.  Quick question.  Your changelog suggests version 1.7 but your attachment says v1.6.  Is that a typo?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: TheListener on January 12, 2014, 07:35:54 PM
@Branko I tried to pm ya bud. RE: your signature.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: SD-X on January 13, 2014, 01:55:55 AM
Quote from: cieplutki on January 12, 2014, 08:36:44 AM
Ok

Quote* version 1.7 (12. 01. 2013.)
- Windows 8 support included (thanks to lukaszuk1995)
- Windows Phone support included
- Blackberry support included
- Linux Mint support included (thanks to Freñçh)
- Internet Explorer 11 support included (thanks to Sandmansa)

need help with the new version of Opera 18
QuoteMozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36 OPR/18.0.1284.68 (Edition Campaign 21)
It looks like you're missing a couple detections:
http://www.simplemachines.org/community/index.php?topic=278770.msg3652278#msg3652278
:D
(Windows 8.1 is also on that list!)

Overall, nice work! Can't wait to update! :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on January 13, 2014, 12:46:04 PM
Hi,

Windows 8.1  is on pack, 1.7 is only info, source was update.

best
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Hj Ahmad Rasyid Hj Ismail on February 04, 2014, 07:54:38 AM
Quote from: Branko. on January 12, 2014, 08:08:21 AM
Quote from: Sir Cumber-Patcher on January 07, 2014, 08:27:21 AM
Where has that been stated?

Quote from: Sandmansa on January 07, 2014, 10:34:32 PM
Yeah.  I would like to know that too.
Solved.  :)
Latest Updates (http://custom.simplemachines.org/mods/index.php?action=search;type=0-;sort=modified;desc) look for OS & Browser Detection (http://custom.simplemachines.org/mods/index.php?mod=1515)

@cieplutki, now you can add your changes
+1
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on April 28, 2014, 07:16:52 AM
How to added new opera like 20

Quote// Opera
    if((preg_match('/mozilla.*opera ([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) || preg_match('/^opera\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array)) && !$client_data['browser'])
      {
      $client_data['browser'] = "Opera" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'opera';
      if(preg_match('/opera mini/si', $user_agent))
        {
        preg_match('/opera mini\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array);
        $client_data['browser'] .= " (Opera Mini" . ($tmp_array[1] ? " ".$tmp_array[1] : "") . ")";
        }
      if(preg_match('/Version\/([0-9]+\.[0-9]+)/', $user_agent, $tmp_array))
        {
        $client_data['browser'] = "Opera " . $tmp_array[1];
        }
    }

this code show like google chrome but not opera

QuoteMozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.154 Safari/537.36 OPR/20.0.1387.91
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on June 03, 2014, 08:32:45 AM
Ok,
did not give me peace ... how to add opera 20.*

find:
// Opera
    if((preg_match('/mozilla.*opera ([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) || preg_match('/^opera\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array)) && !$client_data['browser'])
      {
      $client_data['browser'] = "Opera" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'opera';
      if(preg_match('/opera mini/si', $user_agent))
        {
        preg_match('/opera mini\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array);
        $client_data['browser'] .= " (Opera Mini" . ($tmp_array[1] ? " ".$tmp_array[1] : "") . ")";
        }
      if(preg_match('/Version\/([0-9]+\.[0-9]+)/', $user_agent, $tmp_array))
        {
        $client_data['browser'] = "Opera " . $tmp_array[1];
        }
    }


add before
    // OPERA 20
    if(preg_match('/OPR\/([0-9a-z\+\-\.]+).*/', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Opera" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'opera';
      if(preg_match('/Version\/([0-9]+\.[0-9]+)/', $user_agent, $tmp_array))
        {
        $client_data['browser'] = "Opera " . $tmp_array[1];
        }
    }


Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on June 03, 2014, 11:02:24 AM
Update ubuntu version:

        // Try to detect version
        if(preg_match('/utopic/si', $user_agent))
          {
          $client_data['system'] .= " 14.10 Utopic Unicorn)";
          }
        elseif(preg_match('/trusty/si', $user_agent))
          {
          $client_data['system'] .= " 14.04 LTS Trusty Tahr)";
          }
        elseif(preg_match('/saucy/si', $user_agent))
          {
          $client_data['system'] .= " 13.10 Saucy Salamander)";
          }
        elseif(preg_match('/raring /si', $user_agent))
          {
          $client_data['system'] .= " 13.04 Raring Ringtail)";
          }
        elseif(preg_match('/quantal/si', $user_agent))
          {
          $client_data['system'] .= " 12.10 Quantal Quetzal)";
          }
        elseif(preg_match('/precise/si', $user_agent))
          {
          $client_data['system'] .= " 12.04 Precise Pangolin)";
          }
        elseif(preg_match('/oneiric/si', $user_agent))
          {
          $client_data['system'] .= " 11.10 Oneiric Ocelot)";
          }
        elseif(preg_match('/natty/si', $user_agent))
          {
          $client_data['system'] .= " 11.04 Natty Narwhal)";
          }
        elseif(preg_match('/maverick/si', $user_agent))
          {
          $client_data['system'] .= " 10.10 Maverick Meerkat)";
          }
        elseif(preg_match('/lucid/si', $user_agent))
          {
          $client_data['system'] .= " 10.04 LTS Lucid Lynx)";
          }
  elseif(preg_match('/karmic/si', $user_agent))
          {
          $client_data['system'] .= " 9.10 Karmic Koala)";
          }
        elseif(preg_match('/jaunty/si', $user_agent))
          {
          $client_data['system'] .= " 9.04 Jaunty Jackalope)";
          }
        elseif(preg_match('/intrepid/si', $user_agent))
          {
          $client_data['system'] .= " 8.10 Intrepid Ibex)";
          }
        elseif(preg_match('/hardy/si', $user_agent))
          {
          $client_data['system'] .= " 8.04 LTS Hardy Heron)";
          }
        elseif(preg_match('/gutsy/si', $user_agent))
          {
          $client_data['system'] .= " 7.10 Gutsy Gibbon)";
          }
        elseif(preg_match('/ubuntu.feist/si', $user_agent))
          {
          $client_data['system'] .= " 7.04 Feisty Fawn)";
          }
        elseif(preg_match('/ubuntu.edgy/si', $user_agent))
          {
          $client_data['system'] .= " 6.10 Edgy Eft)";
          }
        elseif(preg_match('/ubuntu.dapper/si', $user_agent))
          {
          $client_data['system'] .= " 6.06 LTS Dapper Drake)";
          }
        elseif(preg_match('/ubuntu.breezy/si', $user_agent))
          {
          $client_data['system'] .= " 5.10 Breezy Badger)";
          }
        else
  {
          $client_data['system'] .= ")";
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: MESWEB on June 03, 2014, 04:32:53 PM
What about Opera Mini/Classic/Mobile?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on June 04, 2014, 08:16:00 PM
Quote from: cieplutki on January 01, 2014, 05:40:42 AM
hello,

who can test the BlackBerry OS

find:
// SonyEricsson & Ericsson
add before:
//Blackberry
if(preg_match('/blackberry/si', $user_agent))
      {
      $client_data['system'] = "BlackBerry OS";
      $client_data['system_icon'] = "blackberry";
      if(preg_match('/blackberry ([0-9.]+).*/si', $user_agent, $tmp_array))
        {
        $client_data['system'] = "BlackBerry OS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
        }


currently no icon.

This code cause a Parse error: parse error, unexpected '}'

Here is the fix.

//Blackberry
if(preg_match('/blackberry/si', $user_agent))
      {
      $client_data['system'] = "BlackBerry OS";
      $client_data['system_icon'] = "blackberry";
      if(preg_match('/blackberry ([0-9.]+).*/si', $user_agent, $tmp_array))
        {
        $client_data['system'] = "BlackBerry OS" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
        }
      }
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: deloon on June 30, 2014, 04:21:50 AM
Thanks guys. Working for me on 2.0.8   :D
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: lukaszuk1995 on November 24, 2014, 08:06:24 AM
OS & Browser Detection Mod - for SMF 2.1.
This is is my repack, it works fine on SFM 2.1 Beta 1. You can install it as a normal package, it includes the neawest edist by me and users of this forum  (thx).

Attachment removed on author's request.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on November 24, 2014, 08:08:09 AM
(And before anyone from the team objects; this mod has been stated as being under a suitable licence for this)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Sandmansa on November 25, 2014, 08:29:27 PM
You know, I tried to do this before.  And even though the author never returned my emails, it still got rejected because of licensing issues.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on November 25, 2014, 08:41:25 PM
Yes, but these days, the author *has* since indicated such.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on November 26, 2014, 04:42:53 AM
Arantor, if you have the ability for this board, please remove previous attachment (OS & Browser Detection Mod - for SMF 2.1)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Arantor on November 26, 2014, 07:37:08 AM
I don't have the ability. I was under the impression this was all good now though?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: NanoSector on November 27, 2014, 01:43:45 AM
Attachment removed as requested.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Branko. on November 27, 2014, 05:59:44 AM
Thanks ..  :)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: gemchug74 on February 21, 2015, 12:42:46 PM
Hi, added Win10, check correct or not ?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on June 08, 2015, 02:38:33 AM
In smf 2.0.10 work great .
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: btechnix on June 10, 2015, 04:18:33 PM
Quote from: gemchug74 on February 21, 2015, 12:42:46 PM
Hi, added Win10, check correct or not ?
I think it's no good because Microsoft Confirms that Windows 10 will also be Version 10 Internally and not version 6.4
Look for example at http://arstechnica.com/information-technology/2014/11/why-windows-10-isnt-version-6-any-more-and-why-it-will-probably-work/ and http://winsupersite.com/windows-10/microsoft-confirms-windows-10-will-also-be-version-10-internally
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on June 13, 2015, 03:09:39 PM
Another possible user agent to add for MSIE 11:


    if(preg_match('/Windows-RSS.*IE ([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "MS Internet Explorer" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on June 16, 2015, 08:26:43 AM
Quote from: snoopy_virtual on June 13, 2015, 03:09:39 PM
Another possible user agent to add for MSIE 11:

That was because I saw a visitor in one of my forums with this user agent: Windows-RSS-Platform/2.0 (IE 11.0; Windows NT 6.1) and this mod didn't catch it.

Reading this page: https://msdn.microsoft.com/library/ms537503.aspx I sow what it was. That's why I recommended to add that code inside the MSIE 11 area.

Today I have seen another visitor not recognized by the mod with this user agent: Mozilla/5.0 (compatible; Baiduspider/2.0; +http://www.baidu.com/search/spider.html)

It is obviously Baidu robot, so we should add inside the section Various robots...:


    // Baiduspider
    if(preg_match('/Baiduspider\/([0-9a-z\+\-\.]+).*/s', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Baiduspider" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'robot';
      }
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on August 10, 2015, 02:41:37 PM
Add windows 10 and Egde broweser (internet explorer) who check
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on August 10, 2015, 03:29:10 PM
Wonderful. We were needing that icon. I can see a few W 10 every day already in my sites.

(http://www.snoopyvirtualstudio.com/foro/Smileys/default/asturiaspatriaquerida.gif)

Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on August 10, 2015, 04:09:00 PM
use of this post:
http://www.simplemachines.org/community/index.php?topic=278770.msg3794142#msg3794142
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on August 11, 2015, 12:33:13 AM
Thank you very much
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on August 12, 2015, 02:12:20 PM
Quote from: cieplutki on August 10, 2015, 02:41:37 PM
Add windows 10 and Egde broweser (internet explorer) who check

Receive errors in my smf 2.0.10
2: preg_match() [<a href='function.preg-match'>function.preg-match</a>]: No ending delimiter '/' found
in /**/**/Sources/os_browser_detection.php  line 691

This is line 691

if(preg_match('/Edge\/12.0', $user_agent, $tmp_array) && !$client_data['browser'])


i think the correct are ( adding one / in '/Edge\/12.0 ) :

if(preg_match('/Edge\/12.0/', $user_agent, $tmp_array) && !$client_data['browser'])


Any idea please ?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on August 12, 2015, 03:14:34 PM
if(preg_match('/Edge\/12.0', $user_agent, $tmp_array) && !$client_data['browser'])
replece
if(preg_match('/Edge\/12.0/', $user_agent, $tmp_array) && !$client_data['browser'])
should help
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on August 12, 2015, 11:52:08 PM
Depending on your server, sometimes it sees all the letters lowercase, so I would put it as:


if(preg_match('/Edge\/12.0/i', $user_agent, $tmp_array) && !$client_data['browser'])


Adding the "i" to make it case insensitive.

That way it would match both "Edge" or "edge".
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on August 13, 2015, 12:15:10 AM
Even better


// EDGE 
if(preg_match('/Edge\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Edge" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }


Just in case they change the number 12.0 in a couple of weeks  8)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on August 14, 2015, 07:38:18 AM
Quote from: cieplutki on August 10, 2015, 02:41:37 PM
Add windows 10 and Egde broweser (internet explorer) who check

Hi again

Edge 20.10240.16384.0 recognized as "(http://i.imgur.com/BxB7YzD.png)42.0.2311.135 Chrome 42.0.2311.135"

Quote from: snoopy_virtual on August 13, 2015, 12:15:10 AM
Even better


// EDGE 
if(preg_match('/Edge\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Edge" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }


Just in case they change the number 12.0 in a couple of weeks  8)

the same happened with this opinion .......

Any solution please ?


And Edge icon attached
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on August 14, 2015, 09:53:26 AM
Try this
// EDGE
if(preg_match('/Edge\/12.0/', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Edge" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'edge';
      }

put  icon edge to Themes\default\images\os_browser_detection
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on August 14, 2015, 01:22:04 PM
Quote from: cieplutki on August 14, 2015, 09:53:26 AM
Try this
// EDGE
if(preg_match('/Edge\/12.0/', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Edge" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'edge';
      }

put  icon edge to Themes\default\images\os_browser_detection

This is the first thing have try ( the os_browser_detection.php  from your post  (http://www.simplemachines.org/community/index.php?topic=278770.msg3829373#msg3829373) ) and report before DO NOT WORK
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: snoopy_virtual on August 14, 2015, 06:31:15 PM
Quote from: villasg on August 14, 2015, 07:38:18 AM
Quote from: cieplutki on August 10, 2015, 02:41:37 PM
Add windows 10 and Egde broweser (internet explorer) who check

Hi again

Edge 20.10240.16384.0 recognized as "(http://i.imgur.com/BxB7YzD.png)42.0.2311.135 Chrome 42.0.2311.135"

Quote from: snoopy_virtual on August 13, 2015, 12:15:10 AM
Even better


// EDGE 
if(preg_match('/Edge\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Edge" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'msie';
      }


Just in case they change the number 12.0 in a couple of weeks  8)

the same happened with this opinion .......

Any solution please ?


And Edge icon attached

The solution would be to use this:


// EDGE 
if(preg_match('/Edge\/([0-9a-z\+\-\.]+).*/si', $user_agent, $tmp_array) && !$client_data['browser'])
      {
      $client_data['browser'] = "Edge" . ($tmp_array[1] ? " ".$tmp_array[1] : "");
      $client_data['browser_icon'] = 'edge';
      }  


But to put it further up in the file, before the catch for Chrome

Around line 266 I think.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: villasg on August 15, 2015, 03:31:04 AM
Quote from: snoopy_virtual on August 14, 2015, 06:31:15 PM
But to put it further up in the file, before the catch for Chrome

Around line 266 I think.

Work this solution ! ! !

(http://i.imgur.com/NnXlCs8.png)

And chrome work fine too ! !

(http://i.imgur.com/DzoSGA0.png)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on August 15, 2015, 03:56:04 AM
Windows 10
Edge browser
Internet Explorer on mobile
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on April 06, 2016, 02:30:32 PM
ad new webrowser vivaldi
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: Innos on October 17, 2016, 04:35:19 AM
Quote from: cieplutki on August 15, 2015, 03:56:04 AM
Windows 10
Edge browser
Internet Explorer on mobile

I am using 2.0.12

After installing this now I get:
"The database value you're trying to insert does not exist: id_board"

Either I try to create a new thread or post a reply

Any ideas?
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: cieplutki on October 18, 2016, 02:37:52 PM
uninstall the update 2.0.12 most bbcode does not work  on it.
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: IVKE13 on July 11, 2021, 05:46:44 AM
Hello,

where can I find add-on for detection of windows 10, anodoid (mobile)
Title: Re: OS & Browser Detection (version 1.5 is out) [20. 09. 2010.]
Post by: shadav on July 11, 2021, 12:10:16 PM
Quote from: IVKE13 on July 11, 2021, 05:46:44 AM
Hello,

where can I find add-on for detection of windows 10, anodoid (mobile)
well seeing that the last post in this thread was back in 2016 (5 years ago) and seeing that the mod was last updated back in 2014 (7 years ago) I highly doubt that windows 10 was added to it just yet...
and well the mod author hasn't been active since 2015 (6 years ago), I wouldn't hold my breath for an updated

and per the original post it seems windows 7 was the highest version they went to with this mod
Quote from: Branko. on December 06, 2008, 05:23:42 AM
* Version 1.1 (18. 01. 2009.)
- Fixed Unefined index error in Subs-Post.php (SMF 2.x)
- Windows 7 support included
- Swedish translation added (thanks to P_cool)
- Portugeese translation added (thanks to joomlamz)
- Polish translation added (thanks to saneone)
- Spanish translation added (thanks to M-DVD)

although if you search this thread for windows (https://www.simplemachines.org/community/index.php?action=search2;search=windows;topic=278770), there are a few posts that may help you out