Simple Machines Community Forum

Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=1590)

This allows you to add RSS Feed 'Bots' to your forum to display information from RSS Feeds.

Features of this mod:

• Unlimited Feeds
• Post to any board on your site
• Specify which user to post as
• Single click enable/disable of any feed from the admin panel
• Lock feed topics once posted
• Require approval of feeds before publicly viewable (only if Post Moderation is enabled)
• Prefix feed with any title (Ie: [FEED], [RSS], [NEWS], etc)
• Retrieve full article (Regular Expression REQUIRED)
• Find articles by keyword in the Title or Description
• Specify number of items to import from each feed
• Caching of feeds for faster performance in case the feed hasn't changed
• Logging of posted feeds to avoid duplicates
• Uses Scheduled Tasks to determine when to fetch feeds (you can set the frequency)
• Log pruning - removes log entries that are 30 days old (this can be changed too)
• Option to post all feed items into a single topic, instead of seperate topics
• See how many items each feed as posted
• Selectable image icons for feeds
• Add a custom footer to each post for feeds

Change Log:
Version 1.1.0
-------------
* Added a 'Source' bit at the bottom of each post (ManageSettings.php, RSSFeeds.template.php, ScheduledTasks.php)
* Add a footer to the bottom of the post after the feed content (ManageSettings.php, RSSFeeds.template.php, ScheduledTasks.php)
* Selectable message icons for each feed (ManageSettings.php, RSSFeeds.template.php)
+ Allow images in the posts by converting <img> tags to bbcode [img] tags (Subs-Rss.php)
* Feeds keep track of items posted from them, viewable in the feed setup page (ManageSettings.php, ScheduledTasks.php)
? Mark as read option causing errors on scheduled task run, removed feature (ManageSettings.php, RSSFeeds.template.php, ScheduledTasks.php)
! Forgot to check if description was empty (ScheduledTasks.php)
* Option to post all feed items into a single topic, instead of seperate topics (ManageSettings.php, RSSFeeds.template.php)
! Error might be thrown if regular expression didn't find anything (ScheduledTasks.php)
+ Switched from MagPie to SimplePie for the RSS api (Subs-Rss.php)
+ Added logging for feeds that become disabled when the scheduled task runs (ScheduledTasks.php)

Version 1.0.0
-------------
* Release

Legend:
* = New feature
+ = Improved feature
! = Fixed bug
? = Other stuff


Regex Help
Attached to this post is a file named regex.php... you can upload this script to your web server to test out your regular expressions with a given input.  It's pretty self explanatory... the goal is end up with what you want in the [1] => part of the array returned.  For debugging purposes, the entire matches array is displayed.  See this post (http://www.simplemachines.org/community/index.php?topic=285356.msg1875490#msg1875490) of the topic as well.



*Known Issues*
This was meant to work with Auto Suggest for choosing who to post as, but I didn't realize that there was a change in the auto suggest script from Beta 4 to RC1, so auto suggest will only work on RC1+.  This does not hinder the mod in any way, except that you must properly enter the username / displayname otherwise you will get thrown back to an error.

Doesn't play nice with utf-8 characters, cuts off strings or converts to ?s in the Prefix or Footer fields, possible database collation issue.

Suggestions

• Create an additional section in a user's profile to allow them to create and maintain their own feeds that post to boards of their choice or admin selected boards.

hope next time it can be used with 1.1.7

Sorry, I won't be making a version of this for 1.1.x.  vbgamer has an archived version that still works with 1.1.7 as far as I know, you may want to give that one a shot.

Oh... By any chance, is this mod related to the one Smoky Blue was looking into making at some point last week?

I'll have a look into it later if I don't forget. :)

my IPP disallow url_fopen. Working this mod with curl?

The mod seems to use fsockopen, just like SMF does for its fetch_web_data function (which retrieves external packages or SMF news etc). If your SMF works fine, then this should work fine too.

It uses Snoopy php Web browser to retrieve feeds... I really didn't look into it too much, but I do believe it supports curl as well.

Nao - I'm not sure... I didn't know SmokyBlue was working on something like this.  Looking at topics in mod requests, I see that KahneFan was wanting something similar to this and Smoky was working on it.

Quote from: SlammedDime on January 11, 2009, 07:47:57 AM
Sorry, I won't be making a version of this for 1.1.x.  vbgamer has an archived version that still works with 1.1.7 as far as I know, you may want to give that one a shot.

It doesn't work well I'm afraid.  It posts once and then it dies :(

There is an error with Turkish characters. It shows '?' instead of 'ı', 'İ', 'ğ', 'ş', 'Ş'.

I wonder if it's because of the __striptext function of Snoopy... Can you provide a feed as an example.

Yes, http://www.sabah.com.tr/rss/sondakika.xml .

yes i had something in the works like this

i have a bunch of stuff for rss posters from vb, ipb, drupal, wp, ee, and more..

good to know you tried SlammedDime, and thank you..

on the issues of it only posting once, will check things out..

i did get vbgamers mod working perfect, so..  ;)

Currently trying this on a test site.

1) Is there a cron page I need to have my server hit, or does it run a cron job automatically or....?

2) Will it import old articles from feeds or only new articles?

It runs off of SMF's Scheduled tasks - Fake Cron if you will.

You *could* create your own cron if you wanted by writing a simple PHP script that included SSI.php, Sources/ScheduledTasks.php, then ran the scheduled_rss_feeds() function.

It will import anything in the feed based on what you specify in the settings for that feed.  Want to import the entire feed, set the number to import to 0.  Want to import only feeds with certain keywords, put in the keywords... or any combination of both.

Do you know how often SMF's tasks run? I ask for 2 reasons. 1) 24 hours would be minimum (I would think). 2) On another site I had with feeds, I had so many that 15 minutes was actually too far apart.

You can go to the scheduled tasks part of SMF's admin panel and specify how often you want any of your scheduled tasks to run, including this one.  I set the default to every 6 hours.

I have it running here and it works great, thanks SlammedDime.

http://forum.pctweakr.com/index.php/board,3.0.html (http://forum.pctweakr.com/index.php/board,3.0.html)

Thanks for posting that Bigguy.

Quote from: SlammedDime on January 11, 2009, 03:36:14 PM
You can go to the scheduled tasks part of SMF's admin panel and specify how often you want any of your scheduled tasks to run, including this one.  I set the default to every 6 hours.

Learn something new every day. Thanks!

"Ran Now" and works like a charm. This is great, thanks!

np ;)

If you're taking suggestions for a next version :)

It might be nice to see a column for "Feed Items" or even just "Total" in the admin area, so that you can see how many articles each feed has brought through. (hope that makes sense)

| Feed Enabled | Feed Title | Feed Total | ...

Also, when a feed is deleted, if possible, it would be nice to delete the articles of that feed. For example, you have a feed that you no longer want to associate with, for whatever reason, you delete the feed, but the articles are still there.

The first would be easy to implement because I already have a log table that keeps track of the feed items posted, or I could add a column to the rssfeeds table to keep a count and update it when I update the last updated time of the feed.

The second would be easy to implement, again, because I already have the log table, would just have to add a column for topic id.

The only issue I see overcoming is that is someone deletes feeds already posted, or if they have the posts set to require approval, and they delete instead of approve, the feed won't be removed in the feed table, so the 'Total' wouldn't be accurate to what is actually on the forum, but to what has actually been posted, regardless of whether or not it's still there.

also SlammedDime, Kahne wanted to be able to allow users to add feeds as well..

so if you can swing this, i know he would be very happy..  ;)

Might be nice to integrate this into the News Fader. :)

Quote from: SmokyBlue on January 11, 2009, 04:27:34 PM
also SlammedDime, Kahne wanted to be able to allow users to add feeds as well..

so if you can swing this, i know he would be very happy..  ;)

;)

It sounds as though this would be a tough one though. So, having members contact me is OK for now. But if it could happen... :P

Also, I just tried it HERE (http://www.texasfelt.com/index.php?board=9.0) and when I ran it from admin to pull the old articles (535 and ran smoooooth), it posted them by either 1) the order in which I input them (z-newest -> a-oldest) or 2) in alphabeticle (z-a), instead of by date (originally) posted. As long as it posts them in date order from here out will be OK with me. Do you know if future updates will be posted by date order?

i thought of that too BigGuy and i actually have one rss with its own db and page..

set up like the google home pages that you can move around.. happy thoughts tho, since i dont know what im doing with it, nor the time to play like i would like and actually learn, so..

but im more than willing to send my stuff to whoever that would be interested.

It may be possible to allow this to extend to allow users to create feeds, actually might be quite easy to extend that functionality now that I think about it.  I already store the id_member of the poster in the feed table, so I would just have to create an additional profile page that allows a user to edit his/her feed and they could have the same options that an admin would have.

As for how they are imported... the script will run from the top of the feed down to the bottom of the feed, so however they are placed in the feed is how they will be imported, top being imported first, and bottom being imported last (most recent imported).  Now that I think about this, it should probably be reversed, but it's something to keep in mind for later versions

Kahne - it's nice to know it worked on that large of a feed. :)

Quote from: SlammedDime on January 11, 2009, 05:03:25 PM
It may be possible to allow this to extend to allow users to create feeds, actually might be quite easy to extend that functionality now that I think about it.  I already store the id_member of the poster in the feed table, so I would just have to create an additional profile page that allows a user to edit his/her feed and they could have the same options that an admin would have.

The only thing here would be making sure they know where to post them. If user feeds is a possibility, admin approval might be needed, which is still easier than entering them. OR, if admin could specify a single setting of: Post all user feeds in: {board}

wOOt!!
Ive only just setup a test site with smf2(bout time to move on from 1.1.7), and whats the first mod I see!?? lol
Very nice mate, thanks :)

Hi, thanks for this mod.. love it.

Just wanna know any1 tried using the Retrieve Full article features? Any example of the expression or how to use it?

Regards

SlammedDime such a excellent mod.

I will install it and comment here.

Have some suggestions.

Need a Auto filler column under each feed settings.

Say if i add the feed from cnet & reuters.

On the settins page, under feeds i will enter " Source : Cnet " or " Source : Reuters " on the new column you create.

so every time a feed is added , it will enroll the Source text ever time feed is posted on our forum.

Ex Post :

Subject : - Subject already printed here

Body : - Feed information is printer here.

Footer :-  Source - CNET.

Hi,this mod is just awesome.

However,I have a problem with spanish characters: the mod "cuts" every word with a spanish character and all the text that goes behind.

Example: "tecnología" (technology in english)---> tecnolog 

The other words that go behind a spanish character are also deleted.
Exemple: "Penélope Cruz gana del Oscar" (Penelope Cruz wins the Oscar) ----> "Pen"

This problem makes that almost every topic tittle doesn't show full,and also links and the news itself are almost deleted.
Could you fix that,please?.It's very important for people using SMF in other languages than engliss/feeds in other language.

More feedback/suggestions:

-A feature that would be so useful is the option to insert a "footer" to the rss post.I mean,for example: If I set up a rss for "news",It would be nice to have the option that allows you to insert a footer such as "What do you think about this? We want your opinion!",that automatically is inserted on every topic created by the rss "bot".
That way,you can make posts more "human",and ask for participation.
Is that possible? just a suggestion  ;)

-Also: can you (or someone) make a mini "tutorial" to use the "Retrieve full article" feature?.

Thank you very much and good work.

A.SK - Swell idea... although it would be much better (IMO) to utilize the existing information from the feed, and throw the source in as the Feed's title that is sent via RSS, rather than allow an admin to set the source... this way I can also hyperlink it automatically.

Lamarck - This is probably related to the Snoopy PHP Web browser that the mod utilizes to retrieve feeds and might be an easy fix.  I asked another user on the previous page for a direct link to a feed that has such characters so I can further test this.  Can you provide me with a link as well?

As for the footer - that wouldn't be a bad idea either.

Once 2.0 goes RC and I'm sure this still works as is with it, I'll look into incorporating many peoples suggestions.

As for a tutorial on the regular expression and full article... I'll see if I can throw a mini article together later today after work.

SlammedDime You rock man, a lot of people have been wanting this for a while.  Ill be testing it out later today and cant wait. :)

Ok I tested and it works great. In fact it does a much better job of reading poorly written RSS Feeds then VB's version does.

Question though can we get an example of how the regular expression in PCRE is supposed to work. Ive never had to use that for anything and I'm sure others have not either.

Definitely and Awesome mod.  :)

Yes,of course...here is a link:

http://www.20minutos.es/rss (http://www.20minutos.es/rss)

Ah,the problem is not only with "´",the same thing happen with "ñ".

Thanks!.

I'm not sure, but... Shouldn't accented data and single quotes be enclosed in CDATA blocks?

First off, to use the retreive full article feature, the news source must have a decent design on their website that will make it easy.  If not, it won't work.  Here's a quick example of using the Retrieve full article feature from AZCentral.com (Arizona's Newspaper and NBC affiliate site), as well as the regular expression syntax to retreive it for this particular feed.

Here is the feed: http://www.azcentral.com/rss/feeds/northphoenix.xml

Here is one of the items from that feed: http://www.azcentral.com/community/phoenix/articles/2009/01/12/20090112phxpopulation0107.html

If you look at the HTML source for the feed, you'll find the article in the following HTML code...
<span fd-type="start" fd-id="default"></span>

  <h1 class="topHeadline">For first time in modern history, Phoenix may be losing people</h1>

        <h2 class="subHeadline">Population dip would further strain budget</h2>                <p class="byline vcard clearfix">
          <a href="#comments"><span class="bylinecomments" id="commentcount"></span></a>
          by <strong>Michael Clancy  and Casey Newton</strong> - Jan. 12, 2009 12:00 AM<br />
         
          <span class="org">The Arizona Republic</span>
        </p>

          <div id="articlestory"><p>For the first time in modern history, Phoenix's population could be shrinking. </p>
<p>It's an idea that would have been unimaginable just a few years ago, when Phoenix was surging up the list of the nation's most populous cities. Now, a variety of indicators suggest that fewer people are living here than a year ago.</p>
<p>No one knows for sure exactly how many people have moved in or out. But with the 2010 census about to get under way, some indicators suggest Phoenix's population may be smaller than the projected 1,636,170 people.
<span id="articleFlex1"><script type="text/javascript">OAS_AD('ArticleFlex_1')</script></span>
</p>
<p>City records show declining trends in several key areas. Among them: </p>
<p><br /> • Foreclosure numbers have skyrocketed, meaning fewer city homes are occupied. </p>
<p><br /> • Water hookups are down, suggesting the same. </p>

<p><br /> • Some aspects of trash collection have ebbed because fewer people are buying things that produce waste. </p>
<p><br /> • Crime has declined across the city while police are getting fewer calls for services, a possible indicator of fewer people. </p>
<p><br /> • Sales-tax revenues are likely to drop for the second year in a row, with this year's collections off almost 8 percent from last year. </p>
<p>Experts say each trend can be explained in part by other factors, such as the national recession and the bursting of the housing bubble. When consumer spending decreases, so do tax revenues and the amount of trash that people throw away.</p>
<p>Still, an <i>Arizona Republic </i>analysis of the trends suggests Phoenix has anywhere from a few hundred to several thousand people fewer than projected.</p>
<p>"I think the number is minor, but with all these indicators moving down, I think it is real," said City Manager Frank Fairbanks, declining to speculate of the number of people the city may have lost.</p>

<p>Several factors could be behind a population loss, Fairbanks and others say. The state law requiring employers to verify immigration status of their workers is believed to have driven many immigrants out of the state in 2008. The regional decline in construction jobs also could be behind an exodus. </p>
<p>Statewide, growth has slowed to a crawl. A population report released in December showed Arizona grew by 1.6 percent, or about 100,000 residents, in the previous fiscal year - less than half the growth rate of two years prior. </p>
<p>But the possibility that Phoenix has declined relative to other cities has leaders worried.</p>
<p><h3>Tax revenue at risk

</h3></p>
<p>Losing any fraction of the city's population could mean less revenue to Phoenix from the state.</p>
<p>Arizona shares 15 percent of its income-tax collections with cities based on those cities' population. </p>
<p>Phoenix's population now represents about 30 percent of Arizona's population. This year, Phoenix got $435 million from the state. That made up 38.7 percent of the city's general fund. </p>
<p>Assuming that the suburbs maintain or grow their current populations, Phoenix's share of revenue from the state could shrink in coming years, compounding the city's budget crisis.</p>
<p></p>

<p>Phoenix already is facing cuts of $270 million, or more than 22 percent, from its budget this year. The city is weighing cuts from community centers, senior centers, libraries, police and fire protection, and other services.</p>
<p>"It's an important, pressing issue for all of our cities here, but Phoenix probably most of all," said Rita Walton, who monitors population for the Maricopa Association of Governments. "They're the biggest and stand to lose the most."</p>
<p><h3>The evidence

</h3></p>
<p>Several indicators exist showing that the population could be declining. Among them: </p>
<p><b><br /> • Water: </b>The number of water-using accounts fell about 5,600 from fiscal 2007-08 to 2008-09. The number of accounts using no water almost doubled, on average, meaning those homes still have water connections but are probably empty. </p>
<p>Tracking population by water hookups is "a good way of watching for population change," said Steve Doig, a journalism professor at Arizona State University who used a similar method to track the return of people to southern Florida after Hurricane Andrew. </p>
<p>Evidence about the increasing number of water accounts using no water and the decreasing number of accounts generally indicates population decline. </p>
<p><b><br /> • Trash:</b> Trash collection dropped 2 percent overall from fiscal year 2006-07 to 2007-08. While the amount of recyclable material picked up increased slightly, bulk-trash pickup dropped almost 15 percent during the same period. </p>

<p>Dennis Hoffman, professor of economics at the W. P. Carey School of Business at ASU, said trash collections, just like electrical and water hookups, frequently are used to gauge more precise population shifts than a census provides.</p>
<p><b><br /> • Foreclosures: </b>Bank repossessions of homes continue to increase. The key areas of decline are in the western part of the city. Phoenix overall had a staggering 534 percent increase in foreclosures in the first half of 2008, or an increase of about 5,000 additional homes in foreclosure compared with the first half of 2007. Figures for the last half of the year are not yet available. </p>
<p><b><br /> • Taxes: </b>Sales-tax collections have declined dramatically. Although not tied to growth as directly as water hookups, increases in sales-tax collections began slowing in 2006-07, then dropped in the next two years. </p>
<p>Hoffman said that since the retail sector thrives on population growth, it is reasonable to conclude that with the retail sector in so much trouble, declining sales-tax revenue could correlate to declining population.</p>
<p><b><br /> • Crime: </b>Phoenix saw violent crime decrease 0.3 percent last year, along with a 0.3 percent decrease in total property crimes. Crime has continued to fall in 2008, records show. In addition, Phoenix police have had fewer calls for service this year than last year, Police Chief Jack Harris said. Growing populations almost always result in more calls to police.</p>
<p><h3>Hope ahead?


</h3></p>
<p>Not everyone is pessimistic. Mayor Phil Gordon expressed skepticism at the idea of a shrinking city.</p>
<p>"The growth of Phoenix, like all cities in the Valley, has slowed significantly. But Phoenix's net growth is still positive, both in jobs and population," he said. </p>
<p>Gordon said the city is poised to resume steady growth as soon as the economy emerges from the current recession.</p>
<p>"When the recovery comes, we will be better positioned to recover faster and take advantage of it than many other cities locally and throughout the U.S. The world and the nation know Phoenix.... Whether it's national or international, we're first on the list of cities to invest in as the economy turns."</p>
<p></p>
<p><b>Reporters Astrid Galvan, Rebekah Sanders, Dianna M. Náñez, Edythe Jensen, Elias C. Arnold, Lynh Bui and Gary Nelson contributed to this article.</p>
<p></b></p>
<p></p></div>


The main thing that I want is the story... I don't need the title or the author, and they make this easy because the store is wrapped in a div tag with the id of "articlestory" (find <div id="articlestory">, and then the closing </div> is at the bottom of the code block.

Perfect, so I know my article is always wrapped in this HTML, so it'll be easy to always pull it out.  This also makes the regex easy to write.

For those that aren't familiar with PCRE, there is sooooooo much to it that I can't really explain, but I'll give the regex I use, and why I've used it, and hopefully that will give you a starting place...

~<div id="articlestory">(.*)<\/div>~siU

In parts:
Each regex must start and end with a character, any characters, as long as it's the same.  I choose to use ~.  You could just as easily use any non-Meta character (see the PCRE reference) like /, or : or whatever works for you.  I like ~, its easy to remember and isn't used a lot in text, so it normally won't be used in your regex at all.

Next I have the beginning div tag - <div id="articlestory">

Then I have (.*).  This means grab EVERYTHING that follows that starting div tag until the end of the line.  (note, I'll get to it later)

The purpose of being in () is that whatever is found in this () will be captured into the first index of the array that the mod will use to post.  If you have to use () to enclose anything BEFORE this (.*), then you'll want to prevent it from being captured and being put into the array by starting it with (?:search string here)

If you have to use any parenthesis in your regex BEFORE your (.*), you will have to use (?: to start it.  In most cases, I dont think this will be required, but it is something to keep in mind if you see your feed being posted incorrectly.

The next part is the closing div... <\/div>.  All / in a regex need to be escaped using a \.

Following that is the closing ~ that I discussed earlier.

After that are a few letters, siU.  These are called pattern modifiers.  These can change the way your regex works.  Here is what the siU stand for -
s - means that .* should capture all characters including newlines and carriage returns.  Without this, .* will stop at the end of the line.  So by using the s modifier, .* will capture everything from where it starts to the end of the document (more to come on that too, since we want to stop at some point)
i - this means that the search is caseless.  So if you want to search for <DIV>, but <div> is the document, your regex will still find it.
U - this is the ungreedy modifier.  Remember how I said that .* will capture everything until the end of the document... this stops it.  This forces .* to stop when it comes across the next part of the pattern

Well, I hope I confused you enough... have fun... :)

Great information, thanks!

I think it's best to use (.*?) and no ungreendy parameter, rather than the other way around. It can be confusing otherwise.
Also, / usually doesn't need to be escaped.

Wow thanks that is exactly what I was looking for and I think it will help a lot of people.

Nao:
If I didn't escape it, it didn't work right for me... I didn't think it did matter, but better safe than sorry.

As for using? to go ungreedy, because of the typical simplicity needed for this type of application, using U should work okay.  I can see cases when it wouldn't be desired, but I don't think this is one of them.

Quote from: SlammedDime on January 11, 2009, 07:47:57 AM
Sorry, I won't be making a version of this for 1.1.x.  vbgamer has an archived version that still works with 1.1.7 as far as I know, you may want to give that one a shot.

The one by vbgamer doesn't exactly work like it should, as I've been having extremely hard time getting his mod to pull feeds even from my own blog.

Quote from: SlammedDime on January 12, 2009, 12:35:41 PM
Nao:
If I didn't escape it, it didn't work right for me... I didn't think it did matter, but better safe than sorry.

Just so you know -- / isn't part of the preg_quote list either.

QuoteAs for using? to go ungreedy, because of the typical simplicity needed for this type of application, using U should work okay.  I can see cases when it wouldn't be desired, but I don't think this is one of them.

I just think it's good practice to learn what the extra "?" is all about, asap.

I'm having trouble.  Great mod by the way, can't wait to get it working.  I've installed successfully but get this error when taken to the settings page under "Modifications - RSS Feeder"

Unknown column 'f.id_feed' in 'field list'
File: /home/secsport/public_html/forum/Sources/ManageSettings.php
Line: 2577

If I had to guess, it'd be because the table in the database wasn't created properly.  You can try rerunning add_settings.php from the mod package by putting it into your main forum directory and navigating to it.

Quote from: SlammedDime on January 12, 2009, 04:29:22 PM
If I had to guess, it'd be because the table in the database wasn't created properly.  You can try rerunning add_settings.php from the mod package by putting it into your main forum directory and navigating to it.

That didn't work.  Anyway I can manually create the table?  If so, how?

Nevermind, I've got it fixed.  For whatever reason I already had an smf_rssfeed table.  ;)

yea, I made the add_settings so that if the table already existed, it was ignored on creation... :) Glad you got it sorted.

Another quick question. On my test site, the feed poster won't duplicate posts, but on my live site it seems to be duplicating them.

The only difference in settings is that I have my live site option to "Mark as Read" for the RSS posts.  Any solution, or is this an unintended bug?

Any errors in the error log?  Make sure you have the log_rssfeeds table in your database.

Quote from: SlammedDime on January 12, 2009, 07:30:48 PM
Any errors in the error log?  Make sure you have the log_rssfeeds table in your database.

Nevermind, I just realized that I was on my boardtester account, which is using a different theme than my admin account used to install the modification. 

Is there any way to install the mod to multiple themes without having to manually go through all of the edits?  My site runs team themes (12 different ones) and I'd like this feed to work on all of them.  If there is no automatic way to do it, where can I find a list of the manual edits I'd need to make?

This makes no theme edits, it is theme independent, works across any and all.

great tutorial on the full article retrieval, SlammedDime.

Few questions

RSS from moreover.com retrieves news from different news resources. Let say i set the expression to retrieve full article based on one of the resources, does the mod still retrieves other information from other resources + the full article based on the expression resource?

Second:
If i create more entries to retrieve from a same rss feed url (like moreover.com) but each entry with different expressions... will it work?

Trying to test them but I have to wait tomorrow to see the result as the sites i want to get already retrieved...

Regards

In the case of moreover.com, I would not use the retrieve full article option.  It will end up posting just the description of the item if the regex isn't matched.  It could possibly be changed to not post anything if the regex isn't matched.

If I were to implement something like that, then your idea of multiple feeds with the same url would probably work okay.

Quote from: SlammedDime on January 12, 2009, 07:53:12 AM
A.SK - Swell idea... although it would be much better (IMO) to utilize the existing information from the feed, and throw the source in as the Feed's title that is sent via RSS, rather than allow an admin to set the source... this way I can also hyperlink it automatically.

I was used to it, that's a rule on my board to enter source on every page.
That's why i have requested it.

But what you have did is also meaningful.

Quote from: SlammedDime on January 12, 2009, 08:58:40 PM
This makes no theme edits, it is theme independent, works across any and all.

Yeah, I just noticed that.  In that case, I'm not really sure why it's not working.  I have the Mark Topic as Read button checked, but the new articles are still showing up as unread in the "Read unread posts since your last visit" link.

The only thing that I notice the Mark Topic as Read button doing is making it so that the on.gif image doesn't come on, as in the board appears that there are no new posts.

However, I really would like the articles from the RSS feeds to stay off of the unread posts link.  Is that possible?

Quote from: SlammedDime on January 12, 2009, 10:33:53 AM


Here is the feed: http://www.azcentral.com/rss/feeds/northphoenix.xml

Here is one of the items from that feed: http://www.azcentral.com/community/phoenix/articles/2009/01/12/20090112phxpopulation0107.html


~<div id="articlestory">(.*)<\/div>~siU

I have tried to use the full article method,

But it resulted me in one single line and it does not print after enter symbol.

Referred PCRE format also,

http://feeds.reuters.com/reuters/INVideoTechnology?format=xml

Full Article format : ~<div id="article primaryContent">(.*)<\/div>~siU

http://www.rediff.com/rss/bporss.xml

Full Article format : ~<div id="business_storyMiddle">(.*)<\/div>~siU

Do correct me if possible, thank you .

I'm not sure where you came up with those regex's.... For your first one... that has a lot of video feeds... so to extract the text from the video feeds, you'd want to use

~<div id="videoText">.*<\/div>(.*)<\/div>~siU (untested, but should work)

And for the second one

~<p><font class="sb13">(.*)<\/font><\/p>~siU (again, untested, but should work)

I'm still having a few different problems with this RSS Feeder.  First off, I've tried completely uninstalling and removing all the tables and then reinstalling, but  that hasn't worked.

On my test site, I have the problem that despite the feed using the "Mark as Read" option, these articles are still showing up as unread, and they won't even turn "read" after I've read them.  So they stay in my list of unread posts.

On my live site, my feeds are enabled, but then seem to automatically become disabled as soon as the RSS Feeder scheduled task runs.  Anyone that can help me would be greatly appreciated.

I'd really love to get this mod working on my site.

If they become disabled when the task runs, it's because your host may have fsockopen disabled... something to look into.  The only reason it would become disabled is if the feeder is unable to connect to the feed.  (you can check your error log on this too, I believe MagPie throws up a User created PHP error if it can't connect to the feed and SMF will log it)

As far as the mark as read problem on your test site, I'll investigate this on my Beta 4 and Rc1 installs, but I never ran into this issue.

Edit: I just tested the Mark As Read option and it worked just as it should on both of my test installs.

Interestingly enough, it only does this for certain feeds...

How can I check to see if my host has fsockopen disabled or not?

The easiest way to know is to visit your SMF Admin main page.  If the SMF Latest News box updates, then you do have it enabled, as SMF uses the same function to retrieve the latest news from our servers.

Okay, I figured out why the feed wasn't working.  For whatever reason I had the URL wrong, stupid me.

Anyway, it works great on my admin account now.  It just updated the feeds and they showed up as unread on my account.  However, when I logged onto another account (my boardtester account), all of the posts were unread.

Has anyone else tried this mod from an account other than the admin account?  If so, does it do the same for you or is it just on my site that this is happening?

Or maybe it's just a first time thing?  Will they display as unread when it pulls the next new article?

Oh, another awesome feature request that probably wouldn't be too hard:

The option to specify a particular message icon for each individual feed.  For instance, my board has message icons for ESPN, CBSSports, etc.  Now that I have the RSS Feeder to automatically pull the articles, it would be awesome if I could automatically assign them the message icons, rather than having to manually do it.

Quote from: Yağız on January 11, 2009, 01:58:58 PM
There is an error with Turkish characters. It shows '?' instead of 'ı', 'İ', 'ğ', 'ş', 'Ş'.

I've fixed this bug... I didn't realize how powerful Magpie is in parsing RSS and returning results.  I added a line that sets the output character set of Magpie to be whatever the forum is, so it now parses your feed properly that you gave as an example...

Quote from: Lamarck on January 12, 2009, 09:50:50 AM
Yes,of course...here is a link:

http://www.20minutos.es/rss (http://www.20minutos.es/rss)

Ah,the problem is not only with "´",the same thing happen with "ñ".

Thanks!.

The above fixed your problem as well.

shanksta13 - message icon selection it is.... :)

Thanks everyone so far for testing and bug reporting and providing ideas for new features.

Wonderful mod I must say, Is there anyway to limit the number of articles?, Or parse some aritcles like specfic topics

The limit is what your board can hold... If you want only certain articles based on keywords, specify those keywords for that feed.

SD, could there be anyway of allowing those with AEVA to embed videos into the posts? As well as images? I have many members who like to post images (screenshots of graphs) in their blog. I also have members who use YouTube and other players to post videos. For the videos, I would think that anyone with AEVE would just need to allow a link to the vid.

Here's a sample (http://www.tiltedblog.com/aggregator/sources/35) with a graph and a player.

The mod is made to strip all html from feeds, not only for security, but also because it isn't needed in the posts.

As for allowing AEVA - I don't know how items are included in posts, but if it is through the use of BBcode, then if the blog utilized bbcode in the description tag, then that would be passed to the feeder and the bbcode would be parsed in the post.

Okay, I've got the feed behaving mostly properly now, however the Mark as Read option still isn't working.  The feed articles are being pulled up properly, but they're showing up as unread.  Any ideas?

Another suggestion.
Can you make an option to post feed as posts in one topic, instead of many topics for one feed.
It's not hard to implement, but more suitable than a tons of topics.

shanksta - All I can think of is a mod is interfering with it.  I have no problems with it on stock installs of Beta4 or RC1.  Can you list the mods you have installed?

digger - I'll entertain that thought... however answer me these questions:
Should the title of the topic be the title of the feed, or that of the first item pulled from the feed
I assume you mean each feed would have it's own topic?  Not all feeds posting to one topic?

Quote from: SlammedDime on January 13, 2009, 08:00:11 PM
shanksta - All I can think of is a mod is interfering with it.  I have no problems with it on stock installs of Beta4 or RC1.  Can you list the mods you have installed?

digger - I'll entertain that thought... however answer me these questions:
Should the title of the topic be the title of the feed, or that of the first item pulled from the feed
I assume you mean each feed would have it's own topic?  Not all feeds posting to one topic?

Haha, probably won't help much, I have a pretty modded up forum.  :D

Mod Name     Version     
1.    RSS Feeder    1.0.0    [ Uninstall ]
2.    Profile Visitors    4.1    [ Uninstall ]
3.    Prettier_Quotes    1.12    [ Uninstall ]
4.    Member Color Link    3.0.5    [ Uninstall ]
5.    Time Logged-In    1.0    [ Uninstall ]
6.    Excellent Smileys    1.0    [ Uninstall ]
7.    vBulletin Style Meta Tags    1.1    [ Uninstall ]
8.    Custom Copyright    1.1    [ Uninstall ]
9.    Users Online Today    1.5.4    [ Uninstall ]
10.    SMF Arcade    2.5 Beta 2.2 Public    [ Uninstall ]
11.    User Control Panel By Alan S    3.0    [ Uninstall ]
12.    Simple Award System    2.0.0.4b    [ Uninstall ]
13.    Show Joined, Location, Username In Topic View    1.0    [ Uninstall ]
14.    SMF Chat - by Joseph Szenasi    1.0    [ Uninstall ]
15.    Advanced Reputation System    1.5.2    [ Uninstall ]
16.    Referrals Mod    2.1.1    [ Uninstall ]
17.    Recent posts user preference    3.04    [ Uninstall ]
18.    Auto Embed Video/Audio Clips    4.0.2    [ Uninstall ]
19.    Ellow green smiley set    1.1.0.1    [ Uninstall ]
20.    Tagging System    2.1    [ Uninstall ]
21.    Pm_Informer    2.0    [ Uninstall ]
22.    Show Local Url Titles    1.1    [ Uninstall ]
23.    Internal_Links_Use_Same_Window    1.2    [ Uninstall ]
24.    YouTube BBCode    2.3    [ Uninstall ]
25.    New In Topic View    1.1    [ Uninstall ]
26.    Last Post On MemberList    1    [ Uninstall ]
27.    Previous and Next Links for Page Index    1.0    [ Uninstall ]
28.    Top 10 Posters Today And This Week Stats    1.1    [ Uninstall ]
29.    New Style Message Icon    1.0    [ Uninstall ]
30.    MessagePreviewOnHover    1.7    [ Uninstall ]
31.    Irritate lurkers with 0 posts    0.1    [ Uninstall ]
32.    Images On Board    1.1    [ Uninstall ]
33.    Colorize Boards    3.0    [ Uninstall ]
34.    Bookmarks    2.2.1    [ Uninstall ]
35.    Birthday on Profile Summary    1.0    [ Uninstall ]
36.    Ad Managment    2.3.4    [ Uninstall ]

Not to mention I'm using an SMF-Joomla Bridge.  Don't worry, I'll try to figure it out on my own, just have to do a little more research on how to make a thread appear "read".

Quote from: SlammedDime on January 13, 2009, 08:00:11 PM
digger - I'll entertain that thought... however answer me these questions:
Should the title of the topic be the title of the feed, or that of the first item pulled from the feed
I assume you mean each feed would have it's own topic?  Not all feeds posting to one topic?

Each feed would have it's own topic.
Title of the topic would be the title of the feed and titles of the posts might be a titles of the rss items.

SD, thank you for your quick responses to us all it very refreshing!

As for AEVA, all you have to do is allow the link to the video to pass through and AEVA automatically turns it into a video. The video I have posted HERE (http://ipostyoupost.com/index.php?topic=15.msg205#msg205) was embeded by me simply posting a link to the video and AEVA did the rest.

Also, if you could allow image URL's through: 1) people could click to see the image, 2) Someone might be able to make a mod which would allow images inline in posts.

Come to think of it, just allowing all URL's through would probably be a good thing. I've seen mention to security, but if the admin is (currently) the one allowing feeds, then they should be selective of their feeds.

Right, but how do I know what is a valid video link??  AEVA does it because of the hundreds of regular expressions that it uses to parse the videos... not sure I'd want to add all of that.

Although, I should ask for clarification... how do you mean, post a link to the video?  is it as simple as typing:

http://www.youtube.com/myvideolinkhere

And AEVA parses it and displays the video?

As for images - I can probably make a regular expression to pull out images and convert them to bbcode.  Shouldn't be hard.

Quote from: SlammedDime on January 13, 2009, 09:11:12 PM
is it as simple as typing:

http://www.youtube.com/myvideolinkhere

And AEVA parses it and displays the video?

Exactly that. If someone post a YouTube URL on a site with AEVA it will automatically become an embeded video. So you would just need to allow the URL through and AEVA will do the rest. This would also allow people to use your mod with any of the (currently) 185 sites that AEVA works with.

BTW: AEVA Mod Link (http://custom.simplemachines.org/mods/index.php?mod=977) if it helps.

ah, no problem then... this doesn't strip any urls... only <a>... </a> tags or any other HTML tags.  If it's just a pure link, it will still be allowed because it's considered plain text as far as this mod is concerned, so no modifications are needed on my part, it should work as it stands now.

As for the images, I can add a regular expression to the part that actually strips out HTML to keep the images... easy fix.

But THIS (http://texasfelt.com/index.php?topic=545.0) doesn't show the video like THIS (http://www.tiltedblog.com/aggregator/sources/6). It's the same feed. Both my sites, one using SMF (obviously) the other with Drupal.

That's because the RSS feed is not just a link to the video... it has the whole <object> tag, which would be parsed out because it is an html tag.

So there would be no way to pull the <object> tag out?

Now that you say that, it reminds me that there is an area of the Drupal aggregate system which allows admins to specify the tags they will allow through. Which I DID have to add <object> to my admin to allow the videos and players. Do you think this could be a possibility with your mod? This would allow admins complete access to tags they feel are OK to be passed through. Below is a screen shot of the Drupal admin screen. Their defaults seem pretty safe...


<a> <b> <br> <dd> <dl> <dt> <em> <i> <li> <ol> <p> <strong> <u> <ul> <img>


However, I guess with SMF, you have to rebuild all of these in order to allow them through to a post?

Quote from: SlammedDime on January 12, 2009, 11:04:09 PM
In the case of moreover.com, I would not use the retrieve full article option.  It will end up posting just the description of the item if the regex isn't matched.  It could possibly be changed to not post anything if the regex isn't matched.

If I were to implement something like that, then your idea of multiple feeds with the same url would probably work okay.

I've tried the multiple feeds method... it works alright but then after awhile I get the 500 Internal server error. Guessed all i have to do it increase the timeout value from 60 to a higher value? If so, any maximum value?

Great mod I have been waiting for this one  :D

Just FYI: anything will parse through Aeva when you call parse_bbc(). Still, it requires links to be autolinked ([ url ] tag).

Quote from: bloodfire on January 14, 2009, 02:14:20 AM

Quote from: SlammedDime on January 12, 2009, 11:04:09 PM
In the case of moreover.com, I would not use the retrieve full article option.  It will end up posting just the description of the item if the regex isn't matched.  It could possibly be changed to not post anything if the regex isn't matched.

If I were to implement something like that, then your idea of multiple feeds with the same url would probably work okay.

I've tried the multiple feeds method... it works alright but then after awhile I get the 500 Internal server error. Guessed all i have to do it increase the timeout value from 60 to a higher value? If so, any maximum value?

For a 500 error, you'll need to check your server error logs to see what caused the error.  If it was a timeout value, that would probably show in the forum error log.

Nao - good to know, thx.

Quote from: SlammedDime on January 13, 2009, 05:28:58 PM

Quote from: Yağız on January 11, 2009, 01:58:58 PM
There is an error with Turkish characters. It shows '?' instead of 'ı', 'İ', 'ğ', 'ş', 'Ş'.

I've fixed this bug... I didn't realize how powerful Magpie is in parsing RSS and returning results.  I added a line that sets the output character set of Magpie to be whatever the forum is, so it now parses your feed properly that you gave as an example...

Thank you. I'm waiting for the new release.

Quote from: SlammedDime on January 13, 2009, 01:13:16 PM
I'm not sure where you came up with those regex's.... For your first one... that has a lot of video feeds... so to extract the text from the video feeds, you'd want to use

~<div id="videoText">.*<\/div>(.*)<\/div>~siU (untested, but should work)

And for the second one

~<p><font class="sb13">(.*)<\/font><\/p>~siU (again, untested, but should work)

That worked perfectly.

Thanks a lot for it SlammedDime.

I have an suggestion.  Is there any way to add tags on the post using vbgamer tags mod.

not sure, i've never looked into the tags mod, not sure how hard it would be to implement... I don't normally try and code to work with other mods, only because if they are ever updated, I don't want to break functionality with my mods.

I've just noticed a few bugs on my live site that I'm testing this on, one due to a bug in SMF, but also revealed why the Mark as Read wasn't working properly and my lack of understanding...

The mark-as-read option only works for the user who the task was run under, be it a guest visiting your site that triggers the tasks, another user, or yourself, because of the createPost function that uses $user_info['id'] instead of $posterInfo['id'].  Regardless though, that still only means that whatever posterId is used will have the mark-as-read option enabled.

Because of that, I'm going to remove that option, as making the topic marked as read for everyone on the board would be exhausting, especially on large boards.

I'll also be filing a bug report on the issue as well for SMF.

I also have another error in my error log regarding an undefined index error for 'description'..

Apply Filter: Only show the error messages of this URL  http://www.ccwlaws.com/forum/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined index: description
Apply Filter: Only show the errors from this file
File: /home/mattzuba/public_html/ccwlaws.com/forum/Sources/ScheduledTasks.php
Line: 1666

Can anyone else confirm or deny that error as well?

Error confirmed... says the one with 550 articles.

SlammedDime, I've encountered the same error... including errors on Subs-Rss.php and subs-post.php

Apply Filter: Only show the error messages of this URL  http://www.bruneimarket.co.cc/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined offset: 1
Apply Filter: Only show the errors from this file
File: /home/bnmart/public_html/Sources/ScheduledTasks.php
Line: 1733


Apply Filter: Only show the error messages of this URL  http://www.bruneimarket.co.cc/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined index: description
Apply Filter: Only show the errors from this file
File: /home/bnmart/public_html/Sources/Subs-Rss.php
Line: 497


[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  utf8 in /home/bnmart/public_html/Sources/Subs-Post.php on line 1272
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  utf8 in /home/bnmart/public_html/Sources/Subs-Post.php on line 1274
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  server in /home/bnmart/public_html/Sources/Subs-Post.php on line 1290
[14-Jan-2009 05:08:29] PHP Warning:  preg_replace() [<a href='function.preg-replace'>function.preg-replace</a>]: Compilation failed: invalid UTF-8 string at offset 8 in /home/bnmart/public_html/Sources/Subs-Post.php on line 1290
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  character_set in /home/bnmart/public_html/Sources/Subs-Post.php on line 1233


14-Jan-2009 20:00:37] PHP Warning:  fsockopen() [<a href='function.fsockopen'>function.fsockopen</a>]: unable to connect to www.theborneopost.com:80 (Connection refused) in /home/bnmart/public_html/Sources/Subs-Rss.php on line 2040
[14-Jan-2009 20:00:59] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/bnmart/public_html/Sources/ScheduledTasks.php:1734) in /home/bnmart/public_html/Sources/ScheduledTasks.php on line 183
[14-Jan-2009 20:00:59] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/bnmart/public_html/Sources/ScheduledTasks.php:1734) in /home/bnmart/public_html/Sources/ScheduledTasks.php on line 184


Sometimes it works fine.... without any errors

Quote from: bloodfire on January 14, 2009, 09:46:03 PM
SlammedDime, I've encountered the same error... including errors on Subs-Rss.php and subs-post.php

Apply Filter: Only show the error messages of this URL  http://www.bruneimarket.co.cc/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined offset: 1
Apply Filter: Only show the errors from this file
File: /home/bnmart/public_html/Sources/ScheduledTasks.php
Line: 1733


Apply Filter: Only show the error messages of this URL  http://www.bruneimarket.co.cc/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined index: description
Apply Filter: Only show the errors from this file
File: /home/bnmart/public_html/Sources/Subs-Rss.php
Line: 497

These two are caused by this mod... although I'm unsure of the first one.  Can you post what line of code you have on that line?

Quote from: bloodfire on January 14, 2009, 09:46:03 PM
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  utf8 in /home/bnmart/public_html/Sources/Subs-Post.php on line 1272
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  utf8 in /home/bnmart/public_html/Sources/Subs-Post.php on line 1274
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  server in /home/bnmart/public_html/Sources/Subs-Post.php on line 1290
[14-Jan-2009 05:08:29] PHP Warning:  preg_replace() [<a href='function.preg-replace'>function.preg-replace</a>]: Compilation failed: invalid UTF-8 string at offset 8 in /home/bnmart/public_html/Sources/Subs-Post.php on line 1290
[14-Jan-2009 05:08:29] PHP Notice:  Undefined index:  character_set in /home/bnmart/public_html/Sources/Subs-Post.php on line 1233

These are not caused by this mod... the function that those error fall in is not called by this mod

Quote from: bloodfire on January 14, 2009, 09:46:03 PM
14-Jan-2009 20:00:37] PHP Warning:  fsockopen() [<a href='function.fsockopen'>function.fsockopen</a>]: unable to connect to www.theborneopost.com:80 (Connection refused) in /home/bnmart/public_html/Sources/Subs-Rss.php on line 2040
[14-Jan-2009 20:00:59] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/bnmart/public_html/Sources/ScheduledTasks.php:1734) in /home/bnmart/public_html/Sources/ScheduledTasks.php on line 183
[14-Jan-2009 20:00:59] PHP Warning:  Cannot modify header information - headers already sent by (output started at /home/bnmart/public_html/Sources/ScheduledTasks.php:1734) in /home/bnmart/public_html/Sources/ScheduledTasks.php on line 184


Sometimes it works fine.... without any errors

The first one caused the second two, but the first one isn't the fault of the mod, but because the php function was not able to connect to the server specified.  I'm not sure they even were caused by the mod, unless you're trying to call a RSS feed from your own site.

ScheduledTasks.php


1731 $matches = array();
1732 preg_match($feed['regex'], $browser->results, $matches);
1733 $body = $matches[1];



14-Jan-2009 20:00:37] PHP Warning:  fsockopen() [<a href='function.fsockopen'>function.fsockopen</a>]: unable to connect to www.theborneopost.com:80 (Connection refused) in /home/bnmart/public_html/Sources/Subs-Rss.php on line 2040

as for this, it stops there everytime, only to this url... this is from bignewsnetwork.com not from my website... however, there are times it works...

Okay good, I thought I was the only one having the "Mark as Read" option.  That sucks though, that feature is the one reason I really liked the mod.  I've decided to pull it from my live site now, because the relevant feeds I was using post rather frequently and I don't want to smother my members.

The Mark as Read option was exactly what I was looking for, something that allowed users to view the articles if they wanted to, but wouldn't interfere with the normal functioning of the forum (i.e. showing up in the unread posts list).

Anyway, good try on the mod.  If you guys ever figure out how to get that Mark as Read option working, this mod would be incredible.  Thanks for all the hard work, I almost thought it would be the one I was looking for.

Good luck on the mod!

There's a way you can achieve the above, but it will not create a new topic per article.

0) You may want to create a new board for this, keep that in mind for step 8.

1) Install Simple Portal
2) DISABLE Simple Portal (Configuration Menu)
3) DISABLE Redirect to Simple Portal
- The above two steps will make you forum look/run as usual
4) Go to: Blocks --> Add Block --> (bottom of page) RSS Feed Block
5) Fill in the pertinent top information
6) For the "Column" drop down select {TOP} or {BOTTOM} You may change this later, I would suggest Top.
7) On the bottom "Display Options" check "Advanced Options"
8 ) Click the "[ +] Select Boards" and select which board of your forum this feed applies to (this is where you may want to create a new board just for this feed)
9) Click "Add Block"

Now go to the board which you assigned this to and you should see all feeds above/below the posts in that board. This is where selecting Top/Bottom will depend if you want comments below the articles or above the articles. Using "Top" above will make it so that members can read the articles, then comment below.

Is this the best method, probably not, but it will list your articles and not effect your board new/no new system.

Quote from: KahneFan on January 15, 2009, 11:19:07 AM
There's a way you can achieve the above, but it will not create a new topic per article.

0) You may want to create a new board for this, keep that in mind for step 8.

1) Install Simple Portal
2) DISABLE Simple Portal (Configuration Menu)
3) DISABLE Redirect to Simple Portal
- The above two steps will make you forum look/run as usual
4) Go to: Blocks --> Add Block --> (bottom of page) RSS Feed Block
5) Fill in the pertinent top information
6) For the "Column" drop down select {TOP} or {BOTTOM} You may change this later, I would suggest Top.
7) On the bottom "Display Options" check "Advanced Options"
8 ) Click the "[ +] Select Boards" and select which board of your forum this feed applies to (this is where you may want to create a new board just for this feed)
9) Click "Add Block"

Now go to the board which you assigned this to and you should see all feeds above/below the posts in that board. This is where selecting Top/Bottom will depend if you want comments below the articles or above the articles. Using "Top" above will make it so that members can read the articles, then comment below.

Is this the best method, probably not, but it will list your articles and not effect your board new/no new system.

Awesome, I had a already created a new board for this RSS Feeder and I haven't deleted it yet, so I very well may do this.  If I do, I'll be sure to let you know and thank you!

shanksta - before I release the next version, I'll take a hard look at how I can make it work.  The only way I think I can do it is to mark the whole board that the news feed is posted to as read, but then if you have one feed you don't want marked as read, but one feed you do, and they post to the same board, then you're SOL.

Quote from: bloodfire on January 15, 2009, 01:37:33 AM
ScheduledTasks.php

Code Select Expand


1731 $matches = array();
1732 preg_match($feed['regex'], $browser->results, $matches);
1733 $body = $matches[1];



14-Jan-2009 20:00:37] PHP Warning:  fsockopen() [<a href='function.fsockopen'>function.fsockopen</a>]: unable to connect to www.theborneopost.com:80 (Connection refused) in /home/bnmart/public_html/Sources/Subs-Rss.php on line 2040

as for this, it stops there everytime, only to this url... this is from bignewsnetwork.com not from my website... however, there are times it works...

Thanks for posting that code, I've corrected the code so an error will no longer be thrown in the first case above.

For the fsockopen error - it simply means fsockopen wasn't able to connect to the specified server, normally because the server denied the request.  Nothing I can really do to work around it except suppress the error, which I've done for the next version.

SD, if you figure out a way to let images/html through, you may want to have a "Settings" page which changes settings for the whole mod. If you added this page, you could place "Mark Feeds As Read" in this area, which would let people know that it is a setting for all feeds. You could then place a small font note below it stating "All feeds and posts on this board will be marked as read" or something of that nature.

Side question: ...will you be allowing images through on the next version?

Yea, I'm still gonna have to ponder on the Mark as Read option.

As for images, yes, I've edited the stripping function to convert image tags to [ img] bbc tags :)

I actually have version 1.1.0 ready to roll out and I've tested the upgrade script to upgrade anyone already running 1.0.0, but I want to further investigate the mark as read option first.

After digging through the SMF code, adding Mark As Read support just isn't feasable, at least not at this point in SMF time.

Think about it this way...

Let's say you have 10000 members and 10 different feeds, and when the scheduled tasks run, you end up importing 50 items, creating 50 new topics... that is an extra 500,000 rows that would need to be added to the log_topics table, 1 row per item per member.

Likewise, if I enabled 'by board' mark as read, if you have 10000 members, that's at least 10000 rows that would need to be updated, or created, assuming all feeds post to the same board.  If each feed posts in a different board, with 10 feeds you'll be updating or creating 100,000 rows in the table.

As you can see, it's just not feasable to do, and I don't think you'll be able to find any mod that can do it.

A suggestion to try would be the ignore board feature.  Allow your members to Ignore Boards, then have your feeds post to boards that your members can ignore, then the new topics and posts won't show up in their Unread Topics list.

As a side note, I've decided to switch from MagPie RSS to SimplePie RSS for the API.  Much more solid, and much more recent (1 month since last version, vs 2+ years with MagPie).  There will be no difference to anyone using the mod.

Quote from: SlammedDime on January 15, 2009, 12:16:53 PM
shanksta - before I release the next version, I'll take a hard look at how I can make it work.  The only way I think I can do it is to mark the whole board that the news feed is posted to as read, but then if you have one feed you don't want marked as read, but one feed you do, and they post to the same board, then you're SOL.

Quote from: bloodfire on January 15, 2009, 01:37:33 AM
ScheduledTasks.php

Code Select Expand


1731 $matches = array();
1732 preg_match($feed['regex'], $browser->results, $matches);
1733 $body = $matches[1];



14-Jan-2009 20:00:37] PHP Warning:  fsockopen() [<a href='function.fsockopen'>function.fsockopen</a>]: unable to connect to www.theborneopost.com:80 (Connection refused) in /home/bnmart/public_html/Sources/Subs-Rss.php on line 2040

as for this, it stops there everytime, only to this url... this is from bignewsnetwork.com not from my website... however, there are times it works...

Thanks for posting that code, I've corrected the code so an error will no longer be thrown in the first case above.

For the fsockopen error - it simply means fsockopen wasn't able to connect to the specified server, normally because the server denied the request.  Nothing I can really do to work around it except suppress the error, which I've done for the next version.

Great... can't wait for the update version.

Yeah... looks like the server denied the request... nothing to do with the script nor the command... most probably the connection to the server...

Another thing I found... since using this mod.... I found core dump files in my server....

core.12437
core.24225
core.9285
core.6443

Does any1 getting these files? At first, I just delete them, ignoring it. Only just now, when I test this mod by 'run now' on the schedule tasks and abt 1 minute or so, the page shows 500 Internal Service page. Then I try to retrieve the error.log using ftp from my server to find wat other errors... my server seems to be timeout as well... then i reconnect and found the core file... however, no error was shown.

If you're trying to use the 'full article option', try disabling it and then try again.  It is possible that you're using an expression that is causing a core dump... if so, you'll need to revise the expression your using

If you get the 500 error and are able to retrieve the log to see what it shows, please post it.  I'd be interested to see where it came from.

Quote from: SlammedDime on January 16, 2009, 12:52:26 AM
If you're trying to use the 'full article option', try disabling it and then try again.  It is possible that you're using an expression that is causing a core dump... if so, you'll need to revise the expression your using

Ohhhh...... Fun memories! lol

I'm not sure if this is a stupid mistake on my part or a genuine error.  I just setup 2.0 beta and have been trying to get this to work, but after i install it and it tries to redirect, i get this error:

Fatal error: Cannot redeclare modifyrssfeedsettings() (previously declared in /home/my2008/public_html/mytestforum/forum/Sources/ManageSettings.php:1982) in /home/my2008/public_html/mytestforum/forum/Sources/ManageSettings.php on line 2700

Any ideas would be greatly appreciated.

Quote from: SlammedDime on January 16, 2009, 12:52:26 AM
If you're trying to use the 'full article option', try disabling it and then try again.  It is possible that you're using an expression that is causing a core dump... if so, you'll need to revise the expression your using

If you get the 500 error and are able to retrieve the log to see what it shows, please post it.  I'd be interested to see where it came from.

I've tried disabling the full article option...still get the 500 error and the dump core... however... if the rss feed is around 30 like moreover.com... it gets all the news but shows the 500 error page but no dump core file... as for 100 rss list like bignewsnetwork.com... gets both but only until certain amount of rss being retrieved...

the expression is ok... at times... it works fine... retrieving all those match them...

Still no error logs or any indications of wat causing the error... :(

http://en.wikipedia.org/wiki/Core_dump

Quote from: Nao 尚 on January 16, 2009, 05:56:46 AM

Quote from: SlammedDime on January 16, 2009, 12:52:26 AM
If you're trying to use the 'full article option', try disabling it and then try again.  It is possible that you're using an expression that is causing a core dump... if so, you'll need to revise the expression your using

Ohhhh...... Fun memories! lol

LOL

Quote from: Drivin and Cryin on January 16, 2009, 08:29:34 AM
I'm not sure if this is a stupid mistake on my part or a genuine error.  I just setup 2.0 beta and have been trying to get this to work, but after i install it and it tries to redirect, i get this error:

Fatal error: Cannot redeclare modifyrssfeedsettings() (previously declared in /home/my2008/public_html/mytestforum/forum/Sources/ManageSettings.php:1982) in /home/my2008/public_html/mytestforum/forum/Sources/ManageSettings.php on line 2700

Any ideas would be greatly appreciated.

That means the mod was installed twice... you'll need to go through and remove the duplicate code by hand.

Quote from: SlammedDime on January 16, 2009, 11:39:23 AM
That means the mod was installed twice... you'll need to go through and remove the duplicate code by hand.

Thanks, i got that sorted out and it's working now.

Maybe this will help someone else out, but i couldn't get it working with the clean blue theme.  For some reason, the setup screen just wouldn't show up.  So when i kept going to the configuration screen|modifications - rss feeder wasn't listed, which is probably why i ended up with it installed twice in the first place.  I switched to the default theme and everything worked fine.

Can you link me to which theme you are using?  This mod doesn't make any theme or template changes except to add information to the modifications.english.php, which only the default theme should have in it's language folder.

You are working hard in this mod,very good job.I'm looking forward the new release.

Mainly because it's a crucial part of my new site I'm launching... lol.

Quote from: SlammedDime on January 16, 2009, 02:22:02 PM
Mainly because it's a crucial part of my new site I'm launching... lol.

Still, thank you for sharing it with us and for the quick responses.

What's your new site? (or did I miss a link?)

No worries....

www.ccwlaws.com

Ah, that's right. I remember seeing that board. Going live next Tuesday (1-20). Looks good.

[/off topic]

Okay, if anyone would be willing, can you give 1.1.0 a shot... I won't post it on the download site quite yet, so for now it'll have to be through my SVN...

[link removed]

Click on 'Tarball' next to the 1.1.0 under Tags and save the file to your desktop.

I would not recommend this for anyone already using 1.0.0 until I have fixed any bugs that may be found in this version, UNLESS you are comfortable in working in the database and able to drop and restore tables without help.  In that case, then you can install the above version and it will upgrade your existing install and update the database tables.  PLEASE take a backup of the rssfeeds and log_rssfeeds tables BEFORE upgrading, incase you do need to revert back to 1.0.0 for any reason.

If you do need to downgrade, uninstall version 1.1.0, then in the 'Browse Mods' section of your Package Manager, delete version 1.0.0, ignoring the error that it may still be installed, yada yada... then install 1.0.0 again, then go into the database drop, then recreate the tables from your backup.

(if you didn't understand all of the above, then you probably shouldn't upgrade just yet)

I have the new version installed in my test board and it seems to work fine.

I found a "bug" or two: 

-Spanish characters appear as "?" in footer and prefix.

-Also,I get this:

QuoteAn Error Has Occurred!
The database value you're trying to insert does not exist: hash

In the scheduled tasks tab if I press "run now" with RSS Feeder option enabled.Despite this error,a new topic from the rss feed is created with no problem.But mod get only one topic from the feed,even If I have set that option to 2 or 3.


I will be testing this more tomorrow,thanks.


P.S: It's a "fresh" installation,not an updated version from 1.0.0 to 1.1.0,if that helps.

The reason for the ? might be because of an incorrect collation on the database table... I'm not sure I can change it with the install of the mod using SMF's functions, but I'll try.  the ? problem will probably go away if you go into mysql to the tables and change their collation to utf-8

As for the hash... I know why that's not working... stupid last minute change, thanks.

Edit: The hash problem is fixed in the download now...

I'm waiting to hear from the dev's on the utf8 table creation issue, but until that point, i've released 1.1.0, it's available for download on the mods download page.

Anyone currently running 1.0.0, just upload this and click the upgrade option and you're existing installation will be upgraded.

I have this on two sites I'm setting up. On 1 site I tried the upgrade and it didn't work, so I tried uninstalling old, installig new... got a few errors on install, but it appeared to go through. After Install I ran it and it uploaded a couple of articles again that it had loaded previously. I will monitor this and my error log. As long as I don't see anymore duplicates I'm OK with it.

On the other board, I fully uninstalled 1.0 and inistalled 1.1 and now I get this message on the RSS Admin page

Quote
Unknown column 'f.icon' in 'field list'
File: /home/content/b/u/d/budaadmin/html/sites/pickaline/Sources/ScheduledTasks.php
Line: 1611

On a side note: It pulls images through PERFECTLY! and I like the date/source additions.

Anymore thought on videos? :P  (what a pain in the @$$ I am :))

if you uninstalled 1.0, it didn't remove the tables from the database, so your old tables are still there.  Try running upgrade.php from the download package and it should upgrade your tables for 1.1.

To verify this before hand, look at the rssfeeds table.  If you're missing an 'icon', or 'id_topic' row, the new structure is not there and upgrade.php should be run.

So far the new update works fine for me by uninstalling the old one and manually delete the database... the only thing is the images are not gathered... is it implemented? I have not fully tested it yet.. but so far getting rss from moreover.com with full article features... works fine and no more dump cores or time out... will try them in full capacity and c how far can it goes...

Good work with the updates...

The only thing that I worked on images with was if they are in the description, or summary, or if they are contained in the full article.  If the feed uses an <img> xml tag, I didn't implement that.  To be honest, I wasn't even thinking about that.  I'll keep it in mind for future versions.

I actually meant when the full article that is to be retrieve has <img>(s) in it not the feed with img tag in xml. :)

Hi.
"Post Items In Single Topic" work perfect! Thanks. And I think no need to show "Source: ... " in every post in this case.
There is one problem with mod. In all posts tag <br> removed, and posts looks not so good.

Another problem.
Posts looks good when i start update task manually.
When it starts automatically Cyrillic characters looks like ?????????

Quote from: bloodfire on January 16, 2009, 12:34:56 AM
Another thing I found... since using this mod.... I found core dump files in my server....

core.12437
core.24225
core.9285
core.6443

Does any1 getting these files? At first, I just delete them, ignoring it. Only just now, when I test this mod by 'run now' on the schedule tasks and abt 1 minute or so, the page shows 500 Internal Service page. Then I try to retrieve the error.log using ftp from my server to find wat other errors... my server seems to be timeout as well... then i reconnect and found the core file... however, no error was shown.

I do have many core dumps, and i have enable full article mode and not upgraded to latest version.

Quote from: A.SK on January 17, 2009, 07:40:54 AM

Quote from: bloodfire on January 16, 2009, 12:34:56 AM
Another thing I found... since using this mod.... I found core dump files in my server....

core.12437
core.24225
core.9285
core.6443

Does any1 getting these files? At first, I just delete them, ignoring it. Only just now, when I test this mod by 'run now' on the schedule tasks and abt 1 minute or so, the page shows 500 Internal Service page. Then I try to retrieve the error.log using ftp from my server to find wat other errors... my server seems to be timeout as well... then i reconnect and found the core file... however, no error was shown.

I do have many core dumps, and i have enable full article mode and not upgraded to latest version.

My advice... Download the updated mod and you won't get the dump core... however, I still get the 500 internal server error... but i guessed the limit this mod can gather the rss feed but then it gathered all the news.. hmmmm... no error shown in the error log...

Quote from: bloodfire on January 17, 2009, 05:13:49 AM
I actually meant when the full article that is to be retrieve has <img>(s) in it not the feed with img tag in xml. :)

Can you give me a specific article that has images that I can use to test?  In my tests it worked okay.

Quote from: digger on January 17, 2009, 06:06:00 AM
Hi.
"Post Items In Single Topic" work perfect! Thanks. And I think no need to show "Source: ... " in every post in this case.
There is one problem with mod. In all posts tag <br> removed, and posts looks not so good.

I thought I had fixed the <br> problem, UNLESS, the site is not using xhtml <br />s... and just using <br>.  I didn't think of that.  I'll try and account for that next version.  As for source in every post, one thing that the API I use is capable of is 'MultiFeeds', which I may implement in the mod, where you can specify multiple feeds that can all post to the same topic.  I'm still learning more about the API and seeing what it can do.

Quote from: digger on January 17, 2009, 07:21:37 AM
Another problem.
Posts looks good when i start update task manually.
When it starts automatically Cyrillic characters looks like ?????????

Does the actual post have ? in it?  Can you link me to a specific article this happens with?

Quote from: A.SK on January 17, 2009, 07:40:54 AM

Quote from: bloodfire on January 16, 2009, 12:34:56 AM
Another thing I found... since using this mod.... I found core dump files in my server....

core.12437
core.24225
core.9285
core.6443

Does any1 getting these files? At first, I just delete them, ignoring it. Only just now, when I test this mod by 'run now' on the schedule tasks and abt 1 minute or so, the page shows 500 Internal Service page. Then I try to retrieve the error.log using ftp from my server to find wat other errors... my server seems to be timeout as well... then i reconnect and found the core file... however, no error was shown.

I do have many core dumps, and i have enable full article mode and not upgraded to latest version.

As said earlier, if you're getting core dumps with this mod, it is normally because of an invalid, or ambiguous regular expression that causes PHP to crash.  I think the latest builds of PCRE are having some issues, I've seen a lot of core dumps lately from PCRE.

Feed URL:
http://www.bt.com.bn/en/front/feed

Regular Expression:
~<h1 class="title">(.*)printer friendly version~siU

Example of the news from the rss website:
http://www.bt.com.bn/en/home_news/2009/01/14/imported_items_may_pose_threat_to_brunei_eco_system

This is what it gathered in my website
http://www.bruneimarket.co.cc/index.php/topic,1617.0.html

Quote from: bloodfire on January 17, 2009, 08:24:18 AM
Feed URL:

Code Select Expand

http://www.bt.com.bn/en/front/feed

Regular Expression:

Code Select Expand

~<h1 class="title">(.*)printer friendly version~siU

Example of the news from the rss website:
http://www.bt.com.bn/en/home_news/2009/01/14/imported_items_may_pose_threat_to_brunei_eco_system

This is what it gathered in my website
http://www.bruneimarket.co.cc/index.php/topic,1617.0.html

There's nothing wrong with the mod..it's getting the img... it's the url of the image in that the original website. The image is working fine.

My bad... I just try to modify the post to try to add the img manually... however... the img is in the post, it's the url of the img... the original url of the website have src of the image without it's full domain... the post is trying to find the img in my website...

In the post
[img]/en/files/images/photos/2009-01-14/13_envir.jpg[/img]

original from the website

<img src="/en/files/images/photos/2009-01-14/13_envir.jpg" alt="" title="" border="0" style="width:200px; height:auto;" />
now the problem is how to get the full url of the image heheehhe...

Quote from: SlammedDime on January 17, 2009, 08:10:37 AM

Quote from: digger on January 17, 2009, 07:21:37 AM
Another problem.
Posts looks good when i start update task manually.
When it starts automatically Cyrillic characters looks like ?????????

Does the actual post have ? in it?  Can you link me to a specific article this happens with?

http://bash.org.ru/rss

Quite odd... So if you run the task manually, the post turns out just fine, but if you let the scheduled task run as it should, then it goes crazy?

I don't know why,but in my forum (not the test site),It still cuts the text with spanish characters.But now,this only happens with post,not in the topic subject.

I uninstalled version 1.0.0 and deleted the data base tables (rss_feeds,log_rss and that colum in scheduled tasks) and then installed version 1.1.0.

It must be something related to the "upgrade",because I have no problems with spanish characters in my test site.I don't know what to do.

Quote from: SlammedDime on January 17, 2009, 12:33:13 PM
Quite odd... So if you run the task manually, the post turns out just fine, but if you let the scheduled task run as it should, then it goes crazy?

yes

I have tested more,and if i let the scheduled task run by itself,I get 1 post of 3 correctly (I have set to 3 posts every time),and the other 2 with the problem in spanish characters.Any ideas?

EDIT:If I run it manually,every post has the problem with the characters  >:(

I'll have to do more testing on that... it's quite odd that sometimes it works, and others it doesn't.  Seems to be a similar problem as digger has....

hmm ok boys...

here is something to think on:

QuoteAuthor : Bryan (IP: 67.177.216.184 , c-67-177-216-184.hsd1.co.comcast.net)
E-mail : [email protected]
URL    : http://www.grandmasterb.com
Whois  : http://ws.arin.net/cgi-bin/whois.pl?queryinput=67.177.216.184
Comment:
This is a Notice of Infringement as authorized in § 512(c) of the U.S. Copyright Law under the Digital Millennium Copyright Act (DMCA).
This article is an unauthorized reproduction of copyrighted material originally found at: GrandmasterB dot com (http://www.grandmasterb.com)
Please remove this article and others originally published by GrandmasterB dot com immediately or we will file an official complaint with the U.S. Copyright Office, FeedBurner and Google, Inc.  Google's response may include removing or disabling access to material claimed to be the subject of infringing activity and/or terminating subscribers.
Thank you,
Bryan Davis

i got this nice notice from this swell guy that called me a "scrapper" wth??  :o

is this going to be a serious issue or?? just wondering..  was using rss feed poster.. so.. i dont know..

I could be wrong, but as long as you reference the original source, shouldn't that be OK... especially if they are OFFERING a feed?

hmm well he is offereing, if anyone wants him.. but he needs to get his web design figured out..

not sure if you want his stuff or not but hey lmao

info is there.

im just wondering, is it or is it not illegal? hmm

and for him to call me a scraper?? gesh.. little sissy boy.. where is my whip??  >:(

As stupid as it is, they are well within their rights to ask you to remove their content.  I don't understand why they would even want RSS feeds if they didn't want a way to get their info out....

Their loss I suppose.

i guess so too slammeddime.. and to be honest, im glad i did remove it..

for someone to be so ignorant of seo, site marketing etc., they should have taken it as a compliment..

least they could have done is drop me a pm or email on it.. the baby boi sent me 5 spams and then had his  lil friend post up a real manly comment too.. hmm..

Smoky strikes again.. lol..  O:)

Those having the character problems, I think I've figured out the problem and why it works manually and why it doesn't normally... I'll have to work on this, as it's slightly complicated and I have to trace existing code and figure it out.

Edit: Okay, for anyone having character set problems, try this...

Open ScheduledTasks.php


// Lets do this....
// First grab all of the enabled feeds...
$request = $smcFunc['db_query']('', '
SELECT f.id_feed, f.id_board, t.id_topic, f.icon, f.feedurl, f.postername, f.id_member, f.keywords, f.getfull, f.regex, f.locked, f.approve, f.singletopic, f.topicprefix, f.footer, f.numbertoimport
FROM {db_prefix}rssfeeds as f
LEFT JOIN {db_prefix}topics as t ON (t.id_topic = f.id_topic)
WHERE enabled = 1',
array()
);



loadEssentialThemeData();
$context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set'];


And see if that fixes the problem when it runs on it's own.

Quote from: SlammedDime on January 18, 2009, 05:21:00 PM
And see if that fixes the problem when it runs on it's own.

Yes, it fixes the problem.

What about <br> tag ?

I have the same problem even with that "patch" >___<.

I'm working on a better way to take care of the <br> issue... I tried just making my own function but I realized there was a bit more to do than what I was trying, so I'm trying to implement an 'end all' solution for any possibilty.

Lamarck - Can you link me to a topic on your board that has the problem??

Quote from: SmokyBlue on January 18, 2009, 05:09:32 AM
i guess so too slammeddime.. and to be honest, im glad i did remove it..

for someone to be so ignorant of seo, site marketing etc., they should have taken it as a compliment..

least they could have done is drop me a pm or email on it.. the baby boi sent me 5 spams and then had his  lil friend post up a real manly comment too.. hmm..

Smoky strikes again.. lol..  O:)

Well, all I can think is unless u just use the normal title, short description and link to them (similar to wat moreover.com is displaying for their free rss feeder), it should be alright and legal but if u're grabbing their full article and post it on your website without their permission regardless you have post a link back to them - they still have the right but debatable.

So, the best solution is ask for their permission for the full article grabbing to your website and post the approval on your website then... no more problem... eheheh this is wat i'll be doing before I launch my website :)

good thinking bloodfire, but that is what i had it set to..

no worries tho, and i hope people do learn from this.. ;)

Yes,for example:

http://silvanost.byethost31.com/foro/index.php?topic=478.0 (http://silvanost.byethost31.com/foro/index.php?topic=478.0)

or

http://silvanost.byethost31.com/foro/index.php?topic=477.0 (http://silvanost.byethost31.com/foro/index.php?topic=477.0)

Something must be wrong with the Regular expression you're trying to use.  It worked just fine for me.  If you turn off the 'retrieve full article' option, does it work fine?

http://dev.ccwlaws.com/forum/index.php?topic=68.0

The regex I used is: ~<div id="cuerpo_noticia">(.*?)</div>~si

Ok,I tested it and without the retrieve full article option,It works.It don't work even with your regex if it's enabled.

Quote from: SlammedDime on January 16, 2009, 01:14:37 PM
Can you link me to which theme you are using?  This mod doesn't make any theme or template changes except to add information to the modifications.english.php, which only the default theme should have in it's language folder.

Sorry for the delay, i'm pretty sure the error was my fault.  I had 1.1.17 installed, and then i upgraded and in the process i forgot to change themes to one that's 2.0 beta 4 friendly.  The theme name was CleanBlue - http://custom.simplemachines.org/themes/index.php?lemma=874

I do have another question.  Is there a limit to the feed length that you can enter?  I've been testing it with ebay rss feeds with an affiliate id, and it strips them out.  When i go back to edit the feed, i notice that it's not all there and i'm guessing there's a character limit to the feed?  Is there any way around this?  Other than that, it's listing them okay, just without an aff id.

If there's a hard limit to the feed length, i may be able to get around this by using a yahoo pipe.  Not sure though, i'm still learning. 

I think I may have limited it to 255 characters to avoid database bloat, but I'll double check when I get home.  Can you post a sample feed that you're using so I have something to test against?

Quote from: SlammedDime on January 19, 2009, 12:32:43 PM
I think I may have limited it to 255 characters to avoid database bloat, but I'll double check when I get home.  Can you post a sample feed that you're using so I have something to test against?

I was editing my post while you were replying.  How's that for customer service eh?  :D

Here's a feed with my aff id removed,  since ebay is touchy about posting this stuff on third party boards.  The feed will be the same except for the affid, and the fact that the returned links are  cgi.ebay.com instead of rover.ebay.com.  Keep in mind though that this feed can be MUCH larger than this sample when doing an advanced search and adding keywords to ignore, add bidding options, location options, buying preferences, bid numbers,  etc, etc, etc. 

For instance, a very basic search for  red corvette -

http://rss.api.ebay.com/ws/rssapi?FeedName=SearchResults&siteId=0&language=en-US&output=RSS20&floc=1&afmp=&sacqy=&sacat=-1&fcl=3&sacqyop=ge&satitle=red+corvette&sacur=0&frpp=50&sabfmts=0&dfsp=32&saprclo=&ftrt=1&ftrv=1&saprchi=&saobfmts=exsif&fss=0&catref=C5&saslc=0&saaff=afepn&from=R6&nojspr=y&saslop=1

If you'd like try a search yourself, you can do an advanced search on ebay and you'll see the form with a large number of options.  Go through that form,  hit search, and then on the results page, if you scroll to the bottom you'll see a tiny rss icon.  Right click on that then copy link location.  That will be the rss feed i'm using.

I know these long urls work well with simple pie, since i use that on another wordpress site to list some auctions.  And i think you mentioned you were using simple pie.

I just started getting this error for some reason...

Board structure corrupt: unable to find parent board

on the forum or in the error log??  :o

When I run it manually from scheduled tasks it gives me that error, which also shows up in the error log after displayed from the run.

If you run 'Find and Repair errors' on your board, does it return anything having to do with your boards?

The error is not caused by the mod, but rather the update functions after a post is created....

"Topic #1104 is in board #9, which is missing."

And when I click "yes" to proceed, it dumps a feed article into a "salvaged board"

I don't have a board #9, and when I check the feed that is attached to the article that is being "salvaged", the feed is assigned to board #11, so I'm not sure why the feeder is trying to post to a board #9 that doesn't exist.

The error is showing up in the error log every two hours, which is when I have the feeder running.

In the database, is the feed's id_board set to 11?

In the modify feed settings page, can you view the HTML source and verify that the board name you're selecting has an id of 11 for that option.

Quote from: SlammedDime on January 20, 2009, 07:54:29 AM
In the database, is the feed's id_board set to 11?

About half of my boards had an ID of 9 for some reason. I've reset them. I'll just chalk it up to 'something happened in my upgrade process' and see what happens. If they reset to 9 for some reason, I'll let you know.

Quote from: SlammedDime on January 20, 2009, 07:54:29 AM
In the modify feed settings page, can you view the HTML source and verify that the board name you're selecting has an id of 11 for that option.


<option value="11" selected="selected">Poker Blogs</option>


UPDATE: After correcting the db "All selected tasks were completed "  :D

;)

I thought I was fine with this mod after I installed it about three days ago, but I just logged in to the site today and found out that "RSS" menu tab has disappeared from the admin section. Although the existing feeds seemed going well in the forum, I was unable to modify the feeds becasue of its buttons were gone.

Then I visited the original mod page and downloaded the latest RSS feeder (rss_feeder_1.1.0.zip). However, as soon as I installed it, I got the error this message while redirecting to admin page:

Unknown column 'f.importcount' in 'field list'
File: /ManageSettings.php
Line: 2406

What am I missing? I have removed and reinstalled it again but still having the same issue.

Please help me.

Thank you.

Your database has not been upgraded from the first version of the mod.  upload Upgrade.php from the mod package to your root smf directory and run it, then delete it, then try again.

I removed it and ran the upgrade.php file. Then I reinstalled it. I don't get the similar text error, but the menu tab and buttons are blank and not clickable.

I don't know how this happened. Please advise me.

(Thank you for the quick response.)

if you are running a custom theme the file edits need to be done to that theme for your info to show..

see where you downloaded the mod from for the edits.. ;)

I use the default theme and it worked fine for afew days and jst found this out today. I have a blank menu tab (for RSS) in Admin section that is not clickable too. If I go to that page manually, the two form buttons (for Edit and Delete) are blank and not working too.

Is this some type of file permission or language file issue?

Thank you.

sounds like the language strings are missing from Modifications.english.php

Hey

very nice mod :D

one question:

http://www.mmo-champion.com/index.php?type=rss;action=.xml;board=2.0;sa=news;

^^

this rss have many links inside - and html block´s - how can i import this with the mod correctly ?!

ths

PS: sorry for my bad english ;)

I can't view the link here at work, so it'll have to wait until I get home, but have you tried importing yet?  What were the results?

you need to take that url you have, and go to:

http://www.feedburner.com

sign up for an account and then run the feed thru the agrevator.. then take that outcome and place it int hte leads for where you are trying to insert into smf.

the feed will show then ;)

Thanks very much for the mod.    I installed the mod on a 2.0 beta 4 site HERE (http://www.randallkehoelaw.com/SMF/index.php) and it doesn't seem to be posting anything. 

Do I just have to wait longer, or am is there something I'm not doing?

This is on a fresh install of 2.0, no mods, no custom theme, no errors either.        Thanks.

By default it runs ever 6 hours... unless you edit the scheduled task to run in shorter increments.

Hi
I just installed RSS Feeder and getting this error when I select from the admin area.

Maintenance / Scheduled Tasks / Run Now (Radio Button selected)

Fatal error: Call to undefined function: hash() in /home/xxxxxx/public_html/art-forum/Sources/ScheduledTasks.php on line 1701

I'm using SMF 2.0 Beta 4

Any ideas how to fix this?

Quote from: SlammedDime on January 22, 2009, 04:47:54 PM
By default it runs ever 6 hours... unless you edit the scheduled task to run in shorter increments.

Sorry, but where do I go to change that?   and thanks for the quick response.

EDIT:  nvm, lol, getting used to smf2.0 myself.

Quote from: Garry1953 on January 22, 2009, 05:46:05 PM
Hi
I just installed RSS Feeder and getting this error when I select from the admin area.

Maintenance / Scheduled Tasks / Run Now (Radio Button selected)

Fatal error: Call to undefined function: hash() in /home/xxxxxx/public_html/art-forum/Sources/ScheduledTasks.php on line 1701

I'm using SMF 2.0 Beta 4

Any ideas how to fix this?

Awesome... I didn't realize that the 'hash' function was only available on PHP 5.1.2+, so I'll have to fix that...

SlammedDime
Thanks.

I'll wait for your next release.

Maybe something to look into for your next version:

If you delete the board that the feeds go to... it deletes the feeds all together as well. For instance, I added about 40 feeds and directed them to a board. In order to easily delete the feeds brought through so I could start over, I deleted the board... which deleted all 40 feeds as well :o

Is there a way so that you can make it so that if the board is deleted the feeds are just disabled or something of that nature? Now I will need to rebuild all 40 feeds :(

The feeds are still in the database.... probably not displayed though... There is no code that would remove the feeds from the database when a board is deleted, but if I do remember correctly, the feeds are only displayed if they have a valid board, because of the SQL query used.

I'll keep in mind some different ways of accounting for deleted boards though... thanks.

That would explain why my feeds were being doubled. I entered them twice since I thought they were gone.

(note to SD in case people mention double posts in future)

My RSS Feed is working well after the reinstallation. Thank you.

I now want to modify it. Please let me know how to take care of these:

- I want to exclude an extra title, time stamp and Source link from the automatic posts. How can I do this?

- There is a large extra space between the top post title and horizontal line. This is actually caused by the SMF but I don't know which file to look at. I use default theme. Is this in css file or php file?


Please help me.

Thank you.

Quote from: bloodfire on January 17, 2009, 07:58:05 AM

Quote from: A.SK on January 17, 2009, 07:40:54 AM

Quote from: bloodfire on January 16, 2009, 12:34:56 AM
Another thing I found... since using this mod.... I found core dump files in my server....

core.12437
core.24225
core.9285
core.6443

Does any1 getting these files? At first, I just delete them, ignoring it. Only just now, when I test this mod by 'run now' on the schedule tasks and abt 1 minute or so, the page shows 500 Internal Service page. Then I try to retrieve the error.log using ftp from my server to find wat other errors... my server seems to be timeout as well... then i reconnect and found the core file... however, no error was shown.

I do have many core dumps, and i have enable full article mode and not upgraded to latest version.

My advice... Download the updated mod and you won't get the dump core... however, I still get the 500 internal server error... but i guessed the limit this mod can gather the rss feed but then it gathered all the news.. hmmmm... no error shown in the error log...

I was not using it for long time, deactivated all the rss i have configured.

After a Month i have 38 core dump files with 40 mb sized file each.

So now i was really worried that could i able to delete them or not.

Any suggestions on it. I have not upgraded this mod as said by bloodfire.

rii - As for modifying how the post is created, you'll have to look in ScheduledTasks.php in the rss_feeder() function at the bottom and modify the $message variable.

As for the CSS issue, I'm not sure on that.  I developed this on RC1 which didn't have that problem.

A.SK - if you're still getting core dumps after disabling the rss feeds, then the problem is not with the mod... Can you delete them?  Yes, no harm in doing that.

Quote from: SlammedDime on February 02, 2009, 04:57:45 AM

A.SK - if you're still getting core dumps after disabling the rss feeds, then the problem is not with the mod... Can you delete them?  Yes, no harm in doing that.

Hi SlammedDime.

I have deleted the core dump files.

And these dumps were created on 16 & 17th Jan during i was using RSS Mod.

those dump files could also come from the server having a memory loss as well..

i'd have your host check his server and see what is said, if you are still having the issue.. ;)

I'm getting a ton of errors in my error log from simplepie.  On the forum, it seems to be working alright, but it's building a huge error log.  Is it because of the feeds i've set up?  I'm using yahoo pipes for some of the feeds  in order to get them to work with your mod.  Maybe that's why?  I'm clueless when it comes to programming.


here's a very small sample of the errors.   


[02-Feb-2009 16:32:03] PHP Strict Standards:  is_a(): Deprecated. Please use the instanceof operator in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 1729
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::get_curl_version() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 7713
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::get_curl_version() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 7725
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::xml_encoding() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 1833
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::change_encoding() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 1852
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::encoding() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 9179
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::encoding() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 9180
[02-Feb-2009 16:32:03] PHP Strict Standards:  is_a(): Deprecated. Please use the instanceof operator in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 8683
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Parse_Date::get() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 3652
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::absolutize_url() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 13699
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::parse_url() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 8779
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::compress_parse_url() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 8837
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::normalize_url() should not be called statically, assuming $this from incompatible context in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 8843
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::percent_encoding_normalization() cannot be called statically in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 9103
[02-Feb-2009 16:32:03] PHP Strict Standards:  Non-static method SimplePie_Misc::percent_encoding_normalization() cannot be called statically in /home/xxxxxxx/public_html/yyyyyyy/forum/Sources/Subs-Rss.php on line 9103



If you have the option of changing php.ini settings, or the error reporting level of PHP, change it to E_ALL, instead of E_STRICT.

I don't have the time or man power to navigate someone else's code and try to fix those errors, and they're not errors that are really worth fixing at this point time.

As for the very first one about is_a being deprecated, it has been undeprecated as of php 5.3, so I don't see a point in adjusting that line of code either, but all of the errors will go away if you adjust your reporting level to E_ALL.

If you have no clue about adjusting the error reporting level, ask your host to adjust it, or you can just ignore them.

Quote from: SlammedDime on February 02, 2009, 08:47:33 PM
If you have the option of changing php.ini settings, or the error reporting level of PHP, change it to E_ALL, instead of E_STRICT.

I don't have the time or man power to navigate someone else's code and try to fix those errors, and they're not errors that are really worth fixing at this point time.

but all of the errors will go away if you adjust your reporting level to E_ALL.

If you have no clue about adjusting the error reporting level, ask your host to adjust it, or you can just ignore them.

I'm not sure how to do it, but i'll figure it out eventually, i just needed a direction to look into.  I normally wouldn't worry about it, but it grows about 10 meg/day.  I'd like to eliminate that.

thanks again.

i install RSS Feed Poster in SMf 1.1.7 and create many rss feed post but not show they post in my forum.
why?

This mod is for 2.0... if you have vb's mod for 1.1.7, you'll need to ask in that topic for support, not here: http://www.simplemachines.org/community/index.php?topic=141776.0

I have tried to use the SMF Feeder at my  SMF 2.0 beta 4 forum. www.voetbaltalk.nl/index.php I always tried to import te RSS file www.tcof.nl/rssn.php. You see it at many forums, but always the oldest post on the site, is the newest one one the forum.

I tried already to change some things in de PHP files. But always I got the same problem. For me it is important that the forum can be online tomorrow. So does someone here have a solution for this problem?

(Sorry for the bad English, I live in Belgium so I do not speak it every day)

I'll look in the SimplePie() code and see if it's possible... i'm not entirely sure that it is without turning the script into a memory hog...

Edit: It is possible to do with existing methods in SimplePie, but I'm not sure I can have a solution for you by tomorrow.  Unfortunately it's not entirely simple, no pun intended.

might want to run that url, www.tcof.nl/rssn.php

thru http://www.feedburner.com  that will set up the rss thread correct for your site..  ;)

Thank for the advice. I removed the unwanted lines from that file.

I use CDATA in XML file to take care of html codes and auto post it to the forum but the word [CDATA [ is also display in the post. Do you know why?

For example - I have this in my xml file:
<description><![ CDATA [ blah blah blah ]]</description>

After it posted, the code CDATA is also displayed like this:
[CDATA [ blah blah blah ]]

The forum is working functioned with other code but I don't know why CDATA is not working for me. The post works fine too.

Please help.

Thank you.

Quote from: SlammedDime on February 02, 2009, 04:57:45 AM
rii - As for modifying how the post is created, you'll have to look in ScheduledTasks.php in the rss_feeder() function at the bottom and modify the $message variable.

As for the CSS issue, I'm not sure on that.  I developed this on RC1 which didn't have that problem....

Can you link to the XML file that your specifically working with?

I have attached it to this message.


Thank you.

You didn't properly close your cdata section...

All you have is ]].  It needs to be ]]>

Quote from: SmokyBlue on February 03, 2009, 08:19:55 PM
might want to run that url, www.tcof.nl/rssn.php

thru http://www.feedburner.com  that will set up the rss thread correct for your site..  ;)

Does feedburner also update my feed automatic like my script does?

@SlammedDine: If I have to change my RSS feed is also ok for me, the RSS feed won't be used for something else than this.

Thank you for the correction. CDATA issue is fixed now.

I have just noticed old feeds issue. I know a few related posts are already in this forum topic. I am also having the similar issue. Where is the old feeds info stored? I am testing news articles to be posted using rss feeder. It worked great but I cannot make any correction to the existing xml file. It will not update and still post the same info. It is strange. I deleted xml file, removed feed from admin, and also double checked it in sql db (smf_rssfeeds). They'd be successfully removed but only the old deleted info are posted again as soon as I clicked on the Schedule Tasks link. Do I have to remove something else from the smf_log_rssfeeds table too? If so, how to find the right one from the log table? I don't know why I have to create totally a new xml file (with new name) each time to see the correction. Is there anywhere else like cache or something that I need to turn on/off?

Thank you again.

Quote from: SlammedDime on February 04, 2009, 04:55:08 AM
You didn't properly close your cdata section...

All you have is ]].  It needs to be ]]>

Quote from: Rbbn39 on February 04, 2009, 08:18:46 AM

Quote from: SmokyBlue on February 03, 2009, 08:19:55 PM
might want to run that url, www.tcof.nl/rssn.php

thru http://www.feedburner.com  that will set up the rss thread correct for your site..  ;)

Does feedburner also update my feed automatic like my script does?

@SlammedDine: If I have to change my RSS feed is also ok for me, the RSS feed won't be used for something else than this.

Quote from: Rbbn39 on February 04, 2009, 08:18:46 AM

Quote from: SmokyBlue on February 03, 2009, 08:19:55 PM
might want to run that url, www.tcof.nl/rssn.php

thru http://www.feedburner.com  that will set up the rss thread correct for your site..  ;)

Does feedburner also update my feed automatic like my script does?

@SlammedDine: If I have to change my RSS feed is also ok for me, the RSS feed won't be used for something else than this.

feedburner is a "agrivator" meaning it translates the url into something the mod can use..

[offtopic]
im not sure if slammeddime's mod is like vbgamers, but on the old one, if you had a feed that was slow etc., it could and would hang the feeds up.. im presuming that since he is using snoopy and not magpie, the kinks are worked out..
[/offtopic]

you should not have to worry about yhour feeds, unless the site you are linking to has no new ones.. feedburner will send the info on to you..  ;)

Quote from: rii on February 04, 2009, 01:12:11 PM
Thank you for the correction. CDATA issue is fixed now.

I have just noticed old feeds issue. I know a few related posts are already in this forum topic. I am also having the similar issue. Where is the old feeds info stored? I am testing news articles to be posted using rss feeder. It worked great but I cannot make any correction to the existing xml file. It will not update and still post the same info. It is strange. I deleted xml file, removed feed from admin, and also double checked it in sql db (smf_rssfeeds). They'd be successfully removed but only the old deleted info are posted again as soon as I clicked on the Schedule Tasks link. Do I have to remove something else from the smf_log_rssfeeds table too? If so, how to find the right one from the log table? I don't know why I have to create totally a new xml file (with new name) each time to see the correction. Is there anywhere else like cache or something that I need to turn on/off?

Thank you again.

to clear your cache, if you are on the beta: admin>maintaincea>routine

The feed is in deed cached in your cache folder... this is done to prevent overloading of servers.  What are you testing that you need to keep trying to import the same feed over and over to test?

Hi, first of all i loved this mod when i had it working :S

Unfortunately i seem to have broken it and im unable to find a solution to fix it...

Quote from: KahneFan on January 20, 2009, 05:29:02 AM
"Topic #1104 is in board #9, which is missing."

And when I click "yes" to proceed, it dumps a feed article into a "salvaged board"

I don't have a board #9, and when I check the feed that is attached to the article that is being "salvaged", the feed is assigned to board #11, so I'm not sure why the feeder is trying to post to a board #9 that doesn't exist.

I too have this error except it is sending it to id_ board 3 ( which i no longer have) when i need it to go to id_board 4.

Quote from: KahneFan on January 20, 2009, 11:03:22 AM

Quote from: SlammedDime on January 20, 2009, 07:54:29 AM
In the database, is the feed's id_board set to 11?

About half of my boards had an ID of 9 for some reason. I've reset them. I'll just chalk it up to 'something happened in my upgrade process' and see what happens. If they reset to 9 for some reason, I'll let you know.

Quote from: SlammedDime on January 20, 2009, 07:54:29 AM
In the modify feed settings page, can you view the HTML source and verify that the board name you're selecting has an id of 11 for that option.

Code Select Expand


<option value="11" selected="selected">Poker Blogs</option>


UPDATE: After correcting the db "All selected tasks were completed "  :D

Please tell me in simple terms how you edited the id_board numbers?

You'll have to go into the database and make the change manually for that feed in the rssfeeds table.

Thanks for the quick reply

This is all new to me but how do i do what you just said?

Where is the database, is it a file?

Thanks in advance

If you can wait a couple of hours, I'll release a new version that will take care of this... :)

wow... Thanks

:D

Just a glimpse of fixes...

! 'Source' used HTML instead of BBCode for URL... doesn't work right if poster is non-admin (ScheduledTasks.php)
! Charset wasn't read properly (ScheduledTasks.php)
! Show feed even if it's board doesn't exist (ManageSettings.php)
! Feeds were being returned newest to oldest, instead of oldest to newest (Subs-Rss.php)
! Took into account <br> as well as <br /> in feeds

Ok, I've updated it to 1.1.1... hopefully I've covered the bugs found.... and didn't make any more

Hi,

Would it be possible to change the topic subject to display the "guid" instead of the "title" of the feed? And how could I change this? Thanks!

I had to change the file name while I was working on CDATA correction as the code correction was not reflected.

I also would like to know if is possible NOT to strip the html in RSS post. the admin will be the only user who will use it. At this moment I am having trouble with it like:

I am having the similar issue.

I design the html messages and importing them automatically to the forum as Posts using the this mod with my own xml file. 

I use CDATA and html tag like this in the description field of my xml file:

<![CDATA[ [ h t m l ] here is the <font color=#00FF00>regular</font> html <b>coded</b> message[ h t m l ]  ]]>

It only posted the message like just normal text in one paragraph. Html designs are gone.

If I manually post the same message using the same [ h t m l ] code above, it work just fine as I designed.

(I put extra space in html portion in order to show it to you here)

Please look into this and advise me.


Thank you.

Quote from: SlammedDime on February 05, 2009, 10:50:22 AM
The feed is in deed cached in your cache folder... this is done to prevent overloading of servers.  What are you testing that you need to keep trying to import the same feed over and over to test?

teunel - It would be possible, you'll have to make the change in ScheduledTasks.php where the $subject variable is set near the bottom.  If there is no guid, it will return the item title instead.
$title = striphtml($item->get_title());

$title = $item->get_id();


rii - Because most people using this mod are retrieving their data from outside sources, I purposely strip all html tags from the contents of the feed... the last thing I want is to introduce a XSS vulnerability to anyone's board due to a feed they don't have control over.  I also will not introduce an option to turn this off.

If you wish to do this in the code manually, you can make the following change:
// We're all set to finally create the post
// Strip out all of the tags so it's just text with new lines and line breaks
$body = striphtml($body);
$title = striphtml($item->get_title());
$feed_title = $rss_data->get_title() !== null ? striphtml($rss_data->get_title()) : '';


// We're all set to finally create the post
// Strip out all of the tags so it's just text with new lines and line breaks
$body = $body;
$title = $item->get_title();
$feed_title = $rss_data->get_title() !== null ? $rss_data->get_title() : '';


Thank you for your help. It now does as I wanted.

I have to import lots of messages from my old (very old) forum which use the different formatted database so I found yours as a better bridge so far. You are very supportive and your mod is flexibly useful. Response is the most important task to keep discussion alive, and you ruled it. You are getting the positive feedbacks from every user.

I have security concern with the html code now. I currently use rss feed only under Admin login. Do I need to worry about the security hacks because most of my imported posts have html codes (i.e.: <, >, /, &), but I actually have full control over the xml file?


Thank you.

The feed does not clean anything fed into the database, so if the feeds are only posted as an admin using the  bbcode, I don't think you'll have any problems.

Yea, sorry, I forgot the find and replace attributes on the code tags.

Already found it, it works! Thanks! :D

Sorry if this has been covered but I am able to import the full article without any problems, except one; when ever there is a "£" symbol the text stops.

http://newsrss.bbc.co.uk/rss/sportonline_uk_edition/football/gossip_and_transfers/rss.xml

thats the feed I'm using so if I take this post for example:

http://news.bbc.co.uk/sport1/hi/football/gossip_and_transfers/7878186.stm

where it says "AC Milan general manager Adriano Galliani admits their offer for David Beckham is way off what LA Galaxy want - the Americans are believed to value the midfielder at £15m. (Daily Mirror)"

I don't get that in the thread, I get "AC Milan general manager Adriano Galliani admits their offer for David Beckham is way off what LA Galaxy want - the Americans are believed to value the midfielder at"

It stops at the "£" and doesn't post anything else below it from the page, it does this for every story it imported which contains a "£" symbol, is there any way I can fix this? if it matters, the regular expression I am using is:

~<div class="mxb">(.*)<h3>Bookmark with:<\/h3>~siU

thanks, I love this mod, it's the main reason I am converting to SMF  :D

I'm in love with smf 2.0 now, because of your GREAT addon ! But I cannot get it work. No post was made by RSS Feeder. I've set things up since 1 hour ago.

http://img.xgaming.in.th/pub/rss-feeder.png

Is there any solution or requirement to get RSS Feeder woking on? thanks.........

Quote from: Dark-Master on February 09, 2009, 06:45:48 AM
I'm in love with smf 2.0 now, because of your GREAT addon ! But I cannot get it work. No post was made by RSS Feeder. I've set things up since 1 hour ago.

http://img.xgaming.in.th/pub/rss-feeder.png

Is there any solution or requirement to get RSS Feeder woking on? thanks.........

I'm not sure how these boards work, whether only the person who created the code is meant to offer support, but have you gone to maintenance >> scheduled tasks in the admin area? you have to setup the time and frequency RSS feeder runs, there is also a 'run now' option to test it.

Quote from: Jimi1810 on February 09, 2009, 07:22:56 AM

Quote from: Dark-Master on February 09, 2009, 06:45:48 AM
I'm in love with smf 2.0 now, because of your GREAT addon ! But I cannot get it work. No post was made by RSS Feeder. I've set things up since 1 hour ago.

http://img.xgaming.in.th/pub/rss-feeder.png

Is there any solution or requirement to get RSS Feeder woking on? thanks.........

I'm not sure how these boards work, whether only the person who created the code is meant to offer support, but have you gone to maintenance >> scheduled tasks in the admin area? you have to setup the time and frequency RSS feeder runs, there is also a 'run now' option to test it.

Big thanks to you, it works now. :D

thanks Jimi..

if you have noticed, slameddime is keeping up with the rss mod.. and doing very well.. takes a bit of reading for the mod.. but im sure you guys can do.. and glad you helped him out..

cheers ;)

Thanks for the help Jimi... anyone is welcome to help with support... helps me out for sure. :)  As for your issue, I'll look at it when I get home from work... thanks for posting the feed to look at.

Okay no problem, and thanks I would appreciate that  :)

Hello, I still don't understand about regex....if I want to get a full article from some website. What do I need to check on the webpage about regex?

Could you please give me some example. Sorry to ask this kind of favor, but I'm really new to regex. :D

ex:
http://www.gotfrag.com/cs/story/43829/
http://www.gotfrag.com/cs/story/43826/

Hi,

Great mod!
I do have one issue do:
Alltough the task is sheduled to run every 2 minutes, it doesn't import the feed right away, only after a long time. A local installed program 'feedreader' fetches the feed almost instantly, so the error is not in the feed.

Is there any delay for fetching? Is there some string I can change?

Scheduled tasks run based on visits to your forum.... if you get one hit to your site every 5 minutes... or maybe even every 10 minutes because you do not have a busy site, the scheduled task will run every 5 or 10 minutes, if you have it set to less than that.  If you have a busy site, or one that gets a lot of hits every minute, then the scheduled task will run every 2 minutes.  It's just the nature of how SMF's scheduled tasks run.

The tasklog says that the job is executed several times:
RSS Feeder  Vandaag om 09:25:18  0 seconden
RSS Feeder Vandaag om 09:23:18 0 seconden
RSS Feeder Vandaag om 09:21:12 0 seconden
RSS Feeder Vandaag om 09:20:07 0 seconden
RSS Feeder Vandaag om 09:17:56 0 seconden
RSS Feeder Vandaag om 09:15:50 0 seconden
RSS Feeder Vandaag om 09:13:32 0 seconden

while there are 2 feeds who have been fetched after more than one hour:
http://forum.cindyenguy.be/index.php/topic,2675.msg132982.html#msg132982
http://forum.cindyenguy.be/index.php/topic,2675.msg132986.html#msg132986

Why is the feed not fetched earlier?

Another one:
feed created at 12:35 imported in SMF at 13:25 while the task has run several times:

RSS Feeder  Vandaag om 13:27:56  0 seconden
RSS Feeder Vandaag om 13:25:51 0 seconden
RSS Feeder Vandaag om 13:23:14 0 seconden
RSS Feeder Vandaag om 13:21:12 0 seconden
RSS Feeder Vandaag om 13:20:04 0 seconden
RSS Feeder Vandaag om 13:17:56 0 seconden
RSS Feeder Vandaag om 13:15:47 0 seconden
RSS Feeder Vandaag om 13:13:42 0 seconden
RSS Feeder Vandaag om 13:11:29 0 seconden
RSS Feeder Vandaag om 13:09:21 0 seconden
RSS Feeder Vandaag om 13:07:14 0 seconden
RSS Feeder Vandaag om 13:05:08 0 seconden
RSS Feeder Vandaag om 13:04:01 0 seconden
RSS Feeder Vandaag om 13:01:50 0 seconden
Goedkeuringsnotificaties Vandaag om 13:01:24 0 seconden
RSS Feeder Vandaag om 12:59:34 0 seconden
RSS Feeder Vandaag om 12:58:30 0 seconden
RSS Feeder Vandaag om 12:55:38 0 seconden
RSS Feeder Vandaag om 12:53:17 0 seconden
RSS Feeder Vandaag om 12:51:15 0 seconden
RSS Feeder Vandaag om 12:50:06 0 seconden
RSS Feeder Vandaag om 12:47:48 0 seconden
RSS Feeder Vandaag om 12:45:47 0 seconden
RSS Feeder Vandaag om 12:44:26 0 seconden
RSS Feeder Vandaag om 12:41:54 0 seconden
RSS Feeder Vandaag om 12:39:31 0 seconden
RSS Feeder Vandaag om 12:38:18 0 seconden
RSS Feeder Vandaag om 12:35:58 0 seconden
RSS Feeder Vandaag om 12:33:48 0 seconden
RSS Feeder Vandaag om 12:31:46 0 seconden

What do you have set for the number of items to import each time the feed runs?

0 = all

any ideas?

Any errors in the forum error log related to the mod?

Nope, none at all.

Does the mod remembers when he last fetched an feed?
Is there any setting for the frequency of fetching other than the sheduled task?

It keeps track of when a feed was last fetched, but it isn't used for anything at this point.  It does, however, cache feeds for 2 hours, so if the feed changes that rapidly, it may not update.  It trys to use 'Smart Caching' to where it will detect if the feed has changed or not, but that is assuming that the feed is set to send the proper headers.  When I get home from work, I'll post some code you can use to disable the caching to see if that helps.

OK, thank you!

tried to install on fresh 2.0 RC1 install and get the following screen. (see image)

If you tried clicking the 'Install Now' link from the Package browser in SMF, there is a bug in that.  You'll need to download the mod from the mods page here and then upload it to your site from the 'Download Packages' screen in your admin panel.

That is what I did downloaded to my local pc then went in to my admin and ulpoaded from my pc to server then the error came up?

Could be a software firewall on your computer causing an issue... open the file up on your local pc (you'll need something like 7 zip or Winrar) and make sure the files are there.  I just tested downloading from the mod site then uploading and it worked fine for me.


Guy - Open up ScheduledTasks.php and find the following:

      $rss_data->set_cache_location($cachedir);
      $rss_data->set_cache_duration(60*60*2); // 2 hours

and add this AFTER that.

      $rss_data->enable_cache(false);

This is the first mod that this has happened to so I am not sure about it being a firewall issue, however as you have asked I opened the file and winzip asked to decompress it to a temp folder and  inside the rss_feeder_1.1.1.tar.gz file was the following.(image)

Can I suggest that you make a zip version please and see if its my server thats causing the issue?

Ok I solved this issue by extracting all the files to my local PC then making a .ZIP file and uploading that.

Quote from: Jimi1810 on February 09, 2009, 04:56:19 AM
Sorry if this has been covered but I am able to import the full article without any problems, except one; when ever there is a "£" symbol the text stops.

http://newsrss.bbc.co.uk/rss/sportonline_uk_edition/football/gossip_and_transfers/rss.xml

thats the feed I'm using so if I take this post for example:

http://news.bbc.co.uk/sport1/hi/football/gossip_and_transfers/7878186.stm

where it says "AC Milan general manager Adriano Galliani admits their offer for David Beckham is way off what LA Galaxy want - the Americans are believed to value the midfielder at £15m. (Daily Mirror)"

I don't get that in the thread, I get "AC Milan general manager Adriano Galliani admits their offer for David Beckham is way off what LA Galaxy want - the Americans are believed to value the midfielder at"

It stops at the "£" and doesn't post anything else below it from the page, it does this for every story it imported which contains a "£" symbol, is there any way I can fix this? if it matters, the regular expression I am using is:

Code Select Expand

~<div class="mxb">(.*)<h3>Bookmark with:<\/h3>~siU

thanks, I love this mod, it's the main reason I am converting to SMF  :D

Sorry don't mean to be a pain SlammedDime, but have you had a chance to check this out at all?

Jimi- I've started looking into it... it looks like the regex is okay, so simple pie is doing it's job, it must be something with the code I wrote, i'll have to dig through it a bit more.

Thanks again, I appreciate your help :)

I would like to limit the length of the post titles. I have some article items with very long names. I just want them to be shown up about 20 characters only.

Please help me.


Thank you.

is this limited to 1 page of feeds? i have filled 1 page and cannot add anymore feeds? any ideas/suggestions

rii - you'll have to modify the relevant code in ScheduledTasks.php, search for $subject =


MrSandman - What happens when you try to add another one?  Does it just not show up?  It should show multiple page selections at the top.
Edit, I found the problem, damn...  I'll release a new version in the next day or two to solve the issue.
If you want to fix it yourself for the time being (you'll have to reverse the change to upgrade or uninstall)
Open ManageSettings.php
list($numFeeds) = $smcFunc['db_fetch_row'];

list($numFeeds) = $smcFunc['db_fetch_row']($request);


Quote from: SlammedDime on February 14, 2009, 02:43:16 PM

Edit, I found the problem, damn...  I'll release a new version in the next day or two to solve the issue.
If you want to fix it yourself for the time being (you'll have to reverse the change to upgrade or uninstall)
Open ManageSettings.php

Code (Find) Select Expand

list($numFeeds) = $smcFunc['db_fetch_row'];


Code (Replace) Select Expand

list($numFeeds) = $smcFunc['db_fetch_row']($request);


thanks. great mod by the way

@poster pls how do i add it to my forum smf 1.1.8 step by step manual pls

Quote from: MrSandman on February 14, 2009, 02:59:04 PM

Quote from: SlammedDime on February 14, 2009, 02:43:16 PM

Edit, I found the problem, damn...  I'll release a new version in the next day or two to solve the issue.
If you want to fix it yourself for the time being (you'll have to reverse the change to upgrade or uninstall)
Open ManageSettings.php

Code (Find) Select Expand

list($numFeeds) = $smcFunc['db_fetch_row'];


Code (Replace) Select Expand

list($numFeeds) = $smcFunc['db_fetch_row']($request);


thanks. great mod by the way

I made the change and am still only allowed 40 feeds. it does show "The feed was created successfully "
but then the feed is not listed. still only have 1 page of 40 feeds.

never mind. its working fine now. i forgot to save my changes. LOL

thanks again

Quote from: derby on February 14, 2009, 04:26:53 PM
@poster pls how do i add it to my forum smf 1.1.8 step by step manual pls

Upgrade to SMF 2.0.

This does not support 1.1.8, nor will it ever.  Sorry.

Thank you for the response. I tried it like this in ScheduledTasks.php file. No error but not happening yet. The inserted lines are between //Test subject/title length comments.



// Might have to update the subject for the single topic people

$subject = (!empty($feed['topic_prefix']) ? $feed['topic_prefix'] . ' ' : '') . (!empty($feed['single_topic']) && empty($feed['topic_id']) && !empty($feed_title) ? $feed_title : $title);

//start Test subject/title length
$lengthnew=20;
$subjectnew= substr($subject, 0, $lengthnew);
//end Test subject/title length

// Create the message/topic/poster options and insert the topic on the board
$msgOptions = array(
'subject' => $subjectnew,
'body' => $message,
'approved' => !$feed['require_approval'],
'smileys_enabled' => false,
'icon' => $feed['icon'],
);

Can you look into this one?

Thanks.

I don't see an issue with it... not sure why it wouldn't be working.  Is it still posting the regular length subject?

Yes. It works on the forum subject only but not on RSS block. Can you please test it on yours?

Thanks.

It works like it should for me.  Are you sure you saved your changes to the file?

Quote from: SlammedDime on February 14, 2009, 06:26:00 PM

Quote from: derby on February 14, 2009, 04:26:53 PM
@poster pls how do i add it to my forum smf 1.1.8 step by step manual pls

Upgrade to SMF 2.0.

This does not support 1.1.8, nor will it ever.  Sorry.

just wondering but why not?

Quote from: CL0WNER on February 14, 2009, 10:21:29 PM

Quote from: SlammedDime on February 14, 2009, 06:26:00 PM

Quote from: derby on February 14, 2009, 04:26:53 PM
@poster pls how do i add it to my forum smf 1.1.8 step by step manual pls

Upgrade to SMF 2.0.

This does not support 1.1.8, nor will it ever.  Sorry.

just wondering but why not?

It would be far too difficult to backport and would require a lot of recoding and I don't have the time for it, nor do I plan on running any new sites of my own on the 1.1 line of SMF.  I don't normally do mods because other's need them, I do them because I need the functionality for one of my sites, so I choose to release my work because I know others will probably benefit from it.  It also uses a lot of 2.0 specific functions to perform tasks, so I would have to rewrite it to manually support what 2.0 does for me.  Not to mention the scheduled tasks portion.  And vbgamer wrote a similar mod to this for the 1.1 series, although he is no longer supporting it.

Any solution yet for http://www.simplemachines.org/community/index.php?topic=285356.msg1926488#msg1926488 ?

Quote from: SlammedDime on February 12, 2009, 01:06:45 PM
Could be a software firewall on your computer causing an issue... open the file up on your local pc (you'll need something like 7 zip or Winrar) and make sure the files are there.  I just tested downloading from the mod site then uploading and it worked fine for me.


Guy - Open up ScheduledTasks.php and find the following:

      $rss_data->set_cache_location($cachedir);
      $rss_data->set_cache_duration(60*60*2); // 2 hours

and add this AFTER that.

      $rss_data->enable_cache(false);

Oops, guess I haven't seen that post. Sorry.

Doesn't do it. The posts are still not imported right away.
I allready had disabled cache werever I could in Sub-Rss.php and changed times from 3600 to 300 seconds.

Any other ideas?

I tried with 2 diferent feeds and im getting similar error in both.
Feeds urls are:
http://www.noticiasdot.com/feed/
http://www.kriptopolis.org/rss
and the errors shown on logs are

Apply Filter: Only show the errors with the same message
RSS Feeder: http://www.noticiasdot.com/feed/ (cURL error 28: connect() timed out!)

Apply Filter: Only show the errors with the same message
RSS Feeder: http://www.kriptopolis.org/rss (cURL error 6: name lookup timed out)

I tried them by running the shedule task and waiting it for running auto. Any clue?

I can't do anything about those errors chifliiiii - I more or less allowed them to be thrown so users could see what is wrong with the feed.  It has nothing to do with the mod.  I'd suggest doing a google search for those cURL errors for more information on what they mean.  I would only guess that on the first one, the feed took too long to respond, so it timed out.  The second one looks like it couldn't lookup the hostname properly, which would lead to a bad DNS configuration of your host.

Guy - I'm not really sure then why it's not working.  I've never had an issue with a feed not posting every 2 minutes on a scheduled task like it should.  The only thing I can think of is that the script is timing out after 300 seconds and only importing so many, but then you'd see php errors related to that. Sorry, I'm not really sure where to go on that.

It works! Thanks!

The problem was that I didn't add

Quoteand add this AFTER that.

      $rss_data->enable_cache(false);

because that line was above it.
Since I moved that line under the others it works great!

Maybe it would be a good option to set cache expiry and feed interval in the feed settings.

SlammedDime, maybe you can help me with this.  How do I add a feed?  I have spent the last 30 minutes trying to find the area :(
Thanks

You should have automagically been redirected to the admin interface after installing, unless you clicked elsewhere.

It's under Configuration > Modifications > RSS Feeder

Quote from: SlammedDime on January 13, 2009, 01:13:16 PM
I'm not sure where you came up with those regex's.... For your first one... that has a lot of video feeds... so to extract the text from the video feeds, you'd want to use

~<div id="videoText">.*<\/div>(.*)<\/div>~siU (untested, but should work)

And for the second one

~<p><font class="sb13">(.*)<\/font><\/p>~siU (again, untested, but should work)

Great Mod SlammedDime... Works like a charm straight out of the box on www.f-1chat.com ... using over 20+ RSS Feeds (with specifics) and does a steller job... thanks!

That said, I too am wanting to pull the full article if possible - I've been researching PCRE - and since I'm not the best coder in the world - am truly lost as to proper syntax -

Is there a PCRE guide for dummies out there?? I've searched the SMF boards and google  - and lots and lots of code out there... just nothing that says "do this, to get that" kind of thing -

Sorry to ask such a stupid Q - but am new to this... and trying to wrap my brain around it all (PCRE) - any resources you can point me to?

Thanks -

KB

PS: Well that didn't link to the forum I wanted it to ... so let me offer another example -

This is a RSS Feed with a photo attached http://f-1chat.com/forum/index.php/topic,214.0.html
and as you can see, the article got cut...

So, if I'm looking for the PCRE "code" to be able to show all that bit -- hope that clarifies... TIA

Well let me say this is one great mod and well done on this one. Not sure if this would be at all possible to add as a feature but how about the ability for members to ignore post made by the feeder if they want to. Something in their profile like an ignore RSS feeds

PCRE anyone? *bump*

I'm currently at a meeting with other SMF teamies and only have a 56K connection to work with, so unfortunately I can't do much until I get home Saturday afternoon.

Quote from: SlammedDime on February 27, 2009, 02:53:55 AM
I'm currently at a meeting with other SMF teamies and only have a 56K connection to work with, so unfortunately I can't do much until I get home Saturday afternoon.

No problemo - just wanted to see if anyone was still at home :P

We'll pick it up SAT if you're free...

Thanks -!

KB

is working. thx. I just dont know how to pull the entire blog feed from blogger.

Ok... the phrase 'not working', or 'not importing' doesn't give any detail... any errors in your error log?  That feed takes quite a while to load... it may not work with the mod... PHP will only run for so long before timing out, so I have to set a delay that if the feed doesn't return anything fast enough, it times out.

Killer-B - did you see the link in the first post of this topic that links to another post in this same topic on how I came up with, or come up with the regex to use?  Your particular feed might prove difficult because of all of the extra stuff at the top of the article, like the pictures and captions.

I guess is working now. i forgot the schedule  :-X

http://www.ipergames.com/forum/index.php/topic,681.0.html


but... i cannot make links for download to be clickable. i enabled html for posts but seems that i cannot make to click on download.

question please:

anyone know how to pull entire feeds from a blog from blogger ?

http://pes-patch.blogspot.com/feeds/posts/default?alt=rss     

feeds/posts/default?alt=rss      get only the last ones... from the day ?

Quote from: SlammedDime on March 01, 2009, 02:44:02 PM

Killer-B - did you see the link in the first post of this topic that links to another post in this same topic on how I came up with, or come up with the regex to use?  Your particular feed might prove difficult because of all of the extra stuff at the top of the article, like the pictures and captions.

I read the first 4 pages... then honestly skipped to the end, as there was no discussion about it (not on "search" for PCRE) - but will look more... as I do not know about REGEX either...

I'll understand if it doesn't pull all the data per the example I gave - but I'd like to at least learn the proper syntax and give it a try....

Thanks for the response -

KB

Quote from: nikku on March 01, 2009, 03:03:31 PM
I guess is working now. i forgot the schedule  :-X

http://www.ipergames.com/forum/index.php/topic,681.0.html


but... i cannot make links for download to be clickable. i enabled html for posts but seems that i cannot make to click on download.

question please:

anyone know how to pull entire feeds from a blog from blogger ?

http://pes-patch.blogspot.com/feeds/posts/default?alt=rss    

feeds/posts/default?alt=rss      get only the last ones... from the day ?

Nikku,

May I ask how you were able to get the designer theme to stretch out so wide? I wanted to use that theme, but was too narrow with the portal.... if I could get it out like 800-900 px - that'd be awesome - Let me know will ya?

Thanks -

KB

Quote from: nikku on March 01, 2009, 03:03:31 PM
I guess is working now. i forgot the schedule  :-X

http://www.ipergames.com/forum/index.php/topic,681.0.html


but... i cannot make links for download to be clickable. i enabled html for posts but seems that i cannot make to click on download.

question please:

anyone know how to pull entire feeds from a blog from blogger ?

http://pes-patch.blogspot.com/feeds/posts/default?alt=rss    

feeds/posts/default?alt=rss      get only the last ones... from the day ?

it won't be possible to make them clickable at this point in time.  I may look at using SMF 2's html_to_bbc function in the next release, depending on how well it will work.

i searched my bookmark for the answer i couldnt find it  now... >:( ... where is the theme. go to forum and browse it. there is the answer or just ask a topic. is very simple to do it. I forgot how  :-\


thank you SlammedDime. hope to do it someday (make clickable)

How to remove - Source: ... ?

Hi,
can i have the SQL create table scrip for RSS Feeder? i'm having problem installing this mod.

Thanks.

Excellent mod SD and many thanks

Although I never had an issue with vb's for 1.1.x it did stop permitting direct edit of entries sometime around the forum upgrade to 1.1.12 so I just used to edit them in the database every three months, but the actual feeds behaved perfectly - on time and into the correct board etc.  So I was very happy to find yours that allows me control through the ACP again.

Unfortunately, yours has got me pulling my hair a bit

I'm using RSS Feeder 1.1.1 on SMF 2.0 RC1 and everything except one thing is working normally.  Feeds are scheduled for 3-hourly some to retrieve 1 item, some to retrieve up to 4 (they're announcement feeds normally updated 2 or 3 times a day with single posts).

The problem is they they are relentlessly marching backwards in time - after just 24 hours, one of the fed boards had over 500 posts going back to the Indian Ocean tsunami on Boxing Day 2004 and beyond.

I need them to only pull new posts from within the last 3 hours since their last check.

Any idea what could be causing this?

Gaz

The feeder pulls from the bottom of the RSS feed to the top, so they will be posted in the order that the feed has them, oldest posted first.  If the feed has 100 items, and you're doing 1 at a time, it will start at the bottom and work it's way to the top.

Quote from: resti on March 04, 2009, 09:50:41 AM
Hi,
can i have the SQL create table scrip for RSS Feeder? i'm having problem installing this mod.

Thanks.

Just put add_settings.php into your main SMF directory and run it.

Quote from: nikku on March 01, 2009, 03:31:15 PM
i searched my bookmark for the answer i couldnt find it  now... >:( ... where is the theme. go to forum and browse it. there is the answer or just ask a topic. is very simple to do it. I forgot how  :-\


thank you SlammedDime. hope to do it someday (make clickable)

How to remove - Source: ... ?

You'll have to edit that in ScheduledTasks.php

Quote from: SlammedDime on March 04, 2009, 02:37:15 PM
The feeder pulls from the bottom of the RSS feed to the top, so they will be posted in the order that the feed has them, oldest posted first.  If the feed has 100 items, and you're doing 1 at a time, it will start at the bottom and work it's way to the top.

OK - so would you recommend I do a single manual run of unlimited posts to clear the backlog and "bring it up to date"?  After which it should only pull new posts even if I've deleted all the old ones because they've already been captured and posted previously.

(appreciate the rapid help by the way - such a refreshing change)

Gaz

If you are not retrieving the full article, then yes, I would recommend that.

OK - have given it a go - now waiting for the feed creators to add something new and see if it performs the way I'm hoping it will.  I'll post back with results.

just a thought - if this does do what we're discussing, it could be a nice idea to add a little explanation of this particular bit of "how to" to the pop-up help for when selecting number of posts to pull - it might save less experienced users some heartache.  What do you think?

Gaz

Hello Everybody!
I'm having problem installing RSS Feed. The problem is, the tables were not created when i install it. I hope you guys can give me a create table sql script for RSS Feed.

Many thanks,

Gaz - good idear

resti - As I said above, you need to put add_settings.php from the install package into your main SMF directory and run it.  There is more to it than just adding database tables, it also adds settings and values to the database.

Quote from: SlammedDime on March 04, 2009, 02:38:14 PM

Quote from: resti on March 04, 2009, 09:50:41 AM
Hi,
can i have the SQL create table scrip for RSS Feeder? i'm having problem installing this mod.

Thanks.

Just put add_settings.php into your main SMF directory and run it.

Hi i got this error when i executed the add_settings.php

Code Select Expand

/* RSS Feeder Settings */ function ModifyRSSFeedSettings() { global $context, $txt, $sourcedir, $scripturl, $smcFunc; loadTemplate('RSSFeeds'); $context['page_title'] = $txt['rss_feeder']; if (!empty($_REQUEST['feed']) && (isset($_REQUEST['enable']) || isset($_REQUEST['disable']))) { // Quick change on the status... $smcFunc['db_query']('', ' UPDATE {db_prefix}rssfeeds SET enabled = {int:option} WHERE id_feed = {int:feed}', array( 'option' => isset($_REQUEST['enable']) ? 1 : 0, 'feed' => (int) $_REQUEST['feed'], ) ); redirectExit('action=admin;area=modsettings;sa=rssfeeds'); } if (!empty($_REQUEST['feed']) || !empty($_REQUEST['add'])) { $context['sub_template'] = 'rss_feeder_add'; // Load the boards and categories for adding or editing a feed. $request = $smcFunc['db_query']('', ' SELECT b.id_board, b.name, b.child_level, c.name AS cat_name, c.id_cat FROM {db_prefix}boards AS b LEFT JOIN {db_prefix}categories AS c ON (c.id_cat = b.id_cat)', array() ); $context['categories'] = array(); while ($row = $smcFunc['db_fetch_assoc']($request)) { if (!isset($context['categories'][$row['id_cat']])) $context['categories'][$row['id_cat']] = array ( 'name' => strip_tags($row['cat_name']), 'boards' => array(), ); $context['categories'][$row['id_cat']]['boards'][] = array( 'id' => $row['id_board'], 'name' => strip_tags($row['name']), 'category' => strip_tags($row['cat_name']), 'child_level' => $row['child_level'], 'selected' => !empty($_SESSION['move_to_topic']) && $_SESSION['move_to_topic'] == $row['id_board'] && $row['id_board'] != $board, ); } $smcFunc['db_free_result']($request); if (empty($context['categories'])) fatal_lang_error('rss_feed_no_boards', false); // If we're just adding a feed, we can return, don't need to do anything further if (empty($_REQUEST['add'])) { // Lets get the feed from the database $request = $smcFunc['db_query']('', ' SELECT * FROM {db_prefix}rssfeeds WHERE id_feed = {int:feed} LIMIT 1', array( 'feed' => ((int) $_REQUEST['feed']), ) ); // No Feed?? ut oh... hacker!! if ($smcFunc['db_num_rows']($request) != 1) fatal_lang_error('rss_feed_not_found', false); $context['rss_feed'] = $smcFunc['db_fetch_assoc']($request); $context['rss_feed'] = htmlspecialchars__recursive($context['rss_feed']); $smcFunc['db_free_result']($request); } $context['icon'] = !empty($context['rss_feed']['icon']) ? $context['rss_feed']['icon'] : 'xx'; require_once($sourcedir . '/Subs-Editor.php'); // Message icons - customized icons are off? $context['icons'] = getMessageIcons(!empty($context['rss_feed']['id_board']) ? $context['rss_feed']['id_board'] : 0); if (!empty($context['icons'])) $context['icons'][count($context['icons']) - 1]['is_last'] = true; $context['icon_url'] = ''; for ($i = 0, $n = count($context['icons']); $i < $n; $i++) { $context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value']; if ($context['icons'][$i]['selected']) $context['icon_url'] = $context['icons'][$i]['url']; } if (empty($context['icon_url'])) { $context['icon_url'] = $settings[file_exists($settings['theme_dir'] . '/images/post/' . $context['icon'] . '.gif') ? 'images_url' : 'default_images_url'] . '/post/' . $context['icon'] . '.gif'; array_unshift($context['icons'], array( 'value' => $context['icon'], 'name' => $txt['current_icon'], 'url' => $context['icon_url'], 'is_last' => empty($context['icons']), 'selected' => true, )); } return; } // What about deleting one or more?? elseif (!empty($_REQUEST['delete'])) { //$_POST['checked_feeds'] // We already asked that they wanted to delete, so we'll just delete... no confirmation foreach ($_POST['checked_feeds'] as $key => $id) $_POST['checked_feeds'][$key] = (int) $id; $smcFunc['db_query']('', ' DELETE FROM {db_prefix}rssfeeds WHERE id_feed IN ({array_int:feed_list})', array( 'feed_list' => $_POST['checked_feeds'], ) ); } // Or are they saving one being modified?? elseif (!empty($_REQUEST['save']) && !empty($_POST['sc'])) { // First we check the session... checkSession(); // Put the insert array together... $insertOptions = array(); // Let's do the 'unrequireds' first... $insertOptions['id_board'] = (int)$_POST['feed_board']; $insertOptions['icon'] = isset($_POST['icon']) ? preg_replace('~[\./\\\\*\':"<>]~', '', $_POST['icon']) : 'xx'; $insertOptions['enabled'] = isset($_POST['feed_enabled']) ? 1 : 0; $insertOptions['keywords'] = trim($_POST['feed_keywords']) != '' ? trim($_POST['feed_keywords']) : ''; $insertOptions['locked'] = isset($_POST['feed_locked']) ? 1 : 0; $insertOptions['getfull'] = isset($_POST['feed_full']) ? 1 : 0; $insertOptions['approve'] = isset($_POST['feed_approve']) ? 1 : 0; $insertOptions['singletopic'] = isset($_POST['feed_singletopic']) ? 1 : 0; $insertOptions['topicprefix'] = trim($_POST['feed_prefix']) != '' ? trim($_POST['feed_prefix']) : ''; $insertOptions['footer'] = !empty($_POST['feed_footer']) ? trim($_POST['feed_footer']) : ''; $insertOptions['numbertoimport'] = trim($_POST['feed_import']) != '' ? (int) trim($_POST['feed_import']) : 0; $context['feed_errors'] = array(); // And now the requireds that we can throw errors on... if (empty($_POST['feed_title'])) $context['feed_errors']['feed_title'] = ($insertOptions['title'] = ''); else $insertOptions['title'] = preg_replace('~[&]([^;]{8}|[^;]{0,8}$)~', '&$1', $_POST['feed_title']); if (empty($_POST['feed_url'])) $context['feed_errors']['feed_url'] = ($insertOptions['feedurl'] = ''); else $insertOptions['feedurl'] = trim($_POST['feed_url']); if (empty($_POST['feed_poster'])) $context['feed_errors']['feed_poster'] = ($insertOptions['postername'] = ''); // Do a query to get the member's id else { $request = $smcFunc['db_query']('', ' SELECT id_member FROM {db_prefix}members WHERE real_name = {string:name} OR member_name = {string:name} LIMIT 1', array( 'name' => trim($_POST['feed_poster']), ) ); if ($smcFunc['db_num_rows']($request) != 1) $context['feed_errors']['feed_poster'] = ($insertOptions['postername'] = trim($_POST['feed_poster'])); else { $insertOptions['postername'] = trim($_POST['feed_poster']); list($insertOptions['id_member']) = $smcFunc['db_fetch_row']($request); } $smcFunc['db_free_result']($request); } $insertOptions['regex'] = trim($_POST['feed_regex']); if (!empty($insertOptions['getfull']) && empty($insertOptions['regex'])) $context['feed_errors']['feed_regex'] = ''; // if we had any errors, lets kick back a screen and highlight them... if (!empty($context['feed_errors'])) { $context['rss_feed'] = $insertOptions; if (!empty($_POST['feed_id'])) $_REQUEST['feed'] = $_POST['feed_id']; $_REQUEST['add'] = true; return ModifyRSSFeedSettings(); } // Looks like we're good. // Modifying an existing feed? if (!empty($_REQUEST['feed_id'])) { $smcFunc['db_query']('',' UPDATE {db_prefix}rssfeeds SET id_board = {int:id_board}, feedurl = {string:feedurl}, title = {string:title}, icon = {string:icon}, enabled = {int:enabled}, postername = {string:postername}, id_member = {int:id_member}, keywords = {string:keywords}, regex = {string:regex}, locked = {int:locked}, getfull = {int:getfull}, approve = {int:approve}, singletopic = {int:singletopic}, topicprefix = {string:topicprefix}, footer = {string:footer}, numbertoimport = {int:numbertoimport} WHERE id_feed = {int:id_feed}', array_merge(array('id_feed' => (int)$_REQUEST['feed_id']), $insertOptions) ); $context['feed_insert_success'] = $txt['rss_feed_update_success']; } // Or I guess we're inserting a new one else { // Fix up the stuff for insertion, make sure the arrays are aligned $insertRows = array( 'singletopic' => 'int', 'icon' => 'string', 'footer' => 'string', 'getfull' => 'int', 'id_board' => 'int', 'feedurl' => 'string', 'title' => 'string', 'enabled' => 'int', 'postername' => 'string', 'id_member' => 'int', 'keywords' => 'string', 'regex' => 'string', 'locked' => 'int', 'approve' => 'int', 'topicprefix' => 'string', 'numbertoimport' => 'int' ); ksort($insertRows); ksort($insertOptions); $smcFunc['db_insert']('', '{db_prefix}rssfeeds', $insertRows, $insertOptions, array('id_feed') ); $id_feed = $smcFunc['db_insert_id']('{db_prefix}rssfeeds', 'id_feed'); if (empty($id_feed)) $context['feed_insert_error'] = $txt['rss_feed_insert_error']; else $context['feed_insert_success'] = $txt['rss_feed_insert_success']; } } // If they deleted or saved, let's show the main list $context['sub_template'] = 'rss_feeder_list'; // Create the table that will display the feeds $listOptions = array( 'id' => 'rss_feeder_list', 'items_per_page' => 40, 'default_sort_col' => 'icon', 'base_href' => $scripturl . '?action=admin;area=modsettings;sa=rssfeeds', 'no_items_label' => $txt['rss_feed_none'], 'get_items' => array( 'function' => 'list_getFeeds', ), 'get_count' => array( 'function' => 'list_getNumFeeds', ), 'columns' => array( 'icon' => array( 'header' => array( 'value' => $txt['rss_feed_enabled'], ), 'data' => array( 'function' => create_function('$rowData', ' global $settings, $scripturl, $smcFunc, $txt; if (empty($rowData[\'name\']) && $rowData[\'enabled\']) { $smcFunc[\'db_query\'](\'\', \' UPDATE {db_prefix}rssfeeds SET enabled = 0 WHERE id_feed = {int:feed}\', array( \'feed\' => $rowData[\'id_feed\'], ) ); // Log an error about the issue, just so the user can see why their feed was disabled... log_error($txt[\'rss_feeder\'] . \': \' . $rowData[\'title\'] . \' (\' . $txt[\'rss_feed_board_error\'] . \')\'); $rowData[\'enabled\'] = 0; } return \'\';' ), 'style' => 'text-align: center; width: 130px;', ), 'sort' => array( 'default' => 'f.enabled', 'reverse' => 'f.enabled DESC', ), ), 'title' => array( 'header' => array( 'value' => $txt['rss_feed_title'], ), 'data' => array( 'db' => 'title', 'style' => 'text-align: center;', ), 'sort' => array( 'default' => 'f.title', 'reverse' => 'f.title DESC', ), ), 'url' => array( 'header' => array( 'value' => $txt['rss_feed_url'], ), 'data' => array( 'sprintf' => array( 'format' => '%1$s', 'params' => array( 'feedurl' => true, ), ), ), 'sort' => array( 'default' => 'f.feedurl', 'reverse' => 'f.feedurl DESC', ), ), 'board' => array( 'header' => array( 'value' => $txt['rss_feed_board'], ), 'data' => array( 'function' => create_function('$rowData', ' global $txt; return empty($rowData[\'name\']) ? \'<< \' . $txt[\'rss_feed_board_error\'] . \' >>\' : $rowData[\'name\'];' ), 'style' => 'text-align: center;', ), 'sort' => array( 'default' => 'b.name', 'reverse' => 'b.name DESC', ), ), 'count' => array( 'header' => array( 'value' => $txt['rss_feed_count'], ), 'data' => array( 'db' => 'importcount', 'style' => 'text-align: center;', ), 'sort' => array( 'default' => 'f.importcount', 'reverse' => 'f.importcount DESC', ), ), 'modify' => array( 'header' => array( 'value' => $txt['rss_feed_modify'], ), 'data' => array( 'sprintf' => array( 'format' => '' . $txt['rss_feed_modify'] . '', 'params' => array( 'id_feed' => false, ), ), 'style' => 'text-align: center; width: 50px;', ), ), 'check' => array( 'header' => array( 'value' => '', ), 'data' => array( 'sprintf' => array( 'format' => '', 'params' => array( 'id_feed' => false, ), ), 'style' => 'text-align: center; width: 32px;', ), ), ), 'form' => array( 'href' => $scripturl . '?action=admin;area=modsettings;sa=rssfeeds', 'name' => 'rssfeedForm', ), 'additional_rows' => array( array( 'position' => 'above_column_headers', 'value' => ' ', 'style' => 'text-align: right;', 'class' => 'titlebg', ), array( 'position' => 'below_table_data', 'value' => ' ', 'style' => 'text-align: right;', 'class' => 'titlebg', ), ), ); require_once($sourcedir . '/Subs-List.php'); createList($listOptions); } // Get information for the list above... grabs all of the feeds from the database function list_getFeeds($start, $items_per_page, $sort) { global $smcFunc; $request = $smcFunc['db_query']('', ' SELECT f.id_feed, b.name, f.title, f.feedurl, f.enabled, f.importcount FROM {db_prefix}rssfeeds AS f LEFT JOIN {db_prefix}boards AS b ON (b.id_board = f.id_board) ORDER BY {raw:sort} LIMIT ' . $start . ', ' . $items_per_page, array ( 'sort' => $sort, ) ); $feeds = array(); while ($row = $smcFunc['db_fetch_assoc']($request)) $feeds[] = $row; $smcFunc['db_free_result']($request); return $feeds; } // The number grabbed above could be limited at 40... this just gets a count of all of them. function list_getNumFeeds() { global $smcFunc; $request = $smcFunc['db_query']('', ' SELECT COUNT(*) FROM {db_prefix}rssfeeds', array( ) ); list($numFeeds) = $smcFunc['db_fetch_row']; $smcFunc['db_free_result']($request); return $numFeeds; }
Fatal error: Call to undefined function ModifyRSSFeedSettings() in D:\inetpub\vhosts\thegamershive.net\httpdocs\forum\Sources\ManageSettings.php on line 217

hope you can help me on this

Looks like the mod did not install correctly to ManageSettings.php.

You'll need to open that file up and make sure that ?> is the VERY last line of the file.  It looks like it is probably above /* RSS Feeder Settings */

Very nice MOD!

I had the same prob on the install, the >? was not at then end of the file. Easy fix though I'm sure :-)

If someone (anyone) has PCRE coding experience - please PM me... or leave you info as a post in this thread regarding how to get an entire RSS content to show in a feed -

Thank$

KB

Quote from: SlammedDime on March 05, 2009, 12:52:50 PM
Looks like the mod did not install correctly to ManageSettings.php.

You'll need to open that file up and make sure that ?> is the VERY last line of the file.  It looks like it is probably above /* RSS Feeder Settings */

Thanks and now i'm back to table problem and i got this error.

Table 's01win_mysqlb00fd8797d6746085396ce7e1314cece.******_rssfeeds' doesn't exist
File: D:\inetpub\vhosts\*********\httpdocs\forum\Sources\ManageSettings.php
Line: 2561

Please help me, it would be beter if you can give my the SQL string to create the table manualy... thanks

SlammedDime

Just had to say that this is such a good mod. Thanks so much for providing it and also for the very important info regarding how to use the "retrieve full article" feature.

What this mod does is turn a board that has members that don't post regularly into a board that now appears to be really busy. Hopefully this will attract more interest to our sites. Of coarse you know this already but had to drop by and say how much I appreciate your work.  :)

Regards

OK, new issue...

I have 43 RSS feeds (no worries, some are 24hour 1x weather updates) but, I need to "edit" 2 of them, but are not showing on my panel now?

I've just counted, and it displays 40 RSS Feeds, and lists "Page 1" at the bottom (making me assume, there should be a "Page 2" tab) but there is not? - Is there a reason for this I don't know about - or more importantly, how can I access #41, #42, #43 etc?

TIA -

KB

anythign like this that is compatible with 1.1.8 ?

Killer - I haven't had a chance to release a new version yet, but you can fix it by the following

Quote from: SlammedDime on February 14, 2009, 02:43:16 PM
rii - you'll have to modify the relevant code in ScheduledTasks.php, search for $subject =


MrSandman - What happens when you try to add another one?  Does it just not show up?  It should show multiple page selections at the top.
Edit, I found the problem, damn...  I'll release a new version in the next day or two to solve the issue.
If you want to fix it yourself for the time being (you'll have to reverse the change to upgrade or uninstall)
Open ManageSettings.php

Code (Find) Select Expand

list($numFeeds) = $smcFunc['db_fetch_row'];


Code (Replace) Select Expand

list($numFeeds) = $smcFunc['db_fetch_row']($request);


Nena - vbgamer has one for 1.1.x, but it is no longer supported, and I'm not sure how well it works.  Some people have reported problems with it.

Thanks SD - I couldn't find someone else who had the same problem... Will try the mod now...

Cheers

NB: That did it! Thanks!

Quote from: SlammedDime on March 16, 2009, 08:00:07 PM
Nena - vbgamer has one for 1.1.x, but it is no longer supported, and I'm not sure how well it works.  Some people have reported problems with it.

Yeah the bugs w/out support is my worry...i would really like to be able to add this to my members ultimate profile so they can link their blogs to it to display their blog feed... I hope I get to use this mod soon...it sounds fantastic.

This works great SD, thank you very much.

I'm having a problem with "Full Article" though. I would like to get the full articales from http://www.railbirds.com/rss/latestblogs.php

And I can't find the proper <div id... The div right before the content of the article is "<div class="blog-body">"

Here is  a link to a blog if anyone can look to see how I can get this working
http://www.railbirds.com/blog/255412/found-a-way-to-win-more-dollars-in-every-tourney.html

I tried http://www.railbirds.com/rss/latestblogs.php for the Feed URL ( This works good for just getting the feed)

and

~<div class="blog-body">(.*)<\/div>~siU for the Regular Expression. Does it have to be <div id... ?

Sorry for my ignorance in this stuff.

Thank you in advance.

Just making sure this topic didn't get locked....Bumping after 3 days  ;)

I know that the code I tried above is totally wrong but any ideas anyone?

Thanks again

Sorry, didn't see your post before.  It can be *anything*, not just <div something... whatever works to get what you need.  I can't check the site right now to verify the regex (work restrictions), but I'll take a look when I get home from work.  Does it not work for you?

Quote from: mrtrc266 on March 18, 2009, 02:27:14 PM
This works great SD, thank you very much.

I'm having a problem with "Full Article" though. I would like to get the full articales from http://www.railbirds.com/rss/latestblogs.php

And I can't find the proper <div id... The div right before the content of the article is "<div class="blog-body">"

Here is  a link to a blog if anyone can look to see how I can get this working
http://www.railbirds.com/blog/255412/found-a-way-to-win-more-dollars-in-every-tourney.html

I tried http://www.railbirds.com/rss/latestblogs.php for the Feed URL ( This works good for just getting the feed)

and

~<div class="blog-body">(.*)<\/div>~siU for the Regular Expression. Does it have to be <div id... ?

Sorry for my ignorance in this stuff.

Thank you in advance.

mrtrc... I've kinda asked about this before... with no luck - but where are you getting these "codes" to pull the full articles from? As I'm trying to do the same.. but have no idea about PRC coding... I've asked for links or manuals or anywhere where I can study up and learn... but to no avail - the RSS feeder works GREAT.. but am only getting about 300 characters... and am wanting more...

TIA for any guidance -

Cheers-

KB

Killer - You never did answer me to if you checked out the small tutorial that I posted in this topic.  There really isnt' any more to it, and unfortunately, I don't think I can really explain it any simpler.  There is plenty of information on the net regarding regular expressions... http://www.regular-expressions.info/ is a popular site with lots of info.

SD - Sorry, I know you field tons of questions with this, and all your other mods - but honestly, I did go thru all the posts here - and never saw anything of value (sorry if I overlooked something) - I did see your response, where you doubted it would/could pull the photos (as it has been doing very well) - I'm even using it on flickr now and pulling in great feeds -

That said, thanks for the link here... I'll take a look and see if I can get my head around it... and maybe it'll work afterall :)

Cheers-

KB

any plans on this working with 1.1.8?

Sorry Nena, I won't be backporting this, it relys on too many of SMF 2.0's built in functions, and I would have to rewrite a lot of the mod to work.

ehh thanks anyway :) maybe once 2.0 is more worked in I will upgrade. :) i do look forward to trying out your mod.

Quote from: SlammedDime on March 21, 2009, 11:35:40 AM
Sorry, didn't see your post before.  It can be *anything*, not just <div something... whatever works to get what you need.  I can't check the site right now to verify the regex (work restrictions), but I'll take a look when I get home from work.  Does it not work for you?

It does work but I only get a few characters, I'm trying to get full articles to pull from this feed.

http://www.railbirds.com/rss/latestblogs.php

I did read the tutorial and tried everything I can think of but I can't get it going. I am truly clueless and any help is greatly appreciated.

Well I did some preliminary testing with the regex you're using and that feed and it seems to work fine... I'll throw it into the mod itself and see how it does...

Here is a link to my test site that I'm trying it out on.

http://monsters-mansion.com/testrc1/index.php

As you can see in the Latest Railbird Blogs it pulls the feed but only shows the title of the blog. Full articles would be awesome :D

Hey could u look at this plz all

http://www.itsyoursite.info/index.php?action=admin;area=modsettings;sa=rssfeeds

It just gives me text, could anyone help me with this

Thank you

judgey - this link is requiring us to log in?

Sorry my bad -

Im just getting a screen with loads of text, this is just some of it

/* RSS Feeder Settings */ function ModifyRSSFeedSettings() { global $context, $txt, $sourcedir, $scripturl, $smcFunc; loadTemplate('RSSFeeds'); $context['page_title'] = $txt['rss_feeder']; if (!empty($_REQUEST['feed']) && (isset($_REQUEST['enable']) || isset($_REQUEST['disable']))) { // Quick change on the status... $smcFunc['db_query']('', ' UPDATE {db_prefix}rssfeeds SET enabled = {int:option} WHERE id_feed = {int:feed}', array( 'option' => isset($_REQUEST['enable']) ? 1 : 0, 'feed' => (int) $_REQUEST['feed'], ) ); redirectExit('action=admin;area=modsettings;sa=rssfeeds'); } if (!empty($_REQUEST['feed']) || !empty($_REQUEST['add'])) { $context['sub_template'] = 'rss_feeder_add'; // Load the boards and categories for adding or editing a feed. $request = $smcFunc['db_query']('', ' SELECT b.id_board, b.name, b.child_level, c.name AS cat_name, c.id_cat FROM {db_prefix}boards AS b LEFT JOIN {db_prefix}categories AS c ON (c.id_cat = b.id_cat)', array() ); $context['categories'] = array(); while ($row = $smcFunc['db_fetch_assoc']($request)) { if (!isset($context['categories'][$row['id_cat']])) $context['categories'][$row['id_cat']] = array ( 'name' => strip_tags($row['cat_name']), 'boards' => array(), ); $context['categories'][$row['id_cat']]['boards'][] = array( 'id' => $row['id_board'], 'name' => strip_tags($row['name']), 'category' => strip_tags($row['cat_name']), 'child_level' => $row['child_level'], 'selected' => !empty($_SESSION['move_to_topic']) && $_SESSION['move_to_topic'] == $row['id_board'] && $row['id_board'] != $board, ); } $smcFunc['db_free_result']($request); if (empty($context['categories'])) fatal_lang_error('rss_feed_no_boards', false); // If we're just adding a feed, we can return, don't need to do anything further if (empty($_REQUEST['add'])) { // Lets get the feed from the database $request = $smcFunc['db_query']('', ' SELECT * FROM {db_prefix}rssfeeds WHERE id_feed = {int:feed} LIMIT 1', array( 'feed' => ((int) $_REQUEST['feed']), ) ); // No Feed?? ut oh... hacker!! if ($smcFunc['db_num_rows']($request) != 1) fatal_lang_error('rss_feed_not_found', false); $context['rss_feed'] = $smcFunc['db_fetch_assoc']($request); $context['rss_feed'] = htmlspecialchars__recursive($context['rss_feed']); $smcFunc['db_free_result']($request); } $context['icon'] = !empty($context['rss_feed']['icon']) ? $context['rss_feed']['icon'] : 'xx'; require_once($sourcedir . '/Subs-Editor.php'); // Message icons - customized icons are off? $context['icons'] = getMessageIcons(!empty($context['rss_feed']['id_board']) ? $context['rss_feed']['id_board'] : 0); if (!empty($context['icons'])) $context['icons'][count($context['icons']) - 1]['is_last'] = true; $context['icon_url'] = ''; for ($i = 0, $n = count($context['icons']); $i < $n; $i++) { $context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value']; if ($context['icons'][$i]['selected']) $context['icon_url'] = $context['icons'][$i]['url']; } if (empty($context['icon_url'])) { $context['icon_url'] = $settings[file_exists($settings['theme_dir'] . '/images/post/' . $context['icon'] . '.gif') ? 'images_url' : 'default_images_url'] . '/post/' . $context['icon'] . '.gif'; array_unshift($context['icons'], array( 'value' => $context['icon'], 'name' => $txt['current_icon'], 'url' => $context['icon_url'], 'is_last' => empty($context['icons']), 'selected' => true, )); } return; } // What about deleting one or more?? elseif (!empty($_REQUEST['delete'])) { //$_POST['checked_feeds'] // We already asked that they wanted to delete, so we'll just delete... no confirmation foreach

do you have a screen shot?

Here you, and thanks for helping :)

i recently had a similar problem and it ended up being my php tags were not closed...im sure if you attach the file in question someone with more experience would be able to help you out. But that looks almost exactly like an issue I was having and it was I was missing some php tags.

Here is the whole page could not work out wot page to upload, again thank you :)

/* RSS Feeder Settings */
function ModifyRSSFeedSettings()
{
global $context, $txt, $sourcedir, $scripturl, $smcFunc;

loadTemplate('RSSFeeds');
$context['page_title'] = $txt['rss_feeder'];

if (!empty($_REQUEST['feed']) && (isset($_REQUEST['enable']) || isset($_REQUEST['disable'])))
{
// Quick change on the status...
$smcFunc['db_query']('', '
UPDATE {db_prefix}rssfeeds
SET enabled = {int:option}
WHERE id_feed = {int:feed}',
array(
'option' => isset($_REQUEST['enable']) ? 1 : 0,
'feed' => (int) $_REQUEST['feed'],
)
);
redirectExit('action=admin;area=modsettings;sa=rssfeeds');
}

if (!empty($_REQUEST['feed']) || !empty($_REQUEST['add']))
{

$context['sub_template'] = 'rss_feeder_add';

// Load the boards and categories for adding or editing a feed.
$request = $smcFunc['db_query']('', '
SELECT b.id_board, b.name, b.child_level, c.name AS cat_name, c.id_cat
FROM {db_prefix}boards AS b
LEFT JOIN {db_prefix}categories AS c ON (c.id_cat = b.id_cat)',
array()
);
$context['categories'] = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
{
if (!isset($context['categories'][$row['id_cat']]))
$context['categories'][$row['id_cat']] = array (
'name' => strip_tags($row['cat_name']),
'boards' => array(),
);

$context['categories'][$row['id_cat']]['boards'][] = array(
'id' => $row['id_board'],
'name' => strip_tags($row['name']),
'category' => strip_tags($row['cat_name']),
'child_level' => $row['child_level'],
'selected' => !empty($_SESSION['move_to_topic']) && $_SESSION['move_to_topic'] == $row['id_board'] && $row['id_board'] != $board,
);
}
$smcFunc['db_free_result']($request);

if (empty($context['categories']))
fatal_lang_error('rss_feed_no_boards', false);

// If we're just adding a feed, we can return, don't need to do anything further
if (empty($_REQUEST['add']))
{
// Lets get the feed from the database
$request = $smcFunc['db_query']('', '
SELECT *
FROM {db_prefix}rssfeeds
WHERE id_feed = {int:feed}
LIMIT 1',
array(
'feed' => ((int) $_REQUEST['feed']),
)
);

// No Feed?? ut oh... hacker!!
if ($smcFunc['db_num_rows']($request) != 1)
fatal_lang_error('rss_feed_not_found', false);
$context['rss_feed'] = $smcFunc['db_fetch_assoc']($request);
$context['rss_feed'] = htmlspecialchars__recursive($context['rss_feed']);
$smcFunc['db_free_result']($request);
}

$context['icon'] = !empty($context['rss_feed']['icon']) ? $context['rss_feed']['icon'] : 'xx';

require_once($sourcedir . '/Subs-Editor.php');
// Message icons - customized icons are off?
$context['icons'] = getMessageIcons(!empty($context['rss_feed']['id_board']) ? $context['rss_feed']['id_board'] : 0);

if (!empty($context['icons']))
$context['icons'][count($context['icons']) - 1]['is_last'] = true;

$context['icon_url'] = '';
for ($i = 0, $n = count($context['icons']); $i < $n; $i++)
{
$context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value'];
if ($context['icons'][$i]['selected'])
$context['icon_url'] = $context['icons'][$i]['url'];
}
if (empty($context['icon_url']))
{
$context['icon_url'] = $settings[file_exists($settings['theme_dir'] . '/images/post/' . $context['icon'] . '.gif') ? 'images_url' : 'default_images_url'] . '/post/' . $context['icon'] . '.gif';
array_unshift($context['icons'], array(
'value' => $context['icon'],
'name' => $txt['current_icon'],
'url' => $context['icon_url'],
'is_last' => empty($context['icons']),
'selected' => true,
));
}


return;
}
// What about deleting one or more??
elseif (!empty($_REQUEST['delete']))
{
//$_POST['checked_feeds']
// We already asked that they wanted to delete, so we'll just delete... no confirmation
foreach ($_POST['checked_feeds'] as $key => $id)
$_POST['checked_feeds'][$key] = (int) $id;

$smcFunc['db_query']('', '
DELETE FROM {db_prefix}rssfeeds
WHERE id_feed IN ({array_int:feed_list})',
array(
'feed_list' => $_POST['checked_feeds'],
)
);
}
// Or are they saving one being modified??
elseif (!empty($_REQUEST['save']) && !empty($_POST['sc']))
{
// First we check the session...
checkSession();

// Put the insert array together...
$insertOptions = array();

// Let's do the 'unrequireds' first...
$insertOptions['id_board'] = (int)$_POST['feed_board'];
$insertOptions['icon'] = isset($_POST['icon']) ? preg_replace('~[\./\\\\*\':"<>]~', '', $_POST['icon']) : 'xx';
$insertOptions['enabled'] = isset($_POST['feed_enabled']) ? 1 : 0;
$insertOptions['keywords'] = trim($_POST['feed_keywords']) != '' ? trim($_POST['feed_keywords']) : '';
$insertOptions['locked'] = isset($_POST['feed_locked']) ? 1 : 0;
$insertOptions['getfull'] = isset($_POST['feed_full']) ? 1 : 0;
$insertOptions['approve'] = isset($_POST['feed_approve']) ? 1 : 0;
$insertOptions['singletopic'] = isset($_POST['feed_singletopic']) ? 1 : 0;
$insertOptions['topicprefix'] = trim($_POST['feed_prefix']) != '' ? trim($_POST['feed_prefix']) : '';
$insertOptions['footer'] = !empty($_POST['feed_footer']) ? trim($_POST['feed_footer']) : '';
$insertOptions['numbertoimport'] = trim($_POST['feed_import']) != '' ? (int) trim($_POST['feed_import']) : 0;

$context['feed_errors'] = array();
// And now the requireds that we can throw errors on...
if (empty($_POST['feed_title']))
$context['feed_errors']['feed_title'] = ($insertOptions['title'] = '');
else
$insertOptions['title'] = preg_replace('~[&]([^;]{8}|[^;]{0,8}$)~', '&amp;$1', $_POST['feed_title']);

if (empty($_POST['feed_url']))
$context['feed_errors']['feed_url'] = ($insertOptions['feedurl'] = '');
else
$insertOptions['feedurl'] = trim($_POST['feed_url']);

if (empty($_POST['feed_poster']))
$context['feed_errors']['feed_poster'] = ($insertOptions['postername'] = '');
// Do a query to get the member's id
else
{
$request = $smcFunc['db_query']('', '
SELECT id_member
FROM {db_prefix}members
WHERE real_name = {string:name}
OR member_name = {string:name}
LIMIT 1',
array(
'name' => trim($_POST['feed_poster']),
)
);
if ($smcFunc['db_num_rows']($request) != 1)
$context['feed_errors']['feed_poster'] = ($insertOptions['postername'] = trim($_POST['feed_poster']));
else
{
$insertOptions['postername'] = trim($_POST['feed_poster']);
list($insertOptions['id_member']) = $smcFunc['db_fetch_row']($request);
}
$smcFunc['db_free_result']($request);
}

$insertOptions['regex'] = trim($_POST['feed_regex']);
if (!empty($insertOptions['getfull']) && empty($insertOptions['regex']))
$context['feed_errors']['feed_regex'] = '';

// if we had any errors, lets kick back a screen and highlight them...
if (!empty($context['feed_errors']))
{
$context['rss_feed'] = $insertOptions;
if (!empty($_POST['feed_id']))
$_REQUEST['feed'] = $_POST['feed_id'];
$_REQUEST['add'] = true;
return ModifyRSSFeedSettings();
}

// Looks like we're good.
// Modifying an existing feed?
if (!empty($_REQUEST['feed_id']))
{
$smcFunc['db_query']('','
UPDATE {db_prefix}rssfeeds
SET
id_board = {int:id_board},
feedurl = {string:feedurl},
title = {string:title},
icon = {string:icon},
enabled = {int:enabled},
postername = {string:postername},
id_member = {int:id_member},
keywords = {string:keywords},
regex = {string:regex},
locked = {int:locked},
getfull = {int:getfull},
approve = {int:approve},
singletopic = {int:singletopic},
topicprefix = {string:topicprefix},
footer = {string:footer},
numbertoimport = {int:numbertoimport}
WHERE id_feed = {int:id_feed}',
array_merge(array('id_feed' => (int)$_REQUEST['feed_id']), $insertOptions)
);
$context['feed_insert_success'] = $txt['rss_feed_update_success'];
}
// Or I guess we're inserting a new one
else
{
// Fix up the stuff for insertion, make sure the arrays are aligned
$insertRows = array( 'singletopic' => 'int', 'icon' => 'string', 'footer' => 'string', 'getfull' => 'int', 'id_board' => 'int', 'feedurl' => 'string', 'title' => 'string', 'enabled' => 'int', 'postername' => 'string', 'id_member' => 'int', 'keywords' => 'string', 'regex' => 'string', 'locked' => 'int', 'approve' => 'int', 'topicprefix' => 'string', 'numbertoimport' => 'int' );
ksort($insertRows);
ksort($insertOptions);

$smcFunc['db_insert']('',
'{db_prefix}rssfeeds',
$insertRows,
$insertOptions,
array('id_feed')
);
$id_feed = $smcFunc['db_insert_id']('{db_prefix}rssfeeds', 'id_feed');
if (empty($id_feed))
$context['feed_insert_error'] = $txt['rss_feed_insert_error'];
else
$context['feed_insert_success'] = $txt['rss_feed_insert_success'];
}
}

// If they deleted or saved, let's show the main list
$context['sub_template'] = 'rss_feeder_list';
// Create the table that will display the feeds
$listOptions = array(
'id' => 'rss_feeder_list',
'items_per_page' => 40,
'default_sort_col' => 'icon',
'base_href' => $scripturl . '?action=admin;area=modsettings;sa=rssfeeds',
'no_items_label' => $txt['rss_feed_none'],
'get_items' => array(
'function' => 'list_getFeeds',
),
'get_count' => array(
'function' => 'list_getNumFeeds',
),
'columns' => array(
'icon' => array(
'header' => array(
'value' => $txt['rss_feed_enabled'],
),
'data' => array(
'function' => create_function('$rowData', '
global $settings, $scripturl, $smcFunc, $txt;

if (empty($rowData[\'name\']) && $rowData[\'enabled\'])
{
$smcFunc[\'db_query\'](\'\', \'
UPDATE {db_prefix}rssfeeds
SET enabled = 0
WHERE id_feed = {int:feed}\',
array(
\'feed\' => $rowData[\'id_feed\'],
)
);

// Log an error about the issue, just so the user can see why their feed was disabled...
log_error($txt[\'rss_feeder\'] . \': \' . $rowData[\'title\'] . \' (\' . $txt[\'rss_feed_board_error\'] . \')\');

$rowData[\'enabled\'] = 0;
}
return \'<a href="\' . $scripturl . \'?action=admin;area=modsettings;sa=rssfeeds;feed=\' . $rowData[\'id_feed\'] . ($rowData[\'enabled\'] ? \';disable\' : \';enable\') . \'"><img src="\' . $settings[\'images_url\'] . ($rowData[\'enabled\'] ? \'/rss_enabled.gif\' : \'/rss_disabled.gif\') . \'"></a>\';'
),
'style' => 'text-align: center; width: 130px;',
),
'sort' => array(
'default' => 'f.enabled',
'reverse' => 'f.enabled DESC',
),
),
'title' => array(
'header' => array(
'value' => $txt['rss_feed_title'],
),
'data' => array(
'db' => 'title',
'style' => 'text-align: center;',
),
'sort' => array(
'default' => 'f.title',
'reverse' => 'f.title DESC',
),
),
'url' => array(
'header' => array(
'value' => $txt['rss_feed_url'],
),
'data' => array(
'sprintf' => array(
'format' => '<a target="_blank" href="%1$s">%1$s</a>',
'params' => array(
'feedurl' => true,
),
),
),
'sort' => array(
'default' => 'f.feedurl',
'reverse' => 'f.feedurl DESC',
),
),
'board' => array(
'header' => array(
'value' => $txt['rss_feed_board'],
),
'data' => array(
'function' => create_function('$rowData', '
global $txt;
return empty($rowData[\'name\']) ? \'<em><< \' . $txt[\'rss_feed_board_error\'] . \' >></em>\' : $rowData[\'name\'];'
),
'style' => 'text-align: center;',
),
'sort' => array(
'default' => 'b.name',
'reverse' => 'b.name DESC',
),
),
'count' => array(
'header' => array(
'value' => $txt['rss_feed_count'],
),
'data' => array(
'db' => 'importcount',
'style' => 'text-align: center;',
),
'sort' => array(
'default' => 'f.importcount',
'reverse' => 'f.importcount DESC',
),
),
'modify' => array(
'header' => array(
'value' => $txt['rss_feed_modify'],
),
'data' => array(
'sprintf' => array(
'format' => '<a href="' . $scripturl . '?action=admin;area=modsettings;sa=rssfeeds;feed=%1$d">' . $txt['rss_feed_modify'] . '</a>',
'params' => array(
'id_feed' => false,
),
),
'style' => 'text-align: center; width: 50px;',
),
),
'check' => array(
'header' => array(
'value' => '<input type="checkbox" onclick="invertAll(this, this.form);" class="check" />',
),
'data' => array(
'sprintf' => array(
'format' => '<input type="checkbox" name="checked_feeds[]" value="%1$d" class="check" />',
'params' => array(
'id_feed' => false,
),
),
'style' => 'text-align: center; width: 32px;',
),
),
),
'form' => array(
'href' => $scripturl . '?action=admin;area=modsettings;sa=rssfeeds',
'name' => 'rssfeedForm',
),
'additional_rows' => array(
array(
'position' => 'above_column_headers',
'value' => '
<input type="submit" name="add" value="'. $txt['rss_feed_add'] . '" />',
'style' => 'text-align: right;',
'class' => 'titlebg',
),
array(
'position' => 'below_table_data',
'value' => '
<input type="submit" onclick="return confirm(\'' . $txt['rss_feed_confirm'] . '\')" name="delete" value="'. $txt['rss_feed_delete'] . '" />',
'style' => 'text-align: right;',
'class' => 'titlebg',
),
),
);


require_once($sourcedir . '/Subs-List.php');
createList($listOptions);
}

// Get information for the list above... grabs all of the feeds from the database
function list_getFeeds($start, $items_per_page, $sort)
{
global $smcFunc;
$request = $smcFunc['db_query']('', '
SELECT f.id_feed, b.name, f.title, f.feedurl, f.enabled, f.importcount
FROM {db_prefix}rssfeeds AS f
LEFT JOIN {db_prefix}boards AS b ON (b.id_board = f.id_board)
ORDER BY {raw:sort}
LIMIT ' . $start . ', ' . $items_per_page,
array (
'sort' => $sort,
)
);
$feeds = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
$feeds[] = $row;
$smcFunc['db_free_result']($request);

return $feeds;
}

// The number grabbed above could be limited at 40... this just gets a count of all of them.
function list_getNumFeeds()
{
global $smcFunc;

$request = $smcFunc['db_query']('', '
SELECT COUNT(*)
FROM {db_prefix}rssfeeds',
array(
)
);
list($numFeeds) = $smcFunc['db_fetch_row'];
$smcFunc['db_free_result']($request);

return $numFeeds;
}

<br />
<b>Fatal error</b>:  Call to undefined function ModifyRSSFeedSettings() in <b>/var/www/vhosts/judgey/itsyoursite.info/httpdocs/Sources/ManageSettings.php</b> on line <b>226</b><br />


Open up the ManageSettings.php and move ?> to the very end of the file.

mrtrc - I ran your feed through with the Regex enabled with the regex you provided above, and it grabbed the full article without a problem.

Quote from: SlammedDime on March 23, 2009, 06:59:30 PM
Open up the ManageSettings.php and move ?> to the very end of the file.

Hey mate sorry wots the path to that file, sorry just can not think

Thank you

It's in the Sources directory

Thank you so much :)

Quote from: SlammedDime on March 23, 2009, 07:03:44 PM
mrtrc - I ran your feed through with the Regex enabled with the regex you provided above, and it grabbed the full article without a problem.

I'm not sure what the problem was but I uninstalled the Mod then reinstalled and used the same regex. Now it works perfectly. Thank you very much for your help and a GREAT Mod!

Quote from: mrtrc266 on March 24, 2009, 01:11:09 AM

Quote from: SlammedDime on March 23, 2009, 07:03:44 PM
mrtrc - I ran your feed through with the Regex enabled with the regex you provided above, and it grabbed the full article without a problem.

I'm not sure what the problem was but I uninstalled the Mod then reinstalled and used the same regex. Now it works perfectly. Thank you very much for your help and a GREAT Mod!

I saw that it pulled the full articles on your site... looks good! Can you post the regex line you used for others to try?

TIA

KB

Quote from: Killer-B on March 24, 2009, 01:35:20 AM

Quote from: mrtrc266 on March 24, 2009, 01:11:09 AM

Quote from: SlammedDime on March 23, 2009, 07:03:44 PM
mrtrc - I ran your feed through with the Regex enabled with the regex you provided above, and it grabbed the full article without a problem.

I'm not sure what the problem was but I uninstalled the Mod then reinstalled and used the same regex. Now it works perfectly. Thank you very much for your help and a GREAT Mod!

I saw that it pulled the full articles on your site... looks good! Can you post the regex line you used for others to try?

TIA

KB

Here is the link to the feeds I was trying to pull http://www.railbirds.com/rss/latestblogs.php

I viewed the source code and just found the DIV right before where the article started and found this...

<div class="blog-body">

And then used this for the regex.

~<div class="blog-body">(.*)<\/div>~siU

As I stated above I'm not sure why it wasn't working before but I dropped the table, uninstalled the Mod and then reinstalled. Now it works great.

Needs 1.1x version....

Quote from: mrtrc266 on March 24, 2009, 01:43:59 AM

Quote from: Killer-B on March 24, 2009, 01:35:20 AM

Quote from: mrtrc266 on March 24, 2009, 01:11:09 AM

Quote from: SlammedDime on March 23, 2009, 07:03:44 PM
mrtrc - I ran your feed through with the Regex enabled with the regex you provided above, and it grabbed the full article without a problem.

I'm not sure what the problem was but I uninstalled the Mod then reinstalled and used the same regex. Now it works perfectly. Thank you very much for your help and a GREAT Mod!

I saw that it pulled the full articles on your site... looks good! Can you post the regex line you used for others to try?

TIA

KB

Here is the link to the feeds I was trying to pull http://www.railbirds.com/rss/latestblogs.php

I viewed the source code and just found the DIV right before where the article started and found this...

<div class="blog-body">

And then used this for the regex.

~<div class="blog-body">(.*)<\/div>~siU

As I stated above I'm not sure why it wasn't working before but I dropped the table, uninstalled the Mod and then reinstalled. Now it works great.

Ahhhhhh - gotcha! Great way to find that out....

Many thanks - will research my feeds, and see if I can have the same success!

Cheers!

KB

@SilverKnight - "Needs 1.1x version" - Are you referring to the RSS feed (vs. 2.0) or 1.1x for SMF?  - I'm running 2.0RC1 and all my feeds are 2.0

Hello, and first of all thanks for this great mod! Is there a way I can remove the "Source:" from the feed? I noticed you added that feature in like version 1 but is there any way to get rid of it?

Anything is possible... It can be removed in ScheduledTasks.php.  Just do a search for 'Source:' in that file and remove that line.

Quote from: SlammedDime on March 25, 2009, 05:54:33 AM
Anything is possible... It can be removed in ScheduledTasks.php.  Just do a search for 'Source:' in that file and remove that line.

I don't suppose you are/planning to make a 1.1x version? it's a needed feature for everyone...  :-\

Please see this quote from the previous page:

Quote from: SlammedDime on March 21, 2009, 03:41:10 PM
Sorry Nena, I won't be backporting this, it relys on too many of SMF 2.0's built in functions, and I would have to rewrite a lot of the mod to work.

Great mod!  I've had it running for a while now without any problems.  I just have one question.  Is there any way to automatically delete old posts?  For example, I'm importing a few news post everyday and the post count is growing.  I know I can go in and delete posts individually, but I would like to be able to delete posts that are over, for example 2 weeks old, or when the post count reaches a cerain number.  Does anybody have any suggestions?  hanks in advance.

That's a bit beyond the scope of this mod, but SMF 2.0 does have a maintenance section that allows you to do this at will...

http://[yourboard]/index.php?action=admin;area=maintain;sa=topics

Were can i find the settings for this mod, i can add a url thats fine, just like the settings like when to post and stuff?

Thank you

Each feed has it's own settings.  The only global setting is the Scheduled Task, and that can be found with the rest of the scheduled tasks settings in the admin panel.

Thanks for that, i wonder wots up then, it dont seem to post anything from anysites :(

Quote from: SlammedDime on March 28, 2009, 12:40:35 PM
Each feed has it's own settings.  The only global setting is the Scheduled Task, and that can be found with the rest of the scheduled tasks settings in the admin panel.

Hey Slammed...

My RSS feeder has worked like a champ the past 3 weeks (2.0RC1) but suddenly "stopped" at 09:00 yesterday... and have not received any feeds since - (I have over 40 feeds)

I removed any dormant feeds - and checked/parsed the others  -and the links all resolve...

Also, I then went to "Scheduled Tasks" and try to run it manually (it's set to start at 08:00 every 1 hour) - and now after trying to start that, it takes me to a BLANK page.... it's obviously hanging... I loaded it on a new demo site, same URL's/Feeds - and it works fine...!? I have not added any new Mods - nor have I changed my RSS Feeds (except remove the inactive ones) - and it's still stuck - and am still getting the white screen when I try to execute manually - And there are no "errors" in the RSS Error Log either...

Thoughts??? I'm stumped!

Thanks -

KB

Any errors in your hosting error log?  Have you installed any mods since installing this?

Judgey - Have you tried running it manually in the scheduled tasks screen?  Are the feeds enabled (Green checkmark)?  Any errors in your forum error log?

Quote from: SlammedDime on March 28, 2009, 01:06:24 PM
Any errors in your hosting error log?  Have you installed any mods since installing this?

Judgey - Have you tried running it manually in the scheduled tasks screen?  Are the feeds enabled (Green checkmark)?  Any errors in your forum error log?

I don't know if you meant that for me, or for Judgy - but as stated in my original Q ... there are no new mods, and no errors are in the logs... It does show "other" activities (member notices, etc.) did happen today... just nothing on the RSS front.. :-(

Well you had said that there are no 'errors' in the RSS error log.... so really I assumed you meant SMF's error log, hence I asked about your hosts error log, normally available through cPanel, or there may be an error_log file in your SMF directory.

My suggestion would be to disable all feeds (easy with the one click disable/enable, just click the green check mark), then try and run the scheduled task... if it runs okay (although none will be posted), start enabling them one by one until you find the one that causes the white screen.

Let me know what happens :)

Hey, im getting "cURL error 7: couldn't connect to host" and then it keeps turning its self of (the rss feeder bit)

Quote from: SlammedDime on March 28, 2009, 01:18:01 PM
Well you had said that there are no 'errors' in the RSS error log.... so really I assumed you meant SMF's error log, hence I asked about your hosts error log, normally available through cPanel, or there may be an error_log file in your SMF directory.

My suggestion would be to disable all feeds (easy with the one click disable/enable, just click the green check mark), then try and run the scheduled task... if it runs okay (although none will be posted), start enabling them one by one until you find the one that causes the white screen.

Let me know what happens :)

Well, I meant the "scheduled tasks" error (task) log... showed no errors... but also showed no RSS activity since yesterday...

Approval Notifications  Today at 11:00:10 AM  0 seconds
Weekly Maintenance Today at 10:42:01 AM 0 seconds
Fetch Simple Machines Files Today at 10:42:01 AM 3 seconds
Weekly Notification Summary Today at 10:41:58 AM 0 seconds
Daily Notification Summary Today at 10:41:58 AM 0 seconds
Daily Maintenance Today at 10:41:58 AM 0 seconds
Approval Notifications Today at 10:41:58 AM 0 seconds
Approval Notifications Today at 09:00:10 AM 0 seconds
Approval Notifications Today at 07:00:59 AM 0 seconds
Approval Notifications Today at 05:00:58 AM 0 seconds
Approval Notifications Today at 03:00:59 AM 0 seconds
Approval Notifications Today at 01:02:58 AM 0 seconds
Approval Notifications Yesterday at 11:07:00 PM 0 seconds
Approval Notifications Yesterday at 09:01:53 PM 0 seconds
Fetch Simple Machines Files Yesterday at 08:22:02 PM 3 seconds
Approval Notifications Yesterday at 07:04:34 PM 0 seconds
Paid Subscription Checks Yesterday at 05:14:31 PM 0 seconds
Daily Maintenance Yesterday at 05:14:07 PM 0 seconds
Daily Notification Summary Yesterday at 05:11:23 PM 0 seconds
Approval Notifications Yesterday at 05:02:39 PM 0 seconds
Approval Notifications Yesterday at 03:03:13 PM 0 seconds
Approval Notifications Yesterday at 01:00:04 PM 0 seconds
Approval Notifications Yesterday at 11:02:34 AM 0 seconds
RSS Feeder Yesterday at 10:04:20 AM 1 seconds
RSS Feeder Yesterday at 09:07:03 AM 29 seconds
Approval Notifications Yesterday at 09:00:13 AM 0 seconds
RSS Feeder Yesterday at 08:00:49 AM 1 seconds
RSS Feeder Yesterday at 07:04:52 AM 15 seconds
Approval Notifications Yesterday at 07:02:07 AM 0 seconds
RSS Feeder Yesterday at 06:00:57 AM 2 seconds

I guess I'll disable them all, and see what that nets?... Is there a way to "back up" all my feeds in case I have to uninstall/reinstall the RSS mod?

And FWIW, I created an Admin account for you... but will try this first before crying on your shoulder more... It's just that today is THE first race of the season, and our busiest day... and losing all these feeds couldn't have come at a worse time :(

Thanks -

KB

If you have to uninstall the mod, it will not remove the feeds from the database, nor the feed log... they will all stay there. :)

Dont forget about me :)

Just as the error stated, the mod could not connect to the host to retrieve the feed... what is the feed you're trying to use.

Quote from: SlammedDime on March 28, 2009, 01:33:32 PM
If you have to uninstall the mod, it will not remove the feeds from the database, nor the feed log... they will all stay there. :)

Thanks for the tip...

I unchecked all 40+ feeds, and now it allows for Tasks to run... I put 2 or 3 feeds back in, ran it manually, and it works now...

Soooooooo - Now, I have to find the one "bad feed" that was causing it to hang -

Thanks for the prompt help

Cheers

KB

Everything is working great except I can't seem to enter any keywords. When I put in a keyword it doesn't pull any feeds.

I went to the site that I pull the blogs from and there are blogs that contain the keywords that I use. Here is my list, does it look ok?

monster, monsters, rbcl, r.b.c.l., botc, b.o.t.c., bocl, b.o.c.l., mayhem, mash

EDIT: I even tried using just one keyword "monster" and get the same results...nothing :(

What is the feed you are trying to use?

Killer - any updates?

The same as before here, It's working perfectly until I try to enter a keyword.
http://www.simplemachines.org/community/index.php?topic=285356.msg1988596#msg1988596

Yeah - sorry -

Like I said, I removed them all like you suggested, and that allowed me to do manual tasks... and then I loaded (enabled) them 1 by 1 till I found the culprit... Had some RSS feeds from SpeedTV - and for whatever reason, when I turn(ed) those on, it kills everything... so, I just removed them ... and is working double time.. :D  In fact, loaded some other pic feeds.. and can't keep up with all its pulling in! so - working like a champ - thanks for the help - For a moment there thought I was gonna have to fill out 40 forms from scratch again LOL-

Thanks -

KB

First off, awesome mod.

My one question--is it possible to have different update schedule for one of my feeds (it is a scorecard and should be updated regularly)? Perhaps I could install two instances of Feeder (1, 2)...is such a thing possible?

If not, how would I go about doing this manually and linking it from my forum, i.e. calling upon a RSS code full text using the "regular expression" tool?

Thanks.

At this point, it's not possible to setup feeds for different schedules.  I will probably be doing that in the next version.  As for doing it manually... it wouldn't be easy... at all... there is a lot of code that is run through for just one feed, so you would have to copy it, and modify it to work with just one feed. 

Thanks, look forward to those changes.
Would setting it to 2 minutes for all the 5 feeds cause a lot of bandwith to be taken up by the program?

On an unrelated note, sometimes when I get the full text, there's a gap (http://cricketvoice.com/testforum/index.php?topic=68.0) -- white space on top, which is not a problem on the forum itself. But when I try do to an XML feed for that board, the same gap carries over. I'm wondering if it is possible to trim the space as a last command before it injects the text into the forum? Or maybe the XML could trim spaces; not sure which one might be easier.

Also, some feeds capture the image and others don't; any idea how I could get them all to be consistent?

Thanks, and look forward to using it on my live site (cricketvoice.com) very soon!

Hi

I know this has been asked before but I still don't know how to get what I need. I want it to post the full article from this feed http://rss.news.yahoo.com/rss/world and not just the pic and small amount of text on the index page - what code do I have to put in to "Regular Expression - Required if retrieving full article. This must be PCRE format. The match is expected to be in second index of the array ([1])." to get it to do that?

Also I'm using a theme with a dark background, I can't see anything on the Add Feed page unless I switch to default theme - is there any way to fix this?

Thanks in advance for your kind help

I don't use any special css for the add feed page, it should be using all SMF default colors based on the theme, I'll have to look into it.

As for the regular expression, have you looked at the small tutorial that is linked in the first topic of this post?

Yea I have - I saved and uploaded the file regex.php but all I get is 2 blank white boxes titled Regex: and Body: then a submit button

Could this all be to do with the add_settings.php file? Do I need to manually upload this file as I can't find it anywhere, and if so which folder do I need to upload it to?

regex.php is only a small script to test regular expressions.  If you installed the mod already, you don't need to run add_settings.php, as that was done on install.

Did you attempt at creating any regular expressions based on my tutorial?  What was your result?

I've only just found the link, they're not always easy to see LOL - I'll read it and try it out for myself and let you know how I get on - thanks

EDIT: I keep getting errors but then I don't know what to put into each box, I pretty much copied your example - this is what I wanted to try

~<div id="yn-story-secondary" class="ult-section">(.*)<\/div>~siU

Try this, that worked for me.

Feed URL
http://rss.news.yahoo.com/rss/world

Regular Expression
~<div class="yn-story-content">(.*)<\/div>~siU

Thanks mrtrc266 I'll try that :D

Thanks that worked - now just one question - any way to get the main pic as well as the text?

mrtrc -

Where'd you pull this code from for her news? "yn-story-content"

yn = yahoo news obviously...  but the "story" and "content' bits... did you go into the HTML header files and look again?

@ Killer & Vampy

This works for all feed I have used so far, we'll use this as an example...

Feed URL...
http://rss.news.yahoo.com/rss/world

Once you click on that you'll see the list of feeds and click on the first feed...
http://news.yahoo.com/s/nm/20090402/od_uk_nm/oukoe_uk_g20_australia_apology

Look for the first words in the article "LONDON (Reuters)"

Right click and view the source and search for "LONDON (Reuters)"

Find the first DIV before that, in this case its <div class="yn-story-content"> so the Regular Expression will be...

~<div class="yn-story-content">(.*)<\/div>~siU

Hope that helps

QuoteThanks that worked - now just one question - any way to get the main pic as well as the text?

No Problem....Not sure about that, I think the pics in another DIV so I'm not sure how that would work.

Quote from: mrtrc266 on April 02, 2009, 06:20:50 PM

QuoteThanks that worked - now just one question - any way to get the main pic as well as the text?

No Problem....Not sure about that, I think the pics in another DIV so I'm not sure how that would work.

Yeah I checked and it is - If I go back to that div all I get is the pic and the "teaser" text - just like the main index page

Thanks for trying I appreciate it

This is working great in retrieving the full articles but for some reason it won't pull the pics. Check it out here....

http://monsters-mansion.com/index.php/topic,3134.msg5850/topicseen.html

Any ideas on this?


Thanks in advance.

It is pulling the images, the problem is the site doesn't use full urls in their image src tags like they should, they use relative urls, which means the image tries to load relative to your site, which of course doesn't work.  I'll think of a way to fix it, but I don't know how easy it will be.

Thank you very much, that would be awesome ig you could get that going.

Quote from: Jimi1810 on February 09, 2009, 04:56:19 AM
Sorry if this has been covered but I am able to import the full article without any problems, except one; when ever there is a "£" symbol the text stops.

http://newsrss.bbc.co.uk/rss/sportonline_uk_edition/football/gossip_and_transfers/rss.xml

thats the feed I'm using so if I take this post for example:

http://news.bbc.co.uk/sport1/hi/football/gossip_and_transfers/7878186.stm

where it says "AC Milan general manager Adriano Galliani admits their offer for David Beckham is way off what LA Galaxy want - the Americans are believed to value the midfielder at £15m. (Daily Mirror)"

I don't get that in the thread, I get "AC Milan general manager Adriano Galliani admits their offer for David Beckham is way off what LA Galaxy want - the Americans are believed to value the midfielder at"

It stops at the "£" and doesn't post anything else below it from the page, it does this for every story it imported which contains a "£" symbol, is there any way I can fix this? if it matters, the regular expression I am using is:

Code Select Expand

~<div class="mxb">(.*)<h3>Bookmark with:<\/h3>~siU

thanks, I love this mod, it's the main reason I am converting to SMF  :D

Sorry I've not checked in a while so not 100% sure, but did you get a chance to have a look at this SlammedDime? if not no worries, thanks.

@ Jimi1810 

Try this DIV instead, I just got it to pull the full article using that.

<div class="ch1">

Thanks for your help mrtrc266, I've just changed it to that but still having the same problem unfortunately.

Quote from: Jimi1810 on April 08, 2009, 01:44:06 PM
Thanks for your help mrtrc266, I've just changed it to that but still having the same problem unfortunately.

Hmmm, I actually just tried it with the regex your were using ~<div class="mxb">(.*)<h3>Bookmark with:<\/h3>~siU and the result is here....

http://www.monsters-mansion.com/smf2/index.php/topic,2782.0.html

Then tried with the ch1 div ~<div class="ch1">(.*)<h3>Bookmark with:<\/h3>~siU and result is here...
http://www.monsters-mansion.com/smf2/index.php/topic,2783.0.html
and here
http://www.monsters-mansion.com/smf2/index.php/topic,2784.0.html

Only diff really is that one tries to pull the pic? Sorry I thought I was onto something but as usual I'm waayyy off....LOL

Oh you actually have it working! thanks a lot for that, at least I know it is possible. I'll try installing it on another of my test forums and see if that makes a difference.

*edit* tried a clean install of SMF 2.0 RC1 and downloaded the latest 1.1.1 of this mod (had 1.1.0 before) but still getting the same problem, hmm.

Sorry to be a pain again but do you think the regex <div class="mxb">(.*)<h3>Bookmark with:<\/h3>~siU would work with this feed - http://newsrss.bbc.co.uk/rss/newsonline_uk_edition/front_page/rss.xml ? I'm still trying to find a way to get the pictures in it too



In addition to this I still have the issue when using my theme (tabs-purple)- all I get is a blank white box when I want to add or edit a feed (see attached) - is there some file within my theme I need to edit to get it to show properly? I couldn't see anything outside of default files etc within the install xml file

Vampy, you probably have a blank screen like that because there is a Modifications.english.php in the languages folder in your Theme directory.  There should not be.  You should copy everything in that file into the Modifications.english.php folder in the default theme language directory, then delete it.

For that feed, you'd want to use: ~<td class="storybody">(.*?)</td>~si and that should get everything.

Thanks SlammedDime but that's what's causing me such a headache with this - there IS no Modifications.english.php file in my themes languages folder, the only thing in there is ThemeStrings.english.php - everything else runs from the default files.

I'll try that string for the BBC feed - fingers crossed :D

Are there any errors in your error log?

From within SMF error logs this is all I have

Apply Filter: Only show the error messages of this URL  http://www.purplehell.com/TestForum/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined index: message
Apply Filter: Only show the errors from this file
File: /home/purplcom/public_html/TestForum/Sources/Subs-Post.php
Line: 1845
   

Apply Filter: Only show the error messages of this URL http://www.purplehell.com/TestForum/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
2: preg_match() [<a href='function.preg-match'>function.preg-match</a>]: Unknown modifier '('
Apply Filter: Only show the errors from this file
File: /home/purplcom/public_html/TestForum/Sources/ScheduledTasks.php
Line: 1723
   


     Apply Filter: Only show the errors of this type Type of error: Undefined
Apply Filter: Only show the error messages of this URL http://www.purplehell.com/TestForum/index.php?action=admin;area=scheduledtasks
Apply Filter: Only show the errors with the same message
8: Undefined index: message
Apply Filter: Only show the errors from this file
File: /home/purplcom/public_html/TestForum/Sources/Subs-Post.php
Line: 1845


Nothing looks suspicious - do you want me to look on the server error logs too?

cronrss.php is not working for me

Can't really help you... this mod doesn't have such a file.

Hi SlammedDime. This is wonderfull mod, but i see now :(.
Whatever i use the mod for wordpress post to my smf forum.
I use regexp :  ~<div class="entry clearfloat">(.*)<\/div>~siU
My feed is : http://www.rockayseri.net/feed
I want to change something. I want to delete post time, because this is not required. And Source code & item link?
You put this code by knowing as i know, but i use this for mysite to mysite. Can you help me with this ? Or can i edit mod files ?

And..
The line spacing is increasing on feeding. This is fixable?

This is working great on my site--http://www.cricketvoice.com/

My only problem is with the big space between the title and text for each post it makes (as I'm planning on using the feed on a CMS to display as articles)

I have 1 feed that has a key word to search for and for whatever reason I keeps getting disabled all by itself ???

Any ideas on this one?

Thanks in advance.

If the feed get's disabled, it should be throwing an error into the error log.  Any errors there related to the feed?

Guest	Today at 07:01:02 PM
	4573e1cc082a0a730df11155f964eaf4
	Type of error: General
	http://monsters-mansion.com/index.php?http://monsters-mansion.com/ (http://monsters-mansion.com/index.php?http://monsters-mansion.com/)
	RSS Feeder: http://www.railbirds.com/rss/latestblogs.php (XML error: XML_ERR_NAME_REQUIRED at line 82, column 27)

This is the only error I see related to the rss feeds

Hi

This is just for anyone who has experienced the same problem as me:

I found the problem and solution for anyone else with this error. Firstly I don't think it is caused by this mod.

If you move an existing topic from a board into the board's child board then the feeder continues to feed to the original board but SMF is smart enough to redirect the feed to the moved topic but not smart enough to reset the new post (on.gif) setting to the child board.

In other words. The next time the feeder makes a post, to the moved topic, the new post icon will be lit on the original board even though it's not in that board but in it's child board. The child board doesn't show the new post (on.gif) icon even though there is a new post in the moved topic. I assume that is a bug with SMF?

However, Updating the link in the RSS Feed setting fixes the problem. 

mrtrc266 - That means the XML file is malformed, nothing I can really do about that.  It's up to the site that publishes the feed to ensure it's done properly.  Any text *should* be wrapped in CDATA tags if it's going to contain any special characters.

Quote from: Groundhog on April 15, 2009, 01:02:47 AM
Hi

This is just for anyone who has experienced the same problem as me:

I found the problem and solution for anyone else with this error. Firstly I don't think it is caused by this mod.

If you move an existing topic from a board into the board's child board then the feeder continues to feed to the original board but SMF is smart enough to redirect the feed to the moved topic but not smart enough to reset the new post (on.gif) setting to the child board.

In other words. The next time the feeder makes a post, to the moved topic, the new post icon will be lit on the original board even though it's not in that board but in it's child board. The child board doesn't show the new post (on.gif) icon even though there is a new post in the moved topic. I assume that is a bug with SMF?

However, Updating the link in the RSS Feed setting fixes the problem. 

It is likely a bug with the mod, something I didn't think about happening.... if you are using the option to throw the feed into a single post, this will happen.  I'll have to dig through the code to remember how I did the attaching to an existing topic and try and fix that.  Thanks.

QuoteIt is likely a bug with the mod, something I didn't think about happening.... if you are using the option to throw the feed into a single post, this will happen.  I'll have to dig through the code to remember how I did the attaching to an existing topic and try and fix that.  Thanks.

This is probably not how most people would use it so possibly might not be worth bothering about. Just thought that I would highlight this for the few people that may use it this way.

The only reason that I did this is because I needed to move the existing topics into a child board after installing the "Childboards Only" mod.

Thanks for the response. I'm enjoying using your mod.

One question--how do I make it so right on top of the post there's no link and repetition of the title.

There must be a file which controls the display?

Thanks.

I Installed the mod, however I do not see a corrosponding section for it in the Admin Panel - where exactly can enter my feeds into the mod?

Edit: I tried going to "index.php?action=admin;area=modsettings;sa=rssfeeds" however I just got redirected back to my main admin page - like the mod didnt install right.

I uninstalled and reinstalled the mod again (no problems) - but I still cannont access the admin page.

Edit 2: It seems the mod wasnt installing its code correctly in managesettings.php - I ran through and did it manually and all is well now.

I have installed this MOD.......

I get the following:-


/* RSS Feeder Settings */ function ModifyRSSFeedSettings() { global $context, $txt, $sourcedir, $scripturl, $smcFunc; loadTemplate('RSSFeeds'); $context['page_title'] = $txt['rss_feeder']; if (!empty($_REQUEST['feed']) && (isset($_REQUEST['enable']) || isset($_REQUEST['disable']))) { // Quick change on the status... $smcFunc['db_query']('', ' UPDATE {db_prefix}rssfeeds SET enabled = {int:option} WHERE id_feed = {int:feed}', array( 'option' => isset($_REQUEST['enable']) ? 1 : 0, 'feed' => (int) $_REQUEST['feed'], ) ); redirectExit('action=admin;area=modsettings;sa=rssfeeds'); } if (!empty($_REQUEST['feed']) || !empty($_REQUEST['add'])) { $context['sub_template'] = 'rss_feeder_add'; // Load the boards and categories for adding or editing a feed. $request = $smcFunc['db_query']('', ' SELECT b.id_board, b.name, b.child_level, c.name AS cat_name, c.id_cat FROM {db_prefix}boards AS b LEFT JOIN {db_prefix}categories AS c ON (c.id_cat = b.id_cat)', array() ); $context['categories'] = array(); while ($row = $smcFunc['db_fetch_assoc']($request)) { if (!isset($context['categories'][$row['id_cat']])) $context['categories'][$row['id_cat']] = array ( 'name' => strip_tags($row['cat_name']), 'boards' => array(), ); $context['categories'][$row['id_cat']]['boards'][] = array( 'id' => $row['id_board'], 'name' => strip_tags($row['name']), 'category' => strip_tags($row['cat_name']), 'child_level' => $row['child_level'], 'selected' => !empty($_SESSION['move_to_topic']) && $_SESSION['move_to_topic'] == $row['id_board'] && $row['id_board'] != $board, ); } $smcFunc['db_free_result']($request); if (empty($context['categories'])) fatal_lang_error('rss_feed_no_boards', false); // If we're just adding a feed, we can return, don't need to do anything further if (empty($_REQUEST['add'])) { // Lets get the feed from the database $request = $smcFunc['db_query']('', ' SELECT * FROM {db_prefix}rssfeeds WHERE id_feed = {int:feed} LIMIT 1', array( 'feed' => ((int) $_REQUEST['feed']), ) ); // No Feed?? ut oh... hacker!! if ($smcFunc['db_num_rows']($request) != 1) fatal_lang_error('rss_feed_not_found', false); $context['rss_feed'] = $smcFunc['db_fetch_assoc']($request); $context['rss_feed'] = htmlspecialchars__recursive($context['rss_feed']); $smcFunc['db_free_result']($request); } $context['icon'] = !empty($context['rss_feed']['icon']) ? $context['rss_feed']['icon'] : 'xx'; require_once($sourcedir . '/Subs-Editor.php'); // Message icons - customized icons are off? $context['icons'] = getMessageIcons(!empty($context['rss_feed']['id_board']) ? $context['rss_feed']['id_board'] : 0); if (!empty($context['icons'])) $context['icons'][count($context['icons']) - 1]['is_last'] = true; $context['icon_url'] = ''; for ($i = 0, $n = count($context['icons']); $i < $n; $i++) { $context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value']; if ($context['icons'][$i]['selected']) $context['icon_url'] = $context['icons'][$i]['url']; } if (empty($context['icon_url'])) { $context['icon_url'] = $settings[file_exists($settings['theme_dir'] . '/images/post/' . $context['icon'] . '.gif') ? 'images_url' : 'default_images_url'] . '/post/' . $context['icon'] . '.gif'; array_unshift($context['icons'], array( 'value' => $context['icon'], 'name' => $txt['current_icon'], 'url' => $context['icon_url'], 'is_last' => empty($context['icons']), 'selected' => true, )); } return; } // What about deleting one or more?? elseif (!empty($_REQUEST['delete'])) { //$_POST['checked_feeds'] // We already asked that they wanted to delete, so we'll just delete... no confirmation foreach ($_POST['checked_feeds'] as $key => $id) $_POST['checked_feeds'][$key] = (int) $id; $smcFunc['db_query']('', ' DELETE FROM {db_prefix}rssfeeds WHERE id_feed IN ({array_int:feed_list})', array( 'feed_list' => $_POST['checked_feeds'], ) ); } // Or are they saving one being modified?? elseif (!empty($_REQUEST['save']) && !empty($_POST['sc'])) { // First we check the session... checkSession(); // Put the insert array together... $insertOptions = array(); // Let's do the 'unrequireds' first... $insertOptions['id_board'] = (int)$_POST['feed_board']; $insertOptions['icon'] = isset($_POST['icon']) ? preg_replace('~[\./\\\\*\':"<>]~', '', $_POST['icon']) : 'xx'; $insertOptions['enabled'] = isset($_POST['feed_enabled']) ? 1 : 0; $insertOptions['keywords'] = trim($_POST['feed_keywords']) != '' ? trim($_POST['feed_keywords']) : ''; $insertOptions['locked'] = isset($_POST['feed_locked']) ? 1 : 0; $insertOptions['getfull'] = isset($_POST['feed_full']) ? 1 : 0; $insertOptions['approve'] = isset($_POST['feed_approve']) ? 1 : 0; $insertOptions['singletopic'] = isset($_POST['feed_singletopic']) ? 1 : 0; $insertOptions['topicprefix'] = trim($_POST['feed_prefix']) != '' ? trim($_POST['feed_prefix']) : ''; $insertOptions['footer'] = !empty($_POST['feed_footer']) ? trim($_POST['feed_footer']) : ''; $insertOptions['numbertoimport'] = trim($_POST['feed_import']) != '' ? (int) trim($_POST['feed_import']) : 0; $context['feed_errors'] = array(); // And now the requireds that we can throw errors on... if (empty($_POST['feed_title'])) $context['feed_errors']['feed_title'] = ($insertOptions['title'] = ''); else $insertOptions['title'] = preg_replace('~[&]([^;]{8}|[^;]{0,8}$)~', '&$1', $_POST['feed_title']); if (empty($_POST['feed_url'])) $context['feed_errors']['feed_url'] = ($insertOptions['feedurl'] = ''); else $insertOptions['feedurl'] = trim($_POST['feed_url']); if (empty($_POST['feed_poster'])) $context['feed_errors']['feed_poster'] = ($insertOptions['postername'] = ''); // Do a query to get the member's id else { $request = $smcFunc['db_query']('', ' SELECT id_member FROM {db_prefix}members WHERE real_name = {string:name} OR member_name = {string:name} LIMIT 1', array( 'name' => trim($_POST['feed_poster']), ) ); if ($smcFunc['db_num_rows']($request) != 1) $context['feed_errors']['feed_poster'] = ($insertOptions['postername'] = trim($_POST['feed_poster'])); else { $insertOptions['postername'] = trim($_POST['feed_poster']); list($insertOptions['id_member']) = $smcFunc['db_fetch_row']($request); } $smcFunc['db_free_result']($request); } $insertOptions['regex'] = trim($_POST['feed_regex']); if (!empty($insertOptions['getfull']) && empty($insertOptions['regex'])) $context['feed_errors']['feed_regex'] = ''; // if we had any errors, lets kick back a screen and highlight them... if (!empty($context['feed_errors'])) { $context['rss_feed'] = $insertOptions; if (!empty($_POST['feed_id'])) $_REQUEST['feed'] = $_POST['feed_id']; $_REQUEST['add'] = true; return ModifyRSSFeedSettings(); } // Looks like we're good. // Modifying an existing feed? if (!empty($_REQUEST['feed_id'])) { $smcFunc['db_query']('',' UPDATE {db_prefix}rssfeeds SET id_board = {int:id_board}, feedurl = {string:feedurl}, title = {string:title}, icon = {string:icon}, enabled = {int:enabled}, postername = {string:postername}, id_member = {int:id_member}, keywords = {string:keywords}, regex = {string:regex}, locked = {int:locked}, getfull = {int:getfull}, approve = {int:approve}, singletopic = {int:singletopic}, topicprefix = {string:topicprefix}, footer = {string:footer}, numbertoimport = {int:numbertoimport} WHERE id_feed = {int:id_feed}', array_merge(array('id_feed' => (int)$_REQUEST['feed_id']), $insertOptions) ); $context['feed_insert_success'] = $txt['rss_feed_update_success']; } // Or I guess we're inserting a new one else { // Fix up the stuff for insertion, make sure the arrays are aligned $insertRows = array( 'singletopic' => 'int', 'icon' => 'string', 'footer' => 'string', 'getfull' => 'int', 'id_board' => 'int', 'feedurl' => 'string', 'title' => 'string', 'enabled' => 'int', 'postername' => 'string', 'id_member' => 'int', 'keywords' => 'string', 'regex' => 'string', 'locked' => 'int', 'approve' => 'int', 'topicprefix' => 'string', 'numbertoimport' => 'int' ); ksort($insertRows); ksort($insertOptions); $smcFunc['db_insert']('', '{db_prefix}rssfeeds', $insertRows, $insertOptions, array('id_feed') ); $id_feed = $smcFunc['db_insert_id']('{db_prefix}rssfeeds', 'id_feed'); if (empty($id_feed)) $context['feed_insert_error'] = $txt['rss_feed_insert_error']; else $context['feed_insert_success'] = $txt['rss_feed_insert_success']; } } // If they deleted or saved, let's show the main list $context['sub_template'] = 'rss_feeder_list'; // Create the table that will display the feeds $listOptions = array( 'id' => 'rss_feeder_list', 'items_per_page' => 40, 'default_sort_col' => 'icon', 'base_href' => $scripturl . '?action=admin;area=modsettings;sa=rssfeeds', 'no_items_label' => $txt['rss_feed_none'], 'get_items' => array( 'function' => 'list_getFeeds', ), 'get_count' => array( 'function' => 'list_getNumFeeds', ), 'columns' => array( 'icon' => array( 'header' => array( 'value' => $txt['rss_feed_enabled'], ), 'data' => array( 'function' => create_function('$rowData', ' global $settings, $scripturl, $smcFunc, $txt; if (empty($rowData[\'name\']) && $rowData[\'enabled\']) { $smcFunc[\'db_query\'](\'\', \' UPDATE {db_prefix}rssfeeds SET enabled = 0 WHERE id_feed = {int:feed}\', array( \'feed\' => $rowData[\'id_feed\'], ) ); // Log an error about the issue, just so the user can see why their feed was disabled... log_error($txt[\'rss_feeder\'] . \': \' . $rowData[\'title\'] . \' (\' . $txt[\'rss_feed_board_error\'] . \')\'); $rowData[\'enabled\'] = 0; } return \'\';' ), 'style' => 'text-align: center; width: 130px;', ), 'sort' => array( 'default' => 'f.enabled', 'reverse' => 'f.enabled DESC', ), ), 'title' => array( 'header' => array( 'value' => $txt['rss_feed_title'], ), 'data' => array( 'db' => 'title', 'style' => 'text-align: center;', ), 'sort' => array( 'default' => 'f.title', 'reverse' => 'f.title DESC', ), ), 'url' => array( 'header' => array( 'value' => $txt['rss_feed_url'], ), 'data' => array( 'sprintf' => array( 'format' => '%1$s', 'params' => array( 'feedurl' => true, ), ), ), 'sort' => array( 'default' => 'f.feedurl', 'reverse' => 'f.feedurl DESC', ), ), 'board' => array( 'header' => array( 'value' => $txt['rss_feed_board'], ), 'data' => array( 'function' => create_function('$rowData', ' global $txt; return empty($rowData[\'name\']) ? \'<< \' . $txt[\'rss_feed_board_error\'] . \' >>\' : $rowData[\'name\'];' ), 'style' => 'text-align: center;', ), 'sort' => array( 'default' => 'b.name', 'reverse' => 'b.name DESC', ), ), 'count' => array( 'header' => array( 'value' => $txt['rss_feed_count'], ), 'data' => array( 'db' => 'importcount', 'style' => 'text-align: center;', ), 'sort' => array( 'default' => 'f.importcount', 'reverse' => 'f.importcount DESC', ), ), 'modify' => array( 'header' => array( 'value' => $txt['rss_feed_modify'], ), 'data' => array( 'sprintf' => array( 'format' => '' . $txt['rss_feed_modify'] . '', 'params' => array( 'id_feed' => false, ), ), 'style' => 'text-align: center; width: 50px;', ), ), 'check' => array( 'header' => array( 'value' => '', ), 'data' => array( 'sprintf' => array( 'format' => '', 'params' => array( 'id_feed' => false, ), ), 'style' => 'text-align: center; width: 32px;', ), ), ), 'form' => array( 'href' => $scripturl . '?action=admin;area=modsettings;sa=rssfeeds', 'name' => 'rssfeedForm', ), 'additional_rows' => array( array( 'position' => 'above_column_headers', 'value' => ' ', 'style' => 'text-align: right;', 'class' => 'titlebg', ), array( 'position' => 'below_table_data', 'value' => ' ', 'style' => 'text-align: right;', 'class' => 'titlebg', ), ), ); require_once($sourcedir . '/Subs-List.php'); createList($listOptions); } // Get information for the list above... grabs all of the feeds from the database function list_getFeeds($start, $items_per_page, $sort) { global $smcFunc; $request = $smcFunc['db_query']('', ' SELECT f.id_feed, b.name, f.title, f.feedurl, f.enabled, f.importcount FROM {db_prefix}rssfeeds AS f LEFT JOIN {db_prefix}boards AS b ON (b.id_board = f.id_board) ORDER BY {raw:sort} LIMIT ' . $start . ', ' . $items_per_page, array ( 'sort' => $sort, ) ); $feeds = array(); while ($row = $smcFunc['db_fetch_assoc']($request)) $feeds[] = $row; $smcFunc['db_free_result']($request); return $feeds; } // The number grabbed above could be limited at 40... this just gets a count of all of them. function list_getNumFeeds() { global $smcFunc; $request = $smcFunc['db_query']('', ' SELECT COUNT(*) FROM {db_prefix}rssfeeds', array( ) ); list($numFeeds) = $smcFunc['db_fetch_row']; $smcFunc['db_free_result']($request); return $numFeeds; }

@ Verso in Sources/ModSettings.php you need to put this ?> at the very bottom of the file.

SD

Any chance of adding a "post expire" and "auto delete" function like the one available in WordPress?

Ideally it would need to be part of the feed admin - Some of my feeds have a post life-span of just 24 hours

I could really use such a feature for some of my feeds - the manual sort and delete is getting ridiculous

Thanks
Gaz

It's possible... would require another scheduled task and a bit more database work.  I'll think about it for the next version, but no promises.

Quote from: mrtrc266 on April 17, 2009, 10:19:37 AM
@ Verso in Sources/ModSettings.php you need to put this ?> at the very bottom of the file.

I don't seem to have a file of this name.........

Try Sources/ManageSettings.php

Quote from: SlammedDime on April 18, 2009, 03:45:49 PM
It's possible... would require another scheduled task and a bit more database work.  I'll think about it for the next version, but no promises.

That would be very much appreciated ... and I won't hold you to it

Quote from: SlammedDime on April 19, 2009, 05:59:52 AM
Try Sources/ManageSettings.php

I tried that.......

I have included my ManageSettings.php


Hopefully one of you kind people will have a look at it for me

Here you go, the ?> was in there twice

Thanks........

Nearly there...........

Just got a white screen now

In you original file from right after you installed the mod find
?>

and move to the very end of the file

What I done was reinstalled then re-uploaded the file you altered and hey presto it worked.......


Thanks

No problem, glad you got it going

This mod doesn't work for my 2.0 version.

without any more detail, i can't really help you.

hey  guys i in stalled the RSS Feeder im using 2.0rc1 installed great but when i got redirected i got this at the top (pic1)and (pic2) you can see it not there please help me fig it out

Can you upload your /themes/default/languages/modification.{yourlanguage}.php

Rather than upload it here, just open it locally, and make sure there is only ?> and it is located at the very end of the file.

sure i look at the file and ?> is there so here is the file

Odd... that file looks fine to me... and you're still having an issue with it?

yes i have deleted it  reinstalled it  5 times and i have re phased it 2 times just to make sure

let me ask you this where is the   add_settings.php  file located maybe its not open  to execute

add_settings doesn't look like the issue, but it's in the archive with all of the other files.

Do you have any other languages, like english-utf8?

it looks good too

Not really... it's missing the opening <?php tag... Not sure if that is part of the problem, but it's worth correcting to see...

thanks ill check in a bit i got to to stop looking at the screen

If that didn't work, you can try using the file_check.php file attached to this post and see if you can figure out where the extraneous code is... http://www.simplemachines.org/community/index.php?topic=300626.msg1989826#msg1989826

Great  Mod, Thanx a lot.

Here is an Arabic translation:

Modifications.arabic-utf8.php

Find:
?>

Add before:

/* RSS Feeder */
$txt['mods_cat_modifications_rssfeeds'] = 'الأخبار العاجلة (RSS)';
$txt['rss_feeder'] = 'الأخبار العاجلة (RSS)';
$txt['rss_feeder_desc'] = 'هذا القسم يسمح لك بإعداد وعرض الأخبار العاجلة (RSS) التي أرسلت للمنتدى.';
$txt['rss_feed_enabled'] = 'السماح بها';
$txt['rss_feed_title'] = ' الأسم الجهة المغذية';
$txt['rss_feed_title_desc'] = 'هذا يجب أن يكون العنوان الداخلي للجهة التي تقوم بتغذية الأخبار العاجلة.';
$txt['rss_feed_url'] = 'رابط الجهة المغذية';
$txt['rss_feed_url_desc'] = 'ينبغي أن يكون هذا رابط صحيح للجهة المغذية بالأخبار العاجلة(RSS). إذا وجده المعرب اللغوي  غير صحيح، سيقوم بإلغائه.';
$txt['rss_feed_poster'] = 'المشاركة بالأخبار العاجلة كـ (إسم العضو)';
$txt['rss_feed_poster_desc'] = 'أدخل كيف ستكون المشاركة بالأخبار العاجلة.';
$txt['rss_feed_prefix'] = 'مقدمة الموضوع';
$txt['rss_feed_prefix_desc'] = 'إذا رغبت بمقدمات هذه المشاركات للأخبار العاجلةو أدخل أحدهم هنا. هذه الخاصية إختيارية';
$txt['rss_feed_import'] = 'العدد للإستيراد';
$txt['rss_feed_import_desc'] = 'يمكنك تحديد العدد للأخبار المستوردة لكل حمل. 0 لهم جميعاً.';
$txt['rss_feed_locked'] = 'الموضوع مغلق';
$txt['rss_feed_approve'] = 'يتطلب الموافقة على الخبر';
$txt['rss_feed_full_article'] = 'إستيراد كامل الخبر';
$txt['rss_feed_singletopic'] = 'شارك بالأخبار في موضوع واحد';
$txt['rss_feed_regex'] = 'التعابير المعتادة';
$txt['rss_feed_regex_desc'] = 'مطلوب عند إستيراد الأخبار الكاملة. هذا يجب أن يكون على هيئة <a href-"http://us.php.net/manual/en/book.pcre.php">PCRE</a>. المتوافق متوقع أن يكون في الفهرس الثاني من  المصفوفة([1]).';
$txt['rss_feed_keywords'] = 'كلمات رئيسيه للبحث عنها';
$txt['rss_feed_keywords_desc'] = 'إذا أردت إستيراد أخبار عاجلة تحتوي على كلمات رئيسية محددة، أدخل هذه الكلمات مع فواصل بينهم(مثال: كلمة1, كلمة2).';
$txt['rss_feed_board'] = 'المنتدى';
$txt['rss_feed_modify'] = 'تعديل';
$txt['rss_feed_none'] = 'لا توجد أخبار عاجلة للعرض';
$txt['rss_feed_add'] = 'إضافة جهة مغذية للأخبار';
$txt['rss_feed_delete'] = 'حذف المحدد';
$txt['rss_feed_confirm'] = 'هل أنت متأكد من حذف الجهة المحددة?';
$txt['rss_feed_not_found'] = 'لا يمكن العثور على هوية هذه الجهة.';
$txt['rss_feed_no_boards'] = 'لا يوجد منتدى للمشاركة بالأخبار العاجلة به.';
$txt['rss_feed_add_error'] = 'المعلومات البارزة باللون الأحمر مطلوبة';
$txt['rss_feed_insert_error'] = 'لم تتم عملية إدخال الأخبار بنجاح';
$txt['rss_feed_insert_success'] = 'تم إنشاء الأخبار العاجلة بنجاح';
$txt['rss_feed_update_success'] = 'تم تعديل الأخبار العاجلة بنجاح';
$txt['scheduled_task_desc_rss_feeder'] = 'إستيراد الأخبار العاجلة المعدة مسبقاً.';
$txt['scheduled_task_rss_feeder'] = 'الأخبار العاجلة (RSS)';
$txt['pruneRssFeedLog'] = 'إزالة مغذي الأخبار العاجلة (RSS) الأقدم من :<div class="smalltext">(0 للإلغاء)</div>';
$txt['rss_feed_footer'] = 'هامش النص';
$txt['rss_feed_footer_desc'] = 'إذا أردت أي نص أن يكون بعد الخبر العاجل، فضلاً أدخله هنا. أي رموز لـ BBC مسموح بها';
$txt['rss_feed_count'] = 'المشاركات';
$txt['rss_feed_board_error'] = 'لا يوجد منتدى';
/*RSS Feeder */




3wasef.com (http://3wasef.com)

QuoteRegular Expression
Required if retrieving full article. This must be PCRE format. The match is expected to be in second index of the array ([1]).

What is that and where do i get that? Feed what im using is

http://feeds2.feedburner.com/uutiset-terveys_ja_hyvinvointi
http://feeds2.feedburner.com/uutiset-terveys_ja_hyvinvointi?format=xml

edit: and i want to translate those dates and that "Sourse:" part in posts. Where do i find them?

Quote from: Bigguy on January 11, 2009, 03:37:41 PM
I have it running here and it works great, thanks SlammedDime.

http://forum.pctweakr.com/index.php/board,3.0.html (http://forum.pctweakr.com/index.php/board,3.0.html)

That looks perfect. How do you have removed that Source part?

Mine looks like this:

Quote
Vähemmän keskeytyksiä, enemmän tulosta (Mediuutiset)
4 May 2009, 11:01 am

Vähemmän keskeytyksiä, enemmän tulosta (Mediuutiset)

Source: Terveys ja hyvinvointi - Uutiset - Ampparit.com

For the 'Source' bit, I don't think I was thinking and hardcoded the string in there when I was testing and forgot to change it... it's in ScheduledTasks.php

As for the date format, in order to normalize any possible feed, SimplePie reformats the date, so I just spit out how it reformatted it... I suppose I could change it to use the forum's default time conversion function.

As for the regular expression, there is a small tutorial in this topic that is linked in the first post of the topic that I'd suggest reading first... no sense in reiterating all the same stuff.  If you have questions after that, feel free to ask.

Any idea why this isnt working urls like this?
http://www.helistin.fi/rss/
http://www.tohtori.fi/rss/

I have two smf forums of same 2.0. RC1 version.

If i need to update one board in one forum.

And the second forum need to grab the post in the other forums board of smf.

Then what is the Relative full path or Regular Expression i have to use.

Quote from: Owdy on May 05, 2009, 06:38:57 AM
Any idea why this isnt working urls like this?
http://www.helistin.fi/rss/
http://www.tohtori.fi/rss/

Any errors in the error log?

Quote from: A.SK on May 05, 2009, 01:52:05 PM
I have two smf forums of same 2.0. RC1 version.

If i need to update one board in one forum.

And the second forum need to grab the post in the other forums board of smf.

Then what is the Relative full path or Regular Expression i have to use.

I'm afraid there is no easy way to do that that I can think of.

Quote from: SlammedDime on May 05, 2009, 03:28:52 PM

Quote from: Owdy on May 05, 2009, 06:38:57 AM
Any idea why this isnt working urls like this?
http://www.helistin.fi/rss/
http://www.tohtori.fi/rss/

Any errors in the error log?

None.

Quote from: SlammedDime on May 05, 2009, 03:28:52 PM
I'm afraid there is no easy way to do that that I can think of.

Its possible. Both the sites were my own.

So i could do it, kindly give me out the relative path for getting full content from smf 2.0 rc1 forum.

I suggest you to use UserID when selecting user than will post news. I got board with non-latin letters in usernames and so i can't use them.

It should work fine with UTF-8, what was going wrong when you tried?

A.SK - It's not a matter of where the sites are located... I can't find a good regex that will accomplish what you need.

I'm having the exact same problem as chefjohnnie.

Was there a solution for this?

Quote from: SlammedDime on April 30, 2009, 08:03:20 PM
If that didn't work, you can try using the file_check.php file attached to this post and see if you can figure out where the extraneous code is... http://www.simplemachines.org/community/index.php?topic=300626.msg1989826#msg1989826

Quote from: SlammedDime on May 06, 2009, 04:24:51 PM
It should work fine with UTF-8, what was going wrong when you tried?

I just couldn't get name to be understood by the feeder. It showed me that name has to be filled in. When I renamed account into latin letter everything worked.

Can you PM me the name if you don't want to post it here so I can test with it?