Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: SoLoGHoST on August 20, 2009, 09:08:18 AM

Title: PM Attachments
Post by: SoLoGHoST on August 20, 2009, 09:08:18 AM
Link to Mod (https://custom.simplemachines.org/mods/index.php?mod=1974)


PM ATTACHMENTS V2.6
Originally By SoLoGHost (http://www.simplemachines.org/community/index.php?action=profile;u=198712) -> Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=1974)
Taken Over By Dougiefresh (http://www.simplemachines.org/community/index.php?action=profile;u=253913)


Introduction
Gives your users the ability to attach files and send them to other members via Personal Messages.  Based from the same code used to display attachments via posts.  Completely secure!  Only users who have sent or received these files are able to view and/or download them based on their View Attachments Permission for the usergroup they belong to.  Administrators don't even have access to these attachments, unless you report the PM to them via "Report to Admin" link if enabled in Admin Settings.

Important Note:  To ensure PM Attachment Settings are correctly placed and loaded, you will be redirected so that your File Cache will be cleared, directly after installing PM Attachments.  After which, go to: [p]Admin[/b] => Forum => Attachments and Avatars => PM Attachment Settings and complete setup.  Than make sure you have your permissions set for each usergroup.  You will notice the permissions for PM Attachments have been added to the Personal Message Permissions.

Admin Settings
There are two new areas underneath the Admin => Forum => Attachments and Avatars area, called:
o PM Attachments => All options relating to PM attachment functionality
o PM File Maintenance => All maintenance options (moved from File Maintenance tab)

Two new permissions have been added to the Admin => Members => Permissions area:
o View PM Attachments
o Upload PM Attachments

Compatibility Notes
This mod was tested on SMF 2.0.13 and SMF 2.1 Beta 3, but should work on SMF 2.0.3 and up.  SMF 1.x is not and will not be supported.

Translators
> SoLoGHoST (http://www.simplemachines.org/community/index.php?action=profile;u=198712) - English translation
> Bugo (http://www.simplemachines.org/community/index.php?action=profile;u=229017) - Russian translation

Changelog
The changelog has been removed and can be seen at XPtsp.com (http://www.xptsp.com/board/index.php?topic=849.msg1483#msg1483).

License
Quote
Copyright (c) 2009 to 2016, Solomon Closson (aka SoLoGHoST)
Copyright (c) 2017, Solomon Closson (aka SoLoGHoST) and Douglas Orend
All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
Title: Re: PM Attachments
Post by: Dzonny on August 20, 2009, 11:08:44 AM
Nice one SoLoGHoST, i like it...
Will you integrate this with 1.1.10 version maybe?
Title: Re: PM Attachments
Post by: JungleBunny on August 22, 2009, 10:27:21 AM
Jep, the costs would not be the biggest problem 8)
Would need this mod for 1.1.xxxxx, too. :)
Title: Re: PM Attachments
Post by: Sudhakar Arjunan on August 25, 2009, 02:42:35 PM
Excellent mod.

I will be installing my forum now.
Title: Re: PM Attachments
Post by: SoLoGHoST on August 25, 2009, 10:18:28 PM
Thank You!
Title: Re: PM Attachments
Post by: Yağız... on August 27, 2009, 06:58:47 PM
Ok, have given this some more thought and kinda in a good mood today... so will do this for SMF 1.1.x for FREE as it will help me get more familiar with 1.1.x versions of SMF.  Just 1 condition...  Need someone to set up a site with SMF 1.1.10 freshly installed on it with all DEFAULT settings (with No MODs installed, and in English language), give me FTP access to it, and setup an Admin Account for me on this forum as well as have PhpMyAdmin installed so that I can check the database for the forum if needed.  Will need account and passwords for the following:  PhpMyAdmin, Forum, and FTP.  You can PM me all of the details.  Will be doing all of my testing for a PM Attachments MOD compatible with SMF 1.1.x at this forum, so will need it to remain up while I test and code for it.  I could use my server for this, however, would rather not, which is why, if someone is willing to do this, I will do it for FREE!

Cheers :)
Solomon
I can help you but why not making them on a localhost?
Title: Re: PM Attachments
Post by: SoLoGHoST on August 30, 2009, 04:27:43 AM
New update - Version 1.4.  Added by REQUEST direct links for all attachments via PM sent to email addy if the user has "Notify by email every time you receive a personal message" set to Always within their Profile -> Personal Messaging Options.
Title: Re: PM Attachments
Post by: TheListener on September 01, 2009, 07:49:58 PM
Sologhost

I found this mod in the Mod of the Month topic.

Have installed it already with no problems at all.
Title: Re: PM Attachments
Post by: SoLoGHoST on September 01, 2009, 08:53:50 PM
Glad to hear that.  Where is the Mod of the Month topic?
Title: Re: PM Attachments
Post by: Arantor on September 04, 2009, 09:29:46 PM
Note that any mod installed after this one that modifies the help files will cause a fatal error due to the last line of the help modifications in this mod not being terminated with a semicolon.

The line in question:
Code: [Select]
$helptxt['pmattachments_remove_all'] = 'This will remove all PM Attachments from and sent to all members, including yourself.  Should be used as a last resort.<br /><br />Some scenario\'s that may warrant a need for you to do this, are as follows:<br />If you just don\'t have the space on your server for these files anymore.  If you plan on starting fresh and/or want to reduce or increase the size for the PM Attachments Directory, or change the directory and you don\'t want any files in this directory before you make any changes.  If many users are abusing the use of PM Attachments on your server, and many other reasons for this as well.'
Title: Re: PM Attachments
Post by: SoLoGHoST on September 05, 2009, 09:31:01 AM
WoW, thanks for pointing that out Arantor, just now fixed and re-upped. :-[

Cheers :)
Title: Re: PM Attachments
Post by: cme1st2302 on September 08, 2009, 11:02:43 PM
I would be interested in having this work for 1.1.X as well.  What kind of price are we talking about here though?

Chris
Title: Re: PM Attachments
Post by: JungleBunny on September 10, 2009, 07:04:22 AM
The price is OK.
When do we have our 10 people ?! :D
Title: Re: PM Attachments
Post by: [̲̅J̲̅][̲̅U̲̅][̲̅R̲̅][̲̅E̲̅][̲̅K̲̅] ٩(×̯×)۶ on September 13, 2009, 08:00:53 PM
Nice one SoLoGHoST, i like it...
Will you integrate this with 1.1.10 version maybe?

Just wanted to ask the same question...
Title: Re: PM Attachments
Post by: SoLoGHoST on September 13, 2009, 10:01:36 PM
Are you saying you are willing to pay 30 US Dollars for an SMF 1.1.10 Compatible version of the PM Attachments MOD with 1 year FREE Updates??  If so, you make 2 people.  Let me know either way.

Cheers :)
Title: Re: PM Attachments
Post by: allisondk on September 30, 2009, 11:47:30 AM
Hi, awesome mod.

I´m using 2.0RC1-1 and have set it up some days ago.

Now members will need to send a file to me, but i cant seem to open up the files (.rar) just jumps me back onto login screen.

Any idea whats wrong?
Title: Re: PM Attachments
Post by: SoLoGHoST on September 30, 2009, 09:55:48 PM
Make sure you are logged in, and try again.  Also, you can try deleting the following code from within ./Sources/PersonalMessage.php file, within the PMDownload() function:
Code: [Select]
// No guests allowed!
is_not_guest();
It's just in there for extra security, but doesn't need to be there as it just brings users who are not logged in to the login screen.  So omitting it should just bring up an error message instead.

Try the following and let me know how this works for ya k?

Cheers :)
Title: Re: PM Attachments
Post by: allisondk on October 01, 2009, 01:05:29 AM
Thanks for the reply appriciate it

First off, i´m logged in either as admin or a member allowed to add attachments and read them.

However the only thing i can find is this:
Code: [Select]
// This helps organize things...
function MessageMain()
{
global $txt, $scripturl, $sourcedir, $context, $user_info, $user_settings, $smcFunc;

// No guests!
is_not_guest();

// You're not supposed to be here at all, if you can't even read PMs.
isAllowedTo('pm_read');

Its basicly below all the VOIDS in the Personalmessages.php, but i dont see it within the PMDownload() function :S
Title: Re: PM Attachments
Post by: SoLoGHoST on October 01, 2009, 01:34:23 AM
Hello again, if you installed this MOD you will see it in the PersonalMessage.php file just under function PMDownload() as the pic attached shows, as I just now did a quick parse on PM Attachments and located the code for you.  I suggest you have another look.  Should be kinda close to the bottom of the file.

Refer to pic attached!
Title: Re: PM Attachments
Post by: samurai-lupin on October 15, 2009, 02:22:41 AM
I woudld buy it, too!
Title: Re: PM Attachments
Post by: samurai-lupin on October 22, 2009, 11:24:03 AM
Yes, I definately would buy it!
Title: Re: PM Attachments
Post by: C4G-TK on November 09, 2009, 06:04:21 PM
What is the reason for the scroll bar when there is no information that is shown in the post when adding an attachment?

I'm using this on a test site of RC2 and only have like 5 mods installed right now on the default (Curve) theme.

diceroller
member color link
google analytics
dynamic memberlist
pm attachements


Pic shown below...
Title: Re: PM Attachments
Post by: drhamza on November 09, 2009, 10:33:36 PM
hello there, i'm trying to re-install the mod after updating to rc2, and this is what i get:
Duplicate entry 'pmAttachmentSizeLimit' for key 1
File: /home2/jumssnet/public_html/forum/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211

help me please, thanks in advance
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2009, 08:25:38 AM
hello there, i'm trying to re-install the mod after updating to rc2, and this is what i get:
Duplicate entry 'pmAttachmentSizeLimit' for key 1
File: /home2/jumssnet/public_html/forum/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211

help me please, thanks in advance

OK, this means that this row is already in your settings table pmAttachmentSizeLimit.  Did you uninstall PM Attachments before updating to RC2?  If not, you can just open up pmAttachmentsInstallRC2.php and remove the following:
Code: [Select]
// Insert the settings
$smcFunc['db_insert']('insert',
            '{db_prefix}settings',
            array(
'variable' => 'string', 'value' => 'string',
),
            array(
                   array('pmAttachmentSizeLimit', '150'),
                   array('attachmentPMLimit', '200'),
                   array('attachmentNumPerPMLimit', '2'),
                   array('pmAttachmentDirSizeLimit', '10240'),
   array('pmAttachmentUploadDir', $boarddir . '/pm_attachments'),
                   array('pmAttachmentExtensions', 'doc,gif,jpg,mpg,pdf,png,txt,zip'),
   array('pmAttachmentCheckExtensions', '0'),
                   array('pmAttachmentShowImages', '1'),
   array('pmAttachmentEnable', '1'),
                   array('pmAttachmentEncryptFilenames', '1'),
   array('pmAttachmentThumbnails', '1'),
                   array('pmAttachmentThumbWidth', '150'),
   array('pmAttachmentThumbHeight', '150'),
            ),
array('variable')
        );
SAVE and rezip it up and try again.
Title: Re: PM Attachments
Post by: drhamza on November 10, 2009, 09:49:44 AM
aha, it's working now :D
thanks a lot man
Title: Re: PM Attachments
Post by: drhamza on November 10, 2009, 10:06:33 AM
i'm getting this when i open the messages
Unknown column 'pa.pm_report' in 'field list'
File: /home2/jumssnet/public_html/forum/Sources/PersonalMessage.php
Line: 847
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2009, 11:07:24 AM
Ok, quick fix.  And make sure you use the original pmAttachmentsUninstallRC2.php and pmAttachmentsInstallRC2.php files from the actual download on SMF.

Upload pmAttachmentsUninstallRC2.php to your Root SMF Folder where SSI.php is, run it in your browser once.  Than upload pmAttachmentsInstallRC2.php to the same folder where SSI.php is, run it in your browser once.  Remove both files from your root, also, open up pm_attachments folder from your root, and remove any files in there EXCEPT:  .htaccess and index.php, and it should now work perfect.

Cheers :)
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2009, 05:45:30 PM
What is the reason for the scroll bar when there is no information that is shown in the post when adding an attachment?

I'm using this on a test site of RC2 and only have like 5 mods installed right now on the default (Curve) theme.

diceroller
member color link
google analytics
dynamic memberlist
pm attachements


Pic shown below...
Ok, I have tested this and seems to do the same for me.  So I'll have a deeper look into this when I get a chance.

Thanks for pointing this out,
Cheer :)
Title: Re: PM Attachments
Post by: drhamza on November 10, 2009, 08:49:47 PM
it works!
but, i'm having it like this now (attachment)
edit: and the send, spelling check, preview, Save a copy in my outbox, shortcuts: hit shift+alt+s to submit/post or shift+alt+p to preview
are all up, below the forum tree
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2009, 10:33:41 PM
Can you attach you PersonalMessage.template.php file and I'll have a look at it for you and edit it so it displays properly.

Cheers :)
Title: Re: PM Attachments
Post by: drhamza on November 10, 2009, 10:53:20 PM
:)
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2009, 10:55:33 PM
What is the reason for the scroll bar when there is no information that is shown in the post when adding an attachment?

I'm using this on a test site of RC2 and only have like 5 mods installed right now on the default (Curve) theme.

diceroller
member color link
google analytics
dynamic memberlist
pm attachements


Pic shown below...

Ok, here are the edits you can do to ./Themes/default/PersonalMessage.template.php yourself to fix this (Note:  will be updating very soon with this fix and another display fix):

FIND:
Code: [Select]
<div id="post_', $message['id'], '_footer" class="attachments">';
REPLACE WITH:
Code: [Select]
<div id="msg_', $message['id'], '_footer" class="attachments smalltext">';
FIND:
Code: [Select]
<div style="overflow: ', $context['browser']['is_firefox'] ? 'visible' : 'auto', '; width: 100%;">';
REPLACE WITH:
Code: [Select]
<div style="overflow: ', $context['browser']['is_firefox'] ? 'visible' : 'auto', ';">';
There, that should do it now.  Also, going to fix the display of how it looks when adding attachments to New Personal Messages, as it's a little off IMO.  So will be updating very soon.

Cheers :)
Title: Re: PM Attachments
Post by: C4G-TK on November 10, 2009, 11:42:20 PM
Cool deal, I'll install the new one when you get it done and try it out again.
Title: Re: PM Attachments
Post by: drhamza on November 10, 2009, 11:51:48 PM
sologohost, i attached the file my previous post :D
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2009, 11:54:55 PM
sologohost, i attached the file my previous post :D

Ok, have edited it some, try the 1 attached.  Let me know how this works for you.  Includes all of the display fixes that will be included in the next revision bout to be updated in a few...

EDIT:  Ofcourse I only edited the code that pertains to PM Attachments, all other code was untouched.  So if there is a deeper problem that's on you to fix.
Title: Re: PM Attachments
Post by: SoLoGHoST on November 11, 2009, 12:13:29 AM
Ok, have just updated it on the MOD Site with all of the Display issues you all mentioned FIXED!

Cheers and ENJOY! :)
Title: Re: PM Attachments
Post by: drhamza on November 11, 2009, 02:19:06 AM
thank you very much man, as usual; great work :D
Title: Re: PM Attachments
Post by: JustOneOldMan on November 11, 2009, 05:03:33 PM
SoLoGHoST, have you gotten enough people interested in a version for 1.1.10 yet?  I'd also be willing to pay for this.  Otherwise, I'm thinking seriously about moving up to v2, but would rather not quite yet just for this feature...
Title: Re: PM Attachments
Post by: JustOneOldMan on November 11, 2009, 10:59:14 PM
Thanks.  I don't always get a chance to check in here, so if I miss it feel free to email me...
Title: Re: PM Attachments
Post by: recived on November 12, 2009, 05:08:56 PM
Hello, tell me where the delete message with an attachment then it is deleted from the server?
Title: Re: PM Attachments
Post by: SoLoGHoST on November 12, 2009, 06:42:10 PM
Hello, tell me where the delete message with an attachment then it is deleted from the server?
Huh??
Please review the pics attached with the mod.  All of them.  If you go in Admin Panel => Attachments and Avatars => File Maintenance you will see pruning options for PM Attachments.  You can not see attachments on a per pm basis as this would be invasion of privacy, so you only have these options in here when pruning files.

Well, hopefully this answers your question(s).

Cheers :)
Title: Re: PM Attachments
Post by: recived on November 12, 2009, 10:58:17 PM
Thanks
Title: Re: PM Attachments
Post by: busterone on November 12, 2009, 11:02:41 PM
Nice mod SoLoGHoST. Installed and works as it should. :)
Title: Re: PM Attachments
Post by: hansdampf on November 18, 2009, 07:14:29 AM
First of all great work and thanks for that!

I'm currently using v 1.3 and want to upgrade to 1.4. Now I'm wondering how I should be doing this upgrade. Usually I would delete the old mod first and then install the updated one. However, if i click 'Uninstall' it says:

Quote
Uninstalling PM Attachments will completely UNINSTALL this MOD, removing only the pm_attachments folder and all files located in there, in your main SMF Root directory.

I really don't think that this is what I want...  ;D

Please advise! Cheers!
Title: Re: PM Attachments
Post by: SoLoGHoST on November 18, 2009, 12:29:05 PM
This is upgradable, do not remove your 1.3 version.  And just to be sure, backup your database and the pm_attachments folder (as I always do, even for my mods... hehe).  Keep it installed.  Download the new PM Attachments 1.4, and add it, it should ask you to upgrade for 1.4, click to upgrade.  There, all done.  Everything should be fine and you should still be able to see your attachments from 1.3.
Title: Re: PM Attachments
Post by: JustOneOldMan on December 20, 2009, 04:47:00 PM
Hey SoLo, just checking in to see if there's any progress on the 1.1.x version.  Not rushing, just checking... ;)
Title: Re: PM Attachments
Post by: SoLoGHoST on December 20, 2009, 07:29:38 PM
Yes, no probs.  I'm still working on the 1.1.x.  Though I've made much progress on it, just kinda put it down temporarily and will get back to it.  Currently coding a few mods at once here.  The biggest one being Dream Portal.  So this is a bit hectic, but should have a 1.1.x version of this mod out shortly.  Just can't put a date and/or timeframe on it.  Sorry and Thanks for checking up on me with this.

Cheers :)
Title: Re: PM Attachments
Post by: JustOneOldMan on December 21, 2009, 02:03:38 AM
Thanks SoLo, appreciate the update.  Now I have to go check out Dream Portal...
Title: Re: PM Attachments
Post by: SoLoGHoST on December 21, 2009, 05:20:53 AM
Thanks SoLo, appreciate the update.  Now I have to go check out Dream Portal...
Hehe, you'll definitely want to check it out as soon as it is made public bro..  I'll keep you updated.  As a Core Developer, I don't expect it to be Publicly Released until, atleast, another month or 2 at this rate.  But you never actually know, sometimes progress has a way of creepin' up on you when you aren't expecting it.

Cross My Fingers ;)

Cheers :)
Title: Re: PM Attachments
Post by: JustOneOldMan on December 21, 2009, 03:51:24 PM
Good luck with it.  I took a look at the DP site, looks good.  I've been using TP on my 1.x.x sites for quite a while, but have been looking for something for the 2.x sites and hadn't found anything I really liked.  Looks like DP would be it.  I see you will have a shoutbox module, and that's one of the things most of my users want.  Looking forward to seeing that.  I like the way TP's shoutbox works...
Title: Re: PM Attachments
Post by: Eclipse16V on December 26, 2009, 08:21:59 PM
Nice Mod and good job.

Thanks for this Mod.

Translation in German is in work.
Title: Re: PM Attachments
Post by: SoLoGHoST on December 27, 2009, 01:26:46 AM
Thank You Eclipse16V, still waiting on your Post Ratings (http://www.simplemachines.org/community/index.php?topic=344748.msg2399695#msg2399695) translation also.
Title: Re: PM Attachments
Post by: Eclipse16V on December 27, 2009, 01:22:21 PM
Yes. Is to 75% finished.
Title: Re: PM Attachments
Post by: eolith on January 31, 2010, 01:42:51 PM
I installed this, got all success indicators, but nothing looks any different.

I had this result with the Mult-Quote mod as well. I installed by entering the URL on the download packages page, and by uploading it from my computer. Neither worked. I then set all permissions on the forum software to read/write, and still no success.

Help!

EDIT: Based on same problem with other mods, it turns out it's not modifying my theme. I'll have to figure out how to insert the code manually.
Title: Re: PM Attachments
Post by: Eclipse16V on March 15, 2010, 02:17:33 AM
Nice Mod

Please update it for SMF 2.0RC3  ;)

Thanks
Title: Re: PM Attachments
Post by: rlh2006 on March 17, 2010, 12:41:09 PM
Will you be updating this mod for RC3 soon?
Title: Re: PM Attachments
Post by: C4G-TK on March 17, 2010, 05:29:07 PM
What do I need to do in order to install this?

I get no tests failed, but when I click install... this comes up

Duplicate entry 'pmAttachmentSizeLimit' for key 'PRIMARY'
File: /home/xxxxxxx/public_html/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211


I've gone into my database and have deleted this, but it keeps giving me the error.
Title: Re: PM Attachments
Post by: SoLoGHoST on March 18, 2010, 06:29:16 PM
Ok, I'm back now with a computer, will take some time to get all of my apps reinstalled, but as soon as this is all done, I'll be hopping back onto my mods.

Cheers
Title: Re: PM Attachments
Post by: C4G-TK on March 19, 2010, 01:22:02 PM
What do I need to do in order to install this?

I get no tests failed, but when I click install... this comes up

Duplicate entry 'pmAttachmentSizeLimit' for key 'PRIMARY'
File: /home/xxxxxxx/public_html/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211


I've gone into my database and have deleted this, but it keeps giving me the error.


Figured it out!  Woohoo!  I'm on a roll today!

Had to go into my Database (which I hate doing cause I'm not comfortable in that area) and go into settings and delete the entries that were trying to be duplicated.  Then, went back and installed fine.  Whew. O:)
Title: Re: PM Attachments
Post by: Eclipse16V on March 25, 2010, 02:46:34 AM
Any news for this or the post ratings mod?  :'(
Title: Re: PM Attachments
Post by: SoLoGHoST on March 26, 2010, 03:56:42 AM
Sorry Eclipse,  Long story short, don't have an RC3 test site up to test my mods in and/or see what's changed in RC3 for my mods.  If someone wants to put up a test site for me to work with these mods, that would surely speed this along, otherwise, it could take awhile.
Title: Re: PM Attachments
Post by: SoLoGHoST on March 26, 2010, 09:06:06 PM
Ok, guys, PM Attachments updated for SMF 2.0 RC3!  This was the easiest upgrade ever!!  Just a simple tab space in the replace operation in ManageAttachments.template.php.

Cheers and Enjoy! :)
Title: Re: PM Attachments
Post by: Arantor on March 26, 2010, 09:06:35 PM
Congrats and thanks :)
Title: Re: PM Attachments
Post by: ~DS~ on March 26, 2010, 09:18:32 PM
Thanks, been waiting for this.

Uh...oh...there's a error then you install if.
Quote
Duplicate entry 'pmAttachmentSizeLimit' for key 1
File: /home/user/public_html/forum.com/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211
Title: Re: PM Attachments
Post by: Arantor on March 26, 2010, 09:38:56 PM
Dismal, see the previous page in this very thread: http://www.simplemachines.org/community/index.php?topic=331969.msg2543950#msg2543950
Title: Re: PM Attachments
Post by: ~DS~ on March 26, 2010, 10:08:14 PM
What do I need to do in order to install this?

I get no tests failed, but when I click install... this comes up

Duplicate entry 'pmAttachmentSizeLimit' for key 'PRIMARY'
File: /home/xxxxxxx/public_html/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211


I've gone into my database and have deleted this, but it keeps giving me the error.


Figured it out!  Woohoo!  I'm on a roll today!

Had to go into my Database (which I hate doing cause I'm not comfortable in that area) and go into settings and delete the entries that were trying to be duplicated.  Then, went back and installed fine.  Whew. O:)
It's not working for me, deleted. Can't figure this out because your comment was not clear.
Title: Re: PM Attachments
Post by: SoLoGHoST on March 27, 2010, 01:31:47 AM
Did you do upgrade option?

If so, or if you are doing a full install...

Remove this line from the respective place in the package-info.xml file and re-zip it up...
Code: [Select]
<code>pmAttachmentsInstallRC2.php</code>
Yeah, I know, I should use the <database> tag, honestly I haven't really thought about it much with this mod.  Will definitely get around to doing more with it after Dream Portal is finished, which could take awhile...

But you can do this for now, if you have all of the tables installed and don't wanna lose your current attachments in the previous version, since no db edits were required.
Title: Re: PM Attachments
Post by: ~DS~ on March 27, 2010, 01:55:33 AM
I upgraded to RC3, so yeah.

It still doesn't work, guess I have to wait?
Title: Re: PM Attachments
Post by: SoLoGHoST on March 27, 2010, 02:03:28 AM
ok, what doesn't work about it?
Title: Re: PM Attachments
Post by: ~DS~ on March 27, 2010, 02:09:17 AM
It's still showing the install error.
Code: [Select]
Duplicate entry 'pmAttachmentSizeLimit' for key 1
File: /home/user/public_html/forum.com/Packages/temp/pmAttachmentsInstallRC2.php
Line: 211

I assume, this only work on full install.
Even removing the line in package-info.xml didn't work. Deleting in the database didn't work either.
Title: Re: PM Attachments
Post by: SoLoGHoST on March 27, 2010, 04:54:06 AM
Open up PMAttachmentsInstallRC2.php, and change Line #190 in there

FROM THIS:
Code: [Select]
$smcFunc['db_insert']('insert',
TO THIS:
Code: [Select]
$smcFunc['db_insert']('ignore',
Forgot about this.  Now save it, package it up and tada, should install just fine now.

Or you can just Redownload it as I just updated it again with this change!
Title: Re: PM Attachments
Post by: TomW on April 29, 2010, 11:59:13 AM
Great mod, thanks !  I would like for my Post template to have the same look & feel.  In other words, I prefer that the Post template is the same as this one - Could you tell me how to modify the Post template ?
Title: Re: PM Attachments
Post by: Arantor on April 29, 2010, 12:12:54 PM
TomW: What bit exactly do you want to change? The PM template is actually based off the Post template for attachments...
Title: Re: PM Attachments
Post by: TomW on April 29, 2010, 09:23:20 PM
TomW: What bit exactly do you want to change? The PM template is actually based off the Post template for attachments...

The screen shots for this mod must not be from the Default (curve) theme, so they look different.  I'll install the mod 1st, then ask questions.  Sorry about that.
Title: Re: PM Attachments
Post by: SoLoGHoST on May 03, 2010, 06:06:42 AM
The screenshots for this mod uses a Theme created by Shortie of Graphics Mayhem (http://graphicsmayhem.com).  I believe the theme is also available here at SMF, though not sure.  Ofcourse, I'm almost positive it's available at Graphics Mayhem (http://graphicsmayhem.com).
Title: Re: PM Attachments
Post by: TomW on May 04, 2010, 07:22:39 PM
I am manually updating my files  (SMF2.0 RC3), and hit a snag with subs.php due to the special characters.  What is the work-around ?
Title: Re: PM Attachments
Post by: SoLoGHoST on May 04, 2010, 07:52:13 PM
Can you tell me what snag you hit?  Also, is this related to the PM Attachments mod?

If you could post up the code where you hit a snag at in Subs.php and the code where PM Attachments is supposed to do the edit to this automatically, perhaps I may be able to help you...
Title: Re: PM Attachments
Post by: TomW on May 04, 2010, 08:22:11 PM
I got it straightened out, thanks for the offer.  Works great; this is a very nice mod.
Title: Re: PM Attachments
Post by: Gryzor on May 05, 2010, 12:07:31 PM
This sounds awesome, so thanks so much for the mod...

However, even though it installed fine, I can see no option to enable PM attachments in the Avatars and Attachment settings. What manual changes do I need to do myself to enable it?

Thanks again... :)
Title: Re: PM Attachments
Post by: TheListener on May 05, 2010, 12:11:35 PM
Ther permissions which you set for guests and the different membergroups.
Title: Re: PM Attachments
Post by: Gryzor on May 05, 2010, 12:17:30 PM
Ther permissions which you set for guests and the different membergroups.

Sorry - was that meant as a reply to my question?

Btw, I forgot to mention I'm using 2.0RC3.
Title: Re: PM Attachments
Post by: TheListener on May 05, 2010, 12:20:18 PM
Like I said have a look at the permissions for the different membergroups.
Title: Re: PM Attachments
Post by: Gryzor on May 05, 2010, 12:27:41 PM
Yes, but it's not a permissions issue, it's just that I don't see the global setting that's supposed to be under Attachments & Avatars...
Title: Re: PM Attachments
Post by: TheListener on May 05, 2010, 12:34:16 PM
PM Attachments mode  should say enable all attachments.

A screenshot would be helpful tho.
Title: Re: PM Attachments
Post by: Gryzor on May 05, 2010, 12:50:50 PM
As I said, I don't even have the option appearing... that's what I'm asking, how to make the option appear manually...

Screenie:
http://img696.imageshack.us/img696/6540/ss20100505194930.png

Thanks :)
Title: Re: PM Attachments
Post by: SoLoGHoST on May 05, 2010, 10:10:12 PM
Ok, that is a pic of Regular Attachment Settings in SMF.  You need to go to PM Attachment Settings, it's very similar.

Are you not seeing this section, PM Attachment Settings?  Will point to, either, the pic attached, or will be like the image attached:
http://custom.simplemachines.org/mods/index.php?action=download;mod=1974;id=106833;image

Granted, this is using a different theme, but PM Attachment Settings should be directly next to your Regular Attachment Settings.  Also, Clear your FORUM's CACHE and try looking in there again.  If it still doesn't exist, let me know.

Also, in that pic, that doesn't help because you haven't showed us all Menu Options there are within the Attachments and Avatars Section.  For Example:  Browse Files, Attachment Settings, Avatar Settings....

Also, check in your MENU Above, you might see something like "PM Attachment Settings" in one of the submenus if you aren't showing the Admin sections in blocks on the left, than it should be in there.

Attached is a pic of what you should be seeing in your Menus if you have your Admin Panel Fully expanded (which is the default).

You can alternatively browse to the following url:  index.php?action=admin;area=manageattachments;sa=pmattachments

Ofcourse your forums url path will need to be in front of that.
Title: Re: PM Attachments
Post by: Gryzor on May 06, 2010, 01:32:10 AM
No,. that's what I'm saying, that sub-section isn't even there... I did clear the cache (even though it was cleared as part of the installation routine).

Thanks for the path, I tried executing it and it just goes into the attachment settings section...damn. Which means that probably it wasn't installed correctly, even though the forum told me it did... I'll try uninstalling and reinstalling.

Thanks for your help!
Title: Re: PM Attachments
Post by: SoLoGHoST on May 06, 2010, 04:50:43 AM
Sure, I'm not sure what's going wrong with your installation, but perhaps you have mod(s) installed that are interferring with this, as I test my mods on a fresh install of SMF, and that's all I can do really.

You should open up ./Sources/Admin.php file and check to make sure that you have the following code in there:
Code: [Select]
array('ManagePMAttachmentSettings', 'area=manageattachments;sa=pmattachments'),
You should also check with the other edits of this file via parsing this mod on the Modification site.

Than open up your ./Sources/ManageAttachments.php and make sure that all of the edits have been done to this file that need to be done as well.  Again, you can see all of the edits that need to get done for this file, if you parse the PM Attachments mod on the SMF Modification site, that should help you out some.

Good Luck
Title: Re: PM Attachments
Post by: Bugo on September 05, 2010, 11:00:23 AM
Please update russian translations in package.
Title: Re: PM Attachments
Post by: SoLoGHoST on September 06, 2010, 12:09:44 AM
Thank You very much Bugo, will do, can you include this edit for the Russian and Russian UTF-8 translation files also?

Code: [Select]
<file name="$languagedir/PersonalMessage.english.php">
<operation>
<search position="before"><![CDATA[$txt['pm_report_desc'] = 'From this page you can report the personal message you received to the admin team of the forum. Please be sure to include a description of why you are reporting the message, as this will be sent along with the contents of the original message]]></search>
<add><![CDATA[, including all attachments]]></add>
</operation>
</file>

May need to be changed a bit differently for Russian, not sure.

Thanks :)
Title: Re: PM Attachments
Post by: Bugo on September 06, 2010, 05:05:06 AM
The variable $txt['pm_report_desc'] is already added by me in Modifications.russian*.
Title: Re: PM Attachments
Post by: SoLoGHoST on September 06, 2010, 11:26:25 PM
Ok, but my mod adds onto it in english:
Quote
, including all attachments

Would you be able to tell me how it will change in Russian to include the text above from that of the Default SMF Russian language for the $txt['pm_report_desc'] variable?

Thanks :)
Title: Re: PM Attachments
Post by: Bugo on September 07, 2010, 02:06:38 AM
In the Russian localization of this variable ($txt['pm_report_desc']) use a shorter translation, so this additive (", including all attachments") is not needed.
Title: Re: PM Attachments
Post by: SoLoGHoST on September 07, 2010, 02:49:35 PM
Ok, just trying to understand, so you are saying that no edit is needed for the $txt['pm_report_desc'] variable at all from that of the SMF installation for the Russian language of that variable, in order for it to say that it also includes all attachments?  So if no edit is needed in Russian from that of the original SMF variable, will russians automatically understand that it includes all attachments?  If there is an edit needed, perhaps a replacement to the original Russian translation for that variable that comes with the Russian translation of SMF?  If so, what is the replacement that is needed to also state that all attachments are included with a reported Personal Message?

Thanks again, just trying to be as precise as possible, since I believe you stated that something must be changed in this file for this variable from that of its default russian words...

For Example if a replacement is needed, you can just change the ***[FIND]*** with the russian strings to find what needs to be replaced and than change ***[REPLACE]*** with the russian strings to replace what needs to be found.  Hopefully you follow me, if not, just ask me and I'll try to be more descriptive and detailed about it.

Code: [Select]
<file name="$languagedir/PersonalMessage.russian.php">
<operation>
<search position="replace"><![CDATA[***[FIND]***]]></search>
<add><![CDATA[***[REPLACE WITH]***]]></add>
</operation>
</file>

Cheers :)
Title: Re: PM Attachments
Post by: Bugo on September 07, 2010, 03:07:49 PM
Ok, let update translations :)
I fixed this variable in Russian localization...
Title: Re: PM Attachments
Post by: SoLoGHoST on September 07, 2010, 03:20:02 PM
Thanks, updating right now.  Very much appreciated! :)
Title: Re: PM Attachments
Post by: petesky on November 07, 2010, 11:38:04 AM
Hi vbgamer !

I installed it on RC4 and it works but i get a huge space (see attached image). I assume this is because of the modified form ?
Title: Re: PM Attachments
Post by: SoLoGHoST on November 08, 2010, 12:47:51 AM
Hi vbgamer !

I installed it on RC4 and it works but i get a huge space (see attached image). I assume this is because of the modified form ?

What are you talking about?  vbgamer?  Perhaps this is in the wrong topic!  Seems very likely.
Title: Re: PM Attachments
Post by: petesky on November 08, 2010, 02:53:40 AM
Ah sorry, sure i mean SoLoGHoST :-)
Title: Re: PM Attachments
Post by: jarska on November 08, 2010, 03:30:35 AM
I modified that to 2.0RC4.

Upload zip, unpack that and make some changes to packade-info.xml.

Just change 2.0RC3 to 2.0RC4 and now it can be install.

I upload that via FTP in to the packades category.

Then install it normally via admin-packades panel.

I get one error, Themes/default/ PersonalMessage.template.php, correct that manually and it works, see attachment:

Use that modification your own risk, works fine to me. :)
Title: Re: PM Attachments
Post by: petesky on November 08, 2010, 05:42:03 AM
@Jarsaka: I get a huge space when writing a new PM - do you have the same issue ?!
Title: Re: PM Attachments
Post by: jarska on November 08, 2010, 09:42:56 AM
@Jarsaka: I get a huge space when writing a new PM - do you have the same issue ?!

I`m not sure what you mean, everything works same as earlier smf 2.0RC3?
Title: Re: PM Attachments
Post by: petesky on November 08, 2010, 11:05:04 AM
I mean, that i get a space between the beginning of the message form up to the border of the pn windows. Please take a look at my attached picture: http://www.simplemachines.org/community/index.php?topic=331969.msg2842974#msg2842974

I looked into source but did not find a reason why it's not top aligned.
Title: Re: PM Attachments
Post by: jarska on November 08, 2010, 02:10:13 PM
I mean, that i get a space between the beginning of the message form up to the border of the pn windows. Please take a look at my attached picture: http://www.simplemachines.org/community/index.php?topic=331969.msg2842974#msg2842974

I looked into source but did not find a reason why it's not top aligned.

I install that for my three different RC4 forums and none that kind of problem.
Title: Re: PM Attachments
Post by: SoLoGHoST on November 10, 2010, 01:00:03 AM
Ok, PM Attachments has been updated to support RC4.

ENJOY :)
Title: Re: PM Attachments
Post by: petesky on November 10, 2010, 03:22:31 AM
Thx a lot. Thumbs up.
Title: Re: PM Attachments
Post by: petesky on November 11, 2010, 09:18:20 AM
Question: Is there a simple way to show also the clip icon in function template_subject_list() so that io can see faster whenever a massage has an attachment or not ?!
Title: Re: PM Attachments
Post by: SoLoGHoST on November 12, 2010, 12:18:19 AM
Ofcourse there's a way to do this, but not without a bit of coding.  Right now, I'm not offering any additional coding for my mods, other than updating them to support SMF 2.0 RC4.  Sorry for being so blunt, but I have other things on my mind now.

Cheers :)
Title: Re: PM Attachments
Post by: petesky on November 12, 2010, 02:29:06 AM
All right, i didn't checked he arrays in this function but when you give me a tip i will do this enhancement.
Title: Re: PM Attachments
Post by: petesky on November 26, 2010, 10:19:25 AM
Hi - small problem, i can only attach one file. When klicking on more.. it jumps to the top of page (may because of the anchor #) but it does not open a 2nd input field...?!
Title: Re: PM Attachments
Post by: SoLoGHoST on November 26, 2010, 03:32:44 PM
Ok, so I'll update this in a minute without this "#" than, so it will use "javascript:void(0);" instead.

Cheers :)
Title: Re: PM Attachments
Post by: SoLoGHoST on November 26, 2010, 03:51:51 PM
Ok, just updated it so that it uses:  <a href="javascript:void(0);"> instead.

You can re-download and re-install if you'd like as this shouldn't happen again.

Cheers :)
Title: Re: PM Attachments
Post by: Ciler on November 29, 2010, 03:53:20 PM
It is not working for 2.0 RC4 theme black rain:

test failed on PersonalMessage.php

Any suggestions to make it work. Attachements in PM's is really a great extension...
Title: Re: PM Attachments
Post by: petesky on November 29, 2010, 09:53:28 PM
Ok, just updated it so that it uses:  <a href="javascript:void(0);"> instead.

You can re-download and re-install if you'd like as this shouldn't happen again.

Cheers :)

Thanks a lot - works perfect !

Btw. reinstalling cleared the attachement dir + database; had to copy both from backup.
Title: Re: PM Attachments
Post by: SoLoGHoST on November 30, 2010, 11:04:46 AM
It is not working for 2.0 RC4 theme black rain:

test failed on PersonalMessage.php

Any suggestions to make it work. Attachements in PM's is really a great extension...

Am looking into this.

Thanks for the bug report.
Title: Re: PM Attachments
Post by: SoLoGHoST on November 30, 2010, 11:52:27 AM
Ok, I didn't have any issues when installing PM Attachments 1.6 on the Black Rain theme (http://custom.simplemachines.org/themes/index.php?lemma=118).  Although, i noticed a few improvements that could be made in PersonalMessage.template.php and changed all of the edits to try and be more compatible with other themes.  Also changed the size of the file input from 60 to 38 so that the "Choose..." button shows, since one can have that left sidebar displaying when sending PM's and a size of 60 was too wide for that.

Please Redownload and install and let me know if your problem is fixed now.  Otherwise, it would seem that there is a problem with custom edits done to the Theme itself, or perhaps other mods have edited PersonalMessage.template.php that is affecting this Theme.

- Solomon
Title: Re: PM Attachments
Post by: Ciler on November 30, 2010, 02:06:05 PM
It is working now I downloaded the tar file and that's working thanks mate! :(

Do you also support PM sent notification mod? That mod is also not working on my black rain v2 theme and gives also an error in the PersonalMessage.php file...



http://www.simplemachines.org/community/index.php?topic=366142.40
Title: Re: PM Attachments
Post by: SoLoGHoST on November 30, 2010, 11:24:36 PM
I only support my mods.  You should write a post in the Mod Topic (Discussion thread) and  the Mod author, live627 should get with you on this.

Cheers :)
Title: Re: PM Attachments
Post by: laetabi on January 01, 2011, 03:59:00 PM
Hi all,

Just installed this by request on my forum running 2.0 RC4 and all installed fine. On test sending an attachment I get:

Fatal error: Call to undefined function getpmattachmentfilename() in /home2/xxx/public_html/forum/Sources/Subs-Post.php on line 3429

?

Thanks

W
Title: Re: PM Attachments
Post by: laetabi on January 03, 2011, 08:23:20 AM
FTP error to blame, when I checked Subs.php a load of code had been enterered after the closing ?>

Solved - Mod works really well, thanks
Title: Re: PM Attachments
Post by: time31415 on February 20, 2011, 10:01:12 PM
Also would like a 1.1.13 version of this as well...
I am sure there are tons of others who do as well - not like everyone who wants it is also going to comment on it.
So.. what are the odds of getting this? has any progress or work been put towards it?
Title: Re: PM Attachments
Post by: mariusfv on March 23, 2011, 01:59:43 PM
Update pls. for 2.0 RC5...!
Title: Re: PM Attachments
Post by: TheListener on March 23, 2011, 03:11:52 PM
Update pls. for 2.0 RC5...!

Have you tried to emulate version?
Title: Re: PM Attachments
Post by: Ciler on March 27, 2011, 01:19:28 PM
Update pls. for 2.0 RC5...!

Have you tried to emulate version?

You mean package parser? Yes I did it says not compatible with RC5!
Title: Re: PM Attachments
Post by: Arantor on March 27, 2011, 01:20:43 PM
That's not what Brack meant.

Admin > Packages > Browse Packages > advanced - let's you put a different version in, such as RC3, that may allow you to successfully install the package. Not recommended to go below 2.0 RC3 though.
Title: Re: PM Attachments
Post by: Ciler on March 27, 2011, 01:55:24 PM
That's not what Brack meant.

Admin > Packages > Browse Packages > advanced - let's you put a different version in, such as RC3, that may allow you to successfully install the package. Not recommended to go below 2.0 RC3 though.

Thanks Arantor i tested this and installed well but going to sent a message I got database error. When looking at subs.php the mod script was dubbel in it (2 times) so i deleded 1 and I was able to uninstall the mod.
Title: Re: PM Attachments
Post by: Gryzor on May 12, 2011, 02:19:46 AM
I did try emulating RC4, but although the test gives perfect results it doesn't work afterwards. There's no PM attachments settings section and it's not in the Permissions, either...

So, pretty please, a RC5 version? :)

[EDIT] Nah... after checking a couple of files, it seems no edits were done!!?
Title: Re: PM Attachments
Post by: narcolog on May 27, 2011, 04:18:45 PM
SoLoGHoST: some good news about 1.1.. version! Please! Please!
Title: Re: PM Attachments
Post by: SoLoGHoST on May 28, 2011, 04:11:50 AM
PM Attachments is at version 1.6.  If you are referring to SMF version 1.1 branch, no, I will not create it.  There are people who have made a version of PM Attachments for 1.1.  Talk to that dude [SiNaN] from Simple Portal, he is also an SMF Developer, last I heard.  He created a PM Attachments for 1.1 and is selling it for a price, he spoke with everyone within this topic that wanted it via Private Messaging, so maybe he will contact you about it as well.

Cheers :)
Title: Re: PM Attachments
Post by: dry3210 on June 14, 2011, 10:45:14 AM
Trying to get this on 2.0 and get this when installing

Duplicate entry 'pmAttachmentSizeLimit' for key 'PRIMARY'
File: /Packages/temp/pmAttachmentsInstall.php
Line: 103
Title: Re: PM Attachments
Post by: SoLoGHoST on June 14, 2011, 03:26:38 PM
Sounds to me like you didn't uninstall PM Attachments completely.  This is a database error, stating that you already have that column in that table and you can't add it again.

You should run the pmAttachmentsUninstall.php file from your site somewhere and than try installing PM Attachments again.  You will lose previous PM Attachments when doing this ofcourse.  If you want to keep previous attachments, than just remove the <database> tag within package-info.xml, save it, repackage it, and than install it.  Hopefully all tables and columns from PM Attachments are still there and haven't been deleted, or this will cause problems.

Cheers :)
Title: Re: PM Attachments
Post by: dougiefresh on June 15, 2011, 12:47:58 PM
Thank you for the wonderful mod!  I thought I'd let everybody know that when I updated my forum from 2.0 RC5 to 2.0 Gold, I had to reinstall all my mods.  I encountered some errors during installation and wanted to share this information with you.

Here are the errors that I encountered:
./Sources/PersonalMessage.php => operation 8 failed
./Themes/default/PersonalMessage.template.php => operation 3 failed.
./Themes/default/ManageAttachments.template.php => operations 1 & 2 failed.

If I can figure out what is wrong, I'll post my corrections so that this mod will install without issue.....
Title: Re: PM Attachments
Post by: SoLoGHoST on June 15, 2011, 10:50:14 PM
I'll get around to this mod sometime this or next week.
Title: Re: PM Attachments
Post by: Saiyan1337 on July 24, 2011, 05:42:49 PM
Any progress? its been a month since you last posted for this mod.
Title: Re: PM Attachments
Post by: Eclipse16V on July 25, 2011, 06:06:10 AM
no news?
:-(
Title: Re: PM Attachments
Post by: TheListener on July 25, 2011, 09:20:57 AM
Works on 2.0 for me.
Title: Re: PM Attachments
Post by: TomW on August 01, 2011, 11:55:58 PM
I have installed this mod on my 2.0 Gold forum and have found it to work fine, except when a user attempts to attach an image that is too large for my max size.  The error message displays, but when the user removes that image, and adds a smaller image, then click on the 'send message' button, nothing happens.  When attaching an image that is within the limits, it works fine.
Title: Re: PM Attachments
Post by: MiY4Gi on August 14, 2011, 04:50:09 PM
This mod needs an update. I've tried installing it on my 2.0 Gold forum but I encountered a few errors. A manual edit is a no no as well, since some of the code needing replacing is missing. A conflict with another mod perhaps?
Title: Re: PM Attachments
Post by: Eclipse16V on August 15, 2011, 01:38:35 AM
On my 2.0 works it without errors.
Title: Re: PM Attachments
Post by: MiY4Gi on August 15, 2011, 09:15:29 AM
Mm, must be a conflict with one of my other mods.
Title: Re: PM Attachments
Post by: Jessica. on August 19, 2011, 09:44:12 AM
good mod. installing.

This should be built-in SMF.

update for 2.0 final?
Title: Re: PM Attachments
Post by: Eclipse16V on August 19, 2011, 04:40:37 PM
Run on my 2.0 Final without errors or problems.
Title: Re: PM Attachments
Post by: rlh2006 on October 06, 2011, 03:47:33 PM
Is this mod working for SMF 2.0.1?
My forum users depend upon PM Attachments mod, so I can't upgrade to SMF 2.0.1 without working PM Attachments.
Title: Re: PM Attachments
Post by: Eclipse16V on October 06, 2011, 03:56:08 PM
Works without problems on my SMF 2.0.1
Title: Re: PM Attachments
Post by: TomW on October 06, 2011, 10:44:55 PM
Works without problems on my SMF 2.0.1

ditto
Title: Re: PM Attachments
Post by: T3CHN0 on October 09, 2011, 08:31:53 AM
how does it work on 2.0.1.

downloaded a clean install to compare my php's.
and this mod says on install
Quote
./Sources/PersonalMessage.php
find this
Code: [Select]
$context['pm_area'] = 'send';

if (!WIRELESS)
$context['sub_template'] = 'send';
and add before
Code: [Select]
checkSession('request');but this is wrong as checkSession('request'); is already in the PersonalMessage.php and the first part
can't be found.

Quote
Themes/default/PersonalMessage.template.php
Code: [Select]
<form action="', $scripturl, '?action=pm;sa=send2" method="post" accept-charset="', $context['character_set'], '" name="postmodify" id="postmodify" onsubmit="submitonce(this);saveEntities();">
<table border="0" cellpadding="3" width="100%">';
can't be found at all

Quote
./Themes/default/ManageAttachments.template.php
Code: [Select]
<td>', $txt['attachment_space' . ($context['attach_multiple_dirs'] ? '_current' : '')], ':</td><td>', isset($context['attachment_space']) ? $context['attachment_space'] . ' ' . $txt['kilobyte'] : $txt['attachmentdir_size_not_set'], '</td>
</tr>
can't be found at all

Code: [Select]
<input type="hidden" name="sa" value="byAge" />
</form>
</td>
</tr>
</table>';
can't be found BUT >>> <input type="hidden" name="sa" value="byAge" /> can be found so no problem there, easy edit will fix

This is from a fresh download of 2.0.1 looking at the php file to find out how I can apply this mod
to my forum. But as there is so much different from RC4 to 2.0.1 I don't know enough on php coding
to fix this my self...

I have always used this mod on RC3 and works perfectly but I rebuilt my forum and need it now for 2.0.1
any idea's. ? ? ?

will this mod get an update to 2.0.1
Title: Re: PM Attachments
Post by: TomW on October 09, 2011, 07:39:17 PM
When manually installing a mod and I cannot find an exact match, I look for the 1st part of the 'select' code, then visually compare to make sure that it is the right spot.  As I recall, the code is the same, just the spacing is slightly different.  That is why you're not able to find it.
Title: Re: PM Attachments
Post by: T3CHN0 on October 09, 2011, 08:55:33 PM
I do the same, that's why I downloaded a fresh 2.0.1 install and looked at the php's before edits. the 2 codes in the middle are the 2 main codes I can't work out.
the first code does not need to be included as that's already there. and the last code only need to change the input string. OK easy stuff. but if I can't find any part of the middle two then I don't really know where to place the code. if someone has it working on 2.0.1 I would like to download their PersonalMessage.php & ManageAttachments.template.php so I can look at the coding and find where I am to make the edits my self.
cheers
Title: Re: PM Attachments
Post by: SoLoGHoST on October 09, 2011, 10:45:18 PM
Guys, sorry for not being active in this support thread.  FYI - I have prioritized my coding on Dream Portal 1.1.  I will update all of my other mods after Dream Portal 1.1 is released and approved here at the SM.org site.

Cheers :)
Title: Re: PM Attachments
Post by: TheListener on October 09, 2011, 10:47:11 PM
Hey SG

Just so ya know the mod does work on 2.0.1
Title: Re: PM Attachments
Post by: SoLoGHoST on October 09, 2011, 10:51:06 PM
Thanks, I'm sure it does.  Might be a few errors in the After/Before/Replace edits, but I'm sure that it's a piece of cake to change for 2.0.1.  Haven't tested it yet, perhaps the SMF version emulation might help others if they experience any errors.  In any case, I won't be testing this out until I'm finished with Dream Portal 1.1.
Title: Re: PM Attachments
Post by: T3CHN0 on October 13, 2011, 01:44:53 PM
Hey SG

Just so ya know the mod does work on 2.0.1

I can confirm as well, it does work on 2.0.1, ignore my passed posts. Tried again just now and it worked
installed without error's. Silly me must have forgot to change the Emulate Version: to SMF 2.0 RC4
before trying the install. all my time and effort trying to do the edits my self all because of
forgetting one simple step.
Title: Re: PM Attachments
Post by: SoLoGHoST on October 19, 2011, 02:29:31 AM
Well that's good to know.  Cheers :) will get around to it.
Title: Re: PM Attachments
Post by: cerbopoli on November 06, 2011, 09:20:24 PM
I have installed PM attachments on SMF 2.0.1 I used the emmulate for SMF 2.0 RC4 in order to install it and everything appeared to go well, but I do not have an option under Attachments and Avatars for PM Attachments and I also do not see any way to attach a file within a PM.  Is there a step I am missing? 
Title: Re: PM Attachments
Post by: T3CHN0 on November 07, 2011, 04:51:27 AM
put this after your forum URL http://yourforum/index.php?action=admin;area=manageattachments;sa=pmattachments (http://yourforum/index.php?action=admin;area=manageattachments;sa=pmattachments)
and see if that takes you to the PM attachment settings.

you should see the option Attachments and other options at the bottom of each new PM or reply PM now if installed correctly.

Also check you have Attachments mode ON... Admin>Attachments and Avatars>Attachment Settings.
you should have these TABS/ options all in the same location

Browse Files, Attachment Settings, PM Attachment Settings, Avatar Settings, File Maintenance,

if you don't have everything you should, maybe try removing the mod and install it again.
Title: Re: PM Attachments
Post by: cerbopoli on November 07, 2011, 12:00:19 PM
Yes, I tried to add the action to go to the PM attachments within the URL and it just gets me to the regular attachments panel.  I also triple checked that I have attachments enabled.  For some reason I cannot uninstall on my main forum, but I reinstalled a brand new install of 2.0.1 and then went directly to adding this modification and it will not work on that one either.   :(
Title: Re: PM Attachments
Post by: T3CHN0 on November 07, 2011, 05:48:08 PM
I don't know why it didn't work for you then, I also use 2.0.1.. when it installs is there any error's? and are you using a custom theme?
if your using a custom theme could you try changing it to the default theme and having a look to see if it is working!!!
beyond this point I would have to look at your forum to help any further
cheers
Title: Re: PM Attachments
Post by: cerbopoli on November 07, 2011, 05:57:50 PM
No, I am using the default theme and received no errors installing.  I have actually had issues with any Mod that I have tried to install, so I am wondering if there is a server issue, but I am not sure where I should be looking for the issue.  Before I upgraded to SMF 2.0.1 I had no problem with mods.
Title: Re: PM Attachments
Post by: T3CHN0 on November 07, 2011, 06:28:54 PM
the whole mess of things doesn't sound right. your forum is 2.0.1 and working... you upload and install a mod OK with no error's
but then the mod doesn't work... Am I missing something? this is not normal behavior for SMF or any PHP forum.

when installing do you actually get the message saying the mod was installed successfully and if so, it should then work.
This can't be server side error because if you server side was the problem you wouldn't be able to install the mod in the first place.

I do not know, I think I could help more if you PM me you site URL and I'll take a look
cheers
Title: Re: PM Attachments
Post by: sbranky on November 21, 2011, 03:52:04 PM
I have installed this mod on a regular 2.0.1 emulating 2.0 RC4 working but if I can not even pick up the attachment.

Pm received in the attachment is visible and it is linked, but when I try to download the browser goes wrong. The file is present on the server in the directory "pm_attachments" but you can download it in any way. Everything works except for the taking.

you have a solution?
Title: Re: PM Attachments
Post by: T3CHN0 on November 21, 2011, 08:12:23 PM
I have installed this mod on a regular 2.0.1 emulating 2.0 RC4 working but if I can not even pick up the attachment.

Pm received in the attachment is visible and it is linked, but when I try to download the browser goes wrong. The file is present on the server in the directory "pm_attachments" but you can download it in any way. Everything works except for the taking.

you have a solution?
I can't read the error as it's not in English. Screen picture looks right. have you checked your members permissions and do you have a download quota?
Would you mine translating the error into English please!!!
I notice the error is showing your temp folder as where your downloading to. is this correct. could you update your details in smf as well and put your
sites url in so others who try to help don't need to ask for your url.
Title: Re: PM Attachments
Post by: sbranky on November 22, 2011, 09:12:37 AM
I can't read the error as it's not in English. Screen picture looks right. have you checked your members permissions and do you have a download quota?
Would you mine translating the error into English please!!!

It 'true, the error is reported in Italian, sorry
the error is as follows:
php.part can not be saved because you can not read the source file

The user permissions are ok, but the problem also occurs if the attachment is sent to me as Admin, virtually the file were uploaded regularly, but not be unloaded in any way and do not understand why. Even if I send a PM to a user test is the same.

I notice the error is showing your temp folder as where your downloading to. is this correct. could you update your details in smf as well and put your
sites url in so others who try to help don't need to ask for your url.

The files were uploaded within the limit provided for in the model set (max 250 kb)
I can not link my site because it is not visible on the Internet but on a private network not visible.

sorry for my bad English
Title: Re: PM Attachments
Post by: T3CHN0 on November 22, 2011, 09:38:59 AM
hmm OK.
I would like to help but if your site is private and in Italian I don't think I could help to much.
maybe PM me your URL if OK and I will try and have a look
Title: Re: PM Attachments
Post by: sbranky on November 22, 2011, 05:13:32 PM
continued to experiment but I can not get it to work,
If I can help The link is returned is the following, correct?

Code: [Select]
http://10.9.5.8/forum/index.php?action=dlpmattach;pm=13646;attach=1
Firefox d'ont work and the browser Ie8 goes into error as attached image.

EDIT:

on the same server and same permissions but as another location, I installed the old version RC5 (for testing) and the mod works perfectly.
So I think the problem is precisely in the new version 2.0.1 is not allowed in the server or permissions.
Title: Re: PM Attachments
Post by: vomito on December 10, 2011, 01:34:00 PM
I have a little problem with this mod in my RC2.
In the database "pm_attachments" the value for "id_pm" ist not set when sending an pm attachment.
"id_attach", "filename", "file_hash" and so on are written. Only "id_pm" has still the Value "0"
Through that the receiver of the pm doesnt get a notification of the attachment.
maybe you have an Idea how the problem  can be solved...
thanks!
Title: Re: PM Attachments
Post by: Study Force on December 10, 2011, 05:54:01 PM
1.x version available?
Title: Re: PM Attachments
Post by: live627 on December 10, 2011, 05:59:42 PM
You use Firefox 8? Can you try another browser?
Title: Re: PM Attachments
Post by: TheListener on December 10, 2011, 06:07:10 PM
1.x version available?

The mod author has stated once before he is not making a 1.1.x version.
Title: Re: PM Attachments
Post by: Study Force on December 11, 2011, 02:47:15 PM
1.x version available?

The mod author has stated once before he is not making a 1.1.x version.

I thought perhaps someone may have done it and could upload it. :(
Title: Re: PM Attachments
Post by: TheListener on March 30, 2012, 10:00:53 AM
Anyone whom wants this mod on 2.0.2 and has the BCC messages mod installed.

Uninstall BCC messages.

Emulate version 2.0 RC4 and install this mod.

place forum back into 2.0.2

Reinstall BCC Messages mod.
Title: Re: PM Attachments
Post by: TheListener on May 25, 2012, 10:04:03 PM
Can anyone explain to me what

Table 'xxxxsmf164.pm_recipients' doesn't exist
File: /home/xxxxl/Packages/temp/pmAttachmentsUninstall.php
Line: 56

means?

I presume it is server side yet there is such a table when I look.

 ???
Title: Re: PM Attachments
Post by: live627 on May 25, 2012, 11:30:14 PM
It's ancient code (pre RC3) that caused the error. That's the uninstaller
Title: Re: PM Attachments
Post by: TheListener on May 25, 2012, 11:31:21 PM
Any idea how I can get outta it?
Title: Re: PM Attachments
Post by: live627 on May 25, 2012, 11:44:54 PM
You wish to remove the table, then?
Title: Re: PM Attachments
Post by: TheListener on May 25, 2012, 11:46:38 PM
Was trying to remove the mod and then reinstall it to see if the current problems would cease.

Is a useful mod (when it works).

 O:)
Title: Re: PM Attachments
Post by: live627 on May 25, 2012, 11:53:37 PM
Not really a straight answer, but, eh, what the hell.

Code: [Select]
$smcFunc['db_drop_table'] ('pm_attachments');

// Get rid of the added columns in the pm_recipients table
$smcFunc['db_remove_column'] ('pm_recipients', 'attachments');
$smcFunc['db_remove_column'] ('pm_recipients', 'downloads');

Replace the above with

Code: [Select]
$smcFunc['db_drop_table'] ('{db_prefix}pm_attachments');

// Get rid of the added columns in the pm_recipients table
$smcFunc['db_remove_column'] ('{db_prefix}pm_recipients', 'attachments');
$smcFunc['db_remove_column'] ('{db_prefix}pm_recipients', 'downloads');

All that does is add the prefix in.
Title: Re: PM Attachments
Post by: TheListener on May 26, 2012, 12:08:09 AM
No change.
Title: Re: PM Attachments
Post by: Selroth on June 19, 2012, 10:44:53 PM
Tried installing on a SMF 2.0.1 installation.  Ran into a database error on line 111 of pmAttachmentInstall.php.  Needed to add "{db_prefix}" to the bottom loop to resolve the issue (and undo the changes it did on the failed attempt).


Code: [Select]
// Insert the column(s) into the pm_recipients table
if (!empty($columns_pm_recipients))
   foreach ($columns_pm_recipients as $recipients)
      $smcFunc['db_add_column']('{db_prefix}' . $recipients['table'], $recipients['info']);


?>

Just swung by this topic to give an update - apparently the last few posts are in regards to a very similar issue.  Old Fossil, if you're still around, you may want to look into it.


I also noticed a lot of the file changes are expecting tables, whereas SMF 2.0.1 is table-less in those areas.  Perhaps it was just running the wrong install file, but I manually applied the changes using a bit of common sense and basic PHP skills and everything's working like a champ now.  Thanks for a great mod [size=78%]Solomon and live627![/size]
Title: Re: PM Attachments
Post by: TheListener on June 19, 2012, 10:46:25 PM
Quote
Just swung by this topic to give an update - apparently the last few posts are in regards to a very similar issue.  Old Fossil, if you're still around, you may want to look into it.

There is nothing I can do.
Title: Re: PM Attachments
Post by: SoLoGHoST on July 14, 2012, 10:33:23 PM
@ Old Fossil, you should Run the PMAttachmentsUninstall.php file from your SMF Root directory and be logged in as Admin.  Copy and paste the file over, this will remove any database tables that wasn't removed via your previous uninstallation.  If you get an error (just note what error you get).  Move on to uploading and installing PM Attachments via the SMF Package Manager.  Remember, I still need to update this mod for SMF 2.0.2, but it might work on an emulation, not sure.  Most likely there will be a few operations that will need to be adjusted no matter what you emulate it to.  You should be sure that whatever operations that have failed, to click on the magnifying glass next to these failed operations to look at what the operation is stating exactly.  Than you just open up the file, do a search for part of that string (making sure that same string doesn't exist anywhere else in the file) and do the edits manually.  After you have done all of this for each operation that has failed, just install the PM Attachments Mod, and don't worry about the failed operations, since they won't be written to the file anyways.

After that, your PM Attachments should work perfectly fine.
Title: Re: PM Attachments
Post by: stylusss on August 27, 2012, 09:59:46 PM
Could someone make this available for 1.x?

Willing to pay for the conversion via PayPal.

Also, is it possible for the attachments to be saved in the data?
Title: Re: PM Attachments
Post by: TheListener on August 27, 2012, 10:02:38 PM
1.x version available?

The mod author has stated once before he is not making a 1.1.x version.

Please read the support topics properly.

Title: Re: PM Attachments
Post by: stylusss on August 27, 2012, 11:03:40 PM
Would anyone be willing to convert it? :-\
Title: Re: PM Attachments
Post by: TheListener on August 27, 2012, 11:05:33 PM
Would anyone be willing to convert it? :-\

The only person whom can do so is the mods author.

Only with the authors specific permission can anyone else do so.
Title: Re: PM Attachments
Post by: stylusss on August 27, 2012, 11:33:18 PM
Would anyone be willing to convert it? :-\

The only person whom can do so is the mods author.

Only with the authors specific permission can anyone else do so.

I see, should I send a PM or something?
Title: Re: PM Attachments
Post by: SoLoGHoST on August 27, 2012, 11:52:07 PM
Honestly, I'm not very familiar with SMF 1.x variables and built-in functions/classes.  I assume it is more primitive than what SMF has grown to be... 2.x!  I'm not one to look back on the past, and live in it, even if for a price!  I tend to cater to the ever growing technologies and changes... no offense!  I do not and will not code for SMF 1.x, not now, not ever... again, no offense!  To me, it's like coding a webpage to be compatible with IE 1.x, Safari 1.x, Opera 1.x, Chrome 1.x, etc. etc..  No offense to the SMF Team either!  The world is an ever growing and changing environment, we have to learn to accept it and live in the now, and dream for the future!

As far as someone taking the mods code and making a profit off of it, this is forbidden in the License that accompanies this MOD and does not have my permission to do so!  HOWEVER, If someone wants to create an SMF 1.x version of my mod, WITHOUT a PROFIT, they are FREE to do so (using the code from this MOD), as long as the original copyrights and license (from my mod) accompanies the SMF 1.x version of this Mod.

Hope this answers your question(s).
Title: Re: PM Attachments
Post by: stylusss on August 28, 2012, 05:07:41 PM
Thank you!
Title: Re: PM Attachments
Post by: imno007 on December 02, 2012, 12:17:06 AM
Hi, I'm trying to uninstall this and keep getting this message:

Table 'databasename_smf2.pm_recipients' doesn't exist
File: /home/.../public_html/forum/Packages/temp/pmAttachmentsUninstall.php

But I've checked the database and there definitely is a 'pm-recipients' table, so I'm not sure what needs to be done here.

TIA!
Title: Re: PM Attachments
Post by: Itchigotim on March 07, 2013, 02:06:54 AM
I've been having problems getting this to work. Is this compatible with 2.0.4?
Title: Re: PM Attachments
Post by: SoLoGHoST on March 08, 2013, 07:23:35 PM
When you go to download the MOD itself, there is a section called Compatible With.  Currently it says: 
Quote
Compatible With:
2.0 RC1-1, 2.0 RC1.2, 2.0 RC2, 2.0 RC3, 2.0 RC4
Title: Re: PM Attachments
Post by: Sammil on March 09, 2013, 05:53:54 PM
Should we see the 2.0.X version in the next months? I really find this mod interesting.

Thank you :)

PD: Captcha in this forum sucks :(
Title: Re: PM Attachments
Post by: live627 on March 09, 2013, 06:38:36 PM
I have 1.6 installed on SMF 2.0.4 without issues.
Title: Re: PM Attachments
Post by: live627 on March 09, 2013, 06:40:08 PM
How can I install a mod that doesn't work in my SMF version? (http://wiki.simplemachines.org/smf/How_can_install_a_mod_that_doesn%27t_work_in_my_SMF_version)

The above link has some information that may help you.
Title: Re: PM Attachments
Post by: Itchigotim on March 12, 2013, 09:21:54 AM
THANK YOU!! That did it!! 8) I had no idea there was such an option! It's like "compatibility mode! I do get errors when trying to install the security patch, but right now I can live with that.
Title: Re: PM Attachments
Post by: Itchigotim on March 12, 2013, 09:41:18 AM
It appears I celebrated too soon as it only works for me. Is there a way I can extend this to all members? Nevermind, permissions.......... ;) Thank you again.
Title: Re: PM Attachments
Post by: CheeseHead05 on May 27, 2013, 06:58:41 PM
Im having trouble with installing this mod. My Notepad++ is saying that it cant find:

   $context['pm_area'] = 'send';

   if (!WIRELESS)
      $context['sub_template'] = 'send';

I am using a custom theme tho.. ???

Any help?

Thanks in advance..
Title: Re: PM Attachments
Post by: GL700Wing on May 29, 2013, 07:34:39 AM
I have 1.6 installed on SMF 2.0.4 without issues.
The only way I could do this was to use compatibility mode (http://wiki.simplemachines.org/smf/How_can_install_a_mod_that_doesn%27t_work_in_my_SMF_version) and emulate "SMF 2.0 RC4" - all good though!
Title: Re: PM Attachments
Post by: Gryzor on June 13, 2013, 05:02:24 AM
Im having trouble with installing this mod. My Notepad++ is saying that it cant find:

   $context['pm_area'] = 'send';

   if (!WIRELESS)
      $context['sub_template'] = 'send';

I am using a custom theme tho.. ???

Any help?

Thanks in advance..

Yeah, it seems that    $context['pm_area'] = 'send'; has been removed from the code... that's where I've stumbled, too. Here's hoping an update will be coming...

But it did install with version emulation.

One problem I'm having is that I get "Cannot access attachments upload path!". Path is there, of course, user www, permis set at 755. Why wouldn't it work?

[EDIT] Set it to 777, still no soap :(
Title: Re: PM Attachments
Post by: TheListener on June 15, 2013, 12:31:49 PM
When you go to download the MOD itself, there is a section called Compatible With.  Currently it says: 
Quote
Compatible With:
2.0 RC1-1, 2.0 RC1.2, 2.0 RC2, 2.0 RC3, 2.0 RC4

Maybe you should update the list to include 2.0.4
Title: Re: PM Attachments
Post by: Gryzor on June 15, 2013, 12:34:10 PM
I have a problem (other than the mod not being able to write to the Uploads folder); something probably went wrong and when I enter many Admin areas, the mod description text will appear at the top of the page... could anyone help and tell me where to look to fix it?
Title: Re: PM Attachments
Post by: TheListener on June 15, 2013, 12:38:25 PM
Errors in the error log?

What other mods are installed?
Title: Re: PM Attachments
Post by: Gryzor on June 15, 2013, 12:41:23 PM
No error in the log... and too many mods :D
Title: Re: PM Attachments
Post by: TheListener on June 15, 2013, 12:43:55 PM
No error in the log... and too many mods :D

Do you have BCC Message installed?

Can't help much without an idea of other installed mods.
Title: Re: PM Attachments
Post by: Gryzor on June 15, 2013, 12:46:31 PM
No, not BCC Message. As for the rest... too long a list I'm afraid :(

Code: [Select]
1. Add GooglePlus to Posts 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
2. Add Social Media Icons To Profiles 1.0.7  11 January 2013, 14:27:45 [ Uninstall ] [ List Files ] [ Delete ]
3. Additional Polls 1.2.2  22 March 2013, 13:10:20 [ Uninstall ] [ List Files ] [ Delete ]
4. Addthis widget in first post 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
5. Adk Click Right 1.0 N/A [ List Files ] [ Delete ]
6. Adk Shadow Box 1.0  28 June 2012, 16:14:44 [ Uninstall ] [ List Files ] [ Delete ]
7. Adk System FAQs 1.0  24 February 2013, 19:08:49 [ Uninstall ] [ List Files ] [ Delete ]
8. Aeva ~ Auto-Embed Video & Audio 7.1 05 December 2011, 12:20:12 [ List Files ] [ Delete ]
9. Aeva ~ Auto-Embed Video & Audio 7.2  05 December 2011, 12:20:12 [ Uninstall ] [ List Files ] [ Delete ]
10. Ajax History Graph 0.1.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
11. AJAX Instant Quick Reply 1.0.4 N/A [ List Files ] [ Delete ]
12. Attachments In Message 1.3.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
13. BBC User Info 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
14. Bookmarks 2.5  12 November 2012, 11:23:45 [ Uninstall ] [ List Files ] [ Delete ]
15. Compact User Information on Post Display 0.1 N/A [ List Files ] [ Delete ]
16. Country Flags 1.1.2  05 December 2011, 12:50:30 [ Uninstall ] [ List Files ] [ Delete ]
17. Custom Tab 1.2  20 December 2011, 10:01:18 [ Uninstall ] [ List Files ] [ Delete ]
18. Descriptive Links 1.0  10 March 2012, 10:53:09 [ Uninstall ] [ List Files ] [ Delete ]
19. DevCenter 0.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
20. DevCenter 0.3 N/A [ Install Mod ] [ List Files ] [ Delete ]
21. Drafts 1.1.4 N/A [ List Files ] [ Delete ]
22. eBay BBCode 2.0.1 13 April 2013, 13:33:28 [ List Files ] [ Delete ]
23. eBay BBCode 2.0.2  13 April 2013, 13:33:28 [ Uninstall ] [ List Files ] [ Delete ]
24. EmailValidator 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
25. Enhanced PM Popup 1.0.1  10 July 2012, 15:15:35 [ Uninstall ] [ List Files ] [ Delete ]
26. ENotify 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
27. EU Cookie 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
28. FancyBox 4 SMF 0.2.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
29. Footnotes 1.08  05 December 2011, 12:39:49 [ Uninstall ] [ List Files ] [ Delete ]
30. FreiChat 1.0  12 June 2013, 11:02:11 [ Uninstall ] [ List Files ] [ Delete ]
31. geoIP Location 1.1.1  27 April 2012, 16:47:38 [ Uninstall ] [ List Files ] [ Delete ]
32. Google Analytics Code 1.4  05 December 2011, 12:13:13 [ Uninstall ] [ List Files ] [ Delete ]
33. Gravatar 4 SMF 1.0  25 September 2012, 11:51:45 [ Uninstall ] [ List Files ] [ Delete ]
34. Gravatar by SMFPacks.com 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
35. Happy Birthday 0.3 N/A [ Install Mod ] [ List Files ] [ Delete ]
36. Hidden Admin 1.0 N/A [ List Files ] [ Delete ]
37. Increase/Decrease Text Area BBCodes 1.0  31 July 2012, 17:08:37 [ Uninstall ] [ List Files ] [ Delete ]
38. InLine Attachments 1.2.1  14 December 2012, 15:07:05 [ Uninstall ] [ List Files ] [ Delete ]
39. Mark Personal Messages as Read 1.0.5  15 November 2012, 21:35:52 [ Uninstall ] [ List Files ] [ Delete ]
40. Member Awards 2.2.3  19 December 2011, 16:55:09 [ Uninstall ] [ List Files ] [ Delete ]
41. Mibbit Ajax IRC Chat Mod 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
42. Mobile Device Detect 0.2.2  20 March 2013, 21:42:01 [ Uninstall ] [ List Files ] [ Delete ]
43. New Hooks 0.2  11 March 2013, 10:12:53 [ Uninstall ] [ List Files ] [ Delete ]
44. News Letter Mod for SMF2 1.13 25 January 2013, 21:23:10 [ List Files ] [ Delete ]
45. News Letter Mod for SMF2 1.20 25 January 2013, 21:23:10 [ List Files ] [ Delete ]
46. News Letter Mod for SMF2 1.21  25 January 2013, 21:23:10 [ Uninstall ] [ List Files ] [ Delete ]
47. NiceTooltips 1.8  21 March 2012, 16:26:14 [ Uninstall ] [ List Files ] [ Delete ]
48. PM Attachments 1.6  13 June 2013, 12:04:34 [ Uninstall ] [ List Files ] [ Delete ]
49. PM to New Members 1.2  19 November 2012, 11:15:38 [ Uninstall ] [ List Files ] [ Delete ]
50. Pretty URLs 1.0RC5.2  07 December 2011, 19:51:58 [ Uninstall ] [ List Files ] [ Delete ]
51. Quick Translation 0.8  11 March 2013, 10:13:25 [ Uninstall ] [ List Files ] [ Delete ]
52. Recent Topics On Board Index 1.03 N/A [ Install Mod ] [ List Files ] [ Delete ]
53. RSS Feeder 1.1.5  05 December 2011, 10:58:13 [ List Files ] [ Delete ]
54. SCEditor4Smf 0.4.5 N/A [ Install Mod ] [ List Files ] [ Delete ]
55. Search Results Char Limit 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
56. Share This Topic 4.1.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
57. Similar Topics 0.2  05 November 2012, 13:42:34 [ Uninstall ] [ List Files ] [ Delete ]
58. Simple Menu Icons 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
59. Simple Spoiler 1.0.1 N/A [ List Files ] [ Delete ]
60. SimplePortal 2.3.4 N/A [ Install Mod ] [ List Files ] [ Delete ]
61. SimplePortal 2.3.5 N/A [ Install Mod ] [ List Files ] [ Delete ]
62. Sisyphus 1.0  05 December 2011, 13:10:27 [ Uninstall ] [ List Files ] [ Delete ]
63. SMF 2.0.2 Update 1.0  25 December 2011, 09:42:36 [ List Files ] [ Delete ]
64. SMF 2.0.3 Update 1.0  18 December 2012, 11:50:08 [ List Files ] [ Delete ]
65. SMF 2.0.4 Update 1.0  02 February 2013, 18:53:30 [ Uninstall ] [ List Files ] [ Delete ]
66. SMF Downloads Directory 1.2 27 June 2012, 10:54:43 [ List Files ] [ Delete ]
67. SMF Downloads Directory 1.2.2  27 June 2012, 10:54:43 [ Uninstall ] [ List Files ] [ Delete ]
68. SMF Multi Quote 1.1.3  05 December 2011, 12:45:08 [ List Files ] [ Delete ]
69. SMFPacks Alerts Pro 2.0  28 July 2012, 11:42:35 [ Uninstall ] [ List Files ] [ Delete ]
70. SMFPacks Likes Pro Mod 1.3.8  23 January 2013, 18:25:50 [ Uninstall ] [ List Files ] [ Delete ]
71. SMFPacks Shoutbox 1.0.3  06 December 2011, 10:02:02 [ List Files ] [ Delete ]
72. SMFSIMPLE Bookmarks 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
73. Social Bookmarks for SMF 2 1.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
74. Social Login 2.2  11 February 2013, 17:52:07 [ Uninstall ] [ List Files ] [ Delete ]
75. Sortable Packages (and Installed Time) 1.3.3  18 April 2013, 19:24:33 [ List Files ] [ Delete ]
76. Spoiler BBCode 1.1.3  05 December 2011, 12:26:17 [ Uninstall ] [ List Files ] [ Delete ]
77. Spoiler Tag 0.7.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
78. Tapatalk SMF 2.0 RC5/Final Plugin 3.5.0  20 March 2013, 09:16:54 [ Uninstall ] [ List Files ] [ Delete ]
79. The SMF File Management Tool 1.0.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
80. Top X Stats 1.0.1  04 January 2013, 19:09:50 [ Uninstall ] [ List Files ] [ Delete ]
81. Treasury 2.10  13 January 2012, 13:51:32 [ Uninstall ] [ List Files ] [ Delete ]
82. Unread and Replies Tabs in Main Menu 3.0.2 CURVE  05 December 2011, 10:54:17 [ List Files ] [ Delete ]
83. WysiBB for SMF 0.4.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
84. WysiBB for SMF 0.5 N/A [ Install Mod ] [ List Files ] [ Delete ]
85. WYSIWYG Quick Reply 2.3  03 February 2013, 17:46:39 [ Uninstall ] [ List Files ] [ Delete ]
Title: Re: PM Attachments
Post by: TheListener on June 15, 2013, 12:52:21 PM
No, not BCC Message. As for the rest... too long a list I'm afraid :(

Code: [Select]
1. Add GooglePlus to Posts 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
2. Add Social Media Icons To Profiles 1.0.7  11 January 2013, 14:27:45 [ Uninstall ] [ List Files ] [ Delete ]
3. Additional Polls 1.2.2  22 March 2013, 13:10:20 [ Uninstall ] [ List Files ] [ Delete ]
4. Addthis widget in first post 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
5. Adk Click Right 1.0 N/A [ List Files ] [ Delete ]
6. Adk Shadow Box 1.0  28 June 2012, 16:14:44 [ Uninstall ] [ List Files ] [ Delete ]
7. Adk System FAQs 1.0  24 February 2013, 19:08:49 [ Uninstall ] [ List Files ] [ Delete ]
8. Aeva ~ Auto-Embed Video & Audio 7.1 05 December 2011, 12:20:12 [ List Files ] [ Delete ]
9. Aeva ~ Auto-Embed Video & Audio 7.2  05 December 2011, 12:20:12 [ Uninstall ] [ List Files ] [ Delete ]
10. Ajax History Graph 0.1.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
11. AJAX Instant Quick Reply 1.0.4 N/A [ List Files ] [ Delete ]
12. Attachments In Message 1.3.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
13. BBC User Info 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
14. Bookmarks 2.5  12 November 2012, 11:23:45 [ Uninstall ] [ List Files ] [ Delete ]
15. Compact User Information on Post Display 0.1 N/A [ List Files ] [ Delete ]
16. Country Flags 1.1.2  05 December 2011, 12:50:30 [ Uninstall ] [ List Files ] [ Delete ]
17. Custom Tab 1.2  20 December 2011, 10:01:18 [ Uninstall ] [ List Files ] [ Delete ]
18. Descriptive Links 1.0  10 March 2012, 10:53:09 [ Uninstall ] [ List Files ] [ Delete ]
19. DevCenter 0.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
20. DevCenter 0.3 N/A [ Install Mod ] [ List Files ] [ Delete ]
21. Drafts 1.1.4 N/A [ List Files ] [ Delete ]
22. eBay BBCode 2.0.1 13 April 2013, 13:33:28 [ List Files ] [ Delete ]
23. eBay BBCode 2.0.2  13 April 2013, 13:33:28 [ Uninstall ] [ List Files ] [ Delete ]
24. EmailValidator 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
25. Enhanced PM Popup 1.0.1  10 July 2012, 15:15:35 [ Uninstall ] [ List Files ] [ Delete ]
26. ENotify 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
27. EU Cookie 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
28. FancyBox 4 SMF 0.2.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
29. Footnotes 1.08  05 December 2011, 12:39:49 [ Uninstall ] [ List Files ] [ Delete ]
30. FreiChat 1.0  12 June 2013, 11:02:11 [ Uninstall ] [ List Files ] [ Delete ]
31. geoIP Location 1.1.1  27 April 2012, 16:47:38 [ Uninstall ] [ List Files ] [ Delete ]
32. Google Analytics Code 1.4  05 December 2011, 12:13:13 [ Uninstall ] [ List Files ] [ Delete ]
33. Gravatar 4 SMF 1.0  25 September 2012, 11:51:45 [ Uninstall ] [ List Files ] [ Delete ]
34. Gravatar by SMFPacks.com 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
35. Happy Birthday 0.3 N/A [ Install Mod ] [ List Files ] [ Delete ]
36. Hidden Admin 1.0 N/A [ List Files ] [ Delete ]
37. Increase/Decrease Text Area BBCodes 1.0  31 July 2012, 17:08:37 [ Uninstall ] [ List Files ] [ Delete ]
38. InLine Attachments 1.2.1  14 December 2012, 15:07:05 [ Uninstall ] [ List Files ] [ Delete ]
39. Mark Personal Messages as Read 1.0.5  15 November 2012, 21:35:52 [ Uninstall ] [ List Files ] [ Delete ]
40. Member Awards 2.2.3  19 December 2011, 16:55:09 [ Uninstall ] [ List Files ] [ Delete ]
41. Mibbit Ajax IRC Chat Mod 2.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
42. Mobile Device Detect 0.2.2  20 March 2013, 21:42:01 [ Uninstall ] [ List Files ] [ Delete ]
43. New Hooks 0.2  11 March 2013, 10:12:53 [ Uninstall ] [ List Files ] [ Delete ]
44. News Letter Mod for SMF2 1.13 25 January 2013, 21:23:10 [ List Files ] [ Delete ]
45. News Letter Mod for SMF2 1.20 25 January 2013, 21:23:10 [ List Files ] [ Delete ]
46. News Letter Mod for SMF2 1.21  25 January 2013, 21:23:10 [ Uninstall ] [ List Files ] [ Delete ]
47. NiceTooltips 1.8  21 March 2012, 16:26:14 [ Uninstall ] [ List Files ] [ Delete ]
48. PM Attachments 1.6  13 June 2013, 12:04:34 [ Uninstall ] [ List Files ] [ Delete ]
49. PM to New Members 1.2  19 November 2012, 11:15:38 [ Uninstall ] [ List Files ] [ Delete ]
50. Pretty URLs 1.0RC5.2  07 December 2011, 19:51:58 [ Uninstall ] [ List Files ] [ Delete ]
51. Quick Translation 0.8  11 March 2013, 10:13:25 [ Uninstall ] [ List Files ] [ Delete ]
52. Recent Topics On Board Index 1.03 N/A [ Install Mod ] [ List Files ] [ Delete ]
53. RSS Feeder 1.1.5  05 December 2011, 10:58:13 [ List Files ] [ Delete ]
54. SCEditor4Smf 0.4.5 N/A [ Install Mod ] [ List Files ] [ Delete ]
55. Search Results Char Limit 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
56. Share This Topic 4.1.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
57. Similar Topics 0.2  05 November 2012, 13:42:34 [ Uninstall ] [ List Files ] [ Delete ]
58. Simple Menu Icons 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
59. Simple Spoiler 1.0.1 N/A [ List Files ] [ Delete ]
60. SimplePortal 2.3.4 N/A [ Install Mod ] [ List Files ] [ Delete ]
61. SimplePortal 2.3.5 N/A [ Install Mod ] [ List Files ] [ Delete ]
62. Sisyphus 1.0  05 December 2011, 13:10:27 [ Uninstall ] [ List Files ] [ Delete ]
63. SMF 2.0.2 Update 1.0  25 December 2011, 09:42:36 [ List Files ] [ Delete ]
64. SMF 2.0.3 Update 1.0  18 December 2012, 11:50:08 [ List Files ] [ Delete ]
65. SMF 2.0.4 Update 1.0  02 February 2013, 18:53:30 [ Uninstall ] [ List Files ] [ Delete ]
66. SMF Downloads Directory 1.2 27 June 2012, 10:54:43 [ List Files ] [ Delete ]
67. SMF Downloads Directory 1.2.2  27 June 2012, 10:54:43 [ Uninstall ] [ List Files ] [ Delete ]
68. SMF Multi Quote 1.1.3  05 December 2011, 12:45:08 [ List Files ] [ Delete ]
69. SMFPacks Alerts Pro 2.0  28 July 2012, 11:42:35 [ Uninstall ] [ List Files ] [ Delete ]
70. SMFPacks Likes Pro Mod 1.3.8  23 January 2013, 18:25:50 [ Uninstall ] [ List Files ] [ Delete ]
71. SMFPacks Shoutbox 1.0.3  06 December 2011, 10:02:02 [ List Files ] [ Delete ]
72. SMFSIMPLE Bookmarks 1.0 N/A [ Install Mod ] [ List Files ] [ Delete ]
73. Social Bookmarks for SMF 2 1.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
74. Social Login 2.2  11 February 2013, 17:52:07 [ Uninstall ] [ List Files ] [ Delete ]
75. Sortable Packages (and Installed Time) 1.3.3  18 April 2013, 19:24:33 [ List Files ] [ Delete ]
76. Spoiler BBCode 1.1.3  05 December 2011, 12:26:17 [ Uninstall ] [ List Files ] [ Delete ]
77. Spoiler Tag 0.7.2 N/A [ Install Mod ] [ List Files ] [ Delete ]
78. Tapatalk SMF 2.0 RC5/Final Plugin 3.5.0  20 March 2013, 09:16:54 [ Uninstall ] [ List Files ] [ Delete ]
79. The SMF File Management Tool 1.0.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
80. Top X Stats 1.0.1  04 January 2013, 19:09:50 [ Uninstall ] [ List Files ] [ Delete ]
81. Treasury 2.10  13 January 2012, 13:51:32 [ Uninstall ] [ List Files ] [ Delete ]
82. Unread and Replies Tabs in Main Menu 3.0.2 CURVE  05 December 2011, 10:54:17 [ List Files ] [ Delete ]
83. WysiBB for SMF 0.4.1 N/A [ Install Mod ] [ List Files ] [ Delete ]
84. WysiBB for SMF 0.5 N/A [ Install Mod ] [ List Files ] [ Delete ]
85. WYSIWYG Quick Reply 2.3  03 February 2013, 17:46:39 [ Uninstall ] [ List Files ] [ Delete ]

A lot of your mods are double installed.

The smf shoutpacks mod imo is unneccessary considering you have simple portal installed which also has a shoutbox.

I would advise you get the doubled mods corrected before anything else is done.

/me has 68 mods installed on forum.
Title: Re: PM Attachments
Post by: Gryzor on June 15, 2013, 12:55:30 PM
You'll see that these are not double installed, they're just different versions; one of the entries will say [Install] next to it, meaning it's not installed... just the package is there.
Title: Re: PM Attachments
Post by: Deezel on July 29, 2013, 08:07:02 AM
Is this working for the latest version of SMF?
Title: Re: PM Attachments
Post by: TheListener on July 31, 2013, 12:02:44 AM
Is this working for the latest version of SMF?

That's what test forums are for  ::)
Title: Re: PM Attachments
Post by: dougiefresh on August 04, 2013, 06:30:33 PM
Is this working for the latest version of SMF?
Install using version emulation to 2.0 RC4 and it installs nicely!
Title: Re: PM Attachments
Post by: CheeseHead05 on August 14, 2013, 10:53:18 AM
I have several failed tests and am using a custom theme, can I bypass and still install or will it cause a parse error?
Title: Re: PM Attachments
Post by: LightWeightChamp on August 15, 2013, 07:09:01 PM
Hello All,

Im new to smf and I tried to install this mod but I get an error about a table..Im confused.

Table 'for1322703300389.pm_recipients' doesn't exist
File: /home/content/97/10932397/html/reebokconverse/Packages/temp/pmAttachmentsInstall.php
Line: 111
Title: Re: PM Attachments
Post by: Cat McFarlane on September 05, 2013, 08:45:57 AM
Hiya  :)

I too have a similar error to the above error message. About to alter some php's as is guided, but a bit concerned as the error says should upgrade database to 2.0.5.

Thanks  :)

Title: Re: PM Attachments
Post by: SoLoGHoST on September 05, 2013, 08:59:03 PM
I'm sorry, I'm no longer supporting any mods, other than maybe... Dream Portal on the DP.net site.  I've lost all motivation to really do any coding for SMF anymore.  After losing my job, wife, house, and daughter because of coding Mods for SMF, there's just really nothing motivating me to keep going anymore.  Not because I have nothing left to lose, but because I have nothing to gain from any of it!  Their used to be a time when this was sooo much fun, but now it's just a burden!!
Title: Re: PM Attachments
Post by: Cat McFarlane on September 05, 2013, 09:43:44 PM
I'm sorry, I'm no longer supporting any mods, other than maybe... Dream Portal on the DP.net site.  I've lost all motivation to really do any coding for SMF anymore.  After losing my job, wife, house, and daughter because of coding Mods for SMF, there's just really nothing motivating me to keep going anymore.  Not because I have nothing left to lose, but because I have nothing to gain from any of it!  Their used to be a time when this was sooo much fun, but now it's just a burden!!

Sorry to hear your sadness. We all go through tough things sometimes, and always light up again as we truly learn vital lessons from what happened and move forward. New patterns = new results ... and new happiness. Best wishes, Cat
Title: Re: PM Attachments
Post by: live627 on September 05, 2013, 10:54:12 PM
Any chance of passing them on?
Title: Re: PM Attachments
Post by: Phphelp on September 05, 2013, 11:33:03 PM
I just installed it manually on 2.0.5...

2 tricky parts, but wasn't to hard.
Title: Re: PM Attachments
Post by: Cat McFarlane on September 06, 2013, 12:07:19 AM
I just installed it manually on 2.0.5...

2 tricky parts, but wasn't to hard.

I had a problem with editing the 3rd of the 3 files that showed 'test failed' ... couldn't find the sections to replace or add before/after.
 :)
Title: Re: PM Attachments
Post by: Phphelp on September 06, 2013, 01:08:40 AM
I didn't even run the package, I just did it manual and went through the instructions..

There was 2 places that didn't match - so I had to do partial searches to find it.

Then I had to convert a chunk of code removing the tr's and td's and replace it with dt's and dd's

Title: Re: PM Attachments
Post by: Cat McFarlane on September 06, 2013, 01:38:04 AM
I didn't even run the package, I just did it manual and went through the instructions..

There was 2 places that didn't match - so I had to do partial searches to find it.

Then I had to convert a chunk of code removing the tr's and td's and replace it with dt's and dd's

That was it, yes ... couldn't find the dt's etc. Just a newbie at the code thing, so didn't dare try, lol.  :o
Title: Re: PM Attachments
Post by: SoLoGHoST on September 06, 2013, 03:20:42 AM
Any chance of passing them on?

Nahhh, besides you already have enough mods to support.  Thanks anyways.

And, just to be clear... Supporting a mod and updating a mod are 2 different things!
Title: Re: PM Attachments
Post by: stylusss on April 18, 2014, 04:43:35 PM
Is it possible to keep the file when it's uploaded?
Title: Re: PM Attachments
Post by: SoLoGHoST on April 20, 2014, 04:06:52 AM
Is it possible to keep the file when it's uploaded?

I'm not sure what you mean by that.  The file never gets deleted unless you purge them in the Attachment Settings in the SMF Admin.  Please be more specific as to what you mean when you say keep the file...
Title: Re: PM Attachments
Post by: Study Force on April 20, 2014, 01:06:22 PM
When someone attaches a file, does it get stored on the server?
Title: Re: PM Attachments
Post by: SoLoGHoST on April 22, 2014, 02:52:32 AM
Ofcourse... how else would it be able to be downloaded?
Title: Re: PM Attachments
Post by: Study Force on April 25, 2014, 12:41:56 PM
Ofcourse... how else would it be able to be downloaded?

Makes sense... Thanks.
Title: Re: PM Attachments
Post by: kamili34 on May 03, 2014, 01:44:03 PM
Will it works on smf 2.0.7? I have some errors during the installing it.
Title: Re: PM Attachments
Post by: w5hro on May 13, 2014, 12:29:51 PM
Will it works on smf 2.0.7? I have some errors during the installing it.

Yes, can we get an update for SMF v2.0.7? This is a necessary mod.

Thanks...
Title: Re: PM Attachments
Post by: tieskedh on May 28, 2014, 05:48:46 PM
That would indeed be very nice!!!
Title: Re: PM Attachments
Post by: live627 on May 29, 2014, 12:21:55 AM
Try to emulate 2.0 RC4..
Title: Re: PM Attachments
Post by: kamili34 on June 22, 2014, 10:49:06 AM
It emulate but when installing this mod many errors occurred. :/
Title: Re: PM Attachments
Post by: RSI on June 22, 2014, 11:15:18 AM
You can install the mod, but you have to do parts of it manually.

1. Run the install to where it comes up and shows the errors, but don't execute it yet.

2. Make a back up of each of the files that show the install errors.

3. Manually edit those files (not the backed up ones).

4. Execute the install with the errors.

5. Upload the manually edited files to overwrite the ones the install tried to update.

6. If it doesn't work then just auto uninstall it.

That's basically it and what you have to do when many of these mods are not yet updated. Usually it's just something simple which requires editing some of the files manually.
Title: Re: PM Attachments
Post by: SoLoGHoST on June 26, 2014, 10:17:03 PM
This mod has been updated to support SMF 2.0.7 and 2.0.8 as well.  ENJOY!  Thanks to GL700Wing (http://www.simplemachines.org/community/index.php?action=profile;u=112942) for this update.
Title: Re: PM Attachments
Post by: Itchigotim on June 27, 2014, 02:39:57 AM
Question: I'm running 1.6 under emulate an older version (I don't remember which one, RC4?). I have no issues at all. Should I upgrade? Does this add more options, or is it just compatible with the latest SMF? I have SMF 2.08 now on my site.

It's an excellent mod either way and I'm thankful to have it. I just don't want to break anything if I don't have to.
Title: Re: PM Attachments
Post by: GL700Wing on June 27, 2014, 05:14:44 AM
Question: I'm running 1.6 under emulate an older version (I don't remember which one, RC4?). I have no issues at all. Should I upgrade? Does this add more options, or is it just compatible with the latest SMF? I have SMF 2.08 now on my site.

It's an excellent mod either way and I'm thankful to have it. I just don't want to break anything if I don't have to.
This update only adds installer/uninstaller support for SMF versions 2.0.4 and later without the need to use emulation mode - it does not change the mod functionality in any way.

Also, and by default, uninstalling earlier releases will delete the existing 'pm_attachments' directory (and all the PM Attachments in it) and it may also delete all existing associated database data (don't ask me how I know this - thank goodness I make regular data and database backups).*

My recommendation is that you do not uninstall earlier releases unless you know how to backup and restore the existing directory (ie, the 'pm_attachments' directory in the default path of the forum) and the associated database data (ie, the 'pm_attachments' and 'pm_recipients' tables).

However, if you don't mind deleting the current PM Attachments directory and database data you could try removing the earlier release (you will more than likely have to manually edit some files to fully uninstall earlier releases - I also know this from experience!).

-----------------------------------------------------------------------
* I have changed the way the installer/uninstaller works so that this version will not automatically delete the attachments directory or database data.
Title: Re: PM Attachments
Post by: T3CHN0 on June 27, 2014, 09:25:10 AM
My recommendation is that you do not uninstall earlier releases unless you know how to backup and restore the existing directory

Can I suggest you add this quote to the MODS Description:

Not everyone will read the posts to know this and might accidentally uninstall the old one
thinking the new one is better and end up loosing all the old Attachment Files.

This is a very handy mode.
Cheers
Title: Re: PM Attachments
Post by: SoLoGHoST on June 27, 2014, 01:51:37 PM
The versions of the mod did not change, so people should not expect anything different from this mod, but will do this later just to be politically correct I guess.
Title: Re: PM Attachments
Post by: dougiefresh on July 10, 2014, 08:52:11 AM
I've got a bug report for ya....  I've got a clean, fresh copy of SMF v2.0.8, and I've even redownloaded v2.0.8 again to make sure.  Version 1.6 of the PM Attachments mod won't install on this without throwing an error.  The 3rd operation on ./Themes/core/PersonalMessage.template.php is the problem....  Thought you might wanna know.

EDIT: Here is the operation that throws an error:
Code: (search) [Select]
<form action="', $scripturl, '?action=pm;sa=send2" method="post" accept-charset="', $context['character_set'], '" name="postmodify" id="postmodify" class="flow_hidden" onsubmit="submitonce(this);smc_saveEntities(\'postmodify\', [\'subject\', \'message\']);">
<div>
Where is what it should be (at least in v2.0.8 ):
Code: [Select]
<form action="', $scripturl, '?action=pm;sa=send2" method="post" accept-charset="', $context['character_set'], '" name="postmodify" id="postmodify" onsubmit="submitonce(this);smc_saveEntities(\'postmodify\', [\'subject\', \'message\']);">
<div>
Thought this might help.....

EDIT2: I really don't know what the class="flow_hidden" does, but if you replace that in that file, it installs properly....
Title: Re: PM Attachments
Post by: Itchigotim on July 11, 2014, 04:35:34 AM
Thanks guys, I'll leave it as is. :)
Title: Re: PM Attachments
Post by: KungFuJoe on September 23, 2014, 04:48:43 PM
I have a mod that auto resizes images sent as attachments.  This helps immensely to keep file usage on my server low.  Do you know if such a mod will work with this mod or is there a way to integrate such a feature into it?

I like the idea of allowing users to send attachments, but as large as pics are these days, it will quickly fill up the storage quota and setting a low file size limit will just mean more questions/complaints for my userbase who are mostly non technical.
Title: Re: PM Attachments
Post by: dougiefresh on September 24, 2014, 05:09:00 PM
I have a mod that auto resizes images sent as attachments.  This helps immensely to keep file usage on my server low.  Do you know if such a mod will work with this mod or is there a way to integrate such a feature into it?
Well, considering the PM attachments code is implemented completely separate from the core attachments code, you would have to alter your mod to make those changes to the PM attachments code, which is found in Sources/PersonalMessage.php.  Naturally, if the code doesn't exist, you'll want the installer to ignore the changes.... like this:
Code: [Select]
<operation error="ignore">

As for whether it could be integrated, sure, anything can be integrated, given enough time and patience.....  Does the author want to?  That's a whole different question....

Frankly, the mod you mentioned sounds like a good idea!  Is it your mod?  If so, are you going to publish it?  If it isn't your mod, can you point me to the mod you mentioned?  Cause I'm interested....  Thanks!
Title: Re: PM Attachments
Post by: SoLoGHoST on September 25, 2014, 11:50:38 PM
I have a mod that auto resizes images sent as attachments.  This helps immensely to keep file usage on my server low.  Do you know if such a mod will work with this mod or is there a way to integrate such a feature into it?

Max size per attachment sets the filesize.  This is more accurate... but to each their own.  It is not hard to resize images down.  In fact, SMF does this, index.php?action=admin;area=featuresettings;sa=layout (at the bottom are Max Width and Max Height of posted pictures).  Not entirely sure if this will take effect in Personal Messages also, but you can try and see...
Title: Re: PM Attachments
Post by: RSI on February 03, 2015, 12:26:40 PM
Hello,

I'm getting the error below in the error log after installing this mod. Any idea what it is and how to correct it?

http://mydomain/index.php?action=pm;sa=send;f=inbox;pmsg=182;u=all

2: in_array() expects parameter 2 to be array, null given

File: /home/me/public_html/Sources/PersonalMessage.php

Line: 2067
Title: Re: PM Attachments
Post by: SoLoGHoST on February 09, 2015, 02:59:07 AM
Well, the error looks exactly as it says.  So go to that file, open it, go to line 2067, just before in_array is called, the 2nd parameter in there will be the variable you need to target, and put in

Code: [Select]
if (!empty($variable))
{
    // wrap the in_array code in here...


}

So, just wrap all in_array code within the above code, where $variable is the variable name that gets used in the 2nd parameter of in_array.
Title: Re: PM Attachments
Post by: dougiefresh on March 31, 2015, 07:16:35 PM
@SoLoGHoST:  I'm sorry to hear about your situation.  I hope things get better for you!!!

I would be interested in taking over support and care of this mod, if you're okay with it.  Yes, I realize it's a big mod....
Title: Re: PM Attachments
Post by: vomito on April 25, 2015, 07:28:01 AM
I've just installed pm_attachments 1.6 on SMF 2.09
Now I have an error in the section admin/manage attachments. When hitting the button in my admin-area smf crashes and I will get this error:

Fatal error: Cannot redeclare template_pm_attachment_repair() (previously declared in /homepages/19/d127221452/htdocs/Daciakrempel/smf/Sources/Load.php(2240) : eval()'d code:353) in /homepages/19/d127221452/htdocs/Daciakrempel/smf/Sources/Load.php(2240) : eval()'d code on line 513

Does anybody know what might have gone wrong?
Title: Re: PM Attachments
Post by: vomito on April 25, 2015, 11:11:18 AM
Mistake found!  :)

The installer of the modification added some lines twice in ./Themes/default/PersonalMessage.template.php

these ones:

function template_pm_attachment_repair() ... template_show_list('pmattach_paths');
}
Title: Re: PM Attachments
Post by: stucki on May 28, 2015, 05:16:22 AM
Hello,

on 2.0.10, the application can not be installed I get some errors. Will there be a new version of PM attachments?
Title: Re: PM Attachments
Post by: BrainDead Fish on September 24, 2015, 10:09:27 AM
Hi, I have this mod installed on forums that I've had for many years.

I'm running SMF 2.0.11, with version 1.6 of the PM Attachments mod installed.

This has been working fine for a long time, but suddenly attachments to PM messages are no longer working. I get no errors and there is no indication that there is no attachment until the message is sent and no attachment comes through with it.

I've checked to make sure permissions are set properly, but it still doesn't work. Like I said, it has been working fine for years, but suddenly stopped recently.

Can someone help me troubleshoot this? Let me know what info I need to provide in addition to what I've already given.

Thanks in advance.

P.S. Also, I'm willing to pay someone a reasonable fee to help troubleshoot this.
Title: Re: PM Attachments
Post by: SoLoGHoST on October 05, 2015, 11:31:13 PM
You may have reached your storage space limit on the server-side.  Also, you should try pruning all attachments and than try it again.

About upgrading this mod for future versions of SMF, honestly, I'm not interested in doing this.  Why?  Because there will be another version of SMF, and another, and another to upgrade this mod for.  I'm sick of it all.  This is a never-ending struggle to upgrade mods for a forum software that is, 1.  Unimportant and obsolete, and 2. A waste of my time, not to mention 3. Nothing to gain from it.
Title: Re: PM Attachments
Post by: dougiefresh on September 26, 2016, 09:55:20 AM
About upgrading this mod for future versions of SMF, honestly, I'm not interested in doing this.  Why?  Because there will be another version of SMF, and another, and another to upgrade this mod for.  I'm sick of it all.  This is a never-ending struggle to upgrade mods for a forum software that is, 1.  Unimportant and obsolete, and 2. A waste of my time, not to mention 3. Nothing to gain from it.
I once again extend my previous offer to take over this mod for you (http://www.simplemachines.org/community/index.php?topic=331969.msg3802680#msg3802680).....
Title: Re: PM Attachments
Post by: SoLoGHoST on December 29, 2016, 11:01:01 PM
If you will upgrade this mod for all future releases of SMF and provide support for it in this topic, I will be happy to transfer it to you, otherwise, if you only plan on supporting it in this topic and will not actually address future upgrades for current and future SMF versions than I would have to decline this.  There are many people taking over mods that never even get around to doing any actual work on the mod.  This is not what I would want from someone who wants to take over this mod, as you put it.
Title: Re: PM Attachments
Post by: dougiefresh on December 30, 2016, 10:03:42 AM
If you will upgrade this mod for all future releases of SMF and provide support for it in this topic, I will be happy to transfer it to you, otherwise, if you only plan on supporting it in this topic and will not actually address future upgrades for current and future SMF versions than I would have to decline this.  There are many people taking over mods that never even get around to doing any actual work on the mod.  This is not what I would want from someone who wants to take over this mod, as you put it.
Of course I'll upgrade the mod for future releases and provide support for it in this topic....  What would be the point of "taking over a mod" if you don't do anything with it, support or otherwise?  I mean, besides the mod count increase, which if you can't write a few yourself, why bother getting someone else's mods to hold on to....  Kinda pointless to me, I'd think....

I'd ask you to look at my mod list (http://custom.simplemachines.org/mods/index.php?action=profile;u=253913) to see what kind of variety of mods I've written.  Only the first two weren't started by me.....  And I've got 6 or 7 in the approval queue at the moment....  Yes, I've got tons of mods to support, but also look at the threads.  I do pay attention to my users, as well as make sure that my mods work for the current version, not to mention SMF 2.1 Beta 2.....
Title: Re: PM Attachments
Post by: SoLoGHoST on January 06, 2017, 08:39:32 PM
Ok, done, I've added you as an Additional Author for this mod:  http://custom.simplemachines.org/mods/index.php?mod=1974
Title: Re: PM Attachments
Post by: dougiefresh on January 06, 2017, 09:25:18 PM
Thank you, SoLoGHoST!
Title: Re: PM Attachments
Post by: dougiefresh on January 30, 2017, 12:40:32 PM
UPDATE:  I never thought I'd see so much duplication in one mod....  It's kinda ridiculus....   :P O:)  Yeah, I realize it's to support multiple versions of SMF....

I've gotten almost all the duplication for the source files removed from the mod, and am trying to decipher the template changes, since they seem to be all over the place.  My goal is one unified installer that will work across every v2.0.x install....  Once that has been acheived, I'll start looking at bug reports....
Title: Re: PM Attachments
Post by: landyvlad on February 10, 2017, 06:20:46 AM
Wondering if you can help./ I went to instal and got:

Quote
   1.   Adapt Database   pmAttachmentsInstall-204.php   
*   2.   Execute Modification   ./index.php   Test successful
*   3.   Execute Modification   ./Sources/Subs.php   Test successful
*   4.   Execute Modification   ./Sources/Subs-Post.php   Test successful
*   5.   Execute Modification   ./Sources/Admin.php   Test successful
*   6.   Execute Modification   ./Sources/PersonalMessage.php   Test successful
*   7.   Execute Modification   ./Sources/ManageAttachments.php   Test successful
*   8.   Execute Modification   ./Sources/ManagePermissions.php   Test successful
*   9.   Execute Modification   ./Themes/default/PersonalMessage.template.php   Test successful
*   10.   Execute Modification   ./Themes/default/ManageAttachments.template.php   Test failed
   1.   Add After   ./Themes/default/ManageAttachments.template.php   Test successful
   2.   Replace   ./Themes/default/ManageAttachments.template.php   Test failed
   3.   Add Before   ./Themes/default/ManageAttachments.template.php   Test successful
*   11.   Execute Modification   ./Themes/default/languages/Modifications.english.php   Test successful
*   12.   Execute Modification   ./Themes/default/languages/Help.english.php   Test successful
*   13.   Execute Modification   ./Themes/default/languages/EmailTemplates.english.php   Test successful
*   14.   Execute Modification   ./Themes/default/languages/PersonalMessage.english.php   Test successful
15.   Execute Modification   ./Themes/default/languages/Modifications.english-utf8.php   Skipping file
16.   Execute Modification   ./Themes/default/languages/Help.english-utf8.php   Skipping file
17.   Execute Modification   ./Themes/default/languages/EmailTemplates.english-utf8.php   Skipping file
18.   Execute Modification   ./Themes/default/languages/PersonalMessage.english-utf8.php   Skipping file
19.   Execute Modification   ./Themes/default/languages/Modifications.russian.php   Skipping file
20.   Execute Modification   ./Themes/default/languages/Help.russian.php   Skipping file
21.   Execute Modification   ./Themes/default/languages/EmailTemplates.russian.php   Skipping file
22.   Execute Modification   ./Themes/default/languages/PersonalMessage.russian.php   Skipping file
23.   Execute Modification   ./Themes/default/languages/Modifications.russian-utf8.php   Skipping file
24.   Execute Modification   ./Themes/default/languages/Help.russian-utf8.php   Skipping file
25.   Execute Modification   ./Themes/default/languages/EmailTemplates.russian-utf8.php   Skipping file
26.   Execute Modification   ./Themes/default/languages/PersonalMessage.russian-utf8.php   Skipping file
27.   Extract Tree   ./pm_attachments


Install in Other Themes
To use this modification in themes other than the default, the package manager needs to make additional changes to the other themes. If you'd like to install this modification in the other themes, please select these themes below.
   Core Theme
   Execute Modification   ./Themes/core/PersonalMessage.template.php   Test failed
   1.   Add After   ./Themes/core/PersonalMessage.template.php   Test successful
   2.   Add Before   ./Themes/core/PersonalMessage.template.php   Test successful
   3.   Replace   ./Themes/core/PersonalMessage.template.php   Test failed
   4.   Add Before   ./Themes/core/PersonalMessage.template.php   Test successful


Existing mods as per attachment below.

My users are crying out for this so would be great to fix it if we can.
Advice welcome.

Cheers.

Title: Re: PM Attachments
Post by: dougiefresh on February 10, 2017, 10:21:53 PM
@landyvlad: I've almost got the Version 2.0 Beta 1 version ready to put up on the mod page.  I need to sort out a few minor template issues, and the remainder of the language files.  Please be patient.....
Title: Re: PM Attachments
Post by: landyvlad on February 11, 2017, 01:44:35 AM
Cool, thanks mate :)
Title: Re: PM Attachments
Post by: dougiefresh on February 12, 2017, 11:15:09 AM
Uploaded v2.0 Beta 1 - February 12th, 2017
o Moved PM Attachment functionality into Subs-PMAttachments.php.
o Moved PM Attachment admin functions into Subs-PMAttachmentsAdmin.php.
o Moved PM Attachment admin templates into PMAttachments.template.php.
o Moved PM File Maintenance stuff to new PM File Maintenance tab.



@Everybody:  I've tried very hard to tidy up the mod so that it is easier to maintain, so hopefully this will solve some of the issues that have been seen.  The installer still supports the older versions of the SMF 2.0, specifically RC2, RC3, and RC4 (I frankly considered dropping them); however, I do not guarantee that the UI will be correct in every regard.  Each of the SMF versions supported by mod v1.6 had a common code base, and that is what I have been working to consolidate....

Please note that the mod no longer removes the settings from the database upon uninstallation.  I don't see the point of doing so, and the various uninstallers each seemed to do things a little differently....

I am going to continue to work on it and see if I can't resolve some of the older bug reports.  The mod description will also get a revisement, eventually.....  Version 1.6 will continue to be downloadable for the foreseeable future.  Hope this helps someone.....
Title: Re: PM Attachments
Post by: landyvlad on February 12, 2017, 06:51:36 PM
Thanks so much for taking up the torch and running with this one.
Cheers
Title: Re: PM Attachments
Post by: Kinsman on February 13, 2017, 03:56:02 AM
Thanks for the update, I gave it a crack but got "Modification parse error" on install_20x.xml and template_204.xml
Title: Re: PM Attachments
Post by: dougiefresh on February 13, 2017, 08:25:28 AM
@Kinsman: I'm guessing a corrupt file.....  I've rezipped the files and uploaded it again to the Customization Site.

@landyvlad:  You're welcome!
Title: Re: PM Attachments
Post by: Kinsman on February 14, 2017, 05:18:44 AM
Thanks, got it working now.  8)
Title: Re: PM Attachments
Post by: Kinsman on February 16, 2017, 02:45:21 PM
Bugger, what I should have said was I got it installed.

Everything looks great, except no files are sent. The only error I can see is this.


Apply Filter: Only show the error messages of this URL
http://www.clan-botm.com/index.php?pretty;action=pm&amp;sa=send;f=inbox;pmsg=2269;u=all
Apply Filter: Only show the errors with the same message
8: Undefined index: attach_restrict_pmAttachmentSizeLimit
Apply Filter: Only show the errors from this file
File: /home/bikesnst/public_html/clan-botm.com/Sources/PersonalMessage.php
Line: 1992
Title: Re: PM Attachments
Post by: dougiefresh on February 16, 2017, 07:54:58 PM
Bugger, what I should have said was I got it installed.

Everything looks great, except no files are sent. The only error I can see is this.


Apply Filter: Only show the error messages of this URL
http://www.clan-botm.com/index.php?pretty;action=pm&amp;sa=send;f=inbox;pmsg=2269;u=all
Apply Filter: Only show the errors with the same message
8: Undefined index: attach_restrict_pmAttachmentSizeLimit
Apply Filter: Only show the errors from this file
File: /home/bikesnst/public_html/clan-botm.com/Sources/PersonalMessage.php
Line: 1992
O:) I actually found this earlier today, before you reported it.  I've already fixed this bug for the next version, as well as the inability to remove PM attachments.....
Title: Re: PM Attachments
Post by: dougiefresh on February 17, 2017, 11:04:34 AM
Uploaded v2.0 Beta 2 - February 17th, 2017
o Moved function removePMAttachments to Subs-PMAttachments.php.
o Moved load language statement to earlier in PersonalMessage.php.
Title: Re: PM Attachments
Post by: landyvlad on February 18, 2017, 03:19:33 AM
Instal went fine and seems to be working nicely on my forum,. Cheers.
Title: Re: PM Attachments
Post by: Kinsman on February 18, 2017, 06:35:29 AM
No joy here, but I have quite a few PM Mods, so maybe one of those is interfering
Title: Re: PM Attachments
Post by: dougiefresh on February 18, 2017, 09:42:08 AM
@landyvlad:  Good to hear....

@Kinsman:  List your PM mods so that I can see what is going on.  Maybe I can fix the incompatibility.....
Title: Re: PM Attachments
Post by: Kinsman on February 18, 2017, 04:38:19 PM
PM Notification Bar
PM Settings
Search Sent PM's
Show Unread PM's
PM Quick Reply
Title: Re: PM Attachments
Post by: dougiefresh on February 19, 2017, 09:12:53 AM
I've resolved the incompatibility issue with the PM Settings (http://custom.simplemachines.org/mods/index.php?mod=3823) and PM Quick Reply (http://custom.simplemachines.org/mods/index.php?mod=4047) mods for the next version.  All other mods listed were not incompatible while installing them.  I didn't test for functionality, although I'm pretty sure that that will be a non-issue....
Title: Re: PM Attachments
Post by: landyvlad on February 19, 2017, 09:15:52 PM
edit: removed this post. I found my problem I had asked about was in the settings. Sorry.
Title: Re: PM Attachments
Post by: Kinsman on February 20, 2017, 03:22:02 AM
Cool, I'll keep an eye out and test it.
Title: Re: PM Attachments
Post by: dougiefresh on February 20, 2017, 09:36:14 PM
Hello,

I'm getting the error below in the error log after installing this mod. Any idea what it is and how to correct it?

http://mydomain/index.php?action=pm;sa=send;f=inbox;pmsg=182;u=all

2: in_array() expects parameter 2 to be array, null given

File: /home/me/public_html/Sources/PersonalMessage.php

Line: 2067

Hopefully, this bug report has been fixed for the next version.
Title: Re: PM Attachments
Post by: dougiefresh on February 21, 2017, 10:22:34 AM
Uploaded v2.0 Beta 3 - February 21st, 2017
o Fixed undefined element error that could happen, was reported but never fixed.
o Fixed some indentation issues within the mod.
o Resolved incompatibility with PM Settings (http://custom.simplemachines.org/mods/index.php?mod=3823) mod.
o Resolved incompatibility with PM Quick Reply (http://custom.simplemachines.org/mods/index.php?mod=4047) mod.



@RSI and @Kinsman:  Hopefully this update will solve the bug reports that you submitted.  Thank you for the bug reports!
Title: Re: PM Attachments
Post by: Kinsman on February 22, 2017, 01:41:52 AM
Unfortunately still no attachments here, no errors either so not sure what's up with it really.
Title: Re: PM Attachments
Post by: dougiefresh on February 22, 2017, 09:20:59 PM
Unfortunately still no attachments here, no errors either so not sure what's up with it really.
Check two things for me:
1) In Admin => Forum => Attachments and Avatars => PM Attachment Settings, is the PM Attachments mode set to Enable all attachments?

2) Have you granted permission to upload and view PM attachments for the membergroups?

Failure to do either of these things will result in the inability to upload and/or view PM attachments on your forum.
Title: Re: PM Attachments
Post by: Kinsman on February 23, 2017, 03:54:58 AM
Yep, also 775 the pm attachments folder, also installed 1.6 to check, still nothing.

I have however removed the Play Media Attachments mod, as I discovered it was preventing img thumbnails.

Prob just a case of too many mods I guess.
Title: Re: PM Attachments
Post by: Kinsman on February 23, 2017, 04:10:16 AM
Huzzah!, I got 1.6 working by adding all the missing edits manually to themes/default/personalmessagetemplate file.

No idea why the installer didnt add or flag them, but all good now with no errors.
Title: Re: PM Attachments
Post by: dougiefresh on February 23, 2017, 10:38:24 AM
My suggestion would be to check the permissions on the template file.  If the forum can't change it, then (obviously) it won't be changed by Package Manager.....

Meanwhile, I'll look at the Play Attachments mod to see what the conflict might be.....
Title: Re: PM Attachments
Post by: Kinsman on February 24, 2017, 01:50:39 AM
The forum changed one line, but skipped 2, without complaining about it, I only picked it up during uninstallation, so then edited the entire file manually.
Title: Re: PM Attachments
Post by: GL700Wing on March 06, 2017, 05:33:22 PM
I'm getting the following errors in the log file (I've removed my forum name details from the links below):

./forum/index.php?action=dlpmattach;pm=43468;attach=523
8192: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead
File: ./forum/Sources/Subs-PMAttachments.php
Line: 679


I think the code to replace 'preg_replace' stataments with 'preg_replace_callback' in ./Sources/Subs-PMAttachments.php should be as follows:

Find
Code: [Select]
      // Different browsers like different standards...
      if ($context['browser']['is_firefox'])
         header('Content-Disposition: attachment; filename*="UTF-8\'\'' . preg_replace('~&#(\d{3,8});~e', '$fixchar(\'$1\')', $utf8name) . '"');

      elseif ($context['browser']['is_opera'])
         header('Content-Disposition: attachment; filename="' . preg_replace('~&#(\d{3,8});~e', '$fixchar(\'$1\')', $utf8name) . '"');

      elseif ($context['browser']['is_ie'])
         header('Content-Disposition: attachment; filename="' . urlencode(preg_replace('~&#(\d{3,8});~e', '$fixchar(\'$1\')', $utf8name)) . '"');

      else
         header('Content-Disposition: attachment; filename="' . $utf8name . '"');

Replace with:
Code: [Select]
      // Different browsers like different standards...
      if ($context['browser']['is_firefox'])
         header('Content-Disposition: attachment; filename*=UTF-8\'\'' . rawurlencode(preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name)));

      elseif ($context['browser']['is_opera'])
         header('Content-Disposition: attachment; filename="' . preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name) . '"');

      elseif ($context['browser']['is_ie'])
         header('Content-Disposition: attachment; filename="' . urlencode(preg_replace_callback('~&#(\d{3,8});~', 'fixchar__callback', $utf8name)) . '"');

      else
         header('Content-Disposition: attachment; filename="' . $utf8name . '"');
Title: Re: PM Attachments
Post by: dougiefresh on March 07, 2017, 09:12:30 PM
Uploaded v2.1 - March 7th, 2017
o Replaced code that used preg_match with preg_match_callback.  Thanks, GL700Wing (http://www.simplemachines.org/community/index.php?action=profile;u=112942)!



@GL700Wing:  Thanks for the bug report!  It's been incorporated into the mod!

@Everybody:  Since nobody has reported any new issues (aside from GL700Wing) with the mod lately, I've decided to bump it to version 2.1.....
Title: Re: PM Attachments
Post by: SoLoGHoST on March 09, 2017, 03:38:26 AM
Looking good dougiefresh.  Glad to see some work on this mod, and you reduced the filesize dramatically as well.  The templating and modifications in the various xml files got a bit messy due to the many upgrades along the way, as I was aiming more towards compatibility and support with other mods, and not caring too much about the amount of files or code involved in making that happen.  And besides, I was still learning about all of the various hooks in SMF as well.

Haven't tested this mod yet, but look forward to giving it a test drive soon, just to see how things look and function and/or if you've added anything new besides restructuring the code base.

Cheers :)
Title: Re: PM Attachments
Post by: EdjKa on March 10, 2017, 10:24:15 AM
The forum changed one line, but skipped 2, without complaining about it, I only picked it up during uninstallation, so then edited the entire file manually.

Same here, is there a way to fix the installation process?
Title: Re: PM Attachments
Post by: dougiefresh on March 10, 2017, 11:08:27 AM
Please attach your Themes/default/PersonalMessage.template.php after you've installed the mod, so I can see what is being missed by Package Manager.  Can't really investigate without knowing what operations are failing....
Title: Re: PM Attachments
Post by: EdjKa on March 10, 2017, 01:20:03 PM
Here you are!
Title: Re: PM Attachments
Post by: dougiefresh on March 11, 2017, 10:33:53 PM
@EdjKa:  I can't reproduce the missing operations that you reported.  The file you supplied uninstalls without errors on my localhost server using the version 2.1 mod.....
Title: Re: PM Attachments
Post by: EdjKa on March 13, 2017, 07:04:10 AM
That's really strange, i've RE-installed mod again, all LOOKS good, but nothings attaches to PM's.
Title: Re: PM Attachments
Post by: dougiefresh on March 15, 2017, 12:12:34 AM
Assuming you haven't uninstalled the mod since your post, attach your CURRENT PersonalMessage.template.php.  I need to know what mods you are running as well....
Title: Re: PM Attachments
Post by: EdjKa on March 15, 2017, 05:38:30 AM
Nothing actually changed there, here you are :)

BTW Getting this error with installed mod: /home/hsghpmfx/public_html/smf/Themes/default/GenericControls.template.php (send sub template - eval?)
Title: Re: PM Attachments
Post by: dougiefresh on March 15, 2017, 03:28:39 PM
Uploaded v2.2 - March 15th, 2017
o Fixed PersonalMessage.template.php so that Send screen attaches files properly (again).



@EdjKa:  Thank you for providing enough to work with.  The issue you are seeing is the result of the addition not being put in the right spot.  There are two possibilities that it could go into, and the first just doesn't work for this operation.  I've fixed it to make sure it is placed on the second operation in your file.

As for the second part of your bug report (aka: GenericControls.template.php), you haven't provided enough information for me to diagnose this bug report.  I've seen many reports where the file specified that the error originates from is wrong, usually due to another mod making a change in the menus....
Title: Re: PM Attachments
Post by: EdjKa on March 15, 2017, 04:01:14 PM
Replaced PersonalMessage with the original one, RE-installed the mod with 2.2 version and it works now! Thank you very much!
Title: Re: PM Attachments
Post by: DarkAngel612 on May 05, 2017, 07:02:05 PM
smf 2.0.13
various mods installed


see this thread for the problem please, I forgot to come to this thread since it is the specific mod.

the gist: allowed pm attachments no longer show in the pm area, regardless of theme

https://www.simplemachines.org/community/index.php?topic=553678.0
Title: Re: PM Attachments
Post by: SoLoGHoST on June 02, 2017, 10:18:32 PM
@DarkAngel612 - Yes, the allowed attachment types should be showing up as I saw in the pic via that topic you posted, it was not there.  This was there before dougiefresh took over this mod and released a few more versions of it.  It's possible this was overlooked during the crunching of the mod filesize...  Seems like a valid design flaw to me... just my 2 cents.  Have you tried reinstalling the mod, after fully uninstalling it?  Or installing this mod on a fresh install of SMF with no other modifications installed?  If so, and same thing happens, than definitely a design flaw.
Title: Re: PM Attachments
Post by: DarkAngel612 on June 02, 2017, 11:46:33 PM
@DarkAngel612 - Yes, the allowed attachment types should be showing up as I saw in the pic via that topic you posted, it was not there.  This was there before dougiefresh took over this mod and released a few more versions of it.  It's possible this was overlooked during the crunching of the mod filesize...  Seems like a valid design flaw to me... just my 2 cents.  Have you tried reinstalling the mod, after fully uninstalling it?  Or installing this mod on a fresh install of SMF with no other modifications installed?  If so, and same thing happens, than definitely a design flaw.

Yes I sure did, several times since I know 3/4 of my errors are operator trouble...can't type from time to time and then sometimes server eats files but claims they are there...LOL

No difference at all, it is still not showing up. I think I have an older version that I can look at the code to see if I can tell what is missing, then add it in there.
Title: Re: PM Attachments
Post by: GL700Wing on June 03, 2017, 12:46:23 AM
No difference at all, it is still not showing up. I think I have an older version that I can look at the code to see if I can tell what is missing, then add it in there.
Have you confirmed that "Check attachment's extension" is checked in Administration Center -> Attachments and Avatars -> PM Attachment Settings?  If it isn't checked 'Allowed file types' isn't displayed.
Title: Re: PM Attachments
Post by: DarkAngel612 on June 03, 2017, 05:18:10 AM
No difference at all, it is still not showing up. I think I have an older version that I can look at the code to see if I can tell what is missing, then add it in there.
Have you confirmed that "Check attachment's extension" is checked in Administration Center -> Attachments and Avatars -> PM Attachment Settings?  If it isn't checked 'Allowed file types' isn't displayed.

Bless your sweet little heart sugar...you hit it on the head, not as hard as I was clobbering my own noggin though...LOL

When it got deselected I'll never know but now they show up again.

Thanks and have a great weekend.
Title: Re: PM Attachments
Post by: GL700Wing on June 03, 2017, 05:21:39 AM
Bless your sweet little heart sugar...you hit it on the head, not as hard as I was clobbering my own noggin though...LOL

When it got deselected I'll never know but now they show up again.

Thanks and have a great weekend.

;)

Title: Re: PM Attachments
Post by: dougiefresh on July 05, 2017, 07:07:49 PM
@DarkAngel612:  Glad you got your issue straightened out!
Title: Re: PM Attachments
Post by: DarkAngel612 on July 05, 2017, 11:52:08 PM
LOL well I have always said that if something should go wrong my forums will lead the way.

I reinstalled it into that naughty forum, then last night I went thru the others and wouldn't you know it.....

another one went blank.

I had to go into the server files, manually change out the files and removed the old zip. This got my site to come back into view --- same error --- and the other one that was naughty  had to removed the old one cause it went blank when I uninstalled it in admin...LOL I uploaded all the files and it saw everything as the proper version...weird.

Now all forums are updated and working bootifully then I got to go walking to see the neighborhood fireworks.
Title: Re: PM Attachments
Post by: Beowulf1976 on July 07, 2017, 12:33:42 PM
Dougiefresh, I am afraid it was this mod that was causing my completely borked UI in my pm's (you'll remember I THOUGHT it was your inline attachments mod that was the issue?) well, after "disabling attachments" the pm template went completely back to normal. (Did this WITH and WITHOUT your inline attachments mod installed - incidentally one of the only mods I have installed on my forum that didn't scream any errors whatsoever! :) a very clean mod too!)

Let me know if you need to know what other mods I have, or any settings. Hell I'll even give you access to my forum so you can see it for yourself if it helps :)

Best wishes

Beo
Title: Re: PM Attachments
Post by: dougiefresh on July 07, 2017, 02:12:06 PM
Hmmmm....  I'll take a look at the mod again when I get some time.  I've got 7 mods to upgrade for SMF 2.1 Beta 3, and a few mods to fix in general....
Title: Re: PM Attachments
Post by: dougiefresh on July 07, 2017, 02:49:53 PM
UPDATE:  I was trying to modify my Post and PM Inline Attachments (http://custom.simplemachines.org/mods/index.php?mod=3770) mod and discovered that SMF 2.1 Beta 3 takes a completely new approach to attachments.  While the current code can insert attachments, there is a distinct "SMF 2.0"-ishness to the PM attachments that would have felt at home in SMF 2.1 Beta 2, but which is out of place in SMF 2.1 Beta 3.  Since I am interested in maintaining some sense of "SMF 2.1"-ishness within the forum, a complete rewrite looks necessary in order to accomplish this.....
Title: Re: PM Attachments
Post by: dougiefresh on July 11, 2017, 12:09:16 PM
Uploaded v2.3 - July 11th, 2017
o Removed support for SMF 2.0 RC versions, as well as SMF 2.0 thru 2.0.3.
o Replaced IFNULL with COALESCE in database queries for better Postgres support.



@Everybody:  I have removed support for the SMF 2.0 RC versions, as well as SMF 2.0 thru SMF 2.0.3.  My feelings on this particular topic is that I will not support such old forum installs.  Once again, I have kept the old version 1.6 on the mod download page in the event someone needs it, but any forum running 1.6 will not get support from me.
Title: Re: PM Attachments
Post by: dougiefresh on September 02, 2017, 10:55:54 AM
Uploaded v2.4 - September 2nd, 2017
o Added SMF 2.0.x-ish support for SMF 2.1 Beta 3.



UPDATE:  The changes required to bring SMF 2.1 Beta 3 changes to this mod won't be as drastic as I had initially feared.  Evidentally, most of the changes are done via Javascript, which means I've have some fun trying to determine what changes need to be made in order to do drag-and-drop for file uploading, and etc...
Title: Re: PM Attachments
Post by: FractalFrank on September 04, 2017, 04:27:04 PM
hello and thanks for this great mod! it does what it promises in the way I expect.  :)

but we just noticed that it messes with the adminarea quick-search function (not the main search, but /admin/?area=search )
we get this error, and no searches are possible at all:
"Call to undefined function ManagePMAttachmentSettings()"

any idea how we can fix this?


we're using:
SMF 2.0.14
PM_Attachments v2.4

with these other mods:
1.   SMF Gallery Pro Recent Comments Board Index   2.0
2.   SMF Gallery Pro Recent Images Board Index   2.0.1
3.   SMF Gallery Pro Recent Profile Images   2.0.1
4.   SMFPacks Facepunch Pro Mod   1.0.10   
5.   SMFPacks Shoutbox Pro   1.3   
6.   Ohara YouTube Embed   1.2.9
7.   AMSP - Add Member's Signature Permission   1.0.1
8.   Downloads System   3.0.2   
9.   Stop Forum Spam   1.0   
10.   Reason For Editing Mod   2.3.3   
11.   Recent Forum Topics Boardindex   1.0   
12.   Advanced Attachments Uploader   3.0   
13.   FancyBox 4 SMF   0.5.1.1   
14.   Pretty URLs   1.1.4   
15.   SMF Gallery Pro   7.2.2a   

themes:
-Dilber Multicolor
-Yorky
(error happens in both)
Title: Re: PM Attachments
Post by: dougiefresh on September 04, 2017, 07:52:24 PM
Wow....  I'm looking into it right now....
Title: Re: PM Attachments
Post by: dougiefresh on September 04, 2017, 10:46:47 PM
Uploaded v2.5 - September 4th, 2017
o Moved all possible hook code to Subs-PMAttachmentsHooks.php.
o Fixed issue where admin search was broken due to file not being loaded.



@FractalFrank:  This update should fix the issue that you found!  Thanks for the bug report!
Title: Re: PM Attachments
Post by: FractalFrank on September 05, 2017, 04:32:36 AM
wow, that was fast!  :)

uninstalled and updated. sorry to say, we still get the same error.
Don't know what else information I could provide - just let me know..
Title: Re: PM Attachments
Post by: dougiefresh on September 06, 2017, 10:37:26 AM
Uploaded v2.5.1 - September 6th, 2017
o SMF 2.0: Fixed admin search functionality.



@FractalFrank:  Sorry, I thought I fixed it for both versions.  Turns out the code for SMF 2.0 is a bit different than SMF 2.1 Beta 3....  This update fixes the issue.  Thank you for the bug report.
Title: Re: PM Attachments
Post by: DarkAngel612 on September 06, 2017, 05:23:05 PM
so we that still use 2.0.14 can still use this, we do not have to have the beta version of new version ?
Title: Re: PM Attachments
Post by: dougiefresh on September 06, 2017, 08:48:46 PM
so we that still use 2.0.14 can still use this, we do not have to have the beta version of new version ?
No, you don't need SMF 2.1 Beta 3 in order to use this mod.  It should work fine with 2.0.14....
Title: Re: PM Attachments
Post by: DarkAngel612 on September 06, 2017, 10:13:39 PM
thanks sweety, love the mod and your avatar...tis what I have been doing since January last year...LOL
Title: Re: PM Attachments
Post by: FractalFrank on September 07, 2017, 05:36:15 AM
@FractalFrank:  Sorry, I thought I fixed it for both versions.  Turns out the code for SMF 2.0 is a bit different than SMF 2.1 Beta 3....  This update fixes the issue.  Thank you for the bug report.

thx a lot - works like a charm now!
great support!
Title: Re: PM Attachments
Post by: dougiefresh on September 07, 2017, 11:26:30 PM
Glad I could help ya!
Title: Re: PM Attachments
Post by: aegersz on October 14, 2017, 07:47:10 AM
Hi dougie, how/where i can access the attachments sent in PMs ?

I know in which directory you have them but i'd like to audit them (encryption is ON, also) ... is this possible ?
Title: Re: PM Attachments
Post by: dougiefresh on October 14, 2017, 11:16:26 AM
Audit them how?  The point of personal attachments is privacy.  I don't think even the admin can't see the attachments without the related personal message being reported....
Title: Re: PM Attachments
Post by: aegersz on October 14, 2017, 01:01:50 PM
there can be NO privacy on my site as the members can be subjected to any audit, any time. We need to be able to limit people making us a liability, however futile that is sometimes.

not a big problem, i can always disable it for regular members anyway if need be.

my only gripe with SMF is the lack of serious auditing (yes, anti-privacy) tools but then again, my needs are unique.
Title: Re: PM Attachments
Post by: aegersz on October 15, 2017, 03:03:51 AM
i came up with a solution to all my auditing issues and i can download attachments ... see https://www.simplemachines.org/community/index.php?topic=556634
Title: Re: PM Attachments
Post by: dougiefresh on October 15, 2017, 10:52:15 AM
I can't see the thread you linked to.....
Title: Re: PM Attachments
Post by: aegersz on October 15, 2017, 01:25:08 PM
neither can I. someone deleted my thread.
Title: Re: PM Attachments
Post by: dougiefresh on October 17, 2017, 12:41:57 PM
neither can I. someone deleted my thread.
Hmmm....  Unfortunate.  Perhaps I can come up with something....  Or you could share your solution in this thread?

BTW, if moderators have a problem with this, please speak up!
Title: Re: PM Attachments
Post by: aegersz on October 17, 2017, 01:46:29 PM
sure. I run a VPS and when I started I didn't know much about Linux so I installed almost everything I could.

I also had to configure a mail server, Postfix.

Postfix has an option to (BCC) blind carbon copy ALL mail both in and out to a nominated account ... I simply set that and then I could see the PM notification emails and their attachments. I am worried about people sending password protected zip file attachments in an attempt to solicit as well as normal PMs to do the same.

so now I can read each PM and can audit them as they appear. simple.
Title: Re: PM Attachments
Post by: dougiefresh on October 18, 2017, 10:12:38 AM
Okay, so not a mod-related solution....  Gotcha....
Title: Re: PM Attachments
Post by: dougiefresh on November 19, 2017, 10:55:11 PM
Hi dougie, how/where i can access the attachments sent in PMs ?

I know in which directory you have them but i'd like to audit them (encryption is ON, also) ... is this possible ?
Just so that you know, SMF's official response to the question of allowing admin to read other member's PMs not addressed to admin can be read in this thread (https://www.simplemachines.org/community/index.php?topic=368201.0).  I strongly suggest you read the thread.  And, yes, I realize that you already figured a solution to your needs....

Personally, I would be hesitant to add such capability to this mod, as doing so might get the mod rejected from the customization site.  While I share the ability to update the mod with SoLoGHoST, it is NOT my mod....  (I still consider it MINE!  O:) )

EDIT:  Fixed the very first statement to read "to read other member's PMs not addressed to admin"....
Title: Re: PM Attachments
Post by: aegersz on November 23, 2017, 02:36:12 AM
thanks, I read the topic and it makes sense to almost every forum except mine. The only thing i can add is that I use the PM Warning mod to let members know that;

+ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -+
|  Note: All PMs are visible to staff and may be subject to an audit at any time            |
+ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -+
Title: Re: PM Attachments
Post by: GL700Wing on November 29, 2017, 11:24:32 PM
I've found an anomaly and a minor display bug with this mod in relation to PM attachments.

The anomaly is the permission to prevent people viewing attachments that have been sent to them with a PM.  I understand the need to manage who can actually send attachments but surely if someone has received an attachment with a PM they should be always be allowed to see it.  As such I think the permission to allow/disallow/deny viewing attachments sent with a PM should be removed.

The minor display bug is the attachment row has a horizontal scroll bar - a small adjustment to the installation code (ie, reduce width from 100% to 98%) for ./Themes/default/PersonalMessage.template.php removes the horizontal scroll bar.

Find:
Code: [Select]
// Show the member's signature?
Add Before:
Code: [Select]
// Assuming there are attachments...
if (allowedTo('pm_view_attachments') && !empty($message['attachment'])) {


echo '
<div id="post_', $message['id'], '_footer" class="attachments">';

echo '
<hr width="98%" size="1" class="hrcolor" />
<div style="overflow: ', $context['browser']['is_firefox'] ? 'visible' : 'auto', '; width: 98%;">';

foreach ($message['attachment'] as $attachment)
{
if ($attachment['is_image'])
{
if ($attachment['thumbnail']['has_thumb'])
echo '
<a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" border="0" /></a><br />';
else
echo '
<img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" border="0" /><br />';
}
echo '
<a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.gif" align="middle" alt="*" border="0" />&nbsp;' . $attachment['name'] . '</a> ';

echo '
(', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . ' - ' . $txt['attach_viewed'] : ' - ' . $txt['attach_downloaded']) . ' ' . $attachment['downloads'] . ' ' . $txt['attach_times'] . '.)<br />';
}
echo '
</div></div>';

}
Title: Re: PM Attachments
Post by: GL700Wing on November 30, 2017, 02:03:44 AM
I discovered another minor bug with this mod - there is no option to clear/remove attachments while composing a PM unless you start a new message.

In the mod installer file for ./Themes/default/PersonalMessage.template.php (the value for 'size' has also been made consistent with the 'size' value in ./Themes/default/Post.template.php)

Find:
Code: [Select]
<input type="file" size="38" name="attachment[]" class="input_file" />';Replace:
Code: [Select]
<input type="file" size="60" name="attachment[]" id="attachment1" class="input_file" /> (<a href="javascript:void(0);" onclick="cleanFileInput(\'attachment1\');">', $txt['clean_attach'], '</a>)';

Find:
Code: [Select]
echo '
<script language="JavaScript" type="text/javascript"><!-- // --><![', 'CDATA', '[
var allowed_attachments = ', $context['num_allowed_attachments'], ' - 1;

function addAttachment()
{
if (allowed_attachments <= 0)
return alert("', $txt['more_attachments_error'], '");

setOuterHTML(document.getElementById("moreAttachments"), \'<dd class="smalltext"><input type="file" size="38" name="attachment[]" class="input_file" /><\' + \'/dd><dd class="smalltext" id="moreAttachments"><a href="javascript:void(0);" onclick="addAttachment(); return false;">(', $txt['more_attachments'], ')<\' + \'/a><\' + \'/dd>\');

allowed_attachments = allowed_attachments - 1;

return true;
}
// ', ']', ']></script>

Replace:
Code: [Select]
echo '
<script language="JavaScript" type="text/javascript"><!-- // --><![', 'CDATA', '[
var allowed_attachments = ', $context['num_allowed_attachments'], ';
var current_attachment = 1;

function addAttachment()
{
allowed_attachments = allowed_attachments - 1;
current_attachment = current_attachment + 1;
if (allowed_attachments <= 0)
return alert("', $txt['more_attachments_error'], '");

setOuterHTML(document.getElementById("moreAttachments"), \'<dd class="smalltext"><input type="file" size="60" name="attachment[]" id="attachment\' + current_attachment + \'" class="input_file" /> (<a href="javascript:void(0);" onclick="cleanFileInput(\\\'attachment\' + current_attachment + \'\\\');">', $txt['clean_attach'], '</a>)\' + \'</dd><dd class="smalltext" id="moreAttachments"><a href="#" onclick="addAttachment(); return false;">(', $txt['more_attachments'], ')<\' + \'/a><\' + \'/dd>\');

return true;
}
// ', ']', ']></script>
Title: Re: PM Attachments
Post by: dougiefresh on December 06, 2017, 12:17:05 PM
Uploaded v2.6 - December 6th, 2017
o Per GL700Wing: (https://www.simplemachines.org/community/index.php?topic=331969.msg3950084#msg3950084) Horizontal scroll bar beneath PM attachments has been fixed.
o Per GL700Wing: (https://www.simplemachines.org/community/index.php?topic=331969.msg3950098#msg3950098) Added missing functionality to clear/remove attachments.



@GL700Wing:  Thank you for both the bug fixes that you provided!  The changes you suggested have been incorporated into the mod for this version!

The anomaly is the permission to prevent people viewing attachments that have been sent to them with a PM.  I understand the need to manage who can actually send attachments but surely if someone has received an attachment with a PM they should be always be allowed to see it.  As such I think the permission to allow/disallow/deny viewing attachments sent with a PM should be removed.
Let me think about this one....
Title: Re: PM Attachments
Post by: GL700Wing on December 07, 2017, 01:17:55 AM
Found one other minor annoyance/issue - every time I install this mod it overwrites the PM Attachment settings I had previously saved with the default settings.

In the db_install.php in the mod:
Find:
Code: [Select]
$smcFunc['db_insert']('replace',
Replace:
Code: [Select]
$smcFunc['db_insert']('ignore',
Title: Re: PM Attachments
Post by: SoLoGHoST on December 07, 2017, 12:14:28 PM
I've found an anomaly and a minor display bug with this mod in relation to PM attachments.

The anomaly is the permission to prevent people viewing attachments that have been sent to them with a PM.  I understand the need to manage who can actually send attachments but surely if someone has received an attachment with a PM they should be always be allowed to see it.  As such I think the permission to allow/disallow/deny viewing attachments sent with a PM should be removed.

I disagree.  The site administrator should have complete control over who views/downloads what on their site.  Also, it is possible that some groups of people may not wish to receive attachments via PM, for whatever reason.  The admin can than simply add these people to a group and just disable viewing attachments for these members by setting the permission on this.  The ability to view attachments could also be post related, for example, when a user has a certain amount of posts on the site.  This can help to increase traffic on the site, and help to encourage activity, instead of people just registering on the site for the ability to use up the sites bandwidth in downloading an attachment that someone wants to share with them.  Also, prevents people from sharing illegal files to unknown members with no activity.  There could be many other reasons as well.
Title: Re: PM Attachments
Post by: GL700Wing on December 07, 2017, 04:46:58 PM
I've found an anomaly and a minor display bug with this mod in relation to PM attachments.

The anomaly is the permission to prevent people viewing attachments that have been sent to them with a PM.  I understand the need to manage who can actually send attachments but surely if someone has received an attachment with a PM they should be always be allowed to see it.  As such I think the permission to allow/disallow/deny viewing attachments sent with a PM should be removed.

I disagree.  The site administrator should have complete control over who views/downloads what on their site.  Also, it is possible that some groups of people may not wish to receive attachments via PM, for whatever reason.   The admin can than simply add these people to a group and just disable viewing attachments for these members by setting the permission on this.  The ability to view attachments could also be post related, for example, when a user has a certain amount of posts on the site.  This can help to increase traffic on the site, and help to encourage activity, instead of people just registering on the site for the ability to use up the sites bandwidth in downloading an attachment that someone wants to share with them.  Also, prevents people from sharing illegal files to unknown members with no activity.  There could be many other reasons as well.
My reasoning for thinking this is an anomaly is that PMs are private/personal and as such I believe a site administrator shouldn't be able to prevent members who are allowed to read PMs from being able to see attachments that have been sent with them.  That said, I hadn't thought about the situation where some members may not want to receive attachments via PMs.

Currently if a member isn't allowed to Read PMs a warning message is displayed if you try to send them a PM.  However, there is no similar warning message displayed if you try to send an attachment to a member who isn't allowed to view it - in retrospect this is what is actually needed.
Title: Re: PM Attachments
Post by: Rock Lee on December 07, 2017, 07:30:23 PM
I leave the translation to normal Latin Spanish and utf-8, I have some technical doubts in some lines but try to translate it as well as possible any problem let me know :-[ I think I did not miss any line but equally anything tells me...


Regards!
Title: Re: PM Attachments
Post by: dougiefresh on December 07, 2017, 11:31:06 PM
Currently if a member isn't allowed to Read PMs a warning message is displayed if you try to send them a PM.  However, there is no similar warning message displayed if you try to send an attachment to a member who isn't allowed to view it - in retrospect this is what is actually needed.
I will see what I can do about this feature request....
Title: Re: PM Attachments
Post by: dougiefresh on December 08, 2017, 10:21:05 PM
@Rock Lee:  Your translation has been included for the upcoming version!  Thank you!