Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: TheDragon on October 11, 2009, 06:08:04 PM

Title: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 06:08:04 PM
see pix (v 1.10 ) the child board goes ALL the way (this is what I prefer)
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Ffarm4.static.flickr.com%2F3446%2F4002663370_51ab56f058.jpg&hash=b4f741d169bc74d9734d4dcd79d9627cc6bfd097)

BUT . . . v 2.0 stops at the "post box"

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Ffarm3.static.flickr.com%2F2614%2F4001900469_b1c47e9026.jpg&hash=b4b190d73ab4f7384f316195daab9ffa908e6661)

Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 11, 2009, 07:11:23 PM
Can you please attach your BoardIndex.template.php file?
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: Antechinus on October 11, 2009, 07:19:01 PM
Basically, those table cells will be set to <td rowspan="2"> which as you might suspect means they span two rows in height. ;)
If you change them to rowspan="1", or even just remove the rowspan code entirely so they default to 1, then it will look the way you want to to look.

You will also need to change the child boards <td> to <td colspan="3"> so it spans three columns. Just giving you some basic tips on html tables for future reference. ;)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 07:23:54 PM
Quote from: Antechinus on October 11, 2009, 07:19:01 PM
Basically, those table cells will be set to <td rowspan="2"> which as you might suspect means they span two rows in height. ;)
If you change them to rowspan="1", or even just remove the rowspan code entirely so they default to 1, then it will look the way you want to to look.

You will also need to change the child boards <td> to <td colspan="3"> so it spans three columns. Just giving you some basic tips on html tables for future reference. ;)

cool - I can do that  -  8)
but
make the changes in WHAT file  ??? ???
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 07:24:58 PM
Quote from: tyty1234 on October 11, 2009, 07:11:23 PM
Can you please attach your BoardIndex.template.php file?

do you still want this?
ie after the post from Antechinus?
( no problem for me to upload if you still want it)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 07:32:03 PM
Quote from: Antechinus on October 11, 2009, 07:19:01 PM
Basically, those table cells will be set to <td rowspan="2"> which as you might suspect means they span two rows in height. ;)
If you change them to rowspan="1", or even just remove the rowspan code entirely so they default to 1, then it will look the way you want to to look.

You will also need to change the child boards <td> to <td colspan="3"> so it spans three columns. Just giving you some basic tips on html tables for future reference. ;)

there is NO td=colspan in the BoardIndex.template.php file
do I "add" it?

Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 11, 2009, 07:37:32 PM
yes, you have to add it. ;)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 07:43:46 PM
Quote from: tyty1234 on October 11, 2009, 07:37:32 PM
yes, you have to add it. ;)

I did in 2 places - are there more and/or did I use the correct syntax??
see below :
**********************
// Show some basic information about the number of posts, etc.
               echo '
            </td>
            <td colspan="3" ', !empty($board['children']) ? ' rowspan="2"' : '', ' class="windowbg stats

smalltext">
               ', $board['posts'], ' ', $board['is_redirect'] ? $txt['redirects'] : $txt['posts'], ' <br />
               ', $board['is_redirect'] ? '' : $board['topics'] . ' ' . $txt['board_topics'], '
            </td>
            <td colspan="3" ', !empty($board['children']) ? ' rowspan="2"' : '', ' class="windowbg2 smalltext

lastpost">';
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 11, 2009, 07:46:37 PM
It's in the right syntax, but in the wrong place. It should be...

Code (Find) Select

<td class="windowbg3 smalltext largepadding"><strong>', $txt['parent_boards'], '</strong>: ', implode(', ', $children), '</td>


Code (Replace With) Select

<td class="windowbg3 smalltext largepadding" colspan="3"><strong>', $txt['parent_boards'], '</strong>: ', implode(', ', $children), '</td>


Don't forget that rowspan Antechinus mentioned. :)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 07:49:45 PM
looks like it is in the style.css file?
or still in the board.template ??
888888888888
found the string - almost works - let me check a few things
(like undo my earier mistakes)
brb

btw = the 'gray' bar now goes 1/2 across the post block - but it also overwrite some of the data there!
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 07:59:57 PM
ok - the grey goes ALL the way over
BUT - still have 'over write issues '
see photo below
(hint - the 'months are 'child boards')

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Ffarm3.static.flickr.com%2F2536%2F4003112882_9b156442a2_o.jpg&hash=f623483a8bce0e9a180107c359e562d6441f3f95)

thanks for ideas - getting closer !
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 11, 2009, 08:01:07 PM
Quote from: tyty1234 on October 11, 2009, 07:46:37 PM
Don't forget that rowspan Antechinus mentioned. :)
:)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 08:43:34 PM
Quote from: tyty1234 on October 11, 2009, 08:01:07 PM
Quote from: tyty1234 on October 11, 2009, 07:46:37 PM
Don't forget that rowspan Antechinus mentioned. :)
:)

ok - but as  the rowspan was in multiple places - I thought that colspan
was 'simpler' - perhaps it is a combination of then both

I CAN do HTML coding by hand - since mid 90's
but is the embedded php with all the "IF" that are little tough for me
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 11, 2009, 08:57:58 PM
OK - sort of out of ideas
changed all 3 rowspan = 2 to =1
made NO difference to site

file attached

Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 12, 2009, 01:12:29 AM
Try changing rowspan to 3.
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: REDSEW on October 12, 2009, 01:24:53 AM
I guess this is not going to well...
Why dont you dig up some codes from the old version, print them out, take your time, get a pen, write, get back on the computer, type your ideas on your new file. I do that for my themes when I cant get help for them, works out fine.
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: Antechinus on October 12, 2009, 07:45:06 AM
Here.

Quote from: tyty1234 on October 12, 2009, 01:12:29 AM
Try changing rowspan to 3.
Interesting concept. Now why would you want to do that?
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 12, 2009, 08:04:52 AM
PERFECT ! Thanks Antechinus !
As grateful as I am, (and I have received numerous hints from users here on many topics)
none have DONE it FOR me (as in posted an edited file)
so, ONLY IF IT IS NO TROUBLE for you
can you 'highlight' the changes you made?
my guess is you removed two of the rowspan calls?
(ie now have just one - before were 3?)
again = thanks
ps
this is all a result from having 12 child boards (one per month)
ergo - needed a WIDE row
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: Antechinus on October 12, 2009, 08:18:55 AM
Just compare the file with an unedited one and you'll see the differences. Easy way is to use this nifty little application: http://winmerge.org/ ;)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: TheDragon on October 12, 2009, 08:30:26 AM
on my way ! ty
***********************
got the file compare program
found the 2 lines you edited
TY - clearway beyond my php skills
ie, could not have done that with out you
btw = I am not a MODS maker
- but hard to believe that others have not sought the same thing I did
(ie return of child board to span the whole table)
hint - make mod
(hey - was 'gonna add a smiley' where did they go????)
oh well - here is an old one  ;P


Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 13, 2009, 03:52:23 AM
Quote from: Antechinus on October 12, 2009, 07:45:06 AM
Here.

Quote from: tyty1234 on October 12, 2009, 01:12:29 AM
Try changing rowspan to 3.
Interesting concept. Now why would you want to do that?
whoops...my bad. I could've sworn you mentioned something about rowspan somewhere in your post. oh well!

glad you got the problem solved Dragon! :)
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: Antechinus on October 13, 2009, 04:01:04 AM
:D Yes, I did, but that was to do with the rowspans on the stats and lastpost cells. They are set to 2 and needed to be changed to 1, which you do by removing the rowspan code completely. Setting them to 3 would make the problem worse. I think you may have confused rowspan with colspan. Rowspan is how many rows a cell spans vertically. Colspan is how many columns it spans horizontally. So in this case we needed everything spanning one row, with the childboards spanning three columns.
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: tyty1234 on October 13, 2009, 04:19:42 AM
lol, I am aware of the difference between colspan and rowspan. I was guess I just interpreted your post wrong. :P
Title: Re: how can I get the 'child board' row in V2.0 to go ALL the way over as in v1.x
Post by: Antechinus on October 13, 2009, 04:40:34 AM
Cool. Some people get them mixed up (or forget about them entirely).