I wonder if it would be hard to create a mod that would allow my moderators access to registration but not to the full set of options connected to the "Moderate forum members"? In truth all I am trying to accomplish is to protect IPs from everyone except Admins which essentially means that I need IP option to be separate. I need this in the absence of a invite mod for 2.0 RC1.2 (which I am using) as it is my members who invite their friends anyhow, so they can ask a mod to manually register their pals and the new members can change their own passwords to suit when they login (I have registration disabled BTW).
Many thanks to anyone who can help with this.
So I take it this is impossible? Or is this another case of me getting my coat?
Not impossible, just not easy and that no-one has felt the desire to write an invite mod for 2.0 yet, especially now that 2.0 RC2 is out, you may find such a mod won't appear for 2.0 RC1.2 (mod authors cannot select it as a version on the mod site, in fact, it's not even an option presented to them)
You're asking for two different things, though. On the one hand you're asking for protection of IP data, on the other hand you're asking for account approvals to be split out.
What about things like banning members? (This will help determine which road to go down)
Ultimately though, it is just that no-one is interested in such a mod at the present time, nothing more. There is nothing in this board that says any mod will be written, unfortunately.
Thanks for the reply Arantor.
Thankfully the ban list is already a separate assignable option in the "administrative duties" section, so my mods already have that most essential power over the members.
My problem is that some of my members are known from another board where their identity is preferred to be anonymous (albeit surrendering it to the staff of that board). Mine is a smaller, more happy-go-lucky board with staff that change every now and then so I have been asked by quite a few members that their IPs stay private to only the senior staff - which was easy when we were running v1x as there was this mod (http://custom.simplemachines.org/mods/index.php?mod=1378) that protected IPs whilst allowing all the other moderation aspects.
The mod I linked to is something near what I am looking for but unfortunately it is not compatible with 2.0 RC1.2 :'(
Is there any way to achieve this even by manually editing the code?
Thanks anyhoo.
So, to be clear, it's just the IP details being split off, not subdividing down most of the moderation functions for forum members?
Quote from: Arantor on November 13, 2009, 11:09:40 AM
So, to be clear, it's just the IP details being split off, not subdividing down most of the moderation functions for forum members?
Absolutley. All I need to do is protect IPs, and barring DB access, I don't care what other moderation or administrative control the moderators have.
I would be eternally grateful for your help or anyone else's for that matter.
OK, we're going to do this in a nice, clean fashion :)
1. Make a permission.
Sources/ManagePermissions.php
'profile_remote_avatar' => array(false, 'profile', 'use_avatar'),
'view_ip_address' => array(false, 'member_admin', 'administrate'),
Themes/default/languages/Modifications.english.php
?>
$txt['permissionname_view_ip_address'] = 'View IP addresses in the main forum';
Clear the file cache after making this edit.
2. Enforce that in the thread view.
Sources/Display.php
'can_see_ip' => allowedTo('moderate_forum') || ($message['id_member'] == $user_info['id'] && !empty($user_info['id'])),
'can_see_ip' => allowedTo('view_ip_address'),
3. To also extend that into the profile viewing area:
Sources/Profile-View.php
if (allowedTo('moderate_forum'))
{
// Make sure it's a valid ip address; otherwise, don't bother...
if (preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/', $memberContext[$memID]['ip']) == 1 && empty($modSettings['disableHostnameLookup']))
$context['member']['hostname'] = host_from_ip($memberContext[$memID]['ip']);
else
$context['member']['hostname'] = '';
$context['can_see_ip'] = true;
}
else
$context['can_see_ip'] = false;
if (allowedTo('view_ip_address'))
{
// Make sure it's a valid ip address; otherwise, don't bother...
if (preg_match('/^\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}$/', $memberContext[$memID]['ip']) == 1 && empty($modSettings['disableHostnameLookup']))
$context['member']['hostname'] = host_from_ip($memberContext[$memID]['ip']);
else
$context['member']['hostname'] = '';
$context['can_see_ip'] = true;
}
else
$context['can_see_ip'] = false;
4. Last but not least the moderation log.
Sources/Modlog.php
// Can they see the IP address?
$seeIP = allowedTo('moderate_forum');
// Can they see the IP address?
$seeIP = allowedTo('view_ip_address');
Now you have a new permission you can assign at user group level to see IP addresses, without granting the moderate forum permission.
NB: Not tested but see no reason it shouldn't work.
Quote from: Arantor on November 13, 2009, 02:45:29 PM
Now you have a new permission you can assign at user group level to see IP addresses, without granting the moderate forum permission.
NB: Not tested but see no reason it shouldn't work.
Many, many thanks for your work Arantor and I will set that up on one of my dummy boards immediately.
One thing though, it is the IPs that I
don't want seen by the moderators, only your closing comment seem to suggest the opposite?
I'll get stuck into it anyhow :)
Thanks
This way you create a permission to assign at usergroup level, a permission to view IP address. If not granted, they don't see it, simple as that, so by default no-one other than admin level can see it, not even those with moderate_forum.
Quote from: Arantor on November 13, 2009, 04:37:51 PM
This way you create a permission to assign at usergroup level, a permission to view IP address. If not granted, they don't see it, simple as that, so by default no-one other than admin level can see it, not even those with moderate_forum.
Hmmm... I set it up and I indeed now have the ability to assign the permission to see IPs separately, but unfortunately when the option "Moderate forum members" is enabled and your new "View IP addresses in the main forum" is disabled for a member of staff, they can still readily see the IPs?
I have double checked and enlisted some help from my staff on my main board, and oddly if I have "View IP addresses in the main forum" enabled and "Moderate forum members" disabled, they cannot see IPs (not that I wanted them to but I thought that they would)?
I'll check again but for now it doesn't appear to be working for me?
Thanks nonetheless.
If any one of the groups they are in gives them that power, they will be able to see the IP addresses.
Quote from: Arantor on November 13, 2009, 05:29:46 PM
If any one of the groups they are in gives them that power, they will be able to see the IP addresses.
Sorry Arantor, I am getting quite confused (not that unusual..)
I am trying essentially to have my site moderators with the "Moderate forum members" permission, not see the members' IPs which in integral to that permission. Is this modification meant to do that as it is not happening for me? If I turn the "Moderate forum members" off they can no longer see IPs but neither can they access registration which I need them to.
Shall I get my coat yet :)
Thanks
If all of the above edits have been made and saved to the server, it should work as intended...
Pick one of those users, and select Show Permissions while in their profile, then please post here what permissions they have.
These are the permissions for a group called "overpaid consultant" which has the moderate-members power but does not have the new IP permission enabled. It can see IPs both on the boards and in the "who's online" list: (I have not posted the board specific permissions and have thinned some out to make it more readable)
manage_membergroups
Manage and assign membergroups Given by: Overpaid Consultant
moderate_forum
Moderate forum members Given by: Overpaid Consultant
pm_read
Read personal messages Given by: Overpaid Consultant
pm_send
Send personal messages Given by: Overpaid Consultant
profile_extra_own
Edit additional profile settings - Own profile Given by: Overpaid Consultant
profile_identity_own
Edit account settings - Own profile Given by: Overpaid Consultant
profile_remote_avatar
Choose a remotely stored avatar Given by: Overpaid Consultant
profile_remove_own
Delete account - Own account Given by: Overpaid Consultant
profile_view_any
View profile summary and stats - Any profile Given by: Overpaid Consultant
profile_view_own
View profile summary and stats - Own profile Given by: Overpaid Consultant
search_posts
Search for posts and topics Given by: Overpaid Consultant
view_mlist
View the memberlist Given by: Overpaid Consultant
view_stats
View forum statistics Given by: Overpaid Consultant
who_view
View Who's Online Given by: Overpaid Consultant
This is the same permission with moderate-members turned off and the new IP permission on, and I have realised that it can see IPs on the boards but not in the "who's online" list. So even though it is not doing what I want, it is doing what it should do.
manage_membergroups
Manage and assign membergroups Given by: Overpaid Consultant
pm_read
Read personal messages Given by: Overpaid Consultant
pm_send
Send personal messages Given by: Overpaid Consultant
profile_extra_own
Edit additional profile settings - Own profile Given by: Overpaid Consultant
profile_identity_own
Edit account settings - Own profile Given by: Overpaid Consultant
profile_remote_avatar
Choose a remotely stored avatar Given by: Overpaid Consultant
profile_remove_own
Delete account - Own account Given by: Overpaid Consultant
profile_view_any
View profile summary and stats - Any profile Given by: Overpaid Consultant
profile_view_own
View profile summary and stats - Own profile Given by: Overpaid Consultant
search_posts
Search for posts and topics Given by: Overpaid Consultant
view_ip_address
View IP addresses in the main forum Given by: Overpaid Consultant
view_mlist
View the memberlist Given by: Overpaid Consultant
view_stats
View forum statistics Given by: Overpaid Consultant
who_view
View Who's Online Given by: Overpaid Consultant
I am still no better off unfortunatley as I still cannot protect IPs from those who have the moderate-member power, and I'll check the code again.
Sorry to be such a burdon.
You're not a burden at all !
Odd. I didn't change Who.php at all.
Something is definitely weird here.
Quote from: Arantor on November 13, 2009, 07:06:38 PM
You're not a burden at all !
That is not what the missus says..
I'll try it on a clean installation on my localhost as I have made a lot of other edits to get things to work on my test site, I'll report in the morning if the problem is my end.
Thanks for your patience.
Let me know how that goes, in the meantime I can play around with these edits and see if I can reproduce it.
Well, I replicated this on a clean, local installation and it appears to do exactly the same thing - which is that it always displays the IP to any membergroup that has "moderate members" enabled, regardless of whether I have disabled the new modification?
I have checked this repeatedly and I am convinced it is not my ineptness that is the cause, however, I am not guaranteeing that..
Have you been able to replicate the issue?
Continued thanks.
/me screwed up, clearly. Though I did point out it wasn't tested.
I'll go back over the code later on today to figure out what I did wrong.
Quote from: Arantor on November 14, 2009, 10:23:52 AM
/me screwed up, clearly. Though I did point out it wasn't tested.
My money is still on it being my fault :)
Well, I'll build a package with these edits in, and try it myself on a fresh 2.0 RC1.2 (though it might work on 2.0 RC2 too) but I have some other stuff to do first.
Quote from: Arantor on November 14, 2009, 10:31:30 AM
Well, I'll build a package with these edits in, and try it myself on a fresh 2.0 RC1.2 (though it might work on 2.0 RC2 too) but I have some other stuff to do first.
Thank you Arantor, you are incredibly generous with your time and talent.
I wonder Arantor if you ever sussed the edits needed to make this work? as I realise that fully testing it and building a mod package would be work you may not have time for.
If you have any ideas I am more than willing to test them out on one of the many instances of 2.0 RC1.2 I have installed locally purely for testing purposes - and I will also install RC2 to further stress test them.
I know you're busy and maybe still under the weather, but if you do get a spare mo I will be very grateful.
I haven't actually had chance to fix this up, other stuff came up in priority.
I'll look at this one next though.
Meh, I figured out what it was - something unexpected.
There's also an edit to Display.template.php to be made.
Attached is a packaged mod (which I'm about to throw over to the mod site) which covers 2.0 RC1.2 and 2.0 RC2, for all 4 themes bundled between the two (Curve, Core, Babylon and Classic)
if ($context['can_moderate_forum'] && !empty($message['member']['ip']))
if ($context['can_moderate_forum'] && !empty($message['member']['ip']) && $message['can_see_ip'])
http://custom.simplemachines.org/mods/index.php?mod=2286 when it's approved.
Thanks Arantor. I installed it and tested the various different options and it does seem to work well in the posts but unfortunately it still displays the IPs in the "who's online" view? I have tried it a couple of times and checked the edits and it does seem to be a consistent quirk, but I'll try again to make sure.
Hope you are feeling better BTW, as if I said I felt ill last week, I positively feel like I'm on death's doorstep this week..
Argh, I forgot who's online! The edits never touch Who.php so no reason to assume it would work.
Yeah, feeling better thanks, just realised that was kind of stupid to forget that one. I will fix up the mod at the earliest opportunity.
EDIT: Fixed. One line change should be enough. Revised version attached.
I have messed around a little more and discovered that if you enable if for a membergroup with fairly basic privilages, it does not show IPs in posts or the who's online view, but it does display the IP of a member if you view their profile. This is superfluous for me as I am essentially trying to turn the IP view off and not on, but they do seem to be further quirks for you to look at to perfect the mod.
Sorry for being a pain but I am only trying to help you understand.
Man I'm ill!!! I need some of that sea breeze to clear my head.
I'm not sure I follow. You can only see it in the profile if you have view_own (for your own profile) or view_any for any profile. This is actually cutting down what moderate_forum grants.
If a member does not have that permission, they can't see it, simple as that.
I originally tested it for a site moderator membergroup that naturally had "moderate forum members" turned on, and enabling and disabling your new mod allowed the moderator to see ips (or not) in a post next to the "report to moderator" option which is normal and your mod worked fine in hiding the ip in posts (and a member's profile) but not in the "who's online" as I have mentioned.
I then enabled it on a membergroup that was akin the a regular member that of course wouldn't have the "moderate forum members" permission, but the ip could not be seen in posts or the who's online view and could only be seen if a member's profile was viewed, then the ip was displayed or not depending on whether your new permission was set. Is that what you intended?
The view IP permission is literally what it says it is. It separates the ability to view IPs away from anything else (almost)
If a user has view_ip_address_own, they can see their own IP address in all the places a moderator would be able to - profile, who's online, modlog, and thread view. Irrespective of anything else, they'd be able to see it.
If a user has view_ip_address_any, they can see anyone's IP address in all the places a moderator would be able to - profile, who's online, modlog and thread view. Doesn't matter who it is either, if they can see any IPs, that's ANY IPs, including admin.
The only time any other permission is invoked in on the thread view, whether a user has moderate_forum or not. If they have view_any + moderate_forum, the link points to the IP tracking area, otherwise it points to help on why it's been logged.
You might want to check the permissions of users because it sounds like users have more permissions than they should, or you have multiple groups crossing over.
My apologies. I quickly set it up on a fresh install and apart from the "who's online" view it does indeed work how it should. I'm not sure what happened with the previous installation I tried it with as it is using a backup DB of my main forum, so I'll have to dig around to see what may have caused that quirk as of course I ultimately need this on my main board. My DB is a year old and has been through the mill during the various upgrades - I just hope this isn't going to be a big problem for me after all your work.
Thanks
I wondered Arantor, if you ever pinpointed the edits needed in the who.php file for this to be complete? I appreciate you probably have other things to attend to and I am not pushing, but I would be grateful if you found time for this at some point.
Thanks
I did. I submitted it to http://custom.simplemachines.org/mods/index.php?mod=2286 but it's still waiting for approval.
Quote from: Arantor on November 30, 2009, 05:27:42 AM
I did. I submitted it to http://custom.simplemachines.org/mods/index.php?mod=2286 but it's still waiting for approval.
Great, thanks. I'll hold my breath a little longer then.
The edit to Who.php should be, for the record.
'ip' => allowedTo('moderate_forum') ? $row['ip'] : '',
'ip' => (allowedTo('view_ip_address_any') || ($row['member'] == $context['user']['id'] && allowedTo('view_ip_address_own'))) ? $row['ip'] : '',
That's got me all sorted out now and it works perfectly.
Much appreciated.
Good to know it's all sorted; the official mod is just waiting on approval now.
Damn! I have just discovered another problem. It seems that there is still a way for moderators to see IPs when the "moderate forum members" is on but your new mod has "View all ips" turned off - and that is from the "view all members" section in their admin. This unfortunately shows all the members' IPs in a column including the admin's?
I did double check this in that clean install so as to be sure it wasn't a conflicting setting somewhere or anything rogue from my old database, and it was the same with IPs showing in the "view all members" section.
Any thoughts?
What page, exactly, are you seeing that in?
Admin/Members/View all members.
IPs still show in the 'IP address' column.
I was hoping you were going to confirm the URL actually; easier for me to track down that way.
Not sure what to have posted then.. maybe:
*/index.php?action=admin;area=viewmembers;*
It's obviously called from the 'ManageMembers.php' and should your edits override the IP view from that? I have tried this a few times to see if it something I am doing but it seems pretty consistent.
Surely it's time I get my coat? :)
As you can see the edits never touched ManageMembers.php but knowing the URL means I was able to find where the code calls.
Unfortunately this one is a little bit nastier to figure out because the entire page is essentially setup to just call createList (which is a mighty, undocumented function)
/me tries to figure out how this one needs to be done.
Quote from: Arantor on November 30, 2009, 09:09:47 AM
/me tries to figure out how this one needs to be done.
Well I have my coat in hand but I'll sit here a while and see how it pans out then.
Is this going to be a toughie then? Would it be possible or easier just to separate out the "access to registration management" from the moderare members permission?
I actually prefer it the way you have done it by isolating the IP view entirely (well, almost), and if this latest probem could be fixed it would be absolutely ideal.
Thanks.
Well, I'm still trying to figure out how to handle the createList - it's a mammoth piece of coding and I want to get it right. What I'm thinking is, drop the IP column entirely unless you have view all IP rights, seems to be the cleanest solution.
Good luck Arantor and sorry for the headache.
No worries - about time I figured out how to work with createList anyway...
Right, I *think* this one should do it.
This one locks out the column from the view members area if you don't have view_ip_address_any, and also locks the field from being entered on the template (and even if you do enter it, e.g. through Firebug, it won't do anything, the entry is removed prior to a search being executed, so the search will ignore it entirely, if you're not privileged)
I think I'll re-list it on the mod site with this entry :)
Wow, thanks Arantor. I'll install it fortwith although I did install the other one in my main board that I may have to uninstall manually.
I'm positive we're good to go now so thanks for all you help and effort.
Let me know if it doesn't work out - I did submit this one as a mod to the mod site last night, so it can be publicly visible there too once it's approved.
I got kinda bad news..
The link works fine and to I wasn't sure if you had modified any of the previous code so I installed a new forum from scratch and set this up. Unfortunately, when a global mod clicks on his "members" section in his admin, I get this error:
QuoteTemplate Parse Error!
It seems something has gone sour on the forum with the template system. This problem should only be temporary, so please come back later and try again. If you continue to see this message, please contact the administrator.
I had "moderate members" permission on and "view all ips" off in that dummy profile, so I tried it with the "view all ips" on and I got the same error? Does this not replicate for you? I am using v2 RC1.2 in case you set it up for RC2 and that is my issue.
Damn! You really should tell me to get my coat now Arantor.
*headdesk*
I fixed this last night - I just forgot to update the .zip file before uploading.
Themes/default/ManageMembers.template.php
', allowedTo('view_ip_address_any']) ? '' : ' disabled="disabled"', '
', allowedTo('view_ip_address_any') ? '' : ' disabled="disabled"', '
You see, now my bad practices are rubbing off on you..
Just one thing, did you alter any of the other code from original mod? As if you didn't I should be able to force this through rather than backward modifying the files that the original mod altered.
Thanks
I don't think I did; each new edit was done to the end of the install file, meaning that after I added the Who.php edits (for who's online), I did three edits to ManageMembers.php and one to ManageMembers.template.php.
Just tried it on another new install and it works perfectly with the "view ip" permission hiding and bringing back the IP column in the "view members" panel.
Fantastic job Arantor and this really does separate out the IP permission which has to be very useful in many circumstances.
I owe you a beer or 3.
I'm just glad it all works as it's supposed to - I don't drink any more, but thanks anyway :)
For anyone else: it's also listed on the mod site, pending approval from SMF Customization Team (using the fixed version!) under http://custom.simplemachines.org/mods/index.php?mod=2286
Any chance this could be updated for SMF 2.0 please?
Thank you.
please post in the mods support thread if you wish to get it updated
I don't believe this was ever a released mod was it? I thought Arantor had just knocked it up specifically.
unless you are not talking about the mod linked in the last post by arantor, and i dont think he is around anymore to help you or anyone else with this.
Oh, I see, I just read his posts (sniff).
I'll have a go myself then but if you hear a loud bang, you'll know I've got it wrong.