Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: live627 on December 20, 2009, 10:49:47 AM

Title: Join Reason
Post by: live627 on December 20, 2009, 10:49:47 AM
[Link to the mod](https://custom.simplemachines.org/index.php?mod=2326)

# Join Reason
[![Support](http://img.shields.io/badge/PayPal-$-009966.svg)](https://www.paypal.me/JohnRayes)

Package name | SMF version | Minimmum PHP version
--- | --- | ---
Join Reason 3.0.0 | SMF 2.1.x | PHP 7.1
Join Reason 1.3 | SMF 2.0.x | PHP 5.3

[View changelog](https://github.com/live627/smf-mods/blob/main/join-reason/CHANGELOG.md)

This mod adds a field on the registration page asking the visitor how he found the site. In addition, if all registrants must be approved by the site administrator, a section is added to the list of members awaiting approval with their join reason.

[Original Mod Request](https://www.simplemachines.org/community/index.php?topic=353831.0)
Title: Re: Join Reason
Post by: Costa on December 20, 2009, 10:53:49 AM
Cool, congrats  :D


TRANSLATIONS

Code (portuguese_pt) Select
$txt['admin_browse_join_reason'] = 'Motivo para se juntar a nós';
$txt['join_reason'] = 'Como nos encontrou?';


Code (portuguese_pt-utf8) Select
$txt['admin_browse_join_reason'] = 'Motivo para se juntar a nós';
$txt['join_reason'] = 'Como nos encontrou?';


Code (portuguese_brazilian) Select
$txt['admin_browse_join_reason'] = 'Motivo para se juntar a nós';
$txt['join_reason'] = 'Como nos encontrou?';


Code (portuguese_brazilian-utf8) Select
$txt['admin_browse_join_reason'] = 'Motivo para se juntar a nós';
$txt['join_reason'] = 'Como nos encontrou?';
Title: Re: Join Reason
Post by: darrenbeige on December 20, 2009, 11:21:00 AM
Like it. 
Code (spanish) Select
$txt['admin_browse_join_reason'] = 'Razón para unirse';
$txt['join_reason'] = '¿Cómo encontrarnos?';

Title: Re: Join Reason
Post by: Gargoyle on December 20, 2009, 03:38:14 PM
Very nice! Thank you!
Title: Re: Join Reason
Post by: live627 on December 21, 2009, 05:20:05 PM
Updated to 1.1

Title: Re: Join Reason
Post by: Rohan_ on December 22, 2009, 12:36:27 AM
Danish
$txt['admin_browse_join_reason'] = 'Begrundelse for at tilslutte sig';
$txt['join_reason'] = 'Hvordan fandt du os?';


Dutch
$txt['admin_browse_join_reason'] = 'Reden voor deelname aan';
$txt['join_reason'] = 'Hoe heeft u ons gevonden?';


Filipino
$txt['admin_browse_join_reason'] = 'Ang Dahilan para sumali sa';
$txt['join_reason'] = 'Paano ninyo makita sa amin?';


French
$txt['admin_browse_join_reason'] = 'Raison de se joindre à';
$txt['join_reason'] = 'Comment nous avez-vous trouver?';


German
$txt['admin_browse_join_reason'] = 'Grund für den Beitritt';
$txt['join_reason'] = 'Wie haben Sie uns gefunden?';


Russian
$txt['admin_browse_join_reason'] = 'Причина присоединения';
$txt['join_reason'] = 'Как вы узнали о нас?';



if there is some mistake then i am sorry
Title: Re: Join Reason
Post by: -=[Vyorel]=- on December 22, 2009, 02:36:13 AM
Romanian:
$txt['admin_browse_join_reason'] = 'Motivul pentru aderare';
$txt['join_reason'] = 'Cum ne-ati gasit?';
Title: Re: Join Reason
Post by: 4b11l on December 22, 2009, 06:02:53 PM
New registrants can not register.

Getting an error in:

Database Error: Unknown column 'join_reason' in 'field list'
Apply Filter: Only show the errors from this file
File: /public_html/Sources/Subs-Members.php
Line: 785
Title: Re: Join Reason
Post by: live627 on December 22, 2009, 06:30:14 PM
SMF version?
Title: Re: Join Reason
Post by: Arantor on December 22, 2009, 06:34:39 PM
Also of interest: how was it installed?
Title: Re: Join Reason
Post by: live627 on December 22, 2009, 06:53:06 PM
The database problem is fixed in version 1.2
Title: Re: Join Reason
Post by: Gargoyle on December 22, 2009, 07:52:07 PM
What about those of us that have not encountered this issue... Is it necessary for us to apply the "database fix" ?
Title: Re: Join Reason
Post by: live627 on December 22, 2009, 10:58:45 PM
Nope. SMF 1.1.x users are not affected at all.
Title: Re: Join Reason
Post by: SoLoGHoST on December 23, 2009, 03:29:32 AM
Congrats on your modification Live.  The problem is that it never creates the column for RC2 since db_extend('packages') never gets called.  Change if (!array_key_exists('db_add_column', $smcFunc)) within the install20.php file to exclude the !.

You also, need to fix the name of the column from join_reaason, to join_reason with 1 a.

Cheers, and that should do it.
Title: Re: Join Reason
Post by: Arantor on December 23, 2009, 03:31:49 AM
*cough* use <database> *cough*
Title: Re: Join Reason
Post by: 4b11l on December 23, 2009, 06:38:27 AM
Version was rc2.0

I recently uninstalled it already. Should I download and reinstall the new package since you said it's upgraded in 1.2?
I am not familiar with modifying the database and would rather not have to do that if I didn't need to.
Title: Re: Join Reason
Post by: mirahalo on December 24, 2009, 05:01:55 PM
Hi there,   will you please update the spanish translation ;)

spanish_es
$txt['admin_browse_join_reason'] = 'Raz&oacute;n para unirse';
$txt['join_reason'] = '&iquest;C&oacute;mo nos encontraste?';


spanish_latin
$txt['admin_browse_join_reason'] = 'Raz&oacute;n para unirse';
$txt['join_reason'] = '&iquest;C&oacute;mo nos encontraste?';


spanish_es-utf8
$txt['admin_browse_join_reason'] = 'Razón para unirse';
$txt['join_reason'] = '¿Cómo nos encontraste?';


spanish_latin-utf8
$txt['admin_browse_join_reason'] = 'Razón para unirse';
$txt['join_reason'] = '¿Cómo nos encontraste?';



nice mod  btw ;)
Title: Re: Join Reason
Post by: live627 on December 24, 2009, 08:46:21 PM
Quote from: Rohan_ on December 22, 2009, 12:36:27 AM
if there is some mistake then i am sorry


Mistake? Only if there is a translation error on your part, but otherwise, everything is okay

Quote from: The Grinch on December 23, 2009, 03:31:49 AM
*cough* use <database> *cough*

*choke* Database adaption blues...

Quote from: 130860 on December 24, 2009, 05:01:55 PM
Hi there,   will you please update the spanish translation ;)

spanish_es
$txt['admin_browse_join_reason'] = 'Raz&oacute;n para unirse';
$txt['join_reason'] = '&iquest;C&oacute;mo nos encontraste?';


spanish_latin
$txt['admin_browse_join_reason'] = 'Raz&oacute;n para unirse';
$txt['join_reason'] = '&iquest;C&oacute;mo nos encontraste?';


spanish_es-utf8
$txt['admin_browse_join_reason'] = 'Razón para unirse';
$txt['join_reason'] = '¿Cómo nos encontraste?';


spanish_latin-utf8
$txt['admin_browse_join_reason'] = 'Razón para unirse';
$txt['join_reason'] = '¿Cómo nos encontraste?';



nice mod  btw ;)


Is UTF8 and ASCII backwards?
Title: Re: Join Reason
Post by: mirahalo on December 25, 2009, 03:08:42 PM
nope,  well yeah, but thats  the way to go in this, otherwise you will have weird characters.

   ASCII = &aacute;

UTF8 =  á   

I could be wrong,  but  this how SMF do this AFAIK  ;)
   
Title: Re: Join Reason
Post by: Arantor on December 25, 2009, 03:57:47 PM
I have a feeling the non-UTF8 file is encoded in a different scheme to ISO-8859-1 but I'd have to check. If in doubt, what 130860 does is what I do in my mods and it works just fine for me.
Title: Re: Join Reason
Post by: Costa on December 25, 2009, 03:59:31 PM
130860, this (http://www.infodz.com.br/pessoal/costa/utf8.html) is UTF-8. :)
Title: Re: Join Reason
Post by: mirahalo on December 25, 2009, 04:08:05 PM
oh, thanks
Title: Re: Join Reason
Post by: Costa on December 25, 2009, 05:11:40 PM
You're welcome ;)
Title: Re: Join Reason
Post by: Rumboogy on December 29, 2009, 09:09:01 AM
It says this is a mandatory field, but I am seeing people able to register without putting anything in the field. Is that the way it is supposed to work?

Thanks...other than that...great little mod.
Title: Re: Join Reason
Post by: live627 on December 29, 2009, 03:18:32 PM
The field is not mandatory. Can you tell me where I said it's required so I can change it?
Title: Re: Join Reason
Post by: Rumboogy on December 29, 2009, 03:44:29 PM
On the REGISTRATION PAGE, the upper block is for REQUIRED INFORMATION...and I thought that meant it is mandatory...it must not be mandatory...wished it were though.

Hope that clears it up.

Thanks,

Wally
Title: Re: Join Reason
Post by: DoctorMalboro on December 29, 2009, 05:19:24 PM
Quote from: darrenbeige on December 20, 2009, 11:21:00 AMLike it. 
Code (spanish) Select
$txt['admin_browse_join_reason'] = 'Razón para unirse';
$txt['join_reason'] = '¿Cómo encontrarnos?';
wrong
$txt['join_reason'] = '¿Cómo encontrarnos?';
right
$txt['join_reason'] = '¿C&oacute;mo nos encontro&oacute;?';

excellent MOD!!! ;)
Title: Re: Join Reason
Post by: Arantor on December 29, 2009, 05:22:00 PM
Actually... you can encode the raw character if you do it correctly.

If, for example, you encode it correctly into ISO-8859-1 you can put it as-is in the spanish_es files, and if you encode correctly into UTF-8 you can encode it as is to the -utf8 files.

If in doubt, use the multibyte safe entity versions which work wherever.
Title: Re: Join Reason
Post by: Rumboogy on December 30, 2009, 09:50:19 AM
Is there a way to make this a MANDATORY field?

Thanks,

Wally
Title: Re: Join Reason
Post by: live627 on December 30, 2009, 04:49:49 PM
In $sourcedir/Registation.php

Code (Find) Select

// You can't register if it's disabled.
if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 3)
fatal_lang_error('registration_disabled', false);


Code (Add After) Select

// You can't register if it's disabled.
if (empty($_POST['join_reason']))
fatal_error('Please let us know how you found us.', false);
Title: Re: Join Reason
Post by: SoLoGHoST on December 30, 2009, 05:07:23 PM
Just my 2 cents...
would be better to say:
   // You can't register if it's disabled.
   if (trim($_POST['join_reason']) == '')
      fatal_error('Please let us know how you found us.', false);


Since the string value of "0" translates to empty also.  Though I suppose it's not really a big deal.  Just a thought I had that maybe perhaps the Admin might want to allow all types of text input.

Very useful mod live :)
Title: Re: Join Reason
Post by: Gargoyle on January 02, 2010, 12:14:20 PM
Hello again....

I have added the above modification to make the field "required" but now I receive "undefined index" in my error logs when the field is left blank. Any idea where I should add some code to remedy this error ?

Thanks!!
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 12:33:25 PM
What, exactly, do you get for the undefined index error - more details will help :)
Title: Re: Join Reason
Post by: Gargoyle on January 02, 2010, 12:47:42 PM
Quote from: Arantor on January 02, 2010, 12:33:25 PM
What, exactly, do you get for the undefined index error - more details will help :)

8: Undefined index: join_reason
File: /Sources/Register.php
Line: 163

Sorry.... LOL!
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 12:49:31 PM
   // You can't register if it's disabled.
   if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
      fatal_error('Please let us know how you found us.', false);
Title: Re: Join Reason
Post by: Gargoyle on January 02, 2010, 01:10:37 PM
Nice I will try it.. Thanks!
Title: Re: Join Reason
Post by: SoLoGHoST on January 02, 2010, 01:12:45 PM
No no, here ya go:

   // You can't register if it's disabled.
   if ((isset($_POST['join_reason']) && trim($_POST['join_reason']) == '') || !isset($_POST['join_reason']))
      fatal_error('Please let us know how you found us.', false);


Like I said before, don't use empty.  You should use isset and !isset instead.

Cheers :)
Title: Re: Join Reason
Post by: Gargoyle on January 02, 2010, 01:14:58 PM
Seems to have worked when I tested it... I should know for sure during the next few days as the spam bots love my site.. LOL
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 01:15:58 PM
Huh, SoLoGHoST?

You do know that PHP doesn't evaluate the right half of a condition if it doesn't have to, right? The code I posted will do the same thing but with less work...

Mine checked for being empty (i.e. being not defined, or empty, or space, or 0) or if that wasn't the case, it checks for trimmed version being empty. Does exactly the same with less work.
Title: Re: Join Reason
Post by: SoLoGHoST on January 02, 2010, 01:17:12 PM
Quote from: Gargoyle on January 02, 2010, 01:14:58 PM
Seems to have worked when I tested it... I should know for sure during the next few days as the spam bots love my site.. LOL

The problem with Arantor's code, as I have already pointed out.  If a user types in 0 it will give an error message, since 0 = empty.
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 01:17:33 PM
So 0 is a logical join reason?
Title: Re: Join Reason
Post by: SoLoGHoST on January 02, 2010, 01:18:54 PM
Well, it could be....  I just want to be politically correct here.  No offense bro.
Title: Re: Join Reason
Post by: Gargoyle on January 02, 2010, 01:21:09 PM
Well since it is join reason 0 really isn't a reason so that's going to be okay with me... ;D

Thanks for the insight though.. ;D
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 01:23:42 PM
*shrug* I'm all for keeping it simple in code, and I didn't figure that '0' would be a logical join reason hence using empty(), but end of the day it's whatever works.
Title: Re: Join Reason
Post by: SoLoGHoST on January 02, 2010, 01:30:12 PM
It's definitely better to use empty when you aren't dealing with string values, atleast this is my opinion.  Since, when you use string values, the value can be anything at all.  So I am actually training myself to use isset for this.  But, to each their own.  If 0 is not a possible join reason, than using empty should be fine.  I just like error-proofing my code so it works for every possible scenario.

Cheers :)
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 01:33:40 PM
True enough.

Though I'd argue that you're after a reason for joining which would typically be text rather than just simply 0. isset and empty both have their place, my humble opinion is that empty is preferable here given context, but there are plenty of other places empty is not appropriate.
Title: Re: Join Reason
Post by: SoLoGHoST on January 02, 2010, 02:14:31 PM
Well, let's take for instance a forum wants to know the join reason based on a number.  This could be based on anything, a score you had in an online game, or anything really.  So if the Admin wants a join reason based on a number, and the number is zero, the user won't be able to join the forum.

Ofcouse, this is taken out of context, but still something to consider when coding.  Please don't get me wrong, I understand that empty is perfectly fine for this, but there is still that case of 0 being a possible string value, or even a bunch of zero's.  For example:  000000000 also = empty.

Well, it's all good, and please don't take this the wrong way ofcourse.

Cheers :)
Title: Re: Join Reason
Post by: Arantor on January 02, 2010, 02:21:06 PM
In which case you'd probably also modify the description to make it clear that that's the case. Mod out of the box seems to want a general textbox for why someone joined up, implying a reason.

Yes, of course there are going to be oddities, but the general use case would imply that 0 on its own would be unsuitable. Oh, and 000000000 is not considered empty, I think you'll find.
Title: Re: Join Reason
Post by: SoLoGHoST on January 02, 2010, 02:26:12 PM
Ohh, ok, have tested this a while back and was empty, musta been a mistake on my part.  Sorry bout that and thanks for clearing that up.  Will have to give it another go than.
Title: Re: Join Reason
Post by: live627 on January 02, 2010, 05:01:36 PM
Quote from: Arantor on January 02, 2010, 01:23:42 PM
*shrug* I'm all for keeping it simple in code

Hence the name SIMPLE Machines :D

I think empty() is the perfect choice ;)
Title: Re: Join Reason
Post by: Gargoyle on January 03, 2010, 10:44:43 AM
Just reporting back on the code Arantor gave me... No more errors in my logs!

Thanks again!
Title: Re: Join Reason
Post by: lovearat on January 14, 2010, 08:39:09 AM
Quote from: live627 on December 20, 2009, 10:49:47 AM
This mod adds a field on the registration page asking the visitor how he found the site. In addition, if all registrants must be approved by the site administrator, a section is added to the list of members awaiting approval with their join reason.

All registrants are required to be approved before joining my forum. To me asking the visitor how they found the forum amd asking for a join reason are two different questions. And , while it would be nice to know how they found the forum, i.e. searched for, word of mouth, etc. All I really want to know is why they wish to join my forum. Is there a way to make it ask  for a join reason in both areas? Thanks  :)
Title: Re: Join Reason
Post by: dimdom on January 14, 2010, 06:51:38 PM
Sorry but I maybe miss something with this mod...

From where can the admin read the reasons for joining?

Or they only appear if they members need approval?

Title: Re: Join Reason
Post by: live627 on January 15, 2010, 04:21:23 PM
Quote from: dimdom on January 14, 2010, 06:51:38 PM
they only appear if they members need approval
Title: Re: Join Reason
Post by: TheListener on January 18, 2010, 11:37:02 PM
Quote from: live627 on January 15, 2010, 04:21:23 PM
Quote from: dimdom on January 14, 2010, 06:51:38 PM
they only appear if they members need approval

As members do not require approval to register on my forum I have decided to let this mod go.

Would of made for interesting stats otherwise.
Title: Re: Join Reason
Post by: lovearat on January 19, 2010, 01:54:48 PM
Quote from: lovearat on January 14, 2010, 08:39:09 AM
Quote from: live627 on December 20, 2009, 10:49:47 AM
This mod adds a field on the registration page asking the visitor how he found the site. In addition, if all registrants must be approved by the site administrator, a section is added to the list of members awaiting approval with their join reason.

All registrants are required to be approved before joining my forum. To me asking the visitor how they found the forum amd asking for a join reason are two different questions. And , while it would be nice to know how they found the forum, i.e. searched for, word of mouth, etc. All I really want to know is why they wish to join my forum. Is there a way to make it ask  for a join reason in both areas? Thanks  :)

Could someone please help me out with this? Thanks  :)
Title: Re: Join Reason
Post by: live627 on January 19, 2010, 11:44:09 PM
Quote from: Brack1 on January 18, 2010, 11:37:02 PM
Quote from: live627 on January 15, 2010, 04:21:23 PM
Quote from: dimdom on January 14, 2010, 06:51:38 PM
they only appear if they members need approval

As members do not require approval to register on my forum I have decided to let this mod go.

Would of made for interesting stats otherwise.

If you have SMF 2, you can create a custom profile field
Title: Re: Join Reason
Post by: TheListener on January 20, 2010, 12:40:04 AM
Quote from: live627 on January 19, 2010, 11:44:09 PM
Quote from: Brack1 on January 18, 2010, 11:37:02 PM
Quote from: live627 on January 15, 2010, 04:21:23 PM
Quote from: dimdom on January 14, 2010, 06:51:38 PM
they only appear if they members need approval

As members do not require approval to register on my forum I have decided to let this mod go.

Would of made for interesting stats otherwise.

If you have SMF 2, you can create a custom profile field

Point noted with thanks.
Title: Re: Join Reason
Post by: Gargoyle on January 20, 2010, 09:26:09 PM
Quote from: lovearat on January 19, 2010, 01:54:48 PM
Quote from: lovearat on January 14, 2010, 08:39:09 AM
Quote from: live627 on December 20, 2009, 10:49:47 AM
This mod adds a field on the registration page asking the visitor how he found the site. In addition, if all registrants must be approved by the site administrator, a section is added to the list of members awaiting approval with their join reason.

All registrants are required to be approved before joining my forum. To me asking the visitor how they found the forum amd asking for a join reason are two different questions. And , while it would be nice to know how they found the forum, i.e. searched for, word of mouth, etc. All I really want to know is why they wish to join my forum. Is there a way to make it ask  for a join reason in both areas? Thanks  :)

Could someone please help me out with this? Thanks  :)

What "both" areas?? This is for registration.. Where else do you register?
Title: Re: Join Reason
Post by: live627 on January 20, 2010, 10:08:55 PM
*cough* Custom Profiles
Title: Re: Join Reason
Post by: lovearat on January 21, 2010, 04:09:24 AM
Quote from: Gargoyle on January 20, 2010, 09:26:09 PM
Quote from: lovearat on January 19, 2010, 01:54:48 PM
Quote from: lovearat on January 14, 2010, 08:39:09 AM
Quote from: live627 on December 20, 2009, 10:49:47 AM
This mod adds a field on the registration page asking the visitor how he found the site. In addition, if all registrants must be approved by the site administrator, a section is added to the list of members awaiting approval with their join reason.

All registrants are required to be approved before joining my forum. To me asking the visitor how they found the forum amd asking for a join reason are two different questions. And , while it would be nice to know how they found the forum, i.e. searched for, word of mouth, etc. All I really want to know is why they wish to join my forum. Is there a way to make it ask  for a join reason in both areas? Thanks  :)

Could someone please help me out with this? Thanks  :)

What "both" areas?? This is for registration.. Where else do you register?

I'm sorry, I didn't explain what I meant very well.  :)  What I meant is, on the registation page, it only ask the registraint how they found the forum.  It does not ask them what their reason for joining is.  Then the page that lists "awaiting approval" it  shows their answer to "how did you find the forum?' as their answer to " why do you want to join this forum?"  I'm wanting to know why they want to join,ie, because they want to share pictures of their rat terrier,etc. I am using SMF 1.1.11
Title: Re: Join Reason
Post by: live627 on January 21, 2010, 09:20:56 AM
If you want to change the text from How did you find us to Why do you want to join, the language file is easily editable.

   <file name="$languagedir/index.english.php" error="skip">
      <operation>
         <search position="end" />
         <add><![CDATA[
$txt['join_reason'] = 'How did you find us?';]]></add>
      </operation>
   </file>
Title: Re: Join Reason
Post by: lovearat on January 21, 2010, 11:35:49 AM
Quote from: live627 on January 21, 2010, 09:20:56 AM
If you want to change the text from How did you find us to Why do you want to join, the language file is easily editable.

   <file name="$languagedir/index.english.php" error="skip">
      <operation>
         <search position="end" />
         <add><![CDATA[
$txt['join_reason'] = 'How did you find us?';]]></add>
      </operation>
   </file>

Thank you!  :)
Title: Re: Join Reason
Post by: Chas Large on January 29, 2010, 03:58:00 AM
Hi. I had Version 1.2 installed on my site until today. It was proving very useful BUT I had to manually register a member and then this error occurred:

"The database value you're trying to insert does not exist: join_reason Function: registerMember"

This was also recorded in the error log along with:

"8: Undefined index: join_reason
File: /xxxxxx/xxxxxx/f/fiftyplusforum.co.uk/user/xxxxxx/forum/Sources/Subs-Members.php
Line: 725"

I tried several times with refreshes etc but could not manually register the member.

I uninstalled the mod and was then able to manually register a new member. I also have the Language pack for this mod installed.

Is this fixable? I really like this mod and would hate to loose it.


Secondly, I have seen the following error in my log quite a lot for Guests:

"http://www.fiftyplusforum.co.uk/forum/index.php?action=register2
8: Undefined index: join_reason
Apply Filter: Only show the errors from this file
File: /xxxxx/xxxxxxx/f/fiftyplusforum.co.uk/user/xxxxxx/forum/Sources/Register.php
Line: 369 "

Most of the IP addresses point to non UK locations so I'm assuming they're spammer trying to register but an explanation would be nice if possible.

Regards

CHas
Title: Re: Join Reason
Post by: live627 on January 30, 2010, 03:27:53 PM
Version 1.2.1 addresses the first issue. Both branches are affected, and since admins are unable to rgister a member, this version is highly recommended.

For the second issue, try this:

In $sourcedir/Registation.php

Code (Find) Select

// You can't register if it's disabled.
if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 3)
fatal_lang_error('registration_disabled', false);


Code (Add After) Select

   // You can't register without a reason...
   if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
      fatal_error('Please let us know how you found us.', false);
Title: Re: Join Reason
Post by: Chas Large on January 31, 2010, 07:29:07 AM
Quote from: live627 on January 30, 2010, 03:27:53 PM
Version 1.2.1 addresses the first issue. Both branches are affected, and since admins are unable to rgister a member, this version is highly recommended.

For the second issue, try this:

In $sourcedir/Registation.php

Code (Find) Select

// You can't register if it's disabled.
if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 3)
fatal_lang_error('registration_disabled', false);


Code (Add After) Select

   // You can't register without a reason...
   if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
      fatal_error('Please let us know how you found us.', false);

Thanks Live.
As I had already uninstalled 1.2, I went to install 1.2.1 but found that in my packages that it showed 1.2 was still installed. Trying to uninstall showed an error on every file, so I just deleted the files in the packages list, then installed 1.2.1 manually as attempting to install via the packages failed with errors. Manual install worked OK. There was no evidence that 1.2 had ever been there though.

However, I am now getting this error message:

The email template "admin_register_activate" could not be found.

When attempting to manually register a new member via the Admin > Members > Registration > Register New Member option, so either something else is wrong with my forum or 1.2.1 did not fix the problem.


[EDITED] - The problem was with the EMailTemplates.english_british.php file, the template text was missing. Copying it over from the EMailTemplates.english.php file cured the problem, so all is well now.

For translation purposes, I copied the text for ManageMembers.english.php and index.english.php into the ManageMember.english_british.php and index.english_british.php files respectively and that allowed using the English British Language option. I don't use the UTF-8 format. Hope this helps.

I also added the second lot of code in the register.php file to fix the second error.
[EDIT2]
This did cure the issue with the error messages appearing in the Log File.
Title: Problem with Join Reason 1.2.1
Post by: EL34xyz on February 02, 2010, 09:47:10 AM
Howdy,
SMF forum is 1.1.11
I did have join reason 1.2 installed and it worked fine regarding the issue listed below.
I uninstalled 1.2 and installed 1.2.1 this morning

I get this error in the log after a member registers.
Quote8: Undefined index: join_reason
File: D:\hshome\xxxxxx\xxx.com\Forum\Sources\ManageMembers.php
Line: 688

When I go to the admin manage members page to review the member, the join reason does not display.
I looked at the database for this member.
The join reason text is present in the members record at the tail end of the database record

The only mod I made to your install files was that I changed the text to this
$txt['join_reason'] = 'Reason for joining this forum';]]>
I changed the text in all four spots in the english.xml file before installing the mod

Thanks for any help on this.
Title: Re: Join Reason
Post by: live627 on February 02, 2010, 01:07:01 PM
Quote from: live627 on January 30, 2010, 03:27:53 PM
In $sourcedir/Registation.php

Code (Find) Select

// You can't register if it's disabled.
if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 3)
fatal_lang_error('registration_disabled', false);


Code (Add After) Select

   // You can't register without a reason...
   if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
      fatal_error('Please let us know how you found us.', false);

Title: Re: Join Reason
Post by: EL34xyz on February 02, 2010, 02:01:04 PM
Hi, yes I saw that in the post above.
I did that and still had the issue.

I believe your mod and another mad may have clashed
What I had to do was uninstall the 3 other mods I had.
Then upload stock copies of the 1.1.11 SMF files.

Then I applied your mod and it worked just fine.

I am now going to apply the others mods one at a time and see if all goes well.

EDIT: I installed the two other mods and this time everything played nice together.
I did not have to add the code section you posted and it works fine now.
Thanks, I like this mod
Title: Re: Join Reason
Post by: EL34xyz on February 03, 2010, 07:20:03 AM
Hey Live627,
Got a probelm with Join_reason again.
The spammers and hackers seem to be able to bypass the mod.

I had two known spammers awaiting membership this morning.
Both had blank join reasons.
I looked at the database records for these two and they were blank.

The registration Button does not become active until you type a reason, but these guys have a way around that?
Here's s screen shot showing the two spammers
Title: Re: Join Reason
Post by: Rafferty on February 03, 2010, 07:44:20 AM
Running Forum 1.1.11 with TP

I Just uninstalled ver 1.2 and on installing 1.2.1 receiving the following:

QuoteDatabase Error
Duplicate column name 'join_reason'
File: /home/www/*****.com/forum/Packages/temp/install11.php
Line: 17
Title: Re: Join Reason
Post by: live627 on February 03, 2010, 05:10:24 PM
Quote from: EL34xyz on February 03, 2010, 07:20:03 AM
Hey Live627,
Got a probelm with Join_reason again.
The spammers and hackers seem to be able to bypass the mod.

I had two known spammers awaiting membership this morning.
Both had blank join reasons.
I looked at the database records for these two and they were blank.

The registration Button does not become active until you type a reason, but these guys have a way around that?
Here's s screen shot showing the two spammers

I think the code above fixes that problem.

Quote from: live627 on January 30, 2010, 03:27:53 PM
In $sourcedir/Registation.php

Code (Find) Select

// You can't register if it's disabled.
if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 3)
fatal_lang_error('registration_disabled', false);


Code (Add After) Select

   // You can't register without a reason...
   if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
      fatal_error('Please let us know how you found us.', false);

Title: Re: Join Reason
Post by: EL34xyz on February 03, 2010, 05:28:53 PM
Thanks Live, I added the code to Register.php and I will let you know if that does the trick.

BTW, it's Register.php, not Registration.php, just in case someone gets confused.
Title: Re: Join Reason
Post by: live627 on February 03, 2010, 05:52:16 PM
Quote from: Rafferty on February 03, 2010, 07:44:20 AM
Running Forum 1.1.11 with TP

I Just uninstalled ver 1.2 and on installing 1.2.1 receiving the following:

QuoteDatabase Error
Duplicate column name 'join_reason'
File: /home/www/*****.com/forum/Packages/temp/install11.php
Line: 17

The code for finding the database column does not work correctly unless it is at the end of the table. Version 1.2.2 fixes that.

Also, 1.2.2 makes the field required

Title: Re: Join Reason
Post by: b0dyr0ck2006 on February 07, 2010, 05:55:52 PM
This would be even better if we could see a list of members and the answer to how they found the site without having to approve each new member. I wish to allow the members to sign up automatically, but also see how they found us.


Is this easy to implement into the code?


Thanks for a good mod though.
Title: Re: Join Reason
Post by: Chas Large on February 08, 2010, 06:30:53 AM
Quote from: b0dyr0ck2006 on February 07, 2010, 05:55:52 PM
This would be even better if we could see a list of members and the answer to how they found the site without having to approve each new member. I wish to allow the members to sign up automatically, but also see how they found us.


Is this easy to implement into the code?


Thanks for a good mod though.
I've built a mod to add the Join Reason column to the Admin Members list. This mod is only for SMF 2.0 RC-2 as that's what I use. It has been submitted to SMF but as yet is unapproved. I have tested it on TWO forums and it works with no problems. Please use at your own risk.
Chas
Title: Re: Join Reason
Post by: Arantor on February 08, 2010, 07:18:15 AM
Just as a heads-up mods that depend on other mods were not allowed when I was in the Cust. team, though it was something that was being discussed with a view to changing policy.
Title: Re: Join Reason
Post by: EL34xyz on February 08, 2010, 07:34:47 AM
I noticed that some mods interfere with other mods when uninstalling

Say one mod looks for this - (xxx)
Then it installs this -  (xxx, yyy)

Another mod looks for this - (xxx)
Then it tries to install this - (www, xxx)
Mod #2 cannot find (xxx) because it has been changed to (www, xxx)

Or mod #2 only looks for this - xxx,)
It finds that and changes it to this - www, xxx)
Now mod#1 will not uninstall because it cannot find (xxx)

One mod has changes the line of code so that another mod cannot find that line.
Sometimes a line has been changed by another mod and then mod #1 above can no longer find the code it installed.
Mod#1 will no longer uninstall unless you go in and do it by hand manually.

I ran into this with a mod recently
Title: Re: Join Reason
Post by: Arantor on February 08, 2010, 07:46:08 AM
Yup, that's an unfortunate side effect of the package manager - there is no way around it.
Title: Re: Join Reason
Post by: Chas Large on February 08, 2010, 07:52:00 AM
Quote from: EL34xyz on February 08, 2010, 07:34:47 AM
I noticed that some mods interfere with other mods when uninstalling
...

This is true and I think it is a global problem. There are lots of mods that work out of the box but if someone else's mod is installed it can interfere. SMF do a great job checking all the submitted mods but I think it's for individual functionality and possible damage to original SMF code not that it will interfere with another mod. The combinations are too many to consider.

My mod relies on the Join Reason mod as it takes it's data from that mod's input. If the join reason mod is not installed my mod will just give an empty column and an unreferenced title. I tested that. I didn't change anything that the join reason mod changed.

I'm happy if the originator of the Join Reason mod takes my code and adds it in to his but I produced it as I wanted it on my site and saw the need was requested here too.
Title: Re: Join Reason
Post by: EL34xyz on February 08, 2010, 08:51:37 AM
I think the mod I ran into that affected Join reason was a mod that adds the member join date column to the admin members screen.

Every time I went to find a recent member, there was no way to sort the admin list by join date.

The regular member listing had the join date, but not the admin member list.
Title: Re: Join Reason
Post by: Chas Large on February 08, 2010, 12:49:33 PM
As Arantor rightly suspected, my mod has not been approved because it relies on another mod to be installed. So if Live627 would like to add it too his mod then please make use of the code. I'll leave it here for anyone who wants to use it. It works for me.
Title: Re: Join Reason
Post by: Arantor on February 08, 2010, 03:06:54 PM
Chas: Did they actually tell you this? Note that until you hear by PM, it's just sat in a queue (of which last I heard the queue was quite long)
Title: Re: Join Reason
Post by: Chas Large on February 08, 2010, 03:37:29 PM
Quote from: Arantor on February 08, 2010, 03:06:54 PM
Chas: Did they actually tell you this? Note that until you hear by PM, it's just sat in a queue (of which last I heard the queue was quite long)
Yes, they sent me a PM.
Quote from: SMF customization TeamWe do not allow modifications that require another modification to be installed in order to function.  If you would like to see this feature in this modification, please contact the mod author and request addition of such feature.
I guess this is a pretty standard message so quoting a PM is OK IMO.
Chas
Title: Re: Join Reason
Post by: Arantor on February 08, 2010, 03:39:52 PM
Yeah, that's a standard PM, so yeah, I don't think there's a problem with quoting it.

Good to see they're on top of things though :)
Title: Re: Join Reason
Post by: nfries88 on February 23, 2010, 12:13:47 PM
SMF 2.0 RC 2:
If you enable registration with OpenID for verification, this causes the "Reason for joining" field to dissappear, which also makes it impossible to register.

Not a serious issue for the most part, but annoying.

Suggested fix is to move the modified part of the text down to below where the OpenID field is specified. Maybe under the "Additional Information" header?
Title: Re: Join Reason
Post by: MarcFirewing on March 23, 2010, 04:27:54 AM
Hope no one minds me replying to this with a question...

SMF 1.1.11

I was wondering if there was anyway to let the admins choose a membergroup based on their reply that will just show a dropdown button and just let it do it from there instead of having to do it manually. (I've never used the member approval form so if it does, please correct me.)
Title: Re: Join Reason
Post by: jdvarner on April 03, 2010, 12:21:59 AM
have this installed on 1.1.11

where exactly does the admin go to view the join reason field that the new member has inputed? is it in their profile? or somewhere else?
Title: Re: Join Reason
Post by: dimdom on April 27, 2010, 10:24:13 AM
Quote from: jdvarner on April 03, 2010, 12:21:59 AM
have this installed on 1.1.11

where exactly does the admin go to view the join reason field that the new member has inputed? is it in their profile? or somewhere else?

Same question here...
Title: Re: Join Reason
Post by: Arantor on April 27, 2010, 10:27:06 AM
Quote from: live627 on December 20, 2009, 10:49:47 AM
This mod adds a field on the registration page asking the visitor how he found the site. In addition, if all registrants must be approved by the site administrator, a section is added to the list of members awaiting approval with their join reason.
Title: Re: Join Reason
Post by: jdvarner on April 28, 2010, 09:51:45 AM
ah, ok. cool beans. i thought it was a feature i could go back to and see just in case. so if you have your site to auto register or sign up by email then you would never know as an admin why they signed up.
Title: Re: Join Reason
Post by: Arantor on April 28, 2010, 09:57:03 AM
I don't see anywhere this is listed, but really if that's what you're after, I think you'd probably use the Custom Profile Fields mod for 1.1.x or the core feature in 2.0.
Title: Re: Join Reason
Post by: Deviliciouz on August 26, 2010, 09:56:47 AM
Hi, New registered members needs to be aproved by admin before they can acces the forum.
But I can't see in "Awaiting Approval " the answer the new member has given.
Mod installed fine but not this part, I've checked every modified file this mod needed and everything seems to be ok.
I'm using SMF 1.1.11 and the version of join reason is: join_reason_1_2_2, also my forum has the dutch language.
What could be the problem?
Thank You

PS. SMF is intregated in MKPortal
Title: Re: Join Reason
Post by: live627 on August 28, 2010, 09:06:54 PM
Sounds like a custom theme. Are all mod edits  on your theme?
Title: Re: Join Reason
Post by: EL34xyz on September 27, 2010, 04:40:35 PM
Howdy,
I have had Join reason intsalled for a couple years and it has worked out great.
This mod and the Stop Spammer mod have really been a big help.
I have to approve all members personally and so I read the join reasons and check them in the Stop Spammer database before I allow membership

I changed the text on the registration screen to Reason for joining this forum, which is a much more appropriate question than how did you find us.
I make them type in some words relating to the subject of the forum
So that gives me an idea if they are real people who are familiar with the topics on my forum or just spammers and hackers

I am still getting slammed by spammers that have automated the registration screen.

I see the same things being enterered in the Join Reason field by spammers all the time.
Things like "To have fun and make friends" - "I am like the forum" - "Please do be join", etc

Is there any way to have join reason check a list of known phony join reasons?
If join reason looks at a list and "I am like forum" is the reaosn, then just shut down the registration process.

Just throwing out ideas, not sure if it is something other users would find useful, but I certainly would
Thanks
Title: Re: Join Reason
Post by: EL34xyz on September 28, 2010, 03:06:36 PM
See my post right above this one

This is what I am seeing every day multiple times from multiple spammers
This spammer always uses the join reason of - To have fun :)

Full size image can be seen here
http://www.el34world.com/Misc/images/spammer2.gif

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.el34world.com%2FMisc%2Fimages%2Fspammer2.gif&hash=ef76c90c9439390baa4e3e0f55eba6af53f8f793)

Has the mod author abandoned this mod?
Title: Re: Join Reason
Post by: live627 on September 28, 2010, 06:47:38 PM
Due to a lack of free time, I am not working on any freebies ATM.

Quote from: EL34xyz on September 28, 2010, 03:06:36 PM
Has the mod author abandoned this mod?

Nope
Title: Re: Join Reason
Post by: EL34 on September 28, 2010, 06:57:47 PM
Well, do you have a paid for version of this mod that is updated with new ideas and request from users?

BTW, that screen shot of mine above also shows the Stop Spammer mod in case others are wondering.
Title: Re: Join Reason
Post by: live627 on September 29, 2010, 04:00:58 PM
No but that's a good idea... when I get time.
Title: Re: Join Reason
Post by: EL34xyz on October 01, 2010, 08:50:32 AM
Well, I decided to uninstall Join Reason for now.

I installed Anti Spam Verification Question which lets you ask 5 questions on the registration page
BTW, it does work in 1.1.11
http://custom.simplemachines.org/mods/index.php?mod=1516

So far, this has dropped the attempted spammer registrations from 5  or so per day to zero.

One thing that I found out is that I had added my own mod code to the Join Reason mod code
If the Join Reason was blank, it would reject the registration
I had to delete my code after uninstalling Join Reason
Hard to remember that far back, but apparently there is no check in Join Reason if the reason is left blank?
If so, that would be a good thing to add to the mod.

I still like the ability to read a hand typed Reason, so I may come back to this mod later if it ever gets updated.
Title: Re: Join Reason
Post by: nRadiant on October 15, 2010, 12:23:56 PM
Just attempted to add this mod to my 1.1.11 SMF forum which resulted in the following error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE Field = 'join_reason'' at line 1
File: install11.php
Line: 12

Any suggestions on how to complete the install. Bot registrations are becoming a real pain.
Title: Re: Join Reason
Post by: live627 on November 01, 2010, 12:23:18 AM
MySQL version?

Possibly yours doesn't support LIKE statements...
Title: Re: Join Reason
Post by: EL34 on November 01, 2010, 07:40:49 AM
NRadiant,
Not to dis this mod, buit I had it installed for a long time and it was ok, but bots were easily able to automate the registration page and submit.

It was a huge pain to have to sort through and deny registration to the bots and spammers.
I uninstalled Join Reason and installed Anti Spam Verification Question

This mod stopped the bots cold.
I installed Anti Spam Verification Question which lets you ask 5 questions on the registration page
BTW, it does work in 1.1.11
http://custom.simplemachines.org/mods/index.php?mod=1516

I also recently installed the Mod HttpBL and that mod prevents the spammers and bots from even seeing the registration page.
http://custom.simplemachines.org/mods/index.php?mod=2155

I highly reccomend the two mods above.
Title: Re: Join Reason
Post by: Oya on November 01, 2010, 07:44:07 AM
this mod isn't an anti spam mod... it's to see where people are coming from
Title: Re: Join Reason
Post by: EL34 on November 01, 2010, 08:13:23 AM
QuoteBot registrations are becoming a real pain

Sure it is, or at least that is what made me install it in the first place and probably others do the same thing also as nRadiants quote above implies.

So, maybe Join Reason was not intended as a anti spammer/bot mod, but some people tend to think this will help the situation.

In that case, I provided the other links to mods that will actually stop Spammer and bots.
Just throwing out info for other mods that I found were much better at stopping false applicants.
Title: Re: Join Reason
Post by: sharks on November 03, 2010, 02:12:24 PM
Please improve this great mod further by adding these features:

Add option to force new members to fill the "reason for joining" field in order to complete the registration page.

Add feature in the new member profiles to always show info about their "reason for joining". For existing members (who registered before installation of this mod), when they go to edit anything in their profile, they should be prompted to enter a "reason for joining".

Please consider these updates for the next release of your mod. :)
Title: Re: Join Reason
Post by: MCK on December 16, 2010, 09:31:46 AM
Great suggestions above. May I also add the ability to change the "Reason for joining" text? I would like to be able to ask for a more specific response relevant to my site content. Thank you.
Title: Re: Join Reason
Post by: live627 on December 19, 2010, 06:22:32 PM
Join Reason Pro has been completed! SMF 2.0.x

http://dev.live627.com/index.php?topic=9.0
Title: Re: Join Reason
Post by: MaryLouW on January 17, 2011, 01:29:45 AM
I have a question about this mod before I install it.  Is the field that asks how they found the forum mandatory and if so, have bots found a way around this?

The reason I ask is because I am getting from 10-15 requests per day to join the forum (by approval only). Almost all of them have emails like this   MAIL.RU   YAHOO.CO.RU  YAHOO.CO.UK   YANDEX.UA   .INFO

I am sure they are not interested in joining a graphic forum but they are driving me crazy.  I am thinking that if that field is required upon registration, it might eliminate a lot of these. 
Title: Re: Join Reason
Post by: the-wanted on January 17, 2011, 04:04:22 AM
nice mod and here is the swedish translation

Code (swedish) Select
$txt['admin_browse_join_reason'] = 'Anledning till att gå  med i detta forum';
$txt['join_reason'] = 'Hur hittar du oss?';

Title: Re: Join Reason
Post by: sharks on January 17, 2011, 07:06:35 PM
Quote from: live627 on December 19, 2010, 06:22:32 PM
Join Reason Pro has been completed! SMF 2.0.x

http://dev.live627.com/index.php?topic=9.0
I would like to get it, but it's just not good enough, yet. Have you considered my suggestions in my previous reply above?
Title: Re: Join Reason
Post by: EL34 on January 17, 2011, 08:27:41 PM
Sharks,
I uninstalled this mod after using it for quite a while.
It is very limited in it's ability to curb unwanted registrations.
I had to mod the mod myself to make it require a join reason.
Even then, bots were easily able to automate the join reason.
I was dealing with quite a few automated registrations every day.

Also, the author did not seem to be interested in improving a free mod.

This mod has proven to be way more effective in stopping bots from registering
http://custom.simplemachines.org/mods/index.php?mod=1516

Sorry, just throwing out info to others looking for a better way to curb automated registrations.
Title: Re: Join Reason
Post by: live627 on January 17, 2011, 11:47:46 PM
Quote from: MaryLouW on January 17, 2011, 01:29:45 AM
I have a question about this mod before I install it.  Is the field that asks how they found the forum mandatory and if so, have bots found a way around this?
1) The field is mandatory
2) Bots can easily bypass this.

QuoteI am thinking that if that field is required upon registration, it might eliminate a lot of these. 
Wishful thinking...

Quote from: EL34 on January 17, 2011, 08:27:41 PMIt is very limited in it's ability to curb unwanted registrations.
for the unteenth friggin time, this mod does not stop bots! How does that not make sense?

QuoteI had to mod the mod myself to make it require a join reason.
Which version of this mod did you modify? I honestly  thought I made it required...

QuoteI was dealing with quite a few automated registrations every day.
Yes, yes, and this mod is not the right tool to weed them out.

QuoteAlso, the author did not seem to be interested in improving a free mod.
Ah, but you see, this mod does what it was intended to do - simply ask registrees why they join.

QuoteThis mod has proven to be way more effective in stopping bots from registering
http://custom.simplemachines.org/mods/index.php?mod=1516
That's geared more toward stopping spammers.

Quote from: sharks on January 17, 2011, 07:06:35 PM
I would like to get it, but it's just not good enough, yet. Have you considered my suggestions in my previous reply above?
Not good enough, not good enough, blah, blah, blah.

I did my part, yes, and I'm done with friggin freebies. Want my mods? Shell out some cash!

And read what Oya said, please. Especially his last sentence.
Title: Re: Join Reason
Post by: MaryLouW on January 18, 2011, 02:22:35 AM
Well, the mod I installed, the one that asks the 5 questions seems to be working but it's only been about 6 hours or so.  I normally have several try to register in this length of time.  If I find that it's not adequate, I'll come back and try this one.  I think it's also interesting to know how a person found you.
Title: Re: Join Reason
Post by: Arantor on January 18, 2011, 02:36:24 AM
Great, we're happy that you found an anti spam mod that works for you...

QuoteI think it's also interesting to know how a person found you.

That's what this mod does, nothing more...
Title: Re: Join Reason
Post by: MaryLouW on January 18, 2011, 02:54:32 AM
I''m not positive that it's working  but this is the first time in months that I haven't gotten any registration requests in over a 6 hour period!  I also took someone elses advice and banned some of them based on their email address  like  .ru  and .info  and I think that too will help.   A few days or maybe a week will tell. 

Thanks again to everyone for their suggestions and such.  I am much happier tonight than I was this morning!  :)
Title: Re: Join Reason
Post by: sharks on January 18, 2011, 07:41:45 AM
Quote from: Oya on November 01, 2010, 07:44:07 AM
this mod isn't an anti spam mod... it's to see where people are coming from
Well, i just read what Oya said, and there is no way of finding those "reasons to join" after a member has joined. Shouldn't there be some sort of indexed list in the admin panel so the admin can see all the new members and their "reasons for joining"? What's the point of having members type in their reasons for joining, when it's not easily accessible by the admin. For active forums, with several dozens (up to hundreds) of new members every 24 hours, having to check each new member's profile for the "reason to join" just doesn't make sense and is totally impractical.

Quote from: live627 on January 17, 2011, 11:47:46 PM
I did my part, yes, and I'm done with friggin freebies. Want my mods? Shell out some cash!
And really, it's so disappointing that some of the few remaining devs here are turning into crooks and openly asking for money to keep developing their mods. Most of us chose SMF because it is supposed to be FREE. At least, that's what i assumed when i picked up this platform for my forums over 5 years ago.

"I did my part"? WTF does that even mean? Who forced you to ever do your part to begin with? This is free software, and as far as i know people here are not forced to contribute. Don't try to pin your development of a poor/incomplete mod on us. With the never-ending drama on the SMF team and a historic long line of departed and departing devs from this community, it's actually funny to finally see some of you admit it out in the open that you're really here just for the money. Coming from a Charter Sophist member, i'll probably use your line around the internet quite a lot, to prove the growing greed that has been eating this community from within (and clearly explains why SMF 2.0 Gold took the record amount of years to finish).

And to all those asking, this is indeed NOT an anti-spam mod/measure. But for whatever it does, there's still more solid work to be done. What's wrong with voicing a perfectly honest opinion and logic suggestion for improvement? But extortion of SMF members is obviously WRONG!

FYI, even the pro version of your mod is missing the basic improvements that i have suggested. LOL

Peace out.
Title: Re: Join Reason
Post by: Arantor on January 18, 2011, 08:32:51 AM
QuoteWell, i just read what Oya said

I wonder when they'll reattribute my posts to me... ;)

QuoteAnd really, it's so disappointing that some of the few remaining devs here are turning into crooks and openly asking for money to keep developing their mods. Most of us chose SMF because it is supposed to be FREE. At least, that's what i assumed when i picked up this platform for my forums over 5 years ago.

Let me answer that. The reason I stopped publishing mods here is because I felt so damn unappreciated by mod users. I had people guilt-tripping me into trying to add features to things, hell one person even threatened to DDOS my site (before I had arantor.org) unless I wrote a mod for him.

Users, generally, have this expectation that mod authors owe them something - that updates, new features and so on will always be free, will always be done, will always be there without any work on the user's side. Not all of us want to feel as though we're perpetually on the treadmill.

Let me point something out: I wrote close to 70 mods, and made literally thousands of support posts. And how much do you think I got in return for that? The financial return for me after all that is still under $200. Most people here don't want to pay anything for hard work, don't want to take any time to appreciate that coders have to spend a LOT of time working on things to make them work well - and when it comes down to it, users will whine and complain without ever putting in any of the appreciation.

Quote"I did my part"? WTF does that even mean?

It means that Live felt he did a reasonable 'donation' of free time and energy to the community and is fed up of feeling as though he should be expected to provide everything for free when it's his time and energy. A lot like me, really.

QuoteWith the never-ending drama on the SMF team and a historic long line of departed and departing devs from this community, it's actually funny to finally see some of you admit it out in the open that you're really here just for the money.

Yay for people who don't have a clue about what really happened? The long line of devs departing was either due to real life commitments and/or the politics. The people that contributed, me included, did so because we wanted to.

There are very few people here just for the money. Out of respect, I won't name them, but Live isn't one of them. He, like me, got so fed up with the users expecting that their stuff comes first - remember, we wrote mods originally as a *hobby*. Do you have any hobbies? Do you have people telling you how you should enjoy your hobby? Try imagining that scenario, because that's what life ends up when you're a modder or a themer.

QuoteWhat's wrong with voicing a perfectly honest opinion and logic suggestion for improvement? But extortion of SMF members is obviously WRONG!

Spin it around, you're trying to guilt Live into making updates and complaining when it's not happening. Isn't that attempting to extort something for nothing?
Title: Re: Join Reason
Post by: sharks on January 18, 2011, 09:01:05 AM
Here comes Arantor... the SMF sedative to all frank and open discussions. :D (joking)

Seriously...
QuoteSpin it around, you're trying to guilt Live into making updates and complaining when it's not happening. Isn't that attempting to extort something for nothing?

I did say that i was ready to buy his mod as i have already gone through his private site to check on the Pro version, but i'm definitely NOT going to spend any money on it if it doesn't have the basic features that i suggested. These are indeed quite basic features. I am not asking Live to make a portal out of it! LOL. If Live can show some respect and willingness to improve his mod, then i might be able to trust him enough to buy his mod even though it's not currently satisfactory, IMHO. The main problem is once the payment is made, most developers lose interest to keep their paid mods updated or fixed or adding new features. So, i end up with worthless code on my drive with zero support. And out of respect to the copyrighted code, i can't even ask someone else to fix it or share it to the community for someone to improve it, for that matter.

My experience with paid SMF mods is a complete disaster. I have bought quite a few paid mods in the past few years and the support for these paid mods quickly stopped after i hit the "pay" button. I have begged for months for the bugs to be fixed as i was aware that new features would probably never be added, so i was content if the bugs were fixed. Several paid SMF devs seem to be 100% dedicated at one time and then they seem to lose interest rather quickly, eventually abandoning everything. Most probably because the money isn't rolling in as fast as they had expected. The hassle starts for those who bought these paid mods and then receive zero support, especially in case of bugs. As it turns out, i spent over $100 on paid mods but i recently had to give it all up by restarting my forum with fresh SMF files and zero paid mods, as some were incompatible with the recent SMF versions and most of the others were beginning to cause me great trouble with my host due to very high server usage as the bugs were generating excessive SQL queries along with the multiple broken features that my members grew tired of telling me. Once i bought a mod and it has bugs in it. I asked for months for these bugs to be fixed, only to be promised that it will be fixed when "the developer has time". What happened was that i never could use that mod, as after 6 months after having bought that mod, it is so choke full of severe bugs that if i were to enable it on my live forums, my host would kick me out of the server for excessive resource usage and i'm certainly not upgrading to VPS just because of a poorly coded mod.
Sadly, i can't do nothing to fix those as i don't understand much php or i would have fixed those mods myself and even contributed with some free mods of my own to this dying community.

So.. whenever i now see someone asking for money to fix/improve his mods, it loses my favour instantly. If you already have a perfectly working mod and secondly, good support, then i would be more than happy to buy it, knowing that it will be immediately useful on my live forums, without causing havoc on my server or panic with my forum members reporting broken code-related errors all over the forum.

See ya.
Title: Re: Join Reason
Post by: Arantor on January 18, 2011, 09:15:21 AM
QuoteHere comes Arantor... the SMF sedative to all frank and open discussions.

Hahahaha! I try to encourage frank discussion, though it rarely ends up that way :/ What I can say is that I call it how I see it. That may or may not be 100% accurate sometimes, but it's all based on my perception of things.

QuoteI did say that i was ready to buy his mod as i have already gone through his private site to check on the Pro version, but i'm definitely NOT going to spend any money on it if it doesn't have the basic features that i suggested.

My bad; my perception of it was that it was a request of 'this mod doesn't have feature <x> and I want it for free because I think it should be in the free version', which I've heard way too many times. (There are a number of requests for backporting Aeva 2.x features into the free version for example, at least that's what my PM inbox tells me... just because people want what's free)

QuoteMy experience with paid SMF mods is a complete disaster. I have bought quite a few paid mods in the past few years and the support for these paid mods quickly stopped after i hit the "pay" button.

*nods* There are very few paid folks here who actually 1) really know their stuff and 2) are prepared to support it. This is one of the myriad reasons I don't have a lot of respect for the paid modders here, because everything I hear is that they're not prepared to follow up "reasonable" expectations. (Note, I know everyone has a different definition of 'reasonable'. Some people think that paying me $10 for what was a 10 minute job is then an excuse to expect 6 hours work, and think that's reasonable. But here, I'd argue that if you spend money on a mod, you're entitled to at least some support. It might not cover customisation, say, but trouble-shooting and bug fixes, unless otherwise clearly stipulated should be.)

QuoteSeveral paid SMF devs seem to be 100% dedicated at one time and then they seem to lose interest completely quickly, eventually abandoning everything.

Everyone moves on eventually, that's how life ends up, I'm afraid. But some of the paid folks do give up rather quickly. Others get fed up with the hassle; I'll note that I had big plans for a mod marketplace for SMF, but realised that I didn't want all the hassle I knew would have entailed (like the expectation of support for mods I was the marketplace for, etc)

The trouble is, people seem to expect the same level of service from the free modders, who often move on of their own accord - I gave all my mods away from my failed mod site because, ultimately, I'm not going to be using SMF for the long term, I guess I'm moving on too ultimately (in my case it's the politics rather than anything else)

QuoteMost probably the money isn't rolling in as fast as they had expected.

Very likely. Or they find they can't be bothered with the 'want it free' crap. Point of interest: vbgamer bought the ad management mod, and now maintains it. Since on 1.1.x it requires custom theme edits, he offers a service where he'll add it for $15. I won't fault him for that - but what amazes me is the number of people that then ask in the thread about how they can add it for free because he won't. Small wonder the paid community disappears after stunts like that get pulled.

QuoteThe problem is with those who bought these mods and receive zero support, especially in case of bugs.

Can't lay the blame for that anywhere other than at the developer. There are a lot of fly-by-night modders in that respect.

QuoteAs it turns out, i spent over $100 on paid mods but i recently had to give it all up, as some were incompatible with the recent SMF versions and most of the others were beginning to cause me great trouble with my host due to very high server usage as the bugs were shooting away with excessive SQL queries and broken features that my members grew tired of telling me.

Ouch. I can certainly understand your reluctance to deal with paid modders after that, but I gotta say, Live is definitely one of the good guys in that respect :)

QuoteSadly, i can't do nothing to fix those as i don't understand much php or i would have fixed those mods myself and even contributed with some free mods of my own to this dying community.

*nods* I can fully understand that. I won't get into the debate here on why the community is dying but this isn't the only factor at all to it, though it is a big one.
Title: Re: Join Reason
Post by: MCK on February 05, 2011, 02:18:29 PM
Would love to install this mod to a site I just upgraded from SMF 1.1.12 to SMF 2 RC4. When I attempt installation in RC3 compatibility mode the installer is telling me it will fail installation due to "./Sources/ManageMembers.php" and last AddAfter (of 4) for this file seems to be where the problem is. Any ideas on how I can install this mod on RC4? Thank you.

EDIT - I was able to install by letting the installer do its job and manually adding the step 4 into ManageMembers.php. All is working now. Thanks for making this mod.

I would really appreciate help / guidance on how I can make Reason for joining field mandatory during registration though. Hope someone can help me. Thanks!
Title: Re: Join Reason
Post by: sharks on February 11, 2011, 04:06:33 PM
Last time i asked for help on this mod, i was forced to pay for another crippled version, which i refused, obviously. But, hey, it might be different for you. Good luck!
Title: Re: Join Reason
Post by: Mari-chi on February 12, 2011, 04:30:52 AM
Gosh you really need to stop slamming on people. :/ If you want to write out a complaint, then you should do so in private--or go with a review in the Reviews board. But this is a mod's support and comments thread, not somewhere to vent your frustrations.
Title: Re: Join Reason
Post by: Kolya on February 26, 2011, 09:30:13 PM
I wanted a text window for applicants to put down their join reason, instead of just one line.
I wouldn't know how to explain a reason in one short line, so I couldn't expect others to.
Anyway, it's a very simple change.

In Themes\Default\Register.template.php find:
<input type="text" name="join_reason" id="smf_join_reason" size="30" tabindex="', $context['tabindex']++, '" />

...and replace with:

<textarea rows="3" cols="60" name="join_reason" id="smf_join_reason" tabindex="', $context['tabindex']++, '"></textarea>


Cheers to live for making this useful mod. It's appreciated.
Title: Re: Join Reason
Post by: sharks on February 27, 2011, 04:40:57 PM
Quote from: Mari-chi on February 12, 2011, 04:30:52 AM
Gosh you really need to stop slamming on people. :/ If you want to write out a complaint, then you should do so in private--or go with a review in the Reviews board. But this is a mod's support and comments thread, not somewhere to vent your frustrations.
If that would have made the slightest difference, i would have sent the mod dev a postcard with the bugs list! :D
Title: Re: Join Reason
Post by: MCK on February 28, 2011, 01:27:28 AM
Quote from: Kolya on February 26, 2011, 09:30:13 PM
I wanted a text window for applicants to put down their join reason, instead of just one line.
I wouldn't know how to explain a reason in one short line, so I couldn't expect others to.
Anyway, it's a very simple change.

In Themes\Default\Register.template.php find:
<input type="text" name="join_reason" id="smf_join_reason" size="30" tabindex="', $context['tabindex']++, '" />

...and replace with:

<textarea rows="3" cols="60" name="join_reason" id="smf_join_reason" tabindex="', $context['tabindex']++, '"></textarea>


Cheers to live for making this useful mod. It's appreciated.

Kolya, thanks for your contribution. Most appreciated. I wanted to be able to modify the text where it says Join Reason and managed to do it using the following approach. Sharing here for other newbies like me to enjoy if they wish... Of course everyone should modify the text according to their needs.

In Themes\default\languages\index.english.php find:
$txt['join_reason'] = 'Reason for joining this forum.';

...and replace with:

$txt['join_reason'] = 'Reason for joining this forum. Please be very specific referring to our topic & content. Reasons like fun, to share, information etc will not work.';

Title: Re: Join Reason
Post by: Astarta on March 15, 2011, 08:11:42 AM
Hello,

Recently I've started using 'Join  Reason' mod and it works great )
I have only one question, I'd like to have 'join reason' field be present in user profiles (for members that have been registered while this mod is active). Is it possible?

I've tried adding

                                        <td><b>', $txt['join_reason'], ': </b></td>
                                        <td>', $context['member']['join_reason'], '</td>


code to Themes/<current_theme>/Profile.template.php file, but join reason field in is still empty in profiles of new users. $context['member']['join_reason'] seems to be wrong way.

Where I was wrong?

Thank you for any help.
Title: Re: Join Reason
Post by: live627 on March 17, 2011, 01:59:02 AM
Can you tell me which line of code you added after? Not the line number, the actual code...
Title: Re: Join Reason
Post by: ECS Dave on March 27, 2011, 09:34:58 PM
Will Join Reason 1.3 work on a SMF 1.1.11 board? I have 1.2.1 installed, and think that seeing the reason in the admin list would be great...

If it will work with SMF 1.1.11, should I remove the 1.2.1 first?

Thanks for the mod live627!
Title: Re: Join Reason
Post by: live627 on March 27, 2011, 11:18:14 PM
No 2.0 only
Title: Re: Join Reason
Post by: ECS Dave on March 29, 2011, 10:21:32 AM
Quote from: live627 on March 27, 2011, 11:18:14 PM
No 2.0 only
Okay, thanks for the reply...
Title: Re: Join Reason
Post by: live627 on March 29, 2011, 04:19:49 PM
Actually... I think I made a mistake maybe. For 1.1.11, use the 1.2 package as prescribed on the mod page.
Title: Re: Join Reason
Post by: Kathleen Chute on April 14, 2011, 09:18:14 PM
Quote from: MCK on February 28, 2011, 01:27:28 AM
Quote from: Kolya on February 26, 2011, 09:30:13 PM
I wanted a text window for applicants to put down their join reason, instead of just one line.
I wouldn't know how to explain a reason in one short line, so I couldn't expect others to.
Anyway, it's a very simple change.

In Themes\Default\Register.template.php find:
<input type="text" name="join_reason" id="smf_join_reason" size="30" tabindex="', $context['tabindex']++, '" />

...and replace with:

<textarea rows="3" cols="60" name="join_reason" id="smf_join_reason" tabindex="', $context['tabindex']++, '"></textarea>


Cheers to live for making this useful mod. It's appreciated.

Thank you so much this mod is just what I want, I used the Advice above, That was awesome for an old dog that cant bark. Now Can someone tell me how to Change the Text In The Admin Panel
Title: Re: Join Reason
Post by: Kathleen Chute on May 18, 2011, 01:21:11 PM
Quote from: Kathleen Chute on April 14, 2011, 09:18:14 PM
Quote from: MCK on February 28, 2011, 01:27:28 AM
Quote from: Kolya on February 26, 2011, 09:30:13 PM
I wanted a text window for applicants to put down their join reason, instead of just one line.
I wouldn't know how to explain a reason in one short line, so I couldn't expect others to.
Anyway, it's a very simple change.

In Themes\Default\Register.template.php find:
<input type="text" name="join_reason" id="smf_join_reason" size="30" tabindex="', $context['tabindex']++, '" />

...and replace with:

<textarea rows="3" cols="60" name="join_reason" id="smf_join_reason" tabindex="', $context['tabindex']++, '"></textarea>


Cheers to live for making this useful mod. It's appreciated.

Thank you so much this mod is just what I want, I used the Advice above, That was awesome for an old dog that cant bark. Now Can someone tell me how to Change the Text In The Admin Panel
I would Like to Know Where I would find the REASON FOR JOINING Text  in the Admin Panel.
I Used The Above Information Before, But I never did ask about the Location of this file.
Thanks for any help.
Kathleen
Title: Re: Join Reason
Post by: live627 on May 18, 2011, 02:12:57 PM
That is quite the quote :P

Try searching the text in index.english.php, or if you use UTF-8, index.english-utf8.php. Both reside within the languages folder inside your default theme directory.
Title: Re: Join Reason
Post by: Kathleen Chute on May 18, 2011, 03:55:25 PM
Thanks For The fast responce
I will Update
Kathleen
Title: Re: Join Reason
Post by: Kathleen Chute on May 21, 2011, 07:05:52 PM
Quote from: live627 on May 18, 2011, 02:12:57 PM
That is quite the quote :P

Try searching the text in index.english.php, or if you use UTF-8, index.english-utf8.php. Both reside within the languages folder inside your default theme directory.
Yep I messed up That Quote.
I Was able to Find REASON For5 JOINING Text that shows On the REG page to all un reg members.
But The Text also Shows In The Admin  Panel . I would Like to alter That text a well.
Thanks
Kathleen
Title: Re: Join Reason
Post by: live627 on May 21, 2011, 09:40:33 PM
./Themes/default/languages/ManageMembers.english.php

$txt['admin_browse_join_reason'] = 'Reason for joining';
Title: Re: Join Reason
Post by: Kathleen Chute on May 21, 2011, 10:22:58 PM
Thanks
I will test this Tomorrow, dogs are Playing and Im Tired.
Thank you so Much for your Help
Kathleen
Title: Re: Join Reason
Post by: MiY4Gi on July 06, 2011, 07:49:37 AM
Where do I view the users' Join Reasons after they have registered?
Title: Re: Join Reason
Post by: Kolya on July 06, 2011, 08:39:23 AM
In the approval screen.
http://www.YOURSITE.com/index.php?action=admin;area=viewmembers;sa=browse;type=approve;

I have meanwhile ditched this mod in favour of an advanced profile field which is set to be compulsively filled out during registration. While I had no problem with the mod switching was a no-brainer once I realised I could achieve the same through a native forum function.
Title: Re: Join Reason
Post by: MiY4Gi on July 06, 2011, 09:16:51 AM
Quote from: Kolya on July 06, 2011, 08:39:23 AM
In the approval screen.
http://www.YOURSITE.com/index.php?action=admin;area=viewmembers;sa=browse;type=approve;

I have meanwhile ditched this mod in favour of an advanced profile field which is set to be compulsively filled out during registration. While I had no problem with the mod switching was a no-brainer once I realised I could achieve the same through a native forum function.

Thanks for the heads up. I'll give this a go.
Title: Re: Join Reason
Post by: Martingonnella on July 06, 2011, 05:37:29 PM
Live 627..Can you please make this version 2.0 ...I like the Mod..But want to install it in.. thanks
Title: Re: Join Reason
Post by: live627 on July 06, 2011, 07:41:53 PM
Install it already :)
Title: Re: Join Reason
Post by: Martingonnella on July 06, 2011, 07:46:59 PM
Ooo..it does work after all..Thanks
Title: Re: Join Reason
Post by: live627 on July 06, 2011, 07:53:23 PM
That's the thing with this mod: it isn't tied to versions very much... only a loose range: 2.0 - 2.99.99, which allows it to install even on the legacy RC3 release. Without emulation. :D Same with 2.0.45  :P
Title: Re: Join Reason
Post by: bloc on August 28, 2012, 12:32:08 PM
Quote from: Kolya on July 06, 2011, 08:39:23 AM
I have meanwhile ditched this mod in favour of an advanced profile field which is set to be compulsively filled out during registration. While I had no problem with the mod switching was a no-brainer once I realised I could achieve the same through a native forum function.

Not sure of compulsory profile field will show up in the approval screen? Anyhow, installed and working great.

Thanks for a really useful mod. :)
Title: Re: Join Reason
Post by: live627 on August 30, 2012, 01:23:07 AM
QuoteNot sure of compulsory profile field will show up in the approval screen?
It won't show up there.
Title: Re: Join Reason
Post by: bloc on August 30, 2012, 01:41:03 AM
Thought so. This mod have helped a LOT, its now easy to sort out the spammers. If they can't provide a coherent reason for joining, they are not approved. ;D
Title: Re: Join Reason
Post by: live627 on August 30, 2012, 08:15:49 PM
Quote from: Bloc on August 30, 2012, 01:41:03 AM
Thought so. This mod have helped a LOT, its now easy to sort out the spammers. If they can't provide a coherent reason for joining, they are not approved. ;D
Precisely my use  for it
Title: Re: Join Reason
Post by: dvk01 on September 26, 2012, 01:38:24 PM
I have join reason mod  and email template editor mod both installed and want the join reason to be sent in the Admin Notify Approval email
how do I get that variable in there or can't it be done using email template editor or do I need to alter one of the smf core files to get the join reason in the Admin Notify Approval email
Quote from: Labradoodle-360 on September 26, 2012, 01:15:39 PM
You're probably going to want to ask live (author of Join Reason Mod) how best to integrate his modification into Email Template Editor.
Title: Re: Join Reason
Post by: live627 on September 26, 2012, 09:07:29 PM
Need a small code edit. I'lll post it soon.
Title: Re: Join Reason
Post by: live627 on September 26, 2012, 09:23:47 PM
If you go look in ./Sources/Subs-Members.php, you'll find four occurrences of

'REALNAME' => $regOptions['register_vars']['real_name'],

After the LAST THREE, add

'JOINREASON' => $regOptions['register_vars']['join_reason'],

That should add a new variable, JOINREASON, for you to use with the email editor.
Title: Re: Join Reason
Post by: dvk01 on September 27, 2012, 04:14:14 AM
I can't find a way to get it into the editor
is there some other way to alter the sent email apart from using email template editor to send the join reason in the adminnotify  approval email

to make it clear
I have added the edits from live627 above to Sources/Subs-Members.php and I have created a new global variable in email editor {JOINREASON} but all I get in the email is {JOINREASON}not teh data

where am I going wrong
Title: Re: Join Reason
Post by: Game.ruler on February 22, 2013, 07:09:19 AM
Please anyone help me. If i want this join reason field to be optional, then what should i edit?
Thank you.
Title: Re: Join Reason
Post by: LuckyDog Sports on November 06, 2013, 12:22:11 AM
Just tries to install this mod in 2.0.6 (via Package Manager) with the Black Knight Theme and Prevent Topic View Increase by Author Mod and I get the follow:

Fatal error: require() [function.require]: Failed opening required '/homepages/30/d90568795/htdocs/forum/Packages/temp/install20.php' (include_path='.:/usr/lib/php5') in /homepages/30/d90568795/htdocs/forum/Sources/Packages.php on line 951

Can you tell me why and how to fix?

Let me know if you need addidtional info.

Thanks
Title: Re: Join Reason
Post by: Burke ♞ Knight on December 03, 2013, 01:01:42 PM
I tried to install this in a 2.0.6 site, when hit install, get white page. Mod does not install, and nothing wrong with my site or host, so the normal white page of death does not apply in this case.

EDIT:

Happens on any 2.0.6 site, on different servers.
Title: Re: Join Reason
Post by: live627 on December 21, 2013, 07:58:28 PM
Install 1.3.
Title: Re: Join Reason
Post by: ViV on January 19, 2014, 09:42:52 AM
Kindly share the 1.3 version with us. The version available right now is 1.4 and I am unable to find 1.3
Title: Re: Join Reason
Post by: live627 on January 19, 2014, 04:05:42 PM
http://custom.simplemachines.org/mods/index.php?action=download;mod=2326;id=175273
Title: Re: Join Reason
Post by: ViV on January 20, 2014, 02:23:15 AM
The link takes me to a blank page
Title: Re: Join Reason
Post by: ViV on January 20, 2014, 06:55:39 AM
Request you to PM me the file. Alternatively you can email me the same at [email protected]
Title: Re: Join Reason
Post by: live627 on January 20, 2014, 04:52:39 PM
Mail sent.
Title: Re: Join Reason
Post by: ViV on January 21, 2014, 12:54:36 AM
Thanks a million...

Got it and it worked :)
Title: Re: Join Reason
Post by: KungFuJoe on January 29, 2014, 07:34:57 PM
Can you send 1.3 to me as well?  ([email protected]).  I'm getting the install20.php error.
Title: Re: Join Reason
Post by: live627 on January 30, 2014, 01:35:28 AM
http://livemods.net/index.php?topic=134
Title: Re: Join Reason
Post by: GamePersia on February 18, 2014, 07:00:05 AM
whenever installing,..
it shows error : :(
Fatal error: require(): Failed opening required '/home/u728154997/public_html/Packages/temp/install20.php' (include_path='.:/opt/php-5.4/pear') in /home/u728154997/public_html/Sources/Packages.php on line 951
Title: Re: Join Reason
Post by: margarett on February 18, 2014, 07:12:57 AM
Confirmed, there is an error in the package... package-info.xml refers "install20.php" and the file in the package is called "install.php" as already reported in the previous page.

To fix it, unpack the MOD, rename install.php to install20.php, repack and upload it.
Title: Re: Join Reason
Post by: GamePersia on February 18, 2014, 07:27:57 AM
Quote from: margarett on February 18, 2014, 07:12:57 AM
Confirmed, there is an error in the package... package-info.xml refers "install20.php" and the file in the package is called "install.php" as already reported in the previous page.

To fix it, unpack the MOD, rename install.php to install20.php, repack and upload it.
Ok,..
Sorry i not turned this page !! :P
thanks for again telling me buddy !! :D
Title: Re: Join Reason
Post by: vbgamer45 on February 18, 2014, 12:12:30 PM

Version 1.5
!Fix install issue for SMF 2.0.x
Title: Re: Join Reason
Post by: GamePersia on March 04, 2014, 05:10:51 AM
How would i know that a new member who joined site what he/she had written in join reason ??
any place where join reason of his/her would be mention ? :-\
Title: Re: Join Reason
Post by: live627 on March 04, 2014, 01:09:25 PM
rtfm
Title: Re: Join Reason
Post by: GamePersia on March 04, 2014, 09:23:01 PM
Quote from: live627 on March 04, 2014, 01:09:25 PM
rtfm
what is this ???
Title: Re: Join Reason
Post by: Shambles on March 05, 2014, 09:18:51 AM
Quote from: GamePersia
Quote from: live627
rtfm
what is this ???

An extremely rude comment which I'd ignore, if I were you.
Title: Re: Join Reason
Post by: DEEPSNUYB on March 17, 2014, 05:59:28 AM
Does the install.php modify the database or just add tables?  This has been manually installed and I want to remove all traces of it from the db since I really have no use for it.  Thanks.
Title: Re: Join Reason
Post by: margarett on March 17, 2014, 08:49:04 AM
It adds a column "join_reason" to smf_members table
Title: Re: Join Reason
Post by: NekoJonez on March 22, 2014, 01:22:27 PM
Question: How can I see the join reason when there is no admin approval?

Question 2: How can I make this field optional?
Title: Re: Join Reason
Post by: demlak on May 16, 2014, 08:43:08 PM
i just played a little bit with it..
i want to share my findings.. BUT BE CAREFULL.. im NOT A CODER.. i don´t know if this will break your forum!

adding the join-reason to the default memberslist in admin area is simple.. just change in ..Sources/ManageMembers.php
                                        'default' => 'posts',
                                        'reverse' => 'posts DESC',
                                ),
                        ),
                        'check' => array(
                                'header' => array(

to
                                        'default' => 'posts',
                                        'reverse' => 'posts DESC',
                                ),
                        ),
                        'join_reason' => array(
                                'header' => array(
                                        'value' => $txt['admin_browse_join_reason'],
                                ),
                                'data' => array(
                                        'db_htmlsafe' => 'join_reason',
                                ),
                                'sort' =>  array(
                                        'default' => 'join_reason DESC',
                                        'reverse' => 'join_reason',
                                ),
                        ),
                        'check' => array(
                                'header' => array(


in my theme.. this is not accaptable, because the memberslist is wider than the page.. so the list is cropped at the right side..
in my forum there is no difference between Username and DisplayName.. so i just cut off the "display name" column, by adding a # at each line, that is responsible for this column of the members list.. maybe this is a workaround for anyone else..  maybe someone trys to add a smal popup button, which does not make the members list bigger than it should..
here is my workaround:
#                       'display_name' => array(
#                               'header' => array(
#                                       'value' => $txt['display_name'],
#                               ),
#                               'data' => array(
#                                       'sprintf' => array(
#                                               'format' => '<a href="' . strtr($scripturl, array('%' => '%%')) . '?action=profile;u=%1$d">%2$s</a>',
#                                               'params' => array(
#                                                       'id_member' => false,
#                                                       'real_name' => false,
#                                               ),
#                                       ),
#                               ),
#                               'sort' => array(
#                                       'default' => 'real_name',
#                                       'reverse' => 'real_name DESC',
#                               ),
#                       ),


if you want it to be optional and not as an obligation.. just do the same with the coresponding "empty check"..
in Sources/Register.php change:
        // You can't register without a reason..
        if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
               fatal_lang_error('error_join_reason_empty', false);

to
        // You can't register without a reason..
#        if (empty($_POST['join_reason']) || trim($_POST['join_reason']) == '')
#               fatal_lang_error('error_join_reason_empty', false);


would be nice to have those things as a real option in a mod settings page..
Title: Re: Join Reason
Post by: Ninja ZX-10RR on May 20, 2014, 05:49:09 AM
Quote from: Arantor on January 02, 2010, 01:17:33 PM
So 0 is a logical join reason?
I'm really crying for laughing too much  ;D

Anyway... Italian translation? :O
$txt['admin_browse_join_reason'] = 'Motivo della registrazione';
$txt['join_reason'] = 'Come é venuto a conoscenza di questo sito?';


Code (utf) Select
$txt['admin_browse_join_reason'] = 'Motivo della registrazione';
$txt['join_reason'] = 'Come &eacute; venuto a conoscenza di questo sito?';
Title: Re: Join Reason; Cant View Member List after Apllying Mod - blank page only
Post by: dtbradio on October 07, 2014, 02:49:31 PM
Hi!

I went down through the file edits (double-checked everything twice), then copied the files included in the mod ZIP package into my smf directory and ran install.php. Now, when I try to view the member list from the admin panel, I get nothing but a blank screen. No files were modified other than the ones specified in the modification instructions for SMF 2.0.9 (the version I'm using), and no database mods were done after the install.php file was executed.

Any ideas here?
Title: Re: Join Reason
Post by: margarett on October 07, 2014, 06:07:55 PM
Check your server logs. There's probably a php error happening ;)
Title: Re: Join Reason
Post by: aegersz on January 24, 2018, 06:20:11 PM
if you wish to move SMF's Advanced Profile Fields and uninstall this mod then consider the following:

Configure SMF via "Admin > Core Features > Advanced Profile Fields > add a field called "Join Reason" and Profile Section set to Forum Profile carefully selecting your options ...

then you may update the new fields from your old ones - see https://www.simplemachines.org/community/index.php?topic=558527.msg3959189#msg3959189

NOTE: this is a bash script for MySQL and may have to be modified. I just completed this exercise because people were abusing the old Join Reason and it was being overlooked.

This is just really a reference to give you ideas if you can be bothered ! I have now removed the mod but it certainly did it's job !
Title: Re: Join Reason
Post by: nancygraz on February 03, 2019, 11:23:18 AM
Hi,

This mod provides exactly the functionality I want with one exception - I would like to change the text: Reason for joining this forum: to be "How did you learn of us?"

What is the easiest way to achieve this?

TIA!
Nancy
Title: Re: Join Reason
Post by: vbgamer45 on February 03, 2019, 11:38:02 AM
Yes edit the text under themes/default/languages/Modifications.english.php
Title: Re: Join Reason
Post by: nancygraz on February 03, 2019, 11:44:10 AM
Quote from: vbgamer45 on February 03, 2019, 11:38:02 AM
Yes edit the text under themes/default/languages/Modifications.english.php

PERFECT!!!! Thank you so much - worked like a charm!!

Nancy
Title: Re: Join Reason
Post by: vbgamer45 on February 03, 2019, 11:55:49 AM
Glad to help
Title: Re: Join Reason
Post by: aegersz on July 13, 2021, 02:43:20 AM
Linux command to show both join reasons (from the mod and from the Advanced Profile fields):

echo "use smf209; select smf209_members.id_member, smf209_members.member_name, smf209_members.join_reason, smf209_themes.value FROM smf209_themes INNER JOIN smf209_members ON smf209_members.id_member=smf209_themes.id_member WHERE smf209_themes.variable='cust_joinre'\G;" | mysql | less
Title: Re: Join Reason
Post by: viking9 on August 27, 2021, 11:04:44 PM
Is it possible to increase the field size (e.g. 3 lines)? It is currently only one line of text.
We want them to add more information.
Title: Re: Join Reason
Post by: GL700Wing on August 27, 2021, 11:08:23 PM
Quote from: viking9 on August 27, 2021, 11:04:44 PMIs it possible to increase the field size (e.g. 3 lines)? It is currently only one line of text.
We want them to add more information.
See https://www.simplemachines.org/community/index.php?msg=4095669
Title: Re: Join Reason
Post by: joecool85 on March 25, 2022, 11:08:09 AM
Any chance this mod will be fixed for SMF 2.1.1?  This is the biggest things I miss from being on 2.0.19.  Thanks for everything, this mod helps keep back spam so much!
Title: Re: Join Reason
Post by: Diego Andrés on March 25, 2022, 11:39:54 AM
I believe you could accomplish the same using a profile field.
Title: Re: Join Reason
Post by: Arantor on March 25, 2022, 11:55:00 AM
As far as I remember, custom fields can't be shown on the admin member list for filtering out would-be spammers.

Not that it's a great solution, and strong Q&A continues to be the most effective solution for deterring spammers.
Title: Re: Join Reason
Post by: mickjav on March 25, 2022, 01:11:05 PM
Quote from: Arantor on March 25, 2022, 11:55:00 AMAs far as I remember, custom fields can't be shown on the admin member list for filtering out would-be spammers.

Not that it's a great solution, and strong Q&A continues to be the most effective solution for deterring spammers.

I Use A Required Custom Field "Reason For Joining" Along with A Non-Required Fav Artist Custom field, Since adding them my spam has dropped to nothing. ;D
Title: Re: Join Reason
Post by: vbgamer45 on March 26, 2022, 12:09:16 AM
Version 2.0
+Updated for SMF 2.1.x
Title: Re: Join Reason
Post by: joecool85 on March 26, 2022, 09:02:55 PM
Thanks, this works now!

Something I always do for modification though:

Changed /Themes/default/languages/Modifications.english.php line 4
              From: "Reason for joining this forum:"
              To: "Why would you like to join? (Please write a sentence):"

Changed /Themes/default/Register.template.php line 151
              From: <input type="text" name="join_reason" id="smf_join_reason" size="30" tabindex="', $context['tabindex']++, '" />
              To: <textarea name="join_reason" id="smf_join_reason" rows="4" cols="50" name="comment" form="registration"></textarea>
Title: Mod installs fully, but breaks with error message and states to be not installed
Post by: voom on June 10, 2022, 01:32:15 PM
I am pretty sure the problem was created by sth I did earlier, but that is not my point / question. It is more of a general knowledge question, since I probably would have to uninstall manually anyway.

I installed "Join Reason" mod today on 2.1.2 and it checked fine, then the installation process broke off with an error message (php error on white background). I went through every file and all mods are there. Also, the mod works fine, so no trouble in the db or so.

The only thing is, that the mod shows as not installed in the package manager. I suppose there is no way to set it to "installed"? Resp.: it would not make sense, since uninstalling it the proper way would not work anyway? Or, since everything worked out, could it uninstall the proper way?

One thing I can't find, though, is a setting to activate / deactivate the function. But after I went through the files, I figure, there isn't one. That would mean, though, that I would have to uninstall it to deactivate it.