Simple Machines Community Forum

General Community => Site Comments, Issues and Concerns => Topic started by: Yağız... on May 19, 2010, 03:05:24 PM

Title: No XML search for Mod and Theme Sites?
Post by: Yağız... on May 19, 2010, 03:05:24 PM
I wanted to make a new quick search function in ACP, but I saw that there is no XML search for Mod and Theme Sites.
Community: http://www.simplemachines.org/community/index.php?action=search2&xml
Docs: http://docs.simplemachines.org/index.php?action=search2&xml
Mods: http://custom.simplemachines.org/mods/index.php?action=search2&xml
Thems: http://custom.simplemachines.org/themes/index.php?action=search2&xml
Title: Re: No XML search for Mod and Theme Sites?
Post by: Arantor on May 19, 2010, 04:36:35 PM
Um, not sure I understand what the problem is?
Title: Re: No XML search for Mod and Theme Sites?
Post by: live627 on May 19, 2010, 04:58:22 PM
Each link is a standard SMF search link. Community is valid XML, but not Mod or Theme
Title: Re: No XML search for Mod and Theme Sites?
Post by: Arantor on May 19, 2010, 05:00:10 PM
Two things - firstly, & in the URL upsets SMF and secondly, throwing a call to action=search2 without any parameters, it's going to baulk.
Title: Re: No XML search for Mod and Theme Sites?
Post by: Yağız... on May 19, 2010, 05:08:34 PM
Quote from: Arantor on May 19, 2010, 05:00:10 PM
Two things - firstly, & in the URL upsets SMF and secondly, throwing a call to action=search2 without any parameters, it's going to baulk.
Sources/Admin.php line 984.
$search_results = fetch_web_data($context['doc_scripturl'] . '?action=search2&xml', $postVars);

That's why I did like that :) And if you go to the URLs that I gave, you'll see that Community and Docs have an XML search, while Mod and Theme Sites does not.
Title: Re: No XML search for Mod and Theme Sites?
Post by: Arantor on May 19, 2010, 05:11:59 PM
Then it's a bug cuz I'm pretty sure it's not supposed to be like that...


I am curious as to the necessity of searching the mod and theme sites from the ACP though... doubly so as undoubtedly the structure will change when Dime finishes the overhaul of the Cust sites.
Title: Re: No XML search for Mod and Theme Sites?
Post by: Yağız... on May 19, 2010, 05:13:12 PM
Hmm, ok then my ideas gotta wait a little :P
Title: Re: No XML search for Mod and Theme Sites?
Post by: SlammedDime on May 22, 2010, 09:30:13 PM
$search_results = fetch_web_data($context['doc_scripturl'] . '?action=search2&xml', $postVars);

It's posting to search2, which is how it should be...

Mod and theme site currently do not have this functionality.  There will be plenty of XML functionality in the new site.
Title: Re: No XML search for Mod and Theme Sites?
Post by: Yağız... on May 23, 2010, 05:47:21 AM
Quote from: SlammedDime on May 22, 2010, 09:30:13 PM
$search_results = fetch_web_data($context['doc_scripturl'] . '?action=search2&xml', $postVars);

It's posting to search2, which is how it should be...
That's not what Arantor was pointing to. It was the "&" between search2 and xml. Shouldn't it be ";"?

Quote from: SlammedDime on May 22, 2010, 09:30:13 PM
Mod and theme site currently do not have this functionality.  There will be plenty of XML functionality in the new site.
Ok, thanks again :)
Title: Re: No XML search for Mod and Theme Sites?
Post by: SlammedDime on May 23, 2010, 07:01:43 AM
SMF won't choke on &, it will still work just fine with it, rather than ;

example: http://www.simplemachines.org/community/index.php?type=rss&action=.xml
Title: Re: No XML search for Mod and Theme Sites?
Post by: Yağız... on May 23, 2010, 07:05:20 AM
Yeah I know, but SMF never uses "&" in URLs, shouldn't it be changed to ";"?