Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Matthew K. on September 14, 2010, 06:35:06 PM

Title: [4794] Search Personal Messages - Error margin is off.
Post by: Matthew K. on September 14, 2010, 06:35:06 PM
I was looking around on the latest dev release for Charter Members (DEV 20100913) and I found a margin issue.

Screenshot: http://prntscr.com/wj07

After reviewing other areas with similar messages, I noticed that they are above the catbg's, not below like this case.

I tested this in the latest versions of FireFox, as well as Google Chrome.
Title: Re: Search Personal Messages - Error margin is off.
Post by: Antechinus on September 14, 2010, 08:32:58 PM
K I'll take a look at it.
Title: Re: Search Personal Messages - Error margin is off.
Post by: Matthew K. on September 14, 2010, 08:35:52 PM
I'd love to resolve this...is this supposed to be above the catbg, following the rest of the messages like this one? Or is it just supposed to be bumped down?
Title: Re: Search Personal Messages - Error margin is off.
Post by: Antechinus on September 14, 2010, 08:40:56 PM
Should be in the same position as all other error messages IMO.
Title: Re: Search Personal Messages - Error margin is off.
Post by: Matthew K. on September 14, 2010, 08:48:47 PM
Not that my opinion counts for anything in a final decision, but I agree. :P
Title: Re: Search Personal Messages - Error margin is off.
Post by: Matthew K. on September 14, 2010, 09:02:03 PM
Here's the result: http://prntscr.com/wkj2

The correction.
./Themes/default/PersonalMessage.template.php
Code (Find) Select

<form action="', $scripturl, '?action=pm;sa=search2" method="post" accept-charset="', $context['character_set'], '" name="searchform" id="searchform">
<div class="cat_bar">
<h3 class="catbg">', $txt['pm_search_title'], '</h3>
</div>';

if (!empty($context['search_errors']))
{
echo '
<div class="errorbox">
', implode('<br />', $context['search_errors']['messages']), '
</div>';
}

Code (Should be) Select

<form action="', $scripturl, '?action=pm;sa=search2" method="post" accept-charset="', $context['character_set'], '" name="searchform" id="searchform">';

if (!empty($context['search_errors']))
{
echo '
<div class="errorbox">
', implode('<br />', $context['search_errors']['messages']), '
</div>';
}

echo '<div class="cat_bar">
<h3 class="catbg">', $txt['pm_search_title'], '</h3>
</div>';
Title: Re: Search Personal Messages - Error margin is off.
Post by: emanuele on July 06, 2011, 12:50:15 PM
This one was missed.

But... the error box for the normal search page has different colors but it is in the same position.
Which is correct? Which is wrong?
Title: Re: Search Personal Messages - Error margin is off.
Post by: Antechinus on July 06, 2011, 06:19:50 PM
They should be consistent on all pages IMO. Track it to Mantis and assign to to me.
Title: Re: Search Personal Messages - Error margin is off.
Post by: emanuele on July 07, 2011, 04:16:52 AM
Done.
http://dev.simplemachines.org/mantis/view.php?id=4794